[Koha-bugs] [Bug 32271] New: Overdue fines cap (amount) set to 0.00 when editing rule

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271

            Bug ID: 32271
           Summary: Overdue fines cap (amount) set to 0.00 when editing
                    rule
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

I noticed that when I add a circulation rule, if I leave the Overdue fines cap
(amount) field empty, it is displayed as 0.00. If I later edit this rule, the
Overdue fines cap (amount) field is *set to* 0.00, even if that's not what I
wanted. This causes the fines.pl script to charge no fine at all.

To test:

0. Preliminary settings
   0.1. finesMode system preference must be set to Calculate and charge
   0.2. MaxFine system preference must be empty
   0.3. In Tools > Calendar, today must not be a holiday

1. Add a circulation rule with fines but no fines cap
   1.1. Go to Administration > Circulation and fines rules
   1.2. Add or modify a circulation rule, make sure
        -  There is a quantity in "Current checkouts allowed"
        -  There is a number of days in "Loan period"
        -  There is an amount in "Fine amount"
        -  There is a number in "Fine charging interval" (usually 1)
        -  "Overdue fines cap (amount)" is **empty**
   1.3. Save the circulation rule
   --> Note that the amount in "Overdue fines cap (amount)" is displayed as
0.00

2. Checkout an item with a date in the past to create an overdue
   2.1. Find an item barcode
        2.1.1. Go to Item search
        2.2.2. Click Search
        2.2.3. Copy a barcode from the search results
   2.2. Go to a patron's file
        2.2.1. Go to Patrons
        2.2.2. Click on "Search"
        2.2.3. Click on a patron's name
   2.3. Click on the "Check out" tab on the left of the patron's file
   2.4. Click on the settings icon in the "Enter item barcode" field
   2.5. Pick a due date in the past
   2.6. Paste the item barcode in the field
   2.7. Click "Check out" or press Enter
   2.8. Click "Yes, check out"
   --> Patron should have an overdue

3. Run fines.pl
   3.1. In a terminal, run

   ./misc/cronjobs/fines.pl

4. Check that the patron has fines
   4.1. Go to the patron's file
   4.2. Click on the "Accounting" tab on the left
   --> Patron should have a fine (accruing)

5. Modify the circulation rule, change any field except "Overdue fines cap
(amount)" (let's say the quantity of current checkouts has gone up)
   5.1. Go to Administration > Circulation and fines rules
   5.2. Click "Edit" next to the rule created in step 1
   --> Note that the amount in "Overdue fines cap (amount)" is 0.00
   5.3. Change any setting except "Overdue fines cap (amount)", e.g. change
Current checkouts allowed to another number
   5.4. Click "Save"
   --> Note that the amount in "Overdue fines cap (amount)" is displayed as
0.00

6. Redo step 2

7. Redo step 3

8. Redo step 4
--> Note that the patron has no fine

If Overdue fines cap (amount) is empty, it should display as empty (or
"Unlimited"), and when we edit the rule, the field should still be empty and
save as empty.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.