[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com

--- Comment #22 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Hi all,
I'm curious to know the usefulness of having the fines.pl cron run during
library operation hours... If anyone can enlighten me on this, I would be very
grateful.

I was able to recreate the problem on master, and I created a detailed test
plan, if you're interested (see below). However, the patches don't apply on the
current master, so I was not able to test them.

Here is my detailed test plan (I know it's a lot but I figured that I already
wrote it, so might as well share it!)

0. Preliminary settings
   0.1. finesMode system preference must be set to Calculate and charge
   0.2. There must be a circulation rule that will charge fines (beware of bug
32271)
   0.3. In Tools > Calendar, today must not be a holiday

1. Make a lot of overdue checkouts - I used the batch checkout feature, but if
your system already has a lot of overdue checkouts, you can skip to step 2

   1.1. Enable batch checkouts
        1.1.1. Go to Administration > Global system preferences
        1.1.2. Search for BatchCheckouts
        1.1.3. Set BatchCheckouts to Allow
        1.1.4. Select all categories in BatchCheckoutsValidCategories 
        1.1.5. Click "Save all Circulation preferences"

   1.2. Get a list of barcodes
        1.2.1. Go to Reports
        1.2.2. Click "Create from SQL"
        1.2.3. Give the report a name
        1.2.4. For the SQL query, enter

               SELECT barcode FROM items WHERE onloan IS NULL LIMIT 60;

        1.2.5. Click "Save report"
        1.2.6. Click "Run report"
        1.2.7. Click "Download" > "Tab separated text"

   1.3. Go to a patron's file
        1.3.1. Go to Patrons
        1.3.2. Click on "Search"
        1.3.3. Click on a patron's name

   1.4. Do a batch checkout with a due date in the past
        1.4.1. Click on the "Batch check out" tab on the left
        1.4.2. In "Use a file", click "Choose file"
        1.4.3. Choose the file downloaded from the report
        1.4.4. In "Hard due date", choose a date in the past
        1.4.5. Click "Check out"
        1.4.6. Click "Checkout or renew"

2. Find the last issue in the database

   2.1. In the database (or in reports), type the following query

        SELECT issues.*, items.itype as itemtype, items.homebranch,
items.barcode, items.itemlost, items.replacementprice, items.biblionumber FROM
issues  LEFT JOIN items USING (itemnumber) WHERE date_due < NOW() \G;

   2.2. Copy the barcode from the last entry

3. Set up so that you can run fines.pl and check in the item at the same time
(or very close to the same time)

   3.1. In Koha, click the "Check in" option in the search bar at the top of
the page
   3.2. Paste the barcode in the search bar BUT DO NOT PRESS ENTER OR THE ARROW
RIGHT AWAY
   3.3. In a terminal, enter the fines.pl command

        ./misc/cronjobs/fines.pl


   3.4. Execute the command and immediately click on the arrow in the staff
interface to check in the item

4. Check the patron's fines

    4.1. Click on the patron's name in the check in screen
    4.2. Go to the Accounting tab on the left
    4.3. In the search box just above the table, paste in the returned item's
barcode

    --> There are two fines, one Fine (Accruing) and one Fine (Returned) for
the same item at the same time

-- 
You are receiving this mail because:
You are watching all bug changes.