[Koha-bugs] [Bug 32167] When adding an order from a a staged file without item fields we only add price if there is a vendor discount

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32167

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 144212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144212&action=edit
Bug 32167: [21.11.x] (bug 14860 follow-up) Populate price fields even if no
discount on vendor

On bug 14860 an 'else' was removed, assuming the price fields were set before
discount,
this was incorrect. This patch renames the variable and always set the price,
only discounting
ecost if a discount, but setting the values even if not

To test:
 0 - Have a vendor with a discount of 0% specified (no discount)
 1 - Export a record from your Koha
 2 - Stage the record for import and match on biblionumber
 3 - Add to a basket in acq from the staged file
 4 - Select the title, and set order price to $10 and do not fill the discount
field
 5 - Add the order - note $0 order line
 6 - Repeat with another vendor with a 10% discount and confirm that is correct
 7 - Apply patch
 8 - Repeat 2-4
 9 - Add the order and confirm $10 price
10 - Repeat with discounted vendor, confirm prices are set discounted correctly

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.