[Koha-bugs] [Bug 32357] New: Set borrower_message_preferences.days_in_advance default to NULL

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357

            Bug ID: 32357
           Summary: Set borrower_message_preferences.days_in_advance
                    default to NULL
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Database
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lari.taskula at hypernova.fi
        QA Contact: testopia at bugs.koha-community.org

days_in_advance currently defaults to 0, but it should default to NULL because
all but one entry in message_attribute has takes_days=1 making it the exception
and not the default.

Current column default 0 is already ignored by
C4::Members::Messaging::SetMessagingPreference, see
https://github.com/Koha-Community/Koha/blob/8c367775470fcecdda54e28270b05d92834cd33f/C4/Members/Messaging.pm#L134
, so we should also make NULL default at database level instead.

Blocking Bug 18595 (because without this change some tests there will fail
unless we replicate the misuse of default values)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.