[Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #5 from David Nind <david at davidnind.com> ---
Tests pass both before and after the patch is applied.

However, I don't think the databaseupdate updates existing installations. I had
to do a reset_all to replicate a new installation (using koha-testing-docker).

Not that I really know how all this should work!

Testing notes:
1. Access the database: koha-mysql kohadev
2. Show the current database configuration - the default before the patch is
applied for days_in_advance is 0. SQL query: show columns from
borrower_message_preferences;
3. Apply the patch.
4. Update the database (updatedatabase).
5. Repeat steps 1-2 - the default for days_in_advance should now be NULL.[1]
6. Tests should pass:
   . prove t/db_dependent/cronjobs/advance_notices_digest.t
   . prove t/db_dependent/Letters/TemplateToolkit.t
   . prove t/db_dependent/Koha/CurbsidePickups.t
   . prove t/db_dependent/Koha/Patrons.t
   . prove t/db_dependent/Patron/Messaging.t

[1] The updatedatabase command didn't update the existing installation, I had
to do a reset_all to get the database to update.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.