[Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON fields

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I am certainly missing the context here, but this feels like unnecessary
overhead.

You are basically adding a Koha::Object base class for JSON decode and encode
calls. That's all.
The exception is there only to raise a Koha exception, but having a JSON
exception is also fine. The MissingParameter exceptions are not needed either
IMO, you will get a perl error if you are calling the method with missing
mandatory parameter.

If we really need these methods, and that I am missing the root idea and
context of these patches, can you clarify why a base class instead of a regular
class?

-- 
You are receiving this mail because:
You are watching all bug changes.