From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:37:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:37:18 +0000 Subject: [Koha-bugs] [Bug 29434] In UNIMARC instances, the authority finder uses MARC21 relationship codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com --- Comment #12 from Lucas Gass --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:38:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:38:08 +0000 Subject: [Koha-bugs] [Bug 31183] Add Koha::Item::Transfers->filter_by_current In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #13 from Lucas Gass --- Enhancement will not be backported to 22.05.x series unless requested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:38:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:38:08 +0000 Subject: [Koha-bugs] [Bug 31328] Make Koha::Item->get_transfer* use Koha::Item::Transfers->filter_by_current In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31328 Bug 31328 depends on bug 31183, which changed state. Bug 31183 Summary: Add Koha::Item::Transfers->filter_by_current https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:38:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:38:58 +0000 Subject: [Koha-bugs] [Bug 30543] Decouple DumpSearchQueryTemplate from other template dump preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30543 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #5 from Lucas Gass --- Enhancement will not be backported to 22.05.x series unless requested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:39:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:39:47 +0000 Subject: [Koha-bugs] [Bug 10086] No way to go back to the basket on uncertain prices page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas at bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #16 from Lucas Gass --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:40:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:40:27 +0000 Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN too In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #23 from Lucas Gass --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:41:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:41:12 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #110 from Lucas Gass --- Clear enhancement, no backport to the 22.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:41:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:41:13 +0000 Subject: [Koha-bugs] [Bug 29948] Display author information for researches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29948 Bug 29948 depends on bug 29897, which changed state. Bug 29897 Summary: Display author identifiers for researchers https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:42:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:42:12 +0000 Subject: [Koha-bugs] [Bug 31306] Add Koha::Items->search_ordered method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31306 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #14 from Lucas Gass --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:42:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:42:12 +0000 Subject: [Koha-bugs] [Bug 31308] Remove GetItemsInfo from basket/basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31308 Bug 31308 depends on bug 31306, which changed state. Bug 31306 Summary: Add Koha::Items->search_ordered method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31306 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:42:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:42:13 +0000 Subject: [Koha-bugs] [Bug 31309] Remove GetItemsInfo from basket/sendbasket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31309 Bug 31309 depends on bug 31306, which changed state. Bug 31306 Summary: Add Koha::Items->search_ordered method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31306 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:42:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:42:13 +0000 Subject: [Koha-bugs] [Bug 31310] Remove GetItemsInfo from catalogue/imageviewer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31310 Bug 31310 depends on bug 31306, which changed state. Bug 31306 Summary: Add Koha::Items->search_ordered method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31306 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:42:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:42:13 +0000 Subject: [Koha-bugs] [Bug 31311] Remove GetItemsInfo from labels/label-item-search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31311 Bug 31311 depends on bug 31306, which changed state. Bug 31306 Summary: Add Koha::Items->search_ordered method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31306 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:42:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:42:13 +0000 Subject: [Koha-bugs] [Bug 31312] Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31312 Bug 31312 depends on bug 31306, which changed state. Bug 31306 Summary: Add Koha::Items->search_ordered method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31306 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:42:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:42:13 +0000 Subject: [Koha-bugs] [Bug 31313] Remove GetItemsInfo from opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 Bug 31313 depends on bug 31306, which changed state. Bug 31306 Summary: Add Koha::Items->search_ordered method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31306 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:42:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:42:14 +0000 Subject: [Koha-bugs] [Bug 31314] Remove GetItemsInfo from opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31314 Bug 31314 depends on bug 31306, which changed state. Bug 31306 Summary: Add Koha::Items->search_ordered method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31306 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:42:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:42:14 +0000 Subject: [Koha-bugs] [Bug 31315] Remove GetItemsInfo from moredetail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315 Bug 31315 depends on bug 31306, which changed state. Bug 31306 Summary: Add Koha::Items->search_ordered method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31306 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:42:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:42:14 +0000 Subject: [Koha-bugs] [Bug 31316] Remove GetItemsInfo from opac-sendbasket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31316 Bug 31316 depends on bug 31306, which changed state. Bug 31306 Summary: Add Koha::Items->search_ordered method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31306 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:42:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:42:14 +0000 Subject: [Koha-bugs] [Bug 31317] Remove GetItemsInfo from opac-tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31317 Bug 31317 depends on bug 31306, which changed state. Bug 31306 Summary: Add Koha::Items->search_ordered method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31306 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:42:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:42:15 +0000 Subject: [Koha-bugs] [Bug 31318] Remove GetItemsInfo from serials/routing-preview In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31318 Bug 31318 depends on bug 31306, which changed state. Bug 31306 Summary: Add Koha::Items->search_ordered method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31306 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:42:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:42:15 +0000 Subject: [Koha-bugs] [Bug 31319] Remove GetItemsInfo from tags/list.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31319 Bug 31319 depends on bug 31306, which changed state. Bug 31306 Summary: Add Koha::Items->search_ordered method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31306 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:42:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:42:15 +0000 Subject: [Koha-bugs] [Bug 31320] Remove GetItemsInfo from virtualshelves/sendshelf.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31320 Bug 31320 depends on bug 31306, which changed state. Bug 31306 Summary: Add Koha::Items->search_ordered method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31306 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:42:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:42:16 +0000 Subject: [Koha-bugs] [Bug 31321] Remove GetItemsInfo from catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31321 Bug 31321 depends on bug 31306, which changed state. Bug 31306 Summary: Add Koha::Items->search_ordered method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31306 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:42:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:42:41 +0000 Subject: [Koha-bugs] [Bug 31319] Remove GetItemsInfo from tags/list.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31319 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:42:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:42:41 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Bug 27272 depends on bug 31319, which changed state. Bug 31319 Summary: Remove GetItemsInfo from tags/list.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31319 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:43:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:43:10 +0000 Subject: [Koha-bugs] [Bug 31316] Remove GetItemsInfo from opac-sendbasket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31316 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:43:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:43:11 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Bug 27272 depends on bug 31316, which changed state. Bug 31316 Summary: Remove GetItemsInfo from opac-sendbasket https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31316 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:43:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:43:35 +0000 Subject: [Koha-bugs] [Bug 31311] Remove GetItemsInfo from labels/label-item-search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31311 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:43:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:43:35 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Bug 27272 depends on bug 31311, which changed state. Bug 31311 Summary: Remove GetItemsInfo from labels/label-item-search https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31311 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:45:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:45:49 +0000 Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #84 from Lucas Gass --- Do we need/want this is 22.05.x? I am skipping unless told otherwise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:46:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:46:09 +0000 Subject: [Koha-bugs] [Bug 31657] [DOCS] [Omnibus] Fix the cause of duplicate label warning messages when generating the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31657 --- Comment #8 from Katrin Fischer --- I believe between Caroline's and my merge requests we should have taken care of all of them now. I suggest we remove the autosectionlabel after these are merged and then fix anything that remains. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:49:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:49:16 +0000 Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if job not started In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | CC| |lucas at bywatersolutions.com --- Comment #18 from Lucas Gass --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:55:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:55:53 +0000 Subject: [Koha-bugs] [Bug 31346] On the OPAC detail page some Syndetics links are wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31346 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | --- Comment #7 from Lucas Gass --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 00:58:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 22:58:26 +0000 Subject: [Koha-bugs] [Bug 31281] Overdue notices reply-to email address of a branch not respected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #13 from Lucas Gass --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 01:01:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 23:01:09 +0000 Subject: [Koha-bugs] [Bug 31325] Fix koha-preferences get In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31325 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | --- Comment #6 from Lucas Gass --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 01:03:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 23:03:36 +0000 Subject: [Koha-bugs] [Bug 31276] Report results are limited to 999, 999 no matter the actual number of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31276 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | --- Comment #8 from Lucas Gass --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 01:05:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 23:05:05 +0000 Subject: [Koha-bugs] [Bug 31158] Can't filter suggestions by date ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31158 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass --- This shouldn't be needed in 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 01:05:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 23:05:52 +0000 Subject: [Koha-bugs] [Bug 31308] Remove GetItemsInfo from basket/basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31308 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 01:05:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 23:05:52 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Bug 27272 depends on bug 31308, which changed state. Bug 31308 Summary: Remove GetItemsInfo from basket/basket https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31308 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 01:11:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 23:11:42 +0000 Subject: [Koha-bugs] [Bug 31302] Spelling: You can download the scanned materials via the following url(s): In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31302 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | --- Comment #5 from Lucas Gass --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 01:12:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 23:12:41 +0000 Subject: [Koha-bugs] [Bug 31328] Make Koha::Item->get_transfer* use Koha::Item::Transfers->filter_by_current In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31328 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #7 from Lucas Gass --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 01:13:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 23:13:15 +0000 Subject: [Koha-bugs] [Bug 31309] Remove GetItemsInfo from basket/sendbasket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31309 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 01:13:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 23:13:15 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Bug 27272 depends on bug 31309, which changed state. Bug 31309 Summary: Remove GetItemsInfo from basket/sendbasket https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31309 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 01:14:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 23:14:30 +0000 Subject: [Koha-bugs] [Bug 31313] Remove GetItemsInfo from opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #28 from Lucas Gass --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 01:14:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 23:14:30 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Bug 29144 depends on bug 31313, which changed state. Bug 31313 Summary: Remove GetItemsInfo from opac-detail https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 01:14:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 23:14:30 +0000 Subject: [Koha-bugs] [Bug 31396] OPAC shelf browser broken after removal GetItemsInfo from opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31396 Bug 31396 depends on bug 31313, which changed state. Bug 31313 Summary: Remove GetItemsInfo from opac-detail https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 01:14:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 23:14:31 +0000 Subject: [Koha-bugs] [Bug 31463] (Bug 31313 follow-up) Show item order status on opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31463 Bug 31463 depends on bug 31313, which changed state. Bug 31313 Summary: Remove GetItemsInfo from opac-detail https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 01:14:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 23:14:31 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Bug 27272 depends on bug 31313, which changed state. Bug 31313 Summary: Remove GetItemsInfo from opac-detail https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 01:18:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 23:18:14 +0000 Subject: [Koha-bugs] [Bug 29723] Add a "Configure table" button for KohaTable tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting --- Comment #46 from Lucas Gass --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 06:33:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 04:33:33 +0000 Subject: [Koha-bugs] [Bug 31630] Batch item deletion no longer shows which items were not removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31630 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 06:36:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 04:36:09 +0000 Subject: [Koha-bugs] [Bug 31667] New: Merge 'tip' and 'hint' classes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Bug ID: 31667 Summary: Merge 'tip' and 'hint' classes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org 'tip' and 'hint' are classes for a CSS with grey color. Looks like 'hint' is way more used that 'tip' (mainly used for header search boxes). I think we should replace 'tip' with 'hint' to have only one class for this usage. And maybe add a coding guide line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 06:36:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 04:36:22 +0000 Subject: [Koha-bugs] [Bug 31338] Show in advanced search when IncludeSeeFromInSearches is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31338 --- Comment #19 from Fridolin Somers --- I created Bug 31667 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 06:41:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 04:41:40 +0000 Subject: [Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 --- Comment #1 from Fridolin Somers --- > git grep -e 'class="hint[ "]' -- koha-tmpl/ | wc -l 343 > git grep -e 'class="tip[ "]' -- koha-tmpl/ | wc -l 42 They may be few places where this class is not the first. But hint is clearly the boss ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 06:52:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 04:52:47 +0000 Subject: [Koha-bugs] [Bug 31338] Show in advanced search when IncludeSeeFromInSearches is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31338 --- Comment #20 from Fridolin Somers --- Created attachment 141177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141177&action=edit Screenshot of OPAC with patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 06:53:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 04:53:01 +0000 Subject: [Koha-bugs] [Bug 31338] Show in advanced search when IncludeSeeFromInSearches is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31338 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139009|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 06:53:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 04:53:22 +0000 Subject: [Koha-bugs] [Bug 31338] Show in advanced search when IncludeSeeFromInSearches is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31338 --- Comment #21 from Fridolin Somers --- I almost fergot to add also to OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 06:55:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 04:55:55 +0000 Subject: [Koha-bugs] [Bug 31338] Show in advanced search when IncludeSeeFromInSearches is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31338 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 06:56:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 04:56:00 +0000 Subject: [Koha-bugs] [Bug 31338] Show in advanced search when IncludeSeeFromInSearches is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31338 --- Comment #22 from Fridolin Somers --- Created attachment 141178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141178&action=edit Bug 31338: (follow-up) add special class and add also to OPAC In order to easily hide this new text, this patch adds the class "included-see-from-headings-info". Also uses
instead of

. And adds the same feature to OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 07:03:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 05:03:29 +0000 Subject: [Koha-bugs] [Bug 31150] _on or _date for DB date columns? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 --- Comment #11 from Fridolin Somers --- Ahhh sorry I had not understood there is an existing guide line : https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#SWAGGER1.3.4.1_date.2Fdatetime.2Ftimestamp_fields I'm OK to stick to it and apply the same on DB fields. Maybe keep the items.xxx_on as a legacy ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 09:53:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 07:53:45 +0000 Subject: [Koha-bugs] [Bug 31660] MARC preview for authority search results has hidden contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31660 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kevin.carnes at ub.lu.se |ity.org | --- Comment #3 from Katrin Fischer --- Hi Kevin, please add yourself as Assignee whenever you start working on a bug/plan to provide a patch. Thx! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 09:54:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 07:54:15 +0000 Subject: [Koha-bugs] [Bug 29071] HoldsSplitQueueNumbering not set for new installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29071 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | --- Comment #5 from Katrin Fischer --- Got ya, Nick! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 09:54:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 07:54:58 +0000 Subject: [Koha-bugs] [Bug 22666] When using authority records in a bibliographic record, the order of the subfields is not sent over In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22666 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |marion.durand.lelion at gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 09:56:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 07:56:43 +0000 Subject: [Koha-bugs] [Bug 31646] Focus input by default when clicking on a dropdown field in the cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31646 --- Comment #5 from Katrin Fischer --- Hi Lucas, please don't forget to set Assignee, thx! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 09:57:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 07:57:07 +0000 Subject: [Koha-bugs] [Bug 31640] Fuzzy translations of preferences can cause missing sections and inaccurate translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.05 |master Assignee|koha-bugs at lists.koha-commun |kevin.carnes at ub.lu.se |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 09:57:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 07:57:41 +0000 Subject: [Koha-bugs] [Bug 31627] Add ability to embed the letter ID in outgoing email notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Summary|Add ability to embed the |Add ability to embed the |letter id in outgoing email |letter ID in outgoing email |notices |notices --- Comment #6 from Katrin Fischer --- Please don't forget to set Assignee, thx! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 09:58:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 07:58:08 +0000 Subject: [Koha-bugs] [Bug 31286] Embed see-from headings into bibliographic records export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31286 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m --- Comment #2 from Katrin Fischer --- Please don't forget to set Assignee :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 09:58:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 07:58:24 +0000 Subject: [Koha-bugs] [Bug 31216] inventory.pl is slow when comparing many barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31216 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 09:58:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 07:58:38 +0000 Subject: [Koha-bugs] [Bug 30860] Add option for CanBookBeReserved to return all item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30860 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 09:59:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 07:59:12 +0000 Subject: [Koha-bugs] [Bug 30255] Allow skipping "list" step for record batch modification/deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com |ity.org | --- Comment #2 from Katrin Fischer --- Hi David, please set yourself as Assignee, when you start working on a patch for a bug, thx! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 09:59:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 07:59:35 +0000 Subject: [Koha-bugs] [Bug 29811] misc/export_records.pl add possibility to export with timestamp option on authority record type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29811 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |thibaud.guillot at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 09:59:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 07:59:58 +0000 Subject: [Koha-bugs] [Bug 29694] Add preference for setting marc-record system control number and identifier when saving biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29694 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 10:00:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 08:00:18 +0000 Subject: [Koha-bugs] [Bug 29597] Add tomarcplugin option to bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29597 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 10:00:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 08:00:44 +0000 Subject: [Koha-bugs] [Bug 29507] Speed up auto renew cronjob via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29507 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 10:01:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 08:01:07 +0000 Subject: [Koha-bugs] [Bug 28672] Improve EDI debug logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28672 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 10:02:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 08:02:38 +0000 Subject: [Koha-bugs] [Bug 28457] cleanup_database.pl self-registration options are not configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28457 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | --- Comment #5 from Katrin Fischer --- Please don't forget to set assignee, thx! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 10:03:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 08:03:14 +0000 Subject: [Koha-bugs] [Bug 28203] Add Match-heading search field and UNIMARC mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28203 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | --- Comment #5 from Katrin Fischer --- Please don't forget to fill in Assignee, thx! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 10:03:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 08:03:28 +0000 Subject: [Koha-bugs] [Bug 28011] Add CLI script to update bibs from linked authority records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28011 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 10:03:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 08:03:45 +0000 Subject: [Koha-bugs] [Bug 27291] Change datetime format in Zebra logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27291 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 10:04:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 08:04:10 +0000 Subject: [Koha-bugs] [Bug 26657] "Unlinked" output of LinkBibHeadingsToAuthorities is ambiguous In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26657 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 10:04:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 08:04:23 +0000 Subject: [Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |thibaud.guillot at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 10:05:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 08:05:54 +0000 Subject: [Koha-bugs] [Bug 31646] Focus input by default when clicking on a dropdown field in the cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31646 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 10:09:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 08:09:45 +0000 Subject: [Koha-bugs] [Bug 30981] Add option to configure preferred pronouns as a pull down In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30981 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.11 |master --- Comment #1 from Katrin Fischer --- Now that bug 10950 has passed, it would be great if we could also have this, so people starting with using the new pronouns field have both options (free text and normalized) from the beginning! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 10:11:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 08:11:37 +0000 Subject: [Koha-bugs] [Bug 10984] Cannot cancel received order if the parent order is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10984 --- Comment #4 from Katrin Fischer --- (In reply to Daniel Gaghan from comment #3) > Is this the error that accompanies this issue? "The order line you are > trying to cancel was created from a partial receipt of another order line > which has been deleted. Cancellation is not possible." > > If so it's still hanging around. Are there any ideas on a solution for this? At the moment you can only clean the data via SQL - there is a couple of bugs revolving around deleted records in acq. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 10:14:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 08:14:19 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #43 from Katrin Fischer --- (In reply to Julian Maurice from comment #42) > Oh... ok then I'll check what's wrong :) > Thanks Thanks :) Would be great to get this into 22.11! I was wondering, could the problem stem from the itemtypes being not a 'real' AV? You set it up like one, but it's actually drawn from the itemtypes table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 10:35:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 08:35:48 +0000 Subject: [Koha-bugs] [Bug 31665] 952$d ( Date acquired ) no longer prefills with todays date when focused In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 16:00:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 14:00:14 +0000 Subject: [Koha-bugs] [Bug 29071] HoldsSplitQueueNumbering not set for new installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29071 --- Comment #6 from Nick Clemens --- (In reply to Katrin Fischer from comment #5) > Got ya, Nick! Hah, this one was old! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 21:19:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 19:19:21 +0000 Subject: [Koha-bugs] [Bug 31603] Add search option for plugin page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31603 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 21:19:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 19:19:26 +0000 Subject: [Koha-bugs] [Bug 31603] Add search option for plugin page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31603 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140851|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 141179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141179&action=edit Bug 31603: Add search option for plugin page This patch converts the table of plugins to a DataTable so that it will have dynamic sorting, export options, and the quick search field at the top of the table. To test you should have more than one plugin installed. - Apply the patch and go to Administration -> Manage plugins. - The table should be styled as a DataTable, with the first column sorted by default. - At the top of the table you should see the number of entries, a quick search form, and an export button. - Confirm that the quick search form works to filter plugins by name, description, author, etc. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 21:20:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 19:20:07 +0000 Subject: [Koha-bugs] [Bug 31603] Add search option for plugin page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31603 --- Comment #6 from Katrin Fischer --- Love this, small change, great effect :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 21:23:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 19:23:21 +0000 Subject: [Koha-bugs] [Bug 31559] Staff results page doesn't always use up full available screen width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31559 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 21:23:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 19:23:25 +0000 Subject: [Koha-bugs] [Bug 31559] Staff results page doesn't always use up full available screen width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31559 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141011|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 141180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141180&action=edit Bug 31559: Staff results page doesn't always use up full available screen width This patch adds an explicit "width: 100%" to tables which are contained within a #searchresults

. The change affects staff interface catalog search results and these other pages with the same markup: - Advanced MARC editor search results - Holds to pull - Patron search results To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - Test the catalog search results and other affected pages to confirm that the tables affected take up the full width of the page. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 21:29:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 19:29:28 +0000 Subject: [Koha-bugs] [Bug 30304] Reindent lists template in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 --- Comment #5 from Katrin Fischer --- Created attachment 141181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141181&action=edit k -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 21:30:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 19:30:25 +0000 Subject: [Koha-bugs] [Bug 30304] Reindent lists template in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141181|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 21:30:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 19:30:56 +0000 Subject: [Koha-bugs] [Bug 30304] Reindent lists template in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 --- Comment #6 from Katrin Fischer --- I didn't realize that I had already signed off... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 21:37:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 19:37:49 +0000 Subject: [Koha-bugs] [Bug 31528] Replace scss-lint configuration with one for stylelint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 21:37:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 19:37:55 +0000 Subject: [Koha-bugs] [Bug 31528] Replace scss-lint configuration with one for stylelint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140500|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 141182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141182&action=edit Bug 31528: Replace scss-lint configuration with one for stylelint This patch removes the SCSS linting configuration .scss-lint.yml which was intended to be used with a now-obsolete tool, scss-lint. It is replaced with .stylelintrc.json, for use with stylelint. I've tried to keep the linting rules the same as before. To test, run 'yarn install' to install the new dependencies. You can test stylelint from the command line like so: npx stylelint koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss It should output a list of problems with the file: koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss 30:27 ✖ Expected "#e6f0f2" to be "#E6F0F2" color-hex-case 81:31 ✖ Expected single space after "(" function-parentheses-space-inside ...etc. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 21:37:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 19:37:59 +0000 Subject: [Koha-bugs] [Bug 31528] Replace scss-lint configuration with one for stylelint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140501|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 141183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141183&action=edit Bug 31528: (follow-up) A few additional rules Adding a few more rules which came up during the correction process in the follow-up bug. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 21:49:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 19:49:47 +0000 Subject: [Koha-bugs] [Bug 31529] Fix errors in SCSS files raised by stylelint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31529 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 21:49:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 19:49:51 +0000 Subject: [Koha-bugs] [Bug 31529] Fix errors in SCSS files raised by stylelint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31529 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140504|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 141184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141184&action=edit Bug 31529: [OPAC] Fix errors in SCSS files raised by stylelint This patch corrects errors raised by the new stylelint configuration in OPAC SCSS files. Many of the fixes were made automatically by using the "--fix" option: npx stylelint koha-tmpl/opac-tmpl/bootstrap/css/src/*.scss --fix Some examples of errors found: - Unexpected empty line before $-variable - Expected single space after ":" - Expected "#fff" to be "#FFF" - Expected modern color-function notation - Expected single space after "(" - Expected single space before ")" - Expected empty line before comment - Expected no more than 1 empty line - Expected a trailing semicolon - Expected color.adjust($color, $lightness: -$amount) instead of darken($color, $amount) - Unexpected leading zero - Expected single space after "," in a single-line function - Expected double colon pseudo-element notation Manual fixes include replacing named colors with hex codes, combining duplicate selectors, removing empty blocks, etc. Some warnings remain: "Unexpected !important" and "Expected a placeholder selector (e.g. %placeholder) to be used in @extend" which both require more than a quick fix, if we should choose to address them. To test, apply the patch and rebuild the OPAC SCSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client Browse around the OPAC to confirm that there are no visible changes to style. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 21:54:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 19:54:59 +0000 Subject: [Koha-bugs] [Bug 31625] Reindent tools home and tools sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 21:55:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 19:55:04 +0000 Subject: [Koha-bugs] [Bug 31625] Reindent tools home and tools sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141002|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 141185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141185&action=edit Bug 31625: Reindent tools home and tools sidebar This patch performs general template cleanup to the tools-home and tools-menu templates: Make indentation consistent, replace tabs with spaces, fix invalid HTML. To test, apply the patch and go to Tools. The page should look correct, with no visible changes from before the patch. Go to any tools page which shows the left-hand sidebar, e.g. Patron lists, Batch item deletion, Inventory, etc. The menu should look correct. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 21:55:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 19:55:09 +0000 Subject: [Koha-bugs] [Bug 31625] Reindent tools home and tools sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141003|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 141186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141186&action=edit Bug 31625: (follow-up) Markup comments This patch adds comments to the templates to highlight the markup structure. This patch should have no effect on the pages' appearance or functionality. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 21:56:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 19:56:15 +0000 Subject: [Koha-bugs] [Bug 31625] Reindent tools home and tools sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Katrin Fischer --- (In reply to Katrin Fischer from comment #5) > Hm, I wonder if this does not clash with bug 31162 and if we should push one or > the other first? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 21:56:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 19:56:46 +0000 Subject: [Koha-bugs] [Bug 31402] Update tools sidebar to match tools start page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 22:08:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 20:08:30 +0000 Subject: [Koha-bugs] [Bug 31402] Update tools sidebar to match tools start page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 22:08:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 20:08:35 +0000 Subject: [Koha-bugs] [Bug 31402] Update tools sidebar to match tools start page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140995|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 141187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141187&action=edit Bug 31402: Update tools sidebar to match tools start page This patch updates the tools sidebar so that it better matches the tools home page: - Sidebar menu should say Tags instead of Tag moderation - Barcode image generator and Quick spine label creator links reversed. - Upload any file -> Uploads - Cash management section is added to sidebar using brief text This patch does not make changes to the way plugins are displayed in the sidebar. In order for the sidebar to correctly display according to the presence of tool plugins I think some kind of global variable would need to be set. Signed-off-by: Anke Bruns Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 22:26:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 20:26:54 +0000 Subject: [Koha-bugs] [Bug 31633] Add home and holding data attributes to quick spine label print to help customizing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Summary|Allow selection of branch |Add home and holding data |to be applied in quick |attributes to quick spine |spine label CSS class |label print to help | |customizing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 22:28:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 20:28:33 +0000 Subject: [Koha-bugs] [Bug 31633] Add home and holding data attributes to quick spine label print to help customizing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 22:28:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 20:28:38 +0000 Subject: [Koha-bugs] [Bug 31633] Add home and holding data attributes to quick spine label print to help customizing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141037|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 141188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141188&action=edit Bug 31633: Add holding and home data attributes to spinelabel-print.tt To test: 1. Apply patch 2. Have some items with call numbers and different holding/home branches. 3. Generate some quick spine labels and use your browsers dev tools to inscept the #spinelabel element. It should have 2 new data-attributes, data-homebranch and data-holdingbranch 4. You can then apply this CSS via IntraNnetUserCSS to make sure you can select these properly now: background: red; } Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 22:32:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 20:32:09 +0000 Subject: [Koha-bugs] [Bug 31633] Add home and holding data attributes to quick spine label print to help customizing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141188|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 141189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141189&action=edit Bug 31633: Add holding and home data attributes to spinelabel-print.tt To test: 1. Apply patch 2. Have some items with call numbers and different holding/home branches. 3. Generate some quick spine labels and use your browsers dev tools to inscept the #spinelabel element. It should have 2 new data-attributes, data-homebranch and data-holdingbranch 4. You can then apply this CSS via IntraNnetUserCSS to make sure you can select these properly now: background: red; } Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 22:35:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 20:35:05 +0000 Subject: [Koha-bugs] [Bug 31633] Add home and holding data attributes to quick spine label print to help customizing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141189|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 141190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141190&action=edit Bug 31633: Add holding and home data attributes to spinelabel-print.tt To test: 1. Apply patch 2. Have some items with call numbers and different holding/home branches. 3. Generate some quick spine labels and use your browsers dev tools to inscept the #spinelabel element. It should have 2 new data-attributes, data-homebranch and data-holdingbranch 4. You can then apply this CSS via IntraNnetUserCSS to make sure you can select these properly now: background: red; } Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 22:35:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 20:35:10 +0000 Subject: [Koha-bugs] [Bug 31633] Add home and holding data attributes to quick spine label print to help customizing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 --- Comment #11 from Katrin Fischer --- Created attachment 141191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141191&action=edit Bug 31633: (QA follow-up) Add data-attribute for logged-in library The class has some advantages, but I thought it would be nice to also have the complete set of options in data-attributes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 22:41:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 20:41:09 +0000 Subject: [Koha-bugs] [Bug 31553] News item contents field does not always expand when you click on a non-default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31553 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 22:41:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 20:41:13 +0000 Subject: [Koha-bugs] [Bug 31553] News item contents field does not always expand when you click on a non-default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31553 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140608|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 141192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141192&action=edit Bug 31553: Ensure news item content field is always editable Set a padding at the bottom of the news item editor body. This is a tricky bug to replicate. Test plan: 1. Set 'AdditionalContentsEditor' syspref = 'a WYSIWYG editor (TinyMCE)'. 2. Select multiple languages in the 'OPACLanguages' system preference. 3. Go to: Tools > News. 4. Create a new news item. Switch between the different language tabs. 5. Confirm you can always input into the content field in all languages. 6. Edit an exiting news item. Switch between different language tabs. 7. Confirm you can always input into the content field in all languages. Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 22:44:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 20:44:02 +0000 Subject: [Koha-bugs] [Bug 31412] Set focus for cursor to Name when adding a new SMTP server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31412 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 22:44:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 20:44:06 +0000 Subject: [Koha-bugs] [Bug 31412] Set focus for cursor to Name when adding a new SMTP server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31412 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140485|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 141193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141193&action=edit Bug 31412: Add focus to 'name' on SMTP Servers This patch adds the focus class to ensure focus is given to the first form element on the SMTP server entry page. Signed-off-by: Joonas Kylmälä Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 23:44:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 21:44:46 +0000 Subject: [Koha-bugs] [Bug 29071] HoldsSplitQueueNumbering not set for new installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29071 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 23:44:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 21:44:50 +0000 Subject: [Koha-bugs] [Bug 29071] HoldsSplitQueueNumbering not set for new installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29071 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129808|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 141194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141194&action=edit Bug 29071: Add HoldsSplitQueueNumbering to installer data Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 23:44:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 21:44:55 +0000 Subject: [Koha-bugs] [Bug 29071] HoldsSplitQueueNumbering not set for new installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29071 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140834|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 141195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141195&action=edit Bug 29071: Add HoldsQueueSplitNumbering syspref for any libraries that may not have it Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 23:44:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 21:44:59 +0000 Subject: [Koha-bugs] [Bug 29071] HoldsSplitQueueNumbering not set for new installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29071 --- Comment #9 from Katrin Fischer --- Created attachment 141196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141196&action=edit Bug 29071: (QA follow-up) Fix typo acual in syspref description Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 00:03:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 22:03:48 +0000 Subject: [Koha-bugs] [Bug 18556] Message "Patron's address in doubt" is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- I like the change in wording, but I am in doubt about removing the circ-hlt class as it appears in the CSS and in other messages shown in the patron account, so it's something they have in common right now. Maybe we should keep it? And something odd with and without the patch: If you go to a patron account and set both flags, only the first has the list > in the beginning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 00:06:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 22:06:21 +0000 Subject: [Koha-bugs] [Bug 26368] Add support for OCLC Encoding level values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26368 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 00:19:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 22:19:36 +0000 Subject: [Koha-bugs] [Bug 26368] Add support for OCLC Encoding level values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26368 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 00:19:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 22:19:41 +0000 Subject: [Koha-bugs] [Bug 26368] Add support for OCLC Encoding level values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26368 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140837|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 141197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141197&action=edit Bug 26368: Add OCLC options to marc21_leader.tt See documentation at: https://www.oclc.org/bibformats/en/fixedfield/elvl.html To test: 1 - Apply patch, updatedatabase 2 - Edit a record in the basic editor 3 - Edit the leader using the plugin 4 - Note the options for '17 - Encoding level' 5 - Find the system preference 'UseOCLCEncodingLevels' 6 - Edit the record again 7 - Note new options I,J,K,M 8 - Set the value of encodign level to one of the new options and save 9 - Edit again 10 - Confirm the value is displayed correctly selected 11 - Repeat tests using advanced cataloging editor Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 00:19:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 22:19:45 +0000 Subject: [Koha-bugs] [Bug 26368] Add support for OCLC Encoding level values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26368 --- Comment #9 from Katrin Fischer --- Created attachment 141198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141198&action=edit Bug 26368: Rephase system preference to sentence style The preference was using a yes/no instead of the more common display/don't display. This patch switches it to the latter and adds a note about position 17. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 00:19:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 22:19:50 +0000 Subject: [Koha-bugs] [Bug 26368] Add support for OCLC Encoding level values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26368 --- Comment #10 from Katrin Fischer --- Created attachment 141199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141199&action=edit Bug 26368: (QA follow-up) Standardize spaces in option descriptions Most options are labelles as x- description, but a few had additional spaces. This just makes sure they all look the same. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 01:05:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 23:05:06 +0000 Subject: [Koha-bugs] [Bug 31643] Link authorities automatically requires ALL cataloging and authorities permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31643 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 01:05:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 23:05:11 +0000 Subject: [Koha-bugs] [Bug 31643] Link authorities automatically requires ALL cataloging and authorities permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31643 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141170|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 141200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141200&action=edit Bug 31643: Require only edit_catalogue, not full cataloging To test: 1 - Grant a patron: catalogue, edit_catalogue, and editauthorities permissions 2 - Log in to staff client 3 - Browse to: http://localhost:8081/cgi-bin/koha/svc/cataloguing/automatic_linker.pl 4 - UNAUTHORIZED 5 - Apply patch, restart all 6 - Log in and go to link again 7 - status "OK" Signed-off-by: Catrina Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 01:05:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 23:05:31 +0000 Subject: [Koha-bugs] [Bug 31643] Link authorities automatically requires ALL cataloging and authorities permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31643 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.11 |master QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 01:11:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 23:11:52 +0000 Subject: [Koha-bugs] [Bug 29389] Add holding branch to holds queue report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29389 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 01:11:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2022 23:11:56 +0000 Subject: [Koha-bugs] [Bug 29389] Add holding branch to holds queue report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29389 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140835|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 141201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141201&action=edit Bug 29389: Add holding branch to the holds queue report This patch adds the holding branch to the hold queue report. It is added as hidden by default, when running per branch it is not needed To test: 1 - Place some holds in your system 2 - perl misc/cronjobs/holds/build_holdsqueue.pl 3 - View the holds queue 4 - Note there is no 'Current library' column 5 - Apply patch 6 - Reload 7 - Note the column is not there 8 - Click column setting gear 9 - Check the column and confirm it appears 10 - Confirm the filter works Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 11:15:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 09:15:05 +0000 Subject: [Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 11:15:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 09:15:10 +0000 Subject: [Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140193|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer --- Created attachment 141202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141202&action=edit Bug 30517: Translation breaks editing parent type circulation rule fix Test plan: 1. Install another language in the staff interface 1. in commandline: `cd misc/translator/; ./translate install xx-XX` 2. Check the box of the language in the 'language' system preference and save 3. Refresh and you should be able to choose languages 2. Create an item type with a parent 1. Go to Administration > Item types 2. Create a new item type or modify an existing one, assigning a parent type (I created a 'Children's books' type and assigned 'Books' as its parent) 3. Create a circulation rule for the parent type (I created All/Books, with 10 checkouts allowed) 4. Create a circulation rule for All/All (I created All/All with 30 checkouts allowed) 5. In English, click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row (the modifiable row) is changed to 'Books (All)' 6. Modify the number of checkouts allowed (e.g. 99) --> The All/Books rule is modified 7. Switch the interface to the other language 8. Click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row stays on 'All' 9. Modify the number of checkouts allowed (e.g. 88) --> The All/All rule is modified 10. Apply the patch, translate again and refresh the page 11. Do step 8-9 again and notice it now behaves as it should Signed-off-by: Emmanuel Bétemps Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 11:18:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 09:18:28 +0000 Subject: [Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #20 from Katrin Fischer --- Overall I am not super happy about the way we rely on a regex here, but have not managed to break behavior in my tests. So this fix works and that's the most important as this bug has been there for too long causing potential data loss. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 11:19:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 09:19:49 +0000 Subject: [Koha-bugs] [Bug 31594] Report results count of shown can be incorrect on last page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31594 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 11:22:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 09:22:31 +0000 Subject: [Koha-bugs] [Bug 31594] Report results count of shown can be incorrect on last page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31594 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 11:22:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 09:22:35 +0000 Subject: [Koha-bugs] [Bug 31594] Report results count of shown can be incorrect on last page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31594 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140827|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 141203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141203&action=edit Bug 31594: Use ount of results for displaying number shown To test: 1 - Create a report with a number of results that is not a multiple of 20 SELECT barcode FROM items 2 - Run the report 3 - Go to the final page 4 - Note report says 20 shown, but there are less 5 - Apply patch 6 - Reload and confirm correct number of shown is shown :-) Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 11:22:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 09:22:50 +0000 Subject: [Koha-bugs] [Bug 31594] Report results count of shown can be incorrect on last page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31594 --- Comment #4 from Katrin Fischer --- Small logical fix, nice enhancement - love :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 11:25:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 09:25:33 +0000 Subject: [Koha-bugs] [Bug 31593] Remove Test::DBIx::Class from Context.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31593 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 11:25:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 09:25:37 +0000 Subject: [Koha-bugs] [Bug 31593] Remove Test::DBIx::Class from Context.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31593 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140818|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 141204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141204&action=edit Bug 31593: Remove Test::DBIx::Class from Context.t No need to keep it. Fixing a test description too. Test plan: Run t/db_dependent/Context.t Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 11:29:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 09:29:12 +0000 Subject: [Koha-bugs] [Bug 31663] Item not showing transit status on catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31663 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 11:29:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 09:29:16 +0000 Subject: [Koha-bugs] [Bug 31663] Item not showing transit status on catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31663 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141132|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 141205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141205&action=edit Bug 31663: Item transfers are not correctly displayed on item details page To test: 1 - Set an item in transit and confirm the transfer 2 - View details page for biblio 3 - Item shows 'Available' 4 - Apply patch 5 - Restart_all, reload page 6 - Item appears in transit Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 11:29:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 09:29:37 +0000 Subject: [Koha-bugs] [Bug 31663] Item not showing transit status on detail page in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31663 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Summary|Item not showing transit |Item not showing transit |status on |status on detail page in |catalogue/detail.pl |staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 11:56:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 09:56:17 +0000 Subject: [Koha-bugs] [Bug 25503] Add option to export items bundle contents in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 11:56:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 09:56:22 +0000 Subject: [Koha-bugs] [Bug 25503] Add option to export items bundle contents in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140956|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 141206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141206&action=edit Bug 25503: Add option to export items bundle contents in checkouts table Test plan: 1. Enable system preference ExportCircHistory 2. Create an item bundle (see bug 28854 comment 458) 3. Check out the item bundle 4. In the checkouts table, check the box in column "Export", choose export format 'MARC with items', check "Export items bundle contents" and click on "Export" button The exported file should contain the biblio and item created at step 2, but also the biblio and items that are part of the bundle Signed-off-by: Marie-Luce Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 11:57:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 09:57:20 +0000 Subject: [Koha-bugs] [Bug 25503] Add option to export items bundle contents in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #11 from Katrin Fischer --- This works nicely. Maybe the UI could improved a little bit to separate the options visually a little better, but not a blocker here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 11:59:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 09:59:41 +0000 Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #508 from Katrin Fischer --- I notice a lot of nice additions to this are hiding in the 'Blocks' list here! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 12:13:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 10:13:13 +0000 Subject: [Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 12:51:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 10:51:46 +0000 Subject: [Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 --- Comment #8 from Katrin Fischer --- Ok, took a while to work through this, but now I think I got it: * Bug 30924 added RecallCancellation to the branchtransfers.reason, but now we are also adding it to cancellation_reason. Makes sense. * The changes to the ilsdi files are not correct. The listings refer to the service defined in the ILS-DI documentation. It is called CancelRecall and should remain like that. See: https://old.diglib.org/architectures/ilsdi/DLF_ILS_Discovery_1.0.pdf. I am providing a follow-up for this. * I've run through the test plan without the change and didn't manage to create an entry to branchtransfers with CancelRecall so no more clean-up should be needed (it looked like the entries were not created properly at all) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 12:52:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 10:52:47 +0000 Subject: [Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 12:52:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 10:52:52 +0000 Subject: [Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140411|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 141207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141207&action=edit Bug 30944: Fix cancel recalls actions This patch fixes the 'cancel selected recalls' button on the biblio details Recalls page, and ensures a correct cancellation reason is logged when cancelling a recall in transit. To test: 1) Ensure UseRecalls is enabled and relevant recalls circulation rules are set 2) Check out Item A to Patron B 3) Log into OPAC as Patron A 4) Search for Item A and place a recall 5) Go back to the staff interface and search for Item A. When viewing the biblio record, go to the recalls tab. 6) Check the checkbox for your recall, and click the button to cancel selected recalls. 7) Confirm your recall is successfully removed and you're redirected to the correct recalls page for this biblio. 8) Go back to the OPAC and place a recall again. This time set the pickup location to a different library, one that you're not logged in at 9) Back in the staff interface, check in Item A and confirm the recall and transfer 10) Go to Circulation -> Recalls to pull. Your recall should show here. Click the button to cancel the recall and revert the transfer 11) Confirm the recall has been cancelled 12) Go to Reports and create a new SQL report with the following SQL: select * from branchtransfers b join items i on b.itemnumber=i.itemnumber where i.barcode = <> 13) Run the report and paste the barcode of Item A in the field 14) Confirm there are two rows returned - the transfer triggered when the recall was confirmed, with a reason of 'Recall' and a cancellation reason of 'RecallCancellation, and the transfer sending the item back home when the recall was cancelled, with a reason of 'RecallCancellation'. Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 12:52:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 10:52:56 +0000 Subject: [Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 --- Comment #10 from Katrin Fischer --- Created attachment 141208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141208&action=edit Bug 30944: Undo change to ILS-DI documentation The service not implemented by Koha is CancelRecall as specified in: https://old.diglib.org/architectures/ilsdi/DLF_ILS_Discovery_1.0.pdf Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 12:55:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 10:55:33 +0000 Subject: [Koha-bugs] [Bug 30944] Fix single cancel recall button in recalls tab in staff interface and correctly handle cancellations with branch transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Recalls - action buttons to |Fix single cancel recall |cancel recall on various |button in recalls tab in |pages do not work |staff interface and | |correctly handle | |cancellations with branch | |transfers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 12:58:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 10:58:00 +0000 Subject: [Koha-bugs] [Bug 31660] MARC preview for authority search results has hidden contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31660 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.05 |master QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 13:00:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 11:00:07 +0000 Subject: [Koha-bugs] [Bug 31660] MARC preview for authority search results has hidden contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31660 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 13:00:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 11:00:12 +0000 Subject: [Koha-bugs] [Bug 31660] MARC preview for authority search results has hidden contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31660 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141127|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 141209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141209&action=edit Bug 31660: MARC preview for authority search results has hidden contents This patch makes the contents of the MARC preview for authority search results visible. To test: 1) Go to the Authorities page in the staff interface 2) Click Submit to do a search 3) Click on Actions to the right of an authority 4) Select MARC preview 5) Observe that the modal appears empty 6) Apply patch 7) Hold down the shift key when you reload the page, clear the cache, or use another web browser 8) Do another authority search and look at a MARC preview 9) Observe that the MARC preview contains the MARC record Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 13:00:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 11:00:30 +0000 Subject: [Koha-bugs] [Bug 31660] MARC preview for authority search results comes up empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31660 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|MARC preview for authority |MARC preview for authority |search results has hidden |search results comes up |contents |empty --- Comment #5 from Katrin Fischer --- Nice catch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 13:01:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 11:01:31 +0000 Subject: [Koha-bugs] [Bug 30966] Record Overlay Rules - can't use Z39.50 filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 13:02:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 11:02:25 +0000 Subject: [Koha-bugs] [Bug 30966] Record overlay rules - can't use Z39.50 filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Record Overlay Rules - |Record overlay rules - |can't use Z39.50 filter |can't use Z39.50 filter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 13:25:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 11:25:49 +0000 Subject: [Koha-bugs] [Bug 30966] Record overlay rules - can't use Z39.50 filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer --- It looks like the * (all) case might not be covered properly yet: My overlay rules: * source * 245 Protect Skip... * source Z39.50 100 Protect Skip... * Download and save from LOC control number 9162774. Verify it has 245 and 100 set * Edit record * Replace record via Z39.50 search * 245: was updated * 100: remained unchanged * Save record * 245: was updated * 100: was protected Hopefully an easy fix! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 13:27:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 11:27:15 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen at gmail.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 13:31:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 11:31:03 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #32 from Katrin Fischer --- Hi Björn, will you have time to work on the fixes Nick asked for? I'd really like to see this one in :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 13:44:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 11:44:15 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 13:44:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 11:44:16 +0000 Subject: [Koha-bugs] [Bug 27013] Display an image of barcode on slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27013 Bug 27013 depends on bug 13545, which changed state. Bug 13545 Summary: Add barcode image generator service https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 13:44:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 11:44:16 +0000 Subject: [Koha-bugs] [Bug 20676] svc/barcode should allow barcode to be printed without text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Bug 20676 depends on bug 13545, which changed state. Bug 13545 Summary: Add barcode image generator service https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 13:44:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 11:44:16 +0000 Subject: [Koha-bugs] [Bug 20894] Add barcode size parameters to /svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894 Bug 20894 depends on bug 13545, which changed state. Bug 13545 Summary: Add barcode image generator service https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 13:44:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 11:44:28 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 13:45:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 11:45:15 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs Signoff |RESOLVED --- Comment #18 from Katrin Fischer --- I was trying to set this to 'needs documenting' but I can't reach the status it seems :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 13:45:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 11:45:16 +0000 Subject: [Koha-bugs] [Bug 27013] Display an image of barcode on slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27013 Bug 27013 depends on bug 13545, which changed state. Bug 13545 Summary: Add barcode image generator service https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 13:45:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 11:45:16 +0000 Subject: [Koha-bugs] [Bug 20676] svc/barcode should allow barcode to be printed without text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Bug 20676 depends on bug 13545, which changed state. Bug 13545 Summary: Add barcode image generator service https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 13:45:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 11:45:16 +0000 Subject: [Koha-bugs] [Bug 20894] Add barcode size parameters to /svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894 Bug 20894 depends on bug 13545, which changed state. Bug 13545 Summary: Add barcode image generator service https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 13:45:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 11:45:25 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 13:45:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 11:45:26 +0000 Subject: [Koha-bugs] [Bug 27013] Display an image of barcode on slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27013 Bug 27013 depends on bug 13545, which changed state. Bug 13545 Summary: Add barcode image generator service https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 13:45:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 11:45:26 +0000 Subject: [Koha-bugs] [Bug 20676] svc/barcode should allow barcode to be printed without text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Bug 20676 depends on bug 13545, which changed state. Bug 13545 Summary: Add barcode image generator service https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 13:45:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 11:45:26 +0000 Subject: [Koha-bugs] [Bug 20894] Add barcode size parameters to /svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894 Bug 20894 depends on bug 13545, which changed state. Bug 13545 Summary: Add barcode image generator service https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 13:45:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 11:45:49 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 --- Comment #19 from Katrin Fischer --- CLOSED FIXED > Needs Documenting doesn't work, but: RESOLVED FIXED > Needs Documenting does :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 13:53:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 11:53:39 +0000 Subject: [Koha-bugs] [Bug 25657] Remove username from default value form in patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25657 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master Summary|Import Patron fails without |Remove username from |userid - not stated as |default value form in |required field in notes |patron import --- Comment #13 from Katrin Fischer --- Hi Elaine, thx for not giving up investigating here. I agree that userid/username does not really make sense on this form. I have changed the bug description accordingly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 14:11:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 12:11:12 +0000 Subject: [Koha-bugs] [Bug 30184] Create statistical items that are returned immediately In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30184 --- Comment #3 from Katrin Fischer --- Can be solved using a plugin and the checkout hook if someone runs into this as a requirement. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 14:12:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 12:12:33 +0000 Subject: [Koha-bugs] [Bug 29824] Allow for quick spine labels to be editable for printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29824 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 15:11:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 13:11:06 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #95 from Katrin Fischer --- Created attachment 141210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141210&action=edit Bug 26282: (QA follow-up) Fix typo recieve -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 15:16:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 13:16:20 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #96 from Katrin Fischer --- I tried testing this, but have run into 2 dead ends: * Manually added a HOLD_CANCELLATION notice * Added email address to my patron, created a bunch of holds * Verified the AV exists and has values * Verified my patron has a primary email set 1) From the patron account * Switch No to Yes for cancelling a hold * Choose reason, leave notify patron checked * Cancelled hold * Hold was cancelled, but: No notice was created 2) Record detail page, holds tab: * Click on "garbage can" - modal comes up without cancellation reason pull down or notify option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 20:25:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 18:25:27 +0000 Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #36 from Katrin Fischer --- I have decided to move this to 'In discussion' for now. My reasoning: The patch set does appear to do much more than is written on the 'tin': It claims to allow for custom upload paths, but it does a lot more than that. There are unresolved questions about some of the design decisions and how we can deal with the consequences: * While Kyle had originally proposed using an AV in the initial description, this patch set moves everything away from the GUI into the koha-conf.xml. In doing so, it removes the UPLOAD AV. If this is proven to be the right path, it would require more work to remove the AV category properly and ensure a clean upgrade path (see comment#34, comment#29). But we also should discuss if this is a required step as it takes away control from libraries that often don't have easy access to server side configuration. Personally this feels contrary to what I see in other work (like making a GUI for SMTP servers). * Adds other extra features, like: > hash_filename: Whether to prepend hashvalue to the filename or not. I wonder if some of these features would be better suited as follow-ups to keep the initial bug smaller. (comment#35) My feeling is that these conceptual questions cannot be resolved in QA, but need to be resolved before it reaches the QA step with a clear test plan/upgrade path/reasoning of changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 21:49:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 19:49:56 +0000 Subject: [Koha-bugs] [Bug 30407] Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 22:35:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 20:35:55 +0000 Subject: [Koha-bugs] [Bug 30407] Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 22:35:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 20:35:59 +0000 Subject: [Koha-bugs] [Bug 30407] Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138171|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 141211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141211&action=edit Bug 30407: Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description This can be used to instruct staff how the item should handled when it's checked in. For example items notforloan status has been changed as "Invoiced item" while item has been on loan. When it's checked in staff sees that they should put item aside for further processing. To test: 1. Apply patch and update database if needed 2. Set items notforloan status as -1 (or create new one) 3. Add line "-1: ONLYMESSAGE" to UpdateNotForLoanStatusOnCheckin 4. Check item out for patron. 5. Check item in. => Description of notforloan status should be displayed. => Confirm notforloan status hasn't changed. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 22:36:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 20:36:04 +0000 Subject: [Koha-bugs] [Bug 30407] Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 --- Comment #9 from Katrin Fischer --- Created attachment 141212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141212&action=edit Bug 30407: (QA follow-up) Fix missing TT filter Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 22:36:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 20:36:09 +0000 Subject: [Koha-bugs] [Bug 30407] Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 --- Comment #10 from Katrin Fischer --- Created attachment 141213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141213&action=edit Bug 30407: (QA follow-up) Replace message with description Switches "not for loan message" to "not for loan description" to stay closer to the usual terminology for AV values also used when managing them. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 22:45:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 20:45:03 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 23:24:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 21:24:45 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 00:22:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 22:22:21 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #133 from Katrin Fischer --- 1) Unit tests > I've not seeing what module is missing tests. I've added tests for > AddReserve already! Is there one I missed? Doing some code review and... there are some more *hides* Maybe discuss with Martin which ones should be included in tests: * C4/HoldsQueue.pm * GetHoldsQueueItems * GetPendingHoldRequestsForBib * MapItemsToHoldRequests C4/Reserves.pm * AddReserve (covered) * CheckReserves * _Findgroupreserve Koha/Hold.pm * item_group * forced_hold_level Koha/REST/V1/Holds.pm * add 2) Fixes some smaller stuff in 2 follow-ups, please have a look! 3) Holds to pull is off First my test case: * Added 9 items to a record, 3 each for vol. 1-3 in enumchron * Grouped them into 3 item groups * In the OPAC, I placed a hold onto the volume 2 group In /circ/pendingreserves.pl it shows wrong information: * 39999000005776 or any available. * Available enumchron: vol. 1, vol. 2, vol. 3 * There is no information that only volume 2 is wanted. 4) Holds queue Explodes: C4::HoldsQueue::GetHoldsQueueItems(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'item_group_items.item_group_id' in 'on clause' at /kohadevbox/koha/circ/view_holdsqueue.pl line 51 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 I've run a dbic and a restart_all, but the problem remains. The column exists in my database: describe item_group_items; +---------------------+---------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +---------------------+---------+------+-----+---------+----------------+ | item_group_items_id | int(11) | NO | PRI | NULL | auto_increment | | item_group_id | int(11) | NO | MUL | 0 | | | item_id | int(11) | NO | UNI | 0 | | +---------------------+---------+------+-----+---------+----------------+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 00:23:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 22:23:08 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #134 from Katrin Fischer --- Created attachment 141214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141214&action=edit Bug 24860: (QA follow-up) Fix number of tests in t/db_dependent/Koha/Holds.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 00:23:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 22:23:15 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #135 from Katrin Fischer --- Created attachment 141215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141215&action=edit Bug 24860: (QA follow-up) Terminology and translation fixes * Fixes a single to a double underscore for translation in holds.js * Fixes item_group to item group in API description * Fixes volume hold to item group hold in syspref db descrpitions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 00:37:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 22:37:47 +0000 Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #29 from Katrin Fischer --- In your code I see: +my $currentbranch = C4::Context->userenv ? C4::Context->userenv->{branch} : undef; + $is_available = IsAvailableForItemLevelRequest($item, $patron, $currentbranch) + unless $is_available; But when I look at the POD for IsAvailableForItemLevelRequest the third parameter is supposed to be the pick-up location, not the logged-in user's branch: https://git.koha-community.org/Koha-community/Koha/src/commit/9408a443c24a5424828f62b48fa1dda04fdf3512/C4/Reserves.pm#L1323 my $is_available = IsAvailableForItemLevelRequest( $item_record, $borrower_record, $pickup_branchcode ); I believe this isn't correct. A system might allow you to place a hold for pickup at the item's home library, which might not be the patron's home library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 00:41:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 22:41:59 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Katrin Fischer --- (In reply to Nick Clemens from comment #17) > After applying my console has an error: > Uncaught TypeError: t is undefined ... dayjs.min_22.0600035.js:1:6455 I tested on Tools > Calendar. In Firefox I have the same error. In Chromium I see: dayjs.min_22.0600054.js:1 Uncaught TypeError: Cannot read properties of undefined (reading '$i') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 00:45:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 22:45:18 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #65 from Katrin Fischer --- Sorry to repeat history here :( Too late again. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17170: DB Updates Applying: Bug 17170: DO NOT PUSH - Schema Updates Applying: Bug 17170: Update schema for boolean Applying: Bug 17170: Add API route for SearchFilters Applying: Bug 17170: Add search filters to staff and opac interfaces Applying: Bug 17170: Handle search filters in query builders Applying: Bug 17170: Add admin page for filters and ability to edit/save existing filters Applying: Bug 17170: Unit tests Applying: Bug 17170: (follow-up) Display search filters admin links when apprropriate error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc). error: could not build fake ancestor Patch failed at 0001 Bug 17170: (follow-up) Display search filters admin links when apprropriate hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-17170-follow-up-Display-search-filters-admin-l-O7ZVwo.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 00:47:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 22:47:11 +0000 Subject: [Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing in facet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137785|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 01:13:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 23:13:58 +0000 Subject: [Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing in facet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer --- Hi, thx for the patch! Some things: 1) The database update is not idempotent, meaning that you cannot run it a second time without it causing an error: DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bz27136-Add_languages_for_facet.pl [22:55:29]: Bug 27136 - Add missing language information for facets ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry 'cr-language' for key 'uniq_lang' at /kohadevbox/koha/C4/Installer.pm line 739 As we had some issues with that in recent update (bug 30951), I think it would be better to implement some kind of check. 2) Next time it would be better to have these in 2 separate bugs: * Add languages * Avoid displaying nothing in facets Both are distinct issues and in separate patches it gives better advertising in release notes and better chances one or the other might get backported. A strategy of small granular steps usually also works to make your patches move faster. Maybe a suggestion: We could make this one about adding the languages only as the patches are nice and separate. I tihnk I agree with Nick about not displayin the empty ones, as they can't be searched for - but this discussion could be continued on bug 29561. OK? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 01:26:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 23:26:50 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply Keywords|rel_22_05_candidate |rel_22_11_candidate --- Comment #381 from Katrin Fischer --- Hi Kyle, could you please rebase? I was hoping someone else would look into the case we disagreed about, but now ready to try and tackle this again. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20256: Update database Applying: Bug 20256: Add new permission to editor Applying: Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Applying: Bug 20256: Add new methods for checking item editing permissions Applying: Bug 20256: Update groups editor Applying: Bug 20256: Use new methods Using index info to reconstruct a base tree... M Koha/Item.pm M Koha/UI/Table/Builder/Items.pm M catalogue/detail.pl M catalogue/moredetail.pl M cataloguing/additem.pl M koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt M tools/batchMod.pl Falling back to patching base and 3-way merge... Auto-merging tools/batchMod.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc Auto-merging cataloguing/additem.pl Auto-merging catalogue/moredetail.pl CONFLICT (content): Merge conflict in catalogue/moredetail.pl Auto-merging catalogue/detail.pl CONFLICT (content): Merge conflict in catalogue/detail.pl Auto-merging Koha/UI/Table/Builder/Items.pm CONFLICT (content): Merge conflict in Koha/UI/Table/Builder/Items.pm Auto-merging Koha/Item.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 20256: Use new methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 01:30:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2022 23:30:34 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #66 from Katrin Fischer --- I am afraid I am not the right QA person for this one, but also it does no longer apply :( error: sha1 information is lacking or useless (Koha/Patron.pm). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 05:59:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 03:59:54 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 06:04:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 04:04:29 +0000 Subject: [Koha-bugs] [Bug 30260] Script which checks index should also check if the zebraqueue has uncommitted records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30260 --- Comment #6 from Aleisha Amohia --- How should I get that patch into the global repo? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 08:20:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 06:20:44 +0000 Subject: [Koha-bugs] [Bug 31548] OpacMainUserBlock not properly preserved during upgrade - no more reachable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31548 --- Comment #2 from Hans Ulrich Frink --- thanks Katrin for your reply. We solved our problem by reinstalling the whole koha and importing our data into the new empty mysql db. just running the upgrade on the existing installation did NOT work. That was the reason to file the bug. I think the upgrade process does not adress the changed field structure from "news" to "html" properly. I wonder how other users worked around this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 09:00:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 07:00:30 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 09:00:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 07:00:34 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140666|0 |1 is obsolete| | --- Comment #30 from Marcel de Rooy --- Created attachment 141216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141216&action=edit Bug 31503: Adjust db column patron_consent.type We want to control this field now via authorised values. An ENUM is too restrictive. A foreign key on the values of authorised_value for category 'PATRON_CONSENT' is not possible. This will do for now. Test plan: Run dbrev. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 09:00:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 07:00:39 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140667|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy --- Created attachment 141217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141217&action=edit Bug 31503: Add $patron->consent Test plan: Run t/db_dependent/Koha/Patron.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 09:00:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 07:00:43 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140668|0 |1 is obsolete| | --- Comment #32 from Marcel de Rooy --- Created attachment 141218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141218&action=edit Bug 31503: Use patron->consent in opac-patron-consent Includes a few small additional changes in template: [1] op == save (more generic) [2] agreed/disagreed replaced by 1/0 [3] toggling display of consent_info paragraph Test plan: Enable GDPR_Policy. Test adding/removing consent. Check what happens with alert, consent_info paragraph and save button. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 09:00:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 07:00:47 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140669|0 |1 is obsolete| | --- Comment #33 from Marcel de Rooy --- Created attachment 141219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141219&action=edit Bug 31503: Change usermenu condition Test plan: Check if you see Consents tab depending on GDPR_Policy or having PATRON_CONSENT authorised values. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 09:00:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 07:00:51 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140670|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy --- Created attachment 141220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141220&action=edit Bug 31503: Add $av_cat->values Test plan: Run t/db_dependent/AuthorisedValues.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 09:00:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 07:00:56 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140671|0 |1 is obsolete| | --- Comment #35 from Marcel de Rooy --- Created attachment 141221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141221&action=edit Bug 31503: Make opac-patron-consent more generic We now allow multiple consent types as defined under AV (read: authorised values) category 'PATRON_CONSENT'. The description is used on the form too. This is the base patch for multiple consents. We can do some more polishing on a follow-up or another report even. Note: the alert for GDPR was moved to the description. Test plan: First check the form without any PATRON_CONSENT values in AV. Toggle the value of pref GDPR_Policy. Now add GDPR_PROCESSING and another one (e.g. NEWSLETTER). Refresh the OPAC form. Verify that you can toggle consent/dissent and that everything is saved correctly. Note only a real change updates the timestamp. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 09:01:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 07:01:01 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140672|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy --- Created attachment 141222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141222&action=edit Bug 31503: Configurable consent text Although I planned to implement this via Additional contents (AC), I am using the AV description here after all, since AC does not yet provide enough flexibility. The title on the consents page is constructed from the consent type now still, and the description is from the OPAC description in AV (PATRON_CONSENT). Note: AV allows you to add html in the description, although it was not meant to do so. When we switch to AC later, we will have the possibility of html, languages, title and content. Second note: We still need AV translations too. See Bugzilla. Test plan: [1] Add a NEWSLETTER value under AV category PATRON_CONSENT. [2] Add no OPAC description. Save. Hit OPAC consents page. [3] Add description. Check page again. [4] Add html to description. Check again. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 09:04:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 07:04:29 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #37 from Marcel de Rooy --- (In reply to David Nind from comment #29) > The patch no longer applies 8-(.. > > Apply? [(y)es, (n)o, (i)nteractive] y > Applying: Bug 31503: Adjust db column patron_consent.type > Applying: Bug 31503: Add $patron->consent > Using index info to reconstruct a base tree... > M Koha/Patron.pm > M t/db_dependent/Koha/Patron.t > Falling back to patching base and 3-way merge... > Auto-merging t/db_dependent/Koha/Patron.t > CONFLICT (content): Merge conflict in t/db_dependent/Koha/Patron.t > Auto-merging Koha/Patron.pm > error: Failed to merge in the changes. > Patch failed at 0001 Bug 31503: Add $patron->consent Try again please David. Note that this test now fails on master in subtest 19 - notify_library_of_registration() with and without this patch set. So can be ignored, should be addressed somewhere else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 09:12:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 07:12:10 +0000 Subject: [Koha-bugs] [Bug 23538] Email library when new patrons self register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #36 from Marcel de Rooy --- + t::lib::Mocks::mock_preference( 'KohaAdminEmailAddress', 'root at localhost' ); + t::lib::Mocks::mock_preference( 'EmailAddressForPatronRegistrations', 'library at localhost' ); + + # Test when EmailPatronRegistrations equals BranchEmailAddress + t::lib::Mocks::mock_preference( 'EmailPatronRegistrations', 'BranchEmailAddress' ); + is( $patron->notify_library_of_registration(C4::Context->preference('EmailPatronRegistrations')), 1, 'OPAC_REG email is queued if EmailPatronRegistration syspref equals BranchEmailAddress'); + my $sth = $dbh->prepare("SELECT to_address FROM message_queue where borrowernumber = ?"); + $sth->execute( $patron->borrowernumber ); + my $to_address = $sth->fetchrow_array; + is( $to_address, 'to at mybranch.com', 'OPAC_REG email queued to go to branchreplyto address when EmailPatronRegistration equals BranchEmailAddress' ); + $dbh->do(q|DELETE FROM message_queue|); + + # Test when EmailPatronRegistrations equals EmailAddressForPatronRegistrations + t::lib::Mocks::mock_preference( 'EmailPatronRegistrations', 'EmailAddressForPatronRegistrations' ); + is( $patron->notify_library_of_registration(C4::Context->preference('EmailPatronRegistrations')), 1, 'OPAC_REG email is queued if EmailPatronRegistration syspref equals EmailAddressForPatronRegistrations'); + $sth->execute( $patron->borrowernumber ); + $to_address = $sth->fetchrow_array; + is( $to_address, 'library at localhost', 'OPAC_REG email queued to go to EmailAddressForPatronRegistrations syspref when EmailPatronRegistration equals EmailAddressForPatronRegistrations' ); + $dbh->do(q|DELETE FROM message_queue|); + + # Test when EmailPatronRegistrations equals KohaAdminEmailAddress + t::lib::Mocks::mock_preference( 'EmailPatronRegistrations', 'KohaAdminEmailAddress' ); + is( $patron->notify_library_of_registration(C4::Context->preference('EmailPatronRegistrations')), 1, 'OPAC_REG email is queued if EmailPatronRegistration syspref equals KohaAdminEmailAddress'); + $sth->execute( $patron->borrowernumber ); + $to_address = $sth->fetchrow_array; + is( $to_address, 'root at localhost', 'OPAC_REG email queued to go to KohaAdminEmailAddress syspref when EmailPatronRegistration equals KohaAdminEmailAddress' ); + $dbh->do(q|DELETE FROM message_queue|); This part of the test fails with me: not ok 6 - OPAC_REG email queued to go to KohaAdminEmailAddress syspref when EmailPatronRegistration equals KohaAdminEmailAddress # Failed test 'OPAC_REG email queued to go to KohaAdminEmailAddress syspref when EmailPatronRegistration equals KohaAdminEmailAddress' # at t/db_dependent/Koha/Patron.t line 1347. # got: 'bibliotheek at master.rijkskoha.nl' # expected: 'root at localhost' # Looks like you failed 1 test of 6. Also note that you'd better not use localhost as an email address in your tests. And that you include several SQL statements that should be Koha objects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 09:25:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 07:25:43 +0000 Subject: [Koha-bugs] [Bug 23538] Email library when new patrons self register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #37 from Marcel de Rooy --- Koha::Patron elsif ( $email_patron_registrations eq "KohaAdminEmailAddress" ) { $to_address = C4::Context->preference('ReplytoDefault') || C4::Context->preference('KohaAdminEmailAddress'); } This is the cause of the failing test. Why do you use ReplytoDefault here. The value of the pref says KohaAdmin. This is quite confusing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 10:09:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 08:09:06 +0000 Subject: [Koha-bugs] [Bug 23538] Email library when new patrons self register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #38 from Marcel de Rooy --- Created attachment 141223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141223&action=edit Bug 23538: (follow-up) Workaround to fix Patron.t See comment36 and comment37. This needs more attention but serves as a quick fix only. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 10:09:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 08:09:24 +0000 Subject: [Koha-bugs] [Bug 23538] Email library when new patrons self register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 10:09:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 08:09:33 +0000 Subject: [Koha-bugs] [Bug 23538] Email library when new patrons self register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 10:09:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 08:09:41 +0000 Subject: [Koha-bugs] [Bug 23538] Email library when new patrons self register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 10:10:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 08:10:26 +0000 Subject: [Koha-bugs] [Bug 23538] Email library when new patrons self register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Signed Off |Passed QA --- Comment #39 from Marcel de Rooy --- Tomas: Last patch only please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 10:22:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 08:22:34 +0000 Subject: [Koha-bugs] [Bug 31625] Reindent tools home and tools sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 --- Comment #9 from Martin Renvoize --- It'll clash, but I'll have a quick look at rebasing the other ones upon this one.. hopefully it won't be too painful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 10:35:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 08:35:39 +0000 Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 11:06:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 09:06:25 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #301 from Julian Maurice --- There is a test instance set up at https://pro-mt38042-koha.demo.biblibre.eu Credentials are "test" / "test" I'll update it as soon as new patches are written so it should always be up-to-date. Please report bugs to https://github.com/jajm/koha-staff-interface-redesign/issues If something prevents you from testing on this instance, please contact me by email or IRC (jajm) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 11:28:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 09:28:10 +0000 Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 José Anjos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- CC| |joseanjos at gmail.com --- Comment #33 from José Anjos --- I think this is related: Updating database structure Update errors : Upgrade to 22.05.04.002 [10:09:24]: Bug 31086 - Do not allow null values in branchcodes for reserves ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change column 'branchcode': used in a foreign key constraint 'reserves_ibfk_4' at /usr/share/koha/lib/C4/Installer.pm line 739 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 11:35:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 09:35:53 +0000 Subject: [Koha-bugs] [Bug 22693] ILL "Price paid" column does not appear in column configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc at interleaf.ie --- Comment #1 from Holly --- Just adding a comment to express that there is interest in seeing this feature added. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 11:46:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 09:46:18 +0000 Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 11:46:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 09:46:23 +0000 Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139964|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 141224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141224&action=edit Bug 25426: Allow return policy to be selected via syspref and not just home library 1) Apply this patch 2) Run updatedatabase.pl 3) Verify CircControlReturnsBranch is set to home library by default 4) Set a Return policy for Branch A to "Item returns home" ( homebranch ) 5) Set a Return polity for Branch B to "Item returns to issuing library" ( holdingbranch ) 6) Set a Return polity for Branch C to "Item floats" ( noreturn ) 7) Create an item with homebranch of Branch A, holding branch of branch B 8) Log in as Branch C 9) Set CircControlReturnsBranch to "the library the item is currently held by" 10) Check the item in, note it should be returned to the holding library 11) Set CircControlReturnsBranch to "the library the item is owned by" 12) Check the item in, note it should be returned to the home library 13) Set CircControlReturnsBranch to "the library you are logged in at" 14) Check the item in, note it should float Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 11:46:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 09:46:28 +0000 Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426 --- Comment #12 from Katrin Fischer --- Created attachment 141225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141225&action=edit Bug 25426: (QA follow-up) Small fixes to POD and INSERT IGNORE or datatabase update * Makes sure the system preference is added with INSERT IGNORE * Some smaller fixes/additions to the POD of get_return_branch_policy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 11:46:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 09:46:33 +0000 Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426 --- Comment #13 from Katrin Fischer --- Created attachment 141226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141226&action=edit Bug 25426: (QA follow-up) Rephrase CircControlReturnsBranch system preference description Rephrased in hope to make its use a little clearer: * 'logged in at' replaced with 'checked in at' keeping self checks in mind * 'At checkin' rephrased a bit to explain possible options Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 11:46:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 09:46:55 +0000 Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 José Anjos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #34 from José Anjos --- After manually doing this command: ALTER TABLE reserves MODIFY COLUMN `branchcode` varchar(10) COLLATE utf8mb4_unicode_ci NOT NULL COMMENT 'foreign key from the branches table defining which branch the patron wishes to pick this hold up at'; Query OK, 0 rows affected (0.06 sec) Records: 0 Duplicates: 0 Warnings: 0 it was possible to continue with the upgrade... Strange -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 11:54:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 09:54:23 +0000 Subject: [Koha-bugs] [Bug 31001] "CGI::param called in list context" warning in basket.pl flooding error log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31001 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Acquisitions |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:16:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:16:37 +0000 Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426 --- Comment #14 from Katrin Fischer --- Created attachment 141227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141227&action=edit Bug 25426: (QA follow-up) Update notes on circulation rules page for new pref This adds a note to the circulation rules page that already explained about ReservesControlBranch to also include information about the new CircControlReturnsBranch system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:21:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:21:08 +0000 Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426 --- Comment #15 from Katrin Fischer --- I might have gotten carried away a little here, but hope you all approve: 1) System preference description updated a bit. 2) Added a note to the circulation rules page... please also check that! 3) The option itemtype '*' described in the POD can currently not be set in the GUI. As we also set We cannot just add it, 'Hold policy' and 'Hold pickup library match' in the same row, this might require some more work, but happy to have the method already support it. 4) I set release-notes-needed as while I like and agree with this change it will mean a change in behavior for some libraries and we should document that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:21:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:21:56 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:26:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:26:55 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:27:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:27:00 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139948|0 |1 is obsolete| | --- Comment #66 from Nick Clemens --- Created attachment 141228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141228&action=edit Bug 17170: DB Updates This patch adds the new table, permission, and a syspref to enable the feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:27:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:27:04 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139949|0 |1 is obsolete| | --- Comment #67 from Nick Clemens --- Created attachment 141229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141229&action=edit Bug 17170: DO NOT PUSH - Schema Updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:27:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:27:09 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139950|0 |1 is obsolete| | --- Comment #68 from Nick Clemens --- Created attachment 141230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141230&action=edit Bug 17170: Update schema for boolean -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:27:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:27:14 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139951|0 |1 is obsolete| | --- Comment #69 from Nick Clemens --- Created attachment 141231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141231&action=edit Bug 17170: Add API route for SearchFilters This adds the API routes and tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:27:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:27:18 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139952|0 |1 is obsolete| | --- Comment #70 from Nick Clemens --- Created attachment 141232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141232&action=edit Bug 17170: Add search filters to staff and opac interfaces This patch displays the filters on the results pages with the facets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:27:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:27:23 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139953|0 |1 is obsolete| | --- Comment #71 from Nick Clemens --- Created attachment 141233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141233&action=edit Bug 17170: Handle search filters in query builders This patch updates the query building code to expand filters when searching and pass them back as part of the cgi and descriptive search strings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:27:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:27:28 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139954|0 |1 is obsolete| | --- Comment #72 from Nick Clemens --- Created attachment 141234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141234&action=edit Bug 17170: Add admin page for filters and ability to edit/save existing filters This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the resuilts page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:27:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:27:33 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139955|0 |1 is obsolete| | --- Comment #73 from Nick Clemens --- Created attachment 141235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141235&action=edit Bug 17170: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:27:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:27:38 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139956|0 |1 is obsolete| | --- Comment #74 from Nick Clemens --- Created attachment 141236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141236&action=edit Bug 17170: (follow-up) Display search filters admin links when apprropriate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:27:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:27:42 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139957|0 |1 is obsolete| | --- Comment #75 from Nick Clemens --- Created attachment 141237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141237&action=edit Bug 17170: Add the ability to create 'saved searches' for use as filters when searching the catalog This patch alters the code in the ES QueryBuilder. Reflecting how things are handled in build_query_compat we clean the query, but not the limits. In Zebra we simply recursivly call buildQuery, but the ES query structure This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the results page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page Signed-off-by: Michal Urban -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:30:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:30:48 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:36:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:36:12 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:36:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:36:16 +0000 Subject: [Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing in facet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:36:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:36:17 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140074|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 141238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141238&action=edit Bug 30571: Table z3950servers: Make host, syntax and encoding NOT NULL This is not a sync issue between structure and db revs. It just seems a logical move. Note that the interface for long does not allow these fields to be empty. Test plan: Run dbrev. Add a new Z3950/SRU server. Verify if it works as expected. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:36:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:36:20 +0000 Subject: [Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing in facet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139998|0 |1 is obsolete| | Attachment #139999|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 141239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141239&action=edit Bug 27136: Add additional languages for facet display This patch adds two missing languages, Cree & Afrikaans, as well as some necessary linguistic definitions for faceting: Multi language, undetermined, no linguistic content Signed-off-by: Alexis Ripetti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:36:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:36:22 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140075|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 141240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141240&action=edit Bug 30571: (DBIx schema) Update for Z3950server.pm No test plan. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:36:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:36:24 +0000 Subject: [Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing in facet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 --- Comment #12 from Nick Clemens --- Created attachment 141241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141241&action=edit Bug 27136: (follow-up) Make update idempotent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:36:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:36:27 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140076|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 141242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141242&action=edit Bug 30571: Z3950Servers.t - Create subtest for existing tests No real changes, just moving code and indentation. Ground work for following patch. Test plan: To let the test pass, disable strict_mode in koha-conf. Run perl t/db_dependent/Koha/Z3950Servers.t. Should pass now. However, in strict mode or with prove, it should fail. Run prove t/db_dependent/Koha/Z3950Servers.t. Failed? Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:36:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:36:32 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140077|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer --- Created attachment 141243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141243&action=edit Bug 30571: Z3950Servers.t - Add another subtest Subtest for testing nullability of host, syntax and encoding. Test plan: Run prove t/db_dependent/Koha/Z3950Servers.t. (Note: you need strict mode to pass this test.) Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:36:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:36:36 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 --- Comment #19 from Katrin Fischer --- Created attachment 141244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141244&action=edit Bug 30571: (QA follow-up) Update marc to MARC in docs ... don't say it, I know. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:37:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:37:22 +0000 Subject: [Koha-bugs] [Bug 31668] New: Avoid displaying nothing in facet Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31668 Bug ID: 31668 Summary: Avoid displaying nothing in facet Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Adding a way to avoid displaying nothing in facet for opac and client staff when using elasticsearch as SearchEngine. Test plan: 1) Do a search, like 'a' 2) Look in the bottom of the sidebar on the left and see that there is an empty language -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:39:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:39:52 +0000 Subject: [Koha-bugs] [Bug 31668] Avoid displaying nothing in facet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31668 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:39:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:39:56 +0000 Subject: [Koha-bugs] [Bug 31668] Avoid displaying nothing in facet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31668 --- Comment #1 from Nick Clemens --- Created attachment 141245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141245&action=edit Bug 31668: Avoid displaying nothing in facet This patch displays 'No information provided' if a facet value/description cannot be found, rather than displaying an empty/hidden facet Test plan: 1) Do a search, like 'a' 2) Look in the bottom of the sidebar on the left and see that there is an empty language 3) Apply patch 4) Update database 5) Do the same research 6) See that there is now "No information provided" Signed-off-by: Alexis Ripetti -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:40:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:40:05 +0000 Subject: [Koha-bugs] [Bug 31668] Avoid displaying nothing in facet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31668 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:40:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:40:25 +0000 Subject: [Koha-bugs] [Bug 31668] Avoid displaying nothing in facet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31668 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alexis.ripetti at inLibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:40:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:40:49 +0000 Subject: [Koha-bugs] [Bug 27136] Add language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add languages and avoid |Add language |displaying nothing in facet | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:40:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:40:59 +0000 Subject: [Koha-bugs] [Bug 27136] Add language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31668 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:40:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:40:59 +0000 Subject: [Koha-bugs] [Bug 31668] Avoid displaying nothing in facet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31668 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27136 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:46:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:46:58 +0000 Subject: [Koha-bugs] [Bug 27136] Add additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add language |Add additional languages Text to go in the| |Adds Cree, Afrikaans and release notes| |Multiple languages, | |Undetermined and No | |linguistic content to our | |language definitions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:48:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:48:09 +0000 Subject: [Koha-bugs] [Bug 18556] Message "Patron's address in doubt" is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #5 from Nick Clemens --- (In reply to Katrin Fischer from comment #4) > I like the change in wording, but I am in doubt about removing the circ-hlt > class as it appears in the CSS and in other messages shown in the patron > account, so it's something they have in common right now. Maybe we should > keep it? I don't remove it, it remains, one level down > And something odd with and without the patch: If you go to a patron account > and set both flags, only the first has the list > in the beginning. True before these patches too, something in the list markup maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:51:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 10:51:41 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:04:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:04:16 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140578|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize --- Created attachment 141246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141246&action=edit Bug 31162: Add a cataloging module home page This patch adds a new cataloging-home template and controller and replaces most cases of links to addbooks. This servers to provide a new cataloging home page for the cataloging module and keeps it distinct from the current addbooks page it partially replaces as a stating point for cataloging. Signed-off-by: KIT Signed-off-by: Emmanuel Bétemps Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:04:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:04:22 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140579|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize --- Created attachment 141247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141247&action=edit Bug 31162: Remove toolbar This patch removes the existing toolbar with 'New record' and 'New from Z39.50/SRU' and replaces the functionality with simple buttons on the page. We lose the ability to select the Framework or Z39.50/SRU server at this stage but one can still select these options from the resulting dialogues. Signed-off-by: Emmanuel Bétemps Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:04:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:04:29 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140580|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize --- Created attachment 141248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141248&action=edit Bug 31162: (follow-up) 3 Column layout This patch converts to a 3 column layout as suggested by David. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:04:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:04:34 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140581|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize --- Created attachment 141249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141249&action=edit Bug 31162: Remove duplicates from tools-home This patch removes cataloging tools from the tools-home page where they are now listed on the cataloging home page. This leaves just two options in the 'Cataloging' section of the tools home page, 'Rotating collections' and 'Upload local cover images'. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:04:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:04:40 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140582|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize --- Created attachment 141250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141250&action=edit Bug 31162: More conditionals for sections This adds missing conditionals to the section headings in the new cataloging homepage. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:04:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:04:46 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140583|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize --- Created attachment 141251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141251&action=edit Bug 31162: Move Rotating Collections and Upload Covers This patch moves the 'Rotating Collections' link from 'Cataloging' to 'Circulation' on the 'Tools' home page and moves the 'Upload local cover image' link to the 'Cataloging' home page. This removes the 'Cataloging' tools section entirely and as such the template is adapted to a two column layout to compensate. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:04:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:04:51 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140584|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize --- Created attachment 141252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141252&action=edit Bug 31162: Fix help link on catalouging start page Now the link goes to the cataloguing chapter start page of the manual instead of the less specific manual start page. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:04:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:04:57 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140585|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize --- Created attachment 141253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141253&action=edit Bug 31162: (QA follow-up) Change Automations to Automation This was suggested by David Nind in testing and I agree that it sounds a litle nicer. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:05:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:05:03 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140586|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize --- Created attachment 141254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141254&action=edit Bug 31162: Restore ability to pick framework This patch restores the ability to pick the framework via a dropdown on the cataloguing home page. The CSS needs some work.. this is a proof of concept -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:05:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:05:46 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 [Bug 31402] Update tools sidebar to match tools start page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:05:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:05:46 +0000 Subject: [Koha-bugs] [Bug 31402] Update tools sidebar to match tools start page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31162 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 [Bug 31162] Add a clear cataloguing module home page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:06:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:06:36 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #71 from Martin Renvoize --- Rebased against bug 31402.. still needs some CSS work on that final patch.. but also still testable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:21:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:21:54 +0000 Subject: [Koha-bugs] [Bug 31417] Re-instate the cataloguing sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139653|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 141255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141255&action=edit Bug 31417: Update and reference cat-menu.inc This patch reinstates the cat-menu.inc include and references it from the various 'tools' that are closely tied to cataloging. We use the new cataloging home page submission as a reference for which options should appear in the menu. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:22:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:22:09 +0000 Subject: [Koha-bugs] [Bug 31417] Re-instate the cataloguing sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 --- Comment #7 from Martin Renvoize --- Another rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:32:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:32:25 +0000 Subject: [Koha-bugs] [Bug 24127] Improve wording on location drop-down in advanced search in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:32:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:32:29 +0000 Subject: [Koha-bugs] [Bug 24127] Improve wording on location drop-down in advanced search in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 --- Comment #18 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:32:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:32:32 +0000 Subject: [Koha-bugs] [Bug 26368] Add support for OCLC Encoding level values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26368 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:32:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:32:35 +0000 Subject: [Koha-bugs] [Bug 26368] Add support for OCLC Encoding level values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26368 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:32:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:32:38 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:32:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:32:40 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 --- Comment #20 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:32:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:32:43 +0000 Subject: [Koha-bugs] [Bug 31412] Set focus for cursor to Name when adding a new SMTP server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31412 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:32:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:32:46 +0000 Subject: [Koha-bugs] [Bug 31412] Set focus for cursor to Name when adding a new SMTP server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31412 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:32:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:32:49 +0000 Subject: [Koha-bugs] [Bug 31528] Replace scss-lint configuration with one for stylelint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:32:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:32:51 +0000 Subject: [Koha-bugs] [Bug 31528] Replace scss-lint configuration with one for stylelint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:32:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:32:54 +0000 Subject: [Koha-bugs] [Bug 31529] Fix errors in SCSS files raised by stylelint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31529 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:32:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:32:57 +0000 Subject: [Koha-bugs] [Bug 31529] Fix errors in SCSS files raised by stylelint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31529 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:34:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:34:32 +0000 Subject: [Koha-bugs] [Bug 31601] Materials specified note should include an ID on both the check in and checkout pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31601 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:34:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:34:34 +0000 Subject: [Koha-bugs] [Bug 31601] Materials specified note should include an ID on both the check in and checkout pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31601 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:34:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:34:37 +0000 Subject: [Koha-bugs] [Bug 31653] jQuery upgrade broke search button hover effect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31653 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:34:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:34:40 +0000 Subject: [Koha-bugs] [Bug 31653] jQuery upgrade broke search button hover effect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31653 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:39:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:39:28 +0000 Subject: [Koha-bugs] [Bug 22115] Table of checkouts doesn't respect CurrencyFormat setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22115 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:39:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:39:33 +0000 Subject: [Koha-bugs] [Bug 22115] Table of checkouts doesn't respect CurrencyFormat setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22115 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140811|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 141256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141256&action=edit Bug 22115: Format prices in table of checkouts according to CurrencyFormat setting In the patron account in the staff interface, all amounts in the checkouts table should be formatted according to the CurrencyFormat system preference setting. To test: * Edit some items, setting the replacement cost * Make sure one of the item type is set to charge a rental charge * Check out items * Verify the checkouts table displays on both checkouts and details tabs correctly * Try different settings of CurrencyFormat and verify all amounts display correctly Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:39:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:39:37 +0000 Subject: [Koha-bugs] [Bug 22115] Table of checkouts doesn't respect CurrencyFormat setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22115 --- Comment #8 from Nick Clemens --- Created attachment 141257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141257&action=edit Bug 22115: (QA follow-up) prevent wrap on price columns Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:40:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:40:50 +0000 Subject: [Koha-bugs] [Bug 31669] New: Improve support for "cost" field Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31669 Bug ID: 31669 Summary: Improve support for "cost" field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com An ILL request has a "cost" field associated with it. This is intended to be used to indicate the cost of a request as quoted by a supplier. Support for actually using this field is somewhat lacking. The current use is: - The BLDSS backend populates it upon request placement, the value is derived from the BLDSS request response - The "Edit request" screen displays the value, or N/A if not populated. This value is read-only and cannot be modified. What needs to be done: - Other ILL backends should add support for populating the "cost" field during request placement - Modify the "Edit request" template to allow the value to be modified. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:41:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:41:55 +0000 Subject: [Koha-bugs] [Bug 31669] Improve support for ILL "cost" field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31669 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve support for "cost" |Improve support for ILL |field |"cost" field -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:50:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:50:02 +0000 Subject: [Koha-bugs] [Bug 29071] HoldsSplitQueueNumbering not set for new installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29071 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:50:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:50:05 +0000 Subject: [Koha-bugs] [Bug 29071] HoldsSplitQueueNumbering not set for new installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29071 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:50:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:50:08 +0000 Subject: [Koha-bugs] [Bug 31441] Koha::Item::as_marc_field ignores subfields where kohafield is an empty string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31441 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:50:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:50:11 +0000 Subject: [Koha-bugs] [Bug 31441] Koha::Item::as_marc_field ignores subfields where kohafield is an empty string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31441 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:50:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:50:14 +0000 Subject: [Koha-bugs] [Bug 31463] (Bug 31313 follow-up) Show item order status on opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31463 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:50:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:50:17 +0000 Subject: [Koha-bugs] [Bug 31463] (Bug 31313 follow-up) Show item order status on opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31463 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:50:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:50:20 +0000 Subject: [Koha-bugs] [Bug 31482] Label creator does not call barcodedecode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:50:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:50:23 +0000 Subject: [Koha-bugs] [Bug 31482] Label creator does not call barcodedecode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 --- Comment #12 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:50:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:50:26 +0000 Subject: [Koha-bugs] [Bug 31540] Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31540 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:50:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 11:50:29 +0000 Subject: [Koha-bugs] [Bug 31540] Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31540 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 14:03:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 12:03:52 +0000 Subject: [Koha-bugs] [Bug 31586] Log basket number as object when an email order is sent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31586 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 14:03:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 12:03:56 +0000 Subject: [Koha-bugs] [Bug 31586] Log basket number as object when an email order is sent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31586 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140825|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 141258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141258&action=edit Bug 31586: Log basket number as object for action ACQUISITION ORDER Until now we logged undef as object in action_logs when an email order was sent. With this patch the basket number is logged instead, which will allow for reporting and also allows us to display a link to the basket, if permissions permit (order manage), in the log viewer. To test: - Make sure the ClaimsLog system preference is set to Log - Create a vendor or make sure an existing vendor has an email set - Make sure to add an SMTP server and link it to your library - Create a basket in acqisitions and add an order line - Click "E-mail order" to send the email - Go to the log viewer, limit to module Acquisitions - Verify that the entry show with a link to the basket in the Object column If the user doesn't have order_manage permission, the basket number will still show, but isn't linked Signed-off-by: Michaela Sieber Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 14:06:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 12:06:43 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 14:08:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 12:08:46 +0000 Subject: [Koha-bugs] [Bug 23063] Item table in cataloguing doesn't respect CurrencyFormat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23063 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 14:08:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 12:08:50 +0000 Subject: [Koha-bugs] [Bug 23063] Item table in cataloguing doesn't respect CurrencyFormat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23063 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140812|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 141259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141259&action=edit Bug 23063: Use Price formatting on amounts in item table in cataloguing Koha can use CurrencyFormat for displaying price amounts and should do so consistently everywhere. Without this patch price and replacement cost will always display as xx.xx independent of CurrencyFormat setting in the table above the edit items form. This patch fixes the table display. To test: * Apply patch * Search or create a record with multiple items * Fill in some price and replacement costs * Try different settings of the CurrencyFormat system preference * The display in the item table above the edit/add form should display according to the system preference * Verify sorting works Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 14:55:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 12:55:21 +0000 Subject: [Koha-bugs] [Bug 31528] Replace scss-lint configuration with one for stylelint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 141260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141260&action=edit Bug 31528: (QA follow-up) Exclude .stylelintrc.json in Makefile.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 15:02:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 13:02:45 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 15:02:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 13:02:50 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141174|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 141261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141261&action=edit Bug 31666: Add job progress bar to stage-marc-import.pl It would be nice if we had progress bars to indicate the progress of background jobs for scripts that utilize them. This patch implements a reusable bootstrap based progess bar. Test Plan: 1) Apply this patch 2) Stage a marc batch ( preferrably a large one to show the progress updating ) 3) Note the new progess bar, verify it functions correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 15:07:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 13:07:17 +0000 Subject: [Koha-bugs] [Bug 31594] Report results count of shown can be incorrect on last page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31594 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141203|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi --- Created attachment 141262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141262&action=edit Bug 31594: Use count of results for displaying number shown To test: 1 - Create a report with a number of results that is not a multiple of 20 SELECT barcode FROM items 2 - Run the report 3 - Go to the final page 4 - Note report says 20 shown, but there are less 5 - Apply patch 6 - Reload and confirm correct number of shown is shown :-) Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 15:09:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 13:09:47 +0000 Subject: [Koha-bugs] [Bug 28512] Quick spine label creator: Add CSS class with logged in library's branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 15:09:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 13:09:49 +0000 Subject: [Koha-bugs] [Bug 28512] Quick spine label creator: Add CSS class with logged in library's branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 --- Comment #13 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 15:09:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 13:09:52 +0000 Subject: [Koha-bugs] [Bug 29389] Add holding branch to holds queue report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29389 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 15:09:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 13:09:54 +0000 Subject: [Koha-bugs] [Bug 29389] Add holding branch to holds queue report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29389 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 15:09:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 13:09:57 +0000 Subject: [Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 15:10:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 13:10:00 +0000 Subject: [Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #54 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 15:10:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 13:10:03 +0000 Subject: [Koha-bugs] [Bug 31475] Group system preferences for suggestions on OPAC tab under new heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31475 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 15:10:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 13:10:07 +0000 Subject: [Koha-bugs] [Bug 31475] Group system preferences for suggestions on OPAC tab under new heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31475 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 15:10:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 13:10:10 +0000 Subject: [Koha-bugs] [Bug 31594] Report results count of shown can be incorrect on last page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31594 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 15:10:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 13:10:14 +0000 Subject: [Koha-bugs] [Bug 31594] Report results count of shown can be incorrect on last page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31594 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 15:16:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 13:16:36 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #302 from Martin Renvoize --- I spent some time again today going through the github issues.. lots of great work here.. I would be so bold as to say this is really at the QA stage now.. the general feeling is it's a goer and we're just doing final polishing.. some of which should probably go ahead in their own bugs after this is pushed. I'm going to be bold and say this is Signed Off to get more QA eyes on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 15:16:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 13:16:53 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 15:25:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 13:25:04 +0000 Subject: [Koha-bugs] [Bug 31669] Improve support for ILL "cost" field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31669 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 15:41:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 13:41:21 +0000 Subject: [Koha-bugs] [Bug 31670] New: Fix inconsistency with breadcrumbs in the Patrons module Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31670 Bug ID: 31670 Summary: Fix inconsistency with breadcrumbs in the Patrons module Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Breadcrumbs in the Patrons module are inconsistent with many other modules in Koha now. They often take the form: * Home > Patrons > Make a payment for David R Bath (29999000490250) * Home > Patrons > Subscription routing lists for David R Bath (29999000490250) The more modern approach is: * Home > Patrons > David R Batch * Home > Patrons > David R Batch > Accounts * Home > Patrons > David R Batch > Routing lists -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 15:41:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 13:41:29 +0000 Subject: [Koha-bugs] [Bug 31670] Fix inconsistency with breadcrumbs in the Patrons module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31670 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 15:41:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 13:41:38 +0000 Subject: [Koha-bugs] [Bug 31670] Fix inconsistency with breadcrumbs in the Patrons module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31670 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |isobel.graham09 at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:14:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 14:14:34 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:14:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 14:14:39 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141216|0 |1 is obsolete| | --- Comment #38 from David Nind --- Created attachment 141263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141263&action=edit Bug 31503: Adjust db column patron_consent.type We want to control this field now via authorised values. An ENUM is too restrictive. A foreign key on the values of authorised_value for category 'PATRON_CONSENT' is not possible. This will do for now. Test plan: Run dbrev. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:14:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 14:14:45 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141217|0 |1 is obsolete| | --- Comment #39 from David Nind --- Created attachment 141264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141264&action=edit Bug 31503: Add $patron->consent Test plan: Run t/db_dependent/Koha/Patron.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:14:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 14:14:51 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141218|0 |1 is obsolete| | --- Comment #40 from David Nind --- Created attachment 141265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141265&action=edit Bug 31503: Use patron->consent in opac-patron-consent Includes a few small additional changes in template: [1] op == save (more generic) [2] agreed/disagreed replaced by 1/0 [3] toggling display of consent_info paragraph Test plan: Enable GDPR_Policy. Test adding/removing consent. Check what happens with alert, consent_info paragraph and save button. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:14:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 14:14:56 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141219|0 |1 is obsolete| | --- Comment #41 from David Nind --- Created attachment 141266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141266&action=edit Bug 31503: Change usermenu condition Test plan: Check if you see Consents tab depending on GDPR_Policy or having PATRON_CONSENT authorised values. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:15:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 14:15:02 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141220|0 |1 is obsolete| | --- Comment #42 from David Nind --- Created attachment 141267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141267&action=edit Bug 31503: Add $av_cat->values Test plan: Run t/db_dependent/AuthorisedValues.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:15:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 14:15:08 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141221|0 |1 is obsolete| | --- Comment #43 from David Nind --- Created attachment 141268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141268&action=edit Bug 31503: Make opac-patron-consent more generic We now allow multiple consent types as defined under AV (read: authorised values) category 'PATRON_CONSENT'. The description is used on the form too. This is the base patch for multiple consents. We can do some more polishing on a follow-up or another report even. Note: the alert for GDPR was moved to the description. Test plan: First check the form without any PATRON_CONSENT values in AV. Toggle the value of pref GDPR_Policy. Now add GDPR_PROCESSING and another one (e.g. NEWSLETTER). Refresh the OPAC form. Verify that you can toggle consent/dissent and that everything is saved correctly. Note only a real change updates the timestamp. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:15:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 14:15:14 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141222|0 |1 is obsolete| | --- Comment #44 from David Nind --- Created attachment 141269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141269&action=edit Bug 31503: Configurable consent text Although I planned to implement this via Additional contents (AC), I am using the AV description here after all, since AC does not yet provide enough flexibility. The title on the consents page is constructed from the consent type now still, and the description is from the OPAC description in AV (PATRON_CONSENT). Note: AV allows you to add html in the description, although it was not meant to do so. When we switch to AC later, we will have the possibility of html, languages, title and content. Second note: We still need AV translations too. See Bugzilla. Test plan: [1] Add a NEWSLETTER value under AV category PATRON_CONSENT. [2] Add no OPAC description. Save. Hit OPAC consents page. [3] Add description. Check page again. [4] Add html to description. Check again. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:23:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 14:23:20 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #45 from David Nind --- Testing notes (using KTD). The only thing I noted was: 1. If there is no GPPR_PROCESSING authorized value for PATRON_CONSENT, then in the OPAC > your consents the text displayed is "Consent for GDPR_PROCESSING" with Yes and No options. 2. If a GPR_PROCESSING authorized value is added without any descriptions, then the text in [1] is displayed. 3. Is that text editable, or is that just a default that should be changed/customised by updating the descriptions? My attemopt at a consolidated test plan: 1. Apply patches. 2. Update database. 3. Restart all the things (flush_memcached and restart_all). 4. Run the tests - these should pass: - prove t/db_dependent/Koha/Patron.t - prove t/db_dependent/AuthorisedValues.t 5. Enable the GDPR_Policy system preference and test (add any URL for PrivacyPolicyURL system preference, test with enforced and permissive options): - Go to the OPAC - Log in - You are prompted (under your consents) to "Consent for GDPR_PROCESSING" - Answer Yes - Response is "Your consent was registered on [Date/time stamp] - Change consent to No - Response is "We registered that you did not consent on [Date/time stamp]" 6. Disable the GDPR_Policy system preference - check that there is no "your consents" section link for your account (note that there is still a page that is accessible if you access http://127.0.0.1:8080/cgi-bin/koha/opac-patron-consent.pl - but that you can't do anything and the Save button is disabled). 7. Re-enable the GDPR_Policy system preference - check that there is now a "your consents" section for your account. The previous consent should be shown. 8. Check for the new authorized value category PATRON_CONSENT. Note: Without any values, "Consent for GDPR_PROCESSING" is the only option under your account > your consents in the OPAC. 9. Add GDPR_PROCESSING without a Description or Description (OPAC). 10. Refresh the OPAC form. 11. Verify that you can toggle consent/dissent and that everything is saved correctly: - Note that only a real change updates the timestamp. - Note the text displayed for the consent [1]. 12. Add a NEWSLETTER value under the authorized value category PATRON_CONSENT without any descriptions. 13. Add a Description. Save. Refresh the OPAC consents page. 14. Add a Description (OPAC). Refresh and check the OPAC consents page again. 15. Add HTML to the OPAC description. Refresh and check the OPAC consents page again. For example: This is some text for the newsletter consent to
display in the OPAC. 16. Verify that you can toggle consent/dissent for the NEWSLETTER and that everything is saved correctly. [1] Text displayed for GDPR_PROCESSING authorized value if no text enterted into Description or Description (OPAC) in the PATRON_CONSENT authorized values. Consent for GDPR_PROCESSING Please read the privacy policy. [privacy policy is linked to page URL set in PrivacyPolicyURL] In order to keep you logged in, we need your consent to process personal data as specified in the EU General Data Protection Regulation of May 25, 2018. If you would not agree, we will need to remove your account within a reasonable time. Do you agree with our processing of your personal data as outlined in the policy? Yes No -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:25:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 14:25:11 +0000 Subject: [Koha-bugs] [Bug 31663] Item not showing transit status on detail page in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31663 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:52:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 14:52:21 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:52:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 14:52:26 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #77 from Peter Vashchuk --- Created attachment 141270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141270&action=edit Bug 25711: (QA follow-up) Remove leftover code and fix atomic update This patch finalizes another one which deprecates ExpireReservesMaxPickUpDelayCharge. Because we had multiple smart-rules with undefined "expire_reserves_charge" values, this patch updates actomic update to set not only the general All/All smart-rule row to deprecated ExpireReservesMaxPickUpDelayCharge value but also every smart-rule that fall back to default value in "expire_reserves_charge". Also removed additional leftovers in template which earlier expected to show hyperlink to syspref ExpireReservesMaxPickUpDelay. To check if atomic update functions correctly: 1) Go to syspref and set ExpireReservesMaxPickUpDelay as "allow", set ExpireReservesMaxPickUpDelayCharge to some numerical value (that will be your default value), for example "42". 2) Go to smart rules page and create three rules: a rule with empty "Expire reserve charge" value, then create another one rule with "Expire reserve charge" vaue "0", and then another rule with "Expire reserve charge" value set to any number, for example "12". 3) Apply the patch, and run the atomic update via the installer page. 4) Return to the smart rules page and check those rules you created in step 2: - That one rule that you set as empty, now should have "Expire reserve charge" equal 42, i.e. that one you set to the value you set ExpireReservesMaxPickUpDelayCharge in step 1. - All rules that had numerical values set previously should have been exist untouched. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:52:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 14:52:28 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- I think while it's faster, for the UX it's a regression :( Before this patch: The budget is used as top level entry and the funds show below it. This made it really easy to navigate even a long list here for libraries with various open/inactive budgets. Also the pull down stretched to accomodate longer entries. I actually liked this pull down best of all the ones we have (we should be more consistent there..) With the patch: On the sample data now even the short fund names are cut off. The budget level is missing, making orientation much harder. There are also some strange line breaks in the code: + > -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:55:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 14:55:45 +0000 Subject: [Koha-bugs] [Bug 31500] Add ability to specify MaxReservesPickupDelay at the patron category level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31500 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:57:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 14:57:08 +0000 Subject: [Koha-bugs] [Bug 30304] Reindent lists template in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass --- These changes look good. The diff is is good. I also checked this through the W3 HTML validator. There is some warnings that are new to me: "Self-closing tag syntax in text/html documents is widely discouraged; it’s unnecessary and interacts badly with other HTML features" If we need to change the self ending tags I think we should do so in a separate bug report. Or maybe, since it is a warning, it is not necessary to address? Either way, I am passing QA on this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:58:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 14:58:57 +0000 Subject: [Koha-bugs] [Bug 30304] Reindent lists template in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:59:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 14:59:00 +0000 Subject: [Koha-bugs] [Bug 30304] Reindent lists template in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140395|0 |1 is obsolete| | --- Comment #8 from Lucas Gass --- Created attachment 141271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141271&action=edit Bug 30304: Reindent lists template in the staff interface This patch performs general template cleanup to the lists template: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and test all aspects of the lists pages, including: - Viewing the list of public and private lists. - List of lists DataTable controls: Paging, filtering, sorting. - Add, edit and delete lists. - View list contents. - Remove titles from a list. - Place hold from a list. - Add items to a list. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag. The only changes you see should be split lines. Signed-off-by: Katrin Fischer Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:59:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 14:59:05 +0000 Subject: [Koha-bugs] [Bug 30304] Reindent lists template in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140396|0 |1 is obsolete| | --- Comment #9 from Lucas Gass --- Created attachment 141272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141272&action=edit Bug 30304: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Katrin Fischer Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:03:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:03:11 +0000 Subject: [Koha-bugs] [Bug 31500] Add ability to specify MaxReservesPickupDelay at the patron category level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31500 --- Comment #7 from Katrin Fischer --- (In reply to Andrew Fuerste-Henry from comment #6) > Signed off because it works as described. See my note about the highlighting > on the syspref name on /cgi-bin/koha/admin/categories.pl. > > Also, I don't love the wording change on the Holds Awaiting Pickup page. > Where it used to say "Holds waiting over X days" (where X is the value of > MaxReservesPickupDelay). Now it says "Holds waiting over passed pickup > date." I like the change to not give a number, since there is no longer an > assumption of one accurate value. But that phrase is messy. > > Maybe just "Holds waiting past pickup date"? I'll provide a follow-up with that change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:07:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:07:24 +0000 Subject: [Koha-bugs] [Bug 19309] Add ReservesMaxPickUpDelay to the Circulation Matrix In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19309 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31500 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:07:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:07:24 +0000 Subject: [Koha-bugs] [Bug 31500] Add ability to specify MaxReservesPickupDelay at the patron category level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31500 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19309 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:14:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:14:11 +0000 Subject: [Koha-bugs] [Bug 30309] Convert lists tabs in the staff interface to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30309 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #3 from Lucas Gass --- Changes all look good. QA script is happy. HTML all appears to be valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:14:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:14:30 +0000 Subject: [Koha-bugs] [Bug 19309] Add ReservesMaxPickUpDelay to the Circulation Matrix In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19309 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #3 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 8367 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:14:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:14:30 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com --- Comment #188 from Katrin Fischer --- *** Bug 19309 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:15:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:15:07 +0000 Subject: [Koha-bugs] [Bug 30309] Convert lists tabs in the staff interface to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30309 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:15:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:15:12 +0000 Subject: [Koha-bugs] [Bug 30309] Convert lists tabs in the staff interface to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30309 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140394|0 |1 is obsolete| | --- Comment #4 from Lucas Gass --- Created attachment 141273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141273&action=edit Bug 30309: Convert lists tabs in the staff interface to Bootstrap This patch updates the staff interface lists page to use Bootstrap tabs instead of jQueryUI. To test, apply the patch and go to Lists. - Test that the public and private tabs work correctly. - Test that other lists functionality still works as expected. - Confirm that adding the "public" URL parameter works to trigger the "Public lists" tab by default: /cgi-bin/koha/virtualshelves/shelves.pl?public=1 Signed-off-by: Katrin Fischer Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:21:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:21:57 +0000 Subject: [Koha-bugs] [Bug 31500] Add ability to specify MaxReservesPickupDelay at the patron category level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31500 --- Comment #8 from Katrin Fischer --- Ok, I will hold off providing the follow-up for now, because I think we should discuss the concept first: To me, this feels not right on patron category level, I feel like it should be in in the circulation rules instead. So I did some research: 1) There are patches to move ExpireReservesMaxPickUpDelayCharge to circulation rules, which would fit well together with the pickup delay: * bug 25711 - ExpireReservesMaxPickUpDelayCharge (NSO) 2) There have been several bugs filed in present and past about moving the pickup delay to the circulation rules: * bug 19309 - ReservesMaxPickUpDelay (marked duplicate) Which argues: Some libraries would love to have the option to specify the ReservesMaxPickUpDelay by itemtype, rather than specify the ReservesMaxPickUpDelay for all items via the system preference. There are times when specific item types like popular or new items, DVD's or even Museum passes may not want to sit on a shelf for 7 days waiting for the patron to pick it up. Versus a non popular item that can wait for 7 days for the patron to pick the item up. A use case I'd add is academic libraries with closed stacks where you might want to give a longer pickup-period before you return the items to the shelf. And actually we have a competing bug with patches! * bug 8367 - How long is a hold waiting for pickup at a more granular level (FQA) I'd love if we could push the solution on bug 8367 instead of the patron category based solution. We could say: we can do that later... BUT: there is no migration path. If we start with category level, we won't be able to populate values in the circulation rules later because of the * (all) rules. So I think this would be an argument for going circulation rules right away. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:22:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:22:11 +0000 Subject: [Koha-bugs] [Bug 31500] Add ability to specify MaxReservesPickupDelay at the patron category level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31500 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:25:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:25:19 +0000 Subject: [Koha-bugs] [Bug 31500] Add ability to specify MaxReservesPickupDelay at the patron category level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31500 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8367 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:25:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:25:19 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31500 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:35:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:35:42 +0000 Subject: [Koha-bugs] [Bug 31500] Add ability to specify MaxReservesPickupDelay at the patron category level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31500 --- Comment #9 from Andrew Fuerste-Henry --- Chiming in that I'm at one of those libraries that would really love to set pickup delay per itype rather than per patron category. I signed off on this because it seemed abstractly useful, but would rather not move forward here if it will make it harder to get itype distinctions working later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:41:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:41:35 +0000 Subject: [Koha-bugs] [Bug 22115] Table of checkouts doesn't respect CurrencyFormat setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22115 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:41:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:41:38 +0000 Subject: [Koha-bugs] [Bug 22115] Table of checkouts doesn't respect CurrencyFormat setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22115 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:41:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:41:41 +0000 Subject: [Koha-bugs] [Bug 23063] Item table in cataloguing doesn't respect CurrencyFormat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23063 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:41:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:41:43 +0000 Subject: [Koha-bugs] [Bug 23063] Item table in cataloguing doesn't respect CurrencyFormat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23063 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:41:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:41:46 +0000 Subject: [Koha-bugs] [Bug 23538] Email library when new patrons self register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)|22.11.00 |22.11.00,22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:41:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:41:49 +0000 Subject: [Koha-bugs] [Bug 23538] Email library when new patrons self register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #40 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:41:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:41:52 +0000 Subject: [Koha-bugs] [Bug 30304] Reindent lists template in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:41:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:41:54 +0000 Subject: [Koha-bugs] [Bug 30304] Reindent lists template in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:41:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:41:57 +0000 Subject: [Koha-bugs] [Bug 30309] Convert lists tabs in the staff interface to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30309 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:42:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:42:00 +0000 Subject: [Koha-bugs] [Bug 30309] Convert lists tabs in the staff interface to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30309 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:42:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:42:03 +0000 Subject: [Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:42:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:42:06 +0000 Subject: [Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #21 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:42:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:42:09 +0000 Subject: [Koha-bugs] [Bug 31402] Update tools sidebar to match tools start page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:42:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:42:12 +0000 Subject: [Koha-bugs] [Bug 31402] Update tools sidebar to match tools start page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31402 --- Comment #12 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:42:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:42:14 +0000 Subject: [Koha-bugs] [Bug 31559] Staff results page doesn't always use up full available screen width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31559 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:42:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:42:14 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:42:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:42:19 +0000 Subject: [Koha-bugs] [Bug 31559] Staff results page doesn't always use up full available screen width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31559 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:42:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:42:23 +0000 Subject: [Koha-bugs] [Bug 31593] Remove Test::DBIx::Class from Context.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31593 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:42:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:42:25 +0000 Subject: [Koha-bugs] [Bug 31593] Remove Test::DBIx::Class from Context.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31593 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:42:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:42:28 +0000 Subject: [Koha-bugs] [Bug 31625] Reindent tools home and tools sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:42:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:42:31 +0000 Subject: [Koha-bugs] [Bug 31625] Reindent tools home and tools sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:42:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:42:34 +0000 Subject: [Koha-bugs] [Bug 31663] Item not showing transit status on detail page in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31663 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:42:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:42:37 +0000 Subject: [Koha-bugs] [Bug 31663] Item not showing transit status on detail page in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31663 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:42:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:42:45 +0000 Subject: [Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 Marie-Luce Laflamme changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme at inlibro | |.com --- Comment #13 from Marie-Luce Laflamme --- The IntranetUserJS syspref work around isn't working in Koha 22.05+ version. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:43:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:43:07 +0000 Subject: [Koha-bugs] [Bug 23538] Email library when new patrons self register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,22.11.00 |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:47:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:47:02 +0000 Subject: [Koha-bugs] [Bug 20457] Overdue and pre-overdue cronjobs not skipping phone notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20457 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:48:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:48:41 +0000 Subject: [Koha-bugs] [Bug 31500] Add ability to specify MaxReservesPickupDelay at the patron category level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31500 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca --- Comment #10 from Agnes Rivers-Moore --- Agreed, for my libraries, bug 8367 pickup delay by item type is the priority. Also I would prefer to keep this as a separate table in circ rules, not included in the large matrix which is already unwieldy, complicated and easy to make mistakes on. How about adding pickup delay to Default reserves policy by item type - is that possible? Likewise for "Default checkout, hold policy by patron category" for those who do want to set pickup by patron type. Those would have to be mutually exclusive - each library would need to choose only one or the other, to avoid conflicting rules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:52:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:52:33 +0000 Subject: [Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:52:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:52:49 +0000 Subject: [Koha-bugs] [Bug 31671] New: Add a "Print transfer slip" button to /cgi-bin/koha/circ/branchtransfers.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31671 Bug ID: 31671 Summary: Add a "Print transfer slip" button to /cgi-bin/koha/circ/branchtransfers.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be handy if you could print a transfer slip from the Transfer items page without having to navigate to another page to print the slip. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:59:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:59:49 +0000 Subject: [Koha-bugs] [Bug 14149] Labels: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14149 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Caroline Cyr La Rose --- *** This bug has been marked as a duplicate of bug 10762 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:59:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 15:59:49 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger at foundations.ed | |u --- Comment #14 from Caroline Cyr La Rose --- *** Bug 14149 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:07:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:07:39 +0000 Subject: [Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:13:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:13:23 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #11 from Martin Renvoize --- Thanks for the comprehensive testing David. It appears some of the confirmation code got lost during rebases.. I've fixed that now and will upload an updated patchset soon. You've also highlighted lots of cases where I've not yet fully dealt with error conditions.. I'll work through those now too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:24:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:24:54 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139131|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 141274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141274&action=edit Bug 30979: Add 'OpacTrustedCheckout' preference This patch adds a new 'OpacTrustedCheckout' system preference to govern whether the library allows opac users to check out items to themselves from their OPAC login. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:24:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:24:58 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139132|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 141275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141275&action=edit Bug 30979: Add public items lookup route This patch adds a /public equivilent to the item listing endpoint. This allows us to search for an item by it's external_id (barcode). Test plan 1. Apply patch 2. Perform a GET on /api/v1/public/items?external_id=some_barcode 3. Confirm that the above enpoint correctly returns items that should be visible in the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:25:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:25:03 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139133|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 141276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141276&action=edit Bug 30979: Checkout API's This patch adds an initial framework for adding/migrating AddIssue from C4::Circulation into Koha::Checkout... but that feels a bit over scope. Also.. should we do all the checks and return failure in Koha::REST::V1::Checkout->add such that we require a new special header for the equivilent of 'confirm' in the controller script route.. Should we accept an external_id in the checkout add route.. or chain two ajax requests such that the first looks up the item from it's external_id and then the second calls checkout upon it? Should we have a 'CanBookBeIssued' equivilent on the API? Bug 30979: Add confirmation token to API This patch adds the creation of a confirmation token to the get_availability method and then adds a test for the presence of that same token later in the checkout routine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:25:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:25:09 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139134|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 141277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141277&action=edit Bug 30979: Add checkout modal to the OPAC This patch adds a new self checkout modal to the OPAC when OpacTrustedCheckout is enabled and a user is logged in. The new modal allows an end user to scan an item barcode, check for item existance and availability and then check the item out after any confirmations have been displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:25:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:25:14 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #16 from Martin Renvoize --- Created attachment 141278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141278&action=edit Bug 30979: Fix inconsistent return of AddIssue AddIssue can on occasion create a renewal instead of a fresh issue and in such a case we currently return undefined. We should be consistent and return the existing issue object for the renewal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:25:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:25:18 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #17 from Martin Renvoize --- Created attachment 141279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141279&action=edit Bug 30979: Handle more failure cases -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:29:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:29:25 +0000 Subject: [Koha-bugs] [Bug 31625] Reindent tools home and tools sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31625 --- Comment #11 from Martin Renvoize --- Was about to say I rebased this morning so we're all good to push.. then I spotted Tomas already had.. hehe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:34:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:34:25 +0000 Subject: [Koha-bugs] [Bug 20457] Overdue and pre-overdue cronjobs not skipping phone notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20457 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:34:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:34:31 +0000 Subject: [Koha-bugs] [Bug 20457] Overdue and pre-overdue cronjobs not skipping phone notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20457 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140213|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 141280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141280&action=edit Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices The overdue and pre-overdue cron scripts are not skipping the generation of phone notices. This causes many phone notices to be created that will always be left at 'pending' as the Talking Tech outbound script creates its own phone notices and puts them in the message queue. Test Plan: 1) Enable Talking Tech 2) Enable predue and overdue notice phone transports for a patron 3) Generate overdues and predues, notice phone notices are generated 4) Apply the patch 5) Repeat steps 2-3 6) Note phone notices are not generated Signed-off-by: Joonas Kylmälä Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:35:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:35:46 +0000 Subject: [Koha-bugs] [Bug 23538] Email library when new patrons self register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 --- Comment #41 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #39) > Tomas: Last patch only please. Thank you, Marcel. Good job! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:38:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:38:16 +0000 Subject: [Koha-bugs] [Bug 31657] [DOCS] [Omnibus] Fix the cause of duplicate label warning messages when generating the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31657 --- Comment #9 from Caroline Cyr La Rose --- (In reply to Caroline Cyr La Rose from comment #7) > A note to remember that we'll have to change the rst syntax cheatsheet on > the wiki This is done -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:40:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:40:10 +0000 Subject: [Koha-bugs] [Bug 31658] Update conf.py to remove sphinx.ext.autosectionlabel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31658 --- Comment #3 from Caroline Cyr La Rose --- I created a merge request for this! https://gitlab.com/koha-community/koha-manual/-/merge_requests/593 I tried to build a manual with all my latest changes and there are only two warnings left, both in the valuebuilder chapter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:41:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:41:25 +0000 Subject: [Koha-bugs] [Bug 31672] New: Remove 'Your' from tab descriptions in OPAC patron account Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31672 Bug ID: 31672 Summary: Remove 'Your' from tab descriptions in OPAC patron account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:41:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:41:32 +0000 Subject: [Koha-bugs] [Bug 31672] Remove 'Your' from tab descriptions in OPAC patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31672 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:41:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:41:50 +0000 Subject: [Koha-bugs] [Bug 31672] Remove 'Your' from tab descriptions in OPAC patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31672 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:51:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:51:49 +0000 Subject: [Koha-bugs] [Bug 31672] Remove 'Your' from tab descriptions in OPAC patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31672 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:51:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:51:54 +0000 Subject: [Koha-bugs] [Bug 31672] Remove 'Your' from tab descriptions in OPAC patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31672 --- Comment #1 from Katrin Fischer --- Created attachment 141281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141281&action=edit Bug 31672: Remove 'Your' from tab descriptions in OPAC patron account I'll try to keep the test plan simple: * Go to patron account in OPAC * Verify that the your from the beginning of the tab descriptions has been removed Bonus: This moves the Recalls history tab below the Holds history as this is the more logical place for it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:52:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:52:46 +0000 Subject: [Koha-bugs] [Bug 31672] Remove 'Your' from tab descriptions in OPAC patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31672 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:53:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:53:06 +0000 Subject: [Koha-bugs] [Bug 29196] Follow-up to Bug 27068 - Remove unnecessary check In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29196 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:53:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:53:08 +0000 Subject: [Koha-bugs] [Bug 29196] Follow-up to Bug 27068 - Remove unnecessary check In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29196 --- Comment #12 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:53:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:53:11 +0000 Subject: [Koha-bugs] [Bug 30944] Fix single cancel recall button in recalls tab in staff interface and correctly handle cancellations with branch transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:53:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:53:14 +0000 Subject: [Koha-bugs] [Bug 30944] Fix single cancel recall button in recalls tab in staff interface and correctly handle cancellations with branch transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:53:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:53:17 +0000 Subject: [Koha-bugs] [Bug 31234] SubfieldsToAllowForRestrictedEditing : data from drop-down menu not stored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:53:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:53:19 +0000 Subject: [Koha-bugs] [Bug 31234] SubfieldsToAllowForRestrictedEditing : data from drop-down menu not stored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:53:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:53:22 +0000 Subject: [Koha-bugs] [Bug 31566] 'Patrons selected' counter doubles on 'Select all' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:53:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:53:25 +0000 Subject: [Koha-bugs] [Bug 31566] 'Patrons selected' counter doubles on 'Select all' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:53:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:53:27 +0000 Subject: [Koha-bugs] [Bug 31603] Add search option for plugin page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31603 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:53:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:53:31 +0000 Subject: [Koha-bugs] [Bug 31603] Add search option for plugin page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31603 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:53:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:53:34 +0000 Subject: [Koha-bugs] [Bug 31643] Link authorities automatically requires ALL cataloging and authorities permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31643 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:53:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:53:36 +0000 Subject: [Koha-bugs] [Bug 31643] Link authorities automatically requires ALL cataloging and authorities permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31643 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:58:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 16:58:16 +0000 Subject: [Koha-bugs] [Bug 31672] Remove 'Your' from tab descriptions in OPAC patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31672 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141281|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi --- Created attachment 141282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141282&action=edit Bug 31672: Remove 'Your' from tab descriptions in OPAC patron account I'll try to keep the test plan simple: * Go to patron account in OPAC * Verify that the your from the beginning of the tab descriptions has been removed Bonus: This moves the Recalls history tab below the Holds history as this is the more logical place for it. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:00:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:00:03 +0000 Subject: [Koha-bugs] [Bug 31672] Remove 'Your' from tab descriptions in OPAC patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31672 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:10:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:10:56 +0000 Subject: [Koha-bugs] [Bug 31633] Add home and holding data attributes to quick spine label print to help customizing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 141283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141283&action=edit Bug 31633: (follow-up) Group template params Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:14:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:14:30 +0000 Subject: [Koha-bugs] [Bug 20457] Overdue and pre-overdue cronjobs not skipping phone notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20457 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:14:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:14:33 +0000 Subject: [Koha-bugs] [Bug 20457] Overdue and pre-overdue cronjobs not skipping phone notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20457 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:14:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:14:36 +0000 Subject: [Koha-bugs] [Bug 29671] Dropbox mode is unchecked after check in confirm on item with Materials specified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:14:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:14:39 +0000 Subject: [Koha-bugs] [Bug 29671] Dropbox mode is unchecked after check in confirm on item with Materials specified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:14:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:14:42 +0000 Subject: [Koha-bugs] [Bug 30646] Add option to send WELCOME notice for new patrons added at first login via LDAP/SAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:14:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:14:46 +0000 Subject: [Koha-bugs] [Bug 30646] Add option to send WELCOME notice for new patrons added at first login via LDAP/SAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646 --- Comment #17 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:14:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:14:49 +0000 Subject: [Koha-bugs] [Bug 31633] Add home and holding data attributes to quick spine label print to help customizing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:14:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:14:51 +0000 Subject: [Koha-bugs] [Bug 31633] Add home and holding data attributes to quick spine label print to help customizing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 --- Comment #13 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:18:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:18:07 +0000 Subject: [Koha-bugs] [Bug 22322] Self-checkin module should provide for automatic logins (like self-checkout) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:20:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:20:18 +0000 Subject: [Koha-bugs] [Bug 22322] Self-checkin module should provide for automatic logins (like self-checkout) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer --- Hi Emmi, there are several problems highlighted by the QA tools, can you please fix? For fixing the filters there is a handy script: misc/devel/add_missing_filters.pl. FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-sco-self.inc FAIL filters missing_filter at line 7 ( ) missing_filter at line 7 ( ) missing_filter at line 31 ( [% opacheader %]) OK koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt FAIL filters missing_filter at line 486 ( [% checkinmessage %]) missing_filter at line 589 ( if ( (Date.now() - confirmStart) < [% SelfCheckTimeout %] ) {) missing_filter at line 590 ( window.open("/cgi-bin/koha/sco/printslip.pl?borrowernumber=[% borrowernumber %]&print=qslip");) FAIL opac/sco/sco-main.pl FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). FAIL forbidden patterns forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error (bug 24663) (line 79) forbidden pattern: Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) (line 135) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:29:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:29:34 +0000 Subject: [Koha-bugs] [Bug 7960] Choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 --- Comment #27 from Katrin Fischer --- Just realized that I tested this for the first time in 2017... ouch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:30:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:30:07 +0000 Subject: [Koha-bugs] [Bug 7960] Choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:30:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:30:13 +0000 Subject: [Koha-bugs] [Bug 7960] Choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140237|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer --- Created attachment 141284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141284&action=edit Bug 7960: Add class to item type descriptions so they can be hidden with CSS This patch adds the class "itypetext" around item type descriptions so they can easily be hidden with CSS. To test: 1. Navigate to the pages listed below to confirm that the text descriptions do show. 2. Add .itypetext { display:none; } to IntranetUserCSS and OPACUserCSS system preferences and save. 3. Go back to the pages listed below and confirm that the text descriptions DO NOT show. = STAFF CLIENT = - catalogue/advsearch.tt - catalogue/detail.tt - catalogue/results.tt - reserve/request.tt - virtualshelves/shelves.tt = OPAC = - opac-advsearch.tt - opac-detail.tt - opac-readingrecord.tt - opac-reserve.tt - opac-shelves.tt - opac-user.tt Refer to David Nind's test notes from Comment 23 for a more detailed plan for acessing these pages. Sponsored-by: Catalyst IT Signed-off-by: Charles Farmer Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:33:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:33:23 +0000 Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup locations are available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |tomascohen at gmail.com --- Comment #16 from Tomás Cohen Arazi --- (In reply to Julian Maurice from comment #15) > I tried to solve the same issue but fixed it differently (I didn't know > about this bug report until now) > I tested this bug's patches and it doesn't work for me. Please FQA in such cases. > Should I submit my patch in another bug report (as this one is already > Passed QA) ? I'd say you should attach your patch here for other devs review in context (test plan, etc). Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:36:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:36:05 +0000 Subject: [Koha-bugs] [Bug 31548] OpacMainUserBlock not properly preserved during upgrade - no more reachable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31548 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- (In reply to Hans Ulrich Frink from comment #2) > thanks Katrin for your reply. > We solved our problem by reinstalling the whole koha and importing our data > into the new empty mysql db. just running the upgrade on the existing > installation did NOT work. That was the reason to file the bug. I think the > upgrade process does not adress the changed field structure from "news" to > "html" properly. > I wonder how other users worked around this. In general it does address it, but we had some issues that have been fixed since. I am glad it works for you now, but usually that step should not be necessary. When you update, always keep an eye out for any error messages from the update script. Would also have been interesting to see what structure you ended up with. (INVALID is a compromise - I think won't be able to fix that for this old version now with the information we have, but it is a valid report. WORKSFORME or FIXED also didn't fit) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:37:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:37:07 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:37:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:37:11 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 --- Comment #25 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:37:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:37:14 +0000 Subject: [Koha-bugs] [Bug 31586] Log basket number as object when an email order is sent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31586 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:37:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:37:17 +0000 Subject: [Koha-bugs] [Bug 31586] Log basket number as object when an email order is sent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31586 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:37:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:37:20 +0000 Subject: [Koha-bugs] [Bug 31634] Add part_number and part_name in OPAC result browser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31634 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:37:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:37:23 +0000 Subject: [Koha-bugs] [Bug 31634] Add part_number and part_name in OPAC result browser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31634 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:40:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:40:53 +0000 Subject: [Koha-bugs] [Bug 28186] Use Koha::Authority in C4::AuthoritiesMarc::AddAuthority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28186 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:49:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:49:59 +0000 Subject: [Koha-bugs] [Bug 28186] Use Koha::Authority in C4::AuthoritiesMarc::AddAuthority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28186 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:50:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:50:04 +0000 Subject: [Koha-bugs] [Bug 28186] Use Koha::Authority in C4::AuthoritiesMarc::AddAuthority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28186 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140323|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 141285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141285&action=edit Bug 28186: Use Koha::Authority in C4::AuthoritiesMarc::AddAuthority This patch replaces the use of $dbh->do by corresponding use of Koha::Authority object Test plan: 1. Verify that creating/modifying authority still work 2. prove t/db_dependent/AuthoritiesMarc.t Signed-off-by: Joonas Kylmälä Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:50:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:50:49 +0000 Subject: [Koha-bugs] [Bug 31372] Value builder for UNIMARC field 325 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31372 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:57:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 17:57:51 +0000 Subject: [Koha-bugs] [Bug 31619] Cannot select title when setting non-default value for OPACSuggestionMandatoryFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Galen Charlton --- (In reply to Marcel de Rooy from comment #6) > Thanks for your patch, Galen. > Note that title does not belong to biblioitems, but to biblio. The patch adds an entry for "title" as a column in the suggestions table, not biblio nor biblioitems. > And that the pref explains that title is always mandatory and therefore not > listed. You cannot deselect it. > So we either skip this change or move the explanation to the popup form > somehow? Without the patch, any attempt to change the value of OPACSuggestionMandatoryFields to a non-default value will cause the title to not be marked as required; the "title" field is not permanently considered required by the code that reads the value of the system preference unless that preference value is blank. Setting status back to signed off and requesting re-review. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 20:01:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 18:01:42 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Attachment #141095|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 20:03:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 18:03:25 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 20:09:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 18:09:24 +0000 Subject: [Koha-bugs] [Bug 7960] Choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Patch doesn't apply --- Comment #29 from Tomás Cohen Arazi --- Please rebase ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 20:14:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 18:14:45 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 20:14:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 18:14:49 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 --- Comment #83 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 20:14:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 18:14:52 +0000 Subject: [Koha-bugs] [Bug 28186] Use Koha::Authority in C4::AuthoritiesMarc::AddAuthority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28186 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 20:14:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 18:14:54 +0000 Subject: [Koha-bugs] [Bug 28186] Use Koha::Authority in C4::AuthoritiesMarc::AddAuthority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28186 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 20:14:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 18:14:58 +0000 Subject: [Koha-bugs] [Bug 31660] MARC preview for authority search results comes up empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31660 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 20:15:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 18:15:00 +0000 Subject: [Koha-bugs] [Bug 31660] MARC preview for authority search results comes up empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31660 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 20:19:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 18:19:14 +0000 Subject: [Koha-bugs] [Bug 8328] Max checkouts per time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8328 hebah at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 20:24:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 18:24:24 +0000 Subject: [Koha-bugs] [Bug 7960] Choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141284|0 |1 is obsolete| | --- Comment #30 from Katrin Fischer --- Created attachment 141286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141286&action=edit Bug 7960: Add class to item type descriptions so they can be hidden with CSS This patch adds the class "itypetext" around item type descriptions so they can easily be hidden with CSS. To test: 1. Navigate to the pages listed below to confirm that the text descriptions do show. 2. Add .itypetext { display:none; } to IntranetUserCSS and OPACUserCSS system preferences and save. 3. Go back to the pages listed below and confirm that the text descriptions DO NOT show. = STAFF CLIENT = - catalogue/advsearch.tt - catalogue/detail.tt - catalogue/results.tt - reserve/request.tt - virtualshelves/shelves.tt = OPAC = - opac-advsearch.tt - opac-detail.tt - opac-readingrecord.tt - opac-reserve.tt - opac-shelves.tt - opac-user.tt Refer to David Nind's test notes from Comment 23 for a more detailed plan for acessing these pages. Sponsored-by: Catalyst IT Signed-off-by: Charles Farmer Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 20:28:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 18:28:02 +0000 Subject: [Koha-bugs] [Bug 26648] Prevent internal server error if item attached to old checkout has been removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 20:28:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 18:28:06 +0000 Subject: [Koha-bugs] [Bug 26648] Prevent internal server error if item attached to old checkout has been removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648 --- Comment #10 from Lucas Gass --- Created attachment 141287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141287&action=edit Bug 26648: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 20:30:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 18:30:18 +0000 Subject: [Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26648 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648 [Bug 26648] Prevent internal server error if item attached to old checkout has been removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 20:30:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 18:30:18 +0000 Subject: [Koha-bugs] [Bug 26648] Prevent internal server error if item attached to old checkout has been removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31051 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 [Bug 31051] Show patron's 'savings' on the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 20:31:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 18:31:13 +0000 Subject: [Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #31 from Lucas Gass --- Aleisha, I think if we make this one dependent on Bug 26648 we can move it back to NSO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 20:48:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 18:48:13 +0000 Subject: [Koha-bugs] [Bug 31427] Automatic renewal too_many error is confusing in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427 rachel.rappaport at montgomerycountymd.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rachel.rappaport at montgomery | |countymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 21:19:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 19:19:15 +0000 Subject: [Koha-bugs] [Bug 29603] Fix responsive behavior of facets menu in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29603 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate CC| |victor at tuxayo.net --- Comment #12 from Victor Grousset/tuxayo --- Note, I got a request for oldoldstable (21.05.x) will try to backport when it will be in oldstable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 21:29:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 19:29:10 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #72 from Heather --- I'm late to this party, but I looked at the 3-column and 4-column screenshots, and, oh, wow, I want this SO MUCH!!! To me all these things have always been cataloging, and I have to pause and think, "Wait...that's under Tools...or Administration...or..." And to have a button to take me right to the Advanced Bib Editor?!? *squeeeeeee!!!* I understand waiting until the staff client redesign is done. I'm going to be in and out of the office for a while during October, but I *will* be devoting what attention I can give to this when I am at work. Thank you thank you thank you!! Signed, Real Cataloger h2. P.S. Typo in "Bug 31162: Fix help link on catalouging start page" should be "cataloguing.":) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 21:34:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 19:34:59 +0000 Subject: [Koha-bugs] [Bug 31372] Value builder for UNIMARC field 325 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31372 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #3 from Katrin Fischer --- Wondering: Maybe you'd like to add the value builders to the default frameworks in a new bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 21:40:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 19:40:16 +0000 Subject: [Koha-bugs] [Bug 31609] JavaScript error on Additional contents main page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #8 from Owen Leonard --- (In reply to Marcel de Rooy from comment #6) > The error is still present on the list view of Tools/Pages I don't see this. Could you please look again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 21:41:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 19:41:53 +0000 Subject: [Koha-bugs] [Bug 31372] Value builder for UNIMARC field 325 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31372 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 21:41:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 19:41:58 +0000 Subject: [Koha-bugs] [Bug 31372] Value builder for UNIMARC field 325 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31372 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140098|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 141288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141288&action=edit Bug 31372: Value builder for field 325 On page cataloging some plugins were added for subfields $h and $h from field $325 Test plan: 1)Go to Home > Cataloging > New record 2)Section 3 - field 325 : it contains lots of subfields (g, h, i, j...) 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $h and $j Signed-off-by: Thibault Keromnès Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 21:42:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 19:42:57 +0000 Subject: [Koha-bugs] [Bug 31372] Value builder for UNIMARC field 325 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31372 --- Comment #5 from Katrin Fischer --- Had a bit of a hard time getting a UNIMARC environment. I ended up installing with MARC21, dropping db, recreating db and running the web installer. Not perfect, but worked well enough to be able to test :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 21:44:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 19:44:59 +0000 Subject: [Koha-bugs] [Bug 31371] Value builder for UNIMARC field 283 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31371 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 21:56:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 19:56:10 +0000 Subject: [Koha-bugs] [Bug 31371] Value builder for UNIMARC field 283 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31371 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Medium patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 21:56:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 19:56:15 +0000 Subject: [Koha-bugs] [Bug 31371] Value builder for UNIMARC field 283 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31371 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140218|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 141289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141289&action=edit Bug 31371: Value builder for field 283 On page cataloging some plugins were added for subfields $2 and $a from field $283 Test plan: 1)Go to Home > Cataloging > New record 2)Section 2 - field 283 : it contains subfields $2, $6, $8 & $a 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $2 and $a Signed-off-by: Thibault Keromnès Signed-off-by: Katrin Fischer Current patch-complexity: Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 21:56:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 19:56:20 +0000 Subject: [Koha-bugs] [Bug 31371] Value builder for UNIMARC field 283 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31371 --- Comment #8 from Katrin Fischer --- Created attachment 141290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141290&action=edit Bug 31371: (QA follow-up) Capitalization fixes Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 22:04:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 20:04:11 +0000 Subject: [Koha-bugs] [Bug 31659] Add SMSAlertNumber to options in borrowers.primary_contact_method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31659 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 22:09:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 20:09:24 +0000 Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses patron's home library not holds pick up library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 22:13:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 20:13:33 +0000 Subject: [Koha-bugs] [Bug 30403] Update notforloan status also on check out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #6 from Katrin Fischer --- Missing the sign-off (line?) here, but also don't see a comment from testing. Please verify! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 23:08:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 21:08:39 +0000 Subject: [Koha-bugs] [Bug 31499] Add libhttp-tiny-perl 0.076 dependency for ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31499 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com --- Comment #14 from Arthur Suzuki --- likewise, bug was reverted on the 21.11.x branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 23:17:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 21:17:26 +0000 Subject: [Koha-bugs] [Bug 31536] Add UNIMARC framework plugin to fetch PPN from sudoc.fr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31536 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 23:26:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 21:26:22 +0000 Subject: [Koha-bugs] [Bug 31536] Add UNIMARC framework plugin to fetch PPN from sudoc.fr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31536 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 23:26:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 21:26:27 +0000 Subject: [Koha-bugs] [Bug 31536] Add UNIMARC framework plugin to fetch PPN from sudoc.fr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31536 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140414|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 141291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141291&action=edit Bug 31536: Add UNIMARC framework plugin to fetch PPN from sudoc.fr This plugin uses sudoc.fr webservices (isbn2ppn, issn2ppn, ean2ppn) to search a PPN using ISBN, ISSN or EAN as search criteria. The plugin expects than ISBN is in 010$a, ISSN is in 011$a and EAN is in 073$a. Test plan: 1. Configure the default MARC framework so that 009 uses this plugin (unimarc_field_009_ppn.pl) 2. Start creating a new bibliographic record 3. In the editor, write "0195141156" in the 010$a input, then move the focus out of the input (by pressing Tab, or clicking elsewhere on the page) The 009 field should be automatically filled with "06735209X" 4. Empty the 010$a input, then empty the 009 input 5. Write "2262-4694" in the 011$a input, then move the focus out of the input The 009 field should be automatically filled with "166197947" 6. Empty the 011$a input, then empty the 009 input 7. Write "9782070424597" in the 073$a input, then move the focus out of the input The 009 field should be automatically filled with "151662983" 8. Empty only the 009 field, keep the same value for 073$a and save the bibliographic record. 9. Edit the same record, you should have an empty 009 field and 073$a = "9782070424597". Click on the 009 field input, it should be automatically filled with "151662983" Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 23:30:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 21:30:02 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |ASSIGNED Keywords| |additional_work_needed --- Comment #26 from Tomás Cohen Arazi --- Hi Martin and Marcel. This broke the api/v1/patrons.t tests, which felt pretty trivial to fix by disabling the NotifyPasswordChange syspref on the tests but... ... it feels like patron creation shouldn't trigger the notice. So: can you please fix that? Tests for this little situation are welcome too. I can help tomorrow, but right now I've gotta call it a day. Thanks in advance! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:00:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:00:34 +0000 Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses patron's home library not holds pick up library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447 --- Comment #6 from Katrin Fischer --- The test plan is not complete, as also some other occurrences where changed: RESERVED [% IF ( RESERVED ) %]
  • Item [% getTitleMessageIteminfo | html %] ([% getBarcodeMessageIteminfo | html %]) has been on hold for [% resfirstname | html %] [% ressurname | html %] ([% rescardnumber | html %]) at [% Branches.GetName( resbranchcode ) | html %] since [% resreservedate | $KohaDates %]
  • [% END %] TRANSFERRED [% IF ( TRANSFERRED ) %]
  • Item [% getTitleMessageIteminfo | html %] ([% getBarcodeMessageIteminfo | html %]) is on hold for [% resfirstname | html %] [% ressurname | html %] ([% rescardnumber | html %]) and being transferred to [% Branches.GetName( resbranchcode ) | html %]
  • [% END %] PROCESSING [% IF ( PROCESSING ) %]
  • Item [% getTitleMessageIteminfo | html %] ([% getBarcodeMessageIteminfo | html %]) is being processed for [% resfirstname | html %] [% ressurname | html %] ([% rescardnumber | html %]) at [% Branches.GetName( resbranchcode ) | html %]
  • [% END %] In all cases the patron's home library makes no sense, but the hold's pick location does. It looks like resbranchcode is only used in templates. All circulation tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:01:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:01:23 +0000 Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses patron's home library not holds pick up library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:01:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:01:28 +0000 Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses patron's home library not holds pick up library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140338|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 141292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141292&action=edit Bug 31447: Use holds pick up branch in "Please confirm checkout" message When one tries to check out item which has hold in it, "Please confirm checkout" message uses patrons home library instead of holds pick up library. It would be more logical to use latter here. To test: 1. Find record with holds. 2. For first priority hold, change it's pick up library to differ from patrons homebranch if needed. 3. Check out records item for a different patron. => Note that notice reads: "Item ... has been on hold for ... at [patrons homebranch] since ...". 4. Apply this patch. 5. Repeat steps 2 and 3. => Notice should now read: "Item ... has been on hold for ... at [holds pick up branch] since ...". Sponsored-by: Koha-Suomi Oy Signed-off-by: Axelle Clarisse Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:11:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:11:02 +0000 Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses patron's home library not holds pick up library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master --- Comment #8 from Katrin Fischer --- I believe the fix is correct, but I am not sure how that escaped so long? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:12:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:12:26 +0000 Subject: [Koha-bugs] [Bug 30922] Make the "Relative's checkouts" table configurable by the table settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #10 from Lucas Gass --- Enhancment will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:12:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:12:57 +0000 Subject: [Koha-bugs] [Bug 31312] Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31312 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:12:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:12:57 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Bug 27272 depends on bug 31312, which changed state. Bug 31312 Summary: Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31312 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:13:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:13:56 +0000 Subject: [Koha-bugs] [Bug 30901] Add template method to be able to look up renewal data in Koha slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting --- Comment #20 from Lucas Gass --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:14:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:14:43 +0000 Subject: [Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #16 from Lucas Gass --- Enhancement will not be backported to 22.05.x unless requested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:14:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:14:44 +0000 Subject: [Koha-bugs] [Bug 27341] Performance 21.05 - Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27341 Bug 27341 depends on bug 27342, which changed state. Bug 27342 Summary: Improve readability and improvement of C4::Auth::get_template_and_user https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:17:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:17:52 +0000 Subject: [Koha-bugs] [Bug 31294] Article requests: Mandatory subfields in OPAC don't show they are required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #5 from Lucas Gass --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:18:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:18:49 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting --- Comment #190 from Lucas Gass --- Very nice improvement that will not be backported to 22.05.x :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:21:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:21:21 +0000 Subject: [Koha-bugs] [Bug 29662] PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 --- Comment #8 from Katrin Fischer --- Leaving a note for myself or another QA person: I could not see what broke the feature yet, but I can confirm that leaving it empty was meant to copy all the fields: >From bug 7412 that implemented the feature: By default, all subfields are prefilled when the PrefillItem syspref is on, unless you specify which fields you want to prefill in the SubfieldsToUseWhenPrefill syspref. With a value of "f u v", only the $f, $u and $v will be prefilled, for example. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:24:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:24:39 +0000 Subject: [Koha-bugs] [Bug 26632] BatchStageMarcRecords passes a random number to AddBiblioToBatch / AddAuthToBatch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26632 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #10 from Lucas Gass --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:27:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:27:17 +0000 Subject: [Koha-bugs] [Bug 19540] opac-reserve does not correctly warn of too_much reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19540 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | --- Comment #16 from Lucas Gass --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:30:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:30:11 +0000 Subject: [Koha-bugs] [Bug 31228] Fix Coce JavaScript to hide single-pixel cover images in both the staff client detail and results pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31228 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | --- Comment #17 from Lucas Gass --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:34:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:34:53 +0000 Subject: [Koha-bugs] [Bug 29782] Additional contents: Fix handling records without title or content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #15 from Lucas Gass --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:39:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:39:12 +0000 Subject: [Koha-bugs] [Bug 31222] DBIC queries for batch mod can be very large In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com --- Comment #17 from Lucas Gass --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:42:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:42:18 +0000 Subject: [Koha-bugs] [Bug 31654] Hide non-public libraries from MastheadLibraryPulldown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12242 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:42:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:42:18 +0000 Subject: [Koha-bugs] [Bug 12242] Allow hiding branches from the OPAC search pulldowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12242 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31654 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:42:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:42:58 +0000 Subject: [Koha-bugs] [Bug 31382] Cannot reach password reset page when password expired In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31382 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:43:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:43:25 +0000 Subject: [Koha-bugs] [Bug 31654] Hide non-public libraries from MastheadLibraryPulldown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 --- Comment #3 from David Cook --- This is something I'm interested in as well. I don't have time for it this week, but I could probably test/QA it next week. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:45:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:45:26 +0000 Subject: [Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel cover images in the OPAC lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #20 from Lucas Gass --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:47:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:47:03 +0000 Subject: [Koha-bugs] [Bug 30684] koha-* scripts --restart should start even when not running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30684 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #38 from Lucas Gass --- Enhancement will not be backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 00:50:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 22:50:39 +0000 Subject: [Koha-bugs] [Bug 30779] Do not need to remove items from import biblios marc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | --- Comment #10 from Lucas Gass --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 01:11:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2022 23:11:16 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 03:31:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 01:31:16 +0000 Subject: [Koha-bugs] [Bug 31646] Focus input by default when clicking on a dropdown field in the cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31646 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 03:31:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 01:31:21 +0000 Subject: [Koha-bugs] [Bug 31646] Focus input by default when clicking on a dropdown field in the cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31646 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141175|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia --- Created attachment 141293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141293&action=edit Bug 31646: Add Select2 focus to text search field To test: 1. Edit a biblio record 2. Go to tab 9 to find the item type MARC field 942$c 3. Click on the field to select an item type 4. Notice you have to click again on the search field to begin typing to search for your item type 5. Apply patch/clear browser cache 6. Try steps 2-3 again, the focus should now be on the search text field 7. Try another select2 dropdown on the same page like the 942$n ( Suppress in OPAC ), it should also default to the text search field. 8. Try other places in Koha that feature this kind of select2, like when placing hold. Note: Using $(document).on here instead of $(".select2").on becuase there are several instances where there are more than 1 select2 dropdown on a single page. This allows for the text search field to default each time you click on a different dropdown. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 03:48:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 01:48:49 +0000 Subject: [Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 --- Comment #39 from David Cook --- (In reply to Tomás Cohen Arazi from comment #38) > I think we need some more tests here, particularly for the 'staff_authorize' > and 'prepare_template', unless I'm missing something. I noticed at first > glance a subtle issue with __koha__user__ vs. __koha_user__ that is not > caught by the provided tests. Yep, can certainly do that, when I have some time. > It would be great (also) if you could perltidy some of this code. I usually > select the code I want to tidy, and just ctrl+k ctrl+f on VScode. Please do > it inline. Thanks! What's the issue? I think it passed the QA tools, so that should've pointed out any perltidy issues? Because I'm on Windows, I need to do all my editing within the Docker container, so no VScode for me. But it looks like KTD has a ":Tidy" command in Vim, so I could use that. But this is fresh code that I thought I was writing in accordance with the Koha Coding Guidelines? Do we need to update those or am I just out of date? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 05:35:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 03:35:11 +0000 Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 05:35:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 03:35:17 +0000 Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138236|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia --- Created attachment 141299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141299&action=edit Bug 31257: (follow-up) Fix display of PDF This patch rearranges the Qty and Document columns and shifts the vendor account number field lower to make room for address fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 05:36:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 03:36:30 +0000 Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 --- Comment #6 from Aleisha Amohia --- Thank you for your testing. I've left your signed off patch and attached a follow-up to address the two comments below. (In reply to David Nind from comment #4) > Created attachment 140645 [details] > Example PDF output - Document column is very narrow > > I've signed off, but noted that: > > 1. The Document column is very narrow and the Qty column is very wide. Could > this be fixed? Have attached an example. > Switched these around. > 2. I assume there is a limit on the number of lines for address fields, > otherwise it displays "funny". Shifted the account number field lower to make space for address fields. But yes if there are a lot of address lines then there will be overlap. > > Also, should the WIP patch be obsoleted? Yes! Have done so. Ready for testing please -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 08:37:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 06:37:25 +0000 Subject: [Koha-bugs] [Bug 22131] overdue_notice.pl and gather_print_notices.pl should honor letter.is_html In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22131 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #2 from Magnus Enger --- Is this a duplicate of bug 18325? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 09:02:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 07:02:01 +0000 Subject: [Koha-bugs] [Bug 31213] When performing a basic search with no results, repeat the search with term quoted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #15 from Fridolin Somers --- This is super great :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 09:02:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 07:02:15 +0000 Subject: [Koha-bugs] [Bug 31213] When performing a basic search with no results, repeat the search with term quoted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.05 |22.11.00,21.11.12,22.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 09:03:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 07:03:10 +0000 Subject: [Koha-bugs] [Bug 31213] When performing a basic search with no results, repeat the search with term quoted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11.12,22.05.05 |22.11.00,22.05.05,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 11:11:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 09:11:20 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 11:26:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 09:26:07 +0000 Subject: [Koha-bugs] [Bug 15786] Specify a default framework on a per-login basis In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15786 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|specify a default framework |Specify a default framework |on a per-login basis |on a per-login basis -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 11:31:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 09:31:38 +0000 Subject: [Koha-bugs] [Bug 15786] Specify a default framework on a per-login basis In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15786 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23111 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 11:31:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 09:31:38 +0000 Subject: [Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15786 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 11:40:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 09:40:49 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141279|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 141300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141300&action=edit Bug 30979: Handle more failure cases -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:09:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 10:09:05 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 --- Comment #27 from Martin Renvoize --- On it, good call for creations not sending the notice.. I didn't even consider that case, Doh! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 13:20:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 11:20:52 +0000 Subject: [Koha-bugs] [Bug 31635] Empty title for current result in opac results browser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 13:34:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 11:34:16 +0000 Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses patron's home library not holds pick up library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Failed QA --- Comment #9 from Tomás Cohen Arazi --- Hi, I've tracked the uses of this and * SCO * SIP * Illrequest they all really don't care about this. Which is good. I also read circulation.tt and was surprised this fix hadn't been requested years ago :-D Can you please add some regression tests? It is clear there are no tests for this particular situation, but it should be easy to build a test by copying any of the ones in Circulation.t and manually changing the status for each use case. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 13:39:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 11:39:48 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #46 from Marcel de Rooy --- (In reply to David Nind from comment #45) Thanks David! Great. > The only thing I noted was: > 1. If there is no GPPR_PROCESSING authorized value for PATRON_CONSENT, then > in the OPAC > your consents the text displayed is "Consent for > GDPR_PROCESSING" with Yes and No options. > 2. If a GPR_PROCESSING authorized value is added without any descriptions, > then the text in [1] is displayed. > 3. Is that text editable, or is that just a default that should be > changed/customised by updating the descriptions? You found a small flaw! I expected AV.GetByCode to return nothing when there is no description in authorised values. But it just returns the code you were looking for.. Will fix that now. The idea was: If there is no description, use the historic template text (not editable). Do you want to change, add something in AV. Or in Additional Contents on a follow-up report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 13:41:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 11:41:26 +0000 Subject: [Koha-bugs] [Bug 31635] Empty title for current result in opac results browser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 13:41:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 11:41:30 +0000 Subject: [Koha-bugs] [Bug 31635] Empty title for current result in opac results browser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 --- Comment #2 from Owen Leonard --- Created attachment 141301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141301&action=edit Bug 31635: Fix output of current title in OPAC browse results This patch makes a correction to the output of OPAC browse results. In the numbered result navigation links, a title tag on each navigation link should contain the title of the record. The link for the current title didn't include the title information in the title tag because it used the wrong template variables. To test, apply the patch and make sure OpacBrowseResults is enabled. - In OPAC, perform a search that will return multiple results. - View one of the results. - In the right-hand sidebar, click "Browse results." - In the list of numbered links at the top of the panel, hover your mouse over each link. They should each display a tooltip with "View record [title]" - Confirm that the current title in the list includes the correct tooltip. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 13:50:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 11:50:13 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #47 from Marcel de Rooy --- Created attachment 141302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141302&action=edit Bug 31503: (follow-up) Check return of GetByCode AV.GetByCode returns code when there is no description. So we should check the return. This patch also makes the use of the Do you agree-question a bit more consistent. No need to include it in the description. Test plan: Check the OPAC consents page when you have an AV description for a consent type and when you do not. For GDPR you should see the original GDPR text when there is no description. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 13:51:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 11:51:31 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #48 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #46) > (In reply to David Nind from comment #45) > > The idea was: If there is no description, use the historic template text > (not editable). Do you want to change, add something in AV. Or in Additional > Contents on a follow-up report. This only talks about GDPR. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 13:57:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 11:57:29 +0000 Subject: [Koha-bugs] [Bug 31609] JavaScript error on Additional contents main page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Marcel de Rooy --- (In reply to Owen Leonard from comment #8) > (In reply to Marcel de Rooy from comment #6) > > The error is still present on the list view of Tools/Pages > > I don't see this. Could you please look again? You need to hit Tools/Pages. The JS error is on the main page. Not the detail one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:00:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 12:00:49 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #49 from David Nind --- (In reply to Marcel de Rooy from comment #46) > The idea was: If there is no description, use the historic template text > (not editable). Do you want to change, add something in AV. Or in Additional > Contents on a follow-up report. Thanks Marcel! I wasn't sure exactly what was expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:09:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 12:09:37 +0000 Subject: [Koha-bugs] [Bug 31665] 952$d ( Date acquired ) no longer prefills with todays date when focused In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 --- Comment #1 from Marcel de Rooy --- I am seeing this in 21.11 too. Note that it is about focus of the text box. Clicking on the plugin control next to the text box does still update the field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:10:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 12:10:52 +0000 Subject: [Koha-bugs] [Bug 31665] 952$d ( Date acquired ) no longer prefills with todays date when focused In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 --- Comment #2 from Marcel de Rooy --- When you focus the field, the date popup comes up. If that would respond to Enter, it would already be helpful? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:11:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 12:11:12 +0000 Subject: [Koha-bugs] [Bug 31665] 952$d ( Date acquired ) no longer prefills with todays date when focused In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:21:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 12:21:14 +0000 Subject: [Koha-bugs] [Bug 31665] 952$d ( Date acquired ) no longer prefills with todays date when focused In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 --- Comment #3 from Marcel de Rooy --- How to categorize this bug might be hard too: If lots of items would not get a date anymore, a library might not consider this Minor anymore -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:25:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 12:25:36 +0000 Subject: [Koha-bugs] [Bug 31673] New: Bug 31086 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Bug ID: 31673 Summary: Bug 31086 Change sponsored?: --- Product: Koha Version: 22.05 Hardware: PC OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: mohamednofal909 at gmail.com QA Contact: testopia at bugs.koha-community.org Upgrade to 22.05.04.002 [14:07:01]: Bug 31086 - Do not allow null values in branchcodes for reserves ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change column 'branchcode': used in a foreign key constraint 'reserves_ibfk_4' at /usr/share/koha/lib/C4/Installer.pm line 739 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:28:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 12:28:20 +0000 Subject: [Koha-bugs] [Bug 31673] Bug 31086 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 mohamed changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:45:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 12:45:15 +0000 Subject: [Koha-bugs] [Bug 31420] Managing funds: Labels of statistic fields overlap with pull downs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31420 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:45:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 12:45:19 +0000 Subject: [Koha-bugs] [Bug 31420] Managing funds: Labels of statistic fields overlap with pull downs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31420 --- Comment #1 from Owen Leonard --- Created attachment 141303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141303&action=edit Bug 31420: Managing funds: Labels of statistic fields overlap with pull downs This patch removes some very old inline style attributes from the fund edit form. The "white-space" attribute prevented label text from naturally wrapping. To test, apply the patch and go to Administration -> Funds. - In the list of funds, click Actions -> Edit. - The the form, confirm that the text of the "Statistic" 1 and 2 labels wraps, not getting hidden by the associated select tags. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:48:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 12:48:32 +0000 Subject: [Koha-bugs] [Bug 26777] Give the user the option to display their patron card barcode from the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 15:06:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 13:06:06 +0000 Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 15:06:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 13:06:11 +0000 Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140644|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 141304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141304&action=edit Bug 31257: Add a new English 1 page layout to export basketgroup This patch adds a new English 1 page layout to be used when exporting a basketgroup as PDF. This has been modelled after an example PDF from another library system. To test: 1) Go to Koha Administration -> Libraries. Ensure Library A has an address, phone and fax. 2) Go to Koha Administration -> System preferences. Search for OrderPdfFormat. Set this to the new English 1-page layout option. 3) Go to Acquisitions. Use an existing vendor or create a new one. Ensure the vendor has a postal address, phone, fax and accout number. 4) Create a basket for this vendor. Add a few orders to the basket. 5) Close the basket and add it to a basket group of the same name. 6) Edit the basket group. Add an address in the delivery place, and a delivery comment. Check the box to close the basket group and Save. 7) Click the button to Export as PDF. 8) View the exported PDF. Confirm all of the information displayed is correct. 9) Reopen the basketgroup. Edit the details and remove the delivery place text. Re-close the basketgroup. 10) Repeat steps 7 and 8. Sponsored-by: Pymble Ladies' College Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 15:06:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 13:06:15 +0000 Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141299|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 141305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141305&action=edit Bug 31257: (follow-up) Fix display of PDF This patch rearranges the Qty and Document columns and shifts the vendor account number field lower to make room for address fields Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 15:07:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 13:07:24 +0000 Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 --- Comment #9 from David Nind --- Thanks Aleisha for updating. Have signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 15:07:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 13:07:56 +0000 Subject: [Koha-bugs] [Bug 19556] Added Content ISBN Does Not Match MARC 020 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19556 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.22 |master --- Comment #2 from Owen Leonard --- (In reply to John Yorio from comment #0) > Bug 15772 mentions > that Novelist can't interpret 10-digit ISBNs ending in X Not necessarily relevant to this bug report, but I don't think this is still the case. I can see Novelist content related to 10-digit ISBNs ending in X. https://search.myacpl.org/cgi-bin/koha/opac-detail.pl?biblionumber=6645 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 15:09:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 13:09:46 +0000 Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140645|0 |1 is obsolete| | --- Comment #10 from David Nind --- Comment on attachment 140645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140645 Example PDF output - Document column is very narrow Obsoleted as layout now updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 15:17:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 13:17:21 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 --- Comment #28 from Martin Renvoize --- Created attachment 141306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141306&action=edit Bug 25936: (follow-up) Fix ../api/v1/patrons.t Disable password change notifications for the api test to negate the need for setting up notices. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 15:17:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 13:17:30 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 --- Comment #29 from Martin Renvoize --- Created attachment 141307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141307&action=edit Bug 25936: (follow-up) Unit test for store This unit test confirms that we are not triggering the Password Change notification notice upon patron creations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 15:20:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 13:20:38 +0000 Subject: [Koha-bugs] [Bug 31658] Update conf.py to remove sphinx.ext.autosectionlabel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31658 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|david at davidnind.com |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED Status|ASSIGNED |RESOLVED Documentation| |Caroline Cyr La Rose contact| | --- Comment #4 from David Nind --- Thanks Caroline! Now merged, and no output errors when generating the manual! David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 15:21:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 13:21:18 +0000 Subject: [Koha-bugs] [Bug 31658] [DOCS] Update conf.py to remove sphinx.ext.autosectionlabel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31658 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update conf.py to remove |[DOCS] Update conf.py to |sphinx.ext.autosectionlabel |remove | |sphinx.ext.autosectionlabel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 15:26:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 13:26:21 +0000 Subject: [Koha-bugs] [Bug 31657] [DOCS] [Omnibus] Fix the cause of duplicate label warning messages when generating the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31657 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Documentation| |Merge requests 591 and 593 submission| | Resolution|--- |FIXED Documentation| |Katrin Fischer + Caroline contact| |Cyr La Rose --- Comment #10 from David Nind --- Woot! Thanks Katrin and Caroline for all your speedy work on updating all the refs and fixing the casue of error messages! The manual is now generated without any warning or other error messages! David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 15:26:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 13:26:21 +0000 Subject: [Koha-bugs] [Bug 31658] [DOCS] Update conf.py to remove sphinx.ext.autosectionlabel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31658 Bug 31658 depends on bug 31657, which changed state. Bug 31657 Summary: [DOCS] [Omnibus] Fix the cause of duplicate label warning messages when generating the manual https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31657 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 15:26:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 13:26:51 +0000 Subject: [Koha-bugs] [Bug 31657] [DOCS] Fix the cause of duplicate label warning messages when generating the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31657 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[DOCS] [Omnibus] Fix the |[DOCS] Fix the cause of |cause of duplicate label |duplicate label warning |warning messages when |messages when generating |generating the manual |the manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 15:38:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 13:38:24 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #50 from Marcel de Rooy --- >From IRC: [15:34] 28 has all good answers.. looks like you've thought about most of it and are planning them for a continuation in the tree of bugs.. [15:34] so don't let me comment block anything 🙂 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 16:03:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 14:03:30 +0000 Subject: [Koha-bugs] [Bug 24725] xgettext does not support (yet) ES template literals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24725 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 16:03:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 14:03:41 +0000 Subject: [Koha-bugs] [Bug 24725] xgettext does not support (yet) ES template literals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24725 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize at ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 16:03:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 14:03:54 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 16:36:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 14:36:22 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141261|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 141308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141308&action=edit Bug 31666: Add job progress bar to stage-marc-import.pl It would be nice if we had progress bars to indicate the progress of background jobs for scripts that utilize them. This patch implements a reusable bootstrap based progess bar. Test Plan: 1) Apply this patch 2) Stage a marc batch ( preferrably a large one to show the progress updating ) 3) Note the new progess bar, verify it functions correctly. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 16:36:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 14:36:27 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 --- Comment #6 from Martin Renvoize --- Created attachment 141309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141309&action=edit Bug 31666: (QA follow-up) Add filters Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 16:36:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 14:36:31 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 --- Comment #7 from Martin Renvoize --- Created attachment 141310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141310&action=edit Bug 31666: (QA follow-up) Remove ES template literals Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 16:38:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 14:38:15 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- I found this difficult to test as all my imports were so darn quick.. but it does appear to all work. Two QA follow-ups to keep the QA scripts happy.. I'm going to PQA, but a second set of eyes on my final follow-up wouldn't go a miss... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 16:38:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 14:38:27 +0000 Subject: [Koha-bugs] [Bug 31557] Hold queue/home vs. holding library/transport cost matrix complications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 16:42:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 14:42:49 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 16:51:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 14:51:45 +0000 Subject: [Koha-bugs] [Bug 28375] Inefficiencies in fetching COinS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375 --- Comment #11 from Marcel de Rooy --- Great. No failures anymore from qa tools. Here is another question :) @@ -179,6 +179,7 @@ sub XSLTParse4Display { my $hidden_items = $params->{hidden_items} || []; my $variables = $params->{xslt_variables}; my $items_rs = $params->{items_rs}; + my $interface = $params->{interface}; Why do you use a parameter? Did you consider using C4::Context->interface ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 16:57:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 14:57:18 +0000 Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #33 from Marcel de Rooy --- (In reply to Nick Clemens from comment #32) > (In reply to Marcel de Rooy from comment #24) > > Hmm. The PID as the object number. We should not do that. > This is to allow matching the Run to End actions for a single run - what > would you prefer? Well, I think we have more inappropriate use of that column. So I can live with that ;) > (In reply to Marcel de Rooy from comment #26) > > Running advance_notices: > > Can't locate PatternLayout.pm in @INC > > Whats happening here? > > I don't recreate - custom logging setup? Not sure what it is. But my new container doesnt complain anymore.. > (In reply to Marcel de Rooy from comment #28) > > + [% FOREACH actx IN [ 'ADD' 'DELETE' > > 'MODIFY' 'ISSUE' 'RETURN' 'RENEW' 'CREATE' 'CANCEL' 'FILL' 'SUSPEND' > ... > > Seems to work, although I expected commas. > Following pattern with my patch - feel free to provide a follow-up > > > It is a bit weird that we have lower case Run and End here. > Following the current status for this - feel free to provide a follow-up There is a limit :) > (In reply to Marcel de Rooy from comment #29) > > + > > console.log(Array.isArray(options.embed)); > > debugging > > Removed Good -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 17:01:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 15:01:13 +0000 Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 17:01:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 15:01:18 +0000 Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140980|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy --- Created attachment 141311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141311&action=edit Bug 31203: Alter cronlogaction to take a hash This patch simply changes the routine to expect a hashref for info and to log the PID as object in action logs Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 17:01:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 15:01:23 +0000 Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140981|0 |1 is obsolete| | --- Comment #35 from Marcel de Rooy --- Created attachment 141312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141312&action=edit Bug 31203: POC advance_notices This patch proposes a new standard for cronlogaction We copy @ARGV into a space separated string, then pass this to cronlogaction At the end of the script we add a call with info "COMPLETED" To test: 1 - Apply patch 2 - perl misc/cronjobs/advance_notices.pl -v -m 4 -n -c 3 - sudo koha-mysql kohadev 4 - SELECT * FROM action_logs WHERE interface="CRON"; 5 - Note start and completion logged 6 - Note command line arguments included in info If this looks good I will copy this pattern to the other cronjobs Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 17:01:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 15:01:28 +0000 Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140982|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy --- Created attachment 141313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141313&action=edit Bug 31203: Add End action to cronjobs and log viewer Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 17:01:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 15:01:34 +0000 Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140983|0 |1 is obsolete| | --- Comment #37 from Marcel de Rooy --- Created attachment 141314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141314&action=edit Bug 31203: Alter other cronjobs that currenlty use cronlogaction Added command line ooption logging and completion logging where cronlogaction was already imported. We should probably standardize all cronjobs, but this is a start One cron didn't log on confirm, likely we need to update all crons to log if confirm, and possibly not log if running in test mode? Another bug as well Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 17:01:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 15:01:39 +0000 Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141128|0 |1 is obsolete| | --- Comment #38 from Marcel de Rooy --- Created attachment 141315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141315&action=edit Bug 31203: (follow-up) Remove stray debug statement Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 17:06:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 15:06:43 +0000 Subject: [Koha-bugs] [Bug 31673] Bug 31086 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Component|bugs.koha-community.org |Installation and upgrade | |(command-line installer) Severity|enhancement |normal Keywords|Academy | OS|Linux |All Hardware|PC |All -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 17:56:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 15:56:09 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141228|0 |1 is obsolete| | --- Comment #76 from Martin Renvoize --- Created attachment 141316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141316&action=edit Bug 17170: DB Updates This patch adds the new table, permission, and a syspref to enable the feature Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 17:56:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 15:56:15 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141229|0 |1 is obsolete| | --- Comment #77 from Martin Renvoize --- Created attachment 141317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141317&action=edit Bug 17170: DO NOT PUSH - Schema Updates Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 17:56:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 15:56:20 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141230|0 |1 is obsolete| | --- Comment #78 from Martin Renvoize --- Created attachment 141318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141318&action=edit Bug 17170: Update schema for boolean Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 17:56:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 15:56:27 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141231|0 |1 is obsolete| | --- Comment #79 from Martin Renvoize --- Created attachment 141319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141319&action=edit Bug 17170: Add API route for SearchFilters This adds the API routes and tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 17:56:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 15:56:33 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141232|0 |1 is obsolete| | --- Comment #80 from Martin Renvoize --- Created attachment 141320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141320&action=edit Bug 17170: Add search filters to staff and opac interfaces This patch displays the filters on the results pages with the facets Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 17:56:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 15:56:38 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141233|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize --- Created attachment 141321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141321&action=edit Bug 17170: Handle search filters in query builders This patch updates the query building code to expand filters when searching and pass them back as part of the cgi and descriptive search strings Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 17:56:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 15:56:44 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141234|0 |1 is obsolete| | --- Comment #82 from Martin Renvoize --- Created attachment 141322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141322&action=edit Bug 17170: Add admin page for filters and ability to edit/save existing filters This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the resuilts page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 17:56:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 15:56:50 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141235|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize --- Created attachment 141323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141323&action=edit Bug 17170: Unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 17:56:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 15:56:56 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141236|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize --- Created attachment 141324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141324&action=edit Bug 17170: (follow-up) Display search filters admin links when apprropriate Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 17:57:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 15:57:04 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141237|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize --- Created attachment 141325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141325&action=edit Bug 17170: Add the ability to create 'saved searches' for use as filters when searching the catalog This patch alters the code in the ES QueryBuilder. Reflecting how things are handled in build_query_compat we clean the query, but not the limits. In Zebra we simply recursivly call buildQuery, but the ES query structure This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the results page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page Signed-off-by: Michal Urban Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 17:57:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 15:57:10 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #86 from Martin Renvoize --- Created attachment 141326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141326&action=edit Bug 17170: (QA follow-up) Remove re-introduced file We reintroduced the definitions api spec file with this patch.. it's not required. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 17:57:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 15:57:16 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #87 from Martin Renvoize --- Created attachment 141327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141327&action=edit Bug 17170: (QA follow-up) Relocate 'Save' Another minor rebase issue I believe.. relocate the 'Save search as filter' link back up to sit next to 'Edit this search'. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 17:57:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 15:57:21 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #88 from Martin Renvoize --- Created attachment 141328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141328&action=edit Bug 17170: (QA follow-up) Improve model structure This feature is awesome, but it's modals all feel a bit off.. this is an improvement to one of them, but far from perfect. I opt to work with Owen to create a guideline (and template) for modals going forward and let this patchset go in as is. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:00:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 16:00:20 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #89 from Martin Renvoize --- The core code here works well.. though we managed to slip parts of it into master already in bug 30528.. oops. Anyway.. QA wise I'm actually pretty happy it all works as designed and doesn't introduce any regressions... but there GUI elements so far are pretty ugly and strangely formed.. I started working through some of them, but as the final patch says, I think we may be better of pushing this as is and then working Owen and I working togeter to create some nice templates and a guideline for modal based forms going forward.. and then use this feature to apply/test our idea's on their own bug. As such.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:00:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 16:00:35 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:03:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 16:03:29 +0000 Subject: [Koha-bugs] [Bug 29507] Speed up auto renew cronjob via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29507 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:03:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 16:03:53 +0000 Subject: [Koha-bugs] [Bug 31674] New: We need a template/guideline around how to consistently form our modals Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31674 Bug ID: 31674 Summary: We need a template/guideline around how to consistently form our modals Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org We have more and more modals appearing in the staff client now and I like them.. but they're really inconsistently formed.. We should create a template for how they should be structured in the general case and put it into a coding guideline. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:04:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 16:04:05 +0000 Subject: [Koha-bugs] [Bug 31674] We need a template/guideline around how to consistently form our modals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31674 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:04:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 16:04:15 +0000 Subject: [Koha-bugs] [Bug 31674] We need a template/guideline around how to consistently form our modals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31674 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |martin.renvoize at ptfs-europe | |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:04:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 16:04:24 +0000 Subject: [Koha-bugs] [Bug 31674] We need a template/guideline around how to consistently form our modals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31674 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17170 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:04:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 16:04:24 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31674 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:30:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 16:30:35 +0000 Subject: [Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 21.05.19 |22.11.00, 22.05.06, released in| |21.05.19 Status|Pushed to master |Pushed to stable --- Comment #5 from Lucas Gass --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:52:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 16:52:16 +0000 Subject: [Koha-bugs] [Bug 31675] New: Remove packages from debian/control that are no longer used Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31675 Bug ID: 31675 Summary: Remove packages from debian/control that are no longer used Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org As far as I can tell, we are no longer using CGI::Session::Serialize::YAML or YAML::Syck, but they are still marked dependencies for the Debian package. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:52:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 16:52:22 +0000 Subject: [Koha-bugs] [Bug 31675] Remove packages from debian/control that are no longer used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31675 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:53:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 16:53:48 +0000 Subject: [Koha-bugs] [Bug 31675] Remove packages from debian/control that are no longer used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31675 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:53:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 16:53:51 +0000 Subject: [Koha-bugs] [Bug 31675] Remove packages from debian/control that are no longer used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31675 --- Comment #1 from Kyle M Hall --- Created attachment 141329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141329&action=edit Bug 31675: Remove packages from debian/control that are no longer used As far as I can tell, we are no longer using CGI::Session::Serialize::YAML or YAML::Syck, but they are still marked dependencies for the Debian package. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 19:00:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 17:00:26 +0000 Subject: [Koha-bugs] [Bug 10984] Cannot cancel received order if the parent order is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10984 --- Comment #5 from Daniel Gaghan --- Ok, it sounds like this is still a problem. I will look for the bugs concerning this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 19:22:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 17:22:29 +0000 Subject: [Koha-bugs] [Bug 31676] New: Fix db_dependent/Circulation.t tests Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 Bug ID: 31676 Summary: Fix db_dependent/Circulation.t tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: glasklas at gmail.com QA Contact: testopia at bugs.koha-community.org A lot of tests in db_dependent/Circulation.t are currently failing, many seems to have done so for quite a while so it's a bit puzzling how this has gone under radar for such a long time. If any of the changes are unclear I'm happy to expand more on the different addressed issues. A short summary of the changes: - The patron attribute autorenew_checkouts was added a while ago, patrons for some tests needed this set to preserve previous behavior - OverduesBlockRenewing-test relied on a state that was mutated by new tests, these have been moved to a place where the state is as was before this regression. - The test "AddRenewal left both fines" broke when account line statuses where refactored (probably), there should be one one fine - Fixed a test which expects 'auto_to_soon' error. CanBookBeRenewed will not return this status unless the $cron parameter is set to true - "Incremented fee tests" builds an item with missing "library" parameter since treating the library object as a hashref. This cases a circulation-rule not match and serveral tests fail as a result. - The "AddIssue records staff who checked out item if appropriate" subtest treats some objects as hashrefs when retrieving properties, and also checks the wrong issue objects in the last test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 19:29:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 17:29:27 +0000 Subject: [Koha-bugs] [Bug 31676] Fix db_dependent/Circulation.t tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 --- Comment #1 from David Gustafsson --- Created attachment 141330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141330&action=edit Bug 31676: Fix db_dependent/Circulation.t tests To test: 1) Run tests in t/db_dependent/Circulation.t and verify that fails (the script should actually crash before all can be run). 2) Apply the patch 3) Verifiy that all tests now pass Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 19:31:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 17:31:51 +0000 Subject: [Koha-bugs] [Bug 31676] Fix db_dependent/Circulation.t tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 19:43:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 17:43:14 +0000 Subject: [Koha-bugs] [Bug 31677] New: Convert basic MARC editor tabs to Bootstrap Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31677 Bug ID: 31677 Summary: Convert basic MARC editor tabs to Bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 29226 Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the basic MARC editor (addbiblio.tt) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 19:43:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 17:43:14 +0000 Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31677 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31677 [Bug 31677] Convert basic MARC editor tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 19:45:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 17:45:09 +0000 Subject: [Koha-bugs] [Bug 31678] New: Convert authority editor tabs to Bootstrap Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 Bug ID: 31678 Summary: Convert authority editor tabs to Bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 29226 Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the authorities editor (authorities.tt) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 19:45:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 17:45:09 +0000 Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31678 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 [Bug 31678] Convert authority editor tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 21:56:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 19:56:52 +0000 Subject: [Koha-bugs] [Bug 26028] Allow HoldsToPullStartDate to be blank In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26028 hebah at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 21:56:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 19:56:52 +0000 Subject: [Koha-bugs] [Bug 26028] Allow HoldsToPullStartDate to be blank In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26028 hebah at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 22:12:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 20:12:09 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #90 from Katrin Fischer --- Nick, just to let you know: I am back, but Martin was faster! ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 22:16:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 20:16:14 +0000 Subject: [Koha-bugs] [Bug 25884] Automatic item modifications by age needs title and description fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25884 --- Comment #2 from Christopher Brannon --- (In reply to Andrew Fuerste-Henry from comment #1) > You mean each rule itself needs a title/description? Sounds handy! Yes! Very much needed. It would be great to know more about the rules. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 22:16:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 20:16:27 +0000 Subject: [Koha-bugs] [Bug 19556] Added content ISBN does not match MARC 020 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19556 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Added Content ISBN Does Not |Added content ISBN does not |Match MARC 020 |match MARC 020 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 22:33:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 20:33:09 +0000 Subject: [Koha-bugs] [Bug 31679] New: Circulation Rules needs individual rule cloning Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31679 Bug ID: 31679 Summary: Circulation Rules needs individual rule cloning Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Currently you can clone a set of rules, but you can't clone an individual rule. It would be great if the action buttons were replaced by a single action button, and included a cloning option to clone that rule to another branch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 22:34:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 20:34:22 +0000 Subject: [Koha-bugs] [Bug 31635] Empty title for current result in OPAC results browser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Empty title for current |Empty title for current |result in opac results |result in OPAC results |browser |browser -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 22:35:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 20:35:23 +0000 Subject: [Koha-bugs] [Bug 31680] New: Cloning circulation rules to more than one library at a time Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31680 Bug ID: 31680 Summary: Cloning circulation rules to more than one library at a time Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Currently you can only clone a set of rules to one library at a time. It would be better if you could select all the branches you want to clone to and clone them all at once. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 22:36:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 20:36:23 +0000 Subject: [Koha-bugs] [Bug 31665] 952$d ( Date acquired ) no longer prefills with todays date when focused In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 --- Comment #4 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #3) > How to categorize this bug might be hard too: If lots of items would not get > a date anymore, a library might not consider this Minor anymore Today's date is used autommagically when you leave the input empty. So that won't be the case, but I also liked the old behaviour as it allowed easy manipulation of the date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 22:41:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 20:41:47 +0000 Subject: [Koha-bugs] [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bug 31086 |DB update of bug 31086 | |fails: Cannot change column | |'branchcode': used in a | |foreign key constraint Depends on| |31086 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 [Bug 31086] Do not allow hold requests with no branchcode -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 22:41:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 20:41:47 +0000 Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31673 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 22:43:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 20:43:37 +0000 Subject: [Koha-bugs] [Bug 31681] New: Daily digest notice for ALL notices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31681 Bug ID: 31681 Summary: Daily digest notice for ALL notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org What if a patron had the option to have a SINGLE notice per day, that was a digest of all notices to them? So, if they have this option checked, they would get a notice at the end of the day, or beginning, that would contain any hold, overdue, predue, etc notices. So, if this is checked, instead of queuing up for the regular cron, maybe the notice is sent in a new cron that is once a day. If done, it might also be beneficial to note on the parton's notifications how the notification was queued (right away/daily). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 22:48:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 20:48:07 +0000 Subject: [Koha-bugs] [Bug 31676] Fix db_dependent/Circulation.t tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 --- Comment #2 from Katrin Fischer --- Hm, I ran these tests just yesterday without fail, I still see it in my bash history: prove t/db_dependent/Circulation.t t/db_dependent/Circulation/* Could it depend on having an untouched sample database to start with? But it is a bit odd. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 22:49:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 20:49:22 +0000 Subject: [Koha-bugs] [Bug 31679] Circulation Rules needs individual rule cloning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31679 --- Comment #1 from Katrin Fischer --- There is a workaround for this if you need it: Edit any rule: if you change item type or patron category it will either overwrite the existing rule for this combination or create a new one. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 22:57:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 20:57:38 +0000 Subject: [Koha-bugs] [Bug 31679] Circulation Rules needs individual rule cloning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31679 --- Comment #2 from Katrin Fischer --- (In reply to Katrin Fischer from comment #1) > There is a workaround for this if you need it: > Edit any rule: if you change item type or patron category it will either > overwrite the existing rule for this combination or create a new one. Hm, but of course, this doesn't work for copying between libraries, maybe still helpful to some. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 23:11:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 21:11:34 +0000 Subject: [Koha-bugs] [Bug 31679] Circulation Rules needs individual rule cloning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31679 --- Comment #3 from Christopher Brannon --- (In reply to Katrin Fischer from comment #1) > There is a workaround for this if you need it: > Edit any rule: if you change item type or patron category it will either > overwrite the existing rule for this combination or create a new one. Yeah, this doesn't really apply to the topic. :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 23:23:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 21:23:49 +0000 Subject: [Koha-bugs] [Bug 31682] New: Silence warn when using automatic linker in biblio editor Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31682 Bug ID: 31682 Summary: Silence warn when using automatic linker in biblio editor Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When cataloguing a biblio and you use the 'link authorities automatically' button, there is a warn in the logs that could be silenced: [WARN] CGI::param called in list context from /home/vagrant/kohaclone/svc/cataloguing/automatic_linker.pl line 52, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 412. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 23:25:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 21:25:42 +0000 Subject: [Koha-bugs] [Bug 31682] Silence warn when using automatic linker in biblio editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31682 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 23:25:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 21:25:46 +0000 Subject: [Koha-bugs] [Bug 31682] Silence warn when using automatic linker in biblio editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31682 --- Comment #1 from Aleisha Amohia --- Created attachment 141331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141331&action=edit Bug 31682: Silence automatic linker warn To test: 1. Open the plack-intranet-error.log in your terminal 2. When editing or adding a bibliographic record, click the button to link authorities automatically. 3. Notice the warn in the log 4. Apply the patch, restart services and refresh the page 5. Click the button again. There should be no warn Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 23:26:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 21:26:04 +0000 Subject: [Koha-bugs] [Bug 31682] Silence warn when using automatic linker in biblio editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31682 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 23:43:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 21:43:21 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #73 from David Nind --- Hi Martin. I've tested again and have some more feedback and comments. Feedback - bring back the toolbar? ---------------------------------- Should we bring back the toolbar at the top (with Advanced editor, New record and New from Z3950/SRYU buttons) rather than try fitting under the "New" sub-heading? Rationale: - While some styling is required, it looks a little "odd" to me as it is - I don't think we have a dropdown button mingled with options in other areas as part of a landing page. - Familiarity for cataloguers - the key options used are in a familiar place. Feedback - Rotating collections ------------------------------- There doesn't appear to be a link to Rotating collections, unless this is controlled by another system preference. Some other comments ------------------- 1. I like the idea of the separate bugs for the breadcrumbs and the sidebar changes - makes it easier to do a step at a time, rather than a large change all in one bug. 2. Should there be a separate bug to move the permissions from tools to editcatalogue? 3. Should there be a separate bug to move the system preferences from Tools (or other areas) to Cataloging? 4. From Heather's comment #72, should we also have a separate bug to look at the Administration settings? As a compromise (or first step) we could have an option/link to "Catalog administration" or "Catalog configuration", or something similar. 5. The tools currently have a description in their old location on the tools page. Do we need these, or do we have a way of adding a tooltip with the description? We don't on the staff interface home page, so maybe there is not an issue. 6. Some tools are also used for authorities (such as Batch record deletion, Batch record modification, Export data, Stage MARC records for import). Just trying to think about how we would approach these if we adopt this approach for other modules - do we split these tools (separate out the cataloging vs authority parts), make an arbitrary decision on where they should be, or have a way for the breadcrumbs/URLs to recognise what area we are in (Cataloging, Authorities, etc) and then reflect that? Probably thinking too far ahead at the moment.... Testing notes ------------- 1. Enable the StockRotation and EnableAdvancedCatalogingEditor (so that these appear). 2. Check that there are no cataloguing-related tools under the tools menu. 3. Check that all the option links work as expected: . New record . New from Z39.50/SRU . Advanced editor . All the other cataloguing tools 4. Check that all the items previously on the tools page are now on the new cataloging home page (new section shown in brackets): - Batch item deletion (Batch editing) - Batch item modification (Batch editing) - Batch record deletion (Batch editing) - Batch record modification (Batch editing) - Automatic item modifications by age (Automation) - Export data (Export) - Inventory (Reports) - Label creator (Tools) - Barcode image generator (Tools) - Quick spine label creator (Tools) - Rotating collections (---Not currently shown---) - Stock rotation (Automation) - MARC modification templates (Batch editing) - Stage MARC records for import (Import) - Staged MARC record management (Import) - Upload local cover image (Tools) 5. Check that the grouping of the various cataloging tools makes logical sense to you - suggestions welcome on categorising! NOTES: - Breadcrumbs and page URLs will be changed in bug 31556 - The sidebar menu will be changed in bug 31417 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 23:47:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 21:47:56 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #74 from David Nind --- (In reply to David Nind from comment #73) > Feedback - Rotating collections > ------------------------------- > > There doesn't appear to be a link to Rotating collections, unless this is > controlled by another system preference. Ignore this, I see that it is under Patrons and circulation on the Tools page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 00:30:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 22:30:10 +0000 Subject: [Koha-bugs] [Bug 31683] New: Return descriptions from items API endpoint Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31683 Bug ID: 31683 Summary: Return descriptions from items API endpoint Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com CC: tomascohen at gmail.com It would be pretty handy of the items endpoint (/api/v1/items ) returned the descriptions along with the actual codes. For example if I go here to '/api/v1/items/419' the location returned is 'GEN', which is the A.V. code. It would be neat if I could get the description too, 'General stacks'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 00:44:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 22:44:52 +0000 Subject: [Koha-bugs] [Bug 31654] Hide non-public libraries from MastheadLibraryPulldown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #4 from Lucas Gass --- Hey Thomas, This will be a nice addition! There are a few problems with your patch: FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc FAIL forbidden patterns forbidden pattern: tab char (line 235) * Commit title does not start with 'Bug XXXXX: ' - abec2a9a88 Can you make sure your commit title starts with "Bug 31654: " and have a look at the bad pattern in masthead.inc? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 00:48:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 22:48:57 +0000 Subject: [Koha-bugs] [Bug 31683] Return descriptions from items API endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31683 --- Comment #1 from Tomás Cohen Arazi --- Hi, good call. This is actually a duplicate of bug 26635. Could you please take a look at the conversation there? As an API consumer, I would like your opinion on the data structure we should be returning, a subject which has actually blocked that one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 00:50:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 22:50:54 +0000 Subject: [Koha-bugs] [Bug 31683] Return descriptions from items API endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31683 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Lucas Gass --- *** This bug has been marked as a duplicate of bug 26635 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 00:50:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 22:50:54 +0000 Subject: [Koha-bugs] [Bug 26635] Expand authorised values in REST API call In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 --- Comment #44 from Lucas Gass --- *** Bug 31683 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 00:53:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 22:53:06 +0000 Subject: [Koha-bugs] [Bug 31635] Empty title for current result in OPAC results browser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 00:53:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 22:53:10 +0000 Subject: [Koha-bugs] [Bug 31635] Empty title for current result in OPAC results browser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141301|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 141332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141332&action=edit Bug 31635: Fix output of current title in OPAC browse results This patch makes a correction to the output of OPAC browse results. In the numbered result navigation links, a title tag on each navigation link should contain the title of the record. The link for the current title didn't include the title information in the title tag because it used the wrong template variables. To test, apply the patch and make sure OpacBrowseResults is enabled. - In OPAC, perform a search that will return multiple results. - View one of the results. - In the right-hand sidebar, click "Browse results." - In the list of numbered links at the top of the panel, hover your mouse over each link. They should each display a tooltip with "View record [title]" - Confirm that the current title in the list includes the correct tooltip. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 01:22:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 23:22:11 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #80 from David Cook --- Comment on attachment 120622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120622 Bug 8179: Add AcqReceiveMultipleOrderLines syspref to preference configuration Review of attachment 120622: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8179&attachment=120622) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref @@ +113,5 @@ > - pref: EmailAddressForSuggestions > class: email > + - > + - pref: AcqReceiveMultipleOrderLines > + defualt: no Typo in default -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 01:53:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2022 23:53:18 +0000 Subject: [Koha-bugs] [Bug 26635] Expand authorised values in REST API call In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #45 from David Cook --- Another wrinkle could be translations for authorised values: https://lists.katipo.co.nz/public/koha/2021-December/057052.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 03:55:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 01:55:27 +0000 Subject: [Koha-bugs] [Bug 26635] Expand authorised values in REST API call In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 --- Comment #46 from David Cook --- In any case, I reckon backwards compatibility is important, especially since we're still using "v1" for the API, so I don't think we can change the existing "location" field. Whether we embed the data or provide a lookup reference, I think it needs to be as a separate field. On non-Koha projects where I've needed to maintain backwards compatibility, I've added fields like "location_description". -- Sometimes, I think that authorised values should be removed from item data, and replaced with proper foreign key references. Location is an important field which by rights deserves its own database table I think. Of course, that data migration is easier said than done... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 09:07:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 07:07:43 +0000 Subject: [Koha-bugs] [Bug 31654] Hide non-public libraries from MastheadLibraryPulldown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 --- Comment #5 from Katrin Fischer --- As you are just starting out: the QA tools script that points out these kind of errors can be run by everyone. On ktd it's just: 'qa -v 2'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 09:30:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 07:30:47 +0000 Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #35 from Martin Renvoize --- I don't understand how running the exact same SQL as is in the update itself can resolve this problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 11:47:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 09:47:02 +0000 Subject: [Koha-bugs] [Bug 26648] Prevent internal server error if item attached to old checkout has been removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111804|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 141333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141333&action=edit Bug 26648: Prevent explosion in notices on missing item The item accessor in Koha::Old::Checkouts could explode given a checkout where the item had been deleted. To test 1/ Edit the issueslip notice to output some item details from the borrowers old checkouts [% FOREACH old_checkout IN borrower.old_checkouts %] [% IF old_checkout.item %] [% old_checkout.item.price %] [% END %] [% END %] 2/ Delete the item associated with an old checkout for a test patron 3/ Print the issueslip for the patron 4/ Note a server side error is triggered 5/ Apply the patch 6/ Print the slip again and note the price details for old checkouts are now displayed 7/ Signoff Signed-off-by: Caroline Cyr La Rose Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 11:47:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 09:47:06 +0000 Subject: [Koha-bugs] [Bug 26648] Prevent internal server error if item attached to old checkout has been removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141287|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 141334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141334&action=edit Bug 26648: Add tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 11:47:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 09:47:19 +0000 Subject: [Koha-bugs] [Bug 26648] Prevent internal server error if item attached to old checkout has been removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 11:47:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 09:47:33 +0000 Subject: [Koha-bugs] [Bug 26648] Prevent internal server error if item attached to old checkout has been removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize --- Tests added and passing.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:10:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:10:02 +0000 Subject: [Koha-bugs] [Bug 29099] Add support for item bundles in the inventory tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #4 from Martin Renvoize --- Thanks for your work here Julian, I'm so bad at remembering unit tests at the moment :(. Is your customer intending to test and sign this one off.. We don't really use the inventory at all here, so although I'm reasonably confident this achieves what's required, it would be great to hear from someone using it in earnest. It would be great to see this go in within this cycle to have the feature complete at release time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:15:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:15:56 +0000 Subject: [Koha-bugs] [Bug 31654] Hide non-public libraries from MastheadLibraryPulldown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 --- Comment #6 from Thomas Klausner --- Created attachment 141335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141335&action=edit Bug 31654: Hide non-public libraries from MastheadLibraryPulldown (bug_31654_hide_nonpublic_libs) Do not list library in masthead and advanced search if branches.public is false Test Plan: * Set OpacAddMastheadLibraryPulldown to "Add" * Go to Administration -> Libraries, edit "Fairfield", set "public" = "no" (at the end of the form) * Or connect to DB and run update branches set public = 0 where branchcode like 'F%'; This will set all three libraries starting with F to non-public * open OPAC * The "All libraries" Pulldown in the Header (between search slot and search button) still shows the non-public libraries * Go to OPAC -> Advanced Search, scroll to "Location and availability": The selectbox still shows the non-public libraries Now apply the patch * Open OPAC * The "All libraries" Pulldown in the Header now should not contain the libraries set to "public = no" * And in the Advanced Search "Location and availability" pulldown those libraries should also not be shown. Sponsored-by: Steiermärkische Landesbibliothek -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:17:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:17:42 +0000 Subject: [Koha-bugs] [Bug 31654] Hide non-public libraries from MastheadLibraryPulldown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 Thomas Klausner changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Thomas Klausner --- Hi Lucas! I now fixed the problems with the patch and submitted a new one. @Katrin Thanks for pointing out `qa-test-tools/koha-qa.pl` :-) Greetings, domm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:18:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:18:01 +0000 Subject: [Koha-bugs] [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:18:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:18:05 +0000 Subject: [Koha-bugs] [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 --- Comment #1 from Nick Clemens --- Created attachment 141336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141336&action=edit Bug 31673: (bug 31086 follow-up) Drop and constraint to allow updating column It seems that we cannot edit the column while it has a constraint. If we remove it, update the oclumn, then re-add it, the update succeeds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:18:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:18:30 +0000 Subject: [Koha-bugs] [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Severity|normal |critical CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:30:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:30:37 +0000 Subject: [Koha-bugs] [Bug 31532] Zebra search results including 880 with original script incorrect because of Bug 15187 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31532 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140760|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 141337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141337&action=edit Bug 31532: Add preprocessor to Zebra indexing pipeline to index 880 as linked field This patch adds a preprocessor XSLT to the Zebra indexing pipeline, so that 880 fields get indexed as the fields they're linked to. For example, a "880 $6 245" field would be indexed as a "245" field. However, because the preprocessor only occurs in the indexing part of the pipeline, it does not affect the retrieval of MARCXML from Zebra. That MARCXML will be the same MARCXML that was sent to Zebra from Koha. Test plan: 0. Revert bug 15187, and apply patch for 31532 1. cp ./etc/zebradb/biblios/etc/dom-config.xml /etc/koha/zebradb/biblios/etc/dom-config.xml 2a. cp etc/zebradb/marc_defs/marc21/biblios/preprocess_marcxml.xsl /etc/koha/zebradb/marc_defs/marc21/biblios/. 2b. cp etc/zebradb/marc_defs/normarc/biblios/preprocess_marcxml.xsl /etc/koha/zebradb/marc_defs/normarc/biblios/. 2c. cp etc/zebradb/marc_defs/unimarc/biblios/preprocess_marcxml.xsl /etc/koha/zebradb/marc_defs/unimarc/biblios/. 3. koha-rebuild-zebra -b -f -v kohadev 4. Note that in search results the 880$6245$a data appears before the 245$a data 5. Note that you can do a title index search on the 880$6245$a data Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:32:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:32:09 +0000 Subject: [Koha-bugs] [Bug 31532] Zebra search results including 880 with original script incorrect because of Bug 15187 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31532 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- Works well.. RM/RMaints remember to do the revert step in your branches as you roll this out. Passing QA. Note: I'm wondering now if this also affect Elastics as we effectively copied what we're doing there for bug 15187.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:32:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:32:15 +0000 Subject: [Koha-bugs] [Bug 31532] Zebra search results including 880 with original script incorrect because of Bug 15187 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31532 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:36:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:36:06 +0000 Subject: [Koha-bugs] [Bug 31465] Link system preference tabs to correct manual pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31465 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Martin Renvoize --- This looks like we just missed updating the status.. David SO'd and Katrin QA'd. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:39:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:39:29 +0000 Subject: [Koha-bugs] [Bug 30200] Add customizable tabs to interlibrary loan requests list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138863|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 141338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141338&action=edit Bug 30200: Add custom tabs to View ILL requests page Prereqs: 1: Make sure you have enabled an ILL backend and enabled system preferecnce ILLModule. For more information see https://koha-community.org/manual/21.11/en/html/ILL_requests.html To test: 1: Note, the following branchcodes, statuses and backends depend on your test environment and which ILL backend you are using. This example is for Libris backend. Set system preference ILLRequestsTabs: - name: tab1 status: - IN_REM - name: tab2 status: - IN_UTEL - IN_LEV - name: tab3 status: - IN_ANK 2. Add at least 4 ILL requests with the following SQL: INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_REM', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_UTEL', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_LEV', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_ANK', 'Libris'); Note: Change values to whatever your test environment has set up. 3. Go to cgi-bin/koha/ill/ill-requests.pl 4. After the page loads, you should now see 4 different tabs: "All", "tab1", "tab2" and "tab3" 5. Confirm all ILL requests are present under "All" tab 6. Confirm only ILL requests with the statuses you defined in system preference ILLRequestsTabs are under tabs 1, 2 and 3 7. Go to cgi-bin/koha/members/ill-requests.pl?borrowernumber=1 8. Repeat steps 4-6 9. Clear system preference ILLRequestsTabs 10. Observe both ill/ill-requests.pl and members/ill-requests.pl now have only one tab "All" under which correct ILL requests are presented 11. Try some other status values in ILLRequestsTabs and observe expected behavior Signed-off-by: Magnus Enger Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:39:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:39:33 +0000 Subject: [Koha-bugs] [Bug 30200] Add customizable tabs to interlibrary loan requests list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138864|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 141339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141339&action=edit Bug 30200: Add a new system preference ILLRequestsTabs Signed-off-by: Magnus Enger Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:39:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:39:37 +0000 Subject: [Koha-bugs] [Bug 30200] Add customizable tabs to interlibrary loan requests list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138865|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize --- Created attachment 141340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141340&action=edit Bug 30200: (follow-up) Fix missing TT filters Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:39:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:39:41 +0000 Subject: [Koha-bugs] [Bug 30200] Add customizable tabs to interlibrary loan requests list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138866|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 141341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141341&action=edit Bug 30200: (follow-up) Update database update and pref description * Rephrases the system preference description a bit * Adds IGNORE to the database statement * Update output message of database statement to include pref name Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:39:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:39:50 +0000 Subject: [Koha-bugs] [Bug 30200] Add customizable tabs to interlibrary loan requests list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:40:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:40:09 +0000 Subject: [Koha-bugs] [Bug 30200] Add customizable tabs to interlibrary loan requests list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #18 from Martin Renvoize --- Great improvement, all works well and not obvious regressions. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:44:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:44:57 +0000 Subject: [Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138873|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize --- Created attachment 141342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141342&action=edit Bug 22321: Add unit tests To test: 1. prove t/db_dependent/Illrequests.t 2. Observe test failure 1..3 ok 1 - before change, original borrowernumber found not ok 2 - after change, changed borrowernumber found in holds # Failed test 'after change, changed borrowernumber found in holds' # at t/db_dependent/Illrequests.t line 167. # got: '3786' # expected: '3787' ok 3 - after change, changed borrowernumber found in illrequests # Looks like you failed 1 test of 3. not ok 4 - store borrowernumber change also updates holds Signed-off-by: Magnus Enger Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:45:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:45:01 +0000 Subject: [Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138874|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize --- Created attachment 141343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141343&action=edit Bug 22321: Update holds borrowernumber when ILL request borrowernumber changes To test: 1. prove t/db_dependent/Illrequests.t Signed-off-by: Magnus Enger Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:45:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:45:05 +0000 Subject: [Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138875|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize --- Created attachment 141344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141344&action=edit Bug 22321: Allow managing the borrowernumber tied to ILL request Sometimes an ILL request is connected to the wrong borrower, and it would be nice to be able to connect it to the right one. In Swedish ILL the cardnumber of the patron connected with an ILL request is entered into the central Libris system and then propagated to Koha through the Libris API. This can lead to errors, and we have created a dummy "ILL patron" to catch these. It would then be good to be able to connect the ILL to the right patron in Koha. This commit makes it possible to edit illrequests.borrowernumber. To test: 1. Apply patch 2. Create two patrons, A and B 3. Create a new ILL request for patron A 4. Add a hold for patron A where biblionumber is the biblio tied to this ILL request 5. Go to cgi-bin/koha/ill/ill-requests.pl?method=edit_action&illrequest_id=161 6. Observe Patron ID is editable 7. Change borrowernumber to patron B's borrowernumber 8. Click save 9. Observe ILL request is now for patron B 10. Go to patron B's details at cgi-bin/koha/members/moremember.pl?borrowernumber=B_borrowernumber 11. At the bottom section of the page, click 1 Hold(s) 12. Observe the hold you placed at step 4 has transferred to patron b Signed-off-by: Magnus Enger Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:45:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:45:10 +0000 Subject: [Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138876|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize --- Created attachment 141345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141345&action=edit Bug 22321: Unit test for new()->borrowernumber()->store() Signed-off-by: Magnus Enger Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:45:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:45:15 +0000 Subject: [Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138877|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize --- Created attachment 141346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141346&action=edit Bug 22321: Fix store() crash when modifying borrowernumber of a new ILL request To test: 1. prove t/db_dependent/Illrequests.t Signed-off-by: Magnus Enger Tried to change the borrowernumber connected to an ILL request and checked that the associated hold was updated to the new patron as well. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:45:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:45:19 +0000 Subject: [Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138878|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize --- Created attachment 141347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141347&action=edit Bug 22321: (follow-up) Fix number of planned tests in Illrequests.t Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:45:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:45:55 +0000 Subject: [Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA QA Contact| |martin.renvoize at ptfs-europe | |.com --- Comment #29 from Martin Renvoize --- Another nice improvement, all working as advertised. No QA failures or regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:51:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 10:51:01 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:01:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:01:58 +0000 Subject: [Koha-bugs] [Bug 26635] Expand authorised values in REST API call In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 --- Comment #47 from Tomás Cohen Arazi --- (In reply to David Cook from comment #46) > In any case, I reckon backwards compatibility is important, especially since > we're still using "v1" for the API, so I don't think we can change the > existing "location" field. Agreed! > On non-Koha projects where I've needed to maintain backwards compatibility, > I've added fields like "location_description". Right. We also need the category it is linked to, do we can draw things like drop-downs. > Sometimes, I think that authorised values should be removed from item data, > and replaced with proper foreign key references. > > Location is an important field which by rights deserves its own database > table I think. Locations, collections... We've done that with credit/debit tired recently. > Of course, that data migration is easier said than done... Generally speaking, the problem is lack of infinite time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:04:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:04:10 +0000 Subject: [Koha-bugs] [Bug 31684] New: Plugin versions starting with a "v" cause unnecessary warnings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31684 Bug ID: 31684 Summary: Plugin versions starting with a "v" cause unnecessary warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Our code assumes that plugin version will be purely numeric ( e.g. 1.2.3 ) but many plugin authors ( including myself ) use the format "v1.2.3". This causes warnings as we use a numeric comparison on the version numbers. It could make sense to check for and strip any v's from the beginning of the version. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:10:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:10:36 +0000 Subject: [Koha-bugs] [Bug 31612] koha-z3950-responder breaks if it's run in a Koha that was created before bug 28364 was applied In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31612 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- We find lots of issues with permissions at upgrades.. mostly for 'standard' type installs though. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:10:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:10:54 +0000 Subject: [Koha-bugs] [Bug 31665] 952$d ( Date acquired ) no longer prefills with todays date when focused In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 --- Comment #5 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #4) > (In reply to Marcel de Rooy from comment #3) > > How to categorize this bug might be hard too: If lots of items would not get > > a date anymore, a library might not consider this Minor anymore > > Today's date is used autommagically when you leave the input empty. So that > won't be the case, but I also liked the old behaviour as it allowed easy > manipulation of the date. That is depending on the context. You are right for new items. Which will be the scope mainly here. For existing items, see bug 29958: Do not set dateaccessioned on updates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:19:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:19:49 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Change sponsored?|--- |Sponsored Text to go in the| |This patchset adds a new release notes| |feature, the ability to | |save searches on the staff | |client and display them in | |the results page alongside | |facets (staff client and/or | |OPAC) as a search filter | |that can be applied to | |search result set. | | | |The | |feature is enabled/disabled | |by new system preference: | |SavedSearchFilters | | | |New | |filters can be added from | |the results page after a | |search, and there is an | |admin page for updating | |deleting and renaming | |filters. | | | |There is a new | |permission, | |manage_search_filters, to | |control management of these | |filters. | | | |New filters can | |be added that are not | |displayed along with | |facets, this allows for | |building custom links using | |these filters to keep URLs | |shorter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:25:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:25:23 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 --- Comment #21 from Marcel de Rooy --- >From IRC [13:21] marcelr: oleonard's database had nulls, so the update failed Will still take a look how to improve the atomicupdate a bit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:25:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:25:24 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141316|0 |1 is obsolete| | --- Comment #91 from Nick Clemens --- Created attachment 141348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141348&action=edit Bug 17170: DB Updates This patch adds the new table, permission, and a syspref to enable the feature Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:25:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:25:30 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141317|0 |1 is obsolete| | --- Comment #92 from Nick Clemens --- Created attachment 141349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141349&action=edit Bug 17170: DO NOT PUSH - Schema Updates Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:25:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:25:36 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141318|0 |1 is obsolete| | --- Comment #93 from Nick Clemens --- Created attachment 141350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141350&action=edit Bug 17170: Update schema for boolean Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:25:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:25:42 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141319|0 |1 is obsolete| | --- Comment #94 from Nick Clemens --- Created attachment 141351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141351&action=edit Bug 17170: Add API route for SearchFilters This adds the API routes and tests Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:25:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:25:48 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141320|0 |1 is obsolete| | --- Comment #95 from Nick Clemens --- Created attachment 141352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141352&action=edit Bug 17170: Add search filters to staff and opac interfaces This patch displays the filters on the results pages with the facets Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:25:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:25:53 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141321|0 |1 is obsolete| | --- Comment #96 from Nick Clemens --- Created attachment 141353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141353&action=edit Bug 17170: Handle search filters in query builders This patch updates the query building code to expand filters when searching and pass them back as part of the cgi and descriptive search strings Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:25:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:25:59 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141322|0 |1 is obsolete| | --- Comment #97 from Nick Clemens --- Created attachment 141354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141354&action=edit Bug 17170: Add admin page for filters and ability to edit/save existing filters This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the resuilts page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:26:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:26:04 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141323|0 |1 is obsolete| | --- Comment #98 from Nick Clemens --- Created attachment 141355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141355&action=edit Bug 17170: Unit tests Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:26:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:26:09 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #99 from Nick Clemens --- Created attachment 141356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141356&action=edit Bug 17170: (follow-up) Display search filters admin links when appropriate Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:26:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:26:14 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141325|0 |1 is obsolete| | --- Comment #100 from Nick Clemens --- Created attachment 141357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141357&action=edit Bug 17170: Add the ability to create 'saved searches' for use as filters when searching the catalog This patch alters the code in the ES QueryBuilder. Reflecting how things are handled in build_query_compat we clean the query, but not the limits. In Zebra we simply recursivly call buildQuery, but the ES query structure This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the results page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Michal Urban Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:26:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:26:19 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141326|0 |1 is obsolete| | --- Comment #101 from Nick Clemens --- Created attachment 141358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141358&action=edit Bug 17170: (QA follow-up) Remove re-introduced file We reintroduced the definitions api spec file with this patch.. it's not required. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:26:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:26:25 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141327|0 |1 is obsolete| | --- Comment #102 from Nick Clemens --- Created attachment 141359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141359&action=edit Bug 17170: (QA follow-up) Relocate 'Save' Another minor rebase issue I believe.. relocate the 'Save search as filter' link back up to sit next to 'Edit this search'. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:26:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:26:31 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141328|0 |1 is obsolete| | --- Comment #103 from Nick Clemens --- Created attachment 141360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141360&action=edit Bug 17170: (QA follow-up) Improve model structure This feature is awesome, but it's modals all feel a bit off.. this is an improvement to one of them, but far from perfect. I opt to work with Owen to create a guideline (and template) for modals going forward and let this patchset go in as is. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:54:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:54:18 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 --- Comment #22 from Marcel de Rooy --- Created attachment 141361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141361&action=edit Bug 30571: (follow-up) Additional check at upgrade Bad data occurs. We are removing null hosts here and update empty syntax or encoding, informing the user. Test plan: Remove the NOT NULL condition if needed. Copy db_revs/220600056.pl to atomicupdate and test dbrev. You might see something like: Upgrade to 22.06.00.056 [11:48:22]: Bug 30571 - Table z3950servers: three cols NOT NULL Found bad data in table z3950servers: removed 1 records with host undefined Corrected empty syntax or encoding for the following hosts. Please check after upgrade. Updated hosts: lx2.loc.gov,lx2.loc.gov Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:54:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:54:37 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:54:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:54:47 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:54:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:54:55 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:55:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:55:03 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:55:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:55:17 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 --- Comment #23 from Marcel de Rooy --- Tomas: Check last patch only -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:58:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 11:58:31 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 --- Comment #24 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #22) > Created attachment 141361 [details] [review] > Bug 30571: (follow-up) Additional check at upgrade > > Bad data occurs. We are removing null hosts here and update > empty syntax or encoding, informing the user. > > Test plan: > Remove the NOT NULL condition if needed. > Copy db_revs/220600056.pl to atomicupdate and test dbrev. > You might see something like: > Upgrade to 22.06.00.056 [11:48:22]: Bug 30571 - Table z3950servers: > three cols NOT NULL > Found bad data in table z3950servers: removed 1 records with host > undefined > Corrected empty syntax or encoding for the following hosts. Please > check after upgrade. > Updated hosts: lx2.loc.gov,lx2.loc.gov > > Signed-off-by: Marcel de Rooy Forgot to add the second obvious step in testing: create some bad data.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:17:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:17:27 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:17:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:17:32 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 141362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141362&action=edit Bug 31378: DB changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:17:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:17:37 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 141363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141363&action=edit Bug 31378: DBIC updates [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:17:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:17:43 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 141364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141364&action=edit Bug 31378: Add dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:17:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:17:47 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 141365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141365&action=edit Bug 31378: Add Koha::Auth::Provider::Domain(s) class(es) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:17:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:17:52 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 141366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141366&action=edit Bug 31378: Add Koha::Auth::Provider(s) class(es) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:17:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:17:58 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 141367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141367&action=edit Bug 31378: Add Koha::Auth::Client* modules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:18:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:18:03 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 141368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141368&action=edit Bug 31378: Add Auth mojo plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:18:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:18:08 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 141369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141369&action=edit Bug 31378: Add API routes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:18:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:18:14 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 141370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141370&action=edit Bug 31378: Add auth providers template plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:18:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:18:19 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 141371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141371&action=edit Bug 31378: Add the API-based auth mechanism to C4::Auth::check_api_auth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:18:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:18:30 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #13 from Tomás Cohen Arazi --- Created attachment 141372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141372&action=edit Bug 31378: Add OPAC support for authentication providers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:18:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:18:35 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 141373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141373&action=edit Bug 31378: Add STAFF support for authentication providers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:18:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:18:40 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 141374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141374&action=edit Bug 31378: Add accessor methods for JSON attributes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:18:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:18:46 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 141375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141375&action=edit Bug 31378: Add manage_authentication_providers permission Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:18:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:18:51 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 141376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141376&action=edit Bug 31378: Add 'parameter' parameter to Koha::Exceptions::MissingParameter Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:18:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:18:56 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #18 from Tomás Cohen Arazi --- Created attachment 141377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141377&action=edit Bug 31378: Add authentication provider endpoints This patch adds routes for handling authentication providers to the REST API. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_providers.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:19:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:19:02 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 141378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141378&action=edit Bug 31378: Add an administration interface for authentication sources -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:28:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:28:03 +0000 Subject: [Koha-bugs] [Bug 30337] Holds to pull ( pendingreserves.pl ) ignores holds if priority 1 hold is suspended In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30337 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Holds to Pull ( |Holds to pull ( |pendingreserves.pl ) |pendingreserves.pl ) |ignores holds if priority 1 |ignores holds if priority 1 |hold is suspended |hold is suspended -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:32:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:32:07 +0000 Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #17 from Tomás Cohen Arazi --- Can we move this one forward? I keep seeing devs adding random separators and it really makes no sense not having a high-level way to handle multivalued sysprefs. Jonathan and all: the next steps are moving all multivalued sysprefs into this. And adding a generic JS tool to deal with multivalued sysprefs in a way users don't need to deal with the (internal) separator. But please, first things first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:36:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:36:55 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #20 from Tomás Cohen Arazi --- Notes for testing: KTD (master) comes with the koha-staging repo already configured, so in order to test this patches you can just run: $ apt install libmojolicious-plugin-oauth2-perl After installing the dependency, you need to restart Plack (as usual): $ koha-plack --restart kohadev The OAuth2 Mojolicious plugin is feeded with the configured authentication providers at (plack) startup time, so in order for new providers to be picked, restart Plack, just to be sure. Enjoy, provide any constructive comments you can, early. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:37:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:37:20 +0000 Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31333 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:37:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:37:20 +0000 Subject: [Koha-bugs] [Bug 31333] Add the ability to limit purchase suggestions by patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29033 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:40:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:40:13 +0000 Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #18 from Marcel de Rooy --- My comment9 still holds. You did not spend these 5 minutes yet. For me this is a FQA ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:45:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:45:50 +0000 Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #19 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #18) > My comment9 still holds. > You did not spend these 5 minutes yet. > For me this is a FQA ? I disagree with the 'all or nothing' argument. That's why some really nice devs have sitted for years without people willing to test them. I don't like the idea of over-complicating it with a separator param (that will need to have its own unit tests, handling the escaping that is required on each case, etc). But... ... Now that I think about this, we could probably just stick to YAML internally on the DB. And not even deal with splitting manually. Thoughts? PS: Honestly, I didn't know what to answer to your comment. The amount of time needed to do the separator thing is probably the same as moving sysprefs into making them all use the same separator. And I have my personal preferences on what to spend time on too heh -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:49:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:49:07 +0000 Subject: [Koha-bugs] [Bug 31684] Plugin versions starting with a "v" cause unnecessary warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31684 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:49:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:49:10 +0000 Subject: [Koha-bugs] [Bug 31684] Plugin versions starting with a "v" cause unnecessary warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31684 --- Comment #1 from Kyle M Hall --- Created attachment 141379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141379&action=edit Bug 31684: Set Koha::Plugin::Test version to 'v1.01' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:49:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:49:23 +0000 Subject: [Koha-bugs] [Bug 31684] Plugin versions starting with a "v" cause unnecessary warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31684 --- Comment #2 from Kyle M Hall --- Created attachment 141380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141380&action=edit Bug 31684: Plugin versions starting with a "v" cause unnecessary warnings Our code assumes that plugin version will be purely numeric ( e.g. 1.2.3 ) but many plugin authors ( including myself ) use the format "v1.2.3". This causes warnings as we use a numeric comparison on the version numbers. It could make sense to check for and strip any v's from the beginning of the version. Test Plan: 1) Apply the first patch to set the test plugin's version to v1.01 2) prove t/db_dependent/Koha/Plugins/Plugins.t 3) Note the warnings and test failures 4) Apply this patch 5) prove t/db_dependent/Koha/Plugins/Plugins.t 6) All tests pass! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:53:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:53:08 +0000 Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #20 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #19) > I disagree with the 'all or nothing' argument. That's why some really nice > devs have sitted for years without people willing to test them. Maybe we are not on the same level here? But imo you want all or nothing, and I recommend a gradual approach. Note that we several prefs using other separators still. > I don't like the idea of over-complicating it with a separator param (that > will need to have its own unit tests, handling the escaping that is required > on each case, etc). But... This really should be trivial. > ... Now that I think about this, we could probably just stick to YAML > internally on the DB. And not even deal with splitting manually. Sounds good but also a larger project. > PS: Honestly, I didn't know what to answer to your comment. The amount of > time needed to do the separator thing is probably the same as moving > sysprefs into making them all use the same separator. And I have my personal > preferences on what to spend time on too heh You say All or nothing here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:56:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:56:09 +0000 Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #21 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #20) > > You say All or nothing here? I think we are generally on the same page, but with a slightly different approach. Trying to explain: I want to implement the ideal solution and then migrate things one by one into it. You are proposing a somewhat intermediate thing that will need to be redone (removing the separator). The goal is the same. I'll try to provide an implementation of the YAML version ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:58:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 12:58:09 +0000 Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #22 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #21) > (In reply to Marcel de Rooy from comment #20) > > > > You say All or nothing here? > > I think we are generally on the same page, but with a slightly different > approach. Trying to explain: I want to implement the ideal solution and then > migrate things one by one into it. You are proposing a somewhat intermediate > thing that will need to be redone (removing the separator). The goal is the > same. > > I'll try to provide an implementation of the YAML version ASAP. Great! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 15:00:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 13:00:42 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #51 from Nick Clemens --- Minor QA tool failure Why use AV for consents? Looking ahead to bug 20380 it seems the consents will have more options - maybe we could create a 'consent_types' table and use that? Currently too - branch limits are half implemented - I don't see the tab if my only consent is branch limited - but I can force go to the page and see the consent options - was this a plan, or a side effect of choosing AV? The description displays in the form, but the title is still the AV - can let go in light of 31570, but it is lees friendly to see "Consent for GDPR_PROCESSING" +use constant AV_CONSENT => 'PATRON_CONSENT'; Why not just use the string in the search? Same question for existing: use constant GDPR_PROCESSING => 'GDPR_PROCESSING'; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 15:24:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 13:24:57 +0000 Subject: [Koha-bugs] [Bug 25972] SIP2 server doesn't have a TLS/SSL-enabled listener In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25972 --- Comment #3 from Magnus Enger --- > it should be possible to do this without too much effort. That sounds promising ;-) Having a little look at this, but it feels like it is a little bit above me... I found this code, where we pass params from $config->{'server-params'} to ->run: if (defined($config->{'server-params'})) { while (my ($key, $val) = each %{$config->{'server-params'}}) { push @parms, $key . '=' . $val; } } __PACKAGE__ ->run(@parms); https://git.koha-community.org/Koha-community/Koha/src/branch/master/C4/SIP/SIPServer.pm#L80 >From https://metacpan.org/pod/Net::Server::Proto::SSL#SYNOPSIS it looks like SSL is just a question of doing this: main->run( proto => 'ssl', SSL_key_file => "/path/to/my/file.key", SSL_cert_file => "/path/to/my/file.crt", ); Could this mean that enabling SSL is as simple as adding proto, SSL_key_file and SSL_cert_file to the in the SIPconfig.xml? Or are there more adjustments that are needed somewhere? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 15:44:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 13:44:49 +0000 Subject: [Koha-bugs] [Bug 31685] New: Article request count in table caption of opac-user missing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31685 Bug ID: 31685 Summary: Article request count in table caption of opac-user missing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org It mentions Article requests ( total) The total does appear on the tab itself. Reason: The template still refers to current_article_requests_count which has been replaced. Trivial fix forthcoming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 15:44:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 13:44:59 +0000 Subject: [Koha-bugs] [Bug 31685] Article request count in table caption of opac-user missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31685 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 15:49:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 13:49:17 +0000 Subject: [Koha-bugs] [Bug 31686] New: Branch limited patron categories can break patron searching Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31686 Bug ID: 31686 Summary: Branch limited patron categories can break patron searching Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When a patron is returned in a category that is restricted to a branch different than the current logged in branch the datatable results will not load To recreate: 1 - Edit Patron category Patron/PT to limit to a single branch that is not the branch you are logged in at 2 - Perform a patron search that will return a patron in this category 3 - Error in JS console: Uncaught TypeError: categories_map[data] is undefined render Ember S http://localhost:8081/intranet-tmpl/lib/datatables/datatables.min_22.0600060.js:56 fnGetData http://localhost:8081/intranet-tmpl/lib/datatables/datatables.min_22.0600060.js:50 B http://localhost:8081/intranet-tmpl/lib/datatables/datatables.min_22.0600060.js:55 Ha http://localhost:8081/intranet-tmpl/lib/datatables/datatables.min_22.0600060.js:63 P http://localhost:8081/intranet-tmpl/lib/datatables/datatables.min_22.0600060.js:67 vb http://localhost:8081/intranet-tmpl/lib/datatables/datatables.min_22.0600060.js:78 lb http://localhost:8081/intranet-tmpl/lib/datatables/datatables.min_22.0600060.js:75 i http://localhost:8081/intranet-tmpl/lib/datatables/datatables.min_22.0600060.js:73 success http://localhost:8081/intranet-tmpl/lib/datatables/datatables.min_22.0600060.js:74 jQuery 7 sa http://localhost:8081/intranet-tmpl/lib/datatables/datatables.min_22.0600060.js:75 lb http://localhost:8081/intranet-tmpl/lib/datatables/datatables.min_22.0600060.js:75 P http://localhost:8081/intranet-tmpl/lib/datatables/datatables.min_22.0600060.js:67 T http://localhost:8081/intranet-tmpl/lib/datatables/datatables.min_22.0600060.js:69 http://localhost:8081/intranet-tmpl/lib/datatables/datatables.min_22.0600060.js:144 iterator http://localhost:8081/intranet-tmpl/lib/datatables/datatables.min_22.0600060.js:138 http://localhost:8081/intranet-tmpl/lib/datatables/datatables.min_22.0600060.js:144 g http://localhost:8081/intranet-tmpl/lib/datatables/datatables.min_22.0600060.js:141 Ember 2 jQuery 9 Ember jQuery 13 members-home.pl:2281:37 This is because the categories object passed to template is branch limited -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 15:50:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 13:50:59 +0000 Subject: [Koha-bugs] [Bug 31685] Article request count in table caption of opac-user missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31685 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 15:51:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 13:51:03 +0000 Subject: [Koha-bugs] [Bug 31685] Article request count in table caption of opac-user missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31685 --- Comment #1 from Marcel de Rooy --- Created attachment 141381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141381&action=edit Bug 31685: Replace current_article_requests_count in opac-user Fixing the "( total)" in the caption of the table. The tt var should be replaced now by current_article_requests.size. Note that current_article_requests is an array now (from as_list). We cannot use .count since it is no Koha object. Test plan: Submit a few article requests. Check OPAC account page, and verify that both totals are fine now. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 15:51:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 13:51:32 +0000 Subject: [Koha-bugs] [Bug 31685] Article request count in table caption of opac-user missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31685 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 15:51:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 13:51:46 +0000 Subject: [Koha-bugs] [Bug 31685] Article request count in table caption of opac-user missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31685 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 15:52:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 13:52:03 +0000 Subject: [Koha-bugs] [Bug 31685] Article request count in table caption of opac-user missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31685 --- Comment #2 from Marcel de Rooy --- One liner for Tomas. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 15:55:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 13:55:30 +0000 Subject: [Koha-bugs] [Bug 31687] New: Add see from and see also from tracings in Match index Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31687 Bug ID: 31687 Summary: Add see from and see also from tracings in Match index Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com Some see from and see also from tracings are missing from the Match index. This means that if you search for a see from for a personal name, it will find it, but if you search for a see from for a topical term, it will not. I was comparing zebra's index mappings with ES's, and found that these were missing from ES's Match index. - 430(adfghklmnoprstvxyz) - 448(avxyz) - 450(abvxyz) - 451(avxyz) - 455(avxyz) - 530(adfghklmnoprstvxyz) - 548(avxyz) - 550(abvxyz) - 551(avxyz) - 555(avxyz) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 16:01:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 14:01:53 +0000 Subject: [Koha-bugs] [Bug 31654] Hide non-public libraries from MastheadLibraryPulldown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141123|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 16:14:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 14:14:12 +0000 Subject: [Koha-bugs] [Bug 26648] Prevent internal server error if item attached to old checkout has been removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141334|0 |1 is obsolete| | --- Comment #14 from PTFS Europe Sandboxes --- Created attachment 141382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141382&action=edit Bug 26648: Add tests Signed-off-by: Martin Renvoize Signed-off-by: Cab Vinton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 16:14:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 14:14:53 +0000 Subject: [Koha-bugs] [Bug 31665] 952$d ( Date acquired ) no longer prefills with todays date when focused In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Michael Adamyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk at ckls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 16:19:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 14:19:05 +0000 Subject: [Koha-bugs] [Bug 31688] New: Cannot set branches to non-public via administration Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31688 Bug ID: 31688 Summary: Cannot set branches to non-public via administration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Noticed this while testing Bug 31654. If I go to Administration > Libraries and try to set an existing branch to non-public I see the error: An error occurred when updating this library. Perhaps it already exists. If I try to add a new branch and set it to non-public it will be set to public instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 16:19:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 14:19:26 +0000 Subject: [Koha-bugs] [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Keith Sorbo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |keith at thesorbos.com --- Comment #2 from Keith Sorbo --- To help those who don't use diff, I have extracted the relevant sql to the following: ALTER TABLE reserves DROP FOREIGN KEY reserves_ibfk_4; ALTER TABLE reserves MODIFY COLUMN `branchcode` VARCHAR(10) COLLATE utf8mb4_unicode_ci NOT NULL; ALTER TABLE reserves ADD CONSTRAINT reserves_ibfk_4 FOREIGN KEY (branchcode) REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 16:20:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 14:20:14 +0000 Subject: [Koha-bugs] [Bug 30411] Add separate shelving location column to Holds Queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 16:22:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 14:22:06 +0000 Subject: [Koha-bugs] [Bug 31654] Hide non-public libraries from MastheadLibraryPulldown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 --- Comment #8 from Lucas Gass --- Awesome, thanks Thomas! I did notice two things, neither of which are your fault. 1. Should we update the hint on branches.tt which currently reads "Set to 'yes' to show this library on the Libraries page in the OPAC." 2. I cannot set branches to public via administration. I filed a seperate bug for this: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31688 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 16:23:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 14:23:06 +0000 Subject: [Koha-bugs] [Bug 29079] Make biblio info in holds queue customizable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29079 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org --- Comment #1 from Andrew Fuerste-Henry --- This would be handy! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 16:34:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 14:34:29 +0000 Subject: [Koha-bugs] [Bug 31676] Fix db_dependent/Circulation.t tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 --- Comment #3 from David Gustafsson --- Ok, that's strange. I think most of the test failing for me could pass with certain sysprefs set, but at least the one where two account lines are expected I just can't figure out how it would ever do so. In this test an item is issued with due date five weeks ago, UpdateFine is then run which creates an account line with type "OVERDUE" and status "UNRETURNED" (line 722 in current master). AddRenewal is then called twice for this item in turn calling _CalculateAndUpdateFine which checks for a fine calling CalcFine and then possibly calling UpdateFine if got a fine amount. In the first call to AddRenewal the due date is five weeks in the past, so CalcFine will return a fine. UpdateFine is then called which will fetch the account line and adjust the amount (to the same value as before), then calling _FixOverduesOnReturn which sets the account line status to "RENEWED". Due date for the issue is then set to a date in the future. In the second call CalcFine will not return a fine since due date is in the future thus UpdateFine is not called (which I have also verified in my instance). I just can't figure out how UpdateFine could ever add more than one account line in this test case. I also don't see any sysprefs or other state that is not already mocked which could effect AddRenewal behavior. Obviously since the tests work for you there should be such a case, but personally I can't figure out how to reproduce it. I also tried resetting all sysprefs to default values but this test still fails. From what I can see circulation rules are also cleared before running the tests so existing ones should not effect the results. The docker setup currently running koha on makes it very cumbersome to completely reset the koha instance to a completely clean installation, but if I had access to an instance where the tests do indeed pass it would probably be trial to find out what is causing this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 16:35:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 14:35:53 +0000 Subject: [Koha-bugs] [Bug 31676] Fix db_dependent/Circulation.t tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 --- Comment #4 from David Gustafsson --- *trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 16:41:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 14:41:58 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #75 from Heather --- In case this helps: This cataloger's mind thinks of things like this, with the caveat that I'm in the U.S.--please, others, correct me with global perspectives! These are "cataloguing tools:" Record importing, record creating, record editing. (Bibs, items, auts, etc.) I think of this as every day work. I want some people to have the ability to create/modify items, other people to have that power plus the power to create/modify bibs, and yet other people to have all those powers plus the power to create/modify auts. These are "catalogue administration:" Record deletion, batch record editing/modification, batch record deletion, MARC framework creation/editing, templates, etc.--absolutely every power in the creation, editing, deletion of records. I want some people to have all the powers of the "cataloguing tools" above plus all these powers. The more granularity in granting each of these powers to a particular user, the better. One thing I absolutely love about Koha, is that if you don't have permission for a function, you don't see it on your menu--this rocks! --h2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:00:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:00:19 +0000 Subject: [Koha-bugs] [Bug 30869] Stock rotation rotas cannot be deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- In it's most basic form, this should just be exposed as a delete button for any rota's that have no items attached. Thinking more widely, it would be nice to allow deletion regardless and give options to disassociate items from the rota at deletion time including setting where those items should end up. >From memory, non-cyclical rota's don't clean up after themselves either.. it might be nice to have the option to remove the item to rota link once at item hits it's final destination. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:00:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:00:30 +0000 Subject: [Koha-bugs] [Bug 30869] Stock rotation rotas cannot be deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:00:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:00:55 +0000 Subject: [Koha-bugs] [Bug 30869] Stock rotation rotas cannot be deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:09:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:09:23 +0000 Subject: [Koha-bugs] [Bug 15500] Add FRBRized View to OPAC & Staff Interface Results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15500 --- Comment #3 from Jason Robb --- Would love to see this working both in the staff client and OPAC, and would *really* love to see hold capability added to increase patron ease of access to resources with multiple editions living on different bib records. I wonder if Koha's existing authorities architecture could be leveraged as a jumping off point for this? There are some parallels. FRBR organizes things from the top-down - Work > Expression > Manifestation > Item Generally we're only handling Manifestations (at the bib level) and Items (at the item level) in Koha. We could potentially create a collection of "records" for Works similar to an authority file by pulling the general attributes out of existing bib records then merging them into singular "records" for each Work. The Work "record" could store the groupID along with other relevant information, including matchpoints like author, ISBNs and eventually links to external records of the work (LibraryThing, OpenLibrary, Wikidata, etc.) The identifier of the Work could then be added into relevant bib records (maybe the 775?) to create a horizontal link between multiple bib records. Ideally this would all be automated, where, if you bring in a bib record for new edition of an existing Work it gets linked to the existing Work automatically. And if that Work doesn't exist yet, a new Work "record" is generated. Authorities can do some of this type of thing already, just with different parts of the record. And some of the tools in the authorities module would also be useful for managing Works as far as editing, merging, etc. Just a thought! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:12:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:12:01 +0000 Subject: [Koha-bugs] [Bug 31687] Add see from and see also from tracings in Match index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31687 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 141383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141383&action=edit Sample records Some authority records with see from and see also from tracings Uniform title Chronological name Topical term Geographic name Genre/Form term -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:12:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:12:13 +0000 Subject: [Koha-bugs] [Bug 31687] Add see from and see also from tracings in Match index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31687 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:12:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:12:44 +0000 Subject: [Koha-bugs] [Bug 31687] Add see from and see also from tracings in Match index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31687 --- Comment #2 from Caroline Cyr La Rose --- Created attachment 141384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141384&action=edit Bug 31687: Add see from and see also from tracings in Match index This patch adds see from and see also from terms for uniform title, chronological term, topical term, geographic name, and genre/form term to the Match index in Elasticsearch for MARC21. Previously, only see from/see also from for personal names, corporate names, and meeting names were indexed. To test: 1. Without patch, import attached authority records 1.1. Download attached records 1.2. Go to Tools > Stage MARC records for import 1.3. Click 'Browse' and choose the downloaded file 1.4. Click 'Upload file' 1.5. Choose Record type = Authority 1.6. Click 'Stage for import' 1.7. From the job details, click 'View batch' 1.8. Click 'Import this batch into the catalog' 2. Without patch, search for see from and see also from tracings 2.1. Go to Authorities 2.2. In the 'Default' drop-down menu, choose 'Uniform title' 2.3. Choose the 'Search all headings' tab 2.4. Enter the search term 'Five hundred' 2.5. Click 'Submit' or press 'Enter' --> No results 2.6. Redo the search for the following search terms Authority type Search term Should be found in Uniform title five hundred 430 Uniform title films préférés 530 Chronological term fifteenth 448 Chronological term middle ages 548 Topical term lalopathie 450 Topical term troubles communication 550 Geographic name cécropia 451 Geographic name canada francophone 551 Genre/Form term filmiques 455 Genre/Form term films 555 3. Apply patch 4. Delete index, reset mappings and reindex authorities (with command line, -a -d -r) 5. Redo the searches from step 2, there should now be results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:12:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:12:58 +0000 Subject: [Koha-bugs] [Bug 31687] Add see from and see also from tracings in Match index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31687 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:15:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:15:15 +0000 Subject: [Koha-bugs] [Bug 31687] Add see from and see also from tracings in Match index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31687 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add see from and see also |Add see from and see also |from tracings in Match |from tracings in Match |index |index (Elasticsearch, | |MARC21) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:16:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:16:24 +0000 Subject: [Koha-bugs] [Bug 31687] Add see from and see also from tracings in Match index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31687 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds see release notes| |from and see also from | |terms for uniform title, | |chronological term, topical | |term, geographic name, and | |genre/form term to the | |Match index in | |Elasticsearch for MARC21. | |These will now be | |searchable in the | |Authorities module, by | |selecting the 'Search all | |headings' tab. | | | |Previously, | |only see from/see also from | |for personal names, | |corporate names, and | |meeting names were indexed | |and searchable this way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:18:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:18:53 +0000 Subject: [Koha-bugs] [Bug 31676] Fix db_dependent/Circulation.t tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 --- Comment #5 from David Gustafsson --- Now I got the test to work, the syspref cache wasn't probably cleared when ran it the first time. Tests fail for me since the "RenewalPeriodBase" syspref was set to "now". The default value is "date_due", so when renewing the item the new due date is still in the past and will incur fees also on the next renewal (even if the previously generated fee was calculated using the whole period). This is pretty weird behavior and perhaps should be looked over, but at least found the culprit and the tests should set this syspref to one of the options (personally would prefer "now" sisnce the "date_due"-behavior is pretty confusing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:25:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:25:19 +0000 Subject: [Koha-bugs] [Bug 31689] New: Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31689 Bug ID: 31689 Summary: Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com Some see from tracings are indexed in Match-heading-see-from, but not all. Currently indexed are 400, 410, and 411. Missing are 430, 448, 450, 451, and 455. I'm not sure exactly where this index is used, but I figure it's best that the index be complete rather than indexing only some types of authorities. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:27:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:27:57 +0000 Subject: [Koha-bugs] [Bug 31676] Fix db_dependent/Circulation.t tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 --- Comment #6 from David Gustafsson --- Setting RenewalPeriodBase to "now" also explains why the 'OverduesBlockRenewing'-tests failed for me, since when the period is "date_due" the item is still overdue even though it was renewed twice. So if using "now" theses tests has to be moved as in the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:28:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:28:59 +0000 Subject: [Koha-bugs] [Bug 31689] Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31689 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:29:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:29:03 +0000 Subject: [Koha-bugs] [Bug 31689] Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31689 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 141385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141385&action=edit Bug 31689: Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21) This patch adds the following fields to the Match-heading-see-from index - 430(adfghklmnoprstvxyz) - 448(avxyz) - 450(abvxyz) - 451(avxyz) - 455(avxyz) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:31:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:31:35 +0000 Subject: [Koha-bugs] [Bug 31689] Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31689 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com Text to go in the| |This enhancement adds release notes| |fields 430, 448, 450, 451, | |and 455 to the | |Match-heading-see-from. | | | |Previously, only 400, 410, | |and 411 were indexed. --- Comment #2 from Caroline Cyr La Rose --- Sorry, not sure how to test since I don't know where that index is used... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:35:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:35:57 +0000 Subject: [Koha-bugs] [Bug 31690] New: Add see from tracings in See-from index (Elasticsearch, MARC21) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31690 Bug ID: 31690 Summary: Add see from tracings in See-from index (Elasticsearch, MARC21) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com Some see from tracings are indexed in See-from, but not all. Currently indexed are 400, 410, 411, 430, 440, 441, 444, 447, 448, and 462. Missing are 450, 451, and 455. Also, 440, 441, and 444 are not valid MARC fields. But that is something for another bug... I'm not sure exactly where this index is used, but I figure it's best that the index be complete rather than indexing only some types of authorities. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:38:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:38:42 +0000 Subject: [Koha-bugs] [Bug 31690] Add see from tracings in See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31690 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:38:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:38:45 +0000 Subject: [Koha-bugs] [Bug 31690] Add see from tracings in See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31690 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 141386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141386&action=edit Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21) This patch adds the following fields to the See-from index - 450(abvxyz) - 451(avxyz) - 455(avxyz) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:39:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:39:11 +0000 Subject: [Koha-bugs] [Bug 31687] Add see from and see also from tracings in Match index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31687 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31689 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:39:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:39:11 +0000 Subject: [Koha-bugs] [Bug 31689] Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31689 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31687 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:39:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:39:19 +0000 Subject: [Koha-bugs] [Bug 31687] Add see from and see also from tracings in Match index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31687 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31690 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:39:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:39:19 +0000 Subject: [Koha-bugs] [Bug 31690] Add see from tracings in See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31690 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31687 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:39:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:39:45 +0000 Subject: [Koha-bugs] [Bug 31690] Add see from tracings in See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31690 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31689 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:39:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:39:45 +0000 Subject: [Koha-bugs] [Bug 31689] Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31689 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31690 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:40:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:40:47 +0000 Subject: [Koha-bugs] [Bug 31686] Branch limited patron categories can break patron searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31686 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:41:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:41:13 +0000 Subject: [Koha-bugs] [Bug 31690] Add see from tracings in See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31690 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com Text to go in the| |This enhancement adds release notes| |fields 450, 451, and 455 to | |the See-from index for | |MARC21. | | | |Previously, only | |400, 410, 411, 430, 447, | |448, and 462 were indexed. --- Comment #2 from Caroline Cyr La Rose --- Sorry, I'm not sure where this index is used so I don't know how to test... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:52:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:52:17 +0000 Subject: [Koha-bugs] [Bug 13965] Add date last seen on item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13965 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|date last seen on item |Add date last seen on item |search |search --- Comment #1 from Katrin Fischer --- I think this would be really helpful especially in combination with the inventory tool. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:55:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:55:23 +0000 Subject: [Koha-bugs] [Bug 12709] Send a custom email to some or all patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12709 --- Comment #6 from Katrin Fischer --- (In reply to Ray Delahunty from comment #5) > Isn't this a duplicate of Bug 16149 which added the ability to combine > report results with a custom notice to generate emails? I've been testing > out the new feature that came in 19.05 but as it doesn't support html in the > message we probably wont be able to use it. (Enhancement request being > worked on right now.) Bug 16149 relies on a plugin, I think this would be good to have in 'core'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:56:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 15:56:48 +0000 Subject: [Koha-bugs] [Bug 31691] New: Remove non-existent fields from the See-from index (Elasticsearch, MARC21) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31691 Bug ID: 31691 Summary: Remove non-existent fields from the See-from index (Elasticsearch, MARC21) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com The See-from index for MARC21 indexes fields that don't exist in the MARC21 format. The existing fields can be found here : https://www.loc.gov/marc/authority/ad4xx.html Here are the fields currently indexed that are not part of MARC21. - 411$b - 411$m - 411$o - 411$r - 430$b - 430$c - 430$e - 440(abcdefghjklmnopqrstvxyz) (all of them, 440 doesn't exist at all) - 441(abcdefghklmnoprstvxyz) (all of them, 441 doesn't exist at all) - 444(abcdefghjklmnopqrstvxyz) (all of them, 444 doesn't exist at all) - 447$b - 447$e - 447$f - 447$h - 447$j - 447$k - 447$l - 447$m - 447$n - 447$o - 447$p - 447$q - 447$r - 447$s - 447$t - 448$b - 448$c - 448$d - 448$e - 448$f - 448$g - 448$h - 448$k - 448$l - 448$m - 448$n - 448$o - 448$p - 448$r - 448$s - 448$t - 462$b - 462$c - 462$d - 462$e - 462$f - 462$g - 462$h - 462$k - 462$l - 462$m - 462$n - 462$o - 462$p - 462$r - 462$s - 462$t - 462$v - 462$x - 462$y - 462$z -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 18:03:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 16:03:39 +0000 Subject: [Koha-bugs] [Bug 31691] Remove non-existent fields from the See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31691 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 18:03:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 16:03:42 +0000 Subject: [Koha-bugs] [Bug 31691] Remove non-existent fields from the See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31691 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 141387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141387&action=edit Bug 31691: Remove non-existent fields from the See-from index (Elasticsearch, MARC21) This patch removes fields from the See-from index that don't exist in MARC21. The existing fields can be found here: https://www.loc.gov/marc/authority/ad4xx.html The following fields are removed: - 411$b - 411$m - 411$o - 411$r - 430$b - 430$c - 430$e - 440(abcdefghjklmnopqrstvxyz) (all of them, 440 doesn't exist at all) - 441(abcdefghklmnoprstvxyz) (all of them, 441 doesn't exist at all) - 444(abcdefghjklmnopqrstvxyz) (all of them, 444 doesn't exist at all) - 447$b - 447$e - 447$f - 447$h - 447$j - 447$k - 447$l - 447$m - 447$n - 447$o - 447$p - 447$q - 447$r - 447$s - 447$t - 448$b - 448$c - 448$d - 448$e - 448$f - 448$g - 448$h - 448$k - 448$l - 448$m - 448$n - 448$o - 448$p - 448$r - 448$s - 448$t - 462$b - 462$c - 462$d - 462$e - 462$f - 462$g - 462$h - 462$k - 462$l - 462$m - 462$n - 462$o - 462$p - 462$r - 462$s - 462$t - 462$v - 462$x - 462$y - 462$z -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 18:04:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 16:04:39 +0000 Subject: [Koha-bugs] [Bug 31691] Remove non-existent fields from the See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31691 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31690 Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com Text to go in the| |This enhancement removes release notes| |fields from the See-from | |index that don't exist in | |MARC21. | | | |The existing | |fields can be found here: | |https://www.loc.gov/marc/au | |thority/ad4xx.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 18:04:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 16:04:39 +0000 Subject: [Koha-bugs] [Bug 31690] Add see from tracings in See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31690 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31691 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 18:17:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 16:17:11 +0000 Subject: [Koha-bugs] [Bug 31692] New: Let librarians change item level holds to record level holds when possible Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Bug ID: 31692 Summary: Let librarians change item level holds to record level holds when possible Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: lari.taskula at hypernova.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Koha has item level holds (only a specific item was requested) and record level holds (any next available item). There can be a case when a librarian wishes to change an item level hold to a record level hold. This is currently not (easily) possible, as they would have to cancel the hold and then set another type of hold and place it to the previous point in hold queue. This Bug aims to add an easy way to change hold types. Only one type of hold is allowed simultaneously for a record and a patron. The two types cannot be mixed. In other words a patron can't have both item level and record level holds on a specific record at the same time. This must be kept in mind when designing such functionality. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 18:20:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 16:20:58 +0000 Subject: [Koha-bugs] [Bug 31693] New: Remove non-existent fields from the See-also-from index (Elasticsearch, MARC21) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31693 Bug ID: 31693 Summary: Remove non-existent fields from the See-also-from index (Elasticsearch, MARC21) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com The See-also-from index for MARC21 indexes fields that don't exist in the MARC21 format. The existing fields can be found here: https://www.loc.gov/marc/authority/ad5xx.html Here are the fields currently indexed that are not part of MARC21. - 511$b - 511$m - 511$o - 511$r - 530$b - 530$c - 530$e - 547$b - 547$e - 547$f - 547$h - 547$j - 547$k - 547$l - 547$m - 547$n - 547$o - 547$p - 547$q - 547$r - 547$s - 547$t - 548$b - 548$c - 548$d - 548$e - 548$f - 548$g - 548$h - 548$k - 548$l - 548$m - 548$n - 548$o - 548$p - 548$r - 548$s - 548$t - 550$c - 550$d - 550$e - 550$f - 550$h - 550$j - 550$k - 550$l - 550$m - 550$n - 550$o - 550$p - 550$q - 550$r - 550$s - 550$t - 551$b - 551$c - 551$d - 551$e - 551$f - 551$h - 551$k - 551$l - 551$m - 551$n - 551$o - 551$p - 551$r - 551$s - 551$t - 555$b - 555$c - 555$d - 555$e - 555$f - 555$g - 555$h - 555$j - 555$k - 555$l - 555$m - 555$n - 555$o - 555$p - 555$q - 555$r - 555$s - 555$t - 562$b - 562$c - 562$d - 562$e - 562$f - 562$g - 562$h - 562$k - 562$l - 562$m - 562$n - 562$o - 562$p - 562$r - 562$s - 562$t Also, the mapping for 511 is written differently than other mappings, with the a outside the parentheses. 511a(bcdefghjklmnopqrstvxyz) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 18:22:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 16:22:52 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 18:22:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 16:22:56 +0000 Subject: [Koha-bugs] [Bug 31693] Remove non-existent fields from the See-also-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31693 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 18:22:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 16:22:56 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #1 from Lari Taskula --- Created attachment 141388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141388&action=edit Bug 31692: Add Koha::Hold::change_type and unit tests To test: 1. prove t/db_dependent/Koha/Hold.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 18:23:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 16:23:00 +0000 Subject: [Koha-bugs] [Bug 31693] Remove non-existent fields from the See-also-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31693 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 141389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141389&action=edit Bug 31693 Remove non-existent fields from the See-also-from index (Elasticsearch, MARC21) This patch removes fields from the See-from index that don't exist in MARC21. The existing fields can be found here: https://www.loc.gov/marc/authority/ad5xx.html The following fields are removed: - 511$b - 511$m - 511$o - 511$r - 530$b - 530$c - 530$e - 547$b - 547$e - 547$f - 547$h - 547$j - 547$k - 547$l - 547$m - 547$n - 547$o - 547$p - 547$q - 547$r - 547$s - 547$t - 548$b - 548$c - 548$d - 548$e - 548$f - 548$g - 548$h - 548$k - 548$l - 548$m - 548$n - 548$o - 548$p - 548$r - 548$s - 548$t - 550$c - 550$d - 550$e - 550$f - 550$h - 550$j - 550$k - 550$l - 550$m - 550$n - 550$o - 550$p - 550$q - 550$r - 550$s - 550$t - 551$b - 551$c - 551$d - 551$e - 551$f - 551$h - 551$k - 551$l - 551$m - 551$n - 551$o - 551$p - 551$r - 551$s - 551$t - 555$b - 555$c - 555$d - 555$e - 555$f - 555$g - 555$h - 555$j - 555$k - 555$l - 555$m - 555$n - 555$o - 555$p - 555$q - 555$r - 555$s - 555$t - 562$b - 562$c - 562$d - 562$e - 562$f - 562$g - 562$h - 562$k - 562$l - 562$m - 562$n - 562$o - 562$p - 562$r - 562$s - 562$t Furthermore, the format of the mapping for 511 has been corrected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 18:23:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 16:23:01 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #2 from Lari Taskula --- Created attachment 141390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141390&action=edit Bug 31692: Allow librarians to change hold type in staff client To test: 1. Apply patch 2. Add item level hold to a record/item, make sure patron has no other holds on that record 3. Go to /cgi-bin/koha/reserve/request.pl?biblionumber=xxx where xxx is the record you placed the hold for 4. Under "Existing holds" table, in "Details" column you should see "Only item X". Click the red X and click Update hold(s) 5. Observe "Only item " has changed to "Next available" 6. Cancel the hold and add two item level holds 7. Under "Existing holds" table, in "Details" column you should see "Only item ", but no red X for either holds. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 18:23:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 16:23:19 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lari.taskula at hypernova.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 18:23:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 16:23:55 +0000 Subject: [Koha-bugs] [Bug 31693] Remove non-existent fields from the See-also-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31693 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31691 Text to go in the| |This enhancement removes release notes| |fields from the See-from | |index that don't exist in | |MARC21. | | | |The existing | |fields can be found here: | |https://www.loc.gov/marc/au | |thority/ad5xx.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 18:23:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 16:23:55 +0000 Subject: [Koha-bugs] [Bug 31691] Remove non-existent fields from the See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31691 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31693 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 18:24:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 16:24:30 +0000 Subject: [Koha-bugs] [Bug 31693] Remove non-existent fields from the See-also-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31693 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141389|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose --- Created attachment 141391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141391&action=edit Bug 31693 Remove non-existent fields from the See-also-from index (Elasticsearch, MARC21) This patch removes fields from the See-also-from index that don't exist in MARC21. The existing fields can be found here: https://www.loc.gov/marc/authority/ad5xx.html The following fields are removed: - 511$b - 511$m - 511$o - 511$r - 530$b - 530$c - 530$e - 547$b - 547$e - 547$f - 547$h - 547$j - 547$k - 547$l - 547$m - 547$n - 547$o - 547$p - 547$q - 547$r - 547$s - 547$t - 548$b - 548$c - 548$d - 548$e - 548$f - 548$g - 548$h - 548$k - 548$l - 548$m - 548$n - 548$o - 548$p - 548$r - 548$s - 548$t - 550$c - 550$d - 550$e - 550$f - 550$h - 550$j - 550$k - 550$l - 550$m - 550$n - 550$o - 550$p - 550$q - 550$r - 550$s - 550$t - 551$b - 551$c - 551$d - 551$e - 551$f - 551$h - 551$k - 551$l - 551$m - 551$n - 551$o - 551$p - 551$r - 551$s - 551$t - 555$b - 555$c - 555$d - 555$e - 555$f - 555$g - 555$h - 555$j - 555$k - 555$l - 555$m - 555$n - 555$o - 555$p - 555$q - 555$r - 555$s - 555$t - 562$b - 562$c - 562$d - 562$e - 562$f - 562$g - 562$h - 562$k - 562$l - 562$m - 562$n - 562$o - 562$p - 562$r - 562$s - 562$t Furthermore, the format of the mapping for 511 has been corrected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 18:25:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 16:25:09 +0000 Subject: [Koha-bugs] [Bug 31693] Remove non-existent fields from the See-also-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31693 --- Comment #3 from Caroline Cyr La Rose --- I corrected the index name in my commit message... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 19:11:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 17:11:41 +0000 Subject: [Koha-bugs] [Bug 12709] Send a custom email to some or all patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12709 --- Comment #7 from Nick Clemens --- (In reply to Katrin Fischer from comment #6) > (In reply to Ray Delahunty from comment #5) > > Isn't this a duplicate of Bug 16149 which added the ability to combine > > report results with a custom notice to generate emails? I've been testing > > out the new feature that came in 19.05 but as it doesn't support html in the > > message we probably wont be able to use it. (Enhancement request being > > worked on right now.) > > Bug 16149 relies on a plugin, I think this would be good to have in 'core'. To clarify, 16149 is a command line script, there is also a plugin, but they are separate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 19:23:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 17:23:45 +0000 Subject: [Koha-bugs] [Bug 31676] Fix db_dependent/Circulation.t tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 --- Comment #7 from David Gustafsson --- To make the 'Incremented fee tests' fail set CircControl to "ItemHomeLibrary" (which is the default) and HomeOrHoldingBranch to "homebranch" (default is "holdingbranch"). The test will now fail since the item does not have the correct homebranch set (since is set using $library->{branchcode} where library is an object). The reason why the tests pass anyway despite missing both homebranch and holdingbranch is that holdingbranch is set when one of the tests calls AddIssue which will in turn set the expected holdingbranch from userenv ($item_object->holdingbranch(C4::Context->userenv->{'branch'})); The $item will then have the expected homebranch (but not holdingbranch) for the rest of the tests. If the item is passed the correct branch value to begin with all combinations of the above settings will work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 19:26:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 17:26:41 +0000 Subject: [Koha-bugs] [Bug 31676] Fix db_dependent/Circulation.t tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 --- Comment #8 from David Gustafsson --- Will update the testplan (probably tomorrow) so includes how to reproduce the test-bugs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 19:50:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 17:50:50 +0000 Subject: [Koha-bugs] [Bug 29719] onloan dates are cleared from items when importing and overlaying In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29719 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #14 from Lucas Gass --- Can this be backported to 21.11? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 20:10:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 18:10:55 +0000 Subject: [Koha-bugs] [Bug 31333] Add the ability to limit purchase suggestions by patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 --- Comment #41 from Tomás Cohen Arazi --- Created attachment 141392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141392&action=edit Bug 31333: (QA follow-up) Move and improve tests This patch moves tests to the right file (singular class name). It also refactors them a bit, in order to cover more cases, including the syspref split one. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Patron/Category.t \ t/db_dependent/Koha/Patron/Categories.t => SUCCESS: All good. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 20:27:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 18:27:08 +0000 Subject: [Koha-bugs] [Bug 20732] Display the note tab for records without items. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20732 Elaine Bradtke changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eb at efdss.org --- Comment #1 from Elaine Bradtke --- Alternatively, would it be possible to switch off the Holdings tab completely or at least hide the number in parenthesis in records that don't have items? Users look at the Holdings(0) and think we don't have it, when in fact it's online, or a component of a larger item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 20:52:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 18:52:15 +0000 Subject: [Koha-bugs] [Bug 31333] Add the ability to limit purchase suggestions by patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 --- Comment #42 from Tomás Cohen Arazi --- Created attachment 141393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141393&action=edit Bug 31333: (QA follow-up) Simplify code The new syspref is a deny-list. So not being part of the list means you are allowed. This was not that clear reading the code, so this patch tries to simplify the logic. Better handling on undef syspref value is added as well to avoid useless warnings. This patch does the following changes: - Uses `any` instead of `grep`. This has the effect of just returning a boolean on the first match, instead of keep looping until de array Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 20:58:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 18:58:59 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #76 from Barbara Johnson --- I agree with David's comment 73 that we should bring back the toolbar at the top (with Advanced editor, New record and New from Z3950/SRYU buttons) rather than putting it under the "New" sub-heading. I think retaining the toolbar will be better both functionally and aesthetically. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:03:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:03:42 +0000 Subject: [Koha-bugs] [Bug 21705] Map copryrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 --- Comment #4 from Caroline Cyr La Rose --- Hi David, I think you were misled by my test plan. I copy-pasted from another one and forgot to change everything I should have... I'm rewriting the test plan and hopefully I won't make any more mistakes... Caroline -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:04:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:04:22 +0000 Subject: [Koha-bugs] [Bug 31333] Add the ability to limit purchase suggestions by patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|Exclude patron categories |Exclude patron categories released in|from submitting OPAC |from submitting OPAC |purchase suggestions by |purchase suggestions by |selecting them in the new |selecting them in the new |suggestionPatronCategoryExc |suggestionPatronCategoryExc |eptions system preference. |eptions system | |preference.,22.11.00 Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:04:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:04:25 +0000 Subject: [Koha-bugs] [Bug 31333] Add the ability to limit purchase suggestions by patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 --- Comment #43 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:04:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:04:28 +0000 Subject: [Koha-bugs] [Bug 21705] Map copryrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:04:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:04:29 +0000 Subject: [Koha-bugs] [Bug 31371] Value builder for UNIMARC field 283 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31371 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:04:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:04:32 +0000 Subject: [Koha-bugs] [Bug 31371] Value builder for UNIMARC field 283 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31371 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:04:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:04:32 +0000 Subject: [Koha-bugs] [Bug 21705] Map copryrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128186|0 |1 is obsolete| | --- Comment #5 from Caroline Cyr La Rose --- Created attachment 141394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141394&action=edit Bug 21705: Map copryrightdate to both 260/264c by default for new MARC21 installations This patch adds a mapping from 264 to biblio.copyrightdate. To test: 1. Apply patch 2. Delete existing frameworks 2.1. In the database, run the following commands delete from marc_tag_structure; delete from marc_subfield_structure; delete from biblio_framework; 3. Load default framework 3.1. In a terminal, run ./misc/load_yaml.pl -f installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml --load 4. In the staff interface, go to Administration > MARC bibliographic framework --> The default framework should be there 5. Make 264c appear in the editor 5.1. In Administration > MARC bibliographic framework, click on Actions > MARC structure next to the default framework 5.2. Search for 264 5.3. Click on Actions > Edit subfields 5.4. Click on tab c 5.5. Check the 'Editor' box 5.6. Click 'Save changes' 6. In Administration > Koha to MARC mapping, check the mappings for biblio.copyrightdate 6.1. Go to Administration > Koha to MARC mapping 6.2. Search for copyrightdate --> biblio.copyrightdate should be mapped to 260c as well as 264c 7. Create a bibliographic record with a value in 264c 7.1. Go to Cataloging 7.2. Click 'New record' 7.3. Fill in mandatory fields (000, 003, 005, 008, 040c, 245a, 942c) 7.4. Enter a date in 264c 7.5. Click 'Save' 7.6. Note the record number (no need to add an item) 8. Create a bibliographic record with a value in 260c 8.1. Go to Cataloging 8.2. Click 'New record' 8.3. Fill in mandatory fields (000, 003, 005, 008, 040c, 245a, 942c) 8.4. Enter a date in 260c 8.5. Click 'Save' 8.6. Note the record number (no need to add an item) 9. Check the database biblio entry for both records, they should both have a value for copyrightdate 9.1. In the database, enter the following query, replacing AA with your biblionumber from step 7.6 and BB with the biblionumber from 8.6 select biblionumber, copyrightdate from biblio where biblionumber in (AA, BB) --> Both biblios should have a date in copyrightdate I hope I didn't forget anything! :) Caroline -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:04:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:04:34 +0000 Subject: [Koha-bugs] [Bug 31372] Value builder for UNIMARC field 325 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31372 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:04:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:04:37 +0000 Subject: [Koha-bugs] [Bug 31372] Value builder for UNIMARC field 325 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31372 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:04:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:04:40 +0000 Subject: [Koha-bugs] [Bug 31536] Add UNIMARC framework plugin to fetch PPN from sudoc.fr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31536 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:04:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:04:43 +0000 Subject: [Koha-bugs] [Bug 31536] Add UNIMARC framework plugin to fetch PPN from sudoc.fr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31536 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:30:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:30:17 +0000 Subject: [Koha-bugs] [Bug 31694] New: MARC overlay rules presets don't change anything if presets are translated Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Bug ID: 31694 Summary: MARC overlay rules presets don't change anything if presets are translated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In MARC overlay rules, if the preset names are not in English, the settings don't change. Example 1. In staff interface in English, go to Administration > MARC overlay rules 2. In the 'Preset' column, try the different options. Notice the Added, Appended, Removed, Deleted settings change according to the preset you chose 3. Change interface in another language (I tried fr-CA and de-DE) 4. Try the presets again. Note that if the preset name is in English (some in fr-CA are not translated), the settings change, but if the preset name is translated, nothing changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:32:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:32:40 +0000 Subject: [Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #1 from Caroline Cyr La Rose --- I'm putting this as 'normal', maybe it should be 'major'... The functionality doesn't work in other languages than English -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:33:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:33:17 +0000 Subject: [Koha-bugs] [Bug 31338] Show in advanced search when IncludeSeeFromInSearches is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31338 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141010|0 |1 is obsolete| | --- Comment #23 from PTFS Europe Sandboxes --- Created attachment 141395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141395&action=edit Bug 31338: Show in advanced search when IncludeSeeFromInSearches is used Test plan : 1) Apply patch 2) Set system preference IncludeSeeFromInSearches to "Include" 3) Go to staff interface advanced search 4) Check you see tip text in "Search for" 5) Set system preference IncludeSeeFromInSearches to "Don't include" 6) Go to staff interface advanced search 7) Check you don't see tip text in "Search for" Signed-off-by: Owen Leonard Signed-off-by: Lucas Gass Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:33:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:33:21 +0000 Subject: [Koha-bugs] [Bug 31338] Show in advanced search when IncludeSeeFromInSearches is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31338 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141178|0 |1 is obsolete| | --- Comment #24 from PTFS Europe Sandboxes --- Created attachment 141396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141396&action=edit Bug 31338: (follow-up) add special class and add also to OPAC In order to easily hide this new text, this patch adds the class "included-see-from-headings-info". Also uses
    instead of

    . And adds the same feature to OPAC. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:34:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:34:17 +0000 Subject: [Koha-bugs] [Bug 31338] Show in advanced search when IncludeSeeFromInSearches is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31338 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov Status|Needs Signoff |Signed Off --- Comment #25 from Barbara Johnson --- This worked in both the staff interface and the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:35:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:35:06 +0000 Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:35:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:35:09 +0000 Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #39 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:35:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:35:12 +0000 Subject: [Koha-bugs] [Bug 31465] Link system preference tabs to correct manual pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31465 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:35:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:35:16 +0000 Subject: [Koha-bugs] [Bug 31465] Link system preference tabs to correct manual pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31465 --- Comment #15 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:35:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:35:19 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:35:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:35:22 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:35:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:35:25 +0000 Subject: [Koha-bugs] [Bug 31685] Article request count in table caption of opac-user missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31685 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:35:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:35:27 +0000 Subject: [Koha-bugs] [Bug 31685] Article request count in table caption of opac-user missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31685 --- Comment #3 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:35:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:35:51 +0000 Subject: [Koha-bugs] [Bug 31333] Add the ability to limit purchase suggestions by patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Version(s)|Exclude patron categories |22.11.00 released in|from submitting OPAC | |purchase suggestions by | |selecting them in the new | |suggestionPatronCategoryExc | |eptions system | |preference.,22.11.00 | Text to go in the| |Exclude patron categories release notes| |from submitting OPAC | |purchase suggestions by | |selecting them in the new | |suggestionPatronCategoryExc | |eptions system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:44:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:44:12 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141308|0 |1 is obsolete| | --- Comment #10 from Chris Cormack --- Created attachment 141397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141397&action=edit Bug 31666: Add job progress bar to stage-marc-import.pl It would be nice if we had progress bars to indicate the progress of background jobs for scripts that utilize them. This patch implements a reusable bootstrap based progess bar. Test Plan: 1) Apply this patch 2) Stage a marc batch ( preferrably a large one to show the progress updating ) 3) Note the new progess bar, verify it functions correctly. Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:44:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:44:15 +0000 Subject: [Koha-bugs] [Bug 15500] Add FRBRized View to OPAC & Staff Interface Results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15500 --- Comment #4 from Heather --- Oh, Jason, your thoughts are so cataloging-tastic!! (Please note, all my remarks are MARC21-centric.) Authority records have long had a role in this sort of clustering, e.g., see this authority record for The Hobbit by Tolkien: https://lccn.loc.gov/n79102640 And the work record here: http://experiment.worldcat.org/entity/work/data/449428 Every expression of this work will have the authorized 100 field for Tolkien and a 240 10 Hobbit With the 245 field reflecting the transcribed title of the expression. The 100/240 pairing is used (with the cross references in the authority record to facilitate searching) to cluster the expressions (and manifestations) under the work record. (With the 1XX in the bib having the $9 containing the record number of the author/title authority record? And/or the 240 having this $9? I'm not sure how it's currently working--I could look into it & experiment if it's helpful.) But not all works have authority records, and authorities can be a big learning curve. And not all bibs with a 1XX/240 pairing have authority records. If Koha could use the pre-RDA (and early RDA) 1XX/240 pairings to cluster, that would be fabulous. If this could be a simple matter of developer magic, that would be lovely! But, yes, 7XX Linking Entry Fields are wonderful and can also be used!!! It's what they are there for, and where RDA is going--they're going to be used more and m ore. All linking entry links in Koha would have to be functional, but that's another bug(s) and soapbox...:) A 775 is perfect for actual other editions (you cataloger, you, Jason!), but you would sometimes have a 776 ("Additional Physical Form Entry") for ebooks of a book, audiobooks of a book, etc.--that is, e.g., an audiobook would have the 776 linking back to the print book from which it was read, and also a 775 back to the work record--so a bib record would have to be created for the work. This is really easy to do, and I think it would be easier for a lot of libraries to do than to wade into authorities. Because you have to have something to put into the $w of the 775--a record number (for OCLC libraries, its typically an OCLC record number in the corresponding 001 bib record). It would be very possible to automate this--once a bib record set is created of the expressions, and a work bib record is created, the identical 775 could be placed in all the manifestations of the bib. But, then again, wouldn't it be nice if there could be some developer magic that would allow the library to set the matching threshold, and then a search would just cluster the similar bibs together, based on matching 1XX and/or 24X fields? (And absolutely clustering those bibs that have an authority record with corresponding 1XX/240, or 130, or those bibs with 1000% matching 775s?) Cheerio! h2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:44:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:44:34 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141309|0 |1 is obsolete| | --- Comment #11 from Chris Cormack --- Created attachment 141398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141398&action=edit Bug 31666: (QA follow-up) Add filters Signed-off-by: Martin Renvoize Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:44:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:44:51 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141310|0 |1 is obsolete| | --- Comment #12 from Chris Cormack --- Created attachment 141399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141399&action=edit Bug 31666: (QA follow-up) Remove ES template literals Signed-off-by: Martin Renvoize Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:46:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:46:41 +0000 Subject: [Koha-bugs] [Bug 21705] Map copryrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:46:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 19:46:44 +0000 Subject: [Koha-bugs] [Bug 21705] Map copryrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141394|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 141400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141400&action=edit Bug 21705: Map copryrightdate to both 260/264c by default for new MARC21 installations This patch adds a mapping from 264 to biblio.copyrightdate. To test: 1) Apply patch 2) Delete existing frameworks - In the database delete from marc_tag_structure; delete from marc_subfield_structure; delete from biblio_framework; 3) Load default framework - In a terminal, run ./misc/load_yaml.pl -f installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml --load 4) In the staff interface, go to Administration > MARC bibliographic framework - Make sure the default framework is there 5) In Administration > Koha to MARC mapping, check the mappings for biblio.copyrightdate - biblioitems.publishercode should be mapped to 260 as well as 264 6) Create a bibliographic record with a value in 264 - In the database, check the biblio entry for this record, the value from 264 should be in copyrightdate 7) Create a bibliographic record with a value un 260 - In the database, check the biblio entry for this record, the value from 264 should be in copyrightdate I hope I didn't forget anything! :) Caroline Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 22:04:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 20:04:15 +0000 Subject: [Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 22:04:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 20:04:20 +0000 Subject: [Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #2 from Caroline Cyr La Rose --- Created attachment 141401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141401&action=edit Bug 31694: MARC overlay rules presets don't change anything if presets are translated This patch corrects option value names in MARC overlay rules to prevent them from being translated. To test: 1. Install a new language 1.1. In a terminal, run the following commands gulp po:update cd misc/translator ./translate install xx-XX 1.2. Go to Administration > Global system preferences 1.3. Search for language 1.4. In the language syspref check the box for the language you just installed 1.5. Save 2. In the staff interface in English, go to Administration > Record overlay rules 3. In the column 'Preset' try the various options, note that the 'Added', 'Appended', 'Removed', and 'Deleted' settings change depending on the chosen preset 4. Change the interface language 5. Redo step 3, notice that if the preset name is translated, the other settings don't change 6. Apply patch 7. Redo step 3, the presets should now change the settings -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 22:05:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 20:05:40 +0000 Subject: [Koha-bugs] [Bug 21705] Map copryrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 --- Comment #7 from David Nind --- Created attachment 141402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141402&action=edit Screenshots - Display of 260c (has a label) and 264c (has no label) (In reply to Caroline Cyr La Rose from comment #4) > Hi David, > > I think you were misled by my test plan. I copy-pasted from another one and > forgot to change everything I should have... I'm rewriting the test plan and > hopefully I won't make any more mistakes... > > Caroline Thanks Caroline for the comprehensive updated test plan! It made it very easy to test. I've signed off, but did note that: 1. For step 7 with the 264c, the date I entered shows in the normal display (and the OPAC) as a date on its own line - without any label. 2. For step 8 with the 260c, the date I entered shows in the normal display after the label "Publication details". See the attached screenshots. Also, I'm not sure why, but the commit message changed back to the original one when I signed it off (comment #6). David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 22:06:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 20:06:17 +0000 Subject: [Koha-bugs] [Bug 21705] Map copyrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Map copryrightdate to both |Map copyrightdate to both |260/264c by default for new |260/264c by default for new |MARC21 installations |MARC21 installations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 22:07:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 20:07:02 +0000 Subject: [Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #3 from Caroline Cyr La Rose --- I provided a patch... I just changed the option names to make them different from their labels. Since they were the same, I think the translator tool translated everything, name and label, and it couldn't recognize it afterwards... I hope that was the correct correction. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 22:16:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 20:16:45 +0000 Subject: [Koha-bugs] [Bug 21705] Map copyrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 --- Comment #8 from Caroline Cyr La Rose --- (In reply to David Nind from comment #7) > > Thanks Caroline for the comprehensive updated test plan! It made it very > easy to test. > > I've signed off, but did note that: > > 1. For step 7 with the 264c, the date I entered shows in the normal display > (and the OPAC) as a date on its own line - without any label. > > 2. For step 8 with the 260c, the date I entered shows in the normal display > after the label "Publication details". > > See the attached screenshots. > Yes, that is normal, it has to do with indicators. Since 264 can be used for more than publication (it can be used for production information, manufacture information, etc.) it needs to know what you are cataloguing in there exactly. If you want 'Publication', you need to write 1 in the second indicator https://www.loc.gov/marc/bibliographic/bd264.html > Also, I'm not sure why, but the commit message changed back to the original > one when I signed it off (comment #6). Not sure either... I was sure I'd obsoleted the older patch... Maybe someone more used to bugzilla will be able to enlighten us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 22:17:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 20:17:39 +0000 Subject: [Koha-bugs] [Bug 31695] New: Type standard number is missing field ci_raw in field_config.yaml Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695 Bug ID: 31695 Summary: Type standard number is missing field ci_raw in field_config.yaml Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com In Elasticsearch fields config field_config.yaml, default type as a field 'ci_raw'. This is used for exact search. This field is missing for type standard number 'stdno'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 22:17:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 20:17:46 +0000 Subject: [Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27153 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 22:17:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 20:17:46 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31695 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 22:17:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 20:17:53 +0000 Subject: [Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 22:20:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 20:20:15 +0000 Subject: [Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695 --- Comment #1 from Fridolin Somers --- One can see here the call with ci_raw https://git.koha-community.org/Koha-community/Koha/src/commit/2f583efa5b399dee241cdb128d0e849b432314b6/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm#L400 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 22:21:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 20:21:24 +0000 Subject: [Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #4 from Caroline Cyr La Rose --- Ok my patch doesn't 100% work. If you save the rule, it's the option name (the ugly one) rather than the label that appears... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 22:27:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 20:27:21 +0000 Subject: [Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 22:27:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 20:27:25 +0000 Subject: [Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695 --- Comment #2 from Fridolin Somers --- Created attachment 141403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141403&action=edit Bug 31695: Type standard number is missing field ci_raw in field_config.yaml In Elasticsearch fields config field_config.yaml, default type as a field 'ci_raw'. This is used for exact search. This field is missing for type standard number 'stdno'. Test plan : 1) Use Elasticsearch search engine 2) For authorities, configure a search field with type 'standard number' 3) Go to authorities search 4) Perform a search on an existing value, with 'contains' => Result is found with or without patch 5) Perform a search on an existing value, with 'is exactly' => Result is found only with patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 22:31:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 20:31:37 +0000 Subject: [Koha-bugs] [Bug 31696] New: Allow staff to choose default sort order of column configurable tables Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31696 Bug ID: 31696 Summary: Allow staff to choose default sort order of column configurable tables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It would be pretty handy if staff could choose the default_sort_order of various tables in Koha. I often write jQuery to change the sort order and it would be nice if it could be done via administration. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 22:34:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 20:34:16 +0000 Subject: [Koha-bugs] [Bug 31420] Managing funds: Labels of statistic fields overlap with pull downs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31420 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141303|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 141404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141404&action=edit Bug 31420: Managing funds: Labels of statistic fields overlap with pull downs This patch removes some very old inline style attributes from the fund edit form. The "white-space" attribute prevented label text from naturally wrapping. To test, apply the patch and go to Administration -> Funds. - In the list of funds, click Actions -> Edit. - The the form, confirm that the text of the "Statistic" 1 and 2 labels wraps, not getting hidden by the associated select tags. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 22:34:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 20:34:41 +0000 Subject: [Koha-bugs] [Bug 31420] Managing funds: Labels of statistic fields overlap with pull downs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31420 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 23:04:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 21:04:17 +0000 Subject: [Koha-bugs] [Bug 31697] New: Show patron category names rather than codes on overdue notice & status triggers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31697 Bug ID: 31697 Summary: Show patron category names rather than codes on overdue notice & status triggers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: andrewfh at dubcolib.org QA Contact: testopia at bugs.koha-community.org On /cgi-bin/koha/tools/overduerules.pl we list patron categories by code and do not show the category names. In most other places we either show both values or just show the name. I'd like to just show the category name on this page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 23:05:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 21:05:40 +0000 Subject: [Koha-bugs] [Bug 21705] Map copyrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 --- Comment #9 from David Nind --- (In reply to Caroline Cyr La Rose from comment #8) > Yes, that is normal, it has to do with indicators. Since 264 can be used for > more than publication (it can be used for production information, > manufacture information, etc.) it needs to know what you are cataloguing in > there exactly. If you want 'Publication', you need to write 1 in the second > indicator https://www.loc.gov/marc/bibliographic/bd264.html Thanks Caroline! There is always something to learn with MARC21 and cataloguing... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 00:10:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 22:10:36 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #19 from David Nind --- I tested again using KTD and updated message changes for the test plan. I also added a test for when the patron account has outstanding charges. Setup 1. Apply patches, updatedatabase, flush_memcached, restart_all 2. Enable OpacTrustedCheckout system preference Testing the API 1. Get details of items for a record: - Visit http://127.0.0.1:8080/api/v1/public/items?external_id=39999000005097 ==> should return details for the item Test the self-checkout feature: 1. Go to the OPAC home page 2. Login as a patron (in this case I used koha), and note that in the OPAC header there is now a Self checkout option after Cart and Lists 3. Click on Self checkout ==> window pops up asking you to enter a barcode 4. Enter a barcode for an item that is available, for example: 39999000006094 ==> Message should say: "Item '39999000006094' was checked out", and an option to enter another barcode, as well as Submit and Close buttons 5. Click close and check your account > your summary: item checked out should be listed 6. Repeat step 4 with the same barcode, this time the result should be: ==> Message says: "Item will be renewed" . Click Confirm (note: currently this appears to do nothing - stays on the same screen - it does renew the item though (see your summary)) 7. Checkout an item to another patron using the staff interface . Example: checked out 39999000011418 to Mary Burton 9. Use the self-checkout to try and checkout this item: ==> Message says: "This item appears to be checked out to another patron, please return it to the desk Message code 'issued_borrowernumber' with data '49' Message code 'issued_cardnumber' with data '23529000651225' Message code 'issued_firstname' with data 'Mary' Message code 'issued_surname' with data 'Burton'" . Click confirm (note that nothing appears to change, however: item is returned, then checked out - no longer checked out to Mary) 10. Use the self-checkout to try and checkout an item on hold: . Place a hold for an item for another patron using the staff interface. Example: Placed a record level hold for Programming the Perl DBI (biblionumber = 13) ==> Message says: "This item appears to be reserved for another patron, please return it to the desk Message code 'resborrowernumber' with data '49' Message code 'resbranchcode' with data 'MPL' Message code 'rescardnumber' with data '23529000651225' Message code 'reserve_id' with data '1' Message code 'resfirstname' with data 'Mary' Message code 'resreservedate' with data '2022-10-05' Message code 'ressurname' with data 'Burton'" Has Confirm and Close buttons . Click confirm (checks item out to you, hold is still in place for the other patron) 11. Use the self checkout to try and checkout an item on hold for your OPAC patron: . Place a record-level hold for an item using the staff interface (used Perl Better Practices, biblionumber = 19) . Check in an item for the record and confirm the hold (used 39999000008036), should show status as awaiting pickup . Use the self checkout to try and checkout this item to the patron the hold was placed for (39999000008036 and patron koha in this instance) ==> Item should be successfully checked out with message "Item '39999000008036' was checked out", with options to enter another barcode, Submit and Close buttons ==> Click close and check your account > your summary: item checked out should be listed 12. Try and checkout and item not for loan: . Update an item for a record so that is not for loan . Try and checkout using the self-checkout ==> message says: "This item is not normally for loan, please select another or ask at the desk Message code 'item_notforloan' with data '1'" Has Submit and Close buttons ==> Item does not check out, as expected. 13. Try and checkout an item recorded as Withdrawn: . Update an item for a record so that it is withdrawn . Try and checkout using the self-checkout ==> message says: "This item is marked withdrawn, please select another or ask at the desk" 14. Add a manual charge for the koha patron then try and check out an item. . Add a manual invoice for the koha patron of $20. ==> message says: "Message code 'DEBT' with data '20'" ==> Does not checkout item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 01:20:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 23:20:12 +0000 Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138653|0 |1 is obsolete| | --- Comment #24 from Michael Hafen --- Created attachment 141405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141405&action=edit Bug 28726: Add sort1 and sort2 to patron card creator - patron search. [ 2022-10-05 updated for recommendations: AV and select2 ] Bug 28726: Add sort1 and sort2 to patron card creator - patron search. Also adds a select all / clear all and checkboxes. Test plan: 1. start a new batch in the patron card creator (Tools -> Patron card creator -> New -> card batch) 2. click the Add patron(s) button. Observe that Category and Library are the on ly options. 3. Close search for patron window. 4. Apply patch. 5. click the Add patron(s) button. Observe that you can now search for patrons by their sort1 and sort2 values. 6. perform a search and observe the 'Select all | Clear all | Add selected patro ns' links and button. 7. use the Select all link to select all the patrons found by the search. 8. use the Add selected patrons button to add the selected patrons to the card b atch's Add by borrowernumber(s) text input field. 9. close the search for patron window. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 01:20:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2022 23:20:34 +0000 Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 04:49:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 02:49:42 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA Keywords|additional_work_needed | --- Comment #30 from Tomás Cohen Arazi --- Follow-up patches pushed. Thanks, Martin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 04:49:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 02:49:51 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 10:22:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 08:22:32 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 10:28:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 08:28:38 +0000 Subject: [Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 11:29:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 09:29:29 +0000 Subject: [Koha-bugs] [Bug 31697] Show patron category names rather than codes on overdue notice & status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31697 --- Comment #1 from Katrin Fischer --- Hm, that's odd, in 20.11 it does show the patron category descriptions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 11:30:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 09:30:43 +0000 Subject: [Koha-bugs] [Bug 31697] Show patron category names rather than codes on overdue notice & status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31697 --- Comment #2 from Katrin Fischer --- Just quickly checked in a sandbox - also showing the descrptions there. Can you post a screenshot or is it a misunderstanding? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 11:44:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 09:44:53 +0000 Subject: [Koha-bugs] [Bug 31696] Allow staff to choose default sort order of column configurable tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31696 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29648 --- Comment #1 from Katrin Fischer --- Hi Lucas, that's already implemented for some tables with less complicated sort: bug 29648 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 11:44:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 09:44:53 +0000 Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31696 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 11:51:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 09:51:54 +0000 Subject: [Koha-bugs] [Bug 7826] Standardize link for triggering plugins and auto-entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7826 --- Comment #7 from Katrin Fischer --- Maybe as a first small step we could replace the ... with the icon used in the cataloguing editor? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 12:50:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 10:50:46 +0000 Subject: [Koha-bugs] [Bug 25795] Add OAuth2 scopes to REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25795 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20627 CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 12:50:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 10:50:46 +0000 Subject: [Koha-bugs] [Bug 20627] Prevent leakages of user permissions to api access tokens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20627 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25795 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 13:26:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 11:26:07 +0000 Subject: [Koha-bugs] [Bug 31678] Convert authority editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 13:39:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 11:39:40 +0000 Subject: [Koha-bugs] [Bug 31652] Add geo-search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31652 --- Comment #1 from Thomas Klausner --- Created attachment 141406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141406&action=edit Bug 31652: Add geo-search This patch adds geosearch to Koha (using Elasticsearch 7). ElasticSearch search_mappings get new types to store lat/lon, which can be indexed from MARC 034$s and 034$t. There is a small change to the DB to allow a new value in search_field.type ENUM. The QueryBuilder is extended to allow for building advanced ElasticSearch Querys (eg geo_distance) that cannot be represented in a simple string query. The UI for searching (including showing the results on a OSM/Leaflet map) is implemented in a separate plugin (https://github.com/HKS3/HKS3GeoSearch) Test Plan: * make sure you're running ElasticSearch 7 (eg via `curl http://es:9200?pretty | grep number`) * apply patch * Set system preference "SaerchEngine" to "Elasticsearch" * got to a Framework, check Editor for 034$s and 034$t and save * got to some books (in the correct framework) and enter some lat and lon into 034$s and 034$t (for example lat=48.216, lon=16.395) * Run the elasticsearch indexer, maybe limited on the books you edited (-bn 123 -bn 456): misc/search_tools/rebuild_elasticsearch.pl -b -v * You can check if the indexing worked by inspecting the document in elasticsearch: * get the biblionumber (eg 123) * curl http://es:9200/koha_kohadev_biblios/_doc/123?pretty | grep -A5 geolocation * You should get back a JSON fragment containing the lat/lon you stored * You can query elasticsearch directly: * Run the following curl command, but adapt the value for lat/lng and/or the distance (in meters) * curl -X GET "http://es:9200/koha_kohadev_biblios/_search?pretty" -H 'Content-Type: application/json' -d '{"query": {"bool":{"must":{"match_all":{}},"filter":{"geo_distance":{"distance":100000,"geolocation":{"lat":48.2,"lon":16.4}}}}}}' * To run the search via Koha, you need to either install and use https://github.com/HKS3/HKS3GeoSearch or create a handcrafted query string: * handcrafted query string: * /cgi-bin/koha/opac-search.pl?advsearch=1&idx=geolocation&q=lat:48.25+lng:18.35+distance:100km&do=Search * HKS3GeoSearch * install the plugin and enable it * got to OPAC / Advanced Search * There is a new input box "Geographic Search" where you can enter lat/long/radius * On the search result page a map is shown with pins for each found biblioitem Sponsored-by: ZAMG - Zentralanstalt für Meterologie und Geodynamik, Austria - https://www.zamg.ac.at/ This is a combination of 17 commits. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 13:42:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 11:42:26 +0000 Subject: [Koha-bugs] [Bug 31652] Add geo-search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31652 Thomas Klausner changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 13:43:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 11:43:13 +0000 Subject: [Koha-bugs] [Bug 31678] Convert authority editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 13:43:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 11:43:17 +0000 Subject: [Koha-bugs] [Bug 31678] Convert authority editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 --- Comment #1 from Owen Leonard --- Created attachment 141407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141407&action=edit Bug 31678: Convert authority editor tabs to Bootstrap This patch modifies the authorities editor template to replace jQueryUI tabs with Bootstrap tabs. The changes should have no visible effect, with all previous functionality still intact. To test, apply the patch and go to Authorities -> New authority. - When the page first displays, the "0" tab should be active. - Test that each of the numbered tabs works correctly to activate the correct tab content. - Confirm that the numbered tag anchors still work correctly. - Append a specific tab anchor to the URL, e.g. "#tab4XX" and refresh the page (you may need to shift-refresh). When the page reloads the correct tab should be active by default. - Confirm that sortable subfields can still be re-ordered by dragging and dropping them via the "stacked lines" icons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:02:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 12:02:08 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:02:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 12:02:14 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119481|0 |1 is obsolete| | --- Comment #138 from Lari Taskula --- Created attachment 141408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141408&action=edit Bug 17499: Add Koha-objects for messaging preferences This patch adds Koha-objects for messaging preferences. Adds simple validation for messaging preferences. The validation includes - throw exception if both borrowernumber or categorycode is given for a new pref - throw exception if patron for the given borrowernumber is not found - throw exception if category for the given categorycode is not found - throw exception if days in advance cannot be configured but is given - throw exception if days in advance configuration is invalid (value between 0-30) - throw exception if digest is not available but attempted to set on - throw exception if digest must be enabled but attempted to set off - throw exception on duplicate messaging preference Adds a method for getting available messaging options. Adds a method for setting default messaging preferenes. $patron->set_default_messaging_preferences (where $patron is a Koha::Patron) ...or... Koha::Patron::Message::Preference->new_from_default({ borrowernumber => 123, categorycode => "ABC", message_attribute_id => 1, }); Since messaging preference is a feature that has multiple related database tables, usage via Koha-objects is sometimes frustrating. This patch adds easy access to message transport types via $preference->message_transport_types (for getting) $preference->set({ message_transport_types => ['email', 'sms'] }) (for setting) (also supports other calling conventions, see documentation for more) Adds optional parameter message_name for Koha::Patron::Message::Preferences->find and ->search. Simplifies the Koha-object usage by allowing developer to skip joins and / or querying the message name via attribute_id from message_attributes table. Includes test coverage for basic usage. To test: 1. prove t/db_dependent/Koha/Patron/Message/* Following Bug 17499, check also Bug 18595 that replaces C4::Members::Messaging with these new Koha-objects. Signed-off-by: Dominic Pichette Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:02:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 12:02:21 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119482|0 |1 is obsolete| | --- Comment #139 from Lari Taskula --- Created attachment 141409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141409&action=edit Bug 17499: Define koha_object(s)_class where needed This patch adds koha_object(s)_class for needed modules to fix issues with tests. Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:02:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 12:02:29 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119483|0 |1 is obsolete| | --- Comment #140 from Lari Taskula --- Created attachment 141410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141410&action=edit Bug 17499: Replace test subroutines with build_object This patch replaces subroutines used to build test objects with call to $builder->build_object. To test prove that tests are still running with: prove t/db_dependent/Koha/Patron/Message/* Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:02:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 12:02:40 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119484|0 |1 is obsolete| | --- Comment #141 from Lari Taskula --- Created attachment 141411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141411&action=edit Bug 17499: (QA follow-up) Fix Licence Statements Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:02:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 12:02:46 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119485|0 |1 is obsolete| | --- Comment #142 from Lari Taskula --- Created attachment 141412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141412&action=edit Bug 17499: (QA follow-up) Fix POD errors Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:02:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 12:02:53 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119486|0 |1 is obsolete| | --- Comment #143 from Lari Taskula --- Created attachment 141413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141413&action=edit Bug 17499: (follow-up) More explicit exceptions Adds and throws more detailed exceptions. This is useful for APIs and generating translatable errors in GUI. In short, replaces Koha::Exceptions::BadParameter with: Koha::Exceptions::Patron::NotFound Koha::Exceptions::Patron::Category Koha::Exceptions::Patron::Category::NotFound Koha::Exceptions::Patron::Message::Preference Koha::Exceptions::Patron::Message::Preference::AttributeNotFound Koha::Exceptions::Patron::Message::Preference::DaysInAdvanceOutOfRange Koha::Exceptions::Patron::Message::Preference::DaysInAdvanceNotAvailable Koha::Exceptions::Patron::Message::Preference::DigestNotAvailable Koha::Exceptions::Patron::Message::Preference::DigestRequired Koha::Exceptions::Patron::Message::Preference::EmailAddressRequired Koha::Exceptions::Patron::Message::Preference::NoTransportType Koha::Exceptions::Patron::Message::Preference::SMSNumberRequired To test: 1. prove t/db_dependent/Koha/Patron/Message/Preferences.t Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:02:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 12:02:59 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119487|0 |1 is obsolete| | --- Comment #144 from Lari Taskula --- Created attachment 141414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141414&action=edit Bug 17499: (follow-up) Fix warning Fix warning DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single. Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:03:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 12:03:07 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119488|0 |1 is obsolete| | --- Comment #145 from Lari Taskula --- Created attachment 141415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141415&action=edit Bug 17499: (follow-up) Validate phone and itiva transport types Message transport types 'phone' and 'itiva' were not validated unlike 'email' and 'sms'. This patch adds equivalent checks to the missing mtts. To test: 1. prove t/db_dependent/Koha/Patron/Message/Preferences.t Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:03:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 12:03:13 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119489|0 |1 is obsolete| | --- Comment #146 from Lari Taskula --- Created attachment 141416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141416&action=edit Bug 17499: (follow-up) Contact information vs. mtt validation This patch adds a subroutine that handles message transport type validation by first checking related patron contact information. As an example, if there is no email address, we shouldn't let email be selected as a messaging transport type. The reason to isolate logic into a separate subroutine is that C4/Reserves.pm _koha_notify_reserve() also uses the same logic and we should not duplicate it. C4::Reserves::_koha_notify_reserve() will be adjusted to use this new sub in Bug 18595. To test: 1. prove t/db_dependent/Koha/Patron/Message/Preferences.t Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:03:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 12:03:20 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119490|0 |1 is obsolete| | --- Comment #147 from Lari Taskula --- Created attachment 141417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141417&action=edit Bug 17499: (follow-up) Rename to Koha::Patron::MessagePreference Koha::Patron::Message refers to "messages" table that is used for circulation messages. MessagePreference now refers to a messaging preference that is used for enqueued notifications. To test: 1. prove t/db_dependent/Koha/Patron/MessagePreference/Attributes.t 2. prove t/db_dependent/Koha/Patron/MessagePreference/Transport/Preferences.t 3. prove t/db_dependent/Koha/Patron/MessagePreference/Transport/Types.t 4. prove t/db_dependent/Koha/Patron/MessagePreference/Transports.t 5. prove t/db_dependent/Koha/Patron/MessagePreferences.t Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:03:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 12:03:28 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119491|0 |1 is obsolete| | --- Comment #148 from Lari Taskula --- Created attachment 141418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141418&action=edit Bug 17499: (follow-up) Add $patron->messaging_preferences accessor To test: 1. prove t/db_dependent/Koha/Patron.t Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:23:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 12:23:55 +0000 Subject: [Koha-bugs] [Bug 31678] Convert authority editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:24:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 12:24:05 +0000 Subject: [Koha-bugs] [Bug 31678] Convert authority editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141407|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:28:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 12:28:56 +0000 Subject: [Koha-bugs] [Bug 31678] Convert authority editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:29:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 12:29:01 +0000 Subject: [Koha-bugs] [Bug 31678] Convert authority editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 --- Comment #2 from Owen Leonard --- Created attachment 141419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141419&action=edit Bug 31678: Convert authority editor tabs to Bootstrap This patch modifies the authorities editor template to replace jQueryUI tabs with Bootstrap tabs. The changes should have no visible effect, with all previous functionality still intact. To test, apply the patch and go to Authorities -> New authority. - When the page first displays, the "0" tab should be active. - Test that each of the numbered tabs works correctly to activate the correct tab content. - Confirm that the numbered tag anchors still work correctly. - Append a specific tab anchor to the URL, e.g. "#tab4XX" and refresh the page (you may need to shift-refresh). When the page reloads the correct tab should be active by default. - Confirm that sortable subfields can still be re-ordered by dragging and dropping them via the "stacked lines" icons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:29:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 12:29:35 +0000 Subject: [Koha-bugs] [Bug 31677] Convert basic MARC editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31677 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |31678 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 [Bug 31678] Convert authority editor tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:29:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 12:29:35 +0000 Subject: [Koha-bugs] [Bug 31678] Convert authority editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31677 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31677 [Bug 31677] Convert basic MARC editor tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:51:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 12:51:03 +0000 Subject: [Koha-bugs] [Bug 28287] reports execution should stop on execute_query errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28287 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Didier Gautheron --- *** This bug has been marked as a duplicate of bug 28804 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:51:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 12:51:03 +0000 Subject: [Koha-bugs] [Bug 28804] 500 Error when running report with bad syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28804 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |didier.gautheron at biblibre.c | |om --- Comment #8 from Didier Gautheron --- *** Bug 28287 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:56:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 12:56:24 +0000 Subject: [Koha-bugs] [Bug 31697] Show patron category names rather than codes on overdue notice & status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31697 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #3 from Andrew Fuerste-Henry --- Heh, please excuse, this is utterly my failure to read the screen good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:58:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 12:58:33 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #149 from Lari Taskula --- It seems Koha::MessageAttribute(s) classes were introduced before this Bug was able to move forward. As current patch set adds equivalent classes named Koha::Patron::Message::Attribute(s), they have to be removed. Also, Koha::Patron::Message::Transport(s) and Koha::Patron::Message::Transport::Type(s) should be renamed to match naming convention of Koha::MessageAttribute(s). I'll start fixing these. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 15:22:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 13:22:25 +0000 Subject: [Koha-bugs] [Bug 31698] New: Add ability to move a hold to a new biblio/item Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Bug ID: 31698 Summary: Add ability to move a hold to a new biblio/item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Sometimes a library gets a new edition, or a new copy of an item and would like to be able to directly provide this to a patron with an existing hold. We propose add a new action on the holds table on request.pl 'Move hold' For an item level hold it would provide a modal with a barcode entry box so librarians can scan a new copy in hand, and move the hold to that specific item For a biblio level hold it would provide a modal with a search box - entering keywords would search the catalog, and add a 'Move hold' button to the results - similar to 'Add to basket form existing record' search in acquisitions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 15:22:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 13:22:38 +0000 Subject: [Koha-bugs] [Bug 31698] Add ability to move a hold to a new biblio/item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 15:36:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 13:36:25 +0000 Subject: [Koha-bugs] [Bug 31699] New: Add a generic way to redirect back to the page you were on at login for modal logins Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 Bug ID: 31699 Summary: Add a generic way to redirect back to the page you were on at login for modal logins Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Currently, we have a few extra buttons in the OPAC that trigger the login modal.. however, in most cases those don't do anything clever to keep the users context and instead they result with the jarring shift to the opac-user page once logged in. We should implement a general redirect option to allow such modal trigger to specify that context should be maintained. Example - Trying to add a comment on the opac-detail page when not logged in. It'll trigger a login modal and then redirect you to opac-user upon success losing the context of the item you were trying to comment on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 15:36:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 13:36:32 +0000 Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 15:36:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 13:36:32 +0000 Subject: [Koha-bugs] [Bug 22972] Proposal for enriching the bibliographic records with standard identifiers from authority data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22972 --- Comment #4 from Marcel de Rooy --- Thinking along these lines about it: Data looks like 024 7# - OTHER STANDARD IDENTIFIER Standard number or code: https://id.rijksmuseum.nl/31018715 Source of number or code: uri 024 7# - OTHER STANDARD IDENTIFIER Real World Object URI: https://rkd.nl/explore/artists/15189 Source of number or code: rkda 024 7# - OTHER STANDARD IDENTIFIER Real World Object URI: http://www.wikidata.org/entity/Q454568 Source of number or code: wikidata Add a pref to know which field numbers to copy (024 for MARC21). Copy $1 from auth to $1 at biblio side. (Repeatable) Leave #2 alone. It is something different. In the above case we need to decide on the best way to show all (3) additional URIs on the detail page that come with this author (or another auth type). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 15:45:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 13:45:01 +0000 Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 --- Comment #1 from Martin Renvoize --- Created attachment 141420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141420&action=edit Bug 31699: Add 'return' option to opac modal login This patch adds the option to trigger a redirect back to the current context after successful login using modal logins triggered from various places in the OPAC. To make use of this, simply add 'data-return="true"' to the modal trigger link. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 15:45:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 13:45:05 +0000 Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 --- Comment #2 from Martin Renvoize --- Created attachment 141421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141421&action=edit Bug 31699: Impliment modal context return on opac-detail. This patch utilises the generic return option introduced in the previous patch to prevent lose of context when clicking to login to add a comment to a biblio. Test plan 1/ Test that prior to this patch, upon clicking 'Log in to your account to post a comment' you are redirected to opac-user.pl and thus loose your context. 2/ Apply the patch 3/ Confirm that a login using the 'Log in to your account to post a comment' link now redirect immediatly back the correct record and thus maintains context. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 15:45:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 13:45:34 +0000 Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 15:46:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 13:46:36 +0000 Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31028 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 15:46:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 13:46:36 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31699 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 15:53:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 13:53:46 +0000 Subject: [Koha-bugs] [Bug 3514] Returning items through patron Details tab doesn't activate all circulation functions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3514 pierre.genty at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:17:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:17:04 +0000 Subject: [Koha-bugs] [Bug 31678] Convert authority editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:23:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:23:26 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:23:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:23:32 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141348|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:23:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:23:38 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141349|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:23:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:23:44 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141350|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:23:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:23:50 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141351|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:23:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:23:58 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141352|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:24:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:24:05 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141353|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:24:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:24:14 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141354|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:24:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:24:23 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141355|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:24:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:24:31 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141324|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:24:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:24:42 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141357|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:24:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:24:50 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141358|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:24:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:24:57 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141356|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:25:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:25:04 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141360|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:25:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:25:10 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141359|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:26:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:26:15 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #104 from Tomás Cohen Arazi --- Created attachment 141422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141422&action=edit Bug 17170: DB Updates This patch adds the new table, permission, and a syspref to enable the feature Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:26:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:26:22 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #105 from Tomás Cohen Arazi --- Created attachment 141423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141423&action=edit Bug 17170: DBIC schema Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:26:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:26:30 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #106 from Tomás Cohen Arazi --- Created attachment 141424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141424&action=edit Bug 17170: Update schema for boolean Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:26:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:26:38 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #107 from Tomás Cohen Arazi --- Created attachment 141425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141425&action=edit Bug 17170: Add API route for SearchFilters This adds the API routes and tests Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:26:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:26:47 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #108 from Tomás Cohen Arazi --- Created attachment 141426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141426&action=edit Bug 17170: Add search filters to staff and opac interfaces This patch displays the filters on the results pages with the facets Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:26:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:26:55 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #109 from Tomás Cohen Arazi --- Created attachment 141427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141427&action=edit Bug 17170: Handle search filters in query builders This patch updates the query building code to expand filters when searching and pass them back as part of the cgi and descriptive search strings Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:27:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:27:03 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #110 from Tomás Cohen Arazi --- Created attachment 141428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141428&action=edit Bug 17170: Add admin page for filters and ability to edit/save existing filters This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the resuilts page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:27:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:27:13 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #111 from Tomás Cohen Arazi --- Created attachment 141429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141429&action=edit Bug 17170: Unit tests Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:27:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:27:27 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #112 from Tomás Cohen Arazi --- Created attachment 141430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141430&action=edit Bug 17170: (follow-up) Display search filters admin links when appropriate Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:27:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:27:39 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #113 from Tomás Cohen Arazi --- Created attachment 141431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141431&action=edit Bug 17170: Add the ability to create 'saved searches' for use as filters when searching the catalog This patch alters the code in the ES QueryBuilder. Reflecting how things are handled in build_query_compat we clean the query, but not the limits. In Zebra we simply recursivly call buildQuery, but the ES query structure This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the results page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Michal Urban Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:27:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:27:51 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #114 from Tomás Cohen Arazi --- Created attachment 141432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141432&action=edit Bug 17170: (QA follow-up) Remove re-introduced file We reintroduced the definitions api spec file with this patch.. it's not required. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:27:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:27:59 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #115 from Tomás Cohen Arazi --- Created attachment 141433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141433&action=edit Bug 17170: (QA follow-up) Relocate 'Save' Another minor rebase issue I believe.. relocate the 'Save search as filter' link back up to sit next to 'Edit this search'. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:28:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:28:09 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #116 from Tomás Cohen Arazi --- Created attachment 141434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141434&action=edit Bug 17170: (QA follow-up) Improve model structure This feature is awesome, but it's modals all feel a bit off.. this is an improvement to one of them, but far from perfect. I opt to work with Owen to create a guideline (and template) for modals going forward and let this patchset go in as is. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:28:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:28:18 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #117 from Tomás Cohen Arazi --- Created attachment 141435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141435&action=edit Bug 17170: Minor fixes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:28:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:28:27 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #118 from Tomás Cohen Arazi --- Created attachment 141436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141436&action=edit Bug 17170: (QA follow-up) DB changes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:28:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:28:35 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #119 from Tomás Cohen Arazi --- Created attachment 141437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141437&action=edit Bug 17170: (QA follow-up) Spec cleanup This patch removes not required (for now) query parameters as we can query using q= on those. They can be added back eventually, if needed. Attributes now match the database as well. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:28:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:28:43 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #120 from Tomás Cohen Arazi --- Created attachment 141438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141438&action=edit Bug 17170: (QA follow-up) Escape things, make them translatable Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:28:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:28:58 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:30:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:30:34 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 Patrick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pm at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:38:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:38:09 +0000 Subject: [Koha-bugs] [Bug 31676] Fix db_dependent/Circulation.t tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141330|0 |1 is obsolete| | --- Comment #9 from David Gustafsson --- Created attachment 141439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141439&action=edit Bug 31676: Fix db_dependent/Circulation.t tests To test: 1) Set "RenewalPeriodBase" syspref to "the current date", "CircControl" to "the library the item is from." and "HomeOrHoldingBranch" to "the item's home library (homebranch)." 2) Run tests in t/db_dependent/Circulation.t and verify that fails (the script should actually crash before all can be run). 3) Apply the patch 4) Verifiy that all tests now pass Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:38:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:38:47 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141133|0 |1 is obsolete| | --- Comment #154 from Martin Renvoize --- Created attachment 141440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141440&action=edit Bug 31028: Add catalog_concerns table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:38:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:38:53 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141134|0 |1 is obsolete| | --- Comment #155 from Martin Renvoize --- Created attachment 141441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141441&action=edit Bug 31028: DBIC Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:38:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:38:59 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141135|0 |1 is obsolete| | --- Comment #156 from Martin Renvoize --- Created attachment 141442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141442&action=edit Bug 31028: Add `CatalogConcerns` and `OpacCatalogConcerns` preferences This patch adds the `CatalogConcerns` and `OpacCatalogeConcerns` system preferences to enable/disable the catalog concerns feature on the OPAC and Staff client interfaces. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:39:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:39:06 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141136|0 |1 is obsolete| | --- Comment #157 from Martin Renvoize --- Created attachment 141443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141443&action=edit Bug 31028: Add catalog concerns endpoints This patch adds the staff accessible REST API endpoints for catalog concerns. New endpoints available: * POST /catalog/concerns * GET /catalog/concerns * GET /catalog/concerns/{concern_id} * PUT /catalog/concerns/{concern_id} * DELETE /catalog/concenrs/{concern_id} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:39:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:39:13 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141137|0 |1 is obsolete| | --- Comment #158 from Martin Renvoize --- Created attachment 141444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141444&action=edit Bug 31028: Add relations to Catalog::Concern This patch adds the reporter, resolver and biblio relations to the Catalog::Concern class and exposes them to the API as appropriate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:39:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:39:21 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141138|0 |1 is obsolete| | --- Comment #159 from Martin Renvoize --- Created attachment 141445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141445&action=edit Bug 31028: Add Public API endpoint -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:39:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:39:24 +0000 Subject: [Koha-bugs] [Bug 31676] Fix db_dependent/Circulation.t tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 --- Comment #10 from David Gustafsson --- Now updated the test plan so the errors are reproducible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:39:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:39:34 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141139|0 |1 is obsolete| | --- Comment #160 from Martin Renvoize --- Created attachment 141446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141446&action=edit Bug 31028: Add 'Report a concern' to OPAC details This patch adds a new 'Report a concern' option to the right sidebar on the opac detail page. On clicking the link, a modal will display allowing the user to enter a short message regarding their concerns and then submission will record said message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:39:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:39:49 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141140|0 |1 is obsolete| | --- Comment #161 from Martin Renvoize --- Created attachment 141447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141447&action=edit Bug 31028: Trigger login modal when not logged in If the user is not logged in we should trigger the login modal in place of the report a concern modal and then use the code added in bug 31699 to redirect the user back to the current content and open the report a concern modal upon successful login. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:39:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:39:57 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141142|0 |1 is obsolete| | --- Comment #162 from Martin Renvoize --- Created attachment 141448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141448&action=edit Bug 31028: Add a catalog concerns management page This patch adds a new cataloguing concerns page to the staff client for managing reported catalog concerns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:40:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:40:05 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141143|0 |1 is obsolete| | --- Comment #163 from Martin Renvoize --- Created attachment 141449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141449&action=edit Bug 31028: Add 'special:undefined' to handle passing 'null' We can't pass 'null' to the column.search as it gets stringified. This patch adds a special string 'special:undefined' to denote that we want to search on undef for the field in question. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:40:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:40:14 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141144|0 |1 is obsolete| | --- Comment #164 from Martin Renvoize --- Created attachment 141450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141450&action=edit Bug 31028: Add filters to concerns management -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:40:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:40:21 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141145|0 |1 is obsolete| | --- Comment #165 from Martin Renvoize --- Created attachment 141451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141451&action=edit Bug 31028: Add resolution endpoint This patch adds a /resolve endpoint to the catalog concerns endpoints. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:40:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:40:27 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141146|0 |1 is obsolete| | --- Comment #166 from Martin Renvoize --- Created attachment 141452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141452&action=edit Bug 31028: Add resolve action This patch adds a resolution workflow to the catalog concerns management page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:40:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:40:33 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141147|0 |1 is obsolete| | --- Comment #167 from Martin Renvoize --- Created attachment 141453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141453&action=edit Bug 31028: Add 'Add catalog concern' to cataloguing toolbar This patch moves the add concern modal js and template markup into their own files and then references them to add the 'Add concern' option to the cataloguing toolbar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:40:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:40:39 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141148|0 |1 is obsolete| | --- Comment #168 from Martin Renvoize --- Created attachment 141454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141454&action=edit Bug 31028: Add notice trigger for catalog concerns This patch adds a new system prefernce, `CatalogerEmails`. If set with a valid email address adding a new catalog concern should produce a notification email sent to that address. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:40:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:40:47 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141149|0 |1 is obsolete| | --- Comment #169 from Martin Renvoize --- Created attachment 141455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141455&action=edit Bug 31028: Add trigger and notice to resolve This patch adds a sample notice and sets up the trigger to notify the concern reporter when a concern is marked as resolved. The notification itself is optional at resolve time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:40:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:40:55 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141150|0 |1 is obsolete| | --- Comment #170 from Martin Renvoize --- Created attachment 141456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141456&action=edit Bug 31028: (QA follow-up) This is a 'tool' At the moment, this feature is accessible under tools rather than cataloging. Whilst we await the new cataloging homepage and sidebar this patch replaces the breadcrumb and title with 'Tools', replaces the 'cat-menu' include with 'tools-menu' and adds the 'Catalog concerns' tool to the tools-menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:41:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:41:03 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141151|0 |1 is obsolete| | --- Comment #171 from Martin Renvoize --- Created attachment 141457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141457&action=edit Bug 31028: (QA follow-up) Table configuration This patch properly adds the table configuration options to the catalog concerns table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:41:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:41:10 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141152|0 |1 is obsolete| | --- Comment #172 from Martin Renvoize --- Created attachment 141458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141458&action=edit Bug 31028: Use additional_contents for help block This patch updates the modal to use the additional_contents system for the modals help block -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:41:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:41:16 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141153|0 |1 is obsolete| | --- Comment #173 from Martin Renvoize --- Created attachment 141459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141459&action=edit Bug 31028: Add concerns tab to biblio details display This patch adds a 'Concerns' tab to the catalogue/detail display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:41:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:41:23 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141154|0 |1 is obsolete| | --- Comment #174 from Martin Renvoize --- Created attachment 141460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141460&action=edit Bug 31028: Crosslink preferences This patch adds crosslinks to the CatalogConcerns and OpacCatalogConcerns system preferences. We also slightly update the wording of OpacCatalogConcerns to clarify intent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:46:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:46:27 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #121 from Tomás Cohen Arazi --- Created attachment 141461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141461&action=edit Bug 17170: Follow-up for bug 25375 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:46:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:46:36 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #122 from Tomás Cohen Arazi --- Created attachment 141462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141462&action=edit Bug 17170: (follow-up) Use x instead of X Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:47:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:47:39 +0000 Subject: [Koha-bugs] [Bug 31676] Fix db_dependent/Circulation.t tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141439|0 |1 is obsolete| | --- Comment #11 from David Gustafsson --- Created attachment 141463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141463&action=edit Bug 31676: Fix db_dependent/Circulation.t tests To test: 1) Set "RenewalPeriodBase" syspref to "the current date", "CircControl" to "the library the item is from." and "HomeOrHoldingBranch" to "the item's home library (homebranch)." 2) Run tests in t/db_dependent/Circulation.t and verify that fails (the script should actually crash before all can be run). 3) Apply the patch 4) Verifiy that all tests now pass Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:49:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:49:07 +0000 Subject: [Koha-bugs] [Bug 31676] Fix db_dependent/Circulation.t tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141463|0 |1 is obsolete| | --- Comment #12 from David Gustafsson --- Created attachment 141464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141464&action=edit Bug 31676: Fix db_dependent/Circulation.t tests To test: 1) Set "RenewalPeriodBase" syspref to "the current date", "CircControl" to "the library the item is from." and "HomeOrHoldingBranch" to "the item's home library (homebranch)." 2) Run tests in t/db_dependent/Circulation.t and verify that fails (the script should actually crash before all can be run). 3) Apply the patch 4) Verifiy that all tests now pass Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:51:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:51:15 +0000 Subject: [Koha-bugs] [Bug 31700] New: Do not consider variable strings as translatable strings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31700 Bug ID: 31700 Summary: Do not consider variable strings as translatable strings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Some variable strings are present in the .po files and on Pootle, but they should not be translated. I was wondering if there was a way for them not to appear in the translating files/tools. Examples of strings that should not be translated: in xx-XX-staff-prog.po "%s, "dt_created_on": "%s", "dt_modification_time": "%s", "dt_action": "%s" }%s,%s %s ] } %s %s %s %s %s %s [%%~ action_block = ' ' ~%%] %s %s [%%~ action_block = action_block _ ' %s", "dt_owner": " -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:52:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:52:05 +0000 Subject: [Koha-bugs] [Bug 31676] Fix db_dependent/Circulation.t tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 --- Comment #13 from David Gustafsson --- Reverted some of the changes in the patch which found wasn't actually necessary for tests to succeed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:53:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 14:53:52 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #150 from Martin Renvoize --- I actually prefer your original approach if I'm honest.. it doesn't look to me like MessageAttribute has been much yet.. perhaps we could go the other way and keep the work here and update core to match? tl;dr I like Koha::Patron::Message::Attribute(s) better than Koha::MessageAttribute(s). I'll ask Tomas to weight in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 17:30:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 15:30:58 +0000 Subject: [Koha-bugs] [Bug 27057] Add the ability to have a Override this entire Checkout transaction when Allowtoomanyoverride is turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27057 --- Comment #2 from Andrew Fuerste-Henry --- +1, this would save a lot of annoying clicks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 17:31:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 15:31:50 +0000 Subject: [Koha-bugs] [Bug 28290] Record matching rules with no subfields cause ISE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28290 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 17:33:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 15:33:56 +0000 Subject: [Koha-bugs] [Bug 12044] Checkout should be clearly disallowed before inputting item barcode if a patron's fines will block the transaction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12044 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Checkout should not be |Checkout should be clearly |possible if a patron's |disallowed before inputting |fines will block the |item barcode if a patron's |transaction |fines will block the | |transaction -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 18:28:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 16:28:11 +0000 Subject: [Koha-bugs] [Bug 15500] Add FRBRized View to OPAC & Staff Interface Results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15500 --- Comment #5 from Jonathan Field --- These are great ideas and authority records give the consistency (although many libraries have now stopped using authorities; at least here). The biggest UK MARC record supplier has recently changed from supplying LC headings to FAST heading - https://www.oclc.org/research/areas/data-science/fast.html. I think this is the direction LC are going as they are involved? As well as Subject Headings this also includes Authors and Uniform Titles. They are also supplying ISNI numbers - https://isni.org/ which, if widely adopted, could improve data consistency across multiple systems (I'm thinking print, ebook, audiobook etc. here). Although not directly related to the FRBR issue, data consistency is the key to good grouping. So the more consistent/accurate the data, the better FRBR experience. To implement it as suggested would be a great start though, sorting out poor data could potentially be ironed out and improved upon later on. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 19:03:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 17:03:43 +0000 Subject: [Koha-bugs] [Bug 31701] New: Give system administrators the ability to delete any list (virtualshelves) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31701 Bug ID: 31701 Summary: Give system administrators the ability to delete any list (virtualshelves) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: george at nekls.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl System administrators should be able to delete any list (virtualshelf) in their system. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 19:05:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 17:05:22 +0000 Subject: [Koha-bugs] [Bug 31702] New: Give system administrators the ability to change any list (virtualshelves) from public to private Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31702 Bug ID: 31702 Summary: Give system administrators the ability to change any list (virtualshelves) from public to private Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: george at nekls.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl System administrators should have the ability to switch any public list (virtualshelf) to a private list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 19:27:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 17:27:32 +0000 Subject: [Koha-bugs] [Bug 31703] New: Give system administrators the ability to rename any list (virtualshelves) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31703 Bug ID: 31703 Summary: Give system administrators the ability to rename any list (virtualshelves) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: george at nekls.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl System administrators should be able to rename any list (virtualshelf). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 19:59:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 17:59:45 +0000 Subject: [Koha-bugs] [Bug 31678] Convert authority editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 19:59:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 17:59:48 +0000 Subject: [Koha-bugs] [Bug 31678] Convert authority editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141419|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 141465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141465&action=edit Bug 31678: Convert authority editor tabs to Bootstrap This patch modifies the authorities editor template to replace jQueryUI tabs with Bootstrap tabs. The changes should have no visible effect, with all previous functionality still intact. To test, apply the patch and go to Authorities -> New authority. - When the page first displays, the "0" tab should be active. - Test that each of the numbered tabs works correctly to activate the correct tab content. - Confirm that the numbered tag anchors still work correctly. - Append a specific tab anchor to the URL, e.g. "#tab4XX" and refresh the page (you may need to shift-refresh). When the page reloads the correct tab should be active by default. - Confirm that sortable subfields can still be re-ordered by dragging and dropping them via the "stacked lines" icons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 20:08:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 18:08:13 +0000 Subject: [Koha-bugs] [Bug 27057] Add the ability to have a Override this entire Checkout transaction when Allowtoomanyoverride is turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27057 amandav at dubcolib.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amandav at dubcolib.org --- Comment #3 from amandav at dubcolib.org --- +1, even the option to override single checkout or through the full patron interaction would be great. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 20:29:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 18:29:37 +0000 Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #100 from Blou --- Created attachment 141466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141466&action=edit Bug 27113: Allow for ending special characters in titles Modifies the cleanup regex that removed )}' and " endings from the suggested titles or authors. When selected without those, the record was not found. Ex: "MyTitle (1234)" became "MyTitle (123" in the list. It returned no results, where the full title or "MyTitle 123" would. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 20:53:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 18:53:13 +0000 Subject: [Koha-bugs] [Bug 31677] Convert basic MARC editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31677 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 20:53:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 18:53:17 +0000 Subject: [Koha-bugs] [Bug 31677] Convert basic MARC editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31677 --- Comment #1 from Owen Leonard --- Created attachment 141467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141467&action=edit Bug 31677: Convert basic MARC editor tabs to Bootstrap This patch modifies the basic MARC editor template to replace jQueryUI tabs with Bootstrap tabs. The changes should have no visible effect, with all previous functionality still intact. To test, apply the patch and go to Cataloging -> New record. - When the page first displays, the "0" tab should be active. - Test that each of the numbered tabs works correctly to activate the correct tab content. - Confirm that the numbered tag anchors still work correctly. - Append a specific tab anchor to the URL, e.g. "#tab4XX" and refresh the page (you may need to shift-refresh). When the page reloads the correct tab should be active by default. - Try appending a query string to the URL, e.g. "?tab=tab4XX" This should reload the page and make the correct tab active. - Confirm that sortable subfields can still be re-ordered by dragging and dropping them via the "stacked lines" icons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 21:11:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 19:11:36 +0000 Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Failed QA --- Comment #3 from David Nind --- Hi Martin. This isn't working for me: - I tried in Firefox and Google Chrome - I applied the patch, flush_memcached, and restart_all - For browsers, I tried clearing the cache and opening in ingognito mode/private window - Visited http://127.0.0.1:8080/cgi-bin/koha/opac-detail.pl?biblionumber=262 from both the search results page and going to the URL directly - Link for "Log in to your account to post a comment." is showing the changes in the patch ( to post a comment.) David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 21:18:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 19:18:55 +0000 Subject: [Koha-bugs] [Bug 31686] Branch limited patron categories can break patron searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31686 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 31421 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 21:18:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 19:18:55 +0000 Subject: [Koha-bugs] [Bug 31421] Library limitation on patron category breaks patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #1 from Nick Clemens --- *** Bug 31686 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 21:19:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 19:19:35 +0000 Subject: [Koha-bugs] [Bug 31421] Library limitation on patron category breaks patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 21:19:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 19:19:39 +0000 Subject: [Koha-bugs] [Bug 31421] Library limitation on patron category breaks patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 --- Comment #2 from Nick Clemens --- Created attachment 141468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141468&action=edit Bug 31421: Do not apply library limits to Categories plugin This patch simply changes from using 'search_with_library_limits' to 'search' The limits I think are intended to prevent users from setting a patron to the wrong category, they are not meant to hide patrons. Or rather, they don't do that, patrons are returned in search but cannot be processed. The dropdowns as well won't contain the category, so you can see these patrons, but not filter by the category Bug 31422 and bug 31032 point out further issues with limits. For now, let's fix searching To test: 1 - Edit Patron category 'Patron/PT' 2 - Try to do a patron search that returns patrons in this category 3 - See 'Processing' and error in JS console: Uncaught TypeError: categories_map[data] is undefined 4 - Apply patch 5 - Restart all and repeate 6 - It works now! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 21:19:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 19:19:53 +0000 Subject: [Koha-bugs] [Bug 31421] Library limitation on patron category breaks patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 21:54:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 19:54:09 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 21:54:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 19:54:15 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141165|0 |1 is obsolete| | --- Comment #25 from David Nind --- Created attachment 141469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141469&action=edit Bug 29987: Add register support to manual credits This patch adds the register and transaction type selection options to the manual credit page. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 21:54:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 19:54:20 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141166|0 |1 is obsolete| | --- Comment #26 from David Nind --- Created attachment 141470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141470&action=edit Bug 29987: (follow-up) Fix missing payment type The payment type include has changed since the patch was first written, we now require a 'type' is passed to properly set the field name. This should fix the 'bankable' issue raised. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 21:54:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 19:54:25 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141167|0 |1 is obsolete| | --- Comment #27 from David Nind --- Created attachment 141471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141471&action=edit Bug 29987: Display credit without offsets in transactions This patch adds a row to the transactions table for credits without corresponding offsets Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 21:54:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 19:54:30 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141171|0 |1 is obsolete| | --- Comment #28 from David Nind --- Created attachment 141472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141472&action=edit Bug 29987: Improve validation This patch adds hinting to display the required state of the cash register fields. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 22:09:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 20:09:47 +0000 Subject: [Koha-bugs] [Bug 29975] (Bug 21729 followup) patron_expiration_date missing in API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29975 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #10 from Nick Clemens --- Just for clarification here: When creating a hold if an expirationdate is passed then it will be set as the patron_expiration_date When the patron_expiration_date is set, this is copied to the expiration_date When Koha sets an expiration date (when hold filled) it will use the lesser of the patron_expiration_date or the calculated date i.e. the expiration_date field in the api will represent the patron_expiration_date or the Koha expiration_date as appropriate i.e. The field is not so much hidden, as not needed externally - I didn't fully understand and leave this for others as muddled as me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 22:14:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 20:14:14 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #29 from David Nind --- I've retested and signed off. I think things are now working as expected: - Any manual credits that involve cash are now recorded and display correctly when recording a cashup - When creating manual credits, you can now choose the transaction type (not sure how to add transaction types, but just used the cash option) - The cash register (register_id) is recorded correctly in the database End result = when recording cashups for a register, the correct amount is shown for cash transactions. Note that for the transaction history for the cash register, it displays as "No data available in table", but the total income is shown correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 22:45:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 20:45:32 +0000 Subject: [Koha-bugs] [Bug 31682] Silence warn when using automatic linker in biblio editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31682 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 22:45:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 20:45:36 +0000 Subject: [Koha-bugs] [Bug 31682] Silence warn when using automatic linker in biblio editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31682 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141331|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 141473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141473&action=edit Bug 31682: Silence automatic linker warn To test: 1. Open the plack-intranet-error.log in your terminal 2. When editing or adding a bibliographic record, click the button to link authorities automatically. 3. Notice the warn in the log 4. Apply the patch, restart services and refresh the page 5. Click the button again. There should be no warn Sponsored-by: Catalyst IT Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 23:48:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 21:48:55 +0000 Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |david at davidnind.com --- Comment #57 from David Nind --- Could I get some feedback on the documentation required? My initial thoughts, as this is a technical change and is not something that I'm in any way familiar with: 1. This change: a. release note about what this change does - I have added the release-notes-needed keyword b. communication to the main Koha and development mailing lists about Elasticsearch/OpenSearch support for 22.11 and supported releases (or maybe just in the 22.11 release notes) 2. Installing and configuring Elasticsearch/OpenSearch: a. I'm not sure what we have currently, and how up-to-date it is. Any pointers to the Wiki and other sources would be appreciated. b. Should we have a link from the main Koha installation guide to some instructions on the basics? c. What should be in scope? If the Elasticsearch/OpenSearch installation is sufficient, then we should link to that, and only provide any Koha specific things to consider. 3. Guide to using Elasticsearch: this is not something we have now, but something we could potentially work on. 4. Supported version matrix, including OpenSearch options. 5. Material for developers, including the KTD development environment and how to get the various versions working. For anything more than item 1, I'm proposing to create separate documentation bugs for these: - Omnibus Elasticsearch/OpenSearch documentation bug - Specific guides covering: . Installation and administration (from a system administration perspective - keeping things running) . Using Elasticsearch/OpenSearch: more from a library point of view, including an overview, configuring, options, mappings, etc - the day-to-day things to make sure the search in Koha is working as required. - Development guide: from a developer perspective and what to do when working on search-related bugs, testing various versions, KTD environment. Some help would be required with these, as it seems to me to be a quite technical area with some expertise required. David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 00:47:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 22:47:44 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #10 from David Nind --- Patch no longer applies 8-(.. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 31391: RecallsInterface system preference Applying: Bug 31391: Recalled authorised value for hold cancellation Applying: Bug 31391: Implement RecallsInterface on OPAC Applying: Bug 31391: Request recalls and convert reserves on staff interface Using index info to reconstruct a base tree... M Koha/Item.pm M koha-tmpl/intranet-tmpl/prog/en/modules/recalls/request.tt M koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt M reserve/request.pl Falling back to patching base and 3-way merge... Auto-merging reserve/request.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/recalls/request.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/recalls/request.tt Auto-merging Koha/Item.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 31391: Request recalls and convert reserves on staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 01:24:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 23:24:17 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #148 from David Nind --- Hi Shi Yao Wang. I've retested, using the consolidated test plan in comment #128 - please provide an update if anything for testing needs changing. Things I've noted - and the reasons for changing to Failed QA: 1. For the staff interface: - For an individual record, the Save > XSL - Simple Export works as expected - For the cart and lists: . XSL - Simple Export appears in the list of download options . there are error traces if this option is selected Error trace - staff interface cart: Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_basket_downloadcart_2epl::XSLTParse4Display called at /kohadevbox/koha/basket/downloadcart.pl line 83. at /kohadevbox/koha/basket/downloadcart.pl line 71 Error trace - staff interface lists: Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_virtualshelves_downloadshelf_2epl::XSLTParse4Display called at /kohadevbox/koha/virtualshelves/downloadshelf.pl line 85. at /kohadevbox/koha/virtualshelves/downloadshelf.pl line 75 2. For the OPAC: - For an individual record, the Save record > XSL - Simple Export works as expected - For the cart and lists: XSL - Simple Export does not appear in the list of download options 3. Tests fail for prove -l t/XSLT.t: root at kohadevbox:koha(bz17385)$ prove -l t/XSLT.t t/XSLT.t .. 2/12 # Failed test 'CustomXSLTExportList finds custom XSLTs' # at t/XSLT.t line 107. # Failed test 'Title is specified in root node' # at t/XSLT.t line 108. Use of uninitialized value in string eq at t/XSLT.t line 109. # Failed test 'Title is filename if not specified' # at t/XSLT.t line 109. # Looks like you failed 3 tests of 12. t/XSLT.t .. Dubious, test returned 3 (wstat 768, 0x300) Failed 3/12 subtests Test Summary Report ------------------- t/XSLT.t (Wstat: 768 Tests: 12 Failed: 3) Failed tests: 10-12 Non-zero exit status: 3 Files=1, Tests=12, 5 wallclock secs ( 0.02 usr 0.00 sys + 3.91 cusr 0.17 csys = 4.10 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 01:28:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2022 23:28:00 +0000 Subject: [Koha-bugs] [Bug 31031] MarkLostItemsAsReturned does not work with batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31031 --- Comment #4 from Christopher Brannon --- FYI, we just ran into another inconsistency with this setting and batch modification. We had an item actually get checked in, but it also credited the charge. It's behavior seems to be VERY inconsistent. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 02:55:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 00:55:40 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 02:55:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 00:55:45 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139645|0 |1 is obsolete| | --- Comment #11 from Aleisha Amohia --- Created attachment 141474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141474&action=edit Bug 31391: Request recalls and convert reserves on staff interface This enhancement adds the ability to place recalls via the staff interface by introducing a system preference, RecallsInterface, to configure where recalls can be placed. Recalls can either be placed via the OPAC, or the staff interface, or both. This is set to OPAC by default to be consistent with current behaviour. This enhancement also adds the ability to convert existing reserves to recalls easily via the staff interface. The reserve will be cancelled and a recall placed using the reserve's information. To test: 1) Update database and restart services 2) Enable UseRecalls and set the relevant recalls circulation rules 3) View the new RecallsInterface system preference. Confirm it is set to OPAC only by default 4) Check out Item A to Patron B. 5) Log into the OPAC as Patron A. Confirm you can place, view and cancel recalls as normal. 6) In the staff interface, set RecallsInterface to Staff interface only. 7) In the OPAC, confirm you can still view and cancel recalls, but can no longer place recalls. 8) In the staff interface, search for Item A and go to the Reserves tab. Place a reserve for Patron C. 9) Under the Priority column, select the dropdown and choose the recall option next to your reserve. 10) Click Update holds. Confirm when the page refreshes that your reserve has disappeared. 11) Go to the recalls tab. Confirm your reserve has been converted to a recall, and details like the patron, expiration, and pickup location have carried across to the recall. 12) On this recalls page, use the patron search to find Patron D. Test placing a record-level recall by keeping the 'recall next available item' checkbox. 13) When the page refreshes, confirm the recall was successfully placed with the correct details stored. 14) Repeat steps 12 and 13 with Patron E, this time place an item-level recall by choosing an item in the 'place a recall on a specific item' table. When selecting one of these items, the 'recall next available item' checkbox should de-select. 15) Set RecallsInterface back to OPAC only. Go back to the record and view the Recalls tab. 16) Confirm you cannot search for a patron to place a recall, but can still view and cancel recalls. Confirm you also cannot convert reserves to recalls. 17) Set RecallsInterface to both staff interface and OPAC. Confirm you can place recalls on both interfaces. 18) On the staff interface, test placing recalls that your circulation rules do not allow. For example, if 'recalls per record' is 1, ensure you're blocked from placing a second recall on a record for a patron. 19) Place a reserve for one of the patron's that already has a recall. Once complete, try to convert this reserve into a recall. Confirm you are blocked and shown a message that the hold cannot be converted to a recall. 20) Ensure tests pass t/db_dependent/Holds.t Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 08:01:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 06:01:31 +0000 Subject: [Koha-bugs] [Bug 31703] Give system administrators the ability to rename any list (virtualshelves) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31703 --- Comment #1 from Marcel de Rooy --- Previous discussions in this area make it reasonable to control this via a preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 08:14:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 06:14:47 +0000 Subject: [Koha-bugs] [Bug 21705] Map copyrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Keywords| |release-notes-needed QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 08:15:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 06:15:13 +0000 Subject: [Koha-bugs] [Bug 21705] Map copyrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 08:15:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 06:15:17 +0000 Subject: [Koha-bugs] [Bug 21705] Map copyrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 --- Comment #10 from Marcel de Rooy --- Created attachment 141475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141475&action=edit Bug 21705: Map copyrightdate to both 260/264c by default for new MARC21 installations This patch adds a mapping from 264 to biblio.copyrightdate. To test: 1) Apply patch 2) Delete existing frameworks - In the database delete from marc_tag_structure; delete from marc_subfield_structure; delete from biblio_framework; 3) Load default framework - In a terminal, run ./misc/load_yaml.pl -f installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml --load 4) In the staff interface, go to Administration > MARC bibliographic framework - Make sure the default framework is there 5) In Administration > Koha to MARC mapping, check the mappings for biblio.copyrightdate - biblioitems.publishercode should be mapped to 260 as well as 264 6) Create a bibliographic record with a value in 264 - In the database, check the biblio entry for this record, the value from 264 should be in copyrightdate 7) Create a bibliographic record with a value un 260 - In the database, check the biblio entry for this record, the value from 264 should be in copyrightdate I hope I didn't forget anything! :) Caroline Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 08:16:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 06:16:29 +0000 Subject: [Koha-bugs] [Bug 21705] Map copyrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 --- Comment #11 from Marcel de Rooy --- Please inform users of existing installations more explicitly via release notes about adding 264 too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 08:17:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 06:17:03 +0000 Subject: [Koha-bugs] [Bug 21705] Map copyrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141400|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 08:19:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 06:19:33 +0000 Subject: [Koha-bugs] [Bug 31682] Silence warn when using automatic linker in biblio editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31682 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 08:19:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 06:19:37 +0000 Subject: [Koha-bugs] [Bug 31682] Silence warn when using automatic linker in biblio editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31682 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141473|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 141476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141476&action=edit Bug 31682: Silence automatic linker warn To test: 1. Open the plack-intranet-error.log in your terminal 2. When editing or adding a bibliographic record, click the button to link authorities automatically. 3. Notice the warn in the log 4. Apply the patch, restart services and refresh the page 5. Click the button again. There should be no warn Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 08:19:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 06:19:49 +0000 Subject: [Koha-bugs] [Bug 31682] Silence warn when using automatic linker in biblio editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31682 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 08:21:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 06:21:39 +0000 Subject: [Koha-bugs] [Bug 31420] Managing funds: Labels of statistic fields overlap with pull downs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31420 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 08:21:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 06:21:46 +0000 Subject: [Koha-bugs] [Bug 31420] Managing funds: Labels of statistic fields overlap with pull downs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31420 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141404|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 141477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141477&action=edit Bug 31420: Managing funds: Labels of statistic fields overlap with pull downs This patch removes some very old inline style attributes from the fund edit form. The "white-space" attribute prevented label text from naturally wrapping. To test, apply the patch and go to Administration -> Funds. - In the list of funds, click Actions -> Edit. - The the form, confirm that the text of the "Statistic" 1 and 2 labels wraps, not getting hidden by the associated select tags. Signed-off-by: Barbara Johnson Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 08:22:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 06:22:00 +0000 Subject: [Koha-bugs] [Bug 31420] Managing funds: Labels of statistic fields overlap with pull downs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31420 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 08:23:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 06:23:55 +0000 Subject: [Koha-bugs] [Bug 31619] Cannot select title when setting non-default value for OPACSuggestionMandatoryFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |gmcharlt at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 08:24:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 06:24:06 +0000 Subject: [Koha-bugs] [Bug 31619] Cannot select title when setting non-default value for OPACSuggestionMandatoryFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 08:30:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 06:30:19 +0000 Subject: [Koha-bugs] [Bug 31619] Cannot select title when setting non-default value for OPACSuggestionMandatoryFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 --- Comment #8 from Marcel de Rooy --- (In reply to Galen Charlton from comment #7) > The patch adds an entry for "title" as a column in the suggestions table, > not biblio nor biblioitems. Ah, you are right. I just stumbled over an earlier occurrence in the wrong place (i.e. biblioitems). Sorry for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 08:30:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 06:30:51 +0000 Subject: [Koha-bugs] [Bug 31619] Cannot select title when setting non-default value for OPACSuggestionMandatoryFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 08:30:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 06:30:55 +0000 Subject: [Koha-bugs] [Bug 31619] Cannot select title when setting non-default value for OPACSuggestionMandatoryFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141039|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 141478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141478&action=edit Bug 31619: add title back to list of OPACSuggestionMandatoryFields options This patch fixes a regression introduced by bug 29695 that prevented setting the title as a required field when setting the OPACSuggestionMandatoryFields to a non-default value. To test: [1] Set OPACSuggestionMandatoryFields in the system preferences editor and note that 'title' is not listed in the modal that is displayed. [2] Apply the patch. [3] Revist the system preference editor and note that 'title' is now displayed as an option. Signed-off-by: Galen Charlton Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 08:32:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 06:32:31 +0000 Subject: [Koha-bugs] [Bug 19693] update of an authority record creates inconsistency when the heading tag is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138121|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 08:32:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 06:32:56 +0000 Subject: [Koha-bugs] [Bug 19693] update of an authority record creates inconsistency when the heading tag is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #11 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 09:20:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 07:20:25 +0000 Subject: [Koha-bugs] [Bug 31421] Library limitation on patron category breaks patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 09:20:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 07:20:31 +0000 Subject: [Koha-bugs] [Bug 31421] Library limitation on patron category breaks patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141468|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 141479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141479&action=edit Bug 31421: Do not apply library limits to Categories plugin This patch simply changes from using 'search_with_library_limits' to 'search' The limits I think are intended to prevent users from setting a patron to the wrong category, they are not meant to hide patrons. Or rather, they don't do that, patrons are returned in search but cannot be processed. The dropdowns as well won't contain the category, so you can see these patrons, but not filter by the category Bug 31422 and bug 31032 point out further issues with limits. For now, let's fix searching To test: 1 - Edit Patron category 'Patron/PT' 2 - Try to do a patron search that returns patrons in this category 3 - See 'Processing' and error in JS console: Uncaught TypeError: categories_map[data] is undefined 4 - Apply patch 5 - Restart all and repeate 6 - It works now! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 09:21:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 07:21:23 +0000 Subject: [Koha-bugs] [Bug 19693] update of an authority record creates inconsistency when the heading tag is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693 --- Comment #12 from Marcel de Rooy --- Great catch, Janusz. I know the code of merge very well, although time has passed :) Have the feeling that we are cheating a bit here, but I tend to agree with your solution direction. Tempted to polish it a bit further.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 09:55:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 07:55:23 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #21 from Katrin Fischer --- I just noticed that you need to run the database update for Koha to work. Not sure if this could cause problem with the web installer. Error while loading /etc/koha/sites/kohadev/plack.psgi: Can't load application from file "/kohadevbox/koha/api/v1/app.pl": DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Table 'koha_kohadev.auth_providers' doesn't exist at /kohadevbox/koha/Koha/Objects.pm line 312 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 11:42:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 09:42:01 +0000 Subject: [Koha-bugs] [Bug 19693] update of an authority record creates inconsistency when the heading tag is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 11:42:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 09:42:07 +0000 Subject: [Koha-bugs] [Bug 19693] update of an authority record creates inconsistency when the heading tag is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140915|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy --- Created attachment 141480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141480&action=edit Bug 19693: Add test sub to Merge.t In those rare cases when authorities are updated by an external agency (or even internally, by reviewing and correcting an exported authority file) when the heading tag will be changed (seems odd but happens: 111 Congress ==> 110 Corporate body.Congress ; 100 Person ==> 110 Corporate body (a company named with person's name ; 151 City--object ==> 150 Object (city) etc.) and then the authority record in Koha database will be updated with bulkmarcimport or by calling directly ModAuthority from a custom script, the merge function "doesn't know" that the change to the authority type has been made and, consequently, doesn't adequately change the tag in related fields in biblio records (as it would if two different records with different authtypecode were merged with Koha interface). This is because at the moment when merge function is being called by ModAuthority: Koha::Authority::Types->find($autfrom->authtypecode) Koha::Authority::Types->find($authto->authtypecode) both have the same value (because $mergefrom == $mergeto). Therefore in case when $mergefrom == $mergeto and the heading tag changes, $authtypefrom and $authfrom calculated in merge in the ordinar way are misleading and should not be taken unto consideration. Test plan: ========== 1. run t/db_dependent/Authority/Merge.t 2. you should see problems in "Test update A with modified heading tag (changing authtype)" 3. apply the patch 4. run t/db_dependent/Authority/Merge.t again 5. the test should pass Alternatively: 1. have an authority record used in biblio; export it to file; change 1XX heading tag to a different (but reasonable) value and possibly change also the content of the heading (one can delete also 942 but it doesn't matter); make bulkmarcimport.pl -a -update -file and see that the tag in biblio record has not been changed (whereas the type of authority record did change); 2. make orders in database (so that the authority type and the tag of the field in biblio record correspond); apply the patch; 3. repeat the test from 1. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 11:42:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 09:42:11 +0000 Subject: [Koha-bugs] [Bug 19693] update of an authority record creates inconsistency when the heading tag is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140916|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy --- Created attachment 141481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141481&action=edit Bug 19693: Update of an authority record creates inconsistency when the heading tag is changed In those rare cases when authorities are updated by an external agency (or even internally, by reviewing and correcting an exported authority file) when the heading tag will be changed (seems odd but happens: 111 Congress ==> 110 Corporate body.Congress ; 100 Person ==> 110 Corporate body (a company named with person's name ; 151 City--object ==> 150 Object (city) etc.) and then the authority record in Koha database will be updated with bulkmarcimport or by calling directly ModAuthority from a custom script, the merge function "doesn't know" that the change to the authority type has been made and, consequently, doesn't adequately change the tag in related fields in biblio records (as it would if two different records with different authtypecode were merged with Koha interface). This is because at the moment when merge function is being called by ModAuthority: Koha::Authority::Types->find($autfrom->authtypecode) Koha::Authority::Types->find($authto->authtypecode) both have the same value (because $mergefrom == $mergeto). Therefore in case when $mergefrom == $mergeto and the heading tag changes, $authtypefrom and $authfrom calculated in merge in the ordinar way are misleading and should not be taken unto consideration. Test plan: ========== 1. run t/db_dependent/Authority/Merge.t 2. you should see problems in "Test update A with modified heading tag (changing authtype)" 3. apply the patch 4. run t/db_dependent/Authority/Merge.t again 5. the test should pass Alternatively: 1. have an authority record used in biblio; export it to file; change 1XX heading tag to a different (but reasonable) value and possibly change also the content of the heading (one can delete also 942 but it doesn't matter); make bulkmarcimport.pl -a -update -file and see that the tag in biblio record has not been changed (whereas the type of authority record did change); 2. make orders in database (so that the authority type and the tag of the field in biblio record correspond); apply the patch; 3. repeat the test from 1. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 11:42:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 09:42:15 +0000 Subject: [Koha-bugs] [Bug 19693] update of an authority record creates inconsistency when the heading tag is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693 --- Comment #15 from Marcel de Rooy --- Created attachment 141482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141482&action=edit Bug 19693: (QA follow-up) Replace changed tag test The test $MARCfrom->field('1..', '2..'))[0]->tag ne ($MARCto->field('1..', '2..'))[0]->tag is not completely consistent with following code in sub merge. I decided to get the authtype code from the old record that comes from Koha and should include the type. Remaining changes refer to indentation/comments. Test plan: Run t/db_dependent/Authority/Merge.t Note: The test actually could be extended a bit for mocking MARC flavor, but needs some additional framework support to work. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 11:50:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 09:50:05 +0000 Subject: [Koha-bugs] [Bug 31704] New: Mapping of kohafield for authorities should be controlled by default framework too Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31704 Bug ID: 31704 Summary: Mapping of kohafield for authorities should be controlled by default framework too Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Similar to what we do for biblio records. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 11:50:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 09:50:58 +0000 Subject: [Koha-bugs] [Bug 31704] Mapping of kohafield for authorities should be controlled by default framework too In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31704 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19693 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 11:50:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 09:50:58 +0000 Subject: [Koha-bugs] [Bug 19693] update of an authority record creates inconsistency when the heading tag is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31704 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 11:52:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 09:52:13 +0000 Subject: [Koha-bugs] [Bug 31704] Mapping of kohafield for authorities should be controlled by default framework too In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31704 --- Comment #1 from Marcel de Rooy --- Hmm. This might be kind of the same as the one I reported in 2017, bug 19111 :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 11:52:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 09:52:31 +0000 Subject: [Koha-bugs] [Bug 31704] Mapping of kohafield for authorities should be controlled by default framework too In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31704 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19111 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 11:52:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 09:52:31 +0000 Subject: [Koha-bugs] [Bug 19111] Do not mess with kohafield in authority_subfield_structure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19111 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31704 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:00:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:00:43 +0000 Subject: [Koha-bugs] [Bug 31469] log4perl.conf: Plack logfiles need %n in conversionpattern In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31469 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141079|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 141483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141483&action=edit Bug 31469: log4perl.conf: Add %n to conversionpattern for Plack The PLACKOPAC, PLACKAPI and PLACKINTRANET appenders still need %n (i.e. a newline). Note that this patch does not add %l since it is a bit confusing because it adds a lot of Plack internal noise like: [2022/09/29 08:51:34] [WARN] Test mainpage CGI::Compile::ROOT::usr_share_koha_mainpage_2epl::__ANON__ /usr/share/koha/mainpage.pl (49) The patch is a result of: git grep -l "log4perl.appender.PLACK" | xargs sed -i -e"/ConversionPattern/ s/%m$/%m%n/" Test plan: First run: sed -i -e"/ConversionPattern/ s/%m$/%m%n/" /etc/koha/sites/[YOUR_CLONE]/log4perl.conf Edit that file, change PLACKOPAC to debug level like: log4perl.logger.plack-opac = DEBUG, PLACKOPAC Restart. Hit an OPAC page twice. Check plack-opac logfile and verify that it contains a newline between last two messages like: [2022/09/29 08:04:30] [DEBUG] kohaversion : 22.0600054 [2022/09/29 08:04:42] [DEBUG] kohaversion : 22.0600054 Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:01:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:01:00 +0000 Subject: [Koha-bugs] [Bug 31469] log4perl.conf: Plack logfiles need %n in conversionpattern In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31469 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Works for me, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:04:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:04:15 +0000 Subject: [Koha-bugs] [Bug 28372] Use variables for 007 controlfield translations in MARC21slim2intranetResults.xsl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28372 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140874|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 141484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141484&action=edit Bug 28372: Use variables instead of repeated field lookup This simply replaces repeated lookups of the field with a variable test To test: 1 - Perform a search on the staff client 2 - Note the 'Format' in the record results 3 - Apply patch 4 - Repeat search 5 - Confirm Formats are unchanged Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:04:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:04:20 +0000 Subject: [Koha-bugs] [Bug 28372] Use variables for 007 controlfield translations in MARC21slim2intranetResults.xsl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28372 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140875|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 141485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141485&action=edit Bug 28372: Update OPAC results XSLT to use variables for 007 Same test plan as before, but for OPAC Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:04:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:04:49 +0000 Subject: [Koha-bugs] [Bug 28372] Use variables for 007 controlfield translations in MARC21slim2intranetResults.xsl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28372 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:04:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:04:59 +0000 Subject: [Koha-bugs] [Bug 28372] Use variables for 007 controlfield translations in MARC21slim2intranetResults.xsl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28372 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140839|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:06:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:06:10 +0000 Subject: [Koha-bugs] [Bug 28372] Use variables for 007 controlfield translations in MARC21slim2intranetResults.xsl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28372 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Martin Renvoize --- Nice improvement readability wise.. no noticeable change in performance on my part, but I didn't measure it in any meaningful way. I think this is worthwhile for the readability regardless. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:09:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:09:27 +0000 Subject: [Koha-bugs] [Bug 29048] Incorrect search for linked authority records from authority search result list in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29048 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140642|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 141486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141486&action=edit Bug 29048: Fix link to linked records from authority search results in OPAC Without this patch the constructed search link would give wrong results with Elasticsearch. If you searched for records linked to authority id 3 it would also turn up all other records linked to an authority where the id started with 3... This just copies the more specific link using an,phr used in the staff interface and the OPAC detail page to make things consistent To test: - Turn on Elasticsearch - Search for authorities in the OPAC - Locate a authority with a low ID in your result list - Note the number of linked records - Click on the link - It will give you more results than it said before - Verify results don't match your search - Apply patch - Try again - now it should all match up Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:09:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:09:51 +0000 Subject: [Koha-bugs] [Bug 29048] Incorrect search for linked authority records from authority search result list in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29048 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize --- Nice consistency improvement, trivial fix. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:12:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:12:29 +0000 Subject: [Koha-bugs] [Bug 28950] serialsUpdate cron does not mark an issue late until the next issue is expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28950 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140462|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 141487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141487&action=edit Bug 28950: Mark serial late when past grace period This script had some oddities: - There was a LEFT JOIN to subscription, but no error printed if no subscription I changed this to a JOIN as there is a constraint, so this shoudl not happen - Publisheddate was checked after the SQL, moved into query - We checked for the next issue, and marked late only if that issue was already expected This overruled grace period, which should be the mnarker for a serial being late The grace period should be extended if you wish to wait for next issue - If no next published date, we reported an error on the planneddate - Script without confirm had no reporting Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:13:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:13:30 +0000 Subject: [Koha-bugs] [Bug 28950] serialsUpdate cron does not mark an issue late until the next issue is expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28950 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com --- Comment #9 from Martin Renvoize --- All working as described, no regressions found and QA script is happy. This is the sort of thing I'd love to see move into a module and get unit tested.. but as it's all in the script at the moment, there's no precedent for tests here. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:17:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:17:00 +0000 Subject: [Koha-bugs] [Bug 29554] neworderempty.pl may create records with biblioitems.itemtype NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140701|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 141488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141488&action=edit Bug 29554: Do not hide display of itemtypes on neworderempty Hiding the list may lead to biblioitems.itemtype being NULL. We do not want that, since 942$c is mandatory. Test plan: Create basket and set 'create items when' to receiving or cataloging. Create order from new empty record. Check biblioitems.itemtype of created biblio. Without this patch, it would have been NULL like this: select biblionumber,title from biblio; | 7 | Test 3 | select biblionumber,itemtype from biblioitems; | 7 | NULL | Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:17:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:17:11 +0000 Subject: [Koha-bugs] [Bug 29554] neworderempty.pl may create records with biblioitems.itemtype NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:17:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:17:17 +0000 Subject: [Koha-bugs] [Bug 29554] neworderempty.pl may create records with biblioitems.itemtype NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:20:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:20:27 +0000 Subject: [Koha-bugs] [Bug 31575] Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 --- Comment #3 from Martin Renvoize --- Created attachment 141489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141489&action=edit Bug 31575: Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed If some holds are overridable, and AllowHoldPolicyOverride is enabled, Koha used to "flag" each holdable item to let librarians know the hold could not normally be placed. In 22.05 up to current master as of this writing, no warning is displayed. Test Plan: 1) Set one circ rule to allow 0 holds 2) For Library A, set "Hold pickup library match" to "item's hold group" 3) Enable AllowHoldPolicyOverride 4) Set ReservesControlBranch to "item's home branch" 5) Create a record with an item for Library A, one for Library B, and one for Library C This should create a scenario where A's item cannot be held, and B and C's items must be overridden 6) Note you get the "Cannot place hold" but can place those holds anyway without a "warning" sign 7) Apply this patch 8) Restart all the things! 9) Reload the page, you should now see the warning icons! Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:20:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:20:53 +0000 Subject: [Koha-bugs] [Bug 31575] Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #140737|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:21:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:21:32 +0000 Subject: [Koha-bugs] [Bug 31575] Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Working as expected now.. another one where perhaps moving things up a level would mean we had unit tests to prevent such a regression.. but nothing to prevent a QA pass here. Passed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:21:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:21:38 +0000 Subject: [Koha-bugs] [Bug 31575] Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:23:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:23:18 +0000 Subject: [Koha-bugs] [Bug 31576] Cannot place hold even when AllowHoldPolicyOverride should allow it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:37:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:37:54 +0000 Subject: [Koha-bugs] [Bug 28375] Inefficiencies in fetching COinS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141051|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 141490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141490&action=edit Bug 28375: Inefficiencies in fetching COinS This patchset adds an 'interface' parameter to XSLTParseForDisplay to avoid fetching coins when not needed Additionally we move some logic from the scripts to searchResults to avoid an extra fetch fo the biblio object To test: 1 - Enable COinSinOPACResults syspref 2 - Also enable OPACShowOpenURL and OPACOpenURLItemTypes - adding an itemtype that you can find 3 - Perform a search on the OPAC and confirm coins are included and openurl shown 4 - Perform a search on staff client and confirm openurls do not show 5 - Apply patch 6 - Results should be the same Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:37:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:37:59 +0000 Subject: [Koha-bugs] [Bug 28375] Inefficiencies in fetching COinS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141126|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 141491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141491&action=edit Bug 28375: (follow-up) Remove guessed interface parameter - always pass Previous patch added interface parameter passed on each call. There was an existing one that 'guessed' - this patch removes that Fixes missing comma Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:39:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:39:36 +0000 Subject: [Koha-bugs] [Bug 28375] Inefficiencies in fetching COinS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #14 from Martin Renvoize --- Adding a second signoff here as I missed that Marcel had started QAing... Leaving QA to Marcel once he's had an answer to his question.. it does bare asking.. the code would appear much simple if we just use the context. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:45:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:45:11 +0000 Subject: [Koha-bugs] [Bug 31646] Focus input by default when clicking on a dropdown field in the cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31646 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141293|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 141492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141492&action=edit Bug 31646: Add Select2 focus to text search field To test: 1. Edit a biblio record 2. Go to tab 9 to find the item type MARC field 942$c 3. Click on the field to select an item type 4. Notice you have to click again on the search field to begin typing to search for your item type 5. Apply patch/clear browser cache 6. Try steps 2-3 again, the focus should now be on the search text field 7. Try another select2 dropdown on the same page like the 942$n ( Suppress in OPAC ), it should also default to the text search field. 8. Try other places in Koha that feature this kind of select2, like when placing hold. Note: Using $(document).on here instead of $(".select2").on becuase there are several instances where there are more than 1 select2 dropdown on a single page. This allows for the text search field to default each time you click on a different dropdown. Signed-off-by: Aleisha Amohia Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:46:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:46:00 +0000 Subject: [Koha-bugs] [Bug 31646] Focus input by default when clicking on a dropdown field in the cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31646 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com Version|22.05 |unspecified --- Comment #8 from Martin Renvoize --- Nice improvement, works as described. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 12:59:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 10:59:21 +0000 Subject: [Koha-bugs] [Bug 12285] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 13:07:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 11:07:49 +0000 Subject: [Koha-bugs] [Bug 30036] Add XSLT for authority results view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 13:17:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 11:17:09 +0000 Subject: [Koha-bugs] [Bug 30036] Add XSLT for authority results view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 13:17:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 11:17:16 +0000 Subject: [Koha-bugs] [Bug 30036] Add XSLT for authority results view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140406|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 141493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141493&action=edit Bug 30036: Allow XSLT for authority results view in OPAC This patch adds a syspref to allow customizing the authority results view at OPAC with XSLT Test plan: 1. For testing make sure to have at least one or more authorities defined 2. OPAC: Home > Authority search(Submit) > Authority search results Notice the normal view of results 3. Apply patch 4. INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacResultsDisplay" 5. Write the path where your file is. You can use the one for intranet: .../koha/koha-tmpl/intranet-tmpl/prog/en/XSLT/UNIMARCauthResults.xsl 6. Save changes 7. Repeat step 2 and notice the xslt view of results Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 13:17:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 11:17:22 +0000 Subject: [Koha-bugs] [Bug 30036] Add XSLT for authority results view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140407|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 141494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141494&action=edit Bug 30036: (follow-up) Update system preference description Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 13:17:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 11:17:32 +0000 Subject: [Koha-bugs] [Bug 30036] Add XSLT for authority results view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 --- Comment #11 from Katrin Fischer --- Created attachment 141495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141495&action=edit Bug 30036: (QA follow-up) Move system preference to OPAC tab * Moves the AuthorityXSLTOpacResultsDisplay from staff interface to OPAC tab * Fixes some capitalization opac in the database pref description Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 13:19:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 11:19:21 +0000 Subject: [Koha-bugs] [Bug 21330] Add XSLT for authority normal view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 13:20:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 11:20:08 +0000 Subject: [Koha-bugs] [Bug 21330] Add XSLT for authority detail page in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement enables |This enhancement allows to release notes|the use of custom XSLT |use custom XSLT stylesheets |stylesheets for displaying |for displaying authority |OPAC authority details. |detail pages in the OPAC. Summary|Add XSLT for authority |Add XSLT for authority |normal view in OPAC |detail page in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 13:30:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 11:30:03 +0000 Subject: [Koha-bugs] [Bug 21330] Add XSLT for authority detail page in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #17 from Katrin Fischer --- This one does not apply for me, I haven't seen that error before: Applying: Bug 21330: Allow XSLT for authority detail view in OPAC Using index info to reconstruct a base tree... M installer/data/mysql/mandatory/sysprefs.sql Falling back to patching base and 3-way merge... error: The following untracked working tree files would be overwritten by merge: installer/data/mysql/atomicupdate/bug-21330.pl Please move or remove them before you merge. Aborting error: Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 13:30:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 11:30:41 +0000 Subject: [Koha-bugs] [Bug 21330] Add XSLT for authority detail page in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 --- Comment #18 from Katrin Fischer --- Julian, when you are back here: Can you please change 'intranet' to 'staff interface' in descriptions and move the pref to the OPAC tab? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 13:34:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 11:34:58 +0000 Subject: [Koha-bugs] [Bug 31552] SIP2 option format_due_date not honored for AH field in item information response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31552 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- It looks like instead of adding a test for the fixed behviour this patch actually removes the test. Kyle, can you please provide a test for the formatted due date? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 13:36:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 11:36:43 +0000 Subject: [Koha-bugs] [Bug 31552] SIP2 option format_due_date not honored for AH field in item information response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31552 --- Comment #5 from Katrin Fischer --- Sorry, something is odd with my setup today - test was added (added lines in red, terminal, really?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 13:54:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 11:54:59 +0000 Subject: [Koha-bugs] [Bug 31552] SIP2 option format_due_date not honored for AH field in item information response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31552 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 13:55:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 11:55:05 +0000 Subject: [Koha-bugs] [Bug 31552] SIP2 option format_due_date not honored for AH field in item information response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31552 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140487|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 141496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141496&action=edit Bug 31552: SIP2 option format_due_date not honored for AH field in item information response Bug 28730 added the ability to format due dates based on Koha's date format, but missed formatting the due date field in the item information response. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Message.t Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 14:01:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 12:01:13 +0000 Subject: [Koha-bugs] [Bug 28375] Inefficiencies in fetching COinS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375 --- Comment #15 from Nick Clemens --- Created attachment 141497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141497&action=edit Bug 28375: (follow-up) Use C4::Context->interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 14:03:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 12:03:04 +0000 Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content warnings' to catalogue records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 14:09:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 12:09:35 +0000 Subject: [Koha-bugs] [Bug 31705] New: Option for ILL "Manage Request" button to appear on Left of the screen to improve accessibility Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31705 Bug ID: 31705 Summary: Option for ILL "Manage Request" button to appear on Left of the screen to improve accessibility Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: jeremy.evans at ukhsa.gov.uk To improve accessibility and reduce excessive scrolling we would like an option for the "Manage Request" button on the list of ILL requests to appear on the left of the screen. It currently displays on the far right of the screen and normally requires scrolling beyond the columns displaying in the table for each request to be processed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 14:12:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 12:12:43 +0000 Subject: [Koha-bugs] [Bug 31706] New: Journal Title and Article title fields on the ILL Request form should be expandable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31706 Bug ID: 31706 Summary: Journal Title and Article title fields on the ILL Request form should be expandable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: jeremy.evans at ukhsa.gov.uk Journal Title and Article title fields on the ILL Request form should be expandable in the staff client to be able to see the complete entry without having to scroll through the box. This would greatly improve accessibility and allow the staff member to see the entire entry without needing to scroll. The notes field is already expandable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 14:23:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 12:23:14 +0000 Subject: [Koha-bugs] [Bug 31705] Option for ILL "Manage Request" button to appear on Left of the screen to improve accessibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31705 --- Comment #1 from Katrin Fischer --- I'd like that too, not sure if it needs to be optional... maybe because we do have the button on the right usually,b ut with this wide table it does not work well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 14:59:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 12:59:20 +0000 Subject: [Koha-bugs] [Bug 31555] Getting holds via REST API needs edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31555 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |kyle at bywatersolutions.com CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 14:59:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 12:59:48 +0000 Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content warnings' to catalogue records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #13 from Katrin Fischer --- Hi Martin, I have questions :) Can you how you chose the subfields? Will this be documented somewhere, maybe in the pref? It looks like $z is displayed first, separated by a space and then followed by abcdefgijklnou, but this is not a "complete" list of subfields either. + + + + + + abcdefgijklnou + + + -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:00:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:00:32 +0000 Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content warnings' to catalogue records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Katrin Fischer --- Failing, but just to get your attention, overall this looks good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:05:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:05:26 +0000 Subject: [Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:08:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:08:57 +0000 Subject: [Koha-bugs] [Bug 31707] New: Default itemBarcodeInputFilter to "Don't filter" in new installations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31707 Bug ID: 31707 Summary: Default itemBarcodeInputFilter to "Don't filter" in new installations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When you look at the itemBarcodeInputFilter on a new installation, it defaults to "Convert from Cuecat form". I am not sure you can still buy Cuecats? With the introduction of barcodedecode in more spots, it would make sense to choose a neutral default setting here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:09:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:09:32 +0000 Subject: [Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31707 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:09:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:09:32 +0000 Subject: [Koha-bugs] [Bug 31707] Default itemBarcodeInputFilter to "Don't filter" in new installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31707 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31252 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:10:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:10:24 +0000 Subject: [Koha-bugs] [Bug 21705] Map copyrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a release notes| |default mapping from 264c | |to biblio.copyrightdate for | |MARC21. Previously, it was | |only mapped to 260c. Now it | |is mapped to both. | |**This | |only affects new | |installations. For current | |installations, you need to | |add it manually through | |Administration > Koha to | |MARC mapping. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:11:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:11:28 +0000 Subject: [Koha-bugs] [Bug 31707] Default itemBarcodeInputFilter to "Don't filter" in new installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31707 --- Comment #1 from Katrin Fischer --- Hm: actually it's preset to '', but maybe this sets it to the first option in list in the display, have to have another closer look. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:16:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:16:46 +0000 Subject: [Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:16:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:16:52 +0000 Subject: [Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140604|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 141498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141498&action=edit Bug 31252: Advanced search in staff interface should call barcodedecode if the search index is a barcode We should run any inputted barcode through barcodedecode before passing it to any subroutines. This was missed during the initial development of bug 26351. Test Plan: 1) Set itemBarcodeInputFilter to "Remove spaces from" 2) Browse to the staff side advanced search 3) Run a barcode search for "MY TEST" 4) Note the message returned is: No results match your search for 'bc,wrdl: "MY TEST"'. 5) Apply this patch 6) Restart all the things! 7) Repeat your search 8) Note the message returned is: No results match your search for 'bc,wrdl: "MYTEST"'. 9) Note the lack of the space between MY and TEST! Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:18:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:18:47 +0000 Subject: [Koha-bugs] [Bug 21705] Map copyrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 --- Comment #12 from Caroline Cyr La Rose --- Hi Marcel, I added release notes specifying it is only for new installations and where to add it for current installations. Do you want me to also add a dbrev like in bug 30850? Thanks! Caroline -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:19:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:19:24 +0000 Subject: [Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:25:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:25:12 +0000 Subject: [Koha-bugs] [Bug 31708] New: Remove SetImportRecordStatus from neworderempty.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31708 Bug ID: 31708 Summary: Remove SetImportRecordStatus from neworderempty.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 31569 When searching for SetImportRecordStatus with bug 31569 applied, it only appears in one other .pl script: neworderempty. I believe it could easily be replaced using the object method now. ... and then we could possible remove the method altogether. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:25:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:25:12 +0000 Subject: [Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31708 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31708 [Bug 31708] Remove SetImportRecordStatus from neworderempty.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:27:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:27:22 +0000 Subject: [Koha-bugs] [Bug 31709] New: Replace SetMatchedBiblionumber method with object method Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31709 Bug ID: 31709 Summary: Replace SetMatchedBiblionumber method with object method Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 31569 Looking at the patch set on bug 31569 it looks like we could quite easily get rid of some of these specific methods in favor of using object methods. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:27:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:27:22 +0000 Subject: [Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31709 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31709 [Bug 31709] Replace SetMatchedBiblionumber method with object method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:33:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:33:12 +0000 Subject: [Koha-bugs] [Bug 31710] New: Replace GetImportRangeRecords with object methods Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31710 Bug ID: 31710 Summary: Replace GetImportRangeRecords with object methods Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 31569 Bug 31569 replaces GetImportRecordsRange in addorderiso2709.pl by using object methods. We should do this everywhere and remove GetImportRecordsRange. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:33:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:33:12 +0000 Subject: [Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31710 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31710 [Bug 31710] Replace GetImportRangeRecords with object methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:35:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:35:35 +0000 Subject: [Koha-bugs] [Bug 31710] Replace GetImportRecordsRange with object methods In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31710 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Replace |Replace |GetImportRangeRecords with |GetImportRecordsRange with |object methods |object methods -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:35:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:35:53 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Björn Nylén changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130344|0 |1 is obsolete| | --- Comment #33 from Björn Nylén --- Created attachment 141499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141499&action=edit Bug 14783: Change pickup location from opac. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:36:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:36:44 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Björn Nylén changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130346|0 |1 is obsolete| | --- Comment #34 from Björn Nylén --- Created attachment 141500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141500&action=edit Bug 14783: (follow-up) Move pickup library form into modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:38:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:38:01 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Björn Nylén changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130347|0 |1 is obsolete| | --- Comment #35 from Björn Nylén --- Created attachment 141501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141501&action=edit (QA follow-up) Change "Pick up location" to "Pickup location" in table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:38:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:38:54 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Björn Nylén changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130345|0 |1 is obsolete| | --- Comment #36 from Björn Nylén --- Created attachment 141502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141502&action=edit (QA follow-up) Add unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:46:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:46:12 +0000 Subject: [Koha-bugs] [Bug 31701] Give system administrators the ability to delete any list (virtualshelves) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31701 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31702 CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:46:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:46:12 +0000 Subject: [Koha-bugs] [Bug 31702] Give system administrators the ability to change any list (virtualshelves) from public to private In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31702 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31701 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:46:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:46:19 +0000 Subject: [Koha-bugs] [Bug 31701] Give system administrators the ability to delete any list (virtualshelves) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31701 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31703 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:46:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:46:19 +0000 Subject: [Koha-bugs] [Bug 31703] Give system administrators the ability to rename any list (virtualshelves) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31703 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31701 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:46:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:46:30 +0000 Subject: [Koha-bugs] [Bug 31702] Give system administrators the ability to change any list (virtualshelves) from public to private In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31702 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31703 CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:46:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:46:30 +0000 Subject: [Koha-bugs] [Bug 31703] Give system administrators the ability to rename any list (virtualshelves) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31703 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31702 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:47:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:47:53 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Björn Nylén changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #37 from Björn Nylén --- Had forgotten about this. Rebased on to master as well. Bug 30500 already did part of this patch (in regards to intransit holds) so added to that code in some parts and replaces the syspref with this one. Moved the tests to a subtest. User is checked in opac-modrequest.pl (from 30500) Setting back to signed off for more qa. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:49:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:49:01 +0000 Subject: [Koha-bugs] [Bug 31711] New: When creating order lines "From a new file" you are no longer redirected to acq after import Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31711 Bug ID: 31711 Summary: When creating order lines "From a new file" you are no longer redirected to acq after import Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: regression Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org With the new RabbitMQ based importer, you get 'stuck' on the import took when using the "From a new file" option to create a new order line. You should be able to return back to acq and see your uploaded records for ordering. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:51:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:51:03 +0000 Subject: [Koha-bugs] [Bug 25267] OPAC browse shelf feature is not responsive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com --- Comment #10 from Blou --- Bug 31396 seems to have corrected that problem (Can't call method "itemnumber"). Maybe this would now work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:51:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:51:21 +0000 Subject: [Koha-bugs] [Bug 31701] Give system administrators the ability to delete any list (virtualshelves) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31701 --- Comment #1 from Andrew Fuerste-Henry --- What do you mean by "system administrator" here? I wouldn't like to just give this ability to all superlibrarians. I would prefer it to be a distinct permission. A distinct permission will be both more flexible and more obvious to the user. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 15:51:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 13:51:49 +0000 Subject: [Koha-bugs] [Bug 31702] Give system administrators the ability to change any list (virtualshelves) from public to private In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31702 --- Comment #1 from Andrew Fuerste-Henry --- As said on bug 31701, I'd like this to be a distinct permission. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:04:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:04:00 +0000 Subject: [Koha-bugs] [Bug 31555] Getting holds via REST API needs edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31555 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:04:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:04:04 +0000 Subject: [Koha-bugs] [Bug 31555] Getting holds via REST API needs edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31555 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140630|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 141503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141503&action=edit Bug 31555: change holds GET permission to place_holds This patch changes holds' GET REST API endpoint permission to place_holds to match with request.pl Test plan: 1) prove t/db_dependent/api/v1/holds.t Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:05:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:05:20 +0000 Subject: [Koha-bugs] [Bug 31495] Allow opac-page when enforcing GDPR policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31495 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:29:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:29:59 +0000 Subject: [Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:30:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:30:04 +0000 Subject: [Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140676|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 141504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141504&action=edit Bug 31569: DB update and objects Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:30:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:30:09 +0000 Subject: [Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140677|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 141505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141505&action=edit Bug 31569: DO NOT PUSH Schema Updates RM: Please copy object class lines :-) Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:30:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:30:14 +0000 Subject: [Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140678|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 141506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141506&action=edit Bug 31569: Remove GetImportRecordsRange from import_biblios_list This patch changes the way records are loaded for display when adding to a basket from a staged file To test: 1 - Stage a file of records for import 2 - Go to Acquisitions, find a vendor, create or find a basket 3 - Add to basket from staged file 4 - Choose the file 5 - Note the display of records 6 - Cancel 7 - Apply patch 8 - Stage from same file 9 - Note the display is unchanged Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:30:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:30:18 +0000 Subject: [Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140679|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer --- Created attachment 141507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141507&action=edit Bug 31569: Remove GetImportRecordsRange from import stage This patch removes the use of GetimportRecordsRange from the importing step To test: 0 - Apply patch 1 - Stage a marc file for import 2 - Add to basket from a staged file 3 - Select titles to import (don't select all) 4 - Fill out necessary fields, be sure to select itemtype on items tab 5 - Import 6 - Confirm titles successfully added to basket 7 - Confirm staged import not marked as imported 8 - Add to basket from same file 9 - Select rest of titles 10 - Import 11 - Confirm staged file now marked imported Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:30:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:30:23 +0000 Subject: [Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140680|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer --- Created attachment 141508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141508&action=edit Bug 31569: Remove GetImportRecordsRange from list step This patch removes the use of GetImportRecordsRange from the step of listing import batches to choose. It was only used for a count so is a simple replacement To test: 1 - Stage a number of files for import 2 - Import one of the files from tools 3 - Add to basket form a staged file 4 - Confirm staged baskets are listed, and imported basket is not Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:30:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:30:28 +0000 Subject: [Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140681|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer --- Created attachment 141509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141509&action=edit Bug 31569: Remove unecessary imports By using objects a number of other routines are not needed: GetImportRecordMarc SetImportRecordStatus SetMatchedBiblionumber To test: Grep for routines above in addorderiso2709 and confirm they are not used Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:30:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:30:32 +0000 Subject: [Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140682|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer --- Created attachment 141510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141510&action=edit Bug 31569: Add filters Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:30:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:30:36 +0000 Subject: [Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 --- Comment #22 from Katrin Fischer --- Created attachment 141511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141511&action=edit Bug 31569: (QA follow-up) Remove additional spaces from ISBN/ISSN Before this change, the ISBN woudl display like: ( isbn ) This patch removes the additional spaces so the display is the same as without this patch set on current master: (isbn) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:33:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:33:27 +0000 Subject: [Koha-bugs] [Bug 31712] New: When adding orders from a staged file, number of records isn't updated Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31712 Bug ID: 31712 Summary: When adding orders from a staged file, number of records isn't updated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When ordering from a staged file, the number of "bibiographic records" shown when selecting the file, will not update when records have already been ordered. Maybe we could do something like: total/remaining. total: all records imported originally remaining: all records still left for ordering (not having been ordered/imported yet) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:39:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:39:18 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:44:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:44:01 +0000 Subject: [Koha-bugs] [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:44:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:44:07 +0000 Subject: [Koha-bugs] [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:44:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:44:09 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #50 from Katrin Fischer --- Could you please check on the first fail especially? FAIL Koha/Patron/Restriction.pm FAIL forbidden patterns forbidden pattern: Warning: The 'sub type' may be wrong is declared in a Koha::* package (see bug 15446) (line 43) FAIL pod *** WARNING: empty section in previous paragraph in file Koha/Patron/Restriction.pm OK Koha/Patron/Restriction/Types.pm FAIL Koha/Patron/Restrictions.pm FAIL pod *** WARNING: empty section in previous paragraph in file Koha/Patron/Restrictions.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:44:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:44:38 +0000 Subject: [Koha-bugs] [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 --- Comment #3 from Martin Renvoize --- This works.. I'm just marking it PQA as people don't appear to want to put their names to it. SO + QA Done -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:45:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:45:37 +0000 Subject: [Koha-bugs] [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141336|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 141512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141512&action=edit Bug 31673: (bug 31086 follow-up) Drop and constraint to allow updating column It seems that we cannot edit the column while it has a constraint. If we remove it, update the oclumn, then re-add it, the update succeeds Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:49:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:49:00 +0000 Subject: [Koha-bugs] [Bug 31495] Allow opac-page when enforcing GDPR policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31495 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:49:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:49:04 +0000 Subject: [Koha-bugs] [Bug 31495] Allow opac-page when enforcing GDPR policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31495 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140643|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 141513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141513&action=edit Bug 31495: Allow opac-page when enforcing GDPR policy Test plan: Add some page under Additional contents. Enforce GDPR policy. Test with user that has no consent (yet or anymore). Check if you can reach additional contents with opac-page.pl. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:50:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:50:00 +0000 Subject: [Koha-bugs] [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |blocker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:53:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:53:28 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #22 from Nick Clemens --- Created attachment 141514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141514&action=edit Bug 31378: Use base URLs for redirect uri -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:53:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 14:53:46 +0000 Subject: [Koha-bugs] [Bug 31614] Add configurable timeout for Zebra connections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31614 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |kyle at bywatersolutions.com CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:26:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 15:26:31 +0000 Subject: [Koha-bugs] [Bug 31713] New: Allow easy printing of patron's fines Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 Bug ID: 31713 Summary: Allow easy printing of patron's fines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: barton at bywatersolutions.com, emmi.takkinen at koha-suomi.fi, gmcharlt at gmail.com, josef.moravec at gmail.com, katrin.fischer at bsz-bw.de, kelly at bywatersolutions.com, kyle at bywatersolutions.com, lisettepalouse+koha at gmail.com, marjorie.barry-vila at collecto.ca, martin.renvoize at ptfs-europe.com, nkeener at washoecounty.us, pasi.kallinen at koha-suomi.fi, sandboxes at biblibre.com, veron at veron.ch Depends on: 12285 +++ This bug was initially created as a clone of Bug #12285 +++ There should be an easy way to print a slip of patron's fines. --------------------------------------------------------------- Whilst QAing the above, I felt like there should really be a much simpler way to work on adding a notice like this.. I intend to do that with this bug. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 [Bug 12285] Allow easy printing of patron's fines -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:26:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 15:26:31 +0000 Subject: [Koha-bugs] [Bug 12285] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31713 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 [Bug 31713] Allow easy printing of patron's fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:26:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 15:26:46 +0000 Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:28:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 15:28:27 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #51 from Katrin Fischer --- Created nice SUSPENSION and OVERDUE restrictions, but then got stuck on creating my own restriction types: Template process failed: file error - restriction_type_description: not found at /kohadevbox/koha/C4/Templates.pm line 127 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:28:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 15:28:35 +0000 Subject: [Koha-bugs] [Bug 31714] New: Add a more generic way to print patron slips Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714 Bug ID: 31714 Summary: Add a more generic way to print patron slips Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Our slip printing code is somewhat spread out and custom per notice when in reality we could just have a simple controller passed a letter code and borrowernumber for many cases and then use TT notice templates to get all other details. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:28:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 15:28:42 +0000 Subject: [Koha-bugs] [Bug 31714] Add a more generic way to print patron slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:29:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 15:29:06 +0000 Subject: [Koha-bugs] [Bug 31714] Add a more generic way to print patron slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1 Depends on| |3171 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1 [Bug 1] Missing uploadedmarc table definition https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3171 [Bug 3171] Problem due to internationalization in label-create-template.tmpl in de-DE and possibly others -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:29:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 15:29:06 +0000 Subject: [Koha-bugs] [Bug 1] Missing uploadedmarc table definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31714 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714 [Bug 31714] Add a more generic way to print patron slips -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:29:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 15:29:06 +0000 Subject: [Koha-bugs] [Bug 3171] Problem due to internationalization in label-create-template.tmpl in de-DE and possibly others In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3171 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31714 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714 [Bug 31714] Add a more generic way to print patron slips -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:29:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 15:29:27 +0000 Subject: [Koha-bugs] [Bug 31714] Add a more generic way to print patron slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|1 |31713 Depends on|3171 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1 [Bug 1] Missing uploadedmarc table definition https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3171 [Bug 3171] Problem due to internationalization in label-create-template.tmpl in de-DE and possibly others https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 [Bug 31713] Allow easy printing of patron's fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:29:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 15:29:27 +0000 Subject: [Koha-bugs] [Bug 1] Missing uploadedmarc table definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|31714 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714 [Bug 31714] Add a more generic way to print patron slips -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:29:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 15:29:27 +0000 Subject: [Koha-bugs] [Bug 3171] Problem due to internationalization in label-create-template.tmpl in de-DE and possibly others In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3171 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31714 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714 [Bug 31714] Add a more generic way to print patron slips -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:29:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 15:29:27 +0000 Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31714 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714 [Bug 31714] Add a more generic way to print patron slips -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:31:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 15:31:57 +0000 Subject: [Koha-bugs] [Bug 31714] Add a more generic way to print patron slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714 --- Comment #1 from Martin Renvoize --- Created attachment 141515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141515&action=edit Bug 31714: Add Generic way to print patron slips This patch adds a very simple controller and template to allow patron slip printing without all the boilerplate. See bug 31713 for an example use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:32:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 15:32:46 +0000 Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12285 Depends on|12285 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 [Bug 12285] Allow easy printing of patron's fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:32:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 15:32:46 +0000 Subject: [Koha-bugs] [Bug 12285] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31713 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31713 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 [Bug 31713] Allow easy printing of patron's fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:32:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 15:32:49 +0000 Subject: [Koha-bugs] [Bug 31614] Add configurable timeout for Zebra connections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31614 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:32:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 15:32:54 +0000 Subject: [Koha-bugs] [Bug 31614] Add configurable timeout for Zebra connections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31614 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140965|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 141516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141516&action=edit Bug 31614: Adds a koha-conf.xml config to set Zebra connection timeout This patch adds 30 to the koha-conf.xml file. Sometimes, a Zebra search might take longer than 30 seconds. If it does, Koha will say that 0 records have been found. While slow searching is not desirable, it's more desirable to get the result set regardless. Test plan: 0. Apply patch 1. Add .1 to your relevant koha-conf.xml file (e.g. /etc/koha/sites/kohadev/koha-conf.xml) 2. echo 'flush_all' | nc -q 1 memcached 11211 3. koha-plack --restart kohadev 4. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 5. Note that no results are returned 6. Change zebra_connection_timeout to 30 7. echo 'flush_all' | nc -q 1 memcached 11211 8. koha-plack --restart kohadev 9a. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 9b. Note that 3 results are returned 10. Remove zebra_connection_timeout from koha-conf.xml 11. echo 'flush_all' | nc -q 1 memcached 11211 12. koha-plack --restart kohadev 13a. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 13b. Note that 3 results are returned 14. Celebrate Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:34:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 15:34:28 +0000 Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 --- Comment #1 from Martin Renvoize --- Created attachment 141517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141517&action=edit Bug 31713: Add FEE_SUMMARY print slip link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:41:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 15:41:27 +0000 Subject: [Koha-bugs] [Bug 31577] Use patron category multi-select for OpacHiddenItemsExceptions system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31577 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 19:02:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 17:02:25 +0000 Subject: [Koha-bugs] [Bug 27136] Add additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 19:02:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 17:02:30 +0000 Subject: [Koha-bugs] [Bug 27136] Add additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 --- Comment #13 from Katrin Fischer --- Created attachment 141518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141518&action=edit Bug 27136: (QA follow-up) Remove reference to facets, add languages to update description The new languages will also effect other pages in Koha, like the language list on the advanced search page. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 19:03:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 17:03:40 +0000 Subject: [Koha-bugs] [Bug 27136] Add additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Searching - Elasticsearch |Searching QA Contact| |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 19:04:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 17:04:50 +0000 Subject: [Koha-bugs] [Bug 31715] New: Add missing German translations for language descriptions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31715 Bug ID: 31715 Summary: Add missing German translations for language descriptions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: katrin.fischer at bsz-bw.de Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 19:05:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 17:05:01 +0000 Subject: [Koha-bugs] [Bug 31715] Add missing German translations for language descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31715 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27136 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 [Bug 27136] Add additional languages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 19:05:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 17:05:01 +0000 Subject: [Koha-bugs] [Bug 27136] Add additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31715 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31715 [Bug 31715] Add missing German translations for language descriptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 19:11:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 17:11:07 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 19:16:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 17:16:24 +0000 Subject: [Koha-bugs] [Bug 31677] Convert basic MARC editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31677 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141467|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 141519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141519&action=edit Bug 31677: Convert basic MARC editor tabs to Bootstrap This patch modifies the basic MARC editor template to replace jQueryUI tabs with Bootstrap tabs. The changes should have no visible effect, with all previous functionality still intact. To test, apply the patch and go to Cataloging -> New record. - When the page first displays, the "0" tab should be active. - Test that each of the numbered tabs works correctly to activate the correct tab content. - Confirm that the numbered tag anchors still work correctly. - Append a specific tab anchor to the URL, e.g. "#tab4XX" and refresh the page (you may need to shift-refresh). When the page reloads the correct tab should be active by default. - Try appending a query string to the URL, e.g. "?tab=tab4XX" This should reload the page and make the correct tab active. - Confirm that sortable subfields can still be re-ordered by dragging and dropping them via the "stacked lines" icons. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 19:22:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 17:22:06 +0000 Subject: [Koha-bugs] [Bug 31677] Convert basic MARC editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31677 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 19:37:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 17:37:53 +0000 Subject: [Koha-bugs] [Bug 31678] Convert authority editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #4 from Barbara Johnson --- This worked as expected. However, I could not test the last step. None of the authorities contained more than one subfield so I couldn't test the sortability via dragging/dropping. Authorities in my local system are the same - no tag had more than one subfield. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 20:59:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 18:59:40 +0000 Subject: [Koha-bugs] [Bug 31716] New: Enlarge the size of the authorised_value column in authorised_values Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31716 Bug ID: 31716 Summary: Enlarge the size of the authorised_value column in authorised_values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Some libraries want to store URLs or longer values in the AVs to make entry easier. Currently there is an 80 character limit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 21:27:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 19:27:34 +0000 Subject: [Koha-bugs] [Bug 31716] Enlarge the size of the authorised_value column in authorised_values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31716 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 21:27:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 19:27:36 +0000 Subject: [Koha-bugs] [Bug 31716] Enlarge the size of the authorised_value column in authorised_values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31716 --- Comment #1 from Nick Clemens --- Created attachment 141520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141520&action=edit Bug 31716: Enlagre the authorised_value column in authorised_values To test: 1 - Apply patch 2 - Update database 3 - Confirm you can store a longer value in authorised_values -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 21:27:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 19:27:39 +0000 Subject: [Koha-bugs] [Bug 31716] Enlarge the size of the authorised_value column in authorised_values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31716 --- Comment #2 from Nick Clemens --- Created attachment 141521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141521&action=edit Bug 31716: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 21:27:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 19:27:55 +0000 Subject: [Koha-bugs] [Bug 31716] Enlarge the size of the authorised_value column in authorised_values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31716 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 21:36:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 19:36:46 +0000 Subject: [Koha-bugs] [Bug 31588] Update cpanfile for new OpenAPI versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #8 from David Nind --- I think there is a mistake in the patches for master and 22.05 - the version number for JSON:Validator has a comma in it instead of a full stop: requires 'JSON::Validator', '5,08'; master and 22.05 show in orange and as module upgrade needed for JSON::Validator (08) 5.08. JSON::Validator - 21.11: >=3.14, <=3.99 - OK, installed version shows as 3.14 - 21.05: >=3.14, <=3.99 - OK, installed version shows as 3.14 Mojolicious::Plugin::OpenAPI - master: 5.05 OK - 22.05: 5.05 OK - 21.11: >=2.16, <=2.99 - OK, installed version shows as 2.16 - 21.05: >=2.16, <=2.99 - OK, installed version shows as 2.16 The rough process I used for testing used with KTD (probably easier ways to do this) - repeat for all versions being updated (master to 21.05): Local git repository - check out the version of Koha being tested, for example: git checkout 22.05.x - create a branch: git checkout -B bz31588 KTD: - update .env so that KOHA_IMAGE reflects the version of Koha and patch being tested - start up KTD (images download) - apply the patch for the version of Koha being tested - check About Koha > Perl modules: module versions should reflect the patch and no warnings or errors, such as being highlighted in orange (module upgrade needed) - revert back to master (kshell, cd koha, git checkout [version being tested, e.g. 21.05.x], git branch -D bz31588, git reset --hard origin/[version being tested, e.g. 21.05.x], git checkout master, git branch -D [version being tested, e.g. 21.05.x], git reset --hard origin/master) (probably easier ways tod o this?) - shutdown KTD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:01:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:01:28 +0000 Subject: [Koha-bugs] [Bug 31665] 952$d ( Date acquired ) no longer prefills with todays date when focused In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:04:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:04:23 +0000 Subject: [Koha-bugs] [Bug 31665] 952$d ( Date acquired ) no longer prefills with todays date when focused In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30797 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:04:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:04:23 +0000 Subject: [Koha-bugs] [Bug 30797] Subfields linked to the dateaccessioned.pl value builder on addbiblio.pl throw a JS error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30797 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31665 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:04:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:04:39 +0000 Subject: [Koha-bugs] [Bug 31665] 952$d ( Date acquired ) no longer prefills with todays date when focused In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 --- Comment #6 from Fridolin Somers --- Could this be related to Bug 30797 ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:10:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:10:38 +0000 Subject: [Koha-bugs] [Bug 30797] Subfields linked to the dateaccessioned.pl value builder on addbiblio.pl throw a JS error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30797 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin Somers --- This should be backported to 21.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:18:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:18:03 +0000 Subject: [Koha-bugs] [Bug 25267] OPAC browse shelf feature is not responsive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #11 from David Nind --- Patch no longer applies root at kohadevbox:koha(bz25267)$ git bz apply 25267 Bug 25267 - OPAC browse shelf feature is not responsive 135632 - Bug 25267: Impove shelf browser responsiveness 135634 - Bug 25267: (follow-up) Improve title text responsiveness Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 25267: Impove shelf browser responsiveness .git/rebase-apply/patch:60: trailing whitespace. warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/css/src/_responsive.scss M koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss M koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc .git/rebase-apply/patch:60: trailing whitespace. warning: 1 line applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/src/_responsive.scss error: Failed to merge in the changes. Patch failed at 0001 Bug 25267: Impove shelf browser responsiveness -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:19:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:19:12 +0000 Subject: [Koha-bugs] [Bug 31717] New: Value builder unimarc_field_010.pl should also use 214$c Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 Bug ID: 31717 Summary: Value builder unimarc_field_010.pl should also use 214$c Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Value builder unimarc_field_010.pl tries to find publisher from ISBN in order to fill 210$c. Since there is now 214$c for publisher this value builder should be adapted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:19:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:19:22 +0000 Subject: [Koha-bugs] [Bug 31717] Value builder unimarc_field_010.pl should also use 214$c In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:32:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:32:00 +0000 Subject: [Koha-bugs] [Bug 31718] New: Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 Bug ID: 31718 Summary: Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org This section of the breadcrumb in marc_subfields_structure.tt controls if it says we are in the default framework structure or the XYZ framework structure. [% IF ( frameworkcode ) %] [% frameworkcode | html %] [% ELSE %] Default [% END %] framework structure Before bug 29602, the string to translate looked like this %s %s %s Default %s framework structure Now, the 'Default' and the 'framework structure' are two different strings. However, in French, the correct syntax is 'framework structure default'. Before bug 29602, we could play around with the %s to accomodate the different syntax structure. Since the option to move the %s was removed, I propose we write the whole phrase 'Default framework structure' or 'XYZ framework structure' in the IF ELSE. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:35:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:35:10 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:35:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:35:52 +0000 Subject: [Koha-bugs] [Bug 7960] Choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #31 from David Nind --- Patch now applies - have changed status back to Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:36:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:36:29 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 --- Comment #1 from Caroline Cyr La Rose --- Something like [% IF ( frameworkcode ) %] [% frameworkcode | html %] framework structure [% ELSE %] Default framework structure [% END %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:37:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:37:58 +0000 Subject: [Koha-bugs] [Bug 27136] Add additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 --- Comment #14 from Katrin Fischer --- Created attachment 141522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141522&action=edit Bug 27136: (QA follow-up) Fix entries for multiple und undetermined language(s) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:38:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:38:54 +0000 Subject: [Koha-bugs] [Bug 27136] Add additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 --- Comment #15 from Katrin Fischer --- While working on translations for bug 31715 I noticed some more little changes are needed here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:39:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:39:43 +0000 Subject: [Koha-bugs] [Bug 27136] Add additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 --- Comment #16 from Katrin Fischer --- (In reply to Katrin Fischer from comment #15) > While working on translations for bug 31715 I noticed some more little > changes are needed here. ... were needed: see second follow-up patch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:40:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:40:54 +0000 Subject: [Koha-bugs] [Bug 31717] Value builder unimarc_field_010.pl should also use 214$c In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:40:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:40:58 +0000 Subject: [Koha-bugs] [Bug 31717] Value builder unimarc_field_010.pl should also use 214$c In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 --- Comment #1 from Fridolin Somers --- Created attachment 141523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141523&action=edit Bug 31717: Value builder unimarc_field_010.pl also use 214$c Value builder unimarc_field_010.pl tries to find publisher from ISBN in order to fill 210$c. Since there is now 214$c for publisher this value builder should be adapted. Test plan : 1) Choose an existing record with an ISBN and a published in biblioitems.publishercode, For example 9782070612369 and Gallimard 2) Use value builder unimarc_field_010.pl on 010$a 3) Create a new record 4) Enter 9782070612369 in 010$a 5) Click on value builder icon on this subfield 6) Check you see 'Gallimard' in 214$c -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:43:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:43:35 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 --- Comment #2 from Caroline Cyr La Rose --- (In reply to Caroline Cyr La Rose from comment #1) > Something like > > [% IF ( frameworkcode ) %] > [% frameworkcode | html %] framework structure > [% ELSE %] > Default framework structure > [% END %] The span needs to be around the [% frameworkcode | html %] part so that we can move it around in the string. [% frameworkcode | html %] framework structure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:44:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:44:05 +0000 Subject: [Koha-bugs] [Bug 31715] Add missing German translations for language descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31715 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:44:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:44:10 +0000 Subject: [Koha-bugs] [Bug 31715] Add missing German translations for language descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31715 --- Comment #1 from Katrin Fischer --- Created attachment 141524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141524&action=edit Bug 31715: Add German translations for language descriptions This adds the German translations for the different languages to subtag_registry.sql that is used by all languages during installation. * Apply patch * Run database update * Install de-DE and activate it for the OPAC * Go to advanced search * Look at the language pull down - it shows the languages in their language and then translated to English * Switch to German - verify the German translations are used now There are 2-3 cases where the translation = name, so only name is shown. * Drop your database, create your database * Run the web installer * Everything should complete without error and the language pull down should look exactly the same and be translated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:44:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:44:21 +0000 Subject: [Koha-bugs] [Bug 31715] Add missing German translations for language descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31715 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr Component|Installation and upgrade |I18N/L10N |(web-based installer) | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:51:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:51:00 +0000 Subject: [Koha-bugs] [Bug 31715] Add missing German translations for language descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31715 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141524|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 141525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141525&action=edit Bug 31715: Add German translations for language descriptions This adds the German translations for the different languages to subtag_registry.sql that is used by all languages during installation. * Apply patch * Run database update * Install de-DE and activate it for the OPAC * Go to advanced search * Look at the language pull down - it shows the languages in their language and then translated to English * Switch to German - verify the German translations are used now There are 2-3 cases where the translation = name, so only name is shown. * Drop your database, create your database * Run the web installer * Everything should complete without error and the language pull down should look exactly the same and be translated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:53:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:53:39 +0000 Subject: [Koha-bugs] [Bug 31678] Convert authority editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:54:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:54:39 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:54:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:54:42 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 --- Comment #3 from Caroline Cyr La Rose --- Created attachment 141526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141526&action=edit Bug 31718: Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation This patch changes the strings in the IF ELSE for the framework name in the breadcrumbs on the marc_subfields_structure.pl page. To test: 1) Apply patch 2) In the intranet, go to Administration > MARC bibliographic framework 3) Click 'Actions' next to the default framework and choose 'MARC structure' 4) Click 'Actions' next to a MARC tag and choose 'View subfields' 5) Check the breadcrumbs, they should show Home > Administration > MARC frameworks > Default framework structure > ... 6) Redo steps 2-5, using a different framework, e.g. ACQ The breadcrumbs for ACQ should look like Home > Administration > MARC frameworks > ACQ framework structure > ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:56:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:56:13 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:57:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:57:49 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement changes release notes| |the strings in the IF ELSE | |for the framework name in | |the breadcrumbs on the | |marc_subfields_structure.pl | |page. There is no change to | |the page in English. | |However, it will facilitate | |the translation by having | |complete strings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 22:59:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 20:59:34 +0000 Subject: [Koha-bugs] [Bug 31678] Convert authority editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141465|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 141527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141527&action=edit Bug 31678: Convert authority editor tabs to Bootstrap This patch modifies the authorities editor template to replace jQueryUI tabs with Bootstrap tabs. The changes should have no visible effect, with all previous functionality still intact. To test, apply the patch and go to Authorities -> New authority. - When the page first displays, the "0" tab should be active. - Test that each of the numbered tabs works correctly to activate the correct tab content. - Confirm that the numbered tag anchors still work correctly. - Append a specific tab anchor to the URL, e.g. "#tab4XX" and refresh the page (you may need to shift-refresh). When the page reloads the correct tab should be active by default. - Confirm that sortable subfields can still be re-ordered by dragging and dropping them via the "stacked lines" icons. Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 23:00:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 21:00:31 +0000 Subject: [Koha-bugs] [Bug 31678] Convert authority editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 23:00:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 21:00:36 +0000 Subject: [Koha-bugs] [Bug 31678] Convert authority editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141527|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 141528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141528&action=edit Bug 31678: Convert authority editor tabs to Bootstrap This patch modifies the authorities editor template to replace jQueryUI tabs with Bootstrap tabs. The changes should have no visible effect, with all previous functionality still intact. To test, apply the patch and go to Authorities -> New authority. - When the page first displays, the "0" tab should be active. - Test that each of the numbered tabs works correctly to activate the correct tab content. - Confirm that the numbered tag anchors still work correctly. - Append a specific tab anchor to the URL, e.g. "#tab4XX" and refresh the page (you may need to shift-refresh). When the page reloads the correct tab should be active by default. - Confirm that sortable subfields can still be re-ordered by dragging and dropping them via the "stacked lines" icons. Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 23:01:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 21:01:16 +0000 Subject: [Koha-bugs] [Bug 31678] Convert authority editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 --- Comment #7 from Katrin Fischer --- (In reply to Barbara Johnson from comment #4) > This worked as expected. However, I could not test the last step. None of > the authorities contained more than one subfield so I couldn't test the > sortability via dragging/dropping. Authorities in my local system are the > same - no tag had more than one subfield. Thx for testing Barbara! I added your sign-off line and made sure the drag&drop is working ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 23:05:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 21:05:11 +0000 Subject: [Koha-bugs] [Bug 31677] Convert basic MARC editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 23:05:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 21:05:15 +0000 Subject: [Koha-bugs] [Bug 31677] Convert basic MARC editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141519|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 141529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141529&action=edit Bug 31677: Convert basic MARC editor tabs to Bootstrap This patch modifies the basic MARC editor template to replace jQueryUI tabs with Bootstrap tabs. The changes should have no visible effect, with all previous functionality still intact. To test, apply the patch and go to Cataloging -> New record. - When the page first displays, the "0" tab should be active. - Test that each of the numbered tabs works correctly to activate the correct tab content. - Confirm that the numbered tag anchors still work correctly. - Append a specific tab anchor to the URL, e.g. "#tab4XX" and refresh the page (you may need to shift-refresh). When the page reloads the correct tab should be active by default. - Try appending a query string to the URL, e.g. "?tab=tab4XX" This should reload the page and make the correct tab active. - Confirm that sortable subfields can still be re-ordered by dragging and dropping them via the "stacked lines" icons. Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 23:06:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 21:06:40 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 --- Comment #4 from Caroline Cyr La Rose --- For Release Maintainers, this is needed as far back as 22.05. Before that it's not needed. For translators, the two strings will now be Default framework structure and %s framework structure In French, the translations will be Structure de la grille par défaut and Structure de la grille %s -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 23:07:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 21:07:57 +0000 Subject: [Koha-bugs] [Bug 31338] Show in advanced search when IncludeSeeFromInSearches is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31338 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 23:08:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 21:08:48 +0000 Subject: [Koha-bugs] [Bug 31719] New: Course name should enforce non-white-space character requirement Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31719 Bug ID: 31719 Summary: Course name should enforce non-white-space character requirement Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: hebah at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org While a course name is required on a course reserve, if that field is populated with a space, Koha accepts it as having a name, but there's no further way to get back to that course or interact with it afterwards since the only link is via name. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 23:44:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 21:44:52 +0000 Subject: [Koha-bugs] [Bug 31338] Show in advanced search when IncludeSeeFromInSearches is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31338 --- Comment #26 from Katrin Fischer --- This works well and can be hidden easily. I am still a bit worried that patrons will have no idea how authorities work and not understand what we are talking about here :) See from (non-preferred form) headings are included I think a normal user doesn't even now what a heading is? Maybe we could discuss to change it up later to be a little less librarianese? Maybe talking about alternative spellings... synonyms or such? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 23:46:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 21:46:25 +0000 Subject: [Koha-bugs] [Bug 31338] Show in advanced search when IncludeSeeFromInSearches is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31338 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 23:46:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 21:46:29 +0000 Subject: [Koha-bugs] [Bug 31338] Show in advanced search when IncludeSeeFromInSearches is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31338 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141395|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer --- Created attachment 141530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141530&action=edit Bug 31338: Show in advanced search when IncludeSeeFromInSearches is used Test plan : 1) Apply patch 2) Set system preference IncludeSeeFromInSearches to "Include" 3) Go to staff interface advanced search 4) Check you see tip text in "Search for" 5) Set system preference IncludeSeeFromInSearches to "Don't include" 6) Go to staff interface advanced search 7) Check you don't see tip text in "Search for" Signed-off-by: Owen Leonard Signed-off-by: Lucas Gass Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 23:46:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 21:46:34 +0000 Subject: [Koha-bugs] [Bug 31338] Show in advanced search when IncludeSeeFromInSearches is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31338 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141396|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer --- Created attachment 141531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141531&action=edit Bug 31338: (follow-up) add special class and add also to OPAC In order to easily hide this new text, this patch adds the class "included-see-from-headings-info". Also uses

    instead of

    . And adds the same feature to OPAC. Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 23:47:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 21:47:07 +0000 Subject: [Koha-bugs] [Bug 31635] Empty title for current result in OPAC results browser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 23:53:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 21:53:45 +0000 Subject: [Koha-bugs] [Bug 31635] Empty title for current result in OPAC results browser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 23:53:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 21:53:50 +0000 Subject: [Koha-bugs] [Bug 31635] Empty title for current result in OPAC results browser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141332|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 141532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141532&action=edit Bug 31635: Fix output of current title in OPAC browse results This patch makes a correction to the output of OPAC browse results. In the numbered result navigation links, a title tag on each navigation link should contain the title of the record. The link for the current title didn't include the title information in the title tag because it used the wrong template variables. To test, apply the patch and make sure OpacBrowseResults is enabled. - In OPAC, perform a search that will return multiple results. - View one of the results. - In the right-hand sidebar, click "Browse results." - In the list of numbered links at the top of the panel, hover your mouse over each link. They should each display a tooltip with "View record [title]" - Confirm that the current title in the list includes the correct tooltip. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 23:54:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 21:54:17 +0000 Subject: [Koha-bugs] [Bug 31635] Empty title for current result in OPAC results browser's tooltip on paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Empty title for current |Empty title for current |result in OPAC results |result in OPAC results |browser |browser's tooltip on paging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 23:57:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 21:57:27 +0000 Subject: [Koha-bugs] [Bug 31485] Move ItemsDeniedRenewal checks from C4::Circulation to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31485 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 00:39:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 22:39:36 +0000 Subject: [Koha-bugs] [Bug 31485] Move ItemsDeniedRenewal checks from C4::Circulation to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31485 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 00:39:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 22:39:40 +0000 Subject: [Koha-bugs] [Bug 31485] Move ItemsDeniedRenewal checks from C4::Circulation to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31485 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140506|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 141533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141533&action=edit Bug 31485: Move _item_denied_renewal to Koha::Item The question whether item is denied renewal doesn't depend on circulation rules or the patron, it is only a property of the item and only changes to the item's attributes can cause the return value of the check to change, thus we should move this to be a method of Koha::Item. To test: 1) Run unit tests $ prove t/db_dependent/Circulation.t $ prove t/db_dependent/Koha/Item.t Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 00:46:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 22:46:33 +0000 Subject: [Koha-bugs] [Bug 31519] Unused template parameters in request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 00:53:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 22:53:27 +0000 Subject: [Koha-bugs] [Bug 31519] Unused template parameters in request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 00:53:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 22:53:31 +0000 Subject: [Koha-bugs] [Bug 31519] Unused template parameters in request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140741|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 141534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141534&action=edit Bug 31519: Remove unused SuspendHoldsIntranet and AutoResumeSuspendedHolds variables If you grep koha-tmpl/intranet-tmpl/prog/en for those you will see there are no references for those. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 00:53:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 22:53:35 +0000 Subject: [Koha-bugs] [Bug 31519] Unused template parameters in request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140742|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 141535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141535&action=edit Bug 31519: Move preference fetching directly to be done in the template Since we are not in a loop or using this multiple times it's simple to do it this way, helps with changing the template code in the future too since if we want to remove this syspref variable we know it is only used in this one particular place. To test: 1) Grep for reserve_in_future and make sure there are no matches after applying this patch Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 01:09:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 23:09:06 +0000 Subject: [Koha-bugs] [Bug 31595] Import patrons tool should not process extended attributes if no attributes are being imported In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31595 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 01:15:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 23:15:55 +0000 Subject: [Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493 --- Comment #13 from Katrin Fischer --- Would be great to see this one rescued! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 01:29:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2022 23:29:11 +0000 Subject: [Koha-bugs] [Bug 31720] New: Output of export_borrowers with all fields cannot be imported Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31720 Bug ID: 31720 Summary: Output of export_borrowers with all fields cannot be imported Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz You used to be able to use the output of export_borrowres for patron import in Koha, but it looks like the file now contains some fields like 'description' with the patron category description, that cannot be used in patron import. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 03:02:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 01:02:01 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30733 CC| |fridolin.somers at biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 [Bug 30733] Simplify translatable strings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 03:02:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 01:02:01 +0000 Subject: [Koha-bugs] [Bug 30733] Simplify translatable strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31718 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 [Bug 31718] Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 03:44:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 01:44:25 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 --- Comment #5 from Fridolin Somers --- Created attachment 141536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141536&action=edit Bug 31718: Others facilitate translation in frameworks administration Some other IF/ELSE/END can be changed to facilitate translation Test plan : Always test with default framework and with another framework and compare with and without patch 1) View subfields of field => Check the h1 in page 2) Perform actions on a field (create, modify, delete) => Check breadcrumbs and h1 in page 3) View the framework table => Check columns Repeatable, Mandatory, Important -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 03:45:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 01:45:55 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 --- Comment #6 from Fridolin Somers --- I signed first patch and added a new one for some other IF/ELSE/END that can facilitate translation. Like did Bug 30733 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 12:02:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 10:02:15 +0000 Subject: [Koha-bugs] [Bug 31587] Basket not accessible from ACQORDER notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 12:02:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 10:02:19 +0000 Subject: [Koha-bugs] [Bug 31587] Basket not accessible from ACQORDER notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140787|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 141537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141537&action=edit Bug 31587: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 12:02:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 10:02:24 +0000 Subject: [Koha-bugs] [Bug 31587] Basket not accessible from ACQORDER notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140788|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 141538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141538&action=edit Bug 31587: Basket not accessible from ACQORDER notice The parameter "aqbasket" is passed to GetPreparedLetter, but is always undefined for the notice ACQORDER. Test Plan: 1) Set your ACQORDER notice content to: ***[% basket %]*** 2) Set up a vendor with an email, set contact for email so the "E-mail order" button shows on a basket for that vendor 3) E-mail the basket 4) Note the email contents are "******" 5) Apply this patch 6) Restart all the things! 7) Email the basket again 8) Note the content looks something like: ***Koha::Acquisition::Basket=HASH(0x55870acd96e0)*** Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 12:02:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 10:02:44 +0000 Subject: [Koha-bugs] [Bug 31587] Basket not accessible from ACQORDER notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #6 from Katrin Fischer --- Thanks again, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 12:03:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 10:03:54 +0000 Subject: [Koha-bugs] [Bug 30791] Make it possible to use basket information in ACQORDER subjects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30791 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- This turns out to be a duplicate of bug 31587, the patches there also make the basket information available on the subject line. *** This bug has been marked as a duplicate of bug 31587 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 12:03:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 10:03:54 +0000 Subject: [Koha-bugs] [Bug 31587] Basket not accessible from ACQORDER notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- *** Bug 30791 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 12:17:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 10:17:35 +0000 Subject: [Koha-bugs] [Bug 31595] Import patrons tool should not process extended attributes if no attributes are being imported In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31595 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 12:17:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 10:17:39 +0000 Subject: [Koha-bugs] [Bug 31595] Import patrons tool should not process extended attributes if no attributes are being imported In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31595 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140840|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 141539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141539&action=edit Bug 31595: Don't process extended attributes if none are inlcuded in the file This patch simply adds a check to the import process to only process attrbutes if they have been found in the data To test: 1 - Import some patrons without extended attributes 2 - Import patrons including extended attributes 3 - Confirm both work unchanged Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 12:19:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 10:19:47 +0000 Subject: [Koha-bugs] [Bug 17379] Add a man page for koha-passwd In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17379 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 12:36:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 10:36:46 +0000 Subject: [Koha-bugs] [Bug 17379] Add a man page for koha-passwd In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17379 --- Comment #21 from Katrin Fischer --- I also installed apt-get install man-db. And I did a reset_all in hope that the files would get copied to the right place. Also did a man koha-common. I am not sure what worked :( But: man koha-passwd now shows the help for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 12:38:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 10:38:01 +0000 Subject: [Koha-bugs] [Bug 17379] Add a man page for koha-passwd In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17379 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 12:38:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 10:38:06 +0000 Subject: [Koha-bugs] [Bug 17379] Add a man page for koha-passwd In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17379 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57848|0 |1 is obsolete| | Attachment #140838|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer --- Created attachment 141540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141540&action=edit Bug 17379: Add a man page for koha-passwd Adding a manpage for the koha-passwd utility. To test: 1) Run these commands and look at the formatted man page: $xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl \ debian/docs/koha-passwd.xml 2)$man -l koha-passwd.8 3) Make sure this test passes: $prove -v xt/verify-debian-docbook.t Signed-off-by: Mika Smith Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 12:38:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 10:38:10 +0000 Subject: [Koha-bugs] [Bug 17379] Add a man page for koha-passwd In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17379 --- Comment #23 from Katrin Fischer --- Created attachment 141541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141541&action=edit Bug 17379: Add a man page for koha-passwd (2) Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 12:40:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 10:40:22 +0000 Subject: [Koha-bugs] [Bug 27315] The man pages for the command line utilities do not display properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27315 --- Comment #5 from Katrin Fischer --- (In reply to Andreas Roussos from comment #4) > I'm revisiting this as it's still valid in 22.05.02. > > Thanks to the comments posted at the following GitHub issue > I believe I've found what's causing the broken man pages: > https://github.com/docbook/xslt10-stylesheets/issues/123 > > The source XML files for our man pages have the following namespace > declaration at the top: xmlns='http://docbook.org/ns/docbook'. That > means they are DocBook V5.0 documents and should be processed by > namespace-aware DocBook XSL stylesheets. > > However, the Stylesheet that generates the man pages from the DocBook > XML source files is currently part of the docbook-xsl package. > I think we should be using the Stylesheet from the docbook-xsl-ns > package instead (I've actually tested this on Debian 9/10/11 and it > worked just fine -- the generated man pages did not have any issues). I Andreas, I just ran into this issue testing bug 17379. Could you share a patch with your solution? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 12:42:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 10:42:04 +0000 Subject: [Koha-bugs] [Bug 28799] Action logs should capture lost items found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 12:50:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 10:50:18 +0000 Subject: [Koha-bugs] [Bug 28799] Action logs should capture lost items found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 12:50:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 10:50:22 +0000 Subject: [Koha-bugs] [Bug 28799] Action logs should capture lost items found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140849|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 141542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141542&action=edit Bug 28799: Log when item was lost and now found In the subroutine ModDateLastSeen we unset an item's lost status when checked in. This routine passes a noi log parameter to the store request, this is to avoid spamming the cataloguing log on every checkin. When marking an item unlost we should record this change. To test: 1 - Enable cataloguing log 2 - Mark an item lost 3 - View the log and confirm this chagne was recorded 4 - Check the item in 5 - The message indicates item is now found, but logs have no new entry 6 - Apply patch, restart all 7 - Mark the item lost and verify it is logged 8 - Check the item in, reported found and log entry recorded Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 12:51:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 10:51:59 +0000 Subject: [Koha-bugs] [Bug 29561] Remove blank facet for languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize at ptfs-europe |katrin.fischer at bsz-bw.de |.com | --- Comment #11 from Katrin Fischer --- Stealing this QA from Martin ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 13:01:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 11:01:09 +0000 Subject: [Koha-bugs] [Bug 29561] Remove blank facet for languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29561 --- Comment #12 from Katrin Fischer --- Turning on displayFacetCount helps to make this more visible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 13:01:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 11:01:38 +0000 Subject: [Koha-bugs] [Bug 29561] Remove blank facet for languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 13:01:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 11:01:42 +0000 Subject: [Koha-bugs] [Bug 29561] Remove blank facet for languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140862|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 141543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141543&action=edit Bug 29561: Unit test Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 13:01:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 11:01:46 +0000 Subject: [Koha-bugs] [Bug 29561] Remove blank facet for languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140863|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 141544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141544&action=edit Bug 29561: Remove blank facets This patch strips the blank facets from the ES aggregations, this seems to only affect language fields currently, but could affect any facetable field that can contain blank values To test: 1 - Have Koha running Elasticsearch with standard test data, or add some records with blank values in the 008/35-37 2 - Search for 'a' 3 - Look at the language facets, they should appear normal 4 - Browse to: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=&q=a&sort_by=relevance_dsc&count=20&limit=ln: 5 - Note there is now an 'x' under the Languages facet - to remove a limit you cannot see 6 - Apply patch 7 - Reload 8 - Note the x is not there 9 - Inspect HTML, confirm no blank link under language facets Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 13:01:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 11:01:51 +0000 Subject: [Koha-bugs] [Bug 29561] Remove blank facet for languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140864|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 141545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141545&action=edit Bug 29561: (follow-up) Don't remove facet '0' Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 13:10:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 11:10:01 +0000 Subject: [Koha-bugs] [Bug 29561] Remove blank facet for languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31668 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 13:10:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 11:10:01 +0000 Subject: [Koha-bugs] [Bug 31668] Avoid displaying nothing in facet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31668 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29561 --- Comment #2 from Katrin Fischer --- At the moment I believe this is not fully functional. With this patch, we display a text, the count displays correctly, but when clicking on the link, we find 'all', as the empty search with ln: doesn't work right. There are a lot of reasons why a library might not have added language information, like dealing with old/migrated data. For the moment I prefer Nick's solution on bug 29561 that removes those empty facets from display - so they won't appear at all if empty. If I misunderstood something, please let me know! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 13:15:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 11:15:22 +0000 Subject: [Koha-bugs] [Bug 28555] Improve output of verbose option for overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28555 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve logging for |Improve output of verbose |overdue_notices.pl |option for | |overdue_notices.pl QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 13:39:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 11:39:46 +0000 Subject: [Koha-bugs] [Bug 28555] Improve output of verbose option for overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28555 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer --- I really like the improved output, but -v and -v -v lead to the same result for me. Also, if they are supposed to make a difference, this should be advertised when running -h on the script. I personally don't miss the SQL :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 14:01:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 12:01:29 +0000 Subject: [Koha-bugs] [Bug 25763] Allow update of order fund after receipt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 14:15:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 12:15:11 +0000 Subject: [Koha-bugs] [Bug 25763] Allow update of order fund after receipt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 --- Comment #8 from Katrin Fischer --- (In reply to Katrin Fischer from comment #5) > Hi Nick, I like the idea of this! > > I believe the "No fund" option should be removed here. An order will always > have a fund as it's mandatory and if you try to unset it (which should not > be possible) you receive an error on saving. > > Statistic 1 and 2 should also end with a colon as form labels. > > The GUI looks a little bit "rough", but it's subtle, like some missing > padding or maybe because the form fields are not aligned nicely with the > labels? Could be something for a later patch. I did not remember writing this... is this that getting old thing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 14:16:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 12:16:16 +0000 Subject: [Koha-bugs] [Bug 25763] Allow update of order fund after receipt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 14:16:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 12:16:21 +0000 Subject: [Koha-bugs] [Bug 25763] Allow update of order fund after receipt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140865|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 141546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141546&action=edit Bug 25763: Allow updating of order fund from invoice To test: 1 - Receive some orders via acquisitions 2 - View the invoice with these orders 3 - Click 'Modify fund' on the received orders list 4 - Confirm you can change the fund 5 - Set some authorised value categories for funds 6 - Reload the invoice 7 - Confirm the categories dropdowns change when different funds selected 8 - Confirm updating the statistic fields saves correctly 9 - Add an inactive budget with some funds 10 - Test the 'show inactive' button on shipment fund, adjustments, and modifying order fund Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 14:16:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 12:16:26 +0000 Subject: [Koha-bugs] [Bug 25763] Allow update of order fund after receipt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140866|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 141547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141547&action=edit Bug 25763: (follow-up) Fix display and remove 'No fund' This patch adds a fieldset around the inputs to style them as other places in Koha Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 14:23:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 12:23:17 +0000 Subject: [Koha-bugs] [Bug 31721] New: Log changes to orders made via orders API Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31721 Bug ID: 31721 Summary: Log changes to orders made via orders API Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de CC: tomascohen at gmail.com Bug 25763 allows to change the fund of a received order via an API call. But this change won't be logged if the AcquisitionsLog is activated. We should log changes made via the API on acquisition date the same as we already do for changes to patrons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 14:24:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 12:24:20 +0000 Subject: [Koha-bugs] [Bug 25763] Allow update of order fund after receipt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31721 --- Comment #11 from Katrin Fischer --- I like this functionality, but I'd like it better if the changes were logged. I filed bug 31721 to make a case for logging changes made to orders via the API. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 14:24:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 12:24:20 +0000 Subject: [Koha-bugs] [Bug 31721] Log changes to orders made via orders API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31721 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25763 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 14:35:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 12:35:50 +0000 Subject: [Koha-bugs] [Bug 31649] Acquisition basket CSV export fails if biblio does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 14:41:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 12:41:14 +0000 Subject: [Koha-bugs] [Bug 31649] Acquisition basket CSV export fails if biblio does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 14:41:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 12:41:19 +0000 Subject: [Koha-bugs] [Bug 31649] Acquisition basket CSV export fails if biblio does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141084|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 141548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141548&action=edit Bug 31649: Add unit tests Creates new test file GetBasketGroupAsCSV.t Test with : prove t/db_dependent/Acquisition/GetBasketAsCSV.t prove t/db_dependent/Acquisition/GetBasketGroupAsCSV.t Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 14:41:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 12:41:23 +0000 Subject: [Koha-bugs] [Bug 31649] Acquisition basket CSV export fails if biblio does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141085|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 141549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141549&action=edit Bug 31649: Fix acquisition basket CSV export if biblio does not exist Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 14:41:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 12:41:28 +0000 Subject: [Koha-bugs] [Bug 31649] Acquisition basket CSV export fails if biblio does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141086|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 141550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141550&action=edit Bug 31649: Fix acquisition basket group CSV export if biblio does not exist Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 14:43:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 12:43:07 +0000 Subject: [Koha-bugs] [Bug 31649] Acquisition basket CSV export fails if biblio does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31649 --- Comment #12 from Katrin Fischer --- This is a good immediate fix to keep libraries going, but ultimately we need to fix the 'deleted records and orders' issue properly. Libraries need to be able to account on acq and that includes being able to tell how money was spent at all times - even after they have been deleted/withdrawn from the library's holdings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 14:46:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 12:46:52 +0000 Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.11 |master QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 14:52:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 12:52:51 +0000 Subject: [Koha-bugs] [Bug 31722] New: Don't show EDIFACT note on basket group page if EDIFACT is turned off Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 Bug ID: 31722 Summary: Don't show EDIFACT note on basket group page if EDIFACT is turned off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org We now have the system preference EDIFACT to turn/on off the EDI functionality. If a vendor has no EDI information linked to it, we currently show this note on the basket group page: No EDIFACT configuration for My Vendor The visibilitey/display of this note should depend on the preference setting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 14:58:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 12:58:46 +0000 Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 14:58:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 12:58:51 +0000 Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141304|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 141551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141551&action=edit Bug 31257: Add a new English 1 page layout to export basketgroup This patch adds a new English 1 page layout to be used when exporting a basketgroup as PDF. This has been modelled after an example PDF from another library system. To test: 1) Go to Koha Administration -> Libraries. Ensure Library A has an address, phone and fax. 2) Go to Koha Administration -> System preferences. Search for OrderPdfFormat. Set this to the new English 1-page layout option. 3) Go to Acquisitions. Use an existing vendor or create a new one. Ensure the vendor has a postal address, phone, fax and accout number. 4) Create a basket for this vendor. Add a few orders to the basket. 5) Close the basket and add it to a basket group of the same name. 6) Edit the basket group. Add an address in the delivery place, and a delivery comment. Check the box to close the basket group and Save. 7) Click the button to Export as PDF. 8) View the exported PDF. Confirm all of the information displayed is correct. 9) Reopen the basketgroup. Edit the details and remove the delivery place text. Re-close the basketgroup. 10) Repeat steps 7 and 8. Sponsored-by: Pymble Ladies' College Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 14:58:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 12:58:55 +0000 Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141305|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 141552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141552&action=edit Bug 31257: (follow-up) Fix display of PDF This patch rearranges the Qty and Document columns and shifts the vendor account number field lower to make room for address fields Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 14:59:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 12:59:00 +0000 Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 --- Comment #13 from Katrin Fischer --- Created attachment 141553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141553&action=edit Bug 31257: (QA follow-up) Fix some typos The QA tools highlighted some typos in the code comments that this fixes: measurment and milimeter Also removes a space befor colon form: Vendor note : Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 15:19:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 13:19:08 +0000 Subject: [Koha-bugs] [Bug 10135] Adding the ability to define customised basketgroups PDF layouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10135 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Adding the ability to |Adding the ability to |define customised |define customised |basketgroups pdf layouts |basketgroups PDF layouts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 15:21:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 13:21:19 +0000 Subject: [Koha-bugs] [Bug 31723] New: Add TT template based alternative to PDF printing for basket groups Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31723 Bug ID: 31723 Summary: Add TT template based alternative to PDF printing for basket groups Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org I think in order to be able to phase out the current PDF print... we need to offer a nice alternative first. So we should offer a print option for basket groups and possibly also for single baskets that works using a TT notice template as base. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 15:22:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 13:22:28 +0000 Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31723 --- Comment #14 from Katrin Fischer --- This works and I can see how this simpler format will be helpful. But at the same time I wish we had a better technical solution for the PDF printing. The combination of strings in .pm and .odt/.pdf makes every attempt to make these translatable pretty futile... Also no customizations of text etc. without programming :( So I've filed bug 31723 to have a 'home' for that wish to evolve :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 15:22:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 13:22:28 +0000 Subject: [Koha-bugs] [Bug 31723] Add TT template based alternative to PDF printing for basket groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31723 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31257 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 15:23:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 13:23:52 +0000 Subject: [Koha-bugs] [Bug 30168] Use checkout object in GetSoonestRenewDate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 15:25:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 13:25:39 +0000 Subject: [Koha-bugs] [Bug 30168] Use checkout object in GetSoonestRenewDate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 --- Comment #8 from Katrin Fischer --- (In reply to David Nind from comment #7) > I also ran similar tests to bug 30167, for what it is worth. > > - Tested on 09/25/2022 (American date format) with > . 'no renewal before' set to 3 > . 'loan period' set to 5 > - Checked out on date is 09/25/2022 05:10 > - For the patron from the checkouts: No renewal before 04/27/2022 > - When trying to renew from Circulation > Renew, the message is > "Intermediate Perl / ( 39999000005134 ) cannot be renewed before 09/27/2022." > - When trying to renew by checking out to the same patron again, the message > is: "No more renewals possible" > - Date is calculated correctly including the current day (3 days - 25th, > 26th + 27th) Thanks David, your notes are always very helpful! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 15:37:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 13:37:12 +0000 Subject: [Koha-bugs] [Bug 31587] Basket not accessible from ACQORDER notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 --- Comment #8 from Katrin Fischer --- Went ahead and updated the wiki page listing the available objects per notice: https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit#Variables_available_in_each_notice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 16:06:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 14:06:10 +0000 Subject: [Koha-bugs] [Bug 28308] Select 'Days in advance' = 0 for Advance notice effectively disables PREDUE notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28308 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 16:06:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 14:06:49 +0000 Subject: [Koha-bugs] [Bug 29443] Expired patrons should not be allowed to place ILL request on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29443 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 18:07:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 16:07:06 +0000 Subject: [Koha-bugs] [Bug 30168] Use checkout object in GetSoonestRenewDate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 18:07:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 16:07:10 +0000 Subject: [Koha-bugs] [Bug 30168] Use checkout object in GetSoonestRenewDate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140969|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 141554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141554&action=edit Bug 30168: Use checkout object in GetSoonestRenewDate Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 18:07:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 16:07:14 +0000 Subject: [Koha-bugs] [Bug 30168] Use checkout object in GetSoonestRenewDate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 --- Comment #10 from Katrin Fischer --- Created attachment 141555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141555&action=edit Bug 30168: (QA follow-up) Fix POD The POD had $issue in the example, but $checkout in explanation. Also standardized a bit of other terminology. (borrower, issue) = (patron, checkout) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 18:11:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 16:11:28 +0000 Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue notices script ( advance_notices.pl ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17291 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 18:11:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 16:11:28 +0000 Subject: [Koha-bugs] [Bug 17291] Add ... syntax to advance_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17291 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29100 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 18:11:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 16:11:52 +0000 Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue/due notices script (advance_notices.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add checkouts data loop to |Add checkouts data loop to |predue notices script ( |predue/due notices script |advance_notices.pl ) |(advance_notices.pl) QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 18:15:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 16:15:42 +0000 Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue/due notices script (advance_notices.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer --- Hi Kyle, can we please use checkout and checkouts instead of issue? Then it would match with the other notices: https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 18:23:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 16:23:51 +0000 Subject: [Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #74 from Katrin Fischer --- > > I am working on amending my patches to do that now. > > Kind regards, > Alex Hi Alex, moving this out of queue for now - please switch back to Signed-off once you are ready! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 18:26:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 16:26:39 +0000 Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan period if borrower has an 'unfound' hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 22:49:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 20:49:31 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from David Nind --- Hi Aleisha. Everything works as per the test plan EXCEPT for step 7. I cannot cancel a recall and existing or new recall from the OPAC after changing the system preference from 'the OPAC only' to 'the staff interface only'. For step 7 (have an existing recall, hcnage system preference): - Can no longer place recalls (as expected). - Cannot cancel a recall (in OPAC from either your summary > recalls tab or your recalls history). Message is: "Recalls have not been enabled. Please contact your library." David --------------------- Testing notes (using koha-testing-docker): --------------------- Patrons used: - Patron A: Mary Burton (Midway) (changed password and set username to first name) - Patron B: Henry Acevedo (Midway) Step 2: Circulation rules for recalls - Recalls allowed (total): 5 - Recalls per record (count): 1 - On shelf recalls allowed: If any unavailable - Recall due date interval (day): 5 - Recall overdue fine amount:5 - Recall pickup period (day):2 Step 5: - Placed and cancelled a recall from: . the patron's OPAC account (your summary > recalls > cancel) . in the staff interface: . recalls tab for the record . patron's account - details section > holds tab . patron's account - recalls history section . circulation > recalls > recalls queue - Placed and fulfilled the recall . place recall . check item in (and transfer if required) . check item is listed under circulation > recalls > recalls awaiting pickup . check under patron's account that recall status is 'Ready for pickup' . checkout out item to recall requestor . check in item again so that it is available Step 6: before changing the system preference to staff interface only, checkout an item to Patron B and place a recall again for Patron A so that you can view in their OPAC account and cancel - should still be a recalls tab in the your summary section - your recalls history should still be visible - can cancel from both places Step 8: check out Item to Patron B first -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 23:44:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2022 21:44:31 +0000 Subject: [Koha-bugs] [Bug 31716] Enlarge the size of the authorised_value column in authorised_values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31716 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- I can now update an authorized value code using the database, but I can't add or edit using the staff interface as the form entry's maximum length is 80: . When you do try to edit an entry, you get this message on the edit form "Please enter no more than 80 characters." To update a value in the database: 1. koha-mysql kohadev 2. After applying the patch (I also ran dbic - not sure whether that is required) you can see that the change to the database structure has been enabled: show columns from authorised_values; 3. SQL to update an entry - where XXXX = the id of an existing entry: update authorised_values set authorised_value="This is a really really long authorized value although I am not sure why you would want such a code" where id = XXXX; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 9 08:55:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 06:55:32 +0000 Subject: [Koha-bugs] [Bug 31716] Enlarge the size of the authorised_value column in authorised_values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31716 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- ALTER TABLE authorised_values MODIFY COLUMN authorised_value varchar(255) You go from 80 to 255. At some point that is too low again. We should imo go to a TEXT type: A TEXT column with a maximum length of 65,535 (216 - 1) characters. One point: VARCHAR columns can be fully indexed. TEXT columns can only be indexed over a specified length. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 9 23:00:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 21:00:42 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 9 23:00:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 21:00:46 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141526|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 141556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141556&action=edit Bug 31718: Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation This patch changes the strings in the IF ELSE for the framework name in the breadcrumbs on the marc_subfields_structure.pl page. To test: 1) Apply patch 2) In the intranet, go to Administration > MARC bibliographic framework 3) Click 'Actions' next to the default framework and choose 'MARC structure' 4) Click 'Actions' next to a MARC tag and choose 'View subfields' 5) Check the breadcrumbs, they should show Home > Administration > MARC frameworks > Default framework structure > ... 6) Redo steps 2-5, using a different framework, e.g. ACQ The breadcrumbs for ACQ should look like Home > Administration > MARC frameworks > ACQ framework structure > ... Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 9 23:00:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 21:00:51 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141536|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 141557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141557&action=edit Bug 31718: Others facilitate translation in frameworks administration Some other IF/ELSE/END can be changed to facilitate translation Test plan : Always test with default framework and with another framework and compare with and without patch 1) View subfields of field => Check the h1 in page 2) Perform actions on a field (create, modify, delete) => Check breadcrumbs and h1 in page 3) View the framework table => Check columns Repeatable, Mandatory, Important Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 9 23:35:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 21:35:52 +0000 Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan period if patron has an 'unfound' hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de |testopia at bugs.koha-communit | |y.org Summary|DecreaseLoanHighHolds will |DecreaseLoanHighHolds will |decrease loan period if |decrease loan period if |borrower has an 'unfound' |patron has an 'unfound' |hold |hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 9 23:37:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 21:37:14 +0000 Subject: [Koha-bugs] [Bug 31724] New: MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 Bug ID: 31724 Summary: MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When deleting a subfield in a MARC framework, there is an 'i' added to the breadcrumb on the confirm deletion page, for example: - Home > Administration > MARC frameworks > BKS framework structure > Tag 245 Subfield structure > Confirm deletion of subfield ci - This should be ... Confirm deletion of subfield c It looks like this was added in bug 27846 (released in 21.05.00). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 9 23:37:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 21:37:44 +0000 Subject: [Koha-bugs] [Bug 31724] MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |david at davidnind.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 9 23:39:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 21:39:19 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #9 from David Nind --- Testing notes (using KTD) ------------------------- I checked the default framework and the BKS framework. First patch - breadcrumbs when viewing and editing subfields (changes to a single span tag for the framework name): - View the page source - Search for breadcrumbs - Before the patch is applied - default framework: Default framework structure - After the patch is applied - default framework: Default framework structure - Before the patch is applied - BKS framework: BKS framework structure - After the patch is applied - BKS framework: BKS framework structure Second patch - step 1 - view subfields: - View the page source - Search for

    - No change to output for h1 before and after the patch is applied: . Default framework:

    MARC subfield structure admin for 245 (default framework)

    . BKS framework:

    MARC subfield structure admin for 245 (framework BKS)

    . Updates code for template so that it is consistent with other changes (I think) - Breadcrumbs: changes as per the first patch Second patch - step 2 - add, edit and delete a MARC tag: - View the page source - Search for breadcrumbs - After patch is applied: tags added to breadcrumbs where required Second patch - step 3: Framework table: - View the page source - Search for Repeatable - Check the first row of results: ==> should now have tags around all the Nos and Yeses I also noticed that when deleting a tag from the view subfields page that there is an 'i' added to the breadcrumb, for example: - Home > Administration > MARC frameworks > BKS framework structure > Tag 245 Subfield structure > Confirm deletion of subfield ci - Should be ... Confirm deletion of subfield c I've created bug 31724 for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 9 23:45:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 21:45:27 +0000 Subject: [Koha-bugs] [Bug 31588] Update cpanfile for new OpenAPI versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140794|0 |1 is obsolete| | --- Comment #9 from Mason James --- Created attachment 141558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141558&action=edit Bug 31588 - Update cpanfile for new OpenAPI versions (master) Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 9 23:58:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 21:58:46 +0000 Subject: [Koha-bugs] [Bug 31588] Update cpanfile for new OpenAPI versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140801|0 |1 is obsolete| | --- Comment #10 from Mason James --- Created attachment 141559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141559&action=edit Bug 31588 - Update cpanfile for new OpenAPI versions (22.05) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 9 23:58:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 21:58:57 +0000 Subject: [Koha-bugs] [Bug 31724] MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 9 23:59:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 21:59:00 +0000 Subject: [Koha-bugs] [Bug 31724] MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 --- Comment #1 from David Nind --- Created attachment 141560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141560&action=edit Bug 31724: Remove 'i' from breadcrumb when deleting a MARC framework subfield Remove 'i' added to the end of the breadcrumb on the confirmation page when deleteing a MARC framework subfield. Test plan: 1. Go to Administration > MARC bibliographic frameworks. 2. View the subfields for a tag for a framework, for example: . BKS framework > Actions > MARC structure . Search for tag 245 . Select Actions > View subfields. 3. Select any subfield to delete and select the Delete button. 4. Note that there is an 'i' at the end of the breadcrumb, for example: . ... > Confirm deletion of subfield bi 5. Apply the patch. 6. Refresh the page and note that that 'i' is removed. 7. Sign off. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 00:00:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 22:00:20 +0000 Subject: [Koha-bugs] [Bug 31588] Update cpanfile for new OpenAPI versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 --- Comment #11 from Mason James --- (In reply to David Nind from comment #8) > I think there is a mistake in the patches for master and 22.05 - the version > number for JSON:Validator has a comma in it instead of a full stop: > requires 'JSON::Validator', '5,08'; > oops, ive fixed the comma ',' :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 00:02:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 22:02:10 +0000 Subject: [Koha-bugs] [Bug 31724] MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the breadcrumb release notes| |when deleting a subfield | |for a framework. An 'i' was | |incorrectly added to the | |end of the breadcrumb on | |the deletion confirmation | |page, for example: ... > | |Confirm deletion of | |subfield bi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 00:09:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 22:09:19 +0000 Subject: [Koha-bugs] [Bug 31588] Update cpanfile for new OpenAPI versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141558|0 |1 is obsolete| | --- Comment #12 from David Nind --- Created attachment 141561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141561&action=edit Bug 31588 - Update cpanfile for new OpenAPI versions (master) Signed-off-by: Mason James Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 00:16:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 22:16:51 +0000 Subject: [Koha-bugs] [Bug 31588] Update cpanfile for new OpenAPI versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141559|0 |1 is obsolete| | --- Comment #13 from David Nind --- Created attachment 141562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141562&action=edit Bug 31588 - Update cpanfile for new OpenAPI versions (22.05) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 00:39:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 22:39:04 +0000 Subject: [Koha-bugs] [Bug 31588] Update cpanfile for new OpenAPI versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140802|0 |1 is obsolete| | --- Comment #14 from David Nind --- Created attachment 141563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141563&action=edit Bug 31588 - Update cpanfile for new OpenAPI versions (21.11) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 00:50:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 22:50:16 +0000 Subject: [Koha-bugs] [Bug 31588] Update cpanfile for new OpenAPI versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140803|0 |1 is obsolete| | --- Comment #15 from David Nind --- Created attachment 141564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141564&action=edit Bug 31588 - Update cpanfile for new OpenAPI versions (21.05) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 00:52:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 22:52:39 +0000 Subject: [Koha-bugs] [Bug 31588] Update cpanfile for new OpenAPI versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #16 from David Nind --- Have signed off. See comment #8 for how I tested - hope this is sufficient. Note that for Koha 21.05, Locale::XGettext::TT2 (0.7) shows as orange and Not Installed. David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 00:59:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 22:59:18 +0000 Subject: [Koha-bugs] [Bug 31612] koha-z3950-responder breaks if it's run in a Koha that was created before bug 28364 was applied In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31612 --- Comment #2 from David Cook --- (In reply to Martin Renvoize from comment #1) > We find lots of issues with permissions at upgrades.. mostly for 'standard' > type installs though. I think that's probably a separate issue although an interesting one. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 01:44:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 23:44:27 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #9 from David Cook --- (In reply to Martin Renvoize from comment #4) > I wondered if it was as simple as just running it through RecordProcessor.. > but when I started to have a quick look at the code I couldn't wrap my head > around it.. perhaps not as simple as it appears on the surface. Actually, looking at this again, I think running it through RecordProcessor might work. It would be *slow*, but in theory it should work. The OAI-PMH feed is just a stream of records that we break up using resumption tokens. I suppose if OpacHiddenItems is set and OpacHiddenItemsHidesRecord is set to "Don't hide", then the timestamp for records could reflect changes to items that aren't visible in the OAI-PMH feed, but... that is a minor detail and doesn't look avoidable without making SQL changes. I'm going to email Ere and see what he thinks about this, since he's been behind the latest and greatest OAI-PMH server changes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 01:44:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 23:44:49 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala at helsinki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 01:45:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 23:45:59 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19704 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 01:45:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2022 23:45:59 +0000 Subject: [Koha-bugs] [Bug 19704] OPACs most popular feature includes titles hidden by OpacHiddenItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19704 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31161 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 02:05:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 00:05:37 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #10 from David Cook --- Ah... but the $order_limit specifies a LIMIT which would be a problem if we were filtering out records using RecordProcessor... That said, we could move the record fetch into a function and run it again if the $count hadn't hit the $max. That would make the response even slower than it already would be using RecordProcessor though... But I can't think of a simple way to support "OpacHiddenItemsHidesRecord: Hide" except by post-processing outside the SQL. -- Another thought I had was that maybe we do need to store "hidden_in_opac" in the "biblio" and "items" DB table records. If someone updates "OpacHiddenItems", then they need to do a "touch all items". In theory, this is a system preference that shouldn't be frequently changed anyway. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 02:16:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 00:16:35 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #11 from David Cook --- One downside of hiding records/items in the OAI-PMH is that if you turn on your hiding after you've already harvested a Koha DB, then you'll never get the update... In theory, maybe it makes sense to mark a bib record as deleted - if it's been marked as hidden. That might not be compatible with the system preference "OpacSuppressionRedirect" though. If that syspref says "404" and OAI-PMH says "deleted"... that means that the record did once exist... And since deleted records are shown first and then existent records are shown second, a savvy consumer of OAI-PMH feeds could use it to infer that a record has been hidden rather than deleted... -- But it's an interesting idea. When I harvest records from Koha using plugins, I'll return "deleted" when a record is "hidden", as that allows newly hidden records/items to be removed from the third-party system automatically. -- I suppose that's only really relevant for supporting "OpacSuppression" and "OpacHiddenItemsHidesRecord: Hide" Technically, "OpacHiddenItems" could be supported now (with the only information leaking being based on update timestamps for hidden items but technically a record could have its timestamp updated with zero bib metadata changed so that's not necessarily revealing). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 02:18:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 00:18:30 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Component|MARC Bibliographic data |Web services |support | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 02:21:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 00:21:56 +0000 Subject: [Koha-bugs] [Bug 30252] lower version of 'Locale::XGettext::TT2' to 0.6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30252 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate --- Comment #13 from Mason James --- (In reply to Kyle M Hall from comment #5) > Pushed to 21.11.x for 21.11.05 can we push to 21.05 pleeese -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 02:22:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 00:22:20 +0000 Subject: [Koha-bugs] [Bug 30252] lower version of 'Locale::XGettext::TT2' to 0.6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30252 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 02:24:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 00:24:01 +0000 Subject: [Koha-bugs] [Bug 31588] Update cpanfile for new OpenAPI versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30252 --- Comment #17 from Mason James --- (In reply to David Nind from comment #16) > Have signed off. > > See comment #8 for how I tested - hope this is sufficient. > > Note that for Koha 21.05, Locale::XGettext::TT2 (0.7) shows as orange and > Not Installed. this will be fixed when bug 30252 is pushed to 21.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 02:24:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 00:24:01 +0000 Subject: [Koha-bugs] [Bug 30252] lower version of 'Locale::XGettext::TT2' to 0.6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30252 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31588 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 02:26:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 00:26:29 +0000 Subject: [Koha-bugs] [Bug 31725] New: OAI-PMH - Hide items using OpacHiddenItems Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31725 Bug ID: 31725 Summary: OAI-PMH - Hide items using OpacHiddenItems Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org I first mentioned this on Bug 31161, since OpacHiddenItems can hide bib records too via OpacHiddenItemsHidesRecord. However, the actual mechanism for hiding the items is separate to hiding bib records, so I thought I'd explore this separately. The function to look at here is Koha::OAI::Server::Repository->get_biblio_marcxml() -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 02:26:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 00:26:36 +0000 Subject: [Koha-bugs] [Bug 31725] OAI-PMH - Hide items using OpacHiddenItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31725 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31161 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 02:26:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 00:26:36 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31725 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 02:29:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 00:29:12 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #12 from David Cook --- I've opened bug 31725 to address the hiding of items using OpacHiddenItems. And it's got me thinking that the "deleted" status might be the way to go for records hidden using OpacSuppression or OpacHiddenItems. It's not a 100% perfect solution, but I think it could be a "good enough" solution. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 02:58:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 00:58:54 +0000 Subject: [Koha-bugs] [Bug 31688] Cannot set branches to non-public via administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31688 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 03:06:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 01:06:14 +0000 Subject: [Koha-bugs] [Bug 25972] SIP2 server doesn't have a TLS/SSL-enabled listener In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25972 --- Comment #4 from David Cook --- (In reply to Magnus Enger from comment #3) > Could this mean that enabling SSL is as simple as adding proto, SSL_key_file > and SSL_cert_file to the in the SIPconfig.xml? Or are there > more adjustments that are needed somewhere? I'd have to look into it more. But I don't think that this is something I'm likely to work on. stunnel works well especially in a more centralized reverse proxy setup, so it's a good tool to use. After talking with more hardware vendors, it seems like stunnel is often used on the client side as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 04:54:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 02:54:55 +0000 Subject: [Koha-bugs] [Bug 31726] New: Show record type in z39.50 search results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31726 Bug ID: 31726 Summary: Show record type in z39.50 search results Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl With more and more records being electronic, it would be useful to add another column to the z39.50 search results which tells us what type of record the result is, i.e. physical or electronic or something else. This could possibly be pulled from the 006 (MARC) of the record. It would be helpful for libraries who aren't as confident in cataloguing standards but want to make sure they're importing the right type of record to their catalogue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 06:42:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 04:42:53 +0000 Subject: [Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #75 from Alex Buckley --- (In reply to Katrin Fischer from comment #74) > > > > I am working on amending my patches to do that now. > > > > Kind regards, > > Alex > > Hi Alex, moving this out of queue for now - please switch back to Signed-off > once you are ready! Hi Katrin, thank you, will do! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 08:21:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 06:21:18 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #13 from Ere Maijala --- (In reply to David Cook from comment #12) > I've opened bug 31725 to address the hiding of items using OpacHiddenItems. > > And it's got me thinking that the "deleted" status might be the way to go > for records hidden using OpacSuppression or OpacHiddenItems. > > It's not a 100% perfect solution, but I think it could be a "good enough" > solution. I think it's the only solution that would work without forementioned side-effects. It's important to report the records as deleted particularly since they might not have been suppressed before. And that'd be the case for practically every vanilla Koha instance harvested with OAI-PMH up until this change. That said, there are use cases where OAI-PMH is used for non-opac functionality and suppressed records should be included just like before. For flexibility it should be possible to configure suppression per OAI-PMH set in addition to a default setting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 08:44:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 06:44:23 +0000 Subject: [Koha-bugs] [Bug 21705] Map copyrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 --- Comment #13 from Marcel de Rooy --- (In reply to Caroline Cyr La Rose from comment #12) > Hi Marcel, > I added release notes specifying it is only for new installations and where > to add it for current installations. > Do you want me to also add a dbrev like in bug 30850? > Thanks! > Caroline Let's see if our RM should insist.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 08:49:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 06:49:00 +0000 Subject: [Koha-bugs] [Bug 21705] Map copyrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 --- Comment #14 from Katrin Fischer --- Historically we haven't changed mappings on update and it's not enough anyway, as you would create an inconsistent state of the data: the mappings only work for the new records. So this could lead more to confusion than being actually helpful. If people want this, they also need to run the script to update existing data or be aware of the change. ( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 08:58:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 06:58:47 +0000 Subject: [Koha-bugs] [Bug 21705] Map copyrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 --- Comment #15 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #14) > Historically we haven't changed mappings on update and it's not enough > anyway, as you would create an inconsistent state of the data: the mappings > only work for the new records. So this could lead more to confusion than > being actually helpful. If people want this, they also need to run the > script to update existing data or be aware of the change. ( True, but please read the context. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 09:35:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 07:35:23 +0000 Subject: [Koha-bugs] [Bug 21705] Map copyrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 --- Comment #16 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #15) > (In reply to Katrin Fischer from comment #14) > > Historically we haven't changed mappings on update and it's not enough > > anyway, as you would create an inconsistent state of the data: the mappings > > only work for the new records. So this could lead more to confusion than > > being actually helpful. If people want this, they also need to run the > > script to update existing data or be aware of the change. ( > > True, but please read the context. Ah, sorry... can we blame Monday morning? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 10:12:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 08:12:29 +0000 Subject: [Koha-bugs] [Bug 31495] Allow opac-page when enforcing GDPR policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31495 Mirjam Vantieghem changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirjam.vantieghem at etf.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 10:26:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 08:26:15 +0000 Subject: [Koha-bugs] [Bug 31455] Batch modification tool orders found items by itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31455 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|22.11.00,21.11, 22.05.05 |22.11.00,22.05.05,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 10:29:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 08:29:24 +0000 Subject: [Koha-bugs] [Bug 31455] Batch modification tool orders found items by itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31455 --- Comment #8 from Fridolin Somers --- We could have define no sort by default like in batch record modification : "aaSorting": [], -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 10:35:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 08:35:40 +0000 Subject: [Koha-bugs] [Bug 31455] Batch modification tool orders found items by itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31455 --- Comment #9 from Fridolin Somers --- (In reply to Arthur Suzuki from comment #7) > Thanks! > > Pushed to 21.11 for 21.11.12 Ich I dont see first patch in 21.11.x : https://git.koha-community.org/Koha-community/Koha/commits/branch/21.11.x/search?q=31455 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 11:11:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 09:11:05 +0000 Subject: [Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 11:11:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 09:11:11 +0000 Subject: [Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138766|0 |1 is obsolete| | --- Comment #42 from David Nind --- Created attachment 141565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141565&action=edit Bug 23111: Set a custom framework as the default when importing records or editing records with no framework mapped. To test: 1) Go to edit a biblio with no framework mapped 2) Click the Settings dropdown, notice that the 'Default' framework is selected 3) Go to the Cataloguing home page. Click the main 'New from Z39.50/SRU' button and notice the selected framework in the URL is 'Default' 4) Go to Tools -> Stage MARC records for import. Stage a bibliographic record. Go to Staged MARC management for your newly imported batch. Notice that the frameworks dropdown (above the 'Import this batch into the catalog' button) has the 'Default' framework selected 5) Apply this patch and update the database. Apply the schema changes patch or update your schema files. Restart memcached and plack. 6) Go to Administration -> MARC bibliographic frameworks. Edit one of your custom frameworks. Set it as default by checking the checkbox and saving. 7) Edit a different custom framework and set this one as the default now. Confirm that the previous framework has been unset (the checkbox is no longer checked) as the default. 8) Repeat steps 1-4 and confirm that the selected framework is your newly set default framework, instead of the provided 'Default' framework. 9) Go back to Administration -> MARC bibliographic frameworks. Edit your default framework and unset it as default (uncheck the checkbox). Save. 10) Repeat steps 1-4 and confirm that the selected framework is the provided 'Default' framework again, so we can have no default custom framework if chosen. 11) Confirm the tests pass: t/db_dependent/Koha/BiblioFrameworks.t Sponsored-by: Catalyst IT Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 11:11:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 09:11:17 +0000 Subject: [Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138767|0 |1 is obsolete| | --- Comment #43 from David Nind --- Created attachment 141566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141566&action=edit Bug 23111: Schema changes Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 11:11:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 09:11:22 +0000 Subject: [Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138768|0 |1 is obsolete| | --- Comment #44 from David Nind --- Created attachment 141567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141567&action=edit Bug 23111: Making is_default a boolean flag Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 11:11:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 09:11:28 +0000 Subject: [Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138769|0 |1 is obsolete| | --- Comment #45 from David Nind --- Created attachment 141568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141568&action=edit Bug 23111: (follow-up) Add a column to show default framework Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 11:11:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 09:11:34 +0000 Subject: [Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138770|0 |1 is obsolete| | --- Comment #46 from David Nind --- Created attachment 141569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141569&action=edit Bug 23111: (follow-up) set default framework on advanced editor This patch ensures the advanced editor considers the default biblio framework. Also fixing bug in atomic update Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 11:19:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 09:19:40 +0000 Subject: [Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #47 from David Nind --- I've signed off as everything works as per the test plan. I enable the advanced editor (EnableAdvancedCatalogingEditor system preference) and this worked as expected with this change. I did note that in the staff interface when on the details page for an existing record, you have the option of New > New record - this defaults to the default framework even if another framework is set as the default. There may be other areas where /cgi-bin/koha/cataloguing/addbiblio.pl is used... possibly these can be addressed in a follow-up bug when these are identified, for example in the acquisitions area. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 11:44:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 09:44:34 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es --- Comment #39 from Hugo Agud --- First library surprised. The accdetail send the password via mail when a new account is created, but instead of plain text they receive the encrypted password I agree to hide the password this way, but perhaps give them a chance of creating a password on they fly? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 11:47:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 09:47:35 +0000 Subject: [Koha-bugs] [Bug 25972] SIP2 server doesn't have a TLS/SSL-enabled listener In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25972 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- In our experience, SIP2 clients still don't support this in the vast majority of cases.. we encourage all our customers to use stunnel and that's working well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 12:27:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 10:27:08 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 --- Comment #40 from Katrin Fischer --- (In reply to Hugo Agud from comment #39) > First library surprised. > > The accdetail send the password via mail when a new account is created, but > instead of plain text they receive the encrypted password > > I agree to hide the password this way, but perhaps give them a chance of > creating a password on they fly? You can add a link to the 'forget-password' URL to the notice, so they can set a new password themselves right away. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 13:10:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 11:10:10 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #52 from Marcel de Rooy --- (In reply to Nick Clemens from comment #51) Thx for QA > Minor QA tool failure Fixed. Renamed sub, forgot POD header. Adding follow-up. > Why use AV for consents? Looking ahead to bug 20380 it seems the consents > will have more options - maybe we could create a 'consent_types' table and > use that? Could be done later indeed. Decided here to start with AV and its existing functionality. > Currently too - branch limits are half implemented - I don't see the tab if > my only consent is branch limited - but I can force go to the page and see > the consent options - was this a plan, or a side effect of choosing AV? Good catch. This is the most serious issue imo. And a blocker. Would addressing this be sufficient for you to pass QA? If not, I will probably have to switch first to Additional contents fixing. And try this again for 23.05 or 23.11. > The description displays in the form, but the title is still the AV - can > let go in light of 31570, but it is lees friendly to see "Consent for > GDPR_PROCESSING" Correct. Should be addressed later on. > +use constant AV_CONSENT => 'PATRON_CONSENT'; > Why not just use the string in the search? Same question for existing: > use constant GDPR_PROCESSING => 'GDPR_PROCESSING'; Using constants is good practice. When we add another instance, we can refer to the constant. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 13:10:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 11:10:52 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #53 from Marcel de Rooy --- Created attachment 141570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141570&action=edit Bug 31503: (QA follow-up) Fix POD warning FAIL pod coverage POD is missing for 'values' I renamed the sub in the process :) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 13:19:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 11:19:38 +0000 Subject: [Koha-bugs] [Bug 31714] Add a more generic way to print patron slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141515|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 141571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141571&action=edit Bug 31714: Add Generic way to print patron slips This patch adds a very simple controller and template to allow patron slip printing without all the boilerplate. See bug 31713 for an example use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 13:20:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 11:20:21 +0000 Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141517|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 141572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141572&action=edit Bug 31713: Add FEE_SUMMARY print slip link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 13:20:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 11:20:28 +0000 Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 --- Comment #3 from Martin Renvoize --- Created attachment 141573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141573&action=edit Bug 31713: Add FEE_SUMMARY slip template This patch adds the new FEE_SUMMARY print slip notice template to the database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 13:20:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 11:20:50 +0000 Subject: [Koha-bugs] [Bug 31714] Add a more generic way to print patron slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 13:20:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 11:20:54 +0000 Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 13:21:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 11:21:39 +0000 Subject: [Koha-bugs] [Bug 12285] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #48 from Martin Renvoize --- Please see my simplified and modernized alternative in bug 31713 and bug 31714. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 13:25:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 11:25:15 +0000 Subject: [Koha-bugs] [Bug 12285] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31714 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 13:25:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 11:25:15 +0000 Subject: [Koha-bugs] [Bug 31714] Add a more generic way to print patron slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12285 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 13:36:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 11:36:12 +0000 Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141573|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 141574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141574&action=edit Bug 31713: Add FEE_SUMMARY slip template This patch adds the new FEE_SUMMARY print slip notice template to the database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 13:38:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 11:38:21 +0000 Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141574|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 141575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141575&action=edit Bug 31713: Add FEE_SUMMARY slip template This patch adds the new FEE_SUMMARY print slip notice template to the database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 13:40:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 11:40:18 +0000 Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 --- Comment #6 from Martin Renvoize --- To test: 1) Apply patches from bug 31714 and 31713 2) Check in tools > Notices & Slips that you have the new FINE_SUMMARY slip, and a print message there. If not, run updatedatabase.pl 3) Either create some fines for a patron, or look up a patron with existing fines.. Bonus points, also add some credits to the patron. 4) From that patron's detail page, and the Print-menu in the toolbar, select "Print fines slip" 5) You should get a slip of the patron's outstanding fines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 16:15:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 14:15:06 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com --- Comment #25 from Andrew Nugged --- DANGER!!! ALERT!!! The atomic update FILLS database for BRANCHES rules which not existed before, and values take precedence but are still hidden from the operator! for example, if you had holdallowed for some branch set up, that is table 5 on the page, not 1st, after the atomic update, you will have hidden issuedate=0 for 1st table, and the operator never will notice this until it gets into the raw database. But a single value of issuedate=0 will become applied OVER "all" branches rules because branches have higher precedence. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 16:21:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 14:21:15 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #26 from Andrew Nugged --- Those who installed this on production will get issues with the circulation_rules table because of atomic update. So: On smart-rules.pl (Home > Administration > Circulation and fine rules): we have 5 tables: 1. Defining circulation and fine rules for all libraries (... for XXX branch, if branch selected) 2. Default checkout, hold and return policy (... for XXX branch, if branch selected) 3. Checkout, hold policy by patron category (... for XXX branch, if branch selected) 4. Lost item fee refund on return policy (... for XXX branch, if branch selected) 5. Holds policy by item type (... for XXX branch, if branch selected) and with dropdown, we can select rules for "Standard rules for all libraries" or switch to ANY of the available branches represented by the whole page. THE ISSUE: ... and this atomic update was intended to add "empty strings" and "zeroes" to: issuelength, hardduedate, unseenrenewalsallowed, rentaldiscount, decreaseloanholds values, and the intention of atomuc update looks like was to select ANY combination of branch/itemtype/category of else in DB, then for those, we should add those "zeroes" and "empty strings". Like it was "some rows in table 1 if only, then we add empty/zeroes". But those "any combination" also covers rules belonging NOT just to table 1 but also to tables 2..5, so if you don't have any rule for BRANCH in table 1 but you had something for the branch in tables 2,3,4,5 this atomic update adds orphan values for 'issuelength', 'hardduedate', 'unseenrenewalsallowed', 'rentaldiscount', 'decreaseloanholds'. And, EVEN WORSE: because those rules even will not be shown for the operator as RULES in table 1, but they still affect the results in circulation analysis as bigger priority rules than those without branches (i.e. "*"/all) so zero or '' value will be used as rule result for calculations. And nothing will be shown to the operator (!!!). For example, we just had on our production having "issuedate" "0" for some branches added by this atomic update because those branches had 'holdallowed' settings in table 5 (but nothing in table 1 in that per-branch-page!). But rule became efficient for all requests and made a real mess when borrowers had "today" issue return date & loan length (!!!). More complexity: this now can be fixed only by manually removing trash from circulation_rules but requires analysis, argh! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 16:21:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 14:21:58 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #27 from Andrew Nugged --- so we need now to make new ticket & new atomic update for those affected to HEAL orphan rules from database (pretty complicated task as I see, btw). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 17:00:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 15:00:51 +0000 Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140872|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 17:07:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 15:07:36 +0000 Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #66 from Martin Renvoize --- I've obsoleted another of the patches that Nick rebased as it's already done in bug 26734... This is another case of a bug loosing momentum due to a distinct lack of testing at the time and I'm struggling to catch back up again.. All we need at this point is the new notices.. all the core code stuff is in... Also, with bug 26689 we can finally split these notices up so they're specific to their credit_type_code and debit_type_code.. so the notices submitted here with various cases for the different types built into the one notice don't really make much sense now.. it's much clearer to have a notice per type instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 17:12:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 15:12:38 +0000 Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #67 from Martin Renvoize --- The patchset should now work as it stands.. but personally I'd split the notices up to remove the `[% IF ( credit.credit_type_code == 'PAYMENT' ) %]"` and similar blocks and instead put them in new notices 'CREDIT_PAYMENT' for example. Either way.. give it a test and see if you like seeing the itemised summaries.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 17:12:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 15:12:51 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #28 from Katrin Fischer --- (In reply to Andrew Nugged from comment #27) > so we need now to make new ticket & new atomic update for those affected to > HEAL orphan rules from database (pretty complicated task as I see, btw). Please create a new blocker bug, as this has already been released! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 17:26:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 15:26:26 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #29 from Andrew Nugged --- and another bad thing: unseen_renewals_allowed vs unseenrenewalsallowed (sic!) we have 'unseen_renewals_allowed' everywhere in codebase, except in this atomic update we have 'unseenrenewalsallowed'. And now DB is polluted even more :). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 17:27:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 15:27:05 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #30 from Andrew Nugged --- (In reply to Katrin Fischer from comment #28) > Please create a new blocker bug, as this has already been released! yes, creating -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 17:27:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 15:27:36 +0000 Subject: [Koha-bugs] [Bug 29792] Transfers created from Wrong Transfer checkin are not sent if modal is dismissed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141124|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 141576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141576&action=edit Bug 29792: Automatically send wrong transfers Bug 24434 reinstated the 'updateWrongTransfer' call here, but made the assertion that the transfer should not be sent until 'Ok' was clicked. I see how unsent transfers are useful for rotation, but I believe for wrong transfer we shouldn't require a confirm or print. If a library does want to, the 'transfersblockcirc' system preference will enforce clicking the button to continue This patch also confirms a transfer when item already has a transfer and only options are Confirm/Print because the transfer already exists To test: 1 - Disable TransfersBlockCirc system preference 2 - Manually transfer an item from branch A to branch B 3 - Check in the item at branch A 4 - Dismiss modal without confirming 5 - View item on biblio details page, item not in transit 6 - Check in item, confirm transfer 7 - Note item in transit on details page 8 - Check in the item at branch C 9 - Dismiss modal without confirm 10 - View item on biblio detail, not in transit 11 - Checkin at A, cancel transfer 12 - Apply patch 13 - repeat 1 - 4 14 - Confirm item appears in transit 15 - Check in at branch C, dismiss modal 16 - Confirm item in transit Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 17:28:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 15:28:19 +0000 Subject: [Koha-bugs] [Bug 29792] Transfers created from Wrong Transfer checkin are not sent if modal is dismissed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #14 from Martin Renvoize --- Thanks for taking this over Nick.. looks great and works as described.. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 17:52:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 15:52:58 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #54 from Martin Renvoize --- I asked myself the same question regards the use of AV here.. and would likely ask it again if it was switch to additional_contents.. it feels like this is a big enough feature tree that starting with a fresh new table instead of trying to plumb extra functionality into other tables is the right way to go... The account types stuff is a clear example of where/why this makes sense.. we added lots of functionality to it really quite quickly once we'd converted from AV to distinct tables.. AV's and Additional Contents end up very restrictive if you are actually trying to tie functionality to this stuff... You talk about future enhancements Marcel.. any change you can write up a tree of bugs to describe where your headed with the big picture? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 18:08:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 16:08:18 +0000 Subject: [Koha-bugs] [Bug 31727] New: Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 Bug ID: 31727 Summary: Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nugged at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Blocks: 29012 On smart-rules.pl (Home > Administration > Circulation and fine rules): we have 5 tables: 1. Defining circulation and fine rules for all libraries (... for XXX branch, if branch selected) 2. Default checkout, hold and return policy (... for XXX branch, if branch selected) 3. Checkout, hold policy by patron category (... for XXX branch, if branch selected) 4. Lost item fee refund on return policy (... for XXX branch, if branch selected) 5. Holds policy by item type (... for XXX branch, if branch selected) and with dropdown, we can select rules for "Standard rules for all libraries" or switch to ANY of the available branches represented by the whole page. Attempt to fix missing values in Bug 29012 had the atomic update, which filled up the circulation_rules table with values if ANY combination of "branch+category+itemtype" was found in the circulation_rules table. This had false positives for items from above-mentioned table 2,3,4,5 when assumed that only key/value pairs from table 1 should be those which affect the decision to add or not" new empty or zeroed item. This made the problem: after this atomic update, we have the circulation_rules table randomly filled with orphan elements for "table 1" even if no rules in table 1 for that branch were present in real. Worse: those orphan items are never shown as rows of real rules for the operator so not visible. Bad: those orphan items, for example, "issuelength" of 0 when it has some BRANCH overlaps ANY rule without branches and discretely changes behavior when issuing items. EXAMPLE: - Open smart-rules.pl and choose in the first dropdown "Select a library : " some BRANCH_NAME so this page will reload into BRANCH_NAME-targeted mode for the whole page. - Edit the last (5th) table "Holds policy by item type for BRANCH_NAME" value holdallowed to be set into something, and save it. You will see / still have "table 1" empty. - make the atomic update from Bug 29012 to fill those "zeroes and empties" - check the smart-rules.pl page for BRANCH_NAME-targeted mode: there will be still no rules in the 1st, "Defining circulation and fine rules for XXX branch" table, - but now check the database in raw mode: you will see that there will be a record: BRANCH_NAME will have, for example, "issuelength" of 0 key/value pair. - OUCH! What to fix: Now we need to invent a new atomic update to be applied after this one (and this is very non-trivial because we somehow need to preserve other proper values), to fix the database from orphan values. This anyway can lead to very unpredictable results. Another thing to consider is that we should even if unsure what is orphans - is to reveal all hidden values, i.e. append and populate other values to make a "full row" appear for the operator in the interface, so at least human can SEE wrong with those rules and then decide/delete but make impossible to have "remnants" and orphans hidden. PROBLEM 2: unseen_renewals_allowed vs unseenrenewalsallowed (sic!) we have 'unseen_renewals_allowed' everywhere in the codebase, except in this atomic update we have 'unseenrenewalsallowed'. And now DB is polluted even more :). This also should be fixed - and more: we might now have unseen_renewals_allowed and unseenrenewalsallowed both in database. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 18:08:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 16:08:18 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31727 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 18:15:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 16:15:32 +0000 Subject: [Koha-bugs] [Bug 31728] New: Duplicate claims modal template markup Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31728 Bug ID: 31728 Summary: Duplicate claims modal template markup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 29983 Return claims uses a modal dialog for handling the resolution process. The modal markup is currently duplicated in the templates, once in modal-claims.inc and once in checkouts-table.inc. I think this was a mistake in Bug 29983, which added the modal include without removing the markup in checkouts-table.inc. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 [Bug 29983] Display the return claims column in the circulation overdues page (overdue.tt) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 18:15:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 16:15:32 +0000 Subject: [Koha-bugs] [Bug 29983] Display the return claims column in the circulation overdues page (overdue.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31728 [Bug 31728] Duplicate claims modal template markup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 18:37:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 16:37:33 +0000 Subject: [Koha-bugs] [Bug 31729] New: Enable automatic filesystem refresh in Plack Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Bug ID: 31729 Summary: Enable automatic filesystem refresh in Plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org this patch adds an automatic filesystem refresh in Plack, patch uses the following module... https://metacpan.org/pod/Plack::Middleware::Refresh to test: 1/ start ktd 2/ add warn to about.pl file, loadpage, observe no output in log :( 3/ apply patch to /etc/koha/plack.psgi 4/ restart plack 5/ add warn to about.pl file, loadpage, observe output in log :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 18:41:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 16:41:13 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 18:41:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 16:41:16 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #1 from Mason James --- Created attachment 141577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141577&action=edit Bug 31729: Enable automatic filesystem refresh in Plack patch uses the following module... https://metacpan.org/pod/Plack::Middleware::Refresh to test: 1/ start ktd 2/ add warn to about.pl file, load page, observe no output in log :( 3/ apply patch to /etc/koha/plack.psgi 4/ restart plack 5/ add warn to about.pl file, load page, observe output in log :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 18:43:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 16:43:28 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #303 from Katrin Fischer --- Please have a look at the Z39.50 search - the input fields are misaligned (sorry for posting here... just didn't want to forget) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 18:46:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 16:46:48 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #2 from Mason James --- Created attachment 141578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141578&action=edit Bug 31729: Enable automatic filesystem refresh in Plack (2) updating mojo psgi file too, (not sure how to test patch) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 18:47:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 16:47:50 +0000 Subject: [Koha-bugs] [Bug 31728] Duplicate claims modal template markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31728 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 18:47:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 16:47:54 +0000 Subject: [Koha-bugs] [Bug 31728] Duplicate claims modal template markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31728 --- Comment #1 from Owen Leonard --- Created attachment 141579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141579&action=edit Bug 31728: Remove duplicate claims modal template markup This patch removes some markup which duplicates markup now in a separate include file. modal-claims.inc contains the same markup for #claims-returned-modal as checkouts.table.inc. To test, apply the patch and make sure a LOST authorized value code is defined in the ClaimReturnedLostValue system preference. - Check an item out to a patron, e.g. item 39999000001334 to patron 23529000179433. - In the table showing the patron's checkouts, click the "Claim returned" button. - A "Claim returned" modal should appear. - Click "Make claim." - Switch to the "Claims" tab. You should see the item listed there. - Check out another item, e.g. 39999000013313, to the patron and test the return claim process again from the patron detail page. - Check out another item, e.g. 39999000018691, to the patron with a due date specified which is in the past. - Go to Circulation -> Overdues. You should see the item in the list of overdues. Test that the "Claim returned" button works correctly on this page too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 18:48:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 16:48:03 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 18:48:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 16:48:30 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 20:00:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 18:00:49 +0000 Subject: [Koha-bugs] [Bug 31730] New: Link to authorized value interface when an authval is mentioned in preferences Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31730 Bug ID: 31730 Summary: Link to authorized value interface when an authval is mentioned in preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Some preferences ask that an authorized value be entered, e.g.: "Use the LOST authorized value [_____] to represent 'claims returned'." It would be useful to link the user directly to that authval category. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 20:09:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 18:09:59 +0000 Subject: [Koha-bugs] [Bug 31728] Duplicate claims modal template markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31728 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 20:10:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 18:10:03 +0000 Subject: [Koha-bugs] [Bug 31728] Duplicate claims modal template markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31728 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141579|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 141580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141580&action=edit Bug 31728: Remove duplicate claims modal template markup This patch removes some markup which duplicates markup now in a separate include file. modal-claims.inc contains the same markup for #claims-returned-modal as checkouts.table.inc. To test, apply the patch and make sure a LOST authorized value code is defined in the ClaimReturnedLostValue system preference. - Check an item out to a patron, e.g. item 39999000001334 to patron 23529000179433. - In the table showing the patron's checkouts, click the "Claim returned" button. - A "Claim returned" modal should appear. - Click "Make claim." - Switch to the "Claims" tab. You should see the item listed there. - Check out another item, e.g. 39999000013313, to the patron and test the return claim process again from the patron detail page. - Check out another item, e.g. 39999000018691, to the patron with a due date specified which is in the past. - Go to Circulation -> Overdues. You should see the item in the list of overdues. Test that the "Claim returned" button works correctly on this page too. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 20:43:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 18:43:44 +0000 Subject: [Koha-bugs] [Bug 31687] Add see from and see also from tracings in Match index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31687 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 20:43:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 18:43:48 +0000 Subject: [Koha-bugs] [Bug 31687] Add see from and see also from tracings in Match index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31687 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141384|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 141581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141581&action=edit Bug 31687: Add see from and see also from tracings in Match index This patch adds see from and see also from terms for uniform title, chronological term, topical term, geographic name, and genre/form term to the Match index in Elasticsearch for MARC21. Previously, only see from/see also from for personal names, corporate names, and meeting names were indexed. To test: 1. Without patch, import attached authority records 1.1. Download attached records 1.2. Go to Tools > Stage MARC records for import 1.3. Click 'Browse' and choose the downloaded file 1.4. Click 'Upload file' 1.5. Choose Record type = Authority 1.6. Click 'Stage for import' 1.7. From the job details, click 'View batch' 1.8. Click 'Import this batch into the catalog' 2. Without patch, search for see from and see also from tracings 2.1. Go to Authorities 2.2. In the 'Default' drop-down menu, choose 'Uniform title' 2.3. Choose the 'Search all headings' tab 2.4. Enter the search term 'Five hundred' 2.5. Click 'Submit' or press 'Enter' --> No results 2.6. Redo the search for the following search terms Authority type Search term Should be found in Uniform title five hundred 430 Uniform title films préférés 530 Chronological term fifteenth 448 Chronological term middle ages 548 Topical term lalopathie 450 Topical term troubles communication 550 Geographic name cécropia 451 Geographic name canada francophone 551 Genre/Form term filmiques 455 Genre/Form term films 555 3. Apply patch 4. Delete index, reset mappings and reindex authorities (with command line, -a -d -r) 5. Redo the searches from step 2, there should now be results Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 20:45:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 18:45:02 +0000 Subject: [Koha-bugs] [Bug 31687] Add see from and see also from tracings in Match index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31687 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- Thanks Caroline for the clear test plan and example records - these made it so easy to test! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 20:55:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 18:55:23 +0000 Subject: [Koha-bugs] [Bug 31731] New: Offer user a dropdown of authorized values instead of a text field in preferences Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31731 Bug ID: 31731 Summary: Offer user a dropdown of authorized values instead of a text field in preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, testopia at bugs.koha-community.org Depends on: 31730 If we're asking the user to enter one or more authorized value codes to a system preference we should offer them a dropdown menu to select from. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31730 [Bug 31730] Link to authorized value interface when an authval is mentioned in preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 20:55:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 18:55:23 +0000 Subject: [Koha-bugs] [Bug 31730] Link to authorized value interface when an authval is mentioned in preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31730 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31731 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31731 [Bug 31731] Offer user a dropdown of authorized values instead of a text field in preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 20:56:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 18:56:59 +0000 Subject: [Koha-bugs] [Bug 31691] Remove non-existent fields from the See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31691 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 20:57:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 18:57:04 +0000 Subject: [Koha-bugs] [Bug 31691] Remove non-existent fields from the See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31691 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141387|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 141582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141582&action=edit Bug 31691: Remove non-existent fields from the See-from index (Elasticsearch, MARC21) This patch removes fields from the See-from index that don't exist in MARC21. The existing fields can be found here: https://www.loc.gov/marc/authority/ad4xx.html The following fields are removed: - 411$b - 411$m - 411$o - 411$r - 430$b - 430$c - 430$e - 440(abcdefghjklmnopqrstvxyz) (all of them, 440 doesn't exist at all) - 441(abcdefghklmnoprstvxyz) (all of them, 441 doesn't exist at all) - 444(abcdefghjklmnopqrstvxyz) (all of them, 444 doesn't exist at all) - 447$b - 447$e - 447$f - 447$h - 447$j - 447$k - 447$l - 447$m - 447$n - 447$o - 447$p - 447$q - 447$r - 447$s - 447$t - 448$b - 448$c - 448$d - 448$e - 448$f - 448$g - 448$h - 448$k - 448$l - 448$m - 448$n - 448$o - 448$p - 448$r - 448$s - 448$t - 462$b - 462$c - 462$d - 462$e - 462$f - 462$g - 462$h - 462$k - 462$l - 462$m - 462$n - 462$o - 462$p - 462$r - 462$s - 462$t - 462$v - 462$x - 462$y - 462$z Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 20:59:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 18:59:19 +0000 Subject: [Koha-bugs] [Bug 31691] Remove non-existent fields from the See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31691 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- "Tested" by comparing the list of fields removed with the Library of Congress definitions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 21:05:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 19:05:33 +0000 Subject: [Koha-bugs] [Bug 31730] Link to authorized value interface when an authval is mentioned in preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31730 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 21:05:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 19:05:36 +0000 Subject: [Koha-bugs] [Bug 31730] Link to authorized value interface when an authval is mentioned in preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31730 --- Comment #1 from Owen Leonard --- Created attachment 141583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141583&action=edit Bug 31730: Link to authorized value interface when an authval is mentioned in preferences This patch adds links to the authorized value interface anywhere an authorized value category is mentioned in a system preference description. To test, apply the patch and go to Administration -> System preferences. - Check these preferences: Circulation -> ILLHiddenRequestStatuses Circulation -> BundleLostValue Circulation -> BundleNotLoanValue Circulation -> ClaimReturnedLostValue Accounting -> RequirePaymentType - Confirm that the link in the description of each preference takes you to the correct authorized value category. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 21:17:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 19:17:21 +0000 Subject: [Koha-bugs] [Bug 31698] Add ability to move a hold to a new biblio/item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 21:17:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 19:17:44 +0000 Subject: [Koha-bugs] [Bug 31693] Remove non-existent fields from the See-also-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31693 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 21:17:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 19:17:49 +0000 Subject: [Koha-bugs] [Bug 31693] Remove non-existent fields from the See-also-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31693 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141391|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 141584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141584&action=edit Bug 31693 Remove non-existent fields from the See-also-from index (Elasticsearch, MARC21) This patch removes fields from the See-from index that don't exist in MARC21. The existing fields can be found here: https://www.loc.gov/marc/authority/ad5xx.html The following fields are removed: - 511$b - 511$m - 511$o - 511$r - 530$b - 530$c - 530$e - 547$b - 547$e - 547$f - 547$h - 547$j - 547$k - 547$l - 547$m - 547$n - 547$o - 547$p - 547$q - 547$r - 547$s - 547$t - 548$b - 548$c - 548$d - 548$e - 548$f - 548$g - 548$h - 548$k - 548$l - 548$m - 548$n - 548$o - 548$p - 548$r - 548$s - 548$t - 550$c - 550$d - 550$e - 550$f - 550$h - 550$j - 550$k - 550$l - 550$m - 550$n - 550$o - 550$p - 550$q - 550$r - 550$s - 550$t - 551$b - 551$c - 551$d - 551$e - 551$f - 551$h - 551$k - 551$l - 551$m - 551$n - 551$o - 551$p - 551$r - 551$s - 551$t - 555$b - 555$c - 555$d - 555$e - 555$f - 555$g - 555$h - 555$j - 555$k - 555$l - 555$m - 555$n - 555$o - 555$p - 555$q - 555$r - 555$s - 555$t - 562$b - 562$c - 562$d - 562$e - 562$f - 562$g - 562$h - 562$k - 562$l - 562$m - 562$n - 562$o - 562$p - 562$r - 562$s - 562$t Furthermore, the format of the mapping for 511 has been corrected. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 21:19:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 19:19:15 +0000 Subject: [Koha-bugs] [Bug 31693] Remove non-existent fields from the See-also-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31693 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind --- "Tested" by comparing the list of fields removed with the Library of Congress definitions to make sure they don't exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 21:26:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 19:26:03 +0000 Subject: [Koha-bugs] [Bug 31690] Add see from tracings in See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31690 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 21:26:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 19:26:08 +0000 Subject: [Koha-bugs] [Bug 31690] Add see from tracings in See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31690 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141386|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 141585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141585&action=edit Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21) This patch adds the following fields to the See-from index - 450(abvxyz) - 451(avxyz) - 455(avxyz) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 21:28:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 19:28:04 +0000 Subject: [Koha-bugs] [Bug 31690] Add see from tracings in See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31690 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- "Tested" by comparing the list of fields added with the Library of Congress definitions[1] to make sure they exist. [1] https://www.loc.gov/marc/authority/ad4xx.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 21:36:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 19:36:23 +0000 Subject: [Koha-bugs] [Bug 31689] Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31689 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 21:36:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 19:36:28 +0000 Subject: [Koha-bugs] [Bug 31689] Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31689 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141385|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 141586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141586&action=edit Bug 31689: Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21) This patch adds the following fields to the Match-heading-see-from index - 430(adfghklmnoprstvxyz) - 448(avxyz) - 450(abvxyz) - 451(avxyz) - 455(avxyz) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 21:37:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 19:37:13 +0000 Subject: [Koha-bugs] [Bug 31689] Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31689 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- "Tested" by comparing the list of fields added to the index with the Library of Congress definitions[1] to make sure they exist. [1] https://www.loc.gov/marc/authority/ad4xx.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 21:55:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 19:55:18 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #3 from Mason James --- hmm, i've spotted a problem here switching back to ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 22:25:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 20:25:56 +0000 Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #7 from David Nind --- I've tested and have some feedback: 1. Things work as expected using the test plan (for step 2, FINE_SUMMARY should be FEE_SUMMARY). 2. For the print menu for the patron, this is labelled "Print fines slip": should these be "Print charges slip"? I thought we were heading in the direction of using charges rather than fines, but this it is not covered in the terminology list. 3. If I add a manual credit that is more than the outstanding balance (that is, overall the library owes the patron) but don't apply it, I can't print the slip. I assume that if this is the case, staff would know to apply the credit. 4. For the slip: . Should the title be "Outstanding charges"? . The phrase "Total outstanding dues as on date:" doesn't make much sense to me. Possibly "Total outstanding charges" or just "Total outstanding"? . Could the Amount and Outstanding columns be right aligned with the amounts? This all works, so hope my feedback doesn't come across as too negative! David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 22:29:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 20:29:02 +0000 Subject: [Koha-bugs] [Bug 31714] Add a more generic way to print patron slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 22:29:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 20:29:07 +0000 Subject: [Koha-bugs] [Bug 31714] Add a more generic way to print patron slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141571|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 141587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141587&action=edit Bug 31714: Add Generic way to print patron slips This patch adds a very simple controller and template to allow patron slip printing without all the boilerplate. See bug 31713 for an example use. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 22:29:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 20:29:52 +0000 Subject: [Koha-bugs] [Bug 31714] Add a more generic way to print patron slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- Tested using bug 31713. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 22:38:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 20:38:11 +0000 Subject: [Koha-bugs] [Bug 31730] Link to authorized value interface when an authval is mentioned in preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31730 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 22:38:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 20:38:15 +0000 Subject: [Koha-bugs] [Bug 31730] Link to authorized value interface when an authval is mentioned in preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31730 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141583|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 141588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141588&action=edit Bug 31730: Link to authorized value interface when an authval is mentioned in preferences This patch adds links to the authorized value interface anywhere an authorized value category is mentioned in a system preference description. To test, apply the patch and go to Administration -> System preferences. - Check these preferences: Circulation -> ILLHiddenRequestStatuses Circulation -> BundleLostValue Circulation -> BundleNotLoanValue Circulation -> ClaimReturnedLostValue Accounting -> RequirePaymentType - Confirm that the link in the description of each preference takes you to the correct authorized value category. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 22:47:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 20:47:00 +0000 Subject: [Koha-bugs] [Bug 31684] Plugin versions starting with a "v" cause unnecessary warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31684 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 22:47:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 20:47:05 +0000 Subject: [Koha-bugs] [Bug 31684] Plugin versions starting with a "v" cause unnecessary warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31684 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141379|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 141589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141589&action=edit Bug 31684: Set Koha::Plugin::Test version to 'v1.01' Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 22:47:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 20:47:11 +0000 Subject: [Koha-bugs] [Bug 31684] Plugin versions starting with a "v" cause unnecessary warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31684 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141380|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 141590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141590&action=edit Bug 31684: Plugin versions starting with a "v" cause unnecessary warnings Our code assumes that plugin version will be purely numeric ( e.g. 1.2.3 ) but many plugin authors ( including myself ) use the format "v1.2.3". This causes warnings as we use a numeric comparison on the version numbers. It could make sense to check for and strip any v's from the beginning of the version. Test Plan: 1) Apply the first patch to set the test plugin's version to v1.01 2) prove t/db_dependent/Koha/Plugins/Plugins.t 3) Note the warnings and test failures 4) Apply this patch 5) prove t/db_dependent/Koha/Plugins/Plugins.t 6) All tests pass! Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 23:03:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 21:03:11 +0000 Subject: [Koha-bugs] [Bug 31724] MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin Somers --- Looks like a VIM residue ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 23:06:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 21:06:06 +0000 Subject: [Koha-bugs] [Bug 31724] MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27846 [Bug 27846] Accessibility: Staff Client - Breadcrumbs should be more accessible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 23:06:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 21:06:06 +0000 Subject: [Koha-bugs] [Bug 27846] Accessibility: Staff Client - Breadcrumbs should be more accessible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27846 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31724 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 [Bug 31724] MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 23:09:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 21:09:02 +0000 Subject: [Koha-bugs] [Bug 31724] MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 --- Comment #3 from David Nind --- (In reply to Fridolin Somers from comment #2) > Looks like a VIM residue ;) That was my thought as well. The other alternative was that it should be a ? to match the dialogue box text. But I think it makes sense not to have the question mark. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 23:10:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 21:10:12 +0000 Subject: [Koha-bugs] [Bug 31724] MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141560|0 |1 is obsolete| | --- Comment #4 from Fridolin Somers --- Created attachment 141591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141591&action=edit Bug 31724: Remove 'i' from breadcrumb when deleting a MARC framework subfield Remove 'i' added to the end of the breadcrumb on the confirmation page when deleteing a MARC framework subfield. Test plan: 1. Go to Administration > MARC bibliographic frameworks. 2. View the subfields for a tag for a framework, for example: . BKS framework > Actions > MARC structure . Search for tag 245 . Select Actions > View subfields. 3. Select any subfield to delete and select the Delete button. 4. Note that there is an 'i' at the end of the breadcrumb, for example: . ... > Confirm deletion of subfield bi 5. Apply the patch. 6. Refresh the page and note that that 'i' is removed. 7. Sign off. Signed-off-by: David Nind Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 23:10:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 21:10:32 +0000 Subject: [Koha-bugs] [Bug 31724] MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 23:10:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 21:10:37 +0000 Subject: [Koha-bugs] [Bug 31724] MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141591|0 |1 is obsolete| | --- Comment #5 from Fridolin Somers --- Created attachment 141592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141592&action=edit Bug 31724: Remove 'i' from breadcrumb when deleting a MARC framework subfield Remove 'i' added to the end of the breadcrumb on the confirmation page when deleteing a MARC framework subfield. Test plan: 1. Go to Administration > MARC bibliographic frameworks. 2. View the subfields for a tag for a framework, for example: . BKS framework > Actions > MARC structure . Search for tag 245 . Select Actions > View subfields. 3. Select any subfield to delete and select the Delete button. 4. Note that there is an 'i' at the end of the breadcrumb, for example: . ... > Confirm deletion of subfield bi 5. Apply the patch. 6. Refresh the page and note that that 'i' is removed. 7. Sign off. Signed-off-by: David Nind Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 23:54:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 21:54:10 +0000 Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008 --- Comment #23 from David Nind --- I couldn't replicate the warning in the logs before applying the patch. I tried with these plugins: - Downloaded and installed the koha-plugin-bibliocommons plugin (https://github.com/thekesolutions/koha-plugin-bibliocommons/tree/c2da98f1bda450452ad687e5623f45939a967bdf) - Downloaded and installed the dev-koha-plugin-kitchen-sink plugin (https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink) After changing the version numbers in the plugin .pm file, I: - ran flush_memcached and restart_all - refreshed the plugins page - made the changes as per the test plan Note: I was able to apply the patches, but noticed no difference to the warning messages compared with before the patch was applied. So, I'm a little confused... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 23:55:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 21:55:54 +0000 Subject: [Koha-bugs] [Bug 31724] MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 --- Comment #6 from David Nind --- Thanks Fridolin for signing off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 00:30:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 22:30:59 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #4 from David Cook --- (In reply to Mason James from comment #1) > to test: > > 1/ start ktd > 2/ add warn to about.pl file, load page, observe no output in log :( > 3/ apply patch to /etc/koha/plack.psgi > 4/ restart plack > 5/ add warn to about.pl file, load page, observe output in log :) I don't think Plack::Middleware::Refresh would apply in this situation, since Module::Refresh scans the %INC for modified files. With this test plan, I think that it would only seem to work because the Starman worker replying to the request hasn't yet cached the compiled version of about.pl in its memory (in the Plack::App::CGIBin namespace). All the more reason for us to move our code out of .pl scripts and into .pm modules hehe. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 00:34:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 22:34:24 +0000 Subject: [Koha-bugs] [Bug 31588] Update cpanfile for new OpenAPI versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #18 from David Cook --- This should probably be renamed to "Update cpanfile for new Mojolicious::Plugin::OpenAPI versions" no? We're still using OpenAPI version 2 (and it looks like the new versions don't fully support OpenAPI version 3 anyway). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 00:35:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 22:35:43 +0000 Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue/due notices script (advance_notices.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 00:36:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2022 22:36:04 +0000 Subject: [Koha-bugs] [Bug 17291] Add ... syntax to advance_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17291 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- Since we're moving to TT syntax for notices, perhaps we should invalidate this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 02:22:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 00:22:12 +0000 Subject: [Koha-bugs] [Bug 31732] New: 880 titles missing from OPAC checkout summary Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31732 Bug ID: 31732 Summary: 880 titles missing from OPAC checkout summary Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org We're showing 880 $6245 values on the search results and the detail page, so we should show them on the OPAC user checkout summary page too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 02:34:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 00:34:43 +0000 Subject: [Koha-bugs] [Bug 31732] 880 titles missing from OPAC checkout summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31732 --- Comment #1 from David Cook --- Created attachment 141593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141593&action=edit Bug 31732: Add 880 titles to OPAC checkout summary Written for 21.11 and not tested on master yet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 02:35:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 00:35:11 +0000 Subject: [Koha-bugs] [Bug 31732] 880 titles missing from OPAC checkout summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31732 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 02:50:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 00:50:01 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #5 from Mason James --- (In reply to David Cook from comment #4) > (In reply to Mason James from comment #1) > > to test: > > > > 1/ start ktd > > 2/ add warn to about.pl file, load page, observe no output in log :( > > 3/ apply patch to /etc/koha/plack.psgi > > 4/ restart plack > > 5/ add warn to about.pl file, load page, observe output in log :) > > I don't think Plack::Middleware::Refresh would apply in this situation, > since Module::Refresh scans the %INC for modified files. this seems to be a better solution for ktd https://gitlab.com/mjames/koha-reload-starman/-/blob/master/koha-reload-starman -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 03:27:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 01:27:59 +0000 Subject: [Koha-bugs] [Bug 31733] New: 880 titles missing from OPAC cart Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31733 Bug ID: 31733 Summary: 880 titles missing from OPAC cart Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org We're showing 880 $6245 values on the search results and the detail page, so we should show them on the OPAC cart popup as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 04:30:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 02:30:09 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #6 from David Cook --- (In reply to Mason James from comment #5) > this seems to be a better solution for ktd > > https://gitlab.com/mjames/koha-reload-starman/-/blob/master/koha-reload- > starman Yeah I think inotify is probably the easiest way to do this. Personally, I probably wouldn't want to use this feature. I'm happy to make a batch of changes and then run either a "koha-plack --restart" or "koha-plack --reload". But it would be nice to have that hot deploy option - at least for ktd. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 06:49:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 04:49:59 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #14 from David Cook --- (In reply to Ere Maijala from comment #13) > I think it's the only solution that would work without forementioned > side-effects. It's important to report the records as deleted particularly > since they might not have been suppressed before. And that'd be the case for > practically every vanilla Koha instance harvested with OAI-PMH up until this > change. I'm glad to hear that you agree! > That said, there are use cases where OAI-PMH is used for non-opac > functionality and suppressed records should be included just like before. Do you have some use cases in mind? > For flexibility it should be possible to configure suppression per OAI-PMH > set in addition to a default setting. GetRecord isn't affected by sets, so are you thinking of a flag in the "oai_sets" data that would disable the suppression/hiding of records? -- I'm planning to trial this hiding locally by using suppression/hiding by default, and then using a system preference to disable it (to cater for any use cases that come up where libraries might need the unfiltered records still). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 07:12:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 05:12:56 +0000 Subject: [Koha-bugs] [Bug 31725] OAI-PMH - Hide items using OpacHiddenItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31725 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #1 from David Cook --- Actually, it looks like C4::Biblio::EmbedItemsInMarcBiblio hides items using OpacHiddenItems, when called by C4::Biblio::GetMarcBiblio, which is called by Koha::OAI::Server::Repository->get_biblio_marcxml() -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 07:38:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 05:38:25 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #15 from David Cook --- So it turns out the OAI-PMH already hides items using OpacHiddenItems: - Koha::OAI::Server::Repository->get_biblio_marcxml() - C4::Biblio::GetMarcBiblio - C4::Biblio::EmbedItemsInMarcBiblio To avoid double-handling and performance penalties for determining record-level suppression using OpacHiddenItems, it would make sense for C4::Biblio::GetMarcBiblio to return null on a hidden record, and for C4::Biblio::EmbedItemsInMarcBiblio to return a "hide_bib" status if it's hidden all the items via OpacHiddenItems. -- Of course, C4::Biblio::GetMarcBiblio is a very entrenched function, so I don't think we can alter default behaviour. I'm thinking that we add a parameter like "suppression". This parameter would be an empty hash reference, which can be checked after C4::Biblio::GetMarcBiblio is called without affecting its return values. If OpacSuppression isn't turned on or isn't applicable, then the "suppression" gets passed to C4::Biblio::EmbedItemsInMarcBiblio as well. If the "suppression" returns a "hide_biblio" after that call, then C4::Biblio::GetMarcBiblio returns null. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 08:15:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 06:15:20 +0000 Subject: [Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 --- Comment #1 from Andrew Nugged --- On smart-rules.pl (Home > Administration > Circulation and fine rules): we have 7 tables: 1. Defining circulation and fine rules for all libraries (... for XXX branch, if branch selected) 2. Default checkout, hold and return policy (... for XXX branch, if branch selected) 3. Checkout, hold policy by patron category (... for XXX branch, if branch selected) 4. Daily open article requests limit (... for XXX branch, if branch selected) 5. Article request fees (... for XXX branch, if branch selected) 6. Lost item fee refund on return policy (... for XXX branch, if branch selected) 7. Holds policy by item type (... for XXX branch, if branch selected) and with dropdown, we can select rules for "Standard rules for all libraries" or switch to ANY of the available branches represented by the whole page. Attempt to fix missing values in Bug 29012 had the atomic update, which filled up the circulation_rules table with values if ANY combination of "branch+category+itemtype" was found in the circulation_rules table. This had false positives for items from above-mentioned table 2..7 when assumed that only key/value pairs from table 1 should be those which affect the decision to add or not" new empty or zeroed item. This made the problem: after this atomic update, we have the circulation_rules table randomly filled with orphan elements for "table 1" even if no rules in table 1 for that branch were present in real. Worse: those orphan items are never shown as rows of real rules for the operator so not visible. Bad: those orphan items, for example, "issuelength" of 0 when it has some BRANCH overlaps ANY rule without branches and discretely changes behavior when issuing items. EXAMPLE: - Open smart-rules.pl and choose in the first dropdown "Select a library : " some BRANCH_NAME so this page will reload into BRANCH_NAME-targeted mode for the whole page. - Edit the second table "Default checkout, hold and return policy for BRANCH_NAME" making value holdallowed to be set into something, and save it. You will see / still have "table 1" empty. At this time key/value pair will be added to the database for this BRANCH_NAME, and this is exactly what later will mislead that atomic update: - make the atomic update from Bug 29012 to fill those "zeroes and empties" - check the smart-rules.pl page for BRANCH_NAME-targeted mode: there will still be no rules in the 1st, "Defining circulation and fine rules for XXX branch" table, - but now check the database in raw mode: you will see that there will be a record: BRANCH_NAME will have, for example, "issuelength" of 0 key/value pair. - OUCH! What to fix: Now we need to invent a new atomic update to be applied after this one (and this is very non-trivial because we somehow need to preserve other proper values), to fix the database from orphan values. This anyway can lead to very unpredictable results. Another thing to consider is that we should even if unsure what is orphans - is to reveal all hidden values, i.e. append and populate other values to make a "full row" appear for the operator in the interface, so at least human can SEE wrong with those rules and then decide/delete but make impossible to have "remnants" and orphans hidden. PROBLEM 2: unseen_renewals_allowed vs unseenrenewalsallowed (sic!) we have 'unseen_renewals_allowed' everywhere in the codebase, except in this atomic update we have 'unseenrenewalsallowed'. And now DB is polluted even more :). This also should be fixed - and more: we might now have unseen_renewals_allowed and unseenrenewalsallowed both in database. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 08:17:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 06:17:51 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #16 from David Cook --- All right... that wasn't so bad in the end. A bit of code in C4::Biblio::GetMarcBiblio, C4::Biblio::EmbedItemsInMarcBiblio, Koha::OAI::Server::GetRecord->new, and Koha::OAI::Server::Repository->get_biblio_marcxml -- There are no new database calls (only syspref calls to cache), so the only overhead added is CPU time and that will be negligible. -- One could argue that there are alternatives to my hashref parameter idea, but it works. I'll likely be implementing this locally in 21.11 tomorrow night. -- I've run out of time today but it shouldn't be a big drama to add unit tests (at least for the C4::Biblio code). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 08:20:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 06:20:58 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #17 from David Cook --- I ended up having to add more disparate lines of code than I would've liked, so I will be keen to upstream this one. The Koha::OAI::Server::GetRecord change could actually be a separate bug report, since that change isn't contingent on bug 31161. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 08:21:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 06:21:33 +0000 Subject: [Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 --- Comment #2 from Andrew Nugged --- Here I preselected from the code which rule_name's we have (indented column), one can double-check me. This was handy for me to fix databases after the "noise-making" session, but I think we should create an atomic-update normalizer which will wipe out "the noise" from the database (but operators will be surprised! :) ): Defining circulation and fine rules for all libraries Defining circulation and fine rules for "BRANCH_NAME" table 1: article_requests auto_renew cap_fine_to_replacement_price chargeperiod chargeperiod_charge_at daysmode decreaseloanholds fine finedays firstremind hardduedate hardduedatecompare holds_per_day holds_per_record issuelength lengthunit maxissueqty maxonsiteissueqty maxsuspensiondays no_auto_renewal_after no_auto_renewal_after_hard_limit norenewalbefore note on_shelf_recalls onshelfholds opacitemholds overduefinescap recall_due_date_interval recall_overdue_fine recall_shelf_time recalls_allowed recalls_per_record renewalperiod renewalsallowed rentaldiscount reservesallowed suspension_chargeperiod unseen_renewals_allowed Default checkout, hold and return policy Default checkout, hold and return policy for BRANCH_NAME table 2: set-branch-defaults hold_fulfillment_policy holdallowed max_holds patron_maxissueqty patron_maxonsiteissueqty returnbranch Default checkout, hold policy by patron category Checkout, hold policy by patron category for BRANCH_NAME table 3: add-branch-cat max_holds patron_maxissueqty patron_maxonsiteissueqty Default open article requests limit Daily open article requests limit for BRANCH_NAME table 4: add-open-article-requests-limit open_article_requests_limit Default article request fees Article request fees for BRANCH_NAME table 5: set-article-request-fee article_request_fee Default lost item fee refund on return policy Lost item fee refund on return policy for BRANCH_NAME table 6: mod-refund-lost-item-fee-rule lostreturn Default holds policy by item type Holds policy by item type for BRANCH_NAME table 7: set-waiting-hold-cancellation waiting_hold_cancellation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 08:54:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 06:54:24 +0000 Subject: [Koha-bugs] [Bug 27315] The man pages for the command line utilities do not display properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27315 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 08:54:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 06:54:27 +0000 Subject: [Koha-bugs] [Bug 27315] The man pages for the command line utilities do not display properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27315 --- Comment #6 from Andreas Roussos --- Created attachment 141594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141594&action=edit Bug 27315: use the namespace-aware docbook stylesheet When viewing the man page for the `koha-list` command, the output does not appear correctly: there appears to be a "staircase"-like effect on the text. The same is true for all other man pages. The source XML files for our man pages have the following namespace declaration at the top: xmlns='http://docbook.org/ns/docbook', which means they are DocBook V5.0 documents and should be processed by namespace-aware DocBook XSL stylesheets. This patch fixes that by using the DocBook-to-man-page transformation stylesheet from the docbook-xsl-ns package (note the "-ns" suffix). Test plan: 1) Apply the patch 2) Build and install new package 3) Confirm the man pages display correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 09:02:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 07:02:11 +0000 Subject: [Koha-bugs] [Bug 27315] The man pages for the command line utilities do not display properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27315 --- Comment #7 from Andreas Roussos --- (In reply to Katrin Fischer from comment #5) > I Andreas, I just ran into this issue testing bug 17379. Could you share a > patch with your solution? Hi Katrin! Sorry for the delay in replying and for taking so long to prepare a patch for this bug report. I've now attached a patch, and wrote a simple test plan which will hopefully be adequate. Please note: instead of replacing `docbook-xsl` in `debian/control.in` with `docbook-xsl-ns`, I opted for *adding* `docbook-xsl-ns` as an extra package in order to avoid any breakage that might occur in case someone was already using the non-namespace-aware variant. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 09:06:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 07:06:29 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #18 from Ere Maijala --- (In reply to David Cook from comment #14) > (In reply to Ere Maijala from comment #13) > > I think it's the only solution that would work without forementioned > > side-effects. It's important to report the records as deleted particularly > > since they might not have been suppressed before. And that'd be the case for > > practically every vanilla Koha instance harvested with OAI-PMH up until this > > change. > > I'm glad to hear that you agree! > > > That said, there are use cases where OAI-PMH is used for non-opac > > functionality and suppressed records should be included just like before. > > Do you have some use cases in mind? Anything non-OPAC could qualify, e.g. a union catalog based on OAI-PMH. Or even an OPAC instance for staff use only. > > For flexibility it should be possible to configure suppression per OAI-PMH > > set in addition to a default setting. > > GetRecord isn't affected by sets, so are you thinking of a flag in the > "oai_sets" data that would disable the suppression/hiding of records? GetRecord response has header/setSpec to indicate which sets the record belongs to. It should reflect suppression by excluding a set where the record would be marked deleted. So if we have sets "all" and "opac", a suppressed record would only have
    all
    . -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 09:24:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 07:24:10 +0000 Subject: [Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kevin.carnes at ub.lu.se |ity.org | CC| |kevin.carnes at ub.lu.se --- Comment #3 from Kevin Carnes --- Thank for catching these problems. I made the false assumption that the database table was only for the first table of rules and I used the template name instead of the database column name for unseen_renewals_allowed. I've made an atomic update that removes these rules when there is no suspension_chargeperiod rule (this is a rule that should be made when saving the first table of rules). It also renames any remaining unseenrenewalsallowed to unseen_renewals_allowed. It would be helpful if somebody else could check this to make sure it's right. It's possible that suspension_chargeperiod is not a accurate check or it might be better to only delete them if the still have the default values. All corrections are appreciated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 09:25:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 07:25:45 +0000 Subject: [Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 --- Comment #4 from Kevin Carnes --- Created attachment 141595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141595&action=edit Bug 31727: Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 09:29:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 07:29:42 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141577|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 141596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141596&action=edit Bug 31729: Enable automatic filesystem refresh in Plack patch uses the following module... https://metacpan.org/pod/Plack::Middleware::Refresh to test: 1/ start ktd 2/ add warn to about.pl file, load page, observe no output in log :( 3/ apply patch to /etc/koha/plack.psgi 4/ restart plack 5/ add warn to about.pl file, load page, observe output in log :) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 09:29:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 07:29:46 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141578|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 141597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141597&action=edit Bug 31729: Enable automatic filesystem refresh in Plack (2) updating mojo psgi file too, (not sure how to test patch) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 09:29:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 07:29:50 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #9 from Martin Renvoize --- Created attachment 141598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141598&action=edit Bug 31729: Add missing brace (and tidy) This adds a missing closing bracket and runs perltidy over the .psgi scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 09:30:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 07:30:26 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 09:30:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 07:30:33 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 09:31:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 07:31:07 +0000 Subject: [Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 09:32:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 07:32:12 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #10 from Martin Renvoize --- Oop, I tested first thing this morning without refreshing to see the comments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 10:22:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 08:22:39 +0000 Subject: [Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 --- Comment #5 from Andrew Nugged --- (I rewrote the ticket description because I lost one table "3" new in master): On smart-rules.pl (Home > Administration > Circulation and fine rules): we have 8 tables: 1. Defining circulation and fine rules for all libraries (... for XXX branch, if branch selected) 2. Default checkout, hold and return policy (... for XXX branch, if branch selected) 3. Default / Waiting hold cancellation policy (... for XXX branch, if branch selected) 4. Checkout, hold policy by patron category (... for XXX branch, if branch selected) 5. Daily open article requests limit (... for XXX branch, if branch selected) 6. Article request fees (... for XXX branch, if branch selected) 7. Lost item fee refund on return policy (... for XXX branch, if branch selected) 8. Holds policy by item type (... for XXX branch, if branch selected) and with dropdown, we can select rules for "Standard rules for all libraries" or switch to ANY of the available branches represented by the whole page. Attempt to fix missing values in Bug 29012 had the atomic update, which filled up the circulation_rules table with values if ANY combination of "branch+category+itemtype" was found in the circulation_rules table. This had false positives for items from above-mentioned table 2..8 when assumed that only key/value pairs from table 1 should be those which affect the decision to add or not" new empty or zeroed item. This made the problem: after this atomic update, we have the circulation_rules table randomly filled with orphan elements for "table 1" even if no rules in table 1 for that branch were present in real. Worse: those orphan items are never shown as rows of real rules for the operator so not visible. Bad: those orphan items, for example, "issuelength" of 0 when it has some BRANCH overlaps ANY rule without branches and discretely changes behavior when issuing items. EXAMPLE: - Open smart-rules.pl and choose in the first dropdown "Select a library : " some BRANCH_NAME so this page will reload into BRANCH_NAME-targeted mode for the whole page. - Edit the second table "Default checkout, hold and return policy for BRANCH_NAME" making value holdallowed to be set into something, and save it. You will see / still have "table 1" empty. At this time key/value pair will be added to the database for this BRANCH_NAME, and this is exactly what later will mislead that atomic update: - make the atomic update from Bug 29012 to fill those "zeroes and empties" - check the smart-rules.pl page for BRANCH_NAME-targeted mode: there will still be no rules in the 1st, "Defining circulation and fine rules for XXX branch" table, - but now check the database in raw mode: you will see that there will be a record: BRANCH_NAME will have, for example, "issuelength" of 0 key/value pair. - OUCH! What to fix: Now we need to invent a new atomic update to be applied after this one (and this is very non-trivial because we somehow need to preserve other proper values), to fix the database from orphan values. This anyway can lead to very unpredictable results. Another thing to consider is that we should even if unsure what is orphans - is to reveal all hidden values, i.e. append and populate other values to make a "full row" appear for the operator in the interface, so at least human can SEE wrong with those rules and then decide/delete but make impossible to have "remnants" and orphans hidden. PROBLEM 2: unseen_renewals_allowed vs unseenrenewalsallowed (sic!) we have 'unseen_renewals_allowed' everywhere in the codebase, except in this atomic update we have 'unseenrenewalsallowed'. And now DB is polluted even more :). This also should be fixed - and more: we might now have unseen_renewals_allowed and unseenrenewalsallowed both in database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 10:23:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 08:23:55 +0000 Subject: [Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 --- Comment #6 from Andrew Nugged --- (In reply to Kevin Carnes from comment #4) ok good, let us check these requests/atomic on our live "happened to be" productions... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 11:40:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 09:40:39 +0000 Subject: [Koha-bugs] [Bug 17291] Add ... syntax to advance_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17291 --- Comment #4 from Katrin Fischer --- (In reply to David Cook from comment #3) > Since we're moving to TT syntax for notices, perhaps we should invalidate > this one? I've linked to bug 29100 with that idea in mind, but wanted to have nice documentation in place first :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 11:56:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 09:56:03 +0000 Subject: [Koha-bugs] [Bug 27315] The man pages for the command line utilities do not display properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27315 --- Comment #8 from Katrin Fischer --- Thanks a lot! I'll leave this for a moment in hope someone will sign-off to make this go into the QA queue :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 13:06:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 11:06:50 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #55 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #54) > I asked myself the same question regards the use of AV here.. and would > likely ask it again if it was switch to additional_contents.. it feels like > this is a big enough feature tree that starting with a fresh new table > instead of trying to plumb extra functionality into other tables is the > right way to go... > > The account types stuff is a clear example of where/why this makes sense.. > we added lots of functionality to it really quite quickly once we'd > converted from AV to distinct tables.. AV's and Additional Contents end up > very restrictive if you are actually trying to tie functionality to this > stuff... > > You talk about future enhancements Marcel.. any change you can write up a > tree of bugs to describe where your headed with the big picture? Thanks, Martin. Reworking this along some other lines will certainly need more time. I was certainly not planning to make this as large as Accounts ;) Baby steps.. Will come back here later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 13:11:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 11:11:05 +0000 Subject: [Koha-bugs] [Bug 20380] [OMNIBUS] Email consent patron opt-in tracking for anti-spam legislation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20380 --- Comment #6 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #3) > (In reply to Marcel de Rooy from comment #2) > > Adding some groundwork for this on bug 31503. > > Bug 31503 is ready for testing, folks. > It became a bit more than groundwork. But it does not implement all things > mentioned in the description here. > It allows you to add various consents to the OPAC consents page. It is > controlled by Authorised values. And adds content (slightly experimental) > via the Additional contents feature. Bug 31503 didnt make it for now. It may need some more thought and time :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 13:53:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 11:53:24 +0000 Subject: [Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 --- Comment #12 from Martin Renvoize --- Hit by this again at our most recent upgrade... If you want to use aqbasket in the title of the email without this patch you can't. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 14:08:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 12:08:32 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 14:09:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 12:09:40 +0000 Subject: [Koha-bugs] [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 141599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141599&action=edit Bug 31673: (QA follow-up) Check if FK exists before attempt to remove Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 14:10:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 12:10:14 +0000 Subject: [Koha-bugs] [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 14:10:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 12:10:17 +0000 Subject: [Koha-bugs] [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 14:45:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 12:45:24 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #14 from Marcel de Rooy --- Just mentioning that this dbrev can be quite nasty for people having some custom records in the former news table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 14:52:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 12:52:18 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #58 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #31) > Disclaimer: This patch is NOT offering the best implementation but, as > we still don't have bug 24975, it cannot be done now. And no, we don't > want to wait for it to move forward here. This patch is going into the > right direction anyway. 24975 wasnt there in August 2021, but still in coma October 2022.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 14:56:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 12:56:43 +0000 Subject: [Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 14:56:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 12:56:47 +0000 Subject: [Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141595|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 141600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141600&action=edit Bug 31727: Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 14:56:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 12:56:51 +0000 Subject: [Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 --- Comment #8 from Nick Clemens --- Created attachment 141601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141601&action=edit Bug 31727: Fix existing update to prevent inserting incorrect data Both updates now rely on 'suspension_chargeperiod' as the source of truth for existence of a rule. Spot checking some existing production databases this seems to be acceptable. This alters the update to only add rules where a 'suspension_chargeperiod' rule exists and a value for the rule is not already set. NOTE: While the table has a unique key: UNIQUE KEY `branchcode` (`branchcode`,`categorycode`,`itemtype`,`rule_name`), This key doesn't prevent duplicates on NULLs, i.e.: branchcode | categorycode | itemtype | rule_name | rule_value NULL | NULL | BK | unseen_renewals_allowed | 1 NULL | NULL | BK | unseen_renewals_allowed | 2 NULL | NULL | BK | unseen_renewals_allowed | 3 So we need to both check that any rule is present and that the specific rule is not. The 'INSERT IGNORE' won't IGNORE existing values except for the most specific rules Test plan: 0 - Edit and save existing default rule in DB (sample data does not include suspension_chargeperiod) 1 - Set some rules for "Default checkout, hold and return policy" for "Standard rule" and some specific libraries 2 - cp installer/data/mysql/db_revs/220600024.pl installer/data/mysql/atomicupdate/ 3 - SELECT * FROM circulation rules, note the number of rules that exist 4 - updatedatabase 5 - Check the DB again, you should now have rules as described in the bug i.e. You will have 5 new rules per 'Default checkout, hold and return policy' 6 - apply 1st patch on bug 7 - rm installer/data/mysql/atomicupdate/220600024.pl (so we don't add again) 8 - updatedatabase 9 - Check DB, the extra rules have been deleted 10 - Apply 2nd patch 11 - cp installer/data/mysql/db_revs/220600024.pl installer/data/mysql/atomicupdate/ 12 - rm installer/data/mysql/atomicupdate/bug_31727.pl (so we can confirm update isn't adding rules) 13 - updatedatabase 14 - Confirm no change in rules since step 9 15 - git reset --hard (get deleted update back) 16 - rm installer/data/mysql/atomicupdate/220600024.pl Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 14:57:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 12:57:42 +0000 Subject: [Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 14:58:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 12:58:29 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Patch doesn't apply --- Comment #25 from Tomás Cohen Arazi --- Please rebase ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:06:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:06:25 +0000 Subject: [Koha-bugs] [Bug 31670] Fix inconsistency with breadcrumbs in the Patrons module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31670 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #1 from Tomás Cohen Arazi --- We also have: Home > Circulation > Checkouts > Henry Acevedo (23529000035676) which should be Home > Patrons > Henry Acevedo (23529000035676) > Checkouts and... Home > Tools > Logs > Results LOL, this is so mixed up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:10:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:10:02 +0000 Subject: [Koha-bugs] [Bug 31619] Cannot select title when setting non-default value for OPACSuggestionMandatoryFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #10 from Tomás Cohen Arazi --- Gotta say... I'm really happy to push a patch from you, Galen :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:13:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:13:25 +0000 Subject: [Koha-bugs] [Bug 31734] New: Hooks for account, recall, indexing and more actions for holds. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31734 Bug ID: 31734 Summary: Hooks for account, recall, indexing and more actions for holds. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: stefan.berndtsson at ub.gu.se QA Contact: testopia at bugs.koha-community.org This patch adds a few more hooks and extensions to an existing hook. The existing hook "after_hold_action" has been extended with the following actions: * "transfer" for when a Hold calls "set_transfer()". * "waiting" for when a Hold calls "set_waiting()". * "processing" for when a Hold calls "set_processing()". A new hook "after_account_action" is added with action "add_credit" for when credit is added via for example PAYMENT or WRITEOFF. This is consistent with when UpdateStats is called so that a plugin can be used to log the same kind of data as the normal statistics. Another new hook "after_recall_action" with action "add_recall" is also added. Also to stay consistent with the UpdateStats usage. Lastly a hook "before_index_action" with action "update" is added for the Elasticsearch::Indexer function "update_index()" so that the records being indexed can be modified before indexing. This allows for a plugin to add metadata to index or tweak or change it to provide better search results without changing the actual records (something that might be prohibited or discouraged due to centralised cataloging). Tests are provided in the patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:15:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:15:12 +0000 Subject: [Koha-bugs] [Bug 31734] Hooks for account, recall, indexing and more actions for holds. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31734 --- Comment #1 from Stefan Berndtsson --- Created attachment 141602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141602&action=edit Bug 31734: Extend hooks for plugins Hooks added: after_account_action / add in Koha::Account::add_credit when adding credit for payment or writeoff. after_hold_action / transfer, waiting and processing in Koha::Hold::set_* after_recall_action / add in Koha::Recalls::add_recall when adding recall before_index_action / update in Koha::SearchEngine::Elasticsearch::Indexer::update_index before actually updating the index Tests added for all new hooks. How to test: 1) Run tests in t/db_dependent/Koha/Plugins/Account_hooks.t 2) Run tests in t/db_dependent/Koha/Plugins/Elasticsearch_Indexer_hooks.t 3) Run tests in t/db_dependent/Koha/Plugins/Holds_hooks.t 4) Run tests in t/db_dependent/Koha/Plugins/Recall_hooks.t Sponsored by: Gothenburg University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:16:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:16:11 +0000 Subject: [Koha-bugs] [Bug 31734] Hooks for account, recall, indexing and more actions for holds. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31734 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |stefan.berndtsson at ub.gu.se |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:23:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:23:26 +0000 Subject: [Koha-bugs] [Bug 17379] Add a man page for koha-passwd In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17379 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:23:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:23:29 +0000 Subject: [Koha-bugs] [Bug 17379] Add a man page for koha-passwd In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17379 --- Comment #24 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:23:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:23:32 +0000 Subject: [Koha-bugs] [Bug 31420] Managing funds: Labels of statistic fields overlap with pull downs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31420 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:23:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:23:35 +0000 Subject: [Koha-bugs] [Bug 31420] Managing funds: Labels of statistic fields overlap with pull downs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31420 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:23:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:23:38 +0000 Subject: [Koha-bugs] [Bug 31485] Move ItemsDeniedRenewal checks from C4::Circulation to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31485 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:23:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:23:41 +0000 Subject: [Koha-bugs] [Bug 31485] Move ItemsDeniedRenewal checks from C4::Circulation to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31485 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:23:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:23:44 +0000 Subject: [Koha-bugs] [Bug 31519] Unused template parameters in request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:23:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:23:46 +0000 Subject: [Koha-bugs] [Bug 31519] Unused template parameters in request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:23:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:23:49 +0000 Subject: [Koha-bugs] [Bug 31575] Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:23:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:23:52 +0000 Subject: [Koha-bugs] [Bug 31575] Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:23:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:23:54 +0000 Subject: [Koha-bugs] [Bug 31587] Basket not accessible from ACQORDER notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:23:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:23:57 +0000 Subject: [Koha-bugs] [Bug 31587] Basket not accessible from ACQORDER notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:24:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:24:00 +0000 Subject: [Koha-bugs] [Bug 31619] Cannot select title when setting non-default value for OPACSuggestionMandatoryFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:24:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:24:03 +0000 Subject: [Koha-bugs] [Bug 31619] Cannot select title when setting non-default value for OPACSuggestionMandatoryFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:24:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:24:05 +0000 Subject: [Koha-bugs] [Bug 31646] Focus input by default when clicking on a dropdown field in the cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31646 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:24:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:24:08 +0000 Subject: [Koha-bugs] [Bug 31646] Focus input by default when clicking on a dropdown field in the cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31646 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:24:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:24:11 +0000 Subject: [Koha-bugs] [Bug 31649] Acquisition basket CSV export fails if biblio does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31649 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:24:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:24:14 +0000 Subject: [Koha-bugs] [Bug 31649] Acquisition basket CSV export fails if biblio does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31649 --- Comment #13 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:25:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:25:12 +0000 Subject: [Koha-bugs] [Bug 31735] New: Circulation optimizations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 Bug ID: 31735 Summary: Circulation optimizations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: glasklas at gmail.com QA Contact: testopia at bugs.koha-community.org We recently had time-out issues and high server loads for patrons with high checkout counts (some patrons have several hundreds, up to about 400). One of the major bottlenecks turned out to be C4::Circulation::CanBookBeRenewed. The primary reason it performed so poorly was constant re-fetching of different database entities which could just as well be passed down directly instead of passing ids which requires re-fetching further down the call stack. After refactoring the most performance critical subroutines to take objects instead of object ids the calls to expensive DBIx-methods has been greatly reduced. In addition some other optimizations and bug fixes related to non working caching resulted in further speedups. The performance gain for a patron with around 400 checkouts is currently about 500%. I made an effort to fix all tests affected by the changes, but I can not guarantee there are absolutely no regressions left in the test-suite. Since many tests seem to fail due to reasons not related to this patch, mainly due to the state of my local instance triggering tests-bugs (for example caused by preferences not being mocked correctly, or relying on database test-entries that are not guaranteed to exist), it was impractical and very time consuming to make sure all tests still run successfully. So subset of tests where the changed subroutines are called directly was selected and these should now pass. The following tests should be effected by the changes and should be run as a part of the test-plan: t/db_dependent/api/v1/biblios.t t/db_dependent/api/v1/checkouts.t t/db_dependent/api/v1/return_claims.t t/db_dependent/Circulation/CalcDateDue.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t t/db_dependent/Circulation/dateexpiry.t t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/Circulation/IsItemIssued.t t/db_dependent/Circulation/issue.t t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Circulation/maxsuspensiondays.t t/db_dependent/Circulation/ReturnClaims.t t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/SwitchOnSiteCheckouts.t t/db_dependent/Circulation.t t/db_dependent/Circulation/TooMany.t t/db_dependent/Circulation/transferbook.t t/db_dependent/DecreaseLoanHighHolds.t t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t t/db_dependent/HoldsQueue.t t/db_dependent/Holds/RevertWaitingStatus.t t/db_dependent/Illrequests.t t/db_dependent/ILSDI_Services.t t/db_dependent/Items.t t/db_dependent/Koha/Account/Line.t t/db_dependent/Koha/Acquisition/Order.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Holds.t t/db_dependent/Koha/Items.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Object.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Pseudonymization.t t/db_dependent/Koha/Recalls.t t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/IssueSlip.t t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_PrevCheckout.t t/db_dependent/Reserves/GetReserveFee.t t/db_dependent/Reserves.t t/db_dependent/rollingloans.t t/db_dependent/selenium/regressions.t t/db_dependent/SIP/ILS.t The following still fails for me but should either work on a fresh Koha installation, or fail for unrelated reasons (that is they also fail in Koha master): t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Items.t t/db_dependent/SIP/ILS.t To be able to run t/db_dependent/Circulation.t in my Koha instance there where some existing bugs that needed fixing, so this patch have a dependency on Bug 31676. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:34:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:34:33 +0000 Subject: [Koha-bugs] [Bug 31735] Circulation optimizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 --- Comment #1 from David Gustafsson --- Created attachment 141603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141603&action=edit Bug 31735: Avoid re-fetcing objects from database by passing them directly instead of ids to various subroutines To test: 1) Run the following test and make sure all pass: t/db_dependent/api/v1/biblios.t t/db_dependent/api/v1/checkouts.t t/db_dependent/api/v1/return_claims.t t/db_dependent/Circulation/CalcDateDue.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t t/db_dependent/Circulation/dateexpiry.t t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/Circulation/IsItemIssued.t t/db_dependent/Circulation/issue.t t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Circulation/maxsuspensiondays.t t/db_dependent/Circulation/ReturnClaims.t t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/SwitchOnSiteCheckouts.t t/db_dependent/Circulation.t t/db_dependent/Circulation/TooMany.t t/db_dependent/Circulation/transferbook.t t/db_dependent/DecreaseLoanHighHolds.t t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t t/db_dependent/HoldsQueue.t t/db_dependent/Holds/RevertWaitingStatus.t t/db_dependent/Illrequests.t t/db_dependent/ILSDI_Services.t t/db_dependent/Items.t t/db_dependent/Koha/Account/Line.t t/db_dependent/Koha/Acquisition/Order.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Holds.t t/db_dependent/Koha/Items.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Object.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Pseudonymization.t t/db_dependent/Koha/Recalls.t t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/IssueSlip.t t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_PrevCheckout.t t/db_dependent/Reserves/GetReserveFee.t t/db_dependent/Reserves.t t/db_dependent/rollingloans.t t/db_dependent/selenium/regressions.t t/db_dependent/SIP/ILS.t 2) Performe one or more checkouts for a patron, making sure that the circulation rules allows for renewals (for example by setting an earlier due-date). 3) Log in as this patron in OPAC and make sure the list of checkouts is displayed correctly, and that renewing an issue still works. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:34:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:34:38 +0000 Subject: [Koha-bugs] [Bug 31735] Circulation optimizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 --- Comment #2 from David Gustafsson --- Created attachment 141604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141604&action=edit Bug 31735: Avoid unesssary unblessing of objects -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:34:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:34:43 +0000 Subject: [Koha-bugs] [Bug 31735] Circulation optimizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 --- Comment #3 from David Gustafsson --- Created attachment 141605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141605&action=edit Bug 31735: Add caching for relatively expensive patron attributes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:34:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:34:46 +0000 Subject: [Koha-bugs] [Bug 31735] Circulation optimizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 --- Comment #4 from David Gustafsson --- Created attachment 141606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141606&action=edit Bug 31735: Remove Koha::Config::SysPref->find since bypasses cache get_yaml_pref_hash also allows invalid YAML and only parses a limited subset so remove this method to avoid future issues. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:34:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:34:51 +0000 Subject: [Koha-bugs] [Bug 31735] Circulation optimizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 --- Comment #5 from David Gustafsson --- Created attachment 141607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141607&action=edit Bug 31735: Match rules on effective item type instead of itype -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:34:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:34:56 +0000 Subject: [Koha-bugs] [Bug 31735] Circulation optimizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 --- Comment #6 from David Gustafsson --- Created attachment 141608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141608&action=edit Bug 31735: Optimize OPAC checkouts view -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:35:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:35:45 +0000 Subject: [Koha-bugs] [Bug 31735] Circulation optimizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31676 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 [Bug 31676] Fix db_dependent/Circulation.t tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:35:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:35:45 +0000 Subject: [Koha-bugs] [Bug 31676] Fix db_dependent/Circulation.t tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 [Bug 31735] Circulation optimizations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:36:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:36:03 +0000 Subject: [Koha-bugs] [Bug 31735] Circulation optimizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:43:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:43:31 +0000 Subject: [Koha-bugs] [Bug 31735] Circulation optimizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 --- Comment #7 from David Gustafsson --- Created attachment 141609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141609&action=edit Benchmark before -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:43:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:43:59 +0000 Subject: [Koha-bugs] [Bug 31735] Circulation optimizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 --- Comment #8 from David Gustafsson --- Created attachment 141610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141610&action=edit Benchmark after -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:50:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:50:59 +0000 Subject: [Koha-bugs] [Bug 31736] New: Context for translation: "All" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31736 Bug ID: 31736 Summary: Context for translation: "All" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr "All" is used all over Koha, and refers to different things. In French, those different things have different genders and the "All" must be in that gender ("tous" for "male-gendered" things and "toutes" for "female-gendered" things). In fr-CA-staff-prog, it says "All" is used in these places #: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt:313 #: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt:380 #: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt:347 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt:121 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt:123 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:208 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:216 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:387 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:396 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:918 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:939 #: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt:45 #: koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt:247 #: koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt:254 #: koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt:261 #: koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt:268 #: koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt:57 #: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt:63 #: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt:74 #: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt:86 #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt:203 #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt:248 #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt:263 #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt:111 #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt:116 #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt:245 #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt:259 #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt:887 #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt:1494 #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt:152 #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt:156 #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt:165 #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt:179 #: koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt:50 #: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt:281 #: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt:396 #: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt:415 #: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-bib-search.tt:25 #: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-bib-search.tt:37 #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt:135 #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt:226 #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt:217 #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt:219 #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt:238 #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt:240 #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt:268 #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt:270 #: koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc:12 #: koha-tmpl/intranet-tmpl/prog/en/includes/av-build-dropbox.inc:16 #: koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc:247 #: koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc:33 #: koha-tmpl/intranet-tmpl/prog/en/includes/str/tinymce_i18n.inc:2 We should add context so that translators know what that "All" refers to. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 15:57:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 13:57:58 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #26 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #25) > Please rebase ASAP. Only the last patch please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 16:08:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 14:08:44 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #59 from Marcel de Rooy --- + $new_lang = "default" if $new_lang eq 'en'; # Assume that "en" is "default" Dont like this assumption after all ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 16:19:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 14:19:37 +0000 Subject: [Koha-bugs] [Bug 31555] Getting holds via REST API needs edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31555 --- Comment #4 from Tomás Cohen Arazi --- Our permissions need a revamp (i.e. we should have individual permissions for each hold action). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 16:21:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 14:21:02 +0000 Subject: [Koha-bugs] [Bug 28799] Action logs should capture lost items found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 16:21:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 14:21:05 +0000 Subject: [Koha-bugs] [Bug 28799] Action logs should capture lost items found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 16:21:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 14:21:07 +0000 Subject: [Koha-bugs] [Bug 28950] serialsUpdate cron does not mark an issue late until the next issue is expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28950 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 16:21:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 14:21:11 +0000 Subject: [Koha-bugs] [Bug 28950] serialsUpdate cron does not mark an issue late until the next issue is expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28950 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 16:21:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 14:21:14 +0000 Subject: [Koha-bugs] [Bug 29048] Incorrect search for linked authority records from authority search result list in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29048 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 16:21:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 14:21:17 +0000 Subject: [Koha-bugs] [Bug 29048] Incorrect search for linked authority records from authority search result list in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29048 --- Comment #14 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 16:21:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 14:21:19 +0000 Subject: [Koha-bugs] [Bug 29561] Remove blank facet for languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29561 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 16:21:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 14:21:22 +0000 Subject: [Koha-bugs] [Bug 29561] Remove blank facet for languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29561 --- Comment #16 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 16:21:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 14:21:25 +0000 Subject: [Koha-bugs] [Bug 30168] Use checkout object in GetSoonestRenewDate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 16:21:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 14:21:29 +0000 Subject: [Koha-bugs] [Bug 30168] Use checkout object in GetSoonestRenewDate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 16:21:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 14:21:31 +0000 Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 16:21:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 14:21:35 +0000 Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 --- Comment #15 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 16:21:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 14:21:37 +0000 Subject: [Koha-bugs] [Bug 31555] Getting holds via REST API needs edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31555 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 16:21:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 14:21:40 +0000 Subject: [Koha-bugs] [Bug 31555] Getting holds via REST API needs edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31555 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 16:21:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 14:21:43 +0000 Subject: [Koha-bugs] [Bug 31682] Silence warn when using automatic linker in biblio editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31682 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 16:21:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 14:21:45 +0000 Subject: [Koha-bugs] [Bug 31682] Silence warn when using automatic linker in biblio editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31682 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 16:31:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 14:31:05 +0000 Subject: [Koha-bugs] [Bug 31687] Add see from and see also from tracings in Match index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31687 --- Comment #5 from Caroline Cyr La Rose --- (In reply to David Nind from comment #4) > Thanks Caroline for the clear test plan and example records - these made it > so easy to test! Thanks David! I'm always afraid my very long test plans will scare away people lol! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 16:32:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 14:32:02 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #60 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #59) > + $new_lang = "default" if $new_lang eq 'en'; # Assume that "en" is > "default" > > Dont like this assumption after all ;) This dbrev made a mess of my news items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 17:10:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 15:10:07 +0000 Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 17:14:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 15:14:43 +0000 Subject: [Koha-bugs] [Bug 25901] Add option for ClaimsReturnedWarningThreshold to count only unresolved claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25901 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 17:18:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 15:18:41 +0000 Subject: [Koha-bugs] [Bug 28841] Canceling holds from 'Holds awaiting pickup' should follow return policies regarding transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28841 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 17:18:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 15:18:54 +0000 Subject: [Koha-bugs] [Bug 28841] Canceling holds from 'Holds awaiting pickup' should follow return policies regarding transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28841 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 17:19:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 15:19:37 +0000 Subject: [Koha-bugs] [Bug 30411] Add separate shelving location column to Holds Queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 17:20:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 15:20:04 +0000 Subject: [Koha-bugs] [Bug 29079] Make biblio info in holds queue customizable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29079 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 17:22:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 15:22:33 +0000 Subject: [Koha-bugs] [Bug 29079] Make biblio info in holds queue customizable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29079 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 17:35:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 15:35:49 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 17:41:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 15:41:04 +0000 Subject: [Koha-bugs] [Bug 28396] Call number browse pagination In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28396 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 17:41:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 15:41:58 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Ann Flournoy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aflournoy at cityofkeller.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 17:44:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 15:44:59 +0000 Subject: [Koha-bugs] [Bug 15428] Different timeout preference for opac and intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 17:53:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 15:53:57 +0000 Subject: [Koha-bugs] [Bug 31737] New: Fix CGI::param called in list context warning in smart-rules.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31737 Bug ID: 31737 Summary: Fix CGI::param called in list context warning in smart-rules.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: slavashishkin at gmail.com Reporter: slavashishkin at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com, nugged at gmail.com When UnseenRenewals syspref is disabled, the form param is not passed at all when parsed it comes as undef, but the code tries directly to do strip_non_numeric call on it. Thus the 'undef' warning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 17:59:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 15:59:05 +0000 Subject: [Koha-bugs] [Bug 31737] Fix CGI::param called in list context warning in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31737 --- Comment #1 from Slava Shishkin --- When UnseenRenewals syspref is disabled, the form param is not passed at all when parsed it comes as undef, but the code tries directly to do strip_non_numeric call on it. Thus the 'undef' warnings: [WARN] Use of uninitialized value $string in substitution (s///) at /kohadevbox/koha/admin/smart-rules.pl line 760. [WARN] Use of uninitialized value $string in pattern match (m//) at /kohadevbox/koha/admin/smart-rules.pl line 761. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 18:01:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 16:01:21 +0000 Subject: [Koha-bugs] [Bug 31737] Fix undef warnings around unseen_renewals_allowed in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31737 Slava Shishkin changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix CGI::param called in |Fix undef warnings around |list context warning in |unseen_renewals_allowed in |smart-rules.pl |smart-rules.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 18:01:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 16:01:58 +0000 Subject: [Koha-bugs] [Bug 31737] Undef warnings around unseen_renewals_allowed in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31737 Slava Shishkin changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix undef warnings around |Undef warnings around |unseen_renewals_allowed in |unseen_renewals_allowed in |smart-rules.pl |smart-rules.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 18:02:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 16:02:50 +0000 Subject: [Koha-bugs] [Bug 31737] Undef warnings around unseen_renewals_allowed in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31737 --- Comment #2 from Slava Shishkin --- Created attachment 141611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141611&action=edit Bug 31737: Fix undef warnings around unseen_renewals_allowed in smart-rules.pl Trivial fix. To reproduce: 1. Create or edit a rule on /cgi-bin/koha/admin/smart-rules.pl - i.e. submit the form (make POST request) 2. Notice the mentioned above warning in plack-intranet-error.log 3. Apply the patch. 4. Repeat step 1. 5. That warning in log file should be no more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 18:06:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 16:06:37 +0000 Subject: [Koha-bugs] [Bug 25916] Create function and UI to modify budgets and funds. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25916 Ann Flournoy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aflournoy at cityofkeller.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 18:07:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 16:07:16 +0000 Subject: [Koha-bugs] [Bug 25918] Add budget/fund modification history to function added in BUG 25916 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25918 Ann Flournoy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aflournoy at cityofkeller.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 18:08:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 16:08:10 +0000 Subject: [Koha-bugs] [Bug 31606] Enhance acquisitions to allow ordering on next year's budget when still in current year. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31606 Ann Flournoy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aflournoy at cityofkeller.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 18:09:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 16:09:48 +0000 Subject: [Koha-bugs] [Bug 31737] Undef warnings around unseen_renewals_allowed in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31737 Slava Shishkin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 18:21:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 16:21:22 +0000 Subject: [Koha-bugs] [Bug 30487] Convert checkout and patron details page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30487 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 18:21:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 16:21:27 +0000 Subject: [Koha-bugs] [Bug 30487] Convert checkout and patron details page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30487 --- Comment #1 from Owen Leonard --- Created attachment 141612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141612&action=edit Bug 30487: Convert checkout and patron details page tabs to Bootstrap This patch updates the checkout and patron details pages, updating jQueryUI tabs to Bootstrap tabs. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Go to Circulation -> Check out and load a patron record for checkout. Ideally the patron record should have a variet of data associated with it: - Checkouts - Relative's checkouts (if patron is a guarantor or guarantee to another patron with checkouts) - Holds - Article requests - Claims - Restrictions - Clubs On the patron's checkout page, test the various tabs corresponding to the features listed above. Having data to display in those tabs helps confirm that any table functionality triggered by the tab activation is working correctly. The checkouts tab should work correctly whether you have "Always show checkouts immediately" checked or not. Test that you can pre-select any tab by appending its anchor to the URL, e.g.: /cgi-bin/koha/circ/circulation.pl?borrowernumber=123#reserves Perform the same checks on the patron details page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 18:29:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 16:29:24 +0000 Subject: [Koha-bugs] [Bug 31738] New: Unstranslatable string in checkouts.js for recalls Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31738 Bug ID: 31738 Summary: Unstranslatable string in checkouts.js for recalls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr When an item has been recalled, there is a red message in the current borrower's checkout list that says "This item has been recalled and the due date updated." I can't find this string anywhere in the translation files. The original string is in koha-tmpl/intranet-tmpl/prog/js/checkouts.js To get this message: 1. Turn on recalls 1.1. In Administration > Global system preferences, enable UseRecalls 1.2. Add recalls permissions in your circulation rules 2. In the OPAC, log in as a patron 3. Find a record with checked out items and place a recall 4. In the intranet, go to the patron file of the patron who currently has that item checked out --> In the Checkouts table at the bottom of the page, there is a red message next to the recalled title -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 18:34:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 16:34:44 +0000 Subject: [Koha-bugs] [Bug 31147] Recalls due date to the minute rather than 23:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31147 --- Comment #2 from Caroline Cyr La Rose --- Release maintainers, this fix is needed as far back as 22.05. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 18:48:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 16:48:49 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 18:48:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 16:48:53 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #1 from Kyle M Hall --- Created attachment 141613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141613&action=edit Bug 24606: Update database, add new schema file -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 18:49:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 16:49:04 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #2 from Kyle M Hall --- Created attachment 141614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141614&action=edit Bug 24606: Add Koha Object(s) with unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 18:49:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 16:49:08 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #3 from Kyle M Hall --- Created attachment 141615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141615&action=edit Bug 24606: Update existing schema files [DO NOT PUSH] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 18:49:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 16:49:12 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #4 from Kyle M Hall --- Created attachment 141616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141616&action=edit Bug 24606: Implement item templates This patch set implements item editor templates for community Koha. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Restart all the things! 4) prove t/db_dependent/Koha/Item/Template* 5) As a non superlibrarian, enter the item editor 6) Set some item fields, save as a new template using the buttom and form below the editor. 7) Test loading a template without remembering for the session 8) Test loading a template while remembering for the session 9) Test deleting a template 10) Test updating a template 11) Create one or more shared templates 12) Log in as another non superlibrarian without the new permission manage_item_editor_templates, verify you cannot edit/delete templates shared to you 13) Enable the new permission manage_item_editor_templates, verify you can now edit and delete templates shared to you -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 18:49:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 16:49:16 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #5 from Kyle M Hall --- Created attachment 141617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141617&action=edit Bug 24606: Add item template editor permission -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 18:49:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 16:49:34 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 21:30:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 19:30:17 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 22:25:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 20:25:05 +0000 Subject: [Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #9 from David Nind --- Created attachment 141618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141618&action=edit Bug 31727 - Database query results from testing I've had a go at testing (using KTD). After step 9, I have one extra rule - I'm not sure if this is an issue. If it isn't an issue, I'm happy to sign off. What I did: 1. Changed default circulation and fines rule: - Suspension in days (day): 2 - Max. suspension duration (day): 5 - Suspension charging interval: 1 2. Default checkout, hold and return policy - Standard rule for all libraries: . Total current checkouts allowed: 20 . Total current on-site checkouts allowed: 20 . Maximum total holds allowed (count): 25 . Hold policy: From any library . Hold pickup library match: Not set . Return policy: Not set 3. Created "Default checkout, hold and return policy" rules for Franklin, Midway, and Springfield: - Just used different numbers for the first 3 settings - Set hold policy differently for all three 4. Result for step 3 - 47 rows/rules [see attachment]. 5. Result for step 5 - now have 63 rows/rules: 47 + 15 (3 libraries x 5 extra rules) + 1 (extra rule for unseenrenewalsallowed for NULL - see row 51) [see attachment]. 6. Result for step 9 - now have 48 row/rules: still have one extra rule - row 51 [see attachment]. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 22:28:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 20:28:49 +0000 Subject: [Koha-bugs] [Bug 25787] Club holds can't be placed without modify_holds_priority permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Jason Robb changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb at sekls.org --- Comment #2 from Jason Robb --- Still valid in 21.11.11. Technically place_holds is also required to get that far so it may be that the overarching reserveforothers permission is what's truly required to successfully place a club hold. The ability to place club holds should really be its own separate user permission nested under the reserveforothers (or possibly clubs?) permission group. In our club usage scenario, a mistaken club hold can lead to hundreds of a holds on a record which puts many items in motion to patrons that don't actually want them. I wrote some JS to hide the "Clubs" tab at request.pl with exception for the select staff users in charge of placing club holds. It also changes the label wording from "Search patrons or clubs" to just "Search patrons". var loggedUser = $("#logged-in-info-full .loggedinusername").text(); var clubbers = ["staffusername1", "staffusername2"]; //show for these users if ($.inArray(loggedUser, clubbers) == -1) { $('#circ_request [href="#holds_clubsearch_pane"]').closest('li').hide(); $('#circ_request label:contains("Search patrons or clubs")').text("Search patrons"); } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 22:39:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 20:39:24 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #5 from David Nind --- Patch no longer applies: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 31212: Change datelastseen from date to datetime field Using index info to reconstruct a base tree... M C4/Items.pm M Koha/Schema/Result/Deleteditem.pm M Koha/Schema/Result/Item.pm M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt M koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt M koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt M koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging installer/data/mysql/kohastructure.sql Auto-merging Koha/Schema/Result/Item.pm Auto-merging Koha/Schema/Result/Deleteditem.pm Auto-merging C4/Items.pm CONFLICT (content): Merge conflict in C4/Items.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 31212: Change datelastseen from date to datetime field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 22:52:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 20:52:44 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #6 from David Nind --- Patch no longer applies: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 24606: Update database, add new schema file Applying: Bug 24606: Add Koha Object(s) with unit tests Applying: Bug 24606: Update existing schema files [DO NOT PUSH] Using index info to reconstruct a base tree... M Koha/Schema/Result/Borrower.pm Falling back to patching base and 3-way merge... Auto-merging Koha/Schema/Result/Borrower.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Borrower.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 24606: Update existing schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 23:56:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 21:56:37 +0000 Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 23:56:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 21:56:42 +0000 Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140868|0 |1 is obsolete| | --- Comment #68 from Lucas Gass --- Created attachment 141619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141619&action=edit Bug 24381: Update sample notices This patch update the sample notices for new installs Signed-off-by: Kyle M Hall Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 23:56:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 21:56:49 +0000 Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140869|0 |1 is obsolete| | --- Comment #69 from Lucas Gass --- Created attachment 141620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141620&action=edit Bug 24381: Update notices if defaults used Signed-off-by: Kyle M Hall Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 23:56:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 21:56:55 +0000 Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140870|0 |1 is obsolete| | --- Comment #70 from Lucas Gass --- Created attachment 141621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141621&action=edit Bug 24381: Update notice params If the update to catch defaults fails, we need to attempt to update renamed template variables Signed-off-by: Kyle M Hall Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 23:57:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 21:57:01 +0000 Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140871|0 |1 is obsolete| | --- Comment #71 from Lucas Gass --- Created attachment 141622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141622&action=edit Bug 24381: (follow-up) Notice improvements Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 23:57:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 21:57:07 +0000 Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140873|0 |1 is obsolete| | --- Comment #72 from Lucas Gass --- Created attachment 141623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141623&action=edit Bug 24381: (follow-up) Add USE statements Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 23:57:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 21:57:56 +0000 Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #73 from Lucas Gass --- Thanks for this one Martin. It will make a lot of librarians happy. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 00:18:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 22:18:33 +0000 Subject: [Koha-bugs] [Bug 30487] Convert checkout and patron details page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30487 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 00:18:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 22:18:37 +0000 Subject: [Koha-bugs] [Bug 30487] Convert checkout and patron details page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30487 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141612|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 141624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141624&action=edit Bug 30487: Convert checkout and patron details page tabs to Bootstrap This patch updates the checkout and patron details pages, updating jQueryUI tabs to Bootstrap tabs. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Go to Circulation -> Check out and load a patron record for checkout. Ideally the patron record should have a variet of data associated with it: - Checkouts - Relative's checkouts (if patron is a guarantor or guarantee to another patron with checkouts) - Holds - Article requests - Claims - Restrictions - Clubs On the patron's checkout page, test the various tabs corresponding to the features listed above. Having data to display in those tabs helps confirm that any table functionality triggered by the tab activation is working correctly. The checkouts tab should work correctly whether you have "Always show checkouts immediately" checked or not. Test that you can pre-select any tab by appending its anchor to the URL, e.g.: /cgi-bin/koha/circ/circulation.pl?borrowernumber=123#reserves Perform the same checks on the patron details page. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 00:21:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 22:21:11 +0000 Subject: [Koha-bugs] [Bug 31676] Fix db_dependent/Circulation.t tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Assignee|chris at bigballofwax.co.nz |glasklas at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 00:34:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 22:34:07 +0000 Subject: [Koha-bugs] [Bug 31676] Fix db_dependent/Circulation.t tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 00:34:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 22:34:12 +0000 Subject: [Koha-bugs] [Bug 31676] Fix db_dependent/Circulation.t tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141464|0 |1 is obsolete| | --- Comment #14 from Lucas Gass --- Created attachment 141625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141625&action=edit Bug 31676: Fix db_dependent/Circulation.t tests To test: 1) Set "RenewalPeriodBase" syspref to "the current date", "CircControl" to "the library the item is from." and "HomeOrHoldingBranch" to "the item's home library (homebranch)." 2) Run tests in t/db_dependent/Circulation.t and verify that fails (the script should actually crash before all can be run). 3) Apply the patch 4) Verifiy that all tests now pass Sponsored-by: Gothenburg University Library Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 00:36:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 22:36:05 +0000 Subject: [Koha-bugs] [Bug 27315] The man pages for the command line utilities do not display properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27315 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 00:36:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 22:36:10 +0000 Subject: [Koha-bugs] [Bug 27315] The man pages for the command line utilities do not display properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27315 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141594|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 141626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141626&action=edit Bug 27315: use the namespace-aware docbook stylesheet When viewing the man page for the `koha-list` command, the output does not appear correctly: there appears to be a "staircase"-like effect on the text. The same is true for all other man pages. The source XML files for our man pages have the following namespace declaration at the top: xmlns='http://docbook.org/ns/docbook', which means they are DocBook V5.0 documents and should be processed by namespace-aware DocBook XSL stylesheets. This patch fixes that by using the DocBook-to-man-page transformation stylesheet from the docbook-xsl-ns package (note the "-ns" suffix). Test plan: 1) Apply the patch 2) Build and install new package 3) Confirm the man pages display correctly Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 00:39:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 22:39:28 +0000 Subject: [Koha-bugs] [Bug 27315] The man pages for the command line utilities do not display properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27315 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #10 from David Nind --- Testing notes (using koha-testing-docker): 1. To replicate the problem: (a) Install man-db: apt-get install man-db (b) man koha-list (or any package command) 2. I wasn't sure how to do step 2 in the test plan, so I: (a) applied the patch (b) installed dockbook-xsl-ns: apt-get install docbook-xsl-ns (c) xsltproc --output /tmp/koha-docs/ /usr/share/xml/docbook/stylesheet/docbook-xsl-ns/manpages/docbook.xsl /kohadevbox/koha/debian/docs/*.xml (d) change to the /tmp/koha-docs directory (e) man -l koha-list.8 (or any package command) (f) gzip -k * (-k = keep source xml files) (g) cp -R *.gz /usr/share/man/man8 (h) man koha-list (or any package command) * 3. Have signed off, as I'm assuming that the build process will now take care of correctly producing the man pages once the change is pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 00:46:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 22:46:55 +0000 Subject: [Koha-bugs] [Bug 31698] Add ability to move a hold to a new biblio/item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisettepalouse+koha at gmail.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 00:47:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 22:47:40 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #3 from Lucas Gass --- I think the use of another red X on the page to change the item level hold into a bib level one is confusing. There are already a few red X's on the page and that particular one offers no explanation to the user as to what it will do. Maybe we need a dropdown? I'm not sure if that is the proper solution either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 01:24:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 23:24:17 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #19 from David Cook --- (In reply to Ere Maijala from comment #18) > Anything non-OPAC could qualify, e.g. a union catalog based on OAI-PMH. Or > even an OPAC instance for staff use only. I was thinking about it again this morning and thinking that it could be any non-public system. > > > For flexibility it should be possible to configure suppression per OAI-PMH > > > set in addition to a default setting. > > > > GetRecord isn't affected by sets, so are you thinking of a flag in the > > "oai_sets" data that would disable the suppression/hiding of records? > > GetRecord response has header/setSpec to indicate which sets the record > belongs to. It should reflect suppression by excluding a set where the > record would be marked deleted. So if we have sets "all" and "opac", a > suppressed record would only have
    all
    . I was thinking that a suppressed record wouldn't be retrievable at all by GetRecord if it's suppressed/hidden by the OPAC business rules. We have libraries who don't want records to leave Koha or be exposed in any public capacity if they're suppressed/hidden, and I think that makes sense. -- An alternative could be to have public and private OAI-PMH endpoints but that wouldn't necessarily be backwards compatible with all harvesting systems... Now that I think about it, we do have non-Koha systems that have public and private OAI-PMH endpoints. It would probably be the cleanest solution, but it would involve work to transition. Since Koha tries not to change behaviour with upgrades, I suppose the oai.pl would keep the current behaviour, and "public/oai.pl" or "public_oai.pl" would be the endpoint that doesn't send suppressed/hidden record metadata. -- I suppose there could also be a few system preference options regarding record suppression/hiding. There could be a "full block" where records are suppressed/hidden regardless. Then there could be a "partial block" where records are retrievable by default, unless the "set" says not to block it. And then "no block" would be showing records regardless. (Maybe "no block" should also turn off the current "OpacHiddenItem" handling too then?) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 01:59:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 23:59:50 +0000 Subject: [Koha-bugs] [Bug 19064] OAI-PMH Records appearing in OAI that can't be found in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19064 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from David Cook --- *** This bug has been marked as a duplicate of bug 31161 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 01:59:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 23:59:50 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marrone.patricio at gmail.com --- Comment #20 from David Cook --- *** Bug 19064 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 01:59:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2022 23:59:51 +0000 Subject: [Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403 Bug 24403 depends on bug 19064, which changed state. Bug 19064 Summary: OAI-PMH Records appearing in OAI that can't be found in OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19064 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 02:03:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 00:03:24 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #21 from Tomás Cohen Arazi --- Can we add 'supressed' and 'supressed_date' to the biblio table and make our high level methods take care of syncing things? That would make it easy to build a performant query for identifying (to be marked as) deleted records in OAI. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 02:04:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 00:04:53 +0000 Subject: [Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #22 from David Cook --- We should probably do a patch for this at some point so that we don't have to package the older HTTP::OAI modules. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 02:44:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 00:44:43 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #22 from David Cook --- (In reply to Tomás Cohen Arazi from comment #21) > Can we add 'supressed' and 'supressed_date' to the biblio table and make our > high level methods take care of syncing things? Can you elaborate on that? OpacSuppression could work with that, but I don't know how you'd make it work with OpacHiddenItems with OpacHiddenItemsHidesRecord. (Unless you require people to touch_all_biblios.pm after changing OpacHiddenItems and OpacHiddenItemsHidesRecord.) > That would make it easy to build a performant query for identifying (to be > marked as) deleted records in OAI. That could be interesting. It would need to be done via a join or a subquery, but it would still probably be fairly performant. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 02:47:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 00:47:27 +0000 Subject: [Koha-bugs] [Bug 27463] OAI-PMH date handling in ListBase.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27463 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|ASSIGNED |RESOLVED --- Comment #21 from David Cook --- Looks like this one can be closed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 03:29:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 01:29:53 +0000 Subject: [Koha-bugs] [Bug 31042] OVERRIDE_SYSPREF does not work for REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31042 --- Comment #2 from David Cook --- That's very interesting. I thought maybe the problem was with RequestHeader/RewriteRule not mixing, but the issue exists for both http://localhost:8081/api/v1/patrons and http://localhost:8081/api/v1/app.pl/api/v1/patrons When I dump out the variables from Koha/Middleware/SetEnv.pm I see the data coming through for both the mainpage.pl and the API: 'HTTP_X_KOHA_SETENV' => 'OVERRIDE_SYSPREF_Foo Bar', When I dump %ENV for mainpage.pl, I see lots of HTTP_X headers including: 'HTTP_X_KOHA_SETENV' => 'OVERRIDE_SYSPREF_Foo Bar', When I dump %ENV for API, I don't see any HTTP_X headers... which look like they're just the environmental variables Starman started with... Yep... you need to access the Plack/PSGI-level environmental variables in Mojo::Server::PSGI using $c->req->env. Plack::App::CGIBin uses Plack::App::WrapCGI which resets the %ENV variables at this line: https://metacpan.org/dist/Plack/source/lib/Plack/App/WrapCGI.pm#L48 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 04:09:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 02:09:53 +0000 Subject: [Koha-bugs] [Bug 31042] OVERRIDE_SYSPREF does not work for REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31042 --- Comment #3 from David Cook --- So... that's interesting. Since %ENV is a global variable, anything we do to it will affect the whole life of the Starman worker process. It looks like we're setting $ENV{REMOTE_ADDR} in Koha/Middleware/RealIP.pm so we're already meddling with that global variable. Since REMOTE_ADDR gets set by every request, I suppose there's no real problem... I suppose we could update Koha/Middleware/SetEnv.pm or Koha/REST/V1.pm, to update %ENV... and folk would need to know they'd need to restart Starman if they change their RequestHeader directives in Apache... -- (As an aside, are we actually flushing L1 caches with the REST API? I don't see anything for it at a glance...) -- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 04:39:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 02:39:18 +0000 Subject: [Koha-bugs] [Bug 31042] OVERRIDE_SYSPREF does not work for REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31042 --- Comment #4 from David Cook --- I'm looking at custom code right now but there's a little over 100 instances of $ENV in the code I'm looking at. For CGI-style .pl scripts, that should be fine. For Perl modules, it's more of a problem since they can be used by Mojolicious code and create bugs as a result. Like we're seeing now. -- I suppose one option would be to move $ENV calls to C4::Context->env(...) which could check %ENV and/or a $req_env variable which could be set per request (using various mechanisms). That seems like a bit of a hack though. The shortest path is just to pollute %ENV like we're doing with REMOTE_ADDR. -- Another idea for this very particular use case would be to create a cache in C4::Context and then use before_dispatch hook in Koha/REST/V1.pm to set that C4::Context cache from the $env variable. (That works while we're using synchronous requests, but if we used Mojo asynchronously then that would probably be vulnerable to a race condition.) -- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 05:43:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 03:43:23 +0000 Subject: [Koha-bugs] [Bug 31042] OVERRIDE_SYSPREF does not work for REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31042 --- Comment #5 from David Cook --- Over time, we'll find global variables and singletons like C4::Context are going to cause more and more headaches. Yet, we've deeply embedded C4::Context->preference throughout all our code... For example, Koha::Patron->store() is riddled with syspref calls. Over time, it would be an idea to switch from C4::Context->preference() to $c->syspref() and to pass preferences through function/method calls. (That would help support multitenancy and non-blocking programming in the future too.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 05:44:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 03:44:12 +0000 Subject: [Koha-bugs] [Bug 31042] OVERRIDE_SYSPREF does not work for REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31042 --- Comment #6 from David Cook --- And I realized that just using %ENV could be a problem since the intranet, opac, and API all are served by the same workers. Unless care is taken to clean the %ENV each time then even the shortest path is fraught... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 06:24:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 04:24:34 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #7 from Aleisha Amohia --- Created attachment 141627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141627&action=edit Bug 23012: Database updates for PROCESSING_FOUND account credit type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 06:24:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 04:24:39 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #8 from Aleisha Amohia --- Created attachment 141628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141628&action=edit Bug 23012: Show the PROCESSING_FOUND account credit type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 06:24:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 04:24:44 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #9 from Aleisha Amohia --- Created attachment 141629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141629&action=edit Bug 23012: Set policy for lost item processing fee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 06:24:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 04:24:48 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #10 from Aleisha Amohia --- Created attachment 141630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141630&action=edit Bug 23012: [WIP] Mark processing fee as found when lost item found -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 06:25:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 04:25:15 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #11 from Aleisha Amohia --- Still working on this, attaching progress here to pick up tomorrow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 06:28:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 04:28:02 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #23 from David Cook --- Just realized that while my changes work well for GetRecord and ListRecords, they don't for ListIdentifiers. For that, we'll have to fetch the metadata in order to know whether or not it needs to be suppressed/hidden. That is unless we do the analysis at the SQL level. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 06:49:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 04:49:54 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #24 from David Cook --- (In reply to David Cook from comment #23) > Just realized that while my changes work well for GetRecord and ListRecords, > they don't for ListIdentifiers. > > For that, we'll have to fetch the metadata in order to know whether or not > it needs to be suppressed/hidden. > > That is unless we do the analysis at the SQL level. Ugh, and even fetching the metadata doesn't work for OpacHiddenItems unless that metadata format includes items. This is so frustrating. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 06:58:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 04:58:17 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #25 from David Cook --- (In reply to David Cook from comment #22) > (In reply to Tomás Cohen Arazi from comment #21) > > Can we add 'supressed' and 'supressed_date' to the biblio table and make our > > high level methods take care of syncing things? I think we need to bite the bullet and store "suppressed" when "OpacSuppression" and "OpacHiddenItemsHidesRecord" are set, and just add the caveat that any changes to these settings will require a data regeneration. Doing the calculation 1 time and then just working off the stored state will make things so much easier across the board. Plus, we could index that state, so that "OpacHiddenItemsHidesRecord" actually hides the record in the Zebra results as well, which would lead to better search result quality. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:26:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:26:20 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140519|0 |1 is obsolete| | --- Comment #304 from Julian Maurice --- Created attachment 141631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141631&action=edit Bug 30952: Staff interface redesign (header) What this patch does: - change the navigation bar style - change the breadcrumbs style - change the "last borrower" link style - move the search bar inside the navigation bar - move the help link to the same row as the breadcrumbs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:26:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:26:29 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140520|0 |1 is obsolete| | --- Comment #305 from Julian Maurice --- Created attachment 141632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141632&action=edit Bug 30952: Add Poppins font assets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:26:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:26:39 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140521|0 |1 is obsolete| | --- Comment #306 from Julian Maurice --- Created attachment 141633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141633&action=edit Bug 30952: Move "Go to advanced/item search" link to toolbar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:26:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:26:48 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140522|0 |1 is obsolete| | --- Comment #307 from Julian Maurice --- Created attachment 141634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141634&action=edit Bug 30952: Staff interface redesign (toolbar) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:26:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:26:57 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140523|0 |1 is obsolete| | --- Comment #308 from Julian Maurice --- Created attachment 141635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141635&action=edit Bug 30952: Change checkout, checkin and renew forms -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:27:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:27:06 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140524|0 |1 is obsolete| | --- Comment #309 from Julian Maurice --- Created attachment 141636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141636&action=edit Bug 30952: Staff interface redesign (main page) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:27:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:27:14 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140525|0 |1 is obsolete| | --- Comment #310 from Julian Maurice --- Created attachment 141637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141637&action=edit Bug 30952: Small adjustments in search results page - Move Z39.50 search button to a toolbar - Use btn and btn-link classes for "Select all" and "Clear all" buttons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:27:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:27:22 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140526|0 |1 is obsolete| | --- Comment #311 from Julian Maurice --- Created attachment 141638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141638&action=edit Bug 30952: Change MARC tags toolbar style -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:27:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:27:30 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140527|0 |1 is obsolete| | --- Comment #312 from Julian Maurice --- Created attachment 141639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141639&action=edit Bug 30952: Change login page style -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:27:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:27:38 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140528|0 |1 is obsolete| | --- Comment #313 from Julian Maurice --- Created attachment 141640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141640&action=edit Bug 30952: Change sysprefs nav menu style -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:27:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:27:45 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140529|0 |1 is obsolete| | --- Comment #314 from Julian Maurice --- Created attachment 141641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141641&action=edit Bug 30952: Change default button style -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:27:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:27:54 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140530|0 |1 is obsolete| | --- Comment #315 from Julian Maurice --- Created attachment 141642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141642&action=edit Bug 30952: Change tables style -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:28:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:28:02 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140531|0 |1 is obsolete| | --- Comment #316 from Julian Maurice --- Created attachment 141643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141643&action=edit Bug 30952: The rest of CSS changes There is still work to do to split this patch correctly into several more logical patches. Consider this patch a WIP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:28:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:28:13 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140532|0 |1 is obsolete| | --- Comment #317 from Julian Maurice --- Created attachment 141644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141644&action=edit Bug 30952: (follow-up) Undo change to Home breadcrumb -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:28:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:28:22 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140533|0 |1 is obsolete| | --- Comment #318 from Julian Maurice --- Created attachment 141645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141645&action=edit Bug 30952: Undo change to Home breadcrumb for remaining templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:28:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:28:29 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140534|0 |1 is obsolete| | --- Comment #319 from Julian Maurice --- Created attachment 141646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141646&action=edit Bug 30952: Replace "Home" by icon in breadcrumbs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:28:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:28:37 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140535|0 |1 is obsolete| | --- Comment #320 from Julian Maurice --- Created attachment 141647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141647&action=edit Bug 30952: Fix "rows" forms Issue #7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:28:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:28:45 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140536|0 |1 is obsolete| | --- Comment #321 from Julian Maurice --- Created attachment 141648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141648&action=edit Bug 30952: Fix position shift when hovering .linktools links Issue #6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:28:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:28:53 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140537|0 |1 is obsolete| | --- Comment #322 from Julian Maurice --- Created attachment 141649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141649&action=edit Bug 30952: Fix the 'keep_text' feature of the search bar Text in one form should be copied in other forms when switching tab Issue #2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:29:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:29:01 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140538|0 |1 is obsolete| | --- Comment #323 from Julian Maurice --- Created attachment 141650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141650&action=edit Bug 30952: Show the search catalog form by default in cat-search.inc Issue #1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:29:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:29:09 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140539|0 |1 is obsolete| | --- Comment #324 from Julian Maurice --- Created attachment 141651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141651&action=edit Bug 30952: Move the toolbar back to the left Issue #8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:29:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:29:17 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140540|0 |1 is obsolete| | --- Comment #325 from Julian Maurice --- Created attachment 141652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141652&action=edit Bug 30952: Fix alignment of search results Issue #11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:29:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:29:25 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140541|0 |1 is obsolete| | --- Comment #326 from Julian Maurice --- Created attachment 141653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141653&action=edit Bug 30952: Fix "browse patrons by last name" display Issue #13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:29:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:29:33 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140542|0 |1 is obsolete| | --- Comment #327 from Julian Maurice --- Created attachment 141654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141654&action=edit Bug 30952: Fix left padding of sidebar Issue #14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:29:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:29:41 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140543|0 |1 is obsolete| | --- Comment #328 from Julian Maurice --- Created attachment 141655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141655&action=edit Bug 30952: Fix lists display on patron detail page Issue #15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:29:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:29:50 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140544|0 |1 is obsolete| | --- Comment #329 from Julian Maurice --- Created attachment 141656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141656&action=edit Bug 30952: Fix background color of dialogs (message, alert, error) Issue #9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:29:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:29:58 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140545|0 |1 is obsolete| | --- Comment #330 from Julian Maurice --- Created attachment 141657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141657&action=edit Bug 30952: Increase contrast between green text and white/grey background Issue #10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:30:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:30:08 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140546|0 |1 is obsolete| | --- Comment #331 from Julian Maurice --- Created attachment 141658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141658&action=edit Bug 30952: Change color of btn-primary and use that for Check out button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:30:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:30:19 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140547|0 |1 is obsolete| | --- Comment #332 from Julian Maurice --- Created attachment 141659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141659&action=edit Bug 30952: Add "card" layout to the checkout page Also fix the label positioning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:30:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:30:30 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140548|0 |1 is obsolete| | --- Comment #333 from Julian Maurice --- Created attachment 141660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141660&action=edit Bug 30952: Move search bar below navbar and reduce navbar height -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:30:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:30:39 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140549|0 |1 is obsolete| | --- Comment #334 from Julian Maurice --- Created attachment 141661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141661&action=edit Bug 30952: Add card layout to patron messages in moremember.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:30:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:30:47 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140550|0 |1 is obsolete| | --- Comment #335 from Julian Maurice --- Created attachment 141662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141662&action=edit Bug 30952: Fix background of search header Issue #3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:30:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:30:56 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140551|0 |1 is obsolete| | --- Comment #336 from Julian Maurice --- Created attachment 141663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141663&action=edit Bug 30952: Fix item edit form Issue #31 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:31:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:31:05 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140552|0 |1 is obsolete| | --- Comment #337 from Julian Maurice --- Created attachment 141664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141664&action=edit Bug 30952: Move 'Clear filter' next to filter in table headers Issue #16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:31:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:31:13 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140553|0 |1 is obsolete| | --- Comment #338 from Julian Maurice --- Created attachment 141665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141665&action=edit Bug 30952: Change circulation home page links to buttons Apply the same style to staff home page links Issue #18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:31:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:31:23 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140554|0 |1 is obsolete| | --- Comment #339 from Julian Maurice --- Created attachment 141666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141666&action=edit Bug 30952: Fix table headers Issue #16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:31:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:31:31 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140555|0 |1 is obsolete| | --- Comment #340 from Julian Maurice --- Created attachment 141667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141667&action=edit Bug 30952: Fix remaining header search bars -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:31:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:31:40 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140556|0 |1 is obsolete| | --- Comment #341 from Julian Maurice --- Created attachment 141668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141668&action=edit Bug 30952: Fix background of "Clear filter" button Issue #16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:31:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:31:48 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140557|0 |1 is obsolete| | --- Comment #342 from Julian Maurice --- Created attachment 141669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141669&action=edit Bug 30952: Fix contrast issue on patron brief view Issue #19 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:31:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:31:58 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140558|0 |1 is obsolete| | --- Comment #343 from Julian Maurice --- Created attachment 141670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141670&action=edit Bug 30952: Remove white text shadow from buttons Issue #20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:32:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:32:08 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140559|0 |1 is obsolete| | --- Comment #344 from Julian Maurice --- Created attachment 141671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141671&action=edit Bug 30952: Fix pagination colors Issue #21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:32:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:32:17 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140560|0 |1 is obsolete| | --- Comment #345 from Julian Maurice --- Created attachment 141672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141672&action=edit Bug 30952: Reintroduce table borders Issue #22 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:33:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:33:09 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140566|0 |1 is obsolete| | --- Comment #346 from Julian Maurice --- Created attachment 141673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141673&action=edit Bug 30952: Reintroduce placeholder and classes in catalogue search They were lost in the last rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:33:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:33:19 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140567|0 |1 is obsolete| | --- Comment #347 from Julian Maurice --- Created attachment 141674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141674&action=edit Bug 30952: Reintroduce borders in search browse links Issue #23 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:33:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:33:29 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140570|0 |1 is obsolete| | --- Comment #348 from Julian Maurice --- Created attachment 141675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141675&action=edit Bug 30952: Remove messages box on patron detail page when empty Issue #28 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:33:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:33:37 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140571|0 |1 is obsolete| | --- Comment #349 from Julian Maurice --- Created attachment 141676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141676&action=edit Bug 30952: Bring back bullet points for lists Issue #29 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:33:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:33:45 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140576|0 |1 is obsolete| | --- Comment #350 from Julian Maurice --- Created attachment 141677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141677&action=edit Bug 30952: Change sidebar menu headers - Remove the bottom border - Increase font size and weight - Fix a padding issue Issue #30 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:33:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:33:56 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140577|0 |1 is obsolete| | --- Comment #351 from Julian Maurice --- Created attachment 141678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141678&action=edit Bug 30952: Fix fieldset legend positioning Issue #27 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:34:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:34:08 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140588|0 |1 is obsolete| | --- Comment #352 from Julian Maurice --- Created attachment 141679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141679&action=edit Bug 30952: Set preferences save buttons as primary buttons Issue #32 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:34:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:34:19 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140613|0 |1 is obsolete| | --- Comment #353 from Julian Maurice --- Created attachment 141680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141680&action=edit Bug 30952: Header search - move tabs to the right (and other tweaks) Make the search bar take the whole page width, with inputs at the center taking all the available space Add a separator between inputs when there are more than one Issue #24 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:34:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:34:28 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140617|0 |1 is obsolete| | --- Comment #354 from Julian Maurice --- Created attachment 141681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141681&action=edit Bug 30952: Fix header search bar for RTL Issue #38 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:34:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:34:37 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140618|0 |1 is obsolete| | --- Comment #355 from Julian Maurice --- Created attachment 141682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141682&action=edit Bug 30952: Fix navbar elements ordering for RTL Issue #38 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:34:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:34:46 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140619|0 |1 is obsolete| | --- Comment #356 from Julian Maurice --- Created attachment 141683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141683&action=edit Bug 30952: Adjust colors of browse search Issue #23 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:34:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:34:55 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140620|0 |1 is obsolete| | --- Comment #357 from Julian Maurice --- Created attachment 141684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141684&action=edit Bug 30952: Fix color of navbar toggle on small screen Issue #37 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:35:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:35:04 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140628|0 |1 is obsolete| | --- Comment #358 from Julian Maurice --- Created attachment 141685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141685&action=edit Bug 30952: Fix toolbar positioning and spacing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:35:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:35:14 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140629|0 |1 is obsolete| | --- Comment #359 from Julian Maurice --- Created attachment 141686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141686&action=edit Bug 30952: Fix style of some buttons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:35:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:35:24 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140635|0 |1 is obsolete| | --- Comment #360 from Julian Maurice --- Created attachment 141687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141687&action=edit Bug 30952: Better header search bar on smaller screens - Show only tab icons on screens <= 992px - Hide form title on the left on screens <= 768px - Move some dropdown lists to the "extra" filters area Issue #24 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:35:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:35:35 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140649|0 |1 is obsolete| | --- Comment #361 from Julian Maurice --- Created attachment 141688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141688&action=edit Bug 30952: Fix spacing of nested fieldsets Issue #42 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:35:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:35:45 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140650|0 |1 is obsolete| | --- Comment #362 from Julian Maurice --- Created attachment 141689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141689&action=edit Bug 30952: Fix positioning of fieldset's elements below a legend Issue #41 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:35:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:35:54 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140651|0 |1 is obsolete| | --- Comment #363 from Julian Maurice --- Created attachment 141690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141690&action=edit Bug 30952: Fix facets block display Issue #40 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:36:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:36:02 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140652|0 |1 is obsolete| | --- Comment #364 from Julian Maurice --- Created attachment 141691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141691&action=edit Bug 30952: Remove useless styles -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:36:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:36:10 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140653|0 |1 is obsolete| | --- Comment #365 from Julian Maurice --- Created attachment 141692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141692&action=edit Bug 30952: Add spacing between itemtypes and subtype limits Issue #43 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:36:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:36:19 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140654|0 |1 is obsolete| | --- Comment #366 from Julian Maurice --- Created attachment 141693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141693&action=edit Bug 30952: Stop search bar resizing when switching tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:36:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:36:26 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140658|0 |1 is obsolete| | --- Comment #367 from Julian Maurice --- Created attachment 141694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141694&action=edit Bug 30952: Fix table styling (cell borders, striping) Issue #22 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:36:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:36:34 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140687|0 |1 is obsolete| | --- Comment #368 from Julian Maurice --- Created attachment 141695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141695&action=edit Bug 30952: (follow-up) Proposed reworking of catalog header menu link Issue #46 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:36:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:36:43 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140977|0 |1 is obsolete| | --- Comment #369 from Julian Maurice --- Created attachment 141696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141696&action=edit Bug 30952: Remove text shadow from buttons so they don't look blurred Issue #49 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:36:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:36:52 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141020|0 |1 is obsolete| | --- Comment #370 from Julian Maurice --- Created attachment 141697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141697&action=edit Bug 30952: Add the "card" style to biblio detail page Issue #45 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:37:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:37:01 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141024|0 |1 is obsolete| | --- Comment #371 from Julian Maurice --- Created attachment 141698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141698&action=edit Bug 30952: Harmonize tables style - 2 pixels border below and above - No border above or below table cells (in thead, tbody and tfoot) - No border around tables Issue #22 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:37:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:37:11 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141026|0 |1 is obsolete| | --- Comment #372 from Julian Maurice --- Created attachment 141699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141699&action=edit Bug 30952: Remove Poppins font, use Bootstrap 5 font stack instead Issue #20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:37:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:37:20 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141027|0 |1 is obsolete| | --- Comment #373 from Julian Maurice --- Created attachment 141700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141700&action=edit Bug 30952: Fix biblio detail display when covers are enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:37:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:37:29 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141041|0 |1 is obsolete| | --- Comment #374 from Julian Maurice --- Created attachment 141701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141701&action=edit Bug 30952: Fix color contrast so we are at least WCAG AA compliant Issue #10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:37:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:37:37 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141043|0 |1 is obsolete| | --- Comment #375 from Julian Maurice --- Created attachment 141702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141702&action=edit Bug 30952: (follow-up) Use variables for primary and secondary greens _variables.scss currently contains a variable, $background-color-primary, which isn't used. I think we should use that variable anywhere the color is used, and use SASS color calculation to generate the secondary color. The two colors can be compared in the search header: primary for the background, secondary for the submit button color. To test, apply the patch and rebuild the staff interface CSS. Test various pages in the staff interface to confirm that the colors look the same as before: Search header, tab colors, "Last patron" button, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:37:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:37:46 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141044|0 |1 is obsolete| | --- Comment #376 from Julian Maurice --- Created attachment 141703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141703&action=edit Bug 30952: (follow-up) Fix style of floating toolbars This patch makes some changes to floating toolbars, both hc-sticky toolbars and DataTables floating toolbars. The changes fix some bugs in the display (incorrect z-index, unwanted margins) and proposes a different style for .searchheader-style toolbars (e.g. patron search results). To test, apply the patch and rebuild the staff interface CSS. Test pages with various kinds and combinations of floating toolbars, e.g.: - Administration -> System preferences - Patrons -> Patron search results - Administration -> Libraries - Catalog search results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:37:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:37:54 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141047|0 |1 is obsolete| | --- Comment #377 from Julian Maurice --- Created attachment 141704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141704&action=edit Bug 30952: Add label style to label class inside fieldset.rows Issue #51 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:38:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:38:03 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141052|0 |1 is obsolete| | --- Comment #378 from Julian Maurice --- Created attachment 141705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141705&action=edit Bug 30952: Harmonize tabs style - Reduce border width from 3px to 2px - Active tab is white on "primary" green (WCAG AA ✓) - Other tabs are black (#111) on "secondary" green (WCAG AA ✓) - Font weight is normal The patch also removes some useless/redundant CSS properties related to tabs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:38:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:38:11 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141053|0 |1 is obsolete| | --- Comment #379 from Julian Maurice --- Created attachment 141706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141706&action=edit Bug 30952: Change default buttons style to look like .btn.btn-default And do not change the style of these buttons when they are in a table If we want to make them look like links, we should use btn-link class instead -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:38:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:38:21 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141054|0 |1 is obsolete| | --- Comment #380 from Julian Maurice --- Created attachment 141707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141707&action=edit Bug 30952: Fix background of header search "extra-content" toggle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:38:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:38:30 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141055|0 |1 is obsolete| | --- Comment #381 from Julian Maurice --- Created attachment 141708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141708&action=edit Bug 30952: Fix toolbar alignment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:38:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:38:39 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141056|0 |1 is obsolete| | --- Comment #382 from Julian Maurice --- Created attachment 141709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141709&action=edit Bug 30952: Fix patroninfo-section alignment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:38:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:38:48 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141057|0 |1 is obsolete| | --- Comment #383 from Julian Maurice --- Created attachment 141710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141710&action=edit Bug 30952: Make the top left logo clickable area wider Issue #35 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:38:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:38:57 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141064|0 |1 is obsolete| | --- Comment #384 from Julian Maurice --- Created attachment 141711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141711&action=edit Bug 30952: Fix style of datatables buttons when not inside a .pager -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:39:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:39:06 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141074|0 |1 is obsolete| | --- Comment #385 from Julian Maurice --- Created attachment 141712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141712&action=edit Bug 30952: (follow-up) Avoid nav menu jump between bold and normal I think styling links with a bold hover state results in a "jumpy" look, and I seem to recall making changes in the past to issues like in response to bug reports. I'd like to propose an alternative style for the nav menu which uses color changes to indicate the hover state. This menu can be seen in the sidebar of patron details, bibliographic details, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:39:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:39:14 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141075|0 |1 is obsolete| | --- Comment #386 from Julian Maurice --- Created attachment 141713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141713&action=edit Bug 30952: (follow-up) Restore DataTable sorting icons Some CSS was removed which controlled the appearance of DataTables column sort icons. Without it, DataTables tries to use some default images which do not exist. This patch restores the icons. With it, sorting icons should look like they do in master and there should be no related 404 errors in the console. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 07:57:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 05:57:28 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #26 from David Cook --- For now, I will proceed with my patches to solve some immediate local problems, but they're probably not worth upstreaming as they don't comprehensively solve the problem. For that, I think we need to change how we handle OpacSuppression and OpacHiddenItems and to use SQL for the suppression/hidden lookup. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 08:00:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 06:00:39 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #387 from Julian Maurice --- All patches rebased on master. As it generates a lot of noises, I might squash all patches before rebasing next time. https://pro-mt38042-koha.demo.biblibre.eu/ is up to date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 08:13:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 06:13:20 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #27 from Ere Maijala --- The thing is that an OAI-PMH provider should really have a publishing process that handles everything needed to publish a set of records for harvesting and keep it up to date. This would make it possible to: 1. Publish a set once in a format that makes harvesting blazing fast. 2. Update the set incrementally with changes in bibs and items. 3. Re-publish all if suppression rules change. 4. Take care of deletions when they affect the records that have been published in the set. If a record has never been a part of a set, it doesn't need to be returned even as deleted. 5. Ensure that a set doesn't change while harvesting (requires set versioning). The obvious downside is that a publishing process is relatively heavy, and keeping sets up to date in a near-real-time manner is more difficult. Also sets published this way would require more database space. --- Now to more practical stuff. The multiple endpoints idea works for me. I don't think there's any other interoperable way if you need to have different rules. You could also have several endpoints like 'internal/oai.pl', 'opac/oai.pl' and 'test/oai.pl', no problem. From the protocol point of view they'd just be separate providers. However, they should also have separate OAI identifiers. Things could go really bad if a harvester receives the same record from multiple endpoints. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 08:25:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 06:25:38 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 08:25:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 06:25:42 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141596|0 |1 is obsolete| | Attachment #141597|0 |1 is obsolete| | Attachment #141598|0 |1 is obsolete| | --- Comment #11 from Mason James --- Created attachment 141714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141714&action=edit Bug 31729: Enable automatic filesystem refresh in Plack to test: 0/ apt install inotify-tools 1/ apply patch 2/ copy files, and set perms manually sudo cp debian/script/koha-plack /usr/sbin sudo cp debian/script/koha-watcher to /usr/sbin sudo chmod 755 debian/script/koha-plack /usr/sbin/koha-plack sudo chmod 755 debian/script/koha-watcher to /usr/sbin/koha-watcher 3/ koha-plack --start --watch kohadev 4/ pat a kitten 🐱 5/ modify file in watched dir echo `date` > /usr/share/koha/xxx1 echo `date` > /usr/share/koha/xxx2 6/ see HUP/inotify messages in log file $ tail -f /var/log/koha/kohadev/plack-error.log /usr/share/koha/ MODIFY xxx1 Sending children hup signal /usr/share/koha/ MODIFY xxx2 Sending children hup signal 7/ observe koha-watch process ps -ef | grep koha-watcher | grep -v grep | wc -l 1 8/ koha-plack --stop kohadev 9/ observe no koha-watch process ps -ef | grep koha-watcher | grep -v grep | wc -l 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 08:31:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 06:31:35 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #12 from Mason James --- Created attachment 141715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141715&action=edit Bug 31729: Enable automatic filesystem refresh in Plack (2) fix typo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 08:49:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 06:49:36 +0000 Subject: [Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 --- Comment #10 from Andrew Nugged --- I did some selection of key/value pairs, their allowances of values, and spreading over tables on smart-rules.pl page: https://wiki.koha-community.org/wiki/Circulation_rules_values_tech_list This might be helpful for analysis (Kevin, others) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 09:25:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 07:25:47 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #13 from Mason James --- Created attachment 141716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141716&action=edit Bug 31729 - Enable automatic filesystem refresh in Plack (3) fix 'elif' typo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 09:32:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 07:32:34 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #388 from Paul Poulain --- +1 for squashing ! (well done Julian, though) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 09:36:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 07:36:33 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #14 from Mason James --- > 5/ modify file in watched dir > echo `date` > /usr/share/koha/xxx1 > echo `date` > /usr/share/koha/xxx2 if testing in KTD, try... # echo `date` > /kohadevbox/koha/xxx2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 09:43:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 07:43:49 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com --- Comment #389 from Arthur Suzuki --- bizarre, in the top menu, english version, it's written "Catalogage" as in french. it used to be "cataloging". Squashing also helps for both rebase and backport, +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 09:50:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 07:50:31 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #390 from Julian Maurice --- (In reply to Arthur Suzuki from comment #389) > bizarre, in the top menu, english version, it's written "Catalogage" as in > french. > it used to be "cataloging". > Squashing also helps for both rebase and backport, +1 It's part of the IntranetNav syspref, not a translation issue ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 10:22:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 08:22:39 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Lukas Koszyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lukasz.koszyk at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 10:37:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 08:37:42 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #391 from Martin Renvoize --- Awesome.. I look forward to jumping on any resulting bugs after push at this point.. lets make it even more polished for the final release.. still plenty of little tweaks in my opinion but getting more eyes on by getting it pushed is my opinion. Arthur.. please don't backport this one ;P.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 10:42:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 08:42:44 +0000 Subject: [Koha-bugs] [Bug 30976] Cover images for biblio should be displayed first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976 --- Comment #11 from Arthur Suzuki --- Thx thomas, applied to 21.11.x for 21.11.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 10:49:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 08:49:27 +0000 Subject: [Koha-bugs] [Bug 30797] Subfields linked to the dateaccessioned.pl value builder on addbiblio.pl throw a JS error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30797 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Status|Pushed to master |Pushed to stable --- Comment #9 from Arthur Suzuki --- applied to 21.11.x for 21.11.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 10:51:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 08:51:22 +0000 Subject: [Koha-bugs] [Bug 31247] Staff interface 2FA blocks logging into the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #13 from Arthur Suzuki --- Depends on 2FA feature, won't backport to 21.11! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 10:51:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 08:51:25 +0000 Subject: [Koha-bugs] [Bug 20476] Two factor authentication for the staff client - omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476 Bug 20476 depends on bug 31247, which changed state. Bug 31247 Summary: Staff interface 2FA blocks logging into the OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 12:10:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 10:10:39 +0000 Subject: [Koha-bugs] [Bug 31238] Unable to save authorised value to frameworks subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |arthur.suzuki at biblibre.com --- Comment #9 from Arthur Suzuki --- I don't reproduce the issue on 21.11.x branch. Also bz29001 was not applied there so maybe that one is not needed for backport. Won't backport unless asked to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 12:16:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 10:16:42 +0000 Subject: [Koha-bugs] [Bug 31739] New: Password reset from staff fails if previous expired reset-entry exists Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31739 Bug ID: 31739 Summary: Password reset from staff fails if previous expired reset-entry exists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: bjorn.nylen at ub.lu.se QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 30611 enabled the password reset to be initiated from the patron details page. However if there is a previous *expired* reset-entry in the db then Koha will try to insert a new entry and fail with a "duplicate key"-error. To reproduce: Initiate a password reset, don't complete. Wait until expired (or modify expiry in db) Initiate a new reset from Staff -- FAIL -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 12:17:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 10:17:17 +0000 Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content warnings' to catalogue records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 --- Comment #15 from Martin Renvoize --- I think my choice of subfields and z was a bit arbitrary.. I used the 'action note', 583, as a basis. Happy to be guided. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 12:22:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 10:22:15 +0000 Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content warnings' to catalogue records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 --- Comment #16 from Martin Renvoize --- Subfield `z` is often 'public note' and subfield `x` is often 'nonpublic note' for other fields.. I did wonder about supporting subfield `u` specifically for a 'uri' to allow for linking to more details or a content policy or some such. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 12:57:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 10:57:31 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 12:57:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 10:57:35 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141613|0 |1 is obsolete| | Attachment #141614|0 |1 is obsolete| | Attachment #141615|0 |1 is obsolete| | Attachment #141616|0 |1 is obsolete| | Attachment #141617|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 141717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141717&action=edit Bug 24606: Update database, add new schema file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 12:58:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 10:58:12 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #8 from Kyle M Hall --- Created attachment 141718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141718&action=edit Bug 24606: Add Koha Object(s) with unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 12:58:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 10:58:16 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #9 from Kyle M Hall --- Created attachment 141719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141719&action=edit Bug 24606: Implement item templates This patch set implements item editor templates for community Koha. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Restart all the things! 4) prove t/db_dependent/Koha/Item/Template* 5) As a non superlibrarian, enter the item editor 6) Set some item fields, save as a new template using the buttom and form below the editor. 7) Test loading a template without remembering for the session 8) Test loading a template while remembering for the session 9) Test deleting a template 10) Test updating a template 11) Create one or more shared templates 12) Log in as another non superlibrarian without the new permission manage_item_editor_templates, verify you cannot edit/delete templates shared to you 13) Enable the new permission manage_item_editor_templates, verify you can now edit and delete templates shared to you -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 12:58:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 10:58:20 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #10 from Kyle M Hall --- Created attachment 141720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141720&action=edit Bug 24606: Add item template editor permission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 12:58:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 10:58:23 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #11 from Kyle M Hall --- Created attachment 141721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141721&action=edit Bug 24606: Update existing schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 13:02:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 11:02:53 +0000 Subject: [Koha-bugs] [Bug 30200] Add customizable tabs to interlibrary loan requests list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #19 from Owen Leonard --- I'm trying to get this to work so I can provide a follow-up to switch out the jQueryUI tabs with Bootstrap. I'm not sure if I'm doing something wrong, but it isn't working for me. Whichever tab I'm on I see all requests. The value in ILLRequestsTabs: - name: New status: - NEW - name: Status1 status: - ILL_STATUS_1 - name: Status2 status: - ILL_STATUS_2 - name: Status3-4 status: - ILL_STATUS_3 - ILL_STATUS_4 I inserted the ILL statues into the ILLSTATUS authorized value category. I manually updated some ILL requests to have the new statuses. When I go to the ILL requests page I see the tabs, but the tabs don't work to filter anything. The "All" and "NEW" tabs show all requests, and the Status1, Status2, Status3-4 tabs don't show anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 13:05:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 11:05:43 +0000 Subject: [Koha-bugs] [Bug 30200] Add customizable tabs to interlibrary loan requests list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #20 from Owen Leonard --- > 2. Add at least 4 ILL requests with the following SQL: > INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) > VALUES (1, 'CPL', 'IN_REM', 'Libris'); Another thing to note: If I manually update an ILL request with a custom status, the ILL requests table breaks completely: "Uncaught TypeError: can't access property "name", row.capabilities[row.status] is undefined" This problem happens in master too, but I mention it because it affects the usefulness of the test plan here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 13:08:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 11:08:53 +0000 Subject: [Koha-bugs] [Bug 31269] DataTables error when managing staged MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31269 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |arthur.suzuki at biblibre.com --- Comment #8 from Arthur Suzuki --- I don't reproduce the original issue on 21.11.x branch. Won't backport unless asked to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 13:22:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 11:22:49 +0000 Subject: [Koha-bugs] [Bug 31716] Enlarge the size of the authorised_value column in authorised_values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31716 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141520|0 |1 is obsolete| | Attachment #141521|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 141722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141722&action=edit Bug 31716: Enlarge the authorised_value column in authorised_values This patch changes authorised_value from VARCHAR(80) to VARCHAR(255) To test: 1 - Apply patch 2 - Update database 3 - Confirm you can store a longer value in authorised_values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 13:22:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 11:22:53 +0000 Subject: [Koha-bugs] [Bug 31716] Enlarge the size of the authorised_value column in authorised_values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31716 --- Comment #6 from Nick Clemens --- Created attachment 141723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141723&action=edit Bug 31716: Prevent issues with foreign key VARCHAR is now allowed to be 65535 bytes max, as opposed to 255 - when testing this, however, I received errors about latering a column with a foreign key. Adding this to the update to avoid problems like bug 31673. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 13:22:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 11:22:56 +0000 Subject: [Koha-bugs] [Bug 31716] Enlarge the size of the authorised_value column in authorised_values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31716 --- Comment #7 from Nick Clemens --- Created attachment 141724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141724&action=edit Bug 31716: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 13:25:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 11:25:03 +0000 Subject: [Koha-bugs] [Bug 31716] Enlarge the size of the authorised_value column in authorised_values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31716 --- Comment #8 from Nick Clemens --- (In reply to David Nind from comment #3) > I can now update an authorized value code using the database, but I can't > add or edit using the staff interface as the form entry's maximum length is > 80: value="" maxlength="80" class="focus" />. > Fixed (In reply to Marcel de Rooy from comment #4) > You go from 80 to 255. At some point that is too low again. We should imo go > to a TEXT type: A TEXT column with a maximum length of 65,535 (216 - 1) > characters. > One point: VARCHAR columns can be fully indexed. TEXT columns can only be > indexed over a specified length. Some versions of MySQL/Maria allow varchar up to 65535 - so we can increase in future as needed - this was the largest push without more work and sufficient for current needs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 13:29:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 11:29:46 +0000 Subject: [Koha-bugs] [Bug 31716] Enlarge the size of the authorised_value column in authorised_values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31716 --- Comment #9 from Marcel de Rooy --- (In reply to Nick Clemens from comment #8) > (In reply to Marcel de Rooy from comment #4) > > You go from 80 to 255. At some point that is too low again. We should imo go > > to a TEXT type: A TEXT column with a maximum length of 65,535 (216 - 1) > > characters. > > One point: VARCHAR columns can be fully indexed. TEXT columns can only be > > indexed over a specified length. > > Some versions of MySQL/Maria allow varchar up to 65535 - so we can increase > in future as needed - this was the largest push without more work and > sufficient for current needs URLs could be up to 2048 chars? Note that addressing the authorized values table is only half of the work. The receiving column should be able to store it too. But you know :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 13:32:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 11:32:14 +0000 Subject: [Koha-bugs] [Bug 31740] New: Illrequests table has a foreign key constraint on status_alias Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31740 Bug ID: 31740 Summary: Illrequests table has a foreign key constraint on status_alias Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org I am not sure the intent of this foreign key, however it seems problematic as we can't tie it to a single category To test: 1 - Add an authorised value for Asort1: Authorised value: MONKEY Description: Capuchin 2 - Add an authroised value for LOC: Authorised value: MONKEY Description: Spider 3 - Put an illrequest in the DB: INSERT INTO illrequests (branchcode,status,status_alias) VALUES ('CPL','REQUEST_TEST','MONKEY') 4 - Delete one of the authorised values above 5 - Check the DB: SELECT status_alias FROM illrequests WHERE status = 'REQUEST_TEST' 6 - Note the status is nulled by deletion of unrelated authroised value -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 13:32:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 11:32:34 +0000 Subject: [Koha-bugs] [Bug 31740] Illrequests table has a foreign key constraint on status_alias In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31740 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 13:38:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 11:38:24 +0000 Subject: [Koha-bugs] [Bug 31716] Enlarge the size of the authorised_value column in authorised_values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31716 --- Comment #10 from Nick Clemens --- (In reply to Marcel de Rooy from comment #9) > (In reply to Nick Clemens from comment #8) > > (In reply to Marcel de Rooy from comment #4) > URLs could be up to 2048 chars? Note that addressing the authorized values > table is only half of the work. The receiving column should be able to store > it too. But you know :) Indeed, flexibility comes with responsibility sometimes :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 13:38:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 11:38:33 +0000 Subject: [Koha-bugs] [Bug 31716] Enlarge the size of the authorised_value column in authorised_values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31716 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31740 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 13:38:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 11:38:33 +0000 Subject: [Koha-bugs] [Bug 31740] Illrequests table has a foreign key constraint on status_alias In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31740 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31716 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 14:06:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 12:06:45 +0000 Subject: [Koha-bugs] [Bug 30571] Table z3950servers: Make host, syntax and encoding NOT NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30571 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master --- Comment #27 from Tomás Cohen Arazi --- Follow-up pushed to master, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 14:46:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 12:46:48 +0000 Subject: [Koha-bugs] [Bug 31614] Add configurable timeout for Zebra connections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31614 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 14:46:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 12:46:52 +0000 Subject: [Koha-bugs] [Bug 31614] Add configurable timeout for Zebra connections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31614 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 14:46:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 12:46:55 +0000 Subject: [Koha-bugs] [Bug 31635] Empty title for current result in OPAC results browser's tooltip on paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 14:46:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 12:46:57 +0000 Subject: [Koha-bugs] [Bug 31635] Empty title for current result in OPAC results browser's tooltip on paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 14:47:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 12:47:00 +0000 Subject: [Koha-bugs] [Bug 31741] New: Update coding guidelines with the replacement of jQueryUI Datepicker with flatpickr Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31741 Bug ID: 31741 Summary: Update coding guidelines with the replacement of jQueryUI Datepicker with flatpickr Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Developer documentation Assignee: koha-bugs at lists.koha-community.org Reporter: victor at tuxayo.net QA Contact: testopia at bugs.koha-community.org Introduced in bug 29239. And document usage in wiki. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 14:47:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 12:47:01 +0000 Subject: [Koha-bugs] [Bug 31677] Convert basic MARC editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31677 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 14:47:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 12:47:04 +0000 Subject: [Koha-bugs] [Bug 31677] Convert basic MARC editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31677 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 14:47:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 12:47:07 +0000 Subject: [Koha-bugs] [Bug 31678] Convert authority editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 14:47:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 12:47:10 +0000 Subject: [Koha-bugs] [Bug 31678] Convert authority editor tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 14:47:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 12:47:14 +0000 Subject: [Koha-bugs] [Bug 31741] Update coding guidelines with the replacement of jQueryUI Datepicker with flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31741 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 14:48:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 12:48:08 +0000 Subject: [Koha-bugs] [Bug 31741] Update coding guidelines with the replacement of jQueryUI Datepicker with flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31741 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29239 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 14:48:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 12:48:08 +0000 Subject: [Koha-bugs] [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31741 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31741 [Bug 31741] Update coding guidelines with the replacement of jQueryUI Datepicker with flatpickr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 14:49:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 12:49:47 +0000 Subject: [Koha-bugs] [Bug 31739] Password reset from staff fails if previous expired reset-entry exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31739 Björn Nylén changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |bjorn.nylen at ub.lu.se |ity.org | Status|NEW |ASSIGNED --- Comment #1 from Björn Nylén --- Will upload a patch shortly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 14:59:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 12:59:26 +0000 Subject: [Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 --- Comment #11 from Kevin Carnes --- Created attachment 141725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141725&action=edit Bug 31727: Remove unseenrenewalsallowed rules that duplicate unseen_renewals_allowed rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 15:08:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 13:08:32 +0000 Subject: [Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 --- Comment #12 from Kevin Carnes --- (In reply to David Nind from comment #9) > Created attachment 141618 [details] > Bug 31727 - Database query results from testing > > I've had a go at testing (using KTD). > > After step 9, I have one extra rule - I'm not sure if this is an issue. > That extra rule is because I used the wrong name for the unseen_renewals_allowed rule. So if there were already rules that had an unseen_renewals_allowed, they now also have an unseenrenewalsallowed rule since it is added when there is no "unseenrenewalsallowed" rule. I think the solution is to remove "unseenrenewalsallowed" rules when there is a similar "unseen_renewals_allowed" rule, before renaming the remaining "unseenrenewalsallowed" to "unseen_renewals_allowed". Another option, especially now that you have an extra duplicate, is to remove an "unseen_renewals_allowed" rule when then are two for same parameters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 15:12:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 13:12:09 +0000 Subject: [Koha-bugs] [Bug 28555] Improve output of verbose option for overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28555 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 15:12:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 13:12:13 +0000 Subject: [Koha-bugs] [Bug 28555] Improve output of verbose option for overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28555 --- Comment #6 from Nick Clemens --- Created attachment 141726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141726&action=edit Bug 28555: (follow-up) Make verbose count flags passed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 15:13:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 13:13:25 +0000 Subject: [Koha-bugs] [Bug 31668] Avoid displaying nothing in facet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31668 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Nick Clemens --- Bug 29561 has been pushed and obsoletes this need, closing as duplicate *** This bug has been marked as a duplicate of bug 29561 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 15:13:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 13:13:25 +0000 Subject: [Koha-bugs] [Bug 29561] Remove blank facet for languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29561 --- Comment #17 from Nick Clemens --- *** Bug 31668 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 15:14:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 13:14:11 +0000 Subject: [Koha-bugs] [Bug 31274] OPACSuggestionAutoFill must be 1 or 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Arthur Suzuki --- Bug14242 not being present in 21.11.x, there is no reason to backport that one. Won't backport unless specifically asked to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 15:17:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 13:17:31 +0000 Subject: [Koha-bugs] [Bug 30879] Add option to sort components by biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com --- Comment #34 from Arthur Suzuki --- depends on Bug30327 which i'm still waiting a valid patch for 21.11.x. Will only backport if I get an update on the dependancy. (don't know the status... on hold?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 15:28:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 13:28:08 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 15:28:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 13:28:12 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141499|0 |1 is obsolete| | Attachment #141500|0 |1 is obsolete| | Attachment #141501|0 |1 is obsolete| | Attachment #141502|0 |1 is obsolete| | --- Comment #38 from Nick Clemens --- Created attachment 141727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141727&action=edit Bug 14783: Change pickup location from opac. This patch allows users to change the pickup location for their holds from the opac. A syspref (OPACAllowUserToChangeBranch) controls at what stage a hold can be changed. To test: 1. Set up holds with diffrent statuses for a patron (pending, waiting, in transit, suspended) 2. No pickup locations for any hold should be able to be changed. 3. Turn on and off the different options under OPACAllowUserToChangeBranch. Make sure that only the corresponding holds can be changed from the opac. Check eg in the staff client that pickup location has changed. 4. The available pickup locations should respect any transfer restrictions. (Same as the holds list for a biblio in staff client) 5. For an in-transit hold: Check in the item at the original pickup location. 6. Note that it will be redirected to the new location. Sponsored-by: Lunds Universitetsbibliotek Signed-off-by: Owen Leonard Signed-off-by: Barbara Johnson Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 15:28:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 13:28:16 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #39 from Nick Clemens --- Created attachment 141728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141728&action=edit Bug 14783: (follow-up) Move pickup library form into modal This patch attemps to simplify the list of holds by moving the form for changing a hold's pickup library into a modal dialog. This patch also makes minor tweaks to the CSS for the "X" close button shown in modal in windows. Instances where modal markup used "x" have been updated to use the Bootstrap 4 standard "×" To test, apply the patch and rebuild the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - Turn on the OPACAllowUserToChangeBranch system preference. - Log in to the OPAC as a user with holds. - In the view of your holds, confirm that each hold which can be modified shows a "Change" link. - Clicking the link should show a modal window with the title of the item on hold shown in the header. - Confirm that changing the pickup location works correctly. Signed-off-by: Barbara Johnson Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 15:28:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 13:28:21 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #40 from Nick Clemens --- Created attachment 141729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141729&action=edit Bug 14783: (QA follow-up) Change "Pick up location" to "Pickup location" in table. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 15:28:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 13:28:26 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #41 from Nick Clemens --- Created attachment 141730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141730&action=edit Bug 14783: (QA follow-up) Add unit tests. This commit adds unit tests for Bug 14783. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 15:31:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 13:31:54 +0000 Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com --- Comment #22 from Arthur Suzuki --- quite a lot of conflicts while trying to apply on 21.11.x... If this is really needed I wouldn't refuse some help on the backport (provide backport patch?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 15:38:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 13:38:45 +0000 Subject: [Koha-bugs] [Bug 30327] Sort component parts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30327 --- Comment #49 from Nick Clemens --- Created attachment 141731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141731&action=edit Bug 30327: [21.11.x] Add options for sorting components This patch adds two new sysprefs: ComponentSortField ComponentSortOrder These allow the user to choose how components should be sorted when displaying on the details page of a record, and the corresponding search for all components This also updates our search from simple_search_compat to search_compat to allow for sorting options Note: Some sorting under ES is unclear - this is a separate issue to be invesitgated Our Zebra index does not offer 'record number' sorting, I will file a bug for that To test: 1 - Enable UseControlNumber (or not) 2 - Add some components to a record by control number or title depending on above 3 - Enable ShowComponentRecords syspref 4 - View the record that has components 5 - Note they are not sorted 6 - Apply patch, updatedatabase 7 - reload record 8 - Note components are sorted by title ascending 9 - Try different values for ComponentSortField and ComponentSortOrder 10 - Confirm sorting changes with system preferences 11 - Repeat test on staff and opac, with ES and Zebra search engines Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Bug 30327: Fix tests Corrected variable name on update to match everywhere else Added a default value for limit in buildQuery and only append limit if it has content Signed-off-by: Katrin Fischer Bug 30327: (follow-up) Fix inconsistencies in syspref names and supply defaults This patch fetches the new sysprefs into variables, providing default title ascending if they are not set to avoid an undefined concatenation warning I also make the update idempotent and fix confusion of plural/singular names Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 16:37:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 14:37:38 +0000 Subject: [Koha-bugs] [Bug 31739] Password reset from staff fails if previous expired reset-entry exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31739 --- Comment #2 from Björn Nylén --- Created attachment 141732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141732&action=edit Bug 31739: Remove need to pass update param to Koha::Patron::Password::Recovery::SendPasswordRecoveryEmail Bug 31739: Password recovery from staff fails if previous expired reset-entry exists. SendPasswordRecoveryEmail relies on the calling script to tell if there is an existing valid recovery already. If there's an expired recovery-entry the members/notices.pl script will try to create a new entry resulting in a duplicate key error. This patch fixes the bug by removing the need for the calling script to do the check since SendPasswordRecoveryEmail does the same thing anyway. SendPasswordRecoveryEmail will now use DBIx ->update_or_create instead of looking at the $update param to determine if it should update an existing entry or create a new. The update param is removed from all calling scripts and test are updated. To test: 1. Generate a password recovery mail for a patron 2. Let it expire. 3. Generate a new password recovery from staff to the same patron - Fail! 4: Apply patch 5. Generate a new password recovery from staff to the same patron - Success! 6. Opac password recovery flow should also work. 7. Tests pass. Sponsored-by: Lund University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 16:42:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 14:42:15 +0000 Subject: [Koha-bugs] [Bug 31739] Password reset from staff fails if previous expired reset-entry exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31739 Björn Nylén changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch --- Comment #3 from Björn Nylén --- Setting to Needs signoff as well. Did the patch by changing the behaviour of SendPasswordRecoveryEmail. Could probably have made it easier but since the bug was related to the somewhat convoluted logic I chose to simplify the code instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 16:51:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 14:51:39 +0000 Subject: [Koha-bugs] [Bug 31742] New: Highlight logged-in library holdings on add/edit items screen (additem.pl) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31742 Bug ID: 31742 Summary: Highlight logged-in library holdings on add/edit items screen (additem.pl) Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: jrobb at sekls.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl It would be helpful in a consortia setting where many different libraries are sharing a single record to make items owned by the logged-in library stand out in the table at additem.pl. Highlighting an item's home library if it matches logged-in library is an easy visual indicator. I wrote some JS for this using the currentlibrary class added with bug 10902: var loggedBranch = $("#logged-in-info-full .logged-in-branch-name").text(); var colIndex = $('#cat_additem th:contains("Home library")').index() + 1; $('#cat_additem tr td:nth-child(' + colIndex + ')').each(function () { if (this.textContent == loggedBranch) { $(this).wrapInner(''); } }); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 16:56:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 14:56:18 +0000 Subject: [Koha-bugs] [Bug 31743] New: Cannot change my notice language when EnhancedMessagingPreferencesOPAC is off Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743 Bug ID: 31743 Summary: Cannot change my notice language when EnhancedMessagingPreferencesOPAC is off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org The combination of enabling TranslateNotices and disabling EnhancedMessagingPreferencesOPAC eliminates the possibility of changing language on OPAC user account. Note that we had both enabled and now we want to disable Enhanced on OPAC, but we loose the language. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 16:57:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 14:57:26 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 16:57:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 14:57:30 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 --- Comment #8 from Nick Clemens --- Created attachment 141733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141733&action=edit Bug 31459: (follow-up) Preserve budget period display This patch adds a level to the budget_loops and displays the budgets as optgroups for the funds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 16:57:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 14:57:34 +0000 Subject: [Koha-bugs] [Bug 31743] Cannot change my notice language when EnhancedMessagingPreferencesOPAC is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 16:58:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 14:58:35 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141733|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 141734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141734&action=edit Bug 31459: (follow-up) Preserve budget period display This patch adds a level to the budget_loops and displays the budgets as optgroups for the funds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 17:18:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 15:18:48 +0000 Subject: [Koha-bugs] [Bug 31382] Cannot reach password reset page when password expired In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31382 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Arthur Suzuki --- depends on password expiration feature not released in 21.11. no need to backport that one for 21.11.x I guess. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 17:18:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 15:18:48 +0000 Subject: [Koha-bugs] [Bug 31483] Minor UI problem in opac-reset-password.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Bug 31483 depends on bug 31382, which changed state. Bug 31382 Summary: Cannot reach password reset page when password expired https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31382 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 17:35:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 15:35:32 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 17:36:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 15:36:40 +0000 Subject: [Koha-bugs] [Bug 29079] Make biblio info in holds queue customizable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29079 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us --- Comment #2 from Rebecca Coert --- This would be an extremely useful addition. +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 17:37:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 15:37:17 +0000 Subject: [Koha-bugs] [Bug 30411] Add separate shelving location column to Holds Queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 17:39:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 15:39:11 +0000 Subject: [Koha-bugs] [Bug 4948] When cancelling a waiting hold, allow to trigger hold for next patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4948 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 17:39:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 15:39:25 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 17:39:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 15:39:33 +0000 Subject: [Koha-bugs] [Bug 31521] Allow to configure behaviour when checking in a reserved item at SCO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31521 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #2 from Lucas Gass --- I like this but have a couple questions/comments: 1. Should 'SCOCheckinIfReservedMessage' allow the use of HTML? 2. If 'SCOCheckinIfReservedBehaviour' is set to forbid or alert should we also check for the existence of 'SCOCheckinIfReservedMessage' to avoid displaying an empty '
    '? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 18:22:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 16:22:10 +0000 Subject: [Koha-bugs] [Bug 31744] New: Inventory tool can take a long time and never complete Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31744 Bug ID: 31744 Summary: Inventory tool can take a long time and never complete Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: wizzyrea at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com There seems to be a problem with scaling for the inventory tool. More and more often now with bigger libraries we are running into libraries putting too many barcodes into the tool, and timing out the tool, or not getting feedback on the job progress and clicking back and trying again (and again. And again.), eventually causing a denial of service as they tie up all of their plack workers with inventory jobs. Potentially we could put the processing part into the background jobs or work on the performance here some other way so that larger batches could be accommodated? The servers weren't underpowered for this - the libraries were putting in collection-size-appropriate numbers of barcodes. Open to any kind of solution here that would help make this tool more usable for libraries. Cheers, Liz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 18:43:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 16:43:43 +0000 Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #24 from Lucas Gass --- When I try to access the opac-user page I am met with an error: Template process failed: file error - parse error - /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt line 1397: unexpected end of input at /kohadevbox/koha/C4/Templates.pm line 127 It looks like there is a stray [% END %] in the template logic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:07:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:07:38 +0000 Subject: [Koha-bugs] [Bug 31742] Highlight logged-in library holdings on add/edit items screen (additem.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31742 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:35:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:35:26 +0000 Subject: [Koha-bugs] [Bug 31745] New: New child record from biblio does not populate 773 field in Advanced cataloging editor (rancor) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31745 Bug ID: 31745 Summary: New child record from biblio does not populate 773 field in Advanced cataloging editor (rancor) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When choosing 'New child record' the expectation is that a 773 with parent info will be prepopulated - this does not happen when using advanced cataloging editor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:41:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:41:28 +0000 Subject: [Koha-bugs] [Bug 31746] New: Patron record saves when cardnumber required and value entered is whitespace Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31746 Bug ID: 31746 Summary: Patron record saves when cardnumber required and value entered is whitespace Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: jyorio at equinoxinitiative.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com This happens both with the full patron entry form and the quick add form. When the cardnumber is required, it's possible to enter either spaces or non-printing characters into the cardnumber field and save the record. That is, there's nothing but whitespace. The value of cardnumber saved in the database in this case is NULL. It would be helpful if Koha verified that the cardnumber field contained something other than whitespace and prevented it from saving if it did not, when the cardnumber is required. I'm not sure if this relates to bug 30978 in any way, but I'm referencing it here just in case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:45:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:45:10 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:45:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:45:16 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138221|0 |1 is obsolete| | Attachment #138222|0 |1 is obsolete| | Attachment #138224|0 |1 is obsolete| | Attachment #138225|0 |1 is obsolete| | Attachment #138226|0 |1 is obsolete| | Attachment #138227|0 |1 is obsolete| | Attachment #138228|0 |1 is obsolete| | Attachment #138229|0 |1 is obsolete| | Attachment #138230|0 |1 is obsolete| | Attachment #141214|0 |1 is obsolete| | Attachment #141215|0 |1 is obsolete| | --- Comment #136 from Kyle M Hall --- Created attachment 141735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141735&action=edit Bug 24860: Add reserves.item_group_it This feature builds upon bug 24857 and allows placing holds that target a specific item group of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and item groups, with each item being assigned to an item group 6) Place a hold for a patron 7) Note the new selector to choose an item group in addition to record and item level holds 8) Place an item group level hold 9) Check in an item from the record that is not part of that item group 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that item group 12) Note the hold is trapped for that item 13) Place an item group level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that item group 16) Check out all the items of that item group to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:45:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:45:32 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #137 from Kyle M Hall --- Created attachment 141736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141736&action=edit Bug 24860: Add new syspref EnableItemGroupHolds Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:45:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:45:37 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #138 from Kyle M Hall --- Created attachment 141737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141737&action=edit Bug 24860: Implement reserves.item_group_id Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:45:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:45:43 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #139 from Kyle M Hall --- Created attachment 141738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141738&action=edit Bug 24860: Add ability to select an item group when placing a hold Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:45:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:45:49 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #140 from Kyle M Hall --- Created attachment 141739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141739&action=edit Bug 24860: Add ability to select an item group when placing a hold - OPAC Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:45:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:45:54 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #141 from Kyle M Hall --- Created attachment 141740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141740&action=edit Bug 24860: Skip non-matching item group holds in CheckReserves Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:45:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:45:59 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #142 from Kyle M Hall --- Created attachment 141741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141741&action=edit Bug 24860: Skip non-matching item group holds in HoldsQueue Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:46:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:46:04 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #143 from Kyle M Hall --- Created attachment 141742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141742&action=edit Bug 24860: Add hold's item group to holds table on circulation.pl and moremember.pl Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:46:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:46:09 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #144 from Kyle M Hall --- Created attachment 141743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141743&action=edit Bug 24860: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:46:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:46:14 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #145 from Kyle M Hall --- Created attachment 141744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141744&action=edit Bug 24860: (QA follow-up) Fix number of tests in t/db_dependent/Koha/Holds.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:46:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:46:19 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #146 from Kyle M Hall --- Created attachment 141745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141745&action=edit Bug 24860: (QA follow-up) Terminology and translation fixes * Fixes a single to a double underscore for translation in holds.js * Fixes item_group to item group in API description * Fixes volume hold to item group hold in syspref db descrpitions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:46:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:46:24 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #147 from Kyle M Hall --- Created attachment 141746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141746&action=edit Bug 24860: (QA follow-up) Add unit tests to cover changes to HoldsQueue.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:46:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:46:30 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #148 from Kyle M Hall --- Created attachment 141747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141747&action=edit Bug 24860: (QA follow-up) Add unit tests to cover changes to Reserves.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:46:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:46:35 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #149 from Kyle M Hall --- Created attachment 141748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141748&action=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::Hold::item_group -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:46:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:46:41 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #150 from Kyle M Hall --- Created attachment 141749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141749&action=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::Holds::forced_hold_level -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:46:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:46:46 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #151 from Kyle M Hall --- Created attachment 141750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141750&action=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::REST::V1::Holds::add -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:52:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:52:52 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #152 from Kyle M Hall --- (In reply to Katrin Fischer from comment #133) > 1) Unit tests I've added unit tests for everything you listed! > 2) Fixes some smaller stuff in 2 follow-ups, please have a look! Thank you! > 3) Holds to pull is off > > First my test case: > * Added 9 items to a record, 3 each for vol. 1-3 in enumchron > * Grouped them into 3 item groups > * In the OPAC, I placed a hold onto the volume 2 group > > In /circ/pendingreserves.pl it shows wrong information: > * 39999000005776 or any available. > * Available enumchron: vol. 1, vol. 2, vol. 3 > * There is no information that only volume 2 is wanted. I don't think Holds to pull is the tool a library should be using if they are using item group holds. This same is true for the holds itemtype filter, which has been in Koha since 16.05. I'm finding the holds to pull interface doesn't display data well. For instance, if I place one item level hold, and one biblio level hold for the same record, holds to pull doesn't really indicate that. If you can can tell me what you'd like to see, I'll see what I can do! > 4) Holds queue One line of the query got removed in a rebase. Fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:59:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:59:47 +0000 Subject: [Koha-bugs] [Bug 26648] Prevent internal server error if item attached to old checkout has been removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:59:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:59:50 +0000 Subject: [Koha-bugs] [Bug 26648] Prevent internal server error if item attached to old checkout has been removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648 --- Comment #15 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:59:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:59:53 +0000 Subject: [Koha-bugs] [Bug 27136] Add additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:59:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:59:56 +0000 Subject: [Koha-bugs] [Bug 27136] Add additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 --- Comment #17 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 19:59:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 17:59:58 +0000 Subject: [Koha-bugs] [Bug 31469] log4perl.conf: Plack logfiles need %n in conversionpattern In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31469 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 20:00:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 18:00:02 +0000 Subject: [Koha-bugs] [Bug 31469] log4perl.conf: Plack logfiles need %n in conversionpattern In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31469 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 20:00:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 18:00:05 +0000 Subject: [Koha-bugs] [Bug 31552] SIP2 option format_due_date not honored for AH field in item information response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31552 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 20:00:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 18:00:08 +0000 Subject: [Koha-bugs] [Bug 31552] SIP2 option format_due_date not honored for AH field in item information response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31552 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 20:17:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 18:17:52 +0000 Subject: [Koha-bugs] [Bug 28372] Use variables for 007 controlfield translations in MARC21slim2intranetResults.xsl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28372 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 20:17:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 18:17:54 +0000 Subject: [Koha-bugs] [Bug 28372] Use variables for 007 controlfield translations in MARC21slim2intranetResults.xsl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28372 --- Comment #13 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 20:23:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 18:23:25 +0000 Subject: [Koha-bugs] [Bug 28366] Add batch patron modification to patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28366 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 20:28:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 18:28:02 +0000 Subject: [Koha-bugs] [Bug 30109] Wrong interface in logs when renewing patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30109 --- Comment #2 from Nick Clemens --- Theory: - Related to bug 31042 - problem arises from api (or other?) calls where setenv is not explicitly set - plack worker retains most recent env that was set until something else overwrites it - when one of these scripts requests userenv, it gets the stale one from plack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 21:22:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 19:22:53 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 21:23:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 19:23:16 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 21:23:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 19:23:20 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #392 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 21:24:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 19:24:48 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #393 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #391) > Awesome.. I look forward to jumping on any resulting bugs after push at this > point.. lets make it even more polished for the final release.. still plenty > of little tweaks in my opinion but getting more eyes on by getting it pushed > is my opinion. >From now on, separate follow-up bugs here for required tweaks. As usual. > Arthur.. please don't backport this one ;P.. Correct. Arthur, please don't :-D Thanks everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 21:27:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 19:27:42 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 21:31:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 19:31:43 +0000 Subject: [Koha-bugs] [Bug 31747] New: Round corners in boxes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 Bug ID: 31747 Summary: Round corners in boxes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com After bug 30952, the 'news' boxes have round corners and even a shadow (that is maybe too thick). But other boxes like on the patron details, or the main admin page you have square corners. The style should be a little more consistent. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 21:32:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 19:32:26 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 141751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141751&action=edit Screenshot -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 21:32:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 19:32:57 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Depends on| |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 21:32:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 19:32:57 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31747 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 [Bug 31747] Round corners in boxes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 21:50:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 19:50:31 +0000 Subject: [Koha-bugs] [Bug 31748] New: Restore progress bar on record import Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31748 Bug ID: 31748 Summary: Restore progress bar on record import Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org We've got the progress bar for staging back, we now want it for managing staged records. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 21:50:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 19:50:47 +0000 Subject: [Koha-bugs] [Bug 31748] Restore progress bar on record import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31748 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31666 Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 [Bug 31666] Add job progress bar to stage-marc-import.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 21:50:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 19:50:47 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31748 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31748 [Bug 31748] Restore progress bar on record import -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 21:53:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 19:53:31 +0000 Subject: [Koha-bugs] [Bug 31749] New: Detail view broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31749 Bug ID: 31749 Summary: Detail view broken Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 21:53:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 19:53:54 +0000 Subject: [Koha-bugs] [Bug 31749] Detail view broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31749 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 141752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141752&action=edit Screenshot -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 21:54:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 19:54:16 +0000 Subject: [Koha-bugs] [Bug 31749] Detail view broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31749 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30952 Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 21:54:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 19:54:16 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31749 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31749 [Bug 31749] Detail view broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 22:13:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 20:13:38 +0000 Subject: [Koha-bugs] [Bug 31750] New: Need more padding in cataloguing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Bug ID: 31750 Summary: Need more padding in cataloguing Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The cataloguing form lacks some padding to match the top bar -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 22:13:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 20:13:43 +0000 Subject: [Koha-bugs] [Bug 31561] Background jobs stuck at "New" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31561 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P4 |P3 --- Comment #5 from Aleisha Amohia --- This is still an issue even with the release of 22.05.05. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 22:13:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 20:13:48 +0000 Subject: [Koha-bugs] [Bug 31750] Need more padding in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 22:13:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 20:13:48 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31750 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 [Bug 31750] Need more padding in cataloguing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 22:14:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 20:14:22 +0000 Subject: [Koha-bugs] [Bug 31750] Need more padding in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 141753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141753&action=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 22:16:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 20:16:32 +0000 Subject: [Koha-bugs] [Bug 25393] Create separate No Automatic Renewal Before rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 hebah at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 22:27:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 20:27:36 +0000 Subject: [Koha-bugs] [Bug 15428] Different timeout preference for opac and intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us --- Comment #6 from Rebecca Coert --- I think having a timeout difference for Staff vs. Others would be extremely useful. Our public services staff each have their own login and cycle through service desks every hour. Being able to ensure their account is logged out after a set amount of time would be helpful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 22:53:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 20:53:33 +0000 Subject: [Koha-bugs] [Bug 31741] Update coding guidelines with the replacement of jQueryUI Datepicker with flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31741 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |david at davidnind.com --- Comment #1 from David Nind --- *** This bug has been marked as a duplicate of bug 31645 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 22:53:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 20:53:33 +0000 Subject: [Koha-bugs] [Bug 31645] flatpickr - update coding guidelines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31645 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #2 from David Nind --- *** Bug 31741 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 22:58:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 20:58:01 +0000 Subject: [Koha-bugs] [Bug 31645] flatpickr - update coding guidelines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31645 --- Comment #3 from David Nind --- Discussed at the Development IRC meeting on 12 October 2022: https://meetings.koha-community.org/2022/development_irc_meeting_12_october_2022.2022-10-12-14.01.log.html#l-255 Message sent to mailing list asking for volunteers to update: https://lists.koha-community.org/pipermail/koha-devel/2022-October/047346.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 23:00:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 21:00:29 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 23:00:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 21:00:58 +0000 Subject: [Koha-bugs] [Bug 31749] Detail view broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31749 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 23:04:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 21:04:59 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 23:09:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 21:09:11 +0000 Subject: [Koha-bugs] [Bug 31746] Patron record saves when cardnumber required and value entered is whitespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31746 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 23:11:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 21:11:05 +0000 Subject: [Koha-bugs] [Bug 29739] Add a staff counterpart for OPACURLOpenInNewWindow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29739 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 23:40:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 21:40:57 +0000 Subject: [Koha-bugs] [Bug 31749] Detail view broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31749 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #2 from Lucas Gass --- It looks fine unless all cover image services are turned off. Then the display is broken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 23:45:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 21:45:03 +0000 Subject: [Koha-bugs] [Bug 31751] New: Breadcrumb style Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751 Bug ID: 31751 Summary: Breadcrumb style Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Personally, I prefer breadcrumbs to use the > rather than the /. In addition, I think they should be normal text rather than italics/emphasis. I think the size for this are OK - visible, but not intrusive. Some research on breadcrumbs from the Nielsen Norman Group: Breadcrumbs: 11 Design Guidelines for Desktop and Mobile. 23 December 2018. https://www.nngroup.com/articles/breadcrumbs/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 23:45:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 21:45:29 +0000 Subject: [Koha-bugs] [Bug 31751] Breadcrumb style In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 23:45:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 21:45:29 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31751 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751 [Bug 31751] Breadcrumb style -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 12 23:48:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 21:48:36 +0000 Subject: [Koha-bugs] [Bug 31751] Breadcrumb style In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 00:00:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 22:00:00 +0000 Subject: [Koha-bugs] [Bug 31749] Detail view broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31749 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 00:00:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 22:00:05 +0000 Subject: [Koha-bugs] [Bug 31749] Detail view broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31749 --- Comment #3 from Lucas Gass --- Created attachment 141754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141754&action=edit Bug 31749: Fix detail display when not display cover images To test: 1. Apply patch 2. Have none of the image services turned on: AmazonCoverImages LocalCoverImages IntranetCoce SyndeticsCovers 3. Look at the detail page, things should look right. 4. Turn on some of these image services, things should still look right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 00:00:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 22:00:18 +0000 Subject: [Koha-bugs] [Bug 31749] Detail view broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31749 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED Patch complexity|--- |Trivial patch Assignee|julian.maurice at biblibre.com |lucas at bywatersolutions.com Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 00:03:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 22:03:13 +0000 Subject: [Koha-bugs] [Bug 28543] Clicking on 'New record' will use default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28543 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/594 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 00:12:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 22:12:34 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |lucas at bywatersolutions.com Severity|enhancement |minor Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 00:12:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 22:12:59 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 00:13:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 22:13:03 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 --- Comment #2 from Lucas Gass --- Created attachment 141755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141755&action=edit Bug 31747: Give area-news box new staff design look To test: 1. Apply patch 2. Regenerate staff CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 3. Look at the #area-news element of the mainpage. 4. There should be no rounded corners and the box-shadow should be the same as seen elsewhere ( i.e. patron details page ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 00:15:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 22:15:49 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #23 from David Cook --- Are there test plans for the UIs? I'm keen to test this out (although might be worth saving my SO for the QA stage). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 00:27:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 22:27:34 +0000 Subject: [Koha-bugs] [Bug 31750] Need more padding in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #2 from Lucas Gass --- IMHO this just needs to not have rounded corners ( border-radius ) on the tab-content element. The padding looks nice as is and looks good when you scroll down and the toolbar stays fixed to the top of the screen. Although, that is just my opinion. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 00:44:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 22:44:39 +0000 Subject: [Koha-bugs] [Bug 31752] New: Alignment of labels in notices is wonky Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31752 Bug ID: 31752 Summary: Alignment of labels in notices is wonky Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Created attachment 141756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141756&action=edit Screenshot of problem The alignment of the labels in the notices tool is off. ( see attachment ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 00:44:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 22:44:56 +0000 Subject: [Koha-bugs] [Bug 31752] Alignment of labels in notices is wonky In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31752 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 00:44:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 22:44:56 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31752 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31752 [Bug 31752] Alignment of labels in notices is wonky -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 00:52:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 22:52:18 +0000 Subject: [Koha-bugs] [Bug 31753] New: Dialog boxes inside of modals don't seem wide enough Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 Bug ID: 31753 Summary: Dialog boxes inside of modals don't seem wide enough Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 30952 Created attachment 141757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141757&action=edit Screenshot of problem The dialog boxes inside of modals don't quite look right. They seem to lack the proper width. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 00:52:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 22:52:18 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31753 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 [Bug 31753] Dialog boxes inside of modals don't seem wide enough -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 00:57:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 22:57:28 +0000 Subject: [Koha-bugs] [Bug 31754] New: DataTable paginate_button make other elements move around when hovered Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Bug ID: 31754 Summary: DataTable paginate_button make other elements move around when hovered Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Depends on: 30952 Created attachment 141758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141758&action=edit Screenshot of problem If you bring up a dataTable, like when doing a patron search, and hover over the paginate_button's (first,previous,next,last) you'll notice the rest of the elements in the toolbar move a bit. ( search box, clear filter ) see attachment Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 00:57:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 22:57:28 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31754 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 [Bug 31754] DataTable paginate_button make other elements move around when hovered -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 01:06:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 23:06:17 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #28 from David Cook --- (In reply to Ere Maijala from comment #27) > Now to more practical stuff. The multiple endpoints idea works for me. I > don't think there's any other interoperable way if you need to have > different rules. You could also have several endpoints like > 'internal/oai.pl', 'opac/oai.pl' and 'test/oai.pl', no problem. From the > protocol point of view they'd just be separate providers. However, they > should also have separate OAI identifiers. Things could go really bad if a > harvester receives the same record from multiple endpoints. According to the OAI spec, OAI identifiers are only unique within their repository/0provider, but I don't think a lot of OAI harvesters adhere to the OAI spec in that regard... so that's a good point. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 01:14:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 23:14:55 +0000 Subject: [Koha-bugs] [Bug 31755] New: Store biblio OPAC visibility in biblio table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31755 Bug ID: 31755 Summary: Store biblio OPAC visibility in biblio table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org At the moment, you have to interrogate the MARCXML to determine if a record is suppressed using OpacSuppression, and you have to iterate through all of a bib's items to see if it's hidden/suppressed using OpacHiddenItems and OpacHiddenItemsHidesRecord. As Tomas said at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161#c21, it would make sense to have a "suppressed" field in the biblio table so that we can determine a biblio record's OPAC visibility using a simple SQL query. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 01:19:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 23:19:58 +0000 Subject: [Koha-bugs] [Bug 31755] Store biblio OPAC visibility in biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31755 --- Comment #1 from David Cook --- In theory, every bib record change would trigger an evaluation of whether or not the bib is "suppressed", and every item change should trigger an evaluation of whether or not that item is "hidden". There would also need to be an evaluation of whether or not the bib is suppressed if all its items are hidden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 01:41:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 23:41:18 +0000 Subject: [Koha-bugs] [Bug 30879] Add option to sort components by biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #35 from David Cook --- So I've got an update from Indexdata... It turns out that we could've just patched our Perl code to the following: 375 elsif ( $sort eq "local-number_asc" ) { 376 $sort_by .= "1=12,4=109 References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #36 from David Cook --- (In reply to Lucas Gass from comment #33) > Backported to 22.05.x for 22.05.06 I don't think that this has gone out yet, so we could actually still revert these changes too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 01:52:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 23:52:28 +0000 Subject: [Koha-bugs] [Bug 31756] New: Biblionumber not numerically sorting natively when using Zebra Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 Bug ID: 31756 Summary: Biblionumber not numerically sorting natively when using Zebra Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au When bug 30879 was pushed, we didn't know how to natively sort numbers, but we do now. This issue seeks to replace the workaround with the native implementation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 01:54:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Oct 2022 23:54:18 +0000 Subject: [Koha-bugs] [Bug 30879] Add option to sort components by biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #37 from David Cook --- (In reply to Katrin Fischer from comment #29) > Happy to add a motivational sign-off, but: > > I wonder how we can make sure this feature works correctly for updated > installations. > > 1) We should add a note to the release notes about this requiring to reindex. If we replace the workaround using bug 31756, we won't need to require a reindex! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 02:07:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 00:07:01 +0000 Subject: [Koha-bugs] [Bug 30879] Add option to sort components by biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #38 from David Cook --- (In reply to David Cook from comment #37) > (In reply to Katrin Fischer from comment #29) > > Happy to add a motivational sign-off, but: > > > > I wonder how we can make sure this feature works correctly for updated > > installations. > > > > 1) We should add a note to the release notes about this requiring to reindex. > > If we replace the workaround using bug 31756, we won't need to require a > reindex! Actually, it looks like that may just be true for MARC21. It looks like "Local-number:s" was added for UNIMARC, so they'll probably still need to re-index... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 02:07:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 00:07:10 +0000 Subject: [Koha-bugs] [Bug 31756] Biblionumber not numerically sorting natively when using Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 02:07:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 00:07:48 +0000 Subject: [Koha-bugs] [Bug 31756] Biblionumber not numerically sorting natively when using Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 02:07:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 00:07:52 +0000 Subject: [Koha-bugs] [Bug 31756] Biblionumber not numerically sorting natively when using Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 --- Comment #1 from David Cook --- Created attachment 141759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141759&action=edit Bug 31756: Use native Zebra numeric sort for biblionumber This patch uses native Zebra numeric sort for biblionumber to provide ascending and descending biblionumber sort in Koha. To test: 1. Apply patches 2. koha-plack --restart kohadev 3. Browse to: http://localhost:8081/cgi-bin/koha/catalogue/search.pl? idx=kw&q=a&sort_by=biblionumber_dsc&count=20 4. Confirm records sorted correctly 5. Browse to http://localhost:8081/cgi-bin/koha/catalogue/search.pl? idx=kw&q=a&sort_by=biblionumber_asc&count=20 6. Confirm records sorted correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 02:07:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 00:07:56 +0000 Subject: [Koha-bugs] [Bug 31756] Biblionumber not numerically sorting natively when using Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 --- Comment #2 from David Cook --- Created attachment 141760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141760&action=edit Bug 31756: Undo zeropad workaround for Local-Number:s for MARC21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 02:08:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 00:08:01 +0000 Subject: [Koha-bugs] [Bug 31756] Biblionumber not numerically sorting natively when using Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 --- Comment #3 from David Cook --- Created attachment 141761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141761&action=edit Bug 31756: Undo zeropad workaround for Local-Number:s for UNIMARC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 02:08:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 00:08:44 +0000 Subject: [Koha-bugs] [Bug 31756] Biblionumber not numerically sorting natively when using Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 --- Comment #4 from David Cook --- Actually, the test plan should be the same as bug 30879: To test: 1 - Apply patches 2 - copy etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl to /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl 3 - Restart all, reindex zebra 4 - Browse to: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=kw&q=a&sort_by=biblionumber_dsc&count=20 5 - Confirm records sorted correctly 6 - Browse to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=kw&q=a&sort_by=biblionumber_asc&count=20 7 - Confirm records sorted correctly And same again for UNIMARC... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 02:39:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 00:39:14 +0000 Subject: [Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 02:39:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 00:39:19 +0000 Subject: [Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #23 from Mason James --- Created attachment 141762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141762&action=edit Bug 17704: Fix OAI breakage when using HTTP::OAI 4.03+ bump version in cpanfile, and remove from debian/list-deps (no test plan) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 02:40:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 00:40:25 +0000 Subject: [Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #24 from Mason James --- (In reply to David Cook from comment #22) > We should probably do a patch for this at some point so that we don't have > to package the older HTTP::OAI modules. patch is tested as working for me using HTTP::OAI 4.11 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 02:42:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 00:42:04 +0000 Subject: [Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #25 from Mason James --- Created attachment 141763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141763&action=edit pic -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 03:55:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 01:55:45 +0000 Subject: [Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141762|0 |1 is obsolete| | --- Comment #26 from Mason James --- Created attachment 141764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141764&action=edit Bug 17704: Enable ->xslt method (must use HTTP::OAI >= 4.07) Signed-off-by: David Cook Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 03:55:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 01:55:50 +0000 Subject: [Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 --- Comment #27 from Mason James --- Created attachment 141765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141765&action=edit Bug 17704: Bump version in cpanfile -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 03:57:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 01:57:24 +0000 Subject: [Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107215|0 |1 is obsolete| | Attachment #107216|0 |1 is obsolete| | --- Comment #28 from Mason James --- Created attachment 141766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141766&action=edit Bug 17704: Adapt Koha::OAI::* to the new HTTP::OAI api This is my attempt to adapt the existing implementation to the new version of the HTTP::OAI lib. Currently 4.06 is released, but 4.07 should be used once released, as it contains the fix for the ->xslt method missing. Signed-off-by: David Cook Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 03:58:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 01:58:31 +0000 Subject: [Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 08:09:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 06:09:56 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #394 from Julian Maurice --- (In reply to Tomás Cohen Arazi from comment #392) > Pushed to master for 22.11. That's the first thing I read this morning, and it made my day :) Thanks to all people involved. I'm really glad that it will be in 22.11 ! (In reply to Tomás Cohen Arazi from comment #393) > From now on, separate follow-up bugs here for required tweaks. As usual. Please CC me on follow-up bugs and I'll do my best to fix them -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 08:23:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 06:23:14 +0000 Subject: [Koha-bugs] [Bug 31749] Detail view broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31749 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141754|0 |1 is obsolete| | --- Comment #4 from Julian Maurice --- Created attachment 141767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141767&action=edit Bug 31749: Fix detail display when not display cover images To test: 1. Apply patch 2. Have none of the image services turned on: AmazonCoverImages LocalCoverImages IntranetCoce SyndeticsCovers 3. Look at the detail page, things should look right. 4. Turn on some of these image services, things should still look right. Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 08:23:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 06:23:28 +0000 Subject: [Koha-bugs] [Bug 31749] Detail view broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31749 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 08:29:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 06:29:32 +0000 Subject: [Koha-bugs] [Bug 31743] Cannot change my notice language when EnhancedMessagingPreferencesOPAC is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 08:31:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 06:31:22 +0000 Subject: [Koha-bugs] [Bug 31743] Cannot change my notice language when EnhancedMessagingPreferencesOPAC is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 08:31:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 06:31:25 +0000 Subject: [Koha-bugs] [Bug 31743] Cannot change my notice language when EnhancedMessagingPreferencesOPAC is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743 --- Comment #1 from Marcel de Rooy --- Created attachment 141768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141768&action=edit Bug 31743: Change condition for messaging tab Note for QA: The code for SMSnumber is still made dependent on EnhancedMessagingPreferencesOPAC in order to not disturb current behavior. This fixes Enhanced on, EnhancedOPAC off; the case of Enhanced off is not considered here. Test plan: Enable EnhancedMessaging, disable EnhancedMessagingOPAC. Enable TranslateNotices. Check if you can only change notice language on OPAC. Enable EnhancedMessagingOPAC. Check if you change messaging prefs too. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 08:44:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 06:44:58 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #29 from Ere Maijala --- (In reply to David Cook from comment #28) > According to the OAI spec, OAI identifiers are only unique within their > repository/0provider, but I don't think a lot of OAI harvesters adhere to > the OAI spec in that regard... so that's a good point. I'll soften my stance a bit. I suppose it boils down to whether two endpoints are considered the same repository. It might also be enough to just document that one shouldn't harvest from multiple endpoints like they were the same repository. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 09:04:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 07:04:59 +0000 Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 --- Comment #11 from Martin Renvoize --- I lost track of this one, sorry.. I agree with the approach here, would you like me to have a look at the other cases Tomas? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 09:08:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 07:08:28 +0000 Subject: [Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 --- Comment #13 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #12) > Hit by this again at our most recent upgrade... > > If you want to use aqbasket in the title of the email without this patch you > can't. Martin, status is still FQA. And patch does not apply: Bug 28824 - Errant variable declaration in C4::Letters 123579 - Bug 28824: Unit test 123580 - Bug 28824: Fix for variable declaration scope Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 28824: Unit test Using index info to reconstruct a base tree... M t/db_dependent/Letters.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Letters.t CONFLICT (content): Merge conflict in t/db_dependent/Letters.t error: Failed to merge in the changes. Patch failed at 0001 Bug 28824: Unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 09:41:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 07:41:21 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #61 from Fridolin Somers --- Same for us french. We fixed manually after upgrade. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 10:38:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 08:38:44 +0000 Subject: [Koha-bugs] [Bug 31757] New: Add 'page-section' where it's missing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Bug ID: 31757 Summary: Add 'page-section' where it's missing Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I'm creating this one as a collector bug.. as Lucas pointed out on https://github.com/jajm/koha-staff-interface-redesign/issues/55 and as discussed in various other issues on the github for the new staff client feedback.. we need to implement the 'page-section' div containers consistently to ensure all pages match and proper contrasts appear around tables in particular. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 10:40:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 08:40:21 +0000 Subject: [Koha-bugs] [Bug 31758] New: Add 'page-section' to system preferences page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Bug ID: 31758 Summary: Add 'page-section' to system preferences page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We need the page-section divs adding to the system preferences page to ensure proper contrast for even/odd rows on the tables. See https://github.com/jajm/koha-staff-interface-redesign/issues/55 for discusion. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 10:40:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 08:40:42 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30952 Blocks| |31757 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 10:40:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 08:40:42 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 [Bug 31758] Add 'page-section' to system preferences page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 10:40:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 08:40:42 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 [Bug 31758] Add 'page-section' to system preferences page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 10:40:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 08:40:48 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 10:57:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 08:57:43 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #1 from Martin Renvoize --- Created attachment 141769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141769&action=edit Bug 31758: OPTION 1 - Add page-section to prefs-tab div This patch simply adds the new page-section class to the existing prefs-tab div encasing the whole tab content inside a 'card' display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 10:58:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 08:58:07 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #2 from Martin Renvoize --- Created attachment 141770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141770&action=edit Bug 31758: OPTION 2 - Add page-section div around subsections An alternative that puts adds a new page-section div around each preference subsection rather than around the whole tab section. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 10:58:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 08:58:30 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #3 from Martin Renvoize --- Needs some input.. calling Owen :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 10:58:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 08:58:44 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com, | |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:00:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:00:19 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #4 from Martin Renvoize --- Option 1 just works.. Option 2 splits the content up more and 'might' be nicer.. but needs a little refinement still if people like it.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:23:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:23:23 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Alias|client, refresh, Staff | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:39:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:39:33 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Björn Nylén changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjorn.nylen at ub.lu.se --- Comment #316 from Björn Nylén --- We're also using the Discrete calendar in our library since we went live with Koha 2018. (Thx for the thankless work by the way). It would be a valuable addition to the Koha in our opinion. >From our experiences it works very well and we've not experienced anything odd or any malfunctions. (Apart from some quirks in the admin page) Quite a large patch and and we're not sure we are using enough of Koha to be confident to say the *every* feature is on par with the defualt calendar. How to -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:40:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:40:41 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141362|0 |1 is obsolete| | --- Comment #24 from PTFS Europe Sandboxes --- Created attachment 141771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141771&action=edit Bug 31378: DB changes Signed-off-by: Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:40:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:40:46 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141363|0 |1 is obsolete| | --- Comment #25 from PTFS Europe Sandboxes --- Created attachment 141772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141772&action=edit Bug 31378: DBIC updates [DO NOT PUSH] Signed-off-by: Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:40:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:40:50 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141364|0 |1 is obsolete| | --- Comment #26 from PTFS Europe Sandboxes --- Created attachment 141773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141773&action=edit Bug 31378: Add dependencies Signed-off-by: Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:40:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:40:55 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141365|0 |1 is obsolete| | --- Comment #27 from PTFS Europe Sandboxes --- Created attachment 141774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141774&action=edit Bug 31378: Add Koha::Auth::Provider::Domain(s) class(es) Signed-off-by: Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:41:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:41:00 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141366|0 |1 is obsolete| | --- Comment #28 from PTFS Europe Sandboxes --- Created attachment 141775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141775&action=edit Bug 31378: Add Koha::Auth::Provider(s) class(es) Signed-off-by: Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:41:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:41:04 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- I think we should look to start reducing our specific css.. This seems a good case for that.. I'd add a 'page-section' class to the divs with 'area-news' id (Note "divs".. we should probably fix that whilst we're here and update the 'daily_quote' section to have it's own unique id. Then we can reduce the 'area-news' specific css to just 'color' as that's all that's not dealt with by 'page-section' already. Thoughts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:41:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:41:06 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141367|0 |1 is obsolete| | --- Comment #29 from PTFS Europe Sandboxes --- Created attachment 141776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141776&action=edit Bug 31378: Add Koha::Auth::Client* modules Signed-off-by: Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:41:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:41:10 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141368|0 |1 is obsolete| | --- Comment #30 from PTFS Europe Sandboxes --- Created attachment 141777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141777&action=edit Bug 31378: Add Auth mojo plugin Signed-off-by: Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:41:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:41:15 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141369|0 |1 is obsolete| | --- Comment #31 from PTFS Europe Sandboxes --- Created attachment 141778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141778&action=edit Bug 31378: Add API routes Signed-off-by: Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:41:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:41:21 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141370|0 |1 is obsolete| | --- Comment #32 from PTFS Europe Sandboxes --- Created attachment 141779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141779&action=edit Bug 31378: Add auth providers template plugin Signed-off-by: Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:41:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:41:26 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141371|0 |1 is obsolete| | --- Comment #33 from PTFS Europe Sandboxes --- Created attachment 141780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141780&action=edit Bug 31378: Add the API-based auth mechanism to C4::Auth::check_api_auth Signed-off-by: Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:41:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:41:31 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141372|0 |1 is obsolete| | --- Comment #34 from PTFS Europe Sandboxes --- Created attachment 141781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141781&action=edit Bug 31378: Add OPAC support for authentication providers Signed-off-by: Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:41:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:41:38 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141373|0 |1 is obsolete| | --- Comment #35 from PTFS Europe Sandboxes --- Created attachment 141782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141782&action=edit Bug 31378: Add STAFF support for authentication providers Signed-off-by: Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:41:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:41:43 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141374|0 |1 is obsolete| | --- Comment #36 from PTFS Europe Sandboxes --- Created attachment 141783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141783&action=edit Bug 31378: Add accessor methods for JSON attributes Signed-off-by: Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:41:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:41:48 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141375|0 |1 is obsolete| | --- Comment #37 from PTFS Europe Sandboxes --- Created attachment 141784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141784&action=edit Bug 31378: Add manage_authentication_providers permission Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:41:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:41:53 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141376|0 |1 is obsolete| | --- Comment #38 from PTFS Europe Sandboxes --- Created attachment 141785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141785&action=edit Bug 31378: Add 'parameter' parameter to Koha::Exceptions::MissingParameter Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:41:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:41:57 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141377|0 |1 is obsolete| | --- Comment #39 from PTFS Europe Sandboxes --- Created attachment 141786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141786&action=edit Bug 31378: Add authentication provider endpoints This patch adds routes for handling authentication providers to the REST API. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_providers.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:42:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:42:02 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141378|0 |1 is obsolete| | --- Comment #40 from PTFS Europe Sandboxes --- Created attachment 141787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141787&action=edit Bug 31378: Add an administration interface for authentication sources Signed-off-by: Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:42:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:42:08 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141514|0 |1 is obsolete| | --- Comment #41 from PTFS Europe Sandboxes --- Created attachment 141788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141788&action=edit Bug 31378: Use base URLs for redirect uri Signed-off-by: Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:46:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:46:42 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:52:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:52:04 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 --- Comment #4 from Martin Renvoize --- Created attachment 141789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141789&action=edit Bug 31747: Use page-section class, reduce CSS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:53:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:53:20 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 --- Comment #5 from Martin Renvoize --- Let me know what you think of my follow-up that tries to achieve the above... I'm really keen to reduce our CSS footprint.. instead of targetting lots of individual elements I want to start using shared classes more so we can really improve consistency accross the board. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:53:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:53:31 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 11:57:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 09:57:26 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141789|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 141790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141790&action=edit Bug 31747: Use page-section class, reduce CSS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 12:13:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 10:13:04 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #42 from Katrin Fischer --- Was not me, but the sandbox was created in my name. We'll fix sign-off lines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 12:32:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 10:32:59 +0000 Subject: [Koha-bugs] [Bug 31749] Detail view broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31749 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141767|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 141791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141791&action=edit Bug 31749: Fix detail display when not display cover images To test: 1. Apply patch 2. Have none of the image services turned on: AmazonCoverImages LocalCoverImages IntranetCoce SyndeticsCovers 3. Look at the detail page, things should look right. 4. Turn on some of these image services, things should still look right. Signed-off-by: Julian Maurice Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 12:33:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 10:33:52 +0000 Subject: [Koha-bugs] [Bug 31749] Detail view broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31749 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Fixes the bug as described.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 12:36:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 10:36:52 +0000 Subject: [Koha-bugs] [Bug 31759] New: Tabs vs Pills Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759 Bug ID: 31759 Summary: Tabs vs Pills Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We never completely came to a conclusion regarding pills vs tabs for the staff client refresh.. however I think we did come to the conclusion that they're not great as they are right now.. so I'm opening a new issue here to discus. https://github.com/jajm/koha-staff-interface-redesign/issues/17 starts the conversation and has screenshots. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 12:37:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 10:37:04 +0000 Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 12:37:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 10:37:04 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31759 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759 [Bug 31759] Tabs vs Pills -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 12:46:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 10:46:25 +0000 Subject: [Koha-bugs] [Bug 31760] New: Low constrast of some colors (WCAG) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31760 Bug ID: 31760 Summary: Low constrast of some colors (WCAG) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Collector bug for contrast issues introduced in bug 30952.. most were fixed, but a few were missed. See https://github.com/jajm/koha-staff-interface-redesign/issues/10 for the original report. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 12:46:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 10:46:33 +0000 Subject: [Koha-bugs] [Bug 31760] Low constrast of some colors (WCAG) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31760 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 12:46:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 10:46:33 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31760 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31760 [Bug 31760] Low constrast of some colors (WCAG) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 12:46:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 10:46:41 +0000 Subject: [Koha-bugs] [Bug 31760] Low constrast of some colors (WCAG) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31760 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 12:50:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 10:50:18 +0000 Subject: [Koha-bugs] [Bug 31760] Low constrast of some colors (WCAG) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31760 --- Comment #1 from Martin Renvoize --- Created attachment 141792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141792&action=edit Bug 31760: Fix contrast of 'separator' This patch increases the contrast of the separator pipe visible in the staff client upper right corner of the header bar. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 12:52:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 10:52:54 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #5 from Owen Leonard --- Created attachment 141793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141793&action=edit Bug 31758: OPTION 2 (follow-up) Add padding between adjacent sections -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 12:53:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 10:53:40 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master --- Comment #6 from Owen Leonard --- My preference is option 2, with some padding between the sections. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:04:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:04:41 +0000 Subject: [Koha-bugs] [Bug 31761] New: Toolbar clarity and consistency Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31761 Bug ID: 31761 Summary: Toolbar clarity and consistency Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Our toolbars are widely inconsistent across the staff client and with bug 30952 they became much less obvious as a 'call to action' to the end user. See https://github.com/jajm/koha-staff-interface-redesign/issues/26 for some discussion around this. I think we can still improve here.. Consistency wise and also overall contrast/clarity improvements. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:04:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:04:48 +0000 Subject: [Koha-bugs] [Bug 31761] Toolbar clarity and consistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31761 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:04:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:04:48 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31761 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31761 [Bug 31761] Toolbar clarity and consistency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:08:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:08:02 +0000 Subject: [Koha-bugs] [Bug 31761] Toolbar clarity and consistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31761 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:17:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:17:02 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #7 from Martin Renvoize --- Excellent follow-up Owen, thanks.. I think I prefer option 2 too... However, what do you think to what it does to the look of search results when you search for a system preference?.. It's not terrible, but also doesn't look quite right to me yet either... contemplating. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:24:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:24:05 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #8 from Martin Renvoize --- Also... if I do a search for a preference, say 'UserJS'.. if I then click through using the 'View all X preferences' link on the right of the section.. I end up with a larger top margin on the section I'm looking at.. seems to come from custom styling on 'h3:target'.. not sure how/what it was/is trying to achieve and whether we're safe to remove it now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:25:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:25:31 +0000 Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Hanna Dehlin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hanna.dehlin at hkr.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:31:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:31:46 +0000 Subject: [Koha-bugs] [Bug 31762] New: Flat vs 3D or Mixed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31762 Bug ID: 31762 Summary: Flat vs 3D or Mixed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We now have a mix of 'Flat' and '3D' elements in the staff client. Our re-usable 'page-section' class adds a 'card' like feel to sections of the page which is '3d' style, drop shadows and all.. but out topnav, sidenav and toolbars are all 'flat'.. the mix feels slighlty odd.. should we perhaps drop the drop shadow on our page-sections ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:31:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:31:59 +0000 Subject: [Koha-bugs] [Bug 31762] Flat vs 3D or Mixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31762 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:32:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:32:05 +0000 Subject: [Koha-bugs] [Bug 31762] Flat vs 3D or Mixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31762 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:32:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:32:24 +0000 Subject: [Koha-bugs] [Bug 31762] Flat vs 3D or Mixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31762 --- Comment #1 from Martin Renvoize --- See https://github.com/jajm/koha-staff-interface-redesign/issues/48 for prior discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:35:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:35:18 +0000 Subject: [Koha-bugs] [Bug 31762] Flat vs 3D or Mixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31762 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31747 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 [Bug 31747] Round corners in boxes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:35:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:35:18 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31762 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31762 [Bug 31762] Flat vs 3D or Mixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:40:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:40:28 +0000 Subject: [Koha-bugs] [Bug 31762] Flat vs 3D or Mixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31762 --- Comment #2 from Martin Renvoize --- Created attachment 141794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141794&action=edit Bug 31762: Flatten page-section This patch removes the box-shadow from our 'card' mixin and thus makes page-section and other similar content area blocks look flat -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:40:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:40:46 +0000 Subject: [Koha-bugs] [Bug 31762] Flat vs 3D or Mixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31762 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:42:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:42:09 +0000 Subject: [Koha-bugs] [Bug 31762] Flat vs 3D or Mixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31762 --- Comment #3 from Martin Renvoize --- This doesn't strictly require bug 31747.. but it does make it a lot nicer to test as a whole. Test plan 1. Apply patch 2. yarn build the css 3. Compare main page (with news and user blocks added) 4. Compare borrower details page 5. Compare biblio details page Discus. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:42:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:42:21 +0000 Subject: [Koha-bugs] [Bug 31762] Flat vs 3D or Mixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31762 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:44:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:44:34 +0000 Subject: [Koha-bugs] [Bug 23548] AQ field required in checkin response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23548 --- Comment #11 from Stefan Berndtsson --- (In reply to Martin Renvoize from comment #9) > I'm convinced, and looked up the specs to confirm. Now we just need a unit > test to protect us from later regressions ;-). > > Are you able to submit that, of should I add it to my list to try and get to > soon? I'm unable to run the existing tests for two reasons. 1. I get: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_koha`.`checkout_renewals`, CONSTRAINT `renewals_renewer_id` FOREIGN KEY (`renewer_id`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE) 2. test_checkout_v2 assumes that circulation rules are set in some specific way in the database and does not mock those values in the test. (This may apply to other tests as well). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:51:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:51:47 +0000 Subject: [Koha-bugs] [Bug 31735] Circulation optimizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141603|0 |1 is obsolete| | --- Comment #9 from David Gustafsson --- Created attachment 141795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141795&action=edit Bug 31735: Avoid re-fetcing objects from database by passing them directly instead of ids to various subroutines To test: 1) Run the following test and make sure all pass: t/db_dependent/api/v1/biblios.t t/db_dependent/api/v1/checkouts.t t/db_dependent/api/v1/return_claims.t t/db_dependent/Circulation/CalcDateDue.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t t/db_dependent/Circulation/dateexpiry.t t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/Circulation/IsItemIssued.t t/db_dependent/Circulation/issue.t t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Circulation/maxsuspensiondays.t t/db_dependent/Circulation/ReturnClaims.t t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/SwitchOnSiteCheckouts.t t/db_dependent/Circulation.t t/db_dependent/Circulation/TooMany.t t/db_dependent/Circulation/transferbook.t t/db_dependent/DecreaseLoanHighHolds.t t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t t/db_dependent/HoldsQueue.t t/db_dependent/Holds/RevertWaitingStatus.t t/db_dependent/Illrequests.t t/db_dependent/ILSDI_Services.t t/db_dependent/Items.t t/db_dependent/Koha/Account/Line.t t/db_dependent/Koha/Acquisition/Order.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Holds.t t/db_dependent/Koha/Items.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Object.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Pseudonymization.t t/db_dependent/Koha/Recalls.t t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/IssueSlip.t t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_PrevCheckout.t t/db_dependent/Reserves/GetReserveFee.t t/db_dependent/Reserves.t t/db_dependent/rollingloans.t t/db_dependent/selenium/regressions.t t/db_dependent/SIP/ILS.t 2) Performe one or more checkouts for a patron, making sure that the circulation rules allows for renewals (for example by setting an earlier due-date). 3) Log in as this patron in OPAC and make sure the list of checkouts is displayed correctly, and that renewing an issue still works. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:51:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:51:52 +0000 Subject: [Koha-bugs] [Bug 31735] Circulation optimizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141604|0 |1 is obsolete| | --- Comment #10 from David Gustafsson --- Created attachment 141796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141796&action=edit Bug 31735: Avoid unesssary unblessing of objects -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:51:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:51:56 +0000 Subject: [Koha-bugs] [Bug 31735] Circulation optimizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141605|0 |1 is obsolete| | --- Comment #11 from David Gustafsson --- Created attachment 141797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141797&action=edit Bug 31735: Add caching for relatively expensive patron attributes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:52:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:52:01 +0000 Subject: [Koha-bugs] [Bug 31735] Circulation optimizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141606|0 |1 is obsolete| | --- Comment #12 from David Gustafsson --- Created attachment 141798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141798&action=edit Bug 31735: Remove Koha::Config::SysPref->find since bypasses cache get_yaml_pref_hash also allows invalid YAML and only parses a limited subset so remove this method to avoid future issues. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:52:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:52:06 +0000 Subject: [Koha-bugs] [Bug 31735] Circulation optimizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141607|0 |1 is obsolete| | --- Comment #13 from David Gustafsson --- Created attachment 141799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141799&action=edit Bug 31735: Match rules on effective item type instead of itype -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:52:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:52:11 +0000 Subject: [Koha-bugs] [Bug 31735] Circulation optimizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141608|0 |1 is obsolete| | --- Comment #14 from David Gustafsson --- Created attachment 141800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141800&action=edit Bug 31735: Optimize OPAC checkouts view -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:57:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:57:14 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141771|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize --- Created attachment 141801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141801&action=edit Bug 31378: DB changes Signed-off-by: Lukasz Koszyk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:57:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:57:21 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141772|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize --- Created attachment 141802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141802&action=edit Bug 31378: DBIC updates [DO NOT PUSH] Signed-off-by: Lukasz Koszyk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:57:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:57:27 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141773|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize --- Created attachment 141803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141803&action=edit Bug 31378: Add dependencies Signed-off-by: Lukasz Koszyk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:57:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:57:37 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141774|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize --- Created attachment 141804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141804&action=edit Bug 31378: Add Koha::Auth::Provider::Domain(s) class(es) Signed-off-by: Lukasz Koszyk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:57:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:57:43 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141775|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize --- Created attachment 141805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141805&action=edit Bug 31378: Add Koha::Auth::Provider(s) class(es) Signed-off-by: Lukasz Koszyk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:57:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:57:49 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141776|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize --- Created attachment 141806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141806&action=edit Bug 31378: Add Koha::Auth::Client* modules Signed-off-by: Lukasz Koszyk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:57:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:57:55 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141777|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize --- Created attachment 141807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141807&action=edit Bug 31378: Add Auth mojo plugin Signed-off-by: Lukasz Koszyk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:58:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:58:01 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141778|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize --- Created attachment 141808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141808&action=edit Bug 31378: Add API routes Signed-off-by: Lukasz Koszyk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:58:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:58:07 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141779|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize --- Created attachment 141809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141809&action=edit Bug 31378: Add auth providers template plugin Signed-off-by: Lukasz Koszyk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:58:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:58:13 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141780|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize --- Created attachment 141810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141810&action=edit Bug 31378: Add the API-based auth mechanism to C4::Auth::check_api_auth Signed-off-by: Lukasz Koszyk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:58:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:58:19 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141781|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize --- Created attachment 141811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141811&action=edit Bug 31378: Add OPAC support for authentication providers Signed-off-by: Lukasz Koszyk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:58:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:58:25 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141782|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize --- Created attachment 141812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141812&action=edit Bug 31378: Add STAFF support for authentication providers Signed-off-by: Lukasz Koszyk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:58:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:58:31 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141783|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize --- Created attachment 141813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141813&action=edit Bug 31378: Add accessor methods for JSON attributes Signed-off-by: Lukasz Koszyk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:58:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:58:37 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141784|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize --- Created attachment 141814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141814&action=edit Bug 31378: Add manage_authentication_providers permission Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lukasz Koszyk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:58:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:58:43 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141785|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize --- Created attachment 141815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141815&action=edit Bug 31378: Add 'parameter' parameter to Koha::Exceptions::MissingParameter Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lukasz Koszyk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:58:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:58:50 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141786|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize --- Created attachment 141816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141816&action=edit Bug 31378: Add authentication provider endpoints This patch adds routes for handling authentication providers to the REST API. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_providers.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Lukasz Koszyk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:58:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:58:56 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141787|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize --- Created attachment 141817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141817&action=edit Bug 31378: Add an administration interface for authentication sources Signed-off-by: Lukasz Koszyk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:59:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:59:02 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141788|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize --- Created attachment 141818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141818&action=edit Bug 31378: Use base URLs for redirect uri Signed-off-by: Lukasz Koszyk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 13:59:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 11:59:49 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #61 from Martin Renvoize --- Just fixing up signoff lines.. I think David offered to QA this so I'll set him as assigned for it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:00:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:00:03 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |dcook at prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:03:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:03:04 +0000 Subject: [Koha-bugs] [Bug 26995] Drop column relationship from borrower tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26995 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #26 from Marcel de Rooy --- NewVersion( $DBversion, 26995, "[SKIP] Drop column relationship from borrower tables [not executed]"); Printing this made me wonder what happened ;) Print nothing, no concerns.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:10:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:10:53 +0000 Subject: [Koha-bugs] [Bug 31763] New: Add 'page-section' to patron lists page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 Bug ID: 31763 Summary: Add 'page-section' to patron lists page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, lucas at bywatersolutions.com, oleonard at myacpl.org, testopia at bugs.koha-community.org Depends on: 30952 Blocks: 31757 We need the page-section div adding to patron lists page to ensure proper contrast for even/odd rows on the tables. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:10:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:10:53 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31763 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 [Bug 31763] Add 'page-section' to patron lists page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:10:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:10:53 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31763 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 [Bug 31763] Add 'page-section' to patron lists page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:11:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:11:53 +0000 Subject: [Koha-bugs] [Bug 31764] New: Add 'page-section' to patron clubs page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31764 Bug ID: 31764 Summary: Add 'page-section' to patron clubs page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, koha-bugs at lists.koha-community.org, lucas at bywatersolutions.com, oleonard at myacpl.org, testopia at bugs.koha-community.org Depends on: 30952 Blocks: 31757 We need the page-section divs adding to patron clubs page to ensure proper contrast for even/odd rows on the tables. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:11:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:11:53 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31764 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31764 [Bug 31764] Add 'page-section' to patron clubs page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:11:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:11:53 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31764 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31764 [Bug 31764] Add 'page-section' to patron clubs page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:14:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:14:34 +0000 Subject: [Koha-bugs] [Bug 31765] New: Add 'page-section' to import patrons page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31765 Bug ID: 31765 Summary: Add 'page-section' to import patrons page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, koha-bugs at lists.koha-community.org, lucas at bywatersolutions.com, oleonard at myacpl.org, testopia at bugs.koha-community.org Depends on: 30952 Blocks: 31757 I think the 'Notes' section on the import patrons page needs either page-section or a similar, but different background, class adding to distinguish the notes as 'info only' Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:14:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:14:34 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31765 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31765 [Bug 31765] Add 'page-section' to import patrons page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:14:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:14:34 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31765 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31765 [Bug 31765] Add 'page-section' to import patrons page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:16:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:16:00 +0000 Subject: [Koha-bugs] [Bug 31766] New: Add 'page-section' to notices and slips page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766 Bug ID: 31766 Summary: Add 'page-section' to notices and slips page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, koha-bugs at lists.koha-community.org, lucas at bywatersolutions.com, oleonard at myacpl.org, testopia at bugs.koha-community.org Depends on: 30952 Blocks: 31757 We need the page-section div adding to the notices and slips page to ensure proper contrast for even/odd rows on the tables. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:16:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:16:00 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31766 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766 [Bug 31766] Add 'page-section' to notices and slips page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:16:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:16:00 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31766 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766 [Bug 31766] Add 'page-section' to notices and slips page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:21:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:21:19 +0000 Subject: [Koha-bugs] [Bug 31767] New: Add 'page-section' to tags page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31767 Bug ID: 31767 Summary: Add 'page-section' to tags page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, koha-bugs at lists.koha-community.org, lucas at bywatersolutions.com, oleonard at myacpl.org, testopia at bugs.koha-community.org Depends on: 30952 Blocks: 31757 We need the page-section div adding to the tags page to ensure proper contrast for even/odd rows on the tables. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:21:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:21:19 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31767 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31767 [Bug 31767] Add 'page-section' to tags page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:21:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:21:19 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31767 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31767 [Bug 31767] Add 'page-section' to tags page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:22:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:22:46 +0000 Subject: [Koha-bugs] [Bug 31768] New: Tags is a 'Tool' but doesn't include the tools nav sidebar Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31768 Bug ID: 31768 Summary: Tags is a 'Tool' but doesn't include the tools nav sidebar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We should improve consistency by adding the tools sidebar navigation to the Tags page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:22:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:22:56 +0000 Subject: [Koha-bugs] [Bug 31768] Tags is a 'Tool' but doesn't include the tools nav sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31768 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:22:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:22:56 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31768 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31768 [Bug 31768] Tags is a 'Tool' but doesn't include the tools nav sidebar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:23:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:23:17 +0000 Subject: [Koha-bugs] [Bug 31768] Tags is a 'Tool' but doesn't include the tools nav sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31768 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |isobel.graham09 at gmail.com, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:25:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:25:40 +0000 Subject: [Koha-bugs] [Bug 31769] New: We need a clear guideline regarding how to display 'filters' and 'sidebar nav' at the same time Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31769 Bug ID: 31769 Summary: We need a clear guideline regarding how to display 'filters' and 'sidebar nav' at the same time Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We really should consistently use the left sidebar for module navigation.. but this raises the question of what to do with the 'filters' option some pages use that area for.. we should come up with a solution that allows for both displays in a coherant manner. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:26:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:26:21 +0000 Subject: [Koha-bugs] [Bug 31769] We need a clear guideline regarding how to display 'filters' and 'sidebar nav' at the same time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31769 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31768 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:26:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:26:21 +0000 Subject: [Koha-bugs] [Bug 31768] Tags is a 'Tool' but doesn't include the tools nav sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31768 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31769 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:27:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:27:53 +0000 Subject: [Koha-bugs] [Bug 30403] Update notforloan status also on check out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #7 from Victor Grousset/tuxayo --- Hi, they tested it and only changed the status. I sent a message with how to signoff the patches via the sandboxes. So it should be in order shortly and switched to signed-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:30:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:30:04 +0000 Subject: [Koha-bugs] [Bug 31770] New: Add 'page-section' to rotating collections page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31770 Bug ID: 31770 Summary: Add 'page-section' to rotating collections page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, koha-bugs at lists.koha-community.org, lucas at bywatersolutions.com, oleonard at myacpl.org, testopia at bugs.koha-community.org Depends on: 30952 Blocks: 31757 We need the page-section div adding to the rotating collections page to ensure proper contrast for even/odd rows on the tables. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:30:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:30:04 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31770 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31770 [Bug 31770] Add 'page-section' to rotating collections page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:30:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:30:04 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31770 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31770 [Bug 31770] Add 'page-section' to rotating collections page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:30:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:30:57 +0000 Subject: [Koha-bugs] [Bug 31771] New: Add 'page-section' to stock rotation pages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31771 Bug ID: 31771 Summary: Add 'page-section' to stock rotation pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, koha-bugs at lists.koha-community.org, lucas at bywatersolutions.com, oleonard at myacpl.org, testopia at bugs.koha-community.org Depends on: 30952 Blocks: 31757 We need the page-section div adding to the stock rotation pages to ensure proper contrast for even/odd rows on the tables. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:30:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:30:57 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31771 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31771 [Bug 31771] Add 'page-section' to stock rotation pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:30:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:30:57 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31771 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31771 [Bug 31771] Add 'page-section' to stock rotation pages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:32:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:32:48 +0000 Subject: [Koha-bugs] [Bug 31772] New: Some stock rotation pages could be converted to modals Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31772 Bug ID: 31772 Summary: Some stock rotation pages could be converted to modals Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The stock rotation tool contains a number of simple forms that are currently full pages.. they could be migrated to modals on the main stock rotation page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:33:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:33:40 +0000 Subject: [Koha-bugs] [Bug 31773] New: Add 'page-section' to marc modification templates pages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 Bug ID: 31773 Summary: Add 'page-section' to marc modification templates pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, koha-bugs at lists.koha-community.org, lucas at bywatersolutions.com, oleonard at myacpl.org, testopia at bugs.koha-community.org Depends on: 30952 Blocks: 31757 We need the page-section div adding to the marc modification template page to ensure proper contrast for even/odd rows on the tables. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:33:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:33:40 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31773 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 [Bug 31773] Add 'page-section' to marc modification templates pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:33:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:33:40 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31773 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 [Bug 31773] Add 'page-section' to marc modification templates pages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:35:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:35:03 +0000 Subject: [Koha-bugs] [Bug 31774] New: Add 'page-section' to Manage staged MARC records page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31774 Bug ID: 31774 Summary: Add 'page-section' to Manage staged MARC records page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, koha-bugs at lists.koha-community.org, lucas at bywatersolutions.com, oleonard at myacpl.org, testopia at bugs.koha-community.org Depends on: 30952 Blocks: 31757 We need the page-section div adding to Manage staged MARC records page to ensure proper contrast for even/odd rows on the tables. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:35:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:35:03 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31774 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31774 [Bug 31774] Add 'page-section' to Manage staged MARC records page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:35:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:35:03 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31774 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31774 [Bug 31774] Add 'page-section' to Manage staged MARC records page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:52:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:52:45 +0000 Subject: [Koha-bugs] [Bug 31775] New: Show opac_info of single library Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Bug ID: 31775 Summary: Show opac_info of single library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org When there is only one library, the library list is skipped, but since opac-main does not pass a branch code, you won't see branch info. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:52:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:52:52 +0000 Subject: [Koha-bugs] [Bug 31775] Show opac_info of single library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:53:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:53:03 +0000 Subject: [Koha-bugs] [Bug 31775] Show opac_info of single library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:53:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:53:03 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31775 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 [Bug 31775] Show opac_info of single library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:53:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:53:38 +0000 Subject: [Koha-bugs] [Bug 31775] Show opac_info of single library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:55:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:55:19 +0000 Subject: [Koha-bugs] [Bug 31735] Circulation optimizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141798|0 |1 is obsolete| | --- Comment #15 from David Gustafsson --- Created attachment 141819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141819&action=edit Bug 31735: Remove Koha::Config::SysPref->find since bypasses cache get_yaml_pref_hash also allows invalid YAML and only parses a limited subset so remove this method to avoid future issues. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:55:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:55:24 +0000 Subject: [Koha-bugs] [Bug 31735] Circulation optimizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141799|0 |1 is obsolete| | --- Comment #16 from David Gustafsson --- Created attachment 141820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141820&action=edit Bug 31735: Match rules on effective item type instead of itype -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 14:55:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 12:55:29 +0000 Subject: [Koha-bugs] [Bug 31735] Circulation optimizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141800|0 |1 is obsolete| | --- Comment #17 from David Gustafsson --- Created attachment 141821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141821&action=edit Bug 31735: Optimize OPAC checkouts view -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 15:23:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 13:23:12 +0000 Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #10 from David Gustafsson --- Created attachment 141822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141822&action=edit Bug 29145: Fix conditions for patron debarring overdues -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 15:30:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 13:30:24 +0000 Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #11 from David Gustafsson --- (In reply to Andrew Fuerste-Henry from comment #9) > I went through the test plan I posted above, but hit an issue at step 14. I > have a patron with two items both 2 days overdue. My overdue notice triggers > generate a notice and a restriction at 2 days overdue. When I run the > overdues cron, the notice and restriction generate as expected. I have > AutoRemoveOverduesRestrictions set to when_no_overdue_causing_debarment. My > restriction gets removed when I check in the first of the two items. This is > incorrect; I should have to check in both items for the restriction to be > removed. Hi! Thanks for the feedback and the test plan. Without it would not have discovered the edge-case where overdue items should trigger debarments when are delayed the same number of days that would trigger debarment. Have also updated the tests to reflect your test plan and result in the same error with the previous code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 15:33:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 13:33:27 +0000 Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141822|0 |1 is obsolete| | --- Comment #12 from David Gustafsson --- Created attachment 141823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141823&action=edit Bug 29145: Fix conditions for patron debarring overdues -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 16:00:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 14:00:55 +0000 Subject: [Koha-bugs] [Bug 31737] Undef warnings around unseen_renewals_allowed in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31737 Slava Shishkin changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29012 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 16:00:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 14:00:55 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Slava Shishkin changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31737 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31737 [Bug 31737] Undef warnings around unseen_renewals_allowed in smart-rules.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 16:21:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 14:21:43 +0000 Subject: [Koha-bugs] [Bug 31775] Show opac_info of single library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 16:21:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 14:21:46 +0000 Subject: [Koha-bugs] [Bug 31775] Show opac_info of single library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 --- Comment #1 from Marcel de Rooy --- Created attachment 141824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141824&action=edit Bug 31775: Show single library Test plan: Check both cases: one library (public accessible) and more libraries (public accessible). In the latter case click on one of these libraries too. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 16:21:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 14:21:50 +0000 Subject: [Koha-bugs] [Bug 31775] Show opac_info of single library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 --- Comment #2 from Marcel de Rooy --- Created attachment 141825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141825&action=edit Bug 31775: Template cleanup Removing unused parts. Test plan: See first test plan. Confirm that it still works. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 16:26:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 14:26:32 +0000 Subject: [Koha-bugs] [Bug 29554] neworderempty.pl may create records with biblioitems.itemtype NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 16:26:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 14:26:35 +0000 Subject: [Koha-bugs] [Bug 29554] neworderempty.pl may create records with biblioitems.itemtype NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554 --- Comment #18 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 16:26:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 14:26:37 +0000 Subject: [Koha-bugs] [Bug 31749] Detail view broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31749 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 16:26:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 14:26:40 +0000 Subject: [Koha-bugs] [Bug 31749] Detail view broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31749 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 16:37:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 14:37:09 +0000 Subject: [Koha-bugs] [Bug 31776] New: Typo in cleanup_database.pl cron's help/usage Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31776 Bug ID: 31776 Summary: Typo in cleanup_database.pl cron's help/usage Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: stalkernoid at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 16:38:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 14:38:52 +0000 Subject: [Koha-bugs] [Bug 31776] Typo in cleanup_database.pl cron's help/usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31776 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 16:38:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 14:38:56 +0000 Subject: [Koha-bugs] [Bug 31776] Typo in cleanup_database.pl cron's help/usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31776 --- Comment #1 from Peter Vashchuk --- Created attachment 141826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141826&action=edit Bug 31776: Fix a typo in cleanup_database.pl cronjob's help/usage cleanup_database.pl cronjob has a typo in it's usage/help: "preserve-logs" option should be "preserve-log" as it is everywhere in the code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 16:45:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 14:45:56 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 16:54:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 14:54:03 +0000 Subject: [Koha-bugs] [Bug 30909] Regression, Permanent shelving location is always updated when editing location VIA ADDITEM.PL if both are mapped to MARC fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |victor at tuxayo.net --- Comment #21 from Victor Grousset/tuxayo --- Missing dependencies for 21.05.x, it shouldn't be affected, no backport. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 16:54:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 14:54:04 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 Bug 31187 depends on bug 30909, which changed state. Bug 30909 Summary: Regression, Permanent shelving location is always updated when editing location VIA ADDITEM.PL if both are mapped to MARC fields https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 17:07:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 15:07:59 +0000 Subject: [Koha-bugs] [Bug 31455] Batch modification tool orders found items by itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31455 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #10 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, note: mark resolved when the issue with 21.11 missing a patch is resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 17:08:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 15:08:18 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #9 from Lucas Gass --- (In reply to Martin Renvoize from comment #7) > Excellent follow-up Owen, thanks.. I think I prefer option 2 too... > > However, what do you think to what it does to the look of search results > when you search for a system preference?.. It's not terrible, but also > doesn't look quite right to me yet either... contemplating. I also prefer option #2. When you search for system preferences and return more than 1 in a single category they look a bit "smushed" together. If there was just a tiny margin between the two I think it looks more organized. IMHO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 17:10:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 15:10:31 +0000 Subject: [Koha-bugs] [Bug 31499] Add libhttp-tiny-perl 0.076 dependency for ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31499 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #15 from Victor Grousset/tuxayo --- Not backporting to 21.05.x then. Marking resolved, nothing to document. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 17:10:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 15:10:32 +0000 Subject: [Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 Bug 25439 depends on bug 31499, which changed state. Bug 31499 Summary: Add libhttp-tiny-perl 0.076 dependency for ES7 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31499 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 17:11:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 15:11:08 +0000 Subject: [Koha-bugs] [Bug 30976] Cover images for biblio should be displayed first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #12 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 17:12:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 15:12:20 +0000 Subject: [Koha-bugs] [Bug 30797] Subfields linked to the dateaccessioned.pl value builder on addbiblio.pl throw a JS error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30797 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #10 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 17:19:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 15:19:52 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #31 from Victor Grousset/tuxayo --- > Please create a new blocker bug, as this has already been released! This hasn't been released. 22.05.06 is due for this month. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 17:22:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 15:22:28 +0000 Subject: [Koha-bugs] [Bug 31777] New: Allow for scheduling of holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31777 Bug ID: 31777 Summary: Allow for scheduling of holds Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We have recently had libraries asking for the ability to "schedule" a hold. These scenarios are things that are not really suited for suspension or future holds functions. For instance, a faculty member needs a DVD for use in a class on a specific day and staff would like to enter a hold for that. Another use scenario is for book clubs - I'd like to reserve copies for my club next month etc. Again, this is something asked for by libraries, but I'm not quite sure how it would work, just passing along the suggestion. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 17:23:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 15:23:07 +0000 Subject: [Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #13 from Victor Grousset/tuxayo --- bug 29012 hasn't been released. It's in the 22.05 and 21.11 branches but not released yet. 22.05 and 21.11 rmaints got and email about reverting 29012 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 17:23:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 15:23:08 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #32 from Victor Grousset/tuxayo --- 22.05 and 21.11 rmaints got and email about reverting this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 17:23:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 15:23:36 +0000 Subject: [Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 --- Comment #14 from Victor Grousset/tuxayo --- > bug 29012 hasn't been released So I don't know if that changes the strategy for this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 17:30:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 15:30:24 +0000 Subject: [Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766 --- Comment #1 from Lucas Gass --- Created attachment 141827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141827&action=edit page-section class directly on the table -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 17:30:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 15:30:34 +0000 Subject: [Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 --- Comment #15 from Nick Clemens --- (In reply to Victor Grousset/tuxayo from comment #14) > > bug 29012 hasn't been released > > So I don't know if that changes the strategy for this bug. It means we don't need to provide the cleanup patch, but should simply confirm the amended update patches prevent any problems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 17:31:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 15:31:40 +0000 Subject: [Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766 --- Comment #2 from Lucas Gass --- Created attachment 141828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141828&action=edit page-section class on wrapper around table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 17:31:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 15:31:40 +0000 Subject: [Koha-bugs] [Bug 31251] "Clear" patron attribute link does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31251 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #7 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 17:37:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 15:37:01 +0000 Subject: [Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766 --- Comment #3 from Lucas Gass --- I started to look at this and wasn't sure how to proceed. I added the page-section class directly to the table ( see attached ) Then I added the page-section class as a wrapper around the table. ( see attached ) When we use a wrapper I like that the dataTables tools are part of the "page-section", making it obvious the tools go with the table. However, when page-section is applied directly to the table I like the look of the table header's better. I don't like how that table header's just run right into the page-section in the 2nd example. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 17:52:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 15:52:33 +0000 Subject: [Koha-bugs] [Bug 28707] Missing strings in translation of sample data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28707 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 17:56:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 15:56:04 +0000 Subject: [Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #12 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 17:57:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 15:57:20 +0000 Subject: [Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766 --- Comment #4 from Lucas Gass --- Created attachment 141829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141829&action=edit Bug 31766: Add page-section wrapper to notice table To test: 1. Apply patch 2. Look at the noitce page and notice how the table, and it's tools, now are wrapped with the page-section element. 3. Is it better than it was before? Feel free to osboslete these patch and replace it with your own. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 17:57:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 15:57:49 +0000 Subject: [Koha-bugs] [Bug 30028] Patron message delete confirmation untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to stable |RESOLVED --- Comment #28 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 17:58:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 15:58:45 +0000 Subject: [Koha-bugs] [Bug 30468] koha-mysql does not honor Koha's timezone setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30468 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #13 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:00:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:00:58 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141769|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:02:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:02:07 +0000 Subject: [Koha-bugs] [Bug 30984] Action logs should log the cronjob script name that generated the given log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30984 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #12 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:07:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:07:15 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #10 from Lucas Gass --- (In reply to Lucas Gass from comment #9) > (In reply to Martin Renvoize from comment #7) > > Excellent follow-up Owen, thanks.. I think I prefer option 2 too... > > > > However, what do you think to what it does to the look of search results > > when you search for a system preference?.. It's not terrible, but also > > doesn't look quite right to me yet either... contemplating. > > I also prefer option #2. > > When you search for system preferences and return more than 1 in a single > category they look a bit "smushed" together. If there was just a tiny margin > between the two I think it looks more organized. IMHO. Ignore my comment, this does create a nice margin. I didn't 'yarn build'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:08:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:08:49 +0000 Subject: [Koha-bugs] [Bug 28864] The patron search results in the patron card creator doesn't seem to use PatronsPerPage syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #27 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:10:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:10:43 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:10:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:10:47 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141770|0 |1 is obsolete| | --- Comment #11 from Lucas Gass --- Created attachment 141830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141830&action=edit Bug 31758: OPTION 2 - Add page-section div around subsections An alternative that puts adds a new page-section div around each preference subsection rather than around the whole tab section. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:10:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:10:51 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141793|0 |1 is obsolete| | --- Comment #12 from Lucas Gass --- Created attachment 141831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141831&action=edit Bug 31758: OPTION 2 (follow-up) Add padding between adjacent sections Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:11:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:11:31 +0000 Subject: [Koha-bugs] [Bug 27849] Koha::Token may access undefined C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27849 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #10 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:16:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:16:26 +0000 Subject: [Koha-bugs] [Bug 31249] update_patrons_category.pl cron does not log to action_logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31249 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #6 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:19:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:19:31 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lucas at bywatersolutions.com |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:20:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:20:29 +0000 Subject: [Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #6 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:22:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:22:02 +0000 Subject: [Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |victor at tuxayo.net --- Comment #11 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Maybe something to document. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:22:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:22:36 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 --- Comment #7 from Lucas Gass --- (In reply to Martin Renvoize from comment #5) > Let me know what you think of my follow-up that tries to achieve the above... > > I'm really keen to reduce our CSS footprint.. instead of targetting lots of > individual elements I want to start using shared classes more so we can > really improve consistency accross the board. I like it, less is more. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:23:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:23:27 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:23:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:23:30 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141755|0 |1 is obsolete| | --- Comment #8 from Lucas Gass --- Created attachment 141832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141832&action=edit Bug 31747: Give area-news box new staff design look To test: 1. Apply patch 2. Regenerate staff CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 3. Look at the #area-news element of the mainpage. 4. There should be no rounded corners and the box-shadow should be the same as seen elsewhere ( i.e. patron details page ) Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:23:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:23:34 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141790|0 |1 is obsolete| | --- Comment #9 from Lucas Gass --- Created attachment 141833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141833&action=edit Bug 31747: Use page-section class, reduce CSS Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:24:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:24:03 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:24:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:24:57 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #40 from Martin Renvoize --- Added Marcel to CC list.. this patchset changes get_marc_host.. I know you're close to that sub.. any chance you could validate the change here.. I'm afraid my knowledge of that area has dropped away somewhat. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:31:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:31:41 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #13 from Martin Renvoize --- Created attachment 141834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141834&action=edit Bug 31758: (follow-up) Remove fat margin-top This removes the increased top margin appearing on subsection headings after clicking through from search.. I'm not sure if we need it or not now.. the original feature it appeared to help with doesn't work for me.. scroll to section doesn't happen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:45:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:45:37 +0000 Subject: [Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 --- Comment #16 from Andrew Nugged --- (In reply to Victor Grousset/tuxayo from comment #14) > > bug 29012 hasn't been released > > So I don't know if that changes the strategy for this bug. We SHOULD change strategy, and that's great - this means we don't need to make complicated "reversal atomic updates" for the older wrong atomic update which was very complicated and anyway dangerous. That's great. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:53:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:53:16 +0000 Subject: [Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |INVALID --- Comment #17 from Andrew Nugged --- this ticket is not needed anymore because the contents of 29012 will be obsoleted and re-done. to Kevin Carnes: let's go back to Bug 29012 and obsolete everything there and make again a full new solution taking the idea but do that now as we now know. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:53:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:53:17 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Bug 29012 depends on bug 31727, which changed state. Bug 31727 Summary: Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:53:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:53:47 +0000 Subject: [Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29012 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:53:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:53:47 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #14 from Owen Leonard --- (In reply to Martin Renvoize from comment #13) > Created attachment 141834 [details] [review] > Bug 31758: (follow-up) Remove fat margin-top > > This removes the increased top margin appearing on subsection headings > after clicking through from search.. The purpose of the extra margin can be seen if you click one of the sidebar subheadings to jump down. Without the extra margin, when you jump to that section the heading is obscured by the floating toolbar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:53:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:53:47 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|31727 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:54:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:54:53 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31727 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:54:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:54:53 +0000 Subject: [Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29012 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:57:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:57:09 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |ASSIGNED --- Comment #33 from Andrew Nugged --- ok, so everything what was done above this message is OBSOLETE now, Kevin Carnes, are you ok with committing here new solution from base? (please mind the patches if something were useful in Bug 31727 too). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 18:57:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 16:57:28 +0000 Subject: [Koha-bugs] [Bug 31292] Untranslatable string in sample_notices.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31292 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 19:35:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 17:35:39 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #34 from Lucas Gass --- This patchset has been reverted from 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 19:48:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 17:48:05 +0000 Subject: [Koha-bugs] [Bug 31763] Add 'page-section' to patron lists page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 20:03:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 18:03:47 +0000 Subject: [Koha-bugs] [Bug 31763] Add 'page-section' to patron lists page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 20:03:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 18:03:52 +0000 Subject: [Koha-bugs] [Bug 31763] Add 'page-section' to patron lists page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 --- Comment #1 from Owen Leonard --- Created attachment 141835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141835&action=edit Bug 31763: Add 'page-section' to patron lists page This patch updates patron lists templates so that the main content of the page is wrapped with a "page-section" div. This ensures that content has sufficient contrast. See Bug 31757. Unrelated change: I wrapped some form controls in a
    to make it consistent with other pages and to work better with the updated markup. Note: This patch contains indentation changes, so use diff accordingly. To test, apply the patch and go to Tools -> Patron lists. - If necessary, create one or more patron lists so that the table appears. Confirm that the content area looks correct. - Click Actions -> Add patrons to confirm that the screen looks correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 20:05:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 18:05:40 +0000 Subject: [Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 20:09:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 18:09:18 +0000 Subject: [Koha-bugs] [Bug 31764] Add 'page-section' to patron clubs page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31764 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 20:16:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 18:16:50 +0000 Subject: [Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141829|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 20:18:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 18:18:02 +0000 Subject: [Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141829|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 20:41:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 18:41:57 +0000 Subject: [Koha-bugs] [Bug 31764] Add 'page-section' to patron clubs page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31764 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 20:42:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 18:42:01 +0000 Subject: [Koha-bugs] [Bug 31764] Add 'page-section' to patron clubs page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31764 --- Comment #1 from Owen Leonard --- Created attachment 141836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141836&action=edit Bug 31764: Add 'page-section' to patron clubs page This patch updates patron clubs template so that the main content of the page is wrapped with a "page-section" div. This ensures that content has sufficient contrast. See Bug 31757. Note: This patch contains indentation changes, so use diff accordingly. To test, apply the patch and go to Tools -> Patron clubs. - If necessary, add at least one club template and at least one club based on that template. - Confirm that the display of club templates and clubs looks correct. - Locate some patrons and add them to a club. - On the patron clubs page, locate a club with enrollments and click Actions -> Enrollments. Confirm that the page looks correct. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 20:42:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 18:42:45 +0000 Subject: [Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 20:42:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 18:42:48 +0000 Subject: [Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629 --- Comment #1 from Nick Clemens --- Created attachment 141837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141837&action=edit Bug 31629: Add elasticqueue options to cleanup_database This patch adds an elasticqueue option to cleanup_database.pl to allow for purging completed reindexing jobs To test: 1 - Enable elastic search in Koha 2 - perl misc/maintenance/touch_all_items.pl 3 - Check db and note there are a bunch of elastic reindex jobs 4 - Update to make them old UPDATE background_jobs SET ended_on = '2022-10-01 00:00:00' WHERE type = 'update_elastic_index' 5 - perl misc/cronjobs/cleanup_database.pl 6 - Note elasticqueue entry shows in help 7 - perl misc/cronjobs/cleanup_database.pl --elasticqueue 1 -v 8 - Note that elasticqueue would have been cleared 9 - perl misc/cronjobs/cleanup_database.pl --elasticqueue 1 -v --confirm 10 - Note that number of entries deleted is reported 11 - Confirm in staff interface that jobs are gone: http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl (Uncheck 'Current jobs only') -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 20:42:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 18:42:50 +0000 Subject: [Koha-bugs] [Bug 31767] Add 'page-section' to tags page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31767 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 20:55:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 18:55:25 +0000 Subject: [Koha-bugs] [Bug 31767] Add 'page-section' to tags page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31767 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 20:55:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 18:55:29 +0000 Subject: [Koha-bugs] [Bug 31767] Add 'page-section' to tags page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31767 --- Comment #1 from Owen Leonard --- Created attachment 141838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141838&action=edit Bug 31767: Add 'page-section' to tags page This patch updates tags templates so that the main content of the page is wrapped with a "page-section" div. This ensures that content has sufficient contrast. See Bug 31757. Note: This patch contains indentation changes, so use diff accordingly. To test, apply the patch and go to Tools -> Tags. - Confirm that the content area of the page looks correct. - Click one of the tag terms to view the list of titles tagged with that term. Confirm that this page looks correct too. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 21:33:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 19:33:56 +0000 Subject: [Koha-bugs] [Bug 31778] New: action logs for administrative tasks Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31778 Bug ID: 31778 Summary: action logs for administrative tasks Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Transaction logs Assignee: koha-bugs at lists.koha-community.org Reporter: evelyn at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org There are no action logs generated for changes/creation/removal of branches (for example, the branch code, email, SMTP server selection, etc.). It would be great if changes like that were logged. If there is interest, these logs could be extended to other "administrative" tasks as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 21:34:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 19:34:00 +0000 Subject: [Koha-bugs] [Bug 31764] Add 'page-section' to patron clubs page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31764 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 21:34:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 19:34:04 +0000 Subject: [Koha-bugs] [Bug 31764] Add 'page-section' to patron clubs page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31764 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141836|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 141839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141839&action=edit Bug 31764: Add 'page-section' to patron clubs page This patch updates patron clubs template so that the main content of the page is wrapped with a "page-section" div. This ensures that content has sufficient contrast. See Bug 31757. Note: This patch contains indentation changes, so use diff accordingly. To test, apply the patch and go to Tools -> Patron clubs. - If necessary, add at least one club template and at least one club based on that template. - Confirm that the display of club templates and clubs looks correct. - Locate some patrons and add them to a club. - On the patron clubs page, locate a club with enrollments and click Actions -> Enrollments. Confirm that the page looks correct. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 21:35:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 19:35:05 +0000 Subject: [Koha-bugs] [Bug 31778] action logs for administrative tasks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31778 Evelyn Hartline changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 21:44:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 19:44:51 +0000 Subject: [Koha-bugs] [Bug 31779] New: Article Request form shows all locations in pickup library menu Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31779 Bug ID: 31779 Summary: Article Request form shows all locations in pickup library menu Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: ephetteplace at cca.edu QA Contact: testopia at bugs.koha-community.org To recreate: 1. have multiple locations/branches 2. set one to not be available as a pickup location 3. have an item where you can make article requests (e.g. a newspaper or journal) 4. go to the article request form for the item /cgi-bin/koha/opac-request-article.pl?biblionumber={{biblionumber}} 5. note the "pickup library" select menue at the bottom of the form Expected behavior: the location in step #2 will not be listed in the select menu because it is not an available pickup location. This is the case, for instance, on the holds form at /cgi-bin/koha/opac-reserve.pl?biblionumber={{biblionumber}}. Actual behavior: all libraries are listed. The template iterates over all branches `FOREACH b IN Branches.all` without discrimination. There's a question of whether article pickups and holds pickups should be treated the same, maybe there's some edge case where these are different, but for us and I would imagine the vast majority of libraries it doesn't make sense to offer a pickup location for articles when the branch itself doesn't process holds (usually means there are no circulation functions or staff at that location). I looked at the logic in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt to see if it could be easily copied over to the koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt but it is not as straightforward as I'd expected. We will probably resort to OPACUserJS to work around this in the meantime. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 21:47:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 19:47:23 +0000 Subject: [Koha-bugs] [Bug 31763] Add 'page-section' to patron lists page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 21:47:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 19:47:27 +0000 Subject: [Koha-bugs] [Bug 31763] Add 'page-section' to patron lists page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141835|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 141840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141840&action=edit Bug 31763: Add 'page-section' to patron lists page This patch updates patron lists templates so that the main content of the page is wrapped with a "page-section" div. This ensures that content has sufficient contrast. See Bug 31757. Unrelated change: I wrapped some form controls in a
    to make it consistent with other pages and to work better with the updated markup. Note: This patch contains indentation changes, so use diff accordingly. To test, apply the patch and go to Tools -> Patron lists. - If necessary, create one or more patron lists so that the table appears. Confirm that the content area looks correct. - Click Actions -> Add patrons to confirm that the screen looks correct. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 21:48:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 19:48:28 +0000 Subject: [Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 21:52:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 19:52:39 +0000 Subject: [Koha-bugs] [Bug 31760] Low constrast of some colors (WCAG) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31760 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 21:56:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 19:56:02 +0000 Subject: [Koha-bugs] [Bug 31780] New: Add 'page-section' to audio alerts ( audio_alerts.tt ) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31780 Bug ID: 31780 Summary: Add 'page-section' to audio alerts ( audio_alerts.tt ) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Depends on: 30952 We need the page-section div adding to audio alerts page to ensure proper contrast for even/odd rows on the tables. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 21:56:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 19:56:02 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31780 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31780 [Bug 31780] Add 'page-section' to audio alerts ( audio_alerts.tt ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 21:57:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 19:57:21 +0000 Subject: [Koha-bugs] [Bug 31779] Article Request form shows all locations in pickup library menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31779 --- Comment #1 from Eric Phetteplace --- In case it's useful for other people, this is the custom JS I've added: if (location.pathname.match('/cgi-bin/koha/opac-request-article.pl')) { // remove invalid pickup library options $('option[value="NOTAPICKUPLIB1"], option[value="NOTAPICKUPLIB2"]').remove() } You need to add in your own branch codes. We actually only have one valid location so I added another line `$('#branchcode').parent().hide()` to hide the menu and its label altogether since there's no choice for users to make. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 21:59:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 19:59:44 +0000 Subject: [Koha-bugs] [Bug 31780] Add 'page-section' to audio alerts ( audio_alerts.tt ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31780 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 21:59:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 19:59:47 +0000 Subject: [Koha-bugs] [Bug 31780] Add 'page-section' to audio alerts ( audio_alerts.tt ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31780 --- Comment #1 from Lucas Gass --- Created attachment 141841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141841&action=edit Bug 31780: Add page-section class to audio alerts To test: 1. Apply the patch and go to Administration -> Audio alerts 2. Confirm that the screen/table look correct with the page-section class added. Note: There are some indentation changes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 22:11:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 20:11:09 +0000 Subject: [Koha-bugs] [Bug 31767] Add 'page-section' to tags page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31767 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 22:11:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 20:11:13 +0000 Subject: [Koha-bugs] [Bug 31767] Add 'page-section' to tags page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31767 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141838|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 141842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141842&action=edit Bug 31767: Add 'page-section' to tags page This patch updates tags templates so that the main content of the page is wrapped with a "page-section" div. This ensures that content has sufficient contrast. See Bug 31757. Note: This patch contains indentation changes, so use diff accordingly. To test, apply the patch and go to Tools -> Tags. - Confirm that the content area of the page looks correct. - Click one of the tag terms to view the list of titles tagged with that term. Confirm that this page looks correct too. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 22:14:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 20:14:36 +0000 Subject: [Koha-bugs] [Bug 31780] Add 'page-section' to audio alerts ( audio_alerts.tt ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31780 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 22:23:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 20:23:01 +0000 Subject: [Koha-bugs] [Bug 31774] Add 'page-section' to Manage staged MARC records page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31774 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 22:26:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 20:26:48 +0000 Subject: [Koha-bugs] [Bug 31773] Add 'page-section' to marc modification templates pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 22:26:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 20:26:52 +0000 Subject: [Koha-bugs] [Bug 31773] Add 'page-section' to marc modification templates pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 --- Comment #1 from Lucas Gass --- Created attachment 141843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141843&action=edit Bug 31773: Add page-section class to Manage staged MARC records page To test: 1. Apply patch 2. Have some MARC records and stage them for import. It will be nessesary to add more than 1 3. Go to the Manage staged MARC records page and make sure the table looks right with the page-section added. Note: I am also adding the Bootstrap table class to this table becuase I think it makes the table look much nicer. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 22:27:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 20:27:36 +0000 Subject: [Koha-bugs] [Bug 31773] Add 'page-section' to marc modification templates pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 22:29:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 20:29:49 +0000 Subject: [Koha-bugs] [Bug 31775] Show opac_info of single library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- I had a go at testing, but struggled to notice any difference - except that for a single library, the library name is linked. No additional information is displayed on the linked page (even if all the library information fields are filling in). If this is what is expected, I'm happy to sign off. Testing notes (using koha-testing-docker): - Needed to batch modify patrons to change their library to the one kept (possibly could have just deleted all patrons). - Needed to batch modify items for all libraries not kept so that their home library and current library changed to the library kept. - Not sure how to make a library not publicly accessible, is there some other system preference to change? . Changing an existing library: get message "An error occurred when updating this library. Perhaps it already exists." . Creating a new library - even if you change public to "No", it saves as public with "Yes". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 22:37:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 20:37:45 +0000 Subject: [Koha-bugs] [Bug 31776] Typo in cleanup_database.pl cron's help/usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31776 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 22:37:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 20:37:49 +0000 Subject: [Koha-bugs] [Bug 31776] Typo in cleanup_database.pl cron's help/usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31776 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141826|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 141844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141844&action=edit Bug 31776: Fix a typo in cleanup_database.pl cronjob's help/usage cleanup_database.pl cronjob has a typo in it's usage/help: "preserve-logs" option should be "preserve-log" as it is everywhere in the code. Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 22:41:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 20:41:29 +0000 Subject: [Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 --- Comment #14 from Katrin Fischer --- Could this be a duplicate to the just fixed bug 31587? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 22:42:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 20:42:20 +0000 Subject: [Koha-bugs] [Bug 31776] Typo in cleanup_database.pl cron's help/usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31776 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes (using koha-testing-docker): - Ran cronjob with --preserve-logs option and got error message: misc/cronjobs/cleanup_database.pl --preserve-logs Unknown option: preserve-logs - Ran cronjob with --preserve-log option and got message "You did not specify any cleanup work for the script to do." - Checked help after patch applied and help text is corrected (misc/cronjobs/cleanup_database.pl --help) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 22:51:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 20:51:26 +0000 Subject: [Koha-bugs] [Bug 31763] Add 'page-section' to patron lists page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141840|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 141845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141845&action=edit Bug 31763: Add 'page-section' to patron lists page This patch updates patron lists templates so that the main content of the page is wrapped with a "page-section" div. This ensures that content has sufficient contrast. See Bug 31757. Unrelated change: I wrapped some form controls in a
    to make it consistent with other pages and to work better with the updated markup. Note: This patch contains indentation changes, so use diff accordingly. To test, apply the patch and go to Tools -> Patron lists. - If necessary, create one or more patron lists so that the table appears. Confirm that the content area looks correct. - Click Actions -> Add patrons to confirm that the screen looks correct. Signed-off-by: Lucas Gass Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 23:08:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 21:08:18 +0000 Subject: [Koha-bugs] [Bug 31763] Add 'page-section' to patron lists page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- I hadn't refreshed the page - I now see it was already signed off! I notice that the auto complete for patron search when adding patrons to a list is not working (it wasn't working before the patch was applied). Should this be a separate bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 23:16:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 21:16:36 +0000 Subject: [Koha-bugs] [Bug 31763] Add 'page-section' to patron lists page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 --- Comment #5 from Lucas Gass --- (In reply to David Nind from comment #4) > I hadn't refreshed the page - I now see it was already signed off! > > I notice that the auto complete for patron search when adding patrons to a > list is not working (it wasn't working before the patch was applied). > > Should this be a separate bug? Never hurts to have 2 sign-offs! I see there is a JS error on that page and that is likely why the auto complete function is broken: Uncaught TypeError: $(...).autocomplete(...).data(...) is undefined Let's file a separate bug for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 23:18:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 21:18:41 +0000 Subject: [Koha-bugs] [Bug 31773] Add 'page-section' to marc modification templates pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 23:18:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 21:18:45 +0000 Subject: [Koha-bugs] [Bug 31773] Add 'page-section' to marc modification templates pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141843|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 141846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141846&action=edit Bug 31773: Add page-section class to Manage staged MARC records page To test: 1. Apply patch 2. Have some MARC records and stage them for import. It will be nessesary to add more than 1 3. Go to the Manage staged MARC records page and make sure the table looks right with the page-section added. Note: I am also adding the Bootstrap table class to this table becuase I think it makes the table look much nicer. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 23:25:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 21:25:23 +0000 Subject: [Koha-bugs] [Bug 31781] New: Transferred items table (branchtransfers.tt) needs page-section class Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781 Bug ID: 31781 Summary: Transferred items table (branchtransfers.tt) needs page-section class Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 30952 We need the page-section div added to the branchtransfers page to ensure proper contrast for even/odd rows on the tables. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 23:25:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 21:25:23 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31781 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781 [Bug 31781] Transferred items table (branchtransfers.tt) needs page-section class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 23:35:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 21:35:27 +0000 Subject: [Koha-bugs] [Bug 31782] New: Patron lists - patron autocomplete search does not work Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782 Bug ID: 31782 Summary: Patron lists - patron autocomplete search does not work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org When adding a patron to a list, the autocomplete search does not work. Instead, you have to paste the patron card number or borrower number into the Add multiple patrons form. To replicate: 1. Go to Tools > Patrons and circulation > Patron lists. 2. Add a new patron list. 3. Go to add patrons page for the list. Note that there is a JavaScript in the web developer tools console [1]. 4. Type an existing name in the patron search box, for example: mary. 5. Note that the progress icon/circle appears very briefly, but the name is not autocompeleted. 6. Note also that there is a 400 bad request error in the web developer tools console.[2] [1] JavaScript error when viewing Add patrons page for a patron list: Uncaught TypeError: can't access property "_renderItem", $(...).autocomplete(...).data(...) is undefined patron_autocomplete http://127.0.0.1:8081/intranet-tmpl/js/autocomplete/patrons_22.0600062.js:20 http://127.0.0.1:8081/cgi-bin/koha/patron_lists/list.pl?patron_list_id=1:1080 jQuery 2 e t [2] 400 bad request error when typing a name in the autocomplete field: GET http://127.0.0.1:8081/api/v1/patrons?term=mary Status: 400 Bad Request Version: HTTP/1.1 .. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 23:36:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 21:36:08 +0000 Subject: [Koha-bugs] [Bug 31782] Patron lists - patron autocomplete search does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 23:39:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 21:39:02 +0000 Subject: [Koha-bugs] [Bug 31780] Add 'page-section' to audio alerts ( audio_alerts.tt ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31780 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 23:39:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 21:39:07 +0000 Subject: [Koha-bugs] [Bug 31780] Add 'page-section' to audio alerts ( audio_alerts.tt ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31780 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141841|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 141847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141847&action=edit Bug 31780: Add page-section class to audio alerts To test: 1. Apply the patch and go to Administration -> Audio alerts 2. Confirm that the screen/table look correct with the page-section class added. Note: There are some indentation changes. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 23:51:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 21:51:28 +0000 Subject: [Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 23:51:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 21:51:33 +0000 Subject: [Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141829|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 141848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141848&action=edit Bug 31766: Add page-section wrapper to notice table To test: 1. Apply patch 2. Look at the noitce page and notice how the table, and it's tools, now are wrapped with the page-section element. 3. Is it better than it was before? Feel free to osboslete these patch and replace it with your own. Signed-off-by: David Nind -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 23:52:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 21:52:55 +0000 Subject: [Koha-bugs] [Bug 31763] Add 'page-section' to patron lists page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 --- Comment #6 from David Nind --- (In reply to Lucas Gass from comment #5) > Let's file a separate bug for that. Bug 31782 created for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 23:56:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 21:56:49 +0000 Subject: [Koha-bugs] [Bug 31743] Cannot change my notice language when EnhancedMessagingPreferencesOPAC is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743 Marie-Luce Laflamme changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |marie-luce.laflamme at inlibro | |.com --- Comment #2 from Marie-Luce Laflamme --- Suggestion for the test plan 1. Apply the patch 3. Enable EnhancedMessaging, disable EnhancedMessagingOPAC. 4. Enable TranslateNotices. 5. Login on the OPAC and go in "your messaging" 6. Check if you can only change notice language 7. Enable EnhancedMessagingOPAC. 8. Check if you can change messaging prefs too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 23:57:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 21:57:17 +0000 Subject: [Koha-bugs] [Bug 31743] Cannot change my notice language when EnhancedMessagingPreferencesOPAC is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141768|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes --- Created attachment 141849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141849&action=edit Bug 31743: Change condition for messaging tab Note for QA: The code for SMSnumber is still made dependent on EnhancedMessagingPreferencesOPAC in order to not disturb current behavior. This fixes Enhanced on, EnhancedOPAC off; the case of Enhanced off is not considered here. Test plan: Enable EnhancedMessaging, disable EnhancedMessagingOPAC. Enable TranslateNotices. Check if you can only change notice language on OPAC. Enable EnhancedMessagingOPAC. Check if you change messaging prefs too. Signed-off-by: Marcel de Rooy Signed-off-by: marie-luce -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 23:57:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 21:57:54 +0000 Subject: [Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #6 from David Nind --- It is better than it was before, so I've signed off. However, I like the border around the table and table header (in the first screenshot). For me: - the header/table blends in too much with the background without the borders - with the border, it makes it much easer to scan the table column headers and rows -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 13 23:58:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 21:58:20 +0000 Subject: [Koha-bugs] [Bug 31155] Document --since option in help of borrowers-force-messaging-defaults.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31155 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to stable |Needs documenting --- Comment #7 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Maybe docs to update. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 00:08:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 22:08:16 +0000 Subject: [Koha-bugs] [Bug 29434] In UNIMARC instances, the authority finder uses MARC21 relationship codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #13 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 00:14:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 22:14:55 +0000 Subject: [Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766 --- Comment #7 from Lucas Gass --- (In reply to David Nind from comment #6) > It is better than it was before, so I've signed off. > > However, I like the border around the table and table header (in the first > screenshot). > > For me: > - the header/table blends in too much with the background without the borders > - with the border, it makes it much easer to scan the table column headers > and rows David, I agree. The header/table blends in too much, this is happening on this page and elsewhere. I think we'll need to address that. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 00:23:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 22:23:18 +0000 Subject: [Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 00:23:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 22:23:22 +0000 Subject: [Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141837|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 141850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141850&action=edit Bug 31629: Add elasticqueue options to cleanup_database This patch adds an elasticqueue option to cleanup_database.pl to allow for purging completed reindexing jobs To test: 1 - Enable elastic search in Koha 2 - perl misc/maintenance/touch_all_items.pl 3 - Check db and note there are a bunch of elastic reindex jobs 4 - Update to make them old UPDATE background_jobs SET ended_on = '2022-10-01 00:00:00' WHERE type = 'update_elastic_index' 5 - perl misc/cronjobs/cleanup_database.pl 6 - Note elasticqueue entry shows in help 7 - perl misc/cronjobs/cleanup_database.pl --elasticqueue 1 -v 8 - Note that elasticqueue would have been cleared 9 - perl misc/cronjobs/cleanup_database.pl --elasticqueue 1 -v --confirm 10 - Note that number of entries deleted is reported 11 - Confirm in staff interface that jobs are gone: http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl (Uncheck 'Current jobs only') Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 00:23:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 22:23:53 +0000 Subject: [Koha-bugs] [Bug 31781] Transferred items table (branchtransfers.tt) needs page-section class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 00:23:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 22:23:57 +0000 Subject: [Koha-bugs] [Bug 31781] Transferred items table (branchtransfers.tt) needs page-section class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781 --- Comment #1 from Lucas Gass --- Created attachment 141851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141851&action=edit Bug 31781: Add page-section to branchtransfers page This patch adds the page-section div to 2 tables on the branch transfer page. To test: 1. Apply patch 2. Place an item level hold on a few items. 3. Now go to the branch transfer page and try transferring your items that have holds on them. 4. This should bring up a 'Reserve found' page. Look at the table and make sure it looks good with the page-section div added. 5. Now try some transfers that do not have holds. Make sure the table that populates also goods good with the page-section div added. Note: There are some indentation changes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 00:34:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 22:34:54 +0000 Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #30 from David Cook --- (In reply to Ere Maijala from comment #29) > I'll soften my stance a bit. I suppose it boils down to whether two > endpoints are considered the same repository. It might also be enough to > just document that one shouldn't harvest from multiple endpoints like they > were the same repository. Yeah, I think documenting could be enough. We could even have separate system preferences. On the non-Koha system with private/public endpoints, the private one is restricted by additional security and used for internal projects. The public one is just open to the public, so very different consumers. But we also set that up with those separate endpoints from the initial launch. With Koha, it'll be harder to transition for existing consumers of the OAI-PMH... That said, people looking for support for suppressed/hidden records, they'll probably be doing it intentionally and thus be able to coordinate a migration to a new public endpoint more easily... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 00:48:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 22:48:03 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #62 from David Cook --- (In reply to Fridolin Somers from comment #61) > Same for us french. > We fixed manually after upgrade. I don't know if it was this change, but we've had a lot of issues with news/additional contents with upgrades where we have multiple languages enabled. Manually fixed after upgrade as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 01:12:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 23:12:19 +0000 Subject: [Koha-bugs] [Bug 31783] New: Table settings page needs page-section class Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31783 Bug ID: 31783 Summary: Table settings page needs page-section class Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Depends on: 30952 We need the page-section div added to the columns_settings.tt page to ensure proper contrast for even/odd rows on the tables. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 01:12:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 23:12:19 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31783 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31783 [Bug 31783] Table settings page needs page-section class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 01:17:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 23:17:21 +0000 Subject: [Koha-bugs] [Bug 31783] Table settings page needs page-section class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31783 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 01:17:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 23:17:25 +0000 Subject: [Koha-bugs] [Bug 31783] Table settings page needs page-section class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31783 --- Comment #1 from Lucas Gass --- Created attachment 141852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141852&action=edit Bug 31783: Add page-section to columns_settings.tt page This patch adds the page-section class to the tables on the Table settings page. To test: 1. Apply patch and go to Administration > Table settings 2. Make sure the tables look good with the new page-section class, which is added to an existing div in this case. 3. Make sure that changing some table setting still works and you can properly save new settings. Note: This patch moves the fieldset which contains the Save button into the page-section div. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 01:18:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Oct 2022 23:18:59 +0000 Subject: [Koha-bugs] [Bug 31756] Biblionumber not numerically sorting natively when using Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Failed QA --- Comment #5 from David Nind --- Hi David. Things seem to be working for MARC21. However, for UNIMARC: - I changed the count number =100 - After the first 10 pages of results (that is, from page 11 and the 1001 search result) the order changes to asc starting from 1 It works fine for asc. Note: when copying the definitions in step 2, I replaced marc21 with unimarc in the file paths. David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 02:24:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 00:24:22 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #62 from David Cook --- (In reply to Katrin Fischer from comment #21) > I just noticed that you need to run the database update for Koha to work. > Not sure if this could cause problem with the web installer. > > Error while loading /etc/koha/sites/kohadev/plack.psgi: Can't load > application from file "/kohadevbox/koha/api/v1/app.pl": > DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st > execute failed: Table 'koha_kohadev.auth_providers' doesn't exist at > /kohadevbox/koha/Koha/Objects.pm line 312 This is certainly an issue. I'm looking at follow-ups... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 02:25:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 00:25:55 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #63 from David Cook --- (In reply to Martin Renvoize from comment #58) > To test: > 1. Apply this patch > 2. Run: > $ kshell > k$ prove t/db_dependent/api/v1/auth_providers.t > => SUCCESS: Tests pass! > 3. Sign off :-D Looks like the unit test file is t/db_dependent/Koha/Auth/Provider.t these days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 02:57:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 00:57:15 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #64 from Tomás Cohen Arazi --- (In reply to David Cook from comment #62) > (In reply to Katrin Fischer from comment #21) > > I just noticed that you need to run the database update for Koha to work. > > Not sure if this could cause problem with the web installer. > > > > Error while loading /etc/koha/sites/kohadev/plack.psgi: Can't load > > application from file "/kohadevbox/koha/api/v1/app.pl": > > DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st > > execute failed: Table 'koha_kohadev.auth_providers' doesn't exist at > > /kohadevbox/koha/Koha/Objects.pm line 312 > > This is certainly an issue. I'm looking at follow-ups... I think the old GoogleOpenId... stuff removal is to blame, as we decided to defer it. Will look tomorrow morning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 02:58:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 00:58:14 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #65 from Tomás Cohen Arazi --- (In reply to David Cook from comment #63) > (In reply to Martin Renvoize from comment #58) > > To test: > > 1. Apply this patch > > 2. Run: > > $ kshell > > k$ prove t/db_dependent/api/v1/auth_providers.t > > => SUCCESS: Tests pass! > > 3. Sign off :-D > > Looks like the unit test file is t/db_dependent/Koha/Auth/Provider.t these > days. There should be tests for the providers CRUD in there as well. git diff origin/master --name-only -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 03:10:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 01:10:41 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #66 from Tomás Cohen Arazi --- (In reply to David Cook from comment #62) > (In reply to Katrin Fischer from comment #21) > > I just noticed that you need to run the database update for Koha to work. > > Not sure if this could cause problem with the web installer. > > > > Error while loading /etc/koha/sites/kohadev/plack.psgi: Can't load > > application from file "/kohadevbox/koha/api/v1/app.pl": > > DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st > > execute failed: Table 'koha_kohadev.auth_providers' doesn't exist at > > /kohadevbox/koha/Koha/Objects.pm line 312 > > This is certainly an issue. I'm looking at follow-ups... Please comment about the code, propose things and stuff so this shines for the release. Follow-ups will come out of course. Thanks for your time! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 04:24:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 02:24:03 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #67 from David Cook --- (In reply to Tomás Cohen Arazi from comment #66) > Please comment about the code, propose things and stuff so this shines for > the release. Follow-ups will come out of course. Thanks for your time! I've spent the last few hours working on this one, and have a ton of feedback. Hopefully all pretty easy to fix I think... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 04:24:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 02:24:34 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #68 from David Cook --- I'll shortly add a follow-up to catch the error of the missing database update. In theory, with a package install, the database will be automatically upgraded before the web app is started up. But some people will still need to use the web installer, so we don't want it to fail. (Those people will need to restart their Koha before they're able to use the new auth functionality of course.) Test plan 1: 1. apt install libmojolicious-plugin-oauth2-perl 2. restart_all 3. koha-upgrade-schema kohadev 4. koha-plack --restart kohadev 5. prove t/db_dependent/Koha/Auth/Provider.t So far so good. Test plan 2: 1. Go to http://localhost:8081/cgi-bin/koha/admin/admin-home.pl 2. Click on "Authentication providers" (#NOTE: I would've preferred "Identity Providers" since that's a more common industry term.) 3. Click "New authentication provider" (#NOTE: The UI looks poorly formatted, but I think that's probably a symptom of the new staff interface styling. Not a blocker for me. This can be fixed later...) (#NOTE: There is a bug with the "Configuration" where "Add new X configuration" doesn't work if you've manually changed anything in the text box. Not a blocker for me, but will need to be fixed at some point. Same goes for "Add default OIDC mapping.) (#NOTE: There's not enough documentation/help text on how to use this UI. I'm figuring it out through trial and error, but a bit of help text for "Code", "Description", and "Icon URL" at a minimum would be good.) (#NOTE: With the new Staff Interface, there should be a "Help" link on the right hand side, but I don't see it for this new functionality. I think that's a blocker.) (#NOTE: I don't really like having to include raw JSON in this UI. This could be made more beautiful.) (#NOTE: "Code" doesn't appear to be restricted or validated in any way. We should stick to alphanumeric codes. This is borderline... but I think it's a blocker. We need to set the rule before people start using it.) (#NOTE: We need to add help text at the bottom of this page that says this auth provider won't be available until after a Koha restart.) 4. Click on "Manage Domains" 5. Click "Edit" for first and only line (#NOTE: It's not clear what a "Domain" is in this context. This needs more help text/documentation. I'd say that's a blocker. From past code review in Koha for OIDC, "Domain" referred to email domain. That really should spelled out clearly. ) 6. The breadcrumb doesn't show the auth provider code on the "Edit authentication provider domain" like it does on the "Authentication provider domains" page 4. koha-plack --restart kohadev (#NOTE: This is an unfortunate step but necessary because of the plugin being used. Auth providers are rarely set up, so not a big drama.) 4. In an Incognito tab or different browser, go to http://localhost:8081/ (#NOTE: In my opinion, we should *not* be allowing staff login by default. While "Auto register" is "Don't allow" by default, we should keep the staff interface as locked down as possible. Not a blocker but an observation...) 5. When I try to login with Keycloak, I get the following error in Koha: [{"message":"Malformed query string","path":"\/query\/session_state"}] (#NOTE: Newer OIDC providers will provide session_state in the authentication response. I'll turn this off in Keycloak. Folks can read more about session_state at https://openid.net/specs/openid-connect-session-1_0.html) 6. Now I'm getting this error on the Koha Staff Interface login page (since the user doesn't exist in Koha and I have auto-register turned off): There was an error authenticating to external identity provider Exception 'Koha::Exceptions::Auth::Unauthorized' thrown 'External auth user cannot access resource' with code => 401 (#NOTE: I don't think printing the exception on the staff interface is a good idea. Let's remove that.) 7. After adding my user to Koha and giving staff permissions, I'm able to log in. Very nice! 8. Go to http://localhost:8080/ and click "Log in with Keycloak IdP" 9. Since I already have a session in Keycloak, I'm logged into the OPAC with no login. Very good! 10. If I logout of Keycloak and try to log back into http://localhost:8080/ via Keycloak, I get the following: There was an error authenticating to external identity provider Can't call method "auto_register" on an undefined value at /kohadevbox/koha/Koha/REST/Plugin/Auth.pm line 66. (#NOTE: In the code I see "tranverse_hash" but it should be "traverse_hash" in English.) 11. Turn on auto register for all blank domain... 12. restart_all in ktd 13. Try to log into OPAC and Staff Interface 14. Neither works... (#NOTE: In Koha/REST/Plugin/Auth.pm, it looks like auto-register should only work for OPAC. In theory, I like that, although I suppose the workaround would be to auto-register for the OPAC, and then your account would exist for the Staff Interface anyway...) 15. I tried "Update on login" using the blank domain and a domain of "prosentient.com.au" and both failed to update my firstname and surname on login. That's a blocker... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 04:25:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 02:25:29 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #69 from David Cook --- Here is the TL;DR version: Question: 1. I noticed that the default "Mapping configuration" is just 1-to-1 for strings, but Oauth/OIDC claims can be complex data structures. How do you handle when the claim is an array or an object? The most common one I see in the real world is the "address" object, but there are others too. Looking at Koha/Auth/Client/OAuth.pm and Koha/Auth/Client.pm, I think that you have added code for this. Would it be "address.street_address" in the Mapping to get the "street_address" value out of the "address" claim? The code is uncommented and a bit obscure, so I can't tell if you can handle array values, although I'm less worried about them. Can you? TODO: 0. Add missing "Help" link to all new pages 1. Restrict "Code" to alphanumeric code 2. Add help text to "New authentication provider" UI 3. Add help text to "Edit authentication provider domain" UI 4. Fix breadcrumb on "Edit authentication provider domain" UI 5. Remove exception text from Koha staff interface login page 6. Remove exception text from Koha OPAC login page 7. Think about changing "tranverse_hash" to "traverse_hash" 8. Fix "Auto register" 9. Fix "Update on login" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 04:28:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 02:28:18 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #70 from David Cook --- Created attachment 141853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141853&action=edit Bug 31378: (follow-up) catch startup error when missing Oauth provider table In theory, this shouldn't come up with a package install, but it could happen with other installations, so best to let it get to the web installer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 04:34:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 02:34:34 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #71 from David Cook --- QA tool complaints: FAIL Koha/Auth/Client/OAuth.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 FAIL Koha/Auth/Provider/Domain.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 FAIL Koha/Exceptions/Auth.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 FAIL Koha/REST/Plugin/Auth.pm FAIL pod coverage POD is missing for 'register' FAIL Koha/Schema/Result/AuthProvider.pm FAIL pod coverage POD is missing for koha_object_class POD is missing for koha_objects_class FAIL Koha/Schema/Result/AuthProviderDomain.pm FAIL pod coverage POD is missing for koha_object_class POD is missing for koha_objects_class FAIL admin/authentication_providers.pl FAIL file permissions File must have the exec flag FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/authentication_providers.tt FAIL forbidden patterns forbidden pattern: simple-quote string (line 407) forbidden pattern: tab char (line 427) forbidden pattern: tab char (line 442) forbidden pattern: simple-quote string (line 449) forbidden pattern: simple-quote string (line 450) forbidden pattern: simple-quote string (line 456) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt FAIL valid_template DBIx::Class::Schema::source(): Can't find source for AuthProvider at /kohadevbox/koha/Koha/Objects.pm line 524 FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc FAIL valid_template DBIx::Class::Schema::source(): Can't find source for AuthProvider at /kohadevbox/koha/Koha/Objects.pm line 524 FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt FAIL valid_template DBIx::Class::Schema::source(): Can't find source for AuthProvider at /kohadevbox/koha/Koha/Objects.pm line 524 FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt FAIL valid_template DBIx::Class::Schema::source(): Can't find source for AuthProvider at /kohadevbox/koha/Koha/Objects.pm line 524 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 04:37:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 02:37:51 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #72 from David Cook --- At line 407 of koha-tmpl/intranet-tmpl/prog/en/modules/admin/authentication_providers.tt, "Not a valid JSON" should be "Not valid JSON" since JSON refers to the format and not the data itself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 04:39:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 02:39:34 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #73 from David Cook --- (In reply to Tomás Cohen Arazi from comment #65) > There should be tests for the providers CRUD in there as well. > > git diff origin/master --name-only Not that I can see. Just t/db_dependent/Koha/Auth/Provider.t Maybe there are some missing patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 04:50:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 02:50:28 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #74 from David Cook --- Another problem: If you have a "blank" domain and a specific domain, the "blank" domain is used instead of the specific domain. If you want to set different "Default library" and "Default category" based on email domain, it won't work if you have a "blank" domain. It also means the "Auto register" and "Update on login" wouldn't work right... if they were working... I think the only thing that does work is having "Allow staff: No" in "blank" domain and "Allow staff: Yes" in specific domain. ("Allow opac: no" for "blank" would also work but that would be an unlikely scenario.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 04:54:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 02:54:05 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #75 from David Cook --- One last thing: the styling on the login buttons on the Staff Interface and OPAC have little to no contrast which is hard on the eyes. It also makes the Staff Interface buttons look strange when you have multiple providers with descriptions of different lengths. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 04:55:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 02:55:30 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #76 from David Cook --- One last last thing: It would be good to have a "Sequence" value for the providers, so that you could arrange them on the Staff Interface and OPAC in a desired order rather than the order that they were added to Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 05:01:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 03:01:49 +0000 Subject: [Koha-bugs] [Bug 31756] Biblionumber not numerically sorting natively when using Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 --- Comment #6 from David Cook --- (In reply to David Nind from comment #5) > Hi David. > > Things seem to be working for MARC21. > > However, for UNIMARC: > - I changed the count number =100 > - After the first 10 pages of results (that is, from page 11 and the 1001 > search result) the order changes to asc starting from 1 > > It works fine for asc. > > Note: when copying the definitions in step 2, I replaced marc21 with unimarc > in the file paths. > > David Could you elaborate a bit more? You say the order changes to "asc". Does that mean it was "desc" before? I don't think that's an issue with these patches. Also, in ./etc/zebradb/zebra-biblios-dom.cfg, you'll probably notice that "sortmax" is set to "1000". That means that only the first 1000 records in a result set will be sorted, so that might be what you're encountering. That means only the first 1000 records are sorted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 07:51:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 05:51:14 +0000 Subject: [Koha-bugs] [Bug 31756] Biblionumber not numerically sorting natively when using Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 --- Comment #7 from David Nind --- (In reply to David Cook from comment #6) > Could you elaborate a bit more? You say the order changes to "asc". Does > that mean it was "desc" before? Yes. For UNIMARC, when I used the URL with dsc in it: - Results 1 to 1,000 appear to sort correctly, with biblo records in descending order - For result 1,001 the biblio number of the record displayed is 1, and then it continues in ascending order for the rest of the paged set of results (until "last") If there is a setting that limits the sorting to 1,000, then I would expect this to happen with the URL with asc in it as well, but it doesn't - everything appears to be as expected with all the results set 4,000+ sorting correctly. Maybe for the asc URL this is the "default" for the Zebra config, would that explain why they act differently? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 07:57:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 05:57:38 +0000 Subject: [Koha-bugs] [Bug 31743] Cannot change my notice language when EnhancedMessagingPreferencesOPAC is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #4 from Marcel de Rooy --- (In reply to Marie-Luce Laflamme from comment #2) > Suggestion for the test plan > > 1. Apply the patch > 3. Enable EnhancedMessaging, disable EnhancedMessagingOPAC. > 4. Enable TranslateNotices. > 5. Login on the OPAC and go in "your messaging" > 6. Check if you can only change notice language > 7. Enable EnhancedMessagingOPAC. > 8. Check if you can change messaging prefs too. Thx Marie-Luce for signing off ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 08:02:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 06:02:48 +0000 Subject: [Koha-bugs] [Bug 31775] Show opac_info of single library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 --- Comment #4 from Marcel de Rooy --- (In reply to David Nind from comment #3) > I had a go at testing, but struggled to notice any difference - except that > for a single library, the library name is linked. No additional information > is displayed on the linked page (even if all the library information fields > are filling in). > > If this is what is expected, I'm happy to sign off. Thx for testing, David. You are correct: my test plan could be more detailed. What we need to do also, is add the opac_info information for a branch via Additional Contents, html cust., OpacLibraryInfo location. For one library you should see the full info page at once. For more libraries you should see the list first. Deleting a library should not be needed. Just hiding it via the public flag. I will check if you found a bug there too.. Will comment on a few other points still. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 08:06:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 06:06:01 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #41 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #40) > Added Marcel to CC list.. this patchset changes get_marc_host.. I know > you're close to that sub.. any chance you could validate the change here.. > I'm afraid my knowledge of that area has dropped away somewhat. Its on my list now ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 08:14:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 06:14:34 +0000 Subject: [Koha-bugs] [Bug 31756] Biblionumber not numerically sorting natively when using Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 --- Comment #8 from David Cook --- (In reply to David Nind from comment #7) > (In reply to David Cook from comment #6) > > > Could you elaborate a bit more? You say the order changes to "asc". Does > > that mean it was "desc" before? > > Yes. > > For UNIMARC, when I used the URL with dsc in it: > - Results 1 to 1,000 appear to sort correctly, with biblo records in > descending order > - For result 1,001 the biblio number of the record displayed is 1, and then > it continues in ascending order for the rest of the paged set of results > (until "last") > > If there is a setting that limits the sorting to 1,000, then I would expect > this to happen with the URL with asc in it as well, but it doesn't - > everything appears to be as expected with all the results set 4,000+ sorting > correctly. > > Maybe for the asc URL this is the "default" for the Zebra config, would that > explain why they act differently? Yeah, the default sort in Zebra is ascending by internal record number which is the same as biblionumber. What happens with MARC21? Surely it must be the same behaviour... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 08:17:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 06:17:26 +0000 Subject: [Koha-bugs] [Bug 31784] New: SingleBranchMode ignores public flag Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 Bug ID: 31784 Summary: SingleBranchMode ignores public flag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org The test in C4/Auth.pm: singleBranchMode => ( Koha::Libraries->search->count == 1 ), misses a fundamental condition, i.e. public should be true. C4/XSLT.pm: my $singleBranchMode = Koha::Libraries->search->count == 1 ? 1 : 0; t/Koha.t: is ( Koha::Libraries->search->count, 1, 'There should be only 1 library (singleBranchMode on)' ); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 08:21:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 06:21:22 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #63 from Jonathan Druart --- What did you fix, and how? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 08:49:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 06:49:05 +0000 Subject: [Koha-bugs] [Bug 31756] Biblionumber not numerically sorting natively when using Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 --- Comment #9 from David Nind --- (In reply to David Cook from comment #8) > Yeah, the default sort in Zebra is ascending by internal record number which > is the same as biblionumber. > > What happens with MARC21? Surely it must be the same behaviour... There are only 400 odd records in the sample data set, so doesn't show as an issue. I've had no luck exporting all the records from Koha and then importing at the moment, so can't test this out... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 08:49:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 06:49:40 +0000 Subject: [Koha-bugs] [Bug 31724] MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 08:49:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 06:49:45 +0000 Subject: [Koha-bugs] [Bug 31724] MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141592|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 141854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141854&action=edit Bug 31724: Remove 'i' from breadcrumb when deleting a MARC framework subfield Remove 'i' added to the end of the breadcrumb on the confirmation page when deleteing a MARC framework subfield. Test plan: 1. Go to Administration > MARC bibliographic frameworks. 2. View the subfields for a tag for a framework, for example: . BKS framework > Actions > MARC structure . Search for tag 245 . Select Actions > View subfields. 3. Select any subfield to delete and select the Delete button. 4. Note that there is an 'i' at the end of the breadcrumb, for example: . ... > Confirm deletion of subfield bi 5. Apply the patch. 6. Refresh the page and note that that 'i' is removed. 7. Sign off. Signed-off-by: David Nind Signed-off-by: Fridolin Somers Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 08:56:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 06:56:07 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 08:56:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 06:56:15 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:00:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:00:25 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #64 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #63) > What did you fix, and how? In short (but I spent a few hours): News goes fine, the non-News stuff goes wrong. If you have an EN and an NL record, it adds two Default records. The EN and NL are not connected anymore. This may lead to duplicating elements on the OPAC display too. Also EN became default iirc. I had to do a little bit more since I had customized news stuff too. So it made no sense to submit my fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:03:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:03:34 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:03:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:03:38 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 --- Comment #1 from Marcel de Rooy --- Created attachment 141855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141855&action=edit Bug 31784: Add Libraries->singleBranchMode Test plan: Run t/db_dependent/Koha/Libraries.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:03:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:03:41 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 --- Comment #2 from Marcel de Rooy --- Created attachment 141856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141856&action=edit Bug 31784: Replace some singleBranchMode occurrences Speaks for itself. Test plan: Run t/Koha.t. Check if OPAC shows Library or Libraries in masthead, depending on number of public branches. Login, place a hold. Verify things work as expected. Note: MARC21 XSLT does not care about singleBranchMode. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:06:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:06:12 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #74 from Jonathan Druart --- This reintroduced code removed by bug 28617. +BEGIN { + # find Koha's Perl modules + # test carefully before changing this + use FindBin (); + eval { require "$FindBin::Bin/kohalib.pl" }; +} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:07:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:07:53 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #926 from Jonathan Druart --- >From misc/cronjobs/recalls/expire_recalls.pl and misc/cronjobs/recalls/overdue_recalls.pl: +BEGIN { + # find Koha's Perl modules + # test carefully before changing this + use FindBin; + eval { require "$FindBin::Bin/../kohalib.pl" }; +} Since bug 28617 you should not do that anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:10:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:10:09 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #3 from Jonathan Druart --- snake case: single_library_mode? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:12:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:12:10 +0000 Subject: [Koha-bugs] [Bug 31150] _on or _date for DB date columns? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 --- Comment #12 from Jonathan Druart --- (In reply to Martin Renvoize from comment #10) > DOI we really want to have contradictory guidelines for this.. it's already > annoying having API fields named differently in the database.. here your > basically suggesting enforcing that.. DB fields must not match API field.. > that really doesn't make sense to me. I honestly don't remember the > discussion around _on vas _date.. but I do remember we all agreed on one and > put it in a guideline to prevent a debate every time we came to adding > another API.. We never agreed on a convention for DB column names, hence this bug report. The guideline is for the REST API. """ Where a field contains a 'date' it should be consistently named *_date as opposed to date_* and it should always return a full datetime. """ As stated before, the problem is that a _date suffix is confusing for other datatypes IMO. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:14:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:14:00 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 --- Comment #4 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #3) > snake case: single_library_mode? Do we prefer that now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:15:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:15:08 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 --- Comment #5 from Marcel de Rooy --- Coding guidelines mention snakecase for subroutines ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:15:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:15:49 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 --- Comment #6 from Marcel de Rooy --- LoginFirstname => ( C4::Context->userenv ? C4::Context->userenv->{"firstname"} : "Bel" ), LoginSurname => C4::Context->userenv ? C4::Context->userenv->{"surname"} : "Inconnu", emailaddress => C4::Context->userenv ? C4::Context->userenv->{"emailaddress"} : undef, TagsEnabled => C4::Context->preference("TagsEnabled"), hide_marc => C4::Context->preference("hide_marc"), item_level_itypes => C4::Context->preference('item-level_itypes'), patronimages => C4::Context->preference("patronimages"), singleBranchMode => $singleLibraryMode, #TODO one day our templates will only contain Library, and this can be removed singleLibraryMode => $singleLibraryMode, noItemTypeImages => C4::Context->preference("noItemTypeImages"), marcflavour => C4::Context->preference("marcflavour"), OPACBaseURL => C4::Context->preference('OPACBaseURL'), minPasswordLength => $minPasswordLength, Some work to do :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:16:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:16:38 +0000 Subject: [Koha-bugs] [Bug 31775] Show opac_info of single library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31784 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:16:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:16:38 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31775 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:19:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:19:40 +0000 Subject: [Koha-bugs] [Bug 31775] Show opac_info of single library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 --- Comment #5 from Marcel de Rooy --- (In reply to David Nind from comment #3) > Testing notes (using koha-testing-docker): > > - Needed to batch modify patrons to change their library to the one kept > (possibly could have just deleted all patrons). Should not be needed when you hide a branch. > - Needed to batch modify items for all libraries not kept so that their home > library and current library changed to the library kept. Same. Not really needed. > - Not sure how to make a library not publicly accessible, is there some > other system preference to change? Go to Admin. Libraries. Edit library. Change public. > . Changing an existing library: get message "An error occurred when > updating this library. Perhaps it already exists." Cannot reproduce this one. I toggle various libraries from Yes to No and vv. > . Creating a new library - even if you change public to "No", it saves as > public with "Yes". Yes, good catch. Editing existing libraries works here. But adding a library does not respect the public flag! Opening a new report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:20:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:20:32 +0000 Subject: [Koha-bugs] [Bug 31775] Show opac_info of single library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 --- Comment #6 from Marcel de Rooy --- When you have a lot of branches, use SQL: update branches set public=0; And set one branch back to Yes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:21:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:21:59 +0000 Subject: [Koha-bugs] [Bug 31785] New: Adding a new library does not respect public flag Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31785 Bug ID: 31785 Summary: Adding a new library does not respect public flag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org If you set public to No, it will still be public. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:22:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:22:05 +0000 Subject: [Koha-bugs] [Bug 31785] Adding a new library does not respect public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:22:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:22:13 +0000 Subject: [Koha-bugs] [Bug 31785] Adding a new library does not respect public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:22:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:22:32 +0000 Subject: [Koha-bugs] [Bug 31775] Show opac_info of single library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31785 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:22:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:22:32 +0000 Subject: [Koha-bugs] [Bug 31785] Adding a new library does not respect public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31775 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:25:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:25:37 +0000 Subject: [Koha-bugs] [Bug 31786] New: Sub template->param($var) should return the value Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31786 Bug ID: 31786 Summary: Sub template->param($var) should return the value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Far easier than $template->{VARS}->{singleBranchMode} would be $template->param('singleBranchMode') What do you think? It seems a simple addition? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:26:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:26:06 +0000 Subject: [Koha-bugs] [Bug 31786] Sub template->param($var) should return the value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:26:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:26:47 +0000 Subject: [Koha-bugs] [Bug 31786] Sub template->param($var) should return the value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31786 --- Comment #1 from Marcel de Rooy --- Easier or more elegant? Going thru VARS is hacky. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:35:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:35:37 +0000 Subject: [Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com --- Comment #8 from Martin Renvoize --- Thanks both, I'm happy to be persuaded about the table borders.. we worked a fair bit on refining the tables already, but I'm sure there are further refinements we can make.. any chance one of you could open a new bug for it so we don't lose it in here? For reference, I think the majority of prior discussion aroung this was on github issue https://github.com/jajm/koha-staff-interface-redesign/issues/22 -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:39:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:39:25 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:39:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:39:28 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141855|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 141857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141857&action=edit Bug 31784: Add Libraries->singleBranchMode Test plan: Run t/db_dependent/Koha/Libraries.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:39:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:39:32 +0000 Subject: [Koha-bugs] [Bug 31785] Adding a new library does not respect public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Marcel de Rooy --- Offending line in admin/branches: : ( $_ => scalar $input->param($_) || undef ) The 0 of public becomes undef ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:39:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:39:33 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141856|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 141858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141858&action=edit Bug 31784: Replace some singleBranchMode occurrences Speaks for itself. Test plan: Run t/Koha.t. Check if OPAC shows Library or Libraries in masthead, depending on number of public branches. Login, place a hold. Verify things work as expected. Note: MARC21 XSLT does not care about singleBranchMode. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:41:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:41:05 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #19 from Jonathan Druart --- Hum, I don't recreate, but maybe was it a conflict with bug 30718? Can you try again now that 30718 has been pushed to master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:41:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:41:39 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:41:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:41:44 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135495|0 |1 is obsolete| | Attachment #137676|0 |1 is obsolete| | Attachment #137677|0 |1 is obsolete| | Attachment #137678|0 |1 is obsolete| | Attachment #137679|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart --- Created attachment 141859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141859&action=edit Bug 30310: Add dayjs timezone plugin Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:41:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:41:50 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #21 from Jonathan Druart --- Created attachment 141860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141860&action=edit Bug 30310: Adjust js-date-format Test plan: Confirm that the test plan from bug 24455 is still passing Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:41:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:41:56 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #22 from Jonathan Druart --- Created attachment 141861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141861&action=edit Bug 30310: Remove momentjs Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:42:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:42:02 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #23 from Jonathan Druart --- Created attachment 141862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141862&action=edit Bug 30310: Adjust about page Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:44:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:44:59 +0000 Subject: [Koha-bugs] [Bug 31785] Adding a new library does not respect public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:45:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:45:03 +0000 Subject: [Koha-bugs] [Bug 31785] Adding a new library does not respect public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31785 --- Comment #2 from Marcel de Rooy --- Created attachment 141863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141863&action=edit Bug 31785: Fix for adding non-public library The code in admin/branches.pl changed a 0 to undef which is not desirable for booleans. A similar fix was already present for pickup_location. This may need a bit more thought (somewhere else!). Test plan: Add a new branch with pickup location No, public No. Check. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:45:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:45:44 +0000 Subject: [Koha-bugs] [Bug 31785] Adding a new library does not respect public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off --- Comment #3 from Marcel de Rooy --- Trivial: self SO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:48:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:48:14 +0000 Subject: [Koha-bugs] [Bug 31785] Adding a new library does not respect public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141863|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 141864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141864&action=edit Bug 31785: Fix for adding non-public library The code in admin/branches.pl changed a 0 to undef which is not desirable for booleans. A similar fix was already present for pickup_location. This may need a bit more thought (somewhere else!). Test plan: Add a new branch with pickup location No, public No. Check. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:49:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:49:16 +0000 Subject: [Koha-bugs] [Bug 31785] Adding a new library does not respect public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate CC| |tomascohen at gmail.com --- Comment #5 from Marcel de Rooy --- Added a ^ and $ to be more safe :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:50:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:50:39 +0000 Subject: [Koha-bugs] [Bug 31775] Show opac_info of single library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 --- Comment #7 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #5) > > . Creating a new library - even if you change public to "No", it saves as > > public with "Yes". > Yes, good catch. Editing existing libraries works here. But adding a library > does not respect the public flag! Opening a new report. Fixed on bug 31785 now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 09:56:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 07:56:08 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #77 from Katrin Fischer --- (In reply to David Cook from comment #62) > (In reply to Katrin Fischer from comment #21) > > I just noticed that you need to run the database update for Koha to work. > > Not sure if this could cause problem with the web installer. > > > > Error while loading /etc/koha/sites/kohadev/plack.psgi: Can't load > > application from file "/kohadevbox/koha/api/v1/app.pl": > > DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st > > execute failed: Table 'koha_kohadev.auth_providers' doesn't exist at > > /kohadevbox/koha/Koha/Objects.pm line 312 > > This is certainly an issue. I'm looking at follow-ups... Thx David :) Read your comment below and I think it describes the problem well, package installations being probably ok, but others could get trapped with the web installer not coming up to tell them about the missing package. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 10:25:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 08:25:05 +0000 Subject: [Koha-bugs] [Bug 31763] Add 'page-section' to patron lists page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141845|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 141865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141865&action=edit Bug 31763: Add 'page-section' to patron lists page This patch updates patron lists templates so that the main content of the page is wrapped with a "page-section" div. This ensures that content has sufficient contrast. See Bug 31757. Unrelated change: I wrapped some form controls in a
    to make it consistent with other pages and to work better with the updated markup. Note: This patch contains indentation changes, so use diff accordingly. To test, apply the patch and go to Tools -> Patron lists. - If necessary, create one or more patron lists so that the table appears. Confirm that the content area looks correct. - Click Actions -> Add patrons to confirm that the screen looks correct. Signed-off-by: Lucas Gass Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 10:26:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 08:26:03 +0000 Subject: [Koha-bugs] [Bug 31763] Add 'page-section' to patron lists page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- Looks good, thanks for the quick work. Passing QA.. Thanks for opening another bug regarding autocomplete.. that confused me for a moment too before I read your comments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 11:07:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 09:07:26 +0000 Subject: [Koha-bugs] [Bug 31437] ModItemTransfer triggers indexing twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31437 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 11:07:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 09:07:31 +0000 Subject: [Koha-bugs] [Bug 31437] ModItemTransfer triggers indexing twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31437 --- Comment #1 from Jonathan Druart --- Created attachment 141866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141866&action=edit Revert "Bug 30718: (follow-up) index_records is called more times than we thought" This reverts commit 35165e5f13ec11a62dea7f6b129f7f07c7ecb7f4. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 11:07:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 09:07:35 +0000 Subject: [Koha-bugs] [Bug 31437] ModItemTransfer triggers indexing twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31437 --- Comment #2 from Jonathan Druart --- Created attachment 141867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141867&action=edit Bug 31437: (bug 30718 follow-up) Prevent useless indexation call from ModDateLastSeen Koha::Object->store is triggering an UPDATE because the datelastseen is different than the value in DB (comparing a datetime with a date) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 11:07:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 09:07:54 +0000 Subject: [Koha-bugs] [Bug 31437] ModItemTransfer triggers indexing twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31437 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Severity|enhancement |major Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 11:08:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 09:08:51 +0000 Subject: [Koha-bugs] [Bug 31785] Adding a new library does not respect public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31785 --- Comment #6 from Marcel de Rooy --- Created attachment 141868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141868&action=edit Bug 31785: (follow-up) Fix modify operation too Test plan: Enable SQL strict mode (koha-conf). Modify branch, set Public to No. Check. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 11:11:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 09:11:45 +0000 Subject: [Koha-bugs] [Bug 31782] Patron lists - patron autocomplete search does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- This feels related to bug 30578.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 11:11:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 09:11:50 +0000 Subject: [Koha-bugs] [Bug 7050] Error in French web installer - sample_labels.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7050 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #4 from Jonathan Druart --- sample_labels.sql has been removed by bug 27619. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 11:14:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 09:14:51 +0000 Subject: [Koha-bugs] [Bug 31394] background hold cancellation causing confusion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31394 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major CC| |jonathan.druart+koha at gmail. | |com, tomascohen at gmail.com Version|21.11 |unspecified -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 11:18:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 09:18:43 +0000 Subject: [Koha-bugs] [Bug 31785] Adding or editing library does not respect public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Adding a new library does |Adding or editing library |not respect public flag |does not respect public | |flag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 11:19:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 09:19:39 +0000 Subject: [Koha-bugs] [Bug 31785] Adding or editing library does not respect public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31785 --- Comment #7 from Marcel de Rooy --- Strict SQL mode triggers the error on update. [WARN] DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'public' cannot be null at /usr/share/koha/Koha/Object.pm line 170 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 11:20:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 09:20:21 +0000 Subject: [Koha-bugs] [Bug 31785] Adding or editing library does not respect public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31785 --- Comment #8 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #7) > Strict SQL mode triggers the error on update. > > [WARN] DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: > DBD::mysql::st execute failed: Column 'public' cannot be null at > /usr/share/koha/Koha/Object.pm line 170 Fixed in the follow-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 11:20:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 09:20:24 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 11:20:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 09:20:31 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138309|0 |1 is obsolete| | Attachment #138310|0 |1 is obsolete| | --- Comment #35 from Kevin Carnes --- Created attachment 141869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141869&action=edit Bug 29012: Add default values for blank circulation rules that weren't saved to the database There are 5 fields that are not set if no value is provided when saving/editing a rule in Administration->Circulation and fines rules - issuelength - hardduedate - unseenrenewalsallowed - rentaldiscount - decreaseloanholds This is problematic because it gives the impression these rules are set as blank, but in reality they don't exist and the rule will fal back to the higher level To test: 1 - Set a rule for Patron category: Teacher Itemtype: All Hard due date: (Today) Lona period: 10 2 - Set a rule for Patron category: Teacher Itemtype: Books Hard due date: (leave blank) Loan period: 10 3 - Expected behaviour is Book item will checkout to teacher for 10 days, all other types will be due yesterday at 25:59:00 4 - Checkout an non-book item type to teacher 5 - Hard due date applies 6 - Checkout a 'book' item type to teacher 7 - Hard due date applies - FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 11:28:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 09:28:54 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #36 from Kevin Carnes --- (In reply to Andrew Nugged from comment #33) > ok, so everything what was done above this message is OBSOLETE now, > > Kevin Carnes, are you ok with committing here new solution from base? > > (please mind the patches if something were useful in Bug 31727 too). Ok, now the patch includes all the changes including bugs 31727 and 31737, but without the new atomic update. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 11:31:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 09:31:26 +0000 Subject: [Koha-bugs] [Bug 31737] Undef warnings around unseen_renewals_allowed in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31737 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin.carnes at ub.lu.se Status|Needs Signoff |RESOLVED Resolution|--- |FIXED --- Comment #3 from Kevin Carnes --- Thanks for catching this. It's been decided I should update the patch since it hasn't been released yet. I went ahead and included your fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 11:35:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 09:35:25 +0000 Subject: [Koha-bugs] [Bug 31785] Adding or editing library does not respect public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31785 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #9 from David Nind --- Can confirm that this now works as expected - can now edit a library and change public to 'No', and change back to 'Yes'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 11:48:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 09:48:46 +0000 Subject: [Koha-bugs] [Bug 31787] New: [DOCS] Add description and examples to membership_expiry.pl about --where option Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31787 Bug ID: 31787 Summary: [DOCS] Add description and examples to membership_expiry.pl about --where option Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org An optional `--where` parameter was added to the `membership_expiry.pl` cronjob in 21.11. This allows for arbitrarily complex SQL where statements to be passed to the script to filter affected patrons. Add some additional information about this, and some examples on how to construct SQL queries, for example: to restrict to patrons in a specific category. See IRC discussion: http://irc.koha-community.org/koha/2022-10-14#i_2456049 See bug 28456. Topic affected: https://koha-community.org/manual/22.11/en/html/cron_jobs.html#notify-patrons-of-expiration -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 11:49:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 09:49:17 +0000 Subject: [Koha-bugs] [Bug 31787] [DOCS] Add description and examples to membership_expiry.pl about --where option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31787 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28456 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 11:49:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 09:49:17 +0000 Subject: [Koha-bugs] [Bug 28456] Add option to use a WHERE statement in membership_expiry.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31787 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 11:59:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 09:59:45 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 --- Comment #9 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #5) > Coding guidelines mention snakecase for subroutines ;) Het kwartje is gevallen :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 12:07:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 10:07:26 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 --- Comment #10 from Marcel de Rooy --- Created attachment 141870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141870&action=edit Bug 31784: (QA follow-up) Snake case for subroutine singleLibraryMode => single_library_mode Test plan: Run t/db_dependent/Koha/Libraries.t Run qa tools. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 12:20:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 10:20:22 +0000 Subject: [Koha-bugs] [Bug 31775] Show opac_info of single library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 12:20:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 10:20:27 +0000 Subject: [Koha-bugs] [Bug 31775] Show opac_info of single library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141824|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 141871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141871&action=edit Bug 31775: Show single library Test plan: Check both cases: one library (public accessible) and more libraries (public accessible). In the latter case click on one of these libraries too. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 12:20:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 10:20:32 +0000 Subject: [Koha-bugs] [Bug 31775] Show opac_info of single library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141825|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 141872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141872&action=edit Bug 31775: Template cleanup Removing unused parts. Test plan: See first test plan. Confirm that it still works. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 12:25:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 10:25:31 +0000 Subject: [Koha-bugs] [Bug 31775] Show opac_info of single library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 --- Comment #10 from David Nind --- Testing notes (using koha-testing-docker). 1. I applied bug 31785 (so can toggle Public to No) (Alternative is to use SQL: update branches set public=0; and then set two libraries back to Yes.) 2. Add some additional information to the OPAC page for a library (for example, Centerville) at Tools > Additional tools > HTML customisations > New entry > select OpacLibraryInfo 3. Check the OPAC page for the library to make sure this is visible: OPAC Home > Libraries > [List of Libraries] > click link for Centerville: - Note that for the list of libraries, each library is linked to an individual page - On the list of libraries page, the information entered in the Libraries Administration area is displayed - Note that for the individual library page it includes the information on the listing page, as well as any info entered in step 2 4. Make all other libraries except Centerville not public: Administration > Basic parameters > Libraries: - Change public to no for all libraries except Centerville (see step 1 for the SQL way to make this change) 5. Visit the OPAC page for the list of libraries: http://127.0.0.1:8080/cgi-bin/koha/opac-library.pl . Note that there is no link to the individual Centerville page . Note that only the basic library information entered in Administration > Basic parameters > Libraries is displayed 6. Apply the patch and refresh the list of libraries page: - Note that Centerville is now linked - On the individual library page for Centerville you now have the basic information and the information from step 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 12:29:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 10:29:22 +0000 Subject: [Koha-bugs] [Bug 31786] Sub template->param($var) should return the value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31786 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 12:36:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 10:36:18 +0000 Subject: [Koha-bugs] [Bug 31509] Additional contents: Allow changing the column 'code' that groups records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31509 --- Comment #5 from Jonathan Druart --- If we really want to fix the mess we should split the table into 2 different tables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 13:22:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 11:22:03 +0000 Subject: [Koha-bugs] [Bug 26635] Expand authorised values in REST API call In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|agustinmoyano at theke.io |tomascohen at gmail.com Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 13:33:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 11:33:38 +0000 Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Keywords|additional_work_needed | Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 13:33:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 11:33:39 +0000 Subject: [Koha-bugs] [Bug 23247] Use EmbedItems in opac-MARCdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Bug 23247 depends on bug 29697, which changed state. Bug 29697 Summary: Replace GetMarcBiblio occurrences with $biblio->metadata->record https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 13:33:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 11:33:39 +0000 Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 Bug 31224 depends on bug 29697, which changed state. Bug 29697 Summary: Replace GetMarcBiblio occurrences with $biblio->metadata->record https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 13:33:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 11:33:39 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Bug 27272 depends on bug 29697, which changed state. Bug 29697 Summary: Replace GetMarcBiblio occurrences with $biblio->metadata->record https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 13:35:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 11:35:29 +0000 Subject: [Koha-bugs] [Bug 31783] Table settings page needs page-section class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31783 --- Comment #2 from Owen Leonard --- I think I disagree on this one. The main difference between the current interface and the pre-redesign one is the table borders. The table row highlighting is even a little darker in the redesign. In my opinion the interface is too busy with the added page-section class. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 13:42:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 11:42:17 +0000 Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 13:42:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 11:42:25 +0000 Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 13:43:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 11:43:57 +0000 Subject: [Koha-bugs] [Bug 29554] neworderempty.pl may create records with biblioitems.itemtype NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554 Slava Shishkin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141488|0 |1 is obsolete| | --- Comment #19 from Slava Shishkin --- Created attachment 141873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141873&action=edit Bug 29554: Do not hide display of itemtypes on neworderempty Hiding the list may lead to biblioitems.itemtype being NULL. We do not want that, since 942$c is mandatory. Test plan: Create basket and set 'create items when' to receiving or cataloging. Create order from new empty record. Check biblioitems.itemtype of created biblio. Without this patch, it would have been NULL like this: select biblionumber,title from biblio; | 7 | Test 3 | select biblionumber,itemtype from biblioitems; | 7 | NULL | Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 13:47:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 11:47:35 +0000 Subject: [Koha-bugs] [Bug 31394] background hold cancellation causing confusion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31394 --- Comment #2 from Tomás Cohen Arazi --- Maybe we could solve it by adding the progress bar, and just refreshing the table after the job finishes? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:01:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:01:06 +0000 Subject: [Koha-bugs] [Bug 30403] Update notforloan status also on check out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 catherine.dupuy-lenen at univ-rennes1.fr changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from catherine.dupuy-lenen at univ-rennes1.fr --- I tested this patch once (Koha 21.05 or 21.11, I don't remember) and it worked, but when I retest (koha 22.06) I get an error when I apply the patch : "Applying: Bug 30403: Add syspref UpdateNotForLoanStatusOnCheckout Using index info to reconstruct a base tree... M C4/Circulation.pm M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref M t/db_dependent/Circulation/issue.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Circulation/issue.t CONFLICT (content): Merge conflict in t/db_dependent/Circulation/issue.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging installer/data/mysql/mandatory/sysprefs.sql Auto-merging C4/Circulation.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 30403: Add syspref UpdateNotForLoanStatusOnCheckout" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:08:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:08:09 +0000 Subject: [Koha-bugs] [Bug 31788] New: REST API: CRUD endpoints for Biblios [omnibus] Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31788 Bug ID: 31788 Summary: REST API: CRUD endpoints for Biblios [omnibus] Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org - Single Record per Call - Accept data as marcxml - Support POST, GET, PUT, DELETE - Handle items during the create, and strip 952 - Return Bib ID upon successful creation - No PATCH, a full record per call is expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:08:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:08:28 +0000 Subject: [Koha-bugs] [Bug 31788] REST API: CRUD endpoints for Biblios [omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31788 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17371 Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:08:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:08:28 +0000 Subject: [Koha-bugs] [Bug 17371] Add routes for biblios [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31788 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:08:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:08:35 +0000 Subject: [Koha-bugs] [Bug 31788] REST API: CRUD endpoints for Biblios [omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31788 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:10:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:10:15 +0000 Subject: [Koha-bugs] [Bug 31240] Search bar disappears on two_factor_auth page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31240 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- Looks like it's fixed now (maybe by bug 30952?) Please reopen if I am wrong! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:10:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:10:16 +0000 Subject: [Koha-bugs] [Bug 20476] Two factor authentication for the staff client - omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476 Bug 20476 depends on bug 31240, which changed state. Bug 31240 Summary: Search bar disappears on two_factor_auth page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31240 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:11:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:11:17 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Slava Shishkin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |slavashishkin at gmail.com --- Comment #37 from Slava Shishkin --- Kevin, I have conflicts applying to the current master. Can you check? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:11:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:11:41 +0000 Subject: [Koha-bugs] [Bug 31789] New: REST API: CRUD endpoint for Items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31789 Bug ID: 31789 Summary: REST API: CRUD endpoint for Items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org - Single Item per Call - Accept JSON data of item - Support POST, GET, PUT, DELETE -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:11:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:11:58 +0000 Subject: [Koha-bugs] [Bug 31789] REST API: CRUD endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31789 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31788 Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:11:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:11:58 +0000 Subject: [Koha-bugs] [Bug 31788] REST API: CRUD endpoints for Biblios [omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31788 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31789 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:15:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:15:45 +0000 Subject: [Koha-bugs] [Bug 31790] New: REST API: CRUD endpoints for Authorities [omnibus] Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31790 Bug ID: 31790 Summary: REST API: CRUD endpoints for Authorities [omnibus] Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -Single Record per Call -Accept data as marcxml -Support POST, GET, PUT, DELETE -Return ID upon successful creation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:16:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:16:04 +0000 Subject: [Koha-bugs] [Bug 31790] REST API: CRUD endpoints for Authorities [omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31790 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31788 Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:16:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:16:04 +0000 Subject: [Koha-bugs] [Bug 31788] REST API: CRUD endpoints for Biblios [omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31788 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31790 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:18:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:18:33 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #38 from Andrew Nugged --- Slava/Kevin: I think it's because Tomás not yet reverted the master from old 29012. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:20:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:20:55 +0000 Subject: [Koha-bugs] [Bug 31791] New: Add the ability to lock records to prevent modification through the Koha staff interface(s). Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Bug ID: 31791 Summary: Add the ability to lock records to prevent modification through the Koha staff interface(s). Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl - Add a read-only field - The read-only field will only be editable by superlibrarian - Koha can update these internally for related routines -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:21:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:21:34 +0000 Subject: [Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s). In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:22:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:22:59 +0000 Subject: [Koha-bugs] [Bug 31437] ModItemTransfer triggers indexing twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31437 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:23:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:23:02 +0000 Subject: [Koha-bugs] [Bug 31437] ModItemTransfer triggers indexing twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31437 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141866|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:23:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:23:05 +0000 Subject: [Koha-bugs] [Bug 31437] ModItemTransfer triggers indexing twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31437 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141867|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:23:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:23:30 +0000 Subject: [Koha-bugs] [Bug 31437] ModItemTransfer triggers indexing twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31437 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 141874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141874&action=edit Revert "Bug 30718: (follow-up) index_records is called more times than we thought" This reverts commit 35165e5f13ec11a62dea7f6b129f7f07c7ecb7f4. https://bugs.koha-community.org/show_bug.cgi?id=31437 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:23:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:23:35 +0000 Subject: [Koha-bugs] [Bug 31437] ModItemTransfer triggers indexing twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31437 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 141875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141875&action=edit Bug 31437: (bug 30718 follow-up) Prevent useless indexation call from ModDateLastSeen Koha::Object->store is triggering an UPDATE because the datelastseen is different than the value in DB (comparing a datetime with a date) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:23:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:23:38 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #39 from Kevin Carnes --- Created attachment 141876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141876&action=edit Revert "Bug 29012: DBRev 22.06.00.024" This reverts commit 51cef8c0ec1eca244ebafb853a9164bde65941cb. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:24:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:24:00 +0000 Subject: [Koha-bugs] [Bug 31437] ModItemTransfer triggers indexing twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31437 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:24:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:24:33 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #40 from Kevin Carnes --- Created attachment 141877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141877&action=edit Revert "Bug 29012: (QA follow-up) Use q{} instead of '' in smart-rules.pl" This reverts commit 6f8e77b4e899d6f71fb8987975ba916a65dc8229. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:24:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:24:58 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #41 from Kevin Carnes --- Created attachment 141878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141878&action=edit Revert "Bug 29012: Add default values for blank circulation rules that weren't saved to the database" This reverts commit cf397ac3bcbc93a508954c836d1cb90a84fb2ac6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:25:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:25:14 +0000 Subject: [Koha-bugs] [Bug 31792] New: Serial Patterns: Customize to allow for both full date and enumeration Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31792 Bug ID: 31792 Summary: Serial Patterns: Customize to allow for both full date and enumeration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -Add option to format publication date using templates - Add option for seasons - Month/Day/Year in various orders and formats -Display formatted publication date when showing serial enumeration -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:25:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:25:19 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141869|0 |1 is obsolete| | --- Comment #42 from Kevin Carnes --- Created attachment 141879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141879&action=edit Bug 29012: Add default values for blank circulation rules that weren't saved to the database There are 5 fields that are not set if no value is provided when saving/editing a rule in Administration->Circulation and fines rules - issuelength - hardduedate - unseenrenewalsallowed - rentaldiscount - decreaseloanholds This is problematic because it gives the impression these rules are set as blank, but in reality they don't exist and the rule will fal back to the higher level To test: 1 - Set a rule for Patron category: Teacher Itemtype: All Hard due date: (Today) Lona period: 10 2 - Set a rule for Patron category: Teacher Itemtype: Books Hard due date: (leave blank) Loan period: 10 3 - Expected behaviour is Book item will checkout to teacher for 10 days, all other types will be due yesterday at 25:59:00 4 - Checkout an non-book item type to teacher 5 - Hard due date applies 6 - Checkout a 'book' item type to teacher 7 - Hard due date applies - FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:25:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:25:21 +0000 Subject: [Koha-bugs] [Bug 31792] Serial Patterns: Customize to allow for both full date and enumeration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31792 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:25:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:25:46 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #15 from Jonathan Druart --- Shouldn't we watch for perl files only? What about git checkout branch? Is it going to send 1 signal per file modified? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:27:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:27:05 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #43 from Kevin Carnes --- (In reply to Slava Shishkin from comment #37) > Kevin, I have conflicts applying to the current master. Can you check? I added some revert patches. They can be removed when no longer needed. Otherwise I can make a patch that works with the patch already in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:32:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:32:41 +0000 Subject: [Koha-bugs] [Bug 31724] MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #8 from Tomás Cohen Arazi --- Vim users.... haha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:33:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:33:38 +0000 Subject: [Koha-bugs] [Bug 31437] ModItemTransfer triggers indexing twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31437 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:33:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:33:41 +0000 Subject: [Koha-bugs] [Bug 31437] ModItemTransfer triggers indexing twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31437 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:33:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:33:44 +0000 Subject: [Koha-bugs] [Bug 31724] MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:33:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:33:47 +0000 Subject: [Koha-bugs] [Bug 31724] MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:33:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:33:50 +0000 Subject: [Koha-bugs] [Bug 31763] Add 'page-section' to patron lists page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:33:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:33:53 +0000 Subject: [Koha-bugs] [Bug 31763] Add 'page-section' to patron lists page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:42:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:42:25 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #44 from Slava Shishkin --- Good, thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 14:53:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 12:53:30 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #45 from Nick Clemens --- As we have time before release, and we have fixes - do we need to revert, or can we just fix the DB updates here and push those? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 15:03:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 13:03:16 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #46 from Kevin Carnes --- (In reply to Nick Clemens from comment #45) > As we have time before release, and we have fixes - do we need to revert, or > can we just fix the DB updates here and push those? I think just fixing the DB updates here should be fine. Perhaps I misunderstood that this would be reverted (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727#c14). Since it hasn't been reverted yet, perhaps it's still possible to cancel the revert and just fix it here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 15:09:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 13:09:35 +0000 Subject: [Koha-bugs] [Bug 31783] Table settings page needs page-section class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31783 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 15:22:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 13:22:26 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed CC| |jonathan.druart+koha at gmail. | |com --- Comment #72 from Jonathan Druart --- Caught by Owen on IRC: DT search is broken (general search when searching for libraries). Uncaught TypeError: col.data.split is not a function It's because opac_info is searchable but "data" is a function: "data": function( row, type, val, meta ) { return ''; // provisional placeholder for opac_info }, "searchable": true, "visible": false, "orderable": false It could be considered a bug from datatables.js, but I don't think it is. We should fix branch.tt instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 15:30:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 13:30:48 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #13 from Jonathan Druart --- job_progress is the only file in 'includes' to have '_' instead of '-' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 15:41:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 13:41:57 +0000 Subject: [Koha-bugs] [Bug 30515] Move Overdue transports to patron messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #6 from Jonathan Druart --- I don't think we should hardcode the 3 codes. It will make harder to improve this area (like bug 12771). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 15:42:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 13:42:13 +0000 Subject: [Koha-bugs] [Bug 30515] Move Overdue transports to patron messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12771 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 15:42:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 13:42:13 +0000 Subject: [Koha-bugs] [Bug 12771] Enhancement to manage more than 3 levels of overdue notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12771 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30515 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:00:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:00:22 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com --- Comment #75 from Jonathan Druart --- (In reply to Martin Renvoize from comment #72) > This one really is vitally important for 21.11's.. I've added the > rel_21_11_candidate keyword to try and grab the attention of the rmaint (and > left a later on irc too) ping Arthur, did you get that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:10:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:10:14 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #77 from Martin Renvoize --- (In reply to David Nind from comment #73) > Hi Martin. > > I've tested again and have some more feedback and comments. > > Feedback - bring back the toolbar? > ---------------------------------- > > Should we bring back the toolbar at the top (with Advanced editor, New > record and New from Z3950/SRYU buttons) rather than try fitting under the > "New" sub-heading? > > Rationale: > > - While some styling is required, it looks a little "odd" to me as it is - > I don't think we have a dropdown button mingled with options in other areas > as part of a landing page. > > - Familiarity for cataloguers - the key options used are in a familiar place. OK, I've done this and will post the updated patches imminently. > Feedback - Rotating collections > ------------------------------- > > There doesn't appear to be a link to Rotating collections, unless this is > controlled by another system preference. Yup, I left that in 'Tools' for now.. I'm considering moving it to 'Circulation' actually.. it feels like it's really a 'bulk transfer' feature and thus fits within circulation? > Some other comments > ------------------- > > 1. I like the idea of the separate bugs for the breadcrumbs and the sidebar > changes - makes it easier to do a step at a time, rather than a large change > all in one bug. Awesome, once we've completely finalised this one I'll move on to getting those sorted in in line with this. > 2. Should there be a separate bug to move the permissions from tools to > editcatalogue? Good call.. I didn't consider the permissions at all at this time, but it makes a lot of sense to move those eventually too. > 3. Should there be a separate bug to move the system preferences from Tools > (or other areas) to Cataloging? Not entirely sure what we mean by this one.. do you mean the 'cataloging' tab that's in global system preferences under administration right now? > 4. From Heather's comment #72, should we also have a separate bug to look at > the Administration settings? As a compromise (or first step) we could have > an option/link to "Catalog administration" or "Catalog configuration", or > something similar. Wow, there's lots of advanced config like frameworks and things that's all configured from 'Administration'.. I'd not considered those either.. perhaps another bug. For now I've added an 'Administration' section with two links, one to the main admin home page and one to the cataloging tab of global preferences. > 5. The tools currently have a description in their old location on the tools > page. Do we need these, or do we have a way of adding a tooltip with the > description? We don't on the staff interface home page, so maybe there is > not an issue. There's a bug for this one already: bug #31427 > 6. Some tools are also used for authorities (such as Batch record deletion, > Batch record modification, Export data, Stage MARC records for import). Just > trying to think about how we would approach these if we adopt this approach > for other modules - do we split these tools (separate out the cataloging vs > authority parts), make an arbitrary decision on where they should be, or > have a way for the breadcrumbs/URLs to recognise what area we are in > (Cataloging, Authorities, etc) and then reflect that? Probably thinking too > far ahead at the moment.... Hmm, to me Cataloging and Authorities are very closely tied.. I sort of think about them as living in the same place really.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:12:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:12:17 +0000 Subject: [Koha-bugs] [Bug 29001] Subfields attributes are not preserved when order is changed in framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31238 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238 [Bug 31238] Unable to save authorised value to frameworks subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:12:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:12:17 +0000 Subject: [Koha-bugs] [Bug 31238] Unable to save authorised value to frameworks subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29001 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001 [Bug 29001] Subfields attributes are not preserved when order is changed in framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:12:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:12:27 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141246|0 |1 is obsolete| | --- Comment #78 from Martin Renvoize --- Created attachment 141880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141880&action=edit Bug 31162: Add a cataloging module home page This patch adds a new cataloging-home template and controller and replaces most cases of links to addbooks. This servers to provide a new cataloging home page for the cataloging module and keeps it distinct from the current addbooks page it partially replaces as a stating point for cataloging. Signed-off-by: KIT Signed-off-by: Emmanuel Bétemps Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:12:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:12:33 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141247|0 |1 is obsolete| | --- Comment #79 from Martin Renvoize --- Created attachment 141881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141881&action=edit Bug 31162: Remove toolbar This patch removes the existing toolbar with 'New record' and 'New from Z39.50/SRU' and replaces the functionality with simple buttons on the page. We lose the ability to select the Framework or Z39.50/SRU server at this stage but one can still select these options from the resulting dialogues. Signed-off-by: Emmanuel Bétemps Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:12:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:12:39 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141248|0 |1 is obsolete| | --- Comment #80 from Martin Renvoize --- Created attachment 141882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141882&action=edit Bug 31162: (follow-up) 3 Column layout This patch converts to a 3 column layout as suggested by David. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:12:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:12:45 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141249|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize --- Created attachment 141883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141883&action=edit Bug 31162: Remove duplicates from tools-home This patch removes cataloging tools from the tools-home page where they are now listed on the cataloging home page. This leaves just two options in the 'Cataloging' section of the tools home page, 'Rotating collections' and 'Upload local cover images'. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:12:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:12:51 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141250|0 |1 is obsolete| | --- Comment #82 from Martin Renvoize --- Created attachment 141884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141884&action=edit Bug 31162: More conditionals for sections This adds missing conditionals to the section headings in the new cataloging homepage. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:12:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:12:57 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141251|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize --- Created attachment 141885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141885&action=edit Bug 31162: Move Rotating Collections and Upload Covers This patch moves the 'Rotating Collections' link from 'Cataloging' to 'Circulation' on the 'Tools' home page and moves the 'Upload local cover image' link to the 'Cataloging' home page. This removes the 'Cataloging' tools section entirely and as such the template is adapted to a two column layout to compensate. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:13:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:13:04 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141252|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize --- Created attachment 141886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141886&action=edit Bug 31162: Fix help link on catalouging start page Now the link goes to the cataloguing chapter start page of the manual instead of the less specific manual start page. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:13:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:13:09 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141253|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize --- Created attachment 141887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141887&action=edit Bug 31162: (QA follow-up) Change Automations to Automation This was suggested by David Nind in testing and I agree that it sounds a litle nicer. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:13:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:13:15 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141254|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize --- Created attachment 141888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141888&action=edit Bug 31162: Restore ability to pick framework This patch restores the ability to pick the framework via a dropdown on the cataloguing home page. The CSS needs some work.. this is a proof of concept -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:13:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:13:24 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #87 from Martin Renvoize --- Created attachment 141889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141889&action=edit Bug 31162: (follow-up) Restore toolbar This patch reverts to having the 'New' options in the top toolbar as feedback suggested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:13:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:13:31 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #88 from Martin Renvoize --- Created attachment 141890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141890&action=edit Bug 31162: (follow-up) Add links to administration area's -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:16:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:16:20 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #89 from Martin Renvoize --- This will need a squash once people are happy with it.. there's a lot of 'do this, undo it, do that' going on at this point. Hopefully this'll be the iteration that people agree to go with. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:17:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:17:34 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement tries to release notes| |bring a bit more order the | |cataloging features. We | |create a new 'Cataloging' | |module home page and try to | |collect the cataloging | |tools into it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:17:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:17:50 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement tries to |This enhancement tries to release notes|bring a bit more order the |bring a bit more order the |cataloging features. We |cataloguing features. We |create a new 'Cataloging' |create a new 'Cataloguing' |module home page and try to |module home page and try to |collect the cataloging |collect the cataloguing |tools into it. |tools into it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:25:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:25:59 +0000 Subject: [Koha-bugs] [Bug 31611] More visibly highlight records that cannot be batch deleted/modified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #6 from Jonathan Druart --- Why did you remove "Clear on loan"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:29:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:29:36 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139654|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:29:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:29:49 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139598|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:29:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:29:52 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Sara Brown changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbrown at bywatersolutions.com --- Comment #2 from Sara Brown --- This would be great! Once it's added to statistics, it would be helpful to have it added to the pseudonymization options too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:30:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:30:01 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138799|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:30:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:30:32 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #90 from Martin Renvoize --- Created attachment 141891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141891&action=edit Current Iteration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:33:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:33:35 +0000 Subject: [Koha-bugs] [Bug 31793] New: REST API: DELETE endpoint for Authorities Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31793 Bug ID: 31793 Summary: REST API: DELETE endpoint for Authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:34:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:34:04 +0000 Subject: [Koha-bugs] [Bug 31793] REST API: DELETE endpoint for Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31793 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31790 Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31790 [Bug 31790] REST API: CRUD endpoints for Authorities [omnibus] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:34:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:34:04 +0000 Subject: [Koha-bugs] [Bug 31790] REST API: CRUD endpoints for Authorities [omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31790 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31793 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31793 [Bug 31793] REST API: DELETE endpoint for Authorities -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:34:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:34:26 +0000 Subject: [Koha-bugs] [Bug 31794] New: REST API: GET endpoint for Authorities Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31794 Bug ID: 31794 Summary: REST API: GET endpoint for Authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:34:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:34:54 +0000 Subject: [Koha-bugs] [Bug 31794] REST API: GET endpoint for Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31794 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Blocks| |31790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31790 [Bug 31790] REST API: CRUD endpoints for Authorities [omnibus] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:34:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:34:54 +0000 Subject: [Koha-bugs] [Bug 31790] REST API: CRUD endpoints for Authorities [omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31790 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31794 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31794 [Bug 31794] REST API: GET endpoint for Authorities -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:35:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:35:16 +0000 Subject: [Koha-bugs] [Bug 31795] New: REST API: POST endpoint for Authorities Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 Bug ID: 31795 Summary: REST API: POST endpoint for Authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:35:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:35:38 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Blocks| |31790 Change sponsored?|--- |Sponsored Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31790 [Bug 31790] REST API: CRUD endpoints for Authorities [omnibus] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:35:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:35:38 +0000 Subject: [Koha-bugs] [Bug 31790] REST API: CRUD endpoints for Authorities [omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31790 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31795 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 [Bug 31795] REST API: POST endpoint for Authorities -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:35:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:35:59 +0000 Subject: [Koha-bugs] [Bug 31796] New: REST API: PUT endpoint for Authorities Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31796 Bug ID: 31796 Summary: REST API: PUT endpoint for Authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:36:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:36:16 +0000 Subject: [Koha-bugs] [Bug 31796] REST API: PUT endpoint for Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31796 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Blocks| |31790 Change sponsored?|--- |Sponsored Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31790 [Bug 31790] REST API: CRUD endpoints for Authorities [omnibus] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:36:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:36:16 +0000 Subject: [Koha-bugs] [Bug 31790] REST API: CRUD endpoints for Authorities [omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31790 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31796 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31796 [Bug 31796] REST API: PUT endpoint for Authorities -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:36:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:36:36 +0000 Subject: [Koha-bugs] [Bug 31790] REST API: CRUD endpoints for Authorities [omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31790 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:38:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:38:02 +0000 Subject: [Koha-bugs] [Bug 31797] New: REST API: DELETE endpoint for Items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31797 Bug ID: 31797 Summary: REST API: DELETE endpoint for Items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com CC: tomascohen at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:38:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:38:30 +0000 Subject: [Koha-bugs] [Bug 31797] REST API: DELETE endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31797 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31789 Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31789 [Bug 31789] REST API: CRUD endpoint for Items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:38:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:38:30 +0000 Subject: [Koha-bugs] [Bug 31789] REST API: CRUD endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31789 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31797 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31797 [Bug 31797] REST API: DELETE endpoint for Items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:38:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:38:53 +0000 Subject: [Koha-bugs] [Bug 31798] New: REST API: POST endpoint for Items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Bug ID: 31798 Summary: REST API: POST endpoint for Items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com CC: tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:39:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:39:11 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Blocks| |31789 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31789 [Bug 31789] REST API: CRUD endpoint for Items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:39:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:39:11 +0000 Subject: [Koha-bugs] [Bug 31789] REST API: CRUD endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31789 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31798 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 [Bug 31798] REST API: POST endpoint for Items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:39:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:39:32 +0000 Subject: [Koha-bugs] [Bug 31799] New: REST API: PUT endpoint for Items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 Bug ID: 31799 Summary: REST API: PUT endpoint for Items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com CC: tomascohen at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:39:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:39:47 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31789 Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31789 [Bug 31789] REST API: CRUD endpoint for Items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:39:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:39:47 +0000 Subject: [Koha-bugs] [Bug 31789] REST API: CRUD endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31789 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31799 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 [Bug 31799] REST API: PUT endpoint for Items -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:41:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:41:06 +0000 Subject: [Koha-bugs] [Bug 31800] New: REST API: POST endpoint for Biblios Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31800 Bug ID: 31800 Summary: REST API: POST endpoint for Biblios Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com CC: tomascohen at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:41:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:41:28 +0000 Subject: [Koha-bugs] [Bug 31800] REST API: POST endpoint for Biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31800 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31788 Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31788 [Bug 31788] REST API: CRUD endpoints for Biblios [omnibus] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:41:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:41:28 +0000 Subject: [Koha-bugs] [Bug 31788] REST API: CRUD endpoints for Biblios [omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31788 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31800 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31800 [Bug 31800] REST API: POST endpoint for Biblios -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:41:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:41:59 +0000 Subject: [Koha-bugs] [Bug 31801] New: REST API: PUT endpoint for Biblios Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31801 Bug ID: 31801 Summary: REST API: PUT endpoint for Biblios Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com CC: tomascohen at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:42:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:42:18 +0000 Subject: [Koha-bugs] [Bug 31801] REST API: PUT endpoint for Biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31801 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Blocks| |31788 Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31788 [Bug 31788] REST API: CRUD endpoints for Biblios [omnibus] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:42:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:42:18 +0000 Subject: [Koha-bugs] [Bug 31788] REST API: CRUD endpoints for Biblios [omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31788 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31801 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31801 [Bug 31801] REST API: PUT endpoint for Biblios -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:43:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:43:03 +0000 Subject: [Koha-bugs] [Bug 31788] REST API: CRUD endpoints for Biblios [omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31788 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:43:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:43:47 +0000 Subject: [Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s). In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:45:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:45:36 +0000 Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759 --- Comment #1 from Owen Leonard --- Created attachment 141892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141892&action=edit Bug 31759: Tabs vs Pills - Test pills design This patch depends on Bug 30487. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 16:51:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 14:51:29 +0000 Subject: [Koha-bugs] [Bug 31780] Add 'page-section' to audio alerts ( audio_alerts.tt ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31780 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141847|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 141893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141893&action=edit Bug 31780: Add page-section class to audio alerts To test: 1. Apply the patch and go to Administration -> Audio alerts 2. Confirm that the screen/table look correct with the page-section class added. Note: There are some indentation changes. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:00:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:00:38 +0000 Subject: [Koha-bugs] [Bug 31780] Add 'page-section' to audio alerts ( audio_alerts.tt ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31780 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:02:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:02:23 +0000 Subject: [Koha-bugs] [Bug 31780] Add 'page-section' to audio alerts ( audio_alerts.tt ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31780 --- Comment #4 from Martin Renvoize --- Great work.. I wonder if the 'alert' div should be moved above the page heading and toolbar.. I've mentioned of irc we need a guideline for that.. alert box positions is another wildly inconsistent thing in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:04:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:04:42 +0000 Subject: [Koha-bugs] [Bug 31802] New: We need a clear coding guideline for alert box positioning Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31802 Bug ID: 31802 Summary: We need a clear coding guideline for alert box positioning Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Alert boxes are somewhat inconsistently placed in Koha... sometimes above toolbars, sometimes between toolbars and headings, sometimes below headings and sometimes mixed into the content. We should create a guidelines and make sure we're consistent -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:09:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:09:48 +0000 Subject: [Koha-bugs] [Bug 31803] New: "remove from cart" button displayed even if not in cart Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31803 Bug ID: 31803 Summary: "remove from cart" button displayed even if not in cart Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 on catalogue/detail.pl Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:09:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:09:48 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31803 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31803 [Bug 31803] "remove from cart" button displayed even if not in cart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:13:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:13:13 +0000 Subject: [Koha-bugs] [Bug 30487] Convert checkout and patron details page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30487 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:15:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:15:36 +0000 Subject: [Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:15:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:15:51 +0000 Subject: [Koha-bugs] [Bug 31231] Link authorities automatically does not always work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31231 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:16:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:16:41 +0000 Subject: [Koha-bugs] [Bug 30487] Convert checkout and patron details page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30487 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141624|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 141894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141894&action=edit Bug 30487: Convert checkout and patron details page tabs to Bootstrap This patch updates the checkout and patron details pages, updating jQueryUI tabs to Bootstrap tabs. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Go to Circulation -> Check out and load a patron record for checkout. Ideally the patron record should have a variet of data associated with it: - Checkouts - Relative's checkouts (if patron is a guarantor or guarantee to another patron with checkouts) - Holds - Article requests - Claims - Restrictions - Clubs On the patron's checkout page, test the various tabs corresponding to the features listed above. Having data to display in those tabs helps confirm that any table functionality triggered by the tab activation is working correctly. The checkouts tab should work correctly whether you have "Always show checkouts immediately" checked or not. Test that you can pre-select any tab by appending its anchor to the URL, e.g.: /cgi-bin/koha/circ/circulation.pl?borrowernumber=123#reserves Perform the same checks on the patron details page. Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:17:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:17:44 +0000 Subject: [Koha-bugs] [Bug 30487] Convert checkout and patron details page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30487 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Nice work, no regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:21:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:21:08 +0000 Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759 --- Comment #2 from Martin Renvoize --- Created attachment 141895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141895&action=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:23:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:23:32 +0000 Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759 --- Comment #3 from Martin Renvoize --- I like the pills.. though perhaps we need a little more of a bottom margin beneath them.. some content gets very close. Still contemplating a little.. the distinction of "You're on this tab now" is certainly less marked with pills given there's less of a clear link between the Pill itself and the content it is attached to.. with tabs you have a border that feels like it wraps around the content and then up and around the tab.. hmmm... I'm a little torn myself.. needs more wider feedback. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:25:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:25:24 +0000 Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759 --- Comment #4 from Martin Renvoize --- Created attachment 141896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141896&action=edit SCreenshot tabs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:25:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:25:37 +0000 Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141895|Screenshot |Screenshot pills description| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:25:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:25:49 +0000 Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141896|SCreenshot tabs |Screenshot tabs description| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:30:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:30:06 +0000 Subject: [Koha-bugs] [Bug 31802] We need a clear coding guideline for alert box positioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31802 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org, | |victor at tuxayo.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:31:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:31:44 +0000 Subject: [Koha-bugs] [Bug 27542] It should be possible to cancel an ILL request sent to a partner In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27542 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:33:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:33:21 +0000 Subject: [Koha-bugs] [Bug 30200] Add customizable tabs to interlibrary loan requests list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:46:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:46:43 +0000 Subject: [Koha-bugs] [Bug 31802] We need a clear coding guideline for alert box positioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31802 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:47:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:47:10 +0000 Subject: [Koha-bugs] [Bug 31803] "remove from cart" button displayed even if not in cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31803 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:47:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:47:37 +0000 Subject: [Koha-bugs] [Bug 31804] New: Filtering not working when searching for a basket number on the receive orders page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31804 Bug ID: 31804 Summary: Filtering not working when searching for a basket number on the receive orders page Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: noemie.labine at collecto.ca QA Contact: testopia at bugs.koha-community.org Not a duplicate of bz31322 as I don't recreate the behaviour described. I am able to search with the box above the table and the box in every other colomn in the table, but not in the basket one. I don't have any kind of error or any kind of odd behaviour, the filtering just doesn't work when I am searching for a basket number. It seems to search only on the date. In previous version, searching for a basket number was filtering correctly the table. To recreate : Go to the receive orders page for any vendor Try searching for one of the basket number in the box above the table - Every line of the table disappear as if there was no basket with this number Try searching the same number in the Basket search box - same result Try searching for the date of the basket - appropriate lines are filtered Thank you -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:50:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:50:38 +0000 Subject: [Koha-bugs] [Bug 31688] Cannot set branches to non-public via administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31688 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Lucas Gass --- *** This bug has been marked as a duplicate of bug 31785 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:50:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:50:38 +0000 Subject: [Koha-bugs] [Bug 31785] Adding or editing library does not respect public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31785 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass --- *** Bug 31688 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:54:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:54:47 +0000 Subject: [Koha-bugs] [Bug 31785] Adding or editing library does not respect public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31785 --- Comment #11 from Lucas Gass --- Trivial, fixes the problem, QA script is happy. Going to Pass QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:55:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:55:16 +0000 Subject: [Koha-bugs] [Bug 31785] Adding or editing library does not respect public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31785 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:55:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:55:20 +0000 Subject: [Koha-bugs] [Bug 31785] Adding or editing library does not respect public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31785 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141864|0 |1 is obsolete| | --- Comment #12 from Lucas Gass --- Created attachment 141897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141897&action=edit Bug 31785: Fix for adding non-public library The code in admin/branches.pl changed a 0 to undef which is not desirable for booleans. A similar fix was already present for pickup_location. This may need a bit more thought (somewhere else!). Test plan: Add a new branch with pickup location No, public No. Check. Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:55:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:55:25 +0000 Subject: [Koha-bugs] [Bug 31785] Adding or editing library does not respect public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31785 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141868|0 |1 is obsolete| | --- Comment #13 from Lucas Gass --- Created attachment 141898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141898&action=edit Bug 31785: (follow-up) Fix modify operation too Test plan: Enable SQL strict mode (koha-conf). Modify branch, set Public to No. Check. Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 17:59:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 15:59:38 +0000 Subject: [Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766 --- Comment #9 from Lucas Gass --- (In reply to Martin Renvoize from comment #8) > Thanks both, I'm happy to be persuaded about the table borders.. we worked a > fair bit on refining the tables already, but I'm sure there are further > refinements we can make.. any chance one of you could open a new bug for it > so we don't lose it in here? > > For reference, I think the majority of prior discussion aroung this was on > github issue https://github.com/jajm/koha-staff-interface-redesign/issues/22 Do we need a separate bug to talk about table headings/borders? -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 19:29:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 17:29:26 +0000 Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30649 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 [Bug 30649] Add ability to encrypt data in Koha, use for EDI vendor accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 19:29:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 17:29:26 +0000 Subject: [Koha-bugs] [Bug 30649] Add ability to encrypt data in Koha, use for EDI vendor accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Depends on| |28998 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998 [Bug 28998] Encrypt borrowers.secret -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 19:35:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 17:35:23 +0000 Subject: [Koha-bugs] [Bug 31762] Flat vs 3D or Mixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31762 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 19:35:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 17:35:28 +0000 Subject: [Koha-bugs] [Bug 31762] Flat vs 3D or Mixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31762 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141794|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 141899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141899&action=edit Bug 31762: Flatten page-section This patch removes the box-shadow from our 'card' mixin and thus makes page-section and other similar content area blocks look flat Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 19:54:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 17:54:00 +0000 Subject: [Koha-bugs] [Bug 31762] Flat vs 3D or Mixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31762 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind --- Created attachment 141900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141900&action=edit Screenshots - Flat vs 3D or Mixed I've attached some screenshots. I don't mind either option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 20:05:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 18:05:32 +0000 Subject: [Koha-bugs] [Bug 31351] Worker dies on reindex job when operator last name/first name/branch name contains non-ASCII chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #37 from Katrin Fischer --- Can we please have this backported? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 20:10:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 18:10:34 +0000 Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind --- I'm in the tabs camp 8-). For me, it is mainly that the tabs are a known and common user interface pattern. Whereas (to me) the pills look like buttons for doing something (submit, cancel, upload, etc). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 20:36:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 18:36:20 +0000 Subject: [Koha-bugs] [Bug 30879] Add option to sort components by biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #39 from Katrin Fischer --- (In reply to David Cook from comment #38) > (In reply to David Cook from comment #37) > > (In reply to Katrin Fischer from comment #29) > > > Happy to add a motivational sign-off, but: > > > > > > I wonder how we can make sure this feature works correctly for updated > > > installations. > > > > > > 1) We should add a note to the release notes about this requiring to reindex. > > > > If we replace the workaround using bug 31756, we won't need to require a > > reindex! > > Actually, it looks like that may just be true for MARC21. It looks like > "Local-number:s" was added for UNIMARC, so they'll probably still need to > re-index... It makes sense, but since this has been pushed to stable and we are already close to release we need to hurry up if we want to revert and replace with an alternative solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 20:39:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 18:39:53 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #91 from David Nind --- I'm happy with this iteration! (I am not a catloguer though....) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 20:40:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 18:40:40 +0000 Subject: [Koha-bugs] [Bug 31645] flatpickr - update coding guidelines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31645 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #4 from Katrin Fischer --- I am not sure I could do a good job here, all I know is that you stick a different class on things now... Owen, could you help maybe? https://wiki.koha-community.org/wiki/Coding_Guidelines#jQueryUI_Datepicker -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 20:44:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 18:44:32 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #42 from Katrin Fischer --- Thanks, Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 20:45:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 18:45:04 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #92 from David Nind --- (In reply to Martin Renvoize from comment #77) > > 3. Should there be a separate bug to move the system preferences from Tools > > (or other areas) to Cataloging? > > Not entirely sure what we mean by this one.. do you mean the 'cataloging' > tab that's in global system preferences under administration right now? I was thinking of the cataloguing tools that are under the Tools system preferences: Barcodes and Batch item . Thanks for responding to all the feedback! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 20:49:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 18:49:44 +0000 Subject: [Koha-bugs] [Bug 31351] Worker dies on reindex job when operator last name/first name/branch name contains non-ASCII chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 20:50:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 18:50:29 +0000 Subject: [Koha-bugs] [Bug 31654] Hide non-public libraries from MastheadLibraryPulldown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31785 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 20:50:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 18:50:29 +0000 Subject: [Koha-bugs] [Bug 31785] Adding or editing library does not respect public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31785 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31654 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 20:51:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 18:51:53 +0000 Subject: [Koha-bugs] [Bug 15500] Add FRBRized view to OPAC & staff interface results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15500 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add FRBRized View to OPAC & |Add FRBRized view to OPAC & |Staff Interface Results |staff interface results --- Comment #6 from Katrin Fischer --- If you decide that there will be information added to the MARC records automatically, could we make the field configurable maybe or use a field that is not used in standard MARC? In our situation records are automatically overwritten/overlaid with a new version of the record from the union catalog every time someone changes/updates the records in the union catalog. In the past, all features altering the MARC record were quite problematic for us. But: we do have MARC overlay rules now :) Maybe a subfield of 942 could be used? This already lends itself to being write-protected having the OPAC suppression and item type as subfields. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 20:55:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 18:55:32 +0000 Subject: [Koha-bugs] [Bug 31654] Hide non-public libraries from MastheadLibraryPulldown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 --- Comment #9 from David Nind --- A temporary work around to making libraries not public until bug 31785 is in master (fixes MySQL strict mode issues) is to use SQL: update branches set public=0 where branchcode = XXX; Where XXX = code for library you want to make not public, such as CPL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 20:56:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 18:56:51 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #47 from Tomás Cohen Arazi --- (In reply to Kevin Carnes from comment #46) > (In reply to Nick Clemens from comment #45) > > As we have time before release, and we have fixes - do we need to revert, or > > can we just fix the DB updates here and push those? > > I think just fixing the DB updates here should be fine. Perhaps I > misunderstood that this would be reverted > (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727#c14). Since > it hasn't been reverted yet, perhaps it's still possible to cancel the > revert and just fix it here. Can you provide a fix? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 20:57:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 18:57:50 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #48 from Nick Clemens --- (In reply to Kevin Carnes from comment #46) > (In reply to Nick Clemens from comment #45) > > As we have time before release, and we have fixes - do we need to revert, or > > can we just fix the DB updates here and push those? > > I think just fixing the DB updates here should be fine. Perhaps I > misunderstood that this would be reverted > (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727#c14). Since > it hasn't been reverted yet, perhaps it's still possible to cancel the > revert and just fix it here. Hi Kevin, Yes, please remove the revert patches and replace the original patches, along with a new patch to fix the DB update as a followup The code was reverted from stable - and i suggest we don't backport even after the fix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 20:58:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 18:58:04 +0000 Subject: [Koha-bugs] [Bug 25972] SIP2 server doesn't have a TLS/SSL-enabled listener In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25972 --- Comment #6 from Katrin Fischer --- (In reply to Martin Renvoize from comment #5) > In our experience, SIP2 clients still don't support this in the vast > majority of cases.. we encourage all our customers to use stunnel and that's > working well Similar/same for us afaikt. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:03:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:03:37 +0000 Subject: [Koha-bugs] [Bug 30200] Add customizable tabs to interlibrary loan requests list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #21 from Katrin Fischer --- It definitely worked for me when I tested, both on the illrequests summary page and on the illrequest history. I'll try to have another look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:05:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:05:43 +0000 Subject: [Koha-bugs] [Bug 31595] Import patrons tool should not process extended attributes if no attributes are being imported In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31595 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:05:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:05:46 +0000 Subject: [Koha-bugs] [Bug 31595] Import patrons tool should not process extended attributes if no attributes are being imported In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31595 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:05:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:05:49 +0000 Subject: [Koha-bugs] [Bug 31785] Adding or editing library does not respect public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31785 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:05:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:05:52 +0000 Subject: [Koha-bugs] [Bug 31785] Adding or editing library does not respect public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31785 --- Comment #14 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:06:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:06:25 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:12:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:12:31 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting --- Comment #117 from Lucas Gass --- Enhancement will not be backported to 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:13:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:13:59 +0000 Subject: [Koha-bugs] [Bug 30504] Value builder for UNIMARC field 181 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas at bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #11 from Lucas Gass --- Enhancement will not be backported to 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:14:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:14:59 +0000 Subject: [Koha-bugs] [Bug 30506] Value builder for UNIMARC field 182 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |lucas at bywatersolutions.com --- Comment #11 from Lucas Gass --- Enhancement will not be in 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:15:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:15:23 +0000 Subject: [Koha-bugs] [Bug 31394] background hold cancellation causing confusion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31394 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #3 from Katrin Fischer --- (In reply to Tomás Cohen Arazi from comment #2) > Maybe we could solve it by adding the progress bar, and just refreshing the > table after the job finishes? Yes, I think that would be great. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:15:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:15:32 +0000 Subject: [Koha-bugs] [Bug 30507] Value builder for UNIMARC field 183 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30507 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas at bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #11 from Lucas Gass --- Enhancement will not be in 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:16:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:16:07 +0000 Subject: [Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas at bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #10 from Lucas Gass --- Enhancement will not be in 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:18:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:18:49 +0000 Subject: [Koha-bugs] [Bug 31282] Broken characters in patron_emailer.pl verbose mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31282 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass --- Backported to 22.05.x for 22.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:20:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:20:13 +0000 Subject: [Koha-bugs] [Bug 31395] Checking in non-existent barcodes makes Koha explode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31395 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #5 from Lucas Gass --- Missing the dependency for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:23:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:23:31 +0000 Subject: [Koha-bugs] [Bug 31343] DataTables error on waitingreserves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #12 from Lucas Gass --- Missing 22.05.x dependencies, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:25:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:25:44 +0000 Subject: [Koha-bugs] [Bug 31385] Additional contents: Allow searching a CMS page by code in multilanguage env In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31385 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #23 from Lucas Gass --- Not needed in 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:25:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:25:45 +0000 Subject: [Koha-bugs] [Bug 29190] Additional contents: Cache selected records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29190 Bug 29190 depends on bug 31385, which changed state. Bug 31385 Summary: Additional contents: Allow searching a CMS page by code in multilanguage env https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31385 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:26:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:26:43 +0000 Subject: [Koha-bugs] [Bug 30218] Add subfield g to 150 heading_fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30218 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #6 from Lucas Gass --- Enhancement will not be backported to 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:28:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:28:04 +0000 Subject: [Koha-bugs] [Bug 29955] Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass --- I suppose this is an enhancement? I will not backport to 22.05.x unless requested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:28:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:28:05 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Bug 15348 depends on bug 29955, which changed state. Bug 29955 Summary: Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:28:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:28:06 +0000 Subject: [Koha-bugs] [Bug 21204] Move C4::Acquisition code to the Koha namespace [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21204 Bug 21204 depends on bug 29955, which changed state. Bug 29955 Summary: Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:28:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:28:06 +0000 Subject: [Koha-bugs] [Bug 29959] Populate prices when creating an order with the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29959 Bug 29959 depends on bug 29955, which changed state. Bug 29955 Summary: Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:30:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:30:21 +0000 Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through stage MARC record import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/595 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:34:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:34:17 +0000 Subject: [Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #63 from Lucas Gass --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:35:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:35:13 +0000 Subject: [Koha-bugs] [Bug 31017] Add type field for vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas at bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #35 from Lucas Gass --- Enhancement, will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:37:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:37:13 +0000 Subject: [Koha-bugs] [Bug 31756] Biblionumber not numerically sorting natively when using Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #10 from Nick Clemens --- I don't see any problems with 1000+ records in MARC21 I wonder though, do we need to remove the XSLT changes? The sorting works the same with or without them, and helps those who might not know enough about YAZ options but use Z39.50 to search Koha. I suggest dropping the last two patches. Sorting will still work without a reindex. Happy to add my stamp once David is good for sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:37:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:37:58 +0000 Subject: [Koha-bugs] [Bug 31076] Bug 22605 breaks date of publication range search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31076 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:38:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:38:39 +0000 Subject: [Koha-bugs] [Bug 31781] Transferred items table (branchtransfers.tt) needs page-section class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:38:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:38:44 +0000 Subject: [Koha-bugs] [Bug 31781] Transferred items table (branchtransfers.tt) needs page-section class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141851|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 141901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141901&action=edit Bug 31781: Add page-section to branchtransfers page This patch adds the page-section div to 2 tables on the branch transfer page. To test: 1. Apply patch 2. Place an item level hold on a few items. 3. Now go to the branch transfer page and try transferring your items that have holds on them. 4. This should bring up a 'Reserve found' page. Look at the table and make sure it looks good with the page-section div added. 5. Now try some transfers that do not have holds. Make sure the table that populates also goods good with the page-section div added. Note: There are some indentation changes. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:38:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:38:57 +0000 Subject: [Koha-bugs] [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:44:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:44:35 +0000 Subject: [Koha-bugs] [Bug 31352] Terminology: Borrower name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31352 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | --- Comment #5 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:47:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:47:04 +0000 Subject: [Koha-bugs] [Bug 31425] Minor correction to patron categories admin title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31425 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | --- Comment #5 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:47:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:47:35 +0000 Subject: [Koha-bugs] [Bug 29939] Replace opac-ratings-ajax.pl with a new REST API route In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29939 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass --- Enhancement will not be in 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:50:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:50:59 +0000 Subject: [Koha-bugs] [Bug 31355] Specific item holds table on OPAC only showing 10 items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31355 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:52:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:52:03 +0000 Subject: [Koha-bugs] [Bug 31321] Remove GetItemsInfo from catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31321 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:52:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:52:04 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Bug 27272 depends on bug 31321, which changed state. Bug 31321 Summary: Remove GetItemsInfo from catalogue/detail.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31321 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:52:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:52:57 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer --- (In reply to Lucas Gass from comment #3) > I think the use of another red X on the page to change the item level hold > into a bib level one is confusing. There are already a few red X's on the > page and that particular one offers no explanation to the user as to what it > will do. > > Maybe we need a dropdown? I'm not sure if that is the proper solution either. Lucas is making a good point, could you please have a look Lari? Maybe some other icon could be used? I have to admit my first idea was some kind of upwards arrow for (level upwards) but... there are also a lot of arrows already. A tooltip for sure makes sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:55:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:55:18 +0000 Subject: [Koha-bugs] [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:55:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:55:53 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:55:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:55:56 +0000 Subject: [Koha-bugs] [Bug 31377] Add basket's internal note to tables on vendor search result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31377 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #7 from Lucas Gass --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:56:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:56:20 +0000 Subject: [Koha-bugs] [Bug 22407] OMNIBUS: Use DBIC relations to fetch related object rather than searching for the object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:57:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:57:10 +0000 Subject: [Koha-bugs] [Bug 27091] Document how Elasticsearch is supposed to work and implement respective configurations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27091 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:57:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:57:32 +0000 Subject: [Koha-bugs] [Bug 31124] koha-remove fails to remove long_tasks queue daemon, so koha-create for same user fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31124 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:58:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:58:43 +0000 Subject: [Koha-bugs] [Bug 30808] Release team 22.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30808 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:58:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:58:57 +0000 Subject: [Koha-bugs] [Bug 30009] Records with invalid MarcXML show notes tab 'Descriptions(1)' but tab is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30009 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:59:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:59:14 +0000 Subject: [Koha-bugs] [Bug 30640] Focus does not always move to correct search header form field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30640 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:59:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:59:21 +0000 Subject: [Koha-bugs] [Bug 30714] Checkins from other branches spam the cataloguing log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:59:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:59:39 +0000 Subject: [Koha-bugs] [Bug 30776] import_webservice_batch.pl cronjob completely broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30776 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 21:59:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 19:59:44 +0000 Subject: [Koha-bugs] [Bug 30747] Column settings on otherholdings table in detail.tt doesnt work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30747 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 22:00:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 20:00:16 +0000 Subject: [Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 22:03:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 20:03:42 +0000 Subject: [Koha-bugs] [Bug 27057] Add the ability to have a Override this entire Checkout transaction when Allowtoomanyoverride is turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27057 Michael Adamyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk at ckls.org --- Comment #4 from Michael Adamyk --- +1, this is a big time sink for some of our libraries, and it is a feature that some other ILS systems have. What would the functionality look like? Do we want it to automatically apply the override to the entire transaction automatically, or would there be a checkbox or something similar, like the "Remember for session" checkbox on the Checkout Settings? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 22:09:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 20:09:35 +0000 Subject: [Koha-bugs] [Bug 31805] New: Tidy up transfer pages (branchtransfers.pl) - terminology and styling Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31805 Bug ID: 31805 Summary: Tidy up transfer pages (branchtransfers.pl) - terminology and styling Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 141902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141902&action=edit Screenshots - library transfer screen and table When testing bug 31781 I noticed a couple of items that I think need tidying up for the branch transfer page (/cgi-bin/koha/circ/branchtransfers.pl): - When transferring, the page says "Reserve found", from our terminology list this should be "Hold found". - There are grey backgrounds and a left border around the buttons. - The text should be left aligned. - The table looks "different" than others, I'm assuming because it is not using DataTables. To replicate: 1. Apply bug 31781 if it hasn't been pushed to master. 2. Place an item level hold for a patron (select an item that is in another library). 3. Use the library transfer feature: - Circulation > Transfer > Transfer - Enter the barcode for the item and change the destination library - Select Submit 4. Note that: . The page says "Reserve found", from our terminology list this should be "Hold found". . The transfer and Ignore buttons have a grey background and there is a table border to the left. . The options are center aligned. 5. Choose an action, such as Transfer. 6. Note that the table displayed is "different" from normal tables that use DataTables styling/features. Screenshots of before and after for bug 31781 attached. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 22:10:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 20:10:58 +0000 Subject: [Koha-bugs] [Bug 31781] Transferred items table (branchtransfers.tt) needs page-section class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Created attachment 141903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141903&action=edit Screenshots - Before and after patch applied I've signed off, as this bug adds the page-section div. I did notice a couple of things - see screenshots: - When transferring, the page says "Reserve found", from our terminology list this should be "Hold found". - There are grey backgrounds and a left border around the buttons. - The text should be left aligned. - The table looks "different" than others, I'm assuming because it is not using DataTables. Have logged bug 31805 - Tidy up transfer pages (branchtransfers.pl) - terminology and styling for these -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 22:11:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 20:11:25 +0000 Subject: [Koha-bugs] [Bug 31805] Tidy up transfer pages (branchtransfers.pl) - terminology and styling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31805 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31781 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 22:11:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 20:11:25 +0000 Subject: [Koha-bugs] [Bug 31781] Transferred items table (branchtransfers.tt) needs page-section class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31805 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 22:20:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 20:20:15 +0000 Subject: [Koha-bugs] [Bug 31806] New: Add 'page-section' to holds page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 Bug ID: 31806 Summary: Add 'page-section' to holds page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We need the page-section div when placing holds to ensure proper contrast for even/odd rows on the tables. To replicate: 1. Place a hold or an item. 2. On the details page for a record select the holds section/tab. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 22:20:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 20:20:37 +0000 Subject: [Koha-bugs] [Bug 31807] New: Context for translation: Filter (verb) vs. Filter (noun) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 Bug ID: 31807 Summary: Context for translation: Filter (verb) vs. Filter (noun) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr In the new MARC overlay rules, there is one instance of 'Filter' that is meant as a noun. In French (and maybe other languages), the noun and the verb are not the same word. Most instances of 'Filter' are meant as verbs (some are ambiguous and could be both, such as the column headers in Reports > Statistics wizards). MARC overlay rules is the only page where Filter as a verb doesn't really work. I propose we add some context to separate it from the other ones. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 22:20:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 20:20:44 +0000 Subject: [Koha-bugs] [Bug 31806] Add 'page-section' to holds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31757 Depends on| |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 22:20:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 20:20:44 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 [Bug 31806] Add 'page-section' to holds page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 22:20:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 20:20:44 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 [Bug 31806] Add 'page-section' to holds page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 22:29:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 20:29:31 +0000 Subject: [Koha-bugs] [Bug 31716] Enlarge the size of the authorised_value column in authorised_values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31716 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141722|0 |1 is obsolete| | --- Comment #11 from David Nind --- Created attachment 141904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141904&action=edit Bug 31716: Enlarge the authorised_value column in authorised_values This patch changes authorised_value from VARCHAR(80) to VARCHAR(255) To test: 1 - Apply patch 2 - Update database 3 - Confirm you can store a longer value in authorised_values Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 22:29:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 20:29:36 +0000 Subject: [Koha-bugs] [Bug 31716] Enlarge the size of the authorised_value column in authorised_values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31716 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141723|0 |1 is obsolete| | --- Comment #12 from David Nind --- Created attachment 141905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141905&action=edit Bug 31716: Prevent issues with foreign key VARCHAR is now allowed to be 65535 bytes max, as opposed to 255 - when testing this, however, I received errors about latering a column with a foreign key. Adding this to the update to avoid problems like bug 31673. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 22:29:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 20:29:42 +0000 Subject: [Koha-bugs] [Bug 31716] Enlarge the size of the authorised_value column in authorised_values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31716 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141724|0 |1 is obsolete| | --- Comment #13 from David Nind --- Created attachment 141906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141906&action=edit Bug 31716: DO NOT PUSH - Schema updates Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 22:30:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 20:30:20 +0000 Subject: [Koha-bugs] [Bug 31716] Enlarge the size of the authorised_value column in authorised_values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31716 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 22:31:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 20:31:03 +0000 Subject: [Koha-bugs] [Bug 31017] Add type field for vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 22:39:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 20:39:35 +0000 Subject: [Koha-bugs] [Bug 31377] Add basket's internal note to tables on vendor search result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31377 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 22:41:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 20:41:06 +0000 Subject: [Koha-bugs] [Bug 31385] Additional contents: Allow searching a CMS page by code in multilanguage env In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31385 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 22:41:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 20:41:06 +0000 Subject: [Koha-bugs] [Bug 29190] Additional contents: Cache selected records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29190 Bug 29190 depends on bug 31385, which changed state. Bug 31385 Summary: Additional contents: Allow searching a CMS page by code in multilanguage env https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31385 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 22:45:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 20:45:47 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 --- Comment #76 from Arthur Suzuki --- yup. done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 22:49:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 20:49:14 +0000 Subject: [Koha-bugs] [Bug 31587] Basket not accessible from ACQORDER notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate --- Comment #10 from Katrin Fischer --- Ok, not a bad bug, but this would be SO helpful in lower versions :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 22:51:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 20:51:50 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #78 from Agustín Moyano --- Hi everyone, it's been a long time since I wrote to you! Thanks so much David for so extensive testing.. I'll try to address as much points as possible. (In reply to David Cook from comment #68) > (#NOTE: I would've preferred "Identity Providers" since that's a more common > industry term.) Nice point. I'll talk to Tomas if we change it > (#NOTE: The UI looks poorly formatted, but I think that's probably a symptom > of the new staff interface styling. Not a blocker for me. This can be fixed > later...) Sorry, it's been a long time since I've done anything related to Koha.. If you could point me to a well formated page, I'll try to stick to the style as much as possible > (#NOTE: There is a bug with the "Configuration" where "Add new X > configuration" doesn't work if you've manually changed anything in the text > box. Not a blocker for me, but will need to be fixed at some point. Same > goes for "Add default OIDC mapping.) I do not believe this patches are at the latest version.. I've added a jquery-validator to check if your jsons are valid before saving. I imagine this is a patch for now, and we need a way to edit a json in a proper way > (#NOTE: There's not enough documentation/help text on how to use this UI. Yes, I've been coding this between jobs so I had no time to document, but surely we will add some follow-ups. > I'm figuring it out through trial and error, but a bit of help text for > "Code", "Description", and "Icon URL" at a minimum would be good.) Code should be a unique name for your Identity Provider, the Description is the text that will appear in the login button, and Icon URL should be a URL where we can fetch an icon for login button > (#NOTE: With the new Staff Interface, there should be a "Help" link on the > right hand side, but I don't see it for this new functionality. I think > that's a blocker.) Ok, I'll ask Tomas for help about how this shoul be done > (#NOTE: I don't really like having to include raw JSON in this UI. This > could be made more beautiful.) Me neither, there should be a JSON editor or something.. does Koha have one? > (#NOTE: "Code" doesn't appear to be restricted or validated in any way. We > should stick to alphanumeric codes. This is borderline... but I think it's a > blocker. We need to set the rule before people start using it.) Good point. Will be done > (#NOTE: We need to add help text at the bottom of this page that says this > auth provider won't be available until after a Koha restart.) Yes, but we have plans to make it so that you wont need to restart Koha for the provider to be available (a PR to Mojolicious::Plugin::OAuth2 project) > 4. Click on "Manage Domains" > 5. Click "Edit" for first and only line > (#NOTE: It's not clear what a "Domain" is in this context. This needs more > help text/documentation. I'd say that's a blocker. From past code review in > Koha for OIDC, "Domain" referred to email domain. That really should spelled > out clearly. ) Agree. Domain in this case is, as you said, email domain. > 6. The breadcrumb doesn't show the auth provider code on the "Edit > authentication provider domain" like it does on the "Authentication provider > domains" page I'll check it > > > 4. koha-plack --restart kohadev > (#NOTE: This is an unfortunate step but necessary because of the plugin > being used. Auth providers are rarely set up, so not a big drama.) > > 4. In an Incognito tab or different browser, go to http://localhost:8081/ > (#NOTE: In my opinion, we should *not* be allowing staff login by default. > While "Auto register" is "Don't allow" by default, we should keep the staff > interface as locked down as possible. Not a blocker but an observation...) Ok, that's easily done > > 5. When I try to login with Keycloak, I get the following error in Koha: > [{"message":"Malformed query string","path":"\/query\/session_state"}] > (#NOTE: Newer OIDC providers will provide session_state in the > authentication response. I'll turn this off in Keycloak. Folks can read more > about session_state at > https://openid.net/specs/openid-connect-session-1_0.html) > > 6. Now I'm getting this error on the Koha Staff Interface login page (since > the user doesn't exist in Koha and I have auto-register turned off): > There was an error authenticating to external identity provider > Exception 'Koha::Exceptions::Auth::Unauthorized' thrown 'External auth user > cannot access resource' with code => 401 > (#NOTE: I don't think printing the exception on the staff interface is a > good idea. Let's remove that.) As I said, I do not believe these patches to be at the latest version.. now the user gets redirected to the login page (staff or opac) with error message > > 7. After adding my user to Koha and giving staff permissions, I'm able to > log in. Very nice! > > 8. Go to http://localhost:8080/ and click "Log in with Keycloak IdP" > 9. Since I already have a session in Keycloak, I'm logged into the OPAC with > no login. Very good! > > 10. If I logout of Keycloak and try to log back into http://localhost:8080/ > via Keycloak, I get the following: > There was an error authenticating to external identity provider > Can't call method "auto_register" on an undefined value at > /kohadevbox/koha/Koha/REST/Plugin/Auth.pm line 66. Strange, I'll have to check that out > > (#NOTE: In the code I see "tranverse_hash" but it should be "traverse_hash" > in English.) typo... sorry > > 11. Turn on auto register for all blank domain... > 12. restart_all in ktd > 13. Try to log into OPAC and Staff Interface > 14. Neither works... > (#NOTE: In Koha/REST/Plugin/Auth.pm, it looks like auto-register should only > work for OPAC. In theory, I like that, although I suppose the workaround > would be to auto-register for the OPAC, and then your account would exist > for the Staff Interface anyway...) > > 15. I tried "Update on login" using the blank domain and a domain of > "prosentient.com.au" and both failed to update my firstname and surname on > login. That's a blocker... Yep, I think I forgot to code that part Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 22:58:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 20:58:46 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #79 from Agustín Moyano --- (In reply to David Cook from comment #74) > Another problem: > > If you have a "blank" domain and a specific domain, the "blank" domain is > used instead of the specific domain. Strange, the behavior should be the opposite. The logic was that you could define multiple domains (even partially) and the domain with the longest matching text should win. If there was no matching domain, then go with the default. > > If you want to set different "Default library" and "Default category" based > on email domain, it won't work if you have a "blank" domain. Maybe I've done something wrong with the regexp, and if the email domain doesn't match, you won't see that "default library" and "default category" configured for the domain > > It also means the "Auto register" and "Update on login" wouldn't work > right... if they were working... I've fixed auto register in latest patches, but for it to work, you need to define userid or cardnumber in the mapper. > > I think the only thing that does work is having "Allow staff: No" in "blank" > domain and "Allow staff: Yes" in specific domain. ("Allow opac: no" for > "blank" would also work but that would be an unlikely scenario.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:05:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:05:02 +0000 Subject: [Koha-bugs] [Bug 31807] Context for translation: Filter (verb) vs. Filter (noun) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:05:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:05:06 +0000 Subject: [Koha-bugs] [Bug 31807] Context for translation: Filter (verb) vs. Filter (noun) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 141907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141907&action=edit Bug 31807: Context for translation: Filter (verb) vs. Filter (noun) This patch add the context 'noun' to the 'Filter' string in marc-overlay-rules.tt. This will separate that instance of 'Filter' from the other ones, where it is meant as a verb. To test: 1. Apply patch 2. Visit Administration > MARC overlay rules, make sure the page works (no errors) and that there is a column called 'Filter' 3. Update the po files gulp po:update --lang xx-XX for example, gulp po:update --lang fr-CA 4. Check the xx-XX-messages.po file (e.g. misc/translator/po/fr-CA-messages.po), there should be an entry for 'Filter', with a line msgctxt that gives the 'noun' context 5. Update the file with a random word for the 'Filter' translation for example, I translated 'Filter' by 'Filter as a noun', just to see the difference \#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:83 msgctxt "noun" msgid "Filter" msgstr "Filter as a noun" 6. Install a new language 6.1. Run the following commands in the terminal, replacing xx-XX with the language code (e.g. fr-CA) cd misc/translator ./translate install xx-XX 6.2. In the Koha staff interface, go to Administration > Global system preferences 6.3. Search for language 6.4. Check the box next to the new language 6.5. Save 7. View the MARC overlay rules page in the new language, the 'Filter' column heading should be whatever you put in step 5 Optional test 8. In the staff interface in English, view one or more of these pages, the 'Filter' should be unchanged - Acquisitions > Late orders (Filter button) - Aquisitions > Search for vendor > Receive shipments (Filter heading on the left and Filter button) - Acquisitions > Search for vendor > Click vendor's name > Uncertain prices (Filter button) - Administration > Budgets > Click budget's name > Planning > Plan by ... (any option) (Filter heading on the left) - Reports > Use saved (Filter heading on the left) - Reports > Acquisitions statistics wizard (Filter column heading) - Reports > Patrons statistics wizard (Filter column heading) - Reports > Catalog statistics wizard (Filter column heading) - Reports > Circulation statistics wizard (Filter column heading) - Reports > Holds statistics wizard (Filter column heading) - Reports > Average loan time (Filter column heading) - Tools > News (Filter heading on the left) 9. View these same pages in the other language, the Filter should NOT be changed to whatever you put in step 5 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:07:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:07:41 +0000 Subject: [Koha-bugs] [Bug 31755] Store biblio OPAC visibility in biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31755 --- Comment #2 from Katrin Fischer --- We'd also need a maintenance script then, because if items make a record hidden can be changed on the fly. It would make things a bit less flexible for libraries again... having to ask someone to run jobs server side if often not an easy thing for them. Maybe this makes more sense for OpacSuppression only as a first step? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:10:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:10:01 +0000 Subject: [Koha-bugs] [Bug 31807] Context for translation: Filter (verb) vs. Filter (noun) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 --- Comment #2 from Caroline Cyr La Rose --- I only added the noun context to the marc-overlay-rules page. I did not add the 'verb' context to the other pages. Let me know if this would be preferable. Step 8 contains all the other instances of 'Filter' in the staff interface. The buttons and section headings are certainly verbs, but I wasn't sure for the column headings. It could be both. So I abstained from making a decision. If someone thinks it's preferable to add the context everywhere, let me know which would be best for the column headings... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:14:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:14:29 +0000 Subject: [Koha-bugs] [Bug 31807] Context for translation: Filter (verb) vs. Filter (noun) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com Text to go in the| |This enhancement adds some release notes| |context for translators for | |the term "Filter" when used | |as a noun as opposed to a | |verb. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:16:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:16:38 +0000 Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759 --- Comment #6 from Katrin Fischer --- (In reply to David Nind from comment #5) > I'm in the tabs camp 8-). > > For me, it is mainly that the tabs are a known and common user interface > pattern. Whereas (to me) the pills look like buttons for doing something > (submit, cancel, upload, etc). I am with David on this one for the same reason. Although I have to admit that they look kinda nice, I see an issue in explaining them to users. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:40:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:40:03 +0000 Subject: [Koha-bugs] [Bug 31351] Worker dies on reindex job when operator last name/first name/branch name contains non-ASCII chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | --- Comment #38 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:40:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:40:45 +0000 Subject: [Koha-bugs] [Bug 31777] Allow for scheduling of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31777 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29002 --- Comment #1 from Katrin Fischer --- I think we had discussed this before and my feeling that putting reservations/bookings on top of the holds system might not be the best way to go as we already have so many moving pieces there and the goal is very different. For holds the goal usually is: get it to the user as fast as possible. For a reservation it is: make sure that the item is available at a certain time slot and make sure the user gets it exactly then. But: Martin has been working on something that could be interesting for you: bug 29002 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:40:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:40:45 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31777 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:40:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:40:58 +0000 Subject: [Koha-bugs] [Bug 31777] Allow for scheduling of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31777 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:41:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:41:09 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #12 from David Nind --- The only thing I noticed is around editing and updating an already shared template. If you are not the creator, and you can have manage_item_editor_templates permissions, if you don't select 'Share template' then you make it unshared and can no longer see it. Maybe if it is a shared template, the default when updating the template is for the share template option to be selected by default. To replicate: 1. Have two librarian users, one with manage_item_editor_templates permissions (henry) the other without (casey). 2. Create and share a template as henry. 3. As casey, apply the shared template and make some changes, for example the shelving location 4. Casey can only save as a new template, can't update the existing one - as expected. 5. Change permissions for casey, so they have manage_item_editor_templates. 6. Repeat step 3 7. Select save as template and then select the template from under update shared template. 5. Don't tick the share template option. 6. Now you can't see or choose that template - it is only visible to the original creator (henry). 7. Log in as henry - you can see the template, as creator. Everything else seems to work as per the test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:47:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:47:49 +0000 Subject: [Koha-bugs] [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | --- Comment #7 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:49:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:49:46 +0000 Subject: [Koha-bugs] [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:50:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:50:02 +0000 Subject: [Koha-bugs] [Bug 31351] Worker dies on reindex job when operator last name/first name/branch name contains non-ASCII chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:51:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:51:18 +0000 Subject: [Koha-bugs] [Bug 30797] Subfields linked to the dateaccessioned.pl value builder on addbiblio.pl throw a JS error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30797 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:51:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:51:40 +0000 Subject: [Koha-bugs] [Bug 31274] OPACSuggestionAutoFill must be 1 or 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:52:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:52:05 +0000 Subject: [Koha-bugs] [Bug 31247] Staff interface 2FA blocks logging into the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:52:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:52:32 +0000 Subject: [Koha-bugs] [Bug 30337] Holds to pull ( pendingreserves.pl ) ignores holds if priority 1 hold is suspended In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30337 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:53:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:53:01 +0000 Subject: [Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:53:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:53:26 +0000 Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:53:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:53:50 +0000 Subject: [Koha-bugs] [Bug 30918] Non-public note is visible in OPAC in Title Notes tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30918 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:54:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:54:07 +0000 Subject: [Koha-bugs] [Bug 31246] displayed in 'Additional fields' section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31246 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:54:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:54:19 +0000 Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:54:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:54:29 +0000 Subject: [Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:54:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:54:49 +0000 Subject: [Koha-bugs] [Bug 30744] Use RecordProcessor in get_marc_notes to ensure non-public notes do not leak In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:55:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:55:02 +0000 Subject: [Koha-bugs] [Bug 30848] Introduce Koha::Filter::ExpandCodedFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:55:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:55:10 +0000 Subject: [Koha-bugs] [Bug 30823] Recalls should use 'FILL' in action logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30823 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:55:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:55:20 +0000 Subject: [Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:55:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:55:33 +0000 Subject: [Koha-bugs] [Bug 30677] Unknown column 'biblioitem.title' in 'where clause' 500 error in API /api/v1/acquisitions/orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30677 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:55:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:55:41 +0000 Subject: [Koha-bugs] [Bug 30974] Job size not correct for indexing jobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30974 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:55:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:55:53 +0000 Subject: [Koha-bugs] [Bug 30904] (bug 24387 follow-up) Modifying library in news (additional contents) causes inconsistencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30904 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:56:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:56:10 +0000 Subject: [Koha-bugs] [Bug 30912] Database update fails for 21.12.00.016 Bug 30060 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30912 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:56:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:56:23 +0000 Subject: [Koha-bugs] [Bug 30971] Recalls - log viewer error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:56:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:56:33 +0000 Subject: [Koha-bugs] [Bug 30907] Remaining incorrect uses of Koha::Recall->item_level_recall In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30907 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:56:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:56:41 +0000 Subject: [Koha-bugs] [Bug 30854] Missing description for 'import_record_matches' in swagger.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30854 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 14 23:59:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 21:59:35 +0000 Subject: [Koha-bugs] [Bug 31390] Remove noisy warns in C4::Templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31390 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #5 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 00:00:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 22:00:16 +0000 Subject: [Koha-bugs] [Bug 6936] Allow to limit on multiple itemtypes when exporting bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6936 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #14 from Lucas Gass --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 00:01:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 22:01:02 +0000 Subject: [Koha-bugs] [Bug 31388] Add select2 to fund selection in new order form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31388 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #7 from Lucas Gass --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 00:01:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 22:01:02 +0000 Subject: [Koha-bugs] [Bug 31440] Add select2 to fund selection in addorderiso2709.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31440 Bug 31440 depends on bug 31388, which changed state. Bug 31388 Summary: Add select2 to fund selection in new order form https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31388 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 00:03:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 22:03:58 +0000 Subject: [Koha-bugs] [Bug 31348] Plack stop should be graceful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31348 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #9 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.06 release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 00:05:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 22:05:46 +0000 Subject: [Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s). In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #1 from Katrin Fischer --- Hi Nick, could you share some details about the use cases for this one? As we usually don't give superlibrarian permissions to users, could this be tied to a new permission maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 00:07:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 22:07:38 +0000 Subject: [Koha-bugs] [Bug 31387] Marking othernames as required via PatronSelfRegistrationBorrowerMandatoryField does not display required label In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31387 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 00:11:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 22:11:44 +0000 Subject: [Koha-bugs] [Bug 6936] Allow to limit on multiple itemtypes when exporting bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 00:12:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 22:12:43 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #33 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 00:13:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 22:13:27 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 00:15:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 22:15:07 +0000 Subject: [Koha-bugs] [Bug 31802] We need a clear coding guideline for alert box positioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31802 --- Comment #1 from Katrin Fischer --- Our coding guidelines are already quite lengthy, maybe we could split out parts that belong to the frontend and turn them into style/GUI guidelines? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 00:17:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 22:17:17 +0000 Subject: [Koha-bugs] [Bug 31033] SIP2 configuration does not correctly handle multiple simultaneous connections by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #19 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 00:18:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 22:18:15 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #105 from Lucas Gass --- Enhancement won't be backported to the 22.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 00:18:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 22:18:16 +0000 Subject: [Koha-bugs] [Bug 17677] Move C4::Circulation code to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17677 Bug 17677 depends on bug 24295, which changed state. Bug 24295 Summary: C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 00:18:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 22:18:16 +0000 Subject: [Koha-bugs] [Bug 22161] Move C4::Circulation::transferbook and C4::Items::ModItemTransfer to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22161 Bug 22161 depends on bug 24295, which changed state. Bug 24295 Summary: C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 00:19:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 22:19:55 +0000 Subject: [Koha-bugs] [Bug 25682] Style transfers interface to match checkin page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25682 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31805 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 00:19:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 22:19:55 +0000 Subject: [Koha-bugs] [Bug 31805] Tidy up transfer pages (branchtransfers.pl) - terminology and styling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31805 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25682 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 00:29:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 22:29:10 +0000 Subject: [Koha-bugs] [Bug 31388] Add select2 to fund selection in new order form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31388 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 00:29:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 22:29:10 +0000 Subject: [Koha-bugs] [Bug 31440] Add select2 to fund selection in addorderiso2709.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31440 Bug 31440 depends on bug 31388, which changed state. Bug 31388 Summary: Add select2 to fund selection in new order form https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31388 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 00:39:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 22:39:55 +0000 Subject: [Koha-bugs] [Bug 31808] New: When placing a hold patron name is not displaying correctly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31808 Bug ID: 31808 Summary: When placing a hold patron name is not displaying correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Created attachment 141908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141908&action=edit Screenshot of problem To recreate: 1. Find an item and try placing a hold. 2. Under 'Hold details' the first list element is the patron name, it displays far to the right in an unusual location. ( see attachment ) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 00:39:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 22:39:55 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31808 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31808 [Bug 31808] When placing a hold patron name is not displaying correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 00:52:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 22:52:38 +0000 Subject: [Koha-bugs] [Bug 31808] When placing a hold patron name is not displaying correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31808 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #1 from David Nind --- I can replicate this issue on current master as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 00:56:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 22:56:55 +0000 Subject: [Koha-bugs] [Bug 30869] Stock rotation rotas cannot be deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pjamorim91 at gmail.com Assignee|koha-bugs at lists.koha-commun |pjamorim91 at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 01:20:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 23:20:41 +0000 Subject: [Koha-bugs] [Bug 31808] When placing a hold patron name is not displaying correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31808 --- Comment #2 from Lucas Gass --- I think in our CSS for fieldset.rows we need to explicitly set the li elements width to 100%. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 01:23:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 23:23:53 +0000 Subject: [Koha-bugs] [Bug 31808] When placing a hold patron name is not displaying correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31808 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 01:23:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 23:23:57 +0000 Subject: [Koha-bugs] [Bug 31808] When placing a hold patron name is not displaying correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31808 --- Comment #3 from Lucas Gass --- Created attachment 141909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141909&action=edit Bug 31808: Set fieldset.rows li width to 100% To test: 1. Find an item and try placing a hold. 2. Under 'Hold details' the first list element is the patron name, it displays far to the right in an unusual location. 3. Apply patch and regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 4. Try steps 1 & 2 again. 5. The name should display correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 01:24:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Oct 2022 23:24:13 +0000 Subject: [Koha-bugs] [Bug 31808] When placing a hold patron name is not displaying correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31808 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 04:57:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 02:57:32 +0000 Subject: [Koha-bugs] [Bug 31808] When placing a hold patron name is not displaying correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31808 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 04:57:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 02:57:36 +0000 Subject: [Koha-bugs] [Bug 31808] When placing a hold patron name is not displaying correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31808 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141909|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 141910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141910&action=edit Bug 31808: Set fieldset.rows li width to 100% To test: 1. Find an item and try placing a hold. 2. Under 'Hold details' the first list element is the patron name, it displays far to the right in an unusual location. 3. Apply patch and regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 4. Try steps 1 & 2 again. 5. The name should display correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 09:01:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 07:01:18 +0000 Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759 --- Comment #7 from Martin Renvoize --- How about something like bootstraps card with header and tabs... https://getbootstrap.com/docs/4.0/components/card/#navigation. I think for me it's the borders and offset that feels weird where other content areas are all moving towards the page-section custom card implementation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 09:04:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 07:04:15 +0000 Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759 --- Comment #8 from Martin Renvoize --- This raises a slight question as to what colour the header section should be.. a green tint of some kind I reckon rather than a grey (as our overall page background is grey... Though perhaps matching the sidebar grey could work?).. if we do opt for a green I'd suggest matching the modal header green for consistency though personally I'd like to change that green too.. I find it 'dirty'.. think Lucas and I described it as Swamp green in a t cent chat. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 09:25:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 07:25:19 +0000 Subject: [Koha-bugs] [Bug 31654] Hide non-public libraries from MastheadLibraryPulldown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 09:28:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 07:28:16 +0000 Subject: [Koha-bugs] [Bug 31808] When placing a hold patron name is not displaying correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31808 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 09:35:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 07:35:13 +0000 Subject: [Koha-bugs] [Bug 31809] New: Should actions on result list stick to the bottom? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31809 Bug ID: 31809 Summary: Should actions on result list stick to the bottom? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 141911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141911&action=edit Screenshot of result list in staff When you do a search on the result list like 'perl', you can see that the actions are not always sticking to the bottom of the result list entries. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 09:37:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 07:37:07 +0000 Subject: [Koha-bugs] [Bug 31809] Should actions on result list stick to the bottom? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31809 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 09:37:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 07:37:07 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31809 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31809 [Bug 31809] Should actions on result list stick to the bottom? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 09:37:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 07:37:58 +0000 Subject: [Koha-bugs] [Bug 31810] New: Place hold button should be yellow Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Bug ID: 31810 Summary: Place hold button should be yellow Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 When placing a hold in staff, the 'Place hold' button should be yellow for the most important action on this form. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 09:37:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 07:37:58 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31810 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 [Bug 31810] Place hold button should be yellow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 09:40:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 07:40:41 +0000 Subject: [Koha-bugs] [Bug 31808] When placing a hold patron name is not displaying correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31808 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 09:40:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 07:40:46 +0000 Subject: [Koha-bugs] [Bug 31808] When placing a hold patron name is not displaying correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31808 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141910|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 141912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141912&action=edit Bug 31808: Set fieldset.rows li width to 100% To test: 1. Find an item and try placing a hold. 2. Under 'Hold details' the first list element is the patron name, it displays far to the right in an unusual location. 3. Apply patch and regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 4. Try steps 1 & 2 again. 5. The name should display correctly. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 09:41:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 07:41:57 +0000 Subject: [Koha-bugs] [Bug 31781] Transferred items table (branchtransfers.tt) needs page-section class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #4 from Katrin Fischer --- Don't forget to set assignee please! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 09:48:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 07:48:03 +0000 Subject: [Koha-bugs] [Bug 31781] Transferred items table (branchtransfers.tt) needs page-section class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781 --- Comment #5 from Katrin Fischer --- This page needs a lot more work, but this does what is written on the tin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 09:48:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 07:48:58 +0000 Subject: [Koha-bugs] [Bug 31805] Tidy up transfer pages (branchtransfers.pl) - terminology and styling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31805 --- Comment #1 from Katrin Fischer --- There is also something weird about the display of the name - I think it should be using the standard template and it also has a line break, when there would be enough space. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 09:49:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 07:49:29 +0000 Subject: [Koha-bugs] [Bug 31781] Transferred items table (branchtransfers.tt) needs page-section class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 09:49:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 07:49:33 +0000 Subject: [Koha-bugs] [Bug 31781] Transferred items table (branchtransfers.tt) needs page-section class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141901|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 141913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141913&action=edit Bug 31781: Add page-section to branchtransfers page This patch adds the page-section div to 2 tables on the branch transfer page. To test: 1. Apply patch 2. Place an item level hold on a few items. 3. Now go to the branch transfer page and try transferring your items that have holds on them. 4. This should bring up a 'Reserve found' page. Look at the table and make sure it looks good with the page-section div added. 5. Now try some transfers that do not have holds. Make sure the table that populates also goods good with the page-section div added. Note: There are some indentation changes. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 09:50:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 07:50:16 +0000 Subject: [Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 09:53:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 07:53:12 +0000 Subject: [Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 09:53:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 07:53:18 +0000 Subject: [Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141848|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 141914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141914&action=edit Bug 31766: Add page-section wrapper to notice table To test: 1. Apply patch 2. Look at the noitce page and notice how the table, and it's tools, now are wrapped with the page-section element. 3. Is it better than it was before? Feel free to osboslete these patch and replace it with your own. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 09:54:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 07:54:09 +0000 Subject: [Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766 --- Comment #11 from Katrin Fischer --- (In reply to Lucas Gass from comment #9) > (In reply to Martin Renvoize from comment #8) > > Thanks both, I'm happy to be persuaded about the table borders.. we worked a > > fair bit on refining the tables already, but I'm sure there are further > > refinements we can make.. any chance one of you could open a new bug for it > > so we don't lose it in here? > > > > For reference, I think the majority of prior discussion aroung this was on > > github issue https://github.com/jajm/koha-staff-interface-redesign/issues/22 > > Do we need a separate bug to talk about table headings/borders? Might be good :) But not sure if there is one yet already, still diving in. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 09:57:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 07:57:07 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:02:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:02:45 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #15 from Katrin Fischer --- (In reply to Owen Leonard from comment #14) > (In reply to Martin Renvoize from comment #13) > > Created attachment 141834 [details] [review] [review] > > Bug 31758: (follow-up) Remove fat margin-top > > > > This removes the increased top margin appearing on subsection headings > > after clicking through from search.. > > The purpose of the extra margin can be seen if you click one of the sidebar > subheadings to jump down. Without the extra margin, when you jump to that > section the heading is obscured by the floating toolbar. I suggest we leave the last patch off for now, and then we could figure this one out still on a separate bug if we want. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:03:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:03:48 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:03:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:03:53 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141830|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 141915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141915&action=edit Bug 31758: OPTION 2 - Add page-section div around subsections An alternative that puts adds a new page-section div around each preference subsection rather than around the whole tab section. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:03:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:03:58 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141831|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 141916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141916&action=edit Bug 31758: OPTION 2 (follow-up) Add padding between adjacent sections Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:05:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:05:13 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141834|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:06:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:06:18 +0000 Subject: [Koha-bugs] [Bug 31776] Typo in cleanup_database.pl cron's help/usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31776 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:06:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:06:23 +0000 Subject: [Koha-bugs] [Bug 31776] Typo in cleanup_database.pl cron's help/usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31776 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141844|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 141917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141917&action=edit Bug 31776: Fix a typo in cleanup_database.pl cronjob's help/usage cleanup_database.pl cronjob has a typo in it's usage/help: "preserve-logs" option should be "preserve-log" as it is everywhere in the code. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:07:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:07:13 +0000 Subject: [Koha-bugs] [Bug 31776] Typo in cleanup_database.pl cron's help/usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31776 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |stalkernoid at gmail.com |ity.org | QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #5 from Katrin Fischer --- Hi Petro, please don't forget to set Assignee! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:07:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:07:51 +0000 Subject: [Koha-bugs] [Bug 31773] Add 'page-section' to marc modification templates pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:11:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:11:26 +0000 Subject: [Koha-bugs] [Bug 31811] New: Add 'page-section' to marc modification templates pages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 Bug ID: 31811 Summary: Add 'page-section' to marc modification templates pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Blocks: 31757 We need the page-section div adding to the marc modification template page to ensure proper contrast for even/odd rows on the tables. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:11:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:11:26 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31811 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 [Bug 31811] Add 'page-section' to marc modification templates pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:11:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:11:26 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31811 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 [Bug 31811] Add 'page-section' to marc modification templates pages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:12:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:12:13 +0000 Subject: [Koha-bugs] [Bug 31773] Add 'page-section' to manage MARC import page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add 'page-section' to marc |Add 'page-section' to |modification templates |manage MARC import page |pages | --- Comment #3 from Katrin Fischer --- I think this changed a different page - adjusting description to manage marc import and refiled MARC modification templates as bug 31811. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:14:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:14:49 +0000 Subject: [Koha-bugs] [Bug 31812] New: Add yellow to buttons on manage staged imports page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 Bug ID: 31812 Summary: Add yellow to buttons on manage staged imports page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Blocks: 31757 As I undertand, the main action on a page should have a yellow button - no yellow buttons on the manage staged imports page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:14:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:14:49 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31812 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 [Bug 31812] Add yellow to buttons on manage staged imports page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:15:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:15:39 +0000 Subject: [Koha-bugs] [Bug 31811] Add 'page-section' to MARC modification templates pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add 'page-section' to marc |Add 'page-section' to MARC |modification templates |modification templates |pages |pages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:16:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:16:01 +0000 Subject: [Koha-bugs] [Bug 31812] Add yellow to buttons on staged imports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add yellow to buttons on |Add yellow to buttons on |manage staged imports page |staged imports page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:18:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:18:38 +0000 Subject: [Koha-bugs] [Bug 31813] New: Information on manage MARC import details page is misaligned Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Bug ID: 31813 Summary: Information on manage MARC import details page is misaligned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Blocks: 30952 When looking at an imported MARC file details, you have on top: Matching rule applied No matching rule in effect Action if matching record found: Add incoming record Action if no match found: Add incoming record Item processing: Always add items These are misaligned now. Please keep enough space here for longer translations! Also: We are missing a colon! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:18:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:18:38 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31813 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 [Bug 31813] Information on manage MARC import details page is misaligned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:22:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:22:36 +0000 Subject: [Koha-bugs] [Bug 31814] New: Make list of staged MARC imports a datatable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31814 Bug ID: 31814 Summary: Make list of staged MARC imports a datatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com At the moment, this table is not sortable, you cannot search and you cannot do... anything nice with it. We should change that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:24:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:24:35 +0000 Subject: [Koha-bugs] [Bug 31773] Add 'page-section' to manage MARC import page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:24:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:24:40 +0000 Subject: [Koha-bugs] [Bug 31773] Add 'page-section' to manage MARC import page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141846|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 141918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141918&action=edit Bug 31773: Add page-section class to Manage staged MARC records page To test: 1. Apply patch 2. Have some MARC records and stage them for import. It will be nessesary to add more than 1 3. Go to the Manage staged MARC records page and make sure the table looks right with the page-section added. Note: I am also adding the Bootstrap table class to this table becuase I think it makes the table look much nicer. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:25:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:25:15 +0000 Subject: [Koha-bugs] [Bug 31773] Add 'page-section' to manage MARC import page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 --- Comment #5 from Katrin Fischer --- This does what it says, but also the table has a line on top of the header line, which is inconsistent with other pages... do we have a bug for those yet? -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:30:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:30:44 +0000 Subject: [Koha-bugs] [Bug 31767] Add 'page-section' to tags page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31767 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:30:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:30:49 +0000 Subject: [Koha-bugs] [Bug 31767] Add 'page-section' to tags page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31767 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141842|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 141919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141919&action=edit Bug 31767: Add 'page-section' to tags page This patch updates tags templates so that the main content of the page is wrapped with a "page-section" div. This ensures that content has sufficient contrast. See Bug 31757. Note: This patch contains indentation changes, so use diff accordingly. To test, apply the patch and go to Tools -> Tags. - Confirm that the content area of the page looks correct. - Click one of the tag terms to view the list of titles tagged with that term. Confirm that this page looks correct too. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:36:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:36:04 +0000 Subject: [Koha-bugs] [Bug 31764] Add 'page-section' to patron clubs page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31764 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:36:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:36:38 +0000 Subject: [Koha-bugs] [Bug 31764] Add 'page-section' to patron clubs page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31764 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:36:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:36:42 +0000 Subject: [Koha-bugs] [Bug 31764] Add 'page-section' to patron clubs page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31764 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141839|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 141920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141920&action=edit Bug 31764: Add 'page-section' to patron clubs page This patch updates patron clubs template so that the main content of the page is wrapped with a "page-section" div. This ensures that content has sufficient contrast. See Bug 31757. Note: This patch contains indentation changes, so use diff accordingly. To test, apply the patch and go to Tools -> Patron clubs. - If necessary, add at least one club template and at least one club based on that template. - Confirm that the display of club templates and clubs looks correct. - Locate some patrons and add them to a club. - On the patron clubs page, locate a club with enrollments and click Actions -> Enrollments. Confirm that the page looks correct. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:42:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:42:57 +0000 Subject: [Koha-bugs] [Bug 31815] New: Remove round corners from tabbed sections Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31815 Bug ID: 31815 Summary: Remove round corners from tabbed sections Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952, 31747 There are still rounded corners on .tab-content, like we see on the advanced search with the item type search Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 [Bug 31747] Round corners in boxes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:42:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:42:57 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31815 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31815 [Bug 31815] Remove round corners from tabbed sections -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:42:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:42:57 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31815 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31815 [Bug 31815] Remove round corners from tabbed sections -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:43:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:43:31 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 --- Comment #10 from Katrin Fischer --- There are still rounded corners on .tab-content, like we see on the advanced search with the item type search - I've 31815 filed bug for those. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:44:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:44:58 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:45:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:45:19 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:45:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:45:24 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141832|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 141921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141921&action=edit Bug 31747: Give area-news box new staff design look To test: 1. Apply patch 2. Regenerate staff CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 3. Look at the #area-news element of the mainpage. 4. There should be no rounded corners and the box-shadow should be the same as seen elsewhere ( i.e. patron details page ) Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:45:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:45:29 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141833|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 141922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141922&action=edit Bug 31747: Use page-section class, reduce CSS Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:46:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:46:27 +0000 Subject: [Koha-bugs] [Bug 31762] Flat vs 3D or Mixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31762 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:46:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:46:32 +0000 Subject: [Koha-bugs] [Bug 31762] Flat vs 3D or Mixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31762 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141899|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 141923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141923&action=edit Bug 31762: Flatten page-section This patch removes the box-shadow from our 'card' mixin and thus makes page-section and other similar content area blocks look flat Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:46:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:46:52 +0000 Subject: [Koha-bugs] [Bug 31762] Flat vs 3D or Mixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31762 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #7 from Katrin Fischer --- So the world is flat after all :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:47:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:47:02 +0000 Subject: [Koha-bugs] [Bug 31762] Flat vs 3D or mixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31762 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Flat vs 3D or Mixed |Flat vs 3D or mixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 10:51:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 08:51:43 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 13:34:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 11:34:37 +0000 Subject: [Koha-bugs] [Bug 31815] Remove round corners from tabbed sections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31815 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- This is worth considering in relations to the suggestions on bug 31759 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 13:34:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 11:34:56 +0000 Subject: [Koha-bugs] [Bug 31815] Remove round corners from tabbed sections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31815 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31759 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 13:34:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 11:34:56 +0000 Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31815 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 13:38:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 11:38:18 +0000 Subject: [Koha-bugs] [Bug 31773] Add 'page-section' to manage MARC import page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 --- Comment #6 from Martin Renvoize --- I spotted a table inconsistency like that somewhere else yesterday.. can't for the life of me remember where. I didn't submit a big for it yet, got distracted, but we probably should report such bugs as and when we spot them.. I imagine it's yet another small inconsistency with our markup which should be fixed rather than further targeted class rules being added. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 13:39:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 11:39:39 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #18 from Martin Renvoize --- Good call obsoleting the third patch.. we probably should have a big for it though ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 16:46:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 14:46:31 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #19 from Katrin Fischer --- (In reply to Martin Renvoize from comment #18) > Good call obsoleting the third patch.. we probably should have a big for it > though ;) I left it open, because after Owen's explanation I was ok with the current behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 19:31:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 17:31:03 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 19:31:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 17:31:08 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141556|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 141924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141924&action=edit Bug 31718: Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation This patch changes the strings in the IF ELSE for the framework name in the breadcrumbs on the marc_subfields_structure.pl page. To test: 1) Apply patch 2) In the intranet, go to Administration > MARC bibliographic framework 3) Click 'Actions' next to the default framework and choose 'MARC structure' 4) Click 'Actions' next to a MARC tag and choose 'View subfields' 5) Check the breadcrumbs, they should show Home > Administration > MARC frameworks > Default framework structure > ... 6) Redo steps 2-5, using a different framework, e.g. ACQ The breadcrumbs for ACQ should look like Home > Administration > MARC frameworks > ACQ framework structure > ... Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 19:31:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 17:31:13 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141557|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 141925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141925&action=edit Bug 31718: Others facilitate translation in frameworks administration Some other IF/ELSE/END can be changed to facilitate translation Test plan : Always test with default framework and with another framework and compare with and without patch 1) View subfields of field => Check the h1 in page 2) Perform actions on a field (create, modify, delete) => Check breadcrumbs and h1 in page 3) View the framework table => Check columns Repeatable, Mandatory, Important Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 19:31:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 17:31:50 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in MARC subfields structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Change the IF ELSE values |Change the IF ELSE values |in marc_subfields_structure |in MARC subfields structure |breadcrumbs to facilitate |breadcrumbs to facilitate |translation |translation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 19:33:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 17:33:06 +0000 Subject: [Koha-bugs] [Bug 31728] Duplicate claims modal template markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31728 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #3 from Katrin Fischer --- Please don't forget to set assignee! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 19:41:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 17:41:51 +0000 Subject: [Koha-bugs] [Bug 31728] Duplicate claims modal template markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31728 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 19:41:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 17:41:56 +0000 Subject: [Koha-bugs] [Bug 31728] Duplicate claims modal template markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31728 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141580|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 141926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141926&action=edit Bug 31728: Remove duplicate claims modal template markup This patch removes some markup which duplicates markup now in a separate include file. modal-claims.inc contains the same markup for #claims-returned-modal as checkouts.table.inc. To test, apply the patch and make sure a LOST authorized value code is defined in the ClaimReturnedLostValue system preference. - Check an item out to a patron, e.g. item 39999000001334 to patron 23529000179433. - In the table showing the patron's checkouts, click the "Claim returned" button. - A "Claim returned" modal should appear. - Click "Make claim." - Switch to the "Claims" tab. You should see the item listed there. - Check out another item, e.g. 39999000013313, to the patron and test the return claim process again from the patron detail page. - Check out another item, e.g. 39999000018691, to the patron with a due date specified which is in the past. - Go to Circulation -> Overdues. You should see the item in the list of overdues. Test that the "Claim returned" button works correctly on this page too. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 19:43:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 17:43:05 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 21:21:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 19:21:59 +0000 Subject: [Koha-bugs] [Bug 31816] New: Switch singleBranchMode to singleLibraryMode Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31816 Bug ID: 31816 Summary: Switch singleBranchMode to singleLibraryMode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 31784 Bug 31784 inroduces singleLibraryMode, but still sets singleBranchMode as well. We should clean this up. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 [Bug 31784] SingleBranchMode ignores public flag -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 21:21:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 19:21:59 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31816 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31816 [Bug 31816] Switch singleBranchMode to singleLibraryMode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 21:22:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 19:22:33 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 --- Comment #11 from Katrin Fischer --- It looks like there is still some code in Koha.pm/Search.pm using Koha::Libraries->search->count == 1 to decide about displaying library facets. But since the routine is the same for staff and OPAC a bigger change would be needed. I've filed bug 31816 to switch singleBranchMode to singleLibraryMode everywhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 21:23:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 19:23:39 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 21:23:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 19:23:43 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141857|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 141927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141927&action=edit Bug 31784: Add Libraries->singleBranchMode Test plan: Run t/db_dependent/Koha/Libraries.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 21:23:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 19:23:47 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141858|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 141928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141928&action=edit Bug 31784: Replace some singleBranchMode occurrences Speaks for itself. Test plan: Run t/Koha.t. Check if OPAC shows Library or Libraries in masthead, depending on number of public branches. Login, place a hold. Verify things work as expected. Note: MARC21 XSLT does not care about singleBranchMode. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 21:23:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 19:23:52 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141870|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 141929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141929&action=edit Bug 31784: (QA follow-up) Snake case for subroutine singleLibraryMode => single_library_mode Test plan: Run t/db_dependent/Koha/Libraries.t Run qa tools. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 21:30:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 19:30:41 +0000 Subject: [Koha-bugs] [Bug 27315] The man pages for the command line utilities do not display properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27315 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #11 from Katrin Fischer --- > > 3. Have signed off, as I'm assuming that the build process will now take > care of correctly producing the man pages once the change is pushed to > master. Thx for the notes and I'll hope the same :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 21:32:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 19:32:10 +0000 Subject: [Koha-bugs] [Bug 27315] The man pages for the command line utilities do not display properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27315 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 21:32:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 19:32:15 +0000 Subject: [Koha-bugs] [Bug 27315] The man pages for the command line utilities do not display properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27315 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141626|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 141930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141930&action=edit Bug 27315: use the namespace-aware docbook stylesheet When viewing the man page for the `koha-list` command, the output does not appear correctly: there appears to be a "staircase"-like effect on the text. The same is true for all other man pages. The source XML files for our man pages have the following namespace declaration at the top: xmlns='http://docbook.org/ns/docbook', which means they are DocBook V5.0 documents and should be processed by namespace-aware DocBook XSL stylesheets. This patch fixes that by using the DocBook-to-man-page transformation stylesheet from the docbook-xsl-ns package (note the "-ns" suffix). Test plan: 1) Apply the patch 2) Build and install new package 3) Confirm the man pages display correctly Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 21:38:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 19:38:19 +0000 Subject: [Koha-bugs] [Bug 31730] Link to authorized value interface when an authval is mentioned in preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31730 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #3 from Katrin Fischer --- I like this, but I'd like to suggest a small change. For system preferences we don't link the text 'system preference', but only the preference itself. I suggest we handle this the same for the authorised value categories. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 21:39:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 19:39:18 +0000 Subject: [Koha-bugs] [Bug 31654] Hide non-public libraries from MastheadLibraryPulldown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 --- Comment #10 from David Nind --- (In reply to David Nind from comment #9) > A temporary work around to making libraries not public until bug 31785 is in > master This has now been pushed to master, so you should now be able to make a library not public. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 21:42:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 19:42:50 +0000 Subject: [Koha-bugs] [Bug 31730] Link to authorized value interface when an authval is mentioned in preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31730 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 21:42:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 19:42:55 +0000 Subject: [Koha-bugs] [Bug 31730] Link to authorized value interface when an authval is mentioned in preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31730 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141588|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 141931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141931&action=edit Bug 31730: Link to authorized value interface when an authval is mentioned in preferences This patch adds links to the authorized value interface anywhere an authorized value category is mentioned in a system preference description. To test, apply the patch and go to Administration -> System preferences. - Check these preferences: Circulation -> ILLHiddenRequestStatuses Circulation -> BundleLostValue Circulation -> BundleNotLoanValue Circulation -> ClaimReturnedLostValue Accounting -> RequirePaymentType - Confirm that the link in the description of each preference takes you to the correct authorized value category. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 21:42:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 19:42:59 +0000 Subject: [Koha-bugs] [Bug 31730] Link to authorized value interface when an authval is mentioned in preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31730 --- Comment #5 from Katrin Fischer --- Created attachment 141932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141932&action=edit Bug 31730: (QA follow-up) Only link category name Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 22:44:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 20:44:25 +0000 Subject: [Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind --- I attempted to test. The record is updated, however there is this message in the job list after running the batch modification: Bibliographic record 439 has not been modified. An error occurred on modifying it. (C4::Biblio::_koha_modify_biblioitem_nonmarc(): DBI Exception: DBD::mysql::st execute failed: Incorrect integer value: 'Computer programming' for column `koha_kohadev`.`biblioitems`.`totalissues` at row 1 at /kohadevbox/koha/C4/Biblio.pm line 425 ). Here is the record after the batch record modification is run. 000 nam a22 7a 4500 003 ff 005 20221015202837.0 008 201102b xxu||||| |||| 00| 0 eng d 040 _ _ ‡cvsd 100 1 _ ‡012345‡9102‡aKnuth, Donald Ervin,‡d1938- 245 _ _ ‡012345‡aThe aty of computer programming‡cDonald E. Knuth 600 _ 0 ‡042‡aComputer programming‡9462 999 _ _ ‡c439‡d439 942 _ _ ‡0Computer programming -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 22:47:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 20:47:20 +0000 Subject: [Koha-bugs] [Bug 31817] New: Libraries navigation item should not display if all libaries are set to non-public Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31817 Bug ID: 31817 Summary: Libraries navigation item should not display if all libaries are set to non-public Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 31784 When there are no libraries set to public, the Libraries entry on the navigation should not show. When there is only one, it should read Library. When there is more than one, it should read Libraries. The first case doesn't work right now. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 [Bug 31784] SingleBranchMode ignores public flag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 22:47:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 20:47:20 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31817 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31817 [Bug 31817] Libraries navigation item should not display if all libaries are set to non-public -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 22:49:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 20:49:01 +0000 Subject: [Koha-bugs] [Bug 31775] Show opac_info of single library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 22:49:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 20:49:05 +0000 Subject: [Koha-bugs] [Bug 31775] Show opac_info of single library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141871|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 141933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141933&action=edit Bug 31775: Show single library Test plan: Check both cases: one library (public accessible) and more libraries (public accessible). In the latter case click on one of these libraries too. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 22:49:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 20:49:10 +0000 Subject: [Koha-bugs] [Bug 31775] Show opac_info of single library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141872|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 141934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141934&action=edit Bug 31775: Template cleanup Removing unused parts. Test plan: See first test plan. Confirm that it still works. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 22:54:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 20:54:35 +0000 Subject: [Koha-bugs] [Bug 31738] Unstranslatable string in checkouts.js for recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31738 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 23:00:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 21:00:49 +0000 Subject: [Koha-bugs] [Bug 31738] Unstranslatable string in checkouts.js for recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31738 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 15 23:23:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 21:23:40 +0000 Subject: [Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644 --- Comment #6 from Nick Clemens --- (In reply to David Nind from comment #5) > I attempted to test. > > The record is updated, however there is this message in the job list after > running the batch modification: > > Bibliographic record 439 has not been modified. An error occurred on > modifying it. (C4::Biblio::_koha_modify_biblioitem_nonmarc(): DBI Exception: > DBD::mysql::st execute failed: Incorrect integer value: 'Computer > programming' for column `koha_kohadev`.`biblioitems`.`totalissues` at row 1 > at /kohadevbox/koha/C4/Biblio.pm line 425 ). > > That's my fault, the test plan has you copy text to a numeric field. If you try with a field that has a number is suspect you won't get that error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 00:21:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 22:21:10 +0000 Subject: [Koha-bugs] [Bug 31738] Unstranslatable string in checkouts.js for recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31738 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 00:21:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 22:21:14 +0000 Subject: [Koha-bugs] [Bug 31738] Unstranslatable string in checkouts.js for recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31738 --- Comment #1 from Katrin Fischer --- Created attachment 141935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141935&action=edit Bug 31738: Fix untanslatable string for recalls To test translation: 1. Apply patch and update your po files using: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation 2. Verify the string appears in po files now and translate it 3. Install the language To test functionality: 1. Turn on recalls 1.1. In Administration > Global system preferences, enable UseRecalls 1.2. Add recalls permissions in your circulation rules 2. In the OPAC, log in as a patron 3. Find a record with checked out items and place a recall 4. In the intranet, go to the patron file of the patron who currently has that item checked out --> In the Checkouts table at the bottom of the page, there is a red message next to the recalled title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 00:35:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 22:35:46 +0000 Subject: [Koha-bugs] [Bug 28555] Improve output of verbose option for overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28555 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- The output works now, but I still miss documentation, so this is something people can find: --verbose | -v Verbose mode -v | --verbose Verbose. Without this flag set, only fatal errors are reported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 00:39:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Oct 2022 22:39:17 +0000 Subject: [Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 02:48:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 00:48:53 +0000 Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if job not started In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #19 from Victor Grousset/tuxayo --- There isn't "View detail of the enqueued job" in 21.05.x so I bet it's not affected by it? Or is there another way to reach the view that blows up? (note 21.11.x backported it) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 04:31:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 02:31:10 +0000 Subject: [Koha-bugs] [Bug 29603] Fix responsive behavior of facets menu in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29603 --- Comment #13 from Victor Grousset/tuxayo --- Wait, this has been clearly missed in the last cycle. So it won't happen by itself. Email sent to Arthur for 21.11.x backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 07:30:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 05:30:53 +0000 Subject: [Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 07:30:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 05:30:58 +0000 Subject: [Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141091|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 141936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141936&action=edit Bug 31644: Unit test Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 07:31:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 05:31:03 +0000 Subject: [Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141092|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 141937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141937&action=edit Bug 31644: Check if subfield defined, not for truth To test: 1 - Define a new MARC Modification template with actions: Copy field 600$a to 942$0 2 - Define a new record like: LDR 00334nam a22001217a 4500 003 ff 005 20201102111604.0 008 201102b xxu||||| |||| 00| 0 eng d 040 _ _ ‡cvsd 100 1 _ ‡012345‡aKnuth, Donal Ervin‡d1938 245 _ _ ‡012345‡aThe aty of computer programming‡cDonald E. Knuth 600 _ 0 ‡042‡aComputer programming‡9462 3 - Modify this record using the template above 4 - Note that entire field is copied to 942 5 - Apply patch 6 - Now only subfield 0 is copied Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 07:31:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 05:31:07 +0000 Subject: [Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141093|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 141938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141938&action=edit Bug 31644: Add copy test and clarify some functions This patch adds a tst for copy without subfields. I also clarify what eachstep does so the next user/coder understands current behaviour Update existing or add new: In the case where the field/subfield exists we update, if we have two fields - one with the subfield, and one without, we add the subfield to the one without Copy field: - If given a subfield - we will add to existing fields in the record - If not given a subfield - we create an entirely new field The logic of all of this is tricky, makes sense in a certain light, any complaints are for a new bug :-) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 07:34:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 05:34:59 +0000 Subject: [Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644 --- Comment #10 from David Nind --- (In reply to Nick Clemens from comment #6) > That's my fault, the test plan has you copy text to a numeric field. If you > try with a field that has a number is suspect you won't get that error I ended up using this MARC modification template for step 1: Copy field 600$0 to 611$0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 08:29:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 06:29:23 +0000 Subject: [Koha-bugs] [Bug 31807] Context for translation: Filter (verb) vs. Filter (noun) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 08:29:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 06:29:29 +0000 Subject: [Koha-bugs] [Bug 31807] Context for translation: Filter (verb) vs. Filter (noun) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141907|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 141939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141939&action=edit Bug 31807: Context for translation: Filter (verb) vs. Filter (noun) This patch add the context 'noun' to the 'Filter' string in marc-overlay-rules.tt. This will separate that instance of 'Filter' from the other ones, where it is meant as a verb. To test: 1. Apply patch 2. Visit Administration > MARC overlay rules, make sure the page works (no errors) and that there is a column called 'Filter' 3. Update the po files gulp po:update --lang xx-XX for example, gulp po:update --lang fr-CA 4. Check the xx-XX-messages.po file (e.g. misc/translator/po/fr-CA-messages.po), there should be an entry for 'Filter', with a line msgctxt that gives the 'noun' context 5. Update the file with a random word for the 'Filter' translation for example, I translated 'Filter' by 'Filter as a noun', just to see the difference \#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:83 msgctxt "noun" msgid "Filter" msgstr "Filter as a noun" 6. Install a new language 6.1. Run the following commands in the terminal, replacing xx-XX with the language code (e.g. fr-CA) cd misc/translator ./translate install xx-XX 6.2. In the Koha staff interface, go to Administration > Global system preferences 6.3. Search for language 6.4. Check the box next to the new language 6.5. Save 7. View the MARC overlay rules page in the new language, the 'Filter' column heading should be whatever you put in step 5 Optional test 8. In the staff interface in English, view one or more of these pages, the 'Filter' should be unchanged - Acquisitions > Late orders (Filter button) - Aquisitions > Search for vendor > Receive shipments (Filter heading on the left and Filter button) - Acquisitions > Search for vendor > Click vendor's name > Uncertain prices (Filter button) - Administration > Budgets > Click budget's name > Planning > Plan by ... (any option) (Filter heading on the left) - Reports > Use saved (Filter heading on the left) - Reports > Acquisitions statistics wizard (Filter column heading) - Reports > Patrons statistics wizard (Filter column heading) - Reports > Catalog statistics wizard (Filter column heading) - Reports > Circulation statistics wizard (Filter column heading) - Reports > Holds statistics wizard (Filter column heading) - Reports > Average loan time (Filter column heading) - Tools > News (Filter heading on the left) 9. View these same pages in the other language, the Filter should NOT be changed to whatever you put in step 5 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 08:52:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 06:52:45 +0000 Subject: [Koha-bugs] [Bug 31715] Add missing German translations for language descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31715 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 08:52:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 06:52:49 +0000 Subject: [Koha-bugs] [Bug 31715] Add missing German translations for language descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31715 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141525|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 141940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141940&action=edit Bug 31715: Add German translations for language descriptions This adds the German translations for the different languages to subtag_registry.sql that is used by all languages during installation. * Apply patch * Run database update * Install de-DE and activate it for the OPAC * Go to advanced search * Look at the language pull down - it shows the languages in their language and then translated to English * Switch to German - verify the German translations are used now There are 2-3 cases where the translation = name, so only name is shown. * Drop your database, create your database * Run the web installer * Everything should complete without error and the language pull down should look exactly the same and be translated Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 09:00:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 07:00:05 +0000 Subject: [Koha-bugs] [Bug 31715] Add missing German translations for language descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31715 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- Testing notes (using KTD) ------------------------- To install the German language: cd misc/translator ./translate install de-DE To get the web installer running, I used this process: 1. Access the database server[1]: mysql -uroot -ppassword -hkoha_db_1 2. Drop the koha_kohadev database: drop database koha_kohadev; 3. Create the database: create database koha_kohadev; 4. Add privileges (for a real installation this would be limited): grant all on 5. koha_kohadev.* to koha_kohadev; 6. Restart everything (may not be required, but just to be safe): flush_memcached + restart_all 7. Access the web installer: go to 127.0.0.1:8081 8. Use the database user name and password: get from /etc/koha/sites/kohadev/koha-conf.xml (default: koha_kohadev, password) 9. Continue through the installation process Note: [1] Database password is password (from KTD .env file) German translations for different languages: I don't speak German, but I think Katrin knows these! 8-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 12:47:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 10:47:12 +0000 Subject: [Koha-bugs] [Bug 31715] Add missing German translations for language descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31715 --- Comment #5 from Katrin Fischer --- Thank you, David! The grant permissions might not be needed if you drop + create the database without restarting anything in between, at least I ususally do it that way :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:00:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:00:36 +0000 Subject: [Koha-bugs] [Bug 31818] New: Advanced editor doesn't show keyboard shortcuts Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818 Bug ID: 31818 Summary: Advanced editor doesn't show keyboard shortcuts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When using the advanced cataloguing editor, the modal showing the defined keyboard shortcuts no longer works. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:01:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:01:04 +0000 Subject: [Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard shortcuts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818 --- Comment #1 from Katrin Fischer --- I wanted to test the clipboard when running into this - might also be worth having a look. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:05:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:05:09 +0000 Subject: [Koha-bugs] [Bug 31819] New: Formatting of item form in acq when ordering is broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Bug ID: 31819 Summary: Formatting of item form in acq when ordering is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 When creating a new order with items, the item form formatting is broken. Also the statistics fields at the bottom of the form are misaligned. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:05:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:05:09 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31819 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 [Bug 31819] Formatting of item form in acq when ordering is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:06:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:06:14 +0000 Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when ordering is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 --- Comment #1 from Katrin Fischer --- ... and the item list needs the page-section class. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:08:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:08:37 +0000 Subject: [Koha-bugs] [Bug 31820] New: Add page-section to basket summary page (acq) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31820 Bug ID: 31820 Summary: Add page-section to basket summary page (acq) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Blocks: 31757 This might need one or 2 classes for the upper part and the table of order lines. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:08:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:08:37 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31820 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31820 [Bug 31820] Add page-section to basket summary page (acq) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:08:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:08:37 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31820 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31820 [Bug 31820] Add page-section to basket summary page (acq) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:10:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:10:21 +0000 Subject: [Koha-bugs] [Bug 31820] Add page-section to basket summary page (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31820 --- Comment #1 from Katrin Fischer --- ... also the Managed by at the top of the page is misaligned. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:12:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:12:37 +0000 Subject: [Koha-bugs] [Bug 31821] New: Add page-section to vendor result list (acq) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31821 Bug ID: 31821 Summary: Add page-section to vendor result list (acq) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Blocks: 31757 The vendor result list in acq also needs additional work adding the page section class. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:12:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:12:37 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31821 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31821 [Bug 31821] Add page-section to vendor result list (acq) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:12:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:12:37 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31821 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31821 [Bug 31821] Add page-section to vendor result list (acq) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:14:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:14:12 +0000 Subject: [Koha-bugs] [Bug 31822] New: Add page-section to vendor detail page (acq) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31822 Bug ID: 31822 Summary: Add page-section to vendor detail page (acq) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Blocks: 31757 The vendor detail page also needs the treatment with the class. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:14:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:14:12 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31822 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31822 [Bug 31822] Add page-section to vendor detail page (acq) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:14:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:14:12 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31822 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31822 [Bug 31822] Add page-section to vendor detail page (acq) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:14:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:14:43 +0000 Subject: [Koha-bugs] [Bug 31820] Add page-section to basket summary page (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31820 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:16:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:16:42 +0000 Subject: [Koha-bugs] [Bug 31823] New: Add page-section to uncertain prices page (acq) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31823 Bug ID: 31823 Summary: Add page-section to uncertain prices page (acq) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Blocks: 31757 Might need one or 2 classes added for the information on top and the list of orders with uncertain prices. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:16:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:16:42 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31823 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31823 [Bug 31823] Add page-section to uncertain prices page (acq) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:16:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:16:42 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31823 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31823 [Bug 31823] Add page-section to uncertain prices page (acq) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:20:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:20:35 +0000 Subject: [Koha-bugs] [Bug 31824] New: Add page-section to list of pending/received orders (acq) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31824 Bug ID: 31824 Summary: Add page-section to list of pending/received orders (acq) Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/parcel.pl?invoiceid=1 OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Blocks: 31757 When receiving a shipment, the list of pending and then received orders (table below the first one) requires the treatment with page-section classes. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:20:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:20:35 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31824 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31824 [Bug 31824] Add page-section to list of pending/received orders (acq) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:20:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:20:35 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31824 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31824 [Bug 31824] Add page-section to list of pending/received orders (acq) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:23:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:23:21 +0000 Subject: [Koha-bugs] [Bug 31825] New: On order receive suggestion info block always shows, even if there is no suggestion Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31825 Bug ID: 31825 Summary: On order receive suggestion info block always shows, even if there is no suggestion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org This is a regression, but I am not sure when it started. When receiving an order in acq the Suggestion block now always shows, including a broken link: http://localhost:8081/cgi-bin/koha/suggestion/suggestion.pl?suggestionid=&op=show It should only show if there is a valid suggestoinid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:25:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:25:00 +0000 Subject: [Koha-bugs] [Bug 31826] New: Add page-section to item form on order receive page (acq) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31826 Bug ID: 31826 Summary: Add page-section to item form on order receive page (acq) Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/orderreceive.pl?ordernumber=1&invo iceid=1 OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Blocks: 31757 When receiving an order with connected 'order items', the item table is missing the page-section and appears with grey background. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:25:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:25:00 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31826 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31826 [Bug 31826] Add page-section to item form on order receive page (acq) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:25:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:25:00 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31826 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31826 [Bug 31826] Add page-section to item form on order receive page (acq) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:30:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:30:38 +0000 Subject: [Koha-bugs] [Bug 31827] New: Add page-section to list to log viewer Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31827 Bug ID: 31827 Summary: Add page-section to list to log viewer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Blocks: 31757 The log viewer also needs some page-section. There is also a slight misalignment with the options at the top spilling before their labels. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:30:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:30:38 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31827 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31827 [Bug 31827] Add page-section to list to log viewer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:30:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:30:38 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31827 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31827 [Bug 31827] Add page-section to list to log viewer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:33:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:33:06 +0000 Subject: [Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #48 from Katrin Fischer --- Giving this another round of testing: I have made the FA framework my default. This worked nicely. 1) Open a record that has been saved with ACQ framework. Try to switch to Default. The "Change framework" list will have the checkmark at "FA", but the display will be the default framework. Switching to other frameworks works, so it might have to do with the "" of default. 2) I feel we should fix that one David found and that I confirmed within this patch set. There are 2 'major' ways to create a new record (from cataloguing module and form detail page) and as this is one of them, I think it makes sense to have it part here: I did note that in the staff interface when on the details page for an existing record, you have the option of New > New record - this defaults to the default framework even if another framework is set as the default. 3) When a new record is created with "order from new" in acq, and UseACQFrameworkForBiblioRecords is set to Don't use, the record will be using "default". This is less blocker than 2, but if it's not an easy fix, we should file a bug for it. We've just recently had a request for this on the German mailing list, would love to see this make it into 22.11 :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:39:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:39:08 +0000 Subject: [Koha-bugs] [Bug 31828] New: Add page-section to list of open invoices on receive shipment page (acq) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828 Bug ID: 31828 Summary: Add page-section to list of open invoices on receive shipment page (acq) Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/parcels.pl?booksellerid=1 OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Blocks: 31757 When receiving a shipment and you have existing open invoices for this vendor, they show in a list above the form for entering the new invoice number. This area needs a page-section. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:39:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:39:08 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31828 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828 [Bug 31828] Add page-section to list of open invoices on receive shipment page (acq) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:39:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:39:08 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31828 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828 [Bug 31828] Add page-section to list of open invoices on receive shipment page (acq) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:40:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:40:49 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 --- Comment #10 from Katrin Fischer --- Thank you, Nick :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:53:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:53:10 +0000 Subject: [Koha-bugs] [Bug 31829] New: Change password form in patron account is misaligned Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31829 Bug ID: 31829 Summary: Change password form in patron account is misaligned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 As a side effect of the redesign work the "change password" form on the patron account in staff is misaligned. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 13:53:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 11:53:10 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31829 [Bug 31829] Change password form in patron account is misaligned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 14:02:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 12:02:49 +0000 Subject: [Koha-bugs] [Bug 31830] New: Add page-section to budgets and funds table on acq start page (acq) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31830 Bug ID: 31830 Summary: Add page-section to budgets and funds table on acq start page (acq) Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/acqui-home.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Blocks: 31757 The budget and funds table on the acq start page should have a page-section class. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 14:02:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 12:02:49 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31830 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31830 [Bug 31830] Add page-section to budgets and funds table on acq start page (acq) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 14:02:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 12:02:49 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31830 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31830 [Bug 31830] Add page-section to budgets and funds table on acq start page (acq) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 14:08:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 12:08:11 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer --- I am sorry, but I found another regression: If the user doesn't have permission for a fund, it doesn't show in the list. So far so good. But: if the order has been made for a fund the user has no permission for, currently we have an entry in the list as: Keep current ... With the patch set applied, the list jumps to the first 'allowed' fund in the list, so on saving you will change the fund and cannot keep the existing one. I was recently made aware of this feature, which is quite cool as we avoid data loss here in an efficient way. We need to keep doing that. For testing: make sure you remove budget_manage_all permission, then you can limit some funds to a library for example. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 14:15:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 12:15:30 +0000 Subject: [Koha-bugs] [Bug 31831] New: Make inactive search options font slightly bigger Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31831 Bug ID: 31831 Summary: Make inactive search options font slightly bigger Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Increase font size for 'inactive' search options in top search bar. It looks like the inactive ones are a little smaller than the selected one, it would be nicer to have them slightly bigger, to make them easier to read. The active one is also in front and bold, I think that should be enough to make it stand out without the difference in font size. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 14:15:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 12:15:30 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31831 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31831 [Bug 31831] Make inactive search options font slightly bigger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 14:16:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 12:16:04 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #153 from Katrin Fischer --- Having another look here... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 14:17:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 12:17:42 +0000 Subject: [Koha-bugs] [Bug 31832] New: Add reference for EnableItemGroups to EnableItemGroupHolds system preference Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31832 Bug ID: 31832 Summary: Add reference for EnableItemGroups to EnableItemGroupHolds system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Item group holds only make sense if the library allows item groups in the first place. We should add a note to the system preference linking them together. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 14:18:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 12:18:00 +0000 Subject: [Koha-bugs] [Bug 31832] Add reference for EnableItemGroups to EnableItemGroupHolds system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31832 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24860 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 [Bug 24860] Add ability to place item group level holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 14:18:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 12:18:00 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31832 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31832 [Bug 31832] Add reference for EnableItemGroups to EnableItemGroupHolds system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 14:27:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 12:27:08 +0000 Subject: [Koha-bugs] [Bug 31778] action logs for administrative tasks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31778 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22794 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 14:27:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 12:27:08 +0000 Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31778 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31778 [Bug 31778] action logs for administrative tasks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 14:28:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 12:28:20 +0000 Subject: [Koha-bugs] [Bug 31833] New: [Omnibus] Fix table inconsistencies Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31833 Bug ID: 31833 Summary: [Omnibus] Fix table inconsistencies Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 14:28:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 12:28:20 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31833 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31833 [Bug 31833] [Omnibus] Fix table inconsistencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 14:29:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 12:29:17 +0000 Subject: [Koha-bugs] [Bug 22794] [Omnibus] Improve and extend logging in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Omnibus: Improve and extend |[Omnibus] Improve and |logging in Koha |extend logging in Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 14:31:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 12:31:31 +0000 Subject: [Koha-bugs] [Bug 31834] New: Inconsistent table formatting for list of MARC imports Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Bug ID: 31834 Summary: Inconsistent table formatting for list of MARC imports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Blocks: 31833 The table has a line on top of the header line, which is inconsistent with other pages. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31833 [Bug 31833] [Omnibus] Fix table inconsistencies -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 14:31:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 12:31:31 +0000 Subject: [Koha-bugs] [Bug 31833] [Omnibus] Fix table inconsistencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31833 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31834 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 [Bug 31834] Inconsistent table formatting for list of MARC imports -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 14:32:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 12:32:42 +0000 Subject: [Koha-bugs] [Bug 31773] Add 'page-section' to manage MARC import page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 --- Comment #7 from Katrin Fischer --- (In reply to Martin Renvoize from comment #6) > I spotted a table inconsistency like that somewhere else yesterday.. can't > for the life of me remember where. I didn't submit a big for it yet, got > distracted, but we probably should report such bugs as and when we spot > them.. I imagine it's yet another small inconsistency with our markup which > should be fixed rather than further targeted class rules being added. I've created an omnibus with a first linked bug for this one: Bug 31833 - [Omnibus] Fix table inconsistencies Bug 31834 - Inconsistent table formatting for list of MARC imports -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 14:36:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 12:36:12 +0000 Subject: [Koha-bugs] [Bug 30869] Stock rotation rotas cannot be deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #2 from Katrin Fischer --- Confirmed on master with my superlibrarian user: * Enable StockRotation system preference * Tools > Stock rotation > New rota * Enter Name, save. * There is no delete button visible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 14:39:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 12:39:02 +0000 Subject: [Koha-bugs] [Bug 31769] We need a clear guideline regarding how to display 'filters' and 'sidebar nav' at the same time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31769 --- Comment #1 from Katrin Fischer --- A good example might be the suggestions page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 14:42:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 12:42:09 +0000 Subject: [Koha-bugs] [Bug 31750] Need more padding in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 --- Comment #3 from Katrin Fischer --- I tihnk a little bit of padding would not hurt, but need to keep the floating toolbar in mind. I'd also like to have the "Section 4" heading not stick to the section border. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 14:43:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 12:43:56 +0000 Subject: [Koha-bugs] [Bug 31147] Recalls due date to the minute rather than 23:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31147 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 15:21:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 13:21:33 +0000 Subject: [Koha-bugs] [Bug 31734] Hooks for account, recall, indexing and more actions for holds. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31734 --- Comment #2 from Katrin Fischer --- Hi Stefan, in general it's recommended to break up work into smaller granular features. They usually go in much faster, the smaller the change is, as a question or problem doesn't cause a hold up so easily. In this case, I think it would have made sense to have separate bugs for holds, accounts, indexing and recalls. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 15:29:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 13:29:35 +0000 Subject: [Koha-bugs] [Bug 31835] New: Add page-section to holds queue Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31835 Bug ID: 31835 Summary: Add page-section to holds queue Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/view_holdsqueue.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Blocks: 31757 The table on the holds queue page needs to be a page-section. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 15:29:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 13:29:35 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31835 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31835 [Bug 31835] Add page-section to holds queue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 15:29:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 13:29:35 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31835 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31835 [Bug 31835] Add page-section to holds queue -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 15:53:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 13:53:01 +0000 Subject: [Koha-bugs] [Bug 31836] New: Formatting issue on checkin modal Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31836 Bug ID: 31836 Summary: Formatting issue on checkin modal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Created attachment 141941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141941&action=edit Screenshot of checkin modal for hold found Best seen on the screenshot: The yellow section no longer spans the full width of the modal. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 15:53:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 13:53:01 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31836 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31836 [Bug 31836] Formatting issue on checkin modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 15:55:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 13:55:36 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #154 from Katrin Fischer --- 1) All the new and old tests pass. But: I did a reset_all to have a clean starting page before applying these patches. And my branches are all mangled after running the tests: I end up with 36 branches on the sample database, a lot of those generated ones like: brW5iS. There are also a ton of generated patrons... I am not completely sure it's the new tests here, but could you please check your clean-up? 3) Holds queue is looking good now: a1 or any item from item_group A Just please remove the _ :) 2) Pending holds / Holds to pull > I don't think Holds to pull is the tool a library should be using if they > are using item group holds. This same is true for the holds itemtype filter, > which has been in Koha since 16.05. I'm finding the holds to pull interface > doesn't display data well. For instance, if I place one item level hold, and > one biblio level hold for the same record, holds to pull doesn't really > indicate that. If you can can tell me what you'd like to see, I'll see what > I can do! I don't think we can argue that, unless we hid the report once the item group holds are activated... and that might create quite some complaints. I know single branch libraries like to use the report, also the less busy ones. Maybe it would be worth adding a note to the system preference? "Might not go well with..." or so? In general the page needs work, I agree with you on that! I did some more testing: a) If there is a record level hold only: Only 39999000011418 b) If there is an item level hold only: 39999000005097 or any available. c) If there is a group level hold only: 39999000005097 or any available. For a start, could we catch the third case and have a correct message display? Similar to the one on holds queue? I'd be ok with that as a solution for this patch set. For the future 2 ideas (just to get your opinion, will file later): * If there are different types of holds we could display this as a note: "Different types of holds, please check holds page"? * We could repeat the information for every hold, maybe deduplicated. At the moment it looks like we only get the info for the first hold placed. Maye something like: * Only 39999000011418 (1 hold) * 39999000005097 or any available (2 holds) To summarize: * Verify/make sure tests clean up their created data * Remove _ from message on holds queue page * Adapt message when only a item group hold exists on holds to pull OK? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 15:55:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 13:55:45 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 15:55:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 13:55:58 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 15:58:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 13:58:34 +0000 Subject: [Koha-bugs] [Bug 31626] Add letter id to the message queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31626 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 16:02:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 14:02:00 +0000 Subject: [Koha-bugs] [Bug 31626] Add letter ID to the message queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31626 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed Summary|Add letter id to the |Add letter ID to the |message queue table |message queue table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 16:07:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 14:07:14 +0000 Subject: [Koha-bugs] [Bug 31626] Add letter ID to the message queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31626 --- Comment #8 from Katrin Fischer --- My first thought was: isn't the letter code not enough? But indeed... it isn't. we can have the same code for different branches, while it's not the same text. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 16:22:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 14:22:09 +0000 Subject: [Koha-bugs] [Bug 31626] Add letter ID to the message queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31626 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 16:22:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 14:22:13 +0000 Subject: [Koha-bugs] [Bug 31626] Add letter ID to the message queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31626 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141005|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 141942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141942&action=edit Bug 31626: Update Schema Files [DO NOT PUSH] Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 16:22:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 14:22:18 +0000 Subject: [Koha-bugs] [Bug 31626] Add letter ID to the message queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31626 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141006|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 141943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141943&action=edit Bug 31626: Add letter id to the message queue table It can be useful to know exactly what template was used to generate a notice. To this end, it would be useful to store the letter id as a foreign key in the message queue table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Run an action that will send a notice to a patron 5) Note the letter id is now in the message_queue table for that notice! Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 16:23:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 14:23:51 +0000 Subject: [Koha-bugs] [Bug 31807] Context for translation: Filter (verb) vs. Filter (noun) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 16:25:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 14:25:47 +0000 Subject: [Koha-bugs] [Bug 31807] Context for translation: Filter (verb) vs. Filter (noun) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 16:25:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 14:25:51 +0000 Subject: [Koha-bugs] [Bug 31807] Context for translation: Filter (verb) vs. Filter (noun) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141939|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 141944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141944&action=edit Bug 31807: Context for translation: Filter (verb) vs. Filter (noun) This patch add the context 'noun' to the 'Filter' string in marc-overlay-rules.tt. This will separate that instance of 'Filter' from the other ones, where it is meant as a verb. To test: 1. Apply patch 2. Visit Administration > MARC overlay rules, make sure the page works (no errors) and that there is a column called 'Filter' 3. Update the po files gulp po:update --lang xx-XX for example, gulp po:update --lang fr-CA 4. Check the xx-XX-messages.po file (e.g. misc/translator/po/fr-CA-messages.po), there should be an entry for 'Filter', with a line msgctxt that gives the 'noun' context 5. Update the file with a random word for the 'Filter' translation for example, I translated 'Filter' by 'Filter as a noun', just to see the difference \#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:83 msgctxt "noun" msgid "Filter" msgstr "Filter as a noun" 6. Install a new language 6.1. Run the following commands in the terminal, replacing xx-XX with the language code (e.g. fr-CA) cd misc/translator ./translate install xx-XX 6.2. In the Koha staff interface, go to Administration > Global system preferences 6.3. Search for language 6.4. Check the box next to the new language 6.5. Save 7. View the MARC overlay rules page in the new language, the 'Filter' column heading should be whatever you put in step 5 Optional test 8. In the staff interface in English, view one or more of these pages, the 'Filter' should be unchanged - Acquisitions > Late orders (Filter button) - Aquisitions > Search for vendor > Receive shipments (Filter heading on the left and Filter button) - Acquisitions > Search for vendor > Click vendor's name > Uncertain prices (Filter button) - Administration > Budgets > Click budget's name > Planning > Plan by ... (any option) (Filter heading on the left) - Reports > Use saved (Filter heading on the left) - Reports > Acquisitions statistics wizard (Filter column heading) - Reports > Patrons statistics wizard (Filter column heading) - Reports > Catalog statistics wizard (Filter column heading) - Reports > Circulation statistics wizard (Filter column heading) - Reports > Holds statistics wizard (Filter column heading) - Reports > Average loan time (Filter column heading) - Tools > News (Filter heading on the left) 9. View these same pages in the other language, the Filter should NOT be changed to whatever you put in step 5 Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 16:29:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 14:29:29 +0000 Subject: [Koha-bugs] [Bug 31611] More visibly highlight records that cannot be batch deleted/modified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- 2 small things: 1) QA test tools failure: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc FAIL forbidden patterns forbidden pattern: tab char (line 283) 2) The removed bit Jonathan noted, maybe a rebase issue? - Select all | Clear all | Clear on loan + Select all | Clear all - $("#clearonloanbutton").click(function () { - $("#itemst input[name='itemnumber'][data-is-onloan='1']").each(function () { - $(this).prop('checked', false); - }); - return false; - }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 16:35:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 14:35:28 +0000 Subject: [Koha-bugs] [Bug 31837] New: Add page-section to batch record deletion (tools) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Bug ID: 31837 Summary: Add page-section to batch record deletion (tools) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Blocks: 31757 When receiving a shipment, the list of pending and then received orders (table below the first one) requires the treatment with page-section classes. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 16:35:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 14:35:28 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31837 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 [Bug 31837] Add page-section to batch record deletion (tools) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 16:35:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 14:35:28 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31837 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 [Bug 31837] Add page-section to batch record deletion (tools) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 16:43:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 14:43:44 +0000 Subject: [Koha-bugs] [Bug 31611] More visibly highlight records that cannot be batch deleted/modified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 --- Comment #8 from Katrin Fischer --- Hm. testing this, I don't see the 'select on loan' filter without the patch either... So maybe this was just removing dead code? I think bringing back the option to remove all records from the list that have items checked out could still be useful to bring back. So maybe we should keep the code and file a new bug? Alex, could you have a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 16:45:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 14:45:39 +0000 Subject: [Koha-bugs] [Bug 28967] Patrons with no checkouts report shows patrons from other libraries with IndependentBranches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28967 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 16:55:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 14:55:59 +0000 Subject: [Koha-bugs] [Bug 31838] New: Patrons with no checkouts report should only display patrons you are allowed to see Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31838 Bug ID: 31838 Summary: Patrons with no checkouts report should only display patrons you are allowed to see Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Bug 28967 implements a check on IndependentBranches, but there are more criteria that determine if you should see information about a patron (thinking of permissions and library group functionalities). Should we not have the pre-built reports reflect these? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 16:57:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 14:57:00 +0000 Subject: [Koha-bugs] [Bug 28967] Patrons with no checkouts report shows patrons from other libraries with IndependentBranches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28967 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #15 from Katrin Fischer --- This does exactly what the bug description says, but it leaves us with some other cases that are not taken into account. We do have a more complex system for visibility of patron data now, using permissions and library groups. I am not sure how that could be moved into the report, maybe by creating a list of allowed branchcodes to limit on? Filtering the result list before display? Filed: bug 31838. Also: if you have access to reports... can you be stopped from seeing data you shouldn't? Guided and SQL reports cannot be limited to my knowledge. I am inclined to pass QA on this one anyway as it's also a matter of convenience. If you have independent branches, you might only want to take care of your own users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 16:58:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 14:58:06 +0000 Subject: [Koha-bugs] [Bug 28967] Patrons with no checkouts report shows patrons from other libraries with IndependentBranches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28967 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 16:58:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 14:58:10 +0000 Subject: [Koha-bugs] [Bug 28967] Patrons with no checkouts report shows patrons from other libraries with IndependentBranches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28967 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140973|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 141945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141945&action=edit Bug 28967: Patrons with no checkouts report shows patrons from other libraries with IndependentBranches When IndependentBranches is activated and a non-superlibrarian user looks at the "Patrons with no checkouts" report, it shows patrons from other libraries. To recreate: 1) Activate IndependentBranches, IndependentBranchesPatronModifications and IndependentBranchesTransfers 2) Create a staff user with limited permissions (NOT a superlibrarian), including reports permissions. Here are mine as an example - circulate (all) - catalogue - borrowers - delete_borrowers - edit_borrowers - reserveforothers (all) - reports (all) 3) Create (or make sure you already have) a patron in another branch (if using an existing patron, make sure they have no checkouts or checkout history) 4) Log in as your limited staff patron 5) Go to Reports > Inactive > Patrons who haven't checked out 6) Don't put in any limitations and click Submit -- The patron from the other library appears in the list 7) Try to search for that other patron in the patron module -- The patron from the other library is inaccessible 8) Apply the patch 9) Notice that the limited patron can only see patrons from his own library Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 17:02:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 15:02:40 +0000 Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #22 from Katrin Fischer --- There is a change on set-library.tt causing a conflict that I am not sure enough about to resolve. Can you please rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 17:02:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 15:02:52 +0000 Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Summary|Add a permission to control |Add a permission to control |the ability to change the |the ability to change the |logged in branch |logged in library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 17:08:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 15:08:39 +0000 Subject: [Koha-bugs] [Bug 27259] HomeOrHoldingBranch is not used in all places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27259 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 17:09:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 15:09:47 +0000 Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 17:59:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 15:59:14 +0000 Subject: [Koha-bugs] [Bug 31346] On the OPAC detail page some Syndetics links are wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31346 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 18:02:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 16:02:27 +0000 Subject: [Koha-bugs] [Bug 23032] Add 264 to Alternate Graphic Representation (MARC21 880) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23032 giuseppe.angilella at ct.infn.it changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |giuseppe.angilella at ct.infn. | |it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 18:02:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 16:02:51 +0000 Subject: [Koha-bugs] [Bug 31281] Overdue notices reply-to email address of a branch not respected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |victor at tuxayo.net --- Comment #14 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 18:05:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 16:05:30 +0000 Subject: [Koha-bugs] [Bug 23032] Add 264 to Alternate Graphic Representation (MARC21 880) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23032 giuseppe.angilella at ct.infn.it changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 --- Comment #1 from giuseppe.angilella at ct.infn.it --- It would be desirable that also Alternate graphic representation (880) for Content (505, particularly 505$t) were displayed in the OPAC and intranet detail pages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 18:05:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 16:05:38 +0000 Subject: [Koha-bugs] [Bug 31325] Fix koha-preferences get In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31325 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 18:09:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 16:09:07 +0000 Subject: [Koha-bugs] [Bug 31276] Report results are limited to 999, 999 no matter the actual number of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31276 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to stable |RESOLVED --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 21:19:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 19:19:40 +0000 Subject: [Koha-bugs] [Bug 31738] Unstranslatable string in checkouts.js for recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31738 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 21:19:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 19:19:44 +0000 Subject: [Koha-bugs] [Bug 31738] Unstranslatable string in checkouts.js for recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31738 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141935|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 141946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141946&action=edit Bug 31738: Fix untanslatable string for recalls To test translation: 1. Apply patch and update your po files using: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation 2. Verify the string appears in po files now and translate it 3. Install the language To test functionality: 1. Turn on recalls 1.1. In Administration > Global system preferences, enable UseRecalls 1.2. Add recalls permissions in your circulation rules 2. In the OPAC, log in as a patron 3. Find a record with checked out items and place a recall 4. In the intranet, go to the patron file of the patron who currently has that item checked out --> In the Checkouts table at the bottom of the page, there is a red message next to the recalled title Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 22:00:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 20:00:30 +0000 Subject: [Koha-bugs] [Bug 31839] New: Error 500 in normal administrative interface view Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31839 Bug ID: 31839 Summary: Error 500 in normal administrative interface view Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: ricvargasmed at gmail.com QA Contact: testopia at bugs.koha-community.org In Koha 21.11.12, when having the localcoverimages preference active and uploading a cover page of a record, it saves it correctly but in the normal view it marks error 500 and does not allow to consult the information, the MARC, tagged MARC and items view works correctly. If the localcoverimages preference is deactivated, the record is visible in the normal view, but without its cover page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 22:57:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 20:57:48 +0000 Subject: [Koha-bugs] [Bug 28012] Error on Saving new numbering pattern In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 22:57:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 20:57:52 +0000 Subject: [Koha-bugs] [Bug 28012] Error on Saving new numbering pattern In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140196|0 |1 is obsolete| | --- Comment #17 from David Nind --- Created attachment 141947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141947&action=edit Bug 28012: Use definedness test instead of bool when checking whether to null fields Saving a new numbering pattern didn't work without having to fill all the fields, even those that are not mandatory. To test: 1) Go to /cgi-bin/koha/serials/subscription-numberpatterns.pl and try creating a new pattern, notice that only Name and Description are mandatory after applying this patch 2) Make sure editing existing numbering patterns still works Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 22:57:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 20:57:58 +0000 Subject: [Koha-bugs] [Bug 28012] Error on Saving new numbering pattern In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140322|0 |1 is obsolete| | --- Comment #18 from David Nind --- Created attachment 141948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141948&action=edit Bug 28012: Creating numbering pattern: mark mandatory fields required If any of these fields were missing, notably the Numbering formula then saving the new numbering pattern silently failed, it didn't give any error but it didn't save any new pattern either. Note that there is a plan to make description field optional, so even if it currently is mandatory on the DB level we leave it optional here (and due to people using production DB's in non-strict mode which allows this to be optional). To test: 1) After applying this patch make sure all the 3 fields must be filled in /cgi-bin/koha/serials/subscription-numberpatterns.pl?op=new page and it cannot be saved without those. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 23:10:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 21:10:18 +0000 Subject: [Koha-bugs] [Bug 28012] Error on Saving new numbering pattern In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the serials new release notes| |numbering pattern input | |form so that the name and | |numbering formula fields | |are marked as required. | |Before this, there was no | |indication that these | |fields were required and | |error trace messages were | |displayed if these were not | |completed - saving a new | |pattern or editing an | |existing pattern would also | |silently fail. | | | |NOTE: | |Making the description | |field optional will be | |fixed in bug 31297. Until | |this is done, a value needs | |to be entered into this | |field - even though it | |doesn't indicate that it is | |required. CC| |david at davidnind.com --- Comment #19 from David Nind --- Testing notes (using koha-testing-docker) - I hope I got this right! Replicate the issue: 1. Go to Serials > Manage numbering patterns. 2. Add a new numbering pattern, but leave the description field blank (copy an existing numbering pattern such as Number) - note that no fields are marked as required: ==> C4::Serials::Numberpattern::AddSubscriptionNumberpattern(): DBI Exception: DBD::mysql::st execute failed: Incorrect integer value: '' for column `koha_kohadev`.`subscription_numberpatterns`.`add2` at row 1 at /kohadevbox/koha/serials/subscription-numberpatterns.pl line 70 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 3. Repeat step 2 but leave the display order field blank: ==> C4::Serials::Numberpattern::AddSubscriptionNumberpattern(): DBI Exception: DBD::mysql::st execute failed: Incorrect integer value: '' for column `koha_kohadev`.`subscription_numberpatterns`.`displayorder` at row 1 at /kohadevbox/koha/serials/subscription-numberpatterns.pl line 70 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 4. Repeat step 2, leaving name or numbering formula fields blank: ==> adding the new numbering pattern silently fails - you are return to the list of numbering patterns and the your new numbering pattern is not saved. 5. Fill in all the fields (name, description, numbering formula, and display order) and save: ==> C4::Serials::Numberpattern::AddSubscriptionNumberpattern(): DBI Exception: DBD::mysql::st execute failed: Incorrect integer value: '' for column `koha_kohadev`.`subscription_numberpatterns`.`add2` at row 1 at /kohadevbox/koha/serials/subscription-numberpatterns.pl line 70 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 6. Edit an existing pattern with the various combinations from steps 2-5 (for example, the existing number pattern) - no fields are marked as required, you get these results: . Name: C4::Serials::Numberpattern::ModSubscriptionNumberpattern(): DBI Exception: DBD::mysql::st execute failed: Column 'label' cannot be null at /kohadevbox/koha/serials/subscription-numberpatterns.pl line 95 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 . Numbering formula: C4::Serials::Numberpattern::ModSubscriptionNumberpattern(): DBI Exception: DBD::mysql::st execute failed: Column 'numberingmethod' cannot be null at /kohadevbox/koha/serials/subscription-numberpatterns.pl line 95 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 . Description: C4::Serials::Numberpattern::ModSubscriptionNumberpattern(): DBI Exception: DBD::mysql::st execute failed: Column 'description' cannot be null at /kohadevbox/koha/serials/subscription-numberpatterns.pl line 95 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 . Display order: can make blank or renumber This fixes the new numbering pattern input form so that the name and numbering formula fields are marked as required. Before this, there was no indication that these fields were required and error trace messages were displayed if these were not completed, and saving a new pattern or editing an existing pattern would silently fail. Notes: - The description field is not marked as required, but if you leave it blank you will get this error: C4::Serials::Numberpattern::AddSubscriptionNumberpattern(): DBI Exception: DBD::mysql::st execute failed: Column 'description' cannot be null at /kohadevbox/koha/serials/subscription-numberpatterns.pl line 73 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 - Making the description field optional will be fixed in bug 31297 (see comment#15). Test plan: 1. Apply the patches. 2. Go to Serials > Manage numbering patterns. 3. Add a new numbering pattern: . Note that the name and numbering formula fields are now marked as required . If you try to save without completing any of the required fields, you will be prompted to complete these . For testing this bug, put a value in the description field (see notes above). 4. Edit an existing pattern:* . Note that the name and numbering formula fields are now marked as required . If you try to save without completing any of the required fields, you will be prompted to complete these . For testing this bug, put a value in the description field (see notes above). * No test is included for an existing numbering pattern that doesn't have a description. With the sample data included in KTD a database table update would be required to allow NULL values for the description field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 23:10:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 21:10:44 +0000 Subject: [Koha-bugs] [Bug 31302] Spelling: You can download the scanned materials via the following url(s): In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31302 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to stable |RESOLVED --- Comment #6 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 23:11:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 21:11:01 +0000 Subject: [Koha-bugs] [Bug 31297] Cannot add new subscription patterns from edit subscription page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31297 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 23:13:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 21:13:53 +0000 Subject: [Koha-bugs] [Bug 31294] Article requests: Mandatory subfields in OPAC don't show they are required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #6 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 23:17:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 21:17:16 +0000 Subject: [Koha-bugs] [Bug 26632] BatchStageMarcRecords passes a random number to AddBiblioToBatch / AddAuthToBatch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26632 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #11 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 23:23:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 21:23:14 +0000 Subject: [Koha-bugs] [Bug 19540] opac-reserve does not correctly warn of too_much reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19540 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #17 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 23:23:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 21:23:58 +0000 Subject: [Koha-bugs] [Bug 31228] Fix Coce JavaScript to hide single-pixel cover images in both the staff client detail and results pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31228 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #18 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 23:43:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 21:43:47 +0000 Subject: [Koha-bugs] [Bug 29782] Additional contents: Fix handling records without title or content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #16 from Victor Grousset/tuxayo --- Missing dependencies for 21.05.x, it shouldn't be affected, no backport. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 16 23:45:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 21:45:53 +0000 Subject: [Koha-bugs] [Bug 31222] DBIC queries for batch mod can be very large In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #18 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 00:46:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 22:46:27 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #20 from David Cook --- I haven't looked into the code yet but I was wondering how you work out the branch for the checkout. For a multi-branch library, they might need to self-checkout from multiple different locations. Do we just use the holdingbranch of the item in that case? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 00:55:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 22:55:15 +0000 Subject: [Koha-bugs] [Bug 31755] Store biblio OPAC visibility in biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31755 --- Comment #3 from David Cook --- (In reply to Katrin Fischer from comment #2) > We'd also need a maintenance script then, because if items make a record > hidden can be changed on the fly. It would make things a bit less flexible > for libraries again... having to ask someone to run jobs server side if > often not an easy thing for them. Flexibility is what got us into this mess in the first place... > Maybe this makes more sense for OpacSuppression only as a first step? Sure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 01:15:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 23:15:11 +0000 Subject: [Koha-bugs] [Bug 31756] Biblionumber not numerically sorting natively when using Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 --- Comment #11 from David Cook --- (In reply to Nick Clemens from comment #10) > I don't see any problems with 1000+ records in MARC21 > > I wonder though, do we need to remove the XSLT changes? The sorting works > the same with or without them, and helps those who might not know enough > about YAZ options but use Z39.50 to search Koha. I suggest dropping the last > two patches. I'm happy for the last two patches to be dropped. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 01:16:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Oct 2022 23:16:06 +0000 Subject: [Koha-bugs] [Bug 31756] Biblionumber not numerically sorting natively when using Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 --- Comment #12 from David Cook --- (In reply to David Nind from comment #5) > However, for UNIMARC: > - I changed the count number =100 > - After the first 10 pages of results (that is, from page 11 and the 1001 > search result) the order changes to asc starting from 1 Have you tried testing this before applying the patch? Does it only happy with these patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 02:22:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 00:22:42 +0000 Subject: [Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel cover images in the OPAC lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #21 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 02:27:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 00:27:46 +0000 Subject: [Koha-bugs] [Bug 30779] Do not need to remove items from import biblios marc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |victor at tuxayo.net --- Comment #11 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 02:28:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 00:28:13 +0000 Subject: [Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #6 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 02:43:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 00:43:58 +0000 Subject: [Koha-bugs] [Bug 31840] New: Incorrect warning that order total amount exceeds allowed budget when editing existing order Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31840 Bug ID: 31840 Summary: Incorrect warning that order total amount exceeds allowed budget when editing existing order Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org We've noticed that we're getting a warning that the order total amount exceeds the allowed budget when we shouldn't be. To reproduce: 1. Add an active budget of $1,000 2. Attach a fund of $900 3. In Acquisitions, add an order to a basket, give it a vendor price of $500 with no discount and Save 4. Modify the order and change the vendor price to $450. Save the order 5. Notice the warning that we'll exceed the allowed budget, even though this is the only order using this fund and it does not exceed $900. Koha does a weird 500+450 calculation and thinks we've now ordered more than $900 but it is not considering that we've modified an existing order. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 02:44:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 00:44:04 +0000 Subject: [Koha-bugs] [Bug 31840] Incorrect warning that order total amount exceeds allowed budget when editing existing order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31840 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 02:44:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 00:44:13 +0000 Subject: [Koha-bugs] [Bug 31840] Incorrect warning that order total amount exceeds allowed budget when editing existing order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31840 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.05 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 02:44:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 00:44:42 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #77 from Victor Grousset/tuxayo --- Test plan is missing something: > 3. Apply this patch > 4. Repeat 2 > => SUCCESS: Commit succeeds > 5. Sign off :-D step 1 should be repeated as well. Otherwise there is nothing to commit and no error. And when repeating step two, change --batch-number from 1 to 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 02:45:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 00:45:25 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #78 from Victor Grousset/tuxayo --- Backported: Pushed to 21.05.x branch for the upcoming release (21.05.20) Nothing to document. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 02:45:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 00:45:55 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.01 |22.11.00, 22.05.01, released in| |21.05.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 04:27:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 02:27:10 +0000 Subject: [Koha-bugs] [Bug 31840] Incorrect warning that order total amount exceeds allowed budget when editing existing order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31840 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 04:27:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 02:27:14 +0000 Subject: [Koha-bugs] [Bug 31840] Incorrect warning that order total amount exceeds allowed budget when editing existing order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31840 --- Comment #1 from Aleisha Amohia --- Created attachment 141949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141949&action=edit Bug 31840: Consider current cost if modifying order This patch deducts the current cost of an order if modifying it, so that the current cost isn't counted when checking whether the updated cost will take the order total amount above the allowed budget. To test: 1. Add an active budget of $1,000 2. Attach a fund of $1,000. Set the fund to warn at 98% and $900. 3. Add an order to a basket, give it a vendor price of $500 with no discount or tax and Save 4. Modify the order and change the vendor price to $450 and Save 5. Notice you get a warning that this order total amount will exceed the allowed budget - this is incorrect. 6. Apply the patch and cancel the change so you're redirected back to the basket 7. Modify the order and change the vendor price to $450 and Save 8. You should be able to Save without requiring confirmation 9. Add another order to the basket, give it a vendor price of $100 with no discount or tax and Save. This should save normally, confirming we can add new orders that do not exceed the allowed budget 10. Add another order to the basket, give it a vendor price of $500 with no discount or tax and Save. This should trigger the warning that you will exceed the allowed budget, as expected. Sponsored-by: Waikato Institute of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 04:30:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 02:30:49 +0000 Subject: [Koha-bugs] [Bug 31840] Incorrect warning that order total amount exceeds allowed budget when editing existing order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31840 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch deducts the release notes| |current cost of an order if | |modifying it, so that the | |current cost isn't counted | |when checking whether the | |updated cost will take the | |order total amount above | |the allowed budget. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 04:47:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 02:47:55 +0000 Subject: [Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31840 CC| |aleisha at catalyst.net.nz Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31840 [Bug 31840] Incorrect warning that order total amount exceeds allowed budget when editing existing order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 04:47:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 02:47:55 +0000 Subject: [Koha-bugs] [Bug 31840] Incorrect warning that order total amount exceeds allowed budget when editing existing order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31840 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31631 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 05:04:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 03:04:14 +0000 Subject: [Koha-bugs] [Bug 30403] Update notforloan status also on check out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #9 from Victor Grousset/tuxayo --- > I tested this patch once (Koha 21.05 or 21.11, I don't remember) How did you test it on 21.05 or 21.11? The sandboxes can't work if trying to get an older version of Koha. Anyway, setting this to "patch does not apply" since that's the current blocker. Don't hesitate to do this if when applying a patch in a sandbox you get "CONFLICT (content): Merge conflict" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 05:29:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 03:29:37 +0000 Subject: [Koha-bugs] [Bug 22760] catalogue search yields no results if queryparser is on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22760 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED CC| |dcook at prosentient.com.au Resolution|--- |INVALID --- Comment #8 from David Cook --- QueryParser doesn't exist anymore so this should be invalid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 05:30:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 03:30:31 +0000 Subject: [Koha-bugs] [Bug 31841] New: Shelving location search in staff interface dropdown yields invalid Zebra search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841 Bug ID: 31841 Summary: Shelving location search in staff interface dropdown yields invalid Zebra search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au If you choose "Shelving location" in the staff interface dropdown menu, it generates an invalid Zebra search. Example: 14:21:54-17/10 zebrasrv(3) [request] Search biblios ERROR 114 1 1+0 RPN @attrset Bib-1 @or @or @attr 1=8013 @attr 4=1 @attr 6=3 @attr 9=32 @attr 2=102 WEB @attr 1=8013 @attr 4=1 @attr 9=26 @attr 2=102 WEB @a ttr 1=8013 @attr 4=6 @attr 9=20 @attr 2=102 WEB Here's what we actually want to create: 14:21:48-17/10 zebrasrv(2) [request] Search biblios OK 20892 1 1+0 RPN @attrset Bib-1 @attr 1=8013 @attr 4=6 @attr 2=102 WEB -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 05:30:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 03:30:39 +0000 Subject: [Koha-bugs] [Bug 31841] Shelving location search in staff interface dropdown yields invalid Zebra search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 05:34:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 03:34:42 +0000 Subject: [Koha-bugs] [Bug 31841] Shelving location search in staff interface dropdown yields invalid Zebra search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841 --- Comment #1 from David Cook --- Ok it's working in master although it doesn't set the index dropdowns correctly so I guess I can re-purpose this report... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 05:35:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 03:35:12 +0000 Subject: [Koha-bugs] [Bug 31841] Shelving location index not correctly set for "Search within results" or "Edit this search" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Shelving location search in |Shelving location index not |staff interface dropdown |correctly set for "Search |yields invalid Zebra search |within results" or "Edit | |this search" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 05:39:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 03:39:20 +0000 Subject: [Koha-bugs] [Bug 31841] Shelving location index not correctly set for "Search within results" or "Edit this search" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841 --- Comment #2 from David Cook --- Or maybe not... certain permutations of sysprefs don't work... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 05:39:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 03:39:55 +0000 Subject: [Koha-bugs] [Bug 31841] Shelving location search in staff interface sometimes creates invalid Zebra query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Shelving location index not |Shelving location search in |correctly set for "Search |staff interface sometimes |within results" or "Edit |creates invalid Zebra query |this search" | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 05:41:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 03:41:56 +0000 Subject: [Koha-bugs] [Bug 31841] Shelving location search in staff interface sometimes creates invalid Zebra query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841 --- Comment #3 from David Cook --- In Master: 1) Turn off QueryAutoTruncate 2) Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=GEN&idx=location 3) Note "No results found" The problem is that QueryWeightFields adds a "phr" qualifier which is a problem since "location" doesn't have a phrase index defined...: (rk=( location,ext,r1=" GEN " or location,phr,r3=" GEN " or location,wrdl,r6=" GEN " or location,wrdl,fuzzy,r8=" GEN " or location,wrdl,rt,r9=""gen"? ")) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 05:49:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 03:49:10 +0000 Subject: [Koha-bugs] [Bug 31841] Shelving location search in staff interface sometimes creates invalid Zebra query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 05:49:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 03:49:14 +0000 Subject: [Koha-bugs] [Bug 31841] Shelving location search in staff interface sometimes creates invalid Zebra query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841 --- Comment #4 from David Cook --- Created attachment 141950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141950&action=edit Bug 31841: Use location,wrdl when searching Shelving location The "location" index only has a word index defined, so we need to specify the wrdl qualifier when searching it via the staff interface dropdown menu Test plan: 1) Change QueryAutoTruncate to "only if * is added" 2) Change IntranetCatalogSearchPulldown to "Show" 3) Search for "Shelving location" of "GEN" in catalogue search bar 4) Note no results returned 5) Apply patch 6) koha-plack --restart kohadev 7) Repeat Step #3 8) Note that results appear for 'location,wrdl: GEN' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 05:57:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 03:57:07 +0000 Subject: [Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 08:15:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 06:15:32 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141869|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 08:15:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 06:15:54 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138310|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 08:16:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 06:16:08 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141876|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 08:16:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 06:16:22 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141877|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 08:16:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 06:16:34 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141878|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 08:17:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 06:17:07 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141879|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 08:21:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 06:21:38 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138309|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 08:21:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 06:21:51 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141869|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 08:27:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 06:27:48 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #49 from Kevin Carnes --- Created attachment 141951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141951&action=edit Bug 29012: Fix existing update to prevent inserting incorrect data Both updates now rely on 'suspension_chargeperiod' as the source of truth for existence of a rule. Spot checking some existing production databases this seems to be acceptable. This alters the update to only add rules where a 'suspension_chargeperiod' rule exists and a value for the rule is not already set. NOTE: While the table has a unique key: UNIQUE KEY `branchcode` (`branchcode`,`categorycode`,`itemtype`,`rule_name`), This key doesn't prevent duplicates on NULLs, i.e.: branchcode | categorycode | itemtype | rule_name | rule_value NULL | NULL | BK | unseen_renewals_allowed | 1 NULL | NULL | BK | unseen_renewals_allowed | 2 NULL | NULL | BK | unseen_renewals_allowed | 3 So we need to both check that any rule is present and that the specific rule is not. The 'INSERT IGNORE' won't IGNORE existing values except for the most specific rules Test plan: 0 - Edit and save existing default rule in DB (sample data does not include suspension_chargeperiod) 1 - Set some rules for "Default checkout, hold and return policy" for "Standard rule" and some specific libraries 2 - cp installer/data/mysql/db_revs/220600024.pl installer/data/mysql/atomicupdate/ 3 - SELECT * FROM circulation rules, note the number of rules that exist 4 - updatedatabase 5 - Check the DB again, you should now have rules as described in the bug i.e. You will have 5 new rules per 'Default checkout, hold and return policy' 6 - apply 1st patch on bug 7 - rm installer/data/mysql/atomicupdate/220600024.pl (so we don't add again) 8 - updatedatabase 9 - Check DB, the extra rules have been deleted 10 - Apply 2nd patch 11 - cp installer/data/mysql/db_revs/220600024.pl installer/data/mysql/atomicupdate/ 12 - rm installer/data/mysql/atomicupdate/bug_31727.pl (so we can confirm update isn't adding rules) 13 - updatedatabase 14 - Confirm no change in rules since step 9 15 - git reset --hard (get deleted update back) 16 - rm installer/data/mysql/atomicupdate/220600024.pl Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 08:28:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 06:28:14 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #50 from Kevin Carnes --- Created attachment 141952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141952&action=edit Bug 29012: Fix undef warnings around unseen_renewals_allowed in smart-rules.pl Trivial fix. To reproduce: 1. Create or edit a rule on /cgi-bin/koha/admin/smart-rules.pl - i.e. submit the form (make POST request) 2. Notice the mentioned above warning in plack-intranet-error.log 3. Apply the patch. 4. Repeat step 1. 5. That warning in log file should be no more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 08:32:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 06:32:39 +0000 Subject: [Koha-bugs] [Bug 31816] Switch singleBranchMode to singleLibraryMode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31816 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 08:32:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 06:32:52 +0000 Subject: [Koha-bugs] [Bug 31817] Libraries navigation item should not display if all libaries are set to non-public In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31817 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 08:42:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 06:42:40 +0000 Subject: [Koha-bugs] [Bug 31777] Allow for scheduling of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31777 Marie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom at musikverket.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 09:02:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 07:02:07 +0000 Subject: [Koha-bugs] [Bug 31825] On order receive suggestion info block always shows, even if there is no suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 10:00:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 08:00:53 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 --- Comment #24 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #22) > Jonathan, left comment17 and comment19 for your consideration :) Why didn't you add that on the original bug report? :) (In reply to Marcel de Rooy from comment #17) > =head3 new > > my $form = Koha::UI::Form::Builder::Item->new( > { > biblionumber => $biblionumber, > item => $current_item, > } > ); > > Constructor. > biblionumber should be passed if we are creating a new item. > For edition, an hashref representing the item to edit item must be passed. > > Hmm. Why did the author not just pick the biblionumber of the item? The item is not created yet, and so does not belongs to the biblio yet. But I agree we could add it to the item hashref, remove the param and use item->{biblionumber} instead. (In reply to Marcel de Rooy from comment #19) > We are really wasting resources here. > > First we do: > my %itemdata = map { lc($_->{barcode}) => $_->{itemnumber} } @{ > Koha::Items->search({ barcode => { -in => \@barcodelist } }, { columns => [ > 'itemnumber', 'barcode' ] } )->unblessed }; > > Lets discard that info. > And later do: > > sub build_table { > my ( $self, $params ) = @_; > my %itemnumbers_to_idx = map { $self->{itemnumbers}->[$_] => $_ } > 0..$#{$self->{itemnumbers}}; > my $items = Koha::Items->search( { itemnumber => $self->{itemnumbers} } > ); > > We are looking up all items again ;) >From controller we are only fetching itemnumber and barcode. That's extra processing for the "max items to display" feature. From the module we are fetching everything. I am expecting the query from the controller to be very fast, using DBMS indexes. What did we do before 28445 and friends? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 10:01:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 08:01:19 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 --- Comment #25 from Jonathan Druart --- This changes forgot to add unit tests btw. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 10:13:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 08:13:02 +0000 Subject: [Koha-bugs] [Bug 20558] typo mts_authorized_value vs mts_authorised_value in admin/marctagstructure.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20558 --- Comment #2 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #1) > (In reply to Jonathan Druart from comment #0) > > What are the consequences of this? > > There are no consequences. This is dead code. Are you sure? Didn't investigate much, only using git grep admin/marctagstructure.pl: marc_tag_structure.authorised_value as mts_authorized_value, admin/marctagstructure.pl: $row_data{authorised_value} = $results[$i]->{'mts_authorised_value'}; koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt: [% loo.authorised_value | html %] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 10:24:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 08:24:20 +0000 Subject: [Koha-bugs] [Bug 31568] Renaming/removing an authorised value does not cascade to linked tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31568 --- Comment #2 from Jonathan Druart --- Well, there is the script :) An other solution could be to SELECT COUNT(*) FROM items where location = $old_value and display an alert if there are some. You could also provide a link to the batch mod item with the items to modify. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 10:25:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 08:25:28 +0000 Subject: [Koha-bugs] [Bug 31281] Overdue notices reply-to email address of a branch not respected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 --- Comment #15 from Martin Renvoize --- Hmm, this seems to have jumped an rmaint.. this is probably a decent candidate for 21.11.x ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 10:48:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 08:48:24 +0000 Subject: [Koha-bugs] [Bug 30225] Rewrite cities admin view in Vue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30225 --- Comment #16 from Jonathan Druart --- Hum, the ERM code diverged a lot from this. This was supposed to get attention several months ago, now people should focus on ERM. This bug is still valid and the patch can be seen as a quick overview of Vue, and to see it live in Koha. But this patch cannot be pushed to master as it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 11:22:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 09:22:34 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 --- Comment #26 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #25) > This changes forgot to add unit tests btw. We have t/db_dependent/Koha/UI/Form/Builder/Item.t, but generate_subfield_form is not tested directly. Cannot request imo to add tests for trivial changes where the original author did not add tests himself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 11:24:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 09:24:15 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #73 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #72) > Caught by Owen on IRC: DT search is broken (general search when searching > for libraries). > > Uncaught TypeError: col.data.split is not a function > > > It's because opac_info is searchable but "data" is a function: > > "data": function( row, type, val, meta ) { > return ''; // provisional placeholder for opac_info > }, > "searchable": true, > "visible": false, > "orderable": false > > It could be considered a bug from datatables.js, but I don't think it is. We > should fix branch.tt instead. Will probably open a new report for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 11:32:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 09:32:38 +0000 Subject: [Koha-bugs] [Bug 31842] New: Fix rebase issue for branches.tt from 29144 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Bug ID: 31842 Summary: Fix rebase issue for branches.tt from 29144 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org See comment73 on bug 29144. Looks like a rebase issue. Addressing it here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 11:33:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 09:33:04 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #74 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #73) > > It could be considered a bug from datatables.js, but I don't think it is. We > > should fix branch.tt instead. > > Will probably open a new report for this. Bug 31842. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 11:33:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 09:33:22 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | Blocks| |31842 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 [Bug 31842] Fix rebase issue for branches.tt from 29144 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 11:33:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 09:33:22 +0000 Subject: [Koha-bugs] [Bug 31842] Fix rebase issue for branches.tt from 29144 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 11:34:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 09:34:23 +0000 Subject: [Koha-bugs] [Bug 31842] Fix rebase issue for branches.tt from 29144 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 11:39:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 09:39:29 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #75 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #73) > (In reply to Jonathan Druart from comment #72) > > Caught by Owen on IRC: DT search is broken (general search when searching > > for libraries). > > > > Uncaught TypeError: col.data.split is not a function > > > > It's because opac_info is searchable but "data" is a function: > > > > "data": function( row, type, val, meta ) { > > return ''; // provisional placeholder for opac_info > > }, > > "searchable": true, > > "visible": false, > > "orderable": false I am seeing several columns where data is a function btw. "data": function( row, type, val, meta ) { const library_info = []; "data": function( row, type, val, meta ) { var result = ' '+_("Edit")+''; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 11:44:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 09:44:49 +0000 Subject: [Koha-bugs] [Bug 31842] Fix rebase issue for branches.tt from 29144 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #1 from Marcel de Rooy --- It is no rebase issue after all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 11:45:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 09:45:09 +0000 Subject: [Koha-bugs] [Bug 31842] Fix issue with col.data.split for branches.tt from 29144 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix rebase issue for |Fix issue with |branches.tt from 29144 |col.data.split for | |branches.tt from 29144 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 11:45:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 09:45:22 +0000 Subject: [Koha-bugs] [Bug 31842] Fix issue with col.data.split for branches.tt related to 29144 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix issue with |Fix issue with |col.data.split for |col.data.split for |branches.tt from 29144 |branches.tt related to | |29144 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 12:36:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 10:36:02 +0000 Subject: [Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | --- Comment #3 from Katrin Fischer --- Hm... a week ago - I think it's cookie time! ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 12:37:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 10:37:02 +0000 Subject: [Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | --- Comment #29 from Katrin Fischer --- 3 patches, 3 different authors, picking first. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 12:37:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 10:37:45 +0000 Subject: [Koha-bugs] [Bug 31684] Plugin versions starting with a "v" cause unnecessary warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31684 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | --- Comment #5 from Katrin Fischer --- Please don't forget to set Assignee! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 12:38:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 10:38:54 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix issue with |admin/branches: DT search |col.data.split for |generates js error on |branches.tt related to |col.data.split |29144 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 12:39:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 10:39:50 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 12:39:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 10:39:54 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #2 from Marcel de Rooy --- Created attachment 141953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141953&action=edit Bug 31842: Move data function to render in branches.tt This applies to dataTable columns: library_info, actions and opac_info. Set searchable to false for opac_info too. Test plan: Check if DT search for libraries works again. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 12:40:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 10:40:46 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 12:41:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 10:41:14 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 12:43:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 10:43:01 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #76 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #75) > (In reply to Marcel de Rooy from comment #73) > > (In reply to Jonathan Druart from comment #72) > > > Caught by Owen on IRC: DT search is broken (general search when searching > > > for libraries). > > > > > > Uncaught TypeError: col.data.split is not a function > > > > > > It's because opac_info is searchable but "data" is a function: > > > > > > "data": function( row, type, val, meta ) { > > > return ''; // provisional placeholder for opac_info > > > }, > > > "searchable": true, > > > "visible": false, > > > "orderable": false > > I am seeing several columns where data is a function btw. > > "data": function( row, type, val, meta ) { > const library_info = []; > > "data": function( row, type, val, meta ) { > var result = ' href="/cgi-bin/koha/admin/branches.pl?op=add_form& > branchcode='+encodeURIComponent(row.library_id)+'" role="button"> class="fa fa-pencil" aria-hidden="true"> '+_("Edit")+''; Addressed all three columns on bug 31842. Please test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 12:47:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 10:47:04 +0000 Subject: [Koha-bugs] [Bug 31684] Plugin versions starting with a "v" cause unnecessary warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31684 --- Comment #6 from Kyle M Hall --- (In reply to Katrin Fischer from comment #5) > Please don't forget to set Assignee! Ack! Thanks again! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 12:49:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 10:49:07 +0000 Subject: [Koha-bugs] [Bug 31843] New: Stock rotations do not allow rotas with the same name Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31843 Bug ID: 31843 Summary: Stock rotations do not allow rotas with the same name Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: pjamorim91 at gmail.com QA Contact: testopia at bugs.koha-community.org Steps to reproduce: * Enable StockRotation system preference * Tools > Stock rotation > New rota * Enter name "rota", save. * Create new rota, enter name "rota" again. * Nasty plack error This error also occurs when updating a rota's name to an already existing rota's name. plack-intranet-error.log: [WARN] DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Duplicate entry 'rota' for key 'stockrotationrotas_title' at /kohadevbox/koha/Koha/Object.pm line 170 > describe stockrotationrotas; +-------------+--------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +-------------+--------------+------+-----+---------+----------------+ | rota_id | int(11) | NO | PRI | NULL | auto_increment | | title | varchar(100) | NO | UNI | NULL | | | description | text | NO | | NULL | | | cyclical | tinyint(1) | NO | | 0 | | | active | tinyint(1) | NO | | 0 | | +-------------+--------------+------+-----+---------+----------------+ Seems that the title is set as unique in the database and is causing this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:01:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:01:56 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #13 from Kyle M Hall --- Good catch! I'll get that fixed asap! Kyle (In reply to David Nind from comment #12) > The only thing I noticed is around editing and updating an already shared > template. > > If you are not the creator, and you can have manage_item_editor_templates > permissions, if you don't select 'Share template' then you make it unshared > and can no longer see it. > > Maybe if it is a shared template, the default when updating the template is > for the share template option to be selected by default. > > To replicate: > 1. Have two librarian users, one with manage_item_editor_templates > permissions (henry) the other without (casey). > 2. Create and share a template as henry. > 3. As casey, apply the shared template and make some changes, for example > the shelving location > 4. Casey can only save as a new template, can't update the existing one - as > expected. > 5. Change permissions for casey, so they have manage_item_editor_templates. > 6. Repeat step 3 > 7. Select save as template and then select the template from under update > shared template. > 5. Don't tick the share template option. > 6. Now you can't see or choose that template - it is only visible to the > original creator (henry). > 7. Log in as henry - you can see the template, as creator. > > Everything else seems to work as per the test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:08:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:08:17 +0000 Subject: [Koha-bugs] [Bug 30487] Convert checkout and patron details page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30487 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:08:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:08:20 +0000 Subject: [Koha-bugs] [Bug 30487] Convert checkout and patron details page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30487 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:08:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:08:24 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:08:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:08:27 +0000 Subject: [Koha-bugs] [Bug 31747] Round corners in boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31747 --- Comment #13 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:08:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:08:30 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:08:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:08:33 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #20 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:08:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:08:36 +0000 Subject: [Koha-bugs] [Bug 31762] Flat vs 3D or mixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31762 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:08:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:08:39 +0000 Subject: [Koha-bugs] [Bug 31762] Flat vs 3D or mixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31762 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:08:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:08:41 +0000 Subject: [Koha-bugs] [Bug 31764] Add 'page-section' to patron clubs page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31764 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:08:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:08:44 +0000 Subject: [Koha-bugs] [Bug 31764] Add 'page-section' to patron clubs page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31764 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:08:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:08:47 +0000 Subject: [Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:08:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:08:50 +0000 Subject: [Koha-bugs] [Bug 31766] Add 'page-section' to notices and slips page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31766 --- Comment #12 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:08:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:08:53 +0000 Subject: [Koha-bugs] [Bug 31767] Add 'page-section' to tags page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31767 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:08:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:08:57 +0000 Subject: [Koha-bugs] [Bug 31767] Add 'page-section' to tags page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31767 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:08:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:08:59 +0000 Subject: [Koha-bugs] [Bug 31773] Add 'page-section' to manage MARC import page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:09:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:09:02 +0000 Subject: [Koha-bugs] [Bug 31773] Add 'page-section' to manage MARC import page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:14:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:14:13 +0000 Subject: [Koha-bugs] [Bug 31776] Typo in cleanup_database.pl cron's help/usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31776 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141917|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi --- Created attachment 141954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141954&action=edit Bug 31776: Fix a typo in cleanup_database.pl cronjob's help/usage cleanup_database.pl cronjob has a typo in it's usage/help: "preserve-logs" option should be "preserve-log" as it is everywhere in the code. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:28:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:28:46 +0000 Subject: [Koha-bugs] [Bug 28967] Patrons with no checkouts report shows patrons from other libraries with IndependentBranches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28967 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:28:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:28:49 +0000 Subject: [Koha-bugs] [Bug 28967] Patrons with no checkouts report shows patrons from other libraries with IndependentBranches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28967 --- Comment #17 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:28:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:28:53 +0000 Subject: [Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:28:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:28:57 +0000 Subject: [Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 --- Comment #23 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:28:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:28:59 +0000 Subject: [Koha-bugs] [Bug 31775] Show opac_info of single library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:29:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:29:02 +0000 Subject: [Koha-bugs] [Bug 31775] Show opac_info of single library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 --- Comment #13 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:29:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:29:06 +0000 Subject: [Koha-bugs] [Bug 31776] Typo in cleanup_database.pl cron's help/usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31776 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:29:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:29:09 +0000 Subject: [Koha-bugs] [Bug 31776] Typo in cleanup_database.pl cron's help/usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31776 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:29:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:29:12 +0000 Subject: [Koha-bugs] [Bug 31780] Add 'page-section' to audio alerts ( audio_alerts.tt ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31780 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:29:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:29:15 +0000 Subject: [Koha-bugs] [Bug 31780] Add 'page-section' to audio alerts ( audio_alerts.tt ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31780 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:29:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:29:18 +0000 Subject: [Koha-bugs] [Bug 31807] Context for translation: Filter (verb) vs. Filter (noun) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:29:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:29:21 +0000 Subject: [Koha-bugs] [Bug 31807] Context for translation: Filter (verb) vs. Filter (noun) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:29:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:29:24 +0000 Subject: [Koha-bugs] [Bug 31808] When placing a hold patron name is not displaying correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31808 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:29:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:29:27 +0000 Subject: [Koha-bugs] [Bug 31808] When placing a hold patron name is not displaying correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31808 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:48:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:48:22 +0000 Subject: [Koha-bugs] [Bug 28375] Inefficiencies in fetching COinS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:48:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:48:27 +0000 Subject: [Koha-bugs] [Bug 28375] Inefficiencies in fetching COinS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141490|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy --- Created attachment 141955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141955&action=edit Bug 28375: Inefficiencies in fetching COinS This patchset adds an 'interface' parameter to XSLTParseForDisplay to avoid fetching coins when not needed Additionally we move some logic from the scripts to searchResults to avoid an extra fetch fo the biblio object To test: 1 - Enable COinSinOPACResults syspref 2 - Also enable OPACShowOpenURL and OPACOpenURLItemTypes - adding an itemtype that you can find 3 - Perform a search on the OPAC and confirm coins are included and openurl shown 4 - Perform a search on staff client and confirm openurls do not show 5 - Apply patch 6 - Results should be the same Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:48:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:48:32 +0000 Subject: [Koha-bugs] [Bug 28375] Inefficiencies in fetching COinS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141491|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy --- Created attachment 141956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141956&action=edit Bug 28375: (follow-up) Remove guessed interface parameter - always pass Previous patch added interface parameter passed on each call. There was an existing one that 'guessed' - this patch removes that Fixes missing comma Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:48:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:48:36 +0000 Subject: [Koha-bugs] [Bug 28375] Inefficiencies in fetching COinS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141497|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy --- Created attachment 141957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141957&action=edit Bug 28375: (follow-up) Use C4::Context->interface Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:48:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:48:41 +0000 Subject: [Koha-bugs] [Bug 28375] Inefficiencies in fetching COinS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375 --- Comment #19 from Marcel de Rooy --- Created attachment 141958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141958&action=edit Bug 28375: (QA follow-up) Remove two remaining interface params No test plan: parameter is already obsolete. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:57:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:57:30 +0000 Subject: [Koha-bugs] [Bug 30487] Convert checkout and patron details page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30487 --- Comment #6 from Thibaud Guillot --- Created attachment 141959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141959&action=edit Bug 30487: Compiled CSS Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:58:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:58:04 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:58:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:58:08 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 --- Comment #12 from Nick Clemens --- Created attachment 141960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141960&action=edit Bug 31459: (follow-up) Return 'Keep current' option This patch restores the option to keep current budget, in the case that receiver can receive, but cannot order on current budget -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 13:58:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 11:58:21 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140238|0 |1 is obsolete| | --- Comment #24 from Thibaud Guillot --- Created attachment 141961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141961&action=edit Bug 30250: Use ApplyFrameworkDefaults when cataloguing This patch adds a system preference ApplyFrameworkDefaults to configure when to apply framework defaults - when cataloguing a new record, when editing a record as new (duplicating), or when changing the framework while editing an existing record. This applies to both bibliographic records and authority records. To test: 1. Update database 2. Go to Administration -> system preferences. Find the ApplyFrameworkDefaults system preference. Confirm "when cataloguing new records" is selected by default. 3. Keep the system preference open in one tab, and open the staff client in another tab. 4. Go to Administration -> bibliographic frameworks. Choose a framework, edit the subfields for a tag, and give a subfield a default value. For example, set 500$a for the BOOKS framework to have a default value of "TEST". This will be Framework A. 5. Ensure you have another framework that does not have the same default value for a subfield as Framework A. This will be Framework B. 6. Go to Cataloguing. Add a new record using Framework A. Confirm your subfield has the default value filled. Cancel and do not save the record. 7. In your System preferences tab, uncheck the option "when cataloguing new records" and save. No options should now be selected. 8. In our other tab, go to cataloguing, add a new record using Framework A. Confirm your subfield does NOT have the default value filled. Fill the required fields, including the subfield that should have a default value, and Save the record. 9. In your system preferences tab, select all options and save. 10. In your other tab, click Edit, then "Edit as new (duplicate)". Confirm your subfield has maintained the value from the source record. Cancel and do not save the record. 11. Edit your original record and delete the value in your subfield that could be filled with a default value by the framework. Save the record with no value in the subfield. 12. Click Edit, then "Edit as new (duplicate)". Confirm your subfield has the default value filled. Framework defaults will only apply to emplty fields. Save the record. 13. Do a catalogue search and find a record that uses Framework B. 14. If you need to, edit the record to make sure there is nothing in your subfield that should have a default value if this record were to use Framework A, and Save. 15. Edit the record. Using the settings dropdown, change the framework to Framework A. Confirm your subfield has the default value filled. 16. Repeat steps 4 to 12 with authority types and authority records. Sponsored-by: Education Services Australia SCIS Rebased by -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 14:00:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 12:00:19 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140238|1 |0 is obsolete| | --- Comment #25 from Thibaud Guillot --- Comment on attachment 140238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140238 Bug 30250: Use ApplyFrameworkDefaults when cataloguing >From e40573b3a3ae02f146906b33ded9494f722f0de5 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia >Date: Wed, 9 Mar 2022 01:13:32 +0000 >Subject: [PATCH] Bug 30250: Use ApplyFrameworkDefaults when cataloguing > >This patch adds a system preference ApplyFrameworkDefaults to configure >when to apply framework defaults - when cataloguing a new record, when >editing a record as new (duplicating), or when changing the framework >while editing an existing record. This applies to both bibliographic >records and authority records. > >To test: >1. Update database >2. Go to Administration -> system preferences. Find the >ApplyFrameworkDefaults system preference. Confirm "when cataloguing new >records" is selected by default. >3. Keep the system preference open in one tab, and open the staff client >in another tab. >4. Go to Administration -> bibliographic frameworks. Choose a framework, >edit the subfields for a tag, and give a subfield a default value. For >example, set 500$a for the BOOKS framework to have a default value of >"TEST". This will be Framework A. >5. Ensure you have another framework that does not have the same default >value for a subfield as Framework A. This will be Framework B. >6. Go to Cataloguing. Add a new record using Framework A. Confirm your >subfield has the default value filled. Cancel and do not save the >record. >7. In your System preferences tab, uncheck the option "when cataloguing >new records" and save. No options should now be selected. >8. In our other tab, go to cataloguing, add a new record using Framework >A. Confirm your subfield does NOT have the default value filled. Fill >the required fields, including the subfield that should have a default >value, and Save the record. >9. In your system preferences tab, select all options and save. >10. In your other tab, click Edit, then "Edit as new (duplicate)". >Confirm your subfield has maintained the value from the source record. >Cancel and do not save the record. >11. Edit your original record and delete the value in your subfield that >could be filled with a default value by the framework. Save the record >with no value in the subfield. >12. Click Edit, then "Edit as new (duplicate)". Confirm your subfield >has the default value filled. Framework defaults will only apply to >emplty fields. Save the record. >13. Do a catalogue search and find a record that uses Framework B. >14. If you need to, edit the record to make sure there is nothing in your >subfield that should have a default value if this record were to use >Framework A, and Save. >15. Edit the record. Using the settings dropdown, change the framework >to Framework A. Confirm your subfield has the default value filled. >16. Repeat steps 4 to 12 with authority types and authority records. > >Sponsored-by: Education Services Australia SCIS >--- > authorities/authorities.pl | 13 ++++++++++--- > cataloguing/addbiblio.pl | 12 ++++++++++-- > 2 files changed, 20 insertions(+), 5 deletions(-) > >diff --git a/authorities/authorities.pl b/authorities/authorities.pl >index b465d4bcc0..5531e708a1 100755 >--- a/authorities/authorities.pl >+++ b/authorities/authorities.pl >@@ -112,9 +112,16 @@ sub create_input { > $max_length = 40; > } > >- # if there is no value provided but a default value in parameters, get it >- if ($value eq '') { >- $value = $tagslib->{$tag}->{$subfield}->{defaultvalue} if !$cgi->param('authid'); # only for new records >+ # Apply optional framework default value when it is a new record, >+ # or when editing as new (duplicating a record), >+ # based on the ApplyFrameworkDefaults setting. >+ # Substitute date parts, user name >+ my $applydefaults = C4::Context->preference('ApplyFrameworkDefaults'); >+ if ( $value eq '' && ( >+ ( $applydefaults =~ /new/ && !$cgi->param('authid') ) || >+ ( $applydefaults =~ /duplicate/ && $cgi->param('op') eq 'duplicate' ) >+ ) ) { >+ $value = $tagslib->{$tag}->{$subfield}->{defaultvalue}; > if (!defined $value) { > $value = q{}; > } >diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl >index 92abe81082..cc7bc62637 100755 >--- a/cataloguing/addbiblio.pl >+++ b/cataloguing/addbiblio.pl >@@ -288,9 +288,17 @@ sub create_input { > > my $index_subfield = CreateKey(); # create a specifique key for each subfield > >- # Apply optional framework default value when it is a new record >+ # Apply optional framework default value when it is a new record, >+ # or when editing as new (duplicating a record), >+ # or when changing a record's framework, >+ # based on the ApplyFrameworkDefaults setting. > # Substitute date parts, user name >- if ( $value eq '' && !$cgi->param('biblionumber') ) { >+ my $applydefaults = C4::Context->preference('ApplyFrameworkDefaults'); >+ if ( $value eq '' && ( >+ ( $applydefaults =~ /new/ && !$cgi->param('biblionumber') ) || >+ ( $applydefaults =~ /duplicate/ && $cgi->param('op') eq 'duplicate' ) || >+ ( $applydefaults =~ /changed/ && $cgi->param('changed_framework') ) >+ ) ) { > $value = $tagslib->{$tag}->{$subfield}->{defaultvalue} // q{}; > > # get today date & replace <>, <>, <>, <
    > if provided in the default value >-- >2.11.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 14:00:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 12:00:52 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141961|0 |1 is obsolete| | --- Comment #26 from Thibaud Guillot --- Comment on attachment 141961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141961 Bug 30250: Use ApplyFrameworkDefaults when cataloguing >From b8312db900a4a9e7f5a3d25d08d834738d4b75ab Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia >Date: Wed, 9 Mar 2022 01:13:32 +0000 >Subject: [PATCH] Bug 30250: Use ApplyFrameworkDefaults when cataloguing > >This patch adds a system preference ApplyFrameworkDefaults to configure >when to apply framework defaults - when cataloguing a new record, when >editing a record as new (duplicating), or when changing the framework >while editing an existing record. This applies to both bibliographic >records and authority records. > >To test: >1. Update database >2. Go to Administration -> system preferences. Find the >ApplyFrameworkDefaults system preference. Confirm "when cataloguing new >records" is selected by default. >3. Keep the system preference open in one tab, and open the staff client >in another tab. >4. Go to Administration -> bibliographic frameworks. Choose a framework, >edit the subfields for a tag, and give a subfield a default value. For >example, set 500$a for the BOOKS framework to have a default value of >"TEST". This will be Framework A. >5. Ensure you have another framework that does not have the same default >value for a subfield as Framework A. This will be Framework B. >6. Go to Cataloguing. Add a new record using Framework A. Confirm your >subfield has the default value filled. Cancel and do not save the >record. >7. In your System preferences tab, uncheck the option "when cataloguing >new records" and save. No options should now be selected. >8. In our other tab, go to cataloguing, add a new record using Framework >A. Confirm your subfield does NOT have the default value filled. Fill >the required fields, including the subfield that should have a default >value, and Save the record. >9. In your system preferences tab, select all options and save. >10. In your other tab, click Edit, then "Edit as new (duplicate)". >Confirm your subfield has maintained the value from the source record. >Cancel and do not save the record. >11. Edit your original record and delete the value in your subfield that >could be filled with a default value by the framework. Save the record >with no value in the subfield. >12. Click Edit, then "Edit as new (duplicate)". Confirm your subfield >has the default value filled. Framework defaults will only apply to >emplty fields. Save the record. >13. Do a catalogue search and find a record that uses Framework B. >14. If you need to, edit the record to make sure there is nothing in your >subfield that should have a default value if this record were to use >Framework A, and Save. >15. Edit the record. Using the settings dropdown, change the framework >to Framework A. Confirm your subfield has the default value filled. >16. Repeat steps 4 to 12 with authority types and authority records. > >Sponsored-by: Education Services Australia SCIS >--- > authorities/authorities.pl | 13 ++++++++++--- > cataloguing/addbiblio.pl | 12 ++++++++++-- > 2 files changed, 20 insertions(+), 5 deletions(-) > >diff --git a/authorities/authorities.pl b/authorities/authorities.pl >index b465d4bcc0..5531e708a1 100755 >--- a/authorities/authorities.pl >+++ b/authorities/authorities.pl >@@ -112,9 +112,16 @@ sub create_input { > $max_length = 40; > } > >- # if there is no value provided but a default value in parameters, get it >- if ($value eq '') { >- $value = $tagslib->{$tag}->{$subfield}->{defaultvalue} if !$cgi->param('authid'); # only for new records >+ # Apply optional framework default value when it is a new record, >+ # or when editing as new (duplicating a record), >+ # based on the ApplyFrameworkDefaults setting. >+ # Substitute date parts, user name >+ my $applydefaults = C4::Context->preference('ApplyFrameworkDefaults'); >+ if ( $value eq '' && ( >+ ( $applydefaults =~ /new/ && !$cgi->param('authid') ) || >+ ( $applydefaults =~ /duplicate/ && $cgi->param('op') eq 'duplicate' ) >+ ) ) { >+ $value = $tagslib->{$tag}->{$subfield}->{defaultvalue}; > if (!defined $value) { > $value = q{}; > } >diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl >index 5896de18f4..4ee4c85596 100755 >--- a/cataloguing/addbiblio.pl >+++ b/cataloguing/addbiblio.pl >@@ -292,9 +292,17 @@ sub create_input { > > my $index_subfield = CreateKey(); # create a specifique key for each subfield > >- # Apply optional framework default value when it is a new record >+ # Apply optional framework default value when it is a new record, >+ # or when editing as new (duplicating a record), >+ # or when changing a record's framework, >+ # based on the ApplyFrameworkDefaults setting. > # Substitute date parts, user name >- if ( $value eq '' && !$cgi->param('biblionumber') ) { >+ my $applydefaults = C4::Context->preference('ApplyFrameworkDefaults'); >+ if ( $value eq '' && ( >+ ( $applydefaults =~ /new/ && !$cgi->param('biblionumber') ) || >+ ( $applydefaults =~ /duplicate/ && $cgi->param('op') eq 'duplicate' ) || >+ ( $applydefaults =~ /changed/ && $cgi->param('changed_framework') ) >+ ) ) { > $value = $tagslib->{$tag}->{$subfield}->{defaultvalue} // q{}; > > # get today date & replace <>, <>, <>, <
    > if provided in the default value >-- >2.25.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 14:21:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 12:21:17 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140238|0 |1 is obsolete| | --- Comment #27 from Thibaud Guillot --- Created attachment 141962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141962&action=edit Bug 30250: Use ApplyFrameworkDefaults when cataloguing This patch adds a system preference ApplyFrameworkDefaults to configure when to apply framework defaults - when cataloguing a new record, when editing a record as new (duplicating), or when changing the framework while editing an existing record. This applies to both bibliographic records and authority records. To test: 1. Update database 2. Go to Administration -> system preferences. Find the ApplyFrameworkDefaults system preference. Confirm "when cataloguing new records" is selected by default. 3. Keep the system preference open in one tab, and open the staff client in another tab. 4. Go to Administration -> bibliographic frameworks. Choose a framework, edit the subfields for a tag, and give a subfield a default value. For example, set 500$a for the BOOKS framework to have a default value of "TEST". This will be Framework A. 5. Ensure you have another framework that does not have the same default value for a subfield as Framework A. This will be Framework B. 6. Go to Cataloguing. Add a new record using Framework A. Confirm your subfield has the default value filled. Cancel and do not save the record. 7. In your System preferences tab, uncheck the option "when cataloguing new records" and save. No options should now be selected. 8. In our other tab, go to cataloguing, add a new record using Framework A. Confirm your subfield does NOT have the default value filled. Fill the required fields, including the subfield that should have a default value, and Save the record. 9. In your system preferences tab, select all options and save. 10. In your other tab, click Edit, then "Edit as new (duplicate)". Confirm your subfield has maintained the value from the source record. Cancel and do not save the record. 11. Edit your original record and delete the value in your subfield that could be filled with a default value by the framework. Save the record with no value in the subfield. 12. Click Edit, then "Edit as new (duplicate)". Confirm your subfield has the default value filled. Framework defaults will only apply to emplty fields. Save the record. 13. Do a catalogue search and find a record that uses Framework B. 14. If you need to, edit the record to make sure there is nothing in your subfield that should have a default value if this record were to use Framework A, and Save. 15. Edit the record. Using the settings dropdown, change the framework to Framework A. Confirm your subfield has the default value filled. 16. Repeat steps 4 to 12 with authority types and authority records. Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 14:21:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 12:21:23 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140239|0 |1 is obsolete| | --- Comment #28 from Thibaud Guillot --- Created attachment 141963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141963&action=edit Bug 30250: Add ApplyFrameworkDefaults system preference (cherry picked from commit 684a04deb6ec7e94ca60f5cb38811176fbb9c230) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 14:21:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 12:21:30 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140240|0 |1 is obsolete| | --- Comment #29 from Thibaud Guillot --- Created attachment 141964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141964&action=edit Bug 30250: Use ApplyFrameworkDefaults when importing a record This patch adds the case of importing a record to the ApplyFrameworkDefaults options. To test: 1. Update database 2. Confirm the ApplyFrameworkDefaults system preference now has the 'when importing a record via z39.50' option. Do not select it. 3. Go to Cataloguing. Import a record from z39.50, or replace an existing record. 4. Confirm framework defaults are not applied. 5. Go back to the system preference and check the 'when importing a record via z39.50' option. 6. Repeat step 3. This time framework defaults should be applied. Only fields that are empty in the imported record will be replaced by framework defaults. 7. Repeat for authorities. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 14:21:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 12:21:36 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140241|0 |1 is obsolete| | --- Comment #30 from Thibaud Guillot --- Created attachment 141965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141965&action=edit Bug 30250: (follow-up) Clarify syspref wording around importing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 14:22:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 12:22:58 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |thibaud.guillot at biblibre.co | |m --- Comment #31 from Thibaud Guillot --- Rebased sorry for the first try, I missed the first git bz attach command -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 14:29:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 12:29:28 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 14:32:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 12:32:24 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #42 from Marcel de Rooy --- if ( !$hostfld and $record->subfield('773','t') ) { # not linked using $w so just return plaintext my $unlinkedf = $record->field('773'); my $host = join( ", ", $unlinkedf->subfield('a'), $unlinkedf->subfield('t'), $unlinkedf->subfield('g') ); return wantarray ? ( $host, $unlinkedf->subfield('g') ) : $host; } The user of this routine expects a Koha object returned first. You return a concatenation of strings. Would be better to not disturb existing returns but find a way to return new alternative data. And change POD accordingly in the end. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 14:35:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 12:35:58 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #43 from Marcel de Rooy --- - [% INCLUDE 'biblio-title.inc' link = 1 biblio=BIBLIO_RESULT.HOSTITEMENTRIES %] [% BIBLIO_RESULT.RELATEDPARTS | $raw %] + [% INCLUDE 'biblio-title.inc' biblio=BIBLIO_RESULT.HOSTITEMENTRIES %] [% BIBLIO_RESULT.RELATEDPARTS | $raw %] Please clarify why you remove link = 1. Should this have been link=1 without spaces?? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 14:38:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 12:38:02 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #44 from Marcel de Rooy --- Please update release notes/commit message. The routine get_marc_host exists already :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 14:44:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 12:44:50 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 15:10:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 13:10:06 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 15:10:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 13:10:10 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141129|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy --- Created attachment 141966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141966&action=edit Bug 27265: Enable message queue cron to accept multiple codes and types It would be nice to be able to combine several types in a single run, but exclude others, without having to have multiple cron lines Test Plan: 1) Apply this patch 2) Run process_message_queue.pl with a single -c parameter 3) Note behavior is unchanged 4) Run process_message_queue.pl with multiple -c parameters 5) Note all the codes specified are processed 6) Repeat 2-5 with -t for type limits Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 15:10:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 13:10:14 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141130|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy --- Created attachment 141967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141967&action=edit Bug 27265: (follow-up) Use existing parameter Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 15:10:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 13:10:18 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 --- Comment #21 from Marcel de Rooy --- Created attachment 141968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141968&action=edit Bug 27265: (QA follow-up) Typo on L99 cron script Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 15:15:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 13:15:41 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 15:15:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 13:15:44 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141928|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 15:15:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 13:15:47 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141929|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 15:15:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 13:15:50 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141927|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 15:16:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 13:16:19 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 141969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141969&action=edit Bug 31784: Add Libraries->singleBranchMode Test plan: Run t/db_dependent/Koha/Libraries.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 15:16:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 13:16:24 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 141970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141970&action=edit Bug 31784: Replace some singleBranchMode occurrences Speaks for itself. Test plan: Run t/Koha.t. Check if OPAC shows Library or Libraries in masthead, depending on number of public branches. Login, place a hold. Verify things work as expected. Note: MARC21 XSLT does not care about singleBranchMode. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 15:16:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 13:16:28 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 141971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141971&action=edit Bug 31784: (QA follow-up) Cleanup This patch makes use of a ternary operator to simplify the code, and removes references to renamed things. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 15:19:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 13:19:00 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #18 from Tomás Cohen Arazi --- Hi, I like what we are approaching here. But I don't think ->single_branch_mode is a Koha::Libraries (resultset) method. I.e. you're using it in Koha::Libraries->new->single_branch_mode, but devs could mistakenly use it on already calculated resultsets... If it wasn't ugly, I'd just say this should be a C4::Context method. I'm sorry to fail it, but don't have the bandwidth to think of an alternative placement right now. Happy to help if you follow-up on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 15:20:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 13:20:53 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 --- Comment #19 from Marcel de Rooy --- Ternary is fine, Tomas. - Aka singleBranchMode. -sub single_library_mode { # formerly called singleBranchMode Removing those I would not do yet, while we still have lots of old occurrences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 15:29:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 13:29:28 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in MARC subfields structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 --- Comment #12 from Caroline Cyr La Rose --- Release maintainers, this is needed as far back as 22.05, but not before that. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 15:35:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 13:35:54 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #14 from Kyle M Hall --- Created attachment 141972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141972&action=edit Bug 24606: (QA follow-up) Set existing sharing setting when updating existing template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 15:41:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 13:41:47 +0000 Subject: [Koha-bugs] [Bug 27057] Add the ability to have a Override this entire Checkout transaction when Allowtoomanyoverride is turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27057 --- Comment #5 from Andrew Fuerste-Henry --- > What would the functionality look like? Do we want it to automatically apply > the override to the entire transaction automatically, or would there be a > checkbox or something similar, like the "Remember for session" checkbox on > the Checkout Settings? I like a "remember for session" checkbox, yes. And probably a system preference that asks whether the default behavior should be to override for one checkout or for the session. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 15:46:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 13:46:33 +0000 Subject: [Koha-bugs] [Bug 27057] Add the ability to have a Override this entire Checkout transaction when Allowtoomanyoverride is turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27057 --- Comment #6 from Kelly McElligott --- That would be very nice Andrew, I completely agree! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:02:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:02:25 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 --- Comment #27 from Jonathan Druart --- Created attachment 141973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141973&action=edit Bug 31154: Add test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:02:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:02:30 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 --- Comment #28 from Jonathan Druart --- Created attachment 141974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141974&action=edit Bug 31154: Avoid unecessary loop We don't need to loop over the subfield and enter this block if there is no record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:03:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:03:25 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #29 from Jonathan Druart --- This is how I think we should fix this problem. Feel free to ignore the second patch, but first patch is test that can be pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:07:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:07:06 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #3 from Jonathan Druart --- + "data": "actions", There is some magic in datatables.js that is using this (for sorting, searching, etc.) and expect it to be an attribute of library. I would not use "actions". Actually it's the same of the other occurrences. It's not a problem to have a function defined for 'data', it just should not be searchable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:07:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:07:42 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #4 from Jonathan Druart --- (In reply to Jonathan Druart from comment #3) > It's not a problem to have a function defined for 'data', it just should not > be searchable. Do you agree with that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:20:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:20:31 +0000 Subject: [Koha-bugs] [Bug 26635] Expand authorised values in REST API call In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 --- Comment #48 from Jonathan Druart --- Make the REST API returns a "_str" key (generated only if you requested it) which would contains the stringified values { _str: { attr: "stringified_value" }, attr: "coded_value" } JS code would be let string_to_display = json._str.attr || json.attr Not sure why this is still stuck. I needed it for ERM and ended with retrieving the AVs from the TT plugin, serialized to JSON and cached them. The main problem is that we don't even have a route for AVs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:32:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:32:28 +0000 Subject: [Koha-bugs] [Bug 31786] Sub template->param($var) should return the value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31786 --- Comment #2 from Jonathan Druart --- What is the context? Why don't you use CGI->param? :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:36:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:36:57 +0000 Subject: [Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #15 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 31587 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:36:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:36:57 +0000 Subject: [Koha-bugs] [Bug 31587] Basket not accessible from ACQORDER notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #11 from Jonathan Druart --- *** Bug 28824 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:37:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:37:29 +0000 Subject: [Koha-bugs] [Bug 31839] Error when viewing bibliographic details of record with local cover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31839 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Error 500 in normal |Error when viewing |administrative interface |bibliographic details of |view |record with local cover OS|Linux |All Component|Templates |Staff Client Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org CC| |gmcharlt at gmail.com --- Comment #1 from Owen Leonard --- I can reproduce this error in 21.11.12 too: Template process failed: undef error - The method Koha::CoverImage->count is not covered by tests! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:42:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:42:01 +0000 Subject: [Koha-bugs] [Bug 31777] Allow for scheduling of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31777 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Donna --- Thanks, Katrin! I thought I remembered something similar and that would definitely work! I'm going to mark this as resolved. *** This bug has been marked as a duplicate of bug 29002 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:42:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:42:01 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 --- Comment #14 from Donna --- *** Bug 31777 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:42:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:42:59 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141880|0 |1 is obsolete| | --- Comment #93 from Martin Renvoize --- Created attachment 141975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141975&action=edit Bug 31162: Add a cataloging module home page This patch adds a new cataloging-home template and controller and replaces most cases of links to addbooks. This serves to provide a new cataloging home page for the cataloging module and keeps it distinct from the current addbooks page it partially replaces as a starting point for cataloging. We migrate most cataloging related tools from the 'Tools' module whilst opting to move 'Rotating collections' to the 'Circulation' section of the 'Tools' homepage. We also add links to the cataloging tab of system preferences and a the adminstration pages if the user has the correct permissions to have access to these areas. Signed-off-by: KIT Signed-off-by: Emmanuel Bétemps Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:43:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:43:38 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:43:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:43:41 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141888|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:43:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:43:45 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141889|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:43:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:43:50 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141890|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:43:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:43:54 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141881|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:43:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:43:58 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141882|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:44:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:44:02 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141883|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:44:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:44:07 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141884|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:44:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:44:11 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141885|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:44:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:44:15 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141886|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:44:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:44:19 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141887|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:45:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:45:05 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #94 from Martin Renvoize --- Squashed all patches into one.. we've iterated lots and I think come to a reasonable conclusion.. Thanks to everyone for all the testing :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:45:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:45:58 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141975|0 |1 is obsolete| | --- Comment #95 from Martin Renvoize --- Created attachment 141976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141976&action=edit Bug 31162: Add a cataloging module home page This patch adds a new cataloging-home template and controller and replaces most cases of links to addbooks. This serves to provide a new cataloging home page for the cataloging module and keeps it distinct from the current addbooks page it partially replaces as a starting point for cataloging. We migrate most cataloging related tools from the 'Tools' module whilst opting to move 'Rotating collections' to the 'Circulation' section of the 'Tools' homepage. We also add links to the cataloging tab of system preferences and a the adminstration pages if the user has the correct permissions to have access to these areas. Signed-off-by: KIT Signed-off-by: Emmanuel Bétemps Signed-off-by: Katrin Fischer Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:53:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:53:49 +0000 Subject: [Koha-bugs] [Bug 31844] New: Clarify cataloging permissions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31844 Bug ID: 31844 Summary: Clarify cataloging permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 31162 migrates cataloging related tools into a new clarified cataloging module home page. We should migrate the various permissions related to these functions into the editcatalog permissions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:54:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:54:02 +0000 Subject: [Koha-bugs] [Bug 31844] Clarify cataloging permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31844 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31162 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 [Bug 31162] Add a clear cataloguing module home page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 16:54:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 14:54:02 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31844 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31844 [Bug 31844] Clarify cataloging permissions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:05:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:05:02 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141976|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize --- Created attachment 141977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141977&action=edit Bug 31162: Add a cataloging module home page This patch adds a new cataloging-home template and controller and replaces most cases of links to addbooks. This serves to provide a new cataloging home page for the cataloging module and keeps it distinct from the current addbooks page it partially replaces as a starting point for cataloging. We migrate most cataloging related tools from the 'Tools' module whilst opting to move 'Rotating collections' to the 'Circulation' section of the 'Tools' homepage. We also add links to the cataloging tab of system preferences and a the adminstration pages if the user has the correct permissions to have access to these areas. Signed-off-by: KIT Signed-off-by: Emmanuel Bétemps Signed-off-by: Katrin Fischer Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:05:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:05:11 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140416|0 |1 is obsolete| | Attachment #140417|0 |1 is obsolete| | Attachment #140418|0 |1 is obsolete| | Attachment #140419|0 |1 is obsolete| | Attachment #140420|0 |1 is obsolete| | Attachment #140421|0 |1 is obsolete| | Attachment #140422|0 |1 is obsolete| | Attachment #140423|0 |1 is obsolete| | Attachment #140424|0 |1 is obsolete| | Attachment #140425|0 |1 is obsolete| | Attachment #140426|0 |1 is obsolete| | Attachment #140427|0 |1 is obsolete| | Attachment #140428|0 |1 is obsolete| | Attachment #140429|0 |1 is obsolete| | Attachment #140430|0 |1 is obsolete| | --- Comment #44 from Jonathan Druart --- Created attachment 141978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141978&action=edit Bug 30588: Add 'enforced' option to TwoFactorAuthentication Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:05:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:05:15 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 --- Comment #45 from Jonathan Druart --- Created attachment 141979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141979&action=edit Bug 30588: Adjust existing occurrences of TwoFactorAuthentication We need to replace 0 with 'disabled', and 1 with 'enabled' Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:05:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:05:22 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 --- Comment #46 from Jonathan Druart --- Created attachment 141980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141980&action=edit Bug 30588: Add the option to require 2FA setup on first staff login Bug 28786 added the ability to turn on a two-factor authentication, using a One Time Password (OTP). Once enabled on the system, librarian had the choice to enable or disable it for themselves. For security reason an administrator could decide to force the librarians to use this second authentication step. This patch adds a third option to the existing syspref, 'Enforced', for that purpose. QA notes: the code we had in the members/two_factor_auth.pl controller has been moved to REST API controller methods (with their tests and swagger specs), for reusability reason. Code from template has been moved to an include file for the same reason. Test plan: A. Regression tests As we modified the code we need first to confirm the existing features are still working as expected. 1. Turn off TwoFactorAuthentication (disabled) and confirm that you are not able to enable and access the second authentication step 2. Turn it on (enabled) and confirm that you are able to enable it in your account 3. Logout and confirm then that you are able to login into Koha B. The new option 1. Set the pref to "enforced" 2. You are not logged out, logged in users stay logged in 3. Pick a user that does not have 2FA setup, login 4. Notice the new screen (UI is a bit ugly, suggestions welcomed) 5. Try to access Koha without enabling 2FA, you shouldn't be able to access any pages 6. Setup 2FA and confirm that you are redirected to the login screen 7. Login, send the correct pin code => You are fully logged in! Note that at 6 we could redirect to the mainpage, without the need to login again, but I think it's preferable to reduce the change to C4::Auth. If it's considered mandatory by QA I could have a look on another bug report. Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:05:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:05:29 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 --- Comment #47 from Jonathan Druart --- Created attachment 141981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141981&action=edit Bug 30588: Adjust existing selenium tests Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:05:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:05:35 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 --- Comment #48 from Jonathan Druart --- Created attachment 141982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141982&action=edit Bug 30588: Add tests for the REST API routes Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:05:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:05:41 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 --- Comment #49 from Jonathan Druart --- Created attachment 141983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141983&action=edit Bug 30588: Add selenium tests Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:05:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:05:47 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 --- Comment #50 from Jonathan Druart --- Created attachment 141984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141984&action=edit Bug 30588: Add tests for C4::checkauth Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:05:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:05:53 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 --- Comment #51 from Jonathan Druart --- Created attachment 141985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141985&action=edit Bug 30588: Add missing atomic update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:05:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:05:58 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 --- Comment #52 from Jonathan Druart --- Created attachment 141986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141986&action=edit Bug 30588: Add missing include file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:06:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:06:05 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 --- Comment #53 from Jonathan Druart --- Created attachment 141987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141987&action=edit Bug 30588: (QA follow-up) Typos in sysprefs.sql The codebase uses disabled and enforced which is imo better too. So we need to fix this sql file. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:06:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:06:11 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 --- Comment #54 from Jonathan Druart --- Created attachment 141988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141988&action=edit Bug 30588: (QA follow-up) Missing shebang in TwoFactorAuth.t Test plan: Try t/db_dependent/Koha/Auth/TwoFactorAuth.t on cmd line. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:06:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:06:17 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 --- Comment #55 from Jonathan Druart --- Created attachment 141989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141989&action=edit Bug 30588: (QA follow-up) Remove erroneous FIXME Comment speaks for itself. Look at surrounding code. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:06:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:06:22 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 --- Comment #56 from Jonathan Druart --- Created attachment 141990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141990&action=edit Bug 30588: (QA follow-up) Auth - remove two warns and second logout Resolves: Use of uninitialized value $request_method in string eq at /usr/share/koha/C4/Auth.pm line 1122. Use of uninitialized value $return in numeric gt (>) at /usr/share/koha/C4/Auth.pm line 1155. We also remove the double logout from Auth.t Test plan: Run t/db_dependent/Auth.t Check if you do not see the warns anymore. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:06:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:06:27 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 --- Comment #57 from Jonathan Druart --- Created attachment 141991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141991&action=edit Bug 30588: (QA follow-up) Adjust flags for two_factor_auth.pl Anyone with staff access (catalogue) should be able to go to account and enable 2FA. Test plan: Have a staff user with minimum staff permission. Access account, manage 2FA. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:06:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:06:33 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 --- Comment #58 from Jonathan Druart --- Created attachment 141992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141992&action=edit Bug 30588: (QA follow-up) Clear waiting-for-2FA-setup in session If we do not clear this session, the first login directly after setup does not really enhances user experience ;) Test plan: Make sure 2FA is enforced. Test the above. Disable your 2FA, logout and login. Verify that you can access pages with this patch now. Without this patch you could not. Run these tests to provide more confidence: t/db_dependent/Auth.t t/db_dependent/api/v1/two_factor_auth.t t/db_dependent/Koha/Auth/TwoFactorAuth.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:06:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:06:51 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 --- Comment #59 from Jonathan Druart --- Just a rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:17:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:17:51 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:17:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:17:54 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141953|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 141993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141993&action=edit Bug 31842: Move data function to render in branches.tt This applies to dataTable columns: library_info, actions and opac_info. Set searchable to false for opac_info too. Test plan: Check if DT search for libraries works again. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:18:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:18:04 +0000 Subject: [Koha-bugs] [Bug 31417] Re-instate the cataloguing sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141255|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 141994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141994&action=edit Bug 31417: Update and reference cat-menu.inc This patch reinstates the cat-menu.inc include and references it from the various 'tools' that are closely tied to cataloging. We use the new cataloging home page submission as a reference for which options should appear in the menu. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:18:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:18:32 +0000 Subject: [Koha-bugs] [Bug 31417] Re-instate the cataloguing sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 --- Comment #9 from Martin Renvoize --- Rebased and updated for final iteration of bug 31162 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:31:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:31:21 +0000 Subject: [Koha-bugs] [Bug 31556] Correct breadcrumb and URLs for Cataloging module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 --- Comment #1 from Martin Renvoize --- Created attachment 141995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141995&action=edit Bug 31556: Update breadcrumb for Import -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:31:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:31:26 +0000 Subject: [Koha-bugs] [Bug 31556] Correct breadcrumb and URLs for Cataloging module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 --- Comment #2 from Martin Renvoize --- Created attachment 141996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141996&action=edit Bug 31556: Update breadcrumb for Export -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:31:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:31:31 +0000 Subject: [Koha-bugs] [Bug 31556] Correct breadcrumb and URLs for Cataloging module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 --- Comment #3 from Martin Renvoize --- Created attachment 141997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141997&action=edit Bug 31556: Update breadcrumb for Report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:31:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:31:49 +0000 Subject: [Koha-bugs] [Bug 31556] Correct breadcrumb and URLs for Cataloging module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:32:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:32:00 +0000 Subject: [Koha-bugs] [Bug 31556] Correct breadcrumb for Cataloging module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Correct breadcrumb and URLs |Correct breadcrumb for |for Cataloging module |Cataloging module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:33:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:33:46 +0000 Subject: [Koha-bugs] [Bug 31845] New: Move cataloging controllers and templates to fix URLs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31845 Bug ID: 31845 Summary: Move cataloging controllers and templates to fix URLs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl We need to move each of the tools controllers scripts and templates from 'tools' to 'cataloging' to fix the URLs for those functions that moved from the 'Tools' module into the 'Cataloging' module. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:33:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:33:59 +0000 Subject: [Koha-bugs] [Bug 31845] Move cataloging controllers and templates to fix URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31845 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31556 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 [Bug 31556] Correct breadcrumb for Cataloging module -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:33:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:33:59 +0000 Subject: [Koha-bugs] [Bug 31556] Correct breadcrumb for Cataloging module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31845 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31845 [Bug 31845] Move cataloging controllers and templates to fix URLs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:37:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:37:20 +0000 Subject: [Koha-bugs] [Bug 31556] Correct breadcrumb for Cataloging module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31845 | --- Comment #4 from Martin Renvoize --- I made a start, but there's still a number to move.. I was doing them a section at a time and only manipulating the breadcrumb and title parts for now (we can outright replace 'tools' strings later (there are classes and includes and all sorts.. so lets just handle one thing at a time.) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31845 [Bug 31845] Move cataloging controllers and templates to fix URLs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:37:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:37:20 +0000 Subject: [Koha-bugs] [Bug 31845] Move cataloging controllers and templates to fix URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31845 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|31556 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 [Bug 31556] Correct breadcrumb for Cataloging module -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:37:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:37:28 +0000 Subject: [Koha-bugs] [Bug 31556] Correct breadcrumb for Cataloging module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31845 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31845 [Bug 31845] Move cataloging controllers and templates to fix URLs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:37:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:37:28 +0000 Subject: [Koha-bugs] [Bug 31845] Move cataloging controllers and templates to fix URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31845 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31556 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 [Bug 31556] Correct breadcrumb for Cataloging module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:38:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:38:02 +0000 Subject: [Koha-bugs] [Bug 31556] Correct breadcrumb for Cataloging module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|31162 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 [Bug 31162] Add a clear cataloguing module home page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:38:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:38:02 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31556 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 [Bug 31556] Correct breadcrumb for Cataloging module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:49:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:49:32 +0000 Subject: [Koha-bugs] [Bug 31846] New: Add syspref for serials search results limit Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31846 Bug ID: 31846 Summary: Add syspref for serials search results limit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: glasklas at gmail.com QA Contact: testopia at bugs.koha-community.org Performing and advanced search on serials with a significant amount of subscriptions in the database can take up a lot of server resources and even (in our case) cause serious server overload. By introducing a syspref that allows setting a result limit this problem can be mitigated. Also discovered and fixed a lot of performance bottlenecks but will post this as a separate patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:50:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:50:16 +0000 Subject: [Koha-bugs] [Bug 31815] Remove round corners from tabbed sections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31815 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31759 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759 [Bug 31759] Tabs vs Pills -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 17:50:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 15:50:16 +0000 Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31815 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31815 [Bug 31815] Remove round corners from tabbed sections -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 18:16:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 16:16:02 +0000 Subject: [Koha-bugs] [Bug 11340] Make the 'print summary' a custom slip/notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org --- Comment #6 from Andrew Fuerste-Henry --- Agreeing with the crowd. This is a small change that would add a lot of flexibility. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 18:26:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 16:26:48 +0000 Subject: [Koha-bugs] [Bug 11340] Make the 'print summary' a custom slip/notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340 Ed Veal changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eveal at mckinneytexas.org --- Comment #7 from Ed Veal --- Adding my vote as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 18:39:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 16:39:38 +0000 Subject: [Koha-bugs] [Bug 31781] Transferred items table (branchtransfers.tt) needs page-section class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781 --- Comment #7 from Lucas Gass --- (In reply to Katrin Fischer from comment #5) > This page needs a lot more work, but this does what is written on the tin. Curious what other work you are referring to... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 18:44:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 16:44:10 +0000 Subject: [Koha-bugs] [Bug 11340] Make the 'print summary' a custom slip/notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340 Sam Passey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |passey at uintah.utah.gov Priority|P5 - low |P4 --- Comment #8 from Sam Passey --- I agree this would be very helpful! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 18:54:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 16:54:29 +0000 Subject: [Koha-bugs] [Bug 31846] Add syspref for serials search results limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31846 --- Comment #1 from David Gustafsson --- Created attachment 141998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141998&action=edit Bug 31846: Add syspref for serials search results limit To test: 1) Make sure SerialsSearchResultsLimit syspref is unset or set to 0. 2) Perform an advanced search on serials without any conditions and confirm all serials are listed as expected. 3) Set SerialsSearchResultsLimit to a value less the the number of total subscriptions, perform the search again, and confirm that the number of serials has been limited to the set value. 4) Ensure all tests pass in t/db_dependent/Serials.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 18:55:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 16:55:03 +0000 Subject: [Koha-bugs] [Bug 31846] Add syspref for serials search results limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31846 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 18:56:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 16:56:49 +0000 Subject: [Koha-bugs] [Bug 31846] Add syspref for serials search results limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31846 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141998|0 |1 is obsolete| | --- Comment #2 from David Gustafsson --- Created attachment 141999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141999&action=edit Bug 31846: Add syspref for serials search results limit To test: 1) Make sure SerialsSearchResultsLimit syspref is unset or set to 0. 2) Perform an advanced search on serials without any conditions and confirm all serials are listed as expected. 3) Set SerialsSearchResultsLimit to a value less the the number of total subscriptions, perform the search again, and confirm that the number of serials has been limited to the set value. 4) Ensure all tests pass in t/db_dependent/Serials.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 18:59:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 16:59:38 +0000 Subject: [Koha-bugs] [Bug 11340] Make the 'print summary' a custom slip/notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340 --- Comment #9 from George Williams (NEKLS) --- This is still something I'd like to see done. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 19:04:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 17:04:41 +0000 Subject: [Koha-bugs] [Bug 31671] Add a "Print transfer slip" button to /cgi-bin/koha/circ/branchtransfers.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31671 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 19:04:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 17:04:45 +0000 Subject: [Koha-bugs] [Bug 31671] Add a "Print transfer slip" button to /cgi-bin/koha/circ/branchtransfers.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31671 --- Comment #1 from Lucas Gass --- Created attachment 142000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142000&action=edit Bug 31671: Add print slip button to transfer page To test: 1. Apply patch 2. Go to Circulation / Transfer 3. Try transfering some items and notice the 'Print transfer slip' button 4. Try clicking on it and make sure it generates correctly and with the correct information on the slip -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 19:06:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 17:06:25 +0000 Subject: [Koha-bugs] [Bug 31671] Add a "Print transfer slip" button to /cgi-bin/koha/circ/branchtransfers.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31671 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 19:17:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 17:17:44 +0000 Subject: [Koha-bugs] [Bug 28555] Improve output of verbose option for overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28555 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 19:17:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 17:17:48 +0000 Subject: [Koha-bugs] [Bug 28555] Improve output of verbose option for overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28555 --- Comment #8 from Nick Clemens --- Created attachment 142001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142001&action=edit Bug 28555: (follow-up) Add to script documenation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 19:21:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 17:21:54 +0000 Subject: [Koha-bugs] [Bug 31835] Add page-section to holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31835 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 19:26:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 17:26:17 +0000 Subject: [Koha-bugs] [Bug 31835] Add page-section to holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31835 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 19:26:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 17:26:21 +0000 Subject: [Koha-bugs] [Bug 31835] Add page-section to holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31835 --- Comment #1 from Lucas Gass --- Created attachment 142002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142002&action=edit Bug 31835: Add page-section to holds queue To test: 1. Apply patch 2. Make some holds and then run build_holds_queue.pl 3. Look at the holds queue and make sure everything looks right with the new page-section. Note: I made some indentation and whitespace changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 19:31:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 17:31:20 +0000 Subject: [Koha-bugs] [Bug 31847] New: Add page section to item search results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31847 Bug ID: 31847 Summary: Add page section to item search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Depends on: 30952 Blocks: 31757 The item search results page needs the page-section treatment. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 19:31:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 17:31:20 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31847 [Bug 31847] Add page section to item search results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 19:31:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 17:31:20 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31847 [Bug 31847] Add page section to item search results -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 19:58:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 17:58:44 +0000 Subject: [Koha-bugs] [Bug 27265] process_message_queue.pl cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Process message queue cron |process_message_queue.pl |should be able to take |cron should be able to take |multiple types as a |multiple types as a |parameter |parameter CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 20:30:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 18:30:00 +0000 Subject: [Koha-bugs] [Bug 31781] Transferred items table (branchtransfers.tt) needs page-section class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781 --- Comment #8 from David Nind --- (In reply to Lucas Gass from comment #7) .. > Curious what other work you are referring to... See bug 31805 and the screenshots. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 20:53:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 18:53:01 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #45 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #43) > - [% INCLUDE 'biblio-title.inc' link = 1 > biblio=BIBLIO_RESULT.HOSTITEMENTRIES %] [% BIBLIO_RESULT.RELATEDPARTS | $raw > %] > + [% INCLUDE 'biblio-title.inc' > biblio=BIBLIO_RESULT.HOSTITEMENTRIES %] [% BIBLIO_RESULT.RELATEDPARTS | $raw > %] > > Please clarify why you remove link = 1. Should this have been link=1 without > spaces?? I did clarify :) See comment#39: The html links get removed by the HTMLToText Process and don't show in the text based email. So I have decided to remove the links here. Also: we don't want to link to the staff interface, so the email can still be send to users. The staff email currently only includes a link to the record in the OPAC. -> Follow-up provided -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 20:55:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 18:55:34 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 20:55:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 18:55:42 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141717|0 |1 is obsolete| | --- Comment #15 from David Nind --- Created attachment 142003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142003&action=edit Bug 24606: Update database, add new schema file Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 20:55:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 18:55:48 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141718|0 |1 is obsolete| | --- Comment #16 from David Nind --- Created attachment 142004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142004&action=edit Bug 24606: Add Koha Object(s) with unit tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 20:55:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 18:55:54 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141719|0 |1 is obsolete| | --- Comment #17 from David Nind --- Created attachment 142005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142005&action=edit Bug 24606: Implement item templates This patch set implements item editor templates for community Koha. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Restart all the things! 4) prove t/db_dependent/Koha/Item/Template* 5) As a non superlibrarian, enter the item editor 6) Set some item fields, save as a new template using the buttom and form below the editor. 7) Test loading a template without remembering for the session 8) Test loading a template while remembering for the session 9) Test deleting a template 10) Test updating a template 11) Create one or more shared templates 12) Log in as another non superlibrarian without the new permission manage_item_editor_templates, verify you cannot edit/delete templates shared to you 13) Enable the new permission manage_item_editor_templates, verify you can now edit and delete templates shared to you Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 20:55:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 18:55:59 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141720|0 |1 is obsolete| | --- Comment #18 from David Nind --- Created attachment 142006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142006&action=edit Bug 24606: Add item template editor permission Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 20:56:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 18:56:05 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141721|0 |1 is obsolete| | --- Comment #19 from David Nind --- Created attachment 142007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142007&action=edit Bug 24606: Update existing schema files [DO NOT PUSH] Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 20:56:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 18:56:10 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141972|0 |1 is obsolete| | --- Comment #20 from David Nind --- Created attachment 142008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142008&action=edit Bug 24606: (QA follow-up) Set existing sharing setting when updating existing template Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 20:58:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 18:58:16 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch adds a new |This adds information from release notes|subroutine get_marc_host in |host item entry (MARC21 |the |773) and if applicable a |Koha::Biblio module |link to the host record in |which retrieves any 773 |the following places: |fields from the biblio |* |record. The subroutine is |Staff interface: list, list |used to show a host item |email, cart, cart email, |entry and a link to the |and search results |record in the following |* OPAC: |places: |list, list email, cart, |- staff client list |cart email, and search |- staff client cart |results |- staff | |client send list email | |- | |staff client send cart | |email | |- staff client search | |results | |- staff client | |detail page | |- opac list | |- | |opac cart | |- opac send list | |email email | |- opac send | |cart email | |- opac search | |results | |- opac detail page | --- Comment #46 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #44) > Please update release notes/commit message. > The routine get_marc_host exists already :) Updated the release notes description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 20:59:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 18:59:52 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141728|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 20:59:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 18:59:56 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141729|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:00:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:00:00 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141730|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:00:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:00:05 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141727|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:00:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:00:34 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #43 from Tomás Cohen Arazi --- Created attachment 142009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142009&action=edit Bug 14783: Change pickup location from opac. This patch allows users to change the pickup location for their holds from the opac. A syspref (OPACAllowUserToChangeBranch) controls at what stage a hold can be changed. To test: 1. Set up holds with diffrent statuses for a patron (pending, waiting, in transit, suspended) 2. No pickup locations for any hold should be able to be changed. 3. Turn on and off the different options under OPACAllowUserToChangeBranch. Make sure that only the corresponding holds can be changed from the opac. Check eg in the staff client that pickup location has changed. 4. The available pickup locations should respect any transfer restrictions. (Same as the holds list for a biblio in staff client) 5. For an in-transit hold: Check in the item at the original pickup location. 6. Note that it will be redirected to the new location. Sponsored-by: Lunds Universitetsbibliotek Signed-off-by: Owen Leonard Signed-off-by: Barbara Johnson Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:00:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:00:41 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #44 from Tomás Cohen Arazi --- Created attachment 142010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142010&action=edit Bug 14783: (follow-up) Move pickup library form into modal This patch attemps to simplify the list of holds by moving the form for changing a hold's pickup library into a modal dialog. This patch also makes minor tweaks to the CSS for the "X" close button shown in modal in windows. Instances where modal markup used "x" have been updated to use the Bootstrap 4 standard "×" To test, apply the patch and rebuild the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - Turn on the OPACAllowUserToChangeBranch system preference. - Log in to the OPAC as a user with holds. - In the view of your holds, confirm that each hold which can be modified shows a "Change" link. - Clicking the link should show a modal window with the title of the item on hold shown in the header. - Confirm that changing the pickup location works correctly. Signed-off-by: Barbara Johnson Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:00:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:00:47 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #45 from Tomás Cohen Arazi --- Created attachment 142011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142011&action=edit Bug 14783: (QA follow-up) Change "Pick up location" to "Pickup location" in table. Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:00:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:00:55 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #46 from Tomás Cohen Arazi --- Created attachment 142012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142012&action=edit Bug 14783: (QA follow-up) Add unit tests. This commit adds unit tests for Bug 14783. Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:01:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:01:03 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #47 from Tomás Cohen Arazi --- Created attachment 142013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142013&action=edit Bug 14783: (QA follow-up) Rename method and move tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:01:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:01:19 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #48 from Tomás Cohen Arazi --- Created attachment 142014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142014&action=edit Bug 14783: Compiled CSS Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:01:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:01:27 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #49 from Tomás Cohen Arazi --- Created attachment 142015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142015&action=edit Bug 14783: Update atomicupdate syntax Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:06:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:06:25 +0000 Subject: [Koha-bugs] [Bug 28555] Improve output of verbose option for overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28555 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:06:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:06:30 +0000 Subject: [Koha-bugs] [Bug 28555] Improve output of verbose option for overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28555 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140968|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 142016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142016&action=edit Bug 28555: Improve logging for overdue_notices.pl Currenlty the output with -v from overdue_notices is a bit overwhelming and hard to parse I do a few things here: 1 - Only show SQL if verbose > 1 2 - Add some separators to make it more readab;e 3 - Remove some redundant messages with branchcode and borrowernumber To test: 1: perl misc/cronjobs/overdue_notices.pl -v 2: Notice you get a LOT of information all smushed together 3: Apply patch 4: perl misc/cronjobs/overdue_notices.pl -v 5: Less info, and easier to read 6: perl misc/cronjobs/overdue_notices.pl -v -v 7: All the info, but nicer to read Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:06:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:06:36 +0000 Subject: [Koha-bugs] [Bug 28555] Improve output of verbose option for overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28555 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141726|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 142017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142017&action=edit Bug 28555: (follow-up) Make verbose count flags passed Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:06:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:06:42 +0000 Subject: [Koha-bugs] [Bug 28555] Improve output of verbose option for overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28555 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142001|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 142018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142018&action=edit Bug 28555: (follow-up) Add to script documenation Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:06:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:06:55 +0000 Subject: [Koha-bugs] [Bug 28555] Improve output of verbose option for overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28555 --- Comment #12 from Katrin Fischer --- Very nice, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:12:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:12:18 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 --- Comment #13 from Katrin Fischer --- Back here... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:17:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:17:31 +0000 Subject: [Koha-bugs] [Bug 31781] Transferred items table (branchtransfers.tt) needs page-section class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781 --- Comment #9 from Katrin Fischer --- (In reply to Lucas Gass from comment #7) > (In reply to Katrin Fischer from comment #5) > > This page needs a lot more work, but this does what is written on the tin. > > Curious what other work you are referring to... David filed it as bug 31805, but there was also an older bug 25682 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:18:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:18:42 +0000 Subject: [Koha-bugs] [Bug 31781] Transferred items table (branchtransfers.tt) needs page-section class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781 --- Comment #10 from Katrin Fischer --- (In reply to David Nind from comment #8) > (In reply to Lucas Gass from comment #7) > .. > > Curious what other work you are referring to... > > See bug 31805 and the screenshots. Ooops, missed that comment! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:23:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:23:00 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 --- Comment #20 from Katrin Fischer --- Looking at this again today... I also wonder if we are not overstretching the meaning of the public flag. At the moment on the form it appears with the hint: Set to 'yes' to show this library on the Libraries page in the OPAC. Libraries might have a reason to not want a library show in the list (it could be stacks, they don't the address to show), but it should still show up in facets, on the detail pages, etc. We might need to differentiate more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:32:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:32:07 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:32:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:32:12 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140168|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 142019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142019&action=edit Bug 31459: Use the same dropdown as when adding orders to a basket Current order receive code loops over each budget period and gets the hierarchy, this is slow when systems have many budgets. Additionally, the list includes inactive items by default We can switch to a single call, and add consistency by adopting the same dropdown as used when placing an order To test: 1 - Add some budgets with funds - ensure you have at least one inactive budget and fund 2 - Place an order, observe the fund selection menu 3 - Close basket, receive order, observe the fund menu 4 - Apply patch 5 - Cancel receipt 6 - Receive again 7 - Observe fund menu, confirm it matches the order placing menu 8 - Confirm inactive are not displayed by default, but are when button is checked Signed-off-by: Joonas Kylmälä Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=31559 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:32:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:32:17 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141734|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 142020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142020&action=edit Bug 31459: (follow-up) Preserve budget period display This patch adds a level to the budget_loops and displays the budgets as optgroups for the funds Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=31559 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:32:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:32:22 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141960|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 142021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142021&action=edit Bug 31459: (follow-up) Return 'Keep current' option This patch restores the option to keep current budget, in the case that receiver can receive, but cannot order on current budget Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=31559 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:32:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:32:29 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 --- Comment #17 from Katrin Fischer --- Created attachment 142022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142022&action=edit Bug 31459: (QA follow-up) Add missing TT filters Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=31559 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:36:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:36:37 +0000 Subject: [Koha-bugs] [Bug 13956] Add budget information to funds pull down on creating an order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13956 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31459 --- Comment #2 from Katrin Fischer --- I was just about to file this as a new bug... Bug 31459 added lovely top headings with the budget name. I think these would be nice to have every where in the acquisitions module, but starting with the form for creating order lines. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:36:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:36:37 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13956 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:39:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:39:32 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 --- Comment #18 from Katrin Fischer --- Love. Thx, Nick! Btw... I filed bug 13956 in 2015... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:44:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:44:22 +0000 Subject: [Koha-bugs] [Bug 31846] Add syspref for serials search results limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31846 --- Comment #3 from Katrin Fischer --- That is something we don't do in Koha so far afaik. I wonder if moving the search to the API as it was done for the order receive page and the patron search would not be a better way forward here to fix this issue? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:48:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:48:22 +0000 Subject: [Koha-bugs] [Bug 27259] HomeOrHoldingBranch is not used in all places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27259 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:52:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:52:30 +0000 Subject: [Koha-bugs] [Bug 31848] New: Holds queue: Submit button for filters on the left is closer to nav than to its form Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31848 Bug ID: 31848 Summary: Holds queue: Submit button for filters on the left is closer to nav than to its form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 On he holds queue page when you are looking at the holds, the submit button for the filters on the left is right about the navigation, but there is a big gap between the button and it's form. Maybe the button should be even inside the white area? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:52:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:52:30 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31848 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31848 [Bug 31848] Holds queue: Submit button for filters on the left is closer to nav than to its form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:53:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:53:38 +0000 Subject: [Koha-bugs] [Bug 31835] Add page-section to holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31835 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:53:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:53:43 +0000 Subject: [Koha-bugs] [Bug 31835] Add page-section to holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31835 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142002|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 142023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142023&action=edit Bug 31835: Add page-section to holds queue To test: 1. Apply patch 2. Make some holds and then run build_holds_queue.pl 3. Look at the holds queue and make sure everything looks right with the new page-section. Note: I made some indentation and whitespace changes. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:54:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:54:46 +0000 Subject: [Koha-bugs] [Bug 31835] Add page-section to holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31835 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer --- Small change, expecting a lot more of these soon. Going straight to PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 21:58:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 19:58:08 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 22:03:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 20:03:46 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 22:03:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 20:03:51 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141962|0 |1 is obsolete| | --- Comment #32 from David Nind --- Created attachment 142024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142024&action=edit Bug 30250: Use ApplyFrameworkDefaults when cataloguing This patch adds a system preference ApplyFrameworkDefaults to configure when to apply framework defaults - when cataloguing a new record, when editing a record as new (duplicating), or when changing the framework while editing an existing record. This applies to both bibliographic records and authority records. To test: 1. Update database 2. Go to Administration -> system preferences. Find the ApplyFrameworkDefaults system preference. Confirm "when cataloguing new records" is selected by default. 3. Keep the system preference open in one tab, and open the staff client in another tab. 4. Go to Administration -> bibliographic frameworks. Choose a framework, edit the subfields for a tag, and give a subfield a default value. For example, set 500$a for the BOOKS framework to have a default value of "TEST". This will be Framework A. 5. Ensure you have another framework that does not have the same default value for a subfield as Framework A. This will be Framework B. 6. Go to Cataloguing. Add a new record using Framework A. Confirm your subfield has the default value filled. Cancel and do not save the record. 7. In your System preferences tab, uncheck the option "when cataloguing new records" and save. No options should now be selected. 8. In our other tab, go to cataloguing, add a new record using Framework A. Confirm your subfield does NOT have the default value filled. Fill the required fields, including the subfield that should have a default value, and Save the record. 9. In your system preferences tab, select all options and save. 10. In your other tab, click Edit, then "Edit as new (duplicate)". Confirm your subfield has maintained the value from the source record. Cancel and do not save the record. 11. Edit your original record and delete the value in your subfield that could be filled with a default value by the framework. Save the record with no value in the subfield. 12. Click Edit, then "Edit as new (duplicate)". Confirm your subfield has the default value filled. Framework defaults will only apply to emplty fields. Save the record. 13. Do a catalogue search and find a record that uses Framework B. 14. If you need to, edit the record to make sure there is nothing in your subfield that should have a default value if this record were to use Framework A, and Save. 15. Edit the record. Using the settings dropdown, change the framework to Framework A. Confirm your subfield has the default value filled. 16. Repeat steps 4 to 12 with authority types and authority records. Sponsored-by: Education Services Australia SCIS Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 22:03:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 20:03:58 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141963|0 |1 is obsolete| | --- Comment #33 from David Nind --- Created attachment 142025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142025&action=edit Bug 30250: Add ApplyFrameworkDefaults system preference (cherry picked from commit 684a04deb6ec7e94ca60f5cb38811176fbb9c230) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 22:04:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 20:04:05 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141964|0 |1 is obsolete| | --- Comment #34 from David Nind --- Created attachment 142026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142026&action=edit Bug 30250: Use ApplyFrameworkDefaults when importing a record This patch adds the case of importing a record to the ApplyFrameworkDefaults options. To test: 1. Update database 2. Confirm the ApplyFrameworkDefaults system preference now has the 'when importing a record via z39.50' option. Do not select it. 3. Go to Cataloguing. Import a record from z39.50, or replace an existing record. 4. Confirm framework defaults are not applied. 5. Go back to the system preference and check the 'when importing a record via z39.50' option. 6. Repeat step 3. This time framework defaults should be applied. Only fields that are empty in the imported record will be replaced by framework defaults. 7. Repeat for authorities. Sponsored-by: Catalyst IT Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 22:04:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 20:04:12 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141965|0 |1 is obsolete| | --- Comment #35 from David Nind --- Created attachment 142027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142027&action=edit Bug 30250: (follow-up) Clarify syspref wording around importing Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 22:20:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 20:20:22 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 22:20:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 20:20:30 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141977|0 |1 is obsolete| | --- Comment #97 from Katrin Fischer --- Created attachment 142028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142028&action=edit Bug 31162: Add a cataloging module home page This patch adds a new cataloging-home template and controller and replaces most cases of links to addbooks. This serves to provide a new cataloging home page for the cataloging module and keeps it distinct from the current addbooks page it partially replaces as a starting point for cataloging. We migrate most cataloging related tools from the 'Tools' module whilst opting to move 'Rotating collections' to the 'Circulation' section of the 'Tools' homepage. We also add links to the cataloging tab of system preferences and a the adminstration pages if the user has the correct permissions to have access to these areas. Signed-off-by: KIT Signed-off-by: Emmanuel Bétemps Signed-off-by: Katrin Fischer Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 22:20:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 20:20:37 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #98 from Katrin Fischer --- Created attachment 142029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142029&action=edit Bug 31162: (QA follow-up) Use new WRAPPPERs and fix help link This migrates the start page to the new page structure using WRAPPERs instead of includes. One visible problem before was the missing help link. Also makes sure the help link leads to the correct page :) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 22:28:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 20:28:58 +0000 Subject: [Koha-bugs] [Bug 31417] Re-instate the cataloguing sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 22:48:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 20:48:12 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 22:48:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 20:48:15 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #50 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 22:48:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 20:48:18 +0000 Subject: [Koha-bugs] [Bug 21705] Map copyrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 22:48:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 20:48:22 +0000 Subject: [Koha-bugs] [Bug 21705] Map copyrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 --- Comment #17 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 22:48:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 20:48:25 +0000 Subject: [Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 22:48:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 20:48:29 +0000 Subject: [Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 --- Comment #12 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 22:48:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 20:48:34 +0000 Subject: [Koha-bugs] [Bug 31781] Transferred items table (branchtransfers.tt) needs page-section class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 22:48:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 20:48:37 +0000 Subject: [Koha-bugs] [Bug 31781] Transferred items table (branchtransfers.tt) needs page-section class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 22:55:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 20:55:36 +0000 Subject: [Koha-bugs] [Bug 31849] New: Cancel and Transfer all button does not go to background jobs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31849 Bug ID: 31849 Summary: Cancel and Transfer all button does not go to background jobs Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: bdaeuber at cityoffargo.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Using the "Cancel and Transfer all" button on the Holds Awaiting Pickup Tab does not send the job to background jobs. This is inconsistent with "Cancel Selected". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 22:57:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 20:57:52 +0000 Subject: [Koha-bugs] [Bug 30254] New overdue fine applied to incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30254 hebah at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 22:57:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 20:57:52 +0000 Subject: [Koha-bugs] [Bug 31417] Re-instate the cataloguing sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 22:57:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 20:57:58 +0000 Subject: [Koha-bugs] [Bug 31417] Re-instate the cataloguing sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141994|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 142030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142030&action=edit Bug 31417: Update and reference cat-menu.inc This patch reinstates the cat-menu.inc include and references it from the various 'tools' that are closely tied to cataloging. We use the new cataloging home page submission as a reference for which options should appear in the menu. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 23:01:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 21:01:29 +0000 Subject: [Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 --- Comment #24 from Tomás Cohen Arazi --- Created attachment 142031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142031&action=edit Bug 31569: (QA follow-up) Add missing entries in schema Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 23:01:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 21:01:53 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 23:02:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 21:02:03 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 23:02:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 21:02:08 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141993|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 142032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142032&action=edit Bug 31842: Move data function to render in branches.tt This applies to dataTable columns: library_info, actions and opac_info. Set searchable to false for opac_info too. Test plan: Check if DT search for libraries works again. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 23:06:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 21:06:46 +0000 Subject: [Koha-bugs] [Bug 27768] Flatpickr allows entering invalid dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27768 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Saving an item with an |Flatpickr allows entering |invalid dateaccessioned or |invalid dates |replacementpricedate throws | |no helpful error | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 23:10:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 21:10:36 +0000 Subject: [Koha-bugs] [Bug 31835] Add page-section to holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31835 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 23:10:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 21:10:39 +0000 Subject: [Koha-bugs] [Bug 31835] Add page-section to holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31835 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 23:15:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 21:15:17 +0000 Subject: [Koha-bugs] [Bug 31850] New: Patron import: welcome email option style as list Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31850 Bug ID: 31850 Summary: Patron import: welcome email option style as list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 The welcome email option on the patron import page appears as list item with the dot in front of the checkbox. The list-style-type should be none here. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 23:15:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 21:15:17 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31850 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31850 [Bug 31850] Patron import: welcome email option style as list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 23:15:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 21:15:26 +0000 Subject: [Koha-bugs] [Bug 31850] Patron import: welcome email option style as list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31850 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 23:18:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 21:18:27 +0000 Subject: [Koha-bugs] [Bug 26343] Blank columns in patron import CSV clears existing data when overwriting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26343 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Blank columns in patron |Blank columns in patron |import csv clears existing |import CSV clears existing |data when overwriting |data when overwriting --- Comment #2 from Katrin Fischer --- Re-reading this again, I believe the bug description doesn't quite fit. I think the described behaviour is correct, because we need a way to reset/empty out fields. If the other behavior is still desirable, we should change it to read more as an alternative. But I can't come up with something right now :( -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 23:21:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 21:21:23 +0000 Subject: [Koha-bugs] [Bug 21381] Add serial enumeration to circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OMNIBUS: Circulation |Add serial enumeration to |history UI improvements - |circulation history |Add Serial enumeration / | |chronology information at | |title column | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 23:21:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 21:21:29 +0000 Subject: [Koha-bugs] [Bug 21381] Add serial enumeration to circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 23:43:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 21:43:16 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #317 from Victor Grousset/tuxayo --- Thanks Björn, that's the kind of feedback that can help. Do you recall more about the quirks in the admin page? > How to ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 23:44:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 21:44:48 +0000 Subject: [Koha-bugs] [Bug 21381] Add serial enumeration to circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 23:44:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 21:44:53 +0000 Subject: [Koha-bugs] [Bug 21381] Add serial enumeration to circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381 --- Comment #1 from Katrin Fischer --- Created attachment 142033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142033&action=edit Bug 21381: Add serial enumeration to circulation/checkout history * Set readinghistory and intranetreadinghistory to Allow * Check out some items and return some. At least one item should have serial enumeration set to something * Go to OPAC > patron account > checkout history * Verify the Vol info shows the same as on the detail page. * Go to staff interface > patron account > circulation history * Verify the Vol info shows correctly there as well. Bug 21381: Add serial enumeration to circulation/checkout history https://bugs.koha-community.org/show_bug.cgi?id=31281 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 17 23:45:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 21:45:21 +0000 Subject: [Koha-bugs] [Bug 21381] Add serial enumeration to circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381 --- Comment #2 from Katrin Fischer --- This should get us started here :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 00:00:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 22:00:27 +0000 Subject: [Koha-bugs] [Bug 30252] lower version of 'Locale::XGettext::TT2' to 0.6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30252 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #14 from Victor Grousset/tuxayo --- > can we push to 21.05 pleeese Hi, I found this by accident. Otherwise since I'm not CCed and it's from previous cycle, I would have never found. I hope there isn't much stuff I miss like that :o Ok, noted for the next days :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 00:03:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 22:03:26 +0000 Subject: [Koha-bugs] [Bug 29374] searchResults explodes if biblio record has been deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29374 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Keywords|rel_21_05_candidate | Resolution|--- |FIXED CC| |victor at tuxayo.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 00:04:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 22:04:24 +0000 Subject: [Koha-bugs] [Bug 28577] Add column for copynumber on overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28577 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Version|20.05 |master Version(s)| |This adds the copynumber as released in| |optional column to the | |circulation report | |'overdues'. The column can | |be made visible temporarily | |or permanently using the | |table settings | |configuration. Status|NEW |ASSIGNED Summary|Add column for copynumber |Add column for copynumber |on overdue report |on overdues report |(overdue.pl) | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 00:09:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 22:09:48 +0000 Subject: [Koha-bugs] [Bug 28577] Add column for copynumber on overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28577 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 00:09:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 22:09:53 +0000 Subject: [Koha-bugs] [Bug 28577] Add column for copynumber on overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28577 --- Comment #1 from Katrin Fischer --- Created attachment 142034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142034&action=edit Bug 28577: Add column for copynumber to overdues report This adds the copynumber as optional column to the circulation report 'overdues'. The column can be made visible temporarily or permanently using the table settings configuration. To test: * Make sure you have some overdue checkouts in your installation. * Make sure the items for those checkouts have copynumber set, also one should have serial enumaration. * Go to circulation > overdues * Verify the copynumber column is hidden by default, but can be made visible using the column settings * Verify that the export to CSV via the link on top of the table (not the table export) works correctly and includes both: copynumber and serial enumeration Serial enumaration shows after the title in the overdues list, but was missing from export. This was also fixed here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 00:15:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 22:15:55 +0000 Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #9 from David Cook --- I don't really have an opinion on this myself (shocking I know), but I imagine I'll hear about it in the new year from library staff. I don't have a master instance running at the moment, but I wonder what's the most common pattern used with the re-design. Best perhaps just to keep it consistent across the board? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 00:20:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 22:20:56 +0000 Subject: [Koha-bugs] [Bug 21381] Add serial enumeration to circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381 --- Comment #3 from Katrin Fischer --- Created attachment 142035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142035&action=edit Bug 21381: (follow-up) Fix table configuration for new column The new column was added to the table settings configuration. To test: * Make sure the column shows up in the columns menu of the table in the staff interface. * Verify it can be hidden/unhidden correctly using the menu or the table setings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 00:42:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 22:42:12 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 00:42:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 22:42:18 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141058|0 |1 is obsolete| | --- Comment #47 from Aleisha Amohia --- Created attachment 142036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142036&action=edit Bug 16522: Adding 773 to cart and list displays and emails This enhancement adds information from a host item entry and a link if applicable to the host record in the following places: - staff client list - staff client cart - staff client send list email - staff client send cart email - staff client search results - staff client detail page - opac list - opac cart - opac send list email email - opac send cart email - opac search results - opac detail page To test: 1. apply patch, restart services 2. log into the staff client and enable the syspref EasyAnalyticalRecords 3. find a record with an item. take note of the barcode. 4. go to another record (biblio 2). click Edit -> Link to host record 5. enter the barcode in the input and submit. 6. click the MARC tab and confirm the host record has been linked under MARC field 773. 7. add biblio 2 to your cart, and to a list. 8. go to your cart. confirm you see the 'host item entry' link. 9. click on 'more details' and confirm you see the 'host item entries' link. 10. click 'send' to email the cart. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 11. go to the list you added the record to. confirm you see the 'source' link for the host item entry. 12. click 'send list' to email the list. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 13. log into the OPAC. repeat steps 7 to 12 on the OPAC and confirm they all pass as expected. 14. Confirm host item info also shows correctly on the OPAC and staff client search results, and the OPAC and staff client detail pages (where XSLT is used) 15. Delete the 773$w and confirm host item info still shows correctly but no longer links to biblio 16. confirm tests pass t/db_dependent/Koha/Biblio/host_record.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 00:42:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 22:42:24 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141059|0 |1 is obsolete| | --- Comment #48 from Aleisha Amohia --- Created attachment 142037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142037&action=edit Bug 16522: (follow-up) MARC display templates and get_marc_host fixes Also: - Show related parts 773$g - Normalise using 'Host item entry' as title - Remove 'foreach' because non-xslt views only return first - If no $w, use $atg, and related tests in t/db_dependent/Koha/Biblio/host_record.t Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 00:42:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 22:42:30 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141060|0 |1 is obsolete| | --- Comment #49 from Aleisha Amohia --- Created attachment 142038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142038&action=edit Bug 16522: (follow-up) Add missing TT filters Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 00:42:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 22:42:36 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141061|0 |1 is obsolete| | --- Comment #50 from Aleisha Amohia --- Created attachment 142039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142039&action=edit Bug 16522: (follow-up) Rename "Host item entry" to "In" We already use In: as label for 773 on the result lists and detail pages and it's also recommended in the MARC documentation. With this patch the label is the same everywhere. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 00:42:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 22:42:42 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141062|0 |1 is obsolete| | --- Comment #51 from Aleisha Amohia --- Created attachment 142040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142040&action=edit Bug 16522: (follow-up) Fix variable in OPAC cart brief display Without this change records 773 entries with links in $w would not display the title information, but just "No title". With the variable fixed, now the host's title displays. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 00:42:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 22:42:47 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141063|0 |1 is obsolete| | --- Comment #52 from Aleisha Amohia --- Created attachment 142041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142041&action=edit Bug 16522: (follow-up) Remove HTML links from email The emails sent for cart and list are plain text and any tag will be scrubbed by HtmlToText. So we can remove those links. This also solves an issue with the original patch set, where the error below would appear on sending a cart or list email from the staff interface: Template process failed: file error - biblio_a_href: not found at /kohadevbox/koha/C4/Templates.pm line 127 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 00:42:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 22:42:53 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #53 from Aleisha Amohia --- Created attachment 142042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142042&action=edit Bug 16522: (follow-up) If no 773$w, try to return host record Use host biblionumber or host itemnumber to return a host record, or use title and author to search for a host record, or return an undef record and a string of host information when get_marc_host is called in list context. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 00:54:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 22:54:30 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #80 from David Cook --- (In reply to Agustín Moyano from comment #78) > > (#NOTE: The UI looks poorly formatted, but I think that's probably a symptom > > of the new staff interface styling. Not a blocker for me. This can be fixed > > later...) > > Sorry, it's been a long time since I've done anything related to Koha.. If > you could point me to a well formated page, I'll try to stick to the style > as much as possible I'm not familiar with the new staff UI myself, but I think you'll be able to see what I mean at a glance. On CRUD pages, the labels and fields aren't aligned correctly in all cases at the moment. > > (#NOTE: With the new Staff Interface, there should be a "Help" link on the > > right hand side, but I don't see it for this new functionality. I think > > that's a blocker.) > > Ok, I'll ask Tomas for help about how this shoul be done Sounds good. I think it might involve the Koha/Manual.pm file. (I just noticed it on a different issue report earlier today.) > > (#NOTE: I don't really like having to include raw JSON in this UI. This > > could be made more beautiful.) > > Me neither, there should be a JSON editor or something.. does Koha have one? Not that I know of. Rather, I meant it would make sense to just have a regular HTML form and translate that into JSON on the backend. > As I said, I do not believe these patches to be at the latest version.. now > the user gets redirected to the login page (staff or opac) with error message Looking forward to testing the next round! > > 10. If I logout of Keycloak and try to log back into http://localhost:8080/ > > via Keycloak, I get the following: > > There was an error authenticating to external identity provider > > Can't call method "auto_register" on an undefined value at > > /kohadevbox/koha/Koha/REST/Plugin/Auth.pm line 66. > > Strange, I'll have to check that out I wasn't able to reproduce it again so might've just been a bit glitchy due to restarts/Keycloak logouts/etc. Might not need to worry about it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 00:56:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 22:56:29 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #81 from David Cook --- (In reply to Agustín Moyano from comment #79) > > If you have a "blank" domain and a specific domain, the "blank" domain is > > used instead of the specific domain. > > Strange, the behavior should be the opposite. The logic was that you could > define multiple domains (even partially) and the domain with the longest > matching text should win. If there was no matching domain, then go with the > default. Worth double-checking that one I reckon. > > If you want to set different "Default library" and "Default category" based > > on email domain, it won't work if you have a "blank" domain. > > Maybe I've done something wrong with the regexp, and if the email domain > doesn't match, you won't see that "default library" and "default category" > configured for the domain How is the domain supposed to be configured? Perhaps I wasn't inputting it as expected either? > I've fixed auto register in latest patches, but for it to work, you need to > define userid or cardnumber in the mapper. You'll definitely need to indicate that on the UI pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 01:04:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 23:04:38 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #16 from Mason James --- Created attachment 142043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142043&action=edit Bug 31729: watch only perl files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 01:05:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 23:05:06 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141716|0 |1 is obsolete| | --- Comment #17 from Mason James --- Created attachment 142044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142044&action=edit Bug 31729: Enable automatic filesystem refresh in Plack (3) fix 'elif' typo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 01:07:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 23:07:36 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #82 from David Cook --- Looks like "soft" feature freeze is Oct 28, so if you can get the updates patches up ASAP, I'll make time for QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 01:19:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Oct 2022 23:19:40 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #54 from David Cook --- I think I had someone asking for this the other day. I'll come back... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 02:15:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 00:15:14 +0000 Subject: [Koha-bugs] [Bug 27265] process_message_queue.pl cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 02:15:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 00:15:17 +0000 Subject: [Koha-bugs] [Bug 27265] process_message_queue.pl cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 --- Comment #22 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 02:15:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 00:15:21 +0000 Subject: [Koha-bugs] [Bug 27315] The man pages for the command line utilities do not display properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27315 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 02:15:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 00:15:24 +0000 Subject: [Koha-bugs] [Bug 27315] The man pages for the command line utilities do not display properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27315 --- Comment #13 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 02:15:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 00:15:27 +0000 Subject: [Koha-bugs] [Bug 28555] Improve output of verbose option for overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28555 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 02:15:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 00:15:30 +0000 Subject: [Koha-bugs] [Bug 28555] Improve output of verbose option for overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28555 --- Comment #13 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 02:16:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 00:16:28 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in MARC subfields structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #13 from Victor Grousset/tuxayo --- Thanks for the fix Caroline! In 30733 I used the same trick in a few places where I noticed it would be an issue. I hope librarians aren't too unhappy with this missed case ^^ > Release maintainers, this is needed as far back as 22.05, but not before that. Good that you repeat, because RMaints are unlikely to read all the comment history. But don't worry, having bug 30733 in the "Depends on" field here takes care of ensuring that it's not backported too far. Also the way it will conflict when trying to backport would give a hint that it's missing a dependency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 02:21:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 00:21:19 +0000 Subject: [Koha-bugs] [Bug 31851] New: Allow prioritizing identity providers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31851 Bug ID: 31851 Summary: Allow prioritizing identity providers Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Now that bug 31378 introduces a table for identity providers, we should be able to prioritize them, including local login (which could be collapsed if not default). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 02:21:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 00:21:33 +0000 Subject: [Koha-bugs] [Bug 31851] Allow prioritizing identity providers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31851 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31378 Keywords| |rel_22_11_candidate Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 [Bug 31378] Add a generic OAuth2/OIDC client implementation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 02:21:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 00:21:33 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31851 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31851 [Bug 31851] Allow prioritizing identity providers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 02:22:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 00:22:06 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 02:44:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 00:44:25 +0000 Subject: [Koha-bugs] [Bug 11340] Make the 'print summary' a custom slip/notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340 dgarr at cityoflewiston.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dgarr at cityoflewiston.org --- Comment #10 from dgarr at cityoflewiston.org --- Created attachment 142045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142045&action=edit All tabs presented in background vs tabs that actually print in foreground -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 02:46:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 00:46:14 +0000 Subject: [Koha-bugs] [Bug 11340] Make the 'print summary' a custom slip/notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340 --- Comment #11 from dgarr at cityoflewiston.org --- I'm glad we're bringing this up again; this was first requested almost a decade ago, and it still holds importance to us as users. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 03:25:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 01:25:16 +0000 Subject: [Koha-bugs] [Bug 31851] Allow prioritizing identity providers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31851 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 03:35:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 01:35:53 +0000 Subject: [Koha-bugs] [Bug 10757] OAI-PMH records should also include setSpec in their headers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10757 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from David Cook --- This is outdated. This works now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 03:39:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 01:39:06 +0000 Subject: [Koha-bugs] [Bug 24632] Plugins should support simple signing for security/verifiability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24632 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 05:14:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 03:14:04 +0000 Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #24 from Victor Grousset/tuxayo --- So we are two people not getting the warnings: needs more accurate steps to reproduce -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 05:32:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 03:32:28 +0000 Subject: [Koha-bugs] [Bug 30649] Add ability to encrypt data in Koha, use for EDI vendor accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- I don't get how to encrypt a password to an external service and still be able to use the external service. Does that mean Koha can in full autonomy decrypt it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 05:44:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 03:44:38 +0000 Subject: [Koha-bugs] [Bug 31281] Overdue notices reply-to email address of a branch not respected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 --- Comment #16 from Victor Grousset/tuxayo --- No worries, I picked it from 21.11.x so it didn't jump. Arthur is experimenting to not update the ticket until the very release date. Then it is possible to use the scripts in release-tools to mass-update the bugs included in the release without taking the risks of forgetting one. I feel that can cause issues as one does not subscribe to the tickets and will miss a regression uncovered and request to revert. And people wouldn't even make the request (in-ticket or via direct email) to revert if there is no message from the RMaint that they backported it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 06:11:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 04:11:04 +0000 Subject: [Koha-bugs] [Bug 31852] New: Check out date set to today Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31852 Bug ID: 31852 Summary: Check out date set to today Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nayema at mes.ac.in QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We have successfully defined our circulation rules. It was working nicely but since yesterday the check out date is set to same day.So If I check out a book today the due date is today. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 06:12:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 04:12:38 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141627|0 |1 is obsolete| | Attachment #141630|0 |1 is obsolete| | --- Comment #12 from Aleisha Amohia --- Created attachment 142046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142046&action=edit Bug 23012: Database updates for PROCESSING_FOUND account credit type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 06:12:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 04:12:43 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141628|0 |1 is obsolete| | --- Comment #13 from Aleisha Amohia --- Created attachment 142047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142047&action=edit Bug 23012: Show the PROCESSING_FOUND account credit type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 06:12:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 04:12:49 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141629|0 |1 is obsolete| | --- Comment #14 from Aleisha Amohia --- Created attachment 142048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142048&action=edit Bug 23012: Set policy for lost item processing fee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 06:12:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 04:12:54 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #15 from Aleisha Amohia --- Created attachment 142049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142049&action=edit Bug 23012: Apply processing fee return policy when lost item found TEST PLAN TO COME -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 08:35:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 06:35:08 +0000 Subject: [Koha-bugs] [Bug 31281] Overdue notices reply-to email address of a branch not respected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 --- Comment #17 from Katrin Fischer --- I agree it makes things a bit easier if we see right away if something has already been picked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 08:42:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 06:42:14 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #83 from Katrin Fischer --- For the missing help link the last patch on bug 31162 might be interesting. I also noticed the help missing there and it was due to changes to the page structure with the new staff design. For the JSON editor: Maybe CodeMirror that we use for SQL and YAML can do it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 08:44:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 06:44:19 +0000 Subject: [Koha-bugs] [Bug 31852] Check out date set to today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31852 --- Comment #1 from Katrin Fischer --- Hi Nayema, this is more a support question than a bug report. Please use one of our other support channels, like the mailing lists or IRC to ask these. First things to check would be your calendar and if the user will expire soon. Different settings can then shorten the loan period. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 08:44:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 06:44:31 +0000 Subject: [Koha-bugs] [Bug 31852] Check out date set to today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31852 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 08:46:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 06:46:26 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142044|0 |1 is obsolete| | --- Comment #18 from Mason James --- Created attachment 142050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142050&action=edit Bug 31729: add 2 sec loop to koha-watcher, to avoid reload flooding -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 08:48:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 06:48:09 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #19 from Mason James --- (In reply to Jonathan Druart from comment #15) > Shouldn't we watch for perl files only? > > What about git checkout branch? Is it going to send 1 signal per file > modified? hiya, i've added 2 patches to handle these 2 conditions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 10:20:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 08:20:29 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #318 from Björn Nylén --- (In reply to Victor Grousset/tuxayo from comment #317) > Thanks Björn, that's the kind of feedback that can help. > > Do you recall more about the quirks in the admin page? > > > How to > > ? Talked to my colleagues and the quirk was that all calendar changes were for your logged in library, ignoring the selected branch. However the last patch from M Simard should address that. Disregard "How to.." prob had a thought but changed my mind :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 12:11:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 10:11:35 +0000 Subject: [Koha-bugs] [Bug 30006] Article requests: Checkbox for non-commercial use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30006 Mirjam Vantieghem changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirjam.vantieghem at etf.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 12:13:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 10:13:23 +0000 Subject: [Koha-bugs] [Bug 29819] Allow setting AR fees at item type level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29819 Mirjam Vantieghem changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirjam.vantieghem at etf.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 12:54:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 10:54:25 +0000 Subject: [Koha-bugs] [Bug 30649] Add ability to encrypt data in Koha, use for EDI vendor accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 --- Comment #9 from Kyle M Hall --- (In reply to Victor Grousset/tuxayo from comment #8) > I don't get how to encrypt a password to an external service and still be > able to use the external service. Does that mean Koha can in full autonomy > decrypt it? Yes, we store a key in the koha konf file for encryption and decryption. I need to rebase this patch to use the work from Bug 28998. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 12:56:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 10:56:34 +0000 Subject: [Koha-bugs] [Bug 31786] Sub template->param($var) should return the value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31786 --- Comment #3 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #2) > What is the context? Why don't you use CGI->param? :) See description too. If earlier code like C4/Auth already pushed info into the template object, it would be nice to read it back later (instead of requerying etc.). Yes, we can access {VARS} but that looks like a bad practice. In such a case CGI::param might not be in the picture. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 13:07:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 11:07:09 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 13:07:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 11:07:55 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the|This enhancement tries to |This enhancement tries to release notes|bring a bit more order the |bring a bit more order the |cataloguing features. We |cataloguing features. We |create a new 'Cataloguing' |create a new 'Cataloguing' |module home page and try to |module home page and |collect the cataloguing |collecting the cataloguing |tools into it. |tools into it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 13:35:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 11:35:48 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 --- Comment #30 from Marcel de Rooy --- Thanks. Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 13:41:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 11:41:01 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141973|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy --- Created attachment 142051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142051&action=edit Bug 31154: Add test Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 13:41:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 11:41:06 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141974|0 |1 is obsolete| | --- Comment #32 from Marcel de Rooy --- Created attachment 142052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142052&action=edit Bug 31154: Avoid unecessary loop We don't need to loop over the subfield and enter this block if there is no record. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 13:41:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 11:41:23 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 13:41:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 11:41:31 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 13:41:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 11:41:39 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 13:41:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 11:41:56 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #33 from Marcel de Rooy --- Tomás: Last two patches please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 13:46:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 11:46:14 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 --- Comment #21 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #20) > Looking at this again today... I also wonder if we are not overstretching > the meaning of the public flag. At the moment on the form it appears with > the hint: > > Set to 'yes' to show this library on the Libraries page in the OPAC. > > Libraries might have a reason to not want a library show in the list (it > could be stacks, they don't the address to show), but it should still show > up in facets, on the detail pages, etc. > > We might need to differentiate more. Sounds reasonable :) Main thing here is actually getting this test a bit more consolidated. Some features are added in a very narrow scope but end up geting used much wider, with all benefits and disadvantages coming for free. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 14:03:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 12:03:48 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #51 from Marcel de Rooy --- This was a very BAD dbrev. It clears all preferences ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 14:05:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 12:05:33 +0000 Subject: [Koha-bugs] [Bug 31848] Holds queue: Submit button for filters on the left is closer to nav than to its form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31848 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 14:08:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 12:08:51 +0000 Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 --- Comment #12 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #11) > I lost track of this one, sorry.. I agree with the approach here, would you > like me to have a look at the other cases Tomas? Please do. I can too, after the release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 14:14:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 12:14:18 +0000 Subject: [Koha-bugs] [Bug 31853] New: The Overdue-tab states "no renewals left" when item is on hold Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31853 Bug ID: 31853 Summary: The Overdue-tab states "no renewals left" when item is on hold Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: hanna.dehlin at hkr.se QA Contact: testopia at bugs.koha-community.org The renew-column on the overdue-tab in the OPAC states that there are "No renewals left" when renewal is blocked because the item is on hold. The same column on the checked-out-tab states (correctly) that the item is "Not renewable (on hold)". It would be nice if the information on both tabs where the same. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 14:15:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 12:15:24 +0000 Subject: [Koha-bugs] [Bug 31848] Holds queue: Submit button for filters on the left is closer to nav than to its form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31848 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 14:15:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 12:15:28 +0000 Subject: [Koha-bugs] [Bug 31848] Holds queue: Submit button for filters on the left is closer to nav than to its form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31848 --- Comment #1 from Owen Leonard --- Created attachment 142053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142053&action=edit Bug 31848: Correct margin and padding on action fieldset in aside This patch makes a minor modification to the padding and margin of
    nested in a .brief fieldset. This markup is seen most often in sidebar filter form. The change allows the submit button to line up better with other form fields. The patch also corrects and inconsistency by modifying the holds queue template so that the .action fieldset is inside the .brief fieldset. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - If necessary, place one or more holds for pickup at your logged-in library and rebuild the holds queue (misc/cronjobs/holds/build_holds_queue.pl) - Go to Circulation -> Holds queue. - The form should look correct. - Submit the form and check the form in the sidebar. It should look correct as well, with the submit button aligned left with the other form fields. - Check pages with similar sidebar forms, e.g.: - Administration -> Budgets -> Funds -> Planning - Circulation -> Overdues - Circulation -> Holds to pull - Acquisitions -> Invoices -> Search results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 14:20:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 12:20:37 +0000 Subject: [Koha-bugs] [Bug 31854] New: Document conflict with delete_patrons.pl --not_borrowed_since and privacy = 2 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31854 Bug ID: 31854 Summary: Document conflict with delete_patrons.pl --not_borrowed_since and privacy = 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz delete_patrons.pl has this option: --not_borrowed_since Delete patrons who have not borrowed since this date. This sounds easy enough, but if you have patrons with borrowers.privacy = 2, they will have their issues/loans anonymized as they are returned, resulting in an empty history, and they will be deleted the next time delete_patrons.pl is run, even if they have just been active. This is not a problem in itself, but a reminder could be added to the documentation for --not_borrowed_since, to avoid patrons being unduly deleted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 14:21:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 12:21:04 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #52 from Björn Nylén --- (In reply to Marcel de Rooy from comment #51) > This was a very BAD dbrev. It clears all preferences ! Sorry about that one... I'm certain I tested the sql before. :blush: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 14:27:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 12:27:10 +0000 Subject: [Koha-bugs] [Bug 31855] New: Installer output buffering can be confusing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31855 Bug ID: 31855 Summary: Installer output buffering can be confusing Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org On bug 14783 a bug was introduced on the db_rev, that cleared all sysprefs. I rewinded ~500 commits in an attempt to reproduce it, following this steps: $ git reset --hard 1a1529d20572c8eb7e65ad7bbd41f688d5f86f07 $ reset_all $ git reset --hard ae986b992dfc2299ec58f4d1c0079fbac1ec4a03 $ updatedatabase the result is: root at kohadevbox:koha(master)$ updatedatabase C4::Installer::SetVersion(): DBI Exception: DBD::mysql::st execute failed: Duplicate entry 'Version' for key 'PRIMARY' at /kohadevbox/koha/C4/Installer.pm line 777 If I do this: $ git reset --hard 1a1529d20572c8eb7e65ad7bbd41f688d5f86f07 $ reset_all $ git reset --hard ab1e0a5d6ad2eb31e4322ec11a1e971386144f5d $ updatedatabase the result is: root at kohadevbox:koha((1a1529d2057...))$ updatedatabase Upgrade to 22.06.00.045 [12:04:08]: Bug 29144 - Copy and remove branches.opac_info Upgrade to 22.06.00.046 [12:04:08]: Bug 15348 - Add new column aqorders.estimated_delivery_date Upgrade to 22.06.00.047 [12:04:08]: Bug 30025 - Split and rename BiblioAddsAuthorities system preference Added RequireChoosingExistingAuthority and AutoLinkBiblios BiblioAddsAuthorities removed Upgrade to 22.06.00.048 [12:04:08]: Bug 30472 - borrower_relationships.guarantor_id NOT NULL Upgrade to 22.06.00.049 [12:04:08]: Bug 30490 - Adjust FK constraint for parent item type Upgrade to 22.06.00.050 [12:04:08]: Bug 30497 - Recreate old_reserves_ibfk_4 if cascading Upgrade to 22.06.00.051 [12:04:08]: Bug 7021 - Add patron category to the statistics table Upgrade to 22.06.00.052 [12:04:08]: Bug 25735 - Add Elasticsearch field 'available' Upgrade to 22.06.00.053 [12:04:08]: Bug 30484 - Add a notice template for ILL Update notices Bug 30484 DB update complete Upgrade to 22.06.00.054 [12:04:08]: Bug 23538 - Add new system preferences EmailPatronRegistrations and EmailAddressForPatronRegistrations and new OPAC_REG letter Upgrade to 22.06.00.055 [12:04:08]: Bug 26368 - Add OCLC Encoding Levels system preference Added UseOCLCEncodingLevels system preference Upgrade to 22.06.00.056 [12:04:08]: Bug 30571 - Table z3950servers: three cols NOT NULL Upgrade to 22.06.00.057 [12:04:08]: Bug 29071 - Set HoldsQueueSplitNumbering where not set Added HoldsSplitQueueNumbering if not already there Upgrade to 22.06.00.058 [12:04:08]: Bug 30944 - Replace branchtransfers.cancellation_reason CancelRecall with RecallCancellation Upgrade to 22.06.00.059 [12:04:08]: Bug 25936 - A password change notification feature Upgrade to 22.06.00.060 [12:04:08]: Bug 10950 - Add pronouns to borrowers table Added pronouns column to borrowers table Added pronouns column to deletedborrowers table Added pronouns column to borrower_modifications table Upgrade to 22.06.00.061 [12:04:08]: Bug 31333 - Add new suggestionPatronCategoryExceptions system preference Upgrade to 22.06.00.062 [12:04:08]: Bug 27136 - Add missing languages: Cree, Afrikaans and Multiple languages, Undetermined and No linguistic content Added missing languages Upgrade to 22.06.00.063 [12:04:08]: Bug 31569 - Add primary key for import_biblios Added primary key to import_biblios table Upgrade to 22.06.00.064 [12:04:08]: Bug 14783 - Allow patrons to change pickup location for non-waiting holds Added new system preference 'OPACAllowUserToChangeBranch' Removed system preference 'OPACInTransitHoldPickupLocationChange' As the 'failing' db_rev is the last one, I would've expected the upgrade process to print the previous db_revs output and fail on the last one, somehow. It is a weird case (the introduced bug cleared all sysprefs) but yet, the output is not correct. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 14:27:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 12:27:52 +0000 Subject: [Koha-bugs] [Bug 31855] Installer output buffering can be confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31855 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14783 CC| |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com, | |m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 14:27:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 12:27:52 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31855 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 14:35:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 12:35:05 +0000 Subject: [Koha-bugs] [Bug 25158] Introduce koha-memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25158 --- Comment #2 from Magnus Enger --- I suspect this is made obsolete by misc/bin/clear_cache.pl from Bug 20116. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 14:41:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 12:41:41 +0000 Subject: [Koha-bugs] [Bug 31854] Document conflict with delete_patrons.pl --not_borrowed_since and anonymization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31854 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Document conflict with |Document conflict with |delete_patrons.pl |delete_patrons.pl |--not_borrowed_since and |--not_borrowed_since and |privacy = 2 |anonymization -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 14:43:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 12:43:50 +0000 Subject: [Koha-bugs] [Bug 31854] Document conflict with delete_patrons.pl --not_borrowed_since and anonymization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31854 --- Comment #1 from Magnus Enger --- There could be more reasons for anonymization than borrowers.privacy = 2. Also: - borrowers.privacy = 1 + misc/cronjobs/batch_anonymise.pl - patrons choosing to anonymize their history in the OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 14:49:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 12:49:26 +0000 Subject: [Koha-bugs] [Bug 31626] Add letter ID to the message queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31626 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 142054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142054&action=edit Bug 31626: (QA follow-up) Make db_rev robust Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 14:51:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 12:51:38 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #7 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #4) > (In reply to Jonathan Druart from comment #3) > > It's not a problem to have a function defined for 'data', it just should not > > be searchable. > > Do you agree with that? Hmm. It looks a bit inconsistent. I prefer the move to render now. And it works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 14:52:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 12:52:21 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #8 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #3) > + "data": "actions", > > There is some magic in datatables.js that is using this (for sorting, > searching, etc.) and expect it to be an attribute of library. I would not > use "actions". Where can I find that? We can change these "labels" where needed.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 14:53:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 12:53:37 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #9 from Marcel de Rooy --- I do see an action function but I dont see actions in datatables.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 14:58:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 12:58:36 +0000 Subject: [Koha-bugs] [Bug 31854] Document conflict with delete_patrons.pl --not_borrowed_since and anonymization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31854 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 14:58:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 12:58:41 +0000 Subject: [Koha-bugs] [Bug 31854] Document conflict with delete_patrons.pl --not_borrowed_since and anonymization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31854 --- Comment #2 from Magnus Enger --- Created attachment 142055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142055&action=edit Bug 31854: Document --not_borrowed_since and anonymization To test: - Run "perldoc misc/cronjobs/delete_patrons.pl" - Note the absence of information about the potential conflict between --not_borrowed_since and anonymization - Apply this patch - Re-run the perldoc command and make sure the note about anonymization make sense -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:22:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:22:17 +0000 Subject: [Koha-bugs] [Bug 31754] DataTable paginate_button make other elements move around when hovered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:26:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:26:19 +0000 Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be encrypted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to encrypt data |Vendor EDI account |in Koha, use for EDI vendor |passwords should be |accounts |encrypted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:30:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:30:21 +0000 Subject: [Koha-bugs] [Bug 31846] Add syspref for serials search results limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31846 --- Comment #4 from David Gustafsson --- (In reply to Katrin Fischer from comment #3) > That is something we don't do in Koha so far afaik. I wonder if moving the > search to the API as it was done for the order receive page and the patron > search would not be a better way forward here to fix this issue? Yes, but that would require a lot more work, especially since SearchSubscriptions relies on custom queries and in practice does use the Koha::Subscriptions DBIx interface. If someone would like to refactor the search page that would perhaps be preferable, but this is quite a simple fix and think could still be useful until someone puts in the effort. The current fix works for our current needs, without it a staff interface user could presently accidentally put such a high load on the server to cause a temporary system outage. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:30:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:30:37 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 --- Comment #22 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #21) > (In reply to Katrin Fischer from comment #20) > > Looking at this again today... I also wonder if we are not overstretching > > the meaning of the public flag. At the moment on the form it appears with > > the hint: > > > > Set to 'yes' to show this library on the Libraries page in the OPAC. > > > > Libraries might have a reason to not want a library show in the list (it > > could be stacks, they don't the address to show), but it should still show > > up in facets, on the detail pages, etc. > > > > We might need to differentiate more. > > Sounds reasonable :) > Main thing here is actually getting this test a bit more consolidated. > Some features are added in a very narrow scope but end up geting used much > wider, with all benefits and disadvantages coming for free. I am not too keen on undocumented features, got way too many of those. At least leaving a trace outside of the code is necessary. At the moment we have a setting for the libraries page, a setting for pickup-locations and there is one about the library pull downs in search too: Bug 31654 - Hide non-public libraries from MastheadLibraryPulldown It might be worth checking the effects of SingleLibraryMode over to decide. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:30:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:30:38 +0000 Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:30:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:30:41 +0000 Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426 --- Comment #16 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:30:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:30:44 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:30:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:30:48 +0000 Subject: [Koha-bugs] [Bug 29480] Add email address as a method for generating the userid when self registering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #7 from Magnus Enger --- The POD for generate_userid() should be updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:30:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:30:50 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #99 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:30:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:30:55 +0000 Subject: [Koha-bugs] [Bug 31417] Re-instate the cataloguing sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:30:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:30:57 +0000 Subject: [Koha-bugs] [Bug 31417] Re-instate the cataloguing sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:31:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:31:00 +0000 Subject: [Koha-bugs] [Bug 31626] Add letter ID to the message queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31626 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:31:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:31:04 +0000 Subject: [Koha-bugs] [Bug 31626] Add letter ID to the message queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31626 --- Comment #12 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:32:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:32:52 +0000 Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be encrypted in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Vendor EDI account |Vendor EDI account |passwords should be |passwords should be |encrypted |encrypted in the database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:36:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:36:05 +0000 Subject: [Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s). In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #2 from Nick Clemens --- (In reply to Katrin Fischer from comment #1) > Hi Nick, could you share some details about the use cases for this one? > As we usually don't give superlibrarian permissions to users, could this be > tied to a new permission maybe? We also talked about a new permission, that should not be a problem. The idea here is really the ability to lock records from certain sources - in this case the library will be cataloging in an external system and pushing records in to Koha. They do not wish for these records to be edited within Koha, so want to protect them - with a limited set of users being able to edit them if the need arises. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:36:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:36:42 +0000 Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be encrypted in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:36:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:36:47 +0000 Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be encrypted in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134302|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 142056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142056&action=edit Bug 30649: Vendor EDI account passwords should be encrypted in the database We are storing edi vendor acccount passwords in clear text in the database. Now that Koha has the Koha::Encryption module, we should use that to encrypt passwords for all existing and new EDI accounts. Test Plan: 1) Apply this patch 2) Create one or more EDI vendor accounts 3) Run a report to view the account passwords, note they are in clear text 4) Run updatedatabase.pl 5) Re-run the report, account passwords should be encrypted now 6) Edit a vendor EDI account, note you can still view and update the password for an account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:37:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:37:26 +0000 Subject: [Koha-bugs] [Bug 30879] Add option to sort components by biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31756 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 [Bug 31756] Biblionumber not numerically sorting natively when using Zebra -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:37:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:37:26 +0000 Subject: [Koha-bugs] [Bug 31756] Biblionumber not numerically sorting natively when using Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30879 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 [Bug 30879] Add option to sort components by biblionumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:39:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:39:56 +0000 Subject: [Koha-bugs] [Bug 31032] Patron attributes branch limitations are unclear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31032 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com --- Comment #7 from Donna --- I don't know what the original intention of branch limits was, but can speak to how libraries are expecting it to work now. When something (patron category, attribute, auth value) is limited by branch the expectation is that I can see the data, but if I edit the field, the only options I see are the ones that my logged in branch are supposed to see. For instance, if patron category FEE is limited to branch A and B, and I am logged in at branch C, I should be able to search for patrons in that category, display their record, see they are category FEE, but when I create a new patron, or try to edit their record, I do not have the patron category option of FEE. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:41:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:41:26 +0000 Subject: [Koha-bugs] [Bug 31856] New: Improve performance of serials subscriptions search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 Bug ID: 31856 Summary: Improve performance of serials subscriptions search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: glasklas at gmail.com QA Contact: testopia at bugs.koha-community.org Currently the serials subscriptions search is very inefficient for searches producing a large number of results. The current patch introduces caching for authorized value lookups, the retrieval of search results has also been optimized to drastically reduces the number of performed queries and creation of Koha objects resulting in a speedup of about 5.5x. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:42:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:42:43 +0000 Subject: [Koha-bugs] [Bug 31422] Library limitations might cause data loss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com --- Comment #1 from Donna --- This is quite frankly, horrifying. I know a lot of large library systems and consortiums use library limitations. I agree with Katrin's solution - show the user what it currently is, and allow me to change if it needed, but don't let me change it to something that I am not permitted to use based on limitations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:44:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:44:20 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #53 from Katrin Fischer --- (In reply to Björn Nylén from comment #52) > (In reply to Marcel de Rooy from comment #51) > > This was a very BAD dbrev. It clears all preferences ! > > Sorry about that one... I'm certain I tested the sql before. :blush: Don't worry about it, we all broke something before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:45:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:45:44 +0000 Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be encrypted in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142056|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 142057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142057&action=edit Bug 30649: Vendor EDI account passwords should be encrypted in the database We are storing edi vendor acccount passwords in clear text in the database. Now that Koha has the Koha::Encryption module, we should use that to encrypt passwords for all existing and new EDI accounts. Test Plan: 1) Apply this patch 2) Create one or more EDI vendor accounts 3) Run a report to view the account passwords, note they are in clear text 4) Run updatedatabase.pl 5) Re-run the report, account passwords should be encrypted now 6) Edit a vendor EDI account, note you can still view and update the password for an account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:46:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:46:12 +0000 Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be encrypted in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:48:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:48:22 +0000 Subject: [Koha-bugs] [Bug 31856] Improve performance of serials subscriptions search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 --- Comment #1 from David Gustafsson --- Created attachment 142058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142058&action=edit Bug 31856: Improve performance of serials subscriptions search To test: 1) Perform an advanced search that produces a reasonably large resultset for serial subscriptions (preferably at least a couple of hundred) and take not of the execution time. 2) Apply the patch. 3) Perform the search again, the execution should now be about one fifth of the previous search. 4) Ensure tests in t/db_dependent/AuthorisedValues.t all pass. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 15:59:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 13:59:54 +0000 Subject: [Koha-bugs] [Bug 31856] Improve performance of serials subscriptions search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:00:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:00:50 +0000 Subject: [Koha-bugs] [Bug 31846] Add syspref for serials search results limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31846 --- Comment #5 from David Gustafsson --- Now created a separate issue for the performance improvements in bug 31856. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:03:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:03:12 +0000 Subject: [Koha-bugs] [Bug 31032] Patron attributes branch limitations are unclear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31032 --- Comment #8 from Katrin Fischer --- (In reply to Donna from comment #7) > I don't know what the original intention of branch limits was, but can speak > to how libraries are expecting it to work now. When something (patron > category, attribute, auth value) is limited by branch the expectation is > that I can see the data, but if I edit the field, the only options I see are > the ones that my logged in branch are supposed to see. > > For instance, if patron category FEE is limited to branch A and B, and I am > logged in at branch C, I should be able to search for patrons in that > category, display their record, see they are category FEE, but when I create > a new patron, or try to edit their record, I do not have the patron category > option of FEE. Exactly, I think we need to differentiate between new and existing. Because at te moment editing other library's data, we create a data loss situation :( : See Bug 31422 - Library limitations might cause data loss I think if you are allowed to edit other branch's data, we should add a 'keep current' option that allows you to leave values unchanged at least. Or we'd need to add hints that these limitations can only be recommended if you take other precautions like limiting who can edit patron and item data. (would be really happy to see bug 20256 bounce back into QA queue) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:05:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:05:12 +0000 Subject: [Koha-bugs] [Bug 31422] Library limitations might cause data loss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 --- Comment #2 from Katrin Fischer --- Thx Donna, I had missed you already found this one! Not getting much attention yet :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:05:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:05:13 +0000 Subject: [Koha-bugs] [Bug 31856] Improve performance of serials subscriptions search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 --- Comment #2 from David Gustafsson --- Also removed a test in t/db_dependent/AuthorisedValues.t that I found both not very useful and incorrect as categories where sorting is performed on the database level is compared with the same list of categories sorted in Perl (which does not sort on the same conditions as collation etc is not taken into account). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:07:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:07:09 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Ashley Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ajohnson at jcls.org --- Comment #15 from Ashley Johnson --- Highly interested in this one. We are currently using a separate catalog software for our Library of Things because it allows for reservations. Patrons and staff alike struggle with it and constantly are asking for everything to just be within Koha. Adding this ability would be a top priority for us. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:07:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:07:29 +0000 Subject: [Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s). In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #3 from Katrin Fischer --- Ah! That makes a lot of sense and could be useful in our use case as well. Are you thinking of some kind of automatism to set the locked maybe on import too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:08:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:08:23 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140714|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize --- Created attachment 142059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142059&action=edit Bug 31095: Add Koha::Patron::Restriction(s) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:08:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:08:29 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140715|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize --- Created attachment 142060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142060&action=edit Bug 31095: Add restrictions accessor to Koha::Patron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:08:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:08:35 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140716|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize --- Created attachment 142061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142061&action=edit Bug 31095: Add type relation accessor to Koha::Patron::Restriction Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:08:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:08:40 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140717|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize --- Created attachment 142062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142062&action=edit Bug 31095: Remove GetDebarments from circ/circulation.pl This patch remove the use of GetDebarments from circ/circulation.pl, replacing it with a reference to patron.restrictions in the template and includes. Test plan 1. Confirm that the 'Restrictions (x)' tab still appears on the checkout page for a user. 2. Confirm that the 'Restrictions (x)' tab count is correct 3. Confirm that the 'Restrictions (x)' tab table functions 4. Confirm that the 'Restrictions (x)' tab 'Add manual restriction' form works as expected Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:08:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:08:46 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140718|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize --- Created attachment 142063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142063&action=edit Bug 31095: Remove GetDebarments from members/moremember.pl This patch removes the use of GetDebarments from members/moremember.pl and replaces template references with patrons.restrictions and the new includes introduced in the prior patch Test plan 1. Confirm that the 'Restrictions (x)' tab still appears on the patron details page. 2. Confirm that the 'Restrictions (x)' tab count is correct 3. Confirm that the 'Restrictions (x)' tab table functions 4. Confirm that the 'Restrictions (x)' tab 'Add manual restriction' form works as expected Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:08:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:08:51 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140719|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize --- Created attachment 142064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142064&action=edit Bug 31095: Remove GetDebarments from members/memberentry.pl This patch removes the use of GetDebarments from members/memberentry.pl and replaces the references in the templates with patron.restrictions. Test plan 1. Add a new user and confirm that the patron restrictions section does not appear on the form 2. Edit the user and confirm the patron restrictions section now appears 3. Add a manual restriction using the patron edit form 4. Confirm the restriction appears on the patron edit form 5. Confirm you can remove the restriction usine the patron edit form Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:08:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:08:57 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140720|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize --- Created attachment 142065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142065&action=edit Bug 31095: Remove borrower_debarments and patron_restrictions includes This patch removes the aforementioned includes and drops the last remaining reference to them. We have replaces these includes with patron-restrictions-tab.inc and restriction-types.inc. Test plan 1. Confirm the includes are no longer referenced anywhere in the codebase. 'git grep borrower_debarments.inc', 'git grep patron_restrictions.inc' Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:09:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:09:03 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140721|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize --- Created attachment 142066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142066&action=edit Bug 31095: Remove keyed_on_code We no longer require keyed_on_code from Koha::Patron::Restrictoin::Types as we have relation accessors for the relevent use cases and no longer reference the method anywhere in the codebase! Test plan 1. Confirm 'keyed_on_code' is no longer referenced anywhere in the codebase. `git grep keyed_on_code` Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:09:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:09:08 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140722|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize --- Created attachment 142067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142067&action=edit Bug 31095: Remove GetDebarments from tools/modborrowers.pl This patch removes GetDebarments from the modborrowers tool controller and replaces it with $patron->restrictions as appropriate. Test plan 1. Confirm that the 'Batch patron modification' tool pages still load and perform as expected. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:09:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:09:13 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140723|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize --- Created attachment 142068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142068&action=edit Bug 31095: Remove GetDebarments from Circulation.pm This patch removes GetDebarments from Circulation.pm replacing them with calls to $patron->restrictions and filtering using a chained search call. Test plan 1. Confirm that t/db_dependant/Circulation.t continues to pass Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:09:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:09:19 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140724|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize --- Created attachment 142069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142069&action=edit Bug 31095: Remove GetDebarments from Circulation.t Replace GetDebarments with $patron->restrictions. Test plan 1. Run test prior to patch - all should pass 2. Run test after patch - all should pass 3. Confirm no tests were removed as part of the patch Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:09:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:09:27 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140725|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize --- Created attachment 142070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142070&action=edit Bug 31095: Remove GetDebarments from Patron::Import This patch replaced GetDebarments with $patron->restrictions->search in Koha::Patron::Import. Test plan 1. Confirm that importing patrons with debarred and debarredcomment fields in the import still works as expected Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:09:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:09:32 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140726|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize --- Created attachment 142071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142071&action=edit Bug 31095: Remove GetDebarments from maxsuspensiondays.t This patch replaces GetDebarments in maxsuspensiondays.t with calls to the restrictions accessor. Test plan 1. Confirm t/db_dependent/Circulation/maxsuspensiondays.t passes prior to this patch 2. Confirm t/db_dependent/Circulation/maxsuspensiondays.t passes after this patch 3. Confirm no tests have been removed in this patch Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:09:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:09:38 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140727|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize --- Created attachment 142072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142072&action=edit Bug 31095: Remove GetDebarments from MarkIssueReturned.t This patch removes GetDebarments from Ciculation/MarkIssueReturned.t Test plan 1. Confirm t/db_dependent/Circulation/MarkIssueReturned.t passes prior to the patch 2. Confirm t/db_dependent/Circulation/MarkIssueReturned.t passes after the patch 3. Confirm no tests have been removed Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:09:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:09:43 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140728|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize --- Created attachment 142073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142073&action=edit Bug 31095: Remove GetDebarments from Restriction/Type.t This patch replaces GetDebarments with $patron->restrictions in t/db_dependent/Koha/Patron/Restriction/Type.t Test plan 1. Confirm t/db_dependent/Koha/Patron/Restriction/Type.t passes prior to the patch 2. Confirm t/db_dependent/Koha/Patron/Restriction/Type.t passes after the patch 3. Confirm no tests were removed Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:09:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:09:48 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140729|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize --- Created attachment 142074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142074&action=edit Bug 31095: Remove GetDebarments from Borrower_Debarments.t This patch replaces calls to GetDebarments with teh $patron->restritions->search() equivilents. Test plan 1. Run the test prior to the patch and confirm it passes 2. Run the test after the patch and confirm it passes 3. Confirm no tests were removed Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:09:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:09:53 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140730|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize --- Created attachment 142075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142075&action=edit Bug 31095: Remove GetDebarments from Koha::Patron::Debarments This patch finally removes GetDebarments from the codebase. Test plan 1. Confirm GetDebarments is no longer mentioned in the codebase. `git grep GetDebarments` 2. Confirm t/db_dependent/Patron/Borrower_Debarments.t continues to pass Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:09:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:09:59 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #69 from Martin Renvoize --- Created attachment 142076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142076&action=edit Bug 31095: (QA follow-up) Fix after rebase Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:13:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:13:27 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #70 from Martin Renvoize --- (In reply to Katrin Fischer from comment #51) > Created nice SUSPENSION and OVERDUE restrictions, but then got stuck on > creating my own restriction types: > > Template process failed: file error - restriction_type_description: not > found at /kohadevbox/koha/C4/Templates.pm line 127 Fixed by the latest rebase (see final commit.. we lost some things along the way somewhere) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:13:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:13:54 +0000 Subject: [Koha-bugs] [Bug 31847] Add page section to item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31847 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | CC| |tomascohen at gmail.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:14:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:14:02 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #71 from Martin Renvoize --- (In reply to Katrin Fischer from comment #50) > Could you please check on the first fail especially? > > FAIL Koha/Patron/Restriction.pm > FAIL forbidden patterns > forbidden pattern: Warning: The 'sub type' may be wrong is declared in a > Koha::* package (see bug 15446) (line 43) > FAIL pod > *** WARNING: empty section in previous paragraph in file > Koha/Patron/Restriction.pm > > OK Koha/Patron/Restriction/Types.pm > FAIL Koha/Patron/Restrictions.pm > FAIL pod > *** WARNING: empty section in previous paragraph in file > Koha/Patron/Restrictions.pm These are false negatives.. the method name is correct here as we introduce a new 'type' relation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:16:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:16:37 +0000 Subject: [Koha-bugs] [Bug 31847] Add page section to item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31847 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:16:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:16:41 +0000 Subject: [Koha-bugs] [Bug 31847] Add page section to item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31847 --- Comment #1 from Lucas Gass --- Created attachment 142077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142077&action=edit Bug 31847: Add page-section class to item search results To test: 1. Apply patch 2. Look at item search results ( itemsearch.tt ) 3. Make sure everthing looks right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:26:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:26:23 +0000 Subject: [Koha-bugs] [Bug 31857] New: Modal header text/background color does not have enough contrast Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31857 Bug ID: 31857 Summary: Modal header text/background color does not have enough contrast Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 For modals in the new staff interface, the heading color (#696969) with the background color (#D3DFCC) does not pass color contrast checks. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:26:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:26:23 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31857 [Bug 31857] Modal header text/background color does not have enough contrast -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:33:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:33:09 +0000 Subject: [Koha-bugs] [Bug 31839] Error when viewing bibliographic details of record with local cover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31839 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #2 from Liz Rea --- This also seems to exist in 21.11.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:51:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:51:01 +0000 Subject: [Koha-bugs] [Bug 31858] New: TT syntax for ACQORDER notices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31858 Bug ID: 31858 Summary: TT syntax for ACQORDER notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: alex.arnaud at biblibre.com QA Contact: testopia at bugs.koha-community.org Add TT syntax for ACQORDER notices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 16:53:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 14:53:20 +0000 Subject: [Koha-bugs] [Bug 31858] TT syntax for ACQORDER notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31858 --- Comment #1 from Katrin Fischer --- Had this on my wish list to file too - the default notice is not very nice. Did you see you can use [% basket %] now? (Bug 31858). That should allow us to build something much nicer. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 17:15:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 15:15:49 +0000 Subject: [Koha-bugs] [Bug 31859] New: Error 500 when enabling advanced cataloging editor Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31859 Bug ID: 31859 Summary: Error 500 when enabling advanced cataloging editor Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: jcautomatizacion at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 142078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142078&action=edit Erro500 Hello everyone, An error is appearing when the advanced cataloging editor is enabled, it does not allow opening the editor or creating new records, error 500 appears. If the advanced editor is disabled, the system works correctly. The recorded log is as follows: [Tue Oct 18 14:19:17.189372 2022] [cgi:error] [pid 3532853] [client 186.102.58.32:7547] AH01215: {UNKNOWN}: DBI Exception: DBD::mysql::db selectall_arrayref failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ',servername' at line 3 at /usr/share/perl5/DBIx/Class/Schema.pm line 1118.: /usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl, referer: http://intra-archivohistoricopsbdc.org/cgi-bin/koha/cataloguing/addbooks.pl [Tue Oct 18 14:19:17.189604 2022] [cgi:error] [pid 3532853] [client 186.102.58.32:7547] AH01215: \tDBIx::Class::Schema::throw_exception(Koha::Schema=HASH(0x55e190abe1f0), "DBI Exception: DBD::mysql::db selectall_arrayref failed: You "...) called at /usr/share/perl5/DBIx/Class/Storage.pm line 113: /usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl, referer: http://intra-archivohistoricopsbdc.org/cgi-bin/koha/cataloguing/addbooks.pl [Tue Oct 18 14:19:17.189796 2022] [cgi:error] [pid 3532853] [client 186.102.58.32:7547] AH01215: \tDBIx::Class::Storage::throw_exception(DBIx::Class::Storage::DBI::mysql=HASH(0x55e190c5a2f8), "DBI Exception: DBD::mysql::db selectall_arrayref failed: You "...) called at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1501: /usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl, referer: http://intra-archivohistoricopsbdc.org/cgi-bin/koha/cataloguing/addbooks.pl [Tue Oct 18 14:19:17.189985 2022] [cgi:error] [pid 3532853] [client 186.102.58.32:7547] AH01215: \tDBIx::Class::Storage::DBI::__ANON__("DBD::mysql::db selectall_arrayref failed: You have an error i"..., DBI::db=HASH(0x55e192c83040), undef) called at /usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl line 80: /usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl, referer: http://intra-archivohistoricopsbdc.org/cgi-bin/koha/cataloguing/addbooks.pl [Tue Oct 18 14:19:17.189992 2022] [cgi:error] [pid 3532853] [client 186.102.58.32:7547] AH01215: : /usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl, referer: http://intra-archivohistoricopsbdc.org/cgi-bin/koha/cataloguing/addbooks.pl [Tue Oct 18 14:19:17.220155 2022] [cgi:error] [pid 3532853] [client 186.102.58.32:7547] End of script output before headers: editor.pl, referer: http://intra-archivohistoricopsbdc.org/cgi-bin/koha/cataloguing/addbooks.pl I appreciate your help in identifying the cause of this error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 17:16:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 15:16:56 +0000 Subject: [Koha-bugs] [Bug 31754] DataTable paginate_button make other elements move around when hovered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 --- Comment #1 from Owen Leonard --- Created attachment 142079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142079&action=edit GIF showing revised responsive behavior The staff interface update included several changes to DataTables controls which I think were unnecessary (and unrelated to the redesign). I propose to build on some work I'd intended for Bug 30986 to make general improvements. See the attached GIF for a preview. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 17:23:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 15:23:10 +0000 Subject: [Koha-bugs] [Bug 31839] Error when viewing bibliographic details of record with local cover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31839 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #3 from Lucas Gass --- This is fixed in 21.11.13 by Bug 30976. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 17:27:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 15:27:12 +0000 Subject: [Koha-bugs] [Bug 31754] Improve appearance of behavior of DataTables controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|DataTable paginate_button |Improve appearance of |make other elements move |behavior of DataTables |around when hovered |controls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 17:27:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 15:27:46 +0000 Subject: [Koha-bugs] [Bug 31754] Improve appearance of behavior of DataTables controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 17:27:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 15:27:49 +0000 Subject: [Koha-bugs] [Bug 31754] Improve appearance of behavior of DataTables controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 --- Comment #2 from Owen Leonard --- Created attachment 142080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142080&action=edit Bug 31754: Improve appearance of behavior of DataTables controls This patch makes changes to CSS and to the default DataTables DOM configuration in order to make toolbars work better at various screen widths. The patch also makes stylelint corrections to _tables.scss. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Test pages in the staff interface where tables contain multiple pages of results, e.g. a patron search. - Confirm that table information (entries) and controls look correct. - Confirm that all controls work correctly, including the search field. - Resize your browser to check how the controls respond at various browser widths. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 17:34:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 15:34:25 +0000 Subject: [Koha-bugs] [Bug 31754] Improve appearance of behavior of DataTables controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31842 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 [Bug 31842] admin/branches: DT search generates js error on col.data.split -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 17:34:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 15:34:25 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31754 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 [Bug 31754] Improve appearance of behavior of DataTables controls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 17:39:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 15:39:19 +0000 Subject: [Koha-bugs] [Bug 29515] Don't require title for HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29515 Catrina Berka changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina at bywatersolutions.co | |m --- Comment #11 from Catrina Berka --- I experience the same thing as Jonathan. The "+New entry" doesn't save if there isn't a title entered. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 17:48:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 15:48:22 +0000 Subject: [Koha-bugs] [Bug 31813] Information on manage MARC import details page is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 17:50:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 15:50:41 +0000 Subject: [Koha-bugs] [Bug 31813] Specify white-space: normal for spans styled as labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Information on manage MARC |Specify white-space: normal |import details page is |for spans styled as labels |misaligned | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 17:52:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 15:52:23 +0000 Subject: [Koha-bugs] [Bug 31805] Tidy up transfer pages (branchtransfers.pl) - terminology and styling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31805 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 17:55:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 15:55:35 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #319 from Blou --- Thanks Bjorn, we didn't know it was used by anyone else. Puts more pressure now on us to keep it straight. :) We're discovering new issues now that we playing with 22.05, and Maryse is fixing them. After release to our customers, we hope to find time to split the patches in multiple cute ones as demanded. It won't happen until december though, I fear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 18:08:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 16:08:20 +0000 Subject: [Koha-bugs] [Bug 31813] Specify white-space: normal for spans styled as labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 18:08:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 16:08:24 +0000 Subject: [Koha-bugs] [Bug 31813] Specify white-space: normal for spans styled as labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 --- Comment #1 from Owen Leonard --- Created attachment 142081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142081&action=edit Bug 31813: Specify white-space: normal for spans styled as labels This patch is necessary to override a CSS property being inherited from Bootstrap. Allowing a with the "label" class to wrap will keep alignment correct when displaying information in the same layout as a form. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - If necessary, stage a batch of MARC files (Cataloging -> Stage MARC records for import). - Go to Cataloging -> Manage staged MARC records and click on one of the batches to view the details. - In the list of information about the batch, longer labels like "Matching rule applied" should wrap so that they stay aligned with other labels in the list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 18:26:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 16:26:41 +0000 Subject: [Koha-bugs] [Bug 31557] Add ability for holds queue builder to prioritize either sending an item home or keeping it at the holding library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Summary|Hold queue/home vs. holding |Add ability for holds queue |library/transport cost |builder to prioritize |matrix complications |either sending an item home | |or keeping it at the | |holding library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 18:42:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 16:42:45 +0000 Subject: [Koha-bugs] [Bug 31557] Add ability for holds queue builder to prioritize either matching a patron's home library to the item's home or holding library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability for holds queue |Add ability for holds queue |builder to prioritize |builder to prioritize |either sending an item home |either matching a patron's |or keeping it at the |home library to the item's |holding library |home or holding library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 18:48:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 16:48:42 +0000 Subject: [Koha-bugs] [Bug 31750] Need more padding in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 18:49:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 16:49:52 +0000 Subject: [Koha-bugs] [Bug 31557] Add ability for holds queue builder to prioritize either matching a patron's home library to the item's home or holding library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 18:49:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 16:49:55 +0000 Subject: [Koha-bugs] [Bug 31557] Add ability for holds queue builder to prioritize either matching a patron's home library to the item's home or holding library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557 --- Comment #1 from Kyle M Hall --- Created attachment 142082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142082&action=edit Bug 31557: Add ability for holds queue builder to prioritize either matching a patron's home library to the item's home or holding library Right now the holds queue builder starts filling bib-level holds with items whose patron's home library matches the item's home library. It would be good and reasonable to have the option to prioritize item's whose patron's home library matches the item's holding library to minimize transfers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 19:15:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 17:15:29 +0000 Subject: [Koha-bugs] [Bug 29515] Don't require title for HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29515 --- Comment #12 from Martin Renvoize --- I recently found this broken again too. This area appears rather fragile, I'm sure when I QA'd this bug it was working, but lots has moved again since. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 19:36:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 17:36:15 +0000 Subject: [Koha-bugs] [Bug 31739] Password reset from staff fails if previous expired reset-entry exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31739 Emily changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 19:39:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 17:39:17 +0000 Subject: [Koha-bugs] [Bug 31750] Need more padding in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 19:39:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 17:39:21 +0000 Subject: [Koha-bugs] [Bug 31750] Need more padding in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 --- Comment #4 from Owen Leonard --- Created attachment 142083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142083&action=edit Bug 31750: Need more padding in cataloguing This patch makes some minor tweaks to the CSS controlling the appearance of the toolbar shown in the basic cataloging editor. To test, apply the patch and go to Cataloging -> New record. - Confirm that the page looks correct, with the toolbar the same width as the main content of the page. - Confirm that the toolbar looks correct when you scroll and the toolbar "floats" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 19:39:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 17:39:28 +0000 Subject: [Koha-bugs] [Bug 31750] Need more padding in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 --- Comment #5 from Owen Leonard --- Created attachment 142084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142084&action=edit Bug 31750: (follow-up) Stylelint fixes This patch makes no changes which affect the style of the page. All changes are corrections to formatting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 19:39:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 17:39:45 +0000 Subject: [Koha-bugs] [Bug 31848] Holds queue: Submit button for filters on the left is closer to nav than to its form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31848 Emily changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 19:41:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 17:41:45 +0000 Subject: [Koha-bugs] [Bug 31754] Improve appearance of behavior of DataTables controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 --- Comment #3 from Lucas Gass --- So much better, thank you Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 19:42:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 17:42:29 +0000 Subject: [Koha-bugs] [Bug 31754] Improve appearance of behavior of DataTables controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 19:42:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 17:42:33 +0000 Subject: [Koha-bugs] [Bug 31754] Improve appearance of behavior of DataTables controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142080|0 |1 is obsolete| | --- Comment #4 from Lucas Gass --- Created attachment 142085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142085&action=edit Bug 31754: Improve appearance of behavior of DataTables controls This patch makes changes to CSS and to the default DataTables DOM configuration in order to make toolbars work better at various screen widths. The patch also makes stylelint corrections to _tables.scss. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Test pages in the staff interface where tables contain multiple pages of results, e.g. a patron search. - Confirm that table information (entries) and controls look correct. - Confirm that all controls work correctly, including the search field. - Resize your browser to check how the controls respond at various browser widths. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 19:43:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 17:43:14 +0000 Subject: [Koha-bugs] [Bug 31750] Need more padding in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 19:45:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 17:45:31 +0000 Subject: [Koha-bugs] [Bug 31813] Specify white-space: normal for spans styled as labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|30952 | Depends on| |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 19:45:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 17:45:31 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31813 Depends on|31813 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 [Bug 31813] Specify white-space: normal for spans styled as labels -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 19:56:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 17:56:10 +0000 Subject: [Koha-bugs] [Bug 31850] Patron import: welcome email option style as list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31850 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 19:56:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 17:56:13 +0000 Subject: [Koha-bugs] [Bug 31850] Patron import: welcome email option style as list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31850 --- Comment #1 from Owen Leonard --- Created attachment 142086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142086&action=edit Bug 31850: Patron import: welcome email option style as list This patch corrects the markup around the "Send email to new patrons" checkbox on the patron import page. The list should be an ordered list, not an unordered list. To test, apply the patch and go to Tools -> Import patrons. In the "Welcome email" section, there should be no bullet point before the "Send email to new patrons" line. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 19:59:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 17:59:45 +0000 Subject: [Koha-bugs] [Bug 31850] Patron import: welcome email option style as list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31850 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 20:08:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 18:08:52 +0000 Subject: [Koha-bugs] [Bug 31836] Formatting issue on checkin modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31836 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 31753 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 20:08:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 18:08:52 +0000 Subject: [Koha-bugs] [Bug 31753] Dialog boxes inside of modals don't seem wide enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Owen Leonard --- *** Bug 31836 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 20:09:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 18:09:08 +0000 Subject: [Koha-bugs] [Bug 31753] Dialog boxes inside of modals don't seem wide enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 20:22:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 18:22:04 +0000 Subject: [Koha-bugs] [Bug 28486] MARCItemFieldsToOrder values lost when using Add Order button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28486 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 20:22:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 18:22:06 +0000 Subject: [Koha-bugs] [Bug 22108] Items generated through MARCItemFieldsToOrder do not receive values applied in Item Information and Default Accounting Details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22108 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 20:42:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 18:42:51 +0000 Subject: [Koha-bugs] [Bug 21381] Add serial enumeration to circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- Created attachment 142087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142087&action=edit Screenshot of table settings - column name label is blank Hi Katrin. This all works, however for me the column name in the table settings is blank (see screenshot). Also, should this be an option on the checkout history page for a record's details page? David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 21:09:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 19:09:39 +0000 Subject: [Koha-bugs] [Bug 31860] New: 952$h - Serial enumeration / chronology: use sentence case for label Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31860 Bug ID: 31860 Summary: 952$h - Serial enumeration / chronology: use sentence case for label Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org The label for Serial enumeration / chronology (952$h) is displayed as "Serial Enumeration / chronology" - note the capital "E". For consistency, this should be displayed in sentence case wherever it is required in the staff interface and OPAC, including: - details view in the staff interface: MARC view, edit items table, add and edit item form - MARC view in the OPAC: holdings table Note: Libraries can update this themselves by updating $952$h for all the frameworks it is used in. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 21:18:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 19:18:06 +0000 Subject: [Koha-bugs] [Bug 29150] hold pickup sent two patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29150 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- There is not enough information here to move forward with a patch, please reopen with more details if this is still a requirement. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 21:23:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 19:23:35 +0000 Subject: [Koha-bugs] [Bug 31857] Modal header text/background color does not have enough contrast In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31857 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- This issue will be fixed by Bug 31753 *** This bug has been marked as a duplicate of bug 31753 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 21:23:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 19:23:35 +0000 Subject: [Koha-bugs] [Bug 31753] Dialog boxes inside of modals don't seem wide enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 --- Comment #2 from Owen Leonard --- *** Bug 31857 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 21:27:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 19:27:02 +0000 Subject: [Koha-bugs] [Bug 31754] Improve appearance of behavior of DataTables controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 21:36:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 19:36:55 +0000 Subject: [Koha-bugs] [Bug 31861] New: Table controls on checkouts table are buttons Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Bug ID: 31861 Summary: Table controls on checkouts table are buttons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Created attachment 142088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142088&action=edit Screenshot of checkouts table The table controls to export, print and change columns on the checkouts table in patron account look much different to the table controls on other tables. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 21:36:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 19:36:55 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31861 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 [Bug 31861] Table controls on checkouts table are buttons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 21:38:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 19:38:35 +0000 Subject: [Koha-bugs] [Bug 31754] Improve appearance of behavior of DataTables controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 --- Comment #5 from Katrin Fischer --- I quite like what I see, but leaving it here for now as: (21:34:00) oleonard: Hm... I think my patch for Bug 31754 doesn't keep the controls on the right. I should revised it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 21:40:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 19:40:35 +0000 Subject: [Koha-bugs] [Bug 31754] Improve appearance of behavior of DataTables controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142085|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 142089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142089&action=edit Bug 31754: Improve appearance of behavior of DataTables controls This patch makes changes to CSS and to the default DataTables DOM configuration in order to make toolbars work better at various screen widths. The patch also makes stylelint corrections to _tables.scss. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Test pages in the staff interface where tables contain multiple pages of results, e.g. a patron search. - Confirm that table information (entries) and controls look correct. - Confirm that all controls work correctly, including the search field. - Resize your browser to check how the controls respond at various browser widths. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 21:41:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 19:41:30 +0000 Subject: [Koha-bugs] [Bug 27920] Add ability to update patron expiration dates when importing patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 21:41:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 19:41:54 +0000 Subject: [Koha-bugs] [Bug 31862] New: HTML customization not be created if no title entered Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31862 Bug ID: 31862 Summary: HTML customization not be created if no title entered Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: catrina at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When adding a new entry in HTML Customizations, content is not saved if no title is entered. Bug 29515 was supposed to fix this in 22.05 but the issue persists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 21:44:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 19:44:35 +0000 Subject: [Koha-bugs] [Bug 28577] Add column for copynumber on overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28577 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind --- Created attachment 142090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142090&action=edit Screenshots of column display and settings table Hi Katrin. After the patch is applied (see attached screenshots): - Item type is displaying in the copy number column, and copy number is displaying in the item type column. - There is no column name label in the table settings (and the wrong columns are toggled). David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 21:44:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 19:44:54 +0000 Subject: [Koha-bugs] [Bug 28577] Add column for copynumber on overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28577 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 21:54:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 19:54:23 +0000 Subject: [Koha-bugs] [Bug 31847] Add page section to item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31847 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 21:54:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 19:54:27 +0000 Subject: [Koha-bugs] [Bug 31847] Add page section to item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31847 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142077|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142091&action=edit Bug 31847: Add page-section class to item search results To test: 1. Apply patch 2. Look at item search results ( itemsearch.tt ) 3. Make sure everthing looks right. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 21:57:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 19:57:39 +0000 Subject: [Koha-bugs] [Bug 31847] Add page section to item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31847 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- The < Last>> buttons are "scrunched up". I'm not sure if that was the case before the staff interface refresh or not... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 21:59:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 19:59:25 +0000 Subject: [Koha-bugs] [Bug 31846] Add syspref for serials search results limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31846 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com |ity.org | --- Comment #6 from David Nind --- I've added David Gustafsson as the assignee. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:00:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:00:19 +0000 Subject: [Koha-bugs] [Bug 27920] Add ability to update patron expiration dates when importing patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Katrin Fischer --- 1) Unit test With the patch applied, the tests output some warn, without the patch the output is clean: prove t/db_dependent/Koha/Patrons/Import.t t/db_dependent/Koha/Patrons/Import.t .. 166/176 Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$fh> line 2. Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$fh> line 2. t/db_dependent/Koha/Patrons/Import.t .. ok BorrowerRenewalPeriodBase 2) GUI I am not sure the options are described clearly as is: Update existing patron expiration dates. * Maybe instead of update it should be "recalculate"? Otherwise I would understand this as 'use the expiration date from the file'. Update patron's expiration date based on the current date instead of the patron's enrollment date * We have BorrowerRenewalPeriodBase, maybe we could have a pull down or preselect the option according to the pref? * The 2 options feel disconnected. Maybe the second should only be enabled, if the first was checked? Or use identation? * What's the supposed behaviour when there is an expiration date in the import file? Will it be used or do the checkboxes take precedence? If so, maybe we could add: ... values in the import file will be ignored. * While we are there... can we also remove the . from the only option that has it? :) 3) Test plan Can we have a test plan please? 4) CLI Marcel is right, expiration-from-today is missing: +import_patrons.pl --file /path/to/patrons.csv --matchpoint cardnumber --confirm [--default branchcode=MPL] [--overwrite] [--preserve_field ] [--preserve-extended-attributes] [--update-expiration] [--verbose] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:02:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:02:51 +0000 Subject: [Koha-bugs] [Bug 28577] Add column for copynumber on overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28577 --- Comment #3 from Katrin Fischer --- (In reply to David Nind from comment #2) > Created attachment 142090 [details] > Screenshots of column display and settings table > > Hi Katrin. > > After the patch is applied (see attached screenshots): > > - Item type is displaying in the copy number column, and copy number is > displaying in the item type column. > > - There is no column name label in the table settings (and the wrong columns > are toggled). > > David Hm, I wonder what I did there, will have a look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:08:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:08:04 +0000 Subject: [Koha-bugs] [Bug 31847] Add page section to item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31847 --- Comment #4 from Katrin Fischer --- (In reply to David Nind from comment #3) > The < Last>> buttons are "scrunched up". > > I'm not sure if that was the case before the staff interface refresh or > not... I think Owen is working on this on bug 31754 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:09:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:09:04 +0000 Subject: [Koha-bugs] [Bug 31848] Holds queue: Submit button for filters on the left is closer to nav than to its form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31848 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:09:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:09:09 +0000 Subject: [Koha-bugs] [Bug 31848] Holds queue: Submit button for filters on the left is closer to nav than to its form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31848 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142053|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142092&action=edit Bug 31848: Correct margin and padding on action fieldset in aside This patch makes a minor modification to the padding and margin of
    nested in a .brief fieldset. This markup is seen most often in sidebar filter form. The change allows the submit button to line up better with other form fields. The patch also corrects and inconsistency by modifying the holds queue template so that the .action fieldset is inside the .brief fieldset. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - If necessary, place one or more holds for pickup at your logged-in library and rebuild the holds queue (misc/cronjobs/holds/build_holds_queue.pl) - Go to Circulation -> Holds queue. - The form should look correct. - Submit the form and check the form in the sidebar. It should look correct as well, with the submit button aligned left with the other form fields. - Check pages with similar sidebar forms, e.g.: - Administration -> Budgets -> Funds -> Planning - Circulation -> Overdues - Circulation -> Holds to pull - Acquisitions -> Invoices -> Search results Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:10:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:10:44 +0000 Subject: [Koha-bugs] [Bug 22666] When using authority records in a bibliographic record, the order of the subfields is not sent over In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22666 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:10:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:10:49 +0000 Subject: [Koha-bugs] [Bug 22666] When using authority records in a bibliographic record, the order of the subfields is not sent over In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22666 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140060|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 142093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142093&action=edit Bug 25387: The order of authority subfield is not sent over to bibliographic record When creating an authority record there is the possibility to reorder the subfield. However this order is not sent back to the bibliographic records when using this authority in a bibliographic record. This patch make the order of subfield be sent back to bibliographic record when the autority is used. Field that are fill are sent to the begining of the bibliographic record in the same order as in the authority record. Test plan: 1- Find or create an authority record and reorder some subfield 2- Use this authority in a bibliographic record 3- Observe that the order of the subfield is not transferred from the authority record to the bibliographic record 4- Apply the patch 5- Repeat step 1 and 2 again 6- Observe that the order of the subfield is now transferred from the authority record to the bibliographic record https://bugs.koha-community.org/show_bug.cgi?id=22666 Signed-off-by: George Veranis Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:11:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:11:13 +0000 Subject: [Koha-bugs] [Bug 22666] When using authority records in a bibliographic record, the order of the subfields is not sent over In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22666 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Keywords| |release-notes-needed --- Comment #4 from Katrin Fischer --- George, I have added your sign-off line to the patch, assuming you meant to sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:11:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:11:55 +0000 Subject: [Koha-bugs] [Bug 18556] Message "Patron's address in doubt" is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:13:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:13:00 +0000 Subject: [Koha-bugs] [Bug 18556] Message "Patron's address in doubt" is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:13:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:13:05 +0000 Subject: [Koha-bugs] [Bug 18556] Message "Patron's address in doubt" is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140641|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 142094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142094&action=edit Bug 18556: Clarify lost and gonenoaddress messages This patch alters the message for the patron flasg slightly, and adds a title to provide explicit info when hoevered To test: 1 - Edit a patron and set gonenoaddress and lost flags 2 - Note new info in the flags section 3 - Go to 'Checkout' or 'Details' tab for patron 4 - Confirm the messages make sense 5 - Confirm you see a tool tip when hovering on messages Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:17:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:17:39 +0000 Subject: [Koha-bugs] [Bug 31863] New: Advanced cataloging editor no longer auto-resizes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 Bug ID: 31863 Summary: Advanced cataloging editor no longer auto-resizes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The advanced cataloging editor no longer automatically resizes the height of the CodeMirror editor, prior to 22.05 it did. To recreate: 1. Turn on 'EnableAdvancedCatalogingEditor' 2. Go to a record with enough MARC data that it should take up the entire width of your screen, 3. The CodeMirror editor will only be 300px. 4. Prior to 22.05 it would dynamically adjust to the height of your screen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:18:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:18:10 +0000 Subject: [Koha-bugs] [Bug 31863] Advanced cataloging editor no longer auto-resizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com, | |catrina at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:18:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:18:37 +0000 Subject: [Koha-bugs] [Bug 31750] Need more padding in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:18:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:18:42 +0000 Subject: [Koha-bugs] [Bug 31750] Need more padding in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142083|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 142095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142095&action=edit Bug 31750: Need more padding in cataloguing This patch makes some minor tweaks to the CSS controlling the appearance of the toolbar shown in the basic cataloging editor. To test, apply the patch and go to Cataloging -> New record. - Confirm that the page looks correct, with the toolbar the same width as the main content of the page. - Confirm that the toolbar looks correct when you scroll and the toolbar "floats" Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:18:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:18:47 +0000 Subject: [Koha-bugs] [Bug 31750] Need more padding in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142084|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 142096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142096&action=edit Bug 31750: (follow-up) Stylelint fixes This patch makes no changes which affect the style of the page. All changes are corrections to formatting. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:20:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:20:38 +0000 Subject: [Koha-bugs] [Bug 18556] Message "Patron's address in doubt" is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 --- Comment #7 from Katrin Fischer --- (In reply to Nick Clemens from comment #5) > (In reply to Katrin Fischer from comment #4) > > I like the change in wording, but I am in doubt about removing the circ-hlt > > class as it appears in the CSS and in other messages shown in the patron > > account, so it's something they have in common right now. Maybe we should > > keep it? > > I don't remove it, it remains, one level down > This is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:21:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:21:07 +0000 Subject: [Koha-bugs] [Bug 29662] PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:23:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:23:43 +0000 Subject: [Koha-bugs] [Bug 31847] Add page section to item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31847 --- Comment #5 from David Nind --- (In reply to Katrin Fischer from comment #4) > I think Owen is working on this on bug 31754 Excellent! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:31:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:31:47 +0000 Subject: [Koha-bugs] [Bug 29662] PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:31:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:31:52 +0000 Subject: [Koha-bugs] [Bug 29662] PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140344|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 142097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142097&action=edit Bug 29662: (bug 27526 follow-up) Prefill all subfields if SubfieldsToUseWhenPrefill is empty Signed-off-by: Thibault Keromnès Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:31:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:31:58 +0000 Subject: [Koha-bugs] [Bug 29662] PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 --- Comment #10 from Katrin Fischer --- Created attachment 142098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142098&action=edit Bug 29662: (QA folow-up) Add explanation for empty to system preference description This amends the system preference description for PrefillItem to explain what happens when the pref is left empty. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:47:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:47:33 +0000 Subject: [Koha-bugs] [Bug 31813] Specify white-space: normal for spans styled as labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind --- Created attachment 142099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142099&action=edit Screenshots of manage staed MARC records - before and after I'm not noticing any differences (see screenshots, even though they are from two different batches). Am I looking in the right place? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:49:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:49:45 +0000 Subject: [Koha-bugs] [Bug 31863] Advanced cataloging editor no longer auto-resizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 --- Comment #1 from Lucas Gass --- This is because of how we calculate the adjusted height in the function 'onResize'. If the 'changelanguage' element does not exist then '$('#changelanguage').height()' will be undefined. 1 + undefined == NaN. We cannot change the editor height to NaN. We should check for the existence of the 'changelanguage' and if it is not present change the calculation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:53:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:53:04 +0000 Subject: [Koha-bugs] [Bug 31850] Patron import: welcome email option style as list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31850 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:53:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:53:08 +0000 Subject: [Koha-bugs] [Bug 31850] Patron import: welcome email option style as list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31850 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142086|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142100&action=edit Bug 31850: Patron import: welcome email option style as list This patch corrects the markup around the "Send email to new patrons" checkbox on the patron import page. The list should be an ordered list, not an unordered list. To test, apply the patch and go to Tools -> Import patrons. In the "Welcome email" section, there should be no bullet point before the "Send email to new patrons" line. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:58:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:58:49 +0000 Subject: [Koha-bugs] [Bug 31863] Advanced cataloging editor no longer auto-resizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:58:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:58:52 +0000 Subject: [Koha-bugs] [Bug 31863] Advanced cataloging editor no longer auto-resizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 --- Comment #2 from Lucas Gass --- Created attachment 142101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142101&action=edit Bug 31863: Account for changelanguage element when adjusting editor height To test: 1. Turn on 'EnableAdvancedCatalogingEditor' 2. Go to a record with enough MARC data that it should take up the entire width of your screen, 3. The CodeMirror editor will only be 300px. 4. Resize your screen, nothing happens to the editor height 5. Apply patch 6. Look at the same record in your editor, the editor should go to the bottom of the page now. Resizing your screen should resize the editor. 7. Have some additional language packs installed, and change the language system pref so the '#changelanguage' option will appear. 8. Make sure the editor height is still being properly set. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 22:59:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 20:59:45 +0000 Subject: [Koha-bugs] [Bug 31863] Advanced cataloging editor no longer auto-resizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 23:35:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 21:35:45 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 23:35:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 21:35:49 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141388|0 |1 is obsolete| | --- Comment #5 from Lari Taskula --- Created attachment 142102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142102&action=edit Bug 31692: Add Koha::Hold::change_type and unit tests To test: 1. prove t/db_dependent/Koha/Hold.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 23:35:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 21:35:53 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141390|0 |1 is obsolete| | --- Comment #6 from Lari Taskula --- Created attachment 142103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142103&action=edit Bug 31692: Allow librarians to change hold type in staff client To test: 1. Apply patch 2. Add item level hold to a record/item, make sure patron has no other holds on that record 3. Go to /cgi-bin/koha/reserve/request.pl?biblionumber=xxx where xxx is the record you placed the hold for 4. Under "Existing holds" table, in "Details" column you should see "Only item X". Click the red X and click Update hold(s) 5. Observe "Only item " has changed to "Next available" 6. Cancel the hold and add two item level holds 7. Under "Existing holds" table, in "Details" column you should see "Only item ", but no red X for either holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 23:35:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 21:35:57 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #7 from Lari Taskula --- Created attachment 142104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142104&action=edit Bug 31692: (follow-up) Add tooltip for changing hold type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 23:38:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 21:38:34 +0000 Subject: [Koha-bugs] [Bug 31664] Show pending transfers on biblio details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31664 Emily changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 23:45:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 21:45:23 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #8 from Lari Taskula --- (In reply to Lucas Gass from comment #3) > I think the use of another red X on the page to change the item level hold > into a bib level one is confusing. There are already a few red X's on the > page and that particular one offers no explanation to the user as to what it > will do. > > Maybe we need a dropdown? I'm not sure if that is the proper solution either. (In reply to Katrin Fischer from comment #4) > Lucas is making a good point, could you please have a look Lari? Maybe some > other icon could be used? I have to admit my first idea was some kind of > upwards arrow for (level upwards) but... there are also a lot of arrows > already. A tooltip for sure makes sense. Thanks for the feedback, Lucas and Katrin. I've added a tooltip in the form of "title" attribute - if Koha has another way of showing tooltips then please correct me. Great suggestion! About the X, (by the way, it just became green with the new theme) my reasoning for choosing it was to represent something to "remove" the item from the hold. Perhaps an "unlinking" icon could work too. https://fontawesome.com/v4/icon/chain-broken Dropdown is also a nice idea in the sense that it could be extended to show other items as well and let librarians change the item if necessary. But that is unfortunately out of scope for what I am trying to achieve here. I have also rebased to resolve some git conflicts and patches can now be tested again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 18 23:59:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 21:59:09 +0000 Subject: [Koha-bugs] [Bug 31863] Advanced cataloging editor no longer auto-resizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:09:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:09:38 +0000 Subject: [Koha-bugs] [Bug 29662] PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:11:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:11:07 +0000 Subject: [Koha-bugs] [Bug 29663] Document expected behavior of Prefill Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29663 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- I amended the system preference on bug 29662 and we can use the new Needs Documenting after to make sure this goes into the manual. Marking duplicate. *** This bug has been marked as a duplicate of bug 29662 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:11:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:11:07 +0000 Subject: [Koha-bugs] [Bug 29662] PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 --- Comment #11 from Katrin Fischer --- *** Bug 29663 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:15:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:15:04 +0000 Subject: [Koha-bugs] [Bug 31770] Add 'page-section' to rotating collections page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31770 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:15:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:15:09 +0000 Subject: [Koha-bugs] [Bug 31770] Add 'page-section' to rotating collections page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31770 --- Comment #1 from Lucas Gass --- Created attachment 142105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142105&action=edit Bug 31770: Add page-section class to rotating collections page To test: 1. Apply patch 2. Go to the rotating collections page. Tools / Rotating collections 3. Add some new collections 4. Note that the page looks good with the new page section div. Note: I made some indentation changes and fixed a small typo where the 'dropdown-toggle' class was not being properly applied. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:15:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:15:52 +0000 Subject: [Koha-bugs] [Bug 31770] Add 'page-section' to rotating collections page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31770 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:16:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:16:45 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142103|0 |1 is obsolete| | --- Comment #9 from Lari Taskula --- Created attachment 142106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142106&action=edit Bug 31692: Allow librarians to change hold type in staff client To test: 1. Apply patch 2. Add item level hold to a record/item, make sure patron has no other holds on that record 3. Go to /cgi-bin/koha/reserve/request.pl?biblionumber=xxx where xxx is the record you placed the hold for 4. Under "Existing holds" table, in "Details" column you should see "Only item X". Click the red X and click Update hold(s) 5. Observe "Only item " has changed to "Next available" 6. Cancel the hold and add two item level holds 7. Under "Existing holds" table, in "Details" column you should see "Only item ", but no red X for either holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:16:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:16:50 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142104|0 |1 is obsolete| | --- Comment #10 from Lari Taskula --- Created attachment 142107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142107&action=edit Bug 31692: (follow-up) Add tooltip for changing hold type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:16:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:16:54 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #11 from Lari Taskula --- Created attachment 142108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142108&action=edit Bug 31692: (follow-up) Use fa-chain and fa-chain-broken icons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:16:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:16:58 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #12 from Lari Taskula --- Created attachment 142109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142109&action=edit Bug 31692: (follow-up) Rewording tooltip Using "change to next available item" would require changing title and aria-label dynamically to "change to only item ..." when clicked. While possible, simply using "toggle hold type" covers both cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:19:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:19:10 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 --- Comment #16 from David Cook --- We're having requests for this coming up again as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:20:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:20:20 +0000 Subject: [Koha-bugs] [Bug 31739] Password reset from staff fails if previous expired reset-entry exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31739 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:20:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:20:25 +0000 Subject: [Koha-bugs] [Bug 31739] Password reset from staff fails if previous expired reset-entry exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31739 --- Comment #4 from David Nind --- Created attachment 142110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142110&action=edit Bug 31739: Password recovery from staff fails if previous expired reset-entry exists. SendPasswordRecoveryEmail relies on the calling script to tell if there is an existing valid recovery already. If there's an expired recovery-entry the members/notices.pl script will try to create a new entry resulting in a duplicate key error. This patch fixes the bug by removing the need for the calling script to do the check as since SendPasswordRecoveryEmail does the same thing anyway. SendPasswordRecoveryEmail will now use DBIx ->update_or_create instead of looking at the $update param to determine if it should update an existing entry or create a new. The update param is removed from all calling scripts and test are updated. To test: 1. Generate a password recovery mail for a patron 2. Let it expire. 3. Generate a new password recovery from staff to the same patron - Fail! 4: Apply patch 5. Generate a new password recovery from staff to the same patron - Success! 6. Opac password recovery flow should also work. 7. Tests pass. Sponsored-by: Lund University Library Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:22:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:22:21 +0000 Subject: [Koha-bugs] [Bug 31739] Password reset from staff fails if previous expired reset-entry exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31739 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Attachment #141732|0 |1 is obsolete| | --- Comment #5 from David Nind --- Comment on attachment 141732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141732 Bug 31739: Remove need to pass update param to Koha::Patron::Password::Recovery::SendPasswordRecoveryEmail I obsoleted the first patch - for whatever reason, when I signed it off there were two patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:24:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:24:51 +0000 Subject: [Koha-bugs] [Bug 31739] Password reset from staff fails if previous expired reset-entry exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31739 --- Comment #6 from David Nind --- Testing notes (using koha-testing-docker): 1. For a patron category (for example, Patron (PT)), set 'Password reset in OPAC' to 'Allowed' (Administration > Patrons and circulation > Patron categories). 2. Enable system to send emails (for testing, using Gmail) and restart everything (flush_memcached, restart_all): - You need a valid SMTP configuration in koha-conf.xml. - Generate an 'app password' for your Gmail account. - Edit koha-conf.xml and add this configuration (YOUR APP PASSWORD = the app password): smtp.gmail.com 587 5 STARTTLS YOUR GMAIL ADDRESS YOUR APP PASSWORD 1 3. Update the details for a patron: - add your Gmail address to a patron (for example: YOUR GMAIL ADDRESS for Mary Burton, borrower number 49) - update the OPAC/Staff interface login username (for example: mary) 4. Initiate a password reset from the OPAC: . From the OPAC home page, click on 'Forgot your password' below the log in box . Enter the username for the login and press 'Submit' 5. Update the expiry date for the password reset in the database so that it is expired: - List password recovery requests: . koha-mysql kohadev . select * from borrower_password_recovery; - Update the expiry date: . update borrower_password_recovery set valid_until = "2022-10-18 00:00:00" where borrowernumber=49; 6. Go to the patron's details page in the staff interface and select More > Send password reset: ==> You get an error trace: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Duplicate entry '49' for key 'PRIMARY' at /kohadevbox/koha/Koha/Patron/Password/Recovery.pm line 132 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 7. Apply the patch and restart everything (flush_memcached, restart_all). 8. Send password reset from the staff interface again - it should now work (email received and 'Koha password reset' notice under notices). 9. Re-test the forgotten password recovery process - steps 4, 5 and 8. Everything should work as expected: . Note that for step 4 you may get an error message "The process of password recovery has already been started for this account ("mary")...". Click on the link 'Get new password recovery link'. 10. Tests should pass: prove t/db_dependent/Passwordrecovery.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:25:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:25:57 +0000 Subject: [Koha-bugs] [Bug 20116] Improve performance by caching the language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:27:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:27:19 +0000 Subject: [Koha-bugs] [Bug 31771] Add 'page-section' to stock rotation pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31771 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:27:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:27:22 +0000 Subject: [Koha-bugs] [Bug 31771] Add 'page-section' to stock rotation pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31771 --- Comment #1 from Lucas Gass --- Created attachment 142111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142111&action=edit Bug 31771: Add page-section to stock rotation pages To test: 1. Apply patch 2. Set the system preference 'StockRotation' to enable. 3. Go to Cataloging / Stock rotation 4. Add some new rotas 5. Make sure the page looks good with the new page-section div -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:27:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:27:46 +0000 Subject: [Koha-bugs] [Bug 31771] Add 'page-section' to stock rotation pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31771 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:28:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:28:12 +0000 Subject: [Koha-bugs] [Bug 31771] Add 'page-section' to stock rotation pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31771 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:36:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:36:22 +0000 Subject: [Koha-bugs] [Bug 31786] Sub template->param($var) should return the value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31786 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #4 from David Cook --- (In reply to Marcel de Rooy from comment #3) > (In reply to Jonathan Druart from comment #2) > > What is the context? Why don't you use CGI->param? :) > > See description too. If earlier code like C4/Auth already pushed info into > the template object, it would be nice to read it back later (instead of > requerying etc.). Yes, we can access {VARS} but that looks like a bad > practice. > In such a case CGI::param might not be in the picture. In frameworks like Catalyst and Mojolicious, the controller has a "stash" method which provides getting/setting of values to pass to the template. I've certainly used it for both getting and setting in both frameworks. Catalyst: $c->stash->{foo} = $bar; $c->stash( { moose => 'majestic', qux => 0 } ); $c->stash( bar => 1, gorch => 2 ); # equivalent to passing a hashref Mojolicious: my $name = $c->stash('name'); $c->stash(text => "Hello $name"); https://metacpan.org/pod/Catalyst#$c-%3Estash https://docs.mojolicious.org/Mojolicious/Guides/Tutorial#Stash-and-templates https://mojolicious.io/blog/2017/12/02/day-2-the-stash/ So returning a value from $template->param() does sound reasonable. However... I thought that we were moving away from $template->param() and to $template->{VARS} in general. (Although I don't see a Coding Guideline that says that.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:38:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:38:53 +0000 Subject: [Koha-bugs] [Bug 31355] Specific item holds table on OPAC only showing 10 items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31355 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |arthur.suzuki at biblibre.com --- Comment #8 from Arthur Suzuki --- depends on bug 29713, won't backport unless asked for -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:47:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:47:29 +0000 Subject: [Koha-bugs] [Bug 31863] Advanced cataloging editor no longer auto-resizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:47:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:47:34 +0000 Subject: [Koha-bugs] [Bug 31863] Advanced cataloging editor no longer auto-resizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142101|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 142112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142112&action=edit Bug 31863: Account for changelanguage element when adjusting editor height To test: 1. Turn on 'EnableAdvancedCatalogingEditor' 2. Go to a record with enough MARC data that it should take up the entire width of your screen, 3. The CodeMirror editor will only be 300px. 4. Resize your screen, nothing happens to the editor height 5. Apply patch 6. Look at the same record in your editor, the editor should go to the bottom of the page now. Resizing your screen should resize the editor. 7. Have some additional language packs installed, and change the language system pref so the '#changelanguage' option will appear. 8. Make sure the editor height is still being properly set. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:49:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:49:30 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:49:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:49:37 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142049|0 |1 is obsolete| | --- Comment #16 from Aleisha Amohia --- Created attachment 142113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142113&action=edit Bug 23012: Apply processing fee return policy when lost item found This enhancement gives the ability to set a policy for the lost item processing fee that may get charged additional to the lost item replacement cost. The processing fee can be: - refunded - refunded if unpaid - kept To test: Set-up 1. Find an item, Item A. Go to Administration -> Item types and edit the item type for Item A. Add a default replacement cost and a processing fee and Save. 2. Go to Administration -> system preferences and set the following: - WhenLostChargeReplacementFee: Charge - BlockReturnOfLostItems: Don't block 3. Scroll down to the default lost item fee refund on return policy. Set the refund lost item replacement fee policy to 'refund lost item charge'. 4. Edit Item A and set a replacement cost. Reproduce 5. Check out Item A to Patron A. 6. Click the barcode to view Item A's information. Edit Item A and set the Lost status to 'lost'. 7. Go back to Patron A's checkouts. The item should now be checked in with two new charges applied - a lost item fee (the item's replacement cost) and a lost item processing fee (set in item types). 8. Check in Item A to mark it as found. 9. Go back to Patron A's account. Notice the lost item fee has been refunded, but the processing fee remains. 10. Manually pay or write off the processing fee. This enhancement removes the need for this manual step. 11. Apply the patch and restart services Test with lost item - refund 12. Go to Administration -> circulation and fines rules. Scroll down to the default lost item fee refund on return policy. Notice there is now a refund lost item processing fee policy. Set this to 'refund lost item processing charge'. 13. Repeat steps 6 to 9. 14. Go back to Patron A's account. Both the lost item fee and processing fee should have been refunded. 15. Repeat steps 6 to 8 (do not check it yet). 16. Go back to Patron A's account. Pay the processing fee. 17. Repeat step 9. 18. Go back to Patron A's account. Both the lost item fee and processing fee should have been refunded (you'll now be in a credit because the paid processing fee was also refunded). Test with lost item - refund_unpaid 19. Go to Administration -> circulation and fines rules. Scroll down to the default lost item fee refund on return policy. Notice there is now a refund lost item processing fee policy. Set this to 'refund lost item processing charge (only if unpaid)'. 20. Repeat steps 6 to 9. 21. Go back to Patron A's account. Both the lost item fee and processing fee should have been refunded. 22. Repeat steps 16 to 19. 23. Go back to Patron A's account. The lost item fee should have been refunded but not the processing fee, as this was already paid. Test with lost item - leave 24. Go to Administration -> circulation and fines rules. Scroll down to the default lost item fee refund on return policy. Notice there is now a refund lost item processing fee policy. Set this to 'leave lost item processing charge'. 25. Repeat steps 6 to 9. 26. Go back to Patron A's account. The lost item fee and processing fee should have been refunded but not the processing fee. Other tests 27. Confirm tests pass - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/CirculationRules.t Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:50:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:50:21 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement gives the release notes| |ability to set a policy for | |the lost item processing | |fee that may get charged | |additional to the lost item | |replacement cost. The | |processing fee can be: | |- | |refunded | |- refunded if | |unpaid | |- kept -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:51:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:51:04 +0000 Subject: [Koha-bugs] [Bug 31863] Advanced cataloging editor no longer auto-resizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- Thanks Lucas! I had noticed yesterday when testing another bug, but hadn't yet logged a bug. After installing a language, I noticed that the titles for records aren't displayed in the search results after switching to the language in the staff interface and OPAC (even after a reindex). I'm sure it hasn't done that in the past... so maybe another staff interface bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:51:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:51:50 +0000 Subject: [Koha-bugs] [Bug 31864] New: Fix breadcrumbs for each link coming from the new cataloging module home page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 Bug ID: 31864 Summary: Fix breadcrumbs for each link coming from the new cataloging module home page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 31162 Bug 31162 introduced a new cataloging module homepage, awesome! Most of the breadcrumbs on those pages still point back to Tools, even though the links no longer live in tools. We should update the breadcrumbs on each page so they trace back to Cataloging instead of tools. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 [Bug 31162] Add a clear cataloguing module home page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:51:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:51:50 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31864 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:52:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:52:28 +0000 Subject: [Koha-bugs] [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:57:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:57:59 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142106|0 |1 is obsolete| | --- Comment #13 from Lari Taskula --- Created attachment 142114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142114&action=edit Bug 31692: Allow librarians to change hold type in staff client To test: 1. Apply patch 2. Add item level hold to a record/item, make sure patron has no other holds on that record 3. Go to /cgi-bin/koha/reserve/request.pl?biblionumber=xxx where xxx is the record you placed the hold for 4. Under "Existing holds" table, in "Details" column you should see "Only item X". Click the red X and click Update hold(s) 5. Observe "Only item " has changed to "Next available" 6. Cancel the hold and add two item level holds 7. Under "Existing holds" table, in "Details" column you should see "Only item ", but no red X for either holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:58:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:58:04 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142107|0 |1 is obsolete| | --- Comment #14 from Lari Taskula --- Created attachment 142115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142115&action=edit Bug 31692: (follow-up) Add tooltip for changing hold type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:58:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:58:08 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142108|0 |1 is obsolete| | --- Comment #15 from Lari Taskula --- Created attachment 142116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142116&action=edit Bug 31692: (follow-up) Use fa-chain and fa-chain-broken icons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:58:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:58:13 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142109|0 |1 is obsolete| | --- Comment #16 from Lari Taskula --- Created attachment 142117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142117&action=edit Bug 31692: (follow-up) Rewording tooltip Using "change to next available item" would require changing title and aria-label dynamically to "change to only item ..." when clicked. While possible, simply using "toggle hold type" covers both cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 00:58:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 22:58:22 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #17 from Lari Taskula --- Created attachment 142118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142118&action=edit Bug 31692: (alternative look) Use select dropdown -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 01:01:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 23:01:41 +0000 Subject: [Koha-bugs] [Bug 31771] Add 'page-section' to stock rotation pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31771 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31770 -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 01:01:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 23:01:41 +0000 Subject: [Koha-bugs] [Bug 31770] Add 'page-section' to rotating collections page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31770 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31771 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 01:02:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 23:02:42 +0000 Subject: [Koha-bugs] [Bug 31770] Add 'page-section' to rotating collections page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31770 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 01:02:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 23:02:47 +0000 Subject: [Koha-bugs] [Bug 31770] Add 'page-section' to rotating collections page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31770 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142105|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142119&action=edit Bug 31770: Add page-section class to rotating collections page To test: 1. Apply patch 2. Go to the rotating collections page. Tools / Rotating collections 3. Add some new collections 4. Note that the page looks good with the new page section div. Note: I made some indentation changes and fixed a small typo where the 'dropdown-toggle' class was not being properly applied. Signed-off-by: David Nind -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 01:03:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 23:03:04 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #18 from Lari Taskula --- In reply to Lucas Gass from comment #3) > Maybe we need a dropdown? I'm not sure if that is the proper solution either. I actually wanted to see what it looks like so I implemented patch: Bug 31692: (alternative look) Use select dropdown I think it looks quite okay. It also allows me to get rid of all extra JavaScript and tooltip issues. Great idea Lucas. Thoughts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 01:08:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 23:08:14 +0000 Subject: [Koha-bugs] [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 01:14:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 23:14:04 +0000 Subject: [Koha-bugs] [Bug 31770] Add 'page-section' to rotating collections page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31770 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31771 | CC| |david at davidnind.com -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 01:14:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 23:14:04 +0000 Subject: [Koha-bugs] [Bug 31771] Add 'page-section' to stock rotation pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31771 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31770 | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 01:14:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 23:14:24 +0000 Subject: [Koha-bugs] [Bug 31351] Worker dies on reindex job when operator last name/first name/branch name contains non-ASCII chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com --- Comment #39 from Arthur Suzuki --- depends on bug29346 which introduce BatchUpdateBiblioHoldQueue. Lots of conflicts while trying the rebase. Please provide a backport patch for 21.11.x if this one is needed. Won't backport unless asked to. Arthur -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 01:16:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 23:16:16 +0000 Subject: [Koha-bugs] [Bug 31770] Add 'page-section' to rotating collections page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31770 --- Comment #3 from David Nind --- Should the page-section div for list of items in the rotating collection be included in this one, or a separate bug (I couldn't see one)? Apologies for the noise with bug 30771 - I got confused and thought they were related. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 01:17:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 23:17:07 +0000 Subject: [Koha-bugs] [Bug 31771] Add 'page-section' to stock rotation pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31771 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 01:17:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 23:17:13 +0000 Subject: [Koha-bugs] [Bug 31771] Add 'page-section' to stock rotation pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31771 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142111|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142120&action=edit Bug 31771: Add page-section to stock rotation pages To test: 1. Apply patch 2. Set the system preference 'StockRotation' to enable. 3. Go to Cataloging / Stock rotation 4. Add some new rotas 5. Make sure the page looks good with the new page-section div Signed-off-by: David Nind -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 01:28:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 23:28:31 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com --- Comment #34 from Arthur Suzuki --- That one brings in conflicts plus the added tests don't pass on 21.11.x if I fix the conflicts. Could you add backport patches for 21.11.x if that is needed? If that is needed I could spend more time on it but I won't unless you ask. Arthur -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 01:33:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 23:33:12 +0000 Subject: [Koha-bugs] [Bug 31664] Show pending transfers on biblio details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31664 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 01:33:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 23:33:16 +0000 Subject: [Koha-bugs] [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 01:33:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 23:33:17 +0000 Subject: [Koha-bugs] [Bug 31664] Show pending transfers on biblio details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31664 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141125|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142121&action=edit Bug 31664: Display pending transfer information on details page If a transfer is requested, but not sent, we should display this information on biblio details for staff This patch also removes nocancel parameter that was not used, passes transfer object directly to template To test 1 - Manually transfer an item 2 - Note the item shows in transit on details page 3 - Remove the datesent to emulate a pending transfer UPDATE branchtransfers SET datesent = NULL itemnumber=1; 4 - View details page - no info on transfer 5 - Apply patch 6 - Item shows 'Transit pending' Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 01:33:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 23:33:20 +0000 Subject: [Koha-bugs] [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 --- Comment #1 from Lucas Gass --- Created attachment 142122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142122&action=edit Bug 31864: Correct breadcrumbs for pages in new cataloging module To test: 1. Apply patch 2. Set system preference 'StockRotation' to enable. 3. Be logged in as a superlibrarian 4. Check the breadcrumbs on the following pages, accessible from the Cataloging module homepage: barcode-print.tt label-edit-batch.tt label-edit-layout.tt label-edit-profile.tt label-edit-range.tt label-edit-template.tt label-home.tt label-manage.tt spinelabel-home.tt automatic_item_modification_by_age.tt batchMod-edit.tt batchMod.tt batch_delete_records.tt export.tt inventory.tt manage-marc-import.tt marc_modification_templates.tt stage-marc-import.tt stockrotation.tt upload-images.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 01:35:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Oct 2022 23:35:09 +0000 Subject: [Koha-bugs] [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 03:07:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 01:07:48 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 03:07:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 01:07:53 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142046|0 |1 is obsolete| | --- Comment #17 from David Nind --- Created attachment 142123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142123&action=edit Bug 23012: Database updates for PROCESSING_FOUND account credit type Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 03:07:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 01:07:59 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142047|0 |1 is obsolete| | --- Comment #18 from David Nind --- Created attachment 142124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142124&action=edit Bug 23012: Show the PROCESSING_FOUND account credit type Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 03:08:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 01:08:06 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142048|0 |1 is obsolete| | --- Comment #19 from David Nind --- Created attachment 142125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142125&action=edit Bug 23012: Set policy for lost item processing fee Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 03:08:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 01:08:12 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142113|0 |1 is obsolete| | --- Comment #20 from David Nind --- Created attachment 142126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142126&action=edit Bug 23012: Apply processing fee return policy when lost item found This enhancement gives the ability to set a policy for the lost item processing fee that may get charged additional to the lost item replacement cost. The processing fee can be: - refunded - refunded if unpaid - kept To test: Set-up 1. Find an item, Item A. Go to Administration -> Item types and edit the item type for Item A. Add a default replacement cost and a processing fee and Save. 2. Go to Administration -> system preferences and set the following: - WhenLostChargeReplacementFee: Charge - BlockReturnOfLostItems: Don't block 3. Scroll down to the default lost item fee refund on return policy. Set the refund lost item replacement fee policy to 'refund lost item charge'. 4. Edit Item A and set a replacement cost. Reproduce 5. Check out Item A to Patron A. 6. Click the barcode to view Item A's information. Edit Item A and set the Lost status to 'lost'. 7. Go back to Patron A's checkouts. The item should now be checked in with two new charges applied - a lost item fee (the item's replacement cost) and a lost item processing fee (set in item types). 8. Check in Item A to mark it as found. 9. Go back to Patron A's account. Notice the lost item fee has been refunded, but the processing fee remains. 10. Manually pay or write off the processing fee. This enhancement removes the need for this manual step. 11. Apply the patch and restart services Test with lost item - refund 12. Go to Administration -> circulation and fines rules. Scroll down to the default lost item fee refund on return policy. Notice there is now a refund lost item processing fee policy. Set this to 'refund lost item processing charge'. 13. Repeat steps 6 to 9. 14. Go back to Patron A's account. Both the lost item fee and processing fee should have been refunded. 15. Repeat steps 6 to 8 (do not check it yet). 16. Go back to Patron A's account. Pay the processing fee. 17. Repeat step 9. 18. Go back to Patron A's account. Both the lost item fee and processing fee should have been refunded (you'll now be in a credit because the paid processing fee was also refunded). Test with lost item - refund_unpaid 19. Go to Administration -> circulation and fines rules. Scroll down to the default lost item fee refund on return policy. Notice there is now a refund lost item processing fee policy. Set this to 'refund lost item processing charge (only if unpaid)'. 20. Repeat steps 6 to 9. 21. Go back to Patron A's account. Both the lost item fee and processing fee should have been refunded. 22. Repeat steps 16 to 19. 23. Go back to Patron A's account. The lost item fee should have been refunded but not the processing fee, as this was already paid. Test with lost item - leave 24. Go to Administration -> circulation and fines rules. Scroll down to the default lost item fee refund on return policy. Notice there is now a refund lost item processing fee policy. Set this to 'leave lost item processing charge'. 25. Repeat steps 6 to 9. 26. Go back to Patron A's account. The lost item fee and processing fee should have been refunded but not the processing fee. Other tests 27. Confirm tests pass - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/CirculationRules.t Sponsored-by: Auckland University of Technology Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 03:15:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 01:15:50 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #21 from David Nind --- Testing notes (using koha-testing-docker): - Managed to work through the test plan OK. - Step 2: these are the default settings for KTD with the sample data, so no change to system preferences required. - Step 11: updatedatabase required. - Steps 13 + 15 + 20 + 22 + 25: I think a couple of the repeat steps X to should be steps 5 to X? - Step 26 should be: the lost item fee should have been refunded but not the processing fee (as expected with the 'refund lost item processing fee' policy set to 'leave lost item processing charge'). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 05:20:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 03:20:05 +0000 Subject: [Koha-bugs] [Bug 31865] New: Hide display of 'dev/testing' packages on production installs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31865 Bug ID: 31865 Summary: Hide display of 'dev/testing' packages on production installs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: About Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org this patchset attempts to hide the display of 'dev/testing' packages on production installs this will hopefully reduce situations where dev/testing packages are installed from CPAN, which can introduce problems -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 05:55:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 03:55:06 +0000 Subject: [Koha-bugs] [Bug 31866] New: Catalog update Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31866 Bug ID: 31866 Summary: Catalog update Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: amtul.sajjad at fps.edu.pk QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Books have been accessed and shown in report and circulation but could not search in catalog -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 06:42:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 04:42:41 +0000 Subject: [Koha-bugs] [Bug 31865] Hide display of 'dev/testing' packages on production installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31865 --- Comment #1 from Mason James --- Created attachment 142127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142127&action=edit Bug 31865: hide development modules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 06:48:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 04:48:59 +0000 Subject: [Koha-bugs] [Bug 31865] Hide display of 'dev/testing' packages on production installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31865 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142127|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 06:49:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 04:49:34 +0000 Subject: [Koha-bugs] [Bug 31865] Hide display of 'dev/testing' packages on production installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31865 --- Comment #2 from Mason James --- Created attachment 142128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142128&action=edit Bug 31865: add develop section to cpanfile -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 06:50:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 04:50:09 +0000 Subject: [Koha-bugs] [Bug 31840] Incorrect warning that order total amount exceeds allowed budget when editing existing order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31840 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 06:50:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 04:50:15 +0000 Subject: [Koha-bugs] [Bug 31840] Incorrect warning that order total amount exceeds allowed budget when editing existing order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31840 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141949|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142129&action=edit Bug 31840: Consider current cost if modifying order This patch deducts the current cost of an order if modifying it, so that the current cost isn't counted when checking whether the updated cost will take the order total amount above the allowed budget. To test: 1. Add an active budget of $1,000 2. Attach a fund of $1,000. Set the fund to warn at 98% and $900. 3. Add an order to a basket, give it a vendor price of $500 with no discount or tax and Save 4. Modify the order and change the vendor price to $450 and Save 5. Notice you get a warning that this order total amount will exceed the allowed budget - this is incorrect. 6. Apply the patch and cancel the change so you're redirected back to the basket 7. Modify the order and change the vendor price to $450 and Save 8. You should be able to Save without requiring confirmation 9. Add another order to the basket, give it a vendor price of $100 with no discount or tax and Save. This should save normally, confirming we can add new orders that do not exceed the allowed budget 10. Add another order to the basket, give it a vendor price of $500 with no discount or tax and Save. This should trigger the warning that you will exceed the allowed budget, as expected. Sponsored-by: Waikato Institute of Technology Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 06:50:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 04:50:57 +0000 Subject: [Koha-bugs] [Bug 31865] Hide display of 'dev/testing' packages on production installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31865 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142128|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 06:52:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 04:52:10 +0000 Subject: [Koha-bugs] [Bug 31865] Hide display of 'dev/testing' packages on production installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31865 --- Comment #3 from Mason James --- Created attachment 142130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142130&action=edit Bug 31865: add 'develop' section to cpanfile -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 06:52:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 04:52:15 +0000 Subject: [Koha-bugs] [Bug 31865] Hide display of 'dev/testing' packages on production installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31865 --- Comment #4 from Mason James --- Created attachment 142131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142131&action=edit Bug 31865: hide development modules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 06:59:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 04:59:52 +0000 Subject: [Koha-bugs] [Bug 31865] Hide display of 'dev/testing' packages on production installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31865 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #5 from Mason James --- (In reply to Mason James from comment #0) > this patchset attempts to hide the display of 'dev/testing' packages on > production installs > > this will hopefully reduce situations where dev/testing packages are > installed from CPAN, which can introduce problems to test: - apply patchset - start KTD - observe apache::bench module in about.pl->modules - fake 'production' install by adding the following code in about.pl, line 660 660 $ENV{DEV_INSTALL} = 0; <<<<<<<<<<<<< 661 foreach my $pm_type(@pm_types) { 662 my $modules = $perl_modules->get_attr($pm_type); - restart plack - observe apache::bench module is *not* in about.pl->modules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 07:00:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 05:00:37 +0000 Subject: [Koha-bugs] [Bug 31865] Hide display of 'dev/testing' packages on production installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31865 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | CC| |jonathan.druart+koha at gmail. | |com, tomascohen at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 07:03:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 05:03:44 +0000 Subject: [Koha-bugs] [Bug 31865] Hide display of 'dev/testing' packages on production installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31865 --- Comment #6 from Mason James --- Created attachment 142132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142132&action=edit dev_install=0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 08:11:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 06:11:50 +0000 Subject: [Koha-bugs] [Bug 31865] Hide display of 'dev/testing' packages on production installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31865 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #7 from David Cook --- Haven't looked at the patches but I like the idea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 09:09:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 07:09:49 +0000 Subject: [Koha-bugs] [Bug 31858] TT syntax for ACQORDER notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31858 --- Comment #2 from Alex Arnaud --- (In reply to Katrin Fischer from comment #1) > Did you see you can use [% basket %] now? (Bug 31858). That should allow us Wrong bug number ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 09:10:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 07:10:58 +0000 Subject: [Koha-bugs] [Bug 31858] TT syntax for ACQORDER notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31858 --- Comment #3 from Katrin Fischer --- (In reply to Alex Arnaud from comment #2) > (In reply to Katrin Fischer from comment #1) > > Did you see you can use [% basket %] now? (Bug 31858). That should allow us > Wrong bug number ? Typical me... bug 31587 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 09:17:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 07:17:02 +0000 Subject: [Koha-bugs] [Bug 16656] Add option to send patron search results to batch patron modification without using patron lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16656 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add option to send patron |Add option to send patron |search results to bath |search results to batch |patron modification without |patron modification without |using patron lists |using patron lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 09:19:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 07:19:36 +0000 Subject: [Koha-bugs] [Bug 31867] New: Add note to DefaultPatronSearchFields that searchable patron attributes are always included Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31867 Bug ID: 31867 Summary: Add note to DefaultPatronSearchFields that searchable patron attributes are always included Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com There was some confusion recently about what 'searchable' meant for patron attributes. I think it would help if we added a note to the DefaultPatronSearchFields system preference description. Patron attributes marked searchable can always be searched for within the "Standard" search option. See also test plan on bug 30576 for reference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 09:24:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 07:24:13 +0000 Subject: [Koha-bugs] [Bug 28473] Add REST endpoint for searching extended patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28473 --- Comment #5 from Katrin Fischer --- I see there is an x-koha-embed for patron_attributes, probably since the switch of the patron search. Maybe this helps? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 09:26:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 07:26:25 +0000 Subject: [Koha-bugs] [Bug 31868] New: Add search options for searchable patron attributes to pull down list Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31868 Bug ID: 31868 Summary: Add search options for searchable patron attributes to pull down list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com, michaela.sieber at kit.edu When a patron attribute is marked as searchable, it can be searched within the Standard search option, but this is not really transparent and sometimes not so helpful when you have multiple YES_NO options for example. It would be nice if any patron attribute marked searchable would automatically show as a search option in the pull down list. We already do this with other additionally configurable fields in serials and acq, so this would also make things more consistent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 10:12:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 08:12:22 +0000 Subject: [Koha-bugs] [Bug 31865] Hide display of 'dev/testing' packages on production installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31865 --- Comment #8 from Jonathan Druart --- Maybe better to still display them but separately? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 10:27:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 08:27:13 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #320 from Jonathan Druart --- You should make sure the concept of this patch is approved by other developers before spending more time on rewriting/splitting this patchset. See also comment #121, and #154. > * did you take a look at Date::Holidays? 4 years old question still pending for answers, etc. Last release of Date::Holidays was on Oct 10, 2022! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 10:43:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 08:43:56 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #10 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #7) > (In reply to Jonathan Druart from comment #4) > > (In reply to Jonathan Druart from comment #3) > > > It's not a problem to have a function defined for 'data', it just should not > > > be searchable. > > > > Do you agree with that? > > Hmm. It looks a bit inconsistent. I prefer the move to render now. And it > works. Ok but if you keep data:function and set searchable to false, it also works. "It works" is not enough ;) (In reply to Marcel de Rooy from comment #8) > (In reply to Jonathan Druart from comment #3) > > + "data": "actions", > > > > There is some magic in datatables.js that is using this (for sorting, > > searching, etc.) and expect it to be an attribute of library. I would not > > use "actions". > > Where can I find that? We can change these "labels" where needed.. "data" is not a label https://datatables.net/reference/option/columns.data vs https://datatables.net/reference/option/columns.render `data: "actions"` does not mean anything. The magic is: the DT REST API wrapper is using the "data" value to build the table, it must be a value returned by the REST API response. (In reply to Marcel de Rooy from comment #9) > I do see an action function but I dont see actions in datatables.js See above. Occurrences are: 583 var attributes = col.data.split(':'); 607 return col.bSearchable && typeof col.data == 'string' && data.columns[col.idx].search.value != '' 685 var order_by = options.columns[order_col].data; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 10:44:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 08:44:24 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 10:46:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 08:46:27 +0000 Subject: [Koha-bugs] [Bug 30976] Cover images for biblio should be displayed first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976 --- Comment #13 from Jonathan Druart --- (In reply to Arthur Suzuki from comment #11) > Thx thomas, > applied to 21.11.x for 21.11.13 But "Version(s) release in" have "22.11.00, 22.05.04, 21.11.11" Are you editing it manually? There is a RMaint script for that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 10:46:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 08:46:51 +0000 Subject: [Koha-bugs] [Bug 31839] Error when viewing bibliographic details of record with local cover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31839 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 30976 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 10:46:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 08:46:51 +0000 Subject: [Koha-bugs] [Bug 30976] Cover images for biblio should be displayed first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ricvargasmed at gmail.com --- Comment #14 from Jonathan Druart --- *** Bug 31839 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 10:48:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 08:48:56 +0000 Subject: [Koha-bugs] [Bug 27768] Flatpickr allows entering invalid dates (from cataloguing plugin dateaccessioned.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27768 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Flatpickr allows entering |Flatpickr allows entering |invalid dates |invalid dates (from | |cataloguing plugin | |dateaccessioned.pl) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 10:58:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 08:58:00 +0000 Subject: [Koha-bugs] [Bug 29480] Add email address as a method for generating the userid when self registering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 10:58:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 08:58:06 +0000 Subject: [Koha-bugs] [Bug 29480] Add email address as a method for generating the userid when self registering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127679|0 |1 is obsolete| | --- Comment #8 from Magnus Enger --- Created attachment 142133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142133&action=edit Bug 29480: Add new systempreference PatronSelfRegistrationUseridGenerationMethod and add email as option. Test plan - Install patch and run koha-upgrade-schema - The systempreference PatronSelfRegistrationUseridGenerationMethod should be found in the adminstrative interface under OPAC -> Self registration and modification - Also make sure - Make sure that PatronSelfRegistration is set to Allow and PatronSelfRegistrationDefaultCategory is set to an existing borrower category - Make sure that PatronSelfModificationBorrowerUnwantedField doesn't prevent the input of an email address in the self registration form. (I.e., make sure "email" is NOT selected for exclusion.) - Go to opac and self register a patron and verify that the userid is on the form firstname.surname. - Change systempreference to 'email' - Go to OPAC and self register a patron and make sure to add a valid email address. - Verify the that the userid is the email adress. - Go to OPAC and self register a patron using the SAME valid email adress as above (to provoke a conflicting userid). - Verify that the userid is on the form firstname.surname. Signed-off-by: Magnus Enger Works as advertised. I will provide followups for the issues that have been pointed out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 10:58:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 08:58:12 +0000 Subject: [Koha-bugs] [Bug 29480] Add email address as a method for generating the userid when self registering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 --- Comment #9 from Magnus Enger --- Created attachment 142134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142134&action=edit Bug 29480: (follow up) Use "patron", not "borrower" Also changes "user name" to "userid". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 10:58:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 08:58:18 +0000 Subject: [Koha-bugs] [Bug 29480] Add email address as a method for generating the userid when self registering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 --- Comment #10 from Magnus Enger --- Created attachment 142135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142135&action=edit Bug 29480: (follow up) Add tests to subtest generate_userid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 11:03:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 09:03:04 +0000 Subject: [Koha-bugs] [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind --- I haven't signed off because of Batch item deletion and Batch record modification. Batch item deletion: The first page is OK, but not when you process something: 1. Enter a barcode (e.g. 39999000011418) in the barcode list. 2. Click Continue. 4. Results screen: still has Tools > Batch item deletion (http://127.0.0.1:8081/cgi-bin/koha/tools/batchMod.pl). Batch record modification: First page still showing Tools > Batch record modification (with and without and any MARC modification templates setup) In addition, page titles are still showing the old title - maybe changing these should be a separate bug. To view the page title, hover over the tab in your browser, for example for Batch item deletion: Batch item deletion > Tools > Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 11:06:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 09:06:54 +0000 Subject: [Koha-bugs] [Bug 29480] Add email address as a method for generating the userid when self registering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 --- Comment #11 from Magnus Enger --- Created attachment 142136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142136&action=edit Bug 29480: (follow up) Update POD for generate_userid() Add an explanation of how PatronSelfRegistrationUseridGenerationMethod will affect behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 11:20:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 09:20:27 +0000 Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 --- Comment #13 from Martin Renvoize --- Created attachment 142137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142137&action=edit Bug 31224: Add Koha::Biblio->metadata_record This patch introduces a higher-level method for retrieving a 'prepared' record for using in specific contexts. In particular, I only focused on embedding item information and OPAC view filtering. But we could add a way to get the record through the ViewPolicy also for staff. The virtue of this patch is that it explains better than my words why I think having the *embed_items* and *opac* parameters in Koha::Biblio::Metadata->record is not ideal. And makes the other implementation feel like is done at the wrong level. I know it's been done like that to act as a drop-in replacement fro GetMarcBiblio, which was a good first step. But we need to revisit how it is used, in general, to come up with a more refined and useful design. So we do not port the same design problems from C4::* into Koha::*. Try to think how it would be used in contexts like opac-MARCdetail.pl or any other OPAC controller script. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 11:20:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 09:20:32 +0000 Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 --- Comment #14 from Martin Renvoize --- Created attachment 142138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142138&action=edit Bug 31224: Use metadata_record in opac-MARCdetail.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 11:20:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 09:20:37 +0000 Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 --- Comment #15 from Martin Renvoize --- Created attachment 142139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142139&action=edit Bug 31224: (QA follow-up) Fix syntax error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 11:20:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 09:20:41 +0000 Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 --- Comment #16 from Martin Renvoize --- Created attachment 142140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142140&action=edit Bug 31224: Convert C4::Record::marcrecord2csv Update marcrecord2csv to user RecordProcessor directly for embedding listed items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 11:20:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 09:20:46 +0000 Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 --- Comment #17 from Martin Renvoize --- Created attachment 142141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142141&action=edit Bug 31224: Support 'interface' on metadata_record We replace the 'opac' boolean with an 'interface' param here to allow for ViewPolicy filtering depending on 'opac', 'intranet' or 'nothing' being passed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 11:20:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 09:20:50 +0000 Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 --- Comment #18 from Martin Renvoize --- Created attachment 142142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142142&action=edit Bug 31224: Update instances of metadata->record We can now call metadata_record directly on the Koha::Biblio object. This aptch updates all modules and controllers to use Koha::Biblio->metadata_record directly where appropriate. The exceptions are where we don't require any filtering or the filtering makes sense to do after the initial fetch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 11:21:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 09:21:16 +0000 Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138063|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 11:21:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 09:21:26 +0000 Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138064|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 11:25:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 09:25:12 +0000 Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 --- Comment #19 from Martin Renvoize --- OK.. So I've worked through a grep of `metadata->record(` to catch all cases where we were applying filters to the record (well.. all cases that did it directly on fetch and not as a second step) for controllers and modules only at this point.. I will follow-up and do tests next. After working through I decided to update the new method to accept an 'interface' parameter instead of using 'opac' as a boolean.. this allows for 'opac', 'intranet' and 'undefined' as options giving us a little more control for the ViewPolicy filter use case. I opted not to port the optional passing of a list of itemnumbers to embed as there's only one use case of it.. so instead I added the RecordProcesser to the controller in that case. Let me know what you think.. I'm also still somewhat open on the method name.. 'metadata_record' vs 'filtered_record' or 'record_filtered' or something along those lines? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 11:26:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 09:26:09 +0000 Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 --- Comment #20 from Martin Renvoize --- Also.. should I work through and try to replace ALL calls to ->metadata->record with ->metadata_record.. and check for superfluous RecordProcessor instantiations now we can do it inline? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 11:31:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 09:31:32 +0000 Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen at gmail.com |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 11:38:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 09:38:55 +0000 Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142142|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 142143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142143&action=edit Bug 31224: Update instances of metadata->record We can now call metadata_record directly on the Koha::Biblio object. This aptch updates all modules and controllers to use Koha::Biblio->metadata_record directly where appropriate. The exceptions are where we don't require any filtering or the filtering makes sense to do after the initial fetch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 12:22:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 10:22:38 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:02:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:02:32 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #11 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #10) > Ok but if you keep data:function and set searchable to false, it also works. > "It works" is not enough ;) I will revert most changes now. But imo dataTables or the additional customizations are buggy and/or inconsistent. If data may be a function, you simply need to check col.data.split.. Definitely a bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:19:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:19:28 +0000 Subject: [Koha-bugs] [Bug 31869] New: Unable to save thesaurus value to frameworks subfields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31869 Bug ID: 31869 Summary: Unable to save thesaurus value to frameworks subfields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Similar to bug 31238. I checked the rest of the form, seems to just be this field To test: 1. Edit e.g. default frameworks subfield 952$8 2. Add or change fields thesaurus value 3. Save your changes => note that on subfield listing there is no mention that 952$8 is linked to any thesaurus => if you edit 952$8 thesaurus input is empty -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:20:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:20:00 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:20:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:20:04 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142032|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy --- Created attachment 142144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142144&action=edit Bug 31842: Move data function to render in branches.tt This applies to dataTable columns: library_info, actions and opac_info. Set searchable to false for opac_info too. Test plan: Check if DT search for libraries works again. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy {EDIT] Reverted the data/render function change as requested by Jonathan. Considering the fact that dataTables or custom extensions do not check data.col.split as a clear bug btw. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:22:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:22:24 +0000 Subject: [Koha-bugs] [Bug 31753] Dialog boxes inside of modals don't seem wide enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:22:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:22:28 +0000 Subject: [Koha-bugs] [Bug 31753] Dialog boxes inside of modals don't seem wide enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 --- Comment #3 from Owen Leonard --- Created attachment 142145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142145&action=edit Bug 31753: Dialog boxes inside of modals don't seem wide enough This patch makes some tweaks to the style of Bootstrap modals in the staff interface, including making a correction to the style of .dialog
    s within modals. The patch makes a correction to the modal markup generated by the guided reports template for SQL previews so that the modal footer displays correctly. The patch also removes CSS which makes links inside headings the same color as the heading text. The effect of this was to make links invisible in the headings of hold confirmation modals. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Test the hold confirmation modal in check-in: - Place a hold on an available title. - Check in an item from that record and confirm that the modal looks correct. The "Check in message" box should take up the whole width of the modal, and the links in the modal header should be the standard green. - Test the SQL preview modal in reports: - Go to Reports -> Use saved. - Click the actions menu associated with one of your saved reports and choose "Preview SQL." The modal should look correct. - Other modals which might be tested: MARC previews from the bibliographic detail page, the cataloging search page, the Z39.50 search page, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:23:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:23:11 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142144|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy --- Created attachment 142146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142146&action=edit Bug 31842: Fix DT search error on col.data.split Set searchable to false for opac_info. Test plan: Check if DT search for libraries works again. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy [EDIT] Reverted the data/render function change as requested by Jonathan. Considering the fact that dataTables or custom extensions do not check data.col.split as a clear bug btw. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:23:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:23:36 +0000 Subject: [Koha-bugs] [Bug 31869] Unable to save thesaurus value to frameworks subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31869 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:23:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:23:39 +0000 Subject: [Koha-bugs] [Bug 31869] Unable to save thesaurus value to frameworks subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31869 --- Comment #1 from Nick Clemens --- Created attachment 142147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142147&action=edit Bug 31869: Unable to save thesaurus value to frameworks subfields This patch correct a typo authtypecodes for authtypecode To test: 1. Edit e.g. default frameworks subfield 100$a 2. Add or change fields thesaurus value 3. Save your changes => note that on subfield listing there is no mention that 100$a is linked to any thesaurus => if you edit 100$a thesaurus input is empty 4. Apply patch 5. Edit subfield 100$a and set a thesaurus value 6. Confirm it saves and displays correctly Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:24:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:24:09 +0000 Subject: [Koha-bugs] [Bug 31869] Unable to save thesaurus value to frameworks subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31869 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Status|Needs Signoff |Signed Off Severity|enhancement |major --- Comment #2 from Nick Clemens --- Self SO, straight to QA - bad bug, easy fix -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:24:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:24:36 +0000 Subject: [Koha-bugs] [Bug 31869] Unable to save thesaurus value to frameworks subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31869 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29001, 31238 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001 [Bug 29001] Subfields attributes are not preserved when order is changed in framework https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238 [Bug 31238] Unable to save authorised value to frameworks subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:24:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:24:36 +0000 Subject: [Koha-bugs] [Bug 29001] Subfields attributes are not preserved when order is changed in framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31869 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31869 [Bug 31869] Unable to save thesaurus value to frameworks subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:24:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:24:36 +0000 Subject: [Koha-bugs] [Bug 31238] Unable to save authorised value to frameworks subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31869 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31869 [Bug 31869] Unable to save thesaurus value to frameworks subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:24:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:24:42 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142146|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy --- Created attachment 142148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142148&action=edit Bug 31842: Fix DT search error on col.data.split Set searchable to false for opac_info. Test plan: Check if DT search for libraries works again. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy [EDIT] Reverted the data/render function change as requested by Jonathan. Considering the fact that dataTables or custom extensions do not check col.data.split as a clear bug btw. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:25:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:25:06 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #15 from Marcel de Rooy --- Edited the commit message ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:29:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:29:44 +0000 Subject: [Koha-bugs] [Bug 31784] SingleBranchMode ignores public flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX --- Comment #23 from Marcel de Rooy --- I am abandoning this development. This will be consuming too much time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:29:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:29:44 +0000 Subject: [Koha-bugs] [Bug 31816] Switch singleBranchMode to singleLibraryMode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31816 Bug 31816 depends on bug 31784, which changed state. Bug 31784 Summary: SingleBranchMode ignores public flag https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:29:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:29:44 +0000 Subject: [Koha-bugs] [Bug 31817] Libraries navigation item should not display if all libaries are set to non-public In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31817 Bug 31817 depends on bug 31784, which changed state. Bug 31784 Summary: SingleBranchMode ignores public flag https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31784 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:30:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:30:12 +0000 Subject: [Koha-bugs] [Bug 31816] Switch singleBranchMode to singleLibraryMode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31816 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #1 from Marcel de Rooy --- See 31784 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:32:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:32:20 +0000 Subject: [Koha-bugs] [Bug 29314] Move some OpenURL code to Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29314 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX --- Comment #6 from Marcel de Rooy --- Closing this report. Noting that I was kind of amazed that Julian did never respond at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:33:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:33:28 +0000 Subject: [Koha-bugs] [Bug 13654] Cannot place a hold for biblio with too many items to display unless viewing them all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13654 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Failed QA |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:34:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:34:12 +0000 Subject: [Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:34:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:34:52 +0000 Subject: [Koha-bugs] [Bug 18445] Tests in t stumble over Auth's BEGIN block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18445 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:35:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:35:51 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC|m.de.rooy at rijksmuseum.nl | Assignee|m.de.rooy at rijksmuseum.nl |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:36:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:36:43 +0000 Subject: [Koha-bugs] [Bug 28705] Renewal should look at current article requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28705 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Failed QA |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:36:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:36:44 +0000 Subject: [Koha-bugs] [Bug 28767] AddReturn should also look at current article requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28767 Bug 28767 depends on bug 28705, which changed state. Bug 28705 Summary: Renewal should look at current article requests https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28705 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:42:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:42:10 +0000 Subject: [Koha-bugs] [Bug 31870] New: Cleaning up t/db_dependent/Context.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31870 Bug ID: 31870 Summary: Cleaning up t/db_dependent/Context.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 13:42:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 11:42:23 +0000 Subject: [Koha-bugs] [Bug 31870] Cleaning up t/db_dependent/Context.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31870 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 14:12:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 12:12:54 +0000 Subject: [Koha-bugs] [Bug 22972] Proposal for enriching the bibliographic records with standard identifiers from authority data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22972 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 14:17:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 12:17:57 +0000 Subject: [Koha-bugs] [Bug 31870] Cleaning up t/db_dependent/Context.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31870 --- Comment #1 from Marcel de Rooy --- Moving some work here that I intended to go with a rework of 31784. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 14:19:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 12:19:14 +0000 Subject: [Koha-bugs] [Bug 31870] Cleaning up t/db_dependent/Context.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31870 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 14:19:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 12:19:18 +0000 Subject: [Koha-bugs] [Bug 31870] Cleaning up t/db_dependent/Context.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31870 --- Comment #2 from Marcel de Rooy --- Created attachment 142149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142149&action=edit Bug 31870: Groundwork for Context.t Replacing the vars statement. Adding a larger subtest. Removing TransformVersionToNum. Test plan: Run t/db_dependent/Context.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 14:19:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 12:19:22 +0000 Subject: [Koha-bugs] [Bug 31870] Cleaning up t/db_dependent/Context.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31870 --- Comment #3 from Marcel de Rooy --- Created attachment 142150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142150&action=edit Bug 31870: Context.t: Fix indentation, remove old comments Test plan: Run test again. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 14:19:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 12:19:25 +0000 Subject: [Koha-bugs] [Bug 31870] Cleaning up t/db_dependent/Context.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31870 --- Comment #4 from Marcel de Rooy --- Created attachment 142151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142151&action=edit Bug 31870: Context.t: Reorganize subtests Move a few tests into separate subtests. Replace the BEGIN block. Test plan: Run test again. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 14:19:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 12:19:29 +0000 Subject: [Koha-bugs] [Bug 31870] Cleaning up t/db_dependent/Context.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31870 --- Comment #5 from Marcel de Rooy --- Created attachment 142152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142152&action=edit Bug 31870: Add license, remove unused modules Test plan: Run test again. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 14:20:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 12:20:03 +0000 Subject: [Koha-bugs] [Bug 31870] Cleaning up t/db_dependent/Context.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31870 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Marcel de Rooy --- Architectural + trivial, self SO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 14:32:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 12:32:27 +0000 Subject: [Koha-bugs] [Bug 31315] Remove GetItemsInfo from moredetail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stefan.berndtsson at ub.gu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 14:33:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 12:33:53 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 14:46:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 12:46:37 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #321 from Blou --- As I stated in comment 312 last month, we do not care much about performance anymore. This patch exists because it is just a better way to handle schedules and everything related to it (opening times, past fines, etc...) is a discrete (the mathematical meaning) manner. Your comments were noted years ago, we do not intend to waste any time trying to convince anyone about it. We came back to it because there seemed to be an genuine interest by some Koha users. But thank you for your reminder, I'll make sure we do not burn too much energy in the process, while still service those. We have enough patches in architecture purgatory. This patch won't be recoded to follow the latest fad. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 14:48:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 12:48:25 +0000 Subject: [Koha-bugs] [Bug 31871] New: Due date not shown on items tab Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31871 Bug ID: 31871 Summary: Due date not shown on items tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: stefan.berndtsson at ub.gu.se QA Contact: testopia at bugs.koha-community.org Bug 31315 missed one change from ITEM_DAT to checkout in moredetail.tt This trivial patch fixes that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 14:49:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 12:49:54 +0000 Subject: [Koha-bugs] [Bug 31871] Due date not shown on items tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31871 --- Comment #1 from Stefan Berndtsson --- Created attachment 142153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142153&action=edit Bug 31871: Date due not shown on items tab Changed ITEM_DAT to checkout in moredetail.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 14:50:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 12:50:34 +0000 Subject: [Koha-bugs] [Bug 31871] Due date not shown on items tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31871 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |stefan.berndtsson at ub.gu.se |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 14:51:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 12:51:52 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Eric Bégin changed: What |Removed |Added ---------------------------------------------------------------------------- CC|charles.farmer at inlibro.com, | |the-minh.luong at inlibro.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 14:54:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 12:54:08 +0000 Subject: [Koha-bugs] [Bug 12771] Enhancement to manage more than 3 levels of overdue notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12771 Eric Bégin changed: What |Removed |Added ---------------------------------------------------------------------------- CC|charles.farmer at inlibro.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 15:01:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 13:01:17 +0000 Subject: [Koha-bugs] [Bug 29480] Add email address as a method for generating the userid when self registering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Marcel de Rooy --- Please use the new style for an atomic update: use Modern::Perl; return { bug_number => "BUG_NUMBER", description => "A single line description", up => sub { my ($args) = @_; my ($dbh, $out) = @$args{qw(dbh out)}; # Do you stuffs here $dbh->do(q{}); # Print useful stuff here say $out "Update is going well so far"; }, }; See skeleton file in the atomicupdate folder. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 15:07:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 13:07:18 +0000 Subject: [Koha-bugs] [Bug 31872] New: Remove warning in cron-jobs section of the manual about needing StaticHoldsQueueWeight to use RandomizeHoldsQueueWeight Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31872 Bug ID: 31872 Summary: Remove warning in cron-jobs section of the manual about needing StaticHoldsQueueWeight to use RandomizeHoldsQueueWeight Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: emily.lamancusa at montgomerycountymd.gov QA Contact: testopia at bugs.koha-community.org Cron jobs section of the manual (https://koha-community.org/manual/22.05/en/html/cron_jobs.html#circulation) still contains the warning: "Leaving StaticHoldsQueueWeight empty is contraindicated at this time. Doing so will cause the build_holds_queue script to ignore RandomizeHoldsQueueWeight, causing the script to request hold fulfillment not randomly, but by alphabetical order." This warning was removed from other sections of the manual in bug 22846 but seems to have survived here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 15:08:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 13:08:07 +0000 Subject: [Koha-bugs] [Bug 29480] Add email address as a method for generating the userid when self registering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 --- Comment #13 from Marcel de Rooy --- Functional question about: +If PatronSelfRegistrationUseridGenerationMethod is set to 'email', the email +address will be used as the userid. If the patron being created has no email, +or the patron has an email address that is already in use by another patron, +the default way of creating the userid ($firstname.$surname) will be used. Is that really what you want? If my email address is already in the database, I probably dont want another account. One of the issues we face is actually that impatient people register 2 or 3 accounts. There is a security aspect too. You do not want to offer a way to check if an email address is present. So it might be safer to send a verification mail to the email address specified that either gives you a link to proceed or tells you that there is an account already. The OPAC could just say: check your mail, and not reveal the information. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 15:11:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 13:11:25 +0000 Subject: [Koha-bugs] [Bug 31754] Improve appearance of behavior of DataTables controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 --- Comment #7 from Owen Leonard --- Created attachment 142154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142154&action=edit Bug 31754: (follow-up) Correct alignment of buttons This patch corrects the alignment of the "Columns," "Export," and "Configure" buttons. The new design has them aligned to the right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 15:37:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 13:37:07 +0000 Subject: [Koha-bugs] [Bug 31873] New: Can't call method "safe_delete" on an undefined value at cataloguing/additem.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31873 Bug ID: 31873 Summary: Can't call method "safe_delete" on an undefined value at cataloguing/additem.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Line 379 in 21.11. Line 415 in master now. my $item = Koha::Items->find($itemnumber); my $error = $item->safe_delete; No check whatsoever. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 15:52:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 13:52:18 +0000 Subject: [Koha-bugs] [Bug 31873] Can't call method "safe_delete" on an undefined value at cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31873 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 15:52:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 13:52:23 +0000 Subject: [Koha-bugs] [Bug 31873] Can't call method "safe_delete" on an undefined value at cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31873 --- Comment #1 from Marcel de Rooy --- Created attachment 142155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142155&action=edit Bug 31873: Check ->find before calling ->safe_delete When there is no item, you cannot safely delete it :) Resolve this warning: Can't call method "safe_delete" on an undefined value at /usr/share/koha/cataloguing/additem.pl line 379 (Line numbers may vary across versions.) Test plan: Open item editor. Add a new item. Add another tab with same form. Delete new item. Go back to former tab. Try to delete again. You should see an alert now on top of the form. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 15:59:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 13:59:49 +0000 Subject: [Koha-bugs] [Bug 31856] Improve performance of serials subscriptions search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 --- Comment #3 from David Gustafsson --- Created attachment 142156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142156&action=edit Bug 31856: Don't fetch additional field valudes if there are no fields -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 16:08:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 14:08:18 +0000 Subject: [Koha-bugs] [Bug 31873] Can't call method "safe_delete" on an undefined value at cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31873 --- Comment #2 from Marcel de Rooy --- NOTE: The log file did not tell me the real reproduction scenario but the test plan should be enough to catch the point. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 16:08:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 14:08:33 +0000 Subject: [Koha-bugs] [Bug 31873] Can't call method "safe_delete" on an undefined value at cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31873 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 16:11:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 14:11:44 +0000 Subject: [Koha-bugs] [Bug 31856] Improve performance of serials subscriptions search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 --- Comment #4 from David Gustafsson --- Created attachment 142157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142157&action=edit Bug 31856: Add test for get_description_by_category_and_authorised_value -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 16:12:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 14:12:26 +0000 Subject: [Koha-bugs] [Bug 31873] Can't call method "safe_delete" on an undefined value at cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31873 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 16:13:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 14:13:28 +0000 Subject: [Koha-bugs] [Bug 31873] Can't call method "safe_delete" on an undefined value at cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31873 --- Comment #3 from Marcel de Rooy --- Note that this cannot be backported without change in 21.11 due to Boolean.pm stuff. If needed, I have a patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 16:23:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 14:23:21 +0000 Subject: [Koha-bugs] [Bug 15725] Separate permission for merging records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15725 Susan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |susan.merner at nhs.net --- Comment #1 from Susan --- I would echo this request - our regional cataloguing group would favour this to be restricted to a core group of cataloguers/system administrators. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 16:38:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 14:38:01 +0000 Subject: [Koha-bugs] [Bug 19361] Linking an authorised value category to a field in a framework can lose data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 16:38:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 14:38:07 +0000 Subject: [Koha-bugs] [Bug 19361] Linking an authorised value category to a field in a framework can lose data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67657|0 |1 is obsolete| | Attachment #67955|0 |1 is obsolete| | Attachment #105848|0 |1 is obsolete| | --- Comment #23 from Nick Clemens --- Created attachment 142158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142158&action=edit Bug 19361: Display unauthorized values when cataloging and add a warning This patch adds a warning and tool tip when an unauthorised vlaue is encountered during item or biblio editing, and adds the value to the list to allow preserving the value (in case the librarian is only editing another part of the record, or there is some reason to retain) To test: 1 - Edit a record in advanced cataloging editor 2 - Under settings click 'Show fields verbatim' 3 - Edit 942$c to 'HAM' or some other invalid itemtype 4 - Save record 5 - sudo koha-mysql kohadev UPDATE items SET location = 'HAM' WHERE biblionumber = {biblionumber from above} 6 - Edit the biblio and items, confirm the HAM value shows in dropdowns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 16:38:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 14:38:11 +0000 Subject: [Koha-bugs] [Bug 19361] Linking an authorised value category to a field in a framework can lose data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 --- Comment #24 from Nick Clemens --- Created attachment 142159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142159&action=edit Bug 19361: Fix advanced cataloging editor dropdowns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 16:38:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 14:38:54 +0000 Subject: [Koha-bugs] [Bug 19361] Linking an authorised value category to a field in a framework can lose data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #25 from Nick Clemens --- Trying to revive this - feel free to take back if you want Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 16:41:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 14:41:45 +0000 Subject: [Koha-bugs] [Bug 31858] TT syntax for ACQORDER notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31858 --- Comment #4 from Alex Arnaud --- Created attachment 142160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142160&action=edit Bug 31858: add TT syntax for ACQORDER notices Test Plan: 1) Set your ACQORDER notice content to: [%- USE Price -%] [% bookseller.name %] [% FOREACH order IN orders %] Ordernumber [% order.ordernumber %] ([% order.biblio.title %] - [% order.biblio.biblioitem.publicationyear %]) (quantity: [% order.quantity %]) ($[% order.listprice | $Price %] each). [% END %] Thank you, [% branch.branchname %] 2) Set up a vendor with an email, set contact for email so the "E-mail order" button shows on a basket for that vendor 3) E-mail the basket 4) Check the content is correct -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 16:41:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 14:41:49 +0000 Subject: [Koha-bugs] [Bug 31858] TT syntax for ACQORDER notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31858 --- Comment #5 from Alex Arnaud --- Created attachment 142161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142161&action=edit Bug 31858: unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 16:44:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 14:44:14 +0000 Subject: [Koha-bugs] [Bug 31858] TT syntax for ACQORDER notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31858 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142160|0 |1 is obsolete| | --- Comment #6 from Alex Arnaud --- Created attachment 142162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142162&action=edit Bug 31858: add TT syntax for ACQORDER notices Test Plan: 1) Set your ACQORDER notice content to: [%- USE Price -%] [% bookseller.name %] [% FOREACH order IN orders %] Ordernumber [% order.ordernumber %] ([% order.biblio.title %] - [% order.biblio.biblioitem.publicationyear %]) (quantity: [% order.quantity %]) ($[% order.listprice | $Price %] each). [% END %] Thank you, [% branch.branchname %] 2) Set up a vendor with an email, set contact for email so the "E-mail order" button shows on a basket for that vendor 3) E-mail the basket 4) Check the content is correct -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 16:44:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 14:44:18 +0000 Subject: [Koha-bugs] [Bug 31858] TT syntax for ACQORDER notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31858 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142161|0 |1 is obsolete| | --- Comment #7 from Alex Arnaud --- Created attachment 142163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142163&action=edit Bug 31858: unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 16:59:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 14:59:42 +0000 Subject: [Koha-bugs] [Bug 31813] Specify white-space: normal for spans styled as labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 --- Comment #3 from Owen Leonard --- (In reply to David Nind from comment #2) > Am I looking in the right place? Sorry I see my test plan is incorrect: The problem happens when you're viewing a batch which has been staged *and* imported. Before the import those form controls are still visible. After the import they're not and you'll see the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:00:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:00:30 +0000 Subject: [Koha-bugs] [Bug 31874] New: Enable sorting in SRU with CQL syntax Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31874 Bug ID: 31874 Summary: Enable sorting in SRU with CQL syntax Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de Doing an explain on our SRU, I see that every search option is marked with sort=false. In testing I also cannot make sorting work, following the examples here: http://www.loc.gov/standards/sru/cql/contextSets/sort-context-set.html Sorting is possible using PQF syntax with the x-pquery parameter, but it would be nice to also support the easier CQL syntax better. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:00:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:00:47 +0000 Subject: [Koha-bugs] [Bug 31874] Enable sorting in SRU with CQL syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31874 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:05:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:05:21 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141440|0 |1 is obsolete| | --- Comment #175 from Martin Renvoize --- Created attachment 142164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142164&action=edit Bug 31028: Add catalog_concerns table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:05:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:05:29 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141441|0 |1 is obsolete| | --- Comment #176 from Martin Renvoize --- Created attachment 142165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142165&action=edit Bug 31028: DBIC Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:05:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:05:35 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141442|0 |1 is obsolete| | --- Comment #177 from Martin Renvoize --- Created attachment 142166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142166&action=edit Bug 31028: Add `CatalogConcerns` and `OpacCatalogConcerns` preferences This patch adds the `CatalogConcerns` and `OpacCatalogeConcerns` system preferences to enable/disable the catalog concerns feature on the OPAC and Staff client interfaces. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:05:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:05:42 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141443|0 |1 is obsolete| | --- Comment #178 from Martin Renvoize --- Created attachment 142167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142167&action=edit Bug 31028: Add catalog concerns endpoints This patch adds the staff accessible REST API endpoints for catalog concerns. New endpoints available: * POST /catalog/concerns * GET /catalog/concerns * GET /catalog/concerns/{concern_id} * PUT /catalog/concerns/{concern_id} * DELETE /catalog/concenrs/{concern_id} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:05:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:05:50 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141444|0 |1 is obsolete| | --- Comment #179 from Martin Renvoize --- Created attachment 142168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142168&action=edit Bug 31028: Add relations to Catalog::Concern This patch adds the reporter, resolver and biblio relations to the Catalog::Concern class and exposes them to the API as appropriate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:05:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:05:57 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141445|0 |1 is obsolete| | --- Comment #180 from Martin Renvoize --- Created attachment 142169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142169&action=edit Bug 31028: Add Public API endpoint -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:06:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:06:13 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141446|0 |1 is obsolete| | --- Comment #181 from Martin Renvoize --- Created attachment 142170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142170&action=edit Bug 31028: Add 'Report a concern' to OPAC details This patch adds a new 'Report a concern' option to the right sidebar on the opac detail page. On clicking the link, a modal will display allowing the user to enter a short message regarding their concerns and then submission will record said message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:06:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:06:21 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141447|0 |1 is obsolete| | --- Comment #182 from Martin Renvoize --- Created attachment 142171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142171&action=edit Bug 31028: Trigger login modal when not logged in If the user is not logged in we should trigger the login modal in place of the report a concern modal and then use the code added in bug 31699 to redirect the user back to the current content and open the report a concern modal upon successful login. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:06:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:06:28 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141448|0 |1 is obsolete| | --- Comment #183 from Martin Renvoize --- Created attachment 142172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142172&action=edit Bug 31028: Add a catalog concerns management page This patch adds a new cataloguing concerns page to the staff client for managing reported catalog concerns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:06:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:06:35 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141449|0 |1 is obsolete| | --- Comment #184 from Martin Renvoize --- Created attachment 142173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142173&action=edit Bug 31028: Add 'special:undefined' to handle passing 'null' We can't pass 'null' to the column.search as it gets stringified. This patch adds a special string 'special:undefined' to denote that we want to search on undef for the field in question. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:06:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:06:42 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141450|0 |1 is obsolete| | --- Comment #185 from Martin Renvoize --- Created attachment 142174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142174&action=edit Bug 31028: Add filters to concerns management -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:06:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:06:46 +0000 Subject: [Koha-bugs] [Bug 27920] Add ability to update patron expiration dates when importing patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:06:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:06:50 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141451|0 |1 is obsolete| | --- Comment #186 from Martin Renvoize --- Created attachment 142175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142175&action=edit Bug 31028: Add resolution endpoint This patch adds a /resolve endpoint to the catalog concerns endpoints. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:06:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:06:52 +0000 Subject: [Koha-bugs] [Bug 27920] Add ability to update patron expiration dates when importing patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 --- Comment #20 from Kyle M Hall --- Created attachment 142176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142176&action=edit Bug 27920: (QA follow-up) Change radios to a single select pulldown -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:06:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:06:59 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141452|0 |1 is obsolete| | --- Comment #187 from Martin Renvoize --- Created attachment 142177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142177&action=edit Bug 31028: Add resolve action This patch adds a resolution workflow to the catalog concerns management page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:07:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:07:05 +0000 Subject: [Koha-bugs] [Bug 27920] Add ability to update patron expiration dates when importing patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 --- Comment #21 from Kyle M Hall --- Created attachment 142178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142178&action=edit Bug 27920: (QA follow-up) Fix POD in cli tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:07:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:07:06 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141453|0 |1 is obsolete| | --- Comment #188 from Martin Renvoize --- Created attachment 142179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142179&action=edit Bug 31028: Add 'Add catalog concern' to cataloguing toolbar This patch moves the add concern modal js and template markup into their own files and then references them to add the 'Add concern' option to the cataloguing toolbar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:07:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:07:13 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141454|0 |1 is obsolete| | --- Comment #189 from Martin Renvoize --- Created attachment 142180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142180&action=edit Bug 31028: Add notice trigger for catalog concerns This patch adds a new system prefernce, `CatalogerEmails`. If set with a valid email address adding a new catalog concern should produce a notification email sent to that address. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:07:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:07:20 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141455|0 |1 is obsolete| | --- Comment #190 from Martin Renvoize --- Created attachment 142181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142181&action=edit Bug 31028: Add trigger and notice to resolve This patch adds a sample notice and sets up the trigger to notify the concern reporter when a concern is marked as resolved. The notification itself is optional at resolve time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:07:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:07:41 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141456|0 |1 is obsolete| | --- Comment #191 from Martin Renvoize --- Created attachment 142182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142182&action=edit Bug 31028: (QA follow-up) This is a 'tool' At the moment, this feature is accessible under tools rather than cataloging. Whilst we await the new cataloging homepage and sidebar this patch replaces the breadcrumb and title with 'Tools', replaces the 'cat-menu' include with 'tools-menu' and adds the 'Catalog concerns' tool to the tools-menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:07:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:07:49 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141457|0 |1 is obsolete| | --- Comment #192 from Martin Renvoize --- Created attachment 142183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142183&action=edit Bug 31028: (QA follow-up) Table configuration This patch properly adds the table configuration options to the catalog concerns table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:07:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:07:55 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141458|0 |1 is obsolete| | --- Comment #193 from Martin Renvoize --- Created attachment 142184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142184&action=edit Bug 31028: Use additional_contents for help block This patch updates the modal to use the additional_contents system for the modals help block -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:08:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:08:02 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141459|0 |1 is obsolete| | --- Comment #194 from Martin Renvoize --- Created attachment 142185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142185&action=edit Bug 31028: Add concerns tab to biblio details display This patch adds a 'Concerns' tab to the catalogue/detail display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:08:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:08:12 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141460|0 |1 is obsolete| | --- Comment #195 from Martin Renvoize --- Created attachment 142186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142186&action=edit Bug 31028: Crosslink preferences This patch adds crosslinks to the CatalogConcerns and OpacCatalogConcerns system preferences. We also slightly update the wording of OpacCatalogConcerns to clarify intent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:08:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:08:20 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #196 from Martin Renvoize --- Created attachment 142187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142187&action=edit Bug 31028: Add input template This patch adds an example 'CatalogConcernTemplate' to allow pre-population of the catalog concern report text area modal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:08:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:08:26 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #197 from Martin Renvoize --- Created attachment 142188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142188&action=edit Bug 31028: Add acknowledgement notification This patch adds an acknowledgement notification to acknowledge to the patron via email that we have received their catalog concern report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:08:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:08:32 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #198 from Martin Renvoize --- Created attachment 142189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142189&action=edit Bug 31028: Add page-section to concerns management page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:08:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:08:38 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #199 from Martin Renvoize --- Created attachment 142190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142190&action=edit Bug 31028: Move back to cataloging from tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:08:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:08:45 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #200 from Martin Renvoize --- Created attachment 142191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142191&action=edit Bug 31028: Add `wrapfix` class rule to set pre-wrap on content This patch adds a `wrapfix` css class that sets the 'white-space: pre-wrap' rule and applies it to the message content of our catalog concerns allowing multi-line reports to display properly in the table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:10:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:10:44 +0000 Subject: [Koha-bugs] [Bug 27920] Add ability to update patron expiration dates when importing patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 --- Comment #22 from Kyle M Hall --- > 1) Unit test I'm not getting that warning. Can you see if it's still there for you? > 2) GUI I've added a following to unify the options into a single pulldown menu. This feels more unified and clear to me. What do you think? > 3) Test plan Test Plan: 1) Create a patron CSV file with a datexpiry column 2) Apply this patch 3) Restart all the things 4) Upload your file, choose to overwrite existing patrons, test with each of the 3 dateexpiry options, verify each performs correctly! > 4) CLI Fixed with another followup! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:32:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:32:19 +0000 Subject: [Koha-bugs] [Bug 31861] Table controls on checkouts table are buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Depends on| |31754 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 [Bug 31754] Improve appearance of behavior of DataTables controls -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:32:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:32:19 +0000 Subject: [Koha-bugs] [Bug 31754] Improve appearance of behavior of DataTables controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31861 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 [Bug 31861] Table controls on checkouts table are buttons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:45:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:45:12 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141141|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 17:50:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 15:50:53 +0000 Subject: [Koha-bugs] [Bug 31875] New: Reserved words as authorised_values cause search error in Elasticsearch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31875 Bug ID: 31875 Summary: Reserved words as authorised_values cause search error in Elasticsearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com This is bug 31013 but for things like 'LOC' authorised values Set a value in LOC for 'OR' description 'Oregon' Add a few items to this location Search returning those items Try to facet by location - no results -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 18:06:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 16:06:20 +0000 Subject: [Koha-bugs] [Bug 31876] New: Capitalization: Click to Expand this Tag Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31876 Bug ID: 31876 Summary: Capitalization: Click to Expand this Tag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The string "Click to Expand this Tag" appears in addbiblio.tt a couple of times. It should be "Click to expand this tag". To get to the string for the staff interface: 1. In the staff interface, go to Cataloging 2. Click "New record" 3. Hover the mouse cursor over one of the tag titles (e.g. CONTROL NUMBER) --> a little popup thing (tooltip?) appears with "Click to Expand this Tag" 4. Go to Administration > Global system preferences 5. Search for advancedMARCeditor 6. Change the value to "Don't show" 7. Click "Save all Cataloging preferences" 8. Go back to Cataloging > New record 9. Hover the mouse cursor over the tag number (e.g. 001) --> a little popup thing (tooltip?) appears with " Click to Expand this Tag" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 18:06:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 16:06:46 +0000 Subject: [Koha-bugs] [Bug 31876] Capitalization: Click to Expand this Tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31876 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 18:09:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 16:09:01 +0000 Subject: [Koha-bugs] [Bug 31861] Table controls on checkouts table are buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 18:09:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 16:09:05 +0000 Subject: [Koha-bugs] [Bug 31861] Table controls on checkouts table are buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 --- Comment #1 from Owen Leonard --- Created attachment 142192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142192&action=edit Bug 31861: Table controls on checkouts table are buttons This patch updates the style of DataTables buttons (columns, export, and configure), in cases where the buttons are the only control being displayed (no page controls, filter, etc). To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Circulation and check an item out to a patron. - If necessary, click the "Show checkouts" button to reveal the table of checkouts. - The "Columns," "Export," and "Configure" controls should look the same as they do in other situations, with no button-style border. - Go to Circulation -> Check in and check in the item. The table of checked-in items should show the same style controls. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 18:19:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 16:19:16 +0000 Subject: [Koha-bugs] [Bug 31877] New: Capitalization: Delete this Tag Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31877 Bug ID: 31877 Summary: Capitalization: Delete this Tag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The string "Delete this Tag" appears in addbiblio.tt a couple of times. It should be "Delete this tag". To get to the string in the staff interface: 1. In the staff interface, go to Cataloging 2. Click "New record" 3. Hover the mouse cursor over one of the delete tag buttons (rectangle with a small x next to the tag title) --> a little popup thing (tooltip?) appears with "Delete this Tag" 4. Open the developper tools inspector in your browser 5. Click on the delete tag button --> the image alt text is "Delete this Tag" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 18:19:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 16:19:30 +0000 Subject: [Koha-bugs] [Bug 31877] Capitalization: Delete this Tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31877 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 18:27:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 16:27:59 +0000 Subject: [Koha-bugs] [Bug 31878] New: Capitalization: Repeat this Tag Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31878 Bug ID: 31878 Summary: Capitalization: Repeat this Tag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The string "Repeat this Tag" appears in addbiblio.tt a couple of times. It should be "Repeat this tag". To get to the string in the staff interface: 1. In the staff interface, go to Cataloging 2. Click "New record" 3. Hover the mouse cursor over one of the duplicate tag buttons (two rectangles next to the tag title, e.g. next to 020 in MARC21) --> a little popup thing (tooltip?) appears with "Repeat this Tag" 4. Open the developper tools inspector in your browser 5. Click on the duplicate tag button --> the image alt text is "Repeat this Tag" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 18:28:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 16:28:08 +0000 Subject: [Koha-bugs] [Bug 31878] Capitalization: Repeat this Tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31878 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 18:43:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 16:43:18 +0000 Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 18:43:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 16:43:22 +0000 Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138137|0 |1 is obsolete| | Attachment #138138|0 |1 is obsolete| | Attachment #138139|0 |1 is obsolete| | --- Comment #25 from Owen Leonard --- Created attachment 142193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142193&action=edit Bug 28307: Make BakerTaylorEnabled preference separate for staff and OPAC This patch updates the system preferences controlling Baker & Taylor content so that there are separate preferences for the OPAC and the staff interface. The patch also adds Baker & Taylor cover images to the staff client. To test, apply the patch and run the database update. - Go to Admnistration -> System preferences -> Enhanced content - You should see a BakerTaylorEnabled and a OPACBakerTaylorEnabled preference. The OPACBakerTaylorEnabled should have the same setting you previously had for BakerTaylorEnabled. The BakerTaylorEnabled preference should be turned off. - Note that the description of the preferences have been updated to include links to the Baker & Taylor username and password preferences. - Enable both and make sure you have a valid Baker & Taylor username and password entered. - Perform a search in both the OPAC and staff interface. A Baker & Taylor cover image should appear on the bibliographic detail page in the OPAC, and on the search results and bibliographic detail page in the staff interface. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 18:43:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 16:43:27 +0000 Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #26 from Owen Leonard --- Created attachment 142194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142194&action=edit Bug 28307: (follow-up) Add proper check for BakerTaylorEnabled This patch adds a missing check for the BakerTaylorEnabled system preference in staff interface search results. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 18:43:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 16:43:33 +0000 Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #27 from Owen Leonard --- Created attachment 142195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142195&action=edit Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled This patch adds the new OPACBakerTaylorEnabled preferences to OPAC templates and scripts which were missed in the first patch. The patch also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql. Check these pages in the OPAC: - Catalog -> Search results - And search results -> RSS - Catalog -> Bibliographic details page -> Shelf browser - Catalog -> Lists -> List contents - Catalog -> Recent comments - And recent comments -> RSS - Your summary -> Checkouts and Overdues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 18:44:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 16:44:31 +0000 Subject: [Koha-bugs] [Bug 31866] Catalog update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31866 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Owen Leonard --- This sounds like a support request rather than a bug. Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Hopefully you've already seen the Koha documentation: http://koha-community.org/documentation/ You can also find options for paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 19:16:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 17:16:38 +0000 Subject: [Koha-bugs] [Bug 28896] Checkin Slip doesn't work for anonymized checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28896 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 19:24:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 17:24:31 +0000 Subject: [Koha-bugs] [Bug 31813] Specify white-space: normal for spans styled as labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 19:24:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 17:24:36 +0000 Subject: [Koha-bugs] [Bug 31813] Specify white-space: normal for spans styled as labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142081|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 142196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142196&action=edit Bug 31813: Specify white-space: normal for spans styled as labels This patch is necessary to override a CSS property being inherited from Bootstrap. Allowing a with the "label" class to wrap will keep alignment correct when displaying information in the same layout as a form. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - If necessary, stage a batch of MARC files (Cataloging -> Stage MARC records for import). - Go to Cataloging -> Manage staged MARC records and click on one of the batches to view the details. - In the list of information about the batch, longer labels like "Matching rule applied" should wrap so that they stay aligned with other labels in the list. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 19:24:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 17:24:42 +0000 Subject: [Koha-bugs] [Bug 31813] Specify white-space: normal for spans styled as labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 --- Comment #5 from David Nind --- Created attachment 142197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142197&action=edit Bug 31813: (follow-up) Add missing colon for managed staged MARC records Add colon after "Matching rule applied" when viewing details for a batch already imported. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 19:26:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 17:26:05 +0000 Subject: [Koha-bugs] [Bug 31813] Specify white-space: normal for spans styled as labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 --- Comment #6 from David Nind --- (In reply to Owen Leonard from comment #3) > Sorry I see my test plan is incorrect: The problem happens when you're > viewing a batch which has been staged *and* imported. Before the import > those form controls are still visible. After the import they're not and > you'll see the issue. Thanks Owen! I can see it now. I added a follow-up for the missing colon - happy to add to another bug if this preferred. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 20:43:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 18:43:03 +0000 Subject: [Koha-bugs] [Bug 31861] Table controls on checkouts table are buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 20:43:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 18:43:09 +0000 Subject: [Koha-bugs] [Bug 31861] Table controls on checkouts table are buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142192|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142198&action=edit Bug 31861: Table controls on checkouts table are buttons This patch updates the style of DataTables buttons (columns, export, and configure), in cases where the buttons are the only control being displayed (no page controls, filter, etc). To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Circulation and check an item out to a patron. - If necessary, click the "Show checkouts" button to reveal the table of checkouts. - The "Columns," "Export," and "Configure" controls should look the same as they do in other situations, with no button-style border. - Go to Circulation -> Check in and check in the item. The table of checked-in items should show the same style controls. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 20:43:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 18:43:46 +0000 Subject: [Koha-bugs] [Bug 31879] New: Convert mainpage.css to SCSS Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31879 Bug ID: 31879 Summary: Convert mainpage.css to SCSS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Now that we are making more use of SCSS variables it would be efficient to be able to use them in mainpage.css where some common colors are specified. Plus any additional auto-minification we can do is helpful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 20:44:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 18:44:09 +0000 Subject: [Koha-bugs] [Bug 31880] New: "Go to field" link in MARC validation goes nowhere if field not in the same tab Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31880 Bug ID: 31880 Summary: "Go to field" link in MARC validation goes nowhere if field not in the same tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl I'm having trouble with the "Go to field" link when you don't fill in a mandatory field when cataloging. Normally, it takes you to the field, but now it doesn't seem to do anything if the field is not in the current tab... To test: (Note: I did this with the default framework in MARC21, when I refer to fields, they are MARC21 fields and they are mandatory by default in the default framework) 1. Go to Cataloging > New record 2. Click "Save" without filling anything out --> You should get a bunch of warnings about mandatory fields that are not filled 3. Click "Go to field" next to the 245$a error --> Nothing happens 4. Click "Go to field" next to the 040$c error --> You are taken to 040$c 5. Click on tab 2 6. Click Save again (not sure it's necessary) 7. Redo step 3 --> You are taken to 245$a 8. Redo step 4 --> Nothing happens -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 20:56:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 18:56:48 +0000 Subject: [Koha-bugs] [Bug 31879] Convert mainpage.css to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31879 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 20:56:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 18:56:52 +0000 Subject: [Koha-bugs] [Bug 31879] Convert mainpage.css to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31879 --- Comment #1 from Owen Leonard --- Created attachment 142199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142199&action=edit Bug 31879: Convert mainpage.css to SCSS This patch creates a new SCSS file to be used to generate mainpage.css, the stylesheet used specifically for the staff interface home page. The patch makes visible changes in only two places: Removing borders from two elements to make them consistent with the new staff interface design: - div.pending-info, where pending actions like patrons requesting modifications are shown. - div#area-userblock, where the contents of the IntranetmainUserblock system preference are displayed. Otherwise the changes are all for the purpose of properly nesting elements according to SCSS rules and other fixes related to stylelint rules. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View the main page of the staff interface. Everything should look like it did before except for those elements which have had their borders removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 20:57:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 18:57:28 +0000 Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141420|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 142200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142200&action=edit Bug 31699: Add 'return' option to opac modal login This patch adds the option to trigger a redirect back to the current context after successful login using modal logins triggered from various places in the OPAC. To make use of this, simply add 'data-return="true"' to the modal trigger link. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 20:57:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 18:57:32 +0000 Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141421|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 142201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142201&action=edit Bug 31699: Impliment modal context return on opac-detail. This patch utilises the generic return option introduced in the previous patch to prevent lose of context when clicking to login to add a comment to a biblio. Test plan 1/ Test that prior to this patch, upon clicking 'Log in to your account to post a comment' you are redirected to opac-user.pl and thus loose your context. 2/ Apply the patch 3/ Confirm that a login using the 'Log in to your account to post a comment' link now redirect immediatly back the correct record and thus maintains context. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 20:58:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 18:58:52 +0000 Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Martin Renvoize --- Thanks for testing David.. something wierd had crept in.. I've amended the patch (checking for boolean truthyness instead of comparing to a string) and now it appears to be working again for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 20:59:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 18:59:28 +0000 Subject: [Koha-bugs] [Bug 31753] Dialog boxes inside of modals don't seem wide enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 20:59:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 18:59:32 +0000 Subject: [Koha-bugs] [Bug 31753] Dialog boxes inside of modals don't seem wide enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142145|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 142202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142202&action=edit Bug 31753: Dialog boxes inside of modals don't seem wide enough This patch makes some tweaks to the style of Bootstrap modals in the staff interface, including making a correction to the style of .dialog
    s within modals. The patch makes a correction to the modal markup generated by the guided reports template for SQL previews so that the modal footer displays correctly. The patch also removes CSS which makes links inside headings the same color as the heading text. The effect of this was to make links invisible in the headings of hold confirmation modals. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Test the hold confirmation modal in check-in: - Place a hold on an available title. - Check in an item from that record and confirm that the modal looks correct. The "Check in message" box should take up the whole width of the modal, and the links in the modal header should be the standard green. - Test the SQL preview modal in reports: - Go to Reports -> Use saved. - Click the actions menu associated with one of your saved reports and choose "Preview SQL." The modal should look correct. - Other modals which might be tested: MARC previews from the bibliographic detail page, the cataloging search page, the Z39.50 search page, etc. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 21:00:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 19:00:54 +0000 Subject: [Koha-bugs] [Bug 31753] Dialog boxes inside of modals don't seem wide enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind --- I think I somewhat preferred the lighter green for the headers/footers for the modal windows... 8-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 21:07:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 19:07:37 +0000 Subject: [Koha-bugs] [Bug 31879] Convert mainpage.css to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31879 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 21:07:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 19:07:42 +0000 Subject: [Koha-bugs] [Bug 31879] Convert mainpage.css to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31879 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142199|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142203&action=edit Bug 31879: Convert mainpage.css to SCSS This patch creates a new SCSS file to be used to generate mainpage.css, the stylesheet used specifically for the staff interface home page. The patch makes visible changes in only two places: Removing borders from two elements to make them consistent with the new staff interface design: - div.pending-info, where pending actions like patrons requesting modifications are shown. - div#area-userblock, where the contents of the IntranetmainUserblock system preference are displayed. Otherwise the changes are all for the purpose of properly nesting elements according to SCSS rules and other fixes related to stylelint rules. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View the main page of the staff interface. Everything should look like it did before except for those elements which have had their borders removed. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 21:12:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 19:12:55 +0000 Subject: [Koha-bugs] [Bug 31879] Convert mainpage.css to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31879 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes (using koha-testing-docker): - Added a purchase suggestion to show the pending area. - Added some text to IntranetmainUserblock system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 21:13:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 19:13:07 +0000 Subject: [Koha-bugs] [Bug 28694] Check alert in cataloguing should be a static message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/596 Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 21:18:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 19:18:55 +0000 Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 21:18:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 19:18:58 +0000 Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142200|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 142204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142204&action=edit Bug 31699: Add 'return' option to opac modal login This patch adds the option to trigger a redirect back to the current context after successful login using modal logins triggered from various places in the OPAC. To make use of this, simply add 'data-return="true"' to the modal trigger link. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 21:19:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 19:19:03 +0000 Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142201|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 142205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142205&action=edit Bug 31699: Impliment modal context return on opac-detail. This patch utilises the generic return option introduced in the previous patch to prevent lose of context when clicking to login to add a comment to a biblio. Test plan 1/ Test that prior to this patch, upon clicking 'Log in to your account to post a comment' you are redirected to opac-user.pl and thus loose your context. 2/ Apply the patch 3/ Confirm that a login using the 'Log in to your account to post a comment' link now redirect immediatly back the correct record and thus maintains context. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 21:20:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 19:20:50 +0000 Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 --- Comment #9 from David Nind --- (In reply to Martin Renvoize from comment #6) > Thanks for testing David.. something wierd had crept in.. I've amended the > patch (checking for boolean truthyness instead of comparing to a string) and > now it appears to be working again for me. Thanks Martin - this now works. I'm redirected back to the details page for the record I was viewing (but not the comments tab). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 21:27:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 19:27:07 +0000 Subject: [Koha-bugs] [Bug 29358] Allow local definition of staff client's 'View in OPAC' links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29358 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula at hypernova.fi --- Comment #1 from Lari Taskula --- +1 We've also ran into this issue with shared lists https://github.com/Koha-Community/Koha/blob/b2fdd8f745f77a52d00ffffdfea8dd60dc33f462/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/sendshelf.tt#L146 If we used a system preference to control these links, what would be the best format? YAML? Example OPACLinks (default): --- xslt_MARC21slim2intranetDetail_opac_view: "{{OPACBaseURL|raw}}/cgi-bin/koha/opac-detail.pl?biblionumber={{biblionumber}}" virtualshelves_sendshelf: "{{OPACBaseURL|raw}}/cgi-bin/koha/opac-detail.pl?biblionumber={{BIBLIO_RESULT.biblionumber|html}}" OPACLinks (customized) --- xslt_MARC21slim2intranetDetail_opac_view: "https://another_frontend/record/{{biblionumber}}" virtualshelves_sendshelf: "https://another_frontend/record/{{BIBLIO_RESULT.biblionumber|html}}" There are probably plenty of such locations so we have to identify those. Shall we open a new Bug for each of them and consider this Bug omnibus? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 21:34:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 19:34:51 +0000 Subject: [Koha-bugs] [Bug 31873] Can't call method "safe_delete" on an undefined value at cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31873 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 21:34:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 19:34:55 +0000 Subject: [Koha-bugs] [Bug 31873] Can't call method "safe_delete" on an undefined value at cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31873 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142155|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 142206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142206&action=edit Bug 31873: Check ->find before calling ->safe_delete When there is no item, you cannot safely delete it :) Resolve this warning: Can't call method "safe_delete" on an undefined value at /usr/share/koha/cataloguing/additem.pl line 379 (Line numbers may vary across versions.) Test plan: Open item editor. Add a new item. Add another tab with same form. Delete new item. Go back to former tab. Try to delete again. You should see an alert now on top of the form. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind https://bugs.koha-community.org/show_bug.cgi?id=31783 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 21:46:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 19:46:43 +0000 Subject: [Koha-bugs] [Bug 31871] Due date not shown on items tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31871 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 21:46:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 19:46:47 +0000 Subject: [Koha-bugs] [Bug 31871] Due date not shown on items tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31871 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142153|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142207&action=edit Bug 31871: Date due not shown on items tab Changed ITEM_DAT to checkout in moredetail.tt Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 21:47:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 19:47:48 +0000 Subject: [Koha-bugs] [Bug 19361] Linking an authorised value category to a field in a framework can lose data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 21:47:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 19:47:52 +0000 Subject: [Koha-bugs] [Bug 19361] Linking an authorised value category to a field in a framework can lose data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142158|0 |1 is obsolete| | --- Comment #26 from Andrew Fuerste-Henry --- Created attachment 142208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142208&action=edit Bug 19361: Display unauthorized values when cataloging and add a warning This patch adds a warning and tool tip when an unauthorised vlaue is encountered during item or biblio editing, and adds the value to the list to allow preserving the value (in case the librarian is only editing another part of the record, or there is some reason to retain) To test: 1 - Edit a record in advanced cataloging editor 2 - Under settings click 'Show fields verbatim' 3 - Edit 942$c to 'HAM' or some other invalid itemtype 4 - Save record 5 - sudo koha-mysql kohadev UPDATE items SET location = 'HAM' WHERE biblionumber = {biblionumber from above} 6 - Edit the biblio and items, confirm the HAM value shows in dropdowns Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 21:47:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 19:47:57 +0000 Subject: [Koha-bugs] [Bug 19361] Linking an authorised value category to a field in a framework can lose data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142159|0 |1 is obsolete| | --- Comment #27 from Andrew Fuerste-Henry --- Created attachment 142209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142209&action=edit Bug 19361: Fix advanced cataloging editor dropdowns Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 21:48:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 19:48:08 +0000 Subject: [Koha-bugs] [Bug 31863] Advanced cataloging editor no longer auto-resizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 --- Comment #5 from Lucas Gass --- (In reply to David Nind from comment #4) > Thanks Lucas! I had noticed yesterday when testing another bug, but hadn't > yet logged a bug. > > After installing a language, I noticed that the titles for records aren't > displayed in the search results after switching to the language in the staff > interface and OPAC (even after a reindex). > > I'm sure it hasn't done that in the past... so maybe another staff interface > bug? Hey David, Thanks for testing. I am unable to reproduce this problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 21:48:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 19:48:44 +0000 Subject: [Koha-bugs] [Bug 31871] Due date not shown on items tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31871 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes (using koha-testing-docker): 1. Check out an item to a patron. 2. Go to the details page for the record and select the items section. 3. Under statuses, for 'Checkout status' there is no date after 'Due back on' (for example: Checkout status: Checked out to Mary Burton (23529000651225) Due back on ). 4. Apply the patch. 5. Refresh the page - the due date is now displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 21:56:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 19:56:32 +0000 Subject: [Koha-bugs] [Bug 31863] Advanced cataloging editor no longer auto-resizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 --- Comment #6 from David Nind --- (In reply to Lucas Gass from comment #5) > (In reply to David Nind from comment #4) > > Thanks Lucas! I had noticed yesterday when testing another bug, but hadn't > > yet logged a bug. > > > > After installing a language, I noticed that the titles for records aren't > > displayed in the search results after switching to the language in the staff > > interface and OPAC (even after a reindex). > > > > I'm sure it hasn't done that in the past... so maybe another staff interface > > bug? > > Hey David, > > Thanks for testing. I am unable to reproduce this problem. Katrin said on IRC that this sometimes happens with translations (was for fr-CA), so is not a staff interface related bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 22:08:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 20:08:14 +0000 Subject: [Koha-bugs] [Bug 24679] Allow to apply a MARC modification template in export tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24679 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin Somers --- Up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 22:27:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 20:27:05 +0000 Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 22:28:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 20:28:04 +0000 Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 142210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142210&action=edit Bug 31115: Add support for additional fields for invoices This patch adds support for additional fields for invoices. A new option is added to the 'Additional fields' admin page, for the 'aqinvoices' table. Adding/editing invoices now supports this additional fields. To test: 1. Apply this patches 2. Verify the original test plan works => SUCCESS: It does! 3. Sign off :-D Sponsored-by: The Research University in the Helmholtz Association (KIT) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 22:28:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 20:28:09 +0000 Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 142211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142211&action=edit Bug 31115: Add invoice fields manage link This patch adds a link on the acquisitions page for reaching the additional fields config for invoices in an easy way. Sponsored-by: The Research University in the Helmholtz Association (KIT) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 22:28:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 20:28:14 +0000 Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 142212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142212&action=edit Bug 31115: Add additional_attributes support to GetInvoices This patch adds support for searching additional_fields when retrieving invoices using C4::Acquisition::Invoices. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Acquisition.t => SUCCESS: Tests pass! 3. Sign off :-D Sponsored-by: The Research University in the Helmholtz Association (KIT) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 22:28:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 20:28:19 +0000 Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 142213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142213&action=edit Bug 31115: Add additional field filtering for invoice search This patch adds support for filtering invoice searches on additional fields. To test: 1. Generate additional fields for invoices 2. Have invoices with additional fields 3. Use invoice searching and play with filtering by additional fields. => SUCCESS: It works! 4. Sign off :-D Sponsored-by: The Research University in the Helmholtz Association (KIT) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 23:25:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 21:25:54 +0000 Subject: [Koha-bugs] [Bug 31881] New: Link in MARC view does not work Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 Bug ID: 31881 Summary: Link in MARC view does not work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In framework a subfield can be defined with a link (with a search field). This create an hyperlink in MARC view. Currently the link does not work because search query contains 'field,phr:', which is useless since the link contains 'idx=field,phr' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 19 23:26:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 21:26:02 +0000 Subject: [Koha-bugs] [Bug 31881] Link in MARC view does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 00:06:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 22:06:14 +0000 Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 00:19:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 22:19:14 +0000 Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 00:30:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 22:30:17 +0000 Subject: [Koha-bugs] [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 --- Comment #3 from Lucas Gass --- Created attachment 142214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142214&action=edit Bug 31864: (follow-up) Fix breadcrumbs in batchMod and batch_record_mod -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 00:33:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 22:33:55 +0000 Subject: [Koha-bugs] [Bug 31882] New: Fix page title of pages in the new cataloging module home page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31882 Bug ID: 31882 Summary: Fix page title of pages in the new cataloging module home page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 31162 Pages that were moved from Tools to Cataloging in Bug 31162 should have their page titles corrected. For example: Batch record modification › Tools › Koha Should become: Batch record modification › Cataloging › Koha Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 [Bug 31162] Add a clear cataloguing module home page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 00:33:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 22:33:55 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31882 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31882 [Bug 31882] Fix page title of pages in the new cataloging module home page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 00:34:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 22:34:13 +0000 Subject: [Koha-bugs] [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 --- Comment #4 from Lucas Gass --- Thanks David! I filed Bug 31882. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 00:47:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 22:47:09 +0000 Subject: [Koha-bugs] [Bug 31829] Change password form in patron account is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31829 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 00:47:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 22:47:36 +0000 Subject: [Koha-bugs] [Bug 31829] Change password form in patron account is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31829 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 00:47:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 22:47:39 +0000 Subject: [Koha-bugs] [Bug 31829] Change password form in patron account is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31829 --- Comment #1 from Lucas Gass --- Created attachment 142215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142215&action=edit Bug 31829: Fix change password form alignment This patch gives the fieldset on member-password.tt the class row. It also moves the hints below the list. To test: 1. Apply patch 2. Pull up a patron record and go to 'Change password'. 3. Make sure the form now looks good. 4. Also check and make sure the form is still functional. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 00:55:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 22:55:33 +0000 Subject: [Koha-bugs] [Bug 31830] Add page-section to budgets and funds table on acq start page (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31830 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 00:55:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 22:55:37 +0000 Subject: [Koha-bugs] [Bug 31830] Add page-section to budgets and funds table on acq start page (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31830 --- Comment #1 from Lucas Gass --- Created attachment 142216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142216&action=edit Bug 31830: Add page-section class to acq home table To test: 1. Go to the Acquisitions home page. 2. Look and the bugdets and funds table and notice the page-section class. 3. Make sure everything looks good. Note: I made some indentation changes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 00:55:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 22:55:54 +0000 Subject: [Koha-bugs] [Bug 31830] Add page-section to budgets and funds table on acq start page (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31830 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | CC| |lucas at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 01:10:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 23:10:32 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to batch record deletion (tools) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 01:10:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 23:10:35 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to batch record deletion (tools) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 --- Comment #1 from Lucas Gass --- Created attachment 142217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142217&action=edit Bug 31837: Add page-section class to tables on basket.tt This patch adds the page-section class to the orders and cancelled orders tables. To test: 1. Have a vendor, basket, and create an order. 2. Go look at the table on basket.tt and make sure the orders table looks good. 3. Cancel some orders and look at the cancelled order table, make sure it also looks good. Note: I made some indentation changes. I also did NOT add a new wrapper to the cancelled orders table, it already had one so I just added the page-section div to the existing div. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 01:14:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Oct 2022 23:14:19 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to basket.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add page-section to batch |Add page-section to |record deletion (tools) |basket.tt Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | CC| |lucas at bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 02:27:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 00:27:00 +0000 Subject: [Koha-bugs] [Bug 31883] New: t::lib::QA::TemplateFilters missing built-in TT filter "trim" causes false warnings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 Bug ID: 31883 Summary: t::lib::QA::TemplateFilters missing built-in TT filter "trim" causes false warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org info coming... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 02:33:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 00:33:26 +0000 Subject: [Koha-bugs] [Bug 31883] t::lib::QA::TemplateFilters missing built-in TT filter "trim" causes false warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 --- Comment #1 from Mason James --- Created attachment 142218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142218&action=edit Bug 31883: t::lib::QA::TemplateFilters missing built-in TT filter "trim" causes false warnings to test... 1/ checkout latest master 2/ prove xt/find-missing-filters.t xt/find-missing-filters.t .. 1/1 # Failed test 'Template variables should be correctly escaped' # at xt/find-missing-filters.t line 59. # got: '1' # expected: '0' # $VAR1 = { # 'errors' => [ # { # 'error' => 'missing_filter', # 'line' => ' [% messages = INCLUDE \'patron_messages.inc\' moremember = 1 | trim %]', # 'line_number' => 97 # } # ], # 'file' => 'koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt' # }; # Looks like you failed 1 test of 1. 3/ apply patch 4/ prove xt/find-missing-filters.t xt/find-missing-filters.t .. ok All tests successful. Files=1, Tests=1, 2 wallclock secs ( 0.03 usr 0.01 sys + 2.15 cusr 0.07 csys = 2.26 CPU) Result: PASS <<<<<<<<<<<<<<< -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 02:34:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 00:34:20 +0000 Subject: [Koha-bugs] [Bug 31883] t::lib::QA::TemplateFilters missing built-in TT filter "trim" causes false warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Priority|P5 - low |P1 - high CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 02:34:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 00:34:32 +0000 Subject: [Koha-bugs] [Bug 31883] t::lib::QA::TemplateFilters missing built-in TT filter "trim" causes false warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 03:03:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 01:03:37 +0000 Subject: [Koha-bugs] [Bug 31881] Link in MARC view does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 03:03:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 01:03:41 +0000 Subject: [Koha-bugs] [Bug 31881] Link in MARC view does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 --- Comment #1 from Fridolin Somers --- Created attachment 142219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142219&action=edit Bug 31881: Fix search link in MARC view In framework a subfield can be defined with a link (with a search field). This create an hyperlink in MARC view. Currently with Elasticsearch the link does not work because search query contains 'field,phr:', which is useless since the link contains 'idx=field,phr'. With Zebra looks like the idx param is ignored. Test plan : 1) Use Elasticsearch search engine 2) Edit subfield 245$a in default framework 3) Enter 'title' in 'Link' 4) Save 5) Create a record with default framework with 245$a = 'The Fifth Elephant' 6) Go to MARC view 7) Click on link in 245$a 8) You find the record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 03:05:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 01:05:53 +0000 Subject: [Koha-bugs] [Bug 31883] t::lib::QA::TemplateFilters missing built-in TT filter "trim" causes false warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 --- Comment #2 from Tomás Cohen Arazi --- Mason, thanks for the patch! I thought of a similar patch, but kept thinking a variable assignment shouldn't be forced to have a filter, and so was in doubt about it. I'm happy to go with this regardless. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 03:20:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 01:20:42 +0000 Subject: [Koha-bugs] [Bug 31754] Improve appearance of behavior of DataTables controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 03:24:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 01:24:55 +0000 Subject: [Koha-bugs] [Bug 31751] Breadcrumb style In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin Somers --- > I prefer breadcrumbs to use the > rather than the /. I say we should use an icon like caret : https://fontawesome.com/v4/icon/caret-right > normal text rather than italics/emphasis +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 03:28:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 01:28:58 +0000 Subject: [Koha-bugs] [Bug 31810] Place hold button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin Somers --- I see Bug 23957 changed from input to button -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 03:41:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 01:41:52 +0000 Subject: [Koha-bugs] [Bug 31810] Place hold button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 --- Comment #2 from Fridolin Somers --- Looks like important action button must use btn-primary instead of btn-default https://getbootstrap.com/docs/4.0/components/buttons/#examples -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 03:49:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 01:49:29 +0000 Subject: [Koha-bugs] [Bug 31810] Place hold button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 03:49:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 01:49:34 +0000 Subject: [Koha-bugs] [Bug 31810] Place hold button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 --- Comment #3 from Fridolin Somers --- Created attachment 142220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142220&action=edit Bug 31810: Define 'Place hold' button as primary When placing a hold in staff, the 'Place hold' button should be yellow for the most important action on this form. Patch changes this button from btn-default to btn-primary. Test plan : Play with placing hold, one and several, with cases : - normal - override required - none available -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 03:50:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 01:50:45 +0000 Subject: [Koha-bugs] [Bug 31810] Place hold button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 --- Comment #4 from Fridolin Somers --- We see this patch did the same on preferences page : Bug 30952: Set preferences save buttons as primary buttons https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141679 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 04:07:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 02:07:06 +0000 Subject: [Koha-bugs] [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 04:07:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 02:07:11 +0000 Subject: [Koha-bugs] [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142122|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 142221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142221&action=edit Bug 31864: Correct breadcrumbs for pages in new cataloging module To test: 1. Apply patch 2. Set system preference 'StockRotation' to enable. 3. Be logged in as a superlibrarian 4. Check the breadcrumbs on the following pages, accessible from the Cataloging module homepage: barcode-print.tt label-edit-batch.tt label-edit-layout.tt label-edit-profile.tt label-edit-range.tt label-edit-template.tt label-home.tt label-manage.tt spinelabel-home.tt automatic_item_modification_by_age.tt batchMod-edit.tt batchMod.tt batch_delete_records.tt export.tt inventory.tt manage-marc-import.tt marc_modification_templates.tt stage-marc-import.tt stockrotation.tt upload-images.tt Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 04:07:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 02:07:15 +0000 Subject: [Koha-bugs] [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142214|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 142222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142222&action=edit Bug 31864: (follow-up) Fix breadcrumbs in batchMod and batch_record_mod Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 04:07:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 02:07:48 +0000 Subject: [Koha-bugs] [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 --- Comment #7 from David Nind --- (In reply to Lucas Gass from comment #4) > Thanks David! I filed Bug 31882. Thanks Lucas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 04:19:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 02:19:52 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #55 from David Cook --- (In reply to David Cook from comment #54) > I think I had someone asking for this the other day. I'll come back... Actually, I think this might be much much more complicated than what we were wanting to do. We just want to show the 773 information rather than fetching data from a record linked via the 773... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 04:34:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 02:34:55 +0000 Subject: [Koha-bugs] [Bug 31810] Place hold button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 04:34:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 02:34:59 +0000 Subject: [Koha-bugs] [Bug 31810] Place hold button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142220|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 142223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142223&action=edit Bug 31810: Define 'Place hold' button as primary When placing a hold in staff, the 'Place hold' button should be yellow for the most important action on this form. Patch changes this button from btn-default to btn-primary. Test plan : Play with placing hold, one and several, with cases : - normal - override required - none available Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 07:22:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 05:22:55 +0000 Subject: [Koha-bugs] [Bug 23032] Add 264 to Alternate Graphic Representation (MARC21 880) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23032 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- (In reply to giuseppe.angilella from comment #1) > It would be desirable that also Alternate graphic representation (880) for > Content (505, particularly 505$t) were displayed in the OPAC and intranet > detail pages Please raise a separate bug report for that -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 07:23:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 05:23:13 +0000 Subject: [Koha-bugs] [Bug 23032] Add 264 to Alternate Graphic Representation (MARC21 880) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23032 --- Comment #3 from David Cook --- (In reply to Katrin Fischer from comment #0) > The 880 field containing information from 264 is not displayed in the OPAC > and intranet detail pages. Fortunately, this is an easy fix. I'll send a patch shortly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 07:32:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 05:32:31 +0000 Subject: [Koha-bugs] [Bug 23032] Add 264 to Alternate Graphic Representation (MARC21 880) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23032 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 07:32:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 05:32:35 +0000 Subject: [Koha-bugs] [Bug 23032] Add 264 to Alternate Graphic Representation (MARC21 880) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23032 --- Comment #4 from David Cook --- Created attachment 142224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142224&action=edit Bug 23032: Show MARC21 880 for 264 on detail pages This patch adds the 880 display for 264 (in addition to 260) on the detail pages. To test: 0) Apply patch 1) Create/edit a record 2) Create 264 $6 880-01 $a Xianggang : $b Tushuguan, $c 2022 3) Create 880 $6 264-01 $a 香港 : $b 图书馆, $c 2022 4) View record and see "Publication details" appear with the 880 script on the detail page on both the staff interface and OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 07:33:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 05:33:08 +0000 Subject: [Koha-bugs] [Bug 23032] Add 264 to Alternate Graphic Representation (MARC21 880) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23032 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 07:35:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 05:35:23 +0000 Subject: [Koha-bugs] [Bug 31732] 880 titles missing from OPAC and Staff Interface checkout summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31732 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|880 titles missing from |880 titles missing from |OPAC checkout summary |OPAC and Staff Interface | |checkout summary -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 08:20:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 06:20:11 +0000 Subject: [Koha-bugs] [Bug 31884] New: In check in page submit button should be yellow Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31884 Bug ID: 31884 Summary: In check in page submit button should be yellow Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Like Bug 31810, check in button in check in page is the most important action on this form, it should be yellow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 08:20:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 06:20:27 +0000 Subject: [Koha-bugs] [Bug 31884] In check in page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31884 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31810 Depends on| |30952 Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |fridolin.somers at biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 08:20:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 06:20:27 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31884 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31884 [Bug 31884] In check in page submit button should be yellow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 08:20:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 06:20:27 +0000 Subject: [Koha-bugs] [Bug 31810] Place hold button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31884 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 08:22:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 06:22:47 +0000 Subject: [Koha-bugs] [Bug 31884] In check in page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31884 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 08:22:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 06:22:52 +0000 Subject: [Koha-bugs] [Bug 31884] In check in page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31884 --- Comment #1 from Fridolin Somers --- Created attachment 142225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142225&action=edit Bug 31884: Define 'check in' button as primary Check in button in check in page is the most important action on this form, it should be yellow Test plan : 1) Go to check in page /cgi-bin/koha/circ/returns.pl 2) Check submit button 'Check in' as class 'btn-primary' and is yellow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 08:28:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 06:28:13 +0000 Subject: [Koha-bugs] [Bug 31885] New: In renew page submit button should be yellow Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31885 Bug ID: 31885 Summary: In renew page submit button should be yellow Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Like Bug 31810, submit button in renew page is the most important action on this form, it should be yellow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 08:28:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 06:28:49 +0000 Subject: [Koha-bugs] [Bug 31885] In renew page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31885 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |fridolin.somers at biblibre.co | |m Status|NEW |ASSIGNED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31884 Depends on| |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 08:28:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 06:28:49 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31885 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31885 [Bug 31885] In renew page submit button should be yellow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 08:28:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 06:28:49 +0000 Subject: [Koha-bugs] [Bug 31884] In check in page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31884 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31885 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 08:29:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 06:29:39 +0000 Subject: [Koha-bugs] [Bug 31884] In check in page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31884 --- Comment #2 from Fridolin Somers --- BTW maybe button text should be "Submit" like in renew page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 08:31:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 06:31:31 +0000 Subject: [Koha-bugs] [Bug 31885] In renew page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31885 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 08:31:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 06:31:35 +0000 Subject: [Koha-bugs] [Bug 31885] In renew page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31885 --- Comment #1 from Fridolin Somers --- Created attachment 142226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142226&action=edit Bug 31885: Define submit button as primary in renew page Submit button in renew page is the most important action on this form, it should be yellow Test plan : 1) Go to renew page /cgi-bin/koha/circ/renew.pl 2) Check submit button 'Submit' as class 'btn-primary' and is yellow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 08:32:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 06:32:02 +0000 Subject: [Koha-bugs] [Bug 31885] In renew page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31885 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 09:21:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 07:21:29 +0000 Subject: [Koha-bugs] [Bug 31886] New: No side menu when searching for syspref Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Bug ID: 31886 Summary: No side menu when searching for syspref Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 And also something weird at the bottom, see https://snipboard.io/PRgUln.jpg Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 09:21:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 07:21:29 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 [Bug 31886] No side menu when searching for syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 09:24:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 07:24:06 +0000 Subject: [Koha-bugs] [Bug 31883] t::lib::QA::TemplateFilters missing built-in TT filter "trim" causes false warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- I followed the test plan and everything works. For some reason I can't sign off like I normally do (git bz attach -e 31883 HEAD). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 09:30:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 07:30:38 +0000 Subject: [Koha-bugs] [Bug 31885] In renew page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31885 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 09:30:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 07:30:43 +0000 Subject: [Koha-bugs] [Bug 31885] In renew page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31885 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142226|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142227&action=edit Bug 31885: Define submit button as primary in renew page Submit button in renew page is the most important action on this form, it should be yellow Test plan : 1) Go to renew page /cgi-bin/koha/circ/renew.pl 2) Check submit button 'Submit' as class 'btn-primary' and is yellow Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 09:35:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 07:35:22 +0000 Subject: [Koha-bugs] [Bug 31883] t::lib::QA::TemplateFilters missing built-in TT filter "trim" causes false warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 --- Comment #4 from David Nind --- I can sign off other bugs, so maybe something wrong with this one? This is the message I'm getting when I go git bz attach -e 31883 HEAD (after a git so 1): git bz attach -e 31883 HEAD /usr/bin/git-bz:1908: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal obsoleted = (initial_description == patch.description) Traceback (most recent call last): File "/usr/bin/git-bz", line 2722, in do_attach(*args) File "/usr/bin/git-bz", line 2074, in do_attach attach_commits(bug, commits, edit_comments=global_options.edit) File "/usr/bin/git-bz", line 1988, in attach_commits description, body, obsoletes, statuses, patch_complexities, depends = edit_attachment_comment(bug, commit.subject, body) File "/usr/bin/git-bz", line 1940, in edit_attachment_comment lines = edit_template(template.getvalue()) File "/usr/lib/python2.7/StringIO.py", line 271, in getvalue self.buf += ''.join(self.buflist) UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 3: ordinal not in range(128) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 09:50:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 07:50:05 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #56 from Katrin Fischer --- Subfields 0 and 9 are only used with EasyAnalytics and might be used differently by other libraries as these are not standard MARC - I think we should wrap that part into a preference check. Otherwise it could cause issues if either of them is used locally with a numerical value. For our use case 0 and 9 would never be set with any Koha IDs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 09:55:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 07:55:00 +0000 Subject: [Koha-bugs] [Bug 31883] t::lib::QA::TemplateFilters missing built-in TT filter "trim" causes false warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- Same here UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 3: ordinal not in range(128) Will edit commit message now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 09:55:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 07:55:48 +0000 Subject: [Koha-bugs] [Bug 31883] t::lib::QA::TemplateFilters missing built-in TT filter "trim" causes false warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |normal --- Comment #6 from Marcel de Rooy --- Lowering severity. Critical is really another category :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 09:55:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 07:55:53 +0000 Subject: [Koha-bugs] [Bug 31884] In check in page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31884 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 09:55:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 07:55:58 +0000 Subject: [Koha-bugs] [Bug 31884] In check in page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31884 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142225|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 142228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142228&action=edit Bug 31884: Define 'check in' button as primary Check in button in check in page is the most important action on this form, it should be yellow Test plan : 1) Go to check in page /cgi-bin/koha/circ/returns.pl 2) Check submit button 'Check in' as class 'btn-primary' and is yellow Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 09:59:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 07:59:35 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #57 from Katrin Fischer --- Thinking about the search fallback too: I don't think it will work reliably enough and we should remove it. Most of the time 773 are used with articles from serials. And there are a lot of serials with very similar names and subseries in $b etc. Thinking about the serial "Pädagogik" or "Natur" for examples. Even an exact field search would turn up many results there and not only the one you were looking for. Also serials usually don't have authors, so the search is quite limited. I really think using the IDs is ok'ish with the caveat of it checking EasyAnalytics, but trying to link otherwise won't work well enough and there are records where the host is just not in the catalog and then we just need to display 773 information directly from the record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:08:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:08:07 +0000 Subject: [Koha-bugs] [Bug 24678] Add missing search fields to Elasticsearch mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24678 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin Somers --- Still valid ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:10:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:10:41 +0000 Subject: [Koha-bugs] [Bug 31887] New: Search on MARC field does not work in Elasticsearch mappings table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 Bug ID: 31887 Summary: Search on MARC field does not work in Elasticsearch mappings table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In Elasticsearch mappings table, in tabs with MARC fields, searching using DataTable search field does not work for MARC fields / subfields. This is because cell contains an input HTML tag with MARC data in attribute value. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:11:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:11:48 +0000 Subject: [Koha-bugs] [Bug 31883] t::lib::QA::TemplateFilters missing built-in TT filter "trim" causes false warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Marcel de Rooy --- Not sure whats going on here. Please resubmit a new version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:12:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:12:37 +0000 Subject: [Koha-bugs] [Bug 31887] Search on MARC field does not work in Elasticsearch mappings table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 --- Comment #1 from Fridolin Somers --- I think we must define attribute data-search in each cell : https://datatables.net/examples/advanced_init/html5-data-attributes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:12:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:12:46 +0000 Subject: [Koha-bugs] [Bug 31887] Search on MARC field does not work in Elasticsearch mappings table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:14:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:14:21 +0000 Subject: [Koha-bugs] [Bug 31883] t::lib::QA::TemplateFilters missing built-in TT filter "trim" causes false warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Marcel de Rooy --- It seems to be another general issue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:19:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:19:21 +0000 Subject: [Koha-bugs] [Bug 31884] In check in page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31884 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- (In reply to Fridolin Somers from comment #2) > BTW maybe button text should be "Submit" like in renew page I'm not sure what Koha's convention is, but I generally prefer a specific label/action rather than a generic submit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:19:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:19:26 +0000 Subject: [Koha-bugs] [Bug 31887] Search on MARC field does not work in Elasticsearch mappings table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:19:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:19:30 +0000 Subject: [Koha-bugs] [Bug 31887] Search on MARC field does not work in Elasticsearch mappings table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 --- Comment #2 from Fridolin Somers --- Created attachment 142229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142229&action=edit Bug 31887: Fix search on MARC field in Elasticsearch mappings table In Elasticsearch mappings table, in tabs with MARC fields, searching using DataTable search field does not work for MARC fields / subfields. This is because cell contains an input HTML tag with MARC data in attribute value. Test plan : 1) Go to Administration > Search engine configuration (Elasticsearch) 2) Go to tab 'Bibliographic records' 3) Enter in search field a used MARC field (like 245) => Table gets filtered by rows with mapping on searched field 4) Enter in search field the field+subfield used for issues (952l in KTD) => Table gets filtered by rows with mapping on field+subfield -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:21:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:21:32 +0000 Subject: [Koha-bugs] [Bug 31887] Search on MARC field does not work in Elasticsearch mappings table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142229|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 142230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142230&action=edit Bug 31887: Fix search on MARC field in Elasticsearch mappings table In Elasticsearch mappings table, in tabs with MARC fields, searching using DataTable search field does not work for MARC fields / subfields. This is because cell contains an input HTML tag with MARC data in attribute value. Test plan : 1) Go to Administration > Search engine configuration (Elasticsearch) 2) Go to tab 'Bibliographic records' 3) Enter in search field a used MARC field (like 245) => Table gets filtered by rows with mapping on searched field 4) Enter in search field the field+subfield used for issues (952l in KTD) => Table gets filtered by rows with mapping on field+subfield Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:22:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:22:04 +0000 Subject: [Koha-bugs] [Bug 31887] Search on MARC field does not work in Elasticsearch mappings table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:26:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:26:09 +0000 Subject: [Koha-bugs] [Bug 31812] Add yellow to buttons on staged imports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31810 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:26:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:26:09 +0000 Subject: [Koha-bugs] [Bug 31810] Place hold button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31812 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:28:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:28:40 +0000 Subject: [Koha-bugs] [Bug 31888] New: In Elasticsearch mappings page save button should be yellow Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31888 Bug ID: 31888 Summary: In Elasticsearch mappings page save button should be yellow Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Like Bug 31810, save button in Elasticsearch mappings page is the most important action on this form, it should be yellow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:28:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:28:49 +0000 Subject: [Koha-bugs] [Bug 31888] In Elasticsearch mappings page save button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31888 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |fridolin.somers at biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:29:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:29:04 +0000 Subject: [Koha-bugs] [Bug 31888] In Elasticsearch mappings page save button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31888 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31810 Depends on| |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:29:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:29:04 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31888 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31888 [Bug 31888] In Elasticsearch mappings page save button should be yellow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:29:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:29:04 +0000 Subject: [Koha-bugs] [Bug 31810] Place hold button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31888 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:34:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:34:05 +0000 Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Lukas Koszyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lukasz.koszyk at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:34:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:34:41 +0000 Subject: [Koha-bugs] [Bug 31888] In Elasticsearch mappings page save button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31888 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:34:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:34:46 +0000 Subject: [Koha-bugs] [Bug 31888] In Elasticsearch mappings page save button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31888 --- Comment #1 from Fridolin Somers --- Created attachment 142231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142231&action=edit Bug 31888: Define save button as primary in Elasticsearch mappings page Like Bug 31810, save button in Elasticsearch mappings page is the most important action on this form, it should be yellow. Test plan : Go to Administration > Search engine configuration (Elasticsearch) => Check save button has class btn-primary and is yellow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:38:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:38:56 +0000 Subject: [Koha-bugs] [Bug 31812] Add yellow to buttons on staged imports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 --- Comment #1 from Fridolin Somers --- You mean /cgi-bin/koha/tools/manage-marc-import.pl ? I only see a table, there is no main action I think. On a batch /cgi-bin/koha/tools/manage-marc-import.pl?import_batch_id=1 I see 2 input type=submit already yellow -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:45:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:45:30 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to basket.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:45:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:45:35 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to basket.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142217|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142232&action=edit Bug 31837: Add page-section class to tables on basket.tt This patch adds the page-section class to the orders and cancelled orders tables. To test: 1. Have a vendor, basket, and create an order. 2. Go look at the table on basket.tt and make sure the orders table looks good. 3. Cancel some orders and look at the cancelled order table, make sure it also looks good. Note: I made some indentation changes. I also did NOT add a new wrapper to the cancelled orders table, it already had one so I just added the page-section div to the existing div. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:54:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:54:12 +0000 Subject: [Koha-bugs] [Bug 31830] Add page-section to budgets and funds table on acq start page (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31830 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:54:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:54:16 +0000 Subject: [Koha-bugs] [Bug 31830] Add page-section to budgets and funds table on acq start page (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31830 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142216|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142233&action=edit Bug 31830: Add page-section class to acq home table To test: 1. Go to the Acquisitions home page. 2. Look and the bugdets and funds table and notice the page-section class. 3. Make sure everything looks good. Note: I made some indentation changes. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:59:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:59:14 +0000 Subject: [Koha-bugs] [Bug 31829] Change password form in patron account is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31829 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 10:59:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 08:59:19 +0000 Subject: [Koha-bugs] [Bug 31829] Change password form in patron account is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31829 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142215|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142234&action=edit Bug 31829: Fix change password form alignment This patch gives the fieldset on member-password.tt the class row. It also moves the hints below the list. To test: 1. Apply patch 2. Pull up a patron record and go to 'Change password'. 3. Make sure the form now looks good. 4. Also check and make sure the form is still functional. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 11:06:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 09:06:55 +0000 Subject: [Koha-bugs] [Bug 31883] t::lib::QA::TemplateFilters missing built-in TT filter "trim" causes false warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #8) > It seems to be another general issue? No. I refreshed my container. Could git attach again. But after applying this patch, we see our friend again: /usr/local/bin/git-bz:1908: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal obsoleted = (initial_description == patch.description) Traceback (most recent call last): File "/usr/local/bin/git-bz", line 2722, in do_attach(*args) File "/usr/local/bin/git-bz", line 2074, in do_attach attach_commits(bug, commits, edit_comments=global_options.edit) File "/usr/local/bin/git-bz", line 1988, in attach_commits description, body, obsoletes, statuses, patch_complexities, depends = edit_attachment_comment(bug, commit.subject, body) File "/usr/local/bin/git-bz", line 1940, in edit_attachment_comment lines = edit_template(template.getvalue()) File "/usr/lib/python2.7/StringIO.py", line 271, in getvalue self.buf += ''.join(self.buflist) UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 3: ordinal not in range(128) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 11:16:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 09:16:44 +0000 Subject: [Koha-bugs] [Bug 31883] Filter trim causes false warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|t::lib::QA::TemplateFilters |Filter trim causes false |missing built-in TT filter |warnings |"trim" causes false | |warnings | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 11:19:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 09:19:12 +0000 Subject: [Koha-bugs] [Bug 31883] Filter trim causes false warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142218|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy --- Comment on attachment 142218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142218 Bug 31883: t::lib::QA::TemplateFilters missing built-in TT filter "trim" causes false warnings Ttile of bug report and attachment name cause(d) Unicode issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 11:19:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 09:19:29 +0000 Subject: [Koha-bugs] [Bug 31883] Filter trim causes false warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 --- Comment #11 from Marcel de Rooy --- Created attachment 142235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142235&action=edit Filter trim causes false warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 11:19:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 09:19:39 +0000 Subject: [Koha-bugs] [Bug 31883] Filter trim causes false warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 --- Comment #12 from Martin Renvoize --- Created attachment 142236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142236&action=edit Bug 31883: t::lib::QA::TemplateFilters missing built-in TT filter "trim" causes false warnings to test... 1/ checkout latest master 2/ prove xt/find-missing-filters.t xt/find-missing-filters.t .. 1/1 # Failed test 'Template variables should be correctly escaped' # at xt/find-missing-filters.t line 59. # got: '1' # expected: '0' # $VAR1 = { # 'errors' => [ # { # 'error' => 'missing_filter', # 'line' => ' [% messages = INCLUDE \'patron_messages.inc\' moremember = 1 | trim %]', # 'line_number' => 97 # } # ], # 'file' => 'koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt' # }; # Looks like you failed 1 test of 1. 3/ apply patch 4/ prove xt/find-missing-filters.t xt/find-missing-filters.t .. ok All tests successful. Files=1, Tests=1, 2 wallclock secs ( 0.03 usr 0.01 sys + 2.15 cusr 0.07 csys = 2.26 CPU) Result: PASS <<<<<<<<<<<<<<< Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 11:21:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 09:21:19 +0000 Subject: [Koha-bugs] [Bug 31883] Filter trim causes false warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #142235|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 11:24:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 09:24:28 +0000 Subject: [Koha-bugs] [Bug 31883] Filter trim causes false warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142236|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 11:25:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 09:25:04 +0000 Subject: [Koha-bugs] [Bug 31883] Filter trim causes false warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 11:25:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 09:25:08 +0000 Subject: [Koha-bugs] [Bug 31883] Filter trim causes false warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 --- Comment #13 from Marcel de Rooy --- Created attachment 142237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142237&action=edit Bug 31883: Filter trim causes false warnings Test plan: Run xt/find-missing-filters.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 11:27:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 09:27:19 +0000 Subject: [Koha-bugs] [Bug 31883] Filter trim causes false warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142237|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 142238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142238&action=edit Bug 31883: Filter trim causes false warnings Test plan: Run xt/find-missing-filters.t Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 11:27:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 09:27:34 +0000 Subject: [Koha-bugs] [Bug 31883] Filter trim causes false warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 12:35:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 10:35:39 +0000 Subject: [Koha-bugs] [Bug 31803] "remove from cart" button displayed even if not in cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31803 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Version|unspecified |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 13:21:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 11:21:07 +0000 Subject: [Koha-bugs] [Bug 31803] "remove from cart" button displayed even if not in cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31803 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 13:21:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 11:21:11 +0000 Subject: [Koha-bugs] [Bug 31803] "remove from cart" button displayed even if not in cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31803 --- Comment #1 from Owen Leonard --- Created attachment 142239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142239&action=edit Bug 31803: "remove from cart" button displayed even if not in cart This patch modifies CSS related to the "Remove from cart" button associated with bibligraphic record views. A change in specificity of buttons made by Bug 30952 made it so that the button was no longer hidden correctly. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Locate a bibliographic record in the staff interface and view the detail page. - In the toolbar you should see an "Add to cart" button but not a "Remove from cart" button. - The buttons should correctly toggle on and off as you add and remove the title from the cart. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 13:41:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 11:41:36 +0000 Subject: [Koha-bugs] [Bug 31751] Breadcrumb style In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751 --- Comment #2 from Owen Leonard --- Created attachment 142240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142240&action=edit Breadcrumbs reverted to the old style Screenshot showing breadcrumbs reverted to the old style -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 13:42:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 11:42:09 +0000 Subject: [Koha-bugs] [Bug 31751] Breadcrumb style In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751 --- Comment #3 from Owen Leonard --- Created attachment 142241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142241&action=edit Breadcrumbs using a caret icon Screenshot showing breadcrumbs using a caret icon -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 13:46:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 11:46:03 +0000 Subject: [Koha-bugs] [Bug 22693] ILL "Price paid" column does not appear in column configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Patrick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pm at interleaf.ie --- Comment #2 from Patrick --- The 'Price Paid' field should be viewable and exportable (i.e. included in the output from the export function) in the ILL Requests screen. This is the functionality of the other columns in the table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 14:00:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 12:00:30 +0000 Subject: [Koha-bugs] [Bug 31806] Add 'page-section' to holds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 --- Comment #1 from Owen Leonard --- Are you referring to this page? /cgi-bin/koha/reserve/request.pl?biblionumber=X&borrowernumber=X I don't think I'm seeing the issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 14:52:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 12:52:11 +0000 Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 --- Comment #22 from Marcel de Rooy --- Please fix: root at master:/usr/share/koha# git grep EmbedItemsInMarcBiblio C4/Biblio.pm: EmbedItemsInMarcBiblio Exported not existing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 14:55:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 12:55:04 +0000 Subject: [Koha-bugs] [Bug 31806] Add 'page-section' to holds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 --- Comment #2 from David Nind --- Created attachment 142242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142242&action=edit Screenshot - Record details > Holds On the Record details > Holds page: http://127.0.0.1:8081/cgi-bin/koha/reserve/request.pl?biblionumber=126 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 15:03:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 13:03:49 +0000 Subject: [Koha-bugs] [Bug 31889] New: Restore MARC field order when embedding items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889 Bug ID: 31889 Summary: Restore MARC field order when embedding items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org I would like to see 942 952 999 instead of 942 999 952. Tiny fix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 15:04:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 13:04:01 +0000 Subject: [Koha-bugs] [Bug 31889] Restore MARC field order when embedding items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31224 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 15:04:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 13:04:01 +0000 Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31889 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 15:09:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 13:09:29 +0000 Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when embedding items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Restore MARC field order |Insert 952 tags in correct |when embedding items |order when embedding items -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 15:18:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 13:18:31 +0000 Subject: [Koha-bugs] [Bug 31888] In Elasticsearch mappings page save button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31888 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 15:18:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 13:18:35 +0000 Subject: [Koha-bugs] [Bug 31888] In Elasticsearch mappings page save button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31888 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142231|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142243&action=edit Bug 31888: Define save button as primary in Elasticsearch mappings page Like Bug 31810, save button in Elasticsearch mappings page is the most important action on this form, it should be yellow. Test plan : Go to Administration > Search engine configuration (Elasticsearch) => Check save button has class btn-primary and is yellow Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 15:28:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 13:28:05 +0000 Subject: [Koha-bugs] [Bug 31869] Unable to save thesaurus value to frameworks subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31869 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142147|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 142244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142244&action=edit Bug 31869: Unable to save thesaurus value to frameworks subfields This patch correct a typo authtypecodes for authtypecode To test: 1. Edit e.g. default frameworks subfield 100$a 2. Add or change fields thesaurus value 3. Save your changes => note that on subfield listing there is no mention that 100$a is linked to any thesaurus => if you edit 100$a thesaurus input is empty 4. Apply patch 5. Edit subfield 100$a and set a thesaurus value 6. Confirm it saves and displays correctly Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 15:29:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 13:29:10 +0000 Subject: [Koha-bugs] [Bug 31803] "remove from cart" button displayed even if not in cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31803 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 15:29:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 13:29:16 +0000 Subject: [Koha-bugs] [Bug 31803] "remove from cart" button displayed even if not in cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31803 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142239|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142245&action=edit Bug 31803: "remove from cart" button displayed even if not in cart This patch modifies CSS related to the "Remove from cart" button associated with bibligraphic record views. A change in specificity of buttons made by Bug 30952 made it so that the button was no longer hidden correctly. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Locate a bibliographic record in the staff interface and view the detail page. - In the toolbar you should see an "Add to cart" button but not a "Remove from cart" button. - The buttons should correctly toggle on and off as you add and remove the title from the cart. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 15:32:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 13:32:12 +0000 Subject: [Koha-bugs] [Bug 24678] Add missing search fields to Elasticsearch mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24678 --- Comment #3 from Caroline Cyr La Rose --- Bug 28378 and Bug 28391 add 264 mappings to the default ES mappings. There isn't one specifically for 264$a. I don't know if it's still needed... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 15:42:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 13:42:52 +0000 Subject: [Koha-bugs] [Bug 31881] Link in MARC view does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 15:42:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 13:42:58 +0000 Subject: [Koha-bugs] [Bug 31881] Link in MARC view does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142219|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142246&action=edit Bug 31881: Fix search link in MARC view In framework a subfield can be defined with a link (with a search field). This create an hyperlink in MARC view. Currently with Elasticsearch the link does not work because search query contains 'field,phr:', which is useless since the link contains 'idx=field,phr'. With Zebra looks like the idx param is ignored. Test plan : 1) Use Elasticsearch search engine 2) Edit subfield 245$a in default framework 3) Enter 'title' in 'Link' 4) Save 5) Create a record with default framework with 245$a = 'The Fifth Elephant' 6) Go to MARC view 7) Click on link in 245$a 8) You find the record Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 15:51:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 13:51:13 +0000 Subject: [Koha-bugs] [Bug 31421] Library limitation on patron category breaks patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #4 from Jonathan Druart --- Non-limited categories is displayed in the "New patron" dropdown list https://snipboard.io/043TZt.jpg > The limits I think are intended to prevent users from setting a patron to the wrong category, they are not meant to hide patrons. Is that correct? Yes I know I am the one who wrote bug 7919, but not the one who design it. And I have to admit I have no idea how it's supposed to work right now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 15:52:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 13:52:28 +0000 Subject: [Koha-bugs] [Bug 31421] Library limitation on patron category breaks patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 --- Comment #5 from Jonathan Druart --- (In reply to Jonathan Druart from comment #4) > Non-limited categories is displayed in the "New patron" dropdown list Sorry, *limited* categories. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:15:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:15:00 +0000 Subject: [Koha-bugs] [Bug 31421] Library limitation on patron category breaks patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 --- Comment #6 from Nick Clemens --- Created attachment 142247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142247&action=edit Bug 31421: Add a limited option to template plugin This adds a specific 'limited' routine to the Categories plugin, and uses it for the new patron dropdowns To test: 1 - Limit a patron category to some branches 2 - Sign in not at one of those 3 - Confirm the new patron dropdowns don't include the category -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:17:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:17:40 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:17:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:17:47 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141952|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:17:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:17:59 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141951|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:18:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:18:54 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:20:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:20:19 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #51 from Tomás Cohen Arazi --- Created attachment 142248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142248&action=edit Bug 29012: Fix existing update to prevent inserting incorrect data Both updates now rely on 'suspension_chargeperiod' as the source of truth for existence of a rule. Spot checking some existing production databases this seems to be acceptable. This alters the update to only add rules where a 'suspension_chargeperiod' rule exists and a value for the rule is not already set. NOTE: While the table has a unique key: UNIQUE KEY `branchcode` (`branchcode`,`categorycode`,`itemtype`,`rule_name`), This key doesn't prevent duplicates on NULLs, i.e.: branchcode | categorycode | itemtype | rule_name | rule_value NULL | NULL | BK | unseen_renewals_allowed | 1 NULL | NULL | BK | unseen_renewals_allowed | 2 NULL | NULL | BK | unseen_renewals_allowed | 3 So we need to both check that any rule is present and that the specific rule is not. The 'INSERT IGNORE' won't IGNORE existing values except for the most specific rules Test plan: 0 - Edit and save existing default rule in DB (sample data does not include suspension_chargeperiod) 1 - Set some rules for "Default checkout, hold and return policy" for "Standard rule" and some specific libraries 2 - cp installer/data/mysql/db_revs/220600024.pl installer/data/mysql/atomicupdate/ 3 - SELECT * FROM circulation rules, note the number of rules that exist 4 - updatedatabase 5 - Check the DB again, you should now have rules as described in the bug i.e. You will have 5 new rules per 'Default checkout, hold and return policy' 6 - apply 1st patch on bug 7 - rm installer/data/mysql/atomicupdate/220600024.pl (so we don't add again) 8 - updatedatabase 9 - Check DB, the extra rules have been deleted 10 - Apply 2nd patch 11 - cp installer/data/mysql/db_revs/220600024.pl installer/data/mysql/atomicupdate/ 12 - rm installer/data/mysql/atomicupdate/bug_31727.pl (so we can confirm update isn't adding rules) 13 - updatedatabase 14 - Confirm no change in rules since step 9 15 - git reset --hard (get deleted update back) 16 - rm installer/data/mysql/atomicupdate/220600024.pl Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:20:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:20:27 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #52 from Tomás Cohen Arazi --- Created attachment 142249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142249&action=edit Bug 29012: Fix undef warnings around unseen_renewals_allowed in smart-rules.pl Trivial fix. To reproduce: 1. Create or edit a rule on /cgi-bin/koha/admin/smart-rules.pl - i.e. submit the form (make POST request) 2. Notice the mentioned above warning in plack-intranet-error.log 3. Apply the patch. 4. Repeat step 1. 5. That warning in log file should be no more. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:25:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:25:23 +0000 Subject: [Koha-bugs] [Bug 31422] Library limitations might cause data loss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19361 CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:25:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:25:23 +0000 Subject: [Koha-bugs] [Bug 19361] Linking an authorised value category to a field in a framework can lose data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31422 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:32:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:32:19 +0000 Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Lukas Koszyk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:32:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:32:23 +0000 Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Lukas Koszyk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142210|0 |1 is obsolete| | --- Comment #6 from Lukas Koszyk --- Created attachment 142250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142250&action=edit Bug 31115: Add support for additional fields for invoices This patch adds support for additional fields for invoices. A new option is added to the 'Additional fields' admin page, for the 'aqinvoices' table. Adding/editing invoices now supports this additional fields. To test: 1. Apply this patches 2. Verify the original test plan works => SUCCESS: It does! 3. Sign off :-D Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:32:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:32:27 +0000 Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Lukas Koszyk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142211|0 |1 is obsolete| | --- Comment #7 from Lukas Koszyk --- Created attachment 142251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142251&action=edit Bug 31115: Add invoice fields manage link This patch adds a link on the acquisitions page for reaching the additional fields config for invoices in an easy way. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:32:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:32:32 +0000 Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Lukas Koszyk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142212|0 |1 is obsolete| | --- Comment #8 from Lukas Koszyk --- Created attachment 142252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142252&action=edit Bug 31115: Add additional_attributes support to GetInvoices This patch adds support for searching additional_fields when retrieving invoices using C4::Acquisition::Invoices. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Acquisition.t => SUCCESS: Tests pass! 3. Sign off :-D Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:32:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:32:37 +0000 Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Lukas Koszyk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142213|0 |1 is obsolete| | --- Comment #9 from Lukas Koszyk --- Created attachment 142253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142253&action=edit Bug 31115: Add additional field filtering for invoice search This patch adds support for filtering invoice searches on additional fields. To test: 1. Generate additional fields for invoices 2. Have invoices with additional fields 3. Use invoice searching and play with filtering by additional fields. => SUCCESS: It works! 4. Sign off :-D Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:35:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:35:23 +0000 Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when embedding items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:35:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:35:27 +0000 Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when embedding items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889 --- Comment #1 from Marcel de Rooy --- Created attachment 142254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142254&action=edit Bug 31889: Remove exported ghost routine from Biblio module It has been moved to a Koha object. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:35:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:35:31 +0000 Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when embedding items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889 --- Comment #2 from Marcel de Rooy --- Created attachment 142255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142255&action=edit Bug 31889: Add unit test to show problem Test plan: Run t/db_dependent/Koha/Biblio/Metadata.t Fails with: not ok 10 - 951-952s-953 in 245,100,942,951,953,999,952,952,952,952,952,952,952,952 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:35:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:35:35 +0000 Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when embedding items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889 --- Comment #3 from Marcel de Rooy --- Created attachment 142256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142256&action=edit Bug 31889: Replace append_fields in _embed_items Test plan: Run t/db_dependent/Koha/Biblio/Metadata.t again. Should pass. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:35:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:35:58 +0000 Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when embedding items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:44:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:44:38 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,22.11.00, 22.05.06 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:44:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:44:41 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #53 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:44:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:44:45 +0000 Subject: [Koha-bugs] [Bug 31728] Duplicate claims modal template markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31728 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:44:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:44:48 +0000 Subject: [Koha-bugs] [Bug 31728] Duplicate claims modal template markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31728 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:44:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:44:50 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:44:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:44:53 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #16 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:44:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:44:56 +0000 Subject: [Koha-bugs] [Bug 31883] Filter trim causes false warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:44:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:44:58 +0000 Subject: [Koha-bugs] [Bug 31883] Filter trim causes false warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31883 --- Comment #15 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:46:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:46:51 +0000 Subject: [Koha-bugs] [Bug 15869] Change framework on overlay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140857|0 |1 is obsolete| | --- Comment #12 from ByWater Sandboxes --- Created attachment 142257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142257&action=edit Bug 15869: Change framework on overlay This patch allows for selection of framework to use when overlaying records - by default it is set to keep the initial framework To test: 1 - Create some records using one framework 2 - Export the records 3 - Edit the records to add fields not in original framework 4 - Stage records using a rule that will find matches 5 - Import 6 - Note records contain new fields on display, but they are lost on edit 7 - Apply patch 8 - Stage records again 9 - Select a framework that contains the new fields on import 10 - Import records 11 - Note records now use selected framework and are displayed/edited correctly Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:46:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:46:57 +0000 Subject: [Koha-bugs] [Bug 15869] Change framework on overlay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140858|0 |1 is obsolete| | --- Comment #13 from ByWater Sandboxes --- Created attachment 142258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142258&action=edit Bug 15869: Unit test Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:47:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:47:20 +0000 Subject: [Koha-bugs] [Bug 15869] Change framework on overlay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:47:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:47:57 +0000 Subject: [Koha-bugs] [Bug 31890] New: PrefillGuaranteeField should include option to prefill surname Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31890 Bug ID: 31890 Summary: PrefillGuaranteeField should include option to prefill surname Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The PrefillGuaranteeField system preference does not allow for the copying of the surname field, I think it should. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:54:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:54:17 +0000 Subject: [Koha-bugs] [Bug 31422] Library limitations might cause data loss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:54:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:54:22 +0000 Subject: [Koha-bugs] [Bug 31422] Library limitations might cause data loss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 --- Comment #3 from Nick Clemens --- Created attachment 142259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142259&action=edit Bug 31422: Add patron's current category to dropdown while editing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 16:54:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 14:54:31 +0000 Subject: [Koha-bugs] [Bug 31422] Library limitations might cause data loss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 17:01:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 15:01:35 +0000 Subject: [Koha-bugs] [Bug 31891] New: Regression: show "MARC staging results" with clear link to manage staged bartch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891 Bug ID: 31891 Summary: Regression: show "MARC staging results" with clear link to manage staged bartch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: andrewfh at dubcolib.org QA Contact: testopia at bugs.koha-community.org Depends on: 31666 Moving marc batch import actions to background jobs has introduced some confusing clicks to the process. Before this change, after staging a batch one was taken to a "MARC staging results" page with details of how the staging went and, most importantly, a link straight to the batch you'd just staged (at manage-marc-import.pl?import_batch_id=). Now, however, one must click the status bar to get to details of the job and then click "View batch" from there. Not only is that an extra click and page load, but neither of those links are particularly large or obvious. We need a clearer and easier patch from staging a batch to managing the batch. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 [Bug 31666] Add job progress bar to stage-marc-import.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 17:01:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 15:01:35 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31891 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891 [Bug 31891] Regression: show "MARC staging results" with clear link to manage staged bartch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 17:06:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 15:06:13 +0000 Subject: [Koha-bugs] [Bug 31892] New: Regression: return to /manage-marc-import.pl after importing batch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31892 Bug ID: 31892 Summary: Regression: return to /manage-marc-import.pl after importing batch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: andrewfh at dubcolib.org QA Contact: testopia at bugs.koha-community.org Depends on: 31748 Now that MARC batch importing uses the background job system, after one imports a staged MARC batch one needs to follow a link over to the completed background job and then another link back to manage-marc-import.pl for the batch you've just imported. Previously, importing a batch simply re-loaded manage-marc-import.pl in order to show the imported bibs. We should either restore this exact behavior or at least make sure that the completed process bar page contains a link directly to the imported batch. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31748 [Bug 31748] Restore progress bar on record import -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 17:06:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 15:06:13 +0000 Subject: [Koha-bugs] [Bug 31748] Restore progress bar on record import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31748 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31892 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31892 [Bug 31892] Regression: return to /manage-marc-import.pl after importing batch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 17:06:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 15:06:13 +0000 Subject: [Koha-bugs] [Bug 31891] Regression: show "MARC staging results" with clear link to manage staged bartch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31892 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 17:18:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 15:18:06 +0000 Subject: [Koha-bugs] [Bug 31885] In renew page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31885 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 17:18:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 15:18:09 +0000 Subject: [Koha-bugs] [Bug 31885] In renew page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31885 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142227|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 142260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142260&action=edit Bug 31885: Define submit button as primary in renew page Submit button in renew page is the most important action on this form, it should be yellow Test plan : 1) Go to renew page /cgi-bin/koha/circ/renew.pl 2) Check submit button 'Submit' as class 'btn-primary' and is yellow Signed-off-by: David Nind Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 17:20:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 15:20:36 +0000 Subject: [Koha-bugs] [Bug 31884] In check in page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31884 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 17:20:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 15:20:39 +0000 Subject: [Koha-bugs] [Bug 31884] In check in page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31884 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142228|0 |1 is obsolete| | --- Comment #5 from Lucas Gass --- Created attachment 142261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142261&action=edit Bug 31884: Define 'check in' button as primary Check in button in check in page is the most important action on this form, it should be yellow Test plan : 1) Go to check in page /cgi-bin/koha/circ/returns.pl 2) Check submit button 'Check in' as class 'btn-primary' and is yellow Signed-off-by: David Nind Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 17:30:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 15:30:49 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #19 from Lucas Gass --- (In reply to Lari Taskula from comment #18) > In reply to Lucas Gass from comment #3) > > Maybe we need a dropdown? I'm not sure if that is the proper solution either. > > I actually wanted to see what it looks like so I implemented patch: > > Bug 31692: (alternative look) Use select dropdown > > I think it looks quite okay. It also allows me to get rid of all extra > JavaScript and tooltip issues. Great idea Lucas. Thoughts? Lari, I do like that much better! Everything works great. I do wonder if there is still going to be some confusion on what the dropdown does. Do we need a hint or a tip to help describe what the dropdown is going to do? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 17:33:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 15:33:54 +0000 Subject: [Koha-bugs] [Bug 31893] New: Some pages load about.tt template to check authentication rather than using checkauth Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31893 Bug ID: 31893 Summary: Some pages load about.tt template to check authentication rather than using checkauth Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It seems to be an old hack, where the about template is used to check auth for pages that don't actually render. These must all be updated to use checkauth reserve/modrequest.pl reserve/modrequest_suspendall.pl course_reserves/mod_course.pl members/members-update-do.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 17:34:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 15:34:35 +0000 Subject: [Koha-bugs] [Bug 31893] Some pages load about.tt template to check authentication rather than using checkauth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31893 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 17:50:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 15:50:22 +0000 Subject: [Koha-bugs] [Bug 31893] Some pages load about.tt template to check authentication rather than using checkauth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31893 --- Comment #1 from Jonathan Druart --- how did I never notice that?! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 18:31:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 16:31:28 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 18:31:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 16:31:32 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138053|0 |1 is obsolete| | --- Comment #6 from Lucas Gass --- Created attachment 142262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142262&action=edit Bug 31212: Change datelastseen from date to datetime field This patch changes the datelastseen field to a datetime field for better time accuracy. It also fixes the interface in order to display datelastseen as a datetime field. To test: 1. Apply patch 2. Search the catalogue and select a biblio with at least one item. Confirm in the holdings table that every entry in the "Last Seen" column is in date-time format. 3. Navigate to "Items" in for that same biblio and check the item "History" section to have "Last Seen" in the correct format 4. Click "Edit" then "Edit Items" and confirm that the table has date-time format for the "Date Last Seen" Column entries 5. Edit one of the items to have lost status, then navigate to the Reports section, find "Items Lost", and search for the item with the barcode. Confirm the proper date-time format in the result. 6. Navigate to Tools, then Inventory, run inventory and confirm that the "Date Last Seen" column entries are in proper format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 18:31:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 16:31:37 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139510|0 |1 is obsolete| | --- Comment #7 from Lucas Gass --- Created attachment 142263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142263&action=edit Bug 31212: Add Database update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 18:31:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 16:31:42 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #8 from Lucas Gass --- Created attachment 142264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142264&action=edit Bug 31212: Fix date_from_string and explicitly called output_pref subroutine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 18:32:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 16:32:09 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #9 from Lucas Gass --- Rebased for current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 18:38:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 16:38:49 +0000 Subject: [Koha-bugs] [Bug 31894] New: Extend Hold hooks with more actions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894 Bug ID: 31894 Summary: Extend Hold hooks with more actions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: stefan.berndtsson at ub.gu.se QA Contact: testopia at bugs.koha-community.org This patch adds three more hooks to the existing "after_hold_action", extending it to handle the different found values. * "transfer" when a Hold calls "set_transfer()" (found=T) * "waiting" when a Hold calls "set_waiting()" (found=W) * "processing" when a Hold calls "set_processing()" (found=P) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 18:39:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 16:39:30 +0000 Subject: [Koha-bugs] [Bug 31894] Extend Hold hooks with more actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894 --- Comment #1 from Stefan Berndtsson --- Created attachment 142265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142265&action=edit Bug 31894: Extend after_hold_action hook Hook actions added: after_hold_action adds new actions transfer, waiting and processing How to test: Run tests in t/db_dependent/Koha/Plugins/Holds_hooks.t Sponsored by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 18:40:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 16:40:08 +0000 Subject: [Koha-bugs] [Bug 31894] Extend Hold hooks with more actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |stefan.berndtsson at ub.gu.se |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 18:41:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 16:41:21 +0000 Subject: [Koha-bugs] [Bug 31895] New: New Account hook when adding credit Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31895 Bug ID: 31895 Summary: New Account hook when adding credit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: stefan.berndtsson at ub.gu.se QA Contact: testopia at bugs.koha-community.org This patch adds a new hook "after_account_action" with the action "add_credit". This is triggered when a credit is added via for example PAYMENT or WRITEOFF. This is consistent with when UpdateStats is called so that a plugin can be used to log the same kind of data as the normal statistics. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 18:42:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 16:42:00 +0000 Subject: [Koha-bugs] [Bug 31895] New Account hook when adding credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31895 --- Comment #1 from Stefan Berndtsson --- Created attachment 142266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142266&action=edit Bug 31895: New after_account_action hook Hooks added: after_account_action with new action add_credit How to test: Run tests in t/db_dependent/Koha/Plugins/Account_hooks.t Sponsored by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 18:42:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 16:42:18 +0000 Subject: [Koha-bugs] [Bug 31895] New Account hook when adding credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31895 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |stefan.berndtsson at ub.gu.se |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 18:43:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 16:43:23 +0000 Subject: [Koha-bugs] [Bug 31896] New: New Recall hook when adding recall Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896 Bug ID: 31896 Summary: New Recall hook when adding recall Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: stefan.berndtsson at ub.gu.se QA Contact: testopia at bugs.koha-community.org This patch adds a new hook "after_recall_action" with the action "add". This is consistent with when UpdateStats is called so that a plugin can be used to log the same kind of data as the normal statistics. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 18:43:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 16:43:53 +0000 Subject: [Koha-bugs] [Bug 31896] New Recall hook when adding recall In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896 --- Comment #1 from Stefan Berndtsson --- Created attachment 142267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142267&action=edit Bug 31896: New after_recall_action hook Hooks added: after_recall_action with new action add How to test: Run tests in t/db_dependent/Koha/Plugins/Recall_hooks.t Sponsored by: Gothenburg University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 18:44:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 16:44:14 +0000 Subject: [Koha-bugs] [Bug 31896] New Recall hook when adding recall In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |stefan.berndtsson at ub.gu.se |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 18:45:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 16:45:18 +0000 Subject: [Koha-bugs] [Bug 31897] New: New hook when indexing with Elasticsearch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897 Bug ID: 31897 Summary: New hook when indexing with Elasticsearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: stefan.berndtsson at ub.gu.se QA Contact: testopia at bugs.koha-community.org This patch adds a new hook "before_index_action" with the action "update". This is run on the array reference to the biblio records that are about to be updated in the Elasticsearch index. With this, a plugin can change the record so that it better suits the index without having to change the actual record in the database (something that might be prohibited or discouraged due to centralised cataloging). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 18:45:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 16:45:51 +0000 Subject: [Koha-bugs] [Bug 31897] New hook when indexing with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897 --- Comment #1 from Stefan Berndtsson --- Created attachment 142268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142268&action=edit Bug 31897: New before_index_action hook for Elasticsearch Hooks added: before_index_action with new action update How to test: Run tests in t/db_dependent/Koha/Plugins/Elasticsearch_Indexer_hooks.t Sponsored by: Gothenburg University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 18:46:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 16:46:18 +0000 Subject: [Koha-bugs] [Bug 31897] New hook when indexing with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |stefan.berndtsson at ub.gu.se |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 18:50:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 16:50:24 +0000 Subject: [Koha-bugs] [Bug 31734] Hooks for account, recall, indexing and more actions for holds. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31734 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #3 from Stefan Berndtsson --- I didn't see this as that big of a thing, but ok. There are now the bugs: Bug 31894 (Hold) Bug 31895 (Account) Bug 31896 (Recall) Bug 31897 (Index) I guess this one can be closed then. Should it just be set to resolved, or is there another procedure? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 18:57:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 16:57:20 +0000 Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 18:57:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 16:57:25 +0000 Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141069|0 |1 is obsolete| | --- Comment #23 from Lucas Gass --- Created attachment 142269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142269&action=edit Bug 30624: Add select_loggedin_library permission To test: 1. Apply patch, updatedatabase, restart_all 2. Have a user with superlibrarian privileges ( User1 ) 3. Have a user who has staff access and circulate privileges but is not a super librarian. ( User2 ) Make note of this users home library 4. Turn on the system preference 'CircSidebar'. -MAIN log in ( auth.tt ) 5. As User1, go to the main login screen and try logging in. You should be able to log in AND you should be able to properly chnage your branch BEFORE logging in. 6. As User2, to to the main login screnn amd try logging in. You should be able to but if you try and switch your libraray to anything beside the user's home branch it will not work. You will be logged in at your home branch. 7. For User2, set the new permission 'select_loggedin_library' on. 8. Now you should be able to successfully switch libraries before log in. 9. Turn the 'select_loggedin_library' back off for User2. -AFTER log in- 10. With User1, click on your name/branch in the top right, you should see the the link 'Set library' at the top. If you turn on 'UseCirculationDesks' the link will be 'Set library and desk'. 11. With User2, click on your name/branch in the top right. If you have 'UseCirculationDesks' on, you should see 'Set desk', otherwise you should see nothing. 12. Repeat step 7. 13. NOw if you click on your name/branch in the top right, you should see the the link 'Set library' at the top. If you turn on 'UseCirculationDesks' the link will be 'Set library and desk'. 14. Repeat Step 9. -CircSideBar- 15. With 'CircSideBar' turned on, go to any ciculation page (Holds queue, Holds to pull, Holds awaiting pickup) with User1. You will see the 'Set library' link. If 'UseCirculationDesks' is on you will see a 'Set library and desk'. 16. Try with User2 and you will not see a 'Set library' link. If 'UseCirculationDesks' is on you will see a 'Set desk' link. 17. Repeat step 7. 18. For with User2 you go to any ciculation page (Holds queue, Holds to pull, Holds awaiting pickup). You will see the 'Set library' link. If 'UseCirculationDesks' is on you will see a 'Set library and desk'. 19. Repeat step 9. -Set library page- 20. Go to the set library page (http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User1. You will see a dropdown for 'Set library'. Make sure you can change your library successfully. 21. Go to the set library page (http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User2. You should NOT see see a dropdown for 'Set library'. 22. Repeat step 7. 23. Go to the set library page (http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User2. Now you should see a dropdown for 'Set library'. Signed-off-by: Andrew -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 18:57:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 16:57:33 +0000 Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141070|0 |1 is obsolete| | --- Comment #24 from Lucas Gass --- Created attachment 142270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142270&action=edit Bug 30624: DB Update to add permission Signed-off-by: Andrew -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 18:57:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 16:57:38 +0000 Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141071|0 |1 is obsolete| | --- Comment #25 from Lucas Gass --- Created attachment 142271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142271&action=edit Bug 30624: (follow-up) Remove IndependentBraches check on auth.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 18:58:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 16:58:12 +0000 Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 --- Comment #26 from Lucas Gass --- Rebased for current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 19:13:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 17:13:13 +0000 Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 19:38:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 17:38:09 +0000 Subject: [Koha-bugs] [Bug 31672] Remove 'Your' from tab descriptions in OPAC patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31672 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 19:38:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 17:38:14 +0000 Subject: [Koha-bugs] [Bug 31672] Remove 'Your' from tab descriptions in OPAC patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31672 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141282|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 142272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142272&action=edit Bug 31672: Remove 'Your' from tab descriptions in OPAC patron account I'll try to keep the test plan simple: * Go to patron account in OPAC * Verify that the your from the beginning of the tab descriptions has been removed Bonus: This moves the Recalls history tab below the Holds history as this is the more logical place for it. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 19:59:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 17:59:31 +0000 Subject: [Koha-bugs] [Bug 31811] Add 'page-section' to MARC modification templates pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 20:02:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 18:02:39 +0000 Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 [Bug 31758] Add 'page-section' to system preferences page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 20:02:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 18:02:39 +0000 Subject: [Koha-bugs] [Bug 31758] Add 'page-section' to system preferences page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 [Bug 31886] No side menu when searching for syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 20:19:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 18:19:28 +0000 Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when embedding items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 20:19:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 18:19:34 +0000 Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when embedding items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142254|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 142273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142273&action=edit Bug 31889: Remove exported ghost routine from Biblio module It has been moved to a Koha object. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 20:19:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 18:19:38 +0000 Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when embedding items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142255|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 142274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142274&action=edit Bug 31889: Add unit test to show problem Test plan: Run t/db_dependent/Koha/Biblio/Metadata.t Fails with: not ok 10 - 951-952s-953 in 245,100,942,951,953,999,952,952,952,952,952,952,952,952 Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 20:19:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 18:19:43 +0000 Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when embedding items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142256|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 142275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142275&action=edit Bug 31889: Replace append_fields in _embed_items Test plan: Run t/db_dependent/Koha/Biblio/Metadata.t again. Should pass. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 20:24:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 18:24:07 +0000 Subject: [Koha-bugs] [Bug 31811] Add 'page-section' to MARC modification templates pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 20:24:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 18:24:12 +0000 Subject: [Koha-bugs] [Bug 31811] Add 'page-section' to MARC modification templates pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 --- Comment #1 from Owen Leonard --- Created attachment 142276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142276&action=edit Bug 31811: Add 'page-section' to MARC modification templates pages This patch adds "page-section" divs to the MARC modification templates template so that sections are properly defined and content has adequate contrast. Note: The patch includes indentation changes, so please ignore whitespace when checking the diff. To test, apply the patch and go to Cataloging -> MARC modification templates. The main content should be surrounded by a white box whether you're looking at the list of templates, the the action add/edit form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 20:47:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 18:47:56 +0000 Subject: [Koha-bugs] [Bug 31895] New Account hook when adding credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31895 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 20:48:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 18:48:00 +0000 Subject: [Koha-bugs] [Bug 31895] New Account hook when adding credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31895 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142266|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142277&action=edit Bug 31895: New after_account_action hook Hooks added: after_account_action with new action add_credit How to test: Run tests in t/db_dependent/Koha/Plugins/Account_hooks.t Sponsored by: Gothenburg University Library Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 20:51:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 18:51:51 +0000 Subject: [Koha-bugs] [Bug 31894] Extend Hold hooks with more actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 20:51:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 18:51:56 +0000 Subject: [Koha-bugs] [Bug 31894] Extend Hold hooks with more actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142265|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142278&action=edit Bug 31894: Extend after_hold_action hook Hook actions added: after_hold_action adds new actions transfer, waiting and processing How to test: Run tests in t/db_dependent/Koha/Plugins/Holds_hooks.t Sponsored by: Gothenburg University Library Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 20:55:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 18:55:11 +0000 Subject: [Koha-bugs] [Bug 31896] New Recall hook when adding recall In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 20:55:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 18:55:16 +0000 Subject: [Koha-bugs] [Bug 31896] New Recall hook when adding recall In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142267|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142279&action=edit Bug 31896: New after_recall_action hook Hooks added: after_recall_action with new action add How to test: Run tests in t/db_dependent/Koha/Plugins/Recall_hooks.t Sponsored by: Gothenburg University Library Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 20:56:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 18:56:26 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #17 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #11) > (In reply to Jonathan Druart from comment #10) > > Ok but if you keep data:function and set searchable to false, it also works. > > "It works" is not enough ;) > I will revert most changes now. But imo dataTables or the additional > customizations are buggy and/or inconsistent. > If data may be a function, you simply need to check col.data.split.. > Definitely a bug. Are you going to file a bug about that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 20:57:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 18:57:38 +0000 Subject: [Koha-bugs] [Bug 31896] New Recall hook when adding recall In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Note that I got a whitespace error warning - it may pay to fix this so that there is one less thing for the QA Team to deal with: Applying: Bug 31896: New after_recall_action hook .git/rebase-apply/patch:102: trailing whitespace. warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M Koha/Recalls.pm .git/rebase-apply/patch:102: trailing whitespace. warning: 1 line applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging Koha/Recalls.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 21:03:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 19:03:36 +0000 Subject: [Koha-bugs] [Bug 31897] New hook when indexing with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 21:03:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 19:03:42 +0000 Subject: [Koha-bugs] [Bug 31897] New hook when indexing with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142268|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142280&action=edit Bug 31897: New before_index_action hook for Elasticsearch Hooks added: before_index_action with new action update How to test: Run tests in t/db_dependent/Koha/Plugins/Elasticsearch_Indexer_hooks.t Sponsored by: Gothenburg University Library Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 21:05:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 19:05:30 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #65 from Fridolin Somers --- (In reply to Jonathan Druart from comment #63) > What did you fix, and how? Same for us. And before upgrade we looked where custom block is only 'fr-FR' to change it in 'en'. So that is becomes default after upgrade. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 21:09:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 19:09:45 +0000 Subject: [Koha-bugs] [Bug 31811] Add 'page-section' to MARC modification templates pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 21:09:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 19:09:50 +0000 Subject: [Koha-bugs] [Bug 31811] Add 'page-section' to MARC modification templates pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142276|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142281&action=edit Bug 31811: Add 'page-section' to MARC modification templates pages This patch adds "page-section" divs to the MARC modification templates template so that sections are properly defined and content has adequate contrast. Note: The patch includes indentation changes, so please ignore whitespace when checking the diff. To test, apply the patch and go to Cataloging -> MARC modification templates. The main content should be surrounded by a white box whether you're looking at the list of templates, the the action add/edit form. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 21:16:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 19:16:09 +0000 Subject: [Koha-bugs] [Bug 31898] New: OPACFineNoRenewals check should affect ILSDI Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31898 Bug ID: 31898 Summary: OPACFineNoRenewals check should affect ILSDI Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 22:11:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 20:11:40 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142262|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes --- Created attachment 142282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142282&action=edit Bug 31212: Change datelastseen from date to datetime field This patch changes the datelastseen field to a datetime field for better time accuracy. It also fixes the interface in order to display datelastseen as a datetime field. To test: 1. Apply patch 2. Search the catalogue and select a biblio with at least one item. Confirm in the holdings table that every entry in the "Last Seen" column is in date-time format. 3. Navigate to "Items" in for that same biblio and check the item "History" section to have "Last Seen" in the correct format 4. Click "Edit" then "Edit Items" and confirm that the table has date-time format for the "Date Last Seen" Column entries 5. Edit one of the items to have lost status, then navigate to the Reports section, find "Items Lost", and search for the item with the barcode. Confirm the proper date-time format in the result. 6. Navigate to Tools, then Inventory, run inventory and confirm that the "Date Last Seen" column entries are in proper format Signed-off-by: Ann Flournoy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 22:11:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 20:11:44 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142263|0 |1 is obsolete| | --- Comment #11 from ByWater Sandboxes --- Created attachment 142283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142283&action=edit Bug 31212: Add Database update Signed-off-by: Ann Flournoy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 22:11:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 20:11:48 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142264|0 |1 is obsolete| | --- Comment #12 from ByWater Sandboxes --- Created attachment 142284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142284&action=edit Bug 31212: Fix date_from_string and explicitly called output_pref subroutine Signed-off-by: Ann Flournoy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 22:12:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 20:12:09 +0000 Subject: [Koha-bugs] [Bug 31422] Library limitations might cause data loss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 22:12:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 20:12:13 +0000 Subject: [Koha-bugs] [Bug 31422] Library limitations might cause data loss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142259|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 142285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142285&action=edit Bug 31422: Add patron's current category to dropdown while editing Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 22:13:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 20:13:39 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Ann Flournoy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 22:28:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 20:28:33 +0000 Subject: [Koha-bugs] [Bug 31422] Library limitations might cause data loss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind --- Testing notes (using koha-testing-docker): 1. Replicated issue for example 2 in comment #1: . Patron used: Mary Burton (changed library to Centerville) 2. Applied the patch. 3. Retested: . When editing, now displays current patron category (previously it was blank) . Now has an ! icon next to it with this message when you hover over it: "The patron's current category (Patron) is limited to other branches" . If you save without changing the patron category, the patron category remains the same (so no data loss) . If you change the patron category and save, the patron category is changed - if you go to edit it again you can't choose the patron category with the limitation 4. Bug 31421 and bug 19361 deal with the other issues in the description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 22:37:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 20:37:02 +0000 Subject: [Koha-bugs] [Bug 28969] [DOCS] Document recreateIssueStatistics.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28969 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Summary|Document |[DOCS] Document |recreateIssueStatistics.pl |recreateIssueStatistics.pl |script |script -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 22:43:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 20:43:10 +0000 Subject: [Koha-bugs] [Bug 31899] New: [DOCS] Document misc/batchRebuildBiblioTables.pl script Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31899 Bug ID: 31899 Summary: [DOCS] Document misc/batchRebuildBiblioTables.pl script Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org This script is mentioned in the manual (https://koha-community.org/manual/22.11/en/html/administration.html?highlight=batchrebuildbibliotables#edit-a-marc-subfield), but not documented anywhere else. To see the existing help for the script: misc/batchRebuildBiblioTables.pl -h See query on the mailing list and response with instructions on how to use it: https://lists.katipo.co.nz/pipermail/koha/2022-October/058571.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 23:25:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 21:25:04 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142282|0 |1 is obsolete| | --- Comment #13 from David Nind --- Created attachment 142286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142286&action=edit Bug 31212: Change datelastseen from date to datetime field This patch changes the datelastseen field to a datetime field for better time accuracy. It also fixes the interface in order to display datelastseen as a datetime field. To test: 1. Apply patch 2. Search the catalogue and select a biblio with at least one item. Confirm in the holdings table that every entry in the "Last Seen" column is in date-time format. 3. Navigate to "Items" in for that same biblio and check the item "History" section to have "Last Seen" in the correct format 4. Click "Edit" then "Edit Items" and confirm that the table has date-time format for the "Date Last Seen" Column entries 5. Edit one of the items to have lost status, then navigate to the Reports section, find "Items Lost", and search for the item with the barcode. Confirm the proper date-time format in the result. 6. Navigate to Tools, then Inventory, run inventory and confirm that the "Date Last Seen" column entries are in proper format Signed-off-by: Ann Flournoy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 23:25:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 21:25:10 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142283|0 |1 is obsolete| | --- Comment #14 from David Nind --- Created attachment 142287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142287&action=edit Bug 31212: Add Database update Signed-off-by: Ann Flournoy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 23:25:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 21:25:15 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142284|0 |1 is obsolete| | --- Comment #15 from David Nind --- Created attachment 142288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142288&action=edit Bug 31212: Fix date_from_string and explicitly called output_pref subroutine Signed-off-by: Ann Flournoy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 20 23:48:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 21:48:39 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #16 from David Nind --- I've signed off, but then I read through Sally's comments (comment #2). For editing the date last seen in the item editor, I: - Changed the BKS framework for 952$r so that it displays in the editor with the dateaccessioned.pl plugin - Edited an item: saves date and time with 00:00 for the time - Without the daetaccessioned.pl plugin you have to enter the date and time including seconds, otherwise you get an error (edited item so no date, added date without time): "Invalid value passed, items.datelastseen=09/05/2022 expected type is datetime at /...." Can confirm that check in and manual transfer are working as expected (with the date time displayed correctly). Also, when you edit an item, the date last seen changes to the current date but with the time set as 00:00. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 00:18:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 22:18:22 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #66 from David Cook --- (In reply to Jonathan Druart from comment #63) > What did you fix, and how? We ended up having to delete duplicated entries. I can't remember what conditions we used for the cleanup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 00:19:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 22:19:57 +0000 Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 --- Comment #1 from Lucas Gass --- I think it is because of 'LINE.is_group_title'. And that has to do with how we format the .pref yaml files. This seems to happen when you search brings up i18n_l10n or serial system prefs. If we fix the YAML, I think we'll fix the problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 00:25:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 22:25:06 +0000 Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 00:25:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 22:25:10 +0000 Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 --- Comment #2 from Lucas Gass --- Created attachment 142289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142289&action=edit Bug 31886: Fix no sidebar problem in system pref search To test: 1. Go to Adminstration and click on 'Global system preferences' 2. From the left side bar click 'I18N/L10N' and notice no sidebar. 3. Also try 'Serials', no sidebar 4. Apply patch, restart_all 5. Try 1 & 2 again and the sidebar should be restored 6. Try clicking through each of the system preference groups (Accounting, Acquisitions, etc ) and make sure the sidebar is always present. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 00:26:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 22:26:17 +0000 Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 00:56:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 22:56:41 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Lucas Gass --- (In reply to David Nind from comment #16) > I've signed off, but then I read through Sally's comments (comment #2). > > For editing the date last seen in the item editor, I: > - Changed the BKS framework for 952$r so that it displays in the editor with > the dateaccessioned.pl plugin > - Edited an item: saves date and time with 00:00 for the time > - Without the daetaccessioned.pl plugin you have to enter the date and time > including seconds, otherwise you get an error (edited item so no date, added > date without time): "Invalid value passed, items.datelastseen=09/05/2022 > expected type is datetime at /...." > > Can confirm that check in and manual transfer are working as expected (with > the date time displayed correctly). > > Also, when you edit an item, the date last seen changes to the current date > but with the time set as 00:00. Thanks for your testing David, I'll set this one to FQA and try to fix those problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 01:16:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 23:16:52 +0000 Subject: [Koha-bugs] [Bug 31900] New: Add support for logout from external OAuth2/OIDC identity providers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31900 Bug ID: 31900 Summary: Add support for logout from external OAuth2/OIDC identity providers Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 01:17:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 23:17:05 +0000 Subject: [Koha-bugs] [Bug 31900] Add support for logout from external OAuth2/OIDC identity providers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31900 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31378 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 [Bug 31378] Add a generic OAuth2/OIDC client implementation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 01:17:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 23:17:05 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31900 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31900 [Bug 31900] Add support for logout from external OAuth2/OIDC identity providers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 01:19:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 23:19:51 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #18 from Tomás Cohen Arazi --- Hi, after pushing this I noticed the conversation between Jonathan and Marcel is not entirely closed. My feeling now is that we have hidden the problem by making the field not searchable, but a proper solution would be a bit more complex. It this is the case, please file a bug to discuss it an I'm willing to add my two cents for the solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 01:19:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 23:19:58 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 01:22:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Oct 2022 23:22:09 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #84 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #83) > For the missing help link the last patch on bug 31162 might be interesting. > I also noticed the help missing there and it was due to changes to the page > structure with the new staff design. > > For the JSON editor: Maybe CodeMirror that we use for SQL and YAML can do it? I felt like using the CodeMirror plugin would be enough. Maybe we should make the 'Create' button be a dropdown instead, for choosing the protocol, and make the form be already pre-populated, so we remove the buttons too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 04:21:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 02:21:53 +0000 Subject: [Koha-bugs] [Bug 29087] Holds to pull list can crash with a SQL::Abstract puke In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts at ptfs-europe.c | |om --- Comment #7 from David Roberts --- I've tried patching a customer site with this and it works OK. Happy to sign off (even though the bug isn't requesting it yet....) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 08:05:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 06:05:54 +0000 Subject: [Koha-bugs] [Bug 31842] admin/branches: DT search generates js error on col.data.split In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 --- Comment #19 from Marcel de Rooy --- The bug has been addressed now. I will not file another bug, but I gave my observations here. We have more code issues. Cant solve them all ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 08:07:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 06:07:01 +0000 Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when embedding items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889 --- Comment #7 from Marcel de Rooy --- (In reply to David Nind from comment #6) > Signed-off-by: David Nind Thx David for your fast signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 08:24:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 06:24:15 +0000 Subject: [Koha-bugs] [Bug 31900] Add support for logout from external OAuth2/OIDC identity providers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31900 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 08:27:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 06:27:34 +0000 Subject: [Koha-bugs] [Bug 31901] New: Add 505 (Formatted Contents Notes) to Alternate Graphic Representation (MARC21 880) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31901 Bug ID: 31901 Summary: Add 505 (Formatted Contents Notes) to Alternate Graphic Representation (MARC21 880) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: giuseppe.angilella at ct.infn.it QA Contact: testopia at bugs.koha-community.org It would be desirable that an Alternate graphic representation (880) for Formatted Contents Notes (505, particularly 505$t) were displayed in the OPAC and intranet detail pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 08:27:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 06:27:51 +0000 Subject: [Koha-bugs] [Bug 31901] Add 505 (Formatted Contents Notes) to Alternate Graphic Representation (MARC21 880) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31901 giuseppe.angilella at ct.infn.it changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |giuseppe.angilella at ct.infn. | |it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 08:28:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 06:28:56 +0000 Subject: [Koha-bugs] [Bug 23032] Add 264 to Alternate Graphic Representation (MARC21 880) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23032 --- Comment #5 from giuseppe.angilella at ct.infn.it --- (In reply to David Cook from comment #2) > (In reply to giuseppe.angilella from comment #1) > > It would be desirable that also Alternate graphic representation (880) for > > Content (505, particularly 505$t) were displayed in the OPAC and intranet > > detail pages > > Please raise a separate bug report for that Done: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31901 Many thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 08:31:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 06:31:34 +0000 Subject: [Koha-bugs] [Bug 15048] Genre/Form (655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 --- Comment #25 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #16) > QA Comment: > Thanks for your patch, Mason. > I think it still needs some attention: > [1] You add $x when indexing 655. Please note that the whole field 655 is > already indexed under term Subject. (So you would only add to > Index-term-genre.) But the XSLT just looks at Subject (and only with some > specific settings for UseAuthoritiesForTracings and > TraceSubjectSubdivisions). Normally you would search for the authority > number (an). > So, it does not seem to be necessary to add it. > Please explain why you need it. > > [2] If it should be necessary, what about $v $y and $z ? I am revisiting this report now. And just notice my older comment. Mason did not answer it and Nick picked up this patch 6 years later.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 08:33:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 06:33:03 +0000 Subject: [Koha-bugs] [Bug 15048] Genre/Form (655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 08:33:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 06:33:07 +0000 Subject: [Koha-bugs] [Bug 15048] Genre/Form (655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137842|0 |1 is obsolete| | --- Comment #26 from Marcel de Rooy --- Created attachment 142290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142290&action=edit Bug 15048: Index all possible searched subfields for index-term-genre Currently we only index a - but we can setup the system such that avxyz are searched To test: 1 - define both a 655$a *and* 655$x value in a bib, save, reindex 2 - Set system preferences: TraceSubjectSubdivisions: Include TraceCompleteSubfields: Force 3 - View the record edited above in the opac 4 - Click on the subject heading 5 - No results found 6 - Copy zebra files: sudo cp ./etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml \ /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml sudo cp etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl \ /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl 7 - restart all and reindex 8 - Click on the subject heading in OPAC 9 - Sucess! 10 - Repeat with other fields (vyz) 11 - Repeat under ES, reindexing and resetting mappings Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 08:39:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 06:39:15 +0000 Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #23 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #21) > I think we are generally on the same page, but with a slightly different > approach. Trying to explain: I want to implement the ideal solution and then > migrate things one by one into it. You are proposing a somewhat intermediate > thing that will need to be redone (removing the separator). The goal is the > same. Oke. Lets push the ideal solution then ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 08:39:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 06:39:35 +0000 Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 08:39:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 06:39:39 +0000 Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125031|0 |1 is obsolete| | --- Comment #24 from Marcel de Rooy --- Created attachment 142291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142291&action=edit Bug 29033: Add C4::Context->multivalue_preference I've seen several places in which a syspref is retrieved and then splitted using split and the fact they are pipe-separated strings. It seems it would be simple (and handy) to add a method to do that. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Context.t => SUCCESS: Tests pass, a pipe-separated syspref is correctly retrieved as an arrayref. 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 08:45:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 06:45:47 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 08:48:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 06:48:36 +0000 Subject: [Koha-bugs] [Bug 31684] Plugin versions starting with a "v" cause unnecessary warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31684 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 08:48:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 06:48:39 +0000 Subject: [Koha-bugs] [Bug 31684] Plugin versions starting with a "v" cause unnecessary warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31684 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141589|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 142292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142292&action=edit Bug 31684: Set Koha::Plugin::Test version to 'v1.01' Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 08:48:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 06:48:43 +0000 Subject: [Koha-bugs] [Bug 31684] Plugin versions starting with a "v" cause unnecessary warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31684 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141590|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 142293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142293&action=edit Bug 31684: Plugin versions starting with a "v" cause unnecessary warnings Our code assumes that plugin version will be purely numeric ( e.g. 1.2.3 ) but many plugin authors ( including myself ) use the format "v1.2.3". This causes warnings as we use a numeric comparison on the version numbers. It could make sense to check for and strip any v's from the beginning of the version. Test Plan: 1) Apply the first patch to set the test plugin's version to v1.01 2) prove t/db_dependent/Koha/Plugins/Plugins.t 3) Note the warnings and test failures 4) Apply this patch 5) prove t/db_dependent/Koha/Plugins/Plugins.t 6) All tests pass! Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 08:49:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 06:49:21 +0000 Subject: [Koha-bugs] [Bug 31684] Plugin versions starting with a "v" cause unnecessary warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31684 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 08:52:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 06:52:02 +0000 Subject: [Koha-bugs] [Bug 31895] New Account hook when adding credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31895 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #3 from Marcel de Rooy --- + $schema->storage->txn_rollback; + Koha::Plugins::Methods->delete; That does not look good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 08:54:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 06:54:58 +0000 Subject: [Koha-bugs] [Bug 31894] Extend Hold hooks with more actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- I am seeing this pattern a few times: $self->store(); + Koha::Plugins->call( + payload => { hold => $self->get_from_storage } You store and get back from storage right away? Please clarify why that would be needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 08:56:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 06:56:55 +0000 Subject: [Koha-bugs] [Bug 31896] New Recall hook when adding recall In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- FAIL t/db_dependent/Koha/Plugins/Recall_hooks.t OK critic FAIL file permissions File must have the exec flag Tip: Please run qa tools on your patches before submitting? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 08:59:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 06:59:00 +0000 Subject: [Koha-bugs] [Bug 31897] New hook when indexing with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- FAIL t/db_dependent/Koha/Plugins/Elasticsearch_Indexer_hooks.t OK critic FAIL file permissions File must have the exec flag Sorry, but it should not take you too much time to get those four back in the queue ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:03:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:03:15 +0000 Subject: [Koha-bugs] [Bug 31810] Place hold button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m CC| |m.de.rooy at rijksmuseum.nl --- Comment #6 from Marcel de Rooy --- Fridolin: penalty points for not filling Assignee field. You should know. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:03:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:03:48 +0000 Subject: [Koha-bugs] [Bug 31810] Place hold button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 --- Comment #7 from Marcel de Rooy --- Not sure if a yellow button on a green form is the most optimal choice of colors. But its all a matter of taste :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:03:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:03:55 +0000 Subject: [Koha-bugs] [Bug 31810] Place hold button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:04:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:04:20 +0000 Subject: [Koha-bugs] [Bug 31810] Place hold button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:04:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:04:24 +0000 Subject: [Koha-bugs] [Bug 31810] Place hold button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142223|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 142294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142294&action=edit Bug 31810: Define 'Place hold' button as primary When placing a hold in staff, the 'Place hold' button should be yellow for the most important action on this form. Patch changes this button from btn-default to btn-primary. Test plan : Play with placing hold, one and several, with cases : - normal - override required - none available Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:07:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:07:23 +0000 Subject: [Koha-bugs] [Bug 31871] Due date not shown on items tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31871 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:07:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:07:28 +0000 Subject: [Koha-bugs] [Bug 31871] Due date not shown on items tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31871 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142207|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 142295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142295&action=edit Bug 31871: Date due not shown on items tab Changed ITEM_DAT to checkout in moredetail.tt Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:07:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:07:39 +0000 Subject: [Koha-bugs] [Bug 31871] Due date not shown on items tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31871 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:13:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:13:57 +0000 Subject: [Koha-bugs] [Bug 31422] Library limitations might cause data loss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #6 from Marcel de Rooy --- If I am reading the comments, this patch only solves one issue but the description is broader than that? Am I correct? Or will the other issue(s) be addressed separately? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:16:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:16:14 +0000 Subject: [Koha-bugs] [Bug 31421] Library limitation on patron category breaks patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #7 from Marcel de Rooy --- FAIL Koha/Template/Plugin/Categories.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for 'limited' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:19:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:19:21 +0000 Subject: [Koha-bugs] [Bug 31881] Link in MARC view does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 --- Comment #3 from Marcel de Rooy --- Not created here, but how ugly is this: [% IF ( subfiel.link ) %] subfiel ?? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:28:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:28:11 +0000 Subject: [Koha-bugs] [Bug 31881] Link in MARC view does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Marcel de Rooy --- Currently with Elasticsearch the link does not work because search query contains 'field,phr:', which is useless since the link contains 'idx=field,phr'. Not sure about this one. Are we really resolving the problem or just creating a workaround? You say that the query contains 'field'. Isnt that just misconfiguration? The framework column link should contain a valid index? Please clarify. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:29:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:29:50 +0000 Subject: [Koha-bugs] [Bug 28639] Embed see-from headings (from authorities) into bibliographic records at OAI repository level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:29:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:29:53 +0000 Subject: [Koha-bugs] [Bug 28639] Embed see-from headings (from authorities) into bibliographic records at OAI repository level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122500|0 |1 is obsolete| | --- Comment #4 from Thibaud Guillot --- Created attachment 142296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142296&action=edit Bug 28639: Embed see-from headings (from authorities) into bibliographic records at OAI repository level Test plan: 1. Create an authority with at least a 1XX$a and a 4XX$a, for instance: 100 $a Foo 400 $a Bar 2. Create a biblio and add a link to this authority using the cataloguing plugin 3. Enable OAI-PMH syspref and fill OAI-PMH:archiveID syspref with "oai:sandbox" 4. Go to OAI repository and display the previously created record (at /cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=oai:sandbox:{biblionumber} 5. The record should not contain see-from headings 6. Enable OAI-PMH:EmbedSeeFromInBibRecord 7. Go again to the OAI record, you should see alternative forms at the end of the record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:32:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:32:27 +0000 Subject: [Koha-bugs] [Bug 31487] Add emails to message queue by longoverdue script options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31487 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:34:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:34:24 +0000 Subject: [Koha-bugs] [Bug 28639] Embed see-from headings (from authorities) into bibliographic records at OAI repository level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142296|0 |1 is obsolete| | --- Comment #5 from Thibaud Guillot --- Created attachment 142297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142297&action=edit Bug 28639: Embed see-from headings (from authorities) into bibliographic records at OAI repository level Test plan: 1. Create an authority with at least a 1XX$a and a 4XX$a, for instance: 100 $a Foo 400 $a Bar 2. Create a biblio and add a link to this authority using the cataloguing plugin 3. Enable OAI-PMH syspref and fill OAI-PMH:archiveID syspref with "oai:sandbox" 4. Go to OAI repository and display the previously created record (at /cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=oai:sandbox:{biblionumber} 5. The record should not contain see-from headings 6. Run perl installer/data/mysql/atomicupdate/bug_28639-add_EmbedSeeFromInBibRecord_syspref.pl 7. Enable OAI-PMH:EmbedSeeFromInBibRecord 8. Go again to the OAI record, you should see alternative forms at the end of the record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:34:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:34:56 +0000 Subject: [Koha-bugs] [Bug 31576] Cannot place hold even when AllowHoldPolicyOverride should allow it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- Shouldnt this be pushed to the queue of the RMaint of 21.11 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:39:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:39:11 +0000 Subject: [Koha-bugs] [Bug 28639] Embed see-from headings (from authorities) into bibliographic records at OAI repository level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibaud.guillot at biblibre.co | |m --- Comment #6 from Thibaud Guillot --- (In reply to Julien Sicot (Univ. Rennes 2) from comment #0) > Hi, > > It could be interesting to enrich the bibliographic records exposed in OAI > with see-from headings, this would allow users who use koha with a discovery > tool to be able to manage, normalize and index some authorities data ? > > This is something that could be done directly in C4::Biblio::GetMarcBiblio > following the same method used for embedding items. > We could use an optional parameter like embed_items (embed_seefromheading) > and a function similar to C4::Biblio::EmbedItemsInMarcBiblio by reusing what > was made for zebra with EmbedSeeFromHeadings (bug #7417). > > Thanks for feedback, > Best > Julien Sicot > Systems Librarian, > Université Rennes 2 Thanks to you, I just rebase your proposal on master updated and add a atomic update file. I just call Koha::Filter::MARC::EmbedSeeFromHeadings on OAI server side to show or hide embed see-from headings. I could not test your development due to an error so I hope that the intended behaviour remains the same. Please let me know if not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:43:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:43:02 +0000 Subject: [Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #11 from Marcel de Rooy --- > The logic of all of this is tricky, makes sense in a certain light, any complaints are for a new bug :-) LOL The module change makes sense to me, reading the tests is hard, you need to make a study of the logic in order to grasp whats going on there.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:46:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:46:09 +0000 Subject: [Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:46:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:46:14 +0000 Subject: [Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141936|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy --- Created attachment 142298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142298&action=edit Bug 31644: Unit test Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:46:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:46:20 +0000 Subject: [Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141937|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy --- Created attachment 142299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142299&action=edit Bug 31644: Check if subfield defined, not for truth To test: 1 - Define a new MARC Modification template with actions: Copy field 600$a to 942$0 2 - Define a new record like: LDR 00334nam a22001217a 4500 003 ff 005 20201102111604.0 008 201102b xxu||||| |||| 00| 0 eng d 040 _ _ ‡cvsd 100 1 _ ‡012345‡aKnuth, Donal Ervin‡d1938 245 _ _ ‡012345‡aThe aty of computer programming‡cDonald E. Knuth 600 _ 0 ‡042‡aComputer programming‡9462 3 - Modify this record using the template above 4 - Note that entire field is copied to 942 5 - Apply patch 6 - Now only subfield 0 is copied Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:46:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:46:25 +0000 Subject: [Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141938|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy --- Created attachment 142300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142300&action=edit Bug 31644: Add copy test and clarify some functions This patch adds a tst for copy without subfields. I also clarify what eachstep does so the next user/coder understands current behaviour Update existing or add new: In the case where the field/subfield exists we update, if we have two fields - one with the subfield, and one without, we add the subfield to the one without Copy field: - If given a subfield - we will add to existing fields in the record - If not given a subfield - we create an entirely new field The logic of all of this is tricky, makes sense in a certain light, any complaints are for a new bug :-) Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:46:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:46:30 +0000 Subject: [Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644 --- Comment #15 from Marcel de Rooy --- Created attachment 142301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142301&action=edit Bug 31644: (QA follow-up) Add two missing shebang lines Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:46:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:46:52 +0000 Subject: [Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:56:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:56:09 +0000 Subject: [Koha-bugs] [Bug 31715] Add missing German translations for language descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31715 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:56:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:56:13 +0000 Subject: [Koha-bugs] [Bug 31715] Add missing German translations for language descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31715 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141940|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 142302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142302&action=edit Bug 31715: Add German translations for language descriptions This adds the German translations for the different languages to subtag_registry.sql that is used by all languages during installation. * Apply patch * Run database update * Install de-DE and activate it for the OPAC * Go to advanced search * Look at the language pull down - it shows the languages in their language and then translated to English * Switch to German - verify the German translations are used now There are 2-3 cases where the translation = name, so only name is shown. * Drop your database, create your database * Run the web installer * Everything should complete without error and the language pull down should look exactly the same and be translated Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:56:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:56:30 +0000 Subject: [Koha-bugs] [Bug 31715] Add missing German translations for language descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31715 --- Comment #7 from Marcel de Rooy --- Looks good to me. Just found this thing: INSERT INTO language_descriptions(subtag, type, lang, description) -VALUES ( 'la', 'language', 'de', 'Latein'); +VALUES ( 'la', 'language', 'de', 'Lateinisch'); It is in the installer file. But not in the dbrev. So could be considered as an inconsistency. Feel free to add a QA follow-up :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 09:56:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 07:56:38 +0000 Subject: [Koha-bugs] [Bug 31715] Add missing German translations for language descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31715 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 10:17:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 08:17:53 +0000 Subject: [Koha-bugs] [Bug 31465] Link system preference tabs to correct manual pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31465 Niamh Walker-Headon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Niamh.WalkerHeadon at hse.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 10:28:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 08:28:10 +0000 Subject: [Koha-bugs] [Bug 31738] Unstranslatable string in checkouts.js for recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31738 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 10:28:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 08:28:14 +0000 Subject: [Koha-bugs] [Bug 31738] Unstranslatable string in checkouts.js for recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31738 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141946|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 142303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142303&action=edit Bug 31738: Fix untranslatable string for recalls To test translation: 1. Apply patch and update your po files using: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation 2. Verify the string appears in po files now and translate it 3. Install the language To test functionality: 1. Turn on recalls 1.1. In Administration > Global system preferences, enable UseRecalls 1.2. Add recalls permissions in your circulation rules 2. In the OPAC, log in as a patron 3. Find a record with checked out items and place a recall 4. In the intranet, go to the patron file of the patron who currently has that item checked out --> In the Checkouts table at the bottom of the page, there is a red message next to the recalled title Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 10:28:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 08:28:34 +0000 Subject: [Koha-bugs] [Bug 31738] Unstranslatable string in checkouts.js for recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31738 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 10:35:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 08:35:24 +0000 Subject: [Koha-bugs] [Bug 31888] In Elasticsearch mappings page save button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31888 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142243|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 142304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142304&action=edit Bug 31888: Define save button as primary in Elasticsearch mappings page Like Bug 31810, save button in Elasticsearch mappings page is the most important action on this form, it should be yellow. Test plan : Go to Administration > Search engine configuration (Elasticsearch) => Check save button has class btn-primary and is yellow Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 10:35:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 08:35:35 +0000 Subject: [Koha-bugs] [Bug 31888] In Elasticsearch mappings page save button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31888 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 10:39:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 08:39:17 +0000 Subject: [Koha-bugs] [Bug 31850] Patron import: welcome email option style as list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31850 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142100|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 142305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142305&action=edit Bug 31850: Patron import: welcome email option style as list This patch corrects the markup around the "Send email to new patrons" checkbox on the patron import page. The list should be an ordered list, not an unordered list. To test, apply the patch and go to Tools -> Import patrons. In the "Welcome email" section, there should be no bullet point before the "Send email to new patrons" line. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 10:39:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 08:39:32 +0000 Subject: [Koha-bugs] [Bug 31850] Patron import: welcome email option style as list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31850 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 10:41:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 08:41:55 +0000 Subject: [Koha-bugs] [Bug 31848] Holds queue: Submit button for filters on the left is closer to nav than to its form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31848 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142092|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 142306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142306&action=edit Bug 31848: Correct margin and padding on action fieldset in aside This patch makes a minor modification to the padding and margin of
    nested in a .brief fieldset. This markup is seen most often in sidebar filter form. The change allows the submit button to line up better with other form fields. The patch also corrects and inconsistency by modifying the holds queue template so that the .action fieldset is inside the .brief fieldset. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - If necessary, place one or more holds for pickup at your logged-in library and rebuild the holds queue (misc/cronjobs/holds/build_holds_queue.pl) - Go to Circulation -> Holds queue. - The form should look correct. - Submit the form and check the form in the sidebar. It should look correct as well, with the submit button aligned left with the other form fields. - Check pages with similar sidebar forms, e.g.: - Administration -> Budgets -> Funds -> Planning - Circulation -> Overdues - Circulation -> Holds to pull - Acquisitions -> Invoices -> Search results Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 10:42:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 08:42:29 +0000 Subject: [Koha-bugs] [Bug 31848] Holds queue: Submit button for filters on the left is closer to nav than to its form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31848 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 10:43:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 08:43:00 +0000 Subject: [Koha-bugs] [Bug 31848] Holds queue: Submit button for filters on the left is closer to nav than to its form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31848 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 10:47:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 08:47:56 +0000 Subject: [Koha-bugs] [Bug 31894] Extend Hold hooks with more actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894 --- Comment #4 from Stefan Berndtsson --- I can't say why all the others did it this way. My hooks were just copies of the model used everywhere else. I can reason about a situation where it will likely matter. If the plugin forks/threads before doing its work, there is a chance that the originally stored object has been changed after the hook is called, but before the plugin has actually done its work. By fetching a new object, this is not the case. I also do remember having seen a situation where the state of $self after store was not the same as the newly fetched object, but I can't recall how or where this was the case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 10:49:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 08:49:24 +0000 Subject: [Koha-bugs] [Bug 31894] Extend Hold hooks with more actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #5 from Stefan Berndtsson --- Setting it back to Signed off, since nothing has changed in the patch, and clarification was provided. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 10:53:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 08:53:22 +0000 Subject: [Koha-bugs] [Bug 31896] New Recall hook when adding recall In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142279|0 |1 is obsolete| | --- Comment #5 from Stefan Berndtsson --- Created attachment 142307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142307&action=edit Bug 31896: New after_recall_action hook Hooks added: after_recall_action with new action add How to test: Run tests in t/db_dependent/Koha/Plugins/Recall_hooks.t Sponsored by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 10:54:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 08:54:11 +0000 Subject: [Koha-bugs] [Bug 31896] New Recall hook when adding recall In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Stefan Berndtsson --- Now passes QA in my system. Fixed file permissions and trailing whitespace. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 10:55:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 08:55:53 +0000 Subject: [Koha-bugs] [Bug 31897] New hook when indexing with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142280|0 |1 is obsolete| | --- Comment #4 from Stefan Berndtsson --- Created attachment 142308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142308&action=edit Bug 31897: New before_index_action hook for Elasticsearch Hooks added: before_index_action with new action update How to test: Run tests in t/db_dependent/Koha/Plugins/Elasticsearch_Indexer_hooks.t Sponsored by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 10:56:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 08:56:31 +0000 Subject: [Koha-bugs] [Bug 31897] New hook when indexing with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Stefan Berndtsson --- Fixed file permissions and some trailing whitespace in this one as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 10:58:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 08:58:38 +0000 Subject: [Koha-bugs] [Bug 31897] New hook when indexing with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897 --- Comment #6 from Marcel de Rooy --- (In reply to Stefan Berndtsson from comment #5) > Fixed file permissions and some trailing whitespace in this one as well. If you only do cosmetic fixing, keep the previous signoff line and change status back to Signed off. No need to wait for another signoff imo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 10:59:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 08:59:08 +0000 Subject: [Koha-bugs] [Bug 31895] New Account hook when adding credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31895 --- Comment #4 from Stefan Berndtsson --- I'm unclear about this one. I agree it looks strange. It comes from all other files. Holds_hooks.t, Circulation_hooks.t, Patron.t Barcode_transform_hooks.t and so on all have it in this order. I don't know why. I can change it easily of course, so it's not a big deal. There is also some unfixed traling whitespace in this one still remaining that I haven't updated yet. If I should swap the order of those two lines, I'll do that and fix whitespace at the same time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 10:59:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 08:59:31 +0000 Subject: [Koha-bugs] [Bug 31806] Add 'page-section' to holds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 --- Comment #3 from Martin Renvoize --- Created attachment 142309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142309&action=edit Bug 31806: Add page-section to holds tables This patch adds the page-section class to each holds view on reserve/request.pl Test plan 1) Find an biblio to test on and add holds items of different types and homebranches. 2) Work through each setting of the HoldsSplitQueue preference and confirm the page-sections appear as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:00:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:00:51 +0000 Subject: [Koha-bugs] [Bug 31806] Add 'page-section' to holds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:03:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:03:38 +0000 Subject: [Koha-bugs] [Bug 31806] Add 'page-section' to holds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 --- Comment #4 from Martin Renvoize --- I wasn't entirely sure where to put the page-section on this one.. especially given the various options for HoldsSplitQueue. At the moment, I've sectioned off each 'Split' as governed by HoldsSplitQueue.. but the argument could be made that the whole 'Existing holds' form could be a single page-section container? Also.. do the buttons look a bit crowded together for anyone else.. probabably a different bug entirely, but I think the markup there might be wrong too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:11:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:11:22 +0000 Subject: [Koha-bugs] [Bug 31806] Add 'page-section' to holds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 --- Comment #5 from Martin Renvoize --- Created attachment 142310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142310&action=edit Bug 31806: Add page-section container to existing holds This patch adds a page-section container around the existing holds content section -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:12:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:12:15 +0000 Subject: [Koha-bugs] [Bug 31806] Add 'page-section' to holds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #6 from Martin Renvoize --- OK.. after a little more testing I decided a container around the whole existing holds section feels like it makes more sense.. second patch attached does this so you can test one after the other if you'd like to see the distinction. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:16:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:16:16 +0000 Subject: [Koha-bugs] [Bug 31902] New: Inconsistent table formatting for 'Existing holds' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902 Bug ID: 31902 Summary: Inconsistent table formatting for 'Existing holds' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, katrin.fischer at bsz-bw.de, koha-bugs at lists.koha-community.org, testopia at bugs.koha-community.org Depends on: 31834 Blocks: 31833 The table(s) on reserves/request.pl for Existing holds have inconsistent formatting. The top header is missing a line beneath it for each table which is inconsistent with other pages. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31833 [Bug 31833] [Omnibus] Fix table inconsistencies https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 [Bug 31834] Inconsistent table formatting for list of MARC imports -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:16:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:16:16 +0000 Subject: [Koha-bugs] [Bug 31834] Inconsistent table formatting for list of MARC imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31902 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902 [Bug 31902] Inconsistent table formatting for 'Existing holds' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:16:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:16:16 +0000 Subject: [Koha-bugs] [Bug 31833] [Omnibus] Fix table inconsistencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31833 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31902 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902 [Bug 31902] Inconsistent table formatting for 'Existing holds' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:16:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:16:37 +0000 Subject: [Koha-bugs] [Bug 31902] Inconsistent table formatting for 'Existing holds' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|31834 |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 [Bug 31834] Inconsistent table formatting for list of MARC imports -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:16:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:16:37 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31902 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902 [Bug 31902] Inconsistent table formatting for 'Existing holds' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:16:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:16:37 +0000 Subject: [Koha-bugs] [Bug 31834] Inconsistent table formatting for list of MARC imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31902 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902 [Bug 31902] Inconsistent table formatting for 'Existing holds' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:17:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:17:24 +0000 Subject: [Koha-bugs] [Bug 31834] Inconsistent table formatting for list of MARC imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30952 CC| |martin.renvoize at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:17:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:17:24 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31834 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 [Bug 31834] Inconsistent table formatting for list of MARC imports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:17:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:17:35 +0000 Subject: [Koha-bugs] [Bug 31833] [Omnibus] Fix table inconsistencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31833 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Depends on|30952 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:17:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:17:35 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31833 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31833 [Bug 31833] [Omnibus] Fix table inconsistencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:20:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:20:18 +0000 Subject: [Koha-bugs] [Bug 31811] Add 'page-section' to MARC modification templates pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142281|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 142311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142311&action=edit Bug 31811: Add 'page-section' to MARC modification templates pages This patch adds "page-section" divs to the MARC modification templates template so that sections are properly defined and content has adequate contrast. Note: The patch includes indentation changes, so please ignore whitespace when checking the diff. To test, apply the patch and go to Cataloging -> MARC modification templates. The main content should be surrounded by a white box whether you're looking at the list of templates, the the action add/edit form. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:21:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:21:04 +0000 Subject: [Koha-bugs] [Bug 31811] Add 'page-section' to MARC modification templates pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com --- Comment #4 from Martin Renvoize --- `git diff -w` comes in handy with these paches ;p All looks good, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:24:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:24:43 +0000 Subject: [Koha-bugs] [Bug 31903] New: Article requests: Edit URLs link missing in the New tab Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31903 Bug ID: 31903 Summary: Article requests: Edit URLs link missing in the New tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Trivial fix. The format should be passed along like we do for the other tables. Found in 21.11. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:24:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:24:57 +0000 Subject: [Koha-bugs] [Bug 31903] Article requests: Edit URLs link missing in the New tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31903 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:25:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:25:06 +0000 Subject: [Koha-bugs] [Bug 31903] Article requests: Edit URLs link missing in the New tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31903 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:25:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:25:14 +0000 Subject: [Koha-bugs] [Bug 31903] Article requests: Edit URLs link missing in the New tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31903 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:26:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:26:11 +0000 Subject: [Koha-bugs] [Bug 31829] Change password form in patron account is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31829 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142234|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 142312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142312&action=edit Bug 31829: Fix change password form alignment This patch gives the fieldset on member-password.tt the class row. It also moves the hints below the list. To test: 1. Apply patch 2. Pull up a patron record and go to 'Change password'. 3. Make sure the form now looks good. 4. Also check and make sure the form is still functional. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:26:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:26:29 +0000 Subject: [Koha-bugs] [Bug 31829] Change password form in patron account is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31829 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:31:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:31:33 +0000 Subject: [Koha-bugs] [Bug 31903] Article requests: Edit URLs link missing in the New tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31903 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:31:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:31:37 +0000 Subject: [Koha-bugs] [Bug 31903] Article requests: Edit URLs link missing in the New tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31903 --- Comment #1 from Marcel de Rooy --- Created attachment 142313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142313&action=edit Bug 31903: Fix missing Edit URL link We need to pass format too for New tab (see Pending/Processing). Test plan: Include SCAN format in AR preferences. Check circ rules too. Add a new request. Check Circulation, Article requests, New tab. Verify that the Actions menu for a single row (!) does contain the option now. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:32:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:32:08 +0000 Subject: [Koha-bugs] [Bug 31903] Article requests: Edit URLs link missing in the New tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31903 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from Marcel de Rooy --- Trivial one-liner, not widely used (yet). Self SO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:37:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:37:13 +0000 Subject: [Koha-bugs] [Bug 31904] New: The 'action' fieldset following another fieldset feels disparate to the form Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31904 Bug ID: 31904 Summary: The 'action' fieldset following another fieldset feels disparate to the form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The 'action' fieldset that we use to contain our action buttons at the end of a form now feels distinct from the form itself.. the combined margin and padding of the two fieldsets one above the over leads to a lot of 'greyspace' between the 'box' of the form input section and the buttons in the action fieldset. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:38:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:38:19 +0000 Subject: [Koha-bugs] [Bug 31904] The 'action' fieldset following another fieldset feels disparate to the form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31904 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:38:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:38:19 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31904 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31904 [Bug 31904] The 'action' fieldset following another fieldset feels disparate to the form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:38:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:38:41 +0000 Subject: [Koha-bugs] [Bug 31904] The 'action' fieldset following another fieldset feels disparate to the form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31904 --- Comment #1 from Martin Renvoize --- Created attachment 142314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142314&action=edit Example -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:49:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:49:06 +0000 Subject: [Koha-bugs] [Bug 31905] New: Buttons lack spacing on Holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 Bug ID: 31905 Summary: Buttons lack spacing on Holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 31806 The buttons on the reserves/request.pl page have no spacing between them. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 [Bug 31806] Add 'page-section' to holds page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:49:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:49:06 +0000 Subject: [Koha-bugs] [Bug 31806] Add 'page-section' to holds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31905 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 [Bug 31905] Buttons lack spacing on Holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:49:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:49:24 +0000 Subject: [Koha-bugs] [Bug 31905] Buttons lack spacing on Holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 --- Comment #1 from Martin Renvoize --- Created attachment 142315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142315&action=edit Example -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:54:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:54:40 +0000 Subject: [Koha-bugs] [Bug 31902] Inconsistent table formatting for 'Existing holds' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30952 |31806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 [Bug 31806] Add 'page-section' to holds page -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:54:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:54:40 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31902 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902 [Bug 31902] Inconsistent table formatting for 'Existing holds' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:54:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:54:40 +0000 Subject: [Koha-bugs] [Bug 31806] Add 'page-section' to holds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31902 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902 [Bug 31902] Inconsistent table formatting for 'Existing holds' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 11:57:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 09:57:20 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #118 from Jonathan Druart --- (This is so AWESOME!) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 12:07:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 10:07:50 +0000 Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759 --- Comment #10 from Martin Renvoize --- So the current tabs is inconsistent with the cards we're using elsewhere.. I think the question is really around how do we make it look like it belongs with all the other elements on the page rather than sticking out as different. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 12:09:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 10:09:06 +0000 Subject: [Koha-bugs] [Bug 31750] Need more padding in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 12:13:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 10:13:50 +0000 Subject: [Koha-bugs] [Bug 31750] Need more padding in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142095|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 142316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142316&action=edit Bug 31750: Need more padding in cataloguing This patch makes some minor tweaks to the CSS controlling the appearance of the toolbar shown in the basic cataloging editor. To test, apply the patch and go to Cataloging -> New record. - Confirm that the page looks correct, with the toolbar the same width as the main content of the page. - Confirm that the toolbar looks correct when you scroll and the toolbar "floats" Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 12:13:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 10:13:55 +0000 Subject: [Koha-bugs] [Bug 31750] Need more padding in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142096|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 142317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142317&action=edit Bug 31750: (follow-up) Stylelint fixes This patch makes no changes which affect the style of the page. All changes are corrections to formatting. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 12:14:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 10:14:19 +0000 Subject: [Koha-bugs] [Bug 31750] Need more padding in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize --- Solid improvements here.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 12:15:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 10:15:59 +0000 Subject: [Koha-bugs] [Bug 31750] Need more padding in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 --- Comment #11 from Martin Renvoize --- It may be my eyes... but isn't the 'Cancel' link mis-aligned slightly.. apearing slightly above the content of the buttons in the toolbar? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 12:17:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 10:17:32 +0000 Subject: [Koha-bugs] [Bug 31750] Need more padding in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 --- Comment #12 from Martin Renvoize --- Nah.. it's my eyes.. inspecting it suggests it's all the same padding etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 12:20:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 10:20:41 +0000 Subject: [Koha-bugs] [Bug 31751] Breadcrumb style In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- I think I just about prefer the old style rather than the new caret icon... but it's a close call for me.. I like them both better than the current `/` -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 12:20:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 10:20:56 +0000 Subject: [Koha-bugs] [Bug 31751] Breadcrumb style In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 12:21:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 10:21:15 +0000 Subject: [Koha-bugs] [Bug 31751] Breadcrumb style In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 12:23:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 10:23:17 +0000 Subject: [Koha-bugs] [Bug 31753] Dialog boxes inside of modals don't seem wide enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 12:32:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 10:32:47 +0000 Subject: [Koha-bugs] [Bug 31753] Dialog boxes inside of modals don't seem wide enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 --- Comment #6 from Martin Renvoize --- Hate to say it, but I think I agree with David.. I thought I'd prefer the friendlier green for the modal headers/footers but actually I find the contrast between the linked green and the background of the header/footer not as nice... wonder if there's a slight middle ground. I'm not a big color pallet guru though.. I'd love to see our greens a little more standardized.. I prefer our bugzilla/koha-community.org/git.koha-community.org green to the green we use for the new search header bar for example.... though that doesn't really relate to this directly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 12:37:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 10:37:07 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 12:37:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 10:37:57 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 12:38:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 10:38:01 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139816|0 |1 is obsolete| | Attachment #139943|0 |1 is obsolete| | Attachment #139944|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 142318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142318&action=edit Bug 22678: Use Koha::Logger for Mojolicious API logger This patch adds Koha::Logger as the Mojolicious logging object for the API Mojolicious app. Test plan: 0. Apply the patch and koha-plack --restart kohadev 1. Add $c->app->log->debug('DEBUG') and $c->app->log->warn('WARN') to a API controller like Koha::REST::V1::Libraries 2. koha-plack --restart kohadev 3. Go to the API route tied to that API controller method 4. Look at /var/log/koha/kohadev/api-error.log 5. Note that 'WARN' appears but 'DEBUG' does not Signed-off-by: Marcel de Rooy [EDIT] Adding a context sub to Koha::Logger to get it working. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 12:38:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 10:38:13 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 --- Comment #22 from Kyle M Hall --- Created attachment 142319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142319&action=edit Bug 22678: Replace a few unneeded Koha::Logger calls We have Koha::Logger via the Mojo app now. Test plan: Run perl t/db_dependent/api/v1/unhandled_exceptions.t Your plack-api-error.log should contain something like: [2022/08/29 12:15:25] [ERROR] DELETE /api/v1/patrons/1052: unhandled exception (Koha::Exception)<> Bonus: Add one line to Koha/REST/Plugin/PluginRoutes.pm: $app->log->error('PluginRoutes L49'); Before the line with if ( C4::Context->config("enable_plugins") ) Restart and hit the API once again. Your log should contain: [2022/08/29 12:21:55] [ERROR] PluginRoutes L49 This serves to demonstrate that the $api->log change in PluginRoutes works. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 12:38:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 10:38:19 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 --- Comment #23 from Kyle M Hall --- Created attachment 142320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142320&action=edit Bug 22678: (follow-up) Array ref expected in context key Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 12:42:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 10:42:21 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 12:52:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 10:52:35 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141469|0 |1 is obsolete| | Attachment #141470|0 |1 is obsolete| | Attachment #141471|0 |1 is obsolete| | Attachment #141472|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall --- Created attachment 142321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142321&action=edit Bug 29987: Add register support to manual credits This patch adds the register and transaction type selection options to the manual credit page. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 12:52:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 10:52:51 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #31 from Kyle M Hall --- Created attachment 142322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142322&action=edit Bug 29987: (follow-up) Fix missing payment type The payment type include has changed since the patch was first written, we now require a 'type' is passed to properly set the field name. This should fix the 'bankable' issue raised. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 12:52:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 10:52:55 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #32 from Kyle M Hall --- Created attachment 142323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142323&action=edit Bug 29987: Display credit without offsets in transactions This patch adds a row to the transactions table for credits without corresponding offsets Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 12:52:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 10:52:59 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #33 from Kyle M Hall --- Created attachment 142324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142324&action=edit Bug 29987: Improve validation This patch adds hinting to display the required state of the cash register fields. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 12:53:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 10:53:03 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #34 from Kyle M Hall --- Created attachment 142325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142325&action=edit Bug 29987: (QA follow-up) Remove unused cnt attribute missing a filter Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:01:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:01:34 +0000 Subject: [Koha-bugs] [Bug 31753] Dialog boxes inside of modals don't seem wide enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142202|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 142326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142326&action=edit Bug 31753: Dialog boxes inside of modals don't seem wide enough This patch makes some tweaks to the style of Bootstrap modals in the staff interface, including making a correction to the style of .dialog
    s within modals. The patch makes a correction to the modal markup generated by the guided reports template for SQL previews so that the modal footer displays correctly. The patch also removes CSS which makes links inside headings the same color as the heading text. The effect of this was to make links invisible in the headings of hold confirmation modals. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Test the hold confirmation modal in check-in: - Place a hold on an available title. - Check in an item from that record and confirm that the modal looks correct. The "Check in message" box should take up the whole width of the modal, and the links in the modal header should be the standard green. - Test the SQL preview modal in reports: - Go to Reports -> Use saved. - Click the actions menu associated with one of your saved reports and choose "Preview SQL." The modal should look correct. - Other modals which might be tested: MARC previews from the bibliographic detail page, the cataloging search page, the Z39.50 search page, etc. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:01:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:01:39 +0000 Subject: [Koha-bugs] [Bug 31753] Dialog boxes inside of modals don't seem wide enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 --- Comment #8 from Martin Renvoize --- Created attachment 142327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142327&action=edit Bug 31753: (follow-up) lighten headers more OK.. colors are hard!.. This patch increases the 'lighten' parameter a little and hopefully improves the headers and footers of modals slighty back to being less 'bright' green. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:03:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:03:00 +0000 Subject: [Koha-bugs] [Bug 31753] Dialog boxes inside of modals don't seem wide enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize --- OK.. colors shouldn't hold this up... so Passing QA. I've added a follow-up with my attempt at a minor "improvement" to the final color however.. Attaching screen shot of 'before', 'first patch', 'follow-up' side by side for comparison now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:03:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:03:40 +0000 Subject: [Koha-bugs] [Bug 31753] Dialog boxes inside of modals don't seem wide enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 --- Comment #10 from Martin Renvoize --- Created attachment 142328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142328&action=edit Side by side comparisons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:04:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:04:09 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:11:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:11:53 +0000 Subject: [Koha-bugs] [Bug 31577] Use patron category multi-select for OpacHiddenItemsExceptions system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31577 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:11:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:11:57 +0000 Subject: [Koha-bugs] [Bug 31577] Use patron category multi-select for OpacHiddenItemsExceptions system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31577 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140972|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 142329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142329&action=edit Bug 31577: Use patron category multi-select for OpacHiddenItemsExceptions system preference We are now using the patron category selects on almost all system preferences, but OpacHiddenItemsExceptions was still missing. To test: - Before applying the patch: - Add patron categories to OpacHiddenItemsExceptions using | - Add configuration to OpacHiddenItems - Verify all works as expected in the OPAC - Apply patch, run database update - Verify the system preference shows the correct settings from before - Verify feature still works as expected Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:13:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:13:19 +0000 Subject: [Koha-bugs] [Bug 31693] Remove non-existent fields from the See-also-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31693 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |kyle at bywatersolutions.com CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:13:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:13:22 +0000 Subject: [Koha-bugs] [Bug 31690] Add see from tracings in See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31690 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |kyle at bywatersolutions.com CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:13:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:13:26 +0000 Subject: [Koha-bugs] [Bug 31689] Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31689 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:13:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:13:31 +0000 Subject: [Koha-bugs] [Bug 31691] Remove non-existent fields from the See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31691 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |kyle at bywatersolutions.com CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:13:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:13:50 +0000 Subject: [Koha-bugs] [Bug 31714] Add a more generic way to print patron slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:21:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:21:28 +0000 Subject: [Koha-bugs] [Bug 31754] Improve appearance of behavior of DataTables controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- This is looking good.. but Lucas's first point isn't addressed... if you hover over the 'first, previous, next, last' page controls, the bold on hover makes the interactive elements on the left 'jiggle' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:22:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:22:26 +0000 Subject: [Koha-bugs] [Bug 31754] Improve appearance of behavior of DataTables controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 --- Comment #9 from Martin Renvoize --- Created attachment 142330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142330&action=edit Video of hover effect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:22:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:22:55 +0000 Subject: [Koha-bugs] [Bug 31896] New Recall hook when adding recall In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:22:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:22:59 +0000 Subject: [Koha-bugs] [Bug 31896] New Recall hook when adding recall In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142307|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 142331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142331&action=edit Bug 31896: New after_recall_action hook Hooks added: after_recall_action with new action add How to test: Run tests in t/db_dependent/Koha/Plugins/Recall_hooks.t Sponsored by: Gothenburg University Library Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:29:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:29:47 +0000 Subject: [Koha-bugs] [Bug 31803] "remove from cart" button displayed even if not in cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31803 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:32:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:32:07 +0000 Subject: [Koha-bugs] [Bug 31421] Library limitation on patron category breaks patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:32:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:32:12 +0000 Subject: [Koha-bugs] [Bug 31421] Library limitation on patron category breaks patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 --- Comment #8 from Nick Clemens --- Created attachment 142332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142332&action=edit Bug 31421: (follow-up) Add POD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:32:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:32:21 +0000 Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:32:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:32:58 +0000 Subject: [Koha-bugs] [Bug 31689] Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31689 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:33:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:33:01 +0000 Subject: [Koha-bugs] [Bug 31689] Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31689 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141586|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 142333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142333&action=edit Bug 31689: Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21) This patch adds the following fields to the Match-heading-see-from index - 430(adfghklmnoprstvxyz) - 448(avxyz) - 450(abvxyz) - 451(avxyz) - 455(avxyz) Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:33:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:33:02 +0000 Subject: [Koha-bugs] [Bug 31422] Library limitations might cause data loss when editing patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Library limitations might |Library limitations might |cause data loss |cause data loss when | |editing patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:33:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:33:29 +0000 Subject: [Koha-bugs] [Bug 31422] Library limitations might cause data loss when editing patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 --- Comment #7 from Nick Clemens --- (In reply to Marcel de Rooy from comment #6) > If I am reading the comments, this patch only solves one issue but the > description is broader than that? Am I correct? Or will the other issue(s) > be addressed separately? Other issues handled on related bugs in 'See also' section -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:34:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:34:15 +0000 Subject: [Koha-bugs] [Bug 31690] Add see from tracings in See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31690 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:34:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:34:19 +0000 Subject: [Koha-bugs] [Bug 31690] Add see from tracings in See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31690 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141585|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 142334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142334&action=edit Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21) This patch adds the following fields to the See-from index - 450(abvxyz) - 451(avxyz) - 455(avxyz) Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:36:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:36:29 +0000 Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142289|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 142335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142335&action=edit Bug 31886: Fix no sidebar problem in system pref search To test: 1. Go to Adminstration and click on 'Global system preferences' 2. From the left side bar click 'I18N/L10N' and notice no sidebar. 3. Also try 'Serials', no sidebar 4. Apply patch, restart_all 5. Try 1 & 2 again and the sidebar should be restored 6. Try clicking through each of the system preference groups (Accounting, Acquisitions, etc ) and make sure the sidebar is always present. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:37:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:37:16 +0000 Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:39:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:39:00 +0000 Subject: [Koha-bugs] [Bug 31693] Remove non-existent fields from the See-also-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31693 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:39:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:39:04 +0000 Subject: [Koha-bugs] [Bug 31693] Remove non-existent fields from the See-also-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31693 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141584|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 142336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142336&action=edit Bug 31693 Remove non-existent fields from the See-also-from index (Elasticsearch, MARC21) This patch removes fields from the See-from index that don't exist in MARC21. The existing fields can be found here: https://www.loc.gov/marc/authority/ad5xx.html The following fields are removed: - 511$b - 511$m - 511$o - 511$r - 530$b - 530$c - 530$e - 547$b - 547$e - 547$f - 547$h - 547$j - 547$k - 547$l - 547$m - 547$n - 547$o - 547$p - 547$q - 547$r - 547$s - 547$t - 548$b - 548$c - 548$d - 548$e - 548$f - 548$g - 548$h - 548$k - 548$l - 548$m - 548$n - 548$o - 548$p - 548$r - 548$s - 548$t - 550$c - 550$d - 550$e - 550$f - 550$h - 550$j - 550$k - 550$l - 550$m - 550$n - 550$o - 550$p - 550$q - 550$r - 550$s - 550$t - 551$b - 551$c - 551$d - 551$e - 551$f - 551$h - 551$k - 551$l - 551$m - 551$n - 551$o - 551$p - 551$r - 551$s - 551$t - 555$b - 555$c - 555$d - 555$e - 555$f - 555$g - 555$h - 555$j - 555$k - 555$l - 555$m - 555$n - 555$o - 555$p - 555$q - 555$r - 555$s - 555$t - 562$b - 562$c - 562$d - 562$e - 562$f - 562$g - 562$h - 562$k - 562$l - 562$m - 562$n - 562$o - 562$p - 562$r - 562$s - 562$t Furthermore, the format of the mapping for 511 has been corrected. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:40:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:40:14 +0000 Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 --- Comment #4 from Martin Renvoize --- Well spotted Lucas... I wonder if instead of repeating the title we should pick a appropriate subsection group title instead. Perhaps 'Global' or 'Features' or something like that.. So something like? * Serials - Features * I18N - Global -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:41:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:41:14 +0000 Subject: [Koha-bugs] [Bug 31803] "remove from cart" button displayed even if not in cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31803 --- Comment #3 from Katrin Fischer --- I am going to pass this one as it's a clear bug fix, but there is a small remaining issue: When Add to cart is replaced with Remove from cart, the writing is not in line with the other options but displayed a little higher up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:42:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:42:07 +0000 Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 --- Comment #5 from Martin Renvoize --- Side note... it feels a bit weird that the 'You search for: TERM' is an H2 to me.. it means we end up with 'H1 > H2 > H2' and it doesn't stand out very well.. I'd be tempted to switch it to a span of some sort with it's own slightly different formatting? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:42:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:42:43 +0000 Subject: [Koha-bugs] [Bug 31803] "remove from cart" button displayed even if not in cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31803 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:42:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:42:47 +0000 Subject: [Koha-bugs] [Bug 31803] "remove from cart" button displayed even if not in cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31803 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142245|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 142337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142337&action=edit Bug 31803: "remove from cart" button displayed even if not in cart This patch modifies CSS related to the "Remove from cart" button associated with bibligraphic record views. A change in specificity of buttons made by Bug 30952 made it so that the button was no longer hidden correctly. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Locate a bibliographic record in the staff interface and view the detail page. - In the toolbar you should see an "Add to cart" button but not a "Remove from cart" button. - The buttons should correctly toggle on and off as you add and remove the title from the cart. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:43:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:43:35 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to basket.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:44:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:44:20 +0000 Subject: [Koha-bugs] [Bug 31691] Remove non-existent fields from the See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31691 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:44:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:44:26 +0000 Subject: [Koha-bugs] [Bug 31691] Remove non-existent fields from the See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31691 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141582|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 142338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142338&action=edit Bug 31691: Remove non-existent fields from the See-from index (Elasticsearch, MARC21) This patch removes fields from the See-from index that don't exist in MARC21. The existing fields can be found here: https://www.loc.gov/marc/authority/ad4xx.html The following fields are removed: - 411$b - 411$m - 411$o - 411$r - 430$b - 430$c - 430$e - 440(abcdefghjklmnopqrstvxyz) (all of them, 440 doesn't exist at all) - 441(abcdefghklmnoprstvxyz) (all of them, 441 doesn't exist at all) - 444(abcdefghjklmnopqrstvxyz) (all of them, 444 doesn't exist at all) - 447$b - 447$e - 447$f - 447$h - 447$j - 447$k - 447$l - 447$m - 447$n - 447$o - 447$p - 447$q - 447$r - 447$s - 447$t - 448$b - 448$c - 448$d - 448$e - 448$f - 448$g - 448$h - 448$k - 448$l - 448$m - 448$n - 448$o - 448$p - 448$r - 448$s - 448$t - 462$b - 462$c - 462$d - 462$e - 462$f - 462$g - 462$h - 462$k - 462$l - 462$m - 462$n - 462$o - 462$p - 462$r - 462$s - 462$t - 462$v - 462$x - 462$y - 462$z Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:50:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:50:44 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to basket.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 --- Comment #3 from Katrin Fischer --- This one is confusing to me... it fixes the basket page, but it looks like I intended to file for parcels? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:50:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:50:57 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to basket summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add page-section to |Add page-section to basket |basket.tt |summary page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:52:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:52:09 +0000 Subject: [Koha-bugs] [Bug 31684] Plugin versions starting with a "v" cause unnecessary warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31684 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #9 from Tomás Cohen Arazi --- Why don't we force some coding line to align plugin authors about verisoning instead? Plugins could just be forced to use semvers? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:55:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:55:15 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to basket summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 --- Comment #4 from Katrin Fischer --- Ok, I see waht happened here... this is actually the fix for bug 31820 :P I'll switch things around a bit, so we also have a bug for the receive page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:55:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:55:29 +0000 Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:55:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:55:48 +0000 Subject: [Koha-bugs] [Bug 31820] Add page-section to order receive page (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31820 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add page-section to basket |Add page-section to order |summary page (acq) |receive page (acq) --- Comment #2 from Katrin Fischer --- When receiving a shipment, the list of pending and then received orders (table below the first one) requires the treatment with page-section classes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:56:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:56:43 +0000 Subject: [Koha-bugs] [Bug 31906] New: Managed by on basket summary page is misaligned Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31906 Bug ID: 31906 Summary: Managed by on basket summary page is misaligned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:56:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:56:43 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31906 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31906 [Bug 31906] Managed by on basket summary page is misaligned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:57:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:57:47 +0000 Subject: [Koha-bugs] [Bug 31906] Managed by on basket summary page is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31906 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31837 --- Comment #1 from Katrin Fischer --- At the top part of the basket summary page the "managed by" is misaligned. Also: bug 31837 added page-section to the order parts - should we also do the same for the information on top? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 13:57:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 11:57:47 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to basket summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31906 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:01:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:01:19 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to basket summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 --- Comment #5 from Katrin Fischer --- Hi Lucas, compared this to some other pages and it looks like the h2/h3 are usually inside the page-section. Could we move them here as well? The h1 appears to always be outside. For comparison see patron form, patron details and patron import. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:01:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:01:26 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to basket summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:06:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:06:09 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #395 from Jonathan Druart --- - &.cancel { - padding-left: 1em; Why did we remove the padding on the "cancel" links? How do we separate the "submit" button and the "cancel" link now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:20:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:20:36 +0000 Subject: [Koha-bugs] [Bug 31907] New: Show items as On hold when in processing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31907 Bug ID: 31907 Summary: Show items as On hold when in processing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: stefan.berndtsson at ub.gu.se QA Contact: testopia at bugs.koha-community.org The addition of the Processing reserve status should show status in Opac as On hold, just like it does for Waiting. This patch adds that to item list in opac-detail and opac-basket. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:21:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:21:13 +0000 Subject: [Koha-bugs] [Bug 31907] Show items as On hold when in processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31907 --- Comment #1 from Stefan Berndtsson --- Created attachment 142339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142339&action=edit Bug 31907: Show items as On hold when in processing Test plan: 1. Make sure syspref "opacbookbag" is set to "Allow". 2. Make sure syspref "HoldsNeedProcessingSIP" is set to "Don't fulfill". 3. Place a hold on an item. 4. Return item via SIP at the pickup library. 5. View biblio in Opac. 6. Note that it says "Available" as status. 7. Add biblio to Cart. 8. Open Cart. 9. Note that it says "Available" as status. 10. Apply patch. 11. Reload Opac page. 12. It should now say "On hold". 13. Reload Card page. 14. It should also say "On hold". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:22:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:22:01 +0000 Subject: [Koha-bugs] [Bug 31907] Show items as On hold when in processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31907 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |stefan.berndtsson at ub.gu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:23:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:23:43 +0000 Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:23:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:23:47 +0000 Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141572|0 |1 is obsolete| | Attachment #141575|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 142340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142340&action=edit Bug 31713: Add FEE_SUMMARY print slip link Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:24:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:24:01 +0000 Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 --- Comment #9 from Kyle M Hall --- Created attachment 142341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142341&action=edit Bug 31713: Add FEE_SUMMARY slip template This patch adds the new FEE_SUMMARY print slip notice template to the database. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:24:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:24:06 +0000 Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 --- Comment #10 from Kyle M Hall --- Created attachment 142342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142342&action=edit Bug 31713: (QA follow-up) Add current date to slip Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:24:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:24:47 +0000 Subject: [Koha-bugs] [Bug 31714] Add a more generic way to print patron slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:24:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:24:51 +0000 Subject: [Koha-bugs] [Bug 31714] Add a more generic way to print patron slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141587|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 142343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142343&action=edit Bug 31714: Add Generic way to print patron slips This patch adds a very simple controller and template to allow patron slip printing without all the boilerplate. See bug 31713 for an example use. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:27:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:27:06 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:27:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:27:11 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141978|0 |1 is obsolete| | --- Comment #60 from Nick Clemens --- Created attachment 142344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142344&action=edit Bug 30588: Add 'enforced' option to TwoFactorAuthentication Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:27:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:27:15 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141979|0 |1 is obsolete| | --- Comment #61 from Nick Clemens --- Created attachment 142345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142345&action=edit Bug 30588: Adjust existing occurrences of TwoFactorAuthentication We need to replace 0 with 'disabled', and 1 with 'enabled' Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:27:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:27:20 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141980|0 |1 is obsolete| | --- Comment #62 from Nick Clemens --- Created attachment 142346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142346&action=edit Bug 30588: Add the option to require 2FA setup on first staff login Bug 28786 added the ability to turn on a two-factor authentication, using a One Time Password (OTP). Once enabled on the system, librarian had the choice to enable or disable it for themselves. For security reason an administrator could decide to force the librarians to use this second authentication step. This patch adds a third option to the existing syspref, 'Enforced', for that purpose. QA notes: the code we had in the members/two_factor_auth.pl controller has been moved to REST API controller methods (with their tests and swagger specs), for reusability reason. Code from template has been moved to an include file for the same reason. Test plan: A. Regression tests As we modified the code we need first to confirm the existing features are still working as expected. 1. Turn off TwoFactorAuthentication (disabled) and confirm that you are not able to enable and access the second authentication step 2. Turn it on (enabled) and confirm that you are able to enable it in your account 3. Logout and confirm then that you are able to login into Koha B. The new option 1. Set the pref to "enforced" 2. You are not logged out, logged in users stay logged in 3. Pick a user that does not have 2FA setup, login 4. Notice the new screen (UI is a bit ugly, suggestions welcomed) 5. Try to access Koha without enabling 2FA, you shouldn't be able to access any pages 6. Setup 2FA and confirm that you are redirected to the login screen 7. Login, send the correct pin code => You are fully logged in! Note that at 6 we could redirect to the mainpage, without the need to login again, but I think it's preferable to reduce the change to C4::Auth. If it's considered mandatory by QA I could have a look on another bug report. Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:27:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:27:26 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141981|0 |1 is obsolete| | --- Comment #63 from Nick Clemens --- Created attachment 142347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142347&action=edit Bug 30588: Adjust existing selenium tests Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:27:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:27:30 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141982|0 |1 is obsolete| | --- Comment #64 from Nick Clemens --- Created attachment 142348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142348&action=edit Bug 30588: Add tests for the REST API routes Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:27:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:27:34 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141983|0 |1 is obsolete| | --- Comment #65 from Nick Clemens --- Created attachment 142349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142349&action=edit Bug 30588: Add selenium tests Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:27:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:27:39 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141984|0 |1 is obsolete| | --- Comment #66 from Nick Clemens --- Created attachment 142350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142350&action=edit Bug 30588: Add tests for C4::checkauth Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:27:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:27:48 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141985|0 |1 is obsolete| | --- Comment #67 from Nick Clemens --- Created attachment 142351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142351&action=edit Bug 30588: Add missing atomic update Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:28:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:28:21 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141986|0 |1 is obsolete| | --- Comment #68 from Nick Clemens --- Created attachment 142352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142352&action=edit Bug 30588: Add missing include file Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:28:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:28:26 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141987|0 |1 is obsolete| | --- Comment #69 from Nick Clemens --- Created attachment 142353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142353&action=edit Bug 30588: (QA follow-up) Typos in sysprefs.sql The codebase uses disabled and enforced which is imo better too. So we need to fix this sql file. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:28:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:28:40 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141988|0 |1 is obsolete| | --- Comment #70 from Nick Clemens --- Created attachment 142354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142354&action=edit Bug 30588: (QA follow-up) Missing shebang in TwoFactorAuth.t Test plan: Try t/db_dependent/Koha/Auth/TwoFactorAuth.t on cmd line. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:28:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:28:45 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141989|0 |1 is obsolete| | --- Comment #71 from Nick Clemens --- Created attachment 142355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142355&action=edit Bug 30588: (QA follow-up) Remove erroneous FIXME Comment speaks for itself. Look at surrounding code. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:28:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:28:49 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141990|0 |1 is obsolete| | --- Comment #72 from Nick Clemens --- Created attachment 142356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142356&action=edit Bug 30588: (QA follow-up) Auth - remove two warns and second logout Resolves: Use of uninitialized value $request_method in string eq at /usr/share/koha/C4/Auth.pm line 1122. Use of uninitialized value $return in numeric gt (>) at /usr/share/koha/C4/Auth.pm line 1155. We also remove the double logout from Auth.t Test plan: Run t/db_dependent/Auth.t Check if you do not see the warns anymore. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:28:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:28:54 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141991|0 |1 is obsolete| | --- Comment #73 from Nick Clemens --- Created attachment 142357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142357&action=edit Bug 30588: (QA follow-up) Adjust flags for two_factor_auth.pl Anyone with staff access (catalogue) should be able to go to account and enable 2FA. Test plan: Have a staff user with minimum staff permission. Access account, manage 2FA. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:28:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:28:59 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141992|0 |1 is obsolete| | --- Comment #74 from Nick Clemens --- Created attachment 142358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142358&action=edit Bug 30588: (QA follow-up) Clear waiting-for-2FA-setup in session If we do not clear this session, the first login directly after setup does not really enhances user experience ;) Test plan: Make sure 2FA is enforced. Test the above. Disable your 2FA, logout and login. Verify that you can access pages with this patch now. Without this patch you could not. Run these tests to provide more confidence: t/db_dependent/Auth.t t/db_dependent/api/v1/two_factor_auth.t t/db_dependent/Koha/Auth/TwoFactorAuth.t Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:32:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:32:30 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #75 from Nick Clemens --- This all works nicely, minor requests: When a user is configuring 2FA and it is enforced, it would be nice to have a message telling them they must set this up - yes, it doesn't let you in without, but still nice to say so I wondered at first why a user can disable 2FA when it is enforced, but I suppose it is so they can setup a new authentication method? It should also state when enforced on this page, so the user knows they cannot truly disable Neither blockers, moving forward for RM review -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:32:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:32:44 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:49:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:49:19 +0000 Subject: [Koha-bugs] [Bug 31861] Table controls on checkouts table are buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:50:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:50:55 +0000 Subject: [Koha-bugs] [Bug 31861] Table controls on checkouts table are buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142198|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 142359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142359&action=edit Bug 31861: Table controls on checkouts table are buttons This patch updates the style of DataTables buttons (columns, export, and configure), in cases where the buttons are the only control being displayed (no page controls, filter, etc). To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Circulation and check an item out to a patron. - If necessary, click the "Show checkouts" button to reveal the table of checkouts. - The "Columns," "Export," and "Configure" controls should look the same as they do in other situations, with no button-style border. - Go to Circulation -> Check in and check in the item. The table of checked-in items should show the same style controls. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:51:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:51:27 +0000 Subject: [Koha-bugs] [Bug 31861] Table controls on checkouts table are buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Resolves issue found, improves consistency and no regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:52:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:52:48 +0000 Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142342|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 142360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142360&action=edit Bug 31713: (QA follow-up) Add current date to slip Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:54:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:54:28 +0000 Subject: [Koha-bugs] [Bug 31908] New: Context accessed but not always set on mainpage.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908 Bug ID: 31908 Summary: Context accessed but not always set on mainpage.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org To recreate: 1 - Sign in to staff interface as a user without 'catalogue' permission 2 - Get a message that you don't have access 3 - From that page, sign in as an authorised user 4 - Error: Can't use an undefined value as a HASH reference at /kohadevbox/koha/mainpage.pl line 88 I have also seen this error in production when using SSO and signing out of the staff client -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:54:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:54:47 +0000 Subject: [Koha-bugs] [Bug 31908] Context accessed but not always set on mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:58:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:58:31 +0000 Subject: [Koha-bugs] [Bug 28375] Inefficiencies in fetching COinS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:58:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:58:34 +0000 Subject: [Koha-bugs] [Bug 28375] Inefficiencies in fetching COinS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375 --- Comment #20 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:58:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:58:37 +0000 Subject: [Koha-bugs] [Bug 31738] Unstranslatable string in checkouts.js for recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31738 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:58:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:58:39 +0000 Subject: [Koha-bugs] [Bug 31738] Unstranslatable string in checkouts.js for recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31738 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:58:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:58:42 +0000 Subject: [Koha-bugs] [Bug 31750] Need more padding in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:58:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:58:45 +0000 Subject: [Koha-bugs] [Bug 31750] Need more padding in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 --- Comment #13 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:58:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:58:48 +0000 Subject: [Koha-bugs] [Bug 31803] "remove from cart" button displayed even if not in cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31803 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:58:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:58:51 +0000 Subject: [Koha-bugs] [Bug 31803] "remove from cart" button displayed even if not in cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31803 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:58:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:58:54 +0000 Subject: [Koha-bugs] [Bug 31810] Place hold button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:58:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:58:57 +0000 Subject: [Koha-bugs] [Bug 31810] Place hold button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:58:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:58:59 +0000 Subject: [Koha-bugs] [Bug 31811] Add 'page-section' to MARC modification templates pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:59:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:59:02 +0000 Subject: [Koha-bugs] [Bug 31811] Add 'page-section' to MARC modification templates pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:59:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:59:05 +0000 Subject: [Koha-bugs] [Bug 31829] Change password form in patron account is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31829 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:59:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:59:08 +0000 Subject: [Koha-bugs] [Bug 31829] Change password form in patron account is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31829 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:59:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:59:11 +0000 Subject: [Koha-bugs] [Bug 31884] In check in page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31884 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:59:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:59:13 +0000 Subject: [Koha-bugs] [Bug 31884] In check in page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31884 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:59:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:59:16 +0000 Subject: [Koha-bugs] [Bug 31885] In renew page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31885 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 14:59:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 12:59:19 +0000 Subject: [Koha-bugs] [Bug 31885] In renew page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31885 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:00:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:00:25 +0000 Subject: [Koha-bugs] [Bug 31909] New: Normalize semver for plugin versions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31909 Bug ID: 31909 Summary: Normalize semver for plugin versions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Highlighted by bug 31684, the project lacks a clear coding guideline about plugin versioning. I will propose to stick to semver [1] and this report is where we will submit the code to handle it. [1] https://semver.org/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:00:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:00:32 +0000 Subject: [Koha-bugs] [Bug 31909] Normalize semver for plugin versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31909 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31684 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31684 [Bug 31684] Plugin versions starting with a "v" cause unnecessary warnings -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:00:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:00:32 +0000 Subject: [Koha-bugs] [Bug 31684] Plugin versions starting with a "v" cause unnecessary warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31684 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31909 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31909 [Bug 31909] Normalize semver for plugin versions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:02:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:02:03 +0000 Subject: [Koha-bugs] [Bug 31684] Plugin versions starting with a "v" cause unnecessary warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31684 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:02:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:02:06 +0000 Subject: [Koha-bugs] [Bug 31684] Plugin versions starting with a "v" cause unnecessary warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31684 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:03:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:03:33 +0000 Subject: [Koha-bugs] [Bug 31908] Context accessed but not always set on mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908 --- Comment #1 from Nick Clemens --- Created attachment 142361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142361&action=edit Bug 31908: Only count local suggestions if there is a userenv -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:04:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:04:51 +0000 Subject: [Koha-bugs] [Bug 31908] Context accessed but not always set on mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908 --- Comment #2 from Nick Clemens --- Hmm..I though maybe we could just fix the front end, but it gets weird Apply patch Sign in as unauthorised user You are not allowed Sign in as authorised user Note username refers to unauthorised user -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:06:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:06:20 +0000 Subject: [Koha-bugs] [Bug 31908] Context accessed but not always set on mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #3 from Nick Clemens --- Not moving to security - you must have a vlid users authentication to get in - and accessing any page immediately logs you out again, but this is weird and bad, upping severity -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:07:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:07:33 +0000 Subject: [Koha-bugs] [Bug 31908] Context accessed but not always set on mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:10:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:10:39 +0000 Subject: [Koha-bugs] [Bug 31903] Article requests: Edit URLs link missing in the New tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31903 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:17:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:17:10 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #34 from Tomás Cohen Arazi --- Please rebase ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:17:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:17:11 +0000 Subject: [Koha-bugs] [Bug 31687] Add see from and see also from tracings in Match index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31687 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:17:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:17:17 +0000 Subject: [Koha-bugs] [Bug 31687] Add see from and see also from tracings in Match index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31687 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141581|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 142362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142362&action=edit Bug 31687: Add see from and see also from tracings in Match index This patch adds see from and see also from terms for uniform title, chronological term, topical term, geographic name, and genre/form term to the Match index in Elasticsearch for MARC21. Previously, only see from/see also from for personal names, corporate names, and meeting names were indexed. To test: 1. Without patch, import attached authority records 1.1. Download attached records 1.2. Go to Tools > Stage MARC records for import 1.3. Click 'Browse' and choose the downloaded file 1.4. Click 'Upload file' 1.5. Choose Record type = Authority 1.6. Click 'Stage for import' 1.7. From the job details, click 'View batch' 1.8. Click 'Import this batch into the catalog' 2. Without patch, search for see from and see also from tracings 2.1. Go to Authorities 2.2. In the 'Default' drop-down menu, choose 'Uniform title' 2.3. Choose the 'Search all headings' tab 2.4. Enter the search term 'Five hundred' 2.5. Click 'Submit' or press 'Enter' --> No results 2.6. Redo the search for the following search terms Authority type Search term Should be found in Uniform title five hundred 430 Uniform title films préférés 530 Chronological term fifteenth 448 Chronological term middle ages 548 Topical term lalopathie 450 Topical term troubles communication 550 Geographic name cécropia 451 Geographic name canada francophone 551 Genre/Form term filmiques 455 Genre/Form term films 555 3. Apply patch 4. Delete index, reset mappings and reindex authorities (with command line, -a -d -r) 5. Redo the searches from step 2, there should now be results Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:18:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:18:18 +0000 Subject: [Koha-bugs] [Bug 31861] Table controls on checkouts table are buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:18:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:18:28 +0000 Subject: [Koha-bugs] [Bug 31910] New: Article request form is misaligned/misformatted Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31910 Bug ID: 31910 Summary: Article request form is misaligned/misformatted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Created attachment 142363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142363&action=edit Article form in staff interface Make sure you activate ArticleRequests in system preferences and circulation rules. Search in staff interface, pick a record and request article. Search for the patron and look at the article form presented: * list points appear * fields and labels are mushed together * item selection should probably be a page-section Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:18:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:18:28 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31910 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31910 [Bug 31910] Article request form is misaligned/misformatted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:21:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:21:29 +0000 Subject: [Koha-bugs] [Bug 31588] Update cpanfile for new OpenAPI versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:21:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:21:33 +0000 Subject: [Koha-bugs] [Bug 31588] Update cpanfile for new OpenAPI versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141561|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall --- Created attachment 142364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142364&action=edit Bug 31588 - Update cpanfile for new OpenAPI versions (master) Signed-off-by: Mason James Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:26:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:26:59 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:27:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:27:02 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #35 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:27:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:27:06 +0000 Subject: [Koha-bugs] [Bug 31714] Add a more generic way to print patron slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:27:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:27:09 +0000 Subject: [Koha-bugs] [Bug 31714] Add a more generic way to print patron slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:27:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:27:12 +0000 Subject: [Koha-bugs] [Bug 31753] Dialog boxes inside of modals don't seem wide enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:27:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:27:14 +0000 Subject: [Koha-bugs] [Bug 31753] Dialog boxes inside of modals don't seem wide enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:27:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:27:18 +0000 Subject: [Koha-bugs] [Bug 31848] Holds queue: Submit button for filters on the left is closer to nav than to its form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31848 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:27:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:27:22 +0000 Subject: [Koha-bugs] [Bug 31848] Holds queue: Submit button for filters on the left is closer to nav than to its form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31848 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:31:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:31:17 +0000 Subject: [Koha-bugs] [Bug 31903] Article requests: Edit URLs link missing in the New tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31903 --- Comment #3 from Katrin Fischer --- Took me a little bit to find the missing piece: * Set ArticleRequestsSupportedFormats to PHOTOCOPY|SCAN * Create an article request for a digital copy. Maybe we could dig out the older bugs here and mark them needs documenting? Appears to be an interesting feature! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:33:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:33:57 +0000 Subject: [Koha-bugs] [Bug 31903] Article requests: Edit URLs link missing in the New tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31903 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:33:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:33:58 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141422|0 |1 is obsolete| | --- Comment #123 from Nick Clemens --- Created attachment 142365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142365&action=edit Bug 17170: DB Updates This patch adds the new table, permission, and a syspref to enable the feature Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:34:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:34:03 +0000 Subject: [Koha-bugs] [Bug 31903] Article requests: Edit URLs link missing in the New tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31903 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142313|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 142366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142366&action=edit Bug 31903: Fix missing Edit URL link We need to pass format too for New tab (see Pending/Processing). Test plan: * Include SCAN format in ArticleRequestSupportedFormats system preferences. * Check circ rules to allow article requests. * Add a new request for digital copy and another for photocopy. * Check Circulation - Article requests - New tab. * Verify that the Actions menu for a single row for the digital copy does contain the "Edit URL(s)" option now. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Amended test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:34:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:34:05 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141423|0 |1 is obsolete| | --- Comment #124 from Nick Clemens --- Created attachment 142367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142367&action=edit Bug 17170: DBIC schema Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:34:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:34:12 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141424|0 |1 is obsolete| | --- Comment #125 from Nick Clemens --- Created attachment 142368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142368&action=edit Bug 17170: Update schema for boolean Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:34:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:34:21 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141425|0 |1 is obsolete| | --- Comment #126 from Nick Clemens --- Created attachment 142369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142369&action=edit Bug 17170: Add API route for SearchFilters This adds the API routes and tests Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:34:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:34:28 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141426|0 |1 is obsolete| | --- Comment #127 from Nick Clemens --- Created attachment 142370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142370&action=edit Bug 17170: Add search filters to staff and opac interfaces This patch displays the filters on the results pages with the facets Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:34:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:34:34 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141427|0 |1 is obsolete| | --- Comment #128 from Nick Clemens --- Created attachment 142371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142371&action=edit Bug 17170: Handle search filters in query builders This patch updates the query building code to expand filters when searching and pass them back as part of the cgi and descriptive search strings Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:34:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:34:37 +0000 Subject: [Koha-bugs] [Bug 31830] Add page-section to budgets and funds table on acq start page (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31830 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:34:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:34:42 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141428|0 |1 is obsolete| | --- Comment #129 from Nick Clemens --- Created attachment 142372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142372&action=edit Bug 17170: Add admin page for filters and ability to edit/save existing filters This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the resuilts page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:34:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:34:47 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141429|0 |1 is obsolete| | --- Comment #130 from Nick Clemens --- Created attachment 142373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142373&action=edit Bug 17170: Unit tests Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:34:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:34:53 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141430|0 |1 is obsolete| | --- Comment #131 from Nick Clemens --- Created attachment 142374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142374&action=edit Bug 17170: (follow-up) Display search filters admin links when appropriate Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:34:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:34:59 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141431|0 |1 is obsolete| | --- Comment #132 from Nick Clemens --- Created attachment 142375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142375&action=edit Bug 17170: Add the ability to create 'saved searches' for use as filters when searching the catalog This patch alters the code in the ES QueryBuilder. Reflecting how things are handled in build_query_compat we clean the query, but not the limits. In Zebra we simply recursivly call buildQuery, but the ES query structure This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the results page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Michal Urban Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:35:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:35:05 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141432|0 |1 is obsolete| | --- Comment #133 from Nick Clemens --- Created attachment 142376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142376&action=edit Bug 17170: (QA follow-up) Remove re-introduced file We reintroduced the definitions api spec file with this patch.. it's not required. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:35:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:35:11 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141433|0 |1 is obsolete| | --- Comment #134 from Nick Clemens --- Created attachment 142377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142377&action=edit Bug 17170: (QA follow-up) Relocate 'Save' Another minor rebase issue I believe.. relocate the 'Save search as filter' link back up to sit next to 'Edit this search'. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:35:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:35:17 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141434|0 |1 is obsolete| | --- Comment #135 from Nick Clemens --- Created attachment 142378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142378&action=edit Bug 17170: (QA follow-up) Improve model structure This feature is awesome, but it's modals all feel a bit off.. this is an improvement to one of them, but far from perfect. I opt to work with Owen to create a guideline (and template) for modals going forward and let this patchset go in as is. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:35:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:35:24 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141435|0 |1 is obsolete| | --- Comment #136 from Nick Clemens --- Created attachment 142379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142379&action=edit Bug 17170: Minor fixes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:35:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:35:31 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141436|0 |1 is obsolete| | --- Comment #137 from Nick Clemens --- Created attachment 142380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142380&action=edit Bug 17170: (QA follow-up) DB changes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:35:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:35:36 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141437|0 |1 is obsolete| | --- Comment #138 from Nick Clemens --- Created attachment 142381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142381&action=edit Bug 17170: (QA follow-up) Spec cleanup This patch removes not required (for now) query parameters as we can query using q= on those. They can be added back eventually, if needed. Attributes now match the database as well. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:35:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:35:43 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141438|0 |1 is obsolete| | --- Comment #139 from Nick Clemens --- Created attachment 142382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142382&action=edit Bug 17170: (QA follow-up) Escape things, make them translatable Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:35:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:35:49 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #140 from Nick Clemens --- Created attachment 142383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142383&action=edit Bug 17170: (follow-up) adjust tests for bug 25375 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:35:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:35:55 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141462|0 |1 is obsolete| | --- Comment #141 from Nick Clemens --- Created attachment 142384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142384&action=edit Bug 17170: (follow-up) Use x instead of X Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:36:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:36:01 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #142 from Nick Clemens --- Created attachment 142385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142385&action=edit Bug 17170: (follow-up) Adjust for RM follow-ups Use direct DB names when saving/loading Don't escape boolean values as strings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:36:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:36:28 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141461|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:37:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:37:43 +0000 Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:37:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:37:48 +0000 Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141619|0 |1 is obsolete| | Attachment #141620|0 |1 is obsolete| | Attachment #141621|0 |1 is obsolete| | Attachment #141622|0 |1 is obsolete| | Attachment #141623|0 |1 is obsolete| | --- Comment #74 from Kyle M Hall --- Created attachment 142386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142386&action=edit Bug 24381: Update sample notices This patch update the sample notices for new installs Signed-off-by: Kyle M Hall Signed-off-by: Lucas Gass Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:38:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:38:02 +0000 Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #75 from Kyle M Hall --- Created attachment 142387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142387&action=edit Bug 24381: Update notices if defaults used Signed-off-by: Kyle M Hall Signed-off-by: Lucas Gass Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:38:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:38:09 +0000 Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #76 from Kyle M Hall --- Created attachment 142388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142388&action=edit Bug 24381: Update notice params If the update to catch defaults fails, we need to attempt to update renamed template variables Signed-off-by: Kyle M Hall Signed-off-by: Lucas Gass Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:38:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:38:15 +0000 Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #77 from Kyle M Hall --- Created attachment 142389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142389&action=edit Bug 24381: (follow-up) Notice improvements Signed-off-by: Lucas Gass Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:38:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:38:20 +0000 Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #78 from Kyle M Hall --- Created attachment 142390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142390&action=edit Bug 24381: (follow-up) Add USE statements Signed-off-by: Lucas Gass Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:42:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:42:07 +0000 Subject: [Koha-bugs] [Bug 31830] Add page-section to budgets and funds table on acq start page (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31830 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:42:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:42:12 +0000 Subject: [Koha-bugs] [Bug 31830] Add page-section to budgets and funds table on acq start page (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31830 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142233|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 142391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142391&action=edit Bug 31830: Add page-section class to acq home table To test: 1. Go to the Acquisitions home page. 2. Look and the bugdets and funds table and notice the page-section class. 3. Make sure everything looks good. Note: I made some indentation changes. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:42:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:42:16 +0000 Subject: [Koha-bugs] [Bug 31830] Add page-section to budgets and funds table on acq start page (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31830 --- Comment #4 from Katrin Fischer --- Created attachment 142392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142392&action=edit Bug 31830: (QA follow-up) include heading in page section Moves the div up a few levels to the heading for this part of the page is included. This also makes it consistent with the page-section for "Manage orders" directly above. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:42:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:42:30 +0000 Subject: [Koha-bugs] [Bug 31771] Add 'page-section' to stock rotation pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31771 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:45:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:45:47 +0000 Subject: [Koha-bugs] [Bug 31771] Add 'page-section' to stock rotation pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31771 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:45:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:45:51 +0000 Subject: [Koha-bugs] [Bug 31771] Add 'page-section' to stock rotation pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31771 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142120|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 142393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142393&action=edit Bug 31771: Add page-section to stock rotation pages To test: 1. Apply patch 2. Set the system preference 'StockRotation' to enable. 3. Go to Cataloging / Stock rotation 4. Add some new rotas 5. Make sure the page looks good with the new page-section div Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:46:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:46:17 +0000 Subject: [Koha-bugs] [Bug 31770] Add 'page-section' to rotating collections page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31770 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:47:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:47:08 +0000 Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 --- Comment #12 from Martin Renvoize --- These comments got me re-reading the notice. (In reply to David Nind from comment #7) > I've tested and have some feedback: > > 1. Things work as expected using the test plan (for step 2, FINE_SUMMARY > should be FEE_SUMMARY). Oops.. it should probably be renamed again though given the below > 2. For the print menu for the patron, this is labelled "Print fines slip": > should these be "Print charges slip"? I thought we were heading in the > direction of using charges rather than fines, but this it is not covered in > the terminology list. 'Charges' isn't 100% correct either.. we actually allow printing of and 'outstanding' accounts.. credit or debt. > 3. If I add a manual credit that is more than the outstanding balance (that > is, overall the library owes the patron) but don't apply it, I can't print > the slip. I assume that if this is the case, staff would know to apply the > credit. This feels like a bug.. One should be able to print if there are any outstanding accounts in either direction I think. > 4. For the slip: > . Should the title be "Outstanding charges"? > . The phrase "Total outstanding dues as on date:" doesn't make much sense > to me. Possibly "Total outstanding charges" or just "Total outstanding"? > . Could the Amount and Outstanding columns be right aligned with the > amounts? Given the above about the slip in theory printing both debts and credits outstanding, I'm not sure what to put in the overall title.. > This all works, so hope my feedback doesn't come across as too negative! Not at all.. it's great to have feedback :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:49:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:49:28 +0000 Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Michaela Sieber --- Thanks a lot for the patches and the test plan! We can confirm that it works as expected :-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:50:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:50:54 +0000 Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140819|0 |1 is obsolete| | --- Comment #14 from sandboxes at biblibre.com --- Created attachment 142394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142394&action=edit Bug 29145: use overdues restrict delays when removing overdues restriction upon return How to test: 1) Run tests in t/db_dependent/Circulation/MarkIssueReturned.t Sponsored by: Gothenburg University Library Signed-off-by: Michaela -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:50:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:50:59 +0000 Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140820|0 |1 is obsolete| | --- Comment #15 from sandboxes at biblibre.com --- Created attachment 142395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142395&action=edit Bug 29145: Add tests and modify sysprefs Add tests, remove ODueDebarmentRemovalAllowUnrestricted syspref and instead modify AutoRemoveOverduesRestrictions to have a third option Signed-off-by: Michaela -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:51:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:51:04 +0000 Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141823|0 |1 is obsolete| | --- Comment #16 from sandboxes at biblibre.com --- Created attachment 142396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142396&action=edit Bug 29145: Fix conditions for patron debarring overdues Signed-off-by: Michaela -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:52:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:52:13 +0000 Subject: [Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #30 from Kyle M Hall --- Applying: Bug 17704: Enable ->xslt method (must use HTTP::OAI >= 4.07) error: sha1 information is lacking or useless (Koha/OAI/Server/Repository.pm). error: could not build fake ancestor Patch failed at 0001 Bug 17704: Enable ->xslt method (must use HTTP::OAI >= 4.07) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:52:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:52:27 +0000 Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #17 from Andrew Fuerste-Henry --- (In reply to Michaela Sieber from comment #13) > Thanks a lot for the patches and the test plan! > We can confirm that it works as expected :-) Superb! I think this open source thing might just work :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:55:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:55:22 +0000 Subject: [Koha-bugs] [Bug 31770] Add 'page-section' to rotating collections page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31770 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:55:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:55:27 +0000 Subject: [Koha-bugs] [Bug 31770] Add 'page-section' to rotating collections page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31770 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142119|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 142397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142397&action=edit Bug 31770: Add page-section class to rotating collections page To test: 1. Apply patch 2. Go to the rotating collections page. Tools / Rotating collections 3. Add some new collections 4. Note that the page looks good with the new page section div. Note: I made some indentation changes and fixed a small typo where the 'dropdown-toggle' class was not being properly applied. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 15:56:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 13:56:42 +0000 Subject: [Koha-bugs] [Bug 31847] Add page section to item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31847 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:03:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:03:19 +0000 Subject: [Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:04:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:04:39 +0000 Subject: [Koha-bugs] [Bug 31911] New: Headings are inconsistent in rotating collections Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Bug ID: 31911 Summary: Headings are inconsistent in rotating collections Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Headings are placed above the main action toolbar on the 'Add/remove items from collection' page of 'Rotating collections'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:04:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:04:45 +0000 Subject: [Koha-bugs] [Bug 31911] Headings are inconsistent in rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:05:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:05:47 +0000 Subject: [Koha-bugs] [Bug 31911] Headings are inconsistent in rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31770 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31770 [Bug 31770] Add 'page-section' to rotating collections page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:05:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:05:47 +0000 Subject: [Koha-bugs] [Bug 31770] Add 'page-section' to rotating collections page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31770 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31911 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 [Bug 31911] Headings are inconsistent in rotating collections -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:07:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:07:40 +0000 Subject: [Koha-bugs] [Bug 31908] Context accessed but not always set on mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:14:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:14:45 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to basket summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 --- Comment #6 from Lucas Gass --- Sorry, for the confusion here Cait. I'll move these patches over to Bug 31820 and address the heading problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:18:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:18:27 +0000 Subject: [Koha-bugs] [Bug 31911] Headings are inconsistent in rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 --- Comment #1 from Martin Renvoize --- Created attachment 142398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142398&action=edit Bug 31911: Improve rotating collections item management This patch renames 'Add/remove items from collection' to just 'Manage items' in the button in the rotating collections list table, the page heading and the breadcrumbs. We also move the heading below the toolbar to be consistent with elsewhere, remove a superflous second level heading and wrap the content table in a page-section too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:18:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:18:46 +0000 Subject: [Koha-bugs] [Bug 31739] Password reset from staff fails if previous expired reset-entry exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31739 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:18:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:18:51 +0000 Subject: [Koha-bugs] [Bug 31739] Password reset from staff fails if previous expired reset-entry exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31739 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142110|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 142399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142399&action=edit Bug 31739: Password recovery from staff fails if previous expired reset-entry exists. SendPasswordRecoveryEmail relies on the calling script to tell if there is an existing valid recovery already. If there's an expired recovery-entry the members/notices.pl script will try to create a new entry resulting in a duplicate key error. This patch fixes the bug by removing the need for the calling script to do the check as since SendPasswordRecoveryEmail does the same thing anyway. SendPasswordRecoveryEmail will now use DBIx ->update_or_create instead of looking at the $update param to determine if it should update an existing entry or create a new. The update param is removed from all calling scripts and test are updated. To test: 1. Generate a password recovery mail for a patron 2. Let it expire. 3. Generate a new password recovery from staff to the same patron - Fail! 4: Apply patch 5. Generate a new password recovery from staff to the same patron - Success! 6. Opac password recovery flow should also work. 7. Tests pass. Sponsored-by: Lund University Library Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:19:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:19:46 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to basket summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 --- Comment #7 from Katrin Fischer --- (In reply to Lucas Gass from comment #6) > Sorry, for the confusion here Cait. I'll move these patches over to Bug > 31820 and address the heading problem. Please don't move, I fixed the descriptions and the patch is ok here now! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:27:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:27:54 +0000 Subject: [Koha-bugs] [Bug 31912] New: When enforcing 2FA we should alert the user Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31912 Bug ID: 31912 Summary: When enforcing 2FA we should alert the user Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org After bug 30588 the staff can set 2FA as forced - when this set we should notify the user of this setting both on: 1 - Their 2FA setup page in the staff interface/user account 2 - The login screen when sending them to setup 2FA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:27:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:27:56 +0000 Subject: [Koha-bugs] [Bug 31913] New: Use Modals in Rotating collections Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31913 Bug ID: 31913 Summary: Use Modals in Rotating collections Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org We should use modals for 'New collection' and 'Edit' actions.. they're tiny forms and don't really require a whole page load. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:28:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:28:07 +0000 Subject: [Koha-bugs] [Bug 31913] Use Modals in Rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31913 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:28:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:28:11 +0000 Subject: [Koha-bugs] [Bug 31912] When enforcing 2FA we should alert the user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31912 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30588 Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 [Bug 30588] Add the option to require 2FA setup on first staff login -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:28:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:28:11 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31912 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31912 [Bug 31912] When enforcing 2FA we should alert the user -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:32:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:32:04 +0000 Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 --- Comment #6 from Lucas Gass --- (In reply to Martin Renvoize from comment #4) > Well spotted Lucas... I wonder if instead of repeating the title we should > pick a appropriate subsection group title instead. > > Perhaps 'Global' or 'Features' or something like that.. > > So something like? > > * Serials - Features > * I18N - Global This seems reasonable to me, I'll make that change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:32:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:32:35 +0000 Subject: [Koha-bugs] [Bug 31913] Use Modals in Rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31913 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:32:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:32:35 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31913 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31913 [Bug 31913] Use Modals in Rotating collections -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:32:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:32:56 +0000 Subject: [Koha-bugs] [Bug 31772] Some stock rotation pages could be converted to modals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31772 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:32:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:32:56 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31772 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31772 [Bug 31772] Some stock rotation pages could be converted to modals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:35:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:35:40 +0000 Subject: [Koha-bugs] [Bug 31914] New: We should adopt modals more widely for simple forms Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31914 Bug ID: 31914 Summary: We should adopt modals more widely for simple forms Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com There are lots of cases in Koha where we have a very simple form that currently works through a full page load workflow.. we could easily migrate these to modals instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:35:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:35:56 +0000 Subject: [Koha-bugs] [Bug 31914] We should adopt modals more widely for simple forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31914 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31913 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31913 [Bug 31913] Use Modals in Rotating collections -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:35:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:35:56 +0000 Subject: [Koha-bugs] [Bug 31913] Use Modals in Rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31913 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31914 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31914 [Bug 31914] We should adopt modals more widely for simple forms -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:36:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:36:07 +0000 Subject: [Koha-bugs] [Bug 31914] We should adopt modals more widely for simple forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31914 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31772 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31772 [Bug 31772] Some stock rotation pages could be converted to modals -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:36:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:36:07 +0000 Subject: [Koha-bugs] [Bug 31772] Some stock rotation pages could be converted to modals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31772 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31914 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31914 [Bug 31914] We should adopt modals more widely for simple forms -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:38:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:38:07 +0000 Subject: [Koha-bugs] [Bug 31911] Headings are inconsistent in rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:43:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:43:37 +0000 Subject: [Koha-bugs] [Bug 31915] New: Add floating toolbar to item search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31915 Bug ID: 31915 Summary: Add floating toolbar to item search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It would be great if the edit button, the select and export options above the item search results page could be moved into a floating toolbar. Libraries often end up using the 'back' button in the browser that doesn't work here. We could improve this by having the 'Edit search' button always visible. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:46:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:46:25 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:46:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:46:27 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #143 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:46:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:46:30 +0000 Subject: [Koha-bugs] [Bug 29662] PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:46:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:46:33 +0000 Subject: [Koha-bugs] [Bug 29662] PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 --- Comment #12 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:46:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:46:36 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:46:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:46:39 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 --- Comment #76 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:46:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:46:41 +0000 Subject: [Koha-bugs] [Bug 31588] Update cpanfile for new OpenAPI versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:46:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:46:44 +0000 Subject: [Koha-bugs] [Bug 31588] Update cpanfile for new OpenAPI versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 --- Comment #20 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:46:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:46:47 +0000 Subject: [Koha-bugs] [Bug 31672] Remove 'Your' from tab descriptions in OPAC patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31672 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:46:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:46:49 +0000 Subject: [Koha-bugs] [Bug 31672] Remove 'Your' from tab descriptions in OPAC patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31672 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:46:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:46:52 +0000 Subject: [Koha-bugs] [Bug 31687] Add see from and see also from tracings in Match index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31687 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:46:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:46:55 +0000 Subject: [Koha-bugs] [Bug 31687] Add see from and see also from tracings in Match index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31687 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:46:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:46:57 +0000 Subject: [Koha-bugs] [Bug 31691] Remove non-existent fields from the See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31691 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:46:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:46:59 +0000 Subject: [Koha-bugs] [Bug 31691] Remove non-existent fields from the See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31691 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:47:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:47:02 +0000 Subject: [Koha-bugs] [Bug 31693] Remove non-existent fields from the See-also-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31693 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:47:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:47:04 +0000 Subject: [Koha-bugs] [Bug 31693] Remove non-existent fields from the See-also-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31693 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:47:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:47:06 +0000 Subject: [Koha-bugs] [Bug 31770] Add 'page-section' to rotating collections page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31770 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:47:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:47:09 +0000 Subject: [Koha-bugs] [Bug 31770] Add 'page-section' to rotating collections page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31770 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:47:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:47:13 +0000 Subject: [Koha-bugs] [Bug 31771] Add 'page-section' to stock rotation pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31771 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:47:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:47:15 +0000 Subject: [Koha-bugs] [Bug 31771] Add 'page-section' to stock rotation pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31771 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:47:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:47:18 +0000 Subject: [Koha-bugs] [Bug 31830] Add page-section to budgets and funds table on acq start page (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31830 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:47:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:47:21 +0000 Subject: [Koha-bugs] [Bug 31830] Add page-section to budgets and funds table on acq start page (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31830 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:47:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:47:23 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:47:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:47:33 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:49:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:49:13 +0000 Subject: [Koha-bugs] [Bug 31847] Add page section to item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31847 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:49:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:49:17 +0000 Subject: [Koha-bugs] [Bug 31847] Add page section to item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31847 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142091|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 142400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142400&action=edit Bug 31847: Add page-section class to item search results To test: 1. Apply patch 2. Look at item search results ( itemsearch.tt ) 3. Make sure everthing looks right. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:49:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:49:43 +0000 Subject: [Koha-bugs] [Bug 31916] New: It would be nice to make the paging in datatables and search results consistent Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31916 Bug ID: 31916 Summary: It would be nice to make the paging in datatables and search results consistent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The paging UI is nice in the catalog search results.. it would be great to clone that styling to the general datatables paging? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:49:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:49:53 +0000 Subject: [Koha-bugs] [Bug 31916] It would be nice to make the paging in datatables and search results consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31916 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:49:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:49:53 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31916 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31916 [Bug 31916] It would be nice to make the paging in datatables and search results consistent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:50:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:50:06 +0000 Subject: [Koha-bugs] [Bug 31847] Add page section to item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31847 --- Comment #7 from Katrin Fischer --- We had some discussion on IRC about which elements on the top of the page should be outside or inside the page section, which ultimately led to filing bug 31915: We'd like a floating toolbar there please :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:51:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:51:26 +0000 Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize at ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:52:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:52:01 +0000 Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- Just moving out of queue until it bounces back with the follow-up :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:53:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:53:01 +0000 Subject: [Koha-bugs] [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:56:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:56:40 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #218 from geraud.frappier at inlibro.com --- Created attachment 142401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142401&action=edit Bug 31417: Update and reference cat-menu.inc This patch reinstates the cat-menu.inc include and references it from the various 'tools' that are closely tied to cataloging. We use the new cataloging home page submission as a reference for which options should appear in the menu. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:58:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:58:19 +0000 Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:58:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:58:22 +0000 Subject: [Koha-bugs] [Bug 31917] New: Headings don't seem quite right for system preference search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 Bug ID: 31917 Summary: Headings don't seem quite right for system preference search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 31886 When doing a system preference search we end up with two H2 headings directly after each other.. it doesn't feel quite right. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 [Bug 31886] No side menu when searching for syspref -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:58:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:58:22 +0000 Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31917 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 [Bug 31917] Headings don't seem quite right for system preference search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:58:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:58:24 +0000 Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142335|0 |1 is obsolete| | --- Comment #8 from Lucas Gass --- Created attachment 142402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142402&action=edit Bug 31886: Fix no sidebar problem in system pref search To test: 1. Go to Adminstration and click on 'Global system preferences' 2. From the left side bar click 'I18N/L10N' and notice no sidebar. 3. Also try 'Serials', no sidebar 4. Apply patch, restart_all 5. Try 1 & 2 again and the sidebar should be restored 6. Try clicking through each of the system preference groups (Accounting, Acquisitions, etc ) and make sure the sidebar is always present. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:58:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:58:35 +0000 Subject: [Koha-bugs] [Bug 31917] Headings don't seem quite right for system preference search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:58:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:58:43 +0000 Subject: [Koha-bugs] [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:58:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:58:48 +0000 Subject: [Koha-bugs] [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142221|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 142403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142403&action=edit Bug 31864: Correct breadcrumbs for pages in new cataloging module To test: 1. Apply patch 2. Set system preference 'StockRotation' to enable. 3. Be logged in as a superlibrarian 4. Check the breadcrumbs on the following pages, accessible from the Cataloging module homepage: barcode-print.tt label-edit-batch.tt label-edit-layout.tt label-edit-profile.tt label-edit-range.tt label-edit-template.tt label-home.tt label-manage.tt spinelabel-home.tt automatic_item_modification_by_age.tt batchMod-edit.tt batchMod.tt batch_delete_records.tt export.tt inventory.tt manage-marc-import.tt marc_modification_templates.tt stage-marc-import.tt stockrotation.tt upload-images.tt Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:58:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:58:54 +0000 Subject: [Koha-bugs] [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142222|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 142404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142404&action=edit Bug 31864: (follow-up) Fix breadcrumbs in batchMod and batch_record_mod Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 16:59:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 14:59:25 +0000 Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:00:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:00:37 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 geraud.frappier at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |geraud.frappier at inlibro.com Attachment #142401|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:04:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:04:08 +0000 Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142402|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 142405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142405&action=edit Bug 31886: Fix no sidebar problem in system pref search To test: 1. Go to Adminstration and click on 'Global system preferences' 2. From the left side bar click 'I18N/L10N' and notice no sidebar. 3. Also try 'Serials', no sidebar 4. Apply patch, restart_all 5. Try 1 & 2 again and the sidebar should be restored 6. Try clicking through each of the system preference groups (Accounting, Acquisitions, etc ) and make sure the sidebar is always present. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:05:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:05:10 +0000 Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142405|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 142406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142406&action=edit Bug 31886: Fix no sidebar problem in system pref search To test: 1. Go to Adminstration and click on 'Global system preferences' 2. From the left side bar click 'I18N/L10N' and notice no sidebar. 3. Also try 'Serials', no sidebar 4. Apply patch, restart_all 5. Try 1 & 2 again and the sidebar should be restored 6. Try clicking through each of the system preference groups (Accounting, Acquisitions, etc ) and make sure the sidebar is always present. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:05:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:05:42 +0000 Subject: [Koha-bugs] [Bug 31863] Advanced cataloging editor no longer auto-resizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:09:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:09:41 +0000 Subject: [Koha-bugs] [Bug 31917] Headings don't seem quite right for system preference search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 --- Comment #1 from Martin Renvoize --- Created attachment 142407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142407&action=edit Bug 31917: Headings fix for preferences search This patch re-arranges the logic for displaying the search term when executing a system preference search. Test plan 1) Without the patch, search for something that will get no results 'boing' and note how it looks 2) Without the patch, search for something that gets some results 'block' and note how it looks 3) Apply the patch 4) Repeat your searches and comment on whether the look is better of worse ;P -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:15:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:15:02 +0000 Subject: [Koha-bugs] [Bug 31917] Headings don't seem quite right for system preference search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:15:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:15:25 +0000 Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:18:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:18:38 +0000 Subject: [Koha-bugs] [Bug 31918] New: vendor list is not displayed nicely Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31918 Bug ID: 31918 Summary: vendor list is not displayed nicely Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 It's missing blocks, separation, etc. https://snipboard.io/FzH759.jpg Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:18:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:18:38 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31918 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31918 [Bug 31918] vendor list is not displayed nicely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:19:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:19:55 +0000 Subject: [Koha-bugs] [Bug 31918] vendor list is not displayed nicely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31918 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |martin.renvoize at ptfs-europe | |.com Status|NEW |RESOLVED --- Comment #1 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 31821 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:19:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:19:56 +0000 Subject: [Koha-bugs] [Bug 31821] Add page-section to vendor result list (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31821 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Martin Renvoize --- *** Bug 31918 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:26:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:26:03 +0000 Subject: [Koha-bugs] [Bug 31821] Add page-section to vendor result list (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31821 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:26:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:26:32 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:28:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:28:00 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master --- Comment #35 from Tomás Cohen Arazi --- Follow-ups pushed. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:28:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:28:41 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Géraud Frappier changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135545|0 |1 is obsolete| | --- Comment #219 from Géraud Frappier --- Created attachment 142408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142408&action=edit Bug 12446: DBIC specific add_columns canbeguarantee New column canbeguarantee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:29:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:29:21 +0000 Subject: [Koha-bugs] [Bug 31919] New: Hovered items in "More" should change background color Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 Bug ID: 31919 Summary: Hovered items in "More" should change background color Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 when I am on acqui-home.pl, the nav menu is showing the item hovered by the pointer with a nice green label on the left of the element, and changing its background. However the behaviour in the "More" dropdown menu is to simply underline the selected items. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:29:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:29:21 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31919 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 [Bug 31919] Hovered items in "More" should change background color -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:29:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:29:49 +0000 Subject: [Koha-bugs] [Bug 31920] New: Unit test t/db_dependent/Holds.t leaves behind database cruft Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31920 Bug ID: 31920 Summary: Unit test t/db_dependent/Holds.t leaves behind database cruft Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Test Plan: 1) SELECT branchcode FROM branches 2) prove t/db_dependent/Holds.t 3) SELECT branchcode FROM branches -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:29:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:29:53 +0000 Subject: [Koha-bugs] [Bug 31920] Unit test t/db_dependent/Holds.t leaves behind database cruft In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31920 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:31:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:31:19 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Géraud Frappier changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142408|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:33:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:33:19 +0000 Subject: [Koha-bugs] [Bug 31920] Unit test t/db_dependent/Holds.t leaves behind database cruft In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31920 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:33:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:33:22 +0000 Subject: [Koha-bugs] [Bug 31920] Unit test t/db_dependent/Holds.t leaves behind database cruft In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31920 --- Comment #1 from Kyle M Hall --- Created attachment 142409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142409&action=edit Bug 31920: Add transaction to subtest in t/db_dependent/Holds.t A subest in t/db_dependent/Holds.t leaves behind database cruft. Test Plan: Using koha-testing-docker: 1) SELECT branchcode FROM branches 2) prove t/db_dependent/Holds.t 3) SELECT branchcode FROM branches Note cruft 4) reset_all 2) prove t/db_dependent/Holds.t 3) SELECT branchcode FROM branches No cruft! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:34:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:34:08 +0000 Subject: [Koha-bugs] [Bug 31920] Unit test t/db_dependent/Holds.t leaves behind database cruft In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31920 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30447 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447 [Bug 30447] pendingreserves.pl is checking too many transfers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:34:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:34:08 +0000 Subject: [Koha-bugs] [Bug 30447] pendingreserves.pl is checking too many transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31920 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31920 [Bug 31920] Unit test t/db_dependent/Holds.t leaves behind database cruft -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:34:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:34:10 +0000 Subject: [Koha-bugs] [Bug 31821] Add page-section to vendor result list (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31821 --- Comment #2 from Martin Renvoize --- Created attachment 142410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142410&action=edit Bug 31821: Add page-section class to booksellers This patch adds a page-section class to each supplier block -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:39:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:39:15 +0000 Subject: [Koha-bugs] [Bug 31863] Advanced cataloging editor no longer auto-resizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:39:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:39:23 +0000 Subject: [Koha-bugs] [Bug 31863] Advanced cataloging editor no longer auto-resizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142112|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 142411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142411&action=edit Bug 31863: Account for changelanguage element when adjusting editor height To test: 1. Turn on 'EnableAdvancedCatalogingEditor' 2. Go to a record with enough MARC data that it should take up the entire width of your screen, 3. The CodeMirror editor will only be 300px. 4. Resize your screen, nothing happens to the editor height 5. Apply patch 6. Look at the same record in your editor, the editor should go to the bottom of the page now. Resizing your screen should resize the editor. 7. Have some additional language packs installed, and change the language system pref so the '#changelanguage' option will appear. 8. Make sure the editor height is still being properly set. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:42:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:42:08 +0000 Subject: [Koha-bugs] [Bug 31821] Add page-section to vendor result list (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31821 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:42:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:42:33 +0000 Subject: [Koha-bugs] [Bug 31822] Add page-section to vendor detail page (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31822 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:43:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:43:36 +0000 Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when ordering is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart --- https://snipboard.io/2k6ImK.jpg https://snipboard.io/c8AEjz.jpg -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:47:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:47:47 +0000 Subject: [Koha-bugs] [Bug 31921] New: No confirmation alert when deleting a vendor Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 Bug ID: 31921 Summary: No confirmation alert when deleting a vendor Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 28082 First vendor of the page has a confirmation alert, but the answer is ignored! I guess it's coming from Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082 [Bug 28082] Add acquisitions toolbar to vendors on vendor search page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:47:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:47:47 +0000 Subject: [Koha-bugs] [Bug 28082] Add acquisitions toolbar to vendors on vendor search page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31921 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 [Bug 31921] No confirmation alert when deleting a vendor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:48:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:48:36 +0000 Subject: [Koha-bugs] [Bug 31920] Unit test t/db_dependent/Holds.t leaves behind database cruft In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31920 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:56:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:56:33 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #144 from Jonathan Druart --- Dropdown empty in modal: https://snipboard.io/Nnab3I.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 17:58:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 15:58:44 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #145 from Jonathan Druart --- You can save a search even if not displayed at OPAC or staff, is that expected? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:02:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:02:00 +0000 Subject: [Koha-bugs] [Bug 31822] Add page-section to vendor detail page (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31822 --- Comment #1 from Martin Renvoize --- Created attachment 142412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142412&action=edit Bug 31822: Add page-section to vendoer details page This patch contains whitespace changes which an be safely ignored. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:02:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:02:28 +0000 Subject: [Koha-bugs] [Bug 31822] Add page-section to vendor detail page (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31822 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:03:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:03:12 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141735|0 |1 is obsolete| | Attachment #141736|0 |1 is obsolete| | Attachment #141737|0 |1 is obsolete| | Attachment #141738|0 |1 is obsolete| | Attachment #141739|0 |1 is obsolete| | Attachment #141740|0 |1 is obsolete| | Attachment #141741|0 |1 is obsolete| | Attachment #141742|0 |1 is obsolete| | Attachment #141743|0 |1 is obsolete| | Attachment #141744|0 |1 is obsolete| | Attachment #141745|0 |1 is obsolete| | Attachment #141746|0 |1 is obsolete| | Attachment #141747|0 |1 is obsolete| | Attachment #141748|0 |1 is obsolete| | Attachment #141749|0 |1 is obsolete| | Attachment #141750|0 |1 is obsolete| | --- Comment #155 from Kyle M Hall --- Created attachment 142413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142413&action=edit Bug 24860: Add reserves.item_group_it This feature builds upon bug 24857 and allows placing holds that target a specific item group of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and item groups, with each item being assigned to an item group 6) Place a hold for a patron 7) Note the new selector to choose an item group in addition to record and item level holds 8) Place an item group level hold 9) Check in an item from the record that is not part of that item group 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that item group 12) Note the hold is trapped for that item 13) Place an item group level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that item group 16) Check out all the items of that item group to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:03:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:03:53 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #156 from Kyle M Hall --- Created attachment 142414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142414&action=edit Bug 24860: Add new syspref EnableItemGroupHolds Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:03:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:03:55 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #146 from Jonathan Druart --- A filter that is not displayed at the OPAC can still be used if you modify the id in the URL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:04:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:04:01 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #157 from Kyle M Hall --- Created attachment 142415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142415&action=edit Bug 24860: Implement reserves.item_group_id Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:04:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:04:09 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #158 from Kyle M Hall --- Created attachment 142416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142416&action=edit Bug 24860: Add ability to select an item group when placing a hold Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:04:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:04:15 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #159 from Kyle M Hall --- Created attachment 142417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142417&action=edit Bug 24860: Add ability to select an item group when placing a hold - OPAC Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:04:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:04:21 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #160 from Kyle M Hall --- Created attachment 142418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142418&action=edit Bug 24860: Skip non-matching item group holds in CheckReserves Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:04:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:04:27 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #161 from Kyle M Hall --- Created attachment 142419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142419&action=edit Bug 24860: Skip non-matching item group holds in HoldsQueue Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:04:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:04:32 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #162 from Kyle M Hall --- Created attachment 142420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142420&action=edit Bug 24860: Add hold's item group to holds table on circulation.pl and moremember.pl Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:04:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:04:38 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #163 from Kyle M Hall --- Created attachment 142421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142421&action=edit Bug 24860: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:04:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:04:43 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #164 from Kyle M Hall --- Created attachment 142422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142422&action=edit Bug 24860: (QA follow-up) Fix number of tests in t/db_dependent/Koha/Holds.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:04:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:04:49 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #165 from Kyle M Hall --- Created attachment 142423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142423&action=edit Bug 24860: (QA follow-up) Terminology and translation fixes * Fixes a single to a double underscore for translation in holds.js * Fixes item_group to item group in API description * Fixes volume hold to item group hold in syspref db descrpitions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:04:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:04:54 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #166 from Kyle M Hall --- Created attachment 142424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142424&action=edit Bug 24860: (QA follow-up) Add unit tests to cover changes to HoldsQueue.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:05:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:05:02 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #167 from Kyle M Hall --- Created attachment 142425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142425&action=edit Bug 24860: (QA follow-up) Add unit tests to cover changes to Reserves.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:05:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:05:09 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #168 from Kyle M Hall --- Created attachment 142426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142426&action=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::Hold::item_group -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:05:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:05:15 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #169 from Kyle M Hall --- Created attachment 142427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142427&action=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::Holds::forced_hold_level -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:05:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:05:20 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #170 from Kyle M Hall --- Created attachment 142428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142428&action=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::REST::V1::Holds::add -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:05:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:05:26 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #171 from Kyle M Hall --- Created attachment 142429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142429&action=edit Bug 24860: (QA follow-up) Fix typo in holds queue viewer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:05:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:05:33 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #172 from Kyle M Hall --- Created attachment 142430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142430&action=edit Bug 24860: (QA follow-up) Show group holds on Holds to pull -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:07:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:07:24 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #173 from Kyle M Hall --- > To summarize: > * Verify/make sure tests clean up their created data Fixed on Bug 31920 > * Remove _ from message on holds queue page Fixed with followup! > * Adapt message when only a item group hold exists on holds to pull Also fixed with a followup! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:29:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:29:41 +0000 Subject: [Koha-bugs] [Bug 31912] When enforcing 2FA we should alert the user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31912 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:45:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:45:26 +0000 Subject: [Koha-bugs] [Bug 10087] Way to receive easily documents from a specific basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10087 Monique changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |monique.prive at northernvermo | |nt.edu --- Comment #1 from Monique --- It would save time if we could receive all the items in a basket. It would be better if you could omit some if you needed to or add some from other baskets. One by one receiving takes a lot of clicks. Monique Prive NVU-Lyndon in Vermont -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:50:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:50:48 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #147 from Nick Clemens --- (In reply to Jonathan Druart from comment #145) > You can save a search even if not displayed at OPAC or staff, is that > expected? Yes, noted in feature: New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 18:51:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 16:51:47 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #148 from Nick Clemens --- (In reply to Jonathan Druart from comment #146) > A filter that is not displayed at the OPAC can still be used if you modify > the id in the URL. You could perform the search yourself anyways, I do not think it reveals any data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 19:16:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 17:16:12 +0000 Subject: [Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #13 from Lucas Gass --- Doesn't apply cleanly to master, I'll rebase and return to this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 19:19:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 17:19:20 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 geraud.frappier at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135544|0 |1 is obsolete| | --- Comment #220 from geraud.frappier at inlibro.com --- Created attachment 142431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142431&action=edit Bug 12446: Remove can_be_guarentee is_boolean to put it back in another patch This patch resolve merge conflit and add the instantiation of the variable "my $categories" that was missing in memberentry.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 19:23:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 17:23:09 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 geraud.frappier at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135545|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 19:23:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 17:23:40 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 geraud.frappier at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135544|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 19:24:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 17:24:09 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 geraud.frappier at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142431|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 19:46:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 17:46:53 +0000 Subject: [Koha-bugs] [Bug 31922] New: Check alert for important fields is still a javascript message Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31922 Bug ID: 31922 Summary: Check alert for important fields is still a javascript message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Bug 28694 changed the alert message for missing mandatory fields to an in-page alert rather than a javascript pop up alert. However, if you're only missing important fields, this pop-up still shows up, in addition to the in-page alert. To test : (Note: my test plan is written for MARC21 with the default default framework, i.e. the default framework as it comes by default with Koha) 1. Make 020$a 'Important' 1.1. Go to Administration > MARC bibliographic framework 1.2. Click 'Actions' next to the default framework and choose the 'MARC structure' option 1.3. Search for 020 1.4. Click 'Actions' next to the 020 field and choose 'Edit subfields' 1.5. Click the 'a' tab 1.6. Check the 'Important' box 1.7. Click 'Save changes' 2. Create a new record, but only fill out the mandatory fields, not the important field 2.1. Go to Cataloging 2.2. Click 'New record' 2.3. Fill out the mandatory fields, but not the important field - 000 - 003 - 005 - 008 - 040$c - 245$a - 942$c 2.4. Click 'Save' --> There is a javascript pop-up informing you that you missed some important fields (this should not be here) 2.5. Wait a couple of seconds --> The in-page alert appears (this is OK) 2.6. Click 'OK' in the pop-up --> You are taken to the item form, without being able to add a value in the important field (this is the normal behaviour I think, that you're not able to do anything about the important field) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 19:54:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 17:54:48 +0000 Subject: [Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #38 from Heather --- Here's some Cataloger Opinions on Punctuation (in case it's helpful!): I looked at the sample records--lots of fields seem to be missing required indicators, but I guess that doesn't affect this? First record, "This is a series with multiple 8xx but no 4xx" has correct punctuation. Second record, "This is a series with multiple 440 and 8xx but no 490" has incorrect punctuation in second 440 field: "Chronicles of Prydain ǂv 2" should be "Chronicles of Prydain ;ǂv 2" It's the same in the 3rd records, "This is a series with 8xx and 490," with the 490 lacking a semicolon preceding the subfield v. Given that this MARC record lacks the required semicolon preceding the subfield v, yet a semicolon is supplied in the display, it seems that Koha is supplying semicolons as display constants, but this is not permitted in MARC21 for field 490: https://www.loc.gov/marc/bibliographic/bd490.html The only display constants permitted in MARC21 are optional parentheses enclosing the display of the entire field. So catalogers are required to enter a semicolon preceding a subfield v in all MARC21 series fields (4XX &/or 8XX), so Koha shouldn't be supplying semicolon display constants. I think this supplying of a semicolon display constant is why there are weird double-semicolons. So maybe a developer could apply Developer Code Magic to stop Koha from supplying these unallowed semicolon display constants? As for the behavior of record "This is a series with 440 and 490" not displaying the 490 with a first indicator of 1, that seems like correct behavior--that is an incorrect indicator, since "1" should only be used when the record has a paired 8XX field to provide the series added entry. (The correct indicator in the absence of a paired 8XX field is 490 0_). --h2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 19:56:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 17:56:46 +0000 Subject: [Koha-bugs] [Bug 31753] Dialog boxes inside of modals don't seem wide enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 --- Comment #12 from Katrin Fischer --- I like 'follow-up' :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 20:03:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 18:03:30 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 geraud.frappier at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135519|0 |1 is obsolete| | --- Comment #221 from geraud.frappier at inlibro.com --- Created attachment 142432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142432&action=edit Bug 12446: Ability to allow guarantor relationship for all patron category types This adds a new field "Can be guarantee" to patron categories so it becomes possible for any category type to have a guarantor. To test: 1) Have a patron category of type 'Adult' and one of type 'Child' 2) Confirm, by searching for the "Patron guarantor" fieldset in the edit/create form, that: => a patron of the first category can't have a guarantor => a patron from the second category can 3) Apply patch and run updatedatabase.pl 4) Edit the categories and note the new "Can be guarantee" field 5) It should have been set to "yes" for the "Child" and to "no" for the "Adult" 5) Repeat step 2. It should behave in the same way. 6) Edit the "Can be guarantee" for any of the category and check that the fieldset only appears when "Can be guarantee" is set to "yes" 7) prove t/db_dependent/Patrons.t => tests should still pass Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: David Nind Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 20:03:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 18:03:39 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 geraud.frappier at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135520|0 |1 is obsolete| | --- Comment #222 from geraud.frappier at inlibro.com --- Created attachment 142433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142433&action=edit Bug 12446: Schema update Category.pm Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: David Nind Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 20:03:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 18:03:48 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 geraud.frappier at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135521|0 |1 is obsolete| | --- Comment #223 from geraud.frappier at inlibro.com --- Created attachment 142434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142434&action=edit Bug 12446: Limit available categories when using "Add guarantee" button Test plan: 1) Have some patron categories that can and cannot be guarantee 2) Visit a patron's account and click the "Add guarantee" button 3) In the "category" dropdown, note that all categories are available 4) Apply this patch 5) Repeat step 2 and 3; the dropdown now only contains the categories for which "can be guarantee" is set to "Yes". Signed-off-by: Kyle M Hall Signed-off-by: David Nind Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 20:03:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 18:03:58 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 geraud.frappier at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135522|0 |1 is obsolete| | --- Comment #224 from geraud.frappier at inlibro.com --- Created attachment 142435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142435&action=edit Bug 12446: Fix typos Signed-off-by: Owen Leonard JD Amended patch: squashed and edited commit message Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 20:04:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 18:04:08 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 geraud.frappier at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135523|0 |1 is obsolete| | --- Comment #225 from geraud.frappier at inlibro.com --- Created attachment 142436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142436&action=edit Bug 12446: Add canbeguarantee value to patron categories sample data This patch changes sample data so patron categories of type 'C' or 'P' can be guarantees by default. Signed-off-by: Salman Ali Signed-off-by: Salman Ali Signed-off-by: David Nind Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 20:04:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 18:04:19 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 geraud.frappier at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135544|0 |1 is obsolete| | --- Comment #226 from geraud.frappier at inlibro.com --- Created attachment 142437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142437&action=edit Bug 12446: Remove can_be_guarentee is_boolean to put it back in another patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 20:04:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 18:04:30 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 geraud.frappier at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135545|0 |1 is obsolete| | --- Comment #227 from geraud.frappier at inlibro.com --- Created attachment 142438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142438&action=edit Bug 12446: DBIC specific add_columns canbeguarantee New column canbeguarantee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 20:04:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 18:04:39 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #228 from geraud.frappier at inlibro.com --- Created attachment 142439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142439&action=edit Bug 12446: Merge conflit resolve and add missing var This patch resolve merge conflit and add the instantiation of the variable "my $categories" that was missing in memberentry.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 20:21:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 18:21:36 +0000 Subject: [Koha-bugs] [Bug 31923] New: 'Ignore' tab description is misleading Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 Bug ID: 31923 Summary: 'Ignore' tab description is misleading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When you are modifying a MARC bibliographic framework, you can choose in which tab a particular subfield appears, or 'ignore' it. The description under this choice is 'Ignore means that the subfield does not display in the record editor' Which is true, but it doesn't mention that the subfield is completely removed from the record. This can cause data loss. If you're not aware of this, the 'Ignore' description is a bit misleading. I always instruct system administrators to use the 'Editor' checkbox if they do not want to see a particular subfield in the editor, and use only 'Ignore' if they really want to flush that subfield completely. I think the description could be improved to add that values will be deleted from the subfield as well. Maybe 'Ignore means that the subfield does not display in the record editor and that it's value, if any, is deleted from the record' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 20:30:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 18:30:36 +0000 Subject: [Koha-bugs] [Bug 31923] 'Ignore' tab description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 --- Comment #1 from Caroline Cyr La Rose --- To see the Ignore tab in action, 1. Catalog a record with, for example, a value in 020$a 2. Save the record in MARCXML and view it in a text editor --> The 020$a subfield is there 3. Go to Administration > MARC bibliographic framework 4. Edit 020$a and put it in the 'Ignore' tab 5. Edit the record --> The 020$a field is not there anymore, which is normal and what the current description says 6. Don't change anything and save the record 7. Save the record in MARCXML and view it in a text editor --> The 020$a subfield is gone completely -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 20:42:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 18:42:06 +0000 Subject: [Koha-bugs] [Bug 31923] 'Ignore' tab description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 20:42:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 18:42:10 +0000 Subject: [Koha-bugs] [Bug 31923] 'Ignore' tab description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 --- Comment #2 from Caroline Cyr La Rose --- Created attachment 142440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142440&action=edit Bug 31923: 'Ignore' tab description is misleading This patch modifies the description of the 'Ignore' tab in MARC bibliographic and authority framework administration to add that not only does the 'ignored' subfield not appear in the editor, but the subfield will also be deleted from the record. To test: 1. Go to Administration > MARC bibliographic framework 2. Click 'Actions' next to any framework and choose 'MARC structure' 3. Click 'Actions' next to any field and choose 'Edit subfields' 4. Check the hint/description under 'Managed in tab' and make sure it - makes sense - is written in correct english (syntax and spelling) - mentions that the subfield's value will be deleted from the record 5. Go to Administration > Authority types 6. Redo steps 2-4 for authority frameworks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 20:46:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 18:46:50 +0000 Subject: [Koha-bugs] [Bug 31923] 'Ignore' tab description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement modifies release notes| |the description of the | |'Ignore' tab in MARC | |bibliographic and authority | |framework administration to | |add that not only does the | |'ignored' subfield not | |appear in the editor, but | |the subfield will also be | |deleted from the record. | |This is the normal behavior | |of the 'Ignore' tab, it has | |not changed. Only the | |description was updated to | |reflect it's actual | |behavior. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 21:11:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 19:11:26 +0000 Subject: [Koha-bugs] [Bug 31168] Temporary Item Locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31168 Felicity Brown changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felicity.brown at montgomeryco | |untymd.gov --- Comment #2 from Felicity Brown --- Yes, we desperately need a temporary shelving location option, particularly for displays. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 21:16:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 19:16:26 +0000 Subject: [Koha-bugs] [Bug 31924] New: AutoLinkBiblios broken by patch from Bug 30280 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31924 Bug ID: 31924 Summary: AutoLinkBiblios broken by patch from Bug 30280 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: regression Severity: major Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: phil at chetcolibrary.org QA Contact: testopia at bugs.koha-community.org CC: frank.hansen at ub.lu.se Depends on: 30280 With AutoLinkBiblios set to "Do", when you save a biblio after adding an authority-controlled field, it should be linked to the matching authority. With the patch from bug 30280, it no longer is. Steps to reproduce: 1. Set AutoLinkBiblios to "Do". 2. Edit any bib record which does not already have a subject heading for "Perl (Computer language)". 3. Add a new 650 tag, with subfield a containing Perl (Computer language) and save the record 4. Re-edit the record, note that there is no authority record number in subfield 9 of the added 650. 5. git checkout 7a829606a46f5d3c2056ce9da5134ce293d584ad and verify that the steps above resulted in an authority record number in subfield 9 on the parent revision Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 [Bug 30280] Support authority records with common subject headings from different thesaurus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 21:16:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 19:16:26 +0000 Subject: [Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31924 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31924 [Bug 31924] AutoLinkBiblios broken by patch from Bug 30280 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 21:25:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 19:25:47 +0000 Subject: [Koha-bugs] [Bug 31915] Add floating toolbar to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31915 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 21:27:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 19:27:45 +0000 Subject: [Koha-bugs] [Bug 31881] Link in MARC view does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 --- Comment #5 from Fridolin Somers --- (In reply to Marcel de Rooy from comment #4) > Currently with Elasticsearch the link does not work because search query > contains 'field,phr:', > which is useless since the link contains 'idx=field,phr'. > > Not sure about this one. Are we really resolving the problem or just > creating a workaround? > > You say that the query contains 'field'. Isnt that just misconfiguration? > The framework column link should contain a valid index? > > Please clarify. Sure. In test plan, framework column link contains 'title' which is a valid 'index' (= search field). Actually the build search link contains the search field twice : &idx=title,phr &q=title,phr:... I think we want to build a search query like it as been created from advanced search. So keep '&idx' and remove search field from '&q'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 21:29:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 19:29:10 +0000 Subject: [Koha-bugs] [Bug 31810] Place hold button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 --- Comment #10 from Fridolin Somers --- (In reply to Marcel de Rooy from comment #6) > Fridolin: penalty points for not filling Assignee field. You should know. Oupsy, I need more coffee (or more IPA) ^^ Tanks for fixing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 21:31:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 19:31:22 +0000 Subject: [Koha-bugs] [Bug 31897] New hook when indexing with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 21:31:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 19:31:26 +0000 Subject: [Koha-bugs] [Bug 31897] New hook when indexing with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142308|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 142441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142441&action=edit Bug 31897: New before_index_action hook for Elasticsearch Hooks added: before_index_action with new action update How to test: Run tests in t/db_dependent/Koha/Plugins/Elasticsearch_Indexer_hooks.t Sponsored by: Gothenburg University Library Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 21:38:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 19:38:49 +0000 Subject: [Koha-bugs] [Bug 31920] Unit test t/db_dependent/Holds.t leaves behind database cruft In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31920 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 21:38:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 19:38:53 +0000 Subject: [Koha-bugs] [Bug 31920] Unit test t/db_dependent/Holds.t leaves behind database cruft In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31920 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142409|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142442&action=edit Bug 31920: Add transaction to subtest in t/db_dependent/Holds.t A subest in t/db_dependent/Holds.t leaves behind database cruft. Test Plan: Using koha-testing-docker: 1) SELECT branchcode FROM branches 2) prove t/db_dependent/Holds.t 3) SELECT branchcode FROM branches Note cruft 4) reset_all 2) prove t/db_dependent/Holds.t 3) SELECT branchcode FROM branches No cruft! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 21:40:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 19:40:45 +0000 Subject: [Koha-bugs] [Bug 31920] Unit test t/db_dependent/Holds.t leaves behind database cruft In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31920 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes: - Step 4.5: Apply patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 21:43:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 19:43:31 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #229 from Katrin Fischer --- Hi Geraud, what are you trying to do? This bug and the originally attached patches have already been pushed to master a while ago and the feature will be part of the 22.11 release in November. Any additional changes or follow-ups should now go on separate new bugs. You can indicate the relationship using the depends on/blocks or see also fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 22:04:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 20:04:52 +0000 Subject: [Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597 geraud.frappier at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112196|0 |1 is obsolete| | --- Comment #10 from geraud.frappier at inlibro.com --- Created attachment 142443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142443&action=edit Bug 26597: Transfer informations from guarantor when adding a guarantor to an existing patron When creating a new guarantee from the guarantor, the preference PrefillGuaranteeField dictates some fields to be transfered from guarantor to guarantee. This patch makes it so those informations are also transfered when adding a new guarantor relationship to an existing patron. To test: 1) Apply patch 2) Search PrefillGuaranteeField preference and make sure some fields are selected 3) Select a user that can have a guarantor 4) In the edit form, click on "Search to add" in "Patron guarantor" fieldset 5) Choose a patron who has at least one of the fields in 1) set 6) Click "Select" 7) Confirm guarantee's information is filled from the guarantor's record 8) Check that any preexisting information is not overwritten Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 22:14:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 20:14:03 +0000 Subject: [Koha-bugs] [Bug 31923] 'Ignore' tab description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com CC| |david at davidnind.com --- Comment #3 from David Nind --- Hi Caroline. Everything works as per the test plan. For the grammar, "..it's.." should be "..its..". This is one of English's idiosyncrasies - would read as "..it is.." if expanded out, rather than the possessive! https://www.grammarly.com/blog/its-vs-its/ I was thinking, if possible, it may be useful to add a warning symbol before the text (the triangle icon with an exclamation mark), similar to what is on the Tools > Log viewer page. I've also changed the assignee to you. Thanks for creating the bug and fix from the IRC conversation (http://irc.koha-community.org/koha/2022-10-20#i_2457304). I think that the option "Managed in tab: ignore" is quite misleading (but I can't think of a better option name that makes sense), as: - there is no "ignore" tab, and - it removes any values if the record is saved! Testing notes (using koha-testing-docker): - Record used for testing bibliographic record: 262 (Programming Perl), has an 020$a value - Record used for testing an authority record: 1525 (Perl (Computer language)), used 040$c David -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 22:59:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 20:59:30 +0000 Subject: [Koha-bugs] [Bug 31924] AutoLinkBiblios with Zebra broken by patch from Bug 30280 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31924 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|AutoLinkBiblios broken by |AutoLinkBiblios with Zebra |patch from Bug 30280 |broken by patch from Bug | |30280 --- Comment #1 from Phil Ringnalda --- Ah, Zebra-only. With Elasticsearch, it will be linked, with Zebra, it won't be linked (and with AutoCreateAuthorities enabled, a new authority record will be created, so apparently the linker is running and attempting to link and its search returns no matches, so AutoCreateAuthorities believes it should create a new authority record). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 23:10:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 21:10:43 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #67 from Caroline Cyr La Rose --- I'm trying to figure out how to NOT have to do manual changes after the upgrade as we're about to upgrade ~60 installations from 21.05 to 22.05. I have an instance with 4 'OpacMainUserBlock' news, two in fr-CA and two in en. They each are the translation of the other (i.e. en #1 is the translation of fr-CA #1 and en #2 is the translation of fr-CA #2). Although It's not evident in the db and I don't think the dbrev can do anything about it. (And what's worse is that this particular library just copied the French text into the english news... but we won't take that into account.) select idnew, branchcode, title, lang, published_on, updated_on, expirationdate, number, borrowernumber from opac_news where lang like "%OpacMainUserBlock%"; +-------+------------+-------------------------+-------------------------+--------------+---------------------+----------------+--------+----------------+ | idnew | branchcode | title | lang | published_on | updated_on | expirationdate | number | borrowernumber | +-------+------------+-------------------------+-------------------------+--------------+---------------------+----------------+--------+----------------+ | 19 | NULL | OpacMainUserBlock_fr-CA | OpacMainUserBlock_fr-CA | 2021-02-01 | 2022-09-27 11:49:20 | NULL | 0 | NULL | | 20 | NULL | OpacMainUserBlock_en | OpacMainUserBlock_en | 2021-02-01 | 2022-09-27 11:49:20 | NULL | 0 | NULL | | 31 | NULL | Ouverture | OpacMainUserBlock_fr-CA | 2021-06-22 | 2022-08-10 10:08:52 | NULL | 1 | 1 | | 32 | NULL | Welcome | OpacMainUserBlock_en | 2021-06-22 | 2022-08-10 10:08:52 | NULL | 1 | 1 | +-------+------------+-------------------------+-------------------------+--------------+---------------------+----------------+--------+----------------+ 4 rows in set (0.000 sec) After the upgrade, I have six 'OpacMainUserBlock' contents, four defaults and two fr-CA. It seems like it doubled the fr-CA ones (one default and one fr-CA for each) and changed the en ones into default. select idnew, category, code, location, branchcode, title, lang, published_on, expirationdate, number, borrowernumber from additional_contents where location = 'OpacMainUserBlock' order by code; +-------+---------------------+---------+-------------------+------------+-------------------------+---------+--------------+----------------+--------+----------------+ | idnew | category | code | location | branchcode | title | lang | published_on | expirationdate | number | borrowernumber | +-------+---------------------+---------+-------------------+------------+-------------------------+---------+--------------+----------------+--------+----------------+ | 20 | html_customizations | News_20 | OpacMainUserBlock | NULL | OpacMainUserBlock_en | default | 2021-02-01 | NULL | 0 | NULL | | 32 | html_customizations | News_32 | OpacMainUserBlock | NULL | Welcome | default | 2021-06-22 | NULL | 1 | 1 | | 19 | html_customizations | News_49 | OpacMainUserBlock | NULL | OpacMainUserBlock_fr-CA | fr-CA | 2021-02-01 | NULL | 0 | NULL | | 49 | html_customizations | News_49 | OpacMainUserBlock | NULL | OpacMainUserBlock_fr-CA | default | 2021-02-01 | NULL | 0 | NULL | | 31 | html_customizations | News_55 | OpacMainUserBlock | NULL | Ouverture | fr-CA | 2021-06-22 | NULL | 1 | 1 | | 55 | html_customizations | News_55 | OpacMainUserBlock | NULL | Ouverture | default | 2021-06-22 | NULL | 1 | 1 | +-------+---------------------+---------+-------------------+------------+-------------------------+---------+--------------+----------------+--------+----------------+ 6 rows in set (0.000 sec) The contents are doubled everywhere in the OPAC, both in English and French. So I think default appears no matter which language were on? I'm wondering if it's necessary to create defaults? It was not possible to have that before with the news, it had to be in either language. So I don't think it makes sense to create a default in the course of the upgrade... (It's fine to use default after of course). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 23:27:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 21:27:58 +0000 Subject: [Koha-bugs] [Bug 15500] Add FRBRized view to OPAC & staff interface results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15500 --- Comment #7 from Heather --- (In reply to Jonathan Field from comment #5) Hi, Jonathan! FAST is only a project of OCLC, based on Library of Congress Subject Headings: https://fast.oclc.org/ I haven't heard anything about Library of Congress being involved, and their application and use of authorized terms based on their authority records/file is, well, essential to the project.:) Library of Congress is definitely not moving away from authorities, and most academic and research libraries aren't moving away from them, at least here! Authorities are even essential when moving to using URIs--the URI has to point to something.:) Cheerio! h2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 23:35:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 21:35:28 +0000 Subject: [Koha-bugs] [Bug 31923] 'Ignore' tab description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142440|0 |1 is obsolete| | --- Comment #4 from Caroline Cyr La Rose --- Created attachment 142444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142444&action=edit Bug 31923: 'Ignore' tab description is misleading This patch modifies the description of the 'Ignore' tab in MARC bibliographic and authority framework administration to add that not only does the 'ignored' subfield not appear in the editor, but the subfield will also be deleted from the record. To test: 1. Go to Administration > MARC bibliographic framework 2. Click 'Actions' next to any framework and choose 'MARC structure' 3. Click 'Actions' next to any field and choose 'Edit subfields' 4. Check the hint/description under 'Managed in tab' and make sure it - makes sense - is written in correct english (syntax and spelling) - mentions that the subfield's value will be deleted from the record 5. Go to Administration > Authority types 6. Redo steps 2-4 for authority frameworks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 23:40:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 21:40:08 +0000 Subject: [Koha-bugs] [Bug 31923] 'Ignore' tab description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 --- Comment #5 from Caroline Cyr La Rose --- Created attachment 142445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142445&action=edit Bug 31923: 'Ignore' tab description is misleading This patch adds a small warning sign before the sentence and also puts the sentence inside a span. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 23:43:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 21:43:32 +0000 Subject: [Koha-bugs] [Bug 31923] 'Ignore' tab description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 --- Comment #6 from Caroline Cyr La Rose --- Hi David! Thanks for testing! I corrected the "its". I also added a second commit with the warning sign. I wasn't sure how to put a space between the warning sign and the sentence... Maybe someone could help? Thanks! Caroline -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 23:45:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 21:45:59 +0000 Subject: [Koha-bugs] [Bug 11690] topissues should ignore suppressed titles/items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11690 Michael Spagnuolo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspagnuolo at nrhtx.com --- Comment #1 from Michael Spagnuolo --- I would like to see this improvement as well. Our library has hidden some of the search filters due to internal circulating items appearing on the most popular list. We would also like these suppressed items to be hidden in the top issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 23:46:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 21:46:40 +0000 Subject: [Koha-bugs] [Bug 31923] 'Ignore' tab description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142445|0 |1 is obsolete| | --- Comment #7 from Caroline Cyr La Rose --- Created attachment 142446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142446&action=edit Bug 31923: 'Ignore' tab description is misleading This patch adds a small warning sign before the sentence and also puts the sentence inside a span. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 23:52:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 21:52:25 +0000 Subject: [Koha-bugs] [Bug 31923] 'Ignore' tab description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142444|0 |1 is obsolete| | Attachment #142446|0 |1 is obsolete| | --- Comment #8 from Caroline Cyr La Rose --- Created attachment 142447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142447&action=edit Bug 31923: 'Ignore' tab description is misleading This patch modifies the description of the 'Ignore' tab in MARC bibliographic and authority framework administration to add that not only does the 'ignored' subfield not appear in the editor, but the subfield will also be deleted from the record. To test: 1. Go to Administration > MARC bibliographic framework 2. Click 'Actions' next to any framework and choose 'MARC structure' 3. Click 'Actions' next to any field and choose 'Edit subfields' 4. Check the hint/description under 'Managed in tab' and make sure it - makes sense - is written in correct english (syntax and spelling) - mentions that the subfield's value will be deleted from the record 5. Go to Administration > Authority types 6. Redo steps 2-4 for authority frameworks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 23:52:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 21:52:29 +0000 Subject: [Koha-bugs] [Bug 31923] 'Ignore' tab description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 --- Comment #9 from Caroline Cyr La Rose --- Created attachment 142448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142448&action=edit Bug 31923: 'Ignore' tab description is misleading This patch adds a small warning sign before the sentence and also puts the sentence inside a span. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 21 23:54:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 21:54:52 +0000 Subject: [Koha-bugs] [Bug 31923] 'Ignore' tab description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 --- Comment #10 from Caroline Cyr La Rose --- I think I managed the space, but I'm not sure if it is the right way to do it... Also I had to flex my (teeny tiny) git muscles quite a lot so I hope my submissions are OK! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 00:16:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 22:16:31 +0000 Subject: [Koha-bugs] [Bug 31282] Broken characters in patron_emailer.pl verbose mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31282 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |victor at tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 00:18:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 22:18:58 +0000 Subject: [Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #64 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 00:18:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 22:18:58 +0000 Subject: [Koha-bugs] [Bug 28363] Always use semicolon when preference CSVDelimiter is missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28363 Bug 28363 depends on bug 28327, which changed state. Bug 28327 Summary: System preference CSVdelimiter special case for tabulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 00:23:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 22:23:36 +0000 Subject: [Koha-bugs] [Bug 31076] Bug 22605 breaks date of publication range search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31076 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #10 from Victor Grousset/tuxayo --- Missing dependencies for 21.05.x, it shouldn't be affected, no backport. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 00:24:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 22:24:03 +0000 Subject: [Koha-bugs] [Bug 31925] New: AutoCreateAuthorities needs to preserve subject heading thesaurus to not create duplicate authority records Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31925 Bug ID: 31925 Summary: AutoCreateAuthorities needs to preserve subject heading thesaurus to not create duplicate authority records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: phil at chetcolibrary.org QA Contact: testopia at bugs.koha-community.org CC: nick at bywatersolutions.com Depends on: 30280 Bug 30280 taught the linker that "650 _ 0 $aFeminism" and "650 _ 7 $aFeminism$2sao" are not the same heading, so a bib record containing the latter should not be linked to the authority record which matches the former. However, AutoCreateAuthorities just creates LCSH authority records from anything, no matter what the values of indicator 2 and subfield 2 are. As a result, if you have an LCSH authority record for a term, and you import/create a non-LCSH term in a bib record and save it, AutoCreateAuthorities will create a new duplicate LCSH authority record and link to that. Every single time, a new duplicate. Steps to reproduce: 1. Use ElasticSearch, since the patch for bug 30280 only expected to work there, and in fact broke linking on Zebra, bug 31924. 2. Enable the preferences AutoCreateAuthorities, AutoLinkBiblios, CatalogModuleRelink 3. Edit any bib record, add a 650 tag, set the second indicator to 7, type Feminism in subfield a and type sao in subfield 2. 4. Save the record, edit it again, note the authority record id in subfield 9 of the Feminism heading. 5. Edit any other bib record, add a 650 tag, set the second indicator to 7, type Feminism in subfield a and type sao in subfield 2. 6. Save the record, edit it again, note the authority record id in subfield 9 of the Feminism heading. The two authority record ids should be the same, since the headings are identical, but instead one will be linked to, say, 1708 and the next to 1709, an identical duplicate record. Rather than setting position 11 of field 008 in the authority record to "a" for LCSH, AutoCreateAuthorities should have set it to "z" for Other and put sao in subfield f of field 040 (and for non-7, non-0 values of indicator 2, it should be setting 008/11 to the correct letter for that indicator value). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 [Bug 30280] Support authority records with common subject headings from different thesaurus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 00:24:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 22:24:03 +0000 Subject: [Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31925 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31925 [Bug 31925] AutoCreateAuthorities needs to preserve subject heading thesaurus to not create duplicate authority records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 00:24:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 22:24:44 +0000 Subject: [Koha-bugs] [Bug 31352] Terminology: Borrower name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31352 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |victor at tuxayo.net --- Comment #6 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 00:25:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 22:25:57 +0000 Subject: [Koha-bugs] [Bug 31425] Minor correction to patron categories admin title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31425 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #6 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 00:27:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 22:27:15 +0000 Subject: [Koha-bugs] [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to stable |RESOLVED --- Comment #8 from Victor Grousset/tuxayo --- Missing dependencies for 21.05.x, it shouldn't be affected, no backport. Dodged a bullet again :P -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 00:28:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 22:28:05 +0000 Subject: [Koha-bugs] [Bug 31390] Remove noisy warns in C4::Templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31390 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |victor at tuxayo.net --- Comment #6 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 00:28:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 22:28:06 +0000 Subject: [Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 Bug 31380 depends on bug 31390, which changed state. Bug 31390 Summary: Remove noisy warns in C4::Templates https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31390 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 00:29:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 22:29:45 +0000 Subject: [Koha-bugs] [Bug 31348] Plack stop should be graceful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31348 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #10 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 00:30:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 22:30:28 +0000 Subject: [Koha-bugs] [Bug 31387] Marking othernames as required via PatronSelfRegistrationBorrowerMandatoryField does not display required label In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31387 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to stable |RESOLVED --- Comment #6 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 00:31:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 22:31:46 +0000 Subject: [Koha-bugs] [Bug 31033] SIP2 configuration does not correctly handle multiple simultaneous connections by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |victor at tuxayo.net --- Comment #20 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 00:37:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 22:37:43 +0000 Subject: [Koha-bugs] [Bug 30918] Non-public note is visible in OPAC in Title Notes tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30918 --- Comment #13 from Victor Grousset/tuxayo --- Last month to get an opportunity to have this backported to 21.05.x if that is still needed and if someone can make a patch for 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 00:37:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 22:37:51 +0000 Subject: [Koha-bugs] [Bug 30744] Use RecordProcessor in get_marc_notes to ensure non-public notes do not leak In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 --- Comment #30 from Victor Grousset/tuxayo --- Last month to get an opportunity to have this backported to 21.05.x if that is still needed and if someone can make a patch for 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 01:40:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Oct 2022 23:40:31 +0000 Subject: [Koha-bugs] [Bug 30252] lower version of 'Locale::XGettext::TT2' to 0.6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30252 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.05 |22.05.00,21.11.05,21.05.20 released in| | Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #15 from Victor Grousset/tuxayo --- Backported: Pushed to 21.05.x branch for the upcoming release (21.05.20) Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 02:17:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 00:17:22 +0000 Subject: [Koha-bugs] [Bug 31859] Error 500 when enabling advanced cataloging editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31859 Jonathan Cuéllar changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 10:23:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 08:23:01 +0000 Subject: [Koha-bugs] [Bug 31765] Add 'page-section' to import patrons page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31765 --- Comment #1 from Martin Renvoize --- Created attachment 142449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142449&action=edit Bug 31765: Add page-section and bg-info classes to 'Notes' This patch adds the page-section and bg-info classes to the 'Notes' section of the patron imports page. As part of this patch, we update the base 'card' mixin to allow background colors to be overwridden with the standard bg-* options available in [bootstrap](https://getbootstrap.com/docs/4.0/utilities/colors/) Test plan 1) Build your CSS in the usual way 2) Confirm the Notes block looks OK on the patron imports tool -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 10:23:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 08:23:58 +0000 Subject: [Koha-bugs] [Bug 31765] Add 'page-section' to import patrons page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31765 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 11:23:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 09:23:39 +0000 Subject: [Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #55 from Katrin Fischer --- hi Frank, could you maybe have a look at the new bugs in Blocks? bug 31924 and bug 31925. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 11:45:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 09:45:05 +0000 Subject: [Koha-bugs] [Bug 31920] Unit test t/db_dependent/Holds.t leaves behind database cruft In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31920 --- Comment #4 from Katrin Fischer --- Thanks a lot Kyle :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 11:45:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 09:45:44 +0000 Subject: [Koha-bugs] [Bug 31920] Unit test t/db_dependent/Holds.t leaves behind database cruft In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31920 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 11:45:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 09:45:49 +0000 Subject: [Koha-bugs] [Bug 31920] Unit test t/db_dependent/Holds.t leaves behind database cruft In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31920 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142442|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 142450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142450&action=edit Bug 31920: Add transaction to subtest in t/db_dependent/Holds.t A subest in t/db_dependent/Holds.t leaves behind database cruft. Test Plan: Using koha-testing-docker: 1) SELECT branchcode FROM branches 2) prove t/db_dependent/Holds.t 3) SELECT branchcode FROM branches Note cruft 4) reset_all 2) prove t/db_dependent/Holds.t 3) SELECT branchcode FROM branches No cruft! Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 11:46:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 09:46:15 +0000 Subject: [Koha-bugs] [Bug 31920] Unit test t/db_dependent/Holds.t leaves behind database cruft In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31920 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 11:51:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 09:51:00 +0000 Subject: [Koha-bugs] [Bug 31812] Add yellow to buttons on staged imports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31757 |30952 --- Comment #2 from Katrin Fischer --- i meant one step earlier, when you stage: * Upload file * Stage for import Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 11:51:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 09:51:00 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31812 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 [Bug 31812] Add yellow to buttons on staged imports page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 11:51:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 09:51:00 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|31812 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 [Bug 31812] Add yellow to buttons on staged imports page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 11:52:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 09:52:24 +0000 Subject: [Koha-bugs] [Bug 31812] Add yellow to stage imports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add yellow to buttons on |Add yellow to stage imports |staged imports page |page --- Comment #3 from Katrin Fischer --- Possibly really meant something else when first filing this, but this looks good now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 11:59:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 09:59:25 +0000 Subject: [Koha-bugs] [Bug 31813] Specify white-space: normal for spans styled as labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 --- Comment #7 from Katrin Fischer --- The wrapping is good, of course, but why do we limit the rather long labels to such a small column? It would also help with the even longer German translations to give a bit more space :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:02:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:02:37 +0000 Subject: [Koha-bugs] [Bug 31813] Specify white-space: normal for spans styled as labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:02:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:02:42 +0000 Subject: [Koha-bugs] [Bug 31813] Specify white-space: normal for spans styled as labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142196|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 142451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142451&action=edit Bug 31813: Specify white-space: normal for spans styled as labels This patch is necessary to override a CSS property being inherited from Bootstrap. Allowing a with the "label" class to wrap will keep alignment correct when displaying information in the same layout as a form. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - If necessary, stage a batch of MARC files (Cataloging -> Stage MARC records for import). - Go to Cataloging -> Manage staged MARC records and click on one of the batches to view the details. - In the list of information about the batch, longer labels like "Matching rule applied" should wrap so that they stay aligned with other labels in the list. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:02:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:02:47 +0000 Subject: [Koha-bugs] [Bug 31813] Specify white-space: normal for spans styled as labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142197|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 142452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142452&action=edit Bug 31813: (follow-up) Add missing colon for managed staged MARC records Add colon after "Matching rule applied" when viewing details for a batch already imported. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:03:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:03:20 +0000 Subject: [Koha-bugs] [Bug 31813] Specify white-space: normal for spans styled as labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:10:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:10:39 +0000 Subject: [Koha-bugs] [Bug 31870] Cleaning up t/db_dependent/Context.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31870 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:10:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:10:43 +0000 Subject: [Koha-bugs] [Bug 31870] Cleaning up t/db_dependent/Context.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31870 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142149|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 142453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142453&action=edit Bug 31870: Groundwork for Context.t Replacing the vars statement. Adding a larger subtest. Removing TransformVersionToNum. Test plan: Run t/db_dependent/Context.t Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:10:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:10:48 +0000 Subject: [Koha-bugs] [Bug 31870] Cleaning up t/db_dependent/Context.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31870 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142150|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 142454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142454&action=edit Bug 31870: Context.t: Fix indentation, remove old comments Test plan: Run test again. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:10:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:10:53 +0000 Subject: [Koha-bugs] [Bug 31870] Cleaning up t/db_dependent/Context.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31870 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142151|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 142455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142455&action=edit Bug 31870: Context.t: Reorganize subtests Move a few tests into separate subtests. Replace the BEGIN block. Test plan: Run test again. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:10:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:10:57 +0000 Subject: [Koha-bugs] [Bug 31870] Cleaning up t/db_dependent/Context.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31870 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142152|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 142456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142456&action=edit Bug 31870: Add license, remove unused modules Test plan: Run test again. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:23:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:23:36 +0000 Subject: [Koha-bugs] [Bug 31676] Make db_dependent/Circulation.t tests more robust In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix |Make |db_dependent/Circulation.t |db_dependent/Circulation.t |tests |tests more robust --- Comment #15 from Katrin Fischer --- This makes the tests a little more robust/less dependent on the default setup. Recently I noticed that most of the time they would only pass on a new db/reset_all database for me, so hopeful that will help with that :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:24:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:24:08 +0000 Subject: [Koha-bugs] [Bug 31676] Make db_dependent/Circulation.t tests more robust In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:24:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:24:12 +0000 Subject: [Koha-bugs] [Bug 31676] Make db_dependent/Circulation.t tests more robust In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141625|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 142457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142457&action=edit Bug 31676: Fix db_dependent/Circulation.t tests To test: 1) Set "RenewalPeriodBase" syspref to "the current date", "CircControl" to "the library the item is from." and "HomeOrHoldingBranch" to "the item's home library (homebranch)." 2) Run tests in t/db_dependent/Circulation.t and verify that fails (the script should actually crash before all can be run). 3) Apply the patch 4) Verifiy that all tests now pass Sponsored-by: Gothenburg University Library Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:25:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:25:13 +0000 Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com |ity.org | --- Comment #18 from Katrin Fischer --- Please don't forget to fill in the Assignee field when taking on a bug, thx! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:28:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:28:50 +0000 Subject: [Koha-bugs] [Bug 31879] Convert mainpage.css to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31879 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:28:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:28:55 +0000 Subject: [Koha-bugs] [Bug 31879] Convert mainpage.css to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31879 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142203|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 142458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142458&action=edit Bug 31879: Convert mainpage.css to SCSS This patch creates a new SCSS file to be used to generate mainpage.css, the stylesheet used specifically for the staff interface home page. The patch makes visible changes in only two places: Removing borders from two elements to make them consistent with the new staff interface design: - div.pending-info, where pending actions like patrons requesting modifications are shown. - div#area-userblock, where the contents of the IntranetmainUserblock system preference are displayed. Otherwise the changes are all for the purpose of properly nesting elements according to SCSS rules and other fixes related to stylelint rules. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View the main page of the staff interface. Everything should look like it did before except for those elements which have had their borders removed. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:29:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:29:14 +0000 Subject: [Koha-bugs] [Bug 31879] Convert mainpage.css to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31879 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:34:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:34:09 +0000 Subject: [Koha-bugs] [Bug 31926] New: Add page-section to MARC frameworks page (admin) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31926 Bug ID: 31926 Summary: Add page-section to MARC frameworks page (admin) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Blocks: 31757 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:34:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:34:09 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31926 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31926 [Bug 31926] Add page-section to MARC frameworks page (admin) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:34:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:34:09 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31926 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31926 [Bug 31926] Add page-section to MARC frameworks page (admin) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:35:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:35:05 +0000 Subject: [Koha-bugs] [Bug 31926] Add page-section to MARC framework pages (admin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31926 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add page-section to MARC |Add page-section to MARC |frameworks page (admin) |framework pages (admin) --- Comment #1 from Katrin Fischer --- We need to update the frameworks list, but also the framework structure. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:36:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:36:32 +0000 Subject: [Koha-bugs] [Bug 31926] Add page-section to MARC framework pages (admin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31926 --- Comment #2 from Katrin Fischer --- ... and subfields list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:41:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:41:44 +0000 Subject: [Koha-bugs] [Bug 31927] New: Use bigger font-size for bibliographic information on staff details page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31927 Bug ID: 31927 Summary: Use bigger font-size for bibliographic information on staff details page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 The bibliographic details are rather small and hard to read. This is important for libraries, it should be a little easier/bigger :) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:41:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:41:44 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31927 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31927 [Bug 31927] Use bigger font-size for bibliographic information on staff details page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:44:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:44:01 +0000 Subject: [Koha-bugs] [Bug 31928] New: Add page-section to callnumber browser value builder (cat) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928 Bug ID: 31928 Summary: Add page-section to callnumber browser value builder (cat) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Blocks: 31757 The cn_browser.pl value builder uses a pop-up window with a big table inside. the page section would help here with it's white background color. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:44:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:44:01 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31928 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928 [Bug 31928] Add page-section to callnumber browser value builder (cat) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 12:44:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 10:44:01 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31928 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928 [Bug 31928] Add page-section to callnumber browser value builder (cat) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 13:14:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 11:14:52 +0000 Subject: [Koha-bugs] [Bug 28396] Call number browse pagination In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28396 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #5 from Katrin Fischer --- Something is not quite right here for me. As we have no callnumbers in the sample data, I copied the itemnumber into itemcallnumber, set cn_source to z (generic) and ran touch_all_items so set cn_sort. For me the main purpose of the callnumber browser is to quickly determine if a callnumber has already been used. If it's used, you have a red line, if it's free, you see a green line where the callnumber would be. 1) Existing: Search for 26 Old: You get the red markup for 26. 26 shows between 259 and 260 as expected. New: Same. OK. 2) Not existing: Search for 1000 Old: Green line between 100 and 101 as expected. New: You see the green line on top of the table, before 1, you are no longer seeing the "before and after" correctly. Not OK. 3) Existing, not on first page: Search for 500 Old: You get the red markup for 500. 500 shows between 50 and 501 as expected. New: You see the page with the first numbers, no clue red or green as the number is on a much later page. You can page there... (not nice) or you can use the table search - more clicks and you don't see the before and after. Not OK. 2) Modal For me the window is a bit too small now and the table doesn't resize properly when the window size is increased (maybe side effects of the new staff design?) 3) Sorting cn_sort should be used for sorting on the call number column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 13:15:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 11:15:32 +0000 Subject: [Koha-bugs] [Bug 28396] Call number browse pagination In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28396 --- Comment #6 from Katrin Fischer --- My numbering is off... should have been 1 abc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 22 20:48:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 18:48:36 +0000 Subject: [Koha-bugs] [Bug 31927] Use bigger font-size for bibliographic information on staff details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31927 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #1 from Barbara Johnson --- +1 The current font size is super small and very hard to read. A larger font size will increase staff efficiency and reduce eye strain. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:06:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:06:41 +0000 Subject: [Koha-bugs] [Bug 19540] opac-reserve does not correctly warn of too_much reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19540 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:06:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:06:44 +0000 Subject: [Koha-bugs] [Bug 19540] opac-reserve does not correctly warn of too_much reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19540 --- Comment #18 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:06:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:06:47 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:06:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:06:51 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #54 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:06:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:06:54 +0000 Subject: [Koha-bugs] [Bug 26632] BatchStageMarcRecords passes a random number to AddBiblioToBatch / AddAuthToBatch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26632 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:06:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:06:57 +0000 Subject: [Koha-bugs] [Bug 26632] BatchStageMarcRecords passes a random number to AddBiblioToBatch / AddAuthToBatch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26632 --- Comment #12 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:06:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:06:59 +0000 Subject: [Koha-bugs] [Bug 27849] Koha::Token may access undefined C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27849 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:07:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:07:02 +0000 Subject: [Koha-bugs] [Bug 27849] Koha::Token may access undefined C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27849 --- Comment #11 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:07:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:07:05 +0000 Subject: [Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00,21.11 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:07:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:07:09 +0000 Subject: [Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #65 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:07:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:07:12 +0000 Subject: [Koha-bugs] [Bug 28707] Missing strings in translation of sample data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28707 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:07:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:07:15 +0000 Subject: [Koha-bugs] [Bug 28707] Missing strings in translation of sample data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28707 --- Comment #10 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:07:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:07:18 +0000 Subject: [Koha-bugs] [Bug 28864] The patron search results in the patron card creator doesn't seem to use PatronsPerPage syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:07:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:07:21 +0000 Subject: [Koha-bugs] [Bug 28864] The patron search results in the patron card creator doesn't seem to use PatronsPerPage syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864 --- Comment #28 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:07:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:07:24 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,22.11.00, 22.05.06 |22.11.00,22.11.00,21.11, released in| |22.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:07:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:07:28 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #54 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:07:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:07:31 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.01, |22.11.00,21.11, 22.05.01, released in|21.05.20 |21.05.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:07:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:07:34 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 --- Comment #79 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:07:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:07:37 +0000 Subject: [Koha-bugs] [Bug 29434] In UNIMARC instances, the authority finder uses MARC21 relationship codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:07:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:07:40 +0000 Subject: [Koha-bugs] [Bug 29434] In UNIMARC instances, the authority finder uses MARC21 relationship codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434 --- Comment #14 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:07:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:07:43 +0000 Subject: [Koha-bugs] [Bug 29782] Additional contents: Fix handling records without title or content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:07:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:07:46 +0000 Subject: [Koha-bugs] [Bug 29782] Additional contents: Fix handling records without title or content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782 --- Comment #17 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:07:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:07:49 +0000 Subject: [Koha-bugs] [Bug 30028] Patron message delete confirmation untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:07:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:07:52 +0000 Subject: [Koha-bugs] [Bug 30028] Patron message delete confirmation untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028 --- Comment #29 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:07:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:07:55 +0000 Subject: [Koha-bugs] [Bug 30468] koha-mysql does not honor Koha's timezone setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30468 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:07:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:07:58 +0000 Subject: [Koha-bugs] [Bug 30468] koha-mysql does not honor Koha's timezone setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30468 --- Comment #14 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:08:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:08:00 +0000 Subject: [Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:08:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:08:03 +0000 Subject: [Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 --- Comment #13 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:08:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:08:06 +0000 Subject: [Koha-bugs] [Bug 30779] Do not need to remove items from import biblios marc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:08:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:08:09 +0000 Subject: [Koha-bugs] [Bug 30779] Do not need to remove items from import biblios marc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 --- Comment #12 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:08:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:08:13 +0000 Subject: [Koha-bugs] [Bug 30797] Subfields linked to the dateaccessioned.pl value builder on addbiblio.pl throw a JS error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30797 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:08:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:08:16 +0000 Subject: [Koha-bugs] [Bug 30797] Subfields linked to the dateaccessioned.pl value builder on addbiblio.pl throw a JS error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30797 --- Comment #11 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:08:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:08:19 +0000 Subject: [Koha-bugs] [Bug 30976] Cover images for biblio should be displayed first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.04, |22.11.00,21.11, 22.05.04, released in|21.11.11 |21.11.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:08:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:08:22 +0000 Subject: [Koha-bugs] [Bug 30976] Cover images for biblio should be displayed first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976 --- Comment #15 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:08:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:08:25 +0000 Subject: [Koha-bugs] [Bug 30984] Action logs should log the cronjob script name that generated the given log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30984 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:08:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:08:26 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |arthur.suzuki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:08:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:08:27 +0000 Subject: [Koha-bugs] [Bug 30984] Action logs should log the cronjob script name that generated the given log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30984 --- Comment #13 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:08:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:08:30 +0000 Subject: [Koha-bugs] [Bug 31033] SIP2 configuration does not correctly handle multiple simultaneous connections by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:08:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:08:33 +0000 Subject: [Koha-bugs] [Bug 31033] SIP2 configuration does not correctly handle multiple simultaneous connections by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 --- Comment #21 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:08:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:08:36 +0000 Subject: [Koha-bugs] [Bug 31076] Bug 22605 breaks date of publication range search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31076 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00,21.11 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:08:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:08:39 +0000 Subject: [Koha-bugs] [Bug 31076] Bug 22605 breaks date of publication range search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31076 --- Comment #11 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:08:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:08:41 +0000 Subject: [Koha-bugs] [Bug 31155] Document --since option in help of borrowers-force-messaging-defaults.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31155 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11., 22.05.06 |22.11.,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:08:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:08:45 +0000 Subject: [Koha-bugs] [Bug 31155] Document --since option in help of borrowers-force-messaging-defaults.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31155 --- Comment #8 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:08:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:08:45 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:08:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:08:47 +0000 Subject: [Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel cover images in the OPAC lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:08:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:08:50 +0000 Subject: [Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel cover images in the OPAC lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217 --- Comment #22 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:08:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:08:53 +0000 Subject: [Koha-bugs] [Bug 31222] DBIC queries for batch mod can be very large In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:08:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:08:55 +0000 Subject: [Koha-bugs] [Bug 31222] DBIC queries for batch mod can be very large In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222 --- Comment #19 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:08:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:08:58 +0000 Subject: [Koha-bugs] [Bug 31228] Fix Coce JavaScript to hide single-pixel cover images in both the staff client detail and results pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31228 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:09:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:09:01 +0000 Subject: [Koha-bugs] [Bug 31228] Fix Coce JavaScript to hide single-pixel cover images in both the staff client detail and results pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31228 --- Comment #19 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:09:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:09:03 +0000 Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if job not started In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:09:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:09:06 +0000 Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if job not started In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245 --- Comment #20 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:09:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:09:09 +0000 Subject: [Koha-bugs] [Bug 31249] update_patrons_category.pl cron does not log to action_logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31249 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:09:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:09:11 +0000 Subject: [Koha-bugs] [Bug 31249] update_patrons_category.pl cron does not log to action_logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31249 --- Comment #7 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:09:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:09:14 +0000 Subject: [Koha-bugs] [Bug 31251] "Clear" patron attribute link does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31251 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:09:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:09:17 +0000 Subject: [Koha-bugs] [Bug 31251] "Clear" patron attribute link does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31251 --- Comment #8 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:09:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:09:20 +0000 Subject: [Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:09:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:09:22 +0000 Subject: [Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 --- Comment #7 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:09:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:09:25 +0000 Subject: [Koha-bugs] [Bug 31276] Report results are limited to 999, 999 no matter the actual number of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31276 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:09:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:09:28 +0000 Subject: [Koha-bugs] [Bug 31276] Report results are limited to 999, 999 no matter the actual number of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31276 --- Comment #10 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:09:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:09:31 +0000 Subject: [Koha-bugs] [Bug 31281] Overdue notices reply-to email address of a branch not respected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:09:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:09:33 +0000 Subject: [Koha-bugs] [Bug 31281] Overdue notices reply-to email address of a branch not respected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 --- Comment #18 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:09:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:09:36 +0000 Subject: [Koha-bugs] [Bug 31282] Broken characters in patron_emailer.pl verbose mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31282 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00,21.11 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:09:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:09:39 +0000 Subject: [Koha-bugs] [Bug 31282] Broken characters in patron_emailer.pl verbose mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31282 --- Comment #9 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:09:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:09:41 +0000 Subject: [Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:09:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:09:44 +0000 Subject: [Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 --- Comment #12 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:09:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:09:47 +0000 Subject: [Koha-bugs] [Bug 31292] Untranslatable string in sample_notices.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31292 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:09:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:09:49 +0000 Subject: [Koha-bugs] [Bug 31292] Untranslatable string in sample_notices.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31292 --- Comment #9 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:09:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:09:52 +0000 Subject: [Koha-bugs] [Bug 31294] Article requests: Mandatory subfields in OPAC don't show they are required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:09:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:09:55 +0000 Subject: [Koha-bugs] [Bug 31294] Article requests: Mandatory subfields in OPAC don't show they are required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 --- Comment #7 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:09:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:09:57 +0000 Subject: [Koha-bugs] [Bug 31302] Spelling: You can download the scanned materials via the following url(s): In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31302 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:10:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:10:00 +0000 Subject: [Koha-bugs] [Bug 31302] Spelling: You can download the scanned materials via the following url(s): In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31302 --- Comment #7 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:10:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:10:03 +0000 Subject: [Koha-bugs] [Bug 31325] Fix koha-preferences get In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31325 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:10:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:10:06 +0000 Subject: [Koha-bugs] [Bug 31325] Fix koha-preferences get In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31325 --- Comment #8 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:10:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:10:09 +0000 Subject: [Koha-bugs] [Bug 31346] On the OPAC detail page some Syndetics links are wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31346 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:10:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:10:12 +0000 Subject: [Koha-bugs] [Bug 31346] On the OPAC detail page some Syndetics links are wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31346 --- Comment #9 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:10:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:10:15 +0000 Subject: [Koha-bugs] [Bug 31348] Plack stop should be graceful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31348 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:10:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:10:17 +0000 Subject: [Koha-bugs] [Bug 31348] Plack stop should be graceful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31348 --- Comment #11 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:10:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:10:20 +0000 Subject: [Koha-bugs] [Bug 31352] Terminology: Borrower name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31352 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:10:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:10:23 +0000 Subject: [Koha-bugs] [Bug 31352] Terminology: Borrower name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31352 --- Comment #7 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:10:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:10:26 +0000 Subject: [Koha-bugs] [Bug 31387] Marking othernames as required via PatronSelfRegistrationBorrowerMandatoryField does not display required label In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31387 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:10:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:10:28 +0000 Subject: [Koha-bugs] [Bug 31387] Marking othernames as required via PatronSelfRegistrationBorrowerMandatoryField does not display required label In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31387 --- Comment #7 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:10:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:10:31 +0000 Subject: [Koha-bugs] [Bug 31390] Remove noisy warns in C4::Templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31390 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00,21.11 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:10:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:10:34 +0000 Subject: [Koha-bugs] [Bug 31390] Remove noisy warns in C4::Templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31390 --- Comment #7 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:10:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:10:36 +0000 Subject: [Koha-bugs] [Bug 31425] Minor correction to patron categories admin title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31425 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:10:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:10:39 +0000 Subject: [Koha-bugs] [Bug 31425] Minor correction to patron categories admin title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31425 --- Comment #7 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:10:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:10:41 +0000 Subject: [Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06, |22.11.00,21.11, 22.05.06, released in|21.05.19 |21.05.19 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:10:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:10:44 +0000 Subject: [Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 --- Comment #7 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:10:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:10:47 +0000 Subject: [Koha-bugs] [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 00:10:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Oct 2022 22:10:49 +0000 Subject: [Koha-bugs] [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 --- Comment #9 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:25:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:25:01 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:25:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:25:02 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Bug 17170 depends on bug 22605, which changed state. Bug 22605 Summary: Adding the option to modify/edit searches on the staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:25:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:25:03 +0000 Subject: [Koha-bugs] [Bug 27546] Add option to search within results on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546 Bug 27546 depends on bug 22605, which changed state. Bug 22605 Summary: Adding the option to modify/edit searches on the staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:25:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:25:04 +0000 Subject: [Koha-bugs] [Bug 30357] Better display of 'Edit this search' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30357 Bug 30357 depends on bug 22605, which changed state. Bug 22605 Summary: Adding the option to modify/edit searches on the staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:25:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:25:04 +0000 Subject: [Koha-bugs] [Bug 31076] Bug 22605 breaks date of publication range search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31076 Bug 31076 depends on bug 22605, which changed state. Bug 22605 Summary: Adding the option to modify/edit searches on the staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:27:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:27:32 +0000 Subject: [Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #66 from Katrin Fischer --- Something is odd here, how can this be in 22.11 and 21.11, but not in 22.05? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:28:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:28:28 +0000 Subject: [Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11 |22.11.00,22.05.06,21.11.12 released in| | --- Comment #67 from Katrin Fischer --- Fixed the Versions from the comments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:39:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:39:24 +0000 Subject: [Koha-bugs] [Bug 28707] Missing strings in translation of sample data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28707 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,21.11.12,22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:41:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:41:57 +0000 Subject: [Koha-bugs] [Bug 28864] The patron search results in the patron card creator doesn't seem to use PatronsPerPage syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:42:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:42:37 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,22.11.00,21.11, |22.11.00,22.11.00,22.05.06, released in|22.05.06 |21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:43:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:43:21 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.01, |22.11.00,22.05.01,21.11.12, released in|21.05.20 |21.05.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:43:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:43:56 +0000 Subject: [Koha-bugs] [Bug 29434] In UNIMARC instances, the authority finder uses MARC21 relationship codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:44:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:44:19 +0000 Subject: [Koha-bugs] [Bug 29782] Additional contents: Fix handling records without title or content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:44:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:44:50 +0000 Subject: [Koha-bugs] [Bug 30028] Patron message delete confirmation untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:45:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:45:25 +0000 Subject: [Koha-bugs] [Bug 30468] koha-mysql does not honor Koha's timezone setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30468 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:45:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:45:54 +0000 Subject: [Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:46:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:46:23 +0000 Subject: [Koha-bugs] [Bug 30779] Do not need to remove items from import biblios marc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:46:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:46:41 +0000 Subject: [Koha-bugs] [Bug 30797] Subfields linked to the dateaccessioned.pl value builder on addbiblio.pl throw a JS error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30797 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11 |22.05.00,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:47:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:47:33 +0000 Subject: [Koha-bugs] [Bug 30976] Cover images for biblio should be displayed first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.04, |22.11.00,22.05.04,21.11.12 released in|21.11.11 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:48:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:48:13 +0000 Subject: [Koha-bugs] [Bug 30984] Action logs should log the cronjob script name that generated the given log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30984 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:48:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:48:45 +0000 Subject: [Koha-bugs] [Bug 31033] SIP2 configuration does not correctly handle multiple simultaneous connections by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:49:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:49:19 +0000 Subject: [Koha-bugs] [Bug 31076] Bug 22605 breaks date of publication range search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31076 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11 |22.11.00,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:49:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:49:59 +0000 Subject: [Koha-bugs] [Bug 31155] Document --since option in help of borrowers-force-messaging-defaults.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31155 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:50:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:50:24 +0000 Subject: [Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel cover images in the OPAC lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:50:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:50:48 +0000 Subject: [Koha-bugs] [Bug 31222] DBIC queries for batch mod can be very large In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:51:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:51:08 +0000 Subject: [Koha-bugs] [Bug 31228] Fix Coce JavaScript to hide single-pixel cover images in both the staff client detail and results pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31228 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:51:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:51:33 +0000 Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if job not started In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:52:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:52:00 +0000 Subject: [Koha-bugs] [Bug 31249] update_patrons_category.pl cron does not log to action_logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31249 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:52:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:52:24 +0000 Subject: [Koha-bugs] [Bug 31251] "Clear" patron attribute link does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31251 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:52:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:52:53 +0000 Subject: [Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:53:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:53:12 +0000 Subject: [Koha-bugs] [Bug 31276] Report results are limited to 999, 999 no matter the actual number of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31276 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:53:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:53:46 +0000 Subject: [Koha-bugs] [Bug 31281] Overdue notices reply-to email address of a branch not respected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:54:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:54:14 +0000 Subject: [Koha-bugs] [Bug 31282] Broken characters in patron_emailer.pl verbose mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31282 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:54:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:54:38 +0000 Subject: [Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:54:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:54:59 +0000 Subject: [Koha-bugs] [Bug 31292] Untranslatable string in sample_notices.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31292 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:55:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:55:28 +0000 Subject: [Koha-bugs] [Bug 31294] Article requests: Mandatory subfields in OPAC don't show they are required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:55:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:55:53 +0000 Subject: [Koha-bugs] [Bug 31302] Spelling: You can download the scanned materials via the following url(s): In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31302 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:56:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:56:19 +0000 Subject: [Koha-bugs] [Bug 31325] Fix koha-preferences get In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31325 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:56:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:56:39 +0000 Subject: [Koha-bugs] [Bug 31346] On the OPAC detail page some Syndetics links are wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31346 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:57:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:57:09 +0000 Subject: [Koha-bugs] [Bug 31348] Plack stop should be graceful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31348 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:57:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:57:27 +0000 Subject: [Koha-bugs] [Bug 31352] Terminology: Borrower name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:57:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:57:55 +0000 Subject: [Koha-bugs] [Bug 31387] Marking othernames as required via PatronSelfRegistrationBorrowerMandatoryField does not display required label In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31387 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:58:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:58:16 +0000 Subject: [Koha-bugs] [Bug 31390] Remove noisy warns in C4::Templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31390 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:58:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:58:39 +0000 Subject: [Koha-bugs] [Bug 31425] Minor correction to patron categories admin title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31425 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:59:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:59:11 +0000 Subject: [Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06, |22.11.00,22.05.06,21.11.12, released in|21.05.19 |21.05.19 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 11:59:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 09:59:42 +0000 Subject: [Koha-bugs] [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 13:53:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 11:53:16 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to basket summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 13:53:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 11:53:24 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to basket summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142232|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 142459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142459&action=edit Bug 31837: Add page-section class to tables on basket.tt This patch adds the page-section class to the orders and cancelled orders tables. To test: 1. Have a vendor, basket, and create an order. 2. Go look at the table on basket.tt and make sure the orders table looks good. 3. Cancel some orders and look at the cancelled order table, make sure it also looks good. Note: I made some indentation changes. I also did NOT add a new wrapper to the cancelled orders table, it already had one so I just added the page-section div to the existing div. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 13:53:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 11:53:32 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to basket summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 --- Comment #9 from Katrin Fischer --- Created attachment 142460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142460&action=edit Bug 31837: (follow-up) Move page-section to include h2 headings Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 14:42:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 12:42:04 +0000 Subject: [Koha-bugs] [Bug 31765] Add 'page-section' to import patrons page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31765 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 14:42:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 12:42:09 +0000 Subject: [Koha-bugs] [Bug 31765] Add 'page-section' to import patrons page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31765 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142449|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 142461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142461&action=edit Bug 31765: Add page-section and bg-info classes to 'Notes' This patch adds the page-section and bg-info classes to the 'Notes' section of the patron imports page. As part of this patch, we update the base 'card' mixin to allow background colors to be overwridden with the standard bg-* options available in [bootstrap](https://getbootstrap.com/docs/4.0/utilities/colors/) Test plan 1) Build your CSS in the usual way 2) Confirm the Notes block looks OK on the patron imports tool -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 14:43:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 12:43:21 +0000 Subject: [Koha-bugs] [Bug 31765] Add 'page-section' to import patrons page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31765 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 14:44:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 12:44:08 +0000 Subject: [Koha-bugs] [Bug 31765] Add 'page-section' to import patrons page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31765 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142461|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 142462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142462&action=edit Bug 31765: Add page-section and bg-info classes to 'Notes' This patch adds the page-section and bg-info classes to the 'Notes' section of the patron imports page. As part of this patch, we update the base 'card' mixin to allow background colors to be overwridden with the standard bg-* options available in [bootstrap](https://getbootstrap.com/docs/4.0/utilities/colors/) Test plan 1) Build your CSS in the usual way 2) Confirm the Notes block looks OK on the patron imports tool Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 14:44:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 12:44:34 +0000 Subject: [Koha-bugs] [Bug 31765] Add 'page-section' to import patrons page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31765 --- Comment #4 from Katrin Fischer --- Moving this directly on to Tomas. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 14:48:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 12:48:47 +0000 Subject: [Koha-bugs] [Bug 31822] Add page-section to vendor detail page (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31822 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 14:48:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 12:48:52 +0000 Subject: [Koha-bugs] [Bug 31822] Add page-section to vendor detail page (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31822 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142412|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 142463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142463&action=edit Bug 31822: Add page-section to vendoer details page This patch contains whitespace changes which an be safely ignored. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 14:49:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 12:49:14 +0000 Subject: [Koha-bugs] [Bug 31822] Add page-section to vendor detail page (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31822 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer --- Moving to PQA directly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 14:54:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 12:54:51 +0000 Subject: [Koha-bugs] [Bug 31929] New: On vendor edit page options are not aligned Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31929 Bug ID: 31929 Summary: On vendor edit page options are not aligned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Created attachment 142464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142464&action=edit Screenshot of vendor edit page When editing a vendor, the radio boxed options at the bottom are not aligend right. The second option is displayed a little abvoe the first option. (see screenshot) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 14:54:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 12:54:51 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31929 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31929 [Bug 31929] On vendor edit page options are not aligned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 15:26:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 13:26:08 +0000 Subject: [Koha-bugs] [Bug 31821] Add page-section to vendor result list (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31821 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 15:26:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 13:26:13 +0000 Subject: [Koha-bugs] [Bug 31821] Add page-section to vendor result list (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31821 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142410|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 142465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142465&action=edit Bug 31821: Add page-section class to the vendor search results This patch adds a page-section class to each supplier block Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 15:26:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 13:26:51 +0000 Subject: [Koha-bugs] [Bug 31821] Add page-section to vendor result list (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31821 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Status|Signed Off |Passed QA --- Comment #4 from Katrin Fischer --- Simple change, straight to PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 15:27:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 13:27:20 +0000 Subject: [Koha-bugs] [Bug 31765] Add 'page-section' to import patrons page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31765 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 15:31:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 13:31:57 +0000 Subject: [Koha-bugs] [Bug 31930] New: Ignore whitespace before and after barcodes when adding items to rotating collections Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31930 Bug ID: 31930 Summary: Ignore whitespace before and after barcodes when adding items to rotating collections Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When you add items to a rotating collection by copy and pasting the barcode, there will often be whitespace causing a 'barcode not found' error. We should automatically remove/ignore this leading/trailing whitespace as we do in other forms like the checkout/checkin forms. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 15:38:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 13:38:05 +0000 Subject: [Koha-bugs] [Bug 31911] Headings are inconsistent in rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer --- I think this is a good improvement, but I am in doubt about this heading: Total items: 2 It doesn't feel like a heading to me, but more like it should appear in the line below one. Maybe the heading could be: Items in collection ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 16:24:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 14:24:44 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #55 from Nick Clemens --- (In reply to Arthur Suzuki from comment #54) > Thanks! > > Pushed to 21.11 for 21.11.12 This was reverted from 22.05, I think we should not backport this one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 22:21:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 20:21:50 +0000 Subject: [Koha-bugs] [Bug 31923] 'Ignore' tab description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 22:21:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 20:21:55 +0000 Subject: [Koha-bugs] [Bug 31923] 'Ignore' tab description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142447|0 |1 is obsolete| | Attachment #142448|0 |1 is obsolete| | --- Comment #11 from David Nind --- Created attachment 142466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142466&action=edit Bug 31923: 'Ignore' tab description is misleading This patch modifies the description of the 'Ignore' tab in MARC bibliographic and authority framework administration to add that not only does the 'ignored' subfield not appear in the editor, but the subfield will also be deleted from the record. To test: 1. Go to Administration > MARC bibliographic framework 2. Click 'Actions' next to any framework and choose 'MARC structure' 3. Click 'Actions' next to any field and choose 'Edit subfields' 4. Check the hint/description under 'Managed in tab' and make sure it - makes sense - is written in correct english (syntax and spelling) - mentions that the subfield's value will be deleted from the record 5. Go to Administration > Authority types 6. Redo steps 2-4 for authority frameworks Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 22:22:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 20:22:00 +0000 Subject: [Koha-bugs] [Bug 31923] 'Ignore' tab description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 --- Comment #12 from David Nind --- Created attachment 142467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142467&action=edit Bug 31923: Add warning sign and span This patch adds a small warning sign before the sentence and also puts the sentence inside a span. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 22:34:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 20:34:30 +0000 Subject: [Koha-bugs] [Bug 31923] 'Ignore' tab description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 --- Comment #13 from David Nind --- (In reply to Caroline Cyr La Rose from comment #10) > I think I managed the space, but I'm not sure if it is the right way to do > it... Also I had to flex my (teeny tiny) git muscles quite a lot so I hope > my submissions are OK! It looks OK to me, and the patch applied cleanly. I changed the title of the commit message for the second patch so that it is different from the main patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 23 23:57:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 21:57:16 +0000 Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Juliet Heltibridle changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle at rcplib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 00:00:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 22:00:47 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #322 from Victor Grousset/tuxayo --- Blou: > As I stated in comment 312 last month, we do not care much about performance anymore. Jonathan: > See also comment #121 > [note, comment 121 is about performances] Is there actually a worry about performances? At the time of the benchmarks with the test data, checkins & checkouts & fines.pl was either a bit faster or much faster depending on which of the 3 operations. So there doesn't seem to be much of a risk of regression. Or was the worry something else? Still need to have someone else replicate on the current codebase *but only if there isn't other concerns.* Jonathan: > and #154. > [link: comment 154] Ok so next would be to hope for one or two people from QA to check if the fundamental idea of the patch is good enough. And how much of Comment 119 still stands. I can try to advertise it. Meanwhile (or worse case in the long run), having it here is great so other libraries can pick it and report bugs as we have seen :D I know it's frustrating. Though the situation looks like lack of QAing resources in the community rather than fad. And the large patches are suffering the most from the large QA queue. Just looking how much the recalls patches had to be brought up in meetings and emails discussion before they could be reviewed enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 00:50:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 22:50:10 +0000 Subject: [Koha-bugs] [Bug 31806] Add 'page-section' to holds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 00:50:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 22:50:15 +0000 Subject: [Koha-bugs] [Bug 31806] Add 'page-section' to holds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142309|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 142468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142468&action=edit Bug 31806: Add page-section to holds tables This patch adds the page-section class to each holds view on reserve/request.pl Test plan 1) Find an biblio to test on and add holds items of different types and homebranches. 2) Work through each setting of the HoldsSplitQueue preference and confirm the page-sections appear as expected Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 00:50:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 22:50:21 +0000 Subject: [Koha-bugs] [Bug 31806] Add 'page-section' to holds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142310|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 142469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142469&action=edit Bug 31806: Add page-section container to existing holds This patch adds a page-section container around the existing holds content section Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 00:56:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 22:56:51 +0000 Subject: [Koha-bugs] [Bug 31806] Add 'page-section' to holds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 --- Comment #9 from David Nind --- Created attachment 142470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142470&action=edit Screenshots - options and display of holds page I've attached a PDF with screenshots of the options for HoldsSplitQueue. Thanks Martin for logging separate bugs for the table heading row and button placement - I've added a comment about how the light grey background continues after the buttons. Testing notes: - For item types to display: . I added an item to the record I tested this on (books) and made it a Music item type . Placed record level and item level holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 00:57:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 22:57:52 +0000 Subject: [Koha-bugs] [Bug 31902] Inconsistent table formatting for 'Existing holds' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #1 from David Nind --- See screenshots attached to bug 31806 to see what this looks like. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 00:59:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 22:59:56 +0000 Subject: [Koha-bugs] [Bug 31905] Buttons lack spacing on Holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind --- Also, ater the page section is fixed, the background for the row/line with the buttons is a light grey. See the screenshots attached to bug 31806. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 01:03:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 23:03:14 +0000 Subject: [Koha-bugs] [Bug 31931] New: Terminology for HoldsSplitQueue - staff client should be staff interface Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31931 Bug ID: 31931 Summary: Terminology for HoldsSplitQueue - staff client should be staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The description for the HoldsSplitQueue system preference uses "In the staff client,...." This should be "In the staff interface,...". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 01:07:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 23:07:01 +0000 Subject: [Koha-bugs] [Bug 31931] Terminology for HoldsSplitQueue - staff client should be staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31931 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |david at davidnind.com |ity.org | Patch complexity|--- |String patch See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31341, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31386 Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 01:07:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 23:07:01 +0000 Subject: [Koha-bugs] [Bug 31341] HoldsSplitQueue system preference is unrelated to the Holds Queue and should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31341 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31931 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 01:07:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 23:07:01 +0000 Subject: [Koha-bugs] [Bug 31386] OPACShowHoldQueueDetails system preference is unrelated to the Holds Queue and should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31386 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31931 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 01:24:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 23:24:42 +0000 Subject: [Koha-bugs] [Bug 31931] Terminology for HoldsSplitQueue - staff client should be staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31931 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 01:24:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 23:24:46 +0000 Subject: [Koha-bugs] [Bug 31931] Terminology for HoldsSplitQueue - staff client should be staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31931 --- Comment #1 from David Nind --- Created attachment 142471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142471&action=edit Bug 31931: Terminology for HoldsSplitQueue - use staff interface Rename "..staff client.." to "..staff interface.." in the description for the HoldsSplit Queue system preference, as per the terminology guidelines. Test plan. 1. View the description for the HoldsSplitQueue system preference. 2. Note that the description says "..staff client..". 3. Apply the patch. 4. Note that the description now says "..staff interface.." as per the terminology guidelines (https://wiki.koha-community.org/wiki/Terminology#S). 5. Sign off :D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 01:27:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 23:27:43 +0000 Subject: [Koha-bugs] [Bug 31931] Terminology for HoldsSplitQueue - staff client should be staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31931 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the description release notes| |for the HoldsSplitQueue | |system preference so that | |it says "In the staff | |interface, ..." instead of | |"In the staff client, ...", | |as per the terminology | |guidelines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 01:37:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 23:37:06 +0000 Subject: [Koha-bugs] [Bug 31917] Headings don't seem quite right for system preference search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 01:37:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 23:37:10 +0000 Subject: [Koha-bugs] [Bug 31917] Headings don't seem quite right for system preference search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142407|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142472&action=edit Bug 31917: Headings fix for preferences search This patch re-arranges the logic for displaying the search term when executing a system preference search. Test plan 1) Without the patch, search for something that will get no results 'boing' and note how it looks 2) Without the patch, search for something that gets some results 'block' and note how it looks 3) Apply the patch 4) Repeat your searches and comment on whether the look is better of worse ;P Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 01:38:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Oct 2022 23:38:12 +0000 Subject: [Koha-bugs] [Bug 31917] Headings don't seem quite right for system preference search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- +1 - looks better -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 02:00:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 00:00:57 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 02:01:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 00:01:46 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 02:05:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 00:05:55 +0000 Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Juliet Heltibridle changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #28 from Juliet Heltibridle --- (In reply to Owen Leonard from comment #27) > Created attachment 142195 [details] [review] > Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled > > This patch adds the new OPACBakerTaylorEnabled preferences to OPAC > templates and scripts which were missed in the first patch. The patch > also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql. > > Check these pages in the OPAC: > > - Catalog -> Search results > - And search results -> RSS > - Catalog -> Bibliographic details page -> Shelf browser > - Catalog -> Lists -> List contents > - Catalog -> Recent comments > - And recent comments -> RSS > - Your summary -> Checkouts and Overdues Works as expected on all the above pages except for search results -> RSS and recent comments ->RSS. This is my first time using a sandbox, so I'm not sure if I'm doing something wrong or not. It seems to me that the link for the RSS is not being directed back to the sandbox opac. Instead of https://staff-coverimages.sandbox.bywatersolutions.com/cgi-bin/koha/members/member.pl?quicksearch=1&circsearch=1&searchmember=shakespeare, it has http://coverimages.mydnsname.org:8080/cgi-bin/koha/opac-search.pl?idx=kw&q=shakespeare&format=rss. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 10:07:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 08:07:44 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #56 from Arthur Suzuki --- sorry koha-release updatebz script did update that one but it actually has been reverted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 10:07:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 08:07:47 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to basket summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #10 from Martin Renvoize --- This template needs an indentation cleanup.. rather confusing as it stands. More directly related.. I think perhaps each of the top columns should also be carded.. but that's not immediately trivial, as I just found.. so I'll open a new bug for that one.. Finally.. there's also a bug around the 'Managed by'.. the 'add user' is on the wrong side of the label. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 10:08:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 08:08:48 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to basket summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 --- Comment #11 from Martin Renvoize --- Working on a follow-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 10:28:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 08:28:01 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to basket summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142459|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 142473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142473&action=edit Bug 31837: Add page-section class to tables on basket.tt This patch adds the page-section class to the orders and cancelled orders tables. To test: 1. Have a vendor, basket, and create an order. 2. Go look at the table on basket.tt and make sure the orders table looks good. 3. Cancel some orders and look at the cancelled order table, make sure it also looks good. Note: I made some indentation changes. I also did NOT add a new wrapper to the cancelled orders table, it already had one so I just added the page-section div to the existing div. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 10:28:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 08:28:07 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to basket summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142460|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 142474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142474&action=edit Bug 31837: (follow-up) Move page-section to include h2 headings Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 10:28:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 08:28:57 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to basket summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Martin Renvoize --- OK.. I gave up.. this template is a real mess. So.. passing QA as is and I'll raise a new bug for going through the template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 10:32:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 08:32:24 +0000 Subject: [Koha-bugs] [Bug 31932] New: The basket summary page template needs a cleanup Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 Bug ID: 31932 Summary: The basket summary page template needs a cleanup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The indentation on basket.tt is really confusing and could do with a cleanup.. lots of nested conditions without consistent nesting end points. I'd also love to see the top two col sections marked up with page-section to 'card' them, and we could do with fixing where the 'add user' link appear on the 'Managed by' row. Lots of little things. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 10:32:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 08:32:38 +0000 Subject: [Koha-bugs] [Bug 31932] The basket summary page template needs a cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31837 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 [Bug 31837] Add page-section to basket summary page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 10:32:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 08:32:38 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to basket summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31932 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 [Bug 31932] The basket summary page template needs a cleanup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 11:18:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 09:18:07 +0000 Subject: [Koha-bugs] [Bug 31933] New: import patrons fails when patron attribute value contains a comma Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31933 Bug ID: 31933 Summary: import patrons fails when patron attribute value contains a comma Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: bernard.scaife at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Created attachment 142475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142475&action=edit patron upload file with the comma If patron attribute value contains a comma, the record is not imported Test: 1. create test.csv with unique cardnumber, mandatory fields surname, branchcode and categorycode and patron attributes 2. Patron attributes to contain a value which includes a comma each key/value pair surrounded by double-quotes "COURSE:Government, Economics and Commerce","CSCODE:ABC1234" 3. Ensure patron attribute types COURSE and CSCODE exist 4. Import with default values via patron import tool (cardnumber match) 5. If fails to import Import results : 0 imported records 0 overwritten 0 not imported because already in borrowers table and overwrite disabled 1 not imported because they are not in the expected format 1 records parsed Back to Tools Feedback: headerrow : cardnumber, surname, branchcode, categorycode, patron_attributes attribute string : COURSE:Government, Economics and Commerce Content-Type : text/csv Content-Disposition : form-data; name="uploadborrowers"; filename="patron_import_test.csv" Parsing upload file patron_import_test.csv Error analysis: Patron attribute Economics and Commerce is invalid for patron A12364162383. Repeat above but with file that doesn't have the comma: "COURSE:Government Economics and Commerce","CSCODE:ABC1234" Import succeeds comment: I was able to resolve as follows $string =~ s/,//g; on line 563 within sub generate_patron_attributes of /usr/share/koha/lib/Koha/Patrons/Import.pm # Fixup double quotes in case we are passed smart quotes $string =~ s/\xe2\x80\x9c/"/g; $string =~ s/\xe2\x80\x9d/"/g; +$string =~ s/,//g; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 11:23:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 09:23:46 +0000 Subject: [Koha-bugs] [Bug 30668] UpdateItemLocationOnCheckin spams the cataloguing log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30668 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 11:29:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 09:29:37 +0000 Subject: [Koha-bugs] [Bug 30407] Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 --- Comment #11 from Katrin Fischer --- *ping* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 11:32:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 09:32:09 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,22.11.00,22.05.06, |22.11.00,22.05.06,21.11.12 released in|21.11.12 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 11:50:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 09:50:58 +0000 Subject: [Koha-bugs] [Bug 5276] subscription end date shouldn't be required / allow indefinite subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5276 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|colin.campbell at ptfs-europe. |koha-bugs at lists.koha-commun |com |ity.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 11:55:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 09:55:17 +0000 Subject: [Koha-bugs] [Bug 31935] New: Serials subscription form is misaligned Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 Bug ID: 31935 Summary: Serials subscription form is misaligned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 The form for adding subscriptions is misaligned in the new design. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 11:55:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 09:55:17 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31935 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 [Bug 31935] Serials subscription form is misaligned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 11:57:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 09:57:31 +0000 Subject: [Koha-bugs] [Bug 31936] New: Link to advanced search form in acquisitions is missing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31936 Bug ID: 31936 Summary: Link to advanced search form in acquisitions is missing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 In acq there is an advanced search page that can be accessed by the link from the acq specific search tab. There is no link now. Ideas: * Add a static link to the search bar that is always visible * Add a link to the navigation on the left I'd prefer doing the first or both - having easy access to this form is something we had come up in training. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 11:57:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 09:57:31 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31936 [Bug 31936] Link to advanced search form in acquisitions is missing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 12:29:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 10:29:44 +0000 Subject: [Koha-bugs] [Bug 15248] Make it possible to configure duplicate check on bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15248 Marie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom at musikverket.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 12:30:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 10:30:11 +0000 Subject: [Koha-bugs] [Bug 28659] Allow Fast Cataloging to skip duplicate check In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28659 Marie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom at musikverket.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 12:31:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 10:31:24 +0000 Subject: [Koha-bugs] [Bug 31869] Unable to save thesaurus value to frameworks subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31869 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142244|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 142477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142477&action=edit Bug 31869: Unable to save thesaurus value to frameworks subfields This patch correct a typo authtypecodes for authtypecode To test: 1. Edit e.g. default frameworks subfield 100$a 2. Add or change fields thesaurus value 3. Save your changes => note that on subfield listing there is no mention that 100$a is linked to any thesaurus => if you edit 100$a thesaurus input is empty 4. Apply patch 5. Edit subfield 100$a and set a thesaurus value 6. Confirm it saves and displays correctly Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 12:31:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 10:31:35 +0000 Subject: [Koha-bugs] [Bug 31869] Unable to save thesaurus value to frameworks subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31869 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 12:32:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 10:32:28 +0000 Subject: [Koha-bugs] [Bug 31472] Extend FindDuplicate to use 001 + 003 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31472 Marie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom at musikverket.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 12:32:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 10:32:39 +0000 Subject: [Koha-bugs] [Bug 31937] New: cleanup_database locked a large number of patrons Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31937 Bug ID: 31937 Summary: cleanup_database locked a large number of patrons Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz The first run of cleanupdatabase after the upgrade to 21.11 did indeed cleanup a lot ;) It seems that this statement my $expired_patrons = Koha::Patrons->filter_by_expiration_date({ days => $lock_days })->search({ login_attempts => { '!=' => -1 } }); works different than before. It must have selected patrons that had an empty dateexpiry in 20.11 ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 12:36:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 10:36:42 +0000 Subject: [Koha-bugs] [Bug 31937] cleanup_database locked a large number of patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31937 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 12:53:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 10:53:27 +0000 Subject: [Koha-bugs] [Bug 31754] Improve appearance of behavior of DataTables controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142089|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 142478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142478&action=edit Bug 31754: Improve appearance of behavior of DataTables controls This patch makes changes to CSS and to the default DataTables DOM configuration in order to make toolbars work better at various screen widths. The patch also makes stylelint corrections to _tables.scss. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Test pages in the staff interface where tables contain multiple pages of results, e.g. a patron search. - Confirm that table information (entries) and controls look correct. - Confirm that all controls work correctly, including the search field. - Resize your browser to check how the controls respond at various browser widths. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 12:53:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 10:53:33 +0000 Subject: [Koha-bugs] [Bug 31754] Improve appearance of behavior of DataTables controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142154|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 142479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142479&action=edit Bug 31754: (follow-up) Correct alignment of buttons This patch corrects the alignment of the "Columns," "Export," and "Configure" buttons. The new design has them aligned to the right. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 12:53:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 10:53:59 +0000 Subject: [Koha-bugs] [Bug 31754] Improve appearance of behavior of DataTables controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #12 from Martin Renvoize --- It was caching at my end.. passing qa -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 12:54:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 10:54:15 +0000 Subject: [Koha-bugs] [Bug 31861] Table controls on checkouts table are buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:04:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:04:25 +0000 Subject: [Koha-bugs] [Bug 31861] Table controls on checkouts table are buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:05:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:05:30 +0000 Subject: [Koha-bugs] [Bug 31861] Table controls on checkouts table are buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 --- Comment #5 from Martin Renvoize --- OK.. there is a regression here.. The 'Clear filter' link becomes a button again after this patch.. and causes page jiggle.. this seems to undo something fixed in bug 31754 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:09:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:09:17 +0000 Subject: [Koha-bugs] [Bug 31938] New: Add vendor to subscription search result list Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31938 Bug ID: 31938 Summary: Add vendor to subscription search result list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:18:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:18:22 +0000 Subject: [Koha-bugs] [Bug 31939] New: The admin > libraries area needs page-sections Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31939 Bug ID: 31939 Summary: The admin > libraries area needs page-sections Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The libraries administration area needs page-section classes adding. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:18:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:18:49 +0000 Subject: [Koha-bugs] [Bug 31939] The admin > libraries area needs page-sections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31939 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31757 Depends on| |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:18:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:18:49 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31939 [Bug 31939] The admin > libraries area needs page-sections -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:18:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:18:49 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31939 [Bug 31939] The admin > libraries area needs page-sections -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:22:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:22:52 +0000 Subject: [Koha-bugs] [Bug 31939] The admin > libraries area needs page-sections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31939 --- Comment #1 from Martin Renvoize --- Created attachment 142480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142480&action=edit Bug 31939: Add page-section to branches template This patch adds the page-section class to the appropriate blocks in the Libraries administration area. Test plan 1) Confirm that Administration > Libraries correctly displays the table inside a page-section card 2) Confirm that Administration > Libraries > 'A library' correctly displays a card for the main information at the top and a separate card for OPAC Information if added. 3) Confirm that the 'Add' and 'Edit' library forms still look good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:23:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:23:19 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:23:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:23:25 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142123|0 |1 is obsolete| | Attachment #142124|0 |1 is obsolete| | Attachment #142125|0 |1 is obsolete| | Attachment #142126|0 |1 is obsolete| | --- Comment #22 from Nick Clemens --- Created attachment 142481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142481&action=edit Bug 23012: Database updates for PROCESSING_FOUND account credit type Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:23:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:23:30 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #23 from Nick Clemens --- Created attachment 142482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142482&action=edit Bug 23012: Show the PROCESSING_FOUND account credit type Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:23:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:23:35 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #24 from Nick Clemens --- Created attachment 142483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142483&action=edit Bug 23012: Set policy for lost item processing fee Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:23:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:23:40 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #25 from Nick Clemens --- Created attachment 142484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142484&action=edit Bug 23012: Apply processing fee return policy when lost item found This enhancement gives the ability to set a policy for the lost item processing fee that may get charged additional to the lost item replacement cost. The processing fee can be: - refunded - refunded if unpaid - kept To test: Set-up 1. Find an item, Item A. Go to Administration -> Item types and edit the item type for Item A. Add a default replacement cost and a processing fee and Save. 2. Go to Administration -> system preferences and set the following: - WhenLostChargeReplacementFee: Charge - BlockReturnOfLostItems: Don't block 3. Scroll down to the default lost item fee refund on return policy. Set the refund lost item replacement fee policy to 'refund lost item charge'. 4. Edit Item A and set a replacement cost. Reproduce 5. Check out Item A to Patron A. 6. Click the barcode to view Item A's information. Edit Item A and set the Lost status to 'lost'. 7. Go back to Patron A's checkouts. The item should now be checked in with two new charges applied - a lost item fee (the item's replacement cost) and a lost item processing fee (set in item types). 8. Check in Item A to mark it as found. 9. Go back to Patron A's account. Notice the lost item fee has been refunded, but the processing fee remains. 10. Manually pay or write off the processing fee. This enhancement removes the need for this manual step. 11. Apply the patch and restart services Test with lost item - refund 12. Go to Administration -> circulation and fines rules. Scroll down to the default lost item fee refund on return policy. Notice there is now a refund lost item processing fee policy. Set this to 'refund lost item processing charge'. 13. Repeat steps 6 to 9. 14. Go back to Patron A's account. Both the lost item fee and processing fee should have been refunded. 15. Repeat steps 6 to 8 (do not check it yet). 16. Go back to Patron A's account. Pay the processing fee. 17. Repeat step 9. 18. Go back to Patron A's account. Both the lost item fee and processing fee should have been refunded (you'll now be in a credit because the paid processing fee was also refunded). Test with lost item - refund_unpaid 19. Go to Administration -> circulation and fines rules. Scroll down to the default lost item fee refund on return policy. Notice there is now a refund lost item processing fee policy. Set this to 'refund lost item processing charge (only if unpaid)'. 20. Repeat steps 6 to 9. 21. Go back to Patron A's account. Both the lost item fee and processing fee should have been refunded. 22. Repeat steps 16 to 19. 23. Go back to Patron A's account. The lost item fee should have been refunded but not the processing fee, as this was already paid. Test with lost item - leave 24. Go to Administration -> circulation and fines rules. Scroll down to the default lost item fee refund on return policy. Notice there is now a refund lost item processing fee policy. Set this to 'leave lost item processing charge'. 25. Repeat steps 6 to 9. 26. Go back to Patron A's account. The lost item fee and processing fee should have been refunded but not the processing fee. Other tests 27. Confirm tests pass - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/CirculationRules.t Sponsored-by: Auckland University of Technology Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:23:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:23:47 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #26 from Nick Clemens --- Created attachment 142485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142485&action=edit Bug 23012: (QA follow-up) Combine method to get both values The code for get_processingreturn_policy was very similar to get_lostreturn_policy. Combining the two methods allows for use of get_effective_rules which uses get_effective_rule_value which is cached. This should reduce lines of code and improve performance Tests updated and adjusted as well Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:23:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:23:53 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #27 from Nick Clemens --- Created attachment 142486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142486&action=edit Bug 23012: (QA follow-up) No need to create and delete rules for branch The tests create a new branch to make sure one exists without rules. We then add a rule and delete it. We can simply create the new branch and never assign a rule Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:23:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:23:58 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #28 from Nick Clemens --- Created attachment 142487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142487&action=edit Bug 23012: (QA follow-up) Add exec flag to db update Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:31:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:31:45 +0000 Subject: [Koha-bugs] [Bug 17438] Warnings from Business::ISBN::Data in webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17438 shalini changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ism at kis.in --- Comment #12 from shalini --- Created attachment 142488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142488&action=edit Facing problem while upgrading from koha 18 to 21 I am trying to upgrade koha from 18 to 21. When I try to upgrade the schema it doesn't go past 19.06.00.005. It throws the following error: Update errors : ISBN_RANGE_MESSAGE is set to [] but that file does not exist! Trying to use the default locations at /usr/share/perl5/Business/ISBN.pm line 87. Can't use string ("- id: 165 selector: #coverflo"...) as an ARRAY ref while "strict refs" in use at /var/lib/koha/library/plugins/Koha/Plugin/Com/ByWaterSolutions/CoverFlow.pm line 377. Can someone help? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:31:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:31:49 +0000 Subject: [Koha-bugs] [Bug 31939] Add page-section to admin > libraries area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31939 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The admin > libraries area |Add page-section to admin > |needs page-sections |libraries area -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:31:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:31:57 +0000 Subject: [Koha-bugs] [Bug 31939] Add page-section to admin > libraries area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31939 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:32:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:32:02 +0000 Subject: [Koha-bugs] [Bug 31939] Add page-section to admin > libraries area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31939 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:32:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:32:44 +0000 Subject: [Koha-bugs] [Bug 31940] New: Add page-section to admin > library groups area Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31940 Bug ID: 31940 Summary: Add page-section to admin > library groups area Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, testopia at bugs.koha-community.org Depends on: 30952 Blocks: 31757 The library groups administration area needs page-section classes adding. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:32:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:32:44 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31940 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31940 [Bug 31940] Add page-section to admin > library groups area -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:32:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:32:44 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31940 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31940 [Bug 31940] Add page-section to admin > library groups area -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:34:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:34:30 +0000 Subject: [Koha-bugs] [Bug 31940] Add page-section to admin > library groups area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31940 --- Comment #1 from Martin Renvoize --- Created attachment 142489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142489&action=edit Bug 31940: Add page-section to library-groups This patch adds the page-section div around each library-groups table. Test plan 1) Check that the 'card' views appear appropriates on the library groups maangement page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:34:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:34:42 +0000 Subject: [Koha-bugs] [Bug 31940] Add page-section to admin > library groups area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31940 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:34:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:34:44 +0000 Subject: [Koha-bugs] [Bug 17438] Warnings from Business::ISBN::Data in webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17438 --- Comment #13 from Katrin Fischer --- (In reply to shalini from comment #12) > Created attachment 142488 [details] > Facing problem while upgrading from koha 18 to 21 > > I am trying to upgrade koha from 18 to 21. When I try to upgrade the schema > it doesn't go past 19.06.00.005. > It throws the following error: > Update errors : > > ISBN_RANGE_MESSAGE is set to [] but that file does not exist! > Trying to use the default locations > at /usr/share/perl5/Business/ISBN.pm line 87. > Can't use string ("- id: 165 > selector: #coverflo"...) as an ARRAY ref while "strict refs" in use at > /var/lib/koha/library/plugins/Koha/Plugin/Com/ByWaterSolutions/CoverFlow.pm > line 377. > > Can someone help? Please try the mailing list or IRC and also include the full version numbers. There are 18.05, 18.11 and 21.05 and 21.11 - each with various bugfix releases too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:35:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:35:05 +0000 Subject: [Koha-bugs] [Bug 31940] Add page-section to admin > library groups area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31940 --- Comment #2 from Martin Renvoize --- I don't really like how the tables display all different widths.. but that's a bug for another day I reckon. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:38:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:38:46 +0000 Subject: [Koha-bugs] [Bug 31941] New: Add page-section to admin > item types area Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31941 Bug ID: 31941 Summary: Add page-section to admin > item types area Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, koha-bugs at lists.koha-community.org, testopia at bugs.koha-community.org Depends on: 31940 Blocks: 31757 The item types administration area needs page-section classes adding. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31940 [Bug 31940] Add page-section to admin > library groups area -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:38:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:38:46 +0000 Subject: [Koha-bugs] [Bug 31940] Add page-section to admin > library groups area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31940 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31941 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31941 [Bug 31941] Add page-section to admin > item types area -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:38:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:38:46 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31941 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31941 [Bug 31941] Add page-section to admin > item types area -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:38:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:38:53 +0000 Subject: [Koha-bugs] [Bug 31941] Add page-section to admin > item types area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31941 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:40:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:40:29 +0000 Subject: [Koha-bugs] [Bug 31941] Add page-section to admin > item types area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31941 --- Comment #1 from Martin Renvoize --- Created attachment 142490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142490&action=edit Bug 31941: Add page-section container to item types This patch adds the page-section container to the item types adminstration page Test plan 1) Confirm the item types administration page uses the card view around the main table -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:40:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:40:42 +0000 Subject: [Koha-bugs] [Bug 31941] Add page-section to admin > item types area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31941 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:49:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:49:58 +0000 Subject: [Koha-bugs] [Bug 31942] New: Add page-section to admin > authorized values area Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31942 Bug ID: 31942 Summary: Add page-section to admin > authorized values area Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, koha-bugs at lists.koha-community.org, testopia at bugs.koha-community.org Depends on: 30952 Blocks: 31757 The authorized values administration area needs page-section classes adding. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:49:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:49:58 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31942 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31942 [Bug 31942] Add page-section to admin > authorized values area -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:49:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:49:58 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31942 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31942 [Bug 31942] Add page-section to admin > authorized values area -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:51:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:51:34 +0000 Subject: [Koha-bugs] [Bug 31942] Add page-section to admin > authorized values area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31942 --- Comment #1 from Martin Renvoize --- Created attachment 142491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142491&action=edit Bug 31952: Add page-section to authorized values admin This patch adds the page-section container to the authorized_values administration area. Test plan 1) Confirm that the AV admin area looks reasonable for all area's of display -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:51:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:51:47 +0000 Subject: [Koha-bugs] [Bug 31942] Add page-section to admin > authorized values area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31942 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:52:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:52:06 +0000 Subject: [Koha-bugs] [Bug 31941] Add page-section to admin > item types area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31941 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|31940 |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31940 [Bug 31940] Add page-section to admin > library groups area -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:52:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:52:06 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31941 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31941 [Bug 31941] Add page-section to admin > item types area -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 13:52:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 11:52:06 +0000 Subject: [Koha-bugs] [Bug 31940] Add page-section to admin > library groups area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31940 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31941 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31941 [Bug 31941] Add page-section to admin > item types area -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:05:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:05:22 +0000 Subject: [Koha-bugs] [Bug 31943] New: date inputs wider than other inputs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31943 Bug ID: 31943 Summary: date inputs wider than other inputs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 https://snipboard.io/03cGy7.jpg Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:05:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:05:22 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31943 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31943 [Bug 31943] date inputs wider than other inputs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:06:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:06:15 +0000 Subject: [Koha-bugs] [Bug 31944] New: Toolbar is not correctly aligned Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31944 Bug ID: 31944 Summary: Toolbar is not correctly aligned Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 https://snipboard.io/AG96la.jpg .btn-toolbar has a margin-left: -5px coming from bootstrap css Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:06:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:06:15 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31944 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31944 [Bug 31944] Toolbar is not correctly aligned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:07:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:07:33 +0000 Subject: [Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629 --- Comment #4 from Frédéric Demians --- Created attachment 142492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142492&action=edit Bug 31154: Avoid unecessary loop We don't need to loop over the subfield and enter this block if there is no record. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:08:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:08:42 +0000 Subject: [Koha-bugs] [Bug 31943] date inputs wider than other inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31943 --- Comment #1 from Jonathan Druart --- Maybe Replace .flatpickr-input { padding: 3px 3px 3px 20px; } With padding: 3px -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:09:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:09:45 +0000 Subject: [Koha-bugs] [Bug 31945] New: Add page-section to admin > patron categories area Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31945 Bug ID: 31945 Summary: Add page-section to admin > patron categories area Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, koha-bugs at lists.koha-community.org, testopia at bugs.koha-community.org Depends on: 30952 Blocks: 31757 The patron categories administration area needs page-section classes adding. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:09:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:09:45 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31945 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31945 [Bug 31945] Add page-section to admin > patron categories area -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:09:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:09:45 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31945 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31945 [Bug 31945] Add page-section to admin > patron categories area -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:09:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:09:54 +0000 Subject: [Koha-bugs] [Bug 31945] Add page-section to admin > patron categories area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31945 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:11:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:11:07 +0000 Subject: [Koha-bugs] [Bug 31945] Add page-section to admin > patron categories area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31945 --- Comment #1 from Martin Renvoize --- Created attachment 142493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142493&action=edit Bug 31945: Add page-section container to patron categories page This patch adds the page-section container to the patron categories administration page -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:11:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:11:18 +0000 Subject: [Koha-bugs] [Bug 31945] Add page-section to admin > patron categories area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31945 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:12:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:12:27 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #149 from Tomás Cohen Arazi --- Created attachment 142494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142494&action=edit Bug 17170: (QA follow-up) Adjust t/Koha/Auth/Permissions.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:13:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:13:27 +0000 Subject: [Koha-bugs] [Bug 31861] Table controls on checkouts table are buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:13:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:13:32 +0000 Subject: [Koha-bugs] [Bug 31861] Table controls on checkouts table are buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 --- Comment #6 from Owen Leonard --- Created attachment 142495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142495&action=edit Bug 31861: (follow-up) Fix disabled clear search button The disabled clear search button should not have a border and background set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:23:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:23:43 +0000 Subject: [Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 --- Comment #30 from Jonathan Druart --- + value => { flags => 25**2 } # cash_management flag = 25 It must be 2**25 instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:24:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:24:39 +0000 Subject: [Koha-bugs] [Bug 22343] Add configuration options for SMTP servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #237 from Jonathan Druart --- + value => { flags => 3**2 } # parameters flag = 3 It must be 2**3 instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:25:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:25:09 +0000 Subject: [Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr Attachment #142492|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:25:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:25:48 +0000 Subject: [Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629 --- Comment #5 from Frédéric Demians --- Above, it was a false attachement, made by mistake. Sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:25:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:25:59 +0000 Subject: [Koha-bugs] [Bug 31946] New: Wrong permission bit in tests Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31946 Bug ID: 31946 Summary: Wrong permission bit in tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 22343, 26274 t/db_dependent/api/v1/cashups.t: value => { flags => 25**2 } # cash_management flag = 25 t/db_dependent/api/v1/cashups.t: value => { flags => 25**2 } # cash_management flag = 25 t/db_dependent/api/v1/smtp_servers.t: value => { flags => 3**2 } # parameters flag = 3 t/db_dependent/api/v1/smtp_servers.t: value => { flags => 3**2 } # parameters flag = 3 t/db_dependent/api/v1/smtp_servers.t: value => { flags => 3**2 } # parameters flag = 3 t/db_dependent/api/v1/smtp_servers.t: value => { flags => 3**2 } # parameters flag = 3 t/db_dependent/api/v1/smtp_servers.t: value => { flags => 3**2 } # parameters flag = 3 Must be 2**25 and 2**3 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 [Bug 22343] Add configuration options for SMTP servers https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 [Bug 26274] Expose cash register cashup summaries via an API route. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:25:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:25:59 +0000 Subject: [Koha-bugs] [Bug 22343] Add configuration options for SMTP servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31946 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31946 [Bug 31946] Wrong permission bit in tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:25:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:25:59 +0000 Subject: [Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31946 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31946 [Bug 31946] Wrong permission bit in tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:26:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:26:15 +0000 Subject: [Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #6 from Frédéric Demians --- The default value for deletion is set to 30 in DEFAULT_ELASTICQ_PURGEDAYS. Not 1. Is it intended? What do you think about another option for purging all other finished jobs? Something like --jobqueue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:28:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:28:09 +0000 Subject: [Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Nick Clemens --- (In reply to Frédéric Demians from comment #6) > The default value for deletion is set to 30 in DEFAULT_ELASTICQ_PURGEDAYS. > Not 1. Is it intended? Matching the default for zebraqueue > What do you think about another option for purging all other finished jobs? > Something like --jobqueue. I think it is a great idea, please file a follow-up bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:28:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:28:35 +0000 Subject: [Koha-bugs] [Bug 31927] Use bigger font-size for bibliographic information on staff details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31927 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:28:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:28:40 +0000 Subject: [Koha-bugs] [Bug 31927] Use bigger font-size for bibliographic information on staff details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31927 --- Comment #2 from Owen Leonard --- Created attachment 142496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142496&action=edit Bug 31927: Use bigger font-size for bibliographic information on staff details page This patch removes the adusted font size from the definition of the .results_summary spans. The percentage decrease was being multiplied with another rule. To test, apply the patch and rebuild the staff interface CSS. Locate a bibliographic record in the staff client and view the detail page. Confirm that the bibliographic information is displayed in a comfortable size. Also test that catalog search results still look correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:30:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:30:47 +0000 Subject: [Koha-bugs] [Bug 31861] Table controls on checkouts table are buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142495|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 142497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142497&action=edit Bug 31861: (follow-up) Fix disabled clear search button The disabled clear search button should not have a border and background set. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:31:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:31:15 +0000 Subject: [Koha-bugs] [Bug 31861] Table controls on checkouts table are buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- Thanks for quick follow-up.. PQA now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:31:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:31:42 +0000 Subject: [Koha-bugs] [Bug 31861] Table controls on checkouts table are buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30952 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:31:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:31:42 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31861 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 [Bug 31861] Table controls on checkouts table are buttons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:32:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:32:29 +0000 Subject: [Koha-bugs] [Bug 31812] Add yellow to stage imports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30952 Blocks|30952 | CC| |martin.renvoize at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:32:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:32:29 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31812 Depends on|31812 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 [Bug 31812] Add yellow to stage imports page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 14:45:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 12:45:58 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #150 from Nick Clemens --- Created attachment 142498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142498&action=edit Bug 17170: (follow-up) Hide existing filters section if no filters exist -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:15:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:15:51 +0000 Subject: [Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629 Björn Nylén changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjorn.nylen at ub.lu.se --- Comment #8 from Björn Nylén --- I made a more generalized addition to cleanup_database.pl before I saw this. (moved to 22.05 last week so wanted this quickly). Can add it as a suggestion if people are interested? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:16:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:16:22 +0000 Subject: [Koha-bugs] [Bug 30668] UpdateItemLocationOnCheckin spams the cataloguing log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30668 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The release notes| |UpdateNOtForLoanStatusOnChe | |ckin can be user for the | |cart feature, or other | |changes no every checkin. | |Before this patch these | |updates were recorded in | |the cataloguing log, which | |is intended to capture | |changes made by catalogers. | | | |This patchset avoids logs | |for these updates, relying | |on the returns | |log/statistics to capture | |the action and change of | |location. | | | |Before these | |patches the action logs | |grew very quickly as every | |checkin could initiate a | |full log of the item data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:16:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:16:27 +0000 Subject: [Koha-bugs] [Bug 31937] cleanup_database locked a large number of patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31937 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Severity|critical |normal Status|NEW |ASSIGNED --- Comment #1 from Marcel de Rooy --- Nothing better than being hit by your own development :) We need to refine the condition of search_unsubscribed in cleanup_database. I added a lot of refusals for another consent type (still customization), but they were picked up nicely by cleanup_database :) So no more casualties expected after all.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:17:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:17:23 +0000 Subject: [Koha-bugs] [Bug 31939] Add page-section to admin > libraries area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31939 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:17:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:17:30 +0000 Subject: [Koha-bugs] [Bug 31939] Add page-section to admin > libraries area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31939 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142480|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142499&action=edit Bug 31939: Add page-section to branches template This patch adds the page-section class to the appropriate blocks in the Libraries administration area. Test plan 1) Confirm that Administration > Libraries correctly displays the table inside a page-section card 2) Confirm that Administration > Libraries > 'A library' correctly displays a card for the main information at the top and a separate card for OPAC Information if added. 3) Confirm that the 'Add' and 'Edit' library forms still look good. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:17:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:17:40 +0000 Subject: [Koha-bugs] [Bug 31768] Tags is a 'Tool' but doesn't include the tools nav sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31768 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Depends on|30952 | --- Comment #1 from Owen Leonard --- I'm removing the dependency on 30952 since the issue predates the redesign. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:17:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:17:40 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31768 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31768 [Bug 31768] Tags is a 'Tool' but doesn't include the tools nav sidebar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:27:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:27:10 +0000 Subject: [Koha-bugs] [Bug 31942] Add page-section to admin > authorized values area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31942 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:27:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:27:15 +0000 Subject: [Koha-bugs] [Bug 31942] Add page-section to admin > authorized values area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31942 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142491|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142500&action=edit Bug 31952: Add page-section to authorized values admin This patch adds the page-section container to the authorized_values administration area. Test plan 1) Confirm that the AV admin area looks reasonable for all area's of display https://bugs.koha-community.org/show_bug.cgi?id=31942 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:29:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:29:24 +0000 Subject: [Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141850|0 |1 is obsolete| | --- Comment #9 from Frédéric Demians --- Created attachment 142501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142501&action=edit Bug 31629: Add elasticqueue options to cleanup_database This patch adds an elasticqueue option to cleanup_database.pl to allow for purging completed reindexing jobs To test: 1 - Enable elastic search in Koha 2 - perl misc/maintenance/touch_all_items.pl 3 - Check db and note there are a bunch of elastic reindex jobs 4 - Update to make them old UPDATE background_jobs SET ended_on = '2022-10-01 00:00:00' WHERE type = 'update_elastic_index' 5 - perl misc/cronjobs/cleanup_database.pl 6 - Note elasticqueue entry shows in help 7 - perl misc/cronjobs/cleanup_database.pl --elasticqueue 1 -v 8 - Note that elasticqueue would have been cleared 9 - perl misc/cronjobs/cleanup_database.pl --elasticqueue 1 -v --confirm 10 - Note that number of entries deleted is reported 11 - Confirm in staff interface that jobs are gone: http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl (Uncheck 'Current jobs only') Signed-off-by: David Nind Signed-off-by: Frédéric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:29:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:29:32 +0000 Subject: [Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629 --- Comment #10 from Frédéric Demians --- Created attachment 142502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142502&action=edit Bug 31629: Add jobsqueue options to cleanup_database This patch adds an jobsqueue option to cleanup_database.pl to allow for purging background jobs queue There is also a fix for --elasticqueue default value To test: 1. On a DB with a populated background_jobs table, identify in this table entries older than X days. 2. perl misc/cronjobs/cleanup_database.pl Note elasticqueue entry shows in help 3. perl misc/cronjobs/cleanup_database.pl --elasticqueue -v Note this message: Elastic queue (background jobs) purge triggered for 30 days 4. perl misc/cronjobs/cleanup_database.pl --jobsqueue -v Note this message: Background jobs queue purge triggered for 30 days. 5. perl misc/cronjobs/cleanup_database.pl --jobsqueue 1 -v Background jobs queue purge triggered for 1 day. 6. perl misc/cronjobs/cleanup_database.pl --jobsqueue 1 -v --confirm Note that number of entries deleted is reporte 7. In Koha > Admin > Background jobs, see the purge queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:30:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:30:14 +0000 Subject: [Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:30:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:30:28 +0000 Subject: [Koha-bugs] [Bug 31947] New: Add 'btn-primary' to the main action button where it's missing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 Bug ID: 31947 Summary: Add 'btn-primary' to the main action button where it's missing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com With the staff client refresh, the btn-primary was given a much clearer set of yellow styling.. we should try to add said markup wherever it's missing. This bug servers as a collector. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:30:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:30:45 +0000 Subject: [Koha-bugs] [Bug 31810] Place hold button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Blocks| |31947 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 [Bug 31947] Add 'btn-primary' to the main action button where it's missing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:30:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:30:45 +0000 Subject: [Koha-bugs] [Bug 31947] Add 'btn-primary' to the main action button where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31810 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 [Bug 31810] Place hold button should be yellow -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:31:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:31:58 +0000 Subject: [Koha-bugs] [Bug 31812] Add yellow to stage imports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31947 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 [Bug 31947] Add 'btn-primary' to the main action button where it's missing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:31:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:31:58 +0000 Subject: [Koha-bugs] [Bug 31947] Add 'btn-primary' to the main action button where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31812 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 [Bug 31812] Add yellow to stage imports page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:32:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:32:02 +0000 Subject: [Koha-bugs] [Bug 31884] In check in page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31884 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Blocks| |31947 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 [Bug 31947] Add 'btn-primary' to the main action button where it's missing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:32:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:32:02 +0000 Subject: [Koha-bugs] [Bug 31947] Add 'btn-primary' to the main action button where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31884 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31884 [Bug 31884] In check in page submit button should be yellow -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:32:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:32:08 +0000 Subject: [Koha-bugs] [Bug 31885] In renew page submit button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31885 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Blocks| |31947 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 [Bug 31947] Add 'btn-primary' to the main action button where it's missing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:32:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:32:08 +0000 Subject: [Koha-bugs] [Bug 31947] Add 'btn-primary' to the main action button where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31885 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31885 [Bug 31885] In renew page submit button should be yellow -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:32:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:32:14 +0000 Subject: [Koha-bugs] [Bug 31888] In Elasticsearch mappings page save button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31888 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31947 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 [Bug 31947] Add 'btn-primary' to the main action button where it's missing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:32:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:32:14 +0000 Subject: [Koha-bugs] [Bug 31947] Add 'btn-primary' to the main action button where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31888 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31888 [Bug 31888] In Elasticsearch mappings page save button should be yellow -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:32:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:32:31 +0000 Subject: [Koha-bugs] [Bug 31936] Link to advanced search form in acquisitions is missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31936 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:33:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:33:21 +0000 Subject: [Koha-bugs] [Bug 31941] Add page-section to admin > item types area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31941 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:33:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:33:26 +0000 Subject: [Koha-bugs] [Bug 31941] Add page-section to admin > item types area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31941 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142490|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142503&action=edit Bug 31941: Add page-section container to item types This patch adds the page-section container to the item types adminstration page Test plan 1) Confirm the item types administration page uses the card view around the main table Signed-off-by: David Nind -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:38:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:38:54 +0000 Subject: [Koha-bugs] [Bug 31911] Headings are inconsistent in rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142398|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 142504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142504&action=edit Bug 31911: Improve rotating collections item management This patch renames 'Add/remove items from collection' to just 'Manage items' in the button in the rotating collections list table, the page heading and the breadcrumbs. We also move the heading below the toolbar to be consistent with elsewhere, remove a superflous second level heading and wrap the content table in a page-section too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:38:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:38:58 +0000 Subject: [Koha-bugs] [Bug 31911] Headings are inconsistent in rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 --- Comment #4 from Martin Renvoize --- Created attachment 142505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142505&action=edit Bug 31911: (follow-up) Rename second level heading This patch, as suggested, renames the second level heading to 'Items in collection' and move the 'Total items: {count}' into a paragraph. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:39:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:39:19 +0000 Subject: [Koha-bugs] [Bug 31911] Headings are inconsistent in rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:40:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:40:21 +0000 Subject: [Koha-bugs] [Bug 31936] Link to advanced search form in acquisitions is missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31936 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:40:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:40:26 +0000 Subject: [Koha-bugs] [Bug 31936] Link to advanced search form in acquisitions is missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31936 --- Comment #1 from Owen Leonard --- Created attachment 142506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142506&action=edit Bug 31936: Restore link to advanced search in acquisitions header This patch adds back the link to the advanced order search page which was previously in the acquisitions header search. Some CSS is tweaked to make the form style comfortable. To test, apply the patch and rebuild the staff interface CSS. - Go to Acquisitions. - In the header search form, click "Orders search" - Click the icon in the search form to expand the additional options. - You should see an "Advanced search" link which is the same style as other standard links. - The link should take you to the order search form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:43:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:43:41 +0000 Subject: [Koha-bugs] [Bug 31940] Add page-section to admin > library groups area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31940 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:47:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:47:30 +0000 Subject: [Koha-bugs] [Bug 31760] Low constrast of some colors (WCAG) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31760 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:51:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:51:55 +0000 Subject: [Koha-bugs] [Bug 31936] Link to advanced search form in acquisitions is missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31936 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:52:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:52:01 +0000 Subject: [Koha-bugs] [Bug 31936] Link to advanced search form in acquisitions is missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31936 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142506|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142507&action=edit Bug 31936: Restore link to advanced search in acquisitions header This patch adds back the link to the advanced order search page which was previously in the acquisitions header search. Some CSS is tweaked to make the form style comfortable. To test, apply the patch and rebuild the staff interface CSS. - Go to Acquisitions. - In the header search form, click "Orders search" - Click the icon in the search form to expand the additional options. - You should see an "Advanced search" link which is the same style as other standard links. - The link should take you to the order search form. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:55:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:55:04 +0000 Subject: [Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:55:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:55:08 +0000 Subject: [Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142501|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 142508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142508&action=edit Bug 31629: Add elasticqueue options to cleanup_database This patch adds an elasticqueue option to cleanup_database.pl to allow for purging completed reindexing jobs To test: 1 - Enable elastic search in Koha 2 - perl misc/maintenance/touch_all_items.pl 3 - Check db and note there are a bunch of elastic reindex jobs 4 - Update to make them old UPDATE background_jobs SET ended_on = '2022-10-01 00:00:00' WHERE type = 'update_elastic_index' 5 - perl misc/cronjobs/cleanup_database.pl 6 - Note elasticqueue entry shows in help 7 - perl misc/cronjobs/cleanup_database.pl --elasticqueue 1 -v 8 - Note that elasticqueue would have been cleared 9 - perl misc/cronjobs/cleanup_database.pl --elasticqueue 1 -v --confirm 10 - Note that number of entries deleted is reported 11 - Confirm in staff interface that jobs are gone: http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl (Uncheck 'Current jobs only') Signed-off-by: David Nind Signed-off-by: Frédéric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:55:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:55:13 +0000 Subject: [Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142502|0 |1 is obsolete| | --- Comment #12 from Nick Clemens --- Created attachment 142509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142509&action=edit Bug 31629: Add jobsqueue options to cleanup_database This patch adds an jobsqueue option to cleanup_database.pl to allow for purging background jobs queue There is also a fix for --elasticqueue default value To test: 1. On a DB with a populated background_jobs table, identify in this table entries older than X days. 2. perl misc/cronjobs/cleanup_database.pl Note elasticqueue entry shows in help 3. perl misc/cronjobs/cleanup_database.pl --elasticqueue -v Note this message: Elastic queue (background jobs) purge triggered for 30 days 4. perl misc/cronjobs/cleanup_database.pl --jobsqueue -v Note this message: Background jobs queue purge triggered for 30 days. 5. perl misc/cronjobs/cleanup_database.pl --jobsqueue 1 -v Background jobs queue purge triggered for 1 day. 6. perl misc/cronjobs/cleanup_database.pl --jobsqueue 1 -v --confirm Note that number of entries deleted is reporte 7. In Koha > Admin > Background jobs, see the purge queue. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:55:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:55:18 +0000 Subject: [Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629 --- Comment #13 from Nick Clemens --- Created attachment 142510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142510&action=edit Bug 31629: (follow-up) Fix spelling of background Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:55:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:55:32 +0000 Subject: [Koha-bugs] [Bug 31809] Should actions on result list stick to the bottom? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31809 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- I think they should, yes.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:58:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:58:14 +0000 Subject: [Koha-bugs] [Bug 31765] Add 'page-section' to import patrons page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31765 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:58:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:58:16 +0000 Subject: [Koha-bugs] [Bug 31765] Add 'page-section' to import patrons page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31765 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:58:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:58:20 +0000 Subject: [Koha-bugs] [Bug 31821] Add page-section to vendor result list (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31821 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:58:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:58:22 +0000 Subject: [Koha-bugs] [Bug 31945] Add page-section to admin > patron categories area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31945 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:58:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:58:25 +0000 Subject: [Koha-bugs] [Bug 31821] Add page-section to vendor result list (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31821 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:58:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:58:28 +0000 Subject: [Koha-bugs] [Bug 31822] Add page-section to vendor detail page (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31822 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:58:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:58:30 +0000 Subject: [Koha-bugs] [Bug 31945] Add page-section to admin > patron categories area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31945 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142493|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142511&action=edit Bug 31945: Add page-section container to patron categories page This patch adds the page-section container to the patron categories administration page Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:58:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:58:32 +0000 Subject: [Koha-bugs] [Bug 31822] Add page-section to vendor detail page (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31822 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:58:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:58:34 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to basket summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:58:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:58:37 +0000 Subject: [Koha-bugs] [Bug 31837] Add page-section to basket summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 --- Comment #15 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:58:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:58:40 +0000 Subject: [Koha-bugs] [Bug 31863] Advanced cataloging editor no longer auto-resizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:58:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:58:43 +0000 Subject: [Koha-bugs] [Bug 31863] Advanced cataloging editor no longer auto-resizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:58:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:58:46 +0000 Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 15:58:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 13:58:49 +0000 Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:04:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:04:26 +0000 Subject: [Koha-bugs] [Bug 31812] Add yellow to stage imports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 --- Comment #4 from Martin Renvoize --- Created attachment 142512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142512&action=edit Bug 31812: Update 'Stage for import' button to be primary This patch updates the 'Stage for import' input to be of type="submit" and classes is a "button".. This gives it the yellow main action hinting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:04:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:04:48 +0000 Subject: [Koha-bugs] [Bug 31831] Make inactive search options font slightly bigger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31831 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:04:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:04:52 +0000 Subject: [Koha-bugs] [Bug 31831] Make inactive search options font slightly bigger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31831 --- Comment #1 from Owen Leonard --- Created attachment 142513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142513&action=edit Bug 31831: Make inactive search options font slightly bigger This patch removes the reduced font size from the "tab" links in the header search form (the links for switching between search forms). This makes the links the same size as the search form label. To test, apply the patch and rebuild the staff client CSS. On any page in the staff interface, test the appearance and behavior of the header search form. The controls should be clear and readable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:05:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:05:09 +0000 Subject: [Koha-bugs] [Bug 31812] Add yellow to stage imports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:05:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:05:15 +0000 Subject: [Koha-bugs] [Bug 31812] Add yellow to stage imports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:09:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:09:26 +0000 Subject: [Koha-bugs] [Bug 31654] Hide non-public libraries from MastheadLibraryPulldown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141335|0 |1 is obsolete| | --- Comment #11 from sandboxes at biblibre.com --- Created attachment 142514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142514&action=edit Bug 31654: Hide non-public libraries from MastheadLibraryPulldown (bug_31654_hide_nonpublic_libs) Do not list library in masthead and advanced search if branches.public is false Test Plan: * Set OpacAddMastheadLibraryPulldown to "Add" * Go to Administration -> Libraries, edit "Fairfield", set "public" = "no" (at the end of the form) * Or connect to DB and run update branches set public = 0 where branchcode like 'F%'; This will set all three libraries starting with F to non-public * open OPAC * The "All libraries" Pulldown in the Header (between search slot and search button) still shows the non-public libraries * Go to OPAC -> Advanced Search, scroll to "Location and availability": The selectbox still shows the non-public libraries Now apply the patch * Open OPAC * The "All libraries" Pulldown in the Header now should not contain the libraries set to "public = no" * And in the Advanced Search "Location and availability" pulldown those libraries should also not be shown. Sponsored-by: Steiermärkische Landesbibliothek Signed-off-by: Claude -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:11:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:11:30 +0000 Subject: [Koha-bugs] [Bug 31676] Make db_dependent/Circulation.t tests more robust In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:11:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:11:33 +0000 Subject: [Koha-bugs] [Bug 31676] Make db_dependent/Circulation.t tests more robust In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 --- Comment #17 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:11:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:11:36 +0000 Subject: [Koha-bugs] [Bug 31754] Improve appearance of behavior of DataTables controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:11:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:11:39 +0000 Subject: [Koha-bugs] [Bug 31754] Improve appearance of behavior of DataTables controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 --- Comment #13 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:11:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:11:42 +0000 Subject: [Koha-bugs] [Bug 31920] Unit test t/db_dependent/Holds.t leaves behind database cruft In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31920 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:11:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:11:45 +0000 Subject: [Koha-bugs] [Bug 31920] Unit test t/db_dependent/Holds.t leaves behind database cruft In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31920 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:18:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:18:30 +0000 Subject: [Koha-bugs] [Bug 31654] Hide non-public libraries from MastheadLibraryPulldown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 Claude Demeure changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claude.demeure at mailo.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:27:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:27:55 +0000 Subject: [Koha-bugs] [Bug 31834] Inconsistent table formatting for list of MARC imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:27:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:27:59 +0000 Subject: [Koha-bugs] [Bug 31834] Inconsistent table formatting for list of MARC imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 --- Comment #1 from Owen Leonard --- Created attachment 142515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142515&action=edit Bug 31834: Replace incorrect "table" class from MARC imports table The table containing staged MARC record batches has a "table" class added to the tag, which is inconsistent with other tables in the staff interface. The class pulls in default table styles from Bootstrap which aren't consistent. There are a few other non-DataTable tables have the the class "dataTable" added in order to make them more consistent. I think this table should have that class too. The template is also modified to give the table a and , with indentation corrected accordingly. To test, apply the patch and go to Cataloging -> Manage staged records. The table of staged records should look correct, with style matching DataTables elsewhere in Koha, e.g. Administration -> Libraries. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:28:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:28:08 +0000 Subject: [Koha-bugs] [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|31162 |31417 CC| |martin.renvoize at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 [Bug 31162] Add a clear cataloguing module home page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 [Bug 31417] Re-instate the cataloguing sidebar menu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:28:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:28:08 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31864 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:28:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:28:08 +0000 Subject: [Koha-bugs] [Bug 31417] Re-instate the cataloguing sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31864 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:30:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:30:38 +0000 Subject: [Koha-bugs] [Bug 31882] Fix page title of pages in the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31882 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Depends on|31162 |31864 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 [Bug 31162] Add a clear cataloguing module home page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:30:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:30:38 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31882 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31882 [Bug 31882] Fix page title of pages in the new cataloging module home page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:30:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:30:38 +0000 Subject: [Koha-bugs] [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31882 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31882 [Bug 31882] Fix page title of pages in the new cataloging module home page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:31:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:31:26 +0000 Subject: [Koha-bugs] [Bug 31556] Correct breadcrumb for Cataloging module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 31864 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:31:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:31:26 +0000 Subject: [Koha-bugs] [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 --- Comment #10 from Martin Renvoize --- *** Bug 31556 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:31:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:31:28 +0000 Subject: [Koha-bugs] [Bug 31845] Move cataloging controllers and templates to fix URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31845 Bug 31845 depends on bug 31556, which changed state. Bug 31556 Summary: Correct breadcrumb for Cataloging module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:33:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:33:04 +0000 Subject: [Koha-bugs] [Bug 31845] Move cataloging controllers and templates to fix URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31845 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|31556 |31882 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 [Bug 31556] Correct breadcrumb for Cataloging module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31882 [Bug 31882] Fix page title of pages in the new cataloging module home page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:33:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:33:04 +0000 Subject: [Koha-bugs] [Bug 31556] Correct breadcrumb for Cataloging module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31845 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31845 [Bug 31845] Move cataloging controllers and templates to fix URLs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:33:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:33:04 +0000 Subject: [Koha-bugs] [Bug 31882] Fix page title of pages in the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31882 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31845 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31845 [Bug 31845] Move cataloging controllers and templates to fix URLs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:44:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:44:01 +0000 Subject: [Koha-bugs] [Bug 31882] Fix page title of pages in the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31882 --- Comment #1 from Martin Renvoize --- Created attachment 142516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142516&action=edit Bug 31864: Correct titles for pages in new cataloging module To test: 1. Apply patch 2. Set system preference 'StockRotation' to enable. 3. Be logged in as a superlibrarian 4. Check the page titles for all pages, accessible from the Cataloging module homepage -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:44:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:44:17 +0000 Subject: [Koha-bugs] [Bug 31882] Fix page title of pages in the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31882 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:45:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:45:32 +0000 Subject: [Koha-bugs] [Bug 18556] Message "Patron's address in doubt" is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:45:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:45:35 +0000 Subject: [Koha-bugs] [Bug 18556] Message "Patron's address in doubt" is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:45:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:45:37 +0000 Subject: [Koha-bugs] [Bug 31689] Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31689 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:45:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:45:41 +0000 Subject: [Koha-bugs] [Bug 31689] Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31689 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:45:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:45:44 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in MARC subfields structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:45:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:45:47 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in MARC subfields structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 --- Comment #14 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:45:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:45:51 +0000 Subject: [Koha-bugs] [Bug 31813] Specify white-space: normal for spans styled as labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:45:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:45:53 +0000 Subject: [Koha-bugs] [Bug 31813] Specify white-space: normal for spans styled as labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:45:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:45:56 +0000 Subject: [Koha-bugs] [Bug 31861] Table controls on checkouts table are buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:45:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:45:59 +0000 Subject: [Koha-bugs] [Bug 31861] Table controls on checkouts table are buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:46:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:46:02 +0000 Subject: [Koha-bugs] [Bug 31870] Cleaning up t/db_dependent/Context.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31870 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:46:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:46:05 +0000 Subject: [Koha-bugs] [Bug 31870] Cleaning up t/db_dependent/Context.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31870 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:46:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:46:08 +0000 Subject: [Koha-bugs] [Bug 31888] In Elasticsearch mappings page save button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31888 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:46:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:46:10 +0000 Subject: [Koha-bugs] [Bug 31888] In Elasticsearch mappings page save button should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31888 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:47:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:47:33 +0000 Subject: [Koha-bugs] [Bug 31690] Add see from tracings in See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31690 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #6 from Tomás Cohen Arazi --- Please rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:49:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:49:48 +0000 Subject: [Koha-bugs] [Bug 31948] New: Add timestamp to tmp_holdsqueue Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31948 Bug ID: 31948 Summary: Add timestamp to tmp_holdsqueue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, michaela.sieber at kit.edu Depends on: 29346 With the option to have real time updates to tmp_holdsqueue (and maybe don't run the build_holdqueue?) as a consequence, it would be interesting to see when an entry was added or updated in the queue. We should have a timestamp! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 [Bug 29346] Real-time holds queue update -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:49:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:49:48 +0000 Subject: [Koha-bugs] [Bug 29346] Real-time holds queue update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31948 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31948 [Bug 31948] Add timestamp to tmp_holdsqueue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:52:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:52:34 +0000 Subject: [Koha-bugs] [Bug 31074] Plugin metadata is kept in cache after uninstalling a plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074 --- Comment #1 from Olivier Hubert --- Created attachment 142517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142517&action=edit Bug 31074: Reload a plugin's module before installation When using Plack, memcached or another caching mechanism, a plugin's old version is retained in the cache, even when uninstalled. If the plugin is then reinstalled, the old version is used, no matter the version installed. To prevent this, the plugin's module is reloaded every time it is installed. To test: 1) Install a plugin, like the kitchen sink. https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink/releases 2) Modify the .kpz and in KitchenSink.pm, change MINIMUN_VERSION. 3) Uninstall the plugin. 4) Install the new version. 5) The Minimum Koha version column still lists the old version. 6) Apply patch. 7) Repeat steps 1 through 4. 8) Observe that the Minimum Koha version column lists the correct version. 9) Sign off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:55:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:55:36 +0000 Subject: [Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:55:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:55:39 +0000 Subject: [Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644 --- Comment #16 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:55:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:55:42 +0000 Subject: [Koha-bugs] [Bug 31715] Add missing German translations for language descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31715 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:55:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:55:45 +0000 Subject: [Koha-bugs] [Bug 31715] Add missing German translations for language descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31715 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:55:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:55:47 +0000 Subject: [Koha-bugs] [Bug 31847] Add page section to item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31847 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:55:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:55:50 +0000 Subject: [Koha-bugs] [Bug 31847] Add page section to item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31847 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:55:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:55:52 +0000 Subject: [Koha-bugs] [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:55:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:55:55 +0000 Subject: [Koha-bugs] [Bug 31864] Fix breadcrumbs for each link coming from the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31864 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:55:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:55:59 +0000 Subject: [Koha-bugs] [Bug 31869] Unable to save thesaurus value to frameworks subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31869 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:56:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:56:01 +0000 Subject: [Koha-bugs] [Bug 31869] Unable to save thesaurus value to frameworks subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31869 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:56:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:56:04 +0000 Subject: [Koha-bugs] [Bug 31871] Due date not shown on items tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31871 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:56:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:56:08 +0000 Subject: [Koha-bugs] [Bug 31871] Due date not shown on items tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31871 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:56:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:56:10 +0000 Subject: [Koha-bugs] [Bug 31903] Article requests: Edit URLs link missing in the New tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31903 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:56:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:56:13 +0000 Subject: [Koha-bugs] [Bug 31903] Article requests: Edit URLs link missing in the New tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31903 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:58:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:58:00 +0000 Subject: [Koha-bugs] [Bug 31936] Link to advanced search form in acquisitions is missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 16:59:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 14:59:46 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:00:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:00:47 +0000 Subject: [Koha-bugs] [Bug 31074] Plugin metadata is kept in cache after uninstalling a plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074 Olivier Hubert changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |olivier.hubert at inlibro.com |ity.org | Status|NEW |Needs Signoff CC| |olivier.hubert at inlibro.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:01:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:01:06 +0000 Subject: [Koha-bugs] [Bug 22832] Require plugins to specify the methods they implement In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22832 Olivier Hubert changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen at gmail.com |olivier.hubert at inlibro.com CC| |olivier.hubert at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:01:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:01:23 +0000 Subject: [Koha-bugs] [Bug 31690] Add see from tracings in See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31690 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:01:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:01:29 +0000 Subject: [Koha-bugs] [Bug 31690] Add see from tracings in See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31690 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142334|0 |1 is obsolete| | --- Comment #7 from Caroline Cyr La Rose --- Created attachment 142518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142518&action=edit Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21) This patch adds the following fields to the See-from index - 450(abvxyz) - 451(avxyz) - 455(avxyz) Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:01:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:01:41 +0000 Subject: [Koha-bugs] [Bug 31949] New: Remove round corners from toolbars Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31949 Bug ID: 31949 Summary: Remove round corners from toolbars Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 When you change the background color for body, you can see that the toolbars still have round top corners. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:01:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:01:41 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31949 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31949 [Bug 31949] Remove round corners from toolbars -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:02:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:02:10 +0000 Subject: [Koha-bugs] [Bug 31948] Add timestamp to tmp_holdsqueue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31948 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:02:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:02:29 +0000 Subject: [Koha-bugs] [Bug 31690] Add see from tracings in See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31690 --- Comment #8 from Caroline Cyr La Rose --- I rebased it. I wasn't sure which status to put it in after -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:02:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:02:29 +0000 Subject: [Koha-bugs] [Bug 22832] Require plugins to specify the methods they implement In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22832 Olivier Hubert changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|olivier.hubert at inlibro.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:04:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:04:20 +0000 Subject: [Koha-bugs] [Bug 31936] Link to advanced search form in acquisitions is missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31936 --- Comment #3 from Katrin Fischer --- This restores previous functionality with the same amount of clicks - so nothing to complain about. Just wish it was a little more accessible/easier to spot somehow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:06:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:06:16 +0000 Subject: [Koha-bugs] [Bug 31936] Link to advanced search form in acquisitions is missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:06:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:06:20 +0000 Subject: [Koha-bugs] [Bug 31936] Link to advanced search form in acquisitions is missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142507|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 142519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142519&action=edit Bug 31936: Restore link to advanced search in acquisitions header This patch adds back the link to the advanced order search page which was previously in the acquisitions header search. Some CSS is tweaked to make the form style comfortable. To test, apply the patch and rebuild the staff interface CSS. - Go to Acquisitions. - In the header search form, click "Orders search" - Click the icon in the search form to expand the additional options. - You should see an "Advanced search" link which is the same style as other standard links. - The link should take you to the order search form. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:07:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:07:45 +0000 Subject: [Koha-bugs] [Bug 25716] Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:07:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:07:49 +0000 Subject: [Koha-bugs] [Bug 25716] Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125481|0 |1 is obsolete| | Attachment #125482|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 142520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142520&action=edit Bug 25716: Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder The z39.50 responder has a number of command line options that are not accessible if using the debian scripts to control it. We should be able to set those options in the koha conf file to be passed to the script itself. Test Plan: 1) Apply this patch 2) Copy your kohaclone's koha-z3950-responder to /usr/sbin/koha-z3950-responder if necessary 3) Add "--add-item-status k" inside your block in your koha-conf.xml file 4) Use koha-z3950-responder to start/restart the z39.50 responder, note the item status is now in subfield k! Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:08:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:08:00 +0000 Subject: [Koha-bugs] [Bug 25716] Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 --- Comment #15 from Kyle M Hall --- Created attachment 142521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142521&action=edit Bug 25716: Don't exit if config doesn't exist in Koha conf file Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:08:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:08:04 +0000 Subject: [Koha-bugs] [Bug 25716] Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 --- Comment #16 from Kyle M Hall --- Created attachment 142522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142522&action=edit Bug 25716: (QA follow-up) Move additional options to etc/z3950/config.xml This followup moves the configuration to the z3950 etc file, either the default and or the custom file is used as per the existing script code. In addition, the options and be set using an environment variable named Z3950_ADDITIONAL_OPTS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:08:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:08:54 +0000 Subject: [Koha-bugs] [Bug 31945] Add page-section to admin > patron categories area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31945 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:09:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:09:13 +0000 Subject: [Koha-bugs] [Bug 31945] Add page-section to admin > patron categories area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31945 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:09:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:09:19 +0000 Subject: [Koha-bugs] [Bug 31945] Add page-section to admin > patron categories area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31945 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142511|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 142523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142523&action=edit Bug 31945: Add page-section container to patron categories page This patch adds the page-section container to the patron categories administration page Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:09:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:09:50 +0000 Subject: [Koha-bugs] [Bug 31942] Add page-section to admin > authorized values area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31942 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:10:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:10:14 +0000 Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in MARC subfields structure breadcrumbs to facilitate translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718 --- Comment #15 from Caroline Cyr La Rose --- (In reply to Victor Grousset/tuxayo from comment #13) > > Release maintainers, this is needed as far back as 22.05, but not before that. > > Good that you repeat, because RMaints are unlikely to read all the comment > history. > But don't worry, having bug 30733 in the "Depends on" field here takes care > of ensuring that it's not backported too far. Also the way it will conflict > when trying to backport would give a hint that it's missing a dependency. I mainly wanted to let Lucas know that it was important to add it in 22.05 and not skip it :) After that, I figured it wouldn't apply... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:11:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:11:31 +0000 Subject: [Koha-bugs] [Bug 31942] Add page-section to admin > authorized values area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31942 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:11:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:11:35 +0000 Subject: [Koha-bugs] [Bug 31942] Add page-section to admin > authorized values area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31942 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142500|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 142524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142524&action=edit Bug 31952: Add page-section to authorized values admin This patch adds the page-section container to the authorized_values administration area. Test plan 1) Confirm that the AV admin area looks reasonable for all area's of display https://bugs.koha-community.org/show_bug.cgi?id=31942 Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:12:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:12:55 +0000 Subject: [Koha-bugs] [Bug 31941] Add page-section to admin > item types area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31941 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:13:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:13:21 +0000 Subject: [Koha-bugs] [Bug 31941] Add page-section to admin > item types area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31941 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:13:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:13:26 +0000 Subject: [Koha-bugs] [Bug 31941] Add page-section to admin > item types area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31941 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142503|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 142525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142525&action=edit Bug 31941: Add page-section container to item types This patch adds the page-section container to the item types adminstration page Test plan 1) Confirm the item types administration page uses the card view around the main table Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:13:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:13:39 +0000 Subject: [Koha-bugs] [Bug 31939] Add page-section to admin > libraries area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31939 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:16:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:16:50 +0000 Subject: [Koha-bugs] [Bug 31950] New: Page section on library view is too wide / not aligned with toolbar Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31950 Bug ID: 31950 Summary: Page section on library view is too wide / not aligned with toolbar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 31939 When viewing a library (click on the library name in admin > libraries) the page section is too wide and not aligning with the toolbar above. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31939 [Bug 31939] Add page-section to admin > libraries area -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:16:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:16:50 +0000 Subject: [Koha-bugs] [Bug 31939] Add page-section to admin > libraries area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31939 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31950 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31950 [Bug 31950] Page section on library view is too wide / not aligned with toolbar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:18:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:18:09 +0000 Subject: [Koha-bugs] [Bug 31939] Add page-section to admin > libraries area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31939 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:18:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:18:16 +0000 Subject: [Koha-bugs] [Bug 31939] Add page-section to admin > libraries area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31939 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142499|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 142526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142526&action=edit Bug 31939: Add page-section to branches template This patch adds the page-section class to the appropriate blocks in the Libraries administration area. Test plan 1) Confirm that Administration > Libraries correctly displays the table inside a page-section card 2) Confirm that Administration > Libraries > 'A library' correctly displays a card for the main information at the top and a separate card for OPAC Information if added. 3) Confirm that the 'Add' and 'Edit' library forms still look good. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:19:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:19:08 +0000 Subject: [Koha-bugs] [Bug 31917] Headings don't seem quite right for system preference search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:19:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:19:41 +0000 Subject: [Koha-bugs] [Bug 31951] New: Store MD5 sum for each notice in the sample_notices.yml file Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31951 Bug ID: 31951 Summary: Store MD5 sum for each notice in the sample_notices.yml file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When developers need to check if a notices matches the default and thus can be updated, it means putting the entire existing notice in the query. If we stored the MD5 in the YAML file, developers could use the MySQL MD5 function to more easily determine if the notice has changed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:20:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:20:10 +0000 Subject: [Koha-bugs] [Bug 31951] Store MD5 sum for each notice in the sample_notices.yml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31951 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Notices |and plumbing | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:24:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:24:15 +0000 Subject: [Koha-bugs] [Bug 31952] New: Sending an empty system preference search breaks layout Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952 Bug ID: 31952 Summary: Sending an empty system preference search breaks layout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 When sending the form for searching system preferences empty, the layout breaks a bit. One of the system preference headings will float to the right at the same height as the h1 heading. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:24:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:24:15 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952 [Bug 31952] Sending an empty system preference search breaks layout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:27:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:27:41 +0000 Subject: [Koha-bugs] [Bug 31953] New: Add read only "default" versions of notices that would be used if no other version of a notice is defined Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31953 Bug ID: 31953 Summary: Add read only "default" versions of notices that would be used if no other version of a notice is defined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Right now we have "undeletable" system notices. However, these notices can be modified and there is no easy way to get back to the original version. If we made these versions also "read-only" it would make undoing mistakes much easier for librarians, as they would just have to delete the custom version of the notice. When saving an "edited" version of these notices, it would actually make a copy with the branchcode set appropriately. The new order for selecting a notice would be branchcode specific, then no branchcode, then the "read-only" version. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:27:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:27:50 +0000 Subject: [Koha-bugs] [Bug 31953] Add read only "default" versions of notices that would be used if no other version of a notice is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31953 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31951 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:27:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:27:50 +0000 Subject: [Koha-bugs] [Bug 31951] Store MD5 sum for each notice in the sample_notices.yml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31951 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31953 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:29:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:29:28 +0000 Subject: [Koha-bugs] [Bug 31906] Managed by on basket summary page is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31906 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:30:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:30:57 +0000 Subject: [Koha-bugs] [Bug 31954] New: Patron search has no h1 heading Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31954 Bug ID: 31954 Summary: Patron search has no h1 heading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org For accessibility every page should have an h1 level heading and have a clear hierarchical structure of headings. Patron search only has 2 h3 headings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:33:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:33:32 +0000 Subject: [Koha-bugs] [Bug 31950] Page section on library view is too wide / not aligned with toolbar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31950 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #1 from Katrin Fischer --- It's much easier to see with the patch from bug 31939 and this in IntranetUserCSS: body { background-color: silver; } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:39:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:39:36 +0000 Subject: [Koha-bugs] [Bug 31949] Remove round corners from toolbars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31949 --- Comment #1 from Katrin Fischer --- Forgot, these are easier to see if you add this to your IntranetUserCSS: body { background-color: silver; } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:41:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:41:41 +0000 Subject: [Koha-bugs] [Bug 31917] Headings don't seem quite right for system preference search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 --- Comment #4 from Katrin Fischer --- I am not sure about this one. It removes one h1 and adds 3 new h1... but apart from this, we are currently not consistent: * Catalog search: What you searched for displays below the unchanged heading * Patron search: what you searched for displays as part of the altered heading. I'd like to get another set of eyes on this one, Owen or Lukas maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:43:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:43:08 +0000 Subject: [Koha-bugs] [Bug 31806] Add 'page-section' to holds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:46:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:46:13 +0000 Subject: [Koha-bugs] [Bug 31806] Add 'page-section' to holds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:46:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:46:17 +0000 Subject: [Koha-bugs] [Bug 31806] Add 'page-section' to holds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142468|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 142527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142527&action=edit Bug 31806: Add page-section to holds tables This patch adds the page-section class to each holds view on reserve/request.pl Test plan 1) Find an biblio to test on and add holds items of different types and homebranches. 2) Work through each setting of the HoldsSplitQueue preference and confirm the page-sections appear as expected Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:46:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:46:22 +0000 Subject: [Koha-bugs] [Bug 31806] Add 'page-section' to holds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142469|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 142528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142528&action=edit Bug 31806: Add page-section container to existing holds This patch adds a page-section container around the existing holds content section Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:53:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:53:33 +0000 Subject: [Koha-bugs] [Bug 31953] Add read only "default" versions of notices that would be used if no other version of a notice is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31953 --- Comment #1 from Katrin Fischer --- I am not sure about this one tbh. * We already get complaints about the list of notices being confusing. This could add to the confusion of "which notice is actually used". * Translations: New notices are often added in English only and our default notices are mostly not very nice. I think the idea for read-only doesn't work so well in a multi-language environment. * Our default notices are often not very nice and inconsistent. I would often not want to use them as a default. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 17:55:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 15:55:04 +0000 Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:20:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:20:52 +0000 Subject: [Koha-bugs] [Bug 31955] New: Add page-section to additional fields (admin) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31955 Bug ID: 31955 Summary: Add page-section to additional fields (admin) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Blocks: 31757 The table for configured additional fields should have some background (page-section). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:20:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:20:52 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31955 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31955 [Bug 31955] Add page-section to additional fields (admin) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:20:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:20:52 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31955 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31955 [Bug 31955] Add page-section to additional fields (admin) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:22:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:22:28 +0000 Subject: [Koha-bugs] [Bug 31906] Managed by on basket summary page is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31906 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:22:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:22:32 +0000 Subject: [Koha-bugs] [Bug 31906] Managed by on basket summary page is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31906 --- Comment #2 from Owen Leonard --- Created attachment 142529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142529&action=edit Bug 31906: Fix alignment of managed by button on basket summary page This patch makes a couple of changes to CSS which affect, globally, the alignment of labels in forms. With lables corresponding to text areas or other multi-line controls, the label should be aligned with the top of the control. This patch also changes the inline style attribute on the control that lets a user add an additional manager to a basket in acquisitions. It requires an update to work with the new default form layout. To test, apply the patch and go to Acquisitions -> Vendor -> Baskets. - View the details of a basket. - You should see a line labeled "Manged by." The label should be top-aligned to match the "Add user" link next to it. - Test that the link works correctly and that the layout is correct after adding additional managers. View other forms in the staff interface to confirm that the changes work correctly and have not broken layout anywhere else. For instance, in the patron add/edit form, the "Contact note," "OPAC note," labels etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:23:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:23:45 +0000 Subject: [Koha-bugs] [Bug 25716] Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:23:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:23:48 +0000 Subject: [Koha-bugs] [Bug 25716] Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 --- Comment #17 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:23:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:23:52 +0000 Subject: [Koha-bugs] [Bug 31806] Add 'page-section' to holds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:23:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:23:55 +0000 Subject: [Koha-bugs] [Bug 31806] Add 'page-section' to holds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 --- Comment #12 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:23:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:23:58 +0000 Subject: [Koha-bugs] [Bug 31850] Patron import: welcome email option style as list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31850 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:24:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:24:01 +0000 Subject: [Koha-bugs] [Bug 31850] Patron import: welcome email option style as list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31850 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:24:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:24:05 +0000 Subject: [Koha-bugs] [Bug 31879] Convert mainpage.css to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31879 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:24:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:24:08 +0000 Subject: [Koha-bugs] [Bug 31879] Convert mainpage.css to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31879 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:24:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:24:11 +0000 Subject: [Koha-bugs] [Bug 31936] Link to advanced search form in acquisitions is missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31936 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:24:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:24:14 +0000 Subject: [Koha-bugs] [Bug 31936] Link to advanced search form in acquisitions is missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31936 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:24:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:24:17 +0000 Subject: [Koha-bugs] [Bug 31939] Add page-section to admin > libraries area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31939 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:24:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:24:20 +0000 Subject: [Koha-bugs] [Bug 31939] Add page-section to admin > libraries area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31939 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:24:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:24:23 +0000 Subject: [Koha-bugs] [Bug 31941] Add page-section to admin > item types area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31941 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:24:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:24:26 +0000 Subject: [Koha-bugs] [Bug 31941] Add page-section to admin > item types area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31941 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:27:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:27:17 +0000 Subject: [Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #39 from Nick Clemens --- Created attachment 142530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142530&action=edit Bug 13600: (follow-up) Add separator between different series fields This patch checks for an upcoming series tag, and adds a separator if one is found -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:28:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:28:30 +0000 Subject: [Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #40 from Nick Clemens --- I fixed the issue with separators by checking ahead for upcoming series tags The semicolons should be handled on a new bug as we supposedly strip punctuation, then add it back, but it doesn't seem to be working -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:29:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:29:10 +0000 Subject: [Koha-bugs] [Bug 31942] Add page-section to admin > authorized values area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31942 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | CC| |tomascohen at gmail.com Status|Passed QA |Pushed to master --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! Note: I didn't notice the bug number error on the patch on pushing. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:29:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:29:42 +0000 Subject: [Koha-bugs] [Bug 31906] Managed by on basket summary page is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31906 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142529|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 142531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142531&action=edit Bug 31906: Fix alignment of managed by button on basket summary page This patch makes a couple of changes to CSS which affect, globally, the alignment of labels in forms. With lables corresponding to text areas or other multi-line controls, the label should be aligned with the top of the control. This patch also changes the inline style attribute on the control that lets a user add an additional manager to a basket in acquisitions. It requires an update to work with the new default form layout. To test, apply the patch and go to Acquisitions -> Vendor -> Baskets. - View the details of a basket. - You should see a line labeled "Manged by." The label should be top-aligned to match the "Add user" link next to it. - Test that the link works correctly and that the layout is correct after adding additional managers. View other forms in the staff interface to confirm that the changes work correctly and have not broken layout anywhere else. For instance, in the patron add/edit form, the "Contact note," "OPAC note," labels etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:32:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:32:16 +0000 Subject: [Koha-bugs] [Bug 31942] Add page-section to admin > authorized values area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31942 --- Comment #5 from Katrin Fischer --- Me neither... can we do something to fix? If we can't... It would make the one below show in release notes and have this one missing (which is maybe not the worst as all those will be pretty much ignored by normal users) Bug 31952 - Sending an empty system preference search breaks layout So... maybe we just need to fix bug 31952 :) -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:36:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:36:14 +0000 Subject: [Koha-bugs] [Bug 31690] Add see from tracings in See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31690 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Katrin Fischer --- If you feel it's not a totally different patch/are confident it's still working, you can go back to PQA straight away :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:36:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:36:21 +0000 Subject: [Koha-bugs] [Bug 31690] Add see from tracings in See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31690 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:45:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:45:12 +0000 Subject: [Koha-bugs] [Bug 31917] Headings don't seem quite right for system preference search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:45:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:45:18 +0000 Subject: [Koha-bugs] [Bug 31917] Headings don't seem quite right for system preference search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142472|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 142532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142532&action=edit Bug 31917: Headings fix for preferences search This patch re-arranges the logic for displaying the search term when executing a system preference search. Test plan 1) Without the patch, search for something that will get no results 'boing' and note how it looks 2) Without the patch, search for something that gets some results 'block' and note how it looks 3) Apply the patch 4) Repeat your searches and comment on whether the look is better of worse ;P Signed-off-by: David Nind Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:45:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:45:29 +0000 Subject: [Koha-bugs] [Bug 31917] Headings don't seem quite right for system preference search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 --- Comment #6 from Owen Leonard --- The template logic is a little more complex but I think the result is clearer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:52:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:52:06 +0000 Subject: [Koha-bugs] [Bug 31956] New: Clean up headings/legends on invoice summary view Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31956 Bug ID: 31956 Summary: Clean up headings/legends on invoice summary view Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/invoice.pl OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 31115 When looking at the invoice summary view, especially with bug 31115 applied, we see that there are some odd things: * Adjustments is an h3, but I think it should be h2 * The h2 headings our outside the fieldsets/white boxes but following our work on other pages, everything bug h1 should appear inside * As additional fields and other invoice information share a submit button, it makes sense for them to appear together, but the heading feelds to close to the content above. Maybe we need some CSS for nested fieldsets Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 [Bug 31115] Additional fields for invoices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 18:52:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 16:52:06 +0000 Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31956 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31956 [Bug 31956] Clean up headings/legends on invoice summary view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:05:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:05:40 +0000 Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:05:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:05:44 +0000 Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142250|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 142533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142533&action=edit Bug 31115: Add support for additional fields for invoices This patch adds support for additional fields for invoices. A new option is added to the 'Additional fields' admin page, for the 'aqinvoices' table. Adding/editing invoices now supports this additional fields. To test: 1. Apply this patches 2. Verify the original test plan works => SUCCESS: It does! 3. Sign off :-D Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:05:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:05:49 +0000 Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142251|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 142534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142534&action=edit Bug 31115: Add invoice fields manage link This patch adds a link on the acquisitions page for reaching the additional fields config for invoices in an easy way. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:05:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:05:54 +0000 Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142252|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 142535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142535&action=edit Bug 31115: Add additional_attributes support to GetInvoices This patch adds support for searching additional_fields when retrieving invoices using C4::Acquisition::Invoices. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Acquisition.t => SUCCESS: Tests pass! 3. Sign off :-D Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:05:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:05:58 +0000 Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142253|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 142536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142536&action=edit Bug 31115: Add additional field filtering for invoice search This patch adds support for filtering invoice searches on additional fields. To test: 1. Generate additional fields for invoices 2. Have invoices with additional fields 3. Use invoice searching and play with filtering by additional fields. => SUCCESS: It works! 4. Sign off :-D Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:06:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:06:03 +0000 Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 --- Comment #14 from Katrin Fischer --- Created attachment 142537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142537&action=edit Bug 31115: (QA follow-up) Remove hr The hr created a visible white line with a darker background and doesn't make sense here style wise. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:06:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:06:08 +0000 Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 --- Comment #15 from Katrin Fischer --- Created attachment 142538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142538&action=edit Bug 31115: (QA follow-up) Use more specific permission for sidebar link Moves from any acq permission to edit_invoices. Manage order baskets uses order_manage, to this is supposed to make things a little more consistent. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:06:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:06:31 +0000 Subject: [Koha-bugs] [Bug 17438] Warnings from Business::ISBN::Data in webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17438 --- Comment #14 from shalini --- Koha18.05.04.000 -Koha21.05 Thank you so much. I have sent the msg to the mailing list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:08:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:08:04 +0000 Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 --- Comment #16 from Katrin Fischer --- 1) Unit tests pass 2) QA tools pass 3) Permission check / links in navigation + [% IF CAN_user_acquisition && CAN_user_parameters_manage_additional_fields %] +
  • + Manage invoice fields +
  • + [% END %] [% IF CAN_user_acquisition_order_manage && CAN_user_parameters_manage_additional_fields %] The new link for additional invoice fields will need "any acq permission" + the specific administration permission. The old link for additional basket fields uses the more specific permission "order_manage". I've provided a follow-up using edit_invoices for the first link to make things a bit more consistent. I could also imagine merging the links into "Manage additional fields" might be logical a next step, as we also have bug 11844 hopefully moving soon. 4) Tiny follow up for strange hr Feel free to omit or push at your preference :) I set the background to a darker color for better contrast and that made it show up as a strange white line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:08:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:08:47 +0000 Subject: [Koha-bugs] [Bug 31532] Zebra search results including 880 with original script incorrect because of Bug 15187 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31532 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Keywords| |release-notes-needed --- Comment #9 from Tomás Cohen Arazi --- Please, add a comment about the required steps after upgrade for end users, so we add it to a technical section on the release notes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:20:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:20:31 +0000 Subject: [Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629 --- Comment #14 from Katrin Fischer --- (In reply to Björn Nylén from comment #8) > I made a more generalized addition to cleanup_database.pl before I saw this. > (moved to 22.05 last week so wanted this quickly). > Can add it as a suggestion if people are interested? Hi Björn, do you mean for tasks/jobs in general? A separate bug as mentioned in comment#7 would be great. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:37:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:37:01 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:41:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:41:05 +0000 Subject: [Koha-bugs] [Bug 15048] Genre/Form (655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:41:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:41:09 +0000 Subject: [Koha-bugs] [Bug 15048] Genre/Form (655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 --- Comment #27 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:41:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:41:12 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:41:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:41:15 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 --- Comment #24 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:41:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:41:19 +0000 Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:41:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:41:23 +0000 Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 --- Comment #17 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:41:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:41:26 +0000 Subject: [Koha-bugs] [Bug 31532] Zebra search results including 880 with original script incorrect because of Bug 15187 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31532 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:41:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:41:30 +0000 Subject: [Koha-bugs] [Bug 31532] Zebra search results including 880 with original script incorrect because of Bug 15187 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31532 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:41:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:41:34 +0000 Subject: [Koha-bugs] [Bug 31577] Use patron category multi-select for OpacHiddenItemsExceptions system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31577 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:41:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:41:37 +0000 Subject: [Koha-bugs] [Bug 31577] Use patron category multi-select for OpacHiddenItemsExceptions system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31577 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:41:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:41:40 +0000 Subject: [Koha-bugs] [Bug 31690] Add see from tracings in See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31690 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:41:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:41:42 +0000 Subject: [Koha-bugs] [Bug 31690] Add see from tracings in See-from index (Elasticsearch, MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31690 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:41:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:41:45 +0000 Subject: [Koha-bugs] [Bug 31739] Password reset from staff fails if previous expired reset-entry exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31739 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:41:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:41:50 +0000 Subject: [Koha-bugs] [Bug 31739] Password reset from staff fails if previous expired reset-entry exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31739 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:41:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:41:53 +0000 Subject: [Koha-bugs] [Bug 31945] Add page-section to admin > patron categories area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31945 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:41:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:41:56 +0000 Subject: [Koha-bugs] [Bug 31945] Add page-section to admin > patron categories area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31945 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:47:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:47:23 +0000 Subject: [Koha-bugs] [Bug 31955] Add page-section to additional fields (admin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31955 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:47:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:47:27 +0000 Subject: [Koha-bugs] [Bug 31955] Add page-section to additional fields (admin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31955 --- Comment #1 from Lucas Gass --- Created attachment 142539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142539&action=edit Bug 31955: Add page-section div to additional-fields.tt To test: 1. Apply patch 2. Look at Administration > Additional fields. 3. Each of the 4 tables should have a page-section div around it: Order baskets (aqbasket) Subscriptions (subscription) Account lines (credit) (accountlines:credit) Account lines (debit) (accountlines:debit) Note: There are some indentation changes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:47:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:47:58 +0000 Subject: [Koha-bugs] [Bug 31955] Add page-section to additional fields (admin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31955 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:52:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:52:04 +0000 Subject: [Koha-bugs] [Bug 31882] Fix page title of pages in the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31882 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:52:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:52:07 +0000 Subject: [Koha-bugs] [Bug 31882] Fix page title of pages in the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31882 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142516|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 142540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142540&action=edit Bug 31864: Correct titles for pages in new cataloging module To test: 1. Apply patch 2. Set system preference 'StockRotation' to enable. 3. Be logged in as a superlibrarian 4. Check the page titles for all pages, accessible from the Cataloging module homepage https://bugs.koha-community.org/show_bug.cgi?id=31882 Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:57:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:57:33 +0000 Subject: [Koha-bugs] [Bug 31812] Add yellow to stage imports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:57:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:57:38 +0000 Subject: [Koha-bugs] [Bug 31812] Add yellow to stage imports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142512|0 |1 is obsolete| | --- Comment #5 from Lucas Gass --- Created attachment 142541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142541&action=edit Bug 31812: Update 'Stage for import' button to be primary This patch updates the 'Stage for import' input to be of type="submit" and classes is a "button".. This gives it the yellow main action hinting. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 19:59:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 17:59:29 +0000 Subject: [Koha-bugs] [Bug 31812] Add yellow to stage imports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:02:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:02:04 +0000 Subject: [Koha-bugs] [Bug 31831] Make inactive search options font slightly bigger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31831 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #2 from Lucas Gass --- Thanks for making these bigger, looks better that way. +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:02:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:02:14 +0000 Subject: [Koha-bugs] [Bug 31812] Add yellow to stage imports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:02:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:02:20 +0000 Subject: [Koha-bugs] [Bug 31812] Add yellow to stage imports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142541|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 142542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142542&action=edit Bug 31812: Update 'Stage for import' button to be primary This patch updates the 'Stage for import' input to be of type="submit" and classes is a "button".. This gives it the yellow main action hinting. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:02:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:02:50 +0000 Subject: [Koha-bugs] [Bug 31812] Add yellow to stage imports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 --- Comment #7 from Katrin Fischer --- I feel like the upload file button should be yellow too, as we only see this one at first, what do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:02:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:02:51 +0000 Subject: [Koha-bugs] [Bug 31831] Make inactive search options font slightly bigger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31831 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:02:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:02:56 +0000 Subject: [Koha-bugs] [Bug 31831] Make inactive search options font slightly bigger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31831 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142513|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 142543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142543&action=edit Bug 31831: Make inactive search options font slightly bigger This patch removes the reduced font size from the "tab" links in the header search form (the links for switching between search forms). This makes the links the same size as the search form label. To test, apply the patch and rebuild the staff client CSS. On any page in the staff interface, test the appearance and behavior of the header search form. The controls should be clear and readable. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:03:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:03:14 +0000 Subject: [Koha-bugs] [Bug 31831] Make inactive search options font slightly bigger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31831 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:07:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:07:25 +0000 Subject: [Koha-bugs] [Bug 31831] Make inactive search options font slightly bigger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31831 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:07:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:07:29 +0000 Subject: [Koha-bugs] [Bug 31831] Make inactive search options font slightly bigger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31831 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142543|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 142544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142544&action=edit Bug 31831: Make inactive search options font slightly bigger This patch removes the reduced font size from the "tab" links in the header search form (the links for switching between search forms). This makes the links the same size as the search form label. To test, apply the patch and rebuild the staff client CSS. On any page in the staff interface, test the appearance and behavior of the header search form. The controls should be clear and readable. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:08:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:08:09 +0000 Subject: [Koha-bugs] [Bug 31882] Fix page title of pages in the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31882 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:10:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:10:48 +0000 Subject: [Koha-bugs] [Bug 31882] Fix page title of pages in the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31882 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:10:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:10:53 +0000 Subject: [Koha-bugs] [Bug 31882] Fix page title of pages in the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31882 --- Comment #3 from Katrin Fischer --- Created attachment 142545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142545&action=edit Bug 31882: Correct titles for pages in new cataloging module To test: 1. Apply patch 2. Set system preference 'StockRotation' to enable. 3. Be logged in as a superlibrarian 4. Check the page titles for all pages, accessible from the Cataloging module homepage https://bugs.koha-community.org/show_bug.cgi?id=31882 Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:11:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:11:09 +0000 Subject: [Koha-bugs] [Bug 31882] Fix page title of pages in the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31882 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142540|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:11:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:11:24 +0000 Subject: [Koha-bugs] [Bug 31882] Fix page title of pages in the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31882 --- Comment #4 from Katrin Fischer --- Fixed the wrong bug number in the commit message! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:14:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:14:09 +0000 Subject: [Koha-bugs] [Bug 31955] Add page-section to additional fields (admin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31955 --- Comment #2 from Katrin Fischer --- This is great. Wondering: should we have a page-section here too? http://localhost:8081/cgi-bin/koha/admin/additional-fields.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:15:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:15:29 +0000 Subject: [Koha-bugs] [Bug 31955] Add page-section to additional fields (admin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31955 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:15:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:15:48 +0000 Subject: [Koha-bugs] [Bug 31955] Add page-section to additional fields (admin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31955 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:15:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:15:53 +0000 Subject: [Koha-bugs] [Bug 31955] Add page-section to additional fields (admin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31955 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142539|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 142546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142546&action=edit Bug 31955: Add page-section div to additional-fields.tt To test: 1. Apply patch 2. Look at Administration > Additional fields. 3. Each of the 4 tables should have a page-section div around it: Order baskets (aqbasket) Subscriptions (subscription) Account lines (credit) (accountlines:credit) Account lines (debit) (accountlines:debit) Note: There are some indentation changes. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:16:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:16:17 +0000 Subject: [Koha-bugs] [Bug 31955] Add page-section to additional fields (admin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31955 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Katrin Fischer --- Moving to PQA directly! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:20:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:20:09 +0000 Subject: [Koha-bugs] [Bug 31459] Make order receive page faster on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement Summary|Order receive page is slow |Make order receive page |on systems with many |faster on systems with many |budgets |budgets CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:21:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:21:21 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:22:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:22:45 +0000 Subject: [Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629 --- Comment #15 from Björn Nylén --- (In reply to Katrin Fischer from comment #14) > (In reply to Björn Nylén from comment #8) > > I made a more generalized addition to cleanup_database.pl before I saw this. > > (moved to 22.05 last week so wanted this quickly). > > Can add it as a suggestion if people are interested? > > Hi Björn, do you mean for tasks/jobs in general? A separate bug as mentioned > in comment#7 would be great. Yeah, I made it so you could specify what jobtypes to purge and when. Obv mostly needed for elastic jobs but eventually you'll want to get rid of the other types. Will post a bug in the morning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:24:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:24:07 +0000 Subject: [Koha-bugs] [Bug 31929] On vendor edit page options are not aligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31929 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #1 from Lucas Gass --- The radio inputs should not be nested inside of their labels. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:24:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:24:35 +0000 Subject: [Koha-bugs] [Bug 30036] Add XSLT for authority results view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:27:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:27:48 +0000 Subject: [Koha-bugs] [Bug 31929] On vendor edit page options are not aligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31929 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:27:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:27:52 +0000 Subject: [Koha-bugs] [Bug 31929] On vendor edit page options are not aligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31929 --- Comment #2 from Lucas Gass --- Created attachment 142547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142547&action=edit Bug 31929: Radio inputs need to be outside of respective labels 1. Apply patch 2. Go to Acquisitions and edit or create a vendor. 3. Look at the radio buttons in the Ordering information section. 4. They should be properly aligned. 5. Make sure the form still works and you can save changes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:28:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:28:30 +0000 Subject: [Koha-bugs] [Bug 31917] Headings don't seem quite right for system preference search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 --- Comment #7 from Katrin Fischer --- Back to this one :) Thx, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:29:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:29:09 +0000 Subject: [Koha-bugs] [Bug 31917] Headings don't seem quite right for system preference search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:29:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:29:14 +0000 Subject: [Koha-bugs] [Bug 31917] Headings don't seem quite right for system preference search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142532|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 142548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142548&action=edit Bug 31917: Headings fix for preferences search This patch re-arranges the logic for displaying the search term when executing a system preference search. Test plan 1) Without the patch, search for something that will get no results 'boing' and note how it looks 2) Without the patch, search for something that gets some results 'block' and note how it looks 3) Apply the patch 4) Repeat your searches and comment on whether the look is better of worse ;P Signed-off-by: David Nind Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:30:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:30:07 +0000 Subject: [Koha-bugs] [Bug 31929] On vendor edit page options are not aligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31929 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #3 from Katrin Fischer --- Don't forget to set assignee! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:33:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:33:03 +0000 Subject: [Koha-bugs] [Bug 31929] On vendor edit page options are not aligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31929 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:33:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:33:07 +0000 Subject: [Koha-bugs] [Bug 31929] On vendor edit page options are not aligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31929 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142547|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 142549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142549&action=edit Bug 31929: Radio inputs need to be outside of respective labels 1. Apply patch 2. Go to Acquisitions and edit or create a vendor. 3. Look at the radio buttons in the Ordering information section. 4. They should be properly aligned. 5. Make sure the form still works and you can save changes. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:34:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:34:06 +0000 Subject: [Koha-bugs] [Bug 31929] On vendor edit page options are not aligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31929 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Katrin Fischer --- Nice logical fix, thx Lucas! PQA directly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:34:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:34:15 +0000 Subject: [Koha-bugs] [Bug 31834] Inconsistent table formatting for list of MARC imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #2 from Lucas Gass --- Looks better, and all the HTML is valid. My apologies as I think I was the one to add that 'table' class. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:34:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:34:30 +0000 Subject: [Koha-bugs] [Bug 31906] Managed by on basket summary page is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31906 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:34:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:34:55 +0000 Subject: [Koha-bugs] [Bug 31834] Inconsistent table formatting for list of MARC imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:34:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:34:58 +0000 Subject: [Koha-bugs] [Bug 31834] Inconsistent table formatting for list of MARC imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142515|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 142550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142550&action=edit Bug 31834: Replace incorrect "table" class from MARC imports table The table containing staged MARC record batches has a "table" class added to the
    tag, which is inconsistent with other tables in the staff interface. The class pulls in default table styles from Bootstrap which aren't consistent. There are a few other non-DataTable tables have the the class "dataTable" added in order to make them more consistent. I think this table should have that class too. The template is also modified to give the table a and , with indentation corrected accordingly. To test, apply the patch and go to Cataloging -> Manage staged records. The table of staged records should look correct, with style matching DataTables elsewhere in Koha, e.g. Administration -> Libraries. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:36:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:36:39 +0000 Subject: [Koha-bugs] [Bug 31957] New: Translation : Ability to change the sentence structure in branches.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Bug ID: 31957 Summary: Translation : Ability to change the sentence structure in branches.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr I'm having trouble translating the sentences in branches.tt where it says the the default is a system preference. For example, line ~210 [% IF ( CAN_user_parameters_manage_sysprefs ) %] Default: ILLDefaultStaffEmail system preference [% ELSE %] Default: ILLDefaultStaffEmail system preference [% END %] It comes out like this in translation msgid "%s Default: " msgid "ILLDefaultStaffEmail" msgid "" "system preference %s Default: ILLDefaultStaffEmail system preference %s " However, in French, the order of the words should be inverted, e.g. ILLDefaultStaffEmail system preference becomes system preference ILLDefaultStaffEmail. Can we modify the tt so that we get the whole sentence, or a %s that we can play with to change the order of the words? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:37:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:37:21 +0000 Subject: [Koha-bugs] [Bug 31947] [Omnibus] Add 'btn-primary' to the main action button where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add 'btn-primary' to the |[Omnibus] Add 'btn-primary' |main action button where |to the main action button |it's missing |where it's missing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:37:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:37:47 +0000 Subject: [Koha-bugs] [Bug 31958] New: Save button when editing a vendor should be yellow Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31958 Bug ID: 31958 Summary: Save button when editing a vendor should be yellow Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Blocks: 31947 When editing a vendor, the button for saving changes should be yellow. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 [Bug 31947] [Omnibus] Add 'btn-primary' to the main action button where it's missing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:37:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:37:47 +0000 Subject: [Koha-bugs] [Bug 31947] [Omnibus] Add 'btn-primary' to the main action button where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31958 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31958 [Bug 31958] Save button when editing a vendor should be yellow -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:41:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:41:41 +0000 Subject: [Koha-bugs] [Bug 31831] Make inactive search options font slightly bigger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31831 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:43:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:43:06 +0000 Subject: [Koha-bugs] [Bug 31459] Make order receive page faster on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 --- Comment #19 from Tomás Cohen Arazi --- I think this should be backported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:44:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:44:26 +0000 Subject: [Koha-bugs] [Bug 25763] Allow update of order fund after receipt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:44:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:44:30 +0000 Subject: [Koha-bugs] [Bug 25763] Allow update of order fund after receipt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 --- Comment #12 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:44:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:44:34 +0000 Subject: [Koha-bugs] [Bug 31459] Make order receive page faster on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:44:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:44:39 +0000 Subject: [Koha-bugs] [Bug 31459] Make order receive page faster on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 --- Comment #20 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:44:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:44:42 +0000 Subject: [Koha-bugs] [Bug 31812] Add yellow to stage imports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:44:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:44:43 +0000 Subject: [Koha-bugs] [Bug 31959] New: Patron without surname displays as null on basket summary 'Managed by' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31959 Bug ID: 31959 Summary: Patron without surname displays as null on basket summary 'Managed by' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org To test: * Add a new basket * Add a user without surname to "Managed by" (42 in sample data works) * Verify it displays as null koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:44:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:44:46 +0000 Subject: [Koha-bugs] [Bug 31812] Add yellow to stage imports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:44:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:44:50 +0000 Subject: [Koha-bugs] [Bug 31831] Make inactive search options font slightly bigger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31831 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:44:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:44:54 +0000 Subject: [Koha-bugs] [Bug 31831] Make inactive search options font slightly bigger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31831 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:44:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:44:58 +0000 Subject: [Koha-bugs] [Bug 31882] Fix page title of pages in the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31882 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:45:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:45:01 +0000 Subject: [Koha-bugs] [Bug 31882] Fix page title of pages in the new cataloging module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31882 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:45:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:45:05 +0000 Subject: [Koha-bugs] [Bug 31917] Headings don't seem quite right for system preference search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:45:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:45:08 +0000 Subject: [Koha-bugs] [Bug 31917] Headings don't seem quite right for system preference search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:45:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:45:12 +0000 Subject: [Koha-bugs] [Bug 31929] On vendor edit page options are not aligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31929 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:45:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:45:16 +0000 Subject: [Koha-bugs] [Bug 31929] On vendor edit page options are not aligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31929 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:45:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:45:20 +0000 Subject: [Koha-bugs] [Bug 31955] Add page-section to additional fields (admin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31955 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:45:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:45:24 +0000 Subject: [Koha-bugs] [Bug 31955] Add page-section to additional fields (admin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31955 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:48:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:48:06 +0000 Subject: [Koha-bugs] [Bug 31906] Managed by on basket summary page is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31906 --- Comment #4 from Katrin Fischer --- Created attachment 142551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142551&action=edit Screenshot showing labels Two small things: * it looks like the label aligns to the bottom here, but it feels like it should be the same line as 'null koha' here (null case filed separately as bug 31959) * Labels in the second column are already wrapping now and there is not a lot of space on the left column either. They don't extend for longer translations. Can we make this flexible or give some extra space here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:48:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:48:29 +0000 Subject: [Koha-bugs] [Bug 31906] Managed by on basket summary page is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31906 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:51:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:51:01 +0000 Subject: [Koha-bugs] [Bug 31906] Managed by on basket summary page is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31906 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #5 from Katrin Fischer --- Hm, only 1 small thing: I realized I had typoed the yarn build. The label is now correct. Leaving second comment about more flexible layout for contemplation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:51:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:51:44 +0000 Subject: [Koha-bugs] [Bug 31906] Managed by on basket summary page is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31906 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:51:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:51:49 +0000 Subject: [Koha-bugs] [Bug 31906] Managed by on basket summary page is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31906 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142531|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 142552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142552&action=edit Bug 31906: Fix alignment of managed by button on basket summary page This patch makes a couple of changes to CSS which affect, globally, the alignment of labels in forms. With lables corresponding to text areas or other multi-line controls, the label should be aligned with the top of the control. This patch also changes the inline style attribute on the control that lets a user add an additional manager to a basket in acquisitions. It requires an update to work with the new default form layout. To test, apply the patch and go to Acquisitions -> Vendor -> Baskets. - View the details of a basket. - You should see a line labeled "Manged by." The label should be top-aligned to match the "Add user" link next to it. - Test that the link works correctly and that the layout is correct after adding additional managers. View other forms in the staff interface to confirm that the changes work correctly and have not broken layout anywhere else. For instance, in the patron add/edit form, the "Contact note," "OPAC note," labels etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:56:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:56:39 +0000 Subject: [Koha-bugs] [Bug 31834] Inconsistent table formatting for list of MARC imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:59:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:59:39 +0000 Subject: [Koha-bugs] [Bug 31960] New: Information on job detail view is misaligned Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 Bug ID: 31960 Summary: Information on job detail view is misaligned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Created attachment 142553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142553&action=edit Job detail for a staged MARC import Not sure if this applies to all different jobs, but it does to the stage MARC one. (see screneshot) The heading is floating to the right and the other information is too far on the left. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 20:59:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 18:59:39 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31960 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 [Bug 31960] Information on job detail view is misaligned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:18:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:18:26 +0000 Subject: [Koha-bugs] [Bug 31834] Inconsistent table formatting for list of MARC imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:18:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:18:31 +0000 Subject: [Koha-bugs] [Bug 31834] Inconsistent table formatting for list of MARC imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142550|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 142554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142554&action=edit Bug 31834: Replace incorrect "table" class from MARC imports table The table containing staged MARC record batches has a "table" class added to the
    tag, which is inconsistent with other tables in the staff interface. The class pulls in default table styles from Bootstrap which aren't consistent. There are a few other non-DataTable tables have the the class "dataTable" added in order to make them more consistent. I think this table should have that class too. The template is also modified to give the table a and , with indentation corrected accordingly. To test, apply the patch and go to Cataloging -> Manage staged records. The table of staged records should look correct, with style matching DataTables elsewhere in Koha, e.g. Administration -> Libraries. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:23:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:23:36 +0000 Subject: [Koha-bugs] [Bug 31760] Low constrast of some colors (WCAG) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31760 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #2 from Katrin Fischer --- Please don't forget to set Assignee! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:24:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:24:28 +0000 Subject: [Koha-bugs] [Bug 31760] Fix contrast of separator in top header in staff client (WCAG) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31760 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Low constrast of some |Fix contrast of separator |colors (WCAG) |in top header in staff | |client (WCAG) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:26:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:26:43 +0000 Subject: [Koha-bugs] [Bug 31927] Use bigger font-size for bibliographic information on staff details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31927 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:26:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:26:48 +0000 Subject: [Koha-bugs] [Bug 31927] Use bigger font-size for bibliographic information on staff details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31927 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142496|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 142555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142555&action=edit Bug 31927: Use bigger font-size for bibliographic information on staff details page This patch removes the adusted font size from the definition of the .results_summary spans. The percentage decrease was being multiplied with another rule. To test, apply the patch and rebuild the staff interface CSS. Locate a bibliographic record in the staff client and view the detail page. Confirm that the bibliographic information is displayed in a comfortable size. Also test that catalog search results still look correct. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:28:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:28:27 +0000 Subject: [Koha-bugs] [Bug 31760] Fix contrast of separator in top header in staff client (WCAG) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31760 --- Comment #3 from Katrin Fischer --- Testing note: You need to turn on desks or cash registers and set one for the session to get to see the separator. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:30:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:30:17 +0000 Subject: [Koha-bugs] [Bug 31760] Fix contrast of separator in top header in staff client (WCAG) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31760 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:30:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:30:22 +0000 Subject: [Koha-bugs] [Bug 31760] Fix contrast of separator in top header in staff client (WCAG) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31760 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141792|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 142556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142556&action=edit Bug 31760: Fix contrast of 'separator' This patch increases the contrast of the separator pipe visible in the staff client upper right corner of the header bar. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:30:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:30:34 +0000 Subject: [Koha-bugs] [Bug 31927] Use bigger font-size for bibliographic information on staff details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31927 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- +100 I have one minor suggestion, which is to add some more padding before the row data, as the title and other row content is close to the table border. This would also balance this a bit more with the extra space at the bottom of the row. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:34:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:34:38 +0000 Subject: [Koha-bugs] [Bug 31961] New: 'Search' menu opens advanced search page, but selects checkout in simple search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31961 Bug ID: 31961 Summary: 'Search' menu opens advanced search page, but selects checkout in simple search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 I think now that the search bar remains on top of the advanced search, we should pre-select the catalog search there. I just ran into this coming form the acq module and trying to get back the search bar on top for a quick catalog search. I clicked search and ended up in circulation - but I had expected the catalog search. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:34:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:34:38 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31961 [Bug 31961] 'Search' menu opens advanced search page, but selects checkout in simple search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:37:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:37:04 +0000 Subject: [Koha-bugs] [Bug 31927] Use bigger font-size for bibliographic information on staff details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31927 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:37:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:37:34 +0000 Subject: [Koha-bugs] [Bug 31927] Use bigger font-size for bibliographic information on staff details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31927 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:37:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:37:39 +0000 Subject: [Koha-bugs] [Bug 31927] Use bigger font-size for bibliographic information on staff details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31927 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142555|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 142557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142557&action=edit Bug 31927: Use bigger font-size for bibliographic information on staff details page This patch removes the adusted font size from the definition of the .results_summary spans. The percentage decrease was being multiplied with another rule. To test, apply the patch and rebuild the staff interface CSS. Locate a bibliographic record in the staff client and view the detail page. Confirm that the bibliographic information is displayed in a comfortable size. Also test that catalog search results still look correct. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:37:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:37:56 +0000 Subject: [Koha-bugs] [Bug 31927] Use bigger font-size for bibliographic information on staff details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31927 --- Comment #6 from Katrin Fischer --- Also effects results, much better, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:40:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:40:22 +0000 Subject: [Koha-bugs] [Bug 31911] Headings are inconsistent in rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:40:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:40:27 +0000 Subject: [Koha-bugs] [Bug 31911] Headings are inconsistent in rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142504|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 142558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142558&action=edit Bug 31911: Improve rotating collections item management This patch renames 'Add/remove items from collection' to just 'Manage items' in the button in the rotating collections list table, the page heading and the breadcrumbs. We also move the heading below the toolbar to be consistent with elsewhere, remove a superflous second level heading and wrap the content table in a page-section too. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:40:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:40:33 +0000 Subject: [Koha-bugs] [Bug 31911] Headings are inconsistent in rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142505|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 142559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142559&action=edit Bug 31911: (follow-up) Rename second level heading This patch, as suggested, renames the second level heading to 'Items in collection' and move the 'Total items: {count}' into a paragraph. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:41:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:41:09 +0000 Subject: [Koha-bugs] [Bug 31911] Headings are inconsistent in rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:41:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:41:55 +0000 Subject: [Koha-bugs] [Bug 31911] Headings are inconsistent in rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:42:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:42:00 +0000 Subject: [Koha-bugs] [Bug 31911] Headings are inconsistent in rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142558|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 142560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142560&action=edit Bug 31911: Improve rotating collections item management This patch renames 'Add/remove items from collection' to just 'Manage items' in the button in the rotating collections list table, the page heading and the breadcrumbs. We also move the heading below the toolbar to be consistent with elsewhere, remove a superflous second level heading and wrap the content table in a page-section too. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:42:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:42:05 +0000 Subject: [Koha-bugs] [Bug 31911] Headings are inconsistent in rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142559|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 142561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142561&action=edit Bug 31911: (follow-up) Rename second level heading This patch, as suggested, renames the second level heading to 'Items in collection' and move the 'Total items: {count}' into a paragraph. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:42:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:42:41 +0000 Subject: [Koha-bugs] [Bug 31940] Add page-section to admin > library groups area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31940 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:43:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:43:00 +0000 Subject: [Koha-bugs] [Bug 31911] Headings are inconsistent in rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #9 from David Nind --- Created attachment 142562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142562&action=edit Screenshot - list of rotating collections Something minor (and maybe for another bug) - do we need to show 'Showing 1 to 2 of 2 entries' on a separate line? See the screenshot. I think on other screens (such as list of items for a record) we show on the same row as the DataTables header. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:46:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:46:10 +0000 Subject: [Koha-bugs] [Bug 31911] Headings are inconsistent in rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 --- Comment #10 from Katrin Fischer --- (In reply to David Nind from comment #9) > Created attachment 142562 [details] > Screenshot - list of rotating collections > > Something minor (and maybe for another bug) - do we need to show 'Showing 1 > to 2 of 2 entries' on a separate line? See the screenshot. > > I think on other screens (such as list of items for a record) we show on the > same row as the DataTables header. I think this has to do with today's changes to the datatable controls, unrelated to this bug. I see the same on the libraries page. I kinda like it, because the inofrmation was often missed before, but not sure if intentional or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:48:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:48:07 +0000 Subject: [Koha-bugs] [Bug 31911] Headings are inconsistent in rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 --- Comment #11 from Katrin Fischer --- It was bug 31861 and bug 31754. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:48:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:48:43 +0000 Subject: [Koha-bugs] [Bug 31940] Add page-section to admin > library groups area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31940 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:48:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:48:48 +0000 Subject: [Koha-bugs] [Bug 31940] Add page-section to admin > library groups area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31940 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142489|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 142563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142563&action=edit Bug 31940: Add page-section to library-groups This patch adds the page-section div around each library-groups table. Test plan 1) Check that the 'card' views appear appropriates on the library groups maangement page Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:49:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:49:55 +0000 Subject: [Koha-bugs] [Bug 31940] Add page-section to admin > library groups area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31940 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Katrin Fischer --- Small easy fix, passing QA directly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:56:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:56:31 +0000 Subject: [Koha-bugs] [Bug 31962] New: Standardize tooltips on datatable controls Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31962 Bug ID: 31962 Summary: Standardize tooltips on datatable controls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 31861 When you hover over Export and print, there is a tooltip in the form of a speech bubble showing on top. But if you hover over configure, a normal tooltip shows below. To test: * Go to a patron account * Check out any book * Hover over table controls Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 [Bug 31861] Table controls on checkouts table are buttons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:56:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:56:31 +0000 Subject: [Koha-bugs] [Bug 31861] Table controls on checkouts table are buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31962 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31962 [Bug 31962] Standardize tooltips on datatable controls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:59:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:59:19 +0000 Subject: [Koha-bugs] [Bug 31943] Date inputs wider than other inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31943 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|date inputs wider than |Date inputs wider than |other inputs |other inputs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 21:59:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 19:59:35 +0000 Subject: [Koha-bugs] [Bug 31943] Date inputs wider than other inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31943 --- Comment #2 from Katrin Fischer --- Confirmed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:03:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:03:35 +0000 Subject: [Koha-bugs] [Bug 31933] Import patrons fails when patron attribute value contains a comma In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31933 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Summary|import patrons fails when |Import patrons fails when |patron attribute value |patron attribute value |contains a comma |contains a comma -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:05:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:05:09 +0000 Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #29 from Katrin Fischer --- (In reply to Juliet Heltibridle from comment #28) > (In reply to Owen Leonard from comment #27) > > Created attachment 142195 [details] [review] [review] > > Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled > > > > This patch adds the new OPACBakerTaylorEnabled preferences to OPAC > > templates and scripts which were missed in the first patch. The patch > > also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql. > > > > Check these pages in the OPAC: > > > > - Catalog -> Search results > > - And search results -> RSS > > - Catalog -> Bibliographic details page -> Shelf browser > > - Catalog -> Lists -> List contents > > - Catalog -> Recent comments > > - And recent comments -> RSS > > - Your summary -> Checkouts and Overdues > > Works as expected on all the above pages except for search results -> RSS > and recent comments ->RSS. This is my first time using a sandbox, so I'm not > sure if I'm doing something wrong or not. It seems to me that the link for > the RSS is not being directed back to the sandbox opac. Instead of > https://staff-coverimages.sandbox.bywatersolutions.com/cgi-bin/koha/members/ > member.pl?quicksearch=1&circsearch=1&searchmember=shakespeare, it has > http://coverimages.mydnsname.org:8080/cgi-bin/koha/opac-search. > pl?idx=kw&q=shakespeare&format=rss. Hi Juliet, the RSS will build the link from the OpacBaseURL system preference setting, if you correct that, it might work ok. Could you give it another go maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:07:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:07:18 +0000 Subject: [Koha-bugs] [Bug 31931] Terminology for HoldsSplitQueue - staff client should be staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31931 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:07:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:07:23 +0000 Subject: [Koha-bugs] [Bug 31931] Terminology for HoldsSplitQueue - staff client should be staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31931 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142471|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 142564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142564&action=edit Bug 31931: Terminology for HoldsSplitQueue - use staff interface Rename "..staff client.." to "..staff interface.." in the description for the HoldsSplit Queue system preference, as per the terminology guidelines. Test plan. 1. View the description for the HoldsSplitQueue system preference. 2. Note that the description says "..staff client..". 3. Apply the patch. 4. Note that the description now says "..staff interface.." as per the terminology guidelines (https://wiki.koha-community.org/wiki/Terminology#S). 5. Sign off :D Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:07:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:07:51 +0000 Subject: [Koha-bugs] [Bug 31931] Terminology for HoldsSplitQueue - staff client should be staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31931 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer --- Fix is good, straight to PQA! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:12:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:12:36 +0000 Subject: [Koha-bugs] [Bug 11690] 'Most popular' in OPAC should ignore suppressed titles/items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11690 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|topissues should ignore |'Most popular' in OPAC |suppressed titles/items |should ignore suppressed | |titles/items URL| |/cgi-bin/koha/opac-topissue | |s.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:14:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:14:19 +0000 Subject: [Koha-bugs] [Bug 31922] Check alert for important fields is still a JavaScript message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31922 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Check alert for important |Check alert for important |fields is still a |fields is still a |javascript message |JavaScript message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:14:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:14:49 +0000 Subject: [Koha-bugs] [Bug 31338] Show in advanced search when IncludeSeeFromInSearches is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31338 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #29 from Tomás Cohen Arazi --- Please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:17:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:17:46 +0000 Subject: [Koha-bugs] [Bug 31923] 'Ignore' tab description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:17:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:17:50 +0000 Subject: [Koha-bugs] [Bug 31923] 'Ignore' tab description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142466|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 142565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142565&action=edit Bug 31923: 'Ignore' tab description is misleading This patch modifies the description of the 'Ignore' tab in MARC bibliographic and authority framework administration to add that not only does the 'ignored' subfield not appear in the editor, but the subfield will also be deleted from the record. To test: 1. Go to Administration > MARC bibliographic framework 2. Click 'Actions' next to any framework and choose 'MARC structure' 3. Click 'Actions' next to any field and choose 'Edit subfields' 4. Check the hint/description under 'Managed in tab' and make sure it - makes sense - is written in correct english (syntax and spelling) - mentions that the subfield's value will be deleted from the record 5. Go to Administration > Authority types 6. Redo steps 2-4 for authority frameworks Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:17:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:17:55 +0000 Subject: [Koha-bugs] [Bug 31923] 'Ignore' tab description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142467|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 142566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142566&action=edit Bug 31923: Add warning sign and span This patch adds a small warning sign before the sentence and also puts the sentence inside a span. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:23:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:23:09 +0000 Subject: [Koha-bugs] [Bug 19693] update of an authority record creates inconsistency when the heading tag is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:23:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:23:12 +0000 Subject: [Koha-bugs] [Bug 19693] update of an authority record creates inconsistency when the heading tag is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693 --- Comment #16 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:23:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:23:15 +0000 Subject: [Koha-bugs] [Bug 31834] Inconsistent table formatting for list of MARC imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:23:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:23:18 +0000 Subject: [Koha-bugs] [Bug 31834] Inconsistent table formatting for list of MARC imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:23:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:23:21 +0000 Subject: [Koha-bugs] [Bug 31906] Managed by on basket summary page is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31906 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:23:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:23:24 +0000 Subject: [Koha-bugs] [Bug 31906] Managed by on basket summary page is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31906 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:23:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:23:27 +0000 Subject: [Koha-bugs] [Bug 31911] Headings are inconsistent in rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:23:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:23:29 +0000 Subject: [Koha-bugs] [Bug 31911] Headings are inconsistent in rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 --- Comment #12 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:23:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:23:32 +0000 Subject: [Koha-bugs] [Bug 31927] Use bigger font-size for bibliographic information on staff details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31927 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:23:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:23:35 +0000 Subject: [Koha-bugs] [Bug 31927] Use bigger font-size for bibliographic information on staff details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31927 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:23:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:23:38 +0000 Subject: [Koha-bugs] [Bug 31931] Terminology for HoldsSplitQueue - staff client should be staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31931 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:23:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:23:41 +0000 Subject: [Koha-bugs] [Bug 31931] Terminology for HoldsSplitQueue - staff client should be staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31931 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:23:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:23:41 +0000 Subject: [Koha-bugs] [Bug 19693] Update of an authority record creates inconsistency when the heading tag is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|update of an authority |Update of an authority |record creates |record creates |inconsistency when the |inconsistency when the |heading tag is changed |heading tag is changed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:26:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:26:24 +0000 Subject: [Koha-bugs] [Bug 31876] Capitalization: Click to Expand this Tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31876 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:26:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:26:50 +0000 Subject: [Koha-bugs] [Bug 31923] 'Ignore' tab description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:26:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:26:53 +0000 Subject: [Koha-bugs] [Bug 31923] 'Ignore' tab description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923 --- Comment #16 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:26:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:26:55 +0000 Subject: [Koha-bugs] [Bug 31940] Add page-section to admin > library groups area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31940 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:26:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:26:58 +0000 Subject: [Koha-bugs] [Bug 31940] Add page-section to admin > library groups area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31940 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:30:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:30:35 +0000 Subject: [Koha-bugs] [Bug 31876] Capitalization: Click to Expand this Tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31876 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:35:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:35:41 +0000 Subject: [Koha-bugs] [Bug 31907] Show items as On hold when in processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31907 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:35:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:35:46 +0000 Subject: [Koha-bugs] [Bug 31907] Show items as On hold when in processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31907 --- Comment #2 from Katrin Fischer --- Created attachment 142567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142567&action=edit Bug 31876: Fix capitalization "Click to Expand Tag" The string "Click to Expand this Tag" appears in addbiblio.tt a couple of times. It should be "Click to expand this tag". To get to the string for the staff interface: 1. In the staff interface, go to Cataloging 2. Click "New record" 3. Hover the mouse cursor over one of the tag titles (e.g. CONTROL NUMBER) --> a little popup thing (tooltip?) appears with "Click to Expand this Tag" 4. Go to Administration > Global system preferences 5. Search for advancedMARCeditor 6. Change the value to "Don't show" 7. Click "Save all Cataloging preferences" 8. Go back to Cataloging > New record 9. Hover the mouse cursor over the tag number (e.g. 001) --> a little popup thing (tooltip?) appears with " Click to Expand this Tag" 10. Go to Authorities > new record 11. Hover over the desription of a tag which subfields are collapsed --> verify the tooltip appears with "Click to Expand this Tag" 12. Apply patch, all occurrences should be fixed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:36:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:36:37 +0000 Subject: [Koha-bugs] [Bug 31876] Capitalization: Click to Expand this Tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31876 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:36:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:36:42 +0000 Subject: [Koha-bugs] [Bug 31876] Capitalization: Click to Expand this Tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31876 --- Comment #1 from Katrin Fischer --- Created attachment 142568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142568&action=edit Bug 31876: Fix capitalization "Click to Expand Tag" The string "Click to Expand this Tag" appears in addbiblio.tt a couple of times. It should be "Click to expand this tag". To get to the string for the staff interface: 1. In the staff interface, go to Cataloging 2. Click "New record" 3. Hover the mouse cursor over one of the tag titles (e.g. CONTROL NUMBER) --> a little popup thing (tooltip?) appears with "Click to Expand this Tag" 4. Go to Administration > Global system preferences 5. Search for advancedMARCeditor 6. Change the value to "Don't show" 7. Click "Save all Cataloging preferences" 8. Go back to Cataloging > New record 9. Hover the mouse cursor over the tag number (e.g. 001) --> a little popup thing (tooltip?) appears with " Click to Expand this Tag" 10. Go to Authorities > new record 11. Hover over the desription of a tag which subfields are collapsed --> verify the tooltip appears with "Click to Expand this Tag" 12. Apply patch, all occurrences should be fixed now. https://bugs.koha-community.org/show_bug.cgi?id=31907 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:37:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:37:05 +0000 Subject: [Koha-bugs] [Bug 31907] Show items as On hold when in processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31907 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|String patch |Small patch CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:37:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:37:08 +0000 Subject: [Koha-bugs] [Bug 31907] Show items as On hold when in processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31907 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142567|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:37:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:37:29 +0000 Subject: [Koha-bugs] [Bug 7960] Choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:37:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:37:33 +0000 Subject: [Koha-bugs] [Bug 7960] Choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 --- Comment #32 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:37:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:37:37 +0000 Subject: [Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:37:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:37:40 +0000 Subject: [Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 --- Comment #30 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:37:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:37:43 +0000 Subject: [Koha-bugs] [Bug 31495] Allow opac-page when enforcing GDPR policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31495 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:37:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:37:46 +0000 Subject: [Koha-bugs] [Bug 31495] Allow opac-page when enforcing GDPR policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31495 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:37:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:37:49 +0000 Subject: [Koha-bugs] [Bug 31553] News item contents field does not always expand when you click on a non-default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31553 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:37:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:37:53 +0000 Subject: [Koha-bugs] [Bug 31553] News item contents field does not always expand when you click on a non-default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31553 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:37:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:37:56 +0000 Subject: [Koha-bugs] [Bug 31730] Link to authorized value interface when an authval is mentioned in preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31730 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:38:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:38:00 +0000 Subject: [Koha-bugs] [Bug 31730] Link to authorized value interface when an authval is mentioned in preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31730 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:39:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:39:05 +0000 Subject: [Koha-bugs] [Bug 31877] Capitalization: Delete this Tag and Repeat this Tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31877 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Capitalization: Delete this |Capitalization: Delete this |Tag |Tag and Repeat this Tag Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:41:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:41:06 +0000 Subject: [Koha-bugs] [Bug 31878] Capitalization: Repeat this Tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31878 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- Merging the 2 very similar bugs as they can be tested nicely together. *** This bug has been marked as a duplicate of bug 31877 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:41:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:41:06 +0000 Subject: [Koha-bugs] [Bug 31877] Capitalization: Delete this Tag and Repeat this Tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31877 --- Comment #1 from Katrin Fischer --- *** Bug 31878 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:44:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:44:36 +0000 Subject: [Koha-bugs] [Bug 31877] Capitalization: Delete this Tag and Repeat this Tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31877 --- Comment #2 from Katrin Fischer --- To get to the string in the staff interface: 1. In the staff interface, go to Cataloging 2. Click "New record" 3. Hover the mouse cursor over one of the duplicate tag buttons (two rectangles next to the tag title, e.g. next to 020 in MARC21) --> a little popup thing (tooltip?) appears with "Repeat this Tag" 4. Open the developper tools inspector in your browser 5. Click on the duplicate tag button --> the image alt text is "Repeat this Tag" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:52:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:52:13 +0000 Subject: [Koha-bugs] [Bug 31877] Capitalization: Delete this Tag and Repeat this Tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31877 --- Comment #3 from Katrin Fischer --- Created attachment 142569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142569&action=edit Bug 31877: Fix capitalization: "Delete this Tag" and "Repeat this Tag" To get to the string in the staff interface: 1. In the staff interface, go to Cataloging 2. Click "New record" 3. Hover the mouse cursor over one of the delete tag buttons (rectangle with a small x next to the tag title) --> a little popup thing (tooltip?) appears with "Delete this Tag" 4. Open the developper tools inspector in your browser 5. Click on the delete tag button --> the image alt text is "Delete this Tag" 6. Repeat the same check in the authorities editor 7. Apply patch 8. All tooltips and alt text should read correctly now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:52:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:52:30 +0000 Subject: [Koha-bugs] [Bug 31877] Capitalization: Delete this Tag and Repeat this Tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31877 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 22:57:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 20:57:21 +0000 Subject: [Koha-bugs] [Bug 31630] Batch item deletion no longer shows which items were not removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:01:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:01:06 +0000 Subject: [Koha-bugs] [Bug 31880] "Go to field" link in MARC validation goes nowhere if field not in the same tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31880 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #1 from Katrin Fischer --- I see the same, when the field is not on tab 0. Could the switch to Bootstrap tabs have something to do with this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:01:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:01:22 +0000 Subject: [Koha-bugs] [Bug 31880] "Go to field" link in MARC validation goes nowhere if field not in the same tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31880 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:06:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:06:04 +0000 Subject: [Koha-bugs] [Bug 29694] Add preference for setting marc-record system control number and identifier when saving biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29694 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Katrin Fischer --- Hi David, I feel like this is at least a partial duplicate to bug 27981, that was pushed for 22.11. 003 is set for me to the MarcOrgCode system preference value or to the logged in library's MARCOrgCode on saving. So this seems to work as well. *** This bug has been marked as a duplicate of bug 27981 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:06:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:06:04 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |glasklas at gmail.com --- Comment #80 from Katrin Fischer --- *** Bug 29694 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:09:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:09:05 +0000 Subject: [Koha-bugs] [Bug 31669] Improve support for ILL "cost" field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31669 --- Comment #1 from Katrin Fischer --- We use the cost field in our backend for the fee that can be charged to the patron for the ILL request. I am not sure how support for backend would be implemented as not all ILL systems might charge/have costs. Maybe this should cover the 'make editable'? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:11:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:11:49 +0000 Subject: [Koha-bugs] [Bug 31876] Capitalization: Click to Expand this Tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31876 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:11:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:11:53 +0000 Subject: [Koha-bugs] [Bug 31876] Capitalization: Click to Expand this Tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31876 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142568|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose --- Created attachment 142570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142570&action=edit Bug 31876: Fix capitalization "Click to Expand Tag" The string "Click to Expand this Tag" appears in addbiblio.tt a couple of times. It should be "Click to expand this tag". To get to the string for the staff interface: 1. In the staff interface, go to Cataloging 2. Click "New record" 3. Hover the mouse cursor over one of the tag titles (e.g. CONTROL NUMBER) --> a little popup thing (tooltip?) appears with "Click to Expand this Tag" 4. Go to Administration > Global system preferences 5. Search for advancedMARCeditor 6. Change the value to "Don't show" 7. Click "Save all Cataloging preferences" 8. Go back to Cataloging > New record 9. Hover the mouse cursor over the tag number (e.g. 001) --> a little popup thing (tooltip?) appears with " Click to Expand this Tag" 10. Go to Authorities > new record 11. Hover over the desription of a tag which subfields are collapsed --> verify the tooltip appears with "Click to Expand this Tag" 12. Apply patch, all occurrences should be fixed now. https://bugs.koha-community.org/show_bug.cgi?id=31907 Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:18:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:18:27 +0000 Subject: [Koha-bugs] [Bug 31671] Add a "Print transfer slip" button to /cgi-bin/koha/circ/branchtransfers.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31671 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142000|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 142571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142571&action=edit Bug 31671: Add print slip button to transfer page To test: 1. Apply patch 2. Go to Circulation / Transfer 3. Try transfering some items and notice the 'Print transfer slip' button 4. Try clicking on it and make sure it generates correctly and with the correct information on the slip -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:18:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:18:56 +0000 Subject: [Koha-bugs] [Bug 31671] Add a "Print transfer slip" button to /cgi-bin/koha/circ/branchtransfers.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31671 --- Comment #3 from Lucas Gass --- Rebased for current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:19:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:19:14 +0000 Subject: [Koha-bugs] [Bug 31877] Capitalization: Delete this Tag and Repeat this Tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31877 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:19:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:19:18 +0000 Subject: [Koha-bugs] [Bug 31877] Capitalization: Delete this Tag and Repeat this Tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31877 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142569|0 |1 is obsolete| | --- Comment #4 from Caroline Cyr La Rose --- Created attachment 142572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142572&action=edit Bug 31877: Fix capitalization: "Delete this Tag" and "Repeat this Tag" To get to the string in the staff interface: 1. In the staff interface, go to Cataloging 2. Click "New record" 3. Hover the mouse cursor over one of the delete tag buttons (rectangle with a small x next to the tag title) --> a little popup thing (tooltip?) appears with "Delete this Tag" 4. Open the developper tools inspector in your browser 5. Click on the delete tag button --> the image alt text is "Delete this Tag" 6. Repeat the same check in the authorities editor 7. Apply patch 8. All tooltips and alt text should read correctly now Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:31:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:31:41 +0000 Subject: [Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 --- Comment #14 from Katrin Fischer --- (In reply to Marie-Luce Laflamme from comment #13) > The IntranetUserJS syspref work around isn't working in Koha 22.05+ version. The handling for cookies has changed, this appears to work on master: $(document).ready(function() { if (typeof script !== 'undefined' && Cookies.get("issues-table-load-immediately-" + script) !== "true") { Cookies.set("issues-table-load-immediately-" + script, true, { expires: 365, sameSite: 'Lax' }); } }); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:34:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:34:19 +0000 Subject: [Koha-bugs] [Bug 30901] Add template method to be able to look up renewal data in Koha slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds a way to print release notes| |information about renewals | |to notices with Template | |Toolkit. | |Documentation: | |https://wiki.koha-community | |.org/wiki/Notices_with_Temp | |late_Toolkit#Example:_Circu | |lationRules.Renewals Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:35:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:35:35 +0000 Subject: [Koha-bugs] [Bug 30901] Add template method to be able to look up renewal data in Koha slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This adds a way to print |This adds a way to print release notes|information about renewals |information about renewals |to notices with Template |to notices with Template |Toolkit. |Toolkit. This includes the |Documentation: |numbers for used renewals, |https://wiki.koha-community |allowed renewals and |.org/wiki/Notices_with_Temp |remaining renewals and |late_Toolkit#Example:_Circu |more. |lationRules.Renewals |Documentation: | |https://wiki.koha-community | |.org/wiki/Notices_with_Temp | |late_Toolkit#Example:_Circu | |lationRules.Renewals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:36:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:36:56 +0000 Subject: [Koha-bugs] [Bug 31609] JavaScript error on Additional contents main page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 --- Comment #10 from Katrin Fischer --- I can see the JavaScript error as dscribed on Tools > News: Uncaught TypeError: firstTab[0] is undefined http://localhost:8081/cgi-bin/koha/tools/additional-contents.pl?category=news:1653 jQuery 13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:39:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:39:31 +0000 Subject: [Koha-bugs] [Bug 21381] Add serial enumeration to circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381 --- Comment #5 from Lucas Gass --- Created attachment 142573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142573&action=edit Bug 21381: (follow-up) fix typo in columns setting yml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:41:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:41:04 +0000 Subject: [Koha-bugs] [Bug 31609] JavaScript error on Additional contents main page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 --- Comment #11 from Katrin Fischer --- With this patch, all 3, Pages, News and HTML customizations on longer show the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:41:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:41:42 +0000 Subject: [Koha-bugs] [Bug 31609] JavaScript error on Additional contents main page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:41:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:41:46 +0000 Subject: [Koha-bugs] [Bug 31609] JavaScript error on Additional contents main page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140975|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 142574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142574&action=edit Bug 31609: JavaScript error on Additional contents main page This patch makes a minor modification to the JavaScript on the Additional contents page to prevent an error when there are no tabs present on the page. The JS needs an additional check so that it doesn't run when there are no tabs. To test you should have more than one language installed. - Before the patch, you would see a JavaScript error in the console: "Uncaught TypeError: can't access property "hash", firstTab[0] is undefined." - Apply the patch and go to Tools -> Additional contents. - With the patch applied there should be no error on the additional contents main page. - Try creating or editing additional contents entries to confirm that the interface still works correctly. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:42:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:42:08 +0000 Subject: [Koha-bugs] [Bug 31963] New: Only show reserve fee message on OPAC if they will actually be charged Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963 Bug ID: 31963 Summary: Only show reserve fee message on OPAC if they will actually be charged Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Hold fees can be set at the patron-category level, and if a patron who could be charged a reserve fee logs into the OPAC and tries the place a hold, a message about being charged a hold fee will show. This message does not take HoldFeeMode into consideration. When HoldFeeMode is set to "any time a reserve is collected" the message will be "You will be charged a hold fee of $X when you collect this item", but if HoldFeeMode is set to anything else, the message will be what we are seeing "You will be charged a hold fee of $X for placing this hold". This message can be a bit unexpected, especially if HoldFeeMode is set so hold fees should only be charged if all items are checked out and the record has at least one hold already. We don't expect we should see the message if there are items available and no holds on the record, when HoldFeeMode is set this way. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:42:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:42:14 +0000 Subject: [Koha-bugs] [Bug 31963] Only show reserve fee message on OPAC if they will actually be charged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:42:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:42:52 +0000 Subject: [Koha-bugs] [Bug 31963] Only show reserve fee message on OPAC if they will actually be charged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.05 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:43:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:43:17 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 142575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142575&action=edit Bug 23012: get_lostreturn_policy returns a scalar On commit 4d994773f83468b561896939f16131d0332d9cfc Koha::Item->_set_found_trigger gets the call to get_lostreturn_policy() changed so it expects a hashref instead of the scalar it returns. This patch adjusts it back. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => FAIL: Tests fail! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:43:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:43:47 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:43:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:43:50 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #30 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:43:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:43:54 +0000 Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:43:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:43:57 +0000 Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #79 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:44:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:44:36 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |When the system preference release notes| |NotifyPasswordChange is set | |to 'Notify' a notification | |will be sent to the user | |when their password is | |changed. The new | |notification uses the | |letter code PASSCHANGE. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:49:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:49:11 +0000 Subject: [Koha-bugs] [Bug 31952] Sending an empty system preference search breaks layout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #1 from Lucas Gass --- This is the same problem as Bug 31886. I neglected to update local_use.pref -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:49:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:49:39 +0000 Subject: [Koha-bugs] [Bug 31952] Sending an empty system preference search breaks layout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:51:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:51:49 +0000 Subject: [Koha-bugs] [Bug 31952] Sending an empty system preference search breaks layout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:51:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:51:52 +0000 Subject: [Koha-bugs] [Bug 31952] Sending an empty system preference search breaks layout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952 --- Comment #2 from Lucas Gass --- Created attachment 142576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142576&action=edit Bug 31952: Fix broken layout on system pref search TO test: 1. Do an empty system pref search 2. Layout is broken. 3. Apply patch, restart_all 4. Do another empty system pref search, the layout should be fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:52:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:52:55 +0000 Subject: [Koha-bugs] [Bug 25716] Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 --- Comment #18 from Tomás Cohen Arazi --- Created attachment 142577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142577&action=edit Bug 25716: (QA follow-up) Make sure a comment doesn't break tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:55:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:55:01 +0000 Subject: [Koha-bugs] [Bug 31964] New: Missing manpage for koha-z3950-responder Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31964 Bug ID: 31964 Summary: Missing manpage for koha-z3950-responder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:55:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:55:08 +0000 Subject: [Koha-bugs] [Bug 31964] Missing manpage for koha-z3950-responder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31964 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13937 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:55:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:55:08 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31964 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31964 [Bug 31964] Missing manpage for koha-z3950-responder -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:55:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:55:20 +0000 Subject: [Koha-bugs] [Bug 31964] Missing manpage for koha-z3950-responder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31964 --- Comment #1 from Tomás Cohen Arazi --- Not sure how we missed that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 24 23:56:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 21:56:56 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #81 from Katrin Fischer --- Sad to see this one stuck again. At the moment also doesn't apply cleanly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 00:01:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 22:01:49 +0000 Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #36 from Katrin Fischer --- (In reply to Martin Renvoize from comment #35) > I don't understand how running the exact same SQL as is in the update itself > can resolve this problem. Fixed on bug 31673. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 00:02:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 22:02:55 +0000 Subject: [Koha-bugs] [Bug 31960] Information on job detail view is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #1 from Lucas Gass --- It is likely happening with other jobs. The problem lines are these ones:
  • [% IF job.status != 'new' %][% PROCESS 'report' %][% END %]
  • [% IF job.status != 'new' %][% PROCESS 'detail' %][% END %]
  • We are processing those blocks inside of a list element and those blocks contain a bunch of their own HTML, including h2 and h3. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 00:04:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 22:04:04 +0000 Subject: [Koha-bugs] [Bug 12709] Send a custom email to some or all patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12709 --- Comment #8 from Katrin Fischer --- Maybe we should rename this "Move patron-emailer functionality into core"? Then one could manually send custom notices manually and next step could be to implement scheduling in the GUI maybe. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 00:06:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 22:06:09 +0000 Subject: [Koha-bugs] [Bug 20732] Display the note tab for records without items. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20732 --- Comment #2 from Katrin Fischer --- I like both ideas, not sure if Elaine's suggestion would need to be a system preference. Removing the (0) would also be interesting for libraries using AlternateHoldingsField. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 00:06:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 22:06:18 +0000 Subject: [Koha-bugs] [Bug 20732] Display the note tab for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20732 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Display the note tab for |Display the note tab for |records without items. |records without items Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 00:09:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 22:09:32 +0000 Subject: [Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #5 from Katrin Fischer --- Maybe we should remove the translations here? - overlay_rules_presets[_("Overwrite")] = { + overlay_rules_presets[_("overwrite")] = { So maybe: - overlay_rules_presets[_("Overwrite")] = { + overlay_rules_presets["Overwrite"] = { -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 00:21:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 22:21:49 +0000 Subject: [Koha-bugs] [Bug 31910] Article request form is misaligned/misformatted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31910 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 00:21:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 22:21:52 +0000 Subject: [Koha-bugs] [Bug 31910] Article request form is misaligned/misformatted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31910 --- Comment #1 from Lucas Gass --- Created attachment 142578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142578&action=edit Bug 31910: Fix list and add page-section to request-article.tt To test: 1. Apply patch 2. Look at article request form and ensure the fields and labels look good. 3. Ensure there are no more bullet points on the list. 4. Make sure the page-section div around the item selection looks good. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 00:22:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 22:22:59 +0000 Subject: [Koha-bugs] [Bug 31910] Article request form is misaligned/misformatted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31910 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 00:30:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 22:30:33 +0000 Subject: [Koha-bugs] [Bug 31911] Headings are inconsistent in rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 --- Comment #13 from David Nind --- (In reply to Katrin Fischer from comment #10) > (In reply to David Nind from comment #9) > > Created attachment 142562 [details] > > Screenshot - list of rotating collections > > > > Something minor (and maybe for another bug) - do we need to show 'Showing 1 > > to 2 of 2 entries' on a separate line? See the screenshot. > > > > I think on other screens (such as list of items for a record) we show on the > > same row as the DataTables header. > > I think this has to do with today's changes to the datatable controls, > unrelated to this bug. I see the same on the libraries page. > > I kinda like it, because the inofrmation was often missed before, but not > sure if intentional or not. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 00:44:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 22:44:28 +0000 Subject: [Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141401|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 142579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142579&action=edit Bug 31694: MARC overlay rules presets don't change anything if presets are translated This patch corrects option value names in MARC overlay rules to prevent them from being translated. To test: 1. Install a new language 1.1. In a terminal, run the following commands gulp po:update cd misc/translator ./translate install xx-XX 1.2. Go to Administration > Global system preferences 1.3. Search for language 1.4. In the language syspref check the box for the language you just installed 1.5. Save 2. In the staff interface in English, go to Administration > Record overlay rules 3. In the column 'Preset' try the various options, note that the 'Added', 'Appended', 'Removed', and 'Deleted' settings change depending on the chosen preset 4. Change the interface language 5. Redo step 3, notice that if the preset name is translated, the other settings don't change 6. Apply patch 7. Redo step 3, the presets should now change the settings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 00:44:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 22:44:32 +0000 Subject: [Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #7 from Katrin Fischer --- Created attachment 142580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142580&action=edit Bug 31694: (follow-up) Further improve translatability To test: * Add rules fo different modules and with different settings * Verify the saved module description for a saved rule matches the pull down * Verify the saved filter matches the pull downs (especially for source and patron category) Also: * Renames 'User category' to 'Patron category' * Remove some values from translations, that shouldn't be translated, like value attributs for options. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 00:51:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 22:51:15 +0000 Subject: [Koha-bugs] [Bug 31495] Allow viewing CMS pages when enforcing GDPR policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31495 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow opac-page when |Allow viewing CMS pages |enforcing GDPR policy |when enforcing GDPR policy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 00:56:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 22:56:43 +0000 Subject: [Koha-bugs] [Bug 31935] Serials subscription form is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch CC| |lucas at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 00:57:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 22:57:10 +0000 Subject: [Koha-bugs] [Bug 31935] Serials subscription form is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 00:57:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 22:57:14 +0000 Subject: [Koha-bugs] [Bug 31935] Serials subscription form is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 --- Comment #1 from Lucas Gass --- Created attachment 142581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142581&action=edit Bug 31935: Fix misaligned form when adding serial subscription This patch attempts to fix the misaligned form on subscription-add.tt by removing some of the wrapping

    tags and adding labels where appropriate. To test: 1. Add a serial subscription and notice the misaligned form on step 1. 2. Apply patch 3. Look again and confirm that the form looks better. 4. Read through everything and make sure the form still makes sense. 5. Make sure the form still works properly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 01:03:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 23:03:55 +0000 Subject: [Koha-bugs] [Bug 21381] Add serial enumeration to circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 01:04:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 23:04:00 +0000 Subject: [Koha-bugs] [Bug 21381] Add serial enumeration to circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142033|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 142582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142582&action=edit Bug 21381: Add serial enumeration to circulation/checkout history * Set readinghistory and intranetreadinghistory to Allow * Check out some items and return some. At least one item should have serial enumeration set to something * Go to OPAC > patron account > checkout history * Verify the Vol info shows the same as on the detail page. * Go to staff interface > patron account > circulation history * Verify the Vol info shows correctly there as well. Bug 21381: Add serial enumeration to circulation/checkout history https://bugs.koha-community.org/show_bug.cgi?id=31281 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 01:04:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 23:04:06 +0000 Subject: [Koha-bugs] [Bug 21381] Add serial enumeration to circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142035|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 142583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142583&action=edit Bug 21381: (follow-up) Fix table configuration for new column The new column was added to the table settings configuration. To test: * Make sure the column shows up in the columns menu of the table in the staff interface. * Verify it can be hidden/unhidden correctly using the menu or the table setings. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 01:04:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 23:04:11 +0000 Subject: [Koha-bugs] [Bug 21381] Add serial enumeration to circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142573|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 142584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142584&action=edit Bug 21381: (follow-up) fix typo in columns setting yml Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 01:22:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 23:22:51 +0000 Subject: [Koha-bugs] [Bug 31963] Only show reserve fee message on OPAC if they will actually be charged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 01:22:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 23:22:55 +0000 Subject: [Koha-bugs] [Bug 31963] Only show reserve fee message on OPAC if they will actually be charged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963 --- Comment #1 from Aleisha Amohia --- Created attachment 142585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142585&action=edit Bug 31963: Only show hold fee msg on OPAC if patron will be charged This patch ensures HoldFeeMode is considered when displaying a message to patrons on the OPAC that says they'll be charged a hold fee when placing or collecting the hold. When HoldFeeMode is set to not_always or "only if all items are checked out and the record has at least one hold already" then the hold fee message should only show if all items on the record are checked out, AND the record has at least one hold already - both of these conditions must be met. To test: 1. Go to Administration -> Patron categories 2. Edit your patron category and give a hold fee of $1. 3. Go to Administration -> System preferences and search for HoldFeeMode. Set to 'only if all items are checked out and the record has at least one hold already' if not already set. Keep this tab open. 4. In another tab, open the OPAC. 5. Search the OPAC for a record with one item which is NOT checked out. 6. Go to place a hold on this record. Confirm you see a message saying that you will be charged a hold fee, even though not all items are checked out and the record does not have a hold --> This is the bug. 7. Apply patch and restart services. Items available, no holds placed 8. Repeat steps 5-6. This time, you should NOT see the hold fee message. Items available, holds placed 9. In your staff interface tab, find the same record. 10. Place a hold for a different patron on this record. 11. In your OPAC tab, find this record again and go to place a hold. You should NOT see the hold fee message. No items available, no holds placed 12. In your staff interface tab, cancel the hold placed on this record. 13. Check out the item to a different patron. 14. In your OPAC tab, find this record again and go to place a hold. You should NOT see the hold fee message. No items available, holds placed 15. In your staff interface tab, keep the item checked out to another patron. 16. Place a hold for a third patron on this record. 17. In your OPAC tab, find this record again and go to place a hold. You SHOULD see the hold fee message. Multiple holds 18. Search the OPAC for a record. Make sure your search will return more than one result, including our test record. 19. Check the checkbox for our test record, plus another record where the item is not checked out. 20. Click the Place hold button to place holds on all of our selected records. You should only see the hold fee message above our test record. 21. In your staff interface tab, test setting HoldFeeMode to the other values and confirm the hold message shows on the OPAC as expected. 22. Confirm tests pass t/db_dependent/Reserves/GetReserveFee.t Sponsored-by: Horowhenua Libraries Trust -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 01:23:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 23:23:29 +0000 Subject: [Koha-bugs] [Bug 31963] Only show reserve fee message on OPAC if they will actually be charged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch ensures release notes| |HoldFeeMode is considered | |when displaying a message | |to patrons on the OPAC that | |says they'll be charged a | |hold fee when placing or | |collecting the hold. | | | |When | |HoldFeeMode is set to | |not_always or "only if all | |items are checked out and | |the record has at least one | |hold already" then the hold | |fee message should only | |show if all items on the | |record are checked out, AND | |the record has at least one | |hold already - both of | |these conditions must be | |met. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 01:23:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 23:23:51 +0000 Subject: [Koha-bugs] [Bug 28577] Add column for copynumber on overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28577 --- Comment #4 from David Nind --- In admin/columns_settings.yml columnname is spelt incorrectly - spelt as columname (In reply to Katrin Fischer from comment #3) > (In reply to David Nind from comment #2) > > Created attachment 142090 [details] > > Screenshots of column display and settings table > > > > Hi Katrin. > > > > After the patch is applied (see attached screenshots): > > > > - Item type is displaying in the copy number column, and copy number is > > displaying in the item type column. > > > > - There is no column name label in the table settings (and the wrong columns > > are toggled). > > > > David > > Hm, I wonder what I did there, will have a look. For the column name label not displaying, columnname is spelt incorrectly in admin/columns_settings.yml - spelt as columname. (Spotted by Lucas for bug 21381.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 01:39:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 23:39:33 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142102|0 |1 is obsolete| | Attachment #142115|0 |1 is obsolete| | Attachment #142116|0 |1 is obsolete| | Attachment #142117|0 |1 is obsolete| | Attachment #142118|0 |1 is obsolete| | --- Comment #20 from Lari Taskula --- Created attachment 142586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142586&action=edit Bug 31692: Add Koha::Hold::change_type and unit tests To test: 1. prove t/db_dependent/Koha/Hold.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 01:39:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 23:39:38 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142114|0 |1 is obsolete| | --- Comment #21 from Lari Taskula --- Created attachment 142587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142587&action=edit Bug 31692: Allow librarians to change hold type in staff client To test: 1. Apply patch 2. Add item level hold to a record/item, make sure patron has no other holds on that record 3. Go to /cgi-bin/koha/reserve/request.pl?biblionumber=xxx where xxx is the record you placed the hold for 4. Under "Existing holds" table, in "Details" column you should see "Only item " dropdown 5. Select "Next available" from the dropdown 6. Click Update hold(s) 7. Observe dropdown value has changed from "Only item " to "Next available" 8. Cancel the hold and add two item level holds 9. Under "Existing holds" table, in "Details" column you should see "Only item ", but no select dropdown -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 01:41:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 23:41:14 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #85 from David Cook --- I'm not too worried about the JSON editor at this point. More of a nice to have but not essential. Agustin, are we going to get an updated version before the end of this week? I could make time to QA this before the soft feature freeze this Friday. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 01:49:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Oct 2022 23:49:35 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #22 from Lari Taskula --- (In reply to Lucas Gass from comment #19) > I do wonder if there is still going to be some confusion on what the > dropdown does. Do we need a hint or a tip to help describe what the dropdown > is going to do? I think the dropdown values themselves explain what it does. If you think more detailed description is needed, feel free to make a suggestion. On another note I've squashed the follow-ups into the main patch and updated test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 02:15:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 00:15:18 +0000 Subject: [Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 02:15:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 00:15:24 +0000 Subject: [Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140705|0 |1 is obsolete| | --- Comment #41 from David Nind --- Created attachment 142588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142588&action=edit Bug 13600: XSLT - 8xx not showing if there is no 4xx This patch adjusts XSLT so that series tag displays if any 440,490,800,810,830 is present It also adjusts 8xx to display even if 490 ind 1 = 1 is not present To test: 1 - Check records with multiple series tag 2 - Confirm display is correct Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 02:15:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 00:15:31 +0000 Subject: [Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142530|0 |1 is obsolete| | --- Comment #42 from David Nind --- Created attachment 142589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142589&action=edit Bug 13600: (follow-up) Add separator between different series fields This patch checks for an upcoming series tag, and adds a separator if one is found Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 02:20:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 00:20:42 +0000 Subject: [Koha-bugs] [Bug 31965] New: Put OpenID discovery doc URL in a system preference Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 Bug ID: 31965 Summary: Put OpenID discovery doc URL in a system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Theoretically we could authenticate with OpenID Connect and any other identity provider than Google using the existing googleopenidconnect script, this would be helped if the discovery doc URL could be provided with a system preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 02:21:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 00:21:09 +0000 Subject: [Koha-bugs] [Bug 31965] Put OpenID discovery doc URL in a system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 02:23:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 00:23:21 +0000 Subject: [Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #43 from David Nind --- Have signed off based on the follow-up, and that semicolons will be addressed in another bug. Thanks Heather for your great comments! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 02:32:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 00:32:44 +0000 Subject: [Koha-bugs] [Bug 31671] Add a "Print transfer slip" button to /cgi-bin/koha/circ/branchtransfers.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31671 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david at davidnind.com --- Comment #4 from David Nind --- After applying the patch, I'm getting an error trace when I go to access the transfer page: Template process failed: file error - parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt line 275: unexpected end of input at /kohadevbox/koha/C4/Templates.pm line 127.... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 02:36:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 00:36:24 +0000 Subject: [Koha-bugs] [Bug 31965] Put OpenID discovery doc URL in a system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- I think that the community are planning to replace this functionality soon with Bug 31378. I'm not a fan of the googleopenidconnect script myself (for lots of reasons), but I suppose there is no harm in updating it. You'd need to add a system preference for the "issuer" as well, and to rewrite with a patch or with JS anything in the OPAC that says Google I suppose... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 02:40:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 00:40:49 +0000 Subject: [Koha-bugs] [Bug 31965] Put OpenID discovery doc URL in a system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31378 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 02:40:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 00:40:49 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31965 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 02:44:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 00:44:42 +0000 Subject: [Koha-bugs] [Bug 31965] Put OpenID discovery doc URL in a system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 --- Comment #2 from Aleisha Amohia --- Thanks David, I wasn't aware of Bug 31378. I do know that $issuer needs a system preference too, I was going to do that separately. We have a partner library that needs to use OpenID Connect with Azure so perhaps this could be the interim fix while Bug 31378 gets over the line? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 02:54:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 00:54:21 +0000 Subject: [Koha-bugs] [Bug 31910] Article request form is misaligned/misformatted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31910 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 02:54:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 00:54:26 +0000 Subject: [Koha-bugs] [Bug 31910] Article request form is misaligned/misformatted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31910 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142578|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142590&action=edit Bug 31910: Fix list and add page-section to request-article.tt To test: 1. Apply patch 2. Look at article request form and ensure the fields and labels look good. 3. Ensure there are no more bullet points on the list. 4. Make sure the page-section div around the item selection looks good. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 03:10:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 01:10:57 +0000 Subject: [Koha-bugs] [Bug 31935] Serials subscription form is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind --- Created attachment 142591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142591&action=edit Screenshot - new subscription form A couple of things I noted (see the screenshot): 1. For When receiving this serial: when "Create an item record" is selected, the Collection and Item type fields are misaligned. 2. For vendor: no space after the closing bracket and before the search icon, also there is a space between the end of the form field and the bracket which looks odd. 3. For Record: no space after the closing bracket and before "Required", also there is a space between the end of the form field and the bracket which looks odd. 4. "Search for record" and "Create record" placement: looks "off" where they are at the moment - maybe should be aligned under the input field/help text. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 03:11:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 01:11:30 +0000 Subject: [Koha-bugs] [Bug 31935] Serials subscription form is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 03:30:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 01:30:04 +0000 Subject: [Koha-bugs] [Bug 31965] Put OpenID discovery doc URL in a system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |dcook at prosentient.com.au |y.org | --- Comment #3 from David Cook --- (In reply to Aleisha Amohia from comment #2) > Thanks David, I wasn't aware of Bug 31378. > > I do know that $issuer needs a system preference too, I was going to do that > separately. > > We have a partner library that needs to use OpenID Connect with Azure so > perhaps this could be the interim fix while Bug 31378 gets over the line? I suppose that's up to the RM, so best to send him an email. If he's OK with it, I could QA it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 03:38:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 01:38:22 +0000 Subject: [Koha-bugs] [Bug 31963] Only show reserve fee message on OPAC if they will actually be charged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 03:38:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 01:38:27 +0000 Subject: [Koha-bugs] [Bug 31963] Only show reserve fee message on OPAC if they will actually be charged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142585|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142592&action=edit Bug 31963: Only show hold fee msg on OPAC if patron will be charged This patch ensures HoldFeeMode is considered when displaying a message to patrons on the OPAC that says they'll be charged a hold fee when placing or collecting the hold. When HoldFeeMode is set to not_always or "only if all items are checked out and the record has at least one hold already" then the hold fee message should only show if all items on the record are checked out, AND the record has at least one hold already - both of these conditions must be met. To test: 1. Go to Administration -> Patron categories 2. Edit your patron category and give a hold fee of $1. 3. Go to Administration -> System preferences and search for HoldFeeMode. Set to 'only if all items are checked out and the record has at least one hold already' if not already set. Keep this tab open. 4. In another tab, open the OPAC. 5. Search the OPAC for a record with one item which is NOT checked out. 6. Go to place a hold on this record. Confirm you see a message saying that you will be charged a hold fee, even though not all items are checked out and the record does not have a hold --> This is the bug. 7. Apply patch and restart services. Items available, no holds placed 8. Repeat steps 5-6. This time, you should NOT see the hold fee message. Items available, holds placed 9. In your staff interface tab, find the same record. 10. Place a hold for a different patron on this record. 11. In your OPAC tab, find this record again and go to place a hold. You should NOT see the hold fee message. No items available, no holds placed 12. In your staff interface tab, cancel the hold placed on this record. 13. Check out the item to a different patron. 14. In your OPAC tab, find this record again and go to place a hold. You should NOT see the hold fee message. No items available, holds placed 15. In your staff interface tab, keep the item checked out to another patron. 16. Place a hold for a third patron on this record. 17. In your OPAC tab, find this record again and go to place a hold. You SHOULD see the hold fee message. Multiple holds 18. Search the OPAC for a record. Make sure your search will return more than one result, including our test record. 19. Check the checkbox for our test record, plus another record where the item is not checked out. 20. Click the Place hold button to place holds on all of our selected records. You should only see the hold fee message above our test record. 21. In your staff interface tab, test setting HoldFeeMode to the other values and confirm the hold message shows on the OPAC as expected. 22. Confirm tests pass t/db_dependent/Reserves/GetReserveFee.t Sponsored-by: Horowhenua Libraries Trust Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 03:42:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 01:42:29 +0000 Subject: [Koha-bugs] [Bug 31952] Sending an empty system preference search breaks layout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 03:42:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 01:42:35 +0000 Subject: [Koha-bugs] [Bug 31952] Sending an empty system preference search breaks layout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142576|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 142593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142593&action=edit Bug 31952: Fix broken layout on system pref search TO test: 1. Do an empty system pref search 2. Layout is broken. 3. Apply patch, restart_all 4. Do another empty system pref search, the layout should be fixed. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 03:44:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 01:44:03 +0000 Subject: [Koha-bugs] [Bug 31965] Put OpenID discovery doc URL in a system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Aleisha Amohia --- If Bug 31378 isn't far away I will wait for that and help you on that ticket. If we can't get that into Koha 22.11 then I'll revisit this. *** This bug has been marked as a duplicate of bug 31378 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 03:44:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 01:44:03 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz --- Comment #86 from Aleisha Amohia --- *** Bug 31965 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 03:51:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 01:51:14 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 03:51:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 01:51:20 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141474|0 |1 is obsolete| | --- Comment #13 from Aleisha Amohia --- Created attachment 142594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142594&action=edit Bug 31391: Request recalls and convert reserves on staff interface This enhancement adds the ability to place recalls via the staff interface by introducing a system preference, RecallsInterface, to configure where recalls can be placed. Recalls can either be placed via the OPAC, or the staff interface, or both. This is set to OPAC by default to be consistent with current behaviour. This enhancement also adds the ability to convert existing reserves to recalls easily via the staff interface. The reserve will be cancelled and a recall placed using the reserve's information. To test: 1) Update database and restart services 2) Enable UseRecalls and set the relevant recalls circulation rules 3) View the new RecallsInterface system preference. Confirm it is set to OPAC only by default 4) Check out Item A to Patron B. 5) Log into the OPAC as Patron A. Confirm you can place, view and cancel recalls as normal. 6) In the staff interface, set RecallsInterface to Staff interface only. 7) In the OPAC, confirm you can still view and cancel recalls, but can no longer place recalls. 8) In the staff interface, search for Item A and go to the Reserves tab. Place a reserve for Patron C. 9) Under the Priority column, select the dropdown and choose the recall option next to your reserve. 10) Click Update holds. Confirm when the page refreshes that your reserve has disappeared. 11) Go to the recalls tab. Confirm your reserve has been converted to a recall, and details like the patron, expiration, and pickup location have carried across to the recall. 12) On this recalls page, use the patron search to find Patron D. Test placing a record-level recall by keeping the 'recall next available item' checkbox. 13) When the page refreshes, confirm the recall was successfully placed with the correct details stored. 14) Repeat steps 12 and 13 with Patron E, this time place an item-level recall by choosing an item in the 'place a recall on a specific item' table. When selecting one of these items, the 'recall next available item' checkbox should de-select. 15) Set RecallsInterface back to OPAC only. Go back to the record and view the Recalls tab. 16) Confirm you cannot search for a patron to place a recall, but can still view and cancel recalls. Confirm you also cannot convert reserves to recalls. 17) Set RecallsInterface to both staff interface and OPAC. Confirm you can place recalls on both interfaces. 18) On the staff interface, test placing recalls that your circulation rules do not allow. For example, if 'recalls per record' is 1, ensure you're blocked from placing a second recall on a record for a patron. 19) Place a reserve for one of the patron's that already has a recall. Once complete, try to convert this reserve into a recall. Confirm you are blocked and shown a message that the hold cannot be converted to a recall. 20) Ensure tests pass t/db_dependent/Holds.t Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 03:56:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 01:56:50 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 03:56:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 01:56:55 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142586|0 |1 is obsolete| | --- Comment #23 from David Nind --- Created attachment 142595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142595&action=edit Bug 31692: Add Koha::Hold::change_type and unit tests To test: 1. prove t/db_dependent/Koha/Hold.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 03:57:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 01:57:01 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142587|0 |1 is obsolete| | --- Comment #24 from David Nind --- Created attachment 142596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142596&action=edit Bug 31692: Allow librarians to change hold type in staff client To test: 1. Apply patch 2. Add item level hold to a record/item, make sure patron has no other holds on that record 3. Go to /cgi-bin/koha/reserve/request.pl?biblionumber=xxx where xxx is the record you placed the hold for 4. Under "Existing holds" table, in "Details" column you should see "Only item " dropdown 5. Select "Next available" from the dropdown 6. Click Update hold(s) 7. Observe dropdown value has changed from "Only item " to "Next available" 8. Cancel the hold and add two item level holds 9. Under "Existing holds" table, in "Details" column you should see "Only item ", but no select dropdown Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 04:02:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 02:02:19 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #25 from David Nind --- I've signed off, as everything works as per the test plan. For step 8, I added two item level holds for the same patron - I hope that is what was required. My only suggestion would be to change the "Details" column label to "Hold type". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 04:15:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 02:15:42 +0000 Subject: [Koha-bugs] [Bug 31965] Put OpenID discovery doc URL in a system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 --- Comment #5 from David Cook --- (In reply to Aleisha Amohia from comment #4) > If Bug 31378 isn't far away I will wait for that and help you on that ticket. > > If we can't get that into Koha 22.11 then I'll revisit this. > Sounds like a plan to me. At the moment, I'm waiting on updated patches from Agustin. Hoping that he provides something ASAP, as I'm keen to see this get in. (I wrote a local generic OIDC client back in 2014 which I've carried all these years. If Bug 31378 doesn't get in, I'll just keep using it. That said, I have been thinking about implementing it as a Koha plugin. I wasn't planning on working on that until Feb/March 2023, but perhaps I could move up my schedule on that...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 04:20:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 02:20:10 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Keywords| |additional_work_needed --- Comment #31 from Tomás Cohen Arazi --- Tests are failing due to this: https://jenkins.koha-community.org/job/Koha_Master_D10/887/ Please provide patches for the tests. Best regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 04:32:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 02:32:21 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 04:59:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 02:59:10 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #87 from David Cook --- Comment on attachment 141807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141807 Bug 31378: Add Auth mojo plugin Review of attachment 141807: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=31378&attachment=141807) ----------------------------------------------------------------- ::: Koha/REST/Plugin/Auth.pm @@ +83,5 @@ > + 'auth.session' => sub { > + my ( $c, $patron ) = @_; > + my $userid = $patron->userid; > + my $cardnumber = $patron->cardnumber; > + my $cgi = CGI->new; I don't think that we should be using the CGI module in the Mojolicious REST API, since we're not using CGI. This is hacky. @@ +89,5 @@ > + $cgi->param( userid => $userid ); > + $cgi->param( cardnumber => $cardnumber ); > + $cgi->param( auth_client_login => 1 ); > + > + my ( $status, $cookie, $session_id ) = C4::Auth::check_api_auth($cgi); This is a suboptimal design for at least a couple of reasons: 1) it requires a CGI object; 2) it creates a session for the API interface rather than the OPAC/Staff interfaces; 3) it's not to purpose - we're not checking auth. We know that we're just creating a new session. I've been saying for years that we need to standardize session creation, and it's still true. In the meantime, a minimal session can be created as simply as this: $session->param( 'number', $patron->borrowernumber ); $session->param( 'id', $patron->userid ); $session->param( 'cardnumber', $patron->cardnumber ); $session->param( 'firstname', $patron->firstname ); $session->param( 'surname', $patron->surname ); $session->param( 'branch', $patron->branchcode ); $session->param( 'branchname', $patron->library->branchname ); $session->param( 'flags', $patron->flags ); $session->param( 'emailaddress', $patron->email ); $session->param( 'ip', $session->remote_addr() ); $session->param( 'lasttime', time() ); $session->param( 'interface', $type); Then you can either pass the $session object or the session ID as the return value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 05:03:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 03:03:59 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #88 from David Cook --- (In reply to David Cook from comment #87) > I've been saying for years that we need to standardize session creation, and > it's still true. Recently, I did a little patch for that at Bug 31050, but I haven't had an urgent reason to continue on it. It would be perfect for a situation like this though. (Of course, I thought of it while working on Koha plugins, other auth solutions, etc.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 05:07:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 03:07:37 +0000 Subject: [Koha-bugs] [Bug 31965] Put OpenID discovery doc URL in a system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 --- Comment #6 from David Cook --- (In reply to David Cook from comment #5) > (I wrote a local generic OIDC client back in 2014 which I've carried all > these years. If Bug 31378 doesn't get in, I'll just keep using it. That > said, I have been thinking about implementing it as a Koha plugin. I wasn't > planning on working on that until Feb/March 2023, but perhaps I could move > up my schedule on that...) The one thing a Koha plugin can't do is an OIDC logout, but I don't think the googleopenidconnect can handle that either anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 05:14:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 03:14:39 +0000 Subject: [Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 05:14:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 03:14:43 +0000 Subject: [Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #4 from Aleisha Amohia --- Created attachment 142597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142597&action=edit Bug 31631: (follow-up) Use CalculateFundValuesIncludingTax when modifying existing order This patch depends on Bug 31840. To test: 1) Edit an order and increase the price so that you would expect it to trigger a warning that you will exceed the amount allowed for this Fund 2) Confirm the warning is triggered -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 05:15:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 03:15:09 +0000 Subject: [Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #5 from Aleisha Amohia --- Ready for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 07:14:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 05:14:50 +0000 Subject: [Koha-bugs] [Bug 31966] New: Checkout / CheckIn book using restful api Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31966 Bug ID: 31966 Summary: Checkout / CheckIn book using restful api Change sponsored?: --- Product: Koha Version: 22.05 Hardware: PC OS: Linux Status: NEW Severity: new feature Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: ashanfarhan at gmail.com CC: tomascohen at gmail.com I am developing an android application using Koha Restful API. the issue I am facing is that I cannot find anything API for item checkout(book issue) or item checkin(book return). I have installed the koha on ubuntu(Linux) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 08:07:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 06:07:08 +0000 Subject: [Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142580|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 142598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142598&action=edit Bug 31694: (follow-up) Further improve translatability To test: * Add rules fo different modules and with different settings * Verify the saved module description for a saved rule matches the pull down * Verify the saved filter matches the pull downs (especially for source and patron category) Also: * Renames 'User category' to 'Patron category' * Remove some values from translations, that shouldn't be translated, like value attributs for options. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 08:13:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 06:13:16 +0000 Subject: [Koha-bugs] [Bug 15500] Add FRBRized view to OPAC & staff interface results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15500 --- Comment #8 from Jonathan Field --- Thanks Heather, that's interesting. The communication we had was:- "In line with the British Library and in order to future proof our records, BDS plans to move to include FAST and ISNI in our records as of the 1st of October 2022.". BDS are the largest supplier of MARC records in the UK. The British Library ... well .. they're the British Library! It will be interesting to see where this goes. Sorry, slightly off-topic now if this isn't directly related to FRBR. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 08:28:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 06:28:36 +0000 Subject: [Koha-bugs] [Bug 31967] New: Search terms retained in header search for details page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 Bug ID: 31967 Summary: Search terms retained in header search for details page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 26247 added a system preference to manage the Retaining of search terms in header search. But this does not work if there is only one match and you go directly to details page. This needs to be fixed in Javascript : https://git.koha-community.org/Koha-community/Koha/src/commit/b0cf6c087b9e23467b98faecd3eac1ec0d6bc968/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt#L1953 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 08:28:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 06:28:44 +0000 Subject: [Koha-bugs] [Bug 31967] Search terms retained in header search for details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26247 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 [Bug 26247] Search terms retained in header search creates UX inconsistency -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 08:28:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 06:28:44 +0000 Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31967 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 [Bug 31967] Search terms retained in header search for details page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 08:28:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 06:28:55 +0000 Subject: [Koha-bugs] [Bug 31967] Search terms retained in header search for details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED QA Contact|testopia at bugs.koha-communit |fridolin.somers at biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 08:40:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 06:40:15 +0000 Subject: [Koha-bugs] [Bug 31966] Checkout / CheckIn book using restful api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31966 Ahsan Farhan changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Severity|new feature |enhancement -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 08:45:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 06:45:32 +0000 Subject: [Koha-bugs] [Bug 31967] Search terms retained in header search for details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27697 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 08:45:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 06:45:32 +0000 Subject: [Koha-bugs] [Bug 27697] Opening bibliographic record page prepopulates search bar text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27697 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31967 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 08:46:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 06:46:52 +0000 Subject: [Koha-bugs] [Bug 31609] JavaScript error on Additional contents main page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 --- Comment #13 from Marcel de Rooy --- Confirming that I do not see the error either anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 08:47:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 06:47:27 +0000 Subject: [Koha-bugs] [Bug 31609] JavaScript error on Additional contents main page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 08:47:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 06:47:31 +0000 Subject: [Koha-bugs] [Bug 31609] JavaScript error on Additional contents main page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142574|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy --- Created attachment 142599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142599&action=edit Bug 31609: JavaScript error on Additional contents main page This patch makes a minor modification to the JavaScript on the Additional contents page to prevent an error when there are no tabs present on the page. The JS needs an additional check so that it doesn't run when there are no tabs. To test you should have more than one language installed. - Before the patch, you would see a JavaScript error in the console: "Uncaught TypeError: can't access property "hash", firstTab[0] is undefined." - Apply the patch and go to Tools -> Additional contents. - With the patch applied there should be no error on the additional contents main page. - Try creating or editing additional contents entries to confirm that the interface still works correctly. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 08:49:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 06:49:14 +0000 Subject: [Koha-bugs] [Bug 31967] Search terms retained in header search when only one result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Search terms retained in |Search terms retained in |header search for details |header search when only one |page |result -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 08:53:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 06:53:54 +0000 Subject: [Koha-bugs] [Bug 31967] Search terms retained in header search when only one result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 08:53:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 06:53:58 +0000 Subject: [Koha-bugs] [Bug 31967] Search terms retained in header search when only one result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 --- Comment #1 from Fridolin Somers --- Created attachment 142600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142600&action=edit Bug 31967: Search terms retained in header search when only one result Bug 26247 added a system preference to manage the Retaining of search terms in header search. But this does not work if there is only one match and you go directly to details page. Test plan : 1) Set system preference RetainCatalogSearchTerms to "Don't retain" 2) Perform a search leading to a single result. For example in KTD the ISBN 1932100083 => Without patch search bar is populated with search terms => With patch search bar is not populated with search terms -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 08:56:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 06:56:27 +0000 Subject: [Koha-bugs] [Bug 31967] Search terms retained in header search when only one result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 --- Comment #2 from Fridolin Somers --- Some librarians reported this is reaaaaaaally important since they search by scanning ISBN or item barcode. Retaining search terms does not allow to scan another barcode directly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 08:59:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 06:59:28 +0000 Subject: [Koha-bugs] [Bug 31196] Key "default_value_for_mod_marc-" cleared from cache but never set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31196 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 09:43:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 07:43:21 +0000 Subject: [Koha-bugs] [Bug 31967] Search terms retained in header search when only one result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 09:43:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 07:43:24 +0000 Subject: [Koha-bugs] [Bug 31967] Search terms retained in header search when only one result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142600|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 142601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142601&action=edit Bug 31967: Search terms retained in header search when only one result Bug 26247 added a system preference to manage the Retaining of search terms in header search. But this does not work if there is only one match and you go directly to details page. Test plan : 1) Set system preference RetainCatalogSearchTerms to "Don't retain" 2) Perform a search leading to a single result. For example in KTD the ISBN 1932100083 => Without patch search bar is populated with search terms => With patch search bar is not populated with search terms Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 11:18:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 09:18:16 +0000 Subject: [Koha-bugs] [Bug 31196] Key "default_value_for_mod_marc-" cleared from cache but never set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31196 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 11:18:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 09:18:21 +0000 Subject: [Koha-bugs] [Bug 31196] Key "default_value_for_mod_marc-" cleared from cache but never set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31196 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137895|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 142602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142602&action=edit Bug 31196: Remove 'default_value_for_mod_marc-' clear_from_cache calls We are seeing the following lines several times in the codebase $cache->clear_from_cache("default_value_for_mod_marc-"); But values are never set for this key. Test plan: Ask you, "Is the above correct?" Use the correct 'git grep' and 'git log' and confirm the assertion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 11:18:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 09:18:25 +0000 Subject: [Koha-bugs] [Bug 31968] New: Problems with MARC staging/import Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31968 Bug ID: 31968 Summary: Problems with MARC staging/import Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org I'm having various problems with importing staged MARC records on 22.05.05. One example: I have staged a file and click on "Import this batch to the catalogue". The progress bar jumps to 31% but then it stops and goes no further. In the background there are lots of calls to /cgi-bin/koha/tools/background-job-progress.pl?jobID=, but the last one gives a 500 error. This is when the progress bar stops. The job is actually finished after a while, but the interface never updates. I think these are the relevant errors in the logs: ==> /var/log/koha/koha/intranet-access.log <== ... a.b.c.d - - [25/Oct/2022:10:46:39 +0200] "GET /cgi-bin/koha/tools/background-job-progress.pl?jobID= HTTP/1.1" 200 57 a.b.c.d - - [25/Oct/2022:10:46:40 +0200] "GET /cgi-bin/koha/tools/background-job-progress.pl?jobID= HTTP/1.1" 200 57 a.b.c.d - - [25/Oct/2022:10:46:40 +0200] "GET /cgi-bin/koha/tools/background-job-progress.pl?jobID= HTTP/1.1" 200 57 ==> /var/log/koha/koha/intranet-error.log <== [2022/10/25 10:47:50] [WARN] binmode() on closed filehandle _GEN_70 at /usr/share/koha/lib/C4/Templates.pm line 126. CGI::Compile::ROOT::usr_share_koha_intranet_cgi_2dbin_tools_manage_2dmarc_2dimport_2epl::__ANON__ /usr/share/koha/intranet/cgi-bin/tools/manage-marc-import.pl (331) [2022/10/25 10:47:50] [WARN] print() on closed filehandle _GEN_70 at /usr/share/koha/lib/C4/Output.pm line 285. CGI::Compile::ROOT::usr_share_koha_intranet_cgi_2dbin_tools_manage_2dmarc_2dimport_2epl::__ANON__ /usr/share/koha/intranet/cgi-bin/tools/manage-marc-import.pl (331) ==> /var/log/koha/koha/plack-intranet-error.log <== [2022/10/25 10:47:50] [WARN] seek() on closed filehandle _GEN_70 at /usr/share/perl5/CGI/Emulate/PSGI.pm line 34. ==> /var/log/koha/koha/intranet-access.log <== a.b.c.d - - [25/Oct/2022:10:46:41 +0200] "GET /cgi-bin/koha/tools/background-job-progress.pl?jobID= HTTP/1.1" 500 118732 The only related bug I can find is Bug 15032, which mentions "binmode() on closed filehandle" way back in 2015. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 12:16:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 10:16:40 +0000 Subject: [Koha-bugs] [Bug 31969] New: Options for cleanup_database.pl to remove finished jobs from the background job queue Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31969 Bug ID: 31969 Summary: Options for cleanup_database.pl to remove finished jobs from the background job queue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: bjorn.nylen at ub.lu.se QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The background jobs queue will need purging of finished jobs. Bug 31629 focuses on the elastic indexing jobs but the table will fill up with other types of jobs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 12:19:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 10:19:31 +0000 Subject: [Koha-bugs] [Bug 31969] Options for cleanup_database.pl to remove finished jobs from the background job queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31969 Björn Nylén changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |bjorn.nylen at ub.lu.se |ity.org | --- Comment #1 from Björn Nylén --- Created attachment 142603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142603&action=edit Bug 31969 - Add options for cleanup_database.pl to remove finished jobs from the background job queue -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 12:20:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 10:20:36 +0000 Subject: [Koha-bugs] [Bug 31969] Options for cleanup_database.pl to remove finished jobs from the background job queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31969 --- Comment #2 from Björn Nylén --- Bug 31969: Add background queue options to cleanup_database This patch adds background queue options to cleanup_database.pl to allow for purging completed background jobs. --bg-jobs DAYS Purge all finished background jobs this many days old. Defaults to 1 if no DAYS provided. --bg-type TYPE What type of background job to purge. Defaults to "update_elastic_index" if omitted Specifying "all" will purge all types. Repeatable. To test: 1 - Enable elastic search in Koha 2 - perl misc/maintenance/touch_all_items.pl 3 - Generate an number of diffrent types of bg-jobs (eg batch_hold_cancel, batch_biblio_record_deletion, batch_item_record_deletion) 4 - Check db and note there are a bunch of diffrent jobs 5 - Update to make them old UPDATE background_jobs SET enqued_on = '2022-10-01 00:00:00', status='finished' 6 - perl misc/cronjobs/cleanup_database.pl 7 - Note bg-jobs entry shows in help 8 - perl misc/cronjobs/cleanup_database.pl --bg-jobs 1 -v 9 - Note that elasticqueue would have been cleared 10 - perl misc/cronjobs/cleanup_database.pl --bg-jobs 1 -v --confirm 11 - Note that number of entries deleted is reported 12 - Attempt to clear other job types, including "all" eg perl misc/cronjobs/cleanup_database.pl --bg-jobs 1 --bg-type batch_item_record_deletion -v --confirm perl misc/cronjobs/cleanup_database.pl --bg-jobs 1 --bg-type all -v --confirm 13 - Confirm in staff interface that jobs are gone: http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl (Uncheck 'Current jobs only') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 12:21:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 10:21:57 +0000 Subject: [Koha-bugs] [Bug 31969] Options for cleanup_database.pl to remove finished jobs from the background job queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31969 Björn Nylén changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31629 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 12:21:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 10:21:57 +0000 Subject: [Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629 Björn Nylén changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31969 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 12:26:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 10:26:36 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #396 from Jonathan Druart --- Created attachment 142604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142604&action=edit Bug 30952: Fix selenium/administration_tasks.t Cannot wait more for element '//input[@type="submit"]' to be visible at /kohadevbox/koha/t/lib/Selenium.pm line 189. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 12:26:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 10:26:45 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #397 from Jonathan Druart --- Created attachment 142605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142605&action=edit Bug 30952: Fix selenium/basic_workflow.t Error while executing command: no such element: Unable to locate element: //*[@id="circ_returns_checkin"]/div[2]/div[1]/div[2]/button at /usr/share/perl5/Selenium/Remote/Driver.pm line 411. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 12:28:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 10:28:32 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 12:29:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 10:29:05 +0000 Subject: [Koha-bugs] [Bug 29768] hidepatronname hides guarantor name on borrower edit screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139180|0 |1 is obsolete| | --- Comment #20 from Emmi Takkinen --- Created attachment 142606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142606&action=edit Bug 29768: Do not hide guarantor name from memberentry.pl Syspref "hidepatronname" currently hides guarantors name on memberentry.pl. This is inconsistent since name isn't hidden e.g. on moremember.pl and staff can already see patrons other personal information during edit. To test: 1) Disable syspref "hidepatronname" 2) Edit guarantee patrons information => Field "Guarantor" only shows guarantors cardnumber (or is empty if guarantor has no cardnumber) 3) Apply patch => Guarantors name is now displayed (as a hyperlink) Also confirm hidepatronname still works as expected on other pages (holds table, items detail page etc.). Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 12:29:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 10:29:41 +0000 Subject: [Koha-bugs] [Bug 29768] hidepatronname hides guarantor name on borrower edit screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139181|0 |1 is obsolete| | --- Comment #21 from Emmi Takkinen --- Created attachment 142607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142607&action=edit Bug 29768: Fix patron name displays and hyperlinks Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 12:56:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 10:56:16 +0000 Subject: [Koha-bugs] [Bug 31968] Problems with MARC staging/import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31968 --- Comment #1 from Magnus Enger --- Forgot to mention that this does not always happen when processing staged records, only every second or third time I try. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 13:00:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 11:00:37 +0000 Subject: [Koha-bugs] [Bug 30666] Holds reminder cronjob (holds_reminder.pl) uses DateTime::subtract wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30666 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 13:10:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 11:10:54 +0000 Subject: [Koha-bugs] [Bug 31812] Add yellow to stage imports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812 --- Comment #9 from Martin Renvoize --- (In reply to Katrin Fischer from comment #7) > I feel like the upload file button should be yellow too, as we only see this > one at first, what do you think? Looks like this was missed before push? Perhaps a new bug so we don't lose it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 13:25:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 11:25:21 +0000 Subject: [Koha-bugs] [Bug 31970] New: background_jobs_purge.pl to purge background jobs queue Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31970 Bug ID: 31970 Summary: background_jobs_purge.pl to purge background jobs queue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: frederic at tamil.fr QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 13:32:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 11:32:33 +0000 Subject: [Koha-bugs] [Bug 31970] background_jobs_purge.pl to purge background jobs queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31970 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- Hi Frederic, i think this is a duplicate to a new bug from yesterday: bug 31969 *** This bug has been marked as a duplicate of bug 31969 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 13:32:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 11:32:33 +0000 Subject: [Koha-bugs] [Bug 31969] Options for cleanup_database.pl to remove finished jobs from the background job queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31969 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #3 from Katrin Fischer --- *** Bug 31970 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 13:44:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 11:44:01 +0000 Subject: [Koha-bugs] [Bug 31960] Information on job detail view is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 14:07:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 12:07:26 +0000 Subject: [Koha-bugs] [Bug 31960] Information on job detail view is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 14:07:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 12:07:30 +0000 Subject: [Koha-bugs] [Bug 31960] Information on job detail view is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 --- Comment #2 from Owen Leonard --- Created attachment 142608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142608&action=edit Bug 31960: Information on job detail view is misaligned This patch updates the structure of the background jobs template so that HTML processed in the report includes is well styled. The patch does this by breaking the report and detail includes out of the fieldset and putting them in a separate section. This patch also adds the page-section class to the table view of current and past background jobs. Note: The patch includes indentation changes, so please ignore whitespace when viewing the diff. To test, apply the patch and go to Administration -> Manage jobs. - The table of jobs (even if empty) should be contained in a page-section style white box. - Test various processes which trigger a backgroud job: - Batch item modification - Batch item deletion - Batch hold deletion - Batch record modification ... etc. - After each process has been started, view the details of the job. - The information about the job shold be displayed well, with separate sections for "Report" and "Detailed messages." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 14:08:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 12:08:23 +0000 Subject: [Koha-bugs] [Bug 29768] hidepatronname hides guarantor name on borrower edit screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #22 from Emmi Takkinen --- (In reply to Joonas Kylmälä from comment #19) > The hyperlink is not shown in the latest patch version, the > hide_patron_infos_if_needed check was reintroduced in this version of the > patch, it was the one you removed earlier. So it seems (how on earth it got there?), removed it again in latest patch. > Also, I'm thinking whether > introducing a "no_link" variable or equivalent in addition to the "no_html" > would be a good idea? Reading your last patch and patron-title.inc in more > detail the patron's title (Mr, Dr, etc.) seems to be enclosed in a span, > which would be valid inside hyperlink, however a hyperlink wouldn't be valid > inside a hyperlink. Hmm, I guess this could be useful. Feel free to add it if you have some sort idea how to implement it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 14:14:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 12:14:07 +0000 Subject: [Koha-bugs] [Bug 31970] background_jobs_purge.pl to purge background jobs queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31970 --- Comment #2 from Frédéric Demians --- Created attachment 142609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142609&action=edit Bug 31970 - background_jobs_purge.pl to purge background jobs queue With this script, you can see the state of the background jobs queue, finished jobs only, and delete entries, globally, or by job type. Koha::BackgroundJob is extended with a purge() method which could be used from Koha WUI. TO TEST : - On a Koha instance with a populated background_jobs table. - Go in misc/cronjobs directory. - ./background_jobs_purge.pl Display script usage. List of job's types is displayed. - ./background_jobs_purge.pl all 2 --verbose Display a list of jobs (all types) to be deleted. - ./background_jobs_purge.pl all 2 --verbose --confirm Display a list of jobs (all types) that have been deleted. - ./background_jobs_purge.pl all 2 --verbose --confirm Display a message: No job to purge - ./background_jobs_purge.pl update_elastic_index 0 -v Display a list of all update_elastic_index job - ./background_jobs_purge.pl update_elastic_index 0 -v -c Display a list of all update_elastic_index job that have been delete. This could be run several time each day... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 14:16:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 12:16:55 +0000 Subject: [Koha-bugs] [Bug 31970] background_jobs_purge.pl to purge background jobs queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31970 --- Comment #3 from Frédéric Demians --- Katrin, yes, it is! Even it's a different approach. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 14:19:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 12:19:00 +0000 Subject: [Koha-bugs] [Bug 31971] New: SIP server rejects passwords ending in non-alphanumeric characters Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31971 Bug ID: 31971 Summary: SIP server rejects passwords ending in non-alphanumeric characters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1 - Set a patron's password to secret* 2 - Attempt a patron information request via the sip clip emulator: perl misc/sip_cli_emulator.pl -su term1 -sp term1 -l CPL -a localhost -p 6001 -m patron_information --patron ballard --password secret* 3 - It fails? 4 - Set password to secret*s 5 - Repeat perl misc/sip_cli_emulator.pl -su term1 -sp term1 -l CPL -a localhost -p 6001 -m patron_information --patron ballard --password secret*s 6 - It succeeeds Offending line(s) appears to be: 366 $buffer =~ s/^\s*[^A-z0-9]+//s; 367 # Every line must start with a "real" character. Not whitespace, control chars, etc. 368 $buffer =~ s/[^A-z0-9]+$//s; 369 370 # Same for the end. Note this catches the problem some clients have sending empty fields at the end, like ||| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 14:19:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 12:19:34 +0000 Subject: [Koha-bugs] [Bug 31971] SIP server rejects passwords ending in non-alphanumeric characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31971 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com, | |magnus at libriotech.no, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 14:21:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 12:21:02 +0000 Subject: [Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 --- Comment #32 from Owen Leonard --- > https://lists.katipo.co.nz/pipermail/koha/2022-October/058585.html Is it a known issue that searching fails? I see this message: "An error has occurred while searching: We could not complete your search due to a temporary problem. Please try again later." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 14:24:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 12:24:35 +0000 Subject: [Koha-bugs] [Bug 31968] Problems with MARC staging/import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31968 --- Comment #2 from Magnus Enger --- Now the same thing happened after I clicked "Stage for import". The progress goes up to some percentage, and then stops, because background-job-progress.pl returns a 500 error: ==> /var/log/koha/koha/intranet-access.log <== ... a.b.c.d - - [25/Oct/2022:14:02:17 +0200] "GET /cgi-bin/koha/tools/background-job-progress.pl?jobID= HTTP/1.1" 200 67 a.b.c.d - - [25/Oct/2022:14:02:18 +0200] "GET /cgi-bin/koha/tools/background-job-progress.pl?jobID= HTTP/1.1" 200 68 a.b.c.d - - [25/Oct/2022:14:02:18 +0200] "GET /cgi-bin/koha/tools/background-job-progress.pl?jobID= HTTP/1.1" 200 68 a.b.c.d - - [25/Oct/2022:14:02:19 +0200] "GET /cgi-bin/koha/tools/background-job-progress.pl?jobID= HTTP/1.1" 200 68 ==> /var/log/koha/koha/intranet-error.log <== [2022/10/25 14:02:19] [WARN] binmode() on closed filehandle _GEN_60 at /usr/share/koha/lib/C4/Templates.pm line 126. CGI::Compile::ROOT::usr_share_koha_intranet_cgi_2dbin_tools_manage_2dmarc_2dimport_2epl::__ANON__ /usr/share/koha/intranet/cgi-bin/tools/manage-marc-import.pl (331) [2022/10/25 14:02:19] [WARN] print() on closed filehandle _GEN_60 at /usr/share/koha/lib/C4/Output.pm line 285. CGI::Compile::ROOT::usr_share_koha_intranet_cgi_2dbin_tools_manage_2dmarc_2dimport_2epl::__ANON__ /usr/share/koha/intranet/cgi-bin/tools/manage-marc-import.pl (331) ==> /var/log/koha/koha/plack-intranet-error.log <== [2022/10/25 14:02:19] [WARN] seek() on closed filehandle _GEN_60 at /usr/share/perl5/CGI/Emulate/PSGI.pm line 34. ==> /var/log/koha/koha/intranet-access.log <== a.b.c.d - - [25/Oct/2022:14:02:19 +0200] "GET /cgi-bin/koha/tools/background-job-progress.pl?jobID= HTTP/1.1" 200 68 a.b.c.d - - [25/Oct/2022:14:02:20 +0200] "GET /cgi-bin/koha/tools/background-job-progress.pl?jobID= HTTP/1.1" 200 80 a.b.c.d - - [25/Oct/2022:14:02:20 +0200] "GET /cgi-bin/koha/tools/background-job-progress.pl?jobID= HTTP/1.1" 200 68 a.b.c.d - - [25/Oct/2022:14:02:21 +0200] "GET /cgi-bin/koha/tools/background-job-progress.pl?jobID= HTTP/1.1" 200 68 a.b.c.d - - [25/Oct/2022:14:02:21 +0200] "GET /cgi-bin/koha/tools/background-job-progress.pl?jobID= HTTP/1.1" 200 68 ==> /var/log/koha/koha/plack-intranet-error.log <== [2022/10/25 14:02:22] [WARN] commit ineffective with AutoCommit enabled at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1621. [2022/10/25 14:02:22] [WARN] seek() on closed filehandle _GEN_134 at /usr/share/perl5/CGI/Emulate/PSGI.pm line 34. ==> /var/log/koha/koha/intranet-access.log <== a.b.c.d - - [25/Oct/2022:14:02:22 +0200] "GET /cgi-bin/koha/tools/background-job-progress.pl?jobID= HTTP/1.1" 500 118732 The file was actually staged, so the problem seems to be background-job-progress.pl returning a 500 error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 14:35:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 12:35:57 +0000 Subject: [Koha-bugs] [Bug 31972] New: More than 20 Marc overlay rules Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31972 Bug ID: 31972 Summary: More than 20 Marc overlay rules Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: klas.blomberg at skovde.se QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 142610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142610&action=edit Screenshot of Marc overlay rules Create more than 20 Marc overlay rules The first 20 rules looks ok, rule 21 and upwards shows the coded value under Filter, and presets are empty Rules above rule 20 are not editable, and can't be deleted - so you have to delete rules with a lower value until the unwanted rules gets a value below 21 It seems like this is a displayproblem that doesn't affect performance -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 14:42:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 12:42:56 +0000 Subject: [Koha-bugs] [Bug 31972] More than 20 Marc overlay rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31972 --- Comment #1 from Katrin Fischer --- Interesting, I was working on bug 31694 yesterday, adding on to Caroline's work. Maybe it would help at least with the code/description issue? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 14:46:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 12:46:06 +0000 Subject: [Koha-bugs] [Bug 31609] JavaScript error on Additional contents main page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 14:46:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 12:46:08 +0000 Subject: [Koha-bugs] [Bug 31609] JavaScript error on Additional contents main page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 --- Comment #15 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 14:59:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 12:59:45 +0000 Subject: [Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #33 from Caroline Cyr La Rose --- (In reply to Owen Leonard from comment #32) > > https://lists.katipo.co.nz/pipermail/koha/2022-October/058585.html > > Is it a known issue that searching fails? I see this message: "An error has > occurred while searching: We could not complete your search due to a > temporary problem. Please try again later." I also had this problem. - Entered "Meeting" in the search box at the top of the main page - Pressed "Enter" - Got a message "An error has occurred while searching: We could not complete your search due to a temporary problem. Please try again later." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 15:23:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 13:23:35 +0000 Subject: [Koha-bugs] [Bug 16559] [%% ... %%] should not be picked for translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16559 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #8 from Caroline Cyr La Rose --- Still valid. I just came across one in marc-overlay-rules.tt #. %1$s: END #. %2$s: UNLESS Koha.Preference( 'MARCOverlayRules' ) #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:58 #, c-format msgid "%s %s [%% SET pref_MARCOverlayRules_link = '" msgstr "%s %s [%% SET pref_MARCOverlayRules_link = '" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 15:31:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 13:31:04 +0000 Subject: [Koha-bugs] [Bug 28669] Marc field 942 is overwritten when importing a new record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28669 Klas Blomberg changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #3 from Klas Blomberg --- This is finally solved with Marc overlay rules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 15:47:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 13:47:20 +0000 Subject: [Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Caroline Cyr La Rose --- I don't think we're quite there yet :/ Without the patch, in English, when we select let's say 'Add and append' and save the rule, the words 'Add and append' still appear in the preset column of the saved rule. With the patch, the preset is saved as 'Custom' 1. Without the patch, go to Administration > MARC overlay rules 2. Enter the following rule - Module: Source - Filter: Staged MARC import - Tag: 6.. - Preset: Add and append 3. Click 'Add rule' --> In the 'Preset' column, the saved rule says 'Add and append' 4. Delete the rule (click 'Delete' and confirm) 5. Apply the patch 6. Redo steps 2-3 --> In the 'Preset' column, the saved rule says 'Custom' I also noticed, after I applied the patch and updated my po's (`gulp po:update --lang fr-CA`) that I still had two strings "User category" #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:159 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:161 #, c-format msgid "User category" msgstr "Catégorie d'utilisateurs" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 15:56:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 13:56:34 +0000 Subject: [Koha-bugs] [Bug 31196] Key "default_value_for_mod_marc-" cleared from cache but never set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31196 --- Comment #4 from Marcel de Rooy --- You should have a look at bug 23463 to know who forgot to remove them? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 15:58:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 13:58:39 +0000 Subject: [Koha-bugs] [Bug 31196] Key "default_value_for_mod_marc-" cleared from cache but never set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31196 --- Comment #5 from Marcel de Rooy --- misc/release_notes/release_notes_16_11_00.md:- [[13074]](http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074) C4::Items::_build_default_values_for_mod_marc should use Koha::Cache => Interesting difference: the sub uses default_values but the key is called default_value This was refactored to nowhere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 15:59:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 13:59:14 +0000 Subject: [Koha-bugs] [Bug 31196] Key "default_value_for_mod_marc-" cleared from cache but never set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31196 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 15:59:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 13:59:18 +0000 Subject: [Koha-bugs] [Bug 31196] Key "default_value_for_mod_marc-" cleared from cache but never set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31196 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142602|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 142611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142611&action=edit Bug 31196: Remove 'default_value_for_mod_marc-' clear_from_cache calls We are seeing the following lines several times in the codebase $cache->clear_from_cache("default_value_for_mod_marc-"); But values are never set for this key. Test plan: Ask you, "Is the above correct?" Use the correct 'git grep' and 'git log' and confirm the assertion. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 15:59:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 13:59:41 +0000 Subject: [Koha-bugs] [Bug 31196] Key "default_value_for_mod_marc-" cleared from cache but never set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31196 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:00:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:00:38 +0000 Subject: [Koha-bugs] [Bug 31196] Key "default_value_for_mod_marc-" cleared from cache but never set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31196 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Marcel de Rooy --- Taking the liberty to combine SO and QA here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:01:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:01:21 +0000 Subject: [Koha-bugs] [Bug 31196] Key "default_value_for_mod_marc-" cleared from cache but not set anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31196 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Key |Key |"default_value_for_mod_marc |"default_value_for_mod_marc |-" cleared from cache but |-" cleared from cache but |never set |not set anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:20:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:20:45 +0000 Subject: [Koha-bugs] [Bug 31196] Key "default_value_for_mod_marc-" cleared from cache but not set anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31196 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:20:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:20:48 +0000 Subject: [Koha-bugs] [Bug 31196] Key "default_value_for_mod_marc-" cleared from cache but not set anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31196 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:24:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:24:11 +0000 Subject: [Koha-bugs] [Bug 31897] New hook when indexing with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:25:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:25:19 +0000 Subject: [Koha-bugs] [Bug 31897] New hook when indexing with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897 --- Comment #8 from Marcel de Rooy --- $VAR1 = { 'cxn_pool' => 'Static', 'index_name' => 'koha_myclone', 'nodes' => [ 'localhost:9200' ] }; Result of Koha::SearchEngine::Elasticsearch->get_elasticsearch_params; You test that to determine if Elastic exists. Wrong test. Later you crash: Exception 'Koha::Exceptions::Elasticsearch::BadResponse' thrown 'Bad response received when submitting request to Elasticsearch' with details => No nodes are available: [http://localhost:9200], type => NoNodes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:26:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:26:06 +0000 Subject: [Koha-bugs] [Bug 31897] New hook when indexing with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897 --- Comment #9 from Marcel de Rooy --- $schema->storage->txn_rollback; Koha::Plugins::Methods->delete; Really, this is wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:28:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:28:43 +0000 Subject: [Koha-bugs] [Bug 15500] Add FRBRized view to OPAC & staff interface results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15500 --- Comment #9 from Heather --- Hi, Jonathan! That's great that FAST & ISNI will be included with other data (I hope *with* the other metadata!)--they would be valuable additions to the rest of the metadata. And this is kind of on topic--all identifying metadata is potentially useful if the FRBR clustering does end up operating like a profiled weighted search-match-cluster (rather than depending on one human-added control number field). And we're back on topic! The crowd goes wild!!:) --h2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:30:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:30:29 +0000 Subject: [Koha-bugs] [Bug 31894] Extend Hold hooks with more actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894 --- Comment #6 from Marcel de Rooy --- Created attachment 142612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142612&action=edit Bug 31894: (QA follow-up) Move rollbacks to the end Obvious fix. This test removed my method records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:30:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:30:54 +0000 Subject: [Koha-bugs] [Bug 31894] Extend Hold hooks with more actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #7 from Marcel de Rooy --- Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:36:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:36:30 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Keywords|rel_22_11_candidate |additional_work_needed --- Comment #100 from Jonathan Druart --- t/db_dependent/www/search_utf8.t .. 1/89 Link not found at /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 140. 139 $agent->follow_link_ok( { url_regex => qr/tools-home/i }, 'open tools module' ); 140 $agent->follow_link_ok( { text => 'Stage MARC records for import' }, 141 'go to stage MARC' ); Where is this link? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:39:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:39:10 +0000 Subject: [Koha-bugs] [Bug 22666] When using authority records in a bibliographic record, the order of the subfields is not sent over In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22666 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master CC| |tomascohen at gmail.com Version(s)| |22.11.00 released in| | --- Comment #5 from Tomás Cohen Arazi --- Patches pushed to master for 22.11. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:40:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:40:16 +0000 Subject: [Koha-bugs] [Bug 31894] Extend Hold hooks with more actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894 --- Comment #8 from Marcel de Rooy --- (In reply to Stefan Berndtsson from comment #4) > I can't say why all the others did it this way. My hooks were just copies of > the model used everywhere else. Ha. Do not assume that copy/paste creates correct code :) > I can reason about a situation where it will likely matter. If the plugin > forks/threads before doing its work, there is a chance that the originally > stored object has been changed after the hook is called, but before the > plugin has actually done its work. By fetching a new object, this is not the > case. This cannot be correct. The interval between the store and get_from_storage is before the first plugin is called. The result of get_from_storage is passed. > I also do remember having seen a situation where the state of $self after > store was not the same as the newly fetched object, but I can't recall how > or where this was the case. Thats correct. When you pass $self to the plugin, the plugin can change it since it is a reference. That is in line with the intention: @responses = Koha::Plugins->call($method, @args) Note: Pass your arguments as refs, when you want subsequent plugins to use the value updated by preceding plugins, provided that these plugins support that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:42:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:42:17 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #101 from Jonathan Druart --- t/db_dependent/www/batch.t is failing as well because of this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:45:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:45:04 +0000 Subject: [Koha-bugs] [Bug 31894] Extend Hold hooks with more actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894 --- Comment #9 from Marcel de Rooy --- This might be a different scenario: my $old_me = $self->_move_to_old; Koha::Plugins->call( 'after_hold_action', { action => 'cancel', payload => { hold => $old_me->get_from_storage } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:45:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:45:42 +0000 Subject: [Koha-bugs] [Bug 31966] Checkout / CheckIn book using restful api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31966 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard --- This sounds like a support request rather than a bug. Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Hopefully you've already seen the Koha documentation: http://koha-community.org/documentation/ You can also find options for paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:49:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:49:03 +0000 Subject: [Koha-bugs] [Bug 31894] Extend Hold hooks with more actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894 --- Comment #10 from Marcel de Rooy --- Since we only test this sub: sub after_hold_action { my ( $self, $params ) = @_; my $action = $params->{action}; my $hold = $params->{payload}->{hold}; Koha::Exception->throw( "after_hold_action called with action: $action, ref: " . ref($hold) ); } We wont really know what happens in the plugin in connection to different versions of $self.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:52:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:52:25 +0000 Subject: [Koha-bugs] [Bug 31894] Extend Hold hooks with more actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894 --- Comment #11 from Marcel de Rooy --- Created attachment 142613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142613&action=edit Bug 31894: (QA follow-up) Remove unneeded get_from_storage calls Test plan: Run test again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:53:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:53:00 +0000 Subject: [Koha-bugs] [Bug 31894] Extend Hold hooks with more actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894 --- Comment #12 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #11) > Test plan: > Run test again. It does not really help :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:54:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:54:39 +0000 Subject: [Koha-bugs] [Bug 31894] Extend Hold hooks with more actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #13 from Marcel de Rooy --- Stefan: Since I imagine that you have some real life plugin to connect to this hook, could you let me know the results of that plugin with the follow-ups here? The test only does not prove much. Changing status to reflect need for feedback -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:55:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:55:29 +0000 Subject: [Koha-bugs] [Bug 31894] Extend Hold hooks with more actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894 --- Comment #14 from Marcel de Rooy --- Two other actions have the same thing: resume and suspend. But they are outside the scope here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:56:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:56:41 +0000 Subject: [Koha-bugs] [Bug 31895] New Account hook when adding credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31895 --- Comment #5 from Marcel de Rooy --- We'll come back here after 31894, I propose. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:57:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:57:30 +0000 Subject: [Koha-bugs] [Bug 31896] New Recall hook when adding recall In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896 --- Comment #8 from Marcel de Rooy --- + $schema->storage->txn_rollback; + Koha::Plugins::Methods->delete; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:59:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:59:07 +0000 Subject: [Koha-bugs] [Bug 31896] New Recall hook when adding recall In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896 --- Comment #9 from Marcel de Rooy --- +sub after_recall_action { + my ( $self, $params ) = @_; + + my $action = $params->{action}; + my $recall = $params->{payload}->{recall}; + + Koha::Exception->throw( + "after_recall_action called with action: $action, ref: " . ref($recall) ); +} Yeah, I understand you doing that. It does not really test more than the thing was called. No blocker, just noting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 16:59:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 14:59:37 +0000 Subject: [Koha-bugs] [Bug 31896] New Recall hook when adding recall In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |Failed QA --- Comment #10 from Marcel de Rooy --- Please come back after 31894 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:20:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:20:45 +0000 Subject: [Koha-bugs] [Bug 31960] Information on job detail view is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:20:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:20:48 +0000 Subject: [Koha-bugs] [Bug 31960] Information on job detail view is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142608|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 142614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142614&action=edit Bug 31960: Information on job detail view is misaligned This patch updates the structure of the background jobs template so that HTML processed in the report includes is well styled. The patch does this by breaking the report and detail includes out of the fieldset and putting them in a separate section. This patch also adds the page-section class to the table view of current and past background jobs. Note: The patch includes indentation changes, so please ignore whitespace when viewing the diff. To test, apply the patch and go to Administration -> Manage jobs. - The table of jobs (even if empty) should be contained in a page-section style white box. - Test various processes which trigger a backgroud job: - Batch item modification - Batch item deletion - Batch hold deletion - Batch record modification ... etc. - After each process has been started, view the details of the job. - The information about the job shold be displayed well, with separate sections for "Report" and "Detailed messages." Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:28:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:28:50 +0000 Subject: [Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #56 from Frank Hansen --- (In reply to Katrin Fischer from comment #55) > hi Frank, could you maybe have a look at the new bugs in Blocks? bug 31924 > and bug 31925. Hi Katrin, Well 31924 is probably a Zebra related issue. I got the impression that linking of subject headings based on thesaurus already works with Zebra. It is at least that's what I thought when I read this in the authority-koha-indexdefs.xml file: Subject-heading-thesaurus:w Here is already a reference to 040$f which is a crucial part when it comes to other thesaurus. But I see that the linking does not work at all in Zebra. Here at Lund University, we are only using ElasticSearch. In fact, we Zebra is not running at all. So it is difficult for me to test Zebra in real life. I'n not an expert on Zebra. Probably the new subject-heading-thesaurus-conventions index needs to be set up in Zebra as well. I'm not 100% certain how to do that. As for 31925, that's the next step. We don't use AutoLinkBiblios because it doesn't work. We import the subject headings from different thesaurus from Royal Library (Libris). So for avoid 30280 to being too complex, I have focused on getting the thesaurus based subject heading linking to work. Since AutoLinkBiblios only creates LCSH subject headings we cannot use this. But it would be awesome to get it to work later on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:29:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:29:37 +0000 Subject: [Koha-bugs] [Bug 31973] New: Restore background color to message-style alerts Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31973 Bug ID: 31973 Summary: Restore background color to message-style alerts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 30952 We use

    for informational alerts, for instance to inform the user of some kind of successful action or to provide information. In the redesign, these .message alerts have a white background, making them hard to see and not much different than the standard page-section. I think we should restore the old background color. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:29:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:29:37 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31973 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31973 [Bug 31973] Restore background color to message-style alerts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:41:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:41:35 +0000 Subject: [Koha-bugs] [Bug 31973] Restore background color to message-style alerts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31973 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:41:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:41:39 +0000 Subject: [Koha-bugs] [Bug 31973] Restore background color to message-style alerts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31973 --- Comment #1 from Owen Leonard --- Created attachment 142615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142615&action=edit Bug 31973: Restore background color to message-style alerts This patch restores the background color to message-style alerts, those which use the markup
    . These alerts should stand out more to the user. To test, apply the patch and rebuild the staff interface CSS. - Test areas which use the message-style dialog. Perhaps the easiest example is to try to view a bibliographic record which doesn't exist: /cgi-bin/koha/catalogue/detail.pl?biblionumber=1234567890 - It can also be found as a confirmation when deleting a basket in Acquisitions, deleting a patron attribute type in Administration, updating a Z39.50 server in Administration, etc. - Confirm that the alert looks correct and is suitable visible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:49:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:49:04 +0000 Subject: [Koha-bugs] [Bug 31913] Use Modals in Rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31913 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30952 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:49:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:49:04 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31913 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31913 [Bug 31913] Use Modals in Rotating collections -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:54:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:54:44 +0000 Subject: [Koha-bugs] [Bug 31772] Some stock rotation pages could be converted to modals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31772 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30952 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:54:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:54:44 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31772 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31772 [Bug 31772] Some stock rotation pages could be converted to modals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:55:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:55:49 +0000 Subject: [Koha-bugs] [Bug 31809] Should actions on result list stick to the bottom? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31809 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30952 | --- Comment #2 from Owen Leonard --- This is not a regression and also not in the redesign specs, so I'm removing the 30952 dependency. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:55:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:55:49 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31809 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31809 [Bug 31809] Should actions on result list stick to the bottom? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:57:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:57:51 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142164|0 |1 is obsolete| | Attachment #142165|0 |1 is obsolete| | Attachment #142166|0 |1 is obsolete| | Attachment #142167|0 |1 is obsolete| | Attachment #142168|0 |1 is obsolete| | Attachment #142169|0 |1 is obsolete| | Attachment #142170|0 |1 is obsolete| | Attachment #142171|0 |1 is obsolete| | Attachment #142172|0 |1 is obsolete| | Attachment #142173|0 |1 is obsolete| | Attachment #142174|0 |1 is obsolete| | Attachment #142175|0 |1 is obsolete| | Attachment #142177|0 |1 is obsolete| | Attachment #142179|0 |1 is obsolete| | Attachment #142180|0 |1 is obsolete| | Attachment #142181|0 |1 is obsolete| | Attachment #142182|0 |1 is obsolete| | Attachment #142183|0 |1 is obsolete| | Attachment #142184|0 |1 is obsolete| | Attachment #142185|0 |1 is obsolete| | Attachment #142186|0 |1 is obsolete| | Attachment #142187|0 |1 is obsolete| | Attachment #142188|0 |1 is obsolete| | Attachment #142189|0 |1 is obsolete| | Attachment #142190|0 |1 is obsolete| | Attachment #142191|0 |1 is obsolete| | --- Comment #201 from Martin Renvoize --- Created attachment 142616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142616&action=edit Bug 31028: Add `tickets` and `ticket_updates` tables This patch adds the new `tickets` and `ticket_updates` tables for tracking catalog concern tickets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:57:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:57:58 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #202 from Martin Renvoize --- Created attachment 142617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142617&action=edit Bug 31028: DBIC Schema update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:58:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:58:06 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #203 from Martin Renvoize --- Created attachment 142618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142618&action=edit Bug 31028: Add new Koha::Object(s) classes This patch adds new Koha::Object(s) for the newly introduced tables, including updateing existing Koha::Objects adding new relations as required. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:58:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:58:13 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #204 from Martin Renvoize --- Created attachment 142619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142619&action=edit Bug 31028: Add API's for tickets This patch adds basic CRUD API's for the ticket endpoints. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:58:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:58:20 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #205 from Martin Renvoize --- Created attachment 142620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142620&action=edit Bug 31028: Add `OpacCatalogConcerns` preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:58:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:58:27 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #206 from Martin Renvoize --- Created attachment 142621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142621&action=edit Bug 31028: Add ability to report catalog concerns from the OPAC This patch adds the ability for patrons to report catalog concerns via the opac. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:58:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:58:34 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #207 from Martin Renvoize --- Created attachment 142622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142622&action=edit Bug 31028: Add configurable help text and templates This patch adds configurable help text and a template option to the catalog concern report modal in the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:58:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:58:40 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #208 from Martin Renvoize --- Created attachment 142623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142623&action=edit Bug 31028: Add acknowledgement notice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:58:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:58:46 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #209 from Martin Renvoize --- Created attachment 142624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142624&action=edit Bug 31028: Add catalog concern management page to staff This patch adds a catalog concern management page to the staff client accessible via the cataloging home page and a new 'Pending catalog concerns' link on the front page. This includes added the requisit ticket_updates api endpoints and notice triggers and templates for notifying patrons of changes to their reported concerns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:58:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:58:53 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #210 from Martin Renvoize --- Created attachment 142625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142625&action=edit Bug 31028: Add email notification of cataloguers on submissions This patch adds an optional catalogeur notification to email the cataloging team whenever a new catalog concern is reported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:58:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:58:59 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #211 from Martin Renvoize --- Created attachment 142626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142626&action=edit Bug 31028: Add ability to report concerns from the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 17:59:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 15:59:06 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #212 from Martin Renvoize --- Created attachment 142627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142627&action=edit Bug 31028: Add display to details page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:02:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:02:13 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #213 from Martin Renvoize --- A big rebase and squash of patches.. lots of little improvements to the feature as a whole.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:08:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:08:32 +0000 Subject: [Koha-bugs] [Bug 31974] New: Regression: Bug 31813 incorrectly affected labels in the header search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 Bug ID: 31974 Summary: Regression: Bug 31813 incorrectly affected labels in the header search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Staff Client Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952, 31813 The CSS change Bug 31813 resulted in the white-space property of header search labels being overridden. We need to make sure the header search labels do not wrap. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 [Bug 31813] Specify white-space: normal for spans styled as labels -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:08:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:08:32 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31974 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 [Bug 31974] Regression: Bug 31813 incorrectly affected labels in the header search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:08:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:08:32 +0000 Subject: [Koha-bugs] [Bug 31813] Specify white-space: normal for spans styled as labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31974 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 [Bug 31974] Regression: Bug 31813 incorrectly affected labels in the header search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:10:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:10:50 +0000 Subject: [Koha-bugs] [Bug 31271] "Edit search" always resets search options to keyword In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com --- Comment #3 from Donna --- I would argue it is a regression - in previous versions, when I click back to the advanced search to edit the search, the search options are retained. The edit search button should do the same thing. I can click the back arrow and the fields are retained, so having the behavior differ between using the "proper" edit link vs back arrow is rather frustrating. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:15:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:15:46 +0000 Subject: [Koha-bugs] [Bug 31794] REST API: GET endpoint for Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31794 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:15:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:15:50 +0000 Subject: [Koha-bugs] [Bug 31794] REST API: GET endpoint for Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31794 --- Comment #1 from Owen Leonard --- Created attachment 142628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142628&action=edit Bug 31974: Regression: Bug 31813 incorrectly affected labels in the header search This patch adds a specific white-space property to header search labels so that they do not wrap. The change made by Bug 31813 overrode the white-space property incorrectly. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration. - The header search label "Search system preferences" should appear on one line. - Check that labels still wrap correctly on pages like the patron edit screen and the staged MARC record detail view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:22:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:22:39 +0000 Subject: [Koha-bugs] [Bug 31794] REST API: GET endpoint for Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31794 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142628|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:22:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:22:54 +0000 Subject: [Koha-bugs] [Bug 31794] REST API: GET endpoint for Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31794 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:23:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:23:00 +0000 Subject: [Koha-bugs] [Bug 31794] REST API: GET endpoint for Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31794 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:23:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:23:31 +0000 Subject: [Koha-bugs] [Bug 31974] Regression: Bug 31813 incorrectly affected labels in the header search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:23:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:23:35 +0000 Subject: [Koha-bugs] [Bug 31974] Regression: Bug 31813 incorrectly affected labels in the header search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 --- Comment #1 from Owen Leonard --- Created attachment 142629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142629&action=edit Bug 31974: Regression: Bug 31813 incorrectly affected labels in the header search This patch adds a specific white-space property to header search labels so that they do not wrap. The change made by Bug 31813 overrode the white-space property incorrectly. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration. - The header search label "Search system preferences" should appear on one line. - Check that labels still wrap correctly on pages like the patron edit screen and the staged MARC record detail view. https://bugs.koha-community.org/show_bug.cgi?id=31794 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:31:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:31:30 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:31:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:31:36 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131734|0 |1 is obsolete| | Attachment #131735|0 |1 is obsolete| | Attachment #131736|0 |1 is obsolete| | Attachment #131737|0 |1 is obsolete| | Attachment #131738|0 |1 is obsolete| | Attachment #131739|0 |1 is obsolete| | Attachment #131740|0 |1 is obsolete| | Attachment #131741|0 |1 is obsolete| | Attachment #131742|0 |1 is obsolete| | Attachment #131743|0 |1 is obsolete| | Attachment #131744|0 |1 is obsolete| | Attachment #131745|0 |1 is obsolete| | Attachment #131746|0 |1 is obsolete| | Attachment #131747|0 |1 is obsolete| | Attachment #131748|0 |1 is obsolete| | Attachment #131749|0 |1 is obsolete| | --- Comment #105 from Kyle M Hall --- Created attachment 142630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142630&action=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record Signed-off-by: Liz Rea https://bugs.koha-community.org/show_bug.cgi?id=20187 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:31:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:31:54 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #106 from Kyle M Hall --- Created attachment 142631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142631&action=edit Bug 20817: Move subroutines to a new Perl module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:31:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:31:59 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #107 from Kyle M Hall --- Created attachment 142632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142632&action=edit Bug 20817: Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:32:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:32:04 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #108 from Kyle M Hall --- Created attachment 142633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142633&action=edit Bug 20817: Rename get_infos_syspref_on_item to GetMarcItemFieldsToOrderValues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:32:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:32:09 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #109 from Kyle M Hall --- Created attachment 142634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142634&action=edit Bug 20817: Rename get_infos_syspref to GetMarcFieldsToOrderValues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:32:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:32:18 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #110 from Kyle M Hall --- Created attachment 142635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142635&action=edit Bug 20817: Remove syspref from parameters, it is invariant -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:32:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:32:25 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #111 from Kyle M Hall --- Created attachment 142636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142636&action=edit Bug 20817: Fix QA script issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:32:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:32:30 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #112 from Kyle M Hall --- Created attachment 142637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142637&action=edit Bug 20817: Update module to use YAML::XS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:32:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:32:35 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #113 from Kyle M Hall --- Created attachment 142638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142638&action=edit Bug 20817: (QA follow-up) Remove size=1 attribute Resolves QA warning, with reference to bug 28066. Line 345 of acqui/neworderempty.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:32:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:32:42 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #114 from Kyle M Hall --- Created attachment 142639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142639&action=edit Bug 20817: _trim should always return a value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:32:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:32:49 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #115 from Kyle M Hall --- Created attachment 142640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142640&action=edit Bug 20817: (QA follow-up) Fix 'undefined subroutine' error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:32:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:32:54 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #116 from Kyle M Hall --- Created attachment 142641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142641&action=edit Bug 20817: (QA follow-up) Fix _trim The patch 'trim should always return a value' does not completely do the job yet. And might have unwanted effects for the '0' case. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:32:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:32:59 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #117 from Kyle M Hall --- Created attachment 142642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142642&action=edit Bug 20817: Fix incorrect namespace for subroutine call -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:33:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:33:07 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #118 from Kyle M Hall --- Created attachment 142643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142643&action=edit Bug 20817: Import C4::Items::PrepareItemrecordDisplay for neworderempty.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:33:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:33:13 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #119 from Kyle M Hall --- Created attachment 142644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142644&action=edit Bug 20817: (QA follow-up) Add new parameter for PrepareItemrecordDisplay -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:33:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:33:18 +0000 Subject: [Koha-bugs] [Bug 13965] Add date last seen on item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13965 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com --- Comment #2 from Donna --- +1 on this! We were asked exactly for this enhancement today in training! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:33:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:33:23 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #120 from Kyle M Hall --- Created attachment 142645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142645&action=edit Bug 20817: (QA follow-up) Fix POD for GetMarcFieldsToOrderValues and GetMarcItemFieldsToOrderValues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:37:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:37:51 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #82 from Barbara Johnson --- Agreed - this functionality would save so much time for our staff. What is the best path forward to unstick this bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:38:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:38:20 +0000 Subject: [Koha-bugs] [Bug 31975] New: Add Item Search to table settings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31975 Bug ID: 31975 Summary: Add Item Search to table settings Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com With all of the incredibly useful info on the item search, being able to configure the columns would be a great addition! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:41:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:41:32 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142630|0 |1 is obsolete| | Attachment #142631|0 |1 is obsolete| | Attachment #142632|0 |1 is obsolete| | Attachment #142633|0 |1 is obsolete| | Attachment #142634|0 |1 is obsolete| | Attachment #142635|0 |1 is obsolete| | Attachment #142636|0 |1 is obsolete| | Attachment #142637|0 |1 is obsolete| | Attachment #142638|0 |1 is obsolete| | Attachment #142639|0 |1 is obsolete| | Attachment #142640|0 |1 is obsolete| | Attachment #142641|0 |1 is obsolete| | Attachment #142642|0 |1 is obsolete| | Attachment #142643|0 |1 is obsolete| | Attachment #142644|0 |1 is obsolete| | Attachment #142645|0 |1 is obsolete| | --- Comment #121 from Kyle M Hall --- Created attachment 142646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142646&action=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record Signed-off-by: Liz Rea https://bugs.koha-community.org/show_bug.cgi?id=20187 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:41:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:41:53 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #122 from Kyle M Hall --- Created attachment 142647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142647&action=edit Bug 20817: Squashed follow-ups * Move subroutines to a new Perl module * Add unit tests * Rename get_infos_syspref_on_item to GetMarcItemFieldsToOrderValues * Rename get_infos_syspref to GetMarcFieldsToOrderValues * Remove syspref from parameters, it is invariant * Fix QA script issues * Update module to use YAML::XS * _trim should always return a value * (QA follow-up) Fix 'undefined subroutine' error * Fix incorrect namespace for subroutine call * Import C4::Items::PrepareItemrecordDisplay for neworderempty.pl * (QA follow-up) Add new parameter for PrepareItemrecordDisplay * (QA follow-up) Fix POD for GetMarcFieldsToOrderValues and GetMarcItemFieldsToOrderValues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:41:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:41:58 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #123 from Kyle M Hall --- Created attachment 142648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142648&action=edit Bug 20817: (QA follow-up) Remove size=1 attribute Resolves QA warning, with reference to bug 28066. Line 345 of acqui/neworderempty.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:42:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:42:04 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #124 from Kyle M Hall --- Created attachment 142649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142649&action=edit Bug 20817: (QA follow-up) Fix _trim The patch 'trim should always return a value' does not completely do the job yet. And might have unwanted effects for the '0' case. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:45:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:45:18 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142646|0 |1 is obsolete| | Attachment #142647|0 |1 is obsolete| | Attachment #142648|0 |1 is obsolete| | Attachment #142649|0 |1 is obsolete| | --- Comment #125 from Kyle M Hall --- Created attachment 142650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142650&action=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:45:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:45:40 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kohadevinim at devinim.com.tr |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 18:48:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 16:48:17 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142650|0 |1 is obsolete| | --- Comment #126 from Kyle M Hall --- Created attachment 142651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142651&action=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record We would like an Acquisitions development that would streamline the workflow of ordering items that already exist in the system (reorders). The ideal workflow would be something along the lines of: 1. Staged files are added to a basket and a duplicate warning is received. You click "Display them" (This step already exists) 2. From this screen, when you click "add order" on an item, you are able to add that order record to an existing bib record using the information in the 9xx fields. Currently this step discards any 9xx information and creates a blank order record. 3. Click "Save" and move on to the next duplicate. Since the ability to add an order to an existing record is already present, we're just looking to add the 9xx information as well. Additional Authors: Devinim Marcel de Rooy Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 19:00:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 17:00:57 +0000 Subject: [Koha-bugs] [Bug 31976] New: Incorrect breadcrumbs in authorised_values.tt main page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31976 Bug ID: 31976 Summary: Incorrect breadcrumbs in authorised_values.tt main page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org When first accessing the authorized values page, the breadcrumbs say that we are in the AR_CANCELLATION category. To test: 1. Go to Administration > Authorized values --> Breadcrumbs indicate Home / Administration / Authorized values / Authorized values for category AR_CANCELLATION -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 19:08:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 17:08:11 +0000 Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 19:10:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 17:10:30 +0000 Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |This patch adds the ability released in| |to redirect users back to | |where they were when using | |the modal type logins in | |place of an action that | |requires login on the OPAC. | | | |Example: On the | |opac-detail page one can | |add comments if logged in. | |Prior to this patch, | |clicking the link to add a | |comment prior to being | |logged in would expose the | |login modal and then | |re-direct you to your | |opac-user page and thus | |loose the context of your | |action. With this patch | |you are redirected back to | |the biblio you were looking | |at so you can post your | |comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 19:15:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 17:15:48 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #32 from Tomás Cohen Arazi --- Hmm, it feels like Nick's follow-up and mine are to blame. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 19:34:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 17:34:51 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed |rel_22_05_candidate Status|ASSIGNED |In Discussion --- Comment #33 from Tomás Cohen Arazi --- I'm reverting this one for now. The reason is the failures in t/db_dependent/Koha/Items.t look problematic or at least complex enough for requiring a new review. With the new method and the changes made, the $processfee_amount of 20 is being charged when it shouldn't so at least the tests need to be adjusted to clear the whole scenario we are testing. I noticed that Nick's follow-up merging the methods introduced a failure in t/db_dependent/Koha/Item.t that I fixed by breaking things as well. Remarkably, with my broken follow-up nothing changed regarding the tests results... I'm adding the rel_22_05_candidate so this dev has the chance to get in beyond the soft freeze, but please hurry. We can go without Nick's little refactoring for now BTW, and think about it later. Looking forward to your comments and follow-ups. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 19:35:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 17:35:06 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 | released in| | Status|In Discussion |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 19:35:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 17:35:21 +0000 Subject: [Koha-bugs] [Bug 31977] New: Make Item Search result sortable by multiple columns Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31977 Bug ID: 31977 Summary: Make Item Search result sortable by multiple columns Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org It would be really helpful to allow sorting by multiple columns on the item search results page. Right now, you can only sort by one column at a time. It would be a great addition to be able to sort for instance, by call number, then click on the data column and have a secondary sort on that column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 19:35:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 17:35:24 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142575|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 19:37:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 17:37:37 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #34 from Tomás Cohen Arazi --- I'm reverting it tomorrow, if you provide a fix by tomorrow, I won't. It still has the chance to get in either way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 19:47:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 17:47:32 +0000 Subject: [Koha-bugs] [Bug 31977] Make Item Search result sortable by multiple columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31977 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Donna --- Going to mark this as solved, since it has been brought to my attention that you can do this by using the shift key. :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 19:51:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 17:51:15 +0000 Subject: [Koha-bugs] [Bug 31978] New: A cron job is needed to clean out background jobs/tasks Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31978 Bug ID: 31978 Summary: A cron job is needed to clean out background jobs/tasks Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: estherm at sodaspringsid.com QA Contact: testopia at bugs.koha-community.org Our consortium has about 21 libraries that use our Koha install. In just two months, we have logged almost 2,000 background jobs. It would be nice to have a cron job that will automatically clear these out periodically. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 19:58:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 17:58:34 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #35 from Tomás Cohen Arazi --- Created attachment 142652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142652&action=edit Bug 23012: Fix t/db_dependent/Koha/Item.t With the follow-up changes, the return value is no longer a scalar, but a hashref, but the tests weren't updated accordingly. This patch fixes this situation. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => FAIL: Tests fail 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 20:04:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 18:04:34 +0000 Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #30 from Juliet Heltibridle --- Thank you Katrin. I updated the system preference. Cover images show correctly on the Comments RSS as well. But I get the following error when clicking on the RSS feed for a search results page: Template process failed: file error - biblio_a_href: not found at /kohadevbox/koha/C4/Templates.pm line 127 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 20:25:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 18:25:09 +0000 Subject: [Koha-bugs] [Bug 27086] Add a both/most restrictive option for ReservesControlBranch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27086 Michael Adamyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk at ckls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 20:29:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 18:29:52 +0000 Subject: [Koha-bugs] [Bug 31975] Add Item Search to table settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31975 hebah at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 20:52:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 18:52:22 +0000 Subject: [Koha-bugs] [Bug 31975] Add Item Search to table settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31975 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 23565 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 20:52:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 18:52:22 +0000 Subject: [Koha-bugs] [Bug 23565] Add columns configuration and export options to item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23565 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com --- Comment #5 from Owen Leonard --- *** Bug 31975 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 21:03:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 19:03:03 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #68 from Blou --- Created attachment 142653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142653&action=edit Bug 24387 - fixup to db_rev for non-english, multilingual Koha Without this patch, the update process duplicates all the news and content entries when they were non-english to start with. This patch keeps the same process, but new "default" "parent" entries are empty so there' no duplication in the OPAC display, while still being editable/deletable in the intranet. We came through that through many iterations. This was the least invasive while still providing satisfying results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 21:11:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 19:11:26 +0000 Subject: [Koha-bugs] [Bug 31976] Incorrect breadcrumbs in authorised_values.tt main page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31976 --- Comment #1 from Caroline Cyr La Rose --- This bug goes back to at least 22.05. I checked 21.05 and that version is fine. Not sure for 21.11... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 21:59:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 19:59:53 +0000 Subject: [Koha-bugs] [Bug 31671] Add a "Print transfer slip" button to /cgi-bin/koha/circ/branchtransfers.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31671 Ann Flournoy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aflournoy at cityofkeller.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 22:04:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 20:04:41 +0000 Subject: [Koha-bugs] [Bug 31974] Regression: Bug 31813 incorrectly affected labels in the header search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 22:04:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 20:04:48 +0000 Subject: [Koha-bugs] [Bug 31974] Regression: Bug 31813 incorrectly affected labels in the header search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142629|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142654&action=edit Bug 31974: Regression: Bug 31813 incorrectly affected labels in the header search This patch adds a specific white-space property to header search labels so that they do not wrap. The change made by Bug 31813 overrode the white-space property incorrectly. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration. - The header search label "Search system preferences" should appear on one line. - Check that labels still wrap correctly on pages like the patron edit screen and the staged MARC record detail view. https://bugs.koha-community.org/show_bug.cgi?id=31794 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 22:15:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 20:15:15 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #36 from Aleisha Amohia --- Can someone please let me know what work needs to be done here? I wrote the initial patches but I understand the follow-ups caused test failures? A bit hard to follow the commentary :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 22:33:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 20:33:46 +0000 Subject: [Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 --- Comment #15 from Marie-Luce Laflamme --- (In reply to Katrin Fischer from comment #14) > (In reply to Marie-Luce Laflamme from comment #13) > > The IntranetUserJS syspref work around isn't working in Koha 22.05+ version. > > The handling for cookies has changed, this appears to work on master: > > $(document).ready(function() { > > if (typeof script !== 'undefined' && > Cookies.get("issues-table-load-immediately-" + script) !== "true") { > Cookies.set("issues-table-load-immediately-" + script, true, { expires: > 365, sameSite: 'Lax' }); > } > > }); Your quick fix works well in 22.05 and the latest master version. Thanks Kathrin -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 22:35:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 20:35:17 +0000 Subject: [Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598 geraud.frappier at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140376|0 |1 is obsolete| | --- Comment #13 from geraud.frappier at inlibro.com --- Created attachment 142655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142655&action=edit Bug 26598: Display guarantee's fines on guarantor's details page A new tab is added to the details page of a patron to show, in a table, the fines of the patron's guarantees. A warning appears in the "Guarantees" section of the patron to make it obvious that fines exists. + resolve a git merge conflict To test: 1) Apply patch 2) Choose a patron that has guarantees and navigate to the patron's details page 3) If the guarantees don't have any fines, the display should be unchanged 4) Add fines to the guarantee 5) Go back to the guarantor's details page => A warning should appear in the "Guarantees" section with the total due 6) Clicking on the link accompanying the warning focuses on the new "Guarantees' fines" tab containing a table of all guarantee's and their fines. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 22:43:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 20:43:26 +0000 Subject: [Koha-bugs] [Bug 31973] Restore background color to message-style alerts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31973 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 22:43:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 20:43:31 +0000 Subject: [Koha-bugs] [Bug 31973] Restore background color to message-style alerts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31973 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142615|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142656&action=edit Bug 31973: Restore background color to message-style alerts This patch restores the background color to message-style alerts, those which use the markup
    . These alerts should stand out more to the user. To test, apply the patch and rebuild the staff interface CSS. - Test areas which use the message-style dialog. Perhaps the easiest example is to try to view a bibliographic record which doesn't exist: /cgi-bin/koha/catalogue/detail.pl?biblionumber=1234567890 - It can also be found as a confirmation when deleting a basket in Acquisitions, deleting a patron attribute type in Administration, updating a Z39.50 server in Administration, etc. - Confirm that the alert looks correct and is suitable visible. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 22:43:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 20:43:43 +0000 Subject: [Koha-bugs] [Bug 31979] New: Allow formatting / line breaks when editing return_claims.notes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31979 Bug ID: 31979 Summary: Allow formatting / line breaks when editing return_claims.notes Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When editing notes in the Claim Return function, line breaks are not maintained - all notes run together into one note. With how Claim Return notes are used (such as updating the note that a shelf check has been added) these notes need to be visibly separate from each other. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 22:52:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 20:52:16 +0000 Subject: [Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 --- Comment #16 from Katrin Fischer --- (In reply to Marie-Luce Laflamme from comment #15) > (In reply to Katrin Fischer from comment #14) > > (In reply to Marie-Luce Laflamme from comment #13) > > > The IntranetUserJS syspref work around isn't working in Koha 22.05+ version. > > > > The handling for cookies has changed, this appears to work on master: > > > > $(document).ready(function() { > > > > if (typeof script !== 'undefined' && > > Cookies.get("issues-table-load-immediately-" + script) !== "true") { > > Cookies.set("issues-table-load-immediately-" + script, true, { expires: > > 365, sameSite: 'Lax' }); > > } > > > > }); > > > Your quick fix works well in 22.05 and the latest master version. > > Thanks Kathrin Thx for the feedback, happy it helped! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 22:56:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 20:56:45 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #69 from Katrin Fischer --- Thanks Blou! I've marked this as "additional_work_needed" to get some attention, but as this bug has already been released and we don't want it to show up in release notes again, we should move the follow-up to a separate bug where we can also highlight it as a fix for a bad bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 22:58:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 20:58:10 +0000 Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #31 from Katrin Fischer --- (In reply to Juliet Heltibridle from comment #30) > Thank you Katrin. I updated the system preference. Cover images show > correctly on the Comments RSS as well. But I get the following error when > clicking on the RSS feed for a search results page: > Template process failed: file error - biblio_a_href: not found at > /kohadevbox/koha/C4/Templates.pm line 127 It might be unrelated to this patch set. It looks like a missing include (I recently had a similar error elsewhere) Owen, do you want to follow-up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 23:01:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 21:01:37 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #102 from Katrin Fischer --- (In reply to Jonathan Druart from comment #100) > t/db_dependent/www/search_utf8.t .. 1/89 Link not found at > /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 140. > > 139 $agent->follow_link_ok( { url_regex => qr/tools-home/i }, 'open > tools module' ); > 140 $agent->follow_link_ok( { text => 'Stage MARC records for import' }, > 141 'go to stage MARC' ); > > Where is this link? It's on the new cataloging start page now - first link on the left? But maybe this was just meant as a rhetoric question? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 23:02:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 21:02:10 +0000 Subject: [Koha-bugs] [Bug 31980] New: Allow for editing of patron message Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31980 Bug ID: 31980 Summary: Allow for editing of patron message Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In messages.message there is not a way to edit a message once it has been created. The only option is to either add a separate message referring to a previous message, or delete the message and create a new one with the content. It would be a great benefit to be able to edit a message to add supplemental/updated info within the same message. Ideally, the original creation info (borrower, date, branch) would be kept, and another set of data (borrower, date, branch) added when the message is added on to. For instance, original message is: 10/22/2022 East Library ( bwssupport ) "Please check address - mail was returned" and when I edit the message, it now says 10/22/2022 East Library ( bwssupport ) "Please check address - mail was returned" 10/25/2022 East Library ( djones ) "Spoke to patron - they will bring in updated info" all within one message. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 23:04:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 21:04:30 +0000 Subject: [Koha-bugs] [Bug 31271] "Edit search" always resets search options to keyword In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22605 Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | --- Comment #4 from Katrin Fischer --- I also felt like I had tested this when the edit link was added... Adding Nick. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 [Bug 22605] Adding the option to modify/edit searches on the staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 23:04:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 21:04:30 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31271 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 [Bug 31271] "Edit search" always resets search options to keyword -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 23:08:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 21:08:10 +0000 Subject: [Koha-bugs] [Bug 31977] Make Item Search result sortable by multiple columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31977 --- Comment #2 from Katrin Fischer --- (In reply to Donna from comment #1) > Going to mark this as solved, since it has been brought to my attention that > you can do this by using the shift key. :-) I didn't know this!!! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 23:09:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 21:09:48 +0000 Subject: [Koha-bugs] [Bug 31978] A cron job is needed to clean out background jobs/tasks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31978 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 31969 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 23:09:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 21:09:48 +0000 Subject: [Koha-bugs] [Bug 31969] Options for cleanup_database.pl to remove finished jobs from the background job queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31969 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |estherm at sodaspringsid.com --- Comment #4 from Katrin Fischer --- *** Bug 31978 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 23:11:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 21:11:57 +0000 Subject: [Koha-bugs] [Bug 31970] background_jobs_purge.pl to purge background jobs queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31970 --- Comment #4 from Katrin Fischer --- Maybe you should post your patch as an alternate on bug 31969 so it's seen and highlight the differences. With the duplicate status it's now easy to miss and it looks like we should agree on one approach or the other :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 23:13:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 21:13:43 +0000 Subject: [Koha-bugs] [Bug 21699] Allowing circulation messages to be editable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allowing circulation |Allowing circulation |Messages to be editable |messages to be editable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 23:14:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 21:14:10 +0000 Subject: [Koha-bugs] [Bug 31980] Allow for editing of patron message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31980 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 21699 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 23:14:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 21:14:10 +0000 Subject: [Koha-bugs] [Bug 21699] Allowing circulation messages to be editable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com --- Comment #5 from Katrin Fischer --- *** Bug 31980 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 23:14:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 21:14:47 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #37 from Tomás Cohen Arazi --- TL;DR This patch set broke t/db_dependent/Koha/Items.t Please fix it. I blamed the follow-ups, but that was incorrect as far as I can tell. When you fix it, please verify the Circulation* tests still pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 23:47:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 21:47:15 +0000 Subject: [Koha-bugs] [Bug 31981] New: Need to be able to more clearly distinguish between hold warning boxes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 Bug ID: 31981 Summary: Need to be able to more clearly distinguish between hold warning boxes Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 142657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142657&action=edit warning box for example two There are potentially two yellow warning boxes staff can see when checking out an item that is on hold and the two boxes are VERY difficult to distinguish between. It would be helpful to either change the wording, or change the color of one of them to help staff determine what action should be taken. For instance, place a hold on an item for Patron A, do not trigger the hold, and check the item out to Patron B. The message is: Please confirm checkout Item Toby goes bananas / (312824) has been on hold for Donna B (donnab) at Sparkly Unicorn Land since 10/25/2022 Cancel hold Yes, check out (Y) Don't check out and print slip (P) No, don't check out (N) Cancel checkout and place a hold for Jack Shepard (68) Then check the item in, confirm the hold, then check the item out to Patron B. The message is: Please confirm checkout Item Toby goes bananas / (312824) has been waiting for Donna B (donnab) at Sparkly Unicorn Land since 10/25/2022 Cancel hold Revert waiting status The first message is much more common - libraries typically see it when a patron has placed a hold on something, but another patron has taken it off the shelf to check out before staff were able to pull it for the other patron. The second message is much less common - this is when an item is on the hold pick up shelf and a patron other than who it was triggered for is trying to check it out. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 23:47:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 21:47:41 +0000 Subject: [Koha-bugs] [Bug 31981] Need to be able to more clearly distinguish between hold warning boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 --- Comment #1 from Donna --- Created attachment 142658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142658&action=edit warning box for example 1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 25 23:49:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 21:49:22 +0000 Subject: [Koha-bugs] [Bug 31981] Need to be able to more clearly distinguish between hold warning boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 00:46:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 22:46:28 +0000 Subject: [Koha-bugs] [Bug 31969] Options for cleanup_database.pl to remove finished jobs from the background job queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31969 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #5 from Liz Rea --- YES thank you -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 01:47:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 23:47:28 +0000 Subject: [Koha-bugs] [Bug 31969] Options for cleanup_database.pl to remove finished jobs from the background job queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31969 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 01:48:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Oct 2022 23:48:27 +0000 Subject: [Koha-bugs] [Bug 31970] background_jobs_purge.pl to purge background jobs queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31970 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 02:08:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 00:08:21 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from David Nind --- Hi Aleisha. Apologies for Failing QA on this again! The previous issue reported is fixed (step 7 - can't cancel a recall from OPAC when RecallsInterface = staff interface only). I've identified a new issue with step 5 - cancelling a recall from the recalls section for a record - record doesn't exist after cancelling a recall using the 'Cancel selected recalls' button and selecting the normal section. To replicate: 1. Place a recall 2. Go to the recalls section for the record on the staff interface 3. Using Actions > Cancel works as expected 4. Repeat steps 1 and 2. 5. Cancel the recall by ticking the box next to the item and then selecting 'Cancel selected recalls' button doesn't work as expected: . The recall is cancelled . URL = http://127.0.0.1:8081/cgi-bin/koha/recalls/request.pl . Breadcrumb = Home > Catalog > No title > Place a recall . Click on the normal section: message = The record you requested does not exist (). URL = http://127.0.0.1:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber= I'm not sure if I tested this last time. I'm also sure I've seen this when testing something else a while ago, but can't remember or find what bug it was. Also, for step 13 it is possible to have more than one recall for a record or item. Whose recall takes priority, and what is the workflow libraries would use to address this? - If a recall is already on the record (from the previous step), there are now two recalls (a record level one, and an item level one) - On the record page is shows "recalled by X on [date]" - for X it shows the person who made the latest recall, not the first person who place a recall. - Is this an edge case to be resolved in a separate bug, or a non-issue? - It seems logical that multiple patrons could make a recall request for the same record. What would the workflow be for libraries if they were in this situation, and how do they resolve this? David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 04:19:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 02:19:11 +0000 Subject: [Koha-bugs] [Bug 31983] New: Add "public_api_routes" Koha plugin method Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31983 Bug ID: 31983 Summary: Add "public_api_routes" Koha plugin method Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org At the moment, Koha plugins put all their API routes under /api/v1/contrib/. It would be useful to be able to put API routes under either of these two paths: /api/v1/contrib/ /api/v1/public/contrib/ That way, we can more easily separate the public and non-public API interfaces. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 04:19:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 02:19:24 +0000 Subject: [Koha-bugs] [Bug 31983] Add "public_api_routes" Koha plugin method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31983 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31982 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 04:34:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 02:34:21 +0000 Subject: [Koha-bugs] [Bug 31984] New: TaxRate system preference - incorrect default value used and warning message on order form Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31984 Bug ID: 31984 Summary: TaxRate system preference - incorrect default value used and warning message on order form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org For the TaxRate system preference: 1. The description [1] says that the first value entered will be used by default. 2. When entering an order for a basket, the last value in the list is selected as the default (19.65%). 3. If the values for the TaxRate system preference are changed, for example having the values: 0.15|0.20: - 19.65% is shown as the default value, even though it is not a value entered in the TaxRate system preference - There is a warning for the 'Tax rate' input field for the order: "Tax rate not defined in system preference TaxRates!" - The tax inclusive values for budgets/funds are calculated correctly if you choose another option, despite the warning message. To replicate: 1. Check that there are values entered for the TaxRates system preference (in KTD the values entered are: 0|0.12|0.1965). 2. Create a new basket (or use an existing one). 3. Add a new order to the basket. 4. On the accounting details form, note that the default value for the 'Tax rate' field is 19.65% and the other options are 0% and 12%. 5. Complete adding the order to the basket. 6. On the acquisitions home page, note that the ordered amount is tax inclusive and is calculated correctly. 7. Change the TaxRates system preference to: 0.15|0.20 8. Repeat steps 2-3. 9. Note that on the accounting details form for the 'Tax rate' field: . the options available are 15%, 20%, and 19.65%, with the 19.65% shown as the default - even though 19.65% is not a value entered for the system preference . there is a warning for the field: "Tax rate not defined in system preference TaxRates!" 10. Select the 15% option, and repeat steps 5-6. The tax inclusive amount is correctly calculated, despite the warning that was on the form. [1] Current description in master, with default values used in KTD: Tax rates are [0|0.12|0.1965]. Enter in numeric form, 0.12 for 12%. The first item in the list will be selected by default. For more than one value, separate with | (pipe). Please note: The database will only accept values up to 4 decimals precision, further values will be rounded. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 04:41:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 02:41:27 +0000 Subject: [Koha-bugs] [Bug 31984] TaxRate system preference - incorrect default value used and warning message on order form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31984 --- Comment #1 from David Nind --- Created attachment 142659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142659&action=edit Screenshot - tax rate field for order form (with custom values) A screenshot showing the accounting details form for an order, where 15% and 20% values are entered into the TaxRate system preference (0.15|0.20). Note that 19.65% is selected by default, even though it is not a value entered into the TaxRate system preference. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 04:42:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 02:42:43 +0000 Subject: [Koha-bugs] [Bug 31984] TaxRate system preference - incorrect default value used and warning message on order form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31984 --- Comment #2 from David Nind --- (In reply to David Nind from comment #1) > Created attachment 142659 [details] Also note the warning message. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 04:54:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 02:54:07 +0000 Subject: [Koha-bugs] [Bug 31984] TaxRate system preference - incorrect default value used and warning message on order form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31984 --- Comment #3 from David Nind --- Created attachment 142660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142660&action=edit Screenshot - Receiving order - formatting and default values Testing notes and issues/query (tested using koha-testing-docker). Three things I noticed: 1. Tax Rate system preference warning message --------------------------------------------- Even though I defined the Tax Rate system preference as 0.15, when adding an item to a basket: for tax rate there is a message saying "Tax rate not defined in system preference TaxRates!". Despite the warning, everything is calculated correctly using the 15% tax rate. I've logged bug 31984 for this, as this was happening before the patches were applied (includes a screenshot to show what I mean). 2. Step 13 - Formatting things ------------------------------ When receiving order (see screenshot): - For the Retail price field: no space after value and the opening bracket; no space between comma and tax exclusive - For the Budgeted cost field: no space after value and the opening bracket 3. For step 13 - Query about using the default values ----------------------------------------------------- I received the order with the default values (see the screenshot). As the actual cost defaulted to $10 (as entered in step 6), then the 10.00 is the value excluding tax, so: - For step 14: spent = 10.00 - For step 15: subtotal = 10.00 - For step 17: spent = 11.50 - For step 18: subtotal = 11.50 These values are correctly calculated, but don't match up with the test plan. So should I have entered the actual costs as 8.00 (the $10 retail price less the 20% discount, tax exclusive)? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 04:56:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 02:56:12 +0000 Subject: [Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #6 from David Nind --- Created attachment 142661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142661&action=edit Screenshot - Receiving order - formatting and default values Testing notes and issues/query (tested using koha-testing-docker). Three things I noticed: 1. Tax Rate system preference warning message --------------------------------------------- Even though I defined the Tax Rate system preference as 0.15, when adding an item to a basket: for tax rate there is a message saying "Tax rate not defined in system preference TaxRates!". Despite the warning, everything is calculated correctly using the 15% tax rate. I've logged bug 31984 for this, as this was happening before the patches were applied (includes a screenshot to show what I mean). 2. Step 13 - Formatting things ------------------------------ When receiving order (see screenshot): - For the Retail price field: no space after value and the opening bracket; no space between comma and tax exclusive - For the Budgeted cost field: no space after value and the opening bracket 3. For step 13 - Query about using the default values ----------------------------------------------------- I received the order with the default values (see the screenshot). As the actual cost defaulted to $10 (as entered in step 6), then the 10.00 is the value excluding tax, so: - For step 14: spent = 10.00 - For step 15: subtotal = 10.00 - For step 17: spent = 11.50 - For step 18: subtotal = 11.50 These values are correctly calculated, but don't match up with the test plan. So should I have entered the actual costs as 8.00 (the $10 retail price less the 20% discount, tax exclusive)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 04:57:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 02:57:02 +0000 Subject: [Koha-bugs] [Bug 31984] TaxRate system preference - incorrect default value used and warning message on order form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31984 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142660|0 |1 is obsolete| | --- Comment #4 from David Nind --- Comment on attachment 142660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142660 Screenshot - Receiving order - formatting and default values Incorrectly added to this bug! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 07:31:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 05:31:43 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #103 from Jonathan Druart --- Nope, I greped "Stage MARC records for import" and got no result. It's now "Stage records for import". Selenium tests should be easy to fix then. Ask if you need help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 07:33:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 05:33:44 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #104 from Jonathan Druart --- What's the plan to change people's habits? Shouldn't we advert this a bit more in the release notes? Shouldn't we have a hint with a link on top of the tools-home for a couple of releases? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 07:50:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 05:50:38 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #105 from Martin Renvoize --- Sorry, I didn't expect this to effect existing tests. I'm out today in kid duties, so can work on tests tomorrow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 07:53:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 05:53:34 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement tries to |This enhancement brings release notes|bring a bit more order the |more order the cataloguing |cataloguing features. We |features. |create a new 'Cataloguing' | |module home page and |We create a new |collecting the cataloguing |'Cataloguing' module home |tools into it. |page and collect the | |cataloguing tools into it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 07:55:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 05:55:33 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #106 from Martin Renvoize --- I think people's muscle memory will change fairly quickly in reality. But I'm happy to add a quick link from tools home too if we think that will help... I think I even already suggested that as a compromise on irc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 08:05:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 06:05:08 +0000 Subject: [Koha-bugs] [Bug 31983] Add "public_api_routes" Koha plugin method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31983 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 08:10:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 06:10:20 +0000 Subject: [Koha-bugs] [Bug 31970] background_jobs_purge.pl to purge background jobs queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31970 --- Comment #5 from Frédéric Demians --- Thank you Katrin for your vigilance. Bug 31969 approach is fine for me, and it avoid adding a new script. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 08:13:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 06:13:56 +0000 Subject: [Koha-bugs] [Bug 31629] Cleanup database needs a flag for removing elastic index entries from background_jobs table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31629 --- Comment #16 from Frédéric Demians --- In my opinion bug 31969 should be privileged to this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 08:20:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 06:20:54 +0000 Subject: [Koha-bugs] [Bug 31969] Options for cleanup_database.pl to remove finished jobs from the background job queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31969 --- Comment #6 from Frédéric Demians --- Thanks Björn for your patch. Have you considered putting the code of your PurgeBackgroundJobs function into Koha::BackgroundJobs as a class method? This could be used from elsewhere, the WUI for example, and from cleanup_database.pl like that: Koha::BackgroundJobs::purge(10, 'all', 1); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 09:18:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 07:18:23 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 09:32:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 07:32:32 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #107 from Martin Renvoize --- Created attachment 142663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142663&action=edit Bug 31162: (follow-up) Fix Mocks/Zebra.pm This patch updates the t/lib/Mocks/Zebra.pm testing module for the change of navigation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 09:36:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 07:36:42 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #108 from Martin Renvoize --- Created attachment 142664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142664&action=edit Bug 31162: (follow-up) Fix www/batch.t This patch updates the t/db_dependent/www/batch.t test for the change of navigation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 09:41:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 07:41:09 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #109 from Martin Renvoize --- Two follow-ups for the cat-home change bit of the problem.. but the tests still fail further down.. I think it's coming from the move to background jobs and the return of the form submission changing.. must run now but can return to this later this evening unless someone beats me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 10:24:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 08:24:54 +0000 Subject: [Koha-bugs] [Bug 31985] New: dfine default value for 008 field Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31985 Bug ID: 31985 Summary: dfine default value for 008 field Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: hagud at orex.es QA Contact: testopia at bugs.koha-community.org Add syspref to be able to define default value for diferent positions and marc templates For example position 6th of 008 related to date, by default is 'b' unknown date, when it is very common to know the value of the date, then 99% of cataloguin requires updating the value perhaps [template, position, value] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 11:37:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 09:37:57 +0000 Subject: [Koha-bugs] [Bug 31947] [Omnibus] Add 'btn-primary' to the main action button where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 11:39:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 09:39:23 +0000 Subject: [Koha-bugs] [Bug 31947] [Omnibus] Add 'btn-primary' to the main action button where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 --- Comment #1 from Fridolin Somers --- See doc about buttons in https://getbootstrap.com/docs/4.0/components/buttons/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 11:41:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 09:41:11 +0000 Subject: [Koha-bugs] [Bug 19540] opac-reserve does not correctly warn of too_much reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19540 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 12:09:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 10:09:37 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #38 from Aleisha Amohia --- I will fix this tomorrow! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 12:39:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 10:39:43 +0000 Subject: [Koha-bugs] [Bug 31986] New: Add page-section to various administration pages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 Bug ID: 31986 Summary: Add page-section to various administration pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 30952 These admin pages need a page-section div to be added: additional-fields.tt aqbudgets.tt auth_subfields_structure.tt auth_tag_structure.tt authtypes.tt biblio_framework.tt checkmarc.tt classsources.tt currency.tt edi_accounts.tt edi_ean_accounts.tt items_search_fields.tt koha2marclinks.tt marc-overlay-rules.tt marc_subfields_structure.tt marctagstructure.tt matching-rules.tt oai_sets.tt smtp_servers.tt z3950servers.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 12:39:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 10:39:43 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31986 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 [Bug 31986] Add page-section to various administration pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 12:50:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 10:50:42 +0000 Subject: [Koha-bugs] [Bug 31543] MaxComponentRecords link is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31543 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 12:50:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 10:50:46 +0000 Subject: [Koha-bugs] [Bug 31543] MaxComponentRecords link is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31543 --- Comment #3 from Nick Clemens --- Created attachment 142665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142665&action=edit Bug 31543: Use query string, rather than query, to build link This patch returns the query string from build_query_compat Under Zebra, either works for the link, for ES we need the simple string I expand the test for get_components_query to test both engines To test: 1.0) Set search engine to Elasticsearch 1.1) Go to Tools > Stage MARC records for import 1.2) Upload the example file 1.3) In the form, choose the format 'MARCXML' 1.4) Click 'Stage for import' 1.5) Click 'Manage staged records' 1.6) Click 'Import this batch into the catalog' 2) Change MaxComponentRecords to 10 3) In the staff interface, search the catalog for 'easy piano' 4) Click on the record 'Easy piano pieces for children' 5) Click on the 'show all component parts' link at the bottom of the Components tab --> it searches for HASH(...) - returns no results 6) Try the same in OPAC --> it searches for HASH(...) - returns no results 7) Apply patch and restart all 8) repeat 3-6 9) Results returned! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 12:51:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 10:51:05 +0000 Subject: [Koha-bugs] [Bug 31543] MaxComponentRecords link is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31543 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 12:56:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 10:56:39 +0000 Subject: [Koha-bugs] [Bug 31986] Add page-section to various administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 12:56:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 10:56:42 +0000 Subject: [Koha-bugs] [Bug 31986] Add page-section to various administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 --- Comment #1 from Owen Leonard --- Created attachment 142666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142666&action=edit Bug 31986: Add page-section to various administration pages This patch adds a page-section div to some administration pages in order to provide a consistent structure visual contrast. The following pages are modified: Additional fields Funds Authority types Authority types -> MARC tag structure Authority types -> MARC tag structure -> Subfields MARC bibliographic framework MARC bibliographic framework -> MARC tag structure MARC bibliographic framework -> MARC tag structure -> Subfields MARC Bibliographic framework test Classification configuration Currencies and exchange rates EDI accounts Library EANs Item search fields Koha to MARC mapping Record overlay rules Record matching rules OAI sets configuration SMTP servers Z39.50/SRU servers To test, view each page to confirm that the page-section div visibly delineates the main content area. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 13:16:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 11:16:22 +0000 Subject: [Koha-bugs] [Bug 31905] Buttons lack spacing on Holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 13:33:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 11:33:58 +0000 Subject: [Koha-bugs] [Bug 31905] Buttons lack spacing on Holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 13:34:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 11:34:02 +0000 Subject: [Koha-bugs] [Bug 31905] Buttons lack spacing on Holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 --- Comment #3 from Owen Leonard --- Created attachment 142667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142667&action=edit Bug 31905: Fix button spacing on holds page This patch makes minor modifications to the holds template in order to improve the display of the hold buttons related to existing holds. The patch also adds "display:none" to the hold cancellation fieldset so there isn't a flash of content before JavaScript hides it. To test, apply the patch and locate a record in the catalog. - Place one or more holds on the record. - View the holds for that record. - Under the "Existing holds" heading there should be a toolbar of buttons which sits above the page-section div. The buttons should be well spaced. - If you have cancellation reasons defined in authorized values, the "Cancel selected" button should correctly trigger a modal with the option to specify a cancellation reason. - The display should work well for any setting of the HoldsSplitQueue system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 13:37:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 11:37:17 +0000 Subject: [Koha-bugs] [Bug 31985] Define default value for 008 field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31985 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Summary|dfine default value for 008 |Define default value for |field |008 field Component|bugs.koha-community.org |Cataloging CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 13:40:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 11:40:19 +0000 Subject: [Koha-bugs] [Bug 31947] [Omnibus] Add 'btn-primary' to the main action button where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 --- Comment #2 from Owen Leonard --- The staff client is currently on Bootstrap 3.x, so this is what we have to work with now: https://getbootstrap.com/docs/3.3/css/#buttons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 13:40:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 11:40:38 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #26 from Lari Taskula --- (In reply to David Nind from comment #25) > For step 8, I added two item level holds for the same patron - I hope that > is what was required. Yes that's correct. > My only suggestion would be to change the "Details" column label to "Hold > type". It looks like the details column can also contain a "Non priority hold" text. If we were to rename the column, can we consider "non priority hold" as a "hold type", or does hold type just mean an item/biblio hold? https://github.com/Koha-Community/Koha/blob/48bf9b1d91dbbc336f859ac1a83d7d25b0e6a3c1/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc#L189-L191 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 14:28:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 12:28:31 +0000 Subject: [Koha-bugs] [Bug 31987] New: Update plugin unimarc_field_110.pl fields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987 Bug ID: 31987 Summary: Update plugin unimarc_field_110.pl fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: thibaud.guillot at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Actually some fields are missing in plugin unimarc_field_110 it could be great to update it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 14:31:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 12:31:54 +0000 Subject: [Koha-bugs] [Bug 31969] Options for cleanup_database.pl to remove finished jobs from the background job queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31969 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 14:31:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 12:31:58 +0000 Subject: [Koha-bugs] [Bug 31969] Options for cleanup_database.pl to remove finished jobs from the background job queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31969 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142603|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 142668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142668&action=edit Bug 31969: Add background queue options to cleanup_database This patch adds background queue options to cleanup_database.pl to allow for purging completed background jobs. --bg-jobs DAYS Purge all finished background jobs this many days old. Defaults to 1 if no DAYS provided. --bg-type TYPE What type of background job to purge. Defaults to "update_elastic_index" if omitted Specifying "all" will purge all types. Repeatable. To test: 1 - Enable elastic search in Koha 2 - perl misc/maintenance/touch_all_items.pl 3 - Generate an number of diffrent types of bg-jobs (eg batch_hold_cancel, batch_biblio_record_deletion, batch_item_record_deletion) 4 - Check db and note there are a bunch of diffrent jobs 5 - Update to make them old UPDATE background_jobs SET ended_on = '2022-10-01 00:00:00', status='finished' 6 - perl misc/cronjobs/cleanup_database.pl 7 - Note bg-jobs entry shows in help 8 - perl misc/cronjobs/cleanup_database.pl --bg-jobs 1 -v 9 - Note that elasticqueue would have been cleared 10 - perl misc/cronjobs/cleanup_database.pl --bg-jobs 1 -v --confirm 11 - Note that number of entries deleted is reported 12 - Attempt to clear other job types, including "all" eg perl misc/cronjobs/cleanup_database.pl --bg-jobs 1 --bg-type batch_item_record_deletion -v --confirm perl misc/cronjobs/cleanup_database.pl --bg-jobs 1 --bg-type all -v --confirm 13 - Confirm in staff interface that jobs are gone: http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl (Uncheck 'Current jobs only') Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 14:36:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 12:36:05 +0000 Subject: [Koha-bugs] [Bug 31987] Update plugin unimarc_field_110.pl fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 14:36:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 12:36:09 +0000 Subject: [Koha-bugs] [Bug 31987] Update plugin unimarc_field_110.pl fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987 --- Comment #1 from Thibaud Guillot --- Created attachment 142669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142669&action=edit Bug 31987: Update plugin unimarc_field_110 fields According to https://www.ifla.org/wp-content/uploads/U_B_110_update2021_ONLINE_FINAL.pdf Test plan: 1) Be sure to manage unimarc 110 field in your bibliographic framework 2) Edit a record and click on plugin unimarc_110_field input to see new select values Current status: NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 14:40:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 12:40:23 +0000 Subject: [Koha-bugs] [Bug 31969] Options for cleanup_database.pl to remove finished jobs from the background job queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31969 --- Comment #8 from Björn Nylén --- (In reply to Frédéric Demians from comment #6) > Thanks Björn for your patch. Have you considered putting the code of your > PurgeBackgroundJobs function into Koha::BackgroundJobs as a class method? > This > could be used from elsewhere, the WUI for example, and from > cleanup_database.pl > like that: > > Koha::BackgroundJobs::purge(10, 'all', 1); Might be an idea. Easy to do but writing the needed tests is a bit of a pain ( for me at least :) ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 14:49:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 12:49:43 +0000 Subject: [Koha-bugs] [Bug 31988] New: manager.pl is only user for "Catalog by item type" report Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31988 Bug ID: 31988 Summary: manager.pl is only user for "Catalog by item type" report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org This is an odd script - it looks like the intent was to have one script that could call various reports. We have a single "plugin" for the reports - itemtypes.plugin We should convert this to a regular report script -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 14:49:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 12:49:53 +0000 Subject: [Koha-bugs] [Bug 31988] manager.pl is only user for "Catalog by item type" report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31988 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 14:53:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 12:53:04 +0000 Subject: [Koha-bugs] [Bug 31905] Buttons lack spacing on Holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 14:53:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 12:53:08 +0000 Subject: [Koha-bugs] [Bug 31905] Buttons lack spacing on Holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142667|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 142670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142670&action=edit Bug 31905: Fix button spacing on holds page This patch makes minor modifications to the holds template in order to improve the display of the hold buttons related to existing holds. The patch also adds "display:none" to the hold cancellation fieldset so there isn't a flash of content before JavaScript hides it. To test, apply the patch and locate a record in the catalog. - Place one or more holds on the record. - View the holds for that record. - Under the "Existing holds" heading there should be a toolbar of buttons which sits above the page-section div. The buttons should be well spaced. - If you have cancellation reasons defined in authorized values, the "Cancel selected" button should correctly trigger a modal with the option to specify a cancellation reason. - The display should work well for any setting of the HoldsSplitQueue system preference. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 14:53:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 12:53:25 +0000 Subject: [Koha-bugs] [Bug 31989] New: Catalog by item type report should allow specifying home or holding branch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31989 Bug ID: 31989 Summary: Catalog by item type report should allow specifying home or holding branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The counts are hard coded to holdingbranch - some libraries may prefer to count by items they 'own' - i.e. homebranch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 15:45:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 13:45:14 +0000 Subject: [Koha-bugs] [Bug 31947] [Omnibus] Add 'btn-primary' to the main action button where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 --- Comment #3 from Martin Renvoize --- Must admit a assumed it t was btn-primary that had been used until I went to fix a case.. at which point I got totally confused... Another one to get added to the guidelines.. how and when to use it -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 15:45:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 13:45:22 +0000 Subject: [Koha-bugs] [Bug 31986] Add page-section to various administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 15:45:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 13:45:29 +0000 Subject: [Koha-bugs] [Bug 31986] Add page-section to various administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142666|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 142671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142671&action=edit Bug 31986: Add page-section to various administration pages This patch adds a page-section div to some administration pages in order to provide a consistent structure visual contrast. The following pages are modified: Additional fields Funds Authority types Authority types -> MARC tag structure Authority types -> MARC tag structure -> Subfields MARC bibliographic framework MARC bibliographic framework -> MARC tag structure MARC bibliographic framework -> MARC tag structure -> Subfields MARC Bibliographic framework test Classification configuration Currencies and exchange rates EDI accounts Library EANs Item search fields Koha to MARC mapping Record overlay rules Record matching rules OAI sets configuration SMTP servers Z39.50/SRU servers To test, view each page to confirm that the page-section div visibly delineates the main content area. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 15:49:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 13:49:45 +0000 Subject: [Koha-bugs] [Bug 31986] Add page-section to various administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- I've signed off as the mentioned pages now have the page-sections. Some notes and observations - may need separate bugs if required/or have not yet been created. Needs div class: - OIA sets configuration > [OIA set] > Actions > Define mappings (http://127.0.0.1:8081/cgi-bin/koha/admin/oai_set_mappings.pl?id=1) Misaligned add and modify forms: - Authority types > New authority type (http://127.0.0.1:8081/cgi-bin/koha/admin/authtypes.pl?op=add_form) - Authority types > Modify authority type (http://127.0.0.1:8081/cgi-bin/koha/admin/authtypes.pl?op=add_form&authtypecode=GEOGR_NAME) - Add/modify forms in general: Submit / Cancel buttons area at bottom of form has extra white space before buttons, for example: New Z39.50 server Other: - Currencies and exchange rates: DataTables look is different from the standard look - EDI accounts: enable the EDIFACT system preference - Item search fields: first add works OK, trying to add another 'New search field' results in a blank page (http://127.0.0.1:8081/cgi-bin/koha/admin/items_search_fields.pl) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 15:53:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 13:53:26 +0000 Subject: [Koha-bugs] [Bug 31990] New: Shibboleth may redirect to opac if intranet and staff is served on same hostname. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31990 Bug ID: 31990 Summary: Shibboleth may redirect to opac if intranet and staff is served on same hostname. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: bjorn.nylen at ub.lu.se QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org The issue seems to be caused by the session interface being stuck to 'opac' if you serve both intranet and opac on the same hostname (different ports) and you visit the opac page before trying to log into intranet. Using the same hostname will result in opac and intranet using the same session cookie, ie same session which may confuse things. Repoducable in koha testing docker: 1. Enable shibboleth in koha-conf.xml and add a stub configuration userid 2. Resatart everything 3. Visit opac 4. Visit staff. The shib-login link will be to the opac url. Visiting staff before opac will not do the opposite though. Issue arised when we upgraded to 22.05. Possibly a side effect of Bug 29915 or Bug 29914? Not familiar enough to actually say. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 16:14:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 14:14:06 +0000 Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another branch if it already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138503|0 |1 is obsolete| | --- Comment #7 from ByWater Sandboxes --- Created attachment 142672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142672&action=edit Bug 24616: Allow copying notice to a branch even if it exists in that branch If you try to copy notice or slip to a branch which already has that notice or slip Koha won't let you save it. Instead pop-up saying branch already has that notice is displayed. This patch allows users to copy and override already existing notice or slip. To test: 1. Find notice which exists e.g. in all branches and branch A. 2. Copy that notice, add notice screen is displayed. 3. Press save. => Pop-up informing that notice already exists in branch A is displayed. 4. Apply this patch. 5. Repeat steps 2. and 3. 6. Pop-up to confirm overwrite of notice is displayed. => Confirm that if you press OK, notice is saved succesfully. => Otherwise, changes to notice should not be saved. Also try to save the notice you tested with as a new (same code) to branch A. Confirm that pop-up is displayed as it should be. Sponsored-by: Koha-Suomi Oy Signed-off-by: Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 16:14:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 14:14:39 +0000 Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another branch if it already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 26 16:16:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Oct 2022 14:16:32 +0000 Subject: [Koha-bugs] [Bug 31991] New: Restore style of sidebar forms Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31991 Bug ID: 31991 Summary: Restore style of sidebar forms Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 30952 A lot of changes were made the the style of sidebar forms (usually filter forms in an