[Koha-bugs] [Bug 24860] Add ability to place item group level holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #133 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
1) Unit tests

> I've not seeing what module is missing tests. I've added tests for
> AddReserve already! Is there one I missed? 

Doing some code review and... there are some more *hides*

Maybe discuss with Martin which ones should be included in tests:

* C4/HoldsQueue.pm 
  * GetHoldsQueueItems 
  * GetPendingHoldRequestsForBib
  * MapItemsToHoldRequests 

C4/Reserves.pm
  * AddReserve (covered)
  * CheckReserves
  * _Findgroupreserve

Koha/Hold.pm
  * item_group
  * forced_hold_level

Koha/REST/V1/Holds.pm
  * add

2) Fixes some smaller stuff in 2 follow-ups, please have a look!

3) Holds to pull is off

First my test case: 
* Added 9 items to a record, 3 each for vol. 1-3 in enumchron 
* Grouped them into 3 item groups
* In the OPAC, I placed a hold onto the volume 2 group

In /circ/pendingreserves.pl it shows wrong information:
* 39999000005776 or any available.
* Available enumchron: vol. 1, vol. 2, vol. 3
* There is no information that only volume 2 is wanted.

4) Holds queue 

Explodes:
C4::HoldsQueue::GetHoldsQueueItems(): DBI Exception: DBD::mysql::st execute
failed: Unknown column 'item_group_items.item_group_id' in 'on clause' at
/kohadevbox/koha/circ/view_holdsqueue.pl line 51
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77

I've run a dbic and a restart_all, but the problem remains. The column exists
in my database:

describe item_group_items;
+---------------------+---------+------+-----+---------+----------------+
| Field               | Type    | Null | Key | Default | Extra          |
+---------------------+---------+------+-----+---------+----------------+
| item_group_items_id | int(11) | NO   | PRI | NULL    | auto_increment |
| item_group_id       | int(11) | NO   | MUL | 0       |                |
| item_id             | int(11) | NO   | UNI | 0       |                |
+---------------------+---------+------+-----+---------+----------------+

-- 
You are receiving this mail because:
You are watching all bug changes.