[Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing in facet

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi, thx for the patch!

Some things:

1) The database update is not idempotent, meaning that you cannot run it a
second time without it causing an error:

DEV atomic update
/kohadevbox/koha/installer/data/mysql/atomicupdate/bz27136-Add_languages_for_facet.pl
 [22:55:29]: Bug 27136 - Add missing language information for facets
ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry
'cr-language' for key 'uniq_lang' at /kohadevbox/koha/C4/Installer.pm line 739

As we had some issues with that in recent update (bug 30951), I think it would
be better to implement some kind of check.

2) Next time it would be better to have these in 2 separate bugs:
* Add languages
* Avoid displaying nothing in facets

Both are distinct issues and in separate patches it gives better advertising in
release notes and better chances one or the other might get backported. A
strategy of small granular steps usually also works to make your patches move
faster.

Maybe a suggestion: We could make this one about adding the languages only as
the patches are nice and separate. I tihnk I agree with Nick about not
displayin the empty ones, as they can't be searched for - but this discussion
could be continued on bug 29561. OK?

-- 
You are receiving this mail because:
You are watching all bug changes.