[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711

--- Comment #77 from Peter Vashchuk <stalkernoid at gmail.com> ---
Created attachment 141270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141270&action=edit
Bug 25711: (QA follow-up) Remove leftover code and fix atomic update

This patch finalizes another one which deprecates
ExpireReservesMaxPickUpDelayCharge.
Because we had multiple smart-rules with undefined "expire_reserves_charge"
values, this patch updates actomic update to set not only the general All/All
smart-rule row to deprecated ExpireReservesMaxPickUpDelayCharge value but also
every smart-rule that fall back to default value in "expire_reserves_charge".

Also removed additional leftovers in template which earlier expected to show
hyperlink to syspref ExpireReservesMaxPickUpDelay.

To check if atomic update functions correctly:
1) Go to syspref and set ExpireReservesMaxPickUpDelay as "allow", set
ExpireReservesMaxPickUpDelayCharge to some numerical value (that will be your
default value), for example "42".
2) Go to smart rules page and create three rules: a rule with empty "Expire
reserve charge" value, then create another one rule with "Expire reserve
charge" vaue "0", and then another rule with "Expire reserve charge" value set
to any number, for example "12".
3) Apply the patch, and run the atomic update via the installer page.
4) Return to the smart rules page and check those rules you created in step 2:
- That one rule that you set as empty, now should have "Expire reserve charge"
equal 42, i.e. that one you set to the value you set
ExpireReservesMaxPickUpDelayCharge in step 1.
- All rules that had numerical values set previously should have been exist
untouched.

-- 
You are receiving this mail because:
You are watching all bug changes.