[Koha-bugs] [Bug 31619] Cannot select title when setting non-default value for OPACSuggestionMandatoryFields

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #7 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to Marcel de Rooy from comment #6)
> Thanks for your patch, Galen.
> Note that title does not belong to biblioitems, but to biblio.

The patch adds an entry for "title" as a column in the suggestions table, not
biblio nor biblioitems.

> And that the pref explains that title is always mandatory and therefore not
> listed. You cannot deselect it.
> So we either skip this change or move the explanation to the popup form
> somehow?

Without the patch, any attempt to change the value of
OPACSuggestionMandatoryFields to a non-default value will cause the title to
not be marked as required; the "title" field is not permanently considered
required by the code that reads the value of the system preference unless that
preference value is blank.

Setting status back to signed off and requesting re-review.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.