[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380

--- Comment #39 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tomás Cohen Arazi from comment #38)
> I think we need some more tests here, particularly for the 'staff_authorize'
> and 'prepare_template', unless I'm missing something. I noticed at first
> glance a subtle issue with __koha__user__ vs. __koha_user__ that is not
> caught by the provided tests.

Yep, can certainly do that, when I have some time. 

> It would be great (also) if you could perltidy some of this code. I usually
> select the code I want to tidy, and just ctrl+k ctrl+f on VScode. Please do
> it inline. Thanks!

What's the issue? I think it passed the QA tools, so that should've pointed out
any perltidy issues?

Because I'm on Windows, I need to do all my editing within the Docker
container, so no VScode for me. But it looks like KTD has a ":Tidy" command in
Vim, so I could use that. 

But this is fresh code that I thought I was writing in accordance with the Koha
Coding Guidelines? Do we need to update those or am I just out of date?

-- 
You are receiving this mail because:
You are watching all bug changes.