[Koha-bugs] [Bug 31676] New: Fix db_dependent/Circulation.t tests

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676

            Bug ID: 31676
           Summary: Fix db_dependent/Circulation.t tests
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: glasklas at gmail.com
        QA Contact: testopia at bugs.koha-community.org

A lot of tests in db_dependent/Circulation.t are currently failing, many seems
to have done so for quite a while so it's a bit puzzling how this has gone
under radar for such a long time.

If any of the changes are unclear I'm happy to expand more on the different
addressed issues.

A short summary of the changes:

- The patron attribute autorenew_checkouts was added a while ago, patrons for
some tests needed this set to preserve previous behavior

- OverduesBlockRenewing-test relied on a state that was mutated by new tests,
these have been moved to a place where the state is as was before this
regression.

- The test "AddRenewal left both fines" broke when account line statuses where
refactored (probably), there should be one one fine

- Fixed a test which expects 'auto_to_soon' error. CanBookBeRenewed will not
return this status unless the $cron parameter is set to true

- "Incremented fee tests" builds an item with missing "library" parameter since
treating the library object as a hashref. This cases a circulation-rule not
match and serveral tests fail as a result.

- The "AddIssue records staff who checked out item if appropriate" subtest
treats some objects as hashrefs when retrieving properties, and also checks the
wrong issue objects in the last test.

-- 
You are receiving this mail because:
You are watching all bug changes.