[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Tomás Cohen Arazi from comment #19)
> I disagree with the 'all or nothing' argument. That's why some really nice
> devs have sitted for years without people willing to test them.

Maybe we are not on the same level here? But imo you want all or nothing, and I
recommend a gradual approach. Note that we several prefs using other separators
still.

> I don't like the idea of over-complicating it with a separator param (that
> will need to have its own unit tests, handling the escaping that is required
> on each case, etc). But...

This really should be trivial. 

> ... Now that I think about this, we could probably just stick to YAML
> internally on the DB. And not even deal with splitting manually.

Sounds good but also a larger project.

> PS: Honestly, I didn't know what to answer to your comment. The amount of
> time needed to do the separator thing is probably the same as moving
> sysprefs into making them all use the same separator. And I have my personal
> preferences on what to spend time on too heh

You say All or nothing here?

-- 
You are receiving this mail because:
You are watching all bug changes.