[Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Signed Off                  |Failed QA

--- Comment #51 from Nick Clemens <nick at bywatersolutions.com> ---
Minor QA tool failure

Why use AV for consents? Looking ahead to bug 20380 it seems the consents will
have more options - maybe we could create a 'consent_types' table and use that?

Currently too - branch limits are half implemented - I don't see the tab if my
only consent is branch limited - but I can force go to the page and see the
consent options - was this a plan, or a side effect of choosing AV?

The description displays in the form, but the title is still the AV - can let
go in light of 31570, but it is lees friendly to see "Consent for
GDPR_PROCESSING"


+use constant AV_CONSENT => 'PATRON_CONSENT';
Why not just use the string in the search? Same question for existing:
 use constant GDPR_PROCESSING => 'GDPR_PROCESSING';

-- 
You are receiving this mail because:
You are watching all bug changes.