[Koha-bugs] [Bug 28950] serialsUpdate cron does not mark an issue late until the next issue is expected

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Oct 7 12:12:29 CEST 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28950

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140462|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 141487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141487&action=edit
Bug 28950: Mark serial late when past grace period

This script had some oddities:
- There was a LEFT JOIN to subscription, but no error printed if no
subscription
  I changed this to a JOIN as there is a constraint, so this shoudl not happen
- Publisheddate was checked after the SQL, moved into query
- We checked for the next issue, and marked late only if that issue was already
expected
  This overruled grace period, which should be the mnarker for a serial being
late
  The grace period should be extended if you wish to wait for next issue
- If no next published date, we reported an error on the planneddate
- Script without confirm had no reporting

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list