[Koha-bugs] [Bug 31718] Change the IF ELSE values in marc_subfields_structure breadcrumbs to facilitate translation

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #9 from David Nind <david at davidnind.com> ---
Testing notes (using KTD)
-------------------------

I checked the default framework and the BKS framework.

First patch - breadcrumbs when viewing and editing subfields (changes to a
single span tag for the framework name):
- View the page source
- Search for breadcrumbs
- Before the patch is applied - default framework:
  <span>Default</span>
  <span>framework structure</span>
- After the patch is applied - default framework:
   <span>Default framework structure</span>
- Before the patch is applied - BKS framework:
    BKS
  <span>framework structure</span>
- After the patch is applied - BKS framework:
   <span>BKS framework structure</span>

Second patch - step 1 - view subfields:
- View the page source
- Search for <h1>
- No change to output for h1 before and after the patch is applied:
  . Default framework: <h1>MARC subfield structure admin for 245 (default
framework)</h1>
  . BKS framework: <h1>MARC subfield structure admin for 245 (framework
BKS)</h1>
  . Updates code for template so that it is consistent with other changes (I
think)
- Breadcrumbs: changes as per the first patch

Second patch - step 2 - add, edit and delete a MARC tag:
- View the page source
- Search for breadcrumbs
- After patch is applied: <span> tags added to breadcrumbs where required

Second patch - step 3: Framework table:
- View the page source
- Search for Repeatable
- Check the first row of results:
  ==> should now have <span> tags around all the Nos and Yeses

I also noticed that when deleting a tag from the view subfields page that there
is an 'i' added to the breadcrumb, for example:
- Home > Administration > MARC frameworks > BKS framework structure > Tag 245
Subfield structure > Confirm deletion of subfield ci
- Should be ... Confirm deletion of subfield c

I've created bug 31724 for this.

-- 
You are receiving this mail because:
You are watching all bug changes.