[Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727

Kevin Carnes <kevin.carnes at ub.lu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kevin.carnes at ub.lu.se
                   |ity.org                     |
                 CC|                            |kevin.carnes at ub.lu.se

--- Comment #3 from Kevin Carnes <kevin.carnes at ub.lu.se> ---
Thank for catching these problems. I made the false assumption that the
database table was only for the first table of rules and I used the template
name instead of the database column name for unseen_renewals_allowed.

I've made an atomic update that removes these rules when there is no
suspension_chargeperiod rule (this is a rule that should be made when saving
the first table of rules). It also renames any remaining unseenrenewalsallowed
to unseen_renewals_allowed.

It would be helpful if somebody else could check this to make sure it's right.
It's possible that suspension_chargeperiod is not a accurate check or it might
be better to only delete them if the still have the default values. All
corrections are appreciated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.