[Koha-bugs] [Bug 31727] Orphan records in circulation_rules and false positives after attempt to fix values to be empty or zeroes instead of missing

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31727

--- Comment #12 from Kevin Carnes <kevin.carnes at ub.lu.se> ---
(In reply to David Nind from comment #9)
> Created attachment 141618 [details]
> Bug 31727 - Database query results from testing
> 
> I've had a go at testing (using KTD).
> 
> After step 9, I have one extra rule - I'm not sure if this is an issue.
> 

That extra rule is because I used the wrong name for the
unseen_renewals_allowed rule. So if there were already rules that had an
unseen_renewals_allowed, they now also have an unseenrenewalsallowed rule since
it is added when there is no "unseenrenewalsallowed" rule.

I think the solution is to remove "unseenrenewalsallowed" rules when there is a
similar "unseen_renewals_allowed" rule, before renaming the remaining
"unseenrenewalsallowed" to "unseen_renewals_allowed".

Another option, especially now that you have an extra duplicate, is to remove
an "unseen_renewals_allowed" rule when then are two for same parameters.

-- 
You are receiving this mail because:
You are watching all bug changes.