[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #80 from David Cook <dcook at prosentient.com.au> ---
(In reply to Agustín Moyano from comment #78)
> > (#NOTE: The UI looks poorly formatted, but I think that's probably a symptom
> > of the new staff interface styling. Not a blocker for me. This can be fixed
> > later...)
> 
> Sorry, it's been a long time since I've done anything related to Koha.. If
> you could point me to a well formated page, I'll try to stick to the style
> as much as possible

I'm not familiar with the new staff UI myself, but I think you'll be able to
see what I mean at a glance. On CRUD pages, the labels and fields aren't
aligned correctly in all cases at the moment.

> > (#NOTE: With the new Staff Interface, there should be a "Help" link on the
> > right hand side, but I don't see it for this new functionality. I think
> > that's a blocker.)
> 
> Ok, I'll ask Tomas for help about how this shoul be done

Sounds good. I think it might involve the Koha/Manual.pm file. (I just noticed
it on a different issue report earlier today.)

> > (#NOTE: I don't really like having to include raw JSON in this UI. This
> > could be made more beautiful.)
> 
> Me neither, there should be a JSON editor or something.. does Koha have one?

Not that I know of. Rather, I meant it would make sense to just have a regular
HTML form and translate that into JSON on the backend. 

> As I said, I do not believe these patches to be at the latest version.. now
> the user gets redirected to the login page (staff or opac) with error message

Looking forward to testing the next round!

> > 10. If I logout of Keycloak and try to log back into http://localhost:8080/
> > via Keycloak, I get the following:
> > There was an error authenticating to external identity provider
> > Can't call method "auto_register" on an undefined value at
> > /kohadevbox/koha/Koha/REST/Plugin/Auth.pm line 66.
> 
> Strange, I'll have to check that out

I wasn't able to reproduce it again so might've just been a bit glitchy due to
restarts/Keycloak logouts/etc. Might not need to worry about it.

-- 
You are receiving this mail because:
You are watching all bug changes.