[Koha-bugs] [Bug 31644] MARCModification template fails to copy to/from subfield 0

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Oct 21 09:46:25 CEST 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31644

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141938|0                           |1
        is obsolete|                            |

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 142300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142300&action=edit
Bug 31644: Add copy test and clarify some functions

This patch adds a tst for copy without subfields. I also clarify what eachstep
does
so the next user/coder understands current behaviour

Update existing or add new: In the case where the field/subfield exists
we update, if we have two fields - one with the subfield, and one without, we
add the subfield to the one without

Copy field:
 - If given a subfield - we will add to existing fields in the record
 - If not given a subfield - we create an entirely new field

The logic of all of this is tricky, makes sense in a certain light, any
complaints
are for a new bug :-)

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list