[Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
I don't think we're quite there yet :/

Without the patch, in English, when we select let's say 'Add and append' and
save the rule, the words 'Add and append' still appear in the preset column of
the saved rule. With the patch, the preset is saved as 'Custom'

1. Without the patch, go to Administration > MARC overlay rules
2. Enter the following rule
   - Module: Source
   - Filter: Staged MARC import
   - Tag: 6..
   - Preset: Add and append
3. Click 'Add rule'
   --> In the 'Preset' column, the saved rule says 'Add and append'
4. Delete the rule (click 'Delete' and confirm)
5. Apply the patch
6. Redo steps 2-3
   --> In the 'Preset' column, the saved rule says 'Custom'


I also noticed, after I applied the patch and updated my po's (`gulp po:update
--lang fr-CA`) that I still had two strings "User category"

#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:159
#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:161
#, c-format
msgid "User category"
msgstr "Catégorie d'utilisateurs"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.