[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |rel_22_05_candidate
             Status|ASSIGNED                    |In Discussion

--- Comment #33 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I'm reverting this one for now. The reason is the failures in
t/db_dependent/Koha/Items.t look problematic or at least complex enough for
requiring a new review. With the new method and the changes made, the
$processfee_amount of 20 is being charged when it shouldn't so at least the
tests need to be adjusted to clear the whole scenario we are testing.

I noticed that Nick's follow-up merging the methods introduced a failure in
t/db_dependent/Koha/Item.t that I fixed by breaking things as well. Remarkably,
with my broken follow-up nothing changed regarding the tests results...

I'm adding the rel_22_05_candidate so this dev has the chance to get in beyond
the soft freeze, but please hurry. We can go without Nick's little refactoring
for now BTW, and think about it later.

Looking forward to your comments and follow-ups.

-- 
You are receiving this mail because:
You are watching all bug changes.