[Koha-bugs] [Bug 31984] New: TaxRate system preference - incorrect default value used and warning message on order form

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31984

            Bug ID: 31984
           Summary: TaxRate system preference - incorrect default value
                    used and warning message on order form
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: david at davidnind.com
        QA Contact: testopia at bugs.koha-community.org

For the TaxRate system preference:

1. The description [1] says that the first value entered will be used by
default.

2. When entering an order for a basket, the last value in the list is selected
as the default (19.65%).

3. If the values for the TaxRate system preference are changed, for example
having the values: 0.15|0.20:
   - 19.65% is shown as the default value, even though it is not a value
entered in the TaxRate system preference
   - There is a warning for the 'Tax rate' input field for the order: "Tax rate
not defined in system preference TaxRates!"
   - The tax inclusive values for budgets/funds are calculated correctly if you
choose another option, despite the warning message.

To replicate:
1. Check that there are values entered for the TaxRates system preference (in
KTD the values entered are: 0|0.12|0.1965).
2. Create a new basket (or use an existing one).
3. Add a new order to the basket.
4. On the accounting details form, note that the default value for the 'Tax
rate' field is 19.65% and the other options are 0% and 12%.
5. Complete adding the order to the basket.
6. On the acquisitions home page, note that the ordered amount is tax inclusive
and is calculated correctly.
7. Change the TaxRates system preference to: 0.15|0.20
8. Repeat steps 2-3.
9. Note that on the accounting details form for the 'Tax rate' field:
   . the options available are 15%, 20%, and 19.65%, with the 19.65% shown as
the default - even though 19.65% is not a value entered for the system
preference
   . there is a warning for the field: "Tax rate not defined in system
preference TaxRates!"
10. Select the 15% option, and repeat steps 5-6. The tax inclusive amount is
correctly calculated, despite the warning that was on the form.

[1] Current description in master, with default values used in KTD:
Tax rates are [0|0.12|0.1965]. Enter in numeric form, 0.12 for 12%. The first
item in the list will be selected by default. For more than one value, separate
with | (pipe). Please note: The database will only accept values up to 4
decimals precision, further values will be rounded.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.