[Koha-bugs] [Bug 32011] 2FA - Problem with qr_code generation

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Oct 28 08:51:06 CEST 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011

--- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Marcel de Rooy from comment #8)
> Without this patch on commit fd7bc8a9b8de5a8fdea36b046e4621760366dbf0, 2FA
> seems to work just fine on Debian 11 via the interface.
> 
> The Selenium stuff is another story. But it should not dictate us to make
> changes just to pass Selenium imo.

It's failing randomly, so you may not notice it via the interface with only a
couple of tries.

> Jonathan: Please provide some more details on the system you are running on.
> And could you confirm that the interface does not work either anymore on
> your system? If not, this is not a major bug. But maybe just a Selenium
> issue?

I am pretty sure it's not a selenium issue, it's coming from the
Koha::REST::V1::TwoFactorAuth->registration. If the selenium test make it
fails, a normal browser can make it fail.

> I wouldnt mind not having these Selenium tests btw. But I could be biased :)

Lol, they are very strong and caught a bug here, so... We have some shitty
selenium/www tests, but those ones are great IMO.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list