[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi David,

1) QA scipt

Please run the QA tests on your patches before submitting, they are catching
lots of the tiny stuff that can otherwise hold things up unnecessarily. If you
are using ktd for development, you can just run: qa -v 2 from kshell.

OK      C4/Circulation.pm
 FAIL   Koha/Patron.pm
   FAIL   critic
                # Subroutines::ProhibitExplicitReturnUndef: Got 1 violation(s). 
   FAIL   pod coverage
                POD is missing for has_debarring_overdues
                POD is missing for trim_whitespaces

 FAIL  
installer/data/mysql/atomicupdate/bug_29145-modify_AutoRemoveOverduesRestrictions-syspref.pl
   FAIL   file permissions
                File must have the exec flag
   FAIL   spelling
                 prefernce ==> preference

 OK    
installer/data/mysql/atomicupdate/odue-debarment-removal-allow-unrestricted.pl
 OK     installer/data/mysql/mandatory/sysprefs.sql
 OK     misc/cronjobs/overdue_notices.pl
 FAIL   t/db_dependent/Circulation/MarkIssueReturned.t
   FAIL   spelling
                 remaning ==> remaining
                 remaning ==> remaining

I am providing a follow-up for the typos, but I'll need you to have a look at
the missing POD for has_overdues (trim_whitespace is a false one) and
especially the Perlcritic violation. I see that you have written a long comment
on has_overdues, so this is about reformatting this into a proper POD entry.

2) Bug number was missing from database update.

Fixed together with the typos in a follow-up patch.

3) Changes to Patron.pm

We don't have a hard rule here yet, but we should always avoid using SQL. I am
not sure if this qualifies as blocker right now as we don't have a written
rule, so leaving as a note.

Please fix 1)!

-- 
You are receiving this mail because:
You are watching all bug changes.