From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 00:41:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 22:41:29 +0000 Subject: [Koha-bugs] [Bug 23732] Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 01:53:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Aug 2022 23:53:22 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 --- Comment #18 from David Cook --- I tried to understand this without applying the patches, but it's too hard without the context, so let's see... I assume that the second patch "POC" is an alternative patch and not an additional patch... First patch: - adds apostrophe filter to "analyzer_standard" which is used for all default searches... - apostrophe strips out apostrophes Second patch: - Adds a "punc_removed" field (which uses the analyzer_stdno analyzer which already has a punctuation filter) to "default" under "search". If I understood Elasticsearch and Koha's integration better, I would probably understand this, but I don't currently. - Reading through Koha/SearchEngine/Elasticsearch.pm and https://www.elastic.co/guide/en/elasticsearch/reference/current/multi-fields.html it looks like "phrase", "raw", "ci_raw" and "punc_removed" are "fields" only used when queried specifically - In Koha/SearchEngine/Elasticsearch/QueryBuilder.pm adds title.punc_removed field to all Elastic queries. We do something similar in Zebra in C4::Search::_build_weighted_query() where we add title fields to search. I wonder a bit if adding title.punc_removed there will have unintended consequences but it seems similar to Zebra so might not be a big drama. Regarding Zebra, I don't think we can get full feature parity here. However, we could potentially add a Title-punc_removed index and update ./etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl to strip punctuation for it, and then add that into C4::Search::_build_weighted_query() (or elsewhere). -- I think the "POC" patch would need some testing to make sure there aren't any unintended consequences, but overall it sounds like a reasonable proposition. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 02:58:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 00:58:39 +0000 Subject: [Koha-bugs] [Bug 26692] Add barcode image generator service for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #41 from David Cook --- (In reply to Kyle M Hall from comment #40) > Looks great! I can see pros and cons to to having the javascript in the > opacjs method of the plugin. One one hand, it makes for a drop-in easy to > use plugin for librarians. On the other hand, it does "limit" how it can be > displayed if a library wants something different. I honestly think either > choice is good. You can always put the javascript in the the documentation. > > Do you have this in a public repo yet? We don't have any public repos at the moment, but I'll probably look at doing one at some point. For this plugin, it's just a proof of concept, so I figured I'd just upload it here for now. If my 1 client doesn't adopt it, I wouldn't work on it anymore, so probably wouldn't want to advertise it in a public repo at this point. I think that this code should actually be in core Koha, but I figured a plugin was a good way to rapidly prototype it, and a way to get it out to the client ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 06:22:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 04:22:23 +0000 Subject: [Koha-bugs] [Bug 31501] After upgrading to 22.05, I am not able to search Patrons. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31501 --- Comment #2 from Liny Varghese --- Thank you for the reply. borrowernotes are all ''. Also I can list all patrons with all details in borrowers report -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 08:16:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 06:16:43 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139366|0 |1 is obsolete| | --- Comment #58 from Marcel de Rooy --- Created attachment 140020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140020&action=edit Bug 29144: First sort the HTML options Test plan: Check result while adding a new HTML customization entry. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 08:16:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 06:16:48 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139367|0 |1 is obsolete| | --- Comment #59 from Marcel de Rooy --- Created attachment 140021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140021&action=edit Bug 29144: Add OpacBranchInfo as HTML option, show it on opac Test plan: Add a few OpacBranchInfo for libraries. Verify that opac-library shows the correct info per library. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 08:16:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 06:16:52 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139368|0 |1 is obsolete| | --- Comment #60 from Marcel de Rooy --- Created attachment 140022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140022&action=edit Bug 29144: (follow-up) Terminology: rename to OpacLibraryInfo git grep -l OpacBranchInfo | xargs sed -i -e's/OpacBranchInfo/OpacLibraryInfo/g' Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 08:16:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 06:16:57 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139369|0 |1 is obsolete| | --- Comment #61 from Marcel de Rooy --- Created attachment 140023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140023&action=edit Bug 29144: Add $contents->find_best_match, $library->opac_info Test plan: Run t/db_dependent/Koha/AdditionalContents.t Run t/db_dependent/Koha/Library.t Note: You may need to set ListOwnershipUponPatronDeletion to delete to fix a pending issue in patron->delete with lists. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 08:17:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 06:17:02 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139370|0 |1 is obsolete| | --- Comment #62 from Marcel de Rooy --- Created attachment 140024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140024&action=edit Bug 29144: Use ->opac_info in opac-library template The opac_info call uses find_best_match which does not result in the All libaries plus specific library response of AdditionalContents.get. Test plan: Revisit individual library page on OPAC. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 08:17:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 06:17:06 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139372|0 |1 is obsolete| | --- Comment #63 from Marcel de Rooy --- Created attachment 140025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140025&action=edit Bug 29144: Show html opac_info on opac-detail page Note: This patch disables the API call (which is not really needed), and still needs attention in a following patch. Test plan: Add opac_info for two libraries and a branchurl for one of the two. Select a biblio with an item having these two libraries as either home or holding branch. Toggle OpacLocationBranchToDisplay and check items table on opac detail. Click on the library name. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 08:17:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 06:17:13 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139373|0 |1 is obsolete| | --- Comment #64 from Marcel de Rooy --- Created attachment 140026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140026&action=edit Bug 29144: Adjust libraries form Test plan: [1] Go to Administration / libraries. [2] Check list view. [3] Check view on individual library with/without opac info. [4] Edit individual library with/without opac info. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 08:17:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 06:17:18 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139374|0 |1 is obsolete| | --- Comment #65 from Marcel de Rooy --- Created attachment 140027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140027&action=edit Bug 29144: Remove opac_info from a few tests Test plan: Run t/db_dependent/Circulation/GetHardDueDate.t Run t/db_dependent/Circulation/OfflineOperation.t Run t/db_dependent/RotatingCollections.t Run t/db_dependent/api/v1/libraries.t Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 08:17:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 06:17:23 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139375|0 |1 is obsolete| | --- Comment #66 from Marcel de Rooy --- Created attachment 140028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140028&action=edit Bug 29144: Copy and remove branches.opac_info (dbrev) Test plan: Run dbrev. Check api URL: /api/v1/public/libraries (with/without suffix /[branch_code]. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 08:17:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 06:17:27 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139376|0 |1 is obsolete| | --- Comment #67 from Marcel de Rooy --- Created attachment 140029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140029&action=edit Bug 29144: (DBIx schema) Drop branches.opac_info No test plan. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 08:17:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 06:17:31 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139377|0 |1 is obsolete| | --- Comment #68 from Marcel de Rooy --- Created attachment 140030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140030&action=edit Bug 29144: (follow-up) Fix rebase issue related to bug 31313 Fixing display of holding branch name. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 08:18:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 06:18:27 +0000 Subject: [Koha-bugs] [Bug 31496] Printslip.pl prints sco-using logged in patron's home branch to the slip instead of the staff member's which gives access to the sco. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496 Lari Strand changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lmstrand at gmail.com |ity.org | Status|NEW |Needs Signoff CC| |lmstrand at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 08:19:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 06:19:25 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139371|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 08:21:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 06:21:02 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #69 from Marcel de Rooy --- Rebased for 27272 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 08:48:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 06:48:33 +0000 Subject: [Koha-bugs] [Bug 31496] Printslip.pl prints sco-using logged in patron's home branch to the slip instead of the staff member's which gives access to the sco. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496 Lari Strand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140003|0 |1 is obsolete| | --- Comment #2 from Lari Strand --- Created attachment 140031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140031&action=edit Bug 31496: Fix branch in printslip.pl to signed in staff id's branch Test plan: 1) Make sure the staff id's branch (used to login into SCO patron view) is not the same as the patron's who is logging into SCO 2) Print a slip in SCO and notice patron's own branch printed in the slip 3) Apply patch 4) Print a slip in SCO and notice the branch is now the staff id's branch used to sign in to SCO patron view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 09:00:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 07:00:03 +0000 Subject: [Koha-bugs] [Bug 28841] Canceling holds from 'Holds awaiting pickup' should follow return policies regarding transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28841 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25426 CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 09:00:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 07:00:03 +0000 Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28841 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 09:14:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 07:14:03 +0000 Subject: [Koha-bugs] [Bug 31503] New: Groundwork for 20380 (mail consent) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Bug ID: 31503 Summary: Groundwork for 20380 (mail consent) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 10:12:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 08:12:15 +0000 Subject: [Koha-bugs] [Bug 31403] Activate circulation sidebar (CircSidebar system preference) on default in new installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31403 Isobel Graham changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 10:12:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 08:12:20 +0000 Subject: [Koha-bugs] [Bug 31403] Activate circulation sidebar (CircSidebar system preference) on default in new installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31403 --- Comment #2 from Isobel Graham --- Created attachment 140032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140032&action=edit Bug 31403: Enable CircSidebar by default on new installs This patch updates sysprefs.sql to enable the CircSidebar preference y default on new installs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 11:30:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 09:30:35 +0000 Subject: [Koha-bugs] [Bug 31503] Groundwork for 20380 (mail consent) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 11:32:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 09:32:05 +0000 Subject: [Koha-bugs] [Bug 20380] [OMNIBUS] Email consent patron opt-in tracking for anti-spam legislation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20380 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Email consent patron opt-in |[OMNIBUS] Email consent |tracking for anti-spam |patron opt-in tracking for |legislation |anti-spam legislation Blocks| |31503 --- Comment #2 from Marcel de Rooy --- I am making this report an omnibus to allow multiple developments. Adding some groundwork for this on bug 31503. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 [Bug 31503] Groundwork for 20380 (mail consent) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 11:32:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 09:32:05 +0000 Subject: [Koha-bugs] [Bug 31503] Groundwork for 20380 (mail consent) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20380 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20380 [Bug 20380] [OMNIBUS] Email consent patron opt-in tracking for anti-spam legislation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 11:49:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 09:49:17 +0000 Subject: [Koha-bugs] [Bug 31488] "You have checked out too many items" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31488 --- Comment #1 from Isobel Graham --- Created attachment 140033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140033&action=edit Bug 31488: Update Max checkout text This changes text from "you have checked out too many items" to "You have reached the maximum limit of items checked out". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 11:49:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 09:49:56 +0000 Subject: [Koha-bugs] [Bug 31488] "You have checked out too many items" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31488 Isobel Graham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |isobel.graham09 at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 11:50:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 09:50:10 +0000 Subject: [Koha-bugs] [Bug 8305] Add an icon for iOS home screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8305 Isobel Graham changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |isobel.graham09 at gmail.com CC| |isobel.graham09 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 11:50:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 09:50:47 +0000 Subject: [Koha-bugs] [Bug 31488] "You have checked out too many items" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31488 Isobel Graham changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |isobel.graham09 at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 12:14:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 10:14:20 +0000 Subject: [Koha-bugs] [Bug 8305] Add an icon for iOS home screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8305 Isobel Graham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 12:16:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 10:16:09 +0000 Subject: [Koha-bugs] [Bug 8305] Add an icon for iOS home screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8305 --- Comment #6 from Isobel Graham --- Created attachment 140034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140034&action=edit Bug 8305: Added an icon for iOS home screen 1. Bookmark the Koha OPAC on an iOS device 2. See if an icon is formed on the home screen of the device -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 12:38:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 10:38:34 +0000 Subject: [Koha-bugs] [Bug 31494] ILL breadcrumb improvement for ILL View action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31494 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30890 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 12:38:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 10:38:34 +0000 Subject: [Koha-bugs] [Bug 30890] ILL breadcrumbs are wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30890 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31494 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 12:39:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 10:39:22 +0000 Subject: [Koha-bugs] [Bug 31494] ILL breadcrumb improvement for ILL View action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31494 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 30890 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 12:39:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 10:39:22 +0000 Subject: [Koha-bugs] [Bug 30890] ILL breadcrumbs are wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30890 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- *** Bug 31494 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 12:39:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 10:39:46 +0000 Subject: [Koha-bugs] [Bug 30890] ILL breadcrumbs are wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30890 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |isobel.graham09 at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 12:48:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 10:48:25 +0000 Subject: [Koha-bugs] [Bug 31482] Label creator does not call decodebarcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Label creator does not call |Label creator does not call |item_barcode_transform |decodebarcode |plugin hook | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 12:49:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 10:49:50 +0000 Subject: [Koha-bugs] [Bug 31482] Label creator does not call barcodedecode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Label creator does not call |Label creator does not call |decodebarcode |barcodedecode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 12:50:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 10:50:55 +0000 Subject: [Koha-bugs] [Bug 31170] Capitalization: Overdue Item Fine Description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31170 --- Comment #1 from Isobel Graham --- Created attachment 140035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140035&action=edit Bug 31170: Decapatalized "Overdue Item Fine Description" I changed "Overdue Item Fine Description" to "Overdue item fine description" for both the name and title. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 12:51:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 10:51:41 +0000 Subject: [Koha-bugs] [Bug 31482] Label creator does not call barcodedecode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 12:51:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 10:51:44 +0000 Subject: [Koha-bugs] [Bug 31482] Label creator does not call barcodedecode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139997|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 140036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140036&action=edit Bug 31482: Label creator does not call barcodedecode The label creator can accept a list of either itemnumbers or item barcodes. In the case that the list of composed of barcodes, those barcodes should be passed though barcodedecode before the lookup is performed. Test Plan: 1) Apply this patch 2) Download and install the Barcode Transformer plugin https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/ 3) Go to the plugin configuration page, set the configuration to the example configuration from the same page 4) On the "New label batch" page of the Label creator,, type in some valid barcodes, but prefix them with X and postfix them with Y, e.g. X123456Y 5) Submit the form 6) Note the items are added to the label batch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 12:51:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 10:51:53 +0000 Subject: [Koha-bugs] [Bug 31170] Capitalization: Overdue Item Fine Description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31170 Isobel Graham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |isobel.graham09 at gmail.com Assignee|koha-bugs at lists.koha-commun |isobel.graham09 at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 12:52:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 10:52:27 +0000 Subject: [Koha-bugs] [Bug 31482] Label creator does not call barcodedecode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 13:14:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 11:14:32 +0000 Subject: [Koha-bugs] [Bug 30890] ILL breadcrumbs are wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30890 --- Comment #2 from Isobel Graham --- Created attachment 140037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140037&action=edit Bug 30890: Fixed ILL breadcrumb Added correct breadrumb depth when managing requests. 1. Viewing a request on a ILL request page 2. Making sure the breadcrumb has three depths and the manage requests has the correct request id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 13:15:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 11:15:05 +0000 Subject: [Koha-bugs] [Bug 30890] ILL breadcrumbs are wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30890 Isobel Graham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 13:41:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 11:41:53 +0000 Subject: [Koha-bugs] [Bug 29608] Editing numbering patterns does require full serials permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29608 --- Comment #2 from Isobel Graham --- Created attachment 140038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140038&action=edit Bug 29608: Made so doesn't require full permission Made so the numbering sequence does not need to require full permission. 1. Edit number patterns a confirm you don't need full permission -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 13:42:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 11:42:20 +0000 Subject: [Koha-bugs] [Bug 29608] Editing numbering patterns does require full serials permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29608 Isobel Graham changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |isobel.graham09 at gmail.com Assignee|koha-bugs at lists.koha-commun |isobel.graham09 at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 13:42:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 11:42:36 +0000 Subject: [Koha-bugs] [Bug 29608] Editing numbering patterns does require full serials permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29608 Isobel Graham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 13:45:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 11:45:24 +0000 Subject: [Koha-bugs] [Bug 28192] Archived credit/debit types should be filtered by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28192 Isobel Graham changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |isobel.graham09 at gmail.com Assignee|martin.renvoize at ptfs-europe |isobel.graham09 at gmail.com |.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 13:46:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 11:46:34 +0000 Subject: [Koha-bugs] [Bug 27490] Rename system preference language to StaffInterfaceLanguages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 Isobel Graham changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |isobel.graham09 at gmail.com Assignee|koha-bugs at lists.koha-commun |isobel.graham09 at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 13:49:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 11:49:56 +0000 Subject: [Koha-bugs] [Bug 30890] ILL breadcrumbs are wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30890 --- Comment #3 from Owen Leonard --- - [% ELSIF query_type == 'status' %] + [% ELSIF query_type == 'illview' %] Is the "status" query_type not used for anything? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 14:02:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 12:02:44 +0000 Subject: [Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #26 from Mason James --- (In reply to Victor Grousset/tuxayo from comment #25) > Backported: Pushed to 21.05.x branch for 21.05.17 > Nothing to document (not yet full support for ES 7), marking resolved. hi Victor can you push this for ES7 support, (i think it was missed) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 14:02:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 12:02:46 +0000 Subject: [Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 Bug 25439 depends on bug 28610, which changed state. Bug 28610 Summary: Elasticsearch 7 - hits.total is now an object https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 14:36:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 12:36:55 +0000 Subject: [Koha-bugs] [Bug 31504] New: ElasticSearch No indexing new records after upgrade Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31504 Bug ID: 31504 Summary: ElasticSearch No indexing new records after upgrade Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: hagud at orex.es After upgrading koha 21.11 to 22.05 ElasticSearch is not able to index new records. At webadmin we can see the warning 'Index 'koha_xxxxxx' needs to be recreated.' Executing 'Reset mapping' button doesn't fix the error... when trying to full reindex with option -d or -r it doesn't work admin at ___21:~$ sudo koha-elasticsearch --rebuild -d ___ sudo: unable to resolve host ___21: Name or service not known sudo: unable to resolve host ___21: Name or service not known Use of uninitialized value $reason in concatenation (.) or string at /usr/share/koha/lib/Koha/SearchEngine/Elasticsearch/Indexer.pm line 283. Exception 'Koha::Exception' thrown 'Unable to update mappings for index "koha_____biblios". Reason was: "". Index needs to be recreated and reindexed' Something went wrong rebuilding indexes for ___ Removing the index directly at ElasticSearch doesn't works * ElasticSearch is not localhost -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 14:51:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 12:51:39 +0000 Subject: [Koha-bugs] [Bug 31505] New: Improve etc/zebradb/lang_defs/nb/sort-string-utf.chr Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31505 Bug ID: 31505 Summary: Improve etc/zebradb/lang_defs/nb/sort-string-utf.chr Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no The current configuration does not distinguish between e.g. A and Å, so searching for "kårlstad" returns hits for "Karlstad". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 14:56:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 12:56:30 +0000 Subject: [Koha-bugs] [Bug 30627] koha-run-backups delete the backup files after finished its job without caring days option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30627 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23943 CC| |magnus at libriotech.no -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 14:56:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 12:56:30 +0000 Subject: [Koha-bugs] [Bug 23943] koha-run-backups --days is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23943 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30627 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 15:06:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 13:06:35 +0000 Subject: [Koha-bugs] [Bug 31506] New: Add "backup days" to /etc/koha/koha-common.conf Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31506 Bug ID: 31506 Summary: Add "backup days" to /etc/koha/koha-common.conf Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: mtj at kohaaloha.com koha-run-backups takes the --days argument to say how many days of backup we should keep around. The value of this is set to two in the default /etc/cron.daily/koha-common that is installed by the Debian packages. I routinely increase this value to keep more backup. One thing that can happen now is that I want to create fresh backups for all the sites on a server before doing an upgrade. So I run koha-run-backups manually, but I forget about the --days argument. Result: I loose a lot of backup! It would be nice if the default for --days could be set somewhere like /etc/koha/koha-common.conf. That way we could run koha-run-backups both from cron and manually, without the --days argument, and keep the same amount of backups either way. If --days is given as an argument, it should override the default. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 15:07:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 13:07:55 +0000 Subject: [Koha-bugs] [Bug 30976] Cover images for biblio should be displayed first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |tomascohen at gmail.com Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 15:08:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 13:08:03 +0000 Subject: [Koha-bugs] [Bug 30976] Cover images for biblio should be displayed first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 15:08:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 13:08:10 +0000 Subject: [Koha-bugs] [Bug 30976] Cover images for biblio should be displayed first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 15:08:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 13:08:19 +0000 Subject: [Koha-bugs] [Bug 30976] Cover images for biblio should be displayed first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 15:08:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 13:08:55 +0000 Subject: [Koha-bugs] [Bug 30976] Cover images for biblio should be displayed first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable Keywords| |rel_21_11_candidate --- Comment #9 from Tomás Cohen Arazi --- Hi, this broke 21.11.x detail page. I'm submitting a fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 15:10:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 13:10:57 +0000 Subject: [Koha-bugs] [Bug 30976] Cover images for biblio should be displayed first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 140039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140039&action=edit [21.11.x] Bug 30976: Make sure scalar context is used Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 15:24:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 13:24:52 +0000 Subject: [Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 15:53:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 13:53:49 +0000 Subject: [Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Frank Hansen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139855|0 |1 is obsolete| | Attachment #139856|0 |1 is obsolete| | --- Comment #44 from Frank Hansen --- Created attachment 140040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140040&action=edit 30280: Add support for subject headings from different thesaurus when using Elasticsearch This patch allows subject headings from different thesaurus to co-exist in Koha. Test plan: 1. Enable Elasticsearch as the search engine (SearchEngine system preference = Elasticsearch) and reindex (koha-elasticsearch --rebuild -d -b -a kohadev). 2. Load sample authority records attached to the bug (in this case the authorities.mrc file was saved in the koha directory - adjust file location as appropriate): misc/migration_tools/bulkmarcimport.pl -v -a -file authorities.mrc -insert -c=MARC21 3. Load the sample bibliographic record attached to the bug: misc/migration_tools/bulkmarcimport.pl -v -b -file biblios.mrc -insert -c=MARC21 4. Search for ISBN 0704328623 and verify that the subject terms are not linked to any authority records (if you hover over the link terms, all links should look like ../cgi-bin/koha/catalogue/search.pl?q=su:"subjectterm" - none should have any ?q=an:XXX (where XXX = authority record ids) in the link). 5. Apply the patches. 6. Reset the Elasticsearch mappings (Administration > Catalog > Search engine configuration (Elasticsearch)). 7. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev 8. Link bibliographic records to authority records: misc/link_bibs_to_authorities.pl -v -l 9. Repeat the search in step 4 (or refresh the record details page) and verify that the first three Feminism headings[1] are linked to an authority record (should have ?q=an:XXX (where XXX = different authority record IDs for the various feminism authority records linked to a specific thesaurus)). 10. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev [1] Links for subject terms for step 9 in order are (the authority ids may be different depending on how ou are testing): Subject(s:) Feminism | feminism | Feminism | Feminism | Idéhistoria | Litteratur http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1709 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1710 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1708 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Feminism" http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Idéhistoria" http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Litteratur" MARC info: 650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 0 Authority record control number or standard number https://id.kb.se/term/sao/Feminism 2 Source of heading or term sao 650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element feminism 2 Source of heading or term bnb 650 #0 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Idéhistoria 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Litteratur Note: The fourth Feminism term has second indicator 4 which means "Source not specified". So this term is only a local term and does not belong to any specific thesaurus and thus not linked. To specify a source of a term, the second indicator must be set as 7. The source of heading is then specified in subfield 2. Sponsored-by: Lund University Library, Sweden Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 15:53:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 13:53:54 +0000 Subject: [Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #45 from Frank Hansen --- Created attachment 140041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140041&action=edit Bug 30280: (follow-up) Removing tab character in Heading.pm Sponsored-by: Lund University Library, Sweden Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 15:58:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 13:58:48 +0000 Subject: [Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Frank Hansen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 15:58:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 13:58:51 +0000 Subject: [Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #46 from Frank Hansen --- Created attachment 140042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140042&action=edit Bug 30280 - Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 15:59:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 13:59:39 +0000 Subject: [Koha-bugs] [Bug 31483] Minor UI problem in opac-reset-password.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 15:59:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 13:59:42 +0000 Subject: [Koha-bugs] [Bug 31483] Minor UI problem in opac-reset-password.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140019|0 |1 is obsolete| | --- Comment #8 from Joonas Kylmälä --- Created attachment 140043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140043&action=edit Bug 31483: Close
    tag properly on password reset page To test: 1) Enable EnableExpiredPasswordReset 2) Find a patron and change their password so you know what it is supposed to be 3) In the database, expire the patron's password, e.g. UPDATE borrowers SET password_expiration_date = '2022-08-22' where borrowernumber = 21; 4) Go to the OPAC, try to log in with the patron's credentials 5) Click Reset your password => Note that the form is in the grey breadcrumbs box, you can compare with any other OPAC page, the grey box should only contain the breadcrumbs Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 16:00:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 14:00:27 +0000 Subject: [Koha-bugs] [Bug 31483] Minor UI problem in opac-reset-password.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | Status|Signed Off |Passed QA --- Comment #9 from Joonas Kylmälä --- Trivial syntax error fix, straight to PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 16:13:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 14:13:46 +0000 Subject: [Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Frank Hansen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140040|0 |1 is obsolete| | Attachment #140041|0 |1 is obsolete| | Attachment #140042|0 |1 is obsolete| | --- Comment #47 from Frank Hansen --- Created attachment 140044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140044&action=edit Bug 30280: Add support for subject headings from different thesaurus when using Elasticsearch This patch allows subject headings from different thesaurus to co-exist in Koha. Test plan: 1. Enable Elasticsearch as the search engine (SearchEngine system preference = Elasticsearch) and reindex (koha-elasticsearch --rebuild -d -b -a kohadev). 2. Load sample authority records attached to the bug (in this case the authorities.mrc file was saved in the koha directory - adjust file location as appropriate): misc/migration_tools/bulkmarcimport.pl -v -a -file authorities.mrc -insert -c=MARC21 3. Load the sample bibliographic record attached to the bug: misc/migration_tools/bulkmarcimport.pl -v -b -file biblios.mrc -insert -c=MARC21 4. Search for ISBN 0704328623 and verify that the subject terms are not linked to any authority records (if you hover over the link terms, all links should look like ../cgi-bin/koha/catalogue/search.pl?q=su:"subjectterm" - none should have any ?q=an:XXX (where XXX = authority record ids) in the link). 5. Apply the patches. 6. Reset the Elasticsearch mappings (Administration > Catalog > Search engine configuration (Elasticsearch)). 7. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev 8. Link bibliographic records to authority records: misc/link_bibs_to_authorities.pl -v -l 9. Repeat the search in step 4 (or refresh the record details page) and verify that the first three Feminism headings[1] are linked to an authority record (should have ?q=an:XXX (where XXX = different authority record IDs for the various feminism authority records linked to a specific thesaurus)). 10. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev [1] Links for subject terms for step 9 in order are (the authority ids may be different depending on how ou are testing): Subject(s:) Feminism | feminism | Feminism | Feminism | Idéhistoria | Litteratur http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1709 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1710 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1708 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Feminism" http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Idéhistoria" http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Litteratur" MARC info: 650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 0 Authority record control number or standard number https://id.kb.se/term/sao/Feminism 2 Source of heading or term sao 650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element feminism 2 Source of heading or term bnb 650 #0 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Idéhistoria 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Litteratur Note: The fourth Feminism term has second indicator 4 which means "Source not specified". So this term is only a local term and does not belong to any specific thesaurus and thus not linked. To specify a source of a term, the second indicator must be set as 7. The source of heading is then specified in subfield 2. Sponsored-by: Lund University Library, Sweden Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 16:13:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 14:13:51 +0000 Subject: [Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #48 from Frank Hansen --- Created attachment 140045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140045&action=edit Bug 30280: (follow-up) Removing tab character in Heading.pm Sponsored-by: Lund University Library, Sweden Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 16:13:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 14:13:55 +0000 Subject: [Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #49 from Frank Hansen --- Created attachment 140046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140046&action=edit Bug 30280: Add Unit tests Sponsored-by: Lund University Library, Sweden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 16:26:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 14:26:47 +0000 Subject: [Koha-bugs] [Bug 31503] Groundwork for 20380 (mail consent) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 16:26:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 14:26:51 +0000 Subject: [Koha-bugs] [Bug 31503] Groundwork for 20380 (mail consent) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #1 from Marcel de Rooy --- Created attachment 140047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140047&action=edit Bug 31503: Add $patron->consent Test plan: Run t/db_dependent/Koha/Patron.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 16:26:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 14:26:55 +0000 Subject: [Koha-bugs] [Bug 31503] Groundwork for 20380 (mail consent) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #2 from Marcel de Rooy --- Created attachment 140048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140048&action=edit Bug 31503: Use patron->consent in opac-patron-consent Includes a few small additional changes in template: [1] op == save (more generic) [2] agreed/disagreed replaced by 1/0 [3] toggling display of consent_info paragraph Test plan: Enable GDPR_Policy. Test adding/removing consent. Check what happens with alert, consent_info paragraph and save button. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 16:26:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 14:26:58 +0000 Subject: [Koha-bugs] [Bug 31503] Groundwork for 20380 (mail consent) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #3 from Marcel de Rooy --- Created attachment 140049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140049&action=edit Bug 31503: Add $av_cat->values Test plan: Run t/db_dependent/AuthorisedValues.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 16:27:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 14:27:02 +0000 Subject: [Koha-bugs] [Bug 31503] Groundwork for 20380 (mail consent) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #4 from Marcel de Rooy --- Created attachment 140050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140050&action=edit Bug 31503: Make opac-patron-consent more generic We now allow multiple consent types as defined under AV (read: authorised values) category 'PATRON_CONSENT'. The description is used on the form too. This is the base patch for multiple consents. We can do some more polishing on a follow-up or another report even. In order to simplify the alert for GDPR was moved to the description text. Note that we could move this also to a AC HTML block at some point. Test plan: First check the form without PATRON_CONSENT category defined. Add AV category PATRON_CONSENT. Add GDPR_PROCESSING and another one (e.g. NEWSLETTER). Verify that you can toggle consent/dissent and that everything is saved correctly. Note only a real change updates the timestamp. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 16:28:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 14:28:54 +0000 Subject: [Koha-bugs] [Bug 31503] Groundwork for 20380 (mail consent) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #5 from Marcel de Rooy --- What I am still adding here, is probably a text block for a consent type from Additional contents. What is here now already, allows you to define new consent types and register them on the consents page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 16:30:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 14:30:50 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Groundwork for 20380 (mail |Allow several consent types |consent) |on the consents tab of OPAC | |account page Component|Architecture, internals, |OPAC |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 16:33:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 14:33:25 +0000 Subject: [Koha-bugs] [Bug 26874] Exclude label layouts without barcodes from selection when printing from a barcode range In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26874 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 16:50:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 14:50:18 +0000 Subject: [Koha-bugs] [Bug 31482] Label creator does not call barcodedecode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 16:50:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 14:50:22 +0000 Subject: [Koha-bugs] [Bug 31482] Label creator does not call barcodedecode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140036|0 |1 is obsolete| | --- Comment #9 from Joonas Kylmälä --- Created attachment 140051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140051&action=edit Bug 31482: Label creator does not call barcodedecode The label creator can accept a list of either itemnumbers or item barcodes. In the case that the list of composed of barcodes, those barcodes should be passed though barcodedecode before the lookup is performed. Test Plan: 1) Apply this patch 2) Download and install the Barcode Transformer plugin https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/ 3) Go to the plugin configuration page, set the configuration to the example configuration from the same page 4) On the "New label batch" page of the Label creator,, type in some valid barcodes, but prefix them with X and postfix them with Y, e.g. X123456Y 5) Submit the form 6) Note the items are added to the label batch! JK: Remove unnecessary if $number check, barcodedecode already does this Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 16:51:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 14:51:45 +0000 Subject: [Koha-bugs] [Bug 31482] Label creator does not call barcodedecode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 --- Comment #10 from Joonas Kylmälä --- Fixed up the patch a little bit, removed "if $number" from the end as that was causing a bug with 0 barcodes and barcodedecode does it already. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 17:51:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 15:51:10 +0000 Subject: [Koha-bugs] [Bug 31507] New: When printing barcode range labels library name does not print Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31507 Bug ID: 31507 Summary: When printing barcode range labels library name does not print Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org With the ability to print barcode labels from a range, using the Home or Holding description data within the label layout, it does not print any info, since by default, these are barcodes that do not have items yet, and therefore, no home or holding data. It would be really helpful to have a way to have the library info appear without having to manually enter the library name in the fields data. This is particularly important for libraries with multiple branches where you don't want to have to change the library name, nor have a lot of different layouts. Perhaps the default for this scenario could be the logged in library if there is no home or holding? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 18:02:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 16:02:39 +0000 Subject: [Koha-bugs] [Bug 31507] When printing barcode range labels library name does not print In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31507 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 18:30:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 16:30:53 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Joonas Kylmälä --- I have confirmed the bug: changing active or inactive fund in acqui/orderreceive.pl doesn't work. The fund that was selected when adding the order line stays there and cannot be changed in the receive order step. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 19:00:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 17:00:54 +0000 Subject: [Koha-bugs] [Bug 31455] Batch modification tool orders found items by itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31455 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 19:00:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 17:00:57 +0000 Subject: [Koha-bugs] [Bug 31455] Batch modification tool orders found items by itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31455 --- Comment #1 from Lucas Gass --- Created attachment 140052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140052&action=edit Bug 31455: Make batchMod sort by order scanned To test: 1. In batch item deletion and batch item modification add some barcodes. 2. Notice they are being sorted by item number, not in the order scanned. 3. Appply patch and restart services. 4. Try scanning items again in both batch item deletion and batch item modification. 5. The found barcodes should now sort by order scanned. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 19:01:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 17:01:48 +0000 Subject: [Koha-bugs] [Bug 31455] Batch modification tool orders found items by itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31455 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 19:13:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 17:13:46 +0000 Subject: [Koha-bugs] [Bug 31508] New: Authorities link in new marc fields created Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31508 Bug ID: 31508 Summary: Authorities link in new marc fields created Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: vbovictor at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl I created a new field MARC 697 – local subject I also created a “local subjectc” authority type and then linked it to field MARC 697. I imported some records and authorities with the information into the appropriate fields. I ran the misc/link_bibs_to_authorities.pl script to link the authorities with the records information. Fields 650, 100, etc. were linked normally, but field 697 was not linked. Is this a bug in the system? Is Koha not linking newly created MARCS fields? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 19:44:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 17:44:06 +0000 Subject: [Koha-bugs] [Bug 31502] Add a customizable list of useful resources for cataloging to the left side of the cataloging module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31502 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #1 from Lucas Gass --- Chris, Do you think this is a duplicate of Bug 31162? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 19:48:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 17:48:34 +0000 Subject: [Koha-bugs] [Bug 31477] Switch icon for inventory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31477 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #1 from Lucas Gass --- I don't think is available in Font Awesome 4. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 19:57:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 17:57:49 +0000 Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi QA Contact| |joonas.kylmala at iki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 20:00:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 18:00:21 +0000 Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 20:00:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 18:00:26 +0000 Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132327|0 |1 is obsolete| | Attachment #132328|0 |1 is obsolete| | Attachment #132329|0 |1 is obsolete| | Attachment #132330|0 |1 is obsolete| | Attachment #138803|0 |1 is obsolete| | --- Comment #31 from Joonas Kylmälä --- Created attachment 140053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140053&action=edit Bug 25375: Fix 'available' facet in elasticsearch Add a new boolean ES field named 'available', which is true if at least one item is available, which means the item is not on loan, not "notforloan", not withdrawn, not lost and not damaged A full indexation is required Test plan: 1. Apply patch and run updatedatabase.pl 2. Run `misc/search_tools/rebuild_elasticsearch.pl -d -b` 3. Make sure you have some biblios whose items are all unavailable, some biblios whose items are all available, and some biblios with at least one item available and at least one item unavailable 4. Use the 'available' filter on both opac and intranet and make sure it works as expected. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Nick Clemens Signed-off-by: Nick Clemens Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 20:00:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 18:00:31 +0000 Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #32 from Joonas Kylmälä --- Created attachment 140054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140054&action=edit Bug 25375: Get biblionumber from the correct MARC field Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Nick Clemens Signed-off-by: Nick Clemens Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 20:00:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 18:00:37 +0000 Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #33 from Joonas Kylmälä --- Created attachment 140055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140055&action=edit Bug 25375: (QA follow-up) Count available items rather than iterating Signed-off-by: Nick Clemens Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 20:00:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 18:00:42 +0000 Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #34 from Joonas Kylmälä --- Created attachment 140056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140056&action=edit Bug 25375: Add tests for the "available" ES field Signed-off-by: Nick Clemens Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 20:00:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 18:00:47 +0000 Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #35 from Joonas Kylmälä --- Created attachment 140057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140057&action=edit Bug 25375: Match current Zebra availability limit In Zebra the availability limit code states: 'available' is defined as (items.onloan is NULL) and (items.itemlost = 0) We should make ES follow the same behaviour so that changing the engine does not change this. To test: 1 - Find or create several records with two items each 2 - For those records setup items as: a - one checked out, one available b - both marked lost c - both damaged d - both withdrawn e - both notforloan 3 - Enable ES and reindex to confirm everything is set 4 - Perform an advanced search to return those records and 'limit to available items' 5 - Confirm you see records b,c,d,e and records say '2 items, none available' 6 - Apply patch 7 - Run `misc/search_tools/rebuild_elasticsearch.pl -d -b` 8 - Perform an advanced search to return those records and 'limit to available items' 9 - Confirm you see records a,b,c,d and al but a say '2 items, none available' Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 20:01:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 18:01:43 +0000 Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #36 from Joonas Kylmälä --- (In reply to Nick Clemens from comment #28) > (In reply to Katrin Fischer from comment #25) > > Maybe we do need to have some configuration options here? > > If I could pick, I'd pick lost, withdrawn and on loan as unavailable. > > Current behavior is wrong, can we agree to making it match Zebra behavior > for a small improvement, then expand/fix on another bug? I agree, passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 20:14:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 18:14:26 +0000 Subject: [Koha-bugs] [Bug 31439] Item count bullet (• ) should be easier to style/remove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31439 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 20:14:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 18:14:30 +0000 Subject: [Koha-bugs] [Bug 31439] Item count bullet (• ) should be easier to style/remove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31439 --- Comment #1 from Lucas Gass --- Created attachment 140058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140058&action=edit Bug 31439: Use pseudo element for bullet in results.tt To test: 1. Apply patch and regenerate CSS. See: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 2. Go to the staff results page and inscept the result_item_details class. 3. It should contain a ::before pseudo element that is the bullet point. 4. This is easier to remove of alter with the following CSS in IntraNetUSerCSS: .result_item_details::before { content: " " !important; } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 20:14:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 18:14:56 +0000 Subject: [Koha-bugs] [Bug 31439] Item count bullet (• ) should be easier to style/remove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31439 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 20:27:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 18:27:52 +0000 Subject: [Koha-bugs] [Bug 26440] Not renewable Supersedes On Hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26440 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |didier.gautheron at biblibre.c |ity.org |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 20:28:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 18:28:07 +0000 Subject: [Koha-bugs] [Bug 26440] Not renewable Supersedes On Hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26440 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 20:28:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 18:28:17 +0000 Subject: [Koha-bugs] [Bug 26440] Not renewable Supersedes On Hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26440 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 21:05:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 19:05:21 +0000 Subject: [Koha-bugs] [Bug 31455] Batch modification tool orders found items by itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31455 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 21:05:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 19:05:25 +0000 Subject: [Koha-bugs] [Bug 31455] Batch modification tool orders found items by itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31455 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140052|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 140059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140059&action=edit Bug 31455: Make batchMod sort by order scanned To test: 1. In batch item deletion and batch item modification add some barcodes. 2. Notice they are being sorted by item number, not in the order scanned. 3. Appply patch and restart services. 4. Try scanning items again in both batch item deletion and batch item modification. 5. The found barcodes should now sort by order scanned. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 21:30:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 19:30:48 +0000 Subject: [Koha-bugs] [Bug 22666] When using authority records in a bibliographic record, the order of the subfields is not sent over In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22666 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 21:30:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 19:30:52 +0000 Subject: [Koha-bugs] [Bug 22666] When using authority records in a bibliographic record, the order of the subfields is not sent over In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22666 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129535|0 |1 is obsolete| | --- Comment #2 from George Veranis --- Created attachment 140060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140060&action=edit Bug 25387: The order of authority subfield is not sent over to bibliographic record When creating an authority record there is the possibility to reorder the subfield. However this order is not sent back to the bibliographic records when using this authority in a bibliographic record. This patch make the order of subfield be sent back to bibliographic record when the autority is used. Field that are fill are sent to the begining of the bibliographic record in the same order as in the authority record. Test plan: 1- Find or create an authority record and reorder some subfield 2- Use this authority in a bibliographic record 3- Observe that the order of the subfield is not transferred from the authority record to the bibliographic record 4- Apply the patch 5- Repeat step 1 and 2 again 6- Observe that the order of the subfield is now transferred from the authority record to the bibliographic record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 21:40:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 19:40:53 +0000 Subject: [Koha-bugs] [Bug 31455] Batch modification tool orders found items by itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31455 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | CC| |joonas.kylmala at iki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 21:47:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 19:47:04 +0000 Subject: [Koha-bugs] [Bug 31455] Batch modification tool orders found items by itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31455 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 21:47:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 19:47:08 +0000 Subject: [Koha-bugs] [Bug 31455] Batch modification tool orders found items by itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31455 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140059|0 |1 is obsolete| | --- Comment #3 from Joonas Kylmälä --- Created attachment 140061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140061&action=edit Bug 31455: Make batchMod sort by order scanned To test: 1. In batch item deletion and batch item modification add some barcodes. 2. Notice they are being sorted by item number, not in the order scanned. 3. Appply patch and restart services. 4. Try scanning items again in both batch item deletion and batch item modification. 5. The found barcodes should now sort by order scanned. Signed-off-by: Owen Leonard Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 21:47:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 19:47:11 +0000 Subject: [Koha-bugs] [Bug 31455] Batch modification tool orders found items by itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31455 --- Comment #4 from Joonas Kylmälä --- Created attachment 140062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140062&action=edit Bug 31455: (QA follow-up) Make table creation O(N) We can insert the indices before the main loop to a hash, this way we don't have to look up during each loop iteration the index from an array which in the worst case might take O(N) thus making the total time complexity O(N^2). Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 22:45:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 20:45:35 +0000 Subject: [Koha-bugs] [Bug 29825] Preview of authority record on edit mode as MARC formatted view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 22:45:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 20:45:39 +0000 Subject: [Koha-bugs] [Bug 29825] Preview of authority record on edit mode as MARC formatted view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #3 from George Veranis --- Created attachment 140063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140063&action=edit Bug 29825: Preview of authority record on edit mode as MARC formatted view This bug adds a new functionality on Edit mode of a new or existing authority. Add a new button 'MARC Preview' in order librarian have the ability to preview the record on MARC plain structure mode and have all fields and subfields that entered before save/update the record. To test: 1. Open or add an authority 2. The preview button isn't on toolbar 3. Apply the patch 4. Do step 1 5. The preview button exists 6. Do some changes or not to the authority record 7. Click to Preview MARC button and a modal window will appear with all fields indicators and subfields that filled in the form of cataloguing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 00:04:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 22:04:44 +0000 Subject: [Koha-bugs] [Bug 31364] Saving preferences with a dropdown with check boxes doesn't save in the case where all the checks are removed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31364 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #2 from Lucas Gass --- In preferences.js, if we are dealing with multiple select type system preference we check to make sure the value is not NULL before pushing anything to the unserialized array. I think we should allow for that value to be empty/null. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 00:10:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 22:10:03 +0000 Subject: [Koha-bugs] [Bug 31364] Saving preferences with a dropdown with check boxes doesn't save in the case where all the checks are removed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31364 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 00:10:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 22:10:06 +0000 Subject: [Koha-bugs] [Bug 31364] Saving preferences with a dropdown with check boxes doesn't save in the case where all the checks are removed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31364 --- Comment #3 from Lucas Gass --- Created attachment 140064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140064&action=edit Bug 31364: Allow multiple select system prefernces to saved when they are empty/null TO test: 1. Have a multiple select system preference like 'OPACHoldsIfAvailableAtPickupExceptions'. 2. Set a couple patron categories as exceptions and save. 3. Remove all the categories from the exception list and save. 4. You get a message that says 'Nothing to Save' and the changes are not made. 5. Apply patch 6. Try 2-4 again, excpet this time it should save. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 00:10:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 22:10:39 +0000 Subject: [Koha-bugs] [Bug 31364] Saving preferences with a dropdown with check boxes doesn't save in the case where all the checks are removed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31364 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Version|unspecified |master Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 00:23:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 22:23:09 +0000 Subject: [Koha-bugs] [Bug 31470] Incorrect selector for relationship dropdown used in members.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #4 from Lucas Gass --- This highlights another problem. If relationship is going to a class in memberentry.pl then something must be done about its label: The value of the for attribute of the label element must be the ID, not a class. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 00:27:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Sep 2022 22:27:31 +0000 Subject: [Koha-bugs] [Bug 30121] Cannot hide non-patron guarantor relationship via BorrowerUnwantedFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30121 --- Comment #8 from Lucas Gass --- This patch must be reworked as the borrowers.json no longer exists in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 03:30:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 01:30:58 +0000 Subject: [Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lucas at bywatersolutions.com --- Comment #29 from Lucas Gass --- I've tried adding something similar to this in an ISSUESLIP and I always run into the problem where things explode when delete an item that was in the patrons old issues. The same thing seems to happen here. If I delete something from a patrons old issues I get: Can't call method "replacementprice" on an undefined value at /kohadevbox/koha/Koha/Patron.pm line 2218 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 03:38:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 01:38:54 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 04:00:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 02:00:31 +0000 Subject: [Koha-bugs] [Bug 15284] Switch default ISSUESLIP notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15284 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au Depends on| |15278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 04:00:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 02:00:31 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15284 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15284 [Bug 15284] Switch default ISSUESLIP notice to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 04:01:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 02:01:19 +0000 Subject: [Koha-bugs] [Bug 15284] Switch default ISSUESLIP notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15284 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15278 Depends on|15278 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 04:01:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 02:01:19 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15284 | Depends on| |15284 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15284 [Bug 15284] Switch default ISSUESLIP notice to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 04:04:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 02:04:26 +0000 Subject: [Koha-bugs] [Bug 15284] Switch default ISSUESLIP notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15284 --- Comment #9 from David Cook --- I think some of those sample notices might've been updated in error or not properly updated? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 07:36:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 05:36:59 +0000 Subject: [Koha-bugs] [Bug 2838] Checking in an in-transit item to its originating branch causes improper error message(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2838 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |nick at bywatersolutions.com Resolution|--- |WORKSFORME --- Comment #3 from Nick Clemens --- Retested, I get the correct dialog to confirm and transfer / ignore every subsequent check in. I think if there are still any bugs here, they should get a new report :-) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 07:56:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 05:56:06 +0000 Subject: [Koha-bugs] [Bug 31501] After upgrading to 22.05, I am not able to search Patrons. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31501 --- Comment #3 from Liny Varghese --- Please help.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 08:09:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 06:09:05 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 08:09:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 06:09:10 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139767|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 140065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140065&action=edit Bug 31459: Use the same dropdown as when adding orders to a basket Current order receive code loops over each budget period and gets the hierarchy, this is slow when systems have many budgets. Additionally, the list includes inactive items by default We can switch to a single call, and add consistency by adopting the same dropdown as used when placing an order To test: 1 - Add some budgets with funds - ensure you have at least one inactive budget and fund 2 - Place an order, observe the fund selection menu 3 - Close basket, receive order, observe the fund menu 4 - Apply patch 5 - Cancel receipt 6 - Receive again 7 - Observe fund menu, confirm it matches the order placing menu 8 - Confirm inactive are not displayed by default, but are when button is checked -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 08:11:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 06:11:14 +0000 Subject: [Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459 --- Comment #5 from Nick Clemens --- (In reply to Joonas Kylmälä from comment #3) > I have confirmed the bug: changing active or inactive fund in > acqui/orderreceive.pl doesn't work. The fund that was selected when adding > the order line stays there and cannot be changed in the receive order step. I had changed the name of the input, without changing code to read that, amended to use original name and selection now works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 08:22:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 06:22:51 +0000 Subject: [Koha-bugs] [Bug 26440] Not renewable Supersedes On Hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26440 --- Comment #11 from Nick Clemens --- (In reply to Didier Gautheron from comment #6) > Created attachment 128586 [details] [review] > Bug 26440: Prioritize 'on hold' over Not renewable' in Renew column This patch will have an impact on performance. CheckReserves is a complicated routine that checks many aspects or reserves/holdability and for borrowers with many items, or titles with many holds, we will spend a lot of time in this routine and slow the loading of the patron. At a minimum, I would want to see a system preference here, so larger systems can prioritize performance, and others can prioritize 'On hold' message. I also think we should tackle the issue that when a renewal is attempted, the table is reloaded, rather than just the rows updated as needed and new messages lost -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 08:40:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 06:40:18 +0000 Subject: [Koha-bugs] [Bug 28290] Record matching rules with no subfields cause ISE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28290 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 08:40:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 06:40:23 +0000 Subject: [Koha-bugs] [Bug 28290] Record matching rules with no subfields cause ISE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28290 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120827|0 |1 is obsolete| | Attachment #120828|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 140066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140066&action=edit Bug 28290: Don't send subfields to 'as_string' if none to send This fixes an error where we send a blank string to Marc::Field->as_string The subroutine fails as the regex is marked as incomplete as there is nothing between the brackets Also fixes a missing hidden input for 'item_action' when no items are staged during import 1 - Define a new matching rule with no subfields Match-threshold: 1000 Record type: bibliographic record Search-index: Other-control-number Score: 1000 Tag: 035 Subfields: Offset: Length: 2 - Attempt to stage a record with an 035 using this rule (i will attach example to bug) 3 - Staging fails 4 - Stage again with no matching rule 5 - Manage the staged record, try to apply the matching rule 6 - It fails, 500 error 7 - Apply patch 8 - Restart all the things 9 - Apply rule again, it works! 10 - Stage the record again using the rule for matching 11 - It stages and matches! Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 08:40:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 06:40:28 +0000 Subject: [Koha-bugs] [Bug 28290] Record matching rules with no subfields cause ISE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28290 --- Comment #10 from Nick Clemens --- Created attachment 140067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140067&action=edit Bug 28290: (follow-up) Unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 08:47:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 06:47:26 +0000 Subject: [Koha-bugs] [Bug 31023] Cannot create new GENRE/FORM authorities when QueryRegexEscapeOptions set to 'Unescape escaped' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31023 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #9 from Nick Clemens --- (In reply to Tomás Cohen Arazi from comment #8) > Hi, Nick. Do you think you could use > Koha::SearchEngine::Zebra::QueryBuilder::clean_search_term on the > authtypecode? I think that might be overkill on this one - everythign already works in Zebra - in ES, it only doesn't work under a special case where we are unescaping values as specified by the pref. Ideally, I think we would just remove the slash from the type, GENRE_FORM, or something. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 09:01:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 07:01:18 +0000 Subject: [Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 09:01:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 07:01:22 +0000 Subject: [Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138925|0 |1 is obsolete| | Attachment #138926|0 |1 is obsolete| | --- Comment #17 from Nick Clemens --- Created attachment 140068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140068&action=edit Bug 20058: Add option to send permanent_location as AQ in SIP response Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 09:01:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 07:01:27 +0000 Subject: [Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058 --- Comment #18 from Nick Clemens --- Created attachment 140069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140069&action=edit Bug 20058: Add tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 09:01:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 07:01:32 +0000 Subject: [Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058 --- Comment #19 from Nick Clemens --- Created attachment 140070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140070&action=edit Bug 20058: (QA follow-up) Add exec flag to install file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 09:01:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 07:01:36 +0000 Subject: [Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058 --- Comment #20 from Nick Clemens --- Created attachment 140071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140071&action=edit Bug 20058: (QA follow-up) Simplify test code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 09:06:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 07:06:25 +0000 Subject: [Koha-bugs] [Bug 25816] Add OPAC messages in SIP display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25816 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 09:13:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 07:13:07 +0000 Subject: [Koha-bugs] [Bug 30490] Adjust foreign key for parent item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30490 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 09:13:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 07:13:12 +0000 Subject: [Koha-bugs] [Bug 30490] Adjust foreign key for parent item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30490 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139678|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 140072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140072&action=edit Bug 30490: Adjust constraint itemtypes.itemtypes_ibfk_1 Change from CASCADE to restrict. In harmony with dbrev 20.06.00.022. Test plan: Run the dbrev. Bonus: update itemtypes set parent_type='VM' where itemtype='CF'; delete from itemtypes where itemtype='VM'; => ERROR 1451 (23000): Cannot delete or update a parent row: a foreign key constraint fails (`koha_myclone`.`itemtypes`, CONSTRAINT `itemtypes_ibfk_1` FOREIGN KEY (`parent_type`) REFERENCES `itemtypes` (`itemtype`)) Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 09:14:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 07:14:27 +0000 Subject: [Koha-bugs] [Bug 31501] After upgrading to 22.05, I am not able to search Patrons. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31501 --- Comment #4 from Liny Varghese --- While inspecting the datatables after member search I got this : No matching records found -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 09:19:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 07:19:29 +0000 Subject: [Koha-bugs] [Bug 30497] Constraint old_reserves_ibfk_4 should be SET NULL instead of CASCADE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30497 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 09:19:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 07:19:33 +0000 Subject: [Koha-bugs] [Bug 30497] Constraint old_reserves_ibfk_4 should be SET NULL instead of CASCADE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30497 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139680|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 140073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140073&action=edit Bug 30497: Recreate old_reserves_ibfk_4 when it cascades Test plan: Drop old_reserves_ibfk_4. Add back with: alter table old_reserves ADD CONSTRAINT `old_reserves_ibfk_4` FOREIGN KEY (`itemtype`) REFERENCES `itemtypes` (`itemtype`) ON DELETE CASCADE ON UPDATE CASCADE; Run dbrev. Check that constraint has been replaced by SET NULL. Run dbrev again. No changes. Signed-off-by: Marcel de Rooy [EDIT 23-08-22 Replaced DROP CONSTRAINT] Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 09:20:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Sep 2022 07:20:04 +0000 Subject: [Koha-bugs] [Bug 31470] Incorrect selector for relationship dropdown used in members.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 --- Comment #5 from Emmi Takkinen --- (In reply to Lucas Gass from comment #4) > This highlights another problem. If relationship is going to a class in > memberentry.pl then something must be done about its label: > > > > The value of the for attribute of the label element must be the ID, not a > class. Hmm, you're right. So either we change ID from auth-finder-search.inc as something like "special_relationship" to avoid conflicts and change relationship in memberentry from class to ID. Or we add new ID to memberentry (e.g. non_patron_relationship). Latter is probably preferable solution. And we could use that ID in members.js instead of class relationship (which at hindsight could cause problems in future). And looking at this more closely, we have this same problem with other label as well: Without patch : the subfield is empty, it should have the value from drop-down menu. => With patch : the subfield is saved with the value from drop-down menu. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 11 21:54:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Sep 2022 19:54:27 +0000 Subject: [Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 11 21:54:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Sep 2022 19:54:31 +0000 Subject: [Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139034|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 140411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140411&action=edit Bug 30944: Fix cancel recalls actions This patch fixes the 'cancel selected recalls' button on the biblio details Recalls page, and ensures a correct cancellation reason is logged when cancelling a recall in transit. To test: 1) Ensure UseRecalls is enabled and relevant recalls circulation rules are set 2) Check out Item A to Patron B 3) Log into OPAC as Patron A 4) Search for Item A and place a recall 5) Go back to the staff interface and search for Item A. When viewing the biblio record, go to the recalls tab. 6) Check the checkbox for your recall, and click the button to cancel selected recalls. 7) Confirm your recall is successfully removed and you're redirected to the correct recalls page for this biblio. 8) Go back to the OPAC and place a recall again. This time set the pickup location to a different library, one that you're not logged in at 9) Back in the staff interface, check in Item A and confirm the recall and transfer 10) Go to Circulation -> Recalls to pull. Your recall should show here. Click the button to cancel the recall and revert the transfer 11) Confirm the recall has been cancelled 12) Go to Reports and create a new SQL report with the following SQL: select * from branchtransfers b join items i on b.itemnumber=i.itemnumber where i.barcode = <> 13) Run the report and paste the barcode of Item A in the field 14) Confirm there are two rows returned - the transfer triggered when the recall was confirmed, with a reason of 'Recall' and a cancellation reason of 'RecallCancellation, and the transfer sending the item back home when the recall was cancelled, with a reason of 'RecallCancellation'. Sponsored-by: Catalyst IT Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 11 22:01:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Sep 2022 20:01:27 +0000 Subject: [Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the 'cancel' release notes| |recall button in several | |places so that it now works | |as expected (including the | |recalls tab in a patron's | |details section, the | |recalls section for a | |record, and the circulation | |recalls queue and recalls | |to pull pages). It also | |ensures a correct | |cancellation reason is | |logged when cancelling a | |recall in transit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 11 22:04:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Sep 2022 20:04:47 +0000 Subject: [Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 --- Comment #7 from David Nind --- Testing notes (using koha-testing-docker): - Setup recalls and replicate the issue as described in comment #1. - Apply the patch and update the database (updatedatabase). - Follow the test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 11 22:34:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Sep 2022 20:34:43 +0000 Subject: [Koha-bugs] [Bug 28553] Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 11 22:34:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Sep 2022 20:34:48 +0000 Subject: [Koha-bugs] [Bug 28553] Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139021|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 140412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140412&action=edit Bug 28553: Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them Following bug 18532, one can set a patron's messaging prefs to deliver an auto-renew notice via SMS. However, the auto_renewals cron only knows how to generate email notices. We should not allow the selection of non-functional transport types. Test Plan: 1 - Set pref AutoRenewalNotices - 'according to patron messaging preferences' 2 - Set circ rule with: Loan period: 5 days No renewal before: 5 AutoRenewal: Yes Renewals allowed: 5 3 - Set SMS Send driver to Email 4 - Find a patron and set them to receive auto renewal notices via SMS and no other transport 5 - Provide a proivder and sms number for the patron 6 - Checkout an item to the patron, set due date to yesterday 7 - Run auto renewals: perl misc/cronjobs/automatic_renewals.pl -v --send-notices -c 8 - Item renewed, no message sent 9 - Check in item, checkout again due yesterday 10 - Apply patch 11 - Browse to Tools->notices and slips 12 - Edit AUTO_RENEWALS and AUTO_RENEWALS_DIGEST to copy email template to sms and add a title 13 - perl misc/cronjobs/automatic_renewals.pl -v --send-notices -c 14 - Item renewed, confirm patron has a notice in their account 15 - Check the digest option, check in item, checkout again as due, repeat cronjob and note digest notic 16 - sign off https://bugs.koha-community.org/show_bug.cgi?id=30355 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 11 22:45:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Sep 2022 20:45:16 +0000 Subject: [Koha-bugs] [Bug 28553] Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind --- Note that for the AUTO_RENEWALS notice, this message appears for the Email notice, before the last updated date: Template Toolkit error: undef error - : filter not found This message appears before the patch is applied - I'm not sure what is causing this, as it doesn't appear for a sample of other notices I checked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 11 22:58:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Sep 2022 20:58:02 +0000 Subject: [Koha-bugs] [Bug 31239] search_for_data_inconsistencies.pl fails for Koha to MARC mapping using biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31239 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 11 22:58:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Sep 2022 20:58:06 +0000 Subject: [Koha-bugs] [Bug 31239] search_for_data_inconsistencies.pl fails for Koha to MARC mapping using biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31239 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138963|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 140413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140413&action=edit Bug 31239: Fix incorrect AV linked to a mapped biblio column If an AV is linked to a MARC field mapped with a biblio column, the search_for_data_inconsistencies.pl script might explode with The method Koha::Biblioitem->title is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 875 Koha::Object::AUTOLOAD('Koha::Biblioitem=HASH(0x556b67fa7168)') called at misc/maintenance/search_for_data_inconsistencies.pl line 246 Test plan: For a given framework, pick a biblio using it Link 245$a with an authorised value category Run the script => Notice that with this script applied you will see the warning => Without this patch you got the error Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 11 23:23:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Sep 2022 21:23:43 +0000 Subject: [Koha-bugs] [Bug 31536] Add UNIMARC framework plugin to fetch PPN from sudoc.fr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31536 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 11 23:23:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Sep 2022 21:23:47 +0000 Subject: [Koha-bugs] [Bug 31536] Add UNIMARC framework plugin to fetch PPN from sudoc.fr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31536 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140342|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 140414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140414&action=edit Bug 31536: Add UNIMARC framework plugin to fetch PPN from sudoc.fr This plugin uses sudoc.fr webservices (isbn2ppn, issn2ppn, ean2ppn) to search a PPN using ISBN, ISSN or EAN as search criteria. The plugin expects than ISBN is in 010$a, ISSN is in 011$a and EAN is in 073$a. Test plan: 1. Configure the default MARC framework so that 009 uses this plugin (unimarc_field_009_ppn.pl) 2. Start creating a new bibliographic record 3. In the editor, write "0195141156" in the 010$a input, then move the focus out of the input (by pressing Tab, or clicking elsewhere on the page) The 009 field should be automatically filled with "06735209X" 4. Empty the 010$a input, then empty the 009 input 5. Write "2262-4694" in the 011$a input, then move the focus out of the input The 009 field should be automatically filled with "166197947" 6. Empty the 011$a input, then empty the 009 input 7. Write "9782070424597" in the 073$a input, then move the focus out of the input The 009 field should be automatically filled with "151662983" 8. Empty only the 009 field, keep the same value for 073$a and save the bibliographic record. 9. Edit the same record, you should have an empty 009 field and 073$a = "9782070424597". Click on the 009 field input, it should be automatically filled with "151662983" Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 11 23:28:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Sep 2022 21:28:41 +0000 Subject: [Koha-bugs] [Bug 31536] Add UNIMARC framework plugin to fetch PPN from sudoc.fr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31536 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes (using koha-testing-docker): - For step 1: . added the 009 tag (called it 'Test 009') . added a subfield (x) labeled 'Test' and selected the plugin unimarc_field_009_ppn.pl Everything worked as per the test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 11 23:35:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Sep 2022 21:35:59 +0000 Subject: [Koha-bugs] [Bug 31536] Add UNIMARC framework plugin to fetch PPN from sudoc.fr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31536 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a release notes| |UNIMARC plugin | |(unimarc_field_009_ppn.pl) | |that uses sudoc.fr web | |services (isbn2ppn, | |issn2ppn, ean2ppn) to | |search for the Sudoc record | |identifier (PPN) using the | |ISBN, ISSN, or EAN | |identifiers as the search | |criteria. The plugin | |expects the ISBN in 010$a, | |ISSN in 011$a, and EAN in | |073$a. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 00:25:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Sep 2022 22:25:41 +0000 Subject: [Koha-bugs] [Bug 31525] Street number not being accessed correctly on patron search results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31525 --- Comment #1 from wainuiwitikapark at catalyst.net.nz --- Created attachment 140415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140415&action=edit Bug 31525: display streetnumber with address in patron search Adds back street number to the address when searching for patrons To test: 1) Edit a patron's contact information 2) Under Main Address put an address, make sure to put something in the Street number field 3) Do a simple patron search that will yield results (i.e. "a") 4) Confirm the street number does not show, but the rest of the address does 5) Apply this patch 6) Do another patron search 5) Confirm the street number now shows Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 00:26:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Sep 2022 22:26:17 +0000 Subject: [Koha-bugs] [Bug 31525] Street number not being accessed correctly on patron search results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31525 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 03:16:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 01:16:36 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 --- Comment #39 from David Cook --- (In reply to Katrin Fischer from comment #23) > While I am testing this: I am not sure about using "Public" to describe this > feature as it only affects the libraries page in the OPAC right now. I > think we should at least add a hint about what it really does to the > input/edit form for libraries. I think we could leverage this flag to not display library branches in dropdown menus as well (for the masthead dropdown and advanced search dropdowns specifically) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 03:18:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 01:18:52 +0000 Subject: [Koha-bugs] [Bug 31549] New: Don't show library in OPAC dropdowns if marked as not public Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31549 Bug ID: 31549 Summary: Don't show library in OPAC dropdowns if marked as not public Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Bug 27360 added a "Public" flag to the branches table. It would be great to leverage this flag to not display branches in the masthead search branch dropdown and the advanced search branch dropdown. Over the past few years, we've had libraries temporarily or permanently close down, and while we want to keep those libraries in the staff interface, we don't want public users to be able to easily see them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 03:19:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 01:19:46 +0000 Subject: [Koha-bugs] [Bug 31549] Don't show library in OPAC dropdowns if marked as not public In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31549 --- Comment #1 from David Cook --- There are other use cases too. Sometimes there are non-public branches in general, data cleanup to be done for a branch, etc. You can use OpacHiddenItems to hide all the items for a branch, but you can't currently hide the branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 03:24:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 01:24:07 +0000 Subject: [Koha-bugs] [Bug 31549] Don't show library in OPAC dropdowns if marked as not public In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31549 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27360 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 03:24:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 01:24:07 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31549 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31549 [Bug 31549] Don't show library in OPAC dropdowns if marked as not public -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 03:29:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 01:29:44 +0000 Subject: [Koha-bugs] [Bug 31532] Zebra search results incorrect because of Bug 15187 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31532 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 04:02:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 02:02:47 +0000 Subject: [Koha-bugs] [Bug 30962] REST API: Add endpoint /patrons/:patron_id/check_password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962 --- Comment #15 from David Cook --- I'm planning on making a plugin for this, and it's got me thinking more about what people would accept in the longer term... I'm thinking /api/v1/auth/ will be the route, and it'll take "username" and "password" JSON POST parameters. I've noticed FortiAuthenticator works this way; it's the way that the ILS-DI API works; it would be difficult to abuse. I suppose we could argue about the route name. FortiAuthenticator uses that exact same route, but I suppose it could be /api/v1/patrons/auth, so it makes it more obvious that it's a route not for authenticating to use the API but rather just for authenticating patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 07:57:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 05:57:39 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12242 --- Comment #40 from Katrin Fischer --- (In reply to David Cook from comment #39) > (In reply to Katrin Fischer from comment #23) > > While I am testing this: I am not sure about using "Public" to describe this > > feature as it only affects the libraries page in the OPAC right now. I > > think we should at least add a hint about what it really does to the > > input/edit form for libraries. > > I think we could leverage this flag to not display library branches in > dropdown menus as well (for the masthead dropdown and advanced search > dropdowns specifically) Not sure if it should be the same flag, but it could be: see bug 12242. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 07:57:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 05:57:39 +0000 Subject: [Koha-bugs] [Bug 12242] Allow hiding branches from the OPAC search pulldowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12242 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27360 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 07:59:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 05:59:02 +0000 Subject: [Koha-bugs] [Bug 12242] Allow hiding branches from the OPAC search pulldowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12242 --- Comment #6 from Katrin Fischer --- ON bug 27360 David Cook suggested to use the OPAC public flag for this. I think this is not a bad idea to extend it's scope. What do others think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 07:59:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 05:59:32 +0000 Subject: [Koha-bugs] [Bug 31549] Don't show library in OPAC dropdowns if marked as not public In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31549 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 12242 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 07:59:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 05:59:32 +0000 Subject: [Koha-bugs] [Bug 12242] Allow hiding branches from the OPAC search pulldowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12242 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #7 from Katrin Fischer --- *** Bug 31549 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 08:58:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 06:58:50 +0000 Subject: [Koha-bugs] [Bug 26615] Koha 18.11.04.000 Upon clicking any tab after ligin or doing any function it displays error :session timed out please login again In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26615 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28607 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 08:58:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 06:58:50 +0000 Subject: [Koha-bugs] [Bug 28607] Error: Session timed out. Please log in again In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28607 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26615 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 08:59:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 06:59:57 +0000 Subject: [Koha-bugs] [Bug 8959] Self checkout timeout is JavaScript-dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8959 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30867 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 09:09:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 07:09:54 +0000 Subject: [Koha-bugs] [Bug 26615] Koha 18.11.04.000 Upon clicking any tab after ligin or doing any function it displays error :session timed out please login again In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26615 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- There has been no feedback and 18.11 is no longer maintained. Closing WORKSFORME. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 09:11:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 07:11:59 +0000 Subject: [Koha-bugs] [Bug 28607] Error: Session timed out. Please log in again In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28607 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #5 from Katrin Fischer --- There has been no feedback for almost a year. I assume it was a local issue since we had no other reports. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 10:45:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 08:45:30 +0000 Subject: [Koha-bugs] [Bug 31550] New: WS ILSDI opac description for some item fields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Bug ID: 31550 Summary: WS ILSDI opac description for some item fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: thibaud.guillot at biblibre.com QA Contact: testopia at bugs.koha-community.org It may be useful to get the opac description on the ILSDI web service with a specific suffix for some item fields. In relation to bug 25650, this is to add 'ccode', 'permanent_location', 'notforloan', 'itemlost', 'withdrawn', 'damaged' and 'restricted'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 10:45:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 08:45:45 +0000 Subject: [Koha-bugs] [Bug 31550] WS ILSDI opac description for some item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25650 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 10:45:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 08:45:45 +0000 Subject: [Koha-bugs] [Bug 25650] Add location and itype descriptions in ILS-DI GetRecords In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25650 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31550 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 11:14:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 09:14:41 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 --- Comment #28 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #27) > Still testing actually. Having some issues when changing users in Enforced > state. But not sure yet what's going on. > > If you wanna test too, please do ! Found it. Adding a last follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 11:15:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 09:15:28 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 11:15:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 09:15:32 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138953|0 |1 is obsolete| | --- Comment #29 from Marcel de Rooy --- Created attachment 140416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140416&action=edit Bug 30588: Add 'enforced' option to TwoFactorAuthentication Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 11:15:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 09:15:36 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138954|0 |1 is obsolete| | --- Comment #30 from Marcel de Rooy --- Created attachment 140417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140417&action=edit Bug 30588: Adjust existing occurrences of TwoFactorAuthentication We need to replace 0 with 'disabled', and 1 with 'enabled' Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 11:15:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 09:15:40 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138955|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy --- Created attachment 140418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140418&action=edit Bug 30588: Add the option to require 2FA setup on first staff login Bug 28786 added the ability to turn on a two-factor authentication, using a One Time Password (OTP). Once enabled on the system, librarian had the choice to enable or disable it for themselves. For security reason an administrator could decide to force the librarians to use this second authentication step. This patch adds a third option to the existing syspref, 'Enforced', for that purpose. QA notes: the code we had in the members/two_factor_auth.pl controller has been moved to REST API controller methods (with their tests and swagger specs), for reusability reason. Code from template has been moved to an include file for the same reason. Test plan: A. Regression tests As we modified the code we need first to confirm the existing features are still working as expected. 1. Turn off TwoFactorAuthentication (disabled) and confirm that you are not able to enable and access the second authentication step 2. Turn it on (enabled) and confirm that you are able to enable it in your account 3. Logout and confirm then that you are able to login into Koha B. The new option 1. Set the pref to "enforced" 2. You are not logged out, logged in users stay logged in 3. Pick a user that does not have 2FA setup, login 4. Notice the new screen (UI is a bit ugly, suggestions welcomed) 5. Try to access Koha without enabling 2FA, you shouldn't be able to access any pages 6. Setup 2FA and confirm that you are redirected to the login screen 7. Login, send the correct pin code => You are fully logged in! Note that at 6 we could redirect to the mainpage, without the need to login again, but I think it's preferable to reduce the change to C4::Auth. If it's considered mandatory by QA I could have a look on another bug report. Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 11:15:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 09:15:44 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138956|0 |1 is obsolete| | --- Comment #32 from Marcel de Rooy --- Created attachment 140419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140419&action=edit Bug 30588: Adjust existing selenium tests Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 11:15:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 09:15:48 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138957|0 |1 is obsolete| | --- Comment #33 from Marcel de Rooy --- Created attachment 140420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140420&action=edit Bug 30588: Add tests for the REST API routes Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 11:15:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 09:15:54 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138958|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy --- Created attachment 140421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140421&action=edit Bug 30588: Add selenium tests Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 11:15:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 09:15:59 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138959|0 |1 is obsolete| | --- Comment #35 from Marcel de Rooy --- Created attachment 140422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140422&action=edit Bug 30588: Add tests for C4::checkauth Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 11:16:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 09:16:03 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138960|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy --- Created attachment 140423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140423&action=edit Bug 30588: Add missing atomic update Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 11:16:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 09:16:08 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138961|0 |1 is obsolete| | --- Comment #37 from Marcel de Rooy --- Created attachment 140424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140424&action=edit Bug 30588: Add missing include file Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 11:16:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 09:16:12 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140365|0 |1 is obsolete| | --- Comment #38 from Marcel de Rooy --- Created attachment 140425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140425&action=edit Bug 30588: (QA follow-up) Typos in sysprefs.sql The codebase uses disabled and enforced which is imo better too. So we need to fix this sql file. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 11:16:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 09:16:16 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140366|0 |1 is obsolete| | --- Comment #39 from Marcel de Rooy --- Created attachment 140426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140426&action=edit Bug 30588: (QA follow-up) Missing shebang in TwoFactorAuth.t Test plan: Try t/db_dependent/Koha/Auth/TwoFactorAuth.t on cmd line. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 11:16:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 09:16:21 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140367|0 |1 is obsolete| | --- Comment #40 from Marcel de Rooy --- Created attachment 140427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140427&action=edit Bug 30588: (QA follow-up) Remove erroneous FIXME Comment speaks for itself. Look at surrounding code. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 11:16:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 09:16:25 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140368|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy --- Created attachment 140428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140428&action=edit Bug 30588: (QA follow-up) Auth - remove two warns and second logout Resolves: Use of uninitialized value $request_method in string eq at /usr/share/koha/C4/Auth.pm line 1122. Use of uninitialized value $return in numeric gt (>) at /usr/share/koha/C4/Auth.pm line 1155. We also remove the double logout from Auth.t Test plan: Run t/db_dependent/Auth.t Check if you do not see the warns anymore. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 11:16:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 09:16:29 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140369|0 |1 is obsolete| | --- Comment #42 from Marcel de Rooy --- Created attachment 140429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140429&action=edit Bug 30588: (QA follow-up) Adjust flags for two_factor_auth.pl Anyone with staff access (catalogue) should be able to go to account and enable 2FA. Test plan: Have a staff user with minimum staff permission. Access account, manage 2FA. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 11:16:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 09:16:34 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 --- Comment #43 from Marcel de Rooy --- Created attachment 140430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140430&action=edit Bug 30588: (QA follow-up) Clear waiting-for-2FA-setup in session If we do not clear this session, the first login directly after setup does not really enhances user experience ;) Test plan: Make sure 2FA is enforced. Test the above. Disable your 2FA, logout and login. Verify that you can access pages with this patch now. Without this patch you could not. Run these tests to provide more confidence: t/db_dependent/Auth.t t/db_dependent/api/v1/two_factor_auth.t t/db_dependent/Koha/Auth/TwoFactorAuth.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 11:28:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 09:28:35 +0000 Subject: [Koha-bugs] [Bug 31550] WS ILSDI opac description for some item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 11:28:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 09:28:39 +0000 Subject: [Koha-bugs] [Bug 31550] WS ILSDI opac description for some item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 --- Comment #1 from Thibaud Guillot --- Created attachment 140431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140431&action=edit Bug 31552: Add fields to get opac description on ILSDI web service Test plan 1) Active your ILS-DI syspref 2) Have some authorised values linked to one or more concern fields 3) Choose an item and go to 'cgi-bin/koha/opac/ilsdi.pl?service=GetRecords&id=' 4) The XML file contains item fields with some of them the code associated to the authorized values. 5) Apply this patch 6) Repeat step 3 and see the new fields with specific "_description" suffix added and contains opac description from authorized values -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 11:29:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 09:29:31 +0000 Subject: [Koha-bugs] [Bug 31550] WS ILSDI opac description for some item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 --- Comment #2 from Thibaud Guillot --- Comment on attachment 140431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140431 Bug 31552: Add fields to get opac description on ILSDI web service >From e618b742c79ba17b4418685c229e27dd1de244c0 Mon Sep 17 00:00:00 2001 >From: Thibaud Guillot >Date: Mon, 12 Sep 2022 11:04:07 +0200 >Subject: [PATCH] Bug 31550: Add fields to get opac description on ILSDI web > service > >Test plan > >1) Active your ILS-DI syspref >2) Have some authorised values linked to one or more concern >fields >3) Choose an item and go to 'cgi-bin/koha/opac/ilsdi.pl?service=GetRecords&id=' >4) The XML file contains item fields with some of them the code associated to the authorized values. >5) Apply this patch >6) Repeat step 3 and see the new fields with specific "_description" >suffix added and contains opac description from authorized values > >https://bugs.koha-community.org/show_bug.cgi?id=31550 >--- > C4/ILSDI/Services.pm | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > >diff --git a/C4/ILSDI/Services.pm b/C4/ILSDI/Services.pm >index f6bf6bcc14..b8e23c4a5b 100644 >--- a/C4/ILSDI/Services.pm >+++ b/C4/ILSDI/Services.pm >@@ -253,10 +253,15 @@ sub GetRecords { > $item{'homebranchname'} = $home_library ? $home_library->branchname : ''; > $item{'holdingbranchname'} = $holding_library ? $holding_library->branchname : ''; > >- if ($item->location) { >- my $authorised_value = Koha::AuthorisedValues->find_by_koha_field({ kohafield => 'items.location', authorised_value => $item->location }); >- if ($authorised_value) { >- $item{location_description} = $authorised_value->opac_description; >+ my @item_fields_description = ( 'location', 'ccode', 'permanent_location', 'notforloan', 'itemlost', 'withdrawn', 'damaged', 'restricted' ); >+ >+ foreach (@item_fields_description) { >+ >+ if ( $item->$_ ) { >+ my $authorised_value = Koha::AuthorisedValues->find_by_koha_field( { kohafield => 'items.' . $_, authorised_value => $item->$_ } ); >+ if ($authorised_value) { >+ $item{ $_ . _description } = $authorised_value->opac_description; >+ } > } > } > >-- >2.25.1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 11:30:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 09:30:43 +0000 Subject: [Koha-bugs] [Bug 31550] WS ILSDI opac description for some item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140431|0 |1 is obsolete| | --- Comment #3 from Thibaud Guillot --- Created attachment 140432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140432&action=edit Bug 31550: Add fields to get opac description on ILSDI web service Test plan 1) Active your ILS-DI syspref 2) Have some authorised values linked to one or more concern fields 3) Choose an item and go to 'cgi-bin/koha/opac/ilsdi.pl?service=GetRecords&id=' 4) The XML file contains item fields with some of them the code associated to the authorized values. 5) Apply this patch 6) Repeat step 3 and see the new fields with specific "_description" suffix added and contains opac description from authorized values -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 11:47:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 09:47:40 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #198 from Paul Poulain --- @julian : am I wrong or the sandbox has not been updated with the last patch ? https://staff-bug30952.sandboxes.biblibre.eu/ (however: I like the screenshot, more than the search inside the menu: more clear and less risk of overwriting something with too many information on the menu line) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 11:47:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 09:47:43 +0000 Subject: [Koha-bugs] [Bug 29001] Subfields attributes are not preserved when order is changed in framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Severity|normal |blocker --- Comment #11 from Arthur Suzuki --- lots of conflicts on the templates when trying to apply to 21.11.x. Please provide a backport patch if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 12:08:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 10:08:15 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #199 from Julian Maurice --- (In reply to Paul Poulain from comment #198) > @julian : am I wrong or the sandbox has not been updated with the last patch > ? > https://staff-bug30952.sandboxes.biblibre.eu/ I'm surprised it still exists because it is not listed on the sandboxes page... (so we cannot delete it :/) I'm not sure what's happening with the sandboxes but I decided to not use them anymore as they tend to break after some (short) time. So you're right, the sandbox is not up to date. If you want an up-to-date version you have to create a new sandbox. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 12:25:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 10:25:42 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #200 from Julian Maurice --- I summarized the search bar options in a poll on github: https://github.com/jajm/koha-staff-interface-redesign/discussions/34 Please vote :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 12:38:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 10:38:38 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #201 from Katrin Fischer --- > If you want an up-to-date version you have to create a new sandbox. Are we supposed to use the patches here or the git branch? If the git branch: how can I set this up on the sandbox? I failed spectacularly last time I tried the use the branch options in the sandbox form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 13:15:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 11:15:38 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #202 from Julian Maurice --- I update both at the same time, so you can use the method you prefer (or in that case, the one that works ;)) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 13:18:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 11:18:57 +0000 Subject: [Koha-bugs] [Bug 30451] Delete a subscription deletes the linked order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30451 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Delete a subscription |Delete a subscription |delete the linked order |deletes the linked order --- Comment #2 from Katrin Fischer --- I'd like to give this another push, the current behaviour means that we are losing data that is still needed in acq. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 13:44:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 11:44:24 +0000 Subject: [Koha-bugs] [Bug 31250] Don't remove advanced/basic cataloging editor cookie on logout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31250 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #20 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #13) > (In reply to Jonathan Druart from comment #12) > > How will you modified the config files? Once this is pushed you will have to > > keep the behaviour. If we propose a generic solution from the beginning, > > future will be easier ;) > > All improvements in the future :) > Will think a bit about it. Have you thougth about it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 13:45:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 11:45:06 +0000 Subject: [Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 13:45:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 11:45:09 +0000 Subject: [Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 13:45:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 11:45:52 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #203 from Julian Maurice --- Created attachment 140433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140433&action=edit Bug 30952: Fix background of search header Issue #3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:06:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:06:09 +0000 Subject: [Koha-bugs] [Bug 31504] ElasticSearch No indexing new records after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31504 --- Comment #1 from Nick Clemens --- Can you share the ES config, with the instance name replaced, rather than removed? The issue seems to be that ES cannot be reached, can you curl the host? that should get you the standard es 'you know, for search' response (In reply to Hugo Agud from comment #0) > After upgrading koha 21.11 to 22.05 ElasticSearch is not able to index new > records. > > At webadmin we can see the warning > > 'Index 'koha_xxxxxx' needs to be recreated.' > > Executing 'Reset mapping' button doesn't fix the error... > when trying to full reindex with option -d or -r it doesn't work > > admin at ___21:~$ sudo koha-elasticsearch --rebuild -d ___ > > sudo: unable to resolve host ___21: Name or service not known > > sudo: unable to resolve host ___21: Name or service not known > > Use of uninitialized value $reason in concatenation (.) or string at > /usr/share/koha/lib/Koha/SearchEngine/Elasticsearch/Indexer.pm line 283. > > Exception 'Koha::Exception' thrown 'Unable to update mappings for index > "koha_____biblios". Reason was: "". Index needs to be recreated and > reindexed' > > Something went wrong rebuilding indexes for ___ > > Removing the index directly at ElasticSearch doesn't works > > * ElasticSearch is not localhost -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:11:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:11:25 +0000 Subject: [Koha-bugs] [Bug 31537] Elasticsearch - index mapping for 003 control-number-identifier is twice in mappings.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31537 --- Comment #7 from Caroline Cyr La Rose --- (In reply to Katrin Fischer from comment #6) > Stared at this quite a while, wondering if one would be the definition for > authorities - but it isn't, just a double up. Yeah, me too! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:11:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:11:52 +0000 Subject: [Koha-bugs] [Bug 31250] Don't remove advanced/basic cataloging editor cookie on logout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31250 --- Comment #21 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #20) > (In reply to Marcel de Rooy from comment #13) > > (In reply to Jonathan Druart from comment #12) > > > How will you modified the config files? Once this is pushed you will have to > > > keep the behaviour. If we propose a generic solution from the beginning, > > > future will be easier ;) > > > > All improvements in the future :) > > Will think a bit about it. > > Have you thougth about it? Yes and I added a follow-up. Allowing the required flexibility via regexes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:12:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:12:39 +0000 Subject: [Koha-bugs] [Bug 31250] Don't remove advanced/basic cataloging editor cookie on logout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31250 --- Comment #22 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #21) > (In reply to Tomás Cohen Arazi from comment #20) > > (In reply to Marcel de Rooy from comment #13) > > > (In reply to Jonathan Druart from comment #12) > > > > How will you modified the config files? Once this is pushed you will have to > > > > keep the behaviour. If we propose a generic solution from the beginning, > > > > future will be easier ;) > > > > > > All improvements in the future :) > > > Will think a bit about it. > > > > Have you thougth about it? > > Yes and I added a follow-up. Allowing the required flexibility via regexes. Which is the generic solution mentioned. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:15:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:15:42 +0000 Subject: [Koha-bugs] [Bug 31216] inventory.pl is slow when comparing many barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31216 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:16:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:16:32 +0000 Subject: [Koha-bugs] [Bug 31525] Street number not being accessed correctly on patron search results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31525 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:16:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:16:35 +0000 Subject: [Koha-bugs] [Bug 31525] Street number not being accessed correctly on patron search results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31525 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140415|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 140434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140434&action=edit Bug 31525: display streetnumber with address in patron search Adds back street number to the address when searching for patrons To test: 1) Edit a patron's contact information 2) Under Main Address put an address, make sure to put something in the Street number field 3) Do a simple patron search that will yield results (i.e. "a") 4) Confirm the street number does not show, but the rest of the address does 5) Apply this patch 6) Do another patron search 5) Confirm the street number now shows Sponsored-by: Catalyst IT Testing note: AddressFormat system preference must be set to "US style" Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:17:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:17:46 +0000 Subject: [Koha-bugs] [Bug 31504] ElasticSearch No indexing new records after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31504 --- Comment #2 from Hugo Agud --- Hi It is not an ES issue, it is a koha issue, I am pretty sure (and it has been appeared just with 22.05 not previous upgrades) I have checked this koha with many ES Servers (new and previous working ES v6.*), I have checked with working ES, with same results. I saw this error in the very beginng of testing koha, and it was an url (I can't remmeber that via url and 'I know what I am doing') you can delete index. Exception 'Koha::Exception' thrown 'Unable to update mappings for index "koha__demo1_biblios". Reason was: "". Index needs to be recreated and reindexed' It is something that can't be overwritten in koha that makes it crash -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:31:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:31:10 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #204 from Julian Maurice --- Created attachment 140435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140435&action=edit Bug 30952: Fix item edit form Issue #31 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:40:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:40:06 +0000 Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content warnings' to catalogue records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #10 from Martin Renvoize --- Interesting, I can't replicate that issue.. perhaps caching related? We don't really touch any of the AV in XSLT handling code in here, so I can't see how it would fail here but not elsewhere? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:40:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:40:49 +0000 Subject: [Koha-bugs] [Bug 31551] New: Add a 'Quick add' option for harmful content warnings. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31551 Bug ID: 31551 Summary: Add a 'Quick add' option for harmful content warnings. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:43:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:43:42 +0000 Subject: [Koha-bugs] [Bug 31551] Add a 'Quick add' option for harmful content warnings. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31551 --- Comment #1 from Martin Renvoize --- Clicked too fast... Description: In bug 31123 we add the option to define a MARC field to contain 'Harmful content' warning notes. These can be free text or tied to an authorized value as per any other marc field using frameworks. This bug is an enhancement on top of that to add a modal-based workflow for adding such warnings directly from the detail view without having to go into the full cataloguing interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:43:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:43:50 +0000 Subject: [Koha-bugs] [Bug 31551] Add a 'Quick add' option for harmful content warnings. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31551 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31123 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 [Bug 31123] Add a simple way to add 'Harmful content warnings' to catalogue records -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:43:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:43:50 +0000 Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content warnings' to catalogue records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31551 [Bug 31551] Add a 'Quick add' option for harmful content warnings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:43:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:43:54 +0000 Subject: [Koha-bugs] [Bug 31551] Add a 'Quick add' option for harmful content warnings. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31551 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:50:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:50:02 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140289|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize --- Created attachment 140436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140436&action=edit Bug 31028: Add catalog_concerns table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:50:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:50:08 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140290|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize --- Created attachment 140437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140437&action=edit Bug 31028: DBIC Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:50:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:50:13 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140291|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize --- Created attachment 140438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140438&action=edit Bug 31028: Add `CatalogConcerns` and `OpacCatalogConcerns` preferences This patch adds the `CatalogConcerns` and `OpacCatalogeConcerns` system preferences to enable/disable the catalog concerns feature on the OPAC and Staff client interfaces. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:50:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:50:19 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140292|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize --- Created attachment 140439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140439&action=edit Bug 31028: Add catalog concerns endpoints This patch adds the staff accessible REST API endpoints for catalog concerns. New endpoints available: * POST /catalog/concerns * GET /catalog/concerns * GET /catalog/concerns/{concern_id} * PUT /catalog/concerns/{concern_id} * DELETE /catalog/concenrs/{concern_id} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:50:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:50:24 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140293|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize --- Created attachment 140440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140440&action=edit Bug 31028: Add relations to Catalog::Concern This patch adds the reporter, resolver and biblio relations to the Catalog::Concern class and exposes them to the API as appropriate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:50:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:50:29 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140294|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize --- Created attachment 140441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140441&action=edit Bug 31028: Add Public API endpoint -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:50:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:50:34 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140295|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize --- Created attachment 140442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140442&action=edit Bug 31028: Add 'Report a concern' to OPAC details This patch adds a new 'Report a concern' option to the right sidebar on the opac detail page. On clicking the link, a modal will display allowing the user to enter a short message regarding their concerns and then submission will record said message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:50:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:50:39 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140296|0 |1 is obsolete| | --- Comment #71 from Martin Renvoize --- Created attachment 140443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140443&action=edit Bug 31028: Trigger login modal when not logged in This isn't perfect, we detect if there is a logged in user on the OPAC and replace the concern report modal with the login modal if we don't find a valid session. Unfortunelty, we can't then trigger a redirect back to the record details as that's not how our get_template_and_user authentication system works.. instead we end up back at opac-user.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:50:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:50:43 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140297|0 |1 is obsolete| | --- Comment #72 from Martin Renvoize --- Created attachment 140444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140444&action=edit Bug 31028: Tie OPAC display to logged in state This is an alternative to th previous patch.. we can't easily redirect back to the right location after login from our modal. It would be preferable to display the button and prompt a login if we don't have a valid session.. but that's not trivial using the API's and our login flows at the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:50:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:50:48 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140298|0 |1 is obsolete| | --- Comment #73 from Martin Renvoize --- Created attachment 140445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140445&action=edit Bug 31028: Add a catalog concerns management page This patch adds a new cataloguing concerns page to the staff client for managing reported catalog concerns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:50:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:50:53 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140299|0 |1 is obsolete| | --- Comment #74 from Martin Renvoize --- Created attachment 140446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140446&action=edit Bug 31028: Add 'special:undefined' to handle passing 'null' We can't pass 'null' to the column.search as it gets stringified. This patch adds a special string 'special:undefined' to denote that we want to search on undef for the field in question. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:50:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:50:58 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140300|0 |1 is obsolete| | --- Comment #75 from Martin Renvoize --- Created attachment 140447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140447&action=edit Bug 31028: Add filters to concerns management -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:51:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:51:03 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140301|0 |1 is obsolete| | --- Comment #76 from Martin Renvoize --- Created attachment 140448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140448&action=edit Bug 31028: Add resolution endpoint This patch adds a /resolve endpoint to the catalog concerns endpoints. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:51:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:51:08 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140302|0 |1 is obsolete| | --- Comment #77 from Martin Renvoize --- Created attachment 140449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140449&action=edit Bug 31028: Add resolve action This patch adds a resolution workflow to the catalog concerns management page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:51:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:51:13 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140303|0 |1 is obsolete| | --- Comment #78 from Martin Renvoize --- Created attachment 140450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140450&action=edit Bug 31028: Add 'Add catalog concern' to cataloguing toolbar This patch moves the add concern modal js and template markup into their own files and then references them to add the 'Add concern' option to the cataloguing toolbar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:51:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:51:18 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140304|0 |1 is obsolete| | --- Comment #79 from Martin Renvoize --- Created attachment 140451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140451&action=edit Bug 31028: Add notice trigger for catalog concerns This patch adds a new system prefernce, `CatalogerEmails`. If set with a valid email address adding a new catalog concern should produce a notification email sent to that address. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:51:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:51:23 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140305|0 |1 is obsolete| | --- Comment #80 from Martin Renvoize --- Created attachment 140452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140452&action=edit Bug 31028: Add trigger and notice to resolve This patch adds a sample notice and sets up the trigger to notify the concern reporter when a concern is marked as resolved. The notification itself is optional at resolve time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:51:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:51:28 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140306|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize --- Created attachment 140453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140453&action=edit Bug 31028: (QA follow-up) This is a 'tool' At the moment, this feature is accessible under tools only rather than cataloging. Whilst we await the new cataloging homepage and sidebar this path replaces the breadcrumb with 'Tools' and removes the 'cat-menu' include. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:51:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:51:32 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140307|0 |1 is obsolete| | --- Comment #82 from Martin Renvoize --- Created attachment 140454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140454&action=edit Bug 31028: (QA follow-up) Table configuration This patch properly adds the table configuration options to the catalog concerns table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:51:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:51:37 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140308|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize --- Created attachment 140455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140455&action=edit Bug 31028: Use additional_contents for help block This patch updates the modal to use the additional_contents system for the modals help block -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:55:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:55:53 +0000 Subject: [Koha-bugs] [Bug 31373] Notice template validation is missing INCLUDE_PATH In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31373 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:55:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:55:57 +0000 Subject: [Koha-bugs] [Bug 31373] Notice template validation is missing INCLUDE_PATH In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31373 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139211|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy --- Created attachment 140456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140456&action=edit Bug 31373: Add INCLUDE_PATH to notice validation This is a follow-up to bug 31211. It adds the same INCLUDE_PATH variables as C4::Templates adds during processing to prevent false failures. Test plan 1) Add an INCLUDE to any valid notice, for example: [% INCLUDE 'patron-title.inc' patron => patron %] 2) Save and continue 3) Confirm you are faced with a validation error complaining that the include file cannot be found 4) Apply this patch 5) Confirm that the reported error has dissapeared Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:56:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:56:01 +0000 Subject: [Koha-bugs] [Bug 31373] Notice template validation is missing INCLUDE_PATH In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31373 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139677|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy --- Created attachment 140457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140457&action=edit Bug 31373: DRY - Use try/catch around _process_tt This patch reduces the repetition in the tools/letter.pl controller replaceing it with a try/catch block wrapping a call to C4::Letters::_process_tt instead. Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 14:56:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 12:56:18 +0000 Subject: [Koha-bugs] [Bug 31373] Notice template validation is missing INCLUDE_PATH In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31373 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 15:11:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 13:11:19 +0000 Subject: [Koha-bugs] [Bug 31525] Street number not being accessed correctly on patron search results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31525 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 15:11:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 13:11:23 +0000 Subject: [Koha-bugs] [Bug 31525] Street number not being accessed correctly on patron search results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31525 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140434|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 140458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140458&action=edit Bug 31525: display streetnumber with address in patron search Adds back street number to the address when searching for patrons To test: 1) Edit a patron's contact information 2) Under Main Address put an address, make sure to put something in the Street number field 3) Do a simple patron search that will yield results (i.e. "a") 4) Confirm the street number does not show, but the rest of the address does 5) Apply this patch 6) Do another patron search 5) Confirm the street number now shows Sponsored-by: Catalyst IT Testing note: AddressFormat system preference must be set to "US style" Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 15:12:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 13:12:56 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #205 from Julian Maurice --- Created attachment 140459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140459&action=edit Bug 30952: Move 'Clear filter' next to filter in table headers Issue #16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 15:14:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 13:14:53 +0000 Subject: [Koha-bugs] [Bug 31525] Street number not being accessed correctly on patron search results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31525 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 15:29:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 13:29:47 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #206 from Katrin Fischer --- (In reply to Julian Maurice from comment #202) > I update both at the same time, so you can use the method you prefer (or in > that case, the one that works ;)) No luck with the sandbox, I "build CSS" after spinning it up: https://staff-gui.sandboxes.biblibre.eu/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 15:30:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 13:30:56 +0000 Subject: [Koha-bugs] [Bug 31259] Downloading patron card PDF hangs the server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31259 --- Comment #11 from Liz Rea --- It appears to not be infinite when the text doesn't have to wrap. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 15:43:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 13:43:07 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #207 from Katrin Fischer --- (In reply to Katrin Fischer from comment #206) > (In reply to Julian Maurice from comment #202) > > I update both at the same time, so you can use the method you prefer (or in > > that case, the one that works ;)) > > No luck with the sandbox, I "build CSS" after spinning it up: > https://staff-gui.sandboxes.biblibre.eu/ Stubborn browser cache - all good now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 16:00:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 14:00:29 +0000 Subject: [Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 --- Comment #5 from Martin Renvoize --- I have recollections of trying to improve the Context method before and getting caught by all sorts of weird side effects.. do you happen to remember the details David? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 16:05:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 14:05:01 +0000 Subject: [Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29420 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 16:05:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 14:05:01 +0000 Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31468 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 16:06:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 14:06:17 +0000 Subject: [Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 --- Comment #6 from Martin Renvoize --- Lots of discussion around our various implimentations of 'Is this a plack/psgi session' in bug 29420 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 16:20:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 14:20:09 +0000 Subject: [Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 --- Comment #7 from Martin Renvoize --- My gut says we should finally test and push bug 29744 before this.. harmonizing the plack detection and then use it here too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 16:20:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 14:20:23 +0000 Subject: [Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 16:22:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 14:22:00 +0000 Subject: [Koha-bugs] [Bug 28760] Granular restrictions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28760 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- With the recent work to move restriction types to their own table this might be more achievable now -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 16:25:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 14:25:45 +0000 Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 16:29:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 14:29:34 +0000 Subject: [Koha-bugs] [Bug 29658] Crash on cancelling cancelled order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 16:31:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 14:31:18 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #208 from Julian Maurice --- Created attachment 140460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140460&action=edit Bug 30952: Change circulation home page links to buttons Apply the same style to staff home page links Issue #18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 16:34:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 14:34:22 +0000 Subject: [Koha-bugs] [Bug 30025] Split BiblioAddsAuthorities into 2 preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|m.de.rooy at rijksmuseum.nl |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 16:39:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 14:39:08 +0000 Subject: [Koha-bugs] [Bug 31540] Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31540 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 16:39:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 14:39:12 +0000 Subject: [Koha-bugs] [Bug 31540] Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31540 --- Comment #1 from Nick Clemens --- Created attachment 140461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140461&action=edit Bug 31540: Exclude expired holds from the reminder job Some libraries don't want to auto-cancel holds, but we should not remind a patron about a hold which has expired. To test: 1 - Place a hold for a patron 2 - Set it waiting 3 - Run the holds reminder script in the future perl misc/cronjobs/holds/holds_reminder.pl -day 1 --date '2023-09-12' -v 4 - Note the holds would be reminded 5 - Set expirationdate for the hold less than today UPDATE reserves SET expirationdate = DATE_SUB(CURDATE(), INTERVAL 1 DAY); 6 - Run the remidner cron again 7 - No holds trigger! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 16:49:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 14:49:48 +0000 Subject: [Koha-bugs] [Bug 28950] serialsUpdate cron does not mark an issue late until the next issue is expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28950 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 16:49:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 14:49:52 +0000 Subject: [Koha-bugs] [Bug 28950] serialsUpdate cron does not mark an issue late until the next issue is expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28950 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140324|0 |1 is obsolete| | --- Comment #6 from Joonas Kylmälä --- Created attachment 140462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140462&action=edit Bug 28950: Mark serial late when past grace period This script had some oddities: - There was a LEFT JOIN to subscription, but no error printed if no subscription I changed this to a JOIN as there is a constraint, so this shoudl not happen - Publisheddate was checked after the SQL, moved into query - We checked for the next issue, and marked late only if that issue was already expected This overruled grace period, which should be the mnarker for a serial being late The grace period should be extended if you wish to wait for next issue - If no next published date, we reported an error on the planneddate - Script without confirm had no reporting Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 16:51:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 14:51:36 +0000 Subject: [Koha-bugs] [Bug 28950] serialsUpdate cron does not mark an issue late until the next issue is expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28950 --- Comment #7 from Joonas Kylmälä --- (In reply to Nick Clemens from comment #5) > (In reply to Joonas Kylmälä from comment #4) > > Nick can you confirm, it seems that now after this patch we will create a > > new issue to be expected if the current one is late, and then this will > > continue until we have ran into subscription end date or subscription issue > > length? I'm just wondering if libraries are prepared for this and haven't > > set their end dates for subscriptions to the year 2999. The old code seems > > to have stopped creating these new Expected/Missing entries (not 100% on > > this...). > > I don't believe this changes for how long we wil generate issues, but only > when we will mark them late. Thanks, you are right, I was too lazy to test this, but now did so and indeed, we are generating with and without this patch the new expected issues until we reach the end of the subscription. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 16:57:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 14:57:48 +0000 Subject: [Koha-bugs] [Bug 31539] Delay not taken in account when items with different due date are listed in overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31539 --- Comment #2 from Noémie Labine --- Hi Katrin, Thank you very much, I didn't know about this flag. All our sites have the same cronjobs with the same flags so it makes sens the behaviour is the same everywhere for us. We'll try to remove the list-all flag. Thank you again -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 16:59:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 14:59:15 +0000 Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #26 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 17:27:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 15:27:14 +0000 Subject: [Koha-bugs] [Bug 31535] Fix a staff warn or two In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31535 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | CC| |joonas.kylmala at iki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 17:29:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 15:29:07 +0000 Subject: [Koha-bugs] [Bug 31535] Fix a staff warn or two In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31535 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 17:29:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 15:29:11 +0000 Subject: [Koha-bugs] [Bug 31535] Fix a staff warn or two In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31535 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140362|0 |1 is obsolete| | Attachment #140363|0 |1 is obsolete| | Attachment #140364|0 |1 is obsolete| | --- Comment #6 from Joonas Kylmälä --- Created attachment 140463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140463&action=edit Bug 31535: Fix warning - uninitialized value $mode in string ne (addbiblio.pl) Line number varies across versions. (Should be L887 now.) Resolves: Use of uninitialized value $mode in string ne at /usr/share/koha/cataloguing/addbiblio.pl line 845. No test plan here. This is trivial. Read the patch. Signed-off-by: Marcel de Rooy Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 17:29:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 15:29:15 +0000 Subject: [Koha-bugs] [Bug 31535] Fix a staff warn or two In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31535 --- Comment #7 from Joonas Kylmälä --- Created attachment 140464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140464&action=edit Bug 31535: Fix warning - uninitialized value in string ne (MARCdetail.pl) Spotted at line 183 (older Koha version). Test plan: You need a NULL in the tab column of marc_subfield_structure. Hit this page and check the logs. This might convince you easier: my $tabloop=0; my $x; print "Empty string - True\n" if ( $x // q{} ) ne $tabloop; print "Zero - True\n" if ( $x // '0' ) ne $tabloop; You should only see: Empty string - True proving that defaulting to '0' would be a game changer. Signed-off-by: Marcel de Rooy Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 17:29:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 15:29:19 +0000 Subject: [Koha-bugs] [Bug 31535] Fix a staff warn or two In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31535 --- Comment #8 from Joonas Kylmälä --- Created attachment 140465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140465&action=edit Bug 31535: Fix warning - uninitialized value for location In Koha/Item.pm line 169 (line number has been changed) Test plan: You need location to be NULL when storing. Otherwise follow this reasoning: What happens when location is undefined? It is autovivified to empty string in the string compare (ne), so not equal to CART and PROC. The subcondition is true before and after this patch. Signed-off-by: Marcel de Rooy Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 17:42:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 15:42:50 +0000 Subject: [Koha-bugs] [Bug 20628] Search result highlighting not working with truncated search terms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20628 Noémie Labine changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noemie.labine at collecto.ca --- Comment #1 from Noémie Labine --- Still valid in 21.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 17:43:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 15:43:17 +0000 Subject: [Koha-bugs] [Bug 31016] Highlight item in holdings when searching by barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31016 Noémie Labine changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noemie.labine at collecto.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 17:44:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 15:44:57 +0000 Subject: [Koha-bugs] [Bug 30025] Split BiblioAddsAuthorities into 2 preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 --- Comment #25 from Martin Renvoize --- Hmm.. I'm still not 100% on the new syspref name.. but it's not a deal breaker for me.. AutoLinkBiblios.. if you take just the name it sounds like it could plausibly be about other types of biblio linking.. like 773's ;p. However.. I think I'll leave that to the RM to debate.. QAing as is -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 17:46:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 15:46:08 +0000 Subject: [Koha-bugs] [Bug 30025] Split BiblioAddsAuthorities into 2 preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139505|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize --- Created attachment 140466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140466&action=edit Bug 30025: DB update Signed-off-by: AFHDubCoLib -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 17:46:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 15:46:12 +0000 Subject: [Koha-bugs] [Bug 30025] Split BiblioAddsAuthorities into 2 preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139506|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize --- Created attachment 140467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140467&action=edit Bug 30025: Split BiblioAddsAuthorities into two sysprefs This patch adds two new sysprefs: AutoLinkBiblios AllowManualAuthorityEditing Both inherit the setting from BiblioAddsAuhtorities which is removed To test: 1 -Apply patches 2 - Update database 3 - Confirm old setting is transferred to new option 4 - Confirm you can edit authoriteis manually if AllowManualAuthorityEditing set to allow 5 - Confirm you cannot edit authorities manually if AllowManualAuthorityEditing set to don't allow 6 - Confirm a new bib is linked when AutoLinkBiblios is enabled (set AllowManualAuthorityEditing to add unlinked heading) 7 - Confirm new bib notlinked when AutoLinkBiblios is disabled 8 - Confim new bib not linked when AutoLinkBiblios is enabled, but heading doesn't match an authority and AutoCreateAuthorities is disabled 9 - Confim new bib linked to new authority when AutoLinkBiblios is enabled, but heading doesn't match an authority and AutoCreateAuthorities is enabled Signed-off-by: AFHDubCoLib -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 17:46:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 15:46:17 +0000 Subject: [Koha-bugs] [Bug 30025] Split BiblioAddsAuthorities into 2 preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139507|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize --- Created attachment 140468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140468&action=edit Bug 30025: Replace AllowManualAuthorityEditing with RequireChoosingExistingAuthority This flips the pref from an allowance to a requirement, hopefully this makes the logic here clearer Test as before, but the values for the renamed pref flipped Signed-off-by: AFHDubCoLib -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 17:47:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 15:47:27 +0000 Subject: [Koha-bugs] [Bug 30025] Split BiblioAddsAuthorities into 2 preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140466|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize --- Created attachment 140469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140469&action=edit Bug 30025: DB update Signed-off-by: AFHDubCoLib Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 17:47:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 15:47:31 +0000 Subject: [Koha-bugs] [Bug 30025] Split BiblioAddsAuthorities into 2 preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140467|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize --- Created attachment 140470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140470&action=edit Bug 30025: Split BiblioAddsAuthorities into two sysprefs This patch adds two new sysprefs: AutoLinkBiblios AllowManualAuthorityEditing Both inherit the setting from BiblioAddsAuhtorities which is removed To test: 1 -Apply patches 2 - Update database 3 - Confirm old setting is transferred to new option 4 - Confirm you can edit authoriteis manually if AllowManualAuthorityEditing set to allow 5 - Confirm you cannot edit authorities manually if AllowManualAuthorityEditing set to don't allow 6 - Confirm a new bib is linked when AutoLinkBiblios is enabled (set AllowManualAuthorityEditing to add unlinked heading) 7 - Confirm new bib notlinked when AutoLinkBiblios is disabled 8 - Confim new bib not linked when AutoLinkBiblios is enabled, but heading doesn't match an authority and AutoCreateAuthorities is disabled 9 - Confim new bib linked to new authority when AutoLinkBiblios is enabled, but heading doesn't match an authority and AutoCreateAuthorities is enabled Signed-off-by: AFHDubCoLib Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 17:47:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 15:47:36 +0000 Subject: [Koha-bugs] [Bug 30025] Split BiblioAddsAuthorities into 2 preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140468|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize --- Created attachment 140471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140471&action=edit Bug 30025: Replace AllowManualAuthorityEditing with RequireChoosingExistingAuthority This flips the pref from an allowance to a requirement, hopefully this makes the logic here clearer Test as before, but the values for the renamed pref flipped Signed-off-by: AFHDubCoLib Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 17:47:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 15:47:59 +0000 Subject: [Koha-bugs] [Bug 30025] Split BiblioAddsAuthorities into 2 preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #32 from Martin Renvoize --- Nice clarification in general.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 17:58:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 15:58:21 +0000 Subject: [Koha-bugs] [Bug 29658] Crash on cancelling cancelled order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139930|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 140472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140472&action=edit Bug 29658: Fix crash on cancelling cancelled order Found this crash in our 20.11 logs: Cannot insert order: Mandatory parameter biblionumber is missing at /usr/share/koha/acqui/cancelorder.pl line 60. at /usr/share/perl/5.28/Carp.pm line 289 Carp::croak('Cannot insert order: Mandatory parameter biblionumber is missing') called at /usr/share/koha/Koha/Acquisition/Order.pm line 79 Koha::Acquisition::Order::store('Koha::Acquisition::Order=HASH(0x55f3760e2860)') called at /usr/share/koha/Koha/Acquisition/Order.pm line 189 Koha::Acquisition::Order::cancel('Koha::Acquisition::Order=HASH(0x55f3760e2860)', 'HASH(0x55f375a17ec0)') called at /usr/share/koha/acqui/cancelorder.pl line 60 Not sure how to reproduce this one as it happened. But might be related to repeated clicking, backspacing etc. Test plan: Create a new basket and order. Open this same basket in two browser tabs. Cancel the order line (delete catalog record) in tab 1. Go to second tab, try again. Without this patch, it will crash. With this patch, an error message. Signed-off-by: Marcel de Rooy Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 17:58:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 15:58:46 +0000 Subject: [Koha-bugs] [Bug 29658] Crash on cancelling cancelled order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from Martin Renvoize --- Simple fix, no regressions. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:10:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:10:27 +0000 Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 --- Comment #46 from Martin Renvoize --- Created attachment 140473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140473&action=edit Bug 26247: Adding 2 Sysprefs for Search Terms This patch adds two system preferences options : 'RetainCatalogSearchTerms' and 'RetainPatronsSearchTerms'. If enabled, search terms will be retained between searches made from, respectively, the Search Catalog header and the Checkout or Search Patrons headers. If disabled, the searchbars will clear out between page loads. Attention, this is an alternate solution from the previous patches, ONLY apply this patch when testing and not the previous ones.Changed the syspref wording as well. To test: 1 - From the staff client, search some terms using the Check out header search bar. 2 - Confirm search terms are retained. 3 - Do Step 1-2 twice again, this time using the Search patrons and Search the catalog. 4 - Apply patch (again, only this one), update database. 5 - In the system preferences, look for RetainCatalogSearchTerms and set it to 'don't retain'. 6 - Use the checkout head search bar again, confirm that search terms aren't retained after page load. 7 - Do Step 5-6 once again, this time with the RetainPatronsSearchTerms and the Search Patrons and Search the catalog headers. 8 - Search boxes should be cleared. Thanks-to: Fridolin Somers and Nick Clemens for the bases I built on. Signed-off-by: Florian Bontemps Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:10:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:10:33 +0000 Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 --- Comment #47 from Martin Renvoize --- Created attachment 140474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140474&action=edit Bug 26247: (QA follow-up) Merge DB Updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:11:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:11:11 +0000 Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138478|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:11:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:11:24 +0000 Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #48 from Martin Renvoize --- Great work, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:14:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:14:20 +0000 Subject: [Koha-bugs] [Bug 31516] Missing error handling for accessing deleted/non-existent club enrollment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31516 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140326|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 140475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140475&action=edit Bug 31516: Add error message for viewing enrollments for a non-existent club To test: 1) Go to non-existent club's enrollment page, e.g. http://localhost:8081/cgi-bin/koha/clubs/club-enrollments.pl?id=1010101001000 2) Notice the not fully filled header text and empty table 3) Apply patch and revisit the page to see the proper error message given Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:14:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:14:38 +0000 Subject: [Koha-bugs] [Bug 31516] Missing error handling for accessing deleted/non-existent club enrollment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31516 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Trivial fix, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:24:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:24:31 +0000 Subject: [Koha-bugs] [Bug 31412] Set focus for cursor to Name when adding a new SMTP server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31412 --- Comment #1 from Isobel Graham --- Created attachment 140476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140476&action=edit Bug 29608: Made so doesn't require full permission Made so the numbering sequence does not need to require full permission. 1. Edit number patterns a confirm you don't need full permission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:25:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:25:29 +0000 Subject: [Koha-bugs] [Bug 31412] Set focus for cursor to Name when adding a new SMTP server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31412 Isobel Graham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |isobel.graham09 at gmail.com CC| |isobel.graham09 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:29:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:29:47 +0000 Subject: [Koha-bugs] [Bug 30921] Replace use of C4::XSLT::transformMARCXML4XSLT with RecordProcessor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:30:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:30:49 +0000 Subject: [Koha-bugs] [Bug 30921] Replace use of C4::XSLT::transformMARCXML4XSLT with RecordProcessor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:30:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:30:54 +0000 Subject: [Koha-bugs] [Bug 30921] Replace use of C4::XSLT::transformMARCXML4XSLT with RecordProcessor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140354|0 |1 is obsolete| | --- Comment #8 from Joonas Kylmälä --- Created attachment 140477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140477&action=edit Bug 30921: Replace C4::XSLT::transformMARCXML4XSLT with RecordProcessor This patch removes the last remaining uses of transformMARCXML4XSLT and replaced them with the equivilent RecordProcessor usage. Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:30:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:30:58 +0000 Subject: [Koha-bugs] [Bug 30921] Replace use of C4::XSLT::transformMARCXML4XSLT with RecordProcessor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 --- Comment #9 from Joonas Kylmälä --- Created attachment 140478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140478&action=edit Bug 30921: (QA follow-up) Remove unnecessary if The statement is already inside an if block with the same condition. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:31:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:31:03 +0000 Subject: [Koha-bugs] [Bug 20628] Search result highlighting not working with truncated search terms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20628 Maude changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maude.boudreau at collecto.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:35:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:35:16 +0000 Subject: [Koha-bugs] [Bug 31412] Set focus for cursor to Name when adding a new SMTP server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31412 --- Comment #2 from Isobel Graham --- Created attachment 140479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140479&action=edit Bug 31412: Add focus to 'name' on SMTP Servers This patch adds the focus class to ensure focus is given to the first form element on the SMTP server entry page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:40:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:40:20 +0000 Subject: [Koha-bugs] [Bug 31367] Display of sub-funds does not include totals of sub-sub-funds on acquisitions home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31367 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139850|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 140480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140480&action=edit Bug 31367: Add subtotals if budget has children On bug 29287 we added child funds if a fund had no parent id It turns out funds can have a parent, and still have children (sub-sub-funds) This patch simply checks for children, rather than checking for lack of parent. Totals are already calculated correctly in GetBudgetHierarchy To test: 1 - Add a fund "Fund" to a budget - assign 1000 dollars 2 - Add a sub-fund "SubFund" - assign 100 dollars 3 - Add a sub-sub-fund "SubSubFund" - assign 10 dollars 4 - Add to a basket $5 order from SubSubFund 5 - Add to a basket $50 order from SubFund 6 - Add to a basket $500 order form Fun 7 - View acqui home - note 'SubFund' does not include total from 'SubSubFund' 8 - Apply patch 9 - Confirm all sub-sub-funds totaled in sub-funds and that fund total correctly adds sub and sub-sub funds Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:40:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:40:41 +0000 Subject: [Koha-bugs] [Bug 31367] Display of sub-funds does not include totals of sub-sub-funds on acquisitions home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31367 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Nice fix, works as expected.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:44:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:44:25 +0000 Subject: [Koha-bugs] [Bug 31412] Set focus for cursor to Name when adding a new SMTP server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31412 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |joonas.kylmala at iki.fi --- Comment #3 from Joonas Kylmälä --- Isobel, seems like you attached a patch from another bug report by accident. I will mark that one as obsolete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:44:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:44:47 +0000 Subject: [Koha-bugs] [Bug 31412] Set focus for cursor to Name when adding a new SMTP server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31412 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140476|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:51:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:51:48 +0000 Subject: [Koha-bugs] [Bug 29409] Update for bug 25333 can fail due to bad data or constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29409 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139931|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 140481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140481&action=edit Bug 29409: Check for existence of constraint before deletion Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:51:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:51:53 +0000 Subject: [Koha-bugs] [Bug 29409] Update for bug 25333 can fail due to bad data or constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29409 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139932|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 140482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140482&action=edit Bug 29409: Check for data that violates a constraint to avoid update problems Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:52:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:52:17 +0000 Subject: [Koha-bugs] [Bug 29409] Update for bug 25333 can fail due to bad data or constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29409 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize --- Great work, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:54:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:54:09 +0000 Subject: [Koha-bugs] [Bug 31475] Group system preferences for suggestions on OPAC tab under new heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31475 --- Comment #1 from Isobel Graham --- Created attachment 140483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140483&action=edit Bug 31475: Added 'Suggestions' section to preferences Confrim all suggestion preferences are now grouped. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:54:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:54:37 +0000 Subject: [Koha-bugs] [Bug 31475] Group system preferences for suggestions on OPAC tab under new heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31475 Isobel Graham changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |isobel.graham09 at gmail.com |ity.org | CC| |isobel.graham09 at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:54:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:54:53 +0000 Subject: [Koha-bugs] [Bug 31475] Group system preferences for suggestions on OPAC tab under new heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31475 Isobel Graham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:55:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:55:29 +0000 Subject: [Koha-bugs] [Bug 31439] Item count bullet (• ) should be easier to style/remove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31439 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140113|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 140484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140484&action=edit Bug 31439: Use pseudo element for bullet in results.tt To test: 1. Apply patch and regenerate CSS. See: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 2. Go to the staff results page and inscept the result_item_details class. 3. It should contain a ::before pseudo element that is the bullet point. 4. This is easier to remove of alter with the following CSS in IntraNetUSerCSS: .result_item_details::before { content: " " !important; } Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:55:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:55:53 +0000 Subject: [Koha-bugs] [Bug 31439] Item count bullet (• ) should be easier to style/remove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31439 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Perfec', Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 18:55:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 16:55:58 +0000 Subject: [Koha-bugs] [Bug 31439] Item count bullet (• ) should be easier to style/remove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31439 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 19:09:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 17:09:40 +0000 Subject: [Koha-bugs] [Bug 31412] Set focus for cursor to Name when adding a new SMTP server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31412 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 19:09:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 17:09:44 +0000 Subject: [Koha-bugs] [Bug 31412] Set focus for cursor to Name when adding a new SMTP server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31412 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140479|0 |1 is obsolete| | --- Comment #4 from Joonas Kylmälä --- Created attachment 140485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140485&action=edit Bug 31412: Add focus to 'name' on SMTP Servers This patch adds the focus class to ensure focus is given to the first form element on the SMTP server entry page. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 19:52:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 17:52:16 +0000 Subject: [Koha-bugs] [Bug 31552] New: SIP2 option format_due_date not honored for AH field in item information response Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31552 Bug ID: 31552 Summary: SIP2 option format_due_date not honored for AH field in item information response Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 28730 added the ability to format due dates based on Koha's date format, but missed formatting the due date field in the item information response. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 19:52:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 17:52:27 +0000 Subject: [Koha-bugs] [Bug 31552] SIP2 option format_due_date not honored for AH field in item information response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31552 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 19:53:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 17:53:25 +0000 Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content warnings' to catalogue records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 --- Comment #11 from David Nind --- (In reply to Martin Renvoize from comment #10) > Interesting, I can't replicate that issue.. perhaps caching related? It was some sort of caching issue - apologies for the false alarm! I retested again, and then did a flush_memcached, restart_all, and cleared the browser cache - the descriptions for the authorised values now display instead of the authorised value codes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 19:53:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 17:53:27 +0000 Subject: [Koha-bugs] [Bug 31552] SIP2 option format_due_date not honored for AH field in item information response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31552 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 19:53:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 17:53:30 +0000 Subject: [Koha-bugs] [Bug 31552] SIP2 option format_due_date not honored for AH field in item information response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31552 --- Comment #1 from Kyle M Hall --- Created attachment 140486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140486&action=edit Bug 31552: SIP2 option format_due_date not honored for AH field in item information response Bug 28730 added the ability to format due dates based on Koha's date format, but missed formatting the due date field in the item information response. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Message.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 19:55:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 17:55:00 +0000 Subject: [Koha-bugs] [Bug 31552] SIP2 option format_due_date not honored for AH field in item information response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31552 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28730 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28730 [Bug 28730] Add option to format AH field (due date) in SIP checkout response -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 19:55:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 17:55:00 +0000 Subject: [Koha-bugs] [Bug 28730] Add option to format AH field (due date) in SIP checkout response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28730 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31552 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31552 [Bug 31552] SIP2 option format_due_date not honored for AH field in item information response -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 19:56:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 17:56:55 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Failed QA |Signed Off Patch complexity|Medium patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 19:57:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 17:57:12 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139636|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 19:57:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 17:57:26 +0000 Subject: [Koha-bugs] [Bug 31552] SIP2 option format_due_date not honored for AH field in item information response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31552 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 19:57:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 17:57:26 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139637|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 19:57:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 17:57:30 +0000 Subject: [Koha-bugs] [Bug 31552] SIP2 option format_due_date not honored for AH field in item information response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31552 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140486|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 140487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140487&action=edit Bug 31552: SIP2 option format_due_date not honored for AH field in item information response Bug 28730 added the ability to format due dates based on Koha's date format, but missed formatting the due date field in the item information response. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Message.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 19:57:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 17:57:33 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139638|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 19:57:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 17:57:37 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139639|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 19:57:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 17:57:41 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139640|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 19:57:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 17:57:44 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139641|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:08:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:08:26 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 --- Comment #32 from Tomás Cohen Arazi --- Created attachment 140488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140488&action=edit Bug 30982: REST API specs Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:08:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:08:32 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 --- Comment #33 from Tomás Cohen Arazi --- Created attachment 140489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140489&action=edit Bug 30982: Use the REST API for background job list view Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:08:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:08:39 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 --- Comment #34 from Tomás Cohen Arazi --- Created attachment 140490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140490&action=edit Bug 30982: (QA follow-up) Double quoting and console.log This patch fixes the issues highlighted by the QA script; We use double quotes for translatable strings in JS and remove an errant console.log call. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:08:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:08:45 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 --- Comment #35 from Tomás Cohen Arazi --- Created attachment 140491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140491&action=edit Bug 30982: Add tests and implement GET /background_jobs/$id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:08:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:08:51 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 --- Comment #36 from Tomás Cohen Arazi --- Created attachment 140492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140492&action=edit Bug 30982: Make code more re-usable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:08:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:08:56 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 --- Comment #37 from Tomás Cohen Arazi --- Created attachment 140493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140493&action=edit Bug 30982: Add 'context' to the REST API specs context has been added by bug 30889 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:09:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:09:01 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 --- Comment #38 from Tomás Cohen Arazi --- Created attachment 140494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140494&action=edit Bug 30982: Add Koha::BackgroundJobs->filter_by_current Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:09:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:09:07 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 --- Comment #39 from Tomás Cohen Arazi --- Created attachment 140495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140495&action=edit Bug 30982: API tweaks This patch makes the following changes to the 'background_jobs' API: * We now call them 'jobs' * Removed deprecated query parameter definitions * Added only_current query parameter * Controller gets adapted to use $rs->filter_by_current when only_current is passed Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:09:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:09:13 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 --- Comment #40 from Tomás Cohen Arazi --- Created attachment 140496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140496&action=edit Bug 30982: (follow-up) Only escape asterisk chars when non-exact search Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:09:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:09:38 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 --- Comment #41 from Tomás Cohen Arazi --- Created attachment 140497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140497&action=edit Bug 30982: Adapt table to new API spec Disclaimer: this patch is highly opinionated :-D When I started looking at this patch I felt like the two tables (current/past jobs) implemented on bug 30462 was the way to go. In order to make this patches apply after it I had to redo all the things. Or most of them. But I decided to keep the idea of filtering out completed tasks, not just having the option to display 'the last hour' tasks. For the task I added some required helper methods and the relevant tests as well. So a behavior change. Hope you all agree with it. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:09:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:09:59 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 --- Comment #42 from Tomás Cohen Arazi --- Created attachment 140498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140498&action=edit [OPTIONAL] Bug 30982: Rename 'Background Jobs' => 'Jobs' Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:11:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:11:43 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |lucas at bywatersolutions.com, | |nick at bywatersolutions.com --- Comment #43 from Tomás Cohen Arazi --- Please review ASAP for pushing it. Thanks everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:11:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:11:52 +0000 Subject: [Koha-bugs] [Bug 31475] Group system preferences for suggestions on OPAC tab under new heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31475 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:11:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:11:57 +0000 Subject: [Koha-bugs] [Bug 31475] Group system preferences for suggestions on OPAC tab under new heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31475 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140483|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 140499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140499&action=edit Bug 31475: Added 'Suggestions' section to preferences Confrim all suggestion preferences are now grouped. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:12:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:12:28 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:13:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:13:00 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 --- Comment #44 from Tomás Cohen Arazi --- (In reply to Joonas Kylmälä from comment #30) > The table filter "Type" doesn't work, if you select something else than the > empty filter you get no results. Solved on 'Bug 30982: (follow-up) Only escape asterisk chars when non-exact search' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:13:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:13:33 +0000 Subject: [Koha-bugs] [Bug 31552] SIP2 option format_due_date not honored for AH field in item information response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31552 --- Comment #3 from Kyle M Hall --- Thanks for the quick SO David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:15:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:15:39 +0000 Subject: [Koha-bugs] [Bug 31475] Group system preferences for suggestions on OPAC tab under new heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31475 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Nice work Isobel! I think it makes sense to group all the OPAC related system preferences together under OPAC > Suggestions (and leaving EmailPurchaseSuggestions, EmailAddressForSuggestions, and PurgeSuggestionsOlderThan under Acquisitions > Policy). David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:22:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:22:50 +0000 Subject: [Koha-bugs] [Bug 31528] Replace scss-lint configuration with one for stylelint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:22:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:22:56 +0000 Subject: [Koha-bugs] [Bug 31528] Replace scss-lint configuration with one for stylelint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140316|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 140500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140500&action=edit Bug 31528: Replace scss-lint configuration with one for stylelint This patch removes the SCSS linting configuration .scss-lint.yml which was intended to be used with a now-obsolete tool, scss-lint. It is replaced with .stylelintrc.json, for use with stylelint. I've tried to keep the linting rules the same as before. To test, run 'yarn install' to install the new dependencies. You can test stylelint from the command line like so: npx stylelint koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss It should output a list of problems with the file: koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss 30:27 ✖ Expected "#e6f0f2" to be "#E6F0F2" color-hex-case 81:31 ✖ Expected single space after "(" function-parentheses-space-inside ...etc. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:23:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:23:00 +0000 Subject: [Koha-bugs] [Bug 31528] Replace scss-lint configuration with one for stylelint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140339|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 140501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140501&action=edit Bug 31528: (follow-up) A few additional rules Adding a few more rules which came up during the correction process in the follow-up bug. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:29:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:29:42 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #78 from Tomás Cohen Arazi --- Created attachment 140502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140502&action=edit Bug 27981: (QA follow-up) GetMarcBiblio was removed from codebase Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:30:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:30:41 +0000 Subject: [Koha-bugs] [Bug 28512] Quick spine label creator: Add CSS class with logged in library's branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139801|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes --- Created attachment 140503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140503&action=edit Bug 28512: Add branchcode as class to spinelabel element To test: -Apply patch and generate a quick spine label. -Inscept the page and notice that the #spinelabel element should contain a new class which corresponds with that the of the logged in branch. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:31:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:31:08 +0000 Subject: [Koha-bugs] [Bug 28512] Quick spine label creator: Add CSS class with logged in library's branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:36:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:36:57 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:37:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:37:00 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #79 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:37:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:37:03 +0000 Subject: [Koha-bugs] [Bug 31250] Don't remove advanced/basic cataloging editor cookie on logout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31250 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:37:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:37:07 +0000 Subject: [Koha-bugs] [Bug 31250] Don't remove advanced/basic cataloging editor cookie on logout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31250 --- Comment #23 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:37:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:37:10 +0000 Subject: [Koha-bugs] [Bug 31439] Item count bullet (• ) should be easier to style/remove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31439 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:37:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:37:13 +0000 Subject: [Koha-bugs] [Bug 31439] Item count bullet (• ) should be easier to style/remove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31439 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:37:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:37:15 +0000 Subject: [Koha-bugs] [Bug 31455] Batch modification tool orders found items by itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31455 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:37:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:37:18 +0000 Subject: [Koha-bugs] [Bug 31455] Batch modification tool orders found items by itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31455 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:37:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:37:21 +0000 Subject: [Koha-bugs] [Bug 31530] HTML tags in TT comments in patron-search.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31530 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:37:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:37:23 +0000 Subject: [Koha-bugs] [Bug 31530] HTML tags in TT comments in patron-search.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31530 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:37:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:37:26 +0000 Subject: [Koha-bugs] [Bug 31537] Elasticsearch - index mapping for 003 control-number-identifier is twice in mappings.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31537 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:37:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:37:29 +0000 Subject: [Koha-bugs] [Bug 31537] Elasticsearch - index mapping for 003 control-number-identifier is twice in mappings.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31537 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:37:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:37:32 +0000 Subject: [Koha-bugs] [Bug 31542] Home page links wrong font-family In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31542 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:37:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:37:35 +0000 Subject: [Koha-bugs] [Bug 31542] Home page links wrong font-family In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31542 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:37:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:37:38 +0000 Subject: [Koha-bugs] [Bug 31545] ComponentSortField description is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31545 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:37:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:37:40 +0000 Subject: [Koha-bugs] [Bug 31545] ComponentSortField description is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31545 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 20:56:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 18:56:51 +0000 Subject: [Koha-bugs] [Bug 30755] auto_too_soon should not be counted as an error in autorenewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30755 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Keywords| |release-notes-needed --- Comment #20 from Tomás Cohen Arazi --- This introduces a behavior change for those relying on the error for displaying purposes. Can you please write a nice release note about it before I push? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 21:24:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 19:24:12 +0000 Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #37 from Tomás Cohen Arazi --- Hi all, tests are failing for me. Please review. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 21:29:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 19:29:44 +0000 Subject: [Koha-bugs] [Bug 31529] Fix errors in SCSS files raised by stylelint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31529 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 21:29:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 19:29:50 +0000 Subject: [Koha-bugs] [Bug 31529] Fix errors in SCSS files raised by stylelint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31529 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140341|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 140504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140504&action=edit Bug 31529: [OPAC] Fix errors in SCSS files raised by stylelint This patch corrects errors raised by the new stylelint configuration in OPAC SCSS files. Many of the fixes were made automatically by using the "--fix" option: npx stylelint koha-tmpl/opac-tmpl/bootstrap/css/src/*.scss --fix Some examples of errors found: - Unexpected empty line before $-variable - Expected single space after ":" - Expected "#fff" to be "#FFF" - Expected modern color-function notation - Expected single space after "(" - Expected single space before ")" - Expected empty line before comment - Expected no more than 1 empty line - Expected a trailing semicolon - Expected color.adjust($color, $lightness: -$amount) instead of darken($color, $amount) - Unexpected leading zero - Expected single space after "," in a single-line function - Expected double colon pseudo-element notation Manual fixes include replacing named colors with hex codes, combining duplicate selectors, removing empty blocks, etc. Some warnings remain: "Unexpected !important" and "Expected a placeholder selector (e.g. %placeholder) to be used in @extend" which both require more than a quick fix, if we should choose to address them. To test, apply the patch and rebuild the OPAC SCSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client Browse around the OPAC to confirm that there are no visible changes to style. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 21:32:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 19:32:43 +0000 Subject: [Koha-bugs] [Bug 31529] Fix errors in SCSS files raised by stylelint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31529 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Did not notice any specific issues in the OPAC when testing (using Firefox on Ubuntu). Tests included: searching (including advanced), placing a hold, making a suggestion, browsing as an anonymous and logged-in user, adding and removing items from a list and the cart. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 21:38:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 19:38:00 +0000 Subject: [Koha-bugs] [Bug 31516] Missing error handling for accessing deleted/non-existent club enrollment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31516 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This adds an error message |This adds an error message release notes|when viewing enrollments |when viewing enrollments |for a non-existent club. |for a non-existent club. |Previously, the title and |Previously, a page with an |table displayed were empty. |empty title and table were | |displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 21:42:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 19:42:08 +0000 Subject: [Koha-bugs] [Bug 29409] Update for bug 25333 can fail due to bad data or constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29409 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 21:42:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 19:42:11 +0000 Subject: [Koha-bugs] [Bug 29409] Update for bug 25333 can fail due to bad data or constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29409 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 21:42:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 19:42:14 +0000 Subject: [Koha-bugs] [Bug 29658] Crash on cancelling cancelled order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 21:42:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 19:42:17 +0000 Subject: [Koha-bugs] [Bug 29658] Crash on cancelling cancelled order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658 --- Comment #16 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 21:42:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 19:42:20 +0000 Subject: [Koha-bugs] [Bug 30921] Replace use of C4::XSLT::transformMARCXML4XSLT with RecordProcessor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 21:42:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 19:42:23 +0000 Subject: [Koha-bugs] [Bug 30921] Replace use of C4::XSLT::transformMARCXML4XSLT with RecordProcessor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 21:42:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 19:42:26 +0000 Subject: [Koha-bugs] [Bug 31486] Deleting a message from checkouts tab redirects to detail tab in patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 21:42:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 19:42:29 +0000 Subject: [Koha-bugs] [Bug 31486] Deleting a message from checkouts tab redirects to detail tab in patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 21:42:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 19:42:31 +0000 Subject: [Koha-bugs] [Bug 31516] Missing error handling for accessing deleted/non-existent club enrollment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31516 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 21:42:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 19:42:34 +0000 Subject: [Koha-bugs] [Bug 31516] Missing error handling for accessing deleted/non-existent club enrollment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31516 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 21:42:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 19:42:37 +0000 Subject: [Koha-bugs] [Bug 31535] Fix a staff warn or two In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31535 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 21:42:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 19:42:40 +0000 Subject: [Koha-bugs] [Bug 31535] Fix a staff warn or two In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31535 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 21:58:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 19:58:40 +0000 Subject: [Koha-bugs] [Bug 28167] A warning when setting which library to use in intranet and UseCashRegisters is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28167 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 21:58:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 19:58:44 +0000 Subject: [Koha-bugs] [Bug 28167] A warning when setting which library to use in intranet and UseCashRegisters is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28167 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139966|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 140505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140505&action=edit Bug 28167: Remove uninitialized variable warnings from circ/set-library.pl With UseCashRegisters syspref disabled going to the page /cgi-bin/koha/circ/set-library.pl in staff interface and setting a library gives the following errors in plack-intranet-error.log: Use of uninitialized value $register_id in string ne at /kohadevbox/koha/circ/set-library.pl line 79. Use of uninitialized value $referer in pattern match (m//) at /kohadevbox/koha/circ/set-library.pl line 114. In the if clause $userenv_register_id appears to be typoed, it should have been $register_id as $userenv_register_id is always defined. As for the $referer variable, it is undef if there is no referer so let's just initialize it to an empty string for the regex so it doesn't give the warning. To test: 1) Go directly to /cgi-bin/koha/circ/set-library.pl by typing it in the URL bar and set a library 2) Make sure plack-intranet-error.log doesn't contain the above mentioned errors after applying this patch Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 22:11:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 20:11:26 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |tomascohen at gmail.com --- Comment #14 from Tomás Cohen Arazi --- Can we move this (at least) to the AdditionalContents schema? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 22:11:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 20:11:27 +0000 Subject: [Koha-bugs] [Bug 31485] Move ItemsDeniedRenewal checks from C4::Circulation to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31485 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 22:11:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 20:11:32 +0000 Subject: [Koha-bugs] [Bug 31485] Move ItemsDeniedRenewal checks from C4::Circulation to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31485 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139965|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 140506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140506&action=edit Bug 31485: Move _item_denied_renewal to Koha::Item The question whether item is denied renewal doesn't depend on circulation rules or the patron, it is only a property of the item and only changes to the item's attributes can cause the return value of the check to change, thus we should move this to be a method of Koha::Item. To test: 1) Run unit tests $ prove t/db_dependent/Circulation.t $ prove t/db_dependent/Koha/Item.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 22:12:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 20:12:17 +0000 Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 22:12:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 20:12:21 +0000 Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 --- Comment #49 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 22:12:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 20:12:25 +0000 Subject: [Koha-bugs] [Bug 28634] ILL partner request notices are attached to the request creator rather than the partner recipient In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28634 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 22:12:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 20:12:27 +0000 Subject: [Koha-bugs] [Bug 28634] ILL partner request notices are attached to the request creator rather than the partner recipient In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28634 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 22:36:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 20:36:33 +0000 Subject: [Koha-bugs] [Bug 30660] Add cancellation reason to holds delete endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30660 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david at davidnind.com --- Comment #2 from David Nind --- The tests fail after applying the patch. There was quite a lot of output, so I'm just posting the last bit: ... Can't use an undefined value as a HASH reference at t/db_dependent/api/v1/holds.t line 252. # Looks like your test exited with 11 just after 3. t/db_dependent/api/v1/holds.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 14/14 subtests Test Summary Report ------------------- t/db_dependent/api/v1/holds.t (Wstat: 2816 Tests: 3 Failed: 3) Failed tests: 1-3 Non-zero exit status: 11 Parse errors: Bad plan. You planned 14 tests but ran 3. Files=1, Tests=3, 4 wallclock secs ( 0.01 usr 0.01 sys + 3.48 cusr 0.22 csys = 3.72 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 22:39:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 20:39:35 +0000 Subject: [Koha-bugs] [Bug 31481] Pass message_id to SMS drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31481 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 22:39:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 20:39:40 +0000 Subject: [Koha-bugs] [Bug 31481] Pass message_id to SMS drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31481 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139938|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 140507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140507&action=edit Bug 31481: pass message_id to SMS drivers This patch adds message_id to _send_message_by_sms and sms_send so the driver could be build to catch SMS gateways delivery report. Test plan: 1) Apply the patch 2) prove t/SMS.t Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 22:39:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 20:39:47 +0000 Subject: [Koha-bugs] [Bug 30732] Librarians with only "place_holds" permission can not suspend and resume holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30732 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |fridolin.somers at biblibre.co | |m --- Comment #3 from Fridolin Somers --- I rise to Major because this can be a daily issue for librarians. Bug 30207 is pushed so we would like this one should go forward. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 22:44:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 20:44:13 +0000 Subject: [Koha-bugs] [Bug 31546] Reassign items to holds if another item becomes available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31546 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #2 from Christopher Brannon --- I've set this to in discussion. I think this would be a good concept to explore. And I agree, this would be ideal only if the item has arrived at the same pickup location. I would not mess with other transits. Yes, potentially it could delay the next item in line, but then they would also have the potential to be bumped to another item that arrives before it. With that in mind, it would be smart to make this an option for holds, rather than just how it works. It would be great to get others to weigh in on the pros and cons of this concept. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 22:47:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 20:47:22 +0000 Subject: [Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 22:47:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 20:47:25 +0000 Subject: [Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058 --- Comment #21 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 22:47:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 20:47:27 +0000 Subject: [Koha-bugs] [Bug 31236] Add ability to send custom item fields via SIP using Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31236 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 22:47:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 20:47:30 +0000 Subject: [Koha-bugs] [Bug 31236] Add ability to send custom item fields via SIP using Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31236 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 12 23:48:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 21:48:00 +0000 Subject: [Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 --- Comment #30 from Lucas Gass --- Perhaps if we could make Bug 26648 move it would solve the problem here as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 01:18:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 23:18:24 +0000 Subject: [Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 --- Comment #8 from David Cook --- (In reply to Martin Renvoize from comment #5) > I have recollections of trying to improve the Context method before and > getting caught by all sorts of weird side effects.. do you happen to > remember the details David? Not really but I think bug 29744 probably took care of it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 01:23:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 23:23:58 +0000 Subject: [Koha-bugs] [Bug 31259] Downloading patron card PDF hangs the server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31259 --- Comment #12 from David Cook --- (In reply to Liz Rea from comment #11) > It appears to not be infinite when the text doesn't have to wrap. Sounds like the issue is in the WRAP_LINES block in C4/Patroncards/Patroncard.pm then (like it was for bug 22429). I don't have time to look at this today, but I could take a look in the next few days/weeks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 01:38:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 23:38:22 +0000 Subject: [Koha-bugs] [Bug 12242] Allow hiding branches from the OPAC search pulldowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12242 --- Comment #8 from David Cook --- (In reply to Magnus Enger from comment #4) > paxed: Will you be using some other functionality to hide the items from > searches? What happens if an item connected to your hidden branch turns up > in a search? Yeah, you'd use OpacSuppression or OpacHideItems for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 01:39:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Sep 2022 23:39:27 +0000 Subject: [Koha-bugs] [Bug 12242] Allow hiding branches from the OPAC search pulldowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12242 --- Comment #9 from David Cook --- (In reply to Katrin Fischer from comment #6) > ON bug 27360 David Cook suggested to use the OPAC public flag for this. I > think this is not a bad idea to extend it's scope. What do others think? I think that David Cook is on to something there... ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 04:11:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 02:11:23 +0000 Subject: [Koha-bugs] [Bug 31553] New: News item contents field does not always expand when you click on a non-default language Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31553 Bug ID: 31553 Summary: News item contents field does not always expand when you click on a non-default language Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Created attachment 140508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140508&action=edit Arrow pointing at the un-expanded content field when using the English New Zealand news item tab Unfortunately, this is tricky to test as it only happens intermittently. How I am able to occasionally replicate this: 1. Have a Koha OPAC with multiple languages enabled in the 'OPACLanguages' syspref 1. Add a new news item, or edit an existing news item ( Tools > News ). 2. Click on a language tab (i.e. a tab that is not the 'Default'tab ) and observe the content field (area below the editor buttons) has not expanded to enable you to input your news item content. Attached screenshot shows the content field has not expanded for me in the 'English New Zealand (en-NZ)' tab. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 04:11:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 02:11:31 +0000 Subject: [Koha-bugs] [Bug 31553] News item contents field does not always expand when you click on a non-default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31553 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 04:11:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 02:11:42 +0000 Subject: [Koha-bugs] [Bug 31553] News item contents field does not always expand when you click on a non-default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31553 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 04:39:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 02:39:01 +0000 Subject: [Koha-bugs] [Bug 31553] News item contents field does not always expand when you click on a non-default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31553 --- Comment #1 from Alex Buckley --- Created attachment 140509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140509&action=edit Bug 31553: Ensure news item content field is always editable Set a padding at the bottom of the news item editor body. This is a tricky bug to replicate. Test plan: 1. Set 'AdditionalContentsEditor' syspref = 'a WYSIWYG editor (TinyMCE)'. 2. Select multiple languages in the 'OPACLanguages' system preference. 3. Go to: Tools > News. 4. Create a new news item. Switch between the different language tabs. 5. Confirm you can always input into the content field in all languages. 6. Edit an exiting news item. Switch between different language tabs. 7. Confirm you can always input into the content field in all languages. Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 04:39:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 02:39:51 +0000 Subject: [Koha-bugs] [Bug 31553] News item contents field does not always expand when you click on a non-default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31553 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 04:48:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 02:48:22 +0000 Subject: [Koha-bugs] [Bug 31446] Make it easier for libraries to hide lightbox_descriptions from OPAC lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|ASSIGNED |RESOLVED --- Comment #6 from Alex Buckley --- Just noting we have decided not to proceed with this fix. As Katrin pointed out in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456#c5 some content providers look to require text attribution in the Koha OPAC in order for their images to be used, so it is best for these attributions to be retained. If libraries do not use those content providers and want to hide where their cover images are coming from they can already do that using custom JavaScript in the OpacUserJS syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 04:48:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 02:48:25 +0000 Subject: [Koha-bugs] [Bug 31456] Optionally hide lightbox_descriptions from intranet lightbox gallery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |INVALID --- Comment #7 from Alex Buckley --- Just noting we have decided not to proceed with this fix. As Katrin pointed out in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456#c5 some content providers look to require text attribution in the Koha OPAC in order for their images to be used, so it is best for these attributions to be retained. If libraries do not use those content providers and want to hide where their cover images are coming from they can already do that using custom JavaScript in the OpacUserJS syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 05:42:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 03:42:38 +0000 Subject: [Koha-bugs] [Bug 31553] News item contents field does not always expand when you click on a non-default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31553 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 06:44:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 04:44:54 +0000 Subject: [Koha-bugs] [Bug 30951] Duplicate entry 'ar' for key 'PRIMARY' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30951 --- Comment #8 from David Cook --- I was looking at this one again... It looks like installer/data/mysql/mandatory/subtag_registry.sql inserts entries into language_script_mapping, and updatedatabase.pl inserts the same entries in version "3.00.00.045". The git history for installer/data/mysql/mandatory/subtag_registry.sql is super weird... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 07:47:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 05:47:50 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 --- Comment #12 from Emmi Takkinen --- It seems this patch reawakens bug 21141. I'll rework this if needed since it might be that some other patch already fixed this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 07:52:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 05:52:12 +0000 Subject: [Koha-bugs] [Bug 28553] Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 07:52:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 05:52:13 +0000 Subject: [Koha-bugs] [Bug 30355] SMS auto renew digest notices are only generated if patron is also set to receive email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30355 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 07:57:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 05:57:07 +0000 Subject: [Koha-bugs] [Bug 30355] SMS auto renew digest notices are only generated if patron is also set to receive email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30355 --- Comment #2 from David Cook --- I think that we can just close this one as a duplicate of bug 28553. Happy with that, Andrew? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 08:31:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 06:31:09 +0000 Subject: [Koha-bugs] [Bug 28553] Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 --- Comment #6 from David Cook --- (In reply to David Nind from comment #5) > Note that for the AUTO_RENEWALS notice, this message appears for the Email > notice, before the last updated date: > > Template Toolkit error: undef error - : filter not found > > This message appears before the patch is applied - I'm not sure what is > causing this, as it doesn't appear for a sample of other notices I checked. My guess would be due to the following line: The following item, [% biblio.title %], has correctly been renewed and is now due on [% checkout.date_due | $KohaDates as_due_date => 1 %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 08:43:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 06:43:50 +0000 Subject: [Koha-bugs] [Bug 28553] Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 --- Comment #7 from David Cook --- Comment on attachment 140412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140412 Bug 28553: Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them Review of attachment 140412: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=28553&attachment=140412) ----------------------------------------------------------------- The patch title and patch note don't accurately describe the patch. They should say something like the following: Bug 28553: Add SMS notices for auto renew notices This patch adds support for SMS notices to the automatic_renewals.pl cronjob. Both digest and non-digest messages are supported. ::: misc/cronjobs/automatic_renewals.pl @@ +234,5 @@ > ); > + for my $issue ( @{ $report{$borrowernumber} } ) { > + my $item = $issue->item; > + # Force sending of email and only email if pref is set to "cron" > + my @transports = $send_notices_pref eq 'preferences' ? keys %{ $borrower_preferences->{'transports'} } : 'sms'; This is wrong. Instead of 'sms', it should be 'email'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 08:44:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 06:44:21 +0000 Subject: [Koha-bugs] [Bug 30355] SMS auto renew digest notices are only generated if patron is also set to receive email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30355 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from David Cook --- *** This bug has been marked as a duplicate of bug 28553 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 08:44:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 06:44:21 +0000 Subject: [Koha-bugs] [Bug 28553] Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 --- Comment #8 from David Cook --- *** Bug 30355 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 08:46:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 06:46:16 +0000 Subject: [Koha-bugs] [Bug 28553] Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 --- Comment #9 from David Cook --- (In reply to David Cook from comment #7) > ::: misc/cronjobs/automatic_renewals.pl > @@ +234,5 @@ > > ); > > + for my $issue ( @{ $report{$borrowernumber} } ) { > > + my $item = $issue->item; > > + # Force sending of email and only email if pref is set to "cron" > > + my @transports = $send_notices_pref eq 'preferences' ? keys %{ $borrower_preferences->{'transports'} } : 'sms'; > > This is wrong. Instead of 'sms', it should be 'email'. I'll shortly attach a follow-up patch to fix this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 08:49:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 06:49:10 +0000 Subject: [Koha-bugs] [Bug 28553] Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 08:49:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 06:49:14 +0000 Subject: [Koha-bugs] [Bug 28553] Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140412|0 |1 is obsolete| | --- Comment #10 from David Cook --- Created attachment 140510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140510&action=edit Bug 28553: Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them Following bug 18532, one can set a patron's messaging prefs to deliver an auto-renew notice via SMS. However, the auto_renewals cron only knows how to generate email notices. We should not allow the selection of non-functional transport types. Test Plan: 1 - Set pref AutoRenewalNotices - 'according to patron messaging preferences' 2 - Set circ rule with: Loan period: 5 days No renewal before: 5 AutoRenewal: Yes Renewals allowed: 5 3 - Set SMS Send driver to Email 4 - Find a patron and set them to receive auto renewal notices via SMS and no other transport 5 - Provide a proivder and sms number for the patron 6 - Checkout an item to the patron, set due date to yesterday 7 - Run auto renewals: perl misc/cronjobs/automatic_renewals.pl -v --send-notices -c 8 - Item renewed, no message sent 9 - Check in item, checkout again due yesterday 10 - Apply patch 11 - Browse to Tools->notices and slips 12 - Edit AUTO_RENEWALS and AUTO_RENEWALS_DIGEST to copy email template to sms and add a title 13 - perl misc/cronjobs/automatic_renewals.pl -v --send-notices -c 14 - Item renewed, confirm patron has a notice in their account 15 - Check the digest option, check in item, checkout again as due, repeat cronjob and note digest notic 16 - sign off https://bugs.koha-community.org/show_bug.cgi?id=30355 Signed-off-by: David Nind Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 08:49:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 06:49:18 +0000 Subject: [Koha-bugs] [Bug 28553] Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 --- Comment #11 from David Cook --- Created attachment 140511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140511&action=edit Bug 28553: [QA followup] default to auto renew email when cron switched used This patch defaults to using "email" rather than "sms" notices when AutoRenewalNotices is set to use the --send-notices cron switch Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 08:59:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 06:59:02 +0000 Subject: [Koha-bugs] [Bug 28553] Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 --- Comment #12 from David Cook --- Despite my comments about the title/note on the first patch, which would probably ordinarily be a QA fail, I think that the patch is important enough to still Pass QA. Going to leave it up to the RM to decide if it needs to be rewritten, or to rewrite it, or to let it go. Thanks for the patch, Bywater folk! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 10:12:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 08:12:18 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #209 from Julian Maurice --- Created attachment 140512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140512&action=edit Bug 30952: Fix table headers Issue #16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 10:12:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 08:12:25 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #210 from Julian Maurice --- Created attachment 140513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140513&action=edit Bug 30952: Fix remaining header search bars -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 10:12:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 08:12:32 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #211 from Julian Maurice --- Created attachment 140514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140514&action=edit Bug 30952: Fix background of "Clear filter" button Issue #16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 10:12:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 08:12:39 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #212 from Julian Maurice --- Created attachment 140515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140515&action=edit Bug 30952: Fix contrast issue on patron brief view Issue #19 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 10:12:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 08:12:46 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #213 from Julian Maurice --- Created attachment 140516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140516&action=edit Bug 30952: Remove white text shadow from buttons Issue #20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 10:15:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 08:15:15 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 --- Comment #13 from Emmi Takkinen --- Well this is confusing. I was able to repeat this bug again by adding a value in syspref "itemcallnumber" e.g. 084a. This triggers if-statement in Koha/Koha/UI/Form/Builder/Item.pm starting from line 151 which eventually leads Koha to crash on line 165. It seems that having a default value in default framework had nothing to with this at all since I too am unable to trigger this bug again with just default values. Here's an updated test plan: To test: 1. Confirm you have/set value to syspref "itemcallnumber" e.g. 084a 2. Find some item(s) to modify 3. Provide barcodes of those item(s) and check checkbox "Use default values" 4. Hit "Continue" => error 500 is raised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 11:16:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 09:16:02 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #214 from Julian Maurice --- Created attachment 140517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140517&action=edit Bug 30952: Fix pagination colors Issue #21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 11:21:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 09:21:40 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138124|0 |1 is obsolete| | --- Comment #14 from Emmi Takkinen --- Created attachment 140518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140518&action=edit Bug 31154: Pass biblionumber to Koha::UI::Form::Builder::Item->new from batchMod.pl to prevent error 500 When one tries to batch mod items and has "Use default values" checkbox checked on and they have value in syspref "itemcallnumber", Koha dies on error 500. In logs it reads: Can't call method "field" on an undefined value at .../Koha/Koha/UI/Form/Builder/Item.pm line 164. This happens because in batchMod.pl line 269 we don't pass biblionumber as parameter to Koha::UI::Form::Builder::Item->new and thus Koha fails to fetch biblios marc record. To test: 1. Confirm you have/set value to syspref "itemcallnumber" e.g. 084a 2. Find some item(s) to modify 3. Provide barcodes of those item(s) and check checkbox "Use default values" 4. Hit "Continue" => error 500 is raised 5. Apply patch. 6. Repeat steps 3. and 4. => no error is raised Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 11:46:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 09:46:06 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #215 from Katrin Fischer --- Hi Julian, a rebase might be required, I am getting an error on the sandbox trying to apply the patches. And the git log stays at current master: https://sandboxes.biblibre.eu/git_log/gui -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:03:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:03:19 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:07:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:07:38 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140117|0 |1 is obsolete| | --- Comment #216 from Julian Maurice --- Created attachment 140519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140519&action=edit Bug 30952: Staff interface redesign (header) What this patch does: - change the navigation bar style - change the breadcrumbs style - change the "last borrower" link style - move the search bar inside the navigation bar - move the help link to the same row as the breadcrumbs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:07:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:07:47 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140118|0 |1 is obsolete| | --- Comment #217 from Julian Maurice --- Created attachment 140520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140520&action=edit Bug 30952: Add Poppins font assets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:07:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:07:56 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140119|0 |1 is obsolete| | --- Comment #218 from Julian Maurice --- Created attachment 140521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140521&action=edit Bug 30952: Move "Go to advanced/item search" link to toolbar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:08:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:08:04 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140120|0 |1 is obsolete| | --- Comment #219 from Julian Maurice --- Created attachment 140522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140522&action=edit Bug 30952: Staff interface redesign (toolbar) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:08:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:08:12 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140121|0 |1 is obsolete| | --- Comment #220 from Julian Maurice --- Created attachment 140523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140523&action=edit Bug 30952: Change checkout, checkin and renew forms -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:08:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:08:19 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140122|0 |1 is obsolete| | --- Comment #221 from Julian Maurice --- Created attachment 140524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140524&action=edit Bug 30952: Staff interface redesign (main page) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:08:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:08:26 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140123|0 |1 is obsolete| | --- Comment #222 from Julian Maurice --- Created attachment 140525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140525&action=edit Bug 30952: Small adjustments in search results page - Move Z39.50 search button to a toolbar - Use btn and btn-link classes for "Select all" and "Clear all" buttons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:08:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:08:33 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140124|0 |1 is obsolete| | --- Comment #223 from Julian Maurice --- Created attachment 140526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140526&action=edit Bug 30952: Change MARC tags toolbar style -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:08:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:08:40 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140125|0 |1 is obsolete| | --- Comment #224 from Julian Maurice --- Created attachment 140527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140527&action=edit Bug 30952: Change login page style -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:08:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:08:46 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140126|0 |1 is obsolete| | --- Comment #225 from Julian Maurice --- Created attachment 140528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140528&action=edit Bug 30952: Change sysprefs nav menu style -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:08:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:08:53 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140127|0 |1 is obsolete| | --- Comment #226 from Julian Maurice --- Created attachment 140529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140529&action=edit Bug 30952: Change default button style -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:09:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:09:01 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140128|0 |1 is obsolete| | --- Comment #227 from Julian Maurice --- Created attachment 140530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140530&action=edit Bug 30952: Change tables style -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:09:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:09:09 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140129|0 |1 is obsolete| | --- Comment #228 from Julian Maurice --- Created attachment 140531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140531&action=edit Bug 30952: The rest of CSS changes There is still work to do to split this patch correctly into several more logical patches. Consider this patch a WIP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:09:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:09:18 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140130|0 |1 is obsolete| | --- Comment #229 from Julian Maurice --- Created attachment 140532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140532&action=edit Bug 30952: (follow-up) Undo change to Home breadcrumb -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:09:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:09:25 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140131|0 |1 is obsolete| | --- Comment #230 from Julian Maurice --- Created attachment 140533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140533&action=edit Bug 30952: Undo change to Home breadcrumb for remaining templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:09:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:09:32 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140132|0 |1 is obsolete| | --- Comment #231 from Julian Maurice --- Created attachment 140534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140534&action=edit Bug 30952: Replace "Home" by icon in breadcrumbs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:09:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:09:39 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140133|0 |1 is obsolete| | --- Comment #232 from Julian Maurice --- Created attachment 140535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140535&action=edit Bug 30952: Fix "rows" forms Issue #7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:09:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:09:47 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140134|0 |1 is obsolete| | --- Comment #233 from Julian Maurice --- Created attachment 140536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140536&action=edit Bug 30952: Fix position shift when hovering .linktools links Issue #6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:09:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:09:54 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140135|0 |1 is obsolete| | --- Comment #234 from Julian Maurice --- Created attachment 140537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140537&action=edit Bug 30952: Fix the 'keep_text' feature of the search bar Text in one form should be copied in other forms when switching tab Issue #2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:10:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:10:01 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140136|0 |1 is obsolete| | --- Comment #235 from Julian Maurice --- Created attachment 140538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140538&action=edit Bug 30952: Show the search catalog form by default in cat-search.inc Issue #1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:10:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:10:11 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140137|0 |1 is obsolete| | --- Comment #236 from Julian Maurice --- Created attachment 140539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140539&action=edit Bug 30952: Move the toolbar back to the left Issue #8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:10:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:10:21 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140138|0 |1 is obsolete| | --- Comment #237 from Julian Maurice --- Created attachment 140540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140540&action=edit Bug 30952: Fix alignment of search results Issue #11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:10:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:10:29 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140139|0 |1 is obsolete| | --- Comment #238 from Julian Maurice --- Created attachment 140541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140541&action=edit Bug 30952: Fix "browse patrons by last name" display Issue #13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:10:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:10:37 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140140|0 |1 is obsolete| | --- Comment #239 from Julian Maurice --- Created attachment 140542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140542&action=edit Bug 30952: Fix left padding of sidebar Issue #14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:10:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:10:44 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140141|0 |1 is obsolete| | --- Comment #240 from Julian Maurice --- Created attachment 140543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140543&action=edit Bug 30952: Fix lists display on patron detail page Issue #15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:10:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:10:51 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140142|0 |1 is obsolete| | --- Comment #241 from Julian Maurice --- Created attachment 140544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140544&action=edit Bug 30952: Fix background color of dialogs (message, alert, error) Issue #9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:10:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:10:59 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140143|0 |1 is obsolete| | --- Comment #242 from Julian Maurice --- Created attachment 140545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140545&action=edit Bug 30952: Increase contrast between green text and white/grey background Issue #10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:11:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:11:08 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140371|0 |1 is obsolete| | --- Comment #243 from Julian Maurice --- Created attachment 140546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140546&action=edit Bug 30952: Change color of btn-primary and use that for Check out button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:11:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:11:15 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140372|0 |1 is obsolete| | --- Comment #244 from Julian Maurice --- Created attachment 140547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140547&action=edit Bug 30952: Add "card" layout to the checkout page Also fix the label positioning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:11:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:11:23 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140373|0 |1 is obsolete| | --- Comment #245 from Julian Maurice --- Created attachment 140548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140548&action=edit Bug 30952: Move search bar below navbar and reduce navbar height -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:11:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:11:31 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140374|0 |1 is obsolete| | --- Comment #246 from Julian Maurice --- Created attachment 140549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140549&action=edit Bug 30952: Add card layout to patron messages in moremember.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:11:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:11:39 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140433|0 |1 is obsolete| | --- Comment #247 from Julian Maurice --- Created attachment 140550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140550&action=edit Bug 30952: Fix background of search header Issue #3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:11:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:11:46 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140435|0 |1 is obsolete| | --- Comment #248 from Julian Maurice --- Created attachment 140551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140551&action=edit Bug 30952: Fix item edit form Issue #31 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:11:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:11:54 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140459|0 |1 is obsolete| | --- Comment #249 from Julian Maurice --- Created attachment 140552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140552&action=edit Bug 30952: Move 'Clear filter' next to filter in table headers Issue #16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:12:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:12:02 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140460|0 |1 is obsolete| | --- Comment #250 from Julian Maurice --- Created attachment 140553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140553&action=edit Bug 30952: Change circulation home page links to buttons Apply the same style to staff home page links Issue #18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:12:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:12:10 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140512|0 |1 is obsolete| | --- Comment #251 from Julian Maurice --- Created attachment 140554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140554&action=edit Bug 30952: Fix table headers Issue #16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:12:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:12:17 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140513|0 |1 is obsolete| | --- Comment #252 from Julian Maurice --- Created attachment 140555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140555&action=edit Bug 30952: Fix remaining header search bars -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:12:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:12:25 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140514|0 |1 is obsolete| | --- Comment #253 from Julian Maurice --- Created attachment 140556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140556&action=edit Bug 30952: Fix background of "Clear filter" button Issue #16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:12:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:12:33 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140515|0 |1 is obsolete| | --- Comment #254 from Julian Maurice --- Created attachment 140557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140557&action=edit Bug 30952: Fix contrast issue on patron brief view Issue #19 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:12:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:12:41 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140516|0 |1 is obsolete| | --- Comment #255 from Julian Maurice --- Created attachment 140558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140558&action=edit Bug 30952: Remove white text shadow from buttons Issue #20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:12:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:12:50 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140517|0 |1 is obsolete| | --- Comment #256 from Julian Maurice --- Created attachment 140559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140559&action=edit Bug 30952: Fix pagination colors Issue #21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:12:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:12:59 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #257 from Julian Maurice --- Created attachment 140560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140560&action=edit Bug 30952: Reintroduce table borders Issue #22 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:13:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:13:11 +0000 Subject: [Koha-bugs] [Bug 31526] Diff view on manage staged imports page is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31526 --- Comment #2 from Martin Renvoize --- Created attachment 140561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140561&action=edit Bug 31526: Follow-up for bug 29697 There was a typo in bug 29697 which lead to a code reference error. Test plan 1) Export a record with ISBN from your catalog (Save as MARC) 2) Stage it using the ISBN matching rule (make sure it matched) 3) Manage staged import and click on the Diff link Prior to this patch an error would be thrown, after the patch you should now get the diff view as expected again. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:13:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:13:31 +0000 Subject: [Koha-bugs] [Bug 31526] Diff view on manage staged imports page is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:13:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:13:38 +0000 Subject: [Koha-bugs] [Bug 31526] Diff view on manage staged imports page is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:13:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:13:42 +0000 Subject: [Koha-bugs] [Bug 31526] Diff view on manage staged imports page is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:32:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:32:29 +0000 Subject: [Koha-bugs] [Bug 30732] Librarians with only "place_holds" permission can not suspend and resume holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30732 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:32:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:32:33 +0000 Subject: [Koha-bugs] [Bug 30732] Librarians with only "place_holds" permission can not suspend and resume holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30732 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134895|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 140562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140562&action=edit Bug 30732: Librarians with only "place_holds" permission can not suspend and resume holds If a librarian only has the place_holds permission, they can see the buttons for placing and suspending holds on moremember.pl and circulation.pl, but cannot use them. Test Plan: 1) Give your librian only the place_holds permission 2) Attempt to "suspend all" and "resume all" holds on moremember.pl and circulation.pl 3) Note you cannot 4) Apply this patch 5) Restart all the things! 6) Test again, note you can now suspend and resume holds! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:35:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:35:22 +0000 Subject: [Koha-bugs] [Bug 30732] Librarians with only "place_holds" permission can not suspend and resume holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30732 --- Comment #5 from Kyle M Hall --- I've amended by test plan! I should have wrote to use the "all" versions of the suspend and resume buttons! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:39:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:39:53 +0000 Subject: [Koha-bugs] [Bug 31389] Calculate user permissions in separate function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31389 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140202|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 140563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140563&action=edit Bug 31389: Calculate user permissions in separate function This patch refactors the setting of user permissions for templates into a new function, which can be easily unit tested and reduces the amount of code in C4::Auth::get_template_and_user(). It also aids in the re-usability of permission checking code. Test plan: 0) Apply patch and koha-plack --restart kohadev 1) prove t/Koha/Auth/Permissions.t 2) As koha superlibrarian, go to http://localhost:8081/cgi-bin/koha/tools/tools-home.pl 3) Go to http://localhost:8081/cgi-bin/koha/members/members-home.pl 4) Create new test user with "Staff access..." and "Remaining circulation permissions" 5) Logout of koha superlibrarian 6) Login as test user 7) Note you can only see a limited view of the staff interface (i.e. no administration, no tools, no reports, etc.) Signed-off-by: Kyle M Hall Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:40:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:40:02 +0000 Subject: [Koha-bugs] [Bug 31389] Calculate user permissions in separate function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31389 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140203|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 140564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140564&action=edit Bug 31389: (QA follow-up) Correct test message The test in question concerns non-superlibrarian staff users. Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 12:40:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 10:40:41 +0000 Subject: [Koha-bugs] [Bug 31389] Calculate user permissions in separate function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31389 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #9 from Martin Renvoize --- Second QA run done.. this is a nice little cleanup. Passed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 13:06:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 11:06:33 +0000 Subject: [Koha-bugs] [Bug 31554] New: Sorting of acquisition info appears to be broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31554 Bug ID: 31554 Summary: Sorting of acquisition info appears to be broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 20726 According to the notes on bug 20726 the acquisition details for subscriptions should sort by status (open/pending) first and then by ordernumber. The first appears to work, but the second doesn't. Looking at the subscription details of a record with all status being 'complete' the secondary sorting doesn't appear to work. In the column order number, we see: 1683 948 2095 So it doesn't appear to sort alphabetically either. In the column basket we have 2... (603) B... (328) 2... (774) So neither works. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20726 [Bug 20726] Display acquisition details on the subscription detail page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 13:06:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 11:06:33 +0000 Subject: [Koha-bugs] [Bug 20726] Display acquisition details on the subscription detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20726 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31554 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31554 [Bug 31554] Sorting of acquisition info appears to be broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 13:12:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 11:12:36 +0000 Subject: [Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 --- Comment #9 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #7) > My gut says we should finally test and push bug 29744 before this.. > harmonizing the plack detection and then use it here too Sure, I will have a look at the other one. Although it is pretty straightforward to harmonize if we would go the other way around. Still something to discuss here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 13:13:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 11:13:53 +0000 Subject: [Koha-bugs] [Bug 29658] Crash on cancelling cancelled order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658 --- Comment #17 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #15) > Simple fix, no regressions. Passing QA Thanks. Even simple fixes can be long on the way ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 13:16:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 11:16:03 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 Daphne Hoolahan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dch at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 13:16:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 11:16:32 +0000 Subject: [Koha-bugs] [Bug 31526] Diff view on manage staged imports page is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31526 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 13:16:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 11:16:35 +0000 Subject: [Koha-bugs] [Bug 31526] Diff view on manage staged imports page is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31526 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140561|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 140565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140565&action=edit Bug 31526: Follow-up for bug 29697 There was a typo in bug 29697 which lead to a code reference error. Test plan 1) Export a record with ISBN from your catalog (Save as MARC) 2) Stage it using the ISBN matching rule (make sure it matched) 3) Manage staged import and click on the Diff link Prior to this patch an error would be thrown, after the patch you should now get the diff view as expected again. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 13:18:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 11:18:43 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #258 from Julian Maurice --- Created attachment 140566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140566&action=edit Bug 30952: Reintroduce placeholder and classes in catalogue search They were lost in the last rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 13:27:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 11:27:52 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #259 from Julian Maurice --- Created attachment 140567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140567&action=edit Bug 30952: Reintroduce borders in search browse links Issue #23 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 13:35:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 11:35:59 +0000 Subject: [Koha-bugs] [Bug 30802] numReturnedItemsToShow doesn't show more than 20 items on the return screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30802 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 14:07:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 12:07:41 +0000 Subject: [Koha-bugs] [Bug 31555] New: Getting holds via REST API needs edit_borrowers permission Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31555 Bug ID: 31555 Summary: Getting holds via REST API needs edit_borrowers permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: johanna.raisa at koha-suomi.fi CC: tomascohen at gmail.com Permissions on holds GET endpoint and request.pl are different. Staff member can see holds with place_holds permission and but via REST API it is blocked. Also a staff member can see and modify holds on patron's page without edit_borrowers permission. The GET endpoint should use place_holds permission to be more consistent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 14:13:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 12:13:59 +0000 Subject: [Koha-bugs] [Bug 31499] Add libhttp-tiny-perl 0.076 dependency for ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31499 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #6 from Marcel de Rooy --- I reinstalled my dev setup (D10 container). And still found the version of HTTP/Tiny.pm under the required level. 0.70 < 0.76 Could this be an issue? I used http://debian.koha-community.org/koha-staging dev main buster -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 14:16:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 12:16:34 +0000 Subject: [Koha-bugs] [Bug 31499] Add libhttp-tiny-perl 0.076 dependency for ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31499 --- Comment #7 from Marcel de Rooy --- HTTP::Tiny 0.070 * 0.076 Yes Search::Elasticsearch 6.00 * 6.80 Yes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 14:22:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 12:22:22 +0000 Subject: [Koha-bugs] [Bug 31497] Quick add: mandatory fields save as empty when not filled in before first save attempt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 14:22:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 12:22:26 +0000 Subject: [Koha-bugs] [Bug 31497] Quick add: mandatory fields save as empty when not filled in before first save attempt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 --- Comment #2 from Nick Clemens --- Created attachment 140568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140568&action=edit Bug 31497: Prevent ID clash on quick add fields The quick add clones the original fields, including ids. This can cause some clash when other JS is running on the page. This patch updates the ids of the fields before adding to the form, which prevents bad copying/clearing of fields To test: * Go to patrons module * Click on Quick add new patron (I chose Patron as category) * On sample database these fields are marked as mandatory: * Surname * Cardnumber * Library * Category * Fill in Surname, leave cardnumber empty * Save - mandatory message is shown * Fill in cardnumber - save * The patron is saved * BUT: cardnumber is empty! APPLY PATCH * Repeat plan above * Cardnumber is correctly saved -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 14:39:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 12:39:21 +0000 Subject: [Koha-bugs] [Bug 31499] Add libhttp-tiny-perl 0.076 dependency for ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31499 --- Comment #8 from Marcel de Rooy --- Okay, this triggered me sufficiently to move it to D11. Also with staging. And now I have: perl koha_perl_deps.pl -u Installed Required Module is Module Name Version Version Required -------------------------------------------------------------------------------------------- -------------------------------------------------------------------------------------------- Total modules reported: 0 * Module is missing or requires an upgrade. So, thats fine with me. But could you please confirm that other people on D10 wont suffer from this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 14:40:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 12:40:07 +0000 Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content warnings' to catalogue records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 --- Comment #12 from Martin Renvoize --- Awesome, thanks for retesting David :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 14:40:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 12:40:26 +0000 Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content warnings' to catalogue records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |holiver at tavi-port.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 14:40:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 12:40:46 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |holiver at tavi-port.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 14:45:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 12:45:56 +0000 Subject: [Koha-bugs] [Bug 28167] A warning when setting which library to use in intranet and UseCashRegisters is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28167 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140505|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 140569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140569&action=edit Bug 28167: Remove uninitialized variable warnings from circ/set-library.pl With UseCashRegisters syspref disabled going to the page /cgi-bin/koha/circ/set-library.pl in staff interface and setting a library gives the following errors in plack-intranet-error.log: Use of uninitialized value $register_id in string ne at /kohadevbox/koha/circ/set-library.pl line 79. Use of uninitialized value $referer in pattern match (m//) at /kohadevbox/koha/circ/set-library.pl line 114. In the if clause $userenv_register_id appears to be typoed, it should have been $register_id as $userenv_register_id is always defined. As for the $referer variable, it is undef if there is no referer so let's just initialize it to an empty string for the regex so it doesn't give the warning. To test: 1) Go directly to /cgi-bin/koha/circ/set-library.pl by typing it in the URL bar and set a library 2) Make sure plack-intranet-error.log doesn't contain the above mentioned errors after applying this patch Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 14:47:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 12:47:41 +0000 Subject: [Koha-bugs] [Bug 28167] A warning when setting which library to use in intranet and UseCashRegisters is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28167 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Nice catch Joonas, cleans up the warning nicely and no regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 14:48:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 12:48:22 +0000 Subject: [Koha-bugs] [Bug 28167] A warning when setting which library to use in intranet and UseCashRegisters is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28167 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 14:49:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 12:49:08 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #15 from Martin Renvoize --- Yeah, I rebased it, but I also think perhaps it should be done using more modern options. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 14:50:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 12:50:27 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #260 from Julian Maurice --- Created attachment 140570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140570&action=edit Bug 30952: Remove messages box on patron detail page when empty Issue #28 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 15:08:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 13:08:10 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #261 from Julian Maurice --- Created attachment 140571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140571&action=edit Bug 30952: Bring back bullet points for lists Issue #29 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 15:08:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 13:08:29 +0000 Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 15:08:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 13:08:34 +0000 Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #38 from Nick Clemens --- Created attachment 140572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140572&action=edit Bug 25375: Adjust tests and test itemlost, not notforloan Previous commit correctly lists Zebra availability test, but was a bad edit. This fixes the availability test to use itemlost Additiionally, tests were written before limits were agreed. Adjusted for the current settings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 15:16:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 13:16:38 +0000 Subject: [Koha-bugs] [Bug 30755] auto_too_soon should not be counted as an error in autorenewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30755 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch alters the way release notes| |errors/successes are | |counted in auto renewals. | |Prior to this patch, using | |[% error %] in a template | |would provide a count of | |all items not renewed, even | |if 'too_soon' | | | |After this | |patch [% error + | |results.auto_too_soon %] | |will provide the same | |count, or you can get a | |count of each error in the | |results variable | | | |e.g. | |Some | |items were not renewed: | |[% | |FOREACH key in results.keys | |%] | | [% results.$key %] | |item(s) were not renewed | |for reason [% key %] | |[% END | |%] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 15:27:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 13:27:38 +0000 Subject: [Koha-bugs] [Bug 30802] numReturnedItemsToShow doesn't show more than 20 items on the return screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30802 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 15:27:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 13:27:42 +0000 Subject: [Koha-bugs] [Bug 30802] numReturnedItemsToShow doesn't show more than 20 items on the return screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30802 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140393|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy --- Created attachment 140573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140573&action=edit Bug 30802: Make numReturnedItemsToShow function properly Replaced the hardcoded 20 by the value of numReturnedItemsToShow to display the right number of items in check in. Test plan: 1- Make lots of checkouts, at least like 40 (I used the batchCheckouts feature) 2- Go to Circulation > Check in 3- Return 21 items The last 20 items returned will be displayed 4- Change numReturnedItemsToShow to 50 5- Return a couple more items Only the last 20 returned items are displayed 6- Change numReturnedItemsToShow to 10 7- Return a couple more items Only the last 10 returned items are displayed 8- Apply the patch 9- Change numReturnedItemsToShow back to 20 10- Do steps 1 to 7 again, but this time step 5 returns the right amount of items Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 15:27:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 13:27:47 +0000 Subject: [Koha-bugs] [Bug 30802] numReturnedItemsToShow doesn't show more than 20 items on the return screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30802 --- Comment #12 from Marcel de Rooy --- Created attachment 140574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140574&action=edit Bug 30802: (QA follow-up) Simplify a ternary Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 15:29:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 13:29:11 +0000 Subject: [Koha-bugs] [Bug 30802] numReturnedItemsToShow doesn't show more than 20 items on the return screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30802 --- Comment #13 from Marcel de Rooy --- Jay. My first qa from Debian 11 master container ;) With a working git-bz still needing python2.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 15:33:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 13:33:06 +0000 Subject: [Koha-bugs] [Bug 30355] SMS auto renew digest notices are only generated if patron is also set to receive email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30355 --- Comment #4 from Andrew Fuerste-Henry --- (In reply to David Cook from comment #2) > I think that we can just close this one as a duplicate of bug 28553. > > Happy with that, Andrew? Good catch, thanks David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 15:36:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 13:36:02 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #262 from Julian Maurice --- Created attachment 140575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140575&action=edit Bug 30952: Change sidebar menu headers - Remove the bottom border - Increase font size and weight - Fix a padding issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 15:36:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 13:36:43 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140575|0 |1 is obsolete| | --- Comment #263 from Julian Maurice --- Created attachment 140576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140576&action=edit Bug 30952: Change sidebar menu headers - Remove the bottom border - Increase font size and weight - Fix a padding issue Issue #30 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 15:39:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 13:39:17 +0000 Subject: [Koha-bugs] [Bug 31322] Searching not working on the receive orders page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31322 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 15:39:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 13:39:33 +0000 Subject: [Koha-bugs] [Bug 31554] Sorting of acquisition info appears to be broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31554 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 15:51:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 13:51:17 +0000 Subject: [Koha-bugs] [Bug 31322] Searching not working on the receive orders page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31322 --- Comment #4 from Katrin Fischer --- Hi Holly, did you find the problem/is this resolved? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 15:54:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 13:54:35 +0000 Subject: [Koha-bugs] [Bug 24865] Customize the accountlines description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds a new release notes| |notice/slip: | |OVERDUE_FINE_DESC | | | |This can | |be used to customize the | |accountlines description | |for overdue fines that can | |access objects for the | |checkout, the item, and the | |borrower -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:06:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:06:05 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #264 from Julian Maurice --- Created attachment 140577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140577&action=edit Bug 30952: Fix fieldset legend positioning Issue #27 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:19:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:19:40 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139900|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize --- Created attachment 140578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140578&action=edit Bug 31162: Add a cataloging module home page This patch adds a new cataloging-home template and controller and replaces most cases of links to addbooks. This servers to provide a new cataloging home page for the cataloging module and keeps it distinct from the current addbooks page it partially replaces as a stating point for cataloging. Signed-off-by: KIT Signed-off-by: Emmanuel Bétemps Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:19:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:19:46 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139901|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize --- Created attachment 140579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140579&action=edit Bug 31162: Remove toolbar This patch removes the existing toolbar with 'New record' and 'New from Z39.50/SRU' and replaces the functionality with simple buttons on the page. We lose the ability to select the Framework or Z39.50/SRU server at this stage but one can still select these options from the resulting dialogues. Signed-off-by: Emmanuel Bétemps Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:19:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:19:51 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139902|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize --- Created attachment 140580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140580&action=edit Bug 31162: (follow-up) 3 Column layout This patch converts to a 3 column layout as suggested by David. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:19:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:19:57 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139903|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize --- Created attachment 140581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140581&action=edit Bug 31162: Remove duplicates from tools-home This patch removes cataloging tools from the tools-home page where they are now listed on the cataloging home page. This leaves just two options in the 'Cataloging' section of the tools home page, 'Rotating collections' and 'Upload local cover images'. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:20:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:20:02 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139904|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize --- Created attachment 140582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140582&action=edit Bug 31162: More conditionals for sections This adds missing conditionals to the section headings in the new cataloging homepage. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:20:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:20:09 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139905|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize --- Created attachment 140583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140583&action=edit Bug 31162: Move Rotating Collections and Upload Covers This patch moves the 'Rotating Collections' link from 'Cataloging' to 'Circulation' on the 'Tools' home page and moves the 'Upload local cover image' link to the 'Cataloging' home page. This removes the 'Cataloging' tools section entirely and as such the template is adapted to a two column layout to compensate. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:20:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:20:15 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139906|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize --- Created attachment 140584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140584&action=edit Bug 31162: Fix help link on catalouging start page Now the link goes to the cataloguing chapter start page of the manual instead of the less specific manual start page. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:20:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:20:20 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139907|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize --- Created attachment 140585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140585&action=edit Bug 31162: (QA follow-up) Change Automations to Automation This was suggested by David Nind in testing and I agree that it sounds a litle nicer. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:20:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:20:27 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #56 from Martin Renvoize --- Created attachment 140586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140586&action=edit Bug 31162: Restore ability to pick framework This patch restores the ability to pick the framework via a dropdown on the cataloguing home page. The CSS needs some work.. this is a proof of concept -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:25:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:25:23 +0000 Subject: [Koha-bugs] [Bug 30755] auto_too_soon should not be counted as an error in autorenewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30755 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:28:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:28:39 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #57 from Martin Renvoize --- Seems I missed both the last two comments until now, my apologies. Thanks for testing! * The sidebars are handled in another bug I'm working through :) * I agree we should probably move the controller files and thus fix the url's, but again I think that should be done as it's own step in another bug. * Breadcrumbs, that's also one I think should be fixed, but perhaps as part of the sidebar bug. * I've had a go at restoring the framework selection stuff, but need a little SCSS help to polish it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:39:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:39:52 +0000 Subject: [Koha-bugs] [Bug 31475] Group system preferences for suggestions on OPAC tab under new heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31475 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140499|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes --- Created attachment 140587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140587&action=edit Bug 31475: Added 'Suggestions' section to preferences Confrim all suggestion preferences are now grouped. Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:39:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:39:54 +0000 Subject: [Koha-bugs] [Bug 31556] New: Correct breadcrumb and URLs for Cataloging module Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 Bug ID: 31556 Summary: Correct breadcrumb and URLs for Cataloging module Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com With bugs 31162 and 31417 we try to make a clear home for all related cataloguing features. Bug 31162 has been used to showcase all the tools and functions I believe belong together and we've worked together to narrow that set down and order them. Bug 31417 then uses the set proposed by 31162 to reinstate the cat-menu sidebar wherever appropriate. Finally, this bug should serve as the final piece of the puzzle, and update the breadcrumbs on each tool to reflect their new home and preferably move the controllers and templates appropriately such that the URL's match up clearly. We may also want to add some redirects to allow for an upgrade path and not break people's bookmarks. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:39:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:39:58 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #265 from Julian Maurice --- Created attachment 140588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140588&action=edit Bug 30952: Set preferences save buttons as primary buttons Issue #32 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:40:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:40:08 +0000 Subject: [Koha-bugs] [Bug 31556] Correct breadcrumb and URLs for Cataloging module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31162, 31417 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 [Bug 31162] Add a clear cataloguing module home page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 [Bug 31417] Re-instate the cataloguing sidebar menu -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:40:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:40:08 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31556 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 [Bug 31556] Correct breadcrumb and URLs for Cataloging module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:40:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:40:08 +0000 Subject: [Koha-bugs] [Bug 31417] Re-instate the cataloguing sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31556 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 [Bug 31556] Correct breadcrumb and URLs for Cataloging module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:40:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:40:17 +0000 Subject: [Koha-bugs] [Bug 31556] Correct breadcrumb and URLs for Cataloging module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:42:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:42:17 +0000 Subject: [Koha-bugs] [Bug 21860] Marc modification templates cannot check or change indicators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Laura Horgan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |horganl at middlesex.mass.edu Priority|P5 - low |P3 --- Comment #11 from Laura Horgan --- There are several type of subject headings that we would like to automatically exclude when importing a record from OCLC for instance. We have no need for the 650 5 Canadian 650 6 Répertoire de vedettes-matière, etc. In the 650 7 if we could limit only certain +2 that would be good as well sears and bisacsh headings. Just one man's opinion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:42:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:42:23 +0000 Subject: [Koha-bugs] [Bug 31497] Quick add: mandatory fields save as empty when not filled in before first save attempt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:56:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:56:53 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140488|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize --- Created attachment 140589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140589&action=edit Bug 30982: REST API specs Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:56:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:56:58 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140489|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize --- Created attachment 140590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140590&action=edit Bug 30982: Use the REST API for background job list view Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:57:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:57:04 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140490|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize --- Created attachment 140591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140591&action=edit Bug 30982: (QA follow-up) Double quoting and console.log This patch fixes the issues highlighted by the QA script; We use double quotes for translatable strings in JS and remove an errant console.log call. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:57:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:57:09 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140491|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize --- Created attachment 140592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140592&action=edit Bug 30982: Add tests and implement GET /background_jobs/$id Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:57:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:57:14 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140492|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize --- Created attachment 140593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140593&action=edit Bug 30982: Make code more re-usable Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:57:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:57:19 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140493|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize --- Created attachment 140594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140594&action=edit Bug 30982: Add 'context' to the REST API specs context has been added by bug 30889 Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:57:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:57:24 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140494|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize --- Created attachment 140595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140595&action=edit Bug 30982: Add Koha::BackgroundJobs->filter_by_current Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:57:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:57:29 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140495|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize --- Created attachment 140596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140596&action=edit Bug 30982: API tweaks This patch makes the following changes to the 'background_jobs' API: * We now call them 'jobs' * Removed deprecated query parameter definitions * Added only_current query parameter * Controller gets adapted to use $rs->filter_by_current when only_current is passed Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:57:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:57:34 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140496|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize --- Created attachment 140597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140597&action=edit Bug 30982: (follow-up) Only escape asterisk chars when non-exact search Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:57:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:57:39 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140497|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize --- Created attachment 140598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140598&action=edit Bug 30982: Adapt table to new API spec Disclaimer: this patch is highly opinionated :-D When I started looking at this patch I felt like the two tables (current/past jobs) implemented on bug 30462 was the way to go. In order to make this patches apply after it I had to redo all the things. Or most of them. But I decided to keep the idea of filtering out completed tasks, not just having the option to display 'the last hour' tasks. For the task I added some required helper methods and the relevant tests as well. So a behavior change. Hope you all agree with it. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 16:57:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 14:57:44 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 --- Comment #55 from Martin Renvoize --- Created attachment 140599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140599&action=edit Bug 30982: Rename 'Background Jobs' => 'Jobs' Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 17:01:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 15:01:49 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140498|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 17:05:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 15:05:10 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 --- Comment #56 from Martin Renvoize --- I really like the follow-ups here and think the end result is nicely polished in general. We could perhaps continue to refine UI was at a later stage after the staff client UI refresh.. things like the checkboxes for the set filter on the datatable feel slightly inconsistent/out of place and we do it inconsistently elsewhere too. I wonder if 'Pills' might be a nice generic approach.. I digress. As for the API, I think generally it's an improvement. I again wonder slightly about the quick filtering options tied to additional parameters, but so long as they're well documented on the spec I think they mostly make sense. It's an area I've contemplated a few times now and not come up with a nice solution for. Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 18:48:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 16:48:16 +0000 Subject: [Koha-bugs] [Bug 31531] Some modules loaded twice in opac-memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31531 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 18:48:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 16:48:20 +0000 Subject: [Koha-bugs] [Bug 31531] Some modules loaded twice in opac-memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31531 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140330|0 |1 is obsolete| | --- Comment #2 from Joonas Kylmälä --- Created attachment 140600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140600&action=edit Bug 31531: Remove unnecessary use directives on opac-memberentry.pl This patch just removes two redundant use directives in opac-memberentry.pl Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 18:48:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 16:48:41 +0000 Subject: [Koha-bugs] [Bug 31531] Some modules loaded twice in opac-memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31531 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | Status|Signed Off |Passed QA CC| |joonas.kylmala at iki.fi --- Comment #3 from Joonas Kylmälä --- Trivial, straight to PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 19:42:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 17:42:27 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi Status|Needs Signoff |Failed QA --- Comment #308 from Joonas Kylmälä --- Hi, could you please split the patch "Bug 17015: DiscreteCalendar UI, Back-End and necessary scripts" to as many patches are there are logical changes. For example, one patch introducing this new Calendar class, along with its unit tests, and a reason for introducing this new class. The another patch for adding scripts to populate this new calendar system. Third patch to convert existing code to use the new Calendar system, and so forth. Please see this wikipedia article for more info: . Redoing the patches should also fix up the most pressing issue at the moment with this patch set that is preventing a review: there is no clear description in each patch what they are doing, there appears to be many descriptions combined from multiple squashed patches. Writing good descriptions saves a lot of time from the reviewers and helps to get this problem fixed faster as the reviewers can point out any design flaws without reading the code, just based on the patch descriptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 19:54:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 17:54:25 +0000 Subject: [Koha-bugs] [Bug 23010] If an item is checked out or in transit it should not be able to be marked withdrawn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Felicity Brown changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felicity.brown at montgomeryco | |untymd.gov --- Comment #1 from Felicity Brown --- Conversely, it would be nice to have the option to have items check-in automatically (be removed from a customer's account) when a staff member marks them as withdrawn, so that they don't linger forever in both statuses. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 20:06:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 18:06:12 +0000 Subject: [Koha-bugs] [Bug 31556] Correct breadcrumb and URLs for Cataloging module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 20:11:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 18:11:43 +0000 Subject: [Koha-bugs] [Bug 31554] Sorting of acquisition info appears to be broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31554 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi --- Comment #1 from Joonas Kylmälä --- I'm guessing a regression or intended changed from "Bug 21467: Add treetable to subscription detail to group orders by parent ordernumber" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 20:17:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 18:17:00 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 20:29:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 18:29:45 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #58 from Andrew Fuerste-Henry --- Thanks for tackling this, Martin! It's a big but useful change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 20:31:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 18:31:43 +0000 Subject: [Koha-bugs] [Bug 30732] Librarians with only "place_holds" permission can not suspend and resume holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30732 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 20:31:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 18:31:48 +0000 Subject: [Koha-bugs] [Bug 30732] Librarians with only "place_holds" permission can not suspend and resume holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30732 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140562|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 140601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140601&action=edit Bug 30732: Librarians with only "place_holds" permission can not suspend and resume holds If a librarian only has the place_holds permission, they can see the buttons for placing and suspending holds on moremember.pl and circulation.pl, but cannot use them. Test Plan: 1) Give your librian only the place_holds permission 2) Attempt to "suspend all" and "resume all" holds on moremember.pl and circulation.pl 3) Note you cannot 4) Apply this patch 5) Restart all the things! 6) Test again, note you can now suspend and resume holds! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 20:40:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 18:40:19 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 20:40:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 18:40:24 +0000 Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140518|0 |1 is obsolete| | --- Comment #15 from David Nind --- Created attachment 140602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140602&action=edit Bug 31154: Pass biblionumber to Koha::UI::Form::Builder::Item->new from batchMod.pl to prevent error 500 When one tries to batch mod items and has "Use default values" checkbox checked on and they have value in syspref "itemcallnumber", Koha dies on error 500. In logs it reads: Can't call method "field" on an undefined value at .../Koha/Koha/UI/Form/Builder/Item.pm line 164. This happens because in batchMod.pl line 269 we don't pass biblionumber as parameter to Koha::UI::Form::Builder::Item->new and thus Koha fails to fetch biblios marc record. To test: 1. Confirm you have/set value to syspref "itemcallnumber" e.g. 084a 2. Find some item(s) to modify 3. Provide barcodes of those item(s) and check checkbox "Use default values" 4. Hit "Continue" => error 500 is raised 5. Apply patch. 6. Repeat steps 3. and 4. => no error is raised Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 20:42:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 18:42:06 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #309 from Blou --- We have stopped maintaining the patch as a formal prospect long ago, after being told there was no need nor interest for it. It is an endeavour, and maintaining it "proper" is very time consumming. So we maintain it for ourselves and our clients (maybe hoping that maybe one day the stars will align?), as it is vastly superior to the current "calendar" in Koha. We tried many splits over the years, following recommendations. Right now it's mostly for the sake of easy "git apply". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 20:48:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 18:48:53 +0000 Subject: [Koha-bugs] [Bug 31497] Quick add: mandatory fields save as empty when not filled in before first save attempt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 20:48:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 18:48:58 +0000 Subject: [Koha-bugs] [Bug 31497] Quick add: mandatory fields save as empty when not filled in before first save attempt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140568|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 140603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140603&action=edit Bug 31497: Prevent ID clash on quick add fields The quick add clones the original fields, including ids. This can cause some clash when other JS is running on the page. This patch updates the ids of the fields before adding to the form, which prevents bad copying/clearing of fields To test: * Go to patrons module * Click on Quick add new patron (I chose Patron as category) * On sample database these fields are marked as mandatory: * Surname * Cardnumber * Library * Category * Fill in Surname, leave cardnumber empty * Save - mandatory message is shown * Fill in cardnumber - save * The patron is saved * BUT: cardnumber is empty! APPLY PATCH * Repeat plan above * Cardnumber is correctly saved Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 21:12:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 19:12:29 +0000 Subject: [Koha-bugs] [Bug 31550] WS ILSDI opac description for some item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david at davidnind.com --- Comment #4 from David Nind --- I'm getting this error after applying the patch (using koha-testing-docker - flush_memcached, restart_all, and browser cached cleared after patch applied): Could not compile /kohadevbox/koha/opac/ilsdi.pl: Attempt to reload C4/ILSDI/Services.pm aborted. Compilation failed in require at /kohadevbox/koha/opac/ilsdi.pl line 22. BEGIN failed--compilation aborted at /kohadevbox/koha/opac/ilsdi.pl line 22. at /usr/share/perl5/CGI/Compile.pm line 144 in CGI::Compile::compile at /usr/share/perl5/CGI/Compile.pm line 144 141: my $code = $self->_eval($eval); 142: my $exception = $@; 143: 144: die "Could not compile $script: $exception" if $exception; 145: 146: subname "${package}::$subname", sub { 147: my @args = @_; Show function arguments .... Testing notes: 1. Added OPAC descriptions for CCODE authorised values. 2. Tested with sample data using: http://127.0.0.1:8081/cgi-bin/koha/opac/ilsdi.pl?service=GetRecords&id=262 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 21:20:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 19:20:04 +0000 Subject: [Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 21:20:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 19:20:10 +0000 Subject: [Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138202|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 140604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140604&action=edit Bug 31252: Advanced search in staff interface should call barcodedecode if the search index is a barcode We should run any inputted barcode through barcodedecode before passing it to any subroutines. This was missed during the initial development of bug 26351. Test Plan: 1) Set itemBarcodeInputFilter to "Remove spaces from" 2) Browse to the staff side advanced search 3) Run a barcode search for "MY TEST" 4) Note the message returned is: No results match your search for 'bc,wrdl: "MY TEST"'. 5) Apply this patch 6) Restart all the things! 7) Repeat your search 8) Note the message returned is: No results match your search for 'bc,wrdl: "MYTEST"'. 9) Note the lack of the space between MY and TEST! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 21:21:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 19:21:42 +0000 Subject: [Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |david at davidnind.com --- Comment #7 from David Nind --- Patch still applies and have signed off, as everything works as per the test plan. Have changed status to 'In Discussion' as I think Katrin's comments need addressing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 21:29:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 19:29:38 +0000 Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #18 from David Nind --- The patch no longer applies 8-(.... Also, I'm not sure if this needs some more work or if the questions from the discussions are resolved. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29008: Avoid warning when checking Koha version in plugins Using index info to reconstruct a base tree... M Koha/Plugins/Base.pm M koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt M plugins/plugins-home.pl Falling back to patching base and 3-way merge... Auto-merging plugins/plugins-home.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt Auto-merging Koha/Plugins/Base.pm Applying: Bug 29008: Add unit test Using index info to reconstruct a base tree... M t/db_dependent/Koha/Plugins/Plugins.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Plugins/Plugins.t CONFLICT (content): Merge conflict in t/db_dependent/Koha/Plugins/Plugins.t error: Failed to merge in the changes. Patch failed at 0001 Bug 29008: Add unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 21:49:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 19:49:57 +0000 Subject: [Koha-bugs] [Bug 31540] Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31540 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 21:50:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 19:50:02 +0000 Subject: [Koha-bugs] [Bug 31540] Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31540 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140461|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 140605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140605&action=edit Bug 31540: Exclude expired holds from the reminder job Some libraries don't want to auto-cancel holds, but we should not remind a patron about a hold which has expired. To test: 1 - Place a hold for a patron 2 - Set it waiting 3 - Run the holds reminder script in the future perl misc/cronjobs/holds/holds_reminder.pl -day 1 --date '2023-09-12' -v 4 - Note the holds would be reminded 5 - Set expirationdate for the hold less than today UPDATE reserves SET expirationdate = DATE_SUB(CURDATE(), INTERVAL 1 DAY); 6 - Run the remidner cron again 7 - No holds trigger! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 21:50:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 19:50:09 +0000 Subject: [Koha-bugs] [Bug 31539] Delay not taken in account when items with different due date are listed in overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31539 Maude changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Maude --- The tests confirmed that it was indeed the flag that caused the problem. Thank you! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 22:16:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 20:16:54 +0000 Subject: [Koha-bugs] [Bug 21860] Marc modification templates cannot check or change indicators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #12 from Heather --- Exactly, Laura! We would love to be able to do that, but can't with the templates unable to act based on indicator data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 22:21:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 20:21:51 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #23 from David Nind --- Patch no longer applies 8-(... Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 30250: Use ApplyFrameworkDefaults when cataloguing Applying: Bug 30250: Add ApplyFrameworkDefaults system preference Using index info to reconstruct a base tree... M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref Auto-merging installer/data/mysql/mandatory/sysprefs.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 30250: Add ApplyFrameworkDefaults system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 22:22:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 20:22:54 +0000 Subject: [Koha-bugs] [Bug 31557] New: Hold queue/home vs. holding library/transport cost matrix complications Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557 Bug ID: 31557 Summary: Hold queue/home vs. holding library/transport cost matrix complications Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: sbrown at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be helpful if build_holds_queue.pl either 1) checked items' holding libraries in addition to home when items float, or 2) used the Transport Cost Matrix instead when systems have it enabled. Using home library only/first results in higher 'costs' and in holds being filled more slowly than necessary, and can be confusing for libraries. Home/holding: If I understand correctly, build_holds_queue.pl looks for items whose home library matches the hold's pickup library (plus accounting for any preferences set in StaticHoldsQueueWeight/HoldsQueueSkipClosed/RandomizeHoldsQueueWeight). For example, in a system where items float, a hold to be picked up at West library has the following items: Item 1: Home library West, holding library East Item 2: Home library West, holding library West Item 3: Home library North, holding library West If build_holds_queue.pl sees Item 1 first, it will be placed on East's queue to send to West even though Item 2 is already at West and could fill the hold more efficiently. Then since the Transport Cost Matrix is only consulted if no available items have a home library matching the hold's pickup library, holds are filled in a more 'expensive' way than libraries may expect. Using the Transport Cost Matrix directly would address this. For example, in a system where items float and a hold is to be picked up at South: Item 1: Home library East, holding library South Item 2: Home library West, holding library West Item 3: Home library South, holding library West build_holds_queue.pl will see that Item 3 has a home library matching the pickup library and will place it on West's queue to send to South. If build_holds_queue.pl consulted the Transport Cost Matrix, Item 1 would be placed on South's queue with no transfer necessary. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 22:27:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 20:27:17 +0000 Subject: [Koha-bugs] [Bug 31558] New: Upgrade of TinyMCE broke image drag and drop Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 Bug ID: 31558 Summary: Upgrade of TinyMCE broke image drag and drop Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 26949 upgraded JS lib TinyMCE to 5.9.2 This version has a known issue on images drag and drop : https://stackoverflow.com/questions/64782955/tinymce-inline-drag-and-drop-image-upload-not-working -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 22:27:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 20:27:25 +0000 Subject: [Koha-bugs] [Bug 31558] Upgrade of TinyMCE broke image drag and drop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |fridolin.somers at biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 22:29:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 20:29:18 +0000 Subject: [Koha-bugs] [Bug 31497] Quick add: mandatory fields save as empty when not filled in before first save attempt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140603|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes --- Created attachment 140606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140606&action=edit Bug 31497: Prevent ID clash on quick add fields The quick add clones the original fields, including ids. This can cause some clash when other JS is running on the page. This patch updates the ids of the fields before adding to the form, which prevents bad copying/clearing of fields To test: * Go to patrons module * Click on Quick add new patron (I chose Patron as category) * On sample database these fields are marked as mandatory: * Surname * Cardnumber * Library * Category * Fill in Surname, leave cardnumber empty * Save - mandatory message is shown * Fill in cardnumber - save * The patron is saved * BUT: cardnumber is empty! APPLY PATCH * Repeat plan above * Cardnumber is correctly saved Signed-off-by: David Nind Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 22:29:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 20:29:21 +0000 Subject: [Koha-bugs] [Bug 31558] Upgrade of TinyMCE broke image drag and drop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 --- Comment #1 from Fridolin Somers --- I set as major because several librarians are asking for this fix. They may use this feature in OPAC news very often. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 22:29:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 20:29:26 +0000 Subject: [Koha-bugs] [Bug 31558] Upgrade of TinyMCE broke image drag and drop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 22:29:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 20:29:32 +0000 Subject: [Koha-bugs] [Bug 31558] Upgrade of TinyMCE broke image drag and drop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26949 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 [Bug 26949] Upgrade TinyMCE in the staff interface from 5.0.16 to 5.9.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 22:29:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 20:29:32 +0000 Subject: [Koha-bugs] [Bug 26949] Upgrade TinyMCE in the staff interface from 5.0.16 to 5.9.2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31558 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 [Bug 31558] Upgrade of TinyMCE broke image drag and drop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 22:32:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 20:32:59 +0000 Subject: [Koha-bugs] [Bug 31558] Upgrade of TinyMCE broke image drag and drop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 22:33:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 20:33:03 +0000 Subject: [Koha-bugs] [Bug 31558] Upgrade of TinyMCE broke image drag and drop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 --- Comment #2 from Fridolin Somers --- Created attachment 140607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140607&action=edit Bug 31558: Fix image drag and drop in TinyMCE Bug 26949 upgraded JS lib TinyMCE to 5.9.2 This version has a known issue on images drag and drop : https://stackoverflow.com/questions/64782955/tinymce-inline-drag-and-drop-image-upload-not-working Test plan : 1) Go to Tools > HTML customizations 2) Create a new entry (not using text editor) 3) Drag and drop an image => Without patch you see an error message from TinyMCE 'Dropped file type is not supported' => With patch : It works ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 22:33:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 20:33:49 +0000 Subject: [Koha-bugs] [Bug 31553] News item contents field does not always expand when you click on a non-default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31553 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 22:33:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 20:33:55 +0000 Subject: [Koha-bugs] [Bug 31553] News item contents field does not always expand when you click on a non-default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31553 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140509|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 140608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140608&action=edit Bug 31553: Ensure news item content field is always editable Set a padding at the bottom of the news item editor body. This is a tricky bug to replicate. Test plan: 1. Set 'AdditionalContentsEditor' syspref = 'a WYSIWYG editor (TinyMCE)'. 2. Select multiple languages in the 'OPACLanguages' system preference. 3. Go to: Tools > News. 4. Create a new news item. Switch between the different language tabs. 5. Confirm you can always input into the content field in all languages. 6. Edit an exiting news item. Switch between different language tabs. 7. Confirm you can always input into the content field in all languages. Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 22:37:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 20:37:14 +0000 Subject: [Koha-bugs] [Bug 31558] Upgrade of TinyMCE broke image drag and drop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 --- Comment #3 from Fridolin Somers --- There are other places with TinyMCE (wysiwyg prefs, branches description ...) but looks like they do not need images drag and drop. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 22:38:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 20:38:08 +0000 Subject: [Koha-bugs] [Bug 31553] News item contents field does not always expand when you click on a non-default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31553 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- I was able to replicate by installing two additional languages: - sudo koha-translate --install en-NZ --dev kohadev - sudo koha-translate --install fr-FR --dev kohadev This gives the default tab and three language tabs (Default, English New Zealand (en-NZ), English (en), Français (fr-FR)). For me, you couldn't enter anything in the English(en) tab before the patch was applied. Tested using koha-testing-docker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 22:44:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 20:44:17 +0000 Subject: [Koha-bugs] [Bug 31558] Upgrade of TinyMCE broke image drag and drop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 13 22:44:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 20:44:28 +0000 Subject: [Koha-bugs] [Bug 31558] Upgrade of TinyMCE broke image drag and drop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140607|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 140609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140609&action=edit Bug 31558: Fix image drag and drop in TinyMCE Bug 26949 upgraded JS lib TinyMCE to 5.9.2 This version has a known issue on images drag and drop : https://stackoverflow.com/questions/64782955/tinymce-inline-drag-and-drop-image-upload-not-working Test plan : 1) Go to Tools > HTML customizations 2) Create a new entry (not using text editor) 3) Drag and drop an image => Without patch you see an error message from TinyMCE 'Dropped file type is not supported' => With patch : It works ! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 01:32:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 23:32:54 +0000 Subject: [Koha-bugs] [Bug 26949] Upgrade TinyMCE in the staff interface from 5.0.16 to 5.9.2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 01:33:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Sep 2022 23:33:20 +0000 Subject: [Koha-bugs] [Bug 21860] Marc modification templates cannot check or change indicators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 02:55:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 00:55:29 +0000 Subject: [Koha-bugs] [Bug 23817] Normalize phone number when searching patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817 --- Comment #8 from David Cook --- It looks like there's a new wrinkle in this one... I was patching an older Koha that still used C4::Utils::DataTables::Members, but in master it looks like we're using the REST API, which I suspect will be much harder to change. But let's see... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 05:16:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 03:16:27 +0000 Subject: [Koha-bugs] [Bug 23817] Normalize phone number when searching patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817 --- Comment #9 from David Cook --- (In reply to David Cook from comment #8) > It looks like there's a new wrinkle in this one... > > I was patching an older Koha that still used C4::Utils::DataTables::Members, > but in master it looks like we're using the REST API, which I suspect will > be much harder to change. But let's see... I don't think that it's going to be possible to easily fix this with code in master. Using literal SQL, it's possible to craft a search using DBIx::Class to do the search[1], but we can't pass in that literal SQL via the API. We could potentially inject the literal SQL within the API backend but it would need to be in the Koha/REST/Plugin/Objects.pm helper... and it would involve recursively navigating the data (more than it already is...), and that would really just be a hack at that stage anyway. [1] my $test = $rs->search(\[ "regexp_replace(phone,?,?) LIKE ?",'[^0-9]','','%1234%']); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 06:15:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 04:15:45 +0000 Subject: [Koha-bugs] [Bug 23817] Normalize phone number when searching patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817 --- Comment #10 from David Cook --- I think the only way forward is to normalize the data in the database (ie only store [\+0-9], and normalize the search query in "koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc" to [\+0-9] as well. It would still be necessary to update all the patron data in the database. We'd need something like "touch_all_patron_records.pl", or a once off SQL update to strip out everything that isn't [\+0-9]. regexp_replace(phone,'[^0-9]','') would be useful for that. This patch doesn't take into account Katrin's edge cases of multiple phone numbers or text comments in the "phone" field. There's no way to do that unless we completely change how DataTables work with the REST API. I've taken a look at a large patron database and over 99% of phone number data is just 1 phone number. Out of 100,000+ records, I see maybe 5 that have text comments in them. I see 2 records with 2 phone numbers in them. If they need to note the phone number belongs to a particular person or is text only, I think that needs to go in the "Contact note". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 06:19:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 04:19:17 +0000 Subject: [Koha-bugs] [Bug 23817] Normalize phone number when searching patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817 --- Comment #11 from David Cook --- I do have one more idea that wouldn't involve changing the data... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 07:18:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 05:18:36 +0000 Subject: [Koha-bugs] [Bug 23817] Normalize phone number when searching patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #12 from David Cook --- (In reply to David Cook from comment #11) > I do have one more idea that wouldn't involve changing the data... There are some ways to provide additional columns to the DBIC query, but it auto-escapes single quotes, which makes it impossible to use regexp_replace as a derived column. Plus the DBIC search only works on real columns it seems (which is a bit silly...) -- I suppose another solution would be a pure Javascript solution that strips anything but [\+0-9] out of the phone number field when saving and searching... -- Another option would be a database trigger, but Koha has avoided those to date. -- I suppose another idea would be to add a new phone number column called "phone_normalized". That seems unnecessary though. -- Now I've spent quite a bit of time on this one, and I suspect it's going to go nowhere, unfortunately. There just isn't a good way to deal with this one using DBIC and the REST API I reckon... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 07:18:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 05:18:57 +0000 Subject: [Koha-bugs] [Bug 23817] Normalize phone number when searching patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817 --- Comment #13 from David Cook --- Created attachment 140610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140610&action=edit Bug 23817: Normalize phone number when storing and when searching in Patrons module This patch normalizes the phone number when stored via Koha::Patron, and normalizes the phone number when searching "Primary phone" in the Patrons module. Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Go to http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 2. Input '1-(234)-567-8901' into the 'Primary phone' field 3. Note on the next screen the phone number is shown as 12345678901 4. Go to http://localhost:8081/cgi-bin/koha/members/members-home.pl 5. Choose "Search field" of "Primary phone" 6. Search for '1-(234)-567-8901' 7. Note you are taken to http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 8. Try out different permutations like '234 567 8901' or '5678901' 9. Note that every permutation works to find the borrower -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 08:25:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 06:25:39 +0000 Subject: [Koha-bugs] [Bug 31555] Getting holds via REST API needs edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31555 Johanna Räisä changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |johanna.raisa at koha-suomi.fi |ity.org | Status|NEW |Needs Signoff --- Comment #1 from Johanna Räisä --- Created attachment 140611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140611&action=edit Bug 31555: change holds GET permission to place_holds This patch changes holds' GET REST API endpoint permission to place_holds to match with request.pl Test plan: 1) prove t/db_dependent/api/v1/holds.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 08:44:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 06:44:57 +0000 Subject: [Koha-bugs] [Bug 23817] Normalize phone number when searching patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 09:13:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 07:13:32 +0000 Subject: [Koha-bugs] [Bug 31513] NaN errors when using refund and payout with CurrencyFormat = FR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31513 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140405|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes --- Created attachment 140612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140612&action=edit Bug 31513: Remove price formatting form data- attributes We cannot use data formatted with a decimal comma for calculations. So we need to make sure that the data- attributes passed to the modals are in 'database format' with decimal . This will fix the NaN errors on the forms, but might also negatively effect formatting in some spots. Formatting should be fixed separately as this is for sure the right first step, but we need to put in more work for displays. To test: * Set CurrencyFormat system preference to FR * Go to any patron account > accounting tab * Create a credit * On Transactions tab: Payout amount at bottom = Verify NaN in input * On Transactions tab: Issue payout on the credit line = Verify NaN in input * Create a manual debit and pay it * On Transactions tab: Issue refund = Verify NaN in input * Apply patch * Repeat test plan * Now all input fields should be set with the correct amounts https://bugs.koha-community.org/show_bug.cgi?id=31486 Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 09:15:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 07:15:40 +0000 Subject: [Koha-bugs] [Bug 31513] NaN errors when using refund and payout with CurrencyFormat = FR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31513 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 09:35:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 07:35:27 +0000 Subject: [Koha-bugs] [Bug 31554] Sorting of acquisition info appears to be broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31554 --- Comment #2 from Katrin Fischer --- You are probably right, Joonas, but I wonder how we could improve sorting again. Right now I can not see any type of sorting, if all the status are 'complete'. Some kind of chronologically sorting would be nice - maybe by order date? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 09:38:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 07:38:58 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #266 from Julian Maurice --- Created attachment 140613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140613&action=edit Bug 30952: Header search - move tabs to the right (and other tweaks) Make the search bar take the whole page width, with inputs at the center taking all the available space Add a separator between inputs when there are more than one Issue #24 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 09:48:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 07:48:41 +0000 Subject: [Koha-bugs] [Bug 31559] New: Staff results page doesn't always use up full available screen width Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31559 Bug ID: 31559 Summary: Staff results page doesn't always use up full available screen width Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org If the titles of the records are quite short, the entries of the result page will "shrink" not using the full available width of the page. For an example with the sample data: search for 'Henry'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 10:08:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 08:08:48 +0000 Subject: [Koha-bugs] [Bug 12388] IssueSlip output should be sorted by date_due, not timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12388 --- Comment #18 from Emmi Takkinen --- (In reply to Joonas Kylmälä from comment #17) > Running prove t/db_dependent/Members/IssueSlip.t gives the following warning: > > t/db_dependent/Members/IssueSlip.t .. > DBIx::Class::ResultSet::_construct_results(): Unable to properly collapse > has_many results in iterator mode due to order criteria - performed an eager > cursor slurp underneath. Consider using ->all() instead at > /kohadevbox/koha/Koha/Objects.pm line 312 > If I understand correctly (and correct me if I'm wrong), this happens because sub pending_checkouts uses prefetch to get data (at least) from biblio table. Bug 28561 handled same kind of problem, comment from there: > DBIx says about prefetching and collapse the following: > If an "order_by" is already declared, and orders the resultset in a way that > makes collapsing as described above impossible (e.g. ORDER BY > has_many_rel.column or ORDER BY RANDOM()), DBIC will automatically switch to > "eager" mode and slurp the entire resultset before constructing the first > object returned by "next". In bug 28561 this was handled by replacing prefetch with join. However using this same approach here would mean we lose data from biblio table since join returns data only from, in this case, issues table. At least one solution for this would be to move those order_by statements (date_due, issuedate) from sub IssuesSlip to sub pending_reserves. However I'm not sure if this could have some side effects in other parts of Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 10:22:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 08:22:56 +0000 Subject: [Koha-bugs] [Bug 31560] New: koha-create fails with error pwgen invalid option -- 'r' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31560 Bug ID: 31560 Summary: koha-create fails with error pwgen invalid option -- 'r' Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: Linux Status: NEW Severity: blocker Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: jesus at medios.es QA Contact: testopia at bugs.koha-community.org root at newkoha:~# koha-create --create-db gon pwgen: invalid option -- 'r' Usage: pwgen [ OPTIONS ] [ pw_length ] [ num_pw ] Options supported by pwgen: -c or --capitalize Include at least one capital letter in the password -A or --no-capitalize Don't include capital letters in the password -n or --numerals Include at least one number in the password -0 or --no-numerals Don't include numbers in the password -y or --symbols Include at least one special symbol in the password -s or --secure Generate completely random passwords -B or --ambiguous Don't include ambiguous characters in the password -h or --help Print a help message -H or --sha1=path/to/file[#seed] Use sha1 hash of given file as a (not so) random generator -C Print the generated passwords in columns -1 Don't print the generated passwords in columns -v or --no-vowels Do not use any vowels so as to avoid accidental nasty words root at newkoha:~# apt list --installed | grep pwgen WARNING: apt does not have a stable CLI interface. Use with caution in scripts. pwgen/oldoldstable,now 2.07-1.1+b1 amd64 [installed,automatic] root at newkoha:~# apt list --installed | grep koha WARNING: apt does not have a stable CLI interface. Use with caution in scripts. koha-common/stable,now 22.05.04-1 all [installed] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 11:17:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 09:17:05 +0000 Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 11:17:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 09:17:10 +0000 Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124859|0 |1 is obsolete| | --- Comment #19 from Fridolin Somers --- Created attachment 140614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140614&action=edit Bug 29008: Add unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 11:17:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 09:17:51 +0000 Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124858|0 |1 is obsolete| | --- Comment #20 from Fridolin Somers --- Created attachment 140615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140615&action=edit Bug 29008: Avoid warning when checking Koha version in plugins In Koha plugins home page, each plugin min/max version is compared with actual Koha version. This uses metadatas assuming there are numbers, like 18.11 or 20.1100000. But source code version is actually YY.MM.XX.YYY.ZZZ. We sometimes find it in plugins, for examle : https://github.com/thekesolutions/koha-plugin-bibliocommons/blob/c2da98f1bda450452ad687e5623f45939a967bdf/Koha/Plugin/Com/Theke/BiblioCommons.pm#L31 https://github.com/KohaSuomi/koha-plugin-sms-send-link-mobility-driver/blob/master/Koha/Plugin/Fi/KohaSuomi/SMSSendLinkMobilityDriver.pm#L22 This generates warning : Argument "18.11.01" isn't numeric in numeric lt (<) at /home/koha/src/Koha/Plugins/Base.pm line 377.: src/plugins/plugins-home.pl We should allow this syntax in plugins metadatas. Test plan : 1) Install a Koha plugin with minimum_version containing 3 dots : for example 18.11.01.001 2) Go to plugins home page 3) Check there is no warning 4) Install a plugin with minimum_version higher than current Koha version 5) Check in plugins table the warning appears 6) Install a plugin with maximum_version lower than current Koha version 7) Check in plugins table the warning appears -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 11:17:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 09:17:55 +0000 Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140614|0 |1 is obsolete| | --- Comment #21 from Fridolin Somers --- Created attachment 140616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140616&action=edit Bug 29008: Add unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 11:18:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 09:18:59 +0000 Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008 --- Comment #22 from Fridolin Somers --- Thanks a lot for testing David. I added POD to news methods to avoid a QA warning ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 11:34:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 09:34:35 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #267 from Julian Maurice --- Created attachment 140617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140617&action=edit Bug 30952: Fix header search bar for RTL Issue #38 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 11:40:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 09:40:15 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #268 from Julian Maurice --- Created attachment 140618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140618&action=edit Bug 30952: Fix navbar elements ordering for RTL Issue #38 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 11:50:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 09:50:29 +0000 Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com --- Comment #32 from Arthur Suzuki --- Hi David, Given your last comment I won't backport to 21.11 until situation is fixed for this one. Ping me when it's the situation is settled! Arthur -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 11:52:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 09:52:58 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #269 from Julian Maurice --- Created attachment 140619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140619&action=edit Bug 30952: Adjust colors of browse search Issue #23 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 11:56:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 09:56:19 +0000 Subject: [Koha-bugs] [Bug 31246] displayed in 'Additional fields' section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31246 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |arthur.suzuki at biblibre.com --- Comment #7 from Arthur Suzuki --- won't backport on 21.11.x (depends on 30733) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 12:02:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 10:02:50 +0000 Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |arthur.suzuki at biblibre.com Resolution|--- |FIXED --- Comment #27 from Arthur Suzuki --- won't backport to 21.11.x. depends on backgroundjobs (not available in 21.11.x). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 12:05:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 10:05:22 +0000 Subject: [Koha-bugs] [Bug 31560] koha-create fails with error pwgen invalid option -- 'r' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31560 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 12:16:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 10:16:15 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #270 from Julian Maurice --- Created attachment 140620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140620&action=edit Bug 30952: Fix color of navbar toggle on small screen Issue #37 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 12:31:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 10:31:29 +0000 Subject: [Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #8 from Kyle M Hall --- Katrin, I think both the issue with the libsuite8 filter, and adding an option to add the ItemBarcodeInputFilter into the item edit form deserve their own bug reports! (In reply to Katrin Fischer from comment #3) > Looking at this again... the libsuite8 conversion is an odd one: > > IMS-b-126 searches for: CPL-IMS-b--126 => Where is the branchcode suddenly > coming from? > > This should not happen, IMS-B-125 should stay identical on conversion? > > t/Circulation_barcodedecode. > 'libsuite8' => ['b000126', 'b12', 'B0126', 'IMS-B-126', > 'ims-b-126','CD0000024','00123','11998'], > 'libsuite8' => ['IMS-b-126', 'IMS-b-12', 'IMS-B-126', 'IMS-B-126', > 'ims-b-126','IMS-CD-24','IMS-b-123','IMS-b-11998'], > > Can you have a look please? That's out of scope -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 12:35:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 10:35:58 +0000 Subject: [Koha-bugs] [Bug 31417] Re-instate the cataloguing sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 Emmanuel Bétemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 12:36:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 10:36:54 +0000 Subject: [Koha-bugs] [Bug 5523] Display list of items which are to be cataloged in the cataloguing home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5523 Emmanuel Bétemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 12:38:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 10:38:19 +0000 Subject: [Koha-bugs] [Bug 31476] Add tool tips to the buttons on the circulation start page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31476 Emmanuel Bétemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 12:38:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 10:38:44 +0000 Subject: [Koha-bugs] [Bug 31477] Switch icon for inventory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31477 Emmanuel Bétemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 12:39:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 10:39:31 +0000 Subject: [Koha-bugs] [Bug 31478] Standardize upload/download icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31478 Emmanuel Bétemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 12:39:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 10:39:59 +0000 Subject: [Koha-bugs] [Bug 31556] Correct breadcrumb and URLs for Cataloging module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31556 Emmanuel Bétemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 13:11:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 11:11:22 +0000 Subject: [Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 --- Comment #9 from Katrin Fischer --- Sorry, maybe too many comments from me here :) You'll have to read them all: (In reply to Katrin Fischer from comment #5) > I just ran into a case where the library has barcodes with trailing spaces > from a batch of faulty barcode labels. Could it be an option to add the > ItemBarcodeInputFilter into the item edit form too? (just wondering if you > have an opinion about this, totally a separate bug) Yep, totally a separate bug ;) (In reply to Katrin Fischer from comment #4) > I did some more research and it looks like we already use the filter like > that in a lot of places. If there is an issue with libsuite8 we should > probably move it to a separate bug. Again agreed ;) I am ok to move on with this patch set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 13:18:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 11:18:53 +0000 Subject: [Koha-bugs] [Bug 31561] New: Background jobs stuck at "New" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31561 Bug ID: 31561 Summary: Background jobs stuck at "New" Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org "Bug 30172 - Background jobs failing due to race condition" has been fixed in 22.05.00,21.11.05,21.05.14,20.11.18, but I am still seeing background jobs stuck at "New" on 21.11.11, and there is no way to make them run apart from this: $ sudo koha-worker --stop $ sudo service rabbitmq-server stop $ sudo koha-worker --start $ sudo koha-worker --stop $ sudo service rabbitmq-server start $ sudo koha-worker --start Library staff are finding this annoying. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 13:20:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 11:20:45 +0000 Subject: [Koha-bugs] [Bug 31561] Background jobs stuck at "New" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31561 --- Comment #1 from Magnus Enger --- I'd say there are two problems here: 1. That the background jobs get stuck at "New" 2. That they are not "retried" automatically -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 13:22:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 11:22:35 +0000 Subject: [Koha-bugs] [Bug 31561] Background jobs stuck at "New" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31561 --- Comment #2 from Katrin Fischer --- Could this be the diacritics issue? Bug 31351 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 13:26:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 11:26:53 +0000 Subject: [Koha-bugs] [Bug 31562] New: Patron 'flags' don't respect unwanted fields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31562 Bug ID: 31562 Summary: Patron 'flags' don't respect unwanted fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com gonenoaddress and lost are shown in preference BorrowerUnwantedField but do not respect the settings. This seems to be because they are handled in their own 'flags' code -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 13:30:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 11:30:20 +0000 Subject: [Koha-bugs] [Bug 31562] Patron 'flags' don't respect unwanted fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31562 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 13:30:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 11:30:25 +0000 Subject: [Koha-bugs] [Bug 31562] Patron 'flags' don't respect unwanted fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31562 --- Comment #1 from Nick Clemens --- Created attachment 140621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140621&action=edit Bug 31562: Treat flags as other borrower fields Rather than generate a custom hash for these fields, we should treat them as other borrower data fields To test: 1 - Edit a patron, note the 'Lost card' and 'Gone no address' fields 2 - Edit syspref BorrowerunwantedField 3 - Set gonenoaddress and lost as unwanted 4 - Edit patron, the fields remain 5 - Apply patch 6 - Edit a patron, fields are hidden 7 - Unhide one of the fields 8 - Edit a patron and confirm it shows and saves correctly 9 - Unhide the other field 10 - Confirm it can be edited and saved -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 13:41:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 11:41:21 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #41 from Emmi Takkinen --- (In reply to Katrin Fischer from comment #40) > Hi Emmi, > > I recently reviewed bug 23681 and I think this goes in a more maintainable > direction. It will allow to define restriction types in a new table with > some being Koha-internal and others being added in addition. > > And what you do with the YAML pref could then be moved to be columns in the > new table, which would make it easy to query, easy to handle for staff, etc. > and remove any issues with variations of spelling/whitespace by having a > list to pick from. > Bug 23681 is in master now, so I'll take a look at this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 13:47:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 11:47:39 +0000 Subject: [Koha-bugs] [Bug 31562] Patron 'flags' don't respect unwanted fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31562 --- Comment #2 from Nick Clemens --- Created attachment 140622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140622&action=edit Bug 31562: Remove gonenoaddress and lost from OPAC borrower field preferences These are not shown, so cannot be unwanted or mandatory -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 13:47:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 11:47:44 +0000 Subject: [Koha-bugs] [Bug 31562] Patron 'flags' don't respect unwanted fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31562 --- Comment #3 from Nick Clemens --- Created attachment 140623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140623&action=edit Bug 31562: Respect mandatory fields pref To test: 1 - Set gonenoaddress and lost in BorrowerMandatoryField 2 - Edit a patron, confirm fields are required -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 13:47:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 11:47:59 +0000 Subject: [Koha-bugs] [Bug 31562] Patron 'flags' don't respect unwanted fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31562 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 13:49:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 11:49:13 +0000 Subject: [Koha-bugs] [Bug 31244] Logout when not logged in raise a 500 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31244 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |arthur.suzuki at biblibre.com Resolution|--- |FIXED --- Comment #8 from Arthur Suzuki --- Won't backport to 21.11.x. Issue not reproduced + the patch breaks perl compilation. ''' Starting Z39.50/SRU daemon for kohadev:Global symbol "$auth_state" requires explicit package name (did you forget to declare "my $auth_state"?) at /kohadevbox/koha/C4/Auth.pm line 982. BEGIN not safe after errors--compilation aborted at /kohadevbox/koha/C4/Auth.pm line 2001. ''' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 13:49:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 11:49:14 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Bug 30588 depends on bug 31244, which changed state. Bug 31244 Summary: Logout when not logged in raise a 500 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31244 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:12:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:12:16 +0000 Subject: [Koha-bugs] [Bug 31562] Patron 'flags' don't respect unwanted fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31562 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140621|0 |1 is obsolete| | Attachment #140622|0 |1 is obsolete| | Attachment #140623|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 140624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140624&action=edit Bug 31562: Treat flags as other borrower fields Rather than generate a custom hash for these fields, we should treat them as other borrower data fields To test: 1 - Edit a patron, note the 'Lost card' and 'Gone no address' fields 2 - Edit syspref BorrowerunwantedField 3 - Set gonenoaddress and lost as unwanted 4 - Edit patron, the fields remain 5 - Apply patch 6 - Edit a patron, fields are hidden 7 - Unhide one of the fields 8 - Edit a patron and confirm it shows and saves correctly 9 - Unhide the other field 10 - Confirm it can be edited and saved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:12:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:12:20 +0000 Subject: [Koha-bugs] [Bug 31562] Patron 'flags' don't respect unwanted fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31562 --- Comment #5 from Nick Clemens --- Created attachment 140625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140625&action=edit Bug 31562: Remove gonenoaddress and lost from OPAC borrower field preferences These are not shown, so cannot be unwanted or mandatory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:12:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:12:23 +0000 Subject: [Koha-bugs] [Bug 31562] Patron 'flags' don't respect unwanted fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31562 --- Comment #6 from Nick Clemens --- Created attachment 140626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140626&action=edit Bug 31562: Respect mandatory fields pref To test: 1 - Set gonenoaddress and lost in BorrowerMandatoryField 2 - Edit a patron, confirm fields are required -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:19:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:19:13 +0000 Subject: [Koha-bugs] [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 --- Comment #10 from David Nind --- Thanks Kyle and Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:26:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:26:36 +0000 Subject: [Koha-bugs] [Bug 18556] Message "Patron's address in doubt" is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:26:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:26:40 +0000 Subject: [Koha-bugs] [Bug 18556] Message "Patron's address in doubt" is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 --- Comment #2 from Nick Clemens --- Created attachment 140627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140627&action=edit Bug 18556: Clarify lost and gonenoaddress messages This patch alters the message for the patron flasg slightly, and adds a title to provide explicit info when hoevered To test: 1 - Edit a patron and set gonenoaddress and lost flags 2 - Note new info in the flags section 3 - Go to 'Checkout' or 'Details' tab for patron 4 - Confirm the messages make sense 5 - Confirm you see a tool tip when hovering on messages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:27:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:27:00 +0000 Subject: [Koha-bugs] [Bug 18556] Message "Patron's address in doubt" is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31562 Severity|enhancement |normal CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:27:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:27:00 +0000 Subject: [Koha-bugs] [Bug 31562] Patron 'flags' don't respect unwanted fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31562 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18556 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:39:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:39:24 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #271 from Julian Maurice --- Created attachment 140628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140628&action=edit Bug 30952: Fix toolbar positioning and spacing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:39:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:39:32 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #272 from Julian Maurice --- Created attachment 140629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140629&action=edit Bug 30952: Fix style of some buttons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:43:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:43:52 +0000 Subject: [Koha-bugs] [Bug 31560] koha-create fails with error pwgen invalid option -- 'r' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31560 --- Comment #1 from Marcel de Rooy --- Tested under Debian 11 mysqlpwd=$(pwgen -s -y -r ":'&\\<>/" 16 1); echo $mysqlpwd @q-rMH4xPF8XXmxx Tested under Debian 10 root at shadow:/usr/share/koha# mysqlpwd=$(pwgen -s -y -r ":'&\\<>/" 16 1); echo $mysqlpwd `=EYqf_TWTu8x"yx root at shadow:/usr/share/koha# mysqlpwd=$(pwgen -s -y -r ":'&\\<>/" 16 1); echo $mysqlpwd vi4O!M8FIzY6n%yU So it works for me. Just noticing a few characters in the first D10 password that could be excluded also. D10 apt list --installed | grep pwgen pwgen/now 2.08-1 amd64 [installed,local] D11 pwgen/now 2.08-2 amd64 [installed,local] Your pwgen version is lower. You did not specify the distro you are working with. Maybe an idea to switch to Debian 11? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:47:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:47:04 +0000 Subject: [Koha-bugs] [Bug 31555] Getting holds via REST API needs edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31555 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:47:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:47:09 +0000 Subject: [Koha-bugs] [Bug 31555] Getting holds via REST API needs edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31555 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140611|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 140630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140630&action=edit Bug 31555: change holds GET permission to place_holds This patch changes holds' GET REST API endpoint permission to place_holds to match with request.pl Test plan: 1) prove t/db_dependent/api/v1/holds.t Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:58:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:58:10 +0000 Subject: [Koha-bugs] [Bug 21982] Circulation statistics wizard does not count deleted items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00,21.11, 22.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:58:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:58:13 +0000 Subject: [Koha-bugs] [Bug 21982] Circulation statistics wizard does not count deleted items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 --- Comment #12 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:58:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:58:15 +0000 Subject: [Koha-bugs] [Bug 23202] Problems when adding multiple items to an order in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00,21.11, 22.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:58:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:58:18 +0000 Subject: [Koha-bugs] [Bug 23202] Problems when adding multiple items to an order in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 --- Comment #16 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:58:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:58:20 +0000 Subject: [Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00,21.11, 22.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:58:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:58:23 +0000 Subject: [Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 --- Comment #24 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:58:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:58:26 +0000 Subject: [Koha-bugs] [Bug 30308] bulkmarcimport.pl broken by OAI-PMH:AutoUpdateSets(EmbedItemData) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00,21.11, 22.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:58:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:58:29 +0000 Subject: [Koha-bugs] [Bug 30308] bulkmarcimport.pl broken by OAI-PMH:AutoUpdateSets(EmbedItemData) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308 --- Comment #17 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:58:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:58:32 +0000 Subject: [Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in accountline when using "Payout amount" button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00,21.11, 22.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:58:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:58:34 +0000 Subject: [Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in accountline when using "Payout amount" button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458 --- Comment #11 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:58:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:58:37 +0000 Subject: [Koha-bugs] [Bug 30471] Typo in Circulation Rules - Lost item fee refund policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30471 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00,21.11, 22.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:58:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:58:39 +0000 Subject: [Koha-bugs] [Bug 30471] Typo in Circulation Rules - Lost item fee refund policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30471 --- Comment #10 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:58:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:58:42 +0000 Subject: [Koha-bugs] [Bug 30838] to_address is misleading for SMS transports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30838 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00,21.11, 22.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:58:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:58:45 +0000 Subject: [Koha-bugs] [Bug 30838] to_address is misleading for SMS transports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30838 --- Comment #19 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:58:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:58:48 +0000 Subject: [Koha-bugs] [Bug 30878] Canceling holds from 'Holds awaiting pickup' should not reset the selected tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30878 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00,21.11, 22.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:58:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:58:51 +0000 Subject: [Koha-bugs] [Bug 30878] Canceling holds from 'Holds awaiting pickup' should not reset the selected tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30878 --- Comment #6 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:58:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:58:53 +0000 Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00,21.11, 22.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:58:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:58:56 +0000 Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #31 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:59:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:59:00 +0000 Subject: [Koha-bugs] [Bug 31120] Items will renew for zero ( 0 ) days if renewalperiod is blank/empty value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31120 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00,21.11, 22.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:59:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:59:03 +0000 Subject: [Koha-bugs] [Bug 31120] Items will renew for zero ( 0 ) days if renewalperiod is blank/empty value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31120 --- Comment #14 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:59:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:59:05 +0000 Subject: [Koha-bugs] [Bug 31121] Format date range on top of cashup summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00,21.11, 22.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:59:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:59:08 +0000 Subject: [Koha-bugs] [Bug 31121] Format date range on top of cashup summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121 --- Comment #10 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:59:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:59:10 +0000 Subject: [Koha-bugs] [Bug 31138] DataTables is not raising error to the end user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31138 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00,21.11, 22.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:59:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:59:13 +0000 Subject: [Koha-bugs] [Bug 31138] DataTables is not raising error to the end user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31138 --- Comment #7 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:59:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:59:16 +0000 Subject: [Koha-bugs] [Bug 31201] Pseudonymization.t failing if selenium/patrons_search.t failed before In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00,21.11, 22.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:59:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:59:18 +0000 Subject: [Koha-bugs] [Bug 31201] Pseudonymization.t failing if selenium/patrons_search.t failed before In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201 --- Comment #8 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:59:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:59:21 +0000 Subject: [Koha-bugs] [Bug 31202] Koha removes optional SIP fields with a value of "0" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31202 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00,21.11, 22.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:59:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:59:24 +0000 Subject: [Koha-bugs] [Bug 31202] Koha removes optional SIP fields with a value of "0" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31202 --- Comment #6 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:59:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:59:26 +0000 Subject: [Koha-bugs] [Bug 31204] Edit dropdown on results.tt should indicate it is record modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31204 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00,21.11, 22.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:59:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:59:29 +0000 Subject: [Koha-bugs] [Bug 31204] Edit dropdown on results.tt should indicate it is record modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31204 --- Comment #7 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:59:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:59:31 +0000 Subject: [Koha-bugs] [Bug 31213] When performing a basic search with no results, repeat the search with term quoted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00,21.11, 22.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 14:59:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 12:59:34 +0000 Subject: [Koha-bugs] [Bug 31213] When performing a basic search with no results, repeat the search with term quoted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213 --- Comment #13 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 15:19:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 13:19:41 +0000 Subject: [Koha-bugs] [Bug 31563] New: Numbers on claims tab not showing in translated templates Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 Bug ID: 31563 Summary: Numbers on claims tab not showing in translated templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When looking at the patron account details or checkouts tab in the staff interface, the tab Claims is missing the numbers in translated templates. Verified on master for German and Greek. I had filed bug 26561 about this a while ago, but the issue reappered and I don't see how to fix it in the po files. Also we have a second language where it's broken now. I wonder if it's the problem with 0 in templates showing here again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 15:20:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 13:20:28 +0000 Subject: [Koha-bugs] [Bug 31563] Numbers on claims tab not showing in translated templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 --- Comment #1 from Katrin Fischer --- Created attachment 140631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140631&action=edit Screenshot of German interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 15:23:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 13:23:54 +0000 Subject: [Koha-bugs] [Bug 31564] New: Pass start label when exporting single label as pdf Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31564 Bug ID: 31564 Summary: Pass start label when exporting single label as pdf Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 31220 partially fixed exporting a single label, we missed passing the start_label -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 15:26:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 13:26:05 +0000 Subject: [Koha-bugs] [Bug 31564] Pass start label when exporting single label as pdf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31564 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 15:26:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 13:26:08 +0000 Subject: [Koha-bugs] [Bug 31564] Pass start label when exporting single label as pdf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31564 --- Comment #1 from Nick Clemens --- Created attachment 140632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140632&action=edit Bug 31564: Pass start label in PDF link To test: 1 - Tools->Lbel creator 2 - Make a new batch 3 - Add an item 4 - Click 'export' on the single item 5 - Enter a starting label position greater than 1 6 - Click Export 7 - Click Download as PDF 8 - Note label in 1st position 9 - Apply patch 10 - Repeat and note label position now honored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 15:27:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 13:27:09 +0000 Subject: [Koha-bugs] [Bug 31564] Pass start label when exporting single label as pdf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31564 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 15:27:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 13:27:13 +0000 Subject: [Koha-bugs] [Bug 31564] Pass start label when exporting single label as pdf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31564 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140632|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 140633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140633&action=edit Bug 31564: Pass start label in PDF link To test: 1 - Tools->Lbel creator 2 - Make a new batch 3 - Add an item 4 - Click 'export' on the single item 5 - Enter a starting label position greater than 1 6 - Click Export 7 - Click Download as PDF 8 - Note label in 1st position 9 - Apply patch 10 - Repeat and note label position now honored Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 15:27:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 13:27:37 +0000 Subject: [Koha-bugs] [Bug 31564] Pass start label when exporting single label as pdf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31564 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31220 --- Comment #3 from Nick Clemens --- Trivial, self SO, sending to QA Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220 [Bug 31220] Error when attempting to export selected labels as PDF -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 15:27:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 13:27:37 +0000 Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected labels as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31564 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31564 [Bug 31564] Pass start label when exporting single label as pdf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 15:41:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 13:41:55 +0000 Subject: [Koha-bugs] [Bug 31564] Pass start label when exporting single label as pdf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31564 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 15:42:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 13:42:38 +0000 Subject: [Koha-bugs] [Bug 31564] Pass start label when exporting single label as pdf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31564 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140633|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 140634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140634&action=edit Bug 31564: Pass start label in PDF link To test: 1 - Tools->Lbel creator 2 - Make a new batch 3 - Add an item 4 - Click 'export' on the single item 5 - Enter a starting label position greater than 1 6 - Click Export 7 - Click Download as PDF 8 - Note label in 1st position 9 - Apply patch 10 - Repeat and note label position now honored Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 15:43:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 13:43:18 +0000 Subject: [Koha-bugs] [Bug 31564] Pass start label when exporting single label as pdf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31564 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Works as expected now. I fixed a missing filter inline whilst QAing. Passes QA now :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 15:44:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 13:44:18 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #59 from Liz Rea --- love everything about this. Please yes. Any number of columns whatever you think is best. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 15:53:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 13:53:54 +0000 Subject: [Koha-bugs] [Bug 31565] New: Patron search filter by category code with special character returns no results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31565 Bug ID: 31565 Summary: Patron search filter by category code with special character returns no results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: lari.taskula at hypernova.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com To reproduce: 1. Add a new patron category with categorycode 'TEST_CAT' 2. Add a patron to category 'TEST_CAT' 3. Go to Patrons search view 4. Under "Search for patron" filters, filter by category you created at step 1 5. Click Search 6. Observe no results Something to start from: 1. Go to http://yourinstance/api/v1/patrons?_page=1&_per_page=20&q=[{"me.category_id":"TEST\\_CAT"}]&_match=contains&_order_by=+me.surname,+me.firstname,+me.middle_name,+me.othernames,+me.street_number,+me.address,+me.address2,+me.city,+me.state,+me.postal_code,+me.country 2. Observe no results 3. Go to http://yourinstance/api/v1/patrons?_page=1&_per_page=20&q=[{"me.category_id":"TEST_CAT"}]&_match=contains&_order_by=+me.surname,+me.firstname,+me.middle_name,+me.othernames,+me.street_number,+me.address,+me.address2,+me.city,+me.state,+me.postal_code,+me.country (difference is that we've removed escaping characters \\ from q=[{"me.category_id":"TEST\\_CAT"}] to q=[{"me.category_id":"TEST_CAT"}] 4. Observe 1 result (the patron you added at step 2) So it has something to do with escape not functioning as expected. If you try q=[{"me.category_id":"TES__CAT"}] or q=[{"me.category_id":"TEST%CAT"}] there are again no results so it also seems like these special characters are not being passed to the database query. Related Bug 30393 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 15:54:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 13:54:44 +0000 Subject: [Koha-bugs] [Bug 31565] Patron search filter by category code with special character returns no results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31565 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30393 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30393 [Bug 30393] datatables wrapper should handle searching for %, _ and \ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 15:54:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 13:54:44 +0000 Subject: [Koha-bugs] [Bug 30393] datatables wrapper should handle searching for %, _ and \ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30393 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31565 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31565 [Bug 31565] Patron search filter by category code with special character returns no results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 16:05:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 14:05:31 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #273 from Julian Maurice --- Created attachment 140635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140635&action=edit Bug 30952: Better header search bar on smaller screens - Show only tab icons on screens <= 992px - Hide form title on the left on screens <= 768px - Move some dropdown lists to the "extra" filters area Issue #24 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 16:12:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 14:12:51 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 Sophie H changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.halden at cheshireshare | |dservices.gov.uk --- Comment #75 from Sophie H --- We would also be interested in this feature -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 16:37:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 14:37:58 +0000 Subject: [Koha-bugs] [Bug 31565] Patron search filter by category code with special character returns no results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31565 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 16:38:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 14:38:02 +0000 Subject: [Koha-bugs] [Bug 31565] Patron search filter by category code with special character returns no results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31565 --- Comment #1 from Lari Taskula --- Created attachment 140636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140636&action=edit Bug 31565: Fix datatables searching escape for exact search To test: 1. Add a new patron category with categorycode 'TEST_CAT' 2. Add a patron to category 'TEST_CAT' 3. Go to Patrons search view 4. Under "Search for patron" filters, filter by category you created at step 1 5. Click Search 6. Observe no results 7. Go to the cities page 8. Add two cities: - 'Cordoba %' - 'Buenos Aires _' - 'London \' 9. Use the column search on the name, alternating _, \ and % as the query => FAIL: Weird behavior 10. Apply this patch and reload 11. Repeat 9 => SUCCESS: Filtering works correctly! 12. Repeat 3-5 13. Observe expected result -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 16:39:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 14:39:57 +0000 Subject: [Koha-bugs] [Bug 31495] Allow opac-page when enforcing GDPR policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31495 --- Comment #2 from Marcel de Rooy --- Note for testers or QA: We do not need this patch to handle anonymous access to opac-page.pl. If it is an opac page, it will show when not logged in. But this patch allows a logged in user to access opac-page while enforcing GDPR and not having given a consent yet. (He could e.g. read the privacy policy when that is implemented under additional contents.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 16:43:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 14:43:00 +0000 Subject: [Koha-bugs] [Bug 31565] Patron search filter by category code with special character returns no results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31565 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lari.taskula at hypernova.fi |ity.org | --- Comment #2 from Lari Taskula --- https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30393#c0 refers to MySQL documentation https://dev.mysql.com/doc/refman/8.0/en/string-literals.html On this page it is also mentioned that "The \% and \_ sequences are used to search for literal instances of % and _ in pattern-matching contexts where they would otherwise be interpreted as wildcard characters. See the description of the LIKE operator in Section 12.8.1, “String Comparison Functions and Operators”. If you use \% or \_ outside of pattern-matching contexts, they evaluate to the strings \% and \_, not to % and _. " So as I understand it escaping % and _ characters should be escaped in LIKE queries, but not in exact searches because they already evaluate to strings \% and \_. I've attached a patch implementing this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 17:04:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 15:04:17 +0000 Subject: [Koha-bugs] [Bug 31565] Patron search filter by category code with special character returns no results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31565 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140636|0 |1 is obsolete| | --- Comment #3 from Lari Taskula --- Created attachment 140637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140637&action=edit Bug 31565: Fix datatables searching escape for exact search To test: 1. Add a new patron category with categorycode 'TEST_CAT' 2. Add a patron to category 'TEST_CAT' 3. Go to Patrons search view 4. Under "Search for patron" filters, filter by category you created at step 1 5. Click Search 6. Observe no results 7. Go to the cities page 8. Add two cities: - 'Cordoba %' - 'Buenos Aires _' - 'London \' 9. Use the column search on the name, alternating _, \ and % as the query => FAIL: Weird behavior 10. Apply this patch and reload 11. Repeat 9 => SUCCESS: Filtering works correctly! 12. Repeat 3-5 13. Observe expected result -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 17:04:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 15:04:28 +0000 Subject: [Koha-bugs] [Bug 31560] koha-create fails with error pwgen invalid option -- 'r' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31560 --- Comment #2 from jesus at medios.es --- I can confirm this not working on Debian 9: root at newkoha:~# lsb_release -a No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 9.13 (stretch) Release: 9.13 Codename: stretch root at newkoha:~# mysqlpwd=$(pwgen -s -y -r ":'&\\<>/" 16 1); echo $mysqlpwd pwgen: invalid option -- 'r' Usage: pwgen [ OPTIONS ] [ pw_length ] [ num_pw ] Options supported by pwgen: -c or --capitalize Include at least one capital letter in the password -A or --no-capitalize Don't include capital letters in the password -n or --numerals Include at least one number in the password -0 or --no-numerals Don't include numbers in the password -y or --symbols Include at least one special symbol in the password -s or --secure Generate completely random passwords -B or --ambiguous Don't include ambiguous characters in the password -h or --help Print a help message -H or --sha1=path/to/file[#seed] Use sha1 hash of given file as a (not so) random generator -C Print the generated passwords in columns -1 Don't print the generated passwords in columns -v or --no-vowels Do not use any vowels so as to avoid accidental nasty words root at newkoha:~# -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 17:12:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 15:12:57 +0000 Subject: [Koha-bugs] [Bug 31566] New: 'Patrons selected' counter doubles on 'Select all' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 Bug ID: 31566 Summary: 'Patrons selected' counter doubles on 'Select all' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 29971 The new 'Patrons selected' feedback introduced on bug 29971 doesn't work as expected with the 'Select all' feature.. if you click "Select all" once it counts as expected.. if you work with the checkboxes, the counter changes as expected.. if you change your mind and click 'Select all' again, the counter adds all results again, effectively doubling the count each time you click it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 [Bug 29971] Remember selections across patron search pages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 17:12:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 15:12:57 +0000 Subject: [Koha-bugs] [Bug 29971] Remember selections across patron search pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31566 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 [Bug 31566] 'Patrons selected' counter doubles on 'Select all' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 17:13:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 15:13:15 +0000 Subject: [Koha-bugs] [Bug 31566] 'Patrons selected' counter doubles on 'Select all' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 17:31:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 15:31:47 +0000 Subject: [Koha-bugs] [Bug 31565] Patron search filter by category code with special character returns no results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31565 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #4 from Lari Taskula --- I also noticed what seems to be a bit confusing behavior to me when I query cities endpoint with a "\" character as follows: (My database holds a city named "TEST \") 1. LIKE, double escape \\\\ http://myinstance/api/v1/cities?=&_page=1&_per_page=20&q=[{"me.name":{"like":"%TEST \\\\%"}}]&_match=contains&_order_by=+me.city_id Result: found 2. Exact, double escape \\\\ http://myinstance/api/v1/cities?_page=1&_per_page=20&q=[{"me.name":"TEST \\\\"}]&_match=contains&_order_by=+me.city_id Result: not found, although same syntax as above? 3. Exact, single escape \\ http://myinstance/api/v1/cities?_page=1&_per_page=20&q=[{"me.name":"TEST \\"}]&_match=contains&_order_by=+me.city_id Result: found Should we also do the "\" escaping only for LIKE searches like _ and %? If yes then the current patch must be adjusted, as it escapes \ for both types of searches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 17:38:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 15:38:21 +0000 Subject: [Koha-bugs] [Bug 31560] koha-create fails with error pwgen invalid option -- 'r' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31560 --- Comment #3 from jesus at medios.es --- Indeed, upgrading to Debian 11 fixed the problem: root at newkoha:~# cat /etc/os-release PRETTY_NAME="Debian GNU/Linux 11 (bullseye)" NAME="Debian GNU/Linux" VERSION_ID="11" VERSION="11 (bullseye)" VERSION_CODENAME=bullseye ID=debian HOME_URL="https://www.debian.org/" SUPPORT_URL="https://www.debian.org/support" BUG_REPORT_URL="https://bugs.debian.org/" root at newkoha:~# mysqlpwd=$(pwgen -s -y -r ":'&\\<>/" 16 1); echo $mysqlpwd r2@~q`SO at F8$28DD root at newkoha:~# koha-create --create-db gongora perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = "en_US:en", LC_ALL = (unset), LC_CTYPE = "UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to a fallback locale ("en_US.UTF-8"). Koha instance is empty, no staff user created. Starting Koha worker daemon for gongora (default):. Starting Koha indexing daemon for gongora:. root at newkoha:~# -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 19:33:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 17:33:34 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Michael Spagnuolo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspagnuolo at nrhtx.com --- Comment #5 from Michael Spagnuolo --- We have also run into this problem and would like to see the processing fee be able to be refunded when a lost item is returned. It would save staff some time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 19:39:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 17:39:04 +0000 Subject: [Koha-bugs] [Bug 31566] 'Patrons selected' counter doubles on 'Select all' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 19:57:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 17:57:16 +0000 Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Michael Spagnuolo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspagnuolo at nrhtx.com --- Comment #4 from Michael Spagnuolo --- Hi, I would like to see movement on this. We currently allow a three day grace period after the due date, so we would like the restriction to be removed even if a patron still has overdues. Thanks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 20:02:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 18:02:34 +0000 Subject: [Koha-bugs] [Bug 31562] Patron 'flags' don't respect unwanted fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31562 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 20:02:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 18:02:38 +0000 Subject: [Koha-bugs] [Bug 31562] Patron 'flags' don't respect unwanted fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31562 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140624|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 140638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140638&action=edit Bug 31562: Treat flags as other borrower fields Rather than generate a custom hash for these fields, we should treat them as other borrower data fields To test: 1 - Edit a patron, note the 'Lost card' and 'Gone no address' fields 2 - Edit syspref BorrowerunwantedField 3 - Set gonenoaddress and lost as unwanted 4 - Edit patron, the fields remain 5 - Apply patch 6 - Edit a patron, fields are hidden 7 - Unhide one of the fields 8 - Edit a patron and confirm it shows and saves correctly 9 - Unhide the other field 10 - Confirm it can be edited and saved Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 20:02:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 18:02:42 +0000 Subject: [Koha-bugs] [Bug 31562] Patron 'flags' don't respect unwanted fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31562 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140625|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 140639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140639&action=edit Bug 31562: Remove gonenoaddress and lost from OPAC borrower field preferences These are not shown, so cannot be unwanted or mandatory Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 20:02:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 18:02:47 +0000 Subject: [Koha-bugs] [Bug 31562] Patron 'flags' don't respect unwanted fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31562 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140626|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 140640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140640&action=edit Bug 31562: Respect mandatory fields pref To test: 1 - Set gonenoaddress and lost in BorrowerMandatoryField 2 - Edit a patron, confirm fields are required Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 20:09:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 18:09:34 +0000 Subject: [Koha-bugs] [Bug 18556] Message "Patron's address in doubt" is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 20:09:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 18:09:39 +0000 Subject: [Koha-bugs] [Bug 18556] Message "Patron's address in doubt" is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140627|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 140641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140641&action=edit Bug 18556: Clarify lost and gonenoaddress messages This patch alters the message for the patron flasg slightly, and adds a title to provide explicit info when hoevered To test: 1 - Edit a patron and set gonenoaddress and lost flags 2 - Note new info in the flags section 3 - Go to 'Checkout' or 'Details' tab for patron 4 - Confirm the messages make sense 5 - Confirm you see a tool tip when hovering on messages Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 21:06:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 19:06:27 +0000 Subject: [Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items responses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #21 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. API doc is generated, nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 21:06:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 19:06:28 +0000 Subject: [Koha-bugs] [Bug 31084] Display item type in bundle management table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31084 Bug 31084 depends on bug 29105, which changed state. Bug 29105 Summary: Add effective_item_type_id to the api items responses https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 21:06:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 19:06:28 +0000 Subject: [Koha-bugs] [Bug 31128] Add effective_not_for_loan_status to API item objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 Bug 31128 depends on bug 29105, which changed state. Bug 29105 Summary: Add effective_item_type_id to the api items responses https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 21:08:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 19:08:10 +0000 Subject: [Koha-bugs] [Bug 31144] When modifying an order we should not load the vendor default discount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |Needs documenting --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Maybe something to document. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 21:09:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 19:09:21 +0000 Subject: [Koha-bugs] [Bug 20439] SMS provider sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #14 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 21:13:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 19:13:07 +0000 Subject: [Koha-bugs] [Bug 27667] Display the number of non-indexed records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #16 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Maybe worth documenting? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 21:17:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 19:17:47 +0000 Subject: [Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #30 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 21:18:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 19:18:13 +0000 Subject: [Koha-bugs] [Bug 31163] Sort cashup history so that newest entries are first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31163 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 21:21:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 19:21:12 +0000 Subject: [Koha-bugs] [Bug 23817] Normalize phone number when searching patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #14 from David Nind --- I've tested this, and it works as per the test plan. While this works, and I probably don't appreciate the effort required to get searching the phone number to work -- I have some feedback. I'm not a fan of displaying the phone number as a number without any formatting, such as +, dashes, spaces, and brackets: - Usability: They are hard to read or verify by a human - They are displayed on transit slips (see note on the patron edit form), I think it makes it harder to read phone numbers if they are displayed as a string of numbers without formatting - It doesn't follow best practices for web forms Some ideas (but not how to code): 1. Validate the input of phone numbers, so they are entered without inputting +, dashes, spaces, brackets, etc - see this article: https://uxplanet.org/phone-number-field-design-best-practices-23957cbd86d5 2. Number stored as just a number without any formatting 3. Displayed for patron according to a format display setting (as an aside, this would work going forward, but not with existing numbers if they have been entered inconsistently) 4. As long as the number is stored without formatting, then any characters such as brackets, spaces, dashes, +, etc could be removed by JavaScript when inputting in the search box. I couldn't find an "authoritative" article about phone number and web form input, validation and display - but I didn't look very hard: - https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/tel - Maybe there is a well supported JavaScript library for resolving this, such as https://github.com/google/libphonenumber I'm sure there is a trade-off between being able to search (how the number is stored), vs how the number is displayed. Maybe sorting out the input of phone numbers as a separate bug would then make solving the search problem easier.... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 21:22:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 19:22:24 +0000 Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in alphabetical order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #27 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 21:23:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 19:23:47 +0000 Subject: [Koha-bugs] [Bug 30447] pendingreserves.pl is checking too many transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #20 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 21:23:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 19:23:47 +0000 Subject: [Koha-bugs] [Bug 31183] Add Koha::Item::Transfers->filter_by_current In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183 Bug 31183 depends on bug 30447, which changed state. Bug 30447 Summary: pendingreserves.pl is checking too many transfers https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 21:25:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 19:25:53 +0000 Subject: [Koha-bugs] [Bug 27683] Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #19 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 21:27:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 19:27:35 +0000 Subject: [Koha-bugs] [Bug 30935] Holds to pull shows wrong first patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30935 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #12 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 21:29:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 19:29:20 +0000 Subject: [Koha-bugs] [Bug 31020] PassItemMarcToXSLT only applies on results pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 21:29:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 19:29:51 +0000 Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set when creating a child patron from the adult In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net --- Comment #20 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 21:30:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 19:30:49 +0000 Subject: [Koha-bugs] [Bug 30268] When creating an order from a staged file, mandatory item subfields that are empty do not block form submission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 21:31:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 19:31:43 +0000 Subject: [Koha-bugs] [Bug 27045] Exports using CSV profiles with tab as separator don't work correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net --- Comment #25 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 21:32:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 19:32:49 +0000 Subject: [Koha-bugs] [Bug 31186] Search result numbering in OPAC got suppressed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31186 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 21:33:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 19:33:55 +0000 Subject: [Koha-bugs] [Bug 30658] (Bug 29496 follow-up) CheckMandatorySubfields don't work properly with select field in serials-edit.tt for Supplemental issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30658 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 22:43:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 20:43:24 +0000 Subject: [Koha-bugs] [Bug 27045] Exports using CSV profiles with tab as separator don't work correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045 --- Comment #26 from Katrin Fischer --- (In reply to Victor Grousset/tuxayo from comment #25) > Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. > > Nothing to document, marking resolved. It's needed, we noticed this in 20.11 :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 23:26:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 21:26:51 +0000 Subject: [Koha-bugs] [Bug 29048] Incorrect search for linked authority records from authority search result list in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29048 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 23:26:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 21:26:56 +0000 Subject: [Koha-bugs] [Bug 29048] Incorrect search for linked authority records from authority search result list in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29048 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134946|0 |1 is obsolete| | --- Comment #10 from David Nind --- Created attachment 140642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140642&action=edit Bug 29048: Fix link to linked records from authority search results in OPAC Without this patch the constructed search link would give wrong results with Elasticsearch. If you searched for records linked to authority id 3 it would also turn up all other records linked to an authority where the id started with 3... This just copies the more specific link using an,phr used in the staff interface and the OPAC detail page to make things consistent To test: - Turn on Elasticsearch - Search for authorities in the OPAC - Locate a authority with a low ID in your result list - Note the number of linked records - Click on the link - It will give you more results than it said before - Verify results don't match your search - Apply patch - Try again - now it should all match up Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 23:31:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 21:31:06 +0000 Subject: [Koha-bugs] [Bug 29048] Incorrect search for linked authority records from authority search result list in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29048 --- Comment #11 from David Nind --- I've tested and signed off (using KTD and the sample data). This on the assumption that it fixes the actual URL link in the records column (X record) on the OPAC authority search results listing page by changing it from &q=an:3 to &q=an,phr:3. Apologies if I have misunderstood what this is fixing! Testing notes ------------- 1. Both before and after patch: searching for Ritchie (authid=3) shows "1 record" in the records column in the authority search results listing page. 2. Link for '1 record' in the records column in the authority search results page BEFORE the patch is applied: http://127.0.0.1:8080/cgi-bin/koha/opac-search.pl?type=opac&op=do_search&q=an:3 3. Link for '1 record' in the records column in the authority search results page AFTER the patch is applied: http://127.0.0.1:8080/cgi-bin/koha/opac-search.pl?type=opac&op=do_search&q=an,phr:3 4. Both before and after the patch is applied: in the details page for the authority record it shows "Number of records used in: 44" 5. Both before and after the patch is applied: if I click the link in the authority search results listing page, I get 44 search results. 6. For all the above (1-5) QueryAutoTruncate was set to "automatically". 7. If QueryAutoTruncate is set to "only if * is added.", then the number of results displays as expected: 1. (I also linked the authority to another record, and this displayed as expected with 2 records.) 8. Bugs that will fix other issues: . Bug 26608 - Authorities: linked biblios is inconsistent using elasticsearch and QueryAutoTruncate . Bug 30641 - Authority detail page shows wrong number of records using the authority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 23:31:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 21:31:30 +0000 Subject: [Koha-bugs] [Bug 30641] Authority detail page shows wrong number of records using the authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30641 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 23:32:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 21:32:16 +0000 Subject: [Koha-bugs] [Bug 26608] Authorities: linked biblios is inconsistent using elasticsearch and QueryAutoTruncate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26608 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |david at davidnind.com --- Comment #4 from David Nind --- I've changed the status to "Needs Signoff" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 14 23:48:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 21:48:36 +0000 Subject: [Koha-bugs] [Bug 26608] Authorities: linked biblios is inconsistent using elasticsearch and QueryAutoTruncate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26608 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #5 from David Nind --- Patch no longer applies 8-(... Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 26608: Elasticsearch - add exact (ext) field type and use it for linked biblios Using index info to reconstruct a base tree... M Koha/Authorities.pm M Koha/SearchEngine/Elasticsearch/QueryBuilder.pm M koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt Auto-merging Koha/SearchEngine/Elasticsearch/QueryBuilder.pm CONFLICT (content): Merge conflict in Koha/SearchEngine/Elasticsearch/QueryBuilder.pm Auto-merging Koha/Authorities.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 26608: Elasticsearch - add exact (ext) field type and use it for linked biblios -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 00:09:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 22:09:31 +0000 Subject: [Koha-bugs] [Bug 31495] Allow opac-page when enforcing GDPR policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31495 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 00:09:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 22:09:38 +0000 Subject: [Koha-bugs] [Bug 31495] Allow opac-page when enforcing GDPR policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31495 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140001|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 140643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140643&action=edit Bug 31495: Allow opac-page when enforcing GDPR policy Test plan: Add some page under Additional contents. Enforce GDPR policy. Test with user that has no consent (yet or anymore). Check if you can reach additional contents with opac-page.pl. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 00:42:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 22:42:23 +0000 Subject: [Koha-bugs] [Bug 26835] Ability to remove Lost Items from Patrons Account without Checking in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26835 Michael Spagnuolo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspagnuolo at nrhtx.com --- Comment #2 from Michael Spagnuolo --- I would like to see this happen as well. Our library moved to fine free and we realized that the MarkLostItemsAsReturned preference actually returns the lost item removing the restriction from our Overdue notices. It would be great to have a way to remove items from patron's accounts without having to check-in the item. It would be even better if the process could be automated and not just added to batch item modification. Maybe a new preference to remove items marked as lost instead of returning them? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 01:35:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 23:35:33 +0000 Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 01:35:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 23:35:38 +0000 Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138454|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 140644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140644&action=edit Bug 31257: Add a new English 1 page layout to export basketgroup This patch adds a new English 1 page layout to be used when exporting a basketgroup as PDF. This has been modelled after an example PDF from another library system. To test: 1) Go to Koha Administration -> Libraries. Ensure Library A has an address, phone and fax. 2) Go to Koha Administration -> System preferences. Search for OrderPdfFormat. Set this to the new English 1-page layout option. 3) Go to Acquisitions. Use an existing vendor or create a new one. Ensure the vendor has a postal address, phone, fax and accout number. 4) Create a basket for this vendor. Add a few orders to the basket. 5) Close the basket and add it to a basket group of the same name. 6) Edit the basket group. Add an address in the delivery place, and a delivery comment. Check the box to close the basket group and Save. 7) Click the button to Export as PDF. 8) View the exported PDF. Confirm all of the information displayed is correct. 9) Reopen the basketgroup. Edit the details and remove the delivery place text. Re-close the basketgroup. 10) Repeat steps 7 and 8. Sponsored-by: Pymble Ladies' College Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 01:40:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Sep 2022 23:40:25 +0000 Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- Created attachment 140645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140645&action=edit Example PDF output - Document column is very narrow I've signed off, but noted that: 1. The Document column is very narrow and the Qty column is very wide. Could this be fixed? Have attached an example. 2. I assume there is a limit on the number of lines for address fields, otherwise it displays "funny". Also, should the WIP patch be obsoleted? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 03:02:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 01:02:16 +0000 Subject: [Koha-bugs] [Bug 23817] Normalize phone number when searching patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817 --- Comment #15 from David Cook --- Thanks for testing and the feedback, David :) One thing to note about the phone number input is that the web form isn't the only way that phone numbers are added. Patrons can be added via the "Import patrons" tool as well, so I think the ultimate phone number validation needs to be done on the backend. I think adding Javascript validation would be helpful from the UX point of view though. I was thinking a bit about formatting and we have had some discussion on the listserv (hopefully there will be more discussion there). Internationalization does make the phone number formatting tough. For instance, in Australia I think we have 4+ different phone number formats (although in practical terms only 2 would probably be used by the library) whereas back in Canada I think we only had 1 phone number format. -- Ideally, I would rather just normalize the data only when searching (like I'm doing in Koha 21.11), but the DataTables/REST API mechanism makes that seemingly impossible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 06:12:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 04:12:43 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 06:12:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 04:12:48 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128301|0 |1 is obsolete| | --- Comment #56 from Aleisha Amohia --- Created attachment 140646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140646&action=edit Bug 24194: Add ReserveExpiration system preference to disable expiration date options for reserves To test: 1) Update database 2) Go to place a hold on any biblio in the staff intranet and confirm you can see the 'Hold expires on date' field. 3) In another tab, go to place a hold on any biblio in the OPAC and confirm you can see the 'Hold not needed after' field as an option. 4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as waiting. Notice that an expiration date has now been generated for this reserve. 5) Attempt to check out the item you reserved to some other borrower. Revert waiting status. Notice that the expiration date that was generated remains. 6) Go to Administration -> system preferences and set ReserveExpiration system preference to 'Disable' 7) Refresh the hold request page in the intranet. Confirm the expiration date field disappears. 8) Refresh the hold request page in the OPAC. Confirm the expiration date field disappears. 9) Place another reserve. Check it in and set the reserve as waiting. Notice that no expiration date was generated for this reserve. 10) Attempt to check out the item you reserved to some other borrower. Revert waiting status. The expiration date should remain null. 11) Confirm tests pass t/db_dependent/Hold.t t/db_dependent/Reserves.t 12) Go to Admin -> System preferences and search for ReserveExpiration. Confirm related system preferences have a reference to ReserveExpiration and the links all work 13) Text the cancel_expired_holds.pl cronjob and confirm it works with ReserveExpiration enabled, and does nothing when disabled 14) Confirm all instances where hold expiration dates are set or referenced are shown or hidden correctly, depending on ReserveExpiration Pages in the staff interface: - Check out to a patron and check the holds tab - View patron details and check the holds tab - Patron hold history - Patron details -> Print -> Print summary - Place a hold on a title which already has at least one hold on it, check the table of existing holds. - Circulation -> Holds awaiting pickup Pages in the OPAC: - Log in to the OPAC as a patron with holds - Your summary -> Holds tab - Your holds history (OPACHoldsHistory must be enabled). Sponsored-by: Horowhenua Library Trust Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 06:12:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 04:12:54 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128308|0 |1 is obsolete| | --- Comment #57 from Aleisha Amohia --- Created attachment 140647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140647&action=edit Bug 24194: (follow-up) Throw an error if expiration date used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 06:36:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 04:36:04 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128302|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 06:36:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 04:36:14 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128303|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 06:36:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 04:36:22 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128304|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 06:36:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 04:36:33 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128305|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 06:36:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 04:36:42 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128306|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 06:36:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 04:36:53 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128307|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 06:39:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 04:39:30 +0000 Subject: [Koha-bugs] [Bug 23817] Normalize phone number when searching patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817 --- Comment #16 from David Cook --- Created attachment 140648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140648&action=edit Bug 23817: [Alternative patch] Normalize phone number only when searching This patch rewrites the phone number DBIC query when sent from DataTables like in the Patron module. Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Go to http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 2. Input '1-(234)-567-8901' into the 'Primary phone' field 3. Note on the next screen the phone number is shown as '1-(234)-567-8901' 4. Go to http://localhost:8081/cgi-bin/koha/members/members-home.pl 5. Choose "Search field" of "Primary phone" 6. Search for '12345678901' 7. Note you are taken to http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 8. Try out different permutations like '234 567 8901' or '5678901' 9. Note that every permutation works to find the borrower -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 06:40:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 04:40:02 +0000 Subject: [Koha-bugs] [Bug 23817] Normalize phone number when searching patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817 --- Comment #17 from David Cook --- (In reply to David Cook from comment #15) > Ideally, I would rather just normalize the data only when searching (like > I'm doing in Koha 21.11), but the DataTables/REST API mechanism makes that > seemingly impossible. Maybe not impossible after all... just challenging haha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 07:33:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 05:33:39 +0000 Subject: [Koha-bugs] [Bug 31560] koha-create fails with error pwgen invalid option -- 'r' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31560 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com, | |tomascohen at gmail.com --- Comment #4 from Marcel de Rooy --- Ping Tomas and Mason. Officially according to https://wiki.koha-community.org/wiki/System_requirements_and_recommendations which is linked from the 22.05 release notes, we still support Debian 9: Koha is continuously tested against the following configurations and as such these are the recommendations for deployment: Operating system: Debian 11 Debian 10 Debian 9 [etc] Although this problem is resolved under D10 and D11, we should either update the wiki and advertize that change, or resolve this as a blocker? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 07:34:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 05:34:50 +0000 Subject: [Koha-bugs] [Bug 31495] Allow opac-page when enforcing GDPR policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31495 --- Comment #4 from Marcel de Rooy --- (In reply to David Nind from comment #3) > Signed-off-by: David Nind Thx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 07:44:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 05:44:00 +0000 Subject: [Koha-bugs] [Bug 29554] neworderempty.pl may create records with biblioitems.itemtype NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554 --- Comment #10 from Marcel de Rooy --- Could you retry, David ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 07:45:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 05:45:11 +0000 Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT stylesheets over HTTPS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758 --- Comment #27 from Marcel de Rooy --- Still giving this development a few days, but I will close it if no one is interested after all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 07:47:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 05:47:55 +0000 Subject: [Koha-bugs] [Bug 30308] bulkmarcimport.pl broken by OAI-PMH:AutoUpdateSets(EmbedItemData) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.05 |22.11.00,22.05.05,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 07:48:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 05:48:19 +0000 Subject: [Koha-bugs] [Bug 30308] bulkmarcimport.pl broken by OAI-PMH:AutoUpdateSets(EmbedItemData) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 07:48:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 05:48:26 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #18 from Marcel de Rooy --- Having another look here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 08:05:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 06:05:30 +0000 Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #50 from Marcel de Rooy --- Please clean atomicupdate folder -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 09:11:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 07:11:23 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #274 from Julian Maurice --- Created attachment 140649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140649&action=edit Bug 30952: Fix spacing of nested fieldsets Issue #42 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 09:24:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 07:24:21 +0000 Subject: [Koha-bugs] [Bug 31564] Pass start label when exporting single label as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31564 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Pass start label when |Pass start label when |exporting single label as |exporting single label as |pdf |PDF -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 09:25:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 07:25:52 +0000 Subject: [Koha-bugs] [Bug 31564] Pass start label when exporting single label as PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31564 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | --- Comment #6 from Katrin Fischer --- Don't forget Assignee, Nick! :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 09:27:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 07:27:48 +0000 Subject: [Koha-bugs] [Bug 31567] New: Onboarding stuck at "Cardnumber or Userid may already exist" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31567 Bug ID: 31567 Summary: Onboarding stuck at "Cardnumber or Userid may already exist" Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I'm installing Koha 22.05.04-1 on Ubuntu 20.04.5, using the Debian packages. When I got to the "create a user" part of the onboarding I entered some made up user data and tried to save. This gave the message "The patron has not been created! Cardnumber or Userid may already exist." Tried with another cardnumber and userid, but got the same message. Checked the logs and saw this: ==> /var/log/koha/koha/intranet-error.log <== [Thu Sep 15 09:09:38.507240 2022] [cgi:error] [pid x] [client x.x.x.x:x] AH01215: {UNKNOWN}: Can't open /var/log/koha/koha/opac-error.log (Permission denied) at /usr/share/perl5/Log/Log4perl/Appender/File.pm line 151. at /usr/share/koha/lib/Koha/Patron.pm line 362: /usr/share/koha/intranet/cgi-bin/installer/onboarding.pl, referer: http://koha.example.com/cgi-bin/koha/installer/onboarding.pl Checked the permissions of the logs files: $ sudo ls -l /var/log/koha/koha/* -rw-r--r-- 1 koha-koha koha-koha 0 Sep 14 10:08 /var/log/koha/koha/indexer-error.log -rw-r--r-- 1 koha-koha koha-koha 3884632 Sep 15 08:43 /var/log/koha/koha/indexer-output.log -rw-r--r-- 1 root root 259998 Sep 15 09:09 /var/log/koha/koha/intranet-error.log -rw-r--r-- 1 root root 5465262 Sep 14 16:33 /var/log/koha/koha/opac-error.log -rw-rw-r-- 1 koha-koha koha-koha 0 Sep 15 06:25 /var/log/koha/koha/plack-api-error.log -rw-rw-r-- 1 koha-koha koha-koha 0 Sep 15 06:25 /var/log/koha/koha/plack-intranet-error.log -rw-rw-r-- 1 koha-koha koha-koha 0 Sep 15 06:25 /var/log/koha/koha/plack-opac-error.log -rw-rw-r-- 1 koha-koha koha-koha 0 Sep 15 06:25 /var/log/koha/koha/sip.log -rw-r--r-- 1 koha-koha koha-koha 0 Sep 14 10:08 /var/log/koha/koha/worker-error.log -rw-r--r-- 1 koha-koha koha-koha 258 Sep 14 10:08 /var/log/koha/koha/worker-output.log -rw-rw-r-- 1 koha-koha koha-koha 0 Sep 15 06:25 /var/log/koha/koha/z3950-error.log -rw-r--r-- 1 koha-koha koha-koha 0 Sep 14 10:08 /var/log/koha/koha/zebra-error.log -rw-r--r-- 1 koha-koha koha-koha 0 Sep 14 10:08 /var/log/koha/koha/zebra-output.log Changed the ownership of all logs: $ sudo chown koha-koha:koha-koha /var/log/koha/koha/* And now I could add the patron without any problems. Two problems here: - The ownership of the logs - The error message pointing in the wrong direction -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 09:28:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 07:28:19 +0000 Subject: [Koha-bugs] [Bug 31565] Patron search filter by category code with special character returns no results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31565 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #5 from Katrin Fischer --- Hi Lari, be careful with the In Discussion as this makes it drop from the queues people look at the most. The status is normally only used when we have a disagreement to solve. Maybe reach out to people you want to have a look here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 09:30:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 07:30:11 +0000 Subject: [Koha-bugs] [Bug 31567] Onboarding stuck at "Cardnumber or Userid may already exist" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31567 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 09:31:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 07:31:25 +0000 Subject: [Koha-bugs] [Bug 29105] Add effective_item_type_id to the API items responses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add effective_item_type_id |Add effective_item_type_id |to the api items responses |to the API items responses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 10:34:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 08:34:08 +0000 Subject: [Koha-bugs] [Bug 29554] neworderempty.pl may create records with biblioitems.itemtype NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from David Nind --- After applying the patch (and regardless of whether item-level_itypes is set to specific item or bibliographic record) I am getting this error when adding to a basket from a new (empty) record: Template process failed: undef error - The method Koha::ItemTypes->itemtype is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Objects.pm line 572 Koha::Objects::AUTOLOAD('Koha::ItemTypes=HASH(0x55b3275f1d40)') called at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt line 242 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt line 242 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt line 250 eval {...} at /kohadevbox/koha/ ... I have cleared the browser cache, plus a flush_memcached and restart_all (using KTD). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 10:36:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 08:36:48 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #275 from Julian Maurice --- Created attachment 140650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140650&action=edit Bug 30952: Fix positioning of fieldset's elements below a legend Issue #41 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 10:43:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 08:43:23 +0000 Subject: [Koha-bugs] [Bug 31568] New: Renaming/removing an authorised value does not cascade to linked tables Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31568 Bug ID: 31568 Summary: Renaming/removing an authorised value does not cascade to linked tables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We could give lots of examples here. E.g. location is controlled by category LOC having a value like CHILD. If you rename it to CHILDREN, your items still contain the old value. This cannot be solved with a FK since an authorised value may be in use under several AV categories. Maybe there are cases where you do not want to have an AV immediately cascade the change in a linked table? Also note that we have a maintenance script looking for these inconsistencies (bug 21466), but if we could reduce the volume here, I wouldnt mind. How should we best address this need? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 10:45:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 08:45:45 +0000 Subject: [Koha-bugs] [Bug 31568] Renaming/removing an authorised value does not cascade to linked tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31568 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com --- Comment #1 from Marcel de Rooy --- Feedback welcome -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 10:46:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 08:46:00 +0000 Subject: [Koha-bugs] [Bug 31568] Renaming/removing an authorised value does not cascade to linked tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31568 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21466 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 10:46:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 08:46:00 +0000 Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked to AV cat values must have a corresponding authorised value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31568 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 10:50:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 08:50:09 +0000 Subject: [Koha-bugs] [Bug 6175] Mismatch between auth_subfield_structure and authorised_values data type - varchar(32) vs. varchar(10) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6175 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #9 from Marcel de Rooy --- Bug 29336 db_revs/211200009.pl: q|ALTER TABLE auth_subfield_structure CHANGE authorised_value authorised_value varchar(32) COLLATE utf8mb4_unicode_ci DEFAULT NULL|, Closing this one *** This bug has been marked as a duplicate of bug 29336 *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 10:50:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 08:50:09 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |conan at lugmen.org.ar --- Comment #35 from Marcel de Rooy --- *** Bug 6175 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 10:52:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 08:52:58 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #276 from Julian Maurice --- Created attachment 140651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140651&action=edit Bug 30952: Fix facets block display Issue #40 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 15 11:02:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Sep 2022 09:02:03 +0000 Subject: [Koha-bugs] [Bug 20682] Authorised values should have an option to set a default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20682 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #1 from Marcel de Rooy --- (In reply to Hugh Rundle from comment #0) > There are many places in Koha where values can be chosen via a drop-down > menu listing a particular authorised value. For example SUGGEST_FORMAT is > used to populate the list of formats that can be selected when placing a > purchase suggestion. Currently these lists appear in alphabetical order by > description or OPAC description (depending on context), and the first option > in the list is usually auto-selected (i.e. more or less default behaviour > for a vanilla HTML [etc] OR Without patch : the subfield is empty, it should have the value from drop-down menu. => With patch : the subfield is saved with the value from drop-down menu. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 15:52:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 13:52:48 +0000 Subject: [Koha-bugs] [Bug 30515] Move Overdue transports to patron messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org --- Comment #5 from Andrew Fuerste-Henry --- (In reply to Joy Nelson from comment #4) > Katrin, and all other interested parties! > We have written the following brief proposal below. This proposal provides > an option for libraries to allow patrons to select preferences for their > overdue messages. We are looking to balance the patron's ability to set a > preference with the library's ability to control messaging related to > overdues. > > We appreciate everyone's feedback on this proposal: > > > Add two checkboxes to each transport type in the Overdue Triggers matrix. > 1. Enabled: Will the library send a notice in this transport type? > 2. Mandatory: When checked, this transport is the way that this message > is sent. (multiple transport types can be selected) Patron preferences will > be ignored in favor of the transport the library has indicated as mandatory. > > Add matrix of Overdue Message Preferences in the Patron Message Preference > screen. The matrix will contain the 3 Overdue messages (odue1,odue2,odue3) > and patrons will be able to indicate their preferences for receiving these > messages. This matrix will appear on opac and staff side depending on > EnhancedMessage System Preference. > > Add an additional System preference to control whether patron can edit the > Overdue messaging preferences. > If enabled -- Show a BOLD message that they can choose their preferences > but library policies may override their choice (see Mandatory above) > Patrons will be forced to select at least one transport type. > If disabled -- Show a read only matrix of the patron's libraries (or > default) transport types that are set in Overdue triggers and a note that > other library policies may override the patron's libraries settings. This sounds like a good balance of flexibility and control! +1 and then +1 again for good measure :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 16:11:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 14:11:55 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139277|0 |1 is obsolete| | --- Comment #140 from Shi Yao Wang --- Created attachment 141157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141157&action=edit Bug 17385: Add custom export XSLT Rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 16:12:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 14:12:02 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139278|0 |1 is obsolete| | --- Comment #141 from Shi Yao Wang --- Created attachment 141158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141158&action=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 16:12:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 14:12:09 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139279|0 |1 is obsolete| | --- Comment #142 from Shi Yao Wang --- Created attachment 141159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141159&action=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 16:12:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 14:12:16 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139280|0 |1 is obsolete| | --- Comment #143 from Shi Yao Wang --- Created attachment 141160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141160&action=edit Bug 17385: Add tests for CustomXSLTExportList Tests are now in one patch. One test does not pass and I am not able to fix it. The test who fails :
    $ prove -l t/db_dependent/XSLT.t
    t/db_dependent/XSLT.t .. 1/3
        #   Failed test 'This list comes from the cache and that is fine'
        #   at t/db_dependent/XSLT.t line 122.
        #          got: '1'
        #     expected: '2'
        # Looks like you failed 1 test of 1.
    
     #   Failed test 'CustomXSLTExportList: Caching'
     #   at t/db_dependent/XSLT.t line 124.
     # Looks like you failed 1 test of 3.
    t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100)
    Failed 1/3 subtests
    
    Test Summary Report
    -------------------
    t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1)
      Failed test:  2
      Non-zero exit status: 1
    Files=1, Tests=3,  3 wallclock secs ( 0.03 usr  0.00 sys +  1.74 cusr  0.14
    csys =  1.91 CPU)
    Result: FAIL
    
    This one works fine :
    $ prove -l t/XSLT.t
    t/XSLT.t .. ok
    All tests successful.
    Files=1, Tests=12,  4 wallclock secs ( 0.02 usr  0.00 sys +  2.55 cusr  0.17
    csys =  2.74 CPU)
    Result: PASS
    
    -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 16:12:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 14:12:22 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139281|0 |1 is obsolete| | --- Comment #144 from Shi Yao Wang --- Created attachment 141161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141161&action=edit Bug 17385: Add custum export format option when saving a record This patch adds "XSL-Simple Export" when saving a bibliographic record. Previous patches are combined into this one. To test: 1) Search for a record in the intranet. 2) Click on the "Save" button and observe the dropdown menu. 3) Notice that "XSL- Simple Export" is not in the menu. 4) Apply the patch. 5) Repeat the steps 1 and 2. 6) Notice that "XSL - Simple Export" is in the menu. 7) Click on "XSL - Simple Export". A .html file should be downloaded. 8) Open the .html file. You should see the record's informations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 16:12:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 14:12:31 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139282|0 |1 is obsolete| | --- Comment #145 from Shi Yao Wang --- Created attachment 141162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141162&action=edit Bug 17385: Correction of opac-detail-sidebar.inc This patch reverts the changes made in opac-detail-sidebar.inc, so the sidebar is displayed as wanted. Tests are now passing properly. TEST PLAN: 1- Apply the patch and search for a record in the OPAC. 2- Click on "Save record". Notice that the dropdown menu is unchanged. 3- Run t/db_dependent/XSLT.t (All tests should pass) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 16:12:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 14:12:38 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139283|0 |1 is obsolete| | --- Comment #146 from Shi Yao Wang --- Created attachment 141163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141163&action=edit Bug 17385: Fixing display for XSL-Simple Export in OPAC This attachment correct the placement of XSL-Simple Export in the OPAC's page. It is now displayed in the "Save record" dropdown menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 16:12:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 14:12:45 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139284|0 |1 is obsolete| | --- Comment #147 from Shi Yao Wang --- Created attachment 141164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141164&action=edit Bug 17385: Add missing imports and equivalent code for GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 16:15:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 14:15:14 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136755|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 141165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141165&action=edit Bug 29987: Add register support to manual credits This patch adds the register and transaction type selection options to the manual credit page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 16:15:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 14:15:19 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139704|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 141166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141166&action=edit Bug 29987: (follow-up) Fix missing payment type The payment type include has changed since the patch was first written, we now require a 'type' is passed to properly set the field name. This should fix the 'bankable' issue raised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 16:15:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 14:15:23 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139705|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 141167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141167&action=edit Bug 29987: Display credit without offsets in transactions This patch adds a row to the transactions table for credits without corresponding offsets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 16:15:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 14:15:46 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #22 from Martin Renvoize --- Just a quick rebase and now testing on a sandbox.. I can't replicate any of your issues locally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 16:17:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 14:17:36 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138029|0 |1 is obsolete| | --- Comment #45 from Shi Yao Wang --- Created attachment 141168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141168&action=edit Bug 11300: Add a new authority linker which searches for authority links on a Z39.50 server. This patch adds a Z39.50 Linker which searches for authority links on a remote server. If a matching authority is found, it's imported in the local database for linking with the current biblio record. If no matching authority was found on the remote server, the Linker falls back to a local authority search. Configuration : * The option "Z39.50 Server" is added to the LinkerModule preference. You must choose this to use the new Linker. * The preference LinkerZ3950Server is required and specifies which server to use for linking. It must contain the "name" of the server, as defined in the z3950servers table. * You can set the "local_first" option in the LinkerOptions preference to force the Linker to search for authorities in the local database first. If no local authority match was found, the Linker falls back to a remote Z39.50 search. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 16:26:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 14:26:18 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #23 from Martin Renvoize --- (In reply to pascal.uphaus from comment #16) > I applied the patches and did the testplan described in the first comment. > The register_id was still NULL. Is the testplan still up-to-date? Did you select a register at the point of adding a manual credit.. there is a select box and you can opt to not select anything by default (There's a setting that makes the register required, but that's disabled by default and so not enabled on the sandboxes) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 16:29:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 14:29:04 +0000 Subject: [Koha-bugs] [Bug 28396] Call number browse pagination In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28396 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141065|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes --- Created attachment 141169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141169&action=edit Bug 28396: Add dataTable to cn_browser To test: 1. Have a bunch of similar or exactly the same call numbers. I updated all mine to '123abc'. 2. Set up the cn_browser.pl plugin for some frameworks, I am usiong the default one. 3. Go to '/cgi-bin/koha/cataloguing/plugin_launcher.pl?q=123abc&plugin_name=cn_browser.pl' and search for the call number '123abc'. 4. You will see 15 results and have no way of seeing any more. 5. Apply patch, restart_all 6. Perform the search again. You should see all your results in a paginated dataTable. Signed-off-by: Donna -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 16:30:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 14:30:06 +0000 Subject: [Koha-bugs] [Bug 28396] Call number browse pagination In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28396 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Donna --- Works as expected, helpful addition!!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 16:41:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 14:41:07 +0000 Subject: [Koha-bugs] [Bug 31628] Sorting patron search results by library does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31628 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 16:55:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 14:55:23 +0000 Subject: [Koha-bugs] [Bug 31643] Link authorities automatically requires ALL cataloging and authorities permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31643 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141067|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 141170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141170&action=edit Bug 31643: Require only edit_catalogue, not full cataloging To test: 1 - Grant a patron: catalogue, edit_catalogue, and editauthorities permissions 2 - Log in to staff client 3 - Browse to: http://localhost:8081/cgi-bin/koha/svc/cataloguing/automatic_linker.pl 4 - UNAUTHORIZED 5 - Apply patch, restart all 6 - Log in and go to link again 7 - status "OK" Signed-off-by: Catrina -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 16:56:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 14:56:06 +0000 Subject: [Koha-bugs] [Bug 31643] Link authorities automatically requires ALL cataloging and authorities permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31643 Catrina Berka changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina at bywatersolutions.co | |m Status|Needs Signoff |Signed Off --- Comment #3 from Catrina Berka --- Works as expected. Allows for Linking authorities in record editing with those staff permissions set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 17:07:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 15:07:42 +0000 Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #24 from Martin Renvoize --- Created attachment 141171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141171&action=edit Bug 29987: Improve validation This patch adds hinting to display the required state of the cash register fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 17:12:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 15:12:24 +0000 Subject: [Koha-bugs] [Bug 31665] New: 952$d ( Date acquired ) no longer prefills with todays date when focused Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Bug ID: 31665 Summary: 952$d ( Date acquired ) no longer prefills with todays date when focused Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Before the introduction of Flatpickr, when adding a new item if you clicked on the date acquired field, and it was empty, it would be prefilled with today's date. It would be useful if we could get that functionality back. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 17:34:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 15:34:25 +0000 Subject: [Koha-bugs] [Bug 31329] Add ability to block all linked accounts when one account has been restricted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31329 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #2 from Barbara Johnson --- +1 Our library handles blocks for linked accounts in the same way as Wally's library. It takes a lot of staff time to manually block all of the associated accounts. Staff generally also adds notes to each account so that anyone assisting a patron can understand why the accounts are blocked. Having this functionality would save so much staff time and reduce errors. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 17:49:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 15:49:39 +0000 Subject: [Koha-bugs] [Bug 23565] Add columns configuration and export options to item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23565 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com | |, | |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 19:12:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 17:12:47 +0000 Subject: [Koha-bugs] [Bug 31666] New: Add job progress bar to stage-marc-import.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 Bug ID: 31666 Summary: Add job progress bar to stage-marc-import.pl Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It would be nice if we had progress bars to indicate the progress of background jobs for scripts that utilize them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 19:15:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 17:15:12 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 19:15:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 17:15:16 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 --- Comment #1 from Kyle M Hall --- Created attachment 141172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141172&action=edit Bug 31666: Add job progress bar to stage-marc-import.pl It would be nice if we had progress bars to indicate the progress of background jobs for scripts that utilize them. This patch implements a reusable bootstrap based progess bar. Test Plan: 1) Apply this patch 2) Stage a marc batch ( preferrably a large one to show the progress updating ) 3) Note the new progess bar, verify it functions correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 19:21:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 17:21:26 +0000 Subject: [Koha-bugs] [Bug 31630] Batch item deletion no longer shows which items were not removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31630 LeeAnn Nilsson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lnilsson at lewistonschools.ne | |t Depends on| |28353 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 [Bug 28353] Regression: Batch item deletion no longer shows which items were not removed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 19:21:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 17:21:26 +0000 Subject: [Koha-bugs] [Bug 28353] Regression: Batch item deletion no longer shows which items were not removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 LeeAnn Nilsson changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31630 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31630 [Bug 31630] Batch item deletion no longer shows which items were not removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 19:26:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 17:26:28 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141172|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 141173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141173&action=edit Bug 31666: Add job progress bar to stage-marc-import.pl It would be nice if we had progress bars to indicate the progress of background jobs for scripts that utilize them. This patch implements a reusable bootstrap based progess bar. Test Plan: 1) Apply this patch 2) Stage a marc batch ( preferrably a large one to show the progress updating ) 3) Note the new progess bar, verify it functions correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 19:26:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 17:26:38 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 19:29:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 17:29:26 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 19:29:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 17:29:32 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30982 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 [Bug 30982] Use the REST API for background job list view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 19:29:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 17:29:32 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31666 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 [Bug 31666] Add job progress bar to stage-marc-import.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 19:37:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 17:37:31 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141173|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 141174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141174&action=edit Bug 31666: Add job progress bar to stage-marc-import.pl It would be nice if we had progress bars to indicate the progress of background jobs for scripts that utilize them. This patch implements a reusable bootstrap based progess bar. Test Plan: 1) Apply this patch 2) Stage a marc batch ( preferrably a large one to show the progress updating ) 3) Note the new progess bar, verify it functions correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 19:55:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 17:55:56 +0000 Subject: [Koha-bugs] [Bug 31646] Focus input by default when clicking on a dropdown field in the cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31646 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 19:56:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 17:56:00 +0000 Subject: [Koha-bugs] [Bug 31646] Focus input by default when clicking on a dropdown field in the cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31646 --- Comment #4 from Lucas Gass --- Created attachment 141175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141175&action=edit Bug 31646: Add Select2 focus to text search field To test: 1. Edit a biblio record 2. Go to tab 9 to find the item type MARC field 942$c 3. Click on the field to select an item type 4. Notice you have to click again on the search field to begin typing to search for your item type 5. Apply patch/clear browser cache 6. Try steps 2-3 again, the focus should now be on the search text field 7. Try another select2 dropdown on the same page like the 942$n ( Suppress in OPAC ), it should also default to the text search field. 8. Try other places in Koha that feature this kind of select2, like when placing hold. Note: Using $(document).on here instead of $(".select2").on becuase there are several instances where there are more than 1 select2 dropdown on a single page. This allows for the text search field to default each time you click on a different dropdown. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 20:00:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 18:00:12 +0000 Subject: [Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #29 from David Nind --- The patch no longer applies 8-(.. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 31503: Adjust db column patron_consent.type Applying: Bug 31503: Add $patron->consent Using index info to reconstruct a base tree... M Koha/Patron.pm M t/db_dependent/Koha/Patron.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Patron.t CONFLICT (content): Merge conflict in t/db_dependent/Koha/Patron.t Auto-merging Koha/Patron.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 31503: Add $patron->consent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 20:21:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 18:21:45 +0000 Subject: [Koha-bugs] [Bug 30669] [DOCS] [Omnibus] Sentence case for headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30669 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|david at davidnind.com |katrin.fischer at bsz-bw.de Status|ASSIGNED |Needs Signoff --- Comment #1 from Katrin Fischer --- I went through all the chapters, hope I didn't miss any: https://gitlab.com/koha-community/koha-manual/-/merge_requests/590 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 20:33:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 18:33:41 +0000 Subject: [Koha-bugs] [Bug 25719] Add system preference for logged in patrons to display only the patron's first name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25719 Mwoo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mary.woodward at bedfordtx.gov --- Comment #2 from Mwoo --- Agreed. Keeping patron's privacy is most important. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 21:44:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 19:44:57 +0000 Subject: [Koha-bugs] [Bug 31657] [DOCS] [Omnibus] Fix the cause of duplicate label warning messages when generating the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31657 --- Comment #4 from Katrin Fischer --- I am working on patches for this, hope to have something to show soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 21:53:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 19:53:13 +0000 Subject: [Koha-bugs] [Bug 31657] [DOCS] [Omnibus] Fix the cause of duplicate label warning messages when generating the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31657 --- Comment #5 from David Nind --- Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 22:00:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 20:00:58 +0000 Subject: [Koha-bugs] [Bug 30669] [DOCS] [Omnibus] Sentence case for headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30669 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs Signoff |RESOLVED --- Comment #2 from David Nind --- Thanks Katrin! It's great to have all of these done. Any we've missed can be fixed in a follow-up. David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 22:00:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 20:00:58 +0000 Subject: [Koha-bugs] [Bug 30670] [DOCS] Sentence case for headings - searching chapter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30670 Bug 30670 depends on bug 30669, which changed state. Bug 30669 Summary: [DOCS] [Omnibus] Sentence case for headings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30669 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 22:04:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 20:04:19 +0000 Subject: [Koha-bugs] [Bug 31630] Batch item deletion no longer shows which items were not removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31630 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 22:19:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 20:19:15 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #315 from Maryse Simard --- Created attachment 141176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141176&action=edit Bug 17015: Use branchcode when adding or modifying a holiday -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 22:22:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 20:22:02 +0000 Subject: [Koha-bugs] [Bug 31657] [DOCS] [Omnibus] Fix the cause of duplicate label warning messages when generating the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31657 --- Comment #6 from Katrin Fischer --- First patch up: https://gitlab.com/koha-community/koha-manual/-/merge_requests/591 It did seem to work ok when I created the html files locally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 22:22:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 20:22:20 +0000 Subject: [Koha-bugs] [Bug 31657] [DOCS] [Omnibus] Fix the cause of duplicate label warning messages when generating the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31657 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|david at davidnind.com |katrin.fischer at bsz-bw.de QA Contact|testopia at bugs.koha-communit |david at davidnind.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 22:38:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 20:38:28 +0000 Subject: [Koha-bugs] [Bug 31329] Add ability to block all linked accounts when one account has been restricted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31329 Mwoo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mary.woodward at bedfordtx.gov --- Comment #3 from Mwoo --- Please please please implement this. Staff often forget to unblock link accounts which can upset patrons trying to check out materials or trying to use our electronic resources. This would be very helpful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 23:25:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 21:25:02 +0000 Subject: [Koha-bugs] [Bug 10984] Cannot cancel received order if the parent order is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10984 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 30 23:35:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Sep 2022 21:35:04 +0000 Subject: [Koha-bugs] [Bug 31657] [DOCS] [Omnibus] Fix the cause of duplicate label warning messages when generating the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31657 --- Comment #7 from Caroline Cyr La Rose --- A note to remember that we'll have to change the rst syntax cheatsheet on the wiki -- You are receiving this mail because: You are watching all bug changes.