[Koha-bugs] [Bug 31470] Incorrect selector for relationship dropdown used in members.js

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470

--- Comment #5 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
(In reply to Lucas Gass from comment #4)
> This highlights another problem. If relationship is going to a class in
> memberentry.pl then something must be done about its label:
> 
> <label for="relationship">Relationship: </label>
> 
> The value of the for attribute of the label element must be the ID, not a
> class.

Hmm, you're right. So either we change ID from auth-finder-search.inc as
something like "special_relationship" to avoid conflicts and change
relationship in memberentry from class to ID. Or we add new ID to memberentry
(e.g. non_patron_relationship). Latter is probably preferable solution. And we
could use that ID in members.js instead of class relationship (which at
hindsight could cause problems in future). 

And looking at this more closely, we have this same problem with other label as
well:

<label for="guarantor_relationship">Relationship: </label>
<select class="new_guarantor_relationship" name="new_guarantor_relationship">

-- 
You are receiving this mail because:
You are watching all bug changes.