[Koha-bugs] [Bug 31364] Saving preferences with a dropdown with check boxes doesn't save in the case where all the checks are removed.

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31364

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #5 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Adds a comma in the end of the syspref list due to it sending an empty sysref
value in addition to filled ones in the query string:

> MariaDB [koha_kohadev]> select * from systempreferences where variable = "OPACHoldsIfAvailableAtPickupExceptions"\G
> *************************** 1. row ***************************
>    variable: OPACHoldsIfAvailableAtPickupExceptions
>       value: B,HB,
>     options: 
> explanation: List the patron categories not affected by OPACHoldsIfAvailableAtPickup if off
>        type: Free

Since the sysref object value is an array we can just check instead whether the
array is empty. Will send a patch shortly

-- 
You are receiving this mail because:
You are watching all bug changes.