[Koha-bugs] [Bug 31364] Saving preferences with a dropdown with check boxes doesn't save in the case where all the checks are removed.

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31364

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140201|0                           |1
        is obsolete|                            |

--- Comment #7 from David Nind <david at davidnind.com> ---
Created attachment 140220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140220&action=edit
Bug 31364: Check length of the multiple syspref array instead whether it is
null

The multiple systempreferences are always defined as an empty array at
the minimum, so in order to determine whether we need to remove all
the selections from the systempreference we should check whether the
array is empty and not whether the array doesn't exist.

To test:
 1) Set at least 1 value for OPACHoldsIfAvailableAtPickupExceptions
 2) Remove all the values for OPACHoldsIfAvailableAtPickupExceptions
 and notice you get the message "Nothing to save"
 3) Apply patch and repeat, removing all the values should work now.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.