[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

--- Comment #107 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 137716
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137716
Bug 3150: Move emails for sending cart and list contents to notices

Review of attachment 137716:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=3150&attachment=137716)
-----------------------------------------------------------------

::: basket/sendbasket.pl
@@ +101,5 @@
> +        my $user_email = $patron->first_valid_email_address || C4::Context->preference('KohaAdminEmailAddress');
> +        C4::Letters::EnqueueLetter({
> +            letter => $letter,
> +            message_transport_type => 'email',
> +            borrowernumber => $patron->borrowernumber,

I'm not sure we should be setting borrowernumber here.. it's somewhat
misleading as the notice will appear as being sent to this borrower under their
notices.. we don't really have the directionality in the UI to clearly show if
a message was inbound or outbound so I don't know that it should be tied to the
user here.

-- 
You are receiving this mail because:
You are watching all bug changes.