[Koha-bugs] [Bug 31351] Worker dies on reindex job when operator last name/first name/branch name contains non-ASCII chars

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

--- Comment #34 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #33)
> (In reply to Tomás Cohen Arazi from comment #32)
> > FTR: the JSON::encode_json and JSON::decode_json methods deal with UTF-8 [1]
> > and I'm not sure why there's a ->utf8(0) being set.
> > 
> > Overall, I think we should go the bug 30943 path. Take UpdateElasticIndex
> > (as tweaked by bug 30360) as a reference.
> 
> Please check the comments earlier. We should not do the UTF8 conversion in
> the middle of the process but when storing only.
> The uf8(0) is just a confirmation of using this default from the JSON OO
> object. To make it explicit.
> 
> There were inconsistencies in the codebase that are addressed here. I would
> recommend going further here. Moving to the helpers is fine of course.

Ok, I'll take a look again. I loved the added tests the most.

-- 
You are receiving this mail because:
You are watching all bug changes.