[Koha-bugs] [Bug 30926] Remove unnecessary use statements

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30926

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #14 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Did some testing, even though this doesn't currently apply on top of master.
However seems like the script might be a bit too eager with the removals:

> Compilation failed in require at /kohadevbox/koha/Koha/ItemTypes.pm line 23.

I get this among other failures. In ItemTypes.pm C4::Languages is used but this
patch removed the use statement. After this patch has been made there has been
no changes to ItemTypes.pm so I think it is indeed an issue with the script
that generates this patch.

Another corner case not handled by the script:

C4/SIP/SIPServer.pm:

C4::SIP::Trapper import is used by the tie *STDERR, "C4::SIP::Trapper";
statement.

-- 
You are receiving this mail because:
You are watching all bug changes.