[Koha-bugs] [Bug 17015] New Koha Calendar

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi
             Status|Needs Signoff               |Failed QA

--- Comment #308 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Hi,

could you please split the patch "Bug 17015: DiscreteCalendar UI, Back-End and
necessary scripts" to as many patches are there are logical changes. For
example, one patch introducing this new Calendar class, along with its unit
tests, and a reason for introducing this new class. The another patch for
adding scripts to populate this new calendar system. Third patch to convert
existing code to use the new Calendar system, and so forth. Please see this
wikipedia article for more info:
<https://en.wikipedia.org/wiki/Atomic_commit#Atomic_commit_convention>.

Redoing the patches should also fix up the most pressing issue at the moment
with this patch set that is preventing a review: there is no clear description
in each patch what they are doing, there appears to be many descriptions
combined from multiple squashed patches. Writing good descriptions saves a lot
of time from the reviewers and helps to get this problem fixed faster as the
reviewers can point out any design flaws without reading the code, just based
on the patch descriptions.

-- 
You are receiving this mail because:
You are watching all bug changes.