[Koha-bugs] [Bug 20558] typo mts_authorized_value vs mts_authorised_value in admin/marctagstructure.pl

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Sep 15 11:30:26 CEST 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20558

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #0)
> What are the consequences of this?

There are no consequences. This is dead code.

There are several issues here:
[1] We should not allow to edit an authorised value to a field higher than 010
in MARC21. That make no sense !
[2] The template does not make a distinction between control fields lower than
010 and other ones.
Look e.g. here:
<span>Tab:[% subfield.tab | html %]</span> | $[% subfield.tagsubfield | html %]
[% subfield.liblibrarian | html %] [% IF ( subfield.kohafield ) %][%
subfield.kohafield | html %][% END %][% IF ( subfield.repeatable ) %],
<span>repeatable</span>[% END %][% IF ( subfield.mandatory ) %],
<span>Mandatory</span>[% END %][% IF ( subfield.seealso ) %], <span>See [%
subfield.seealso | html %]</span>[% END %][% IF ( subfield.authorised_value )
%], [% subfield.authorised_value | html %][% END %][% IF (
subfield.authtypecode ) %], [% subfield.authtypecode | html %][% END %][% IF (
subfield.value_builder ) %], [% subfield.value_builder | html %][% END %]

If a subfield has an AV it is listed, but if a controlfield<10 has one, it is
not listed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list