[Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup locations are available

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137643|0                           |1
        is obsolete|                            |

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 140683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140683&action=edit
Bug 30687: Override hold policy when no valid pickup location

This patch allows hold policy to be overridden when there is no valid
pickup location and AllowHoldPolicyOverride is enabled. This is
re-implementing old behaviour that has been lost.

To test:

1. Go to Administration -> Circulation and fines rules. Ensure there is
a default circulation rule and default reserves policy.
2. Change the library using the dropdown and scroll to the bottom of the
page to set a reserves policy by item type for Library A, which the
following settings:
- Item type: BK
- Reserve policy: From home library
- Reserve pickup library match: any library
- Return policy: Item returns home
3. Go to Administration -> system preferences. Set the
AllowHoldPolicyOverride setting to Allow.
4. Create a biblio with an item where the item's home library is Library
A and the itemtype is BK.
5. Log in to the staff client as a Patron that belongs to Library B.
6. Search for the biblio you just created and try to request a hold for
yourself. Notice there is a blocking notice "Cannot place reserve", the
"Place reserve" button is disabled, and the item has a "No valid pickup
location" error.
7. Apply the patch and refresh the page or re-request the hold.
8. Confirm you can now place the hold, acknowledging that you must
override hold policy to do so (note the exclamation point icon).
9. Set the AllowHoldPolicyOverride system preference to "Don't allow".
10. Repeat Step 6. Confirm you are blocked again from requesting the
hold and cannot override it.

Sponsored-by: Chartered Accountants Australia and New Zealand

Signed-off-by: Daniel <daniel.jones at cheshiresharedservices.gov.uk>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.