[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033

--- Comment #13 from David Cook <dcook at prosentient.com.au> ---
(In reply to Kyle M Hall from comment #11)
> I have no idea what's going on, but in production this is breaking SIP!
> No errors in the logs.
> Is anyone else experiencing this?

I had an issue with SIP today although it wasn't the max_servers. It was that
min_spare_servers was set to 0. 

(In reply to David Cook from comment #1)
> Looking at the "server-params" in the SIPconfig.xml file, it looks like
> min_servers = 1 and min_spare_servers = 0. In theory, 0 should be fine
> because that should just means 0 spare servers...
> 
> When I change min_spare_servers to = 1, the forking seems to work correctly.
> If there are no current connections, then there is only 1 child process. If
> there are current connections, then it keeps 1 extra connection around. 
> 
> I'd say it's a bug/quirk in Net::Server::PreFork which powers the SIP
> server. 
> 
> Since it looks like the SIP server has accidentally been using a max of 1
> child process, we should probably set some limits on maximums since the
> default max server is 50. The default max spare servers is 10...

The real issue is min_spare_servers...

I think my intention here was that min_servers='1' and min_spare_servers='0'
implies a max_servers='1'.

But if you change max_servers='10', it won't make a difference until you change
"min-spare_servers" to at least 1.

-- 
You are receiving this mail because:
You are watching all bug changes.