[Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am worried by the scope of this one. The changes to every plugin disqualifies
this patch for backporting, especially because of the breaking changes:

> This patch also comes with a bit of cleanup, and introduce "breaking
> changes" (they are breaking changes only if you happen to have custom
> framework plugins):
> 1) Only 'click', 'focus' and 'blur' events are listened to now. They are
>    the only ones we use, and the only ones we actually need.
>    Events removed: change, mouseover, mouseout, mousedown, mouseup,
>    mousemove, keydown, keypress, keyup.
>    If you ever need one of those, you can still add event listeners in
>    the 'focus' event handler, and remove them in the 'blur' event
>    handler
> 2) Event handlers now takes a single parameter that is an Event object
>    It just makes the code a lot less complicated. All framework plugins
>    have been updated
> 3) Event handlers do not pollute the global scope anymore

We do have those custom framework plugins and I know other libraries do as
well.

Also not sure about removing events - some libraires may have used them and is
there a strong reason to remove?

Could we imagine a less invasive fix to the problem, that could also be applied
to stable releases?

-- 
You are receiving this mail because:
You are watching all bug changes.