[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

--- Comment #42 from David Gustafsson <glasklas at gmail.com> ---
(In reply to Martin Renvoize from comment #38)
> Looking good so far.. a couple of comments
> 
> We have a fairly standard 'skip_index' name for the search engine index skip
> param.. we should stick to that here too (I bet your patch pre-dates that,
> but it shouldn't be too onerous to update for consistency)
> 
> However, there's a more challenging thing to resolve.
> 
> If 'BiblioAddsAuthorities' is enabled the index skip is going to cause
> issues as the linker relies of updated indexes to do it's job... we possibly
> need to move where the BiblioAddsAuthories code runs for such cases to run
> at the end after a first run of indexing has taken place and then run a
> second index run to catch the link changes it makes?
> 
> Conundrum.

Good catch. I'm a little bit confused about the first point. I only see
skip_index being used in rebuild_zebra.pl and not really sure what it does.
bulkmarkimport.pl will always defer indexing (but only for elasticsearch) and
bulk-index for each batch. There is not option to disable this as there is no
apparent downside not to do this.

The second issue should now be fixed, it turned out to be pretty
straightforward as only needed to add the option to skip linking for AddBiblio
(the option was already present in ModBiblio), and then run BiblioAutoLink on
all records in the batch after indexing them successfully (if I'm not missing
anything).

The patch is still not rebased but will now have a look at that.

-- 
You are receiving this mail because:
You are watching all bug changes.