[Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744

--- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Tomás Cohen Arazi from comment #24)
> Created attachment 140922 [details] [review]
> Bug 29744: (QA follow-up) Only consider PLACK_ENV for underscore
> 
> When run under certain circumstances (in jenkins, for example) some ENV
> variables are set for convenience, like PLACK_WORKERS and
> PLACK_MAX_REQUESTS and is causing some tests to fail (notably, shib
> ones).
> 
> This patch makes the regex only consider PLACK_ENV when testing for the
> underscore case.
> 
> Tests are updated accordingly, and they are also rewritten to test for
> boolean values instead of empty string, or zero or one, etc. The
> implementation shouldn't matter as long as the boolean evaluation is
> correct and it is clearer for devs what to expect.
> 
> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Thx for following up. I will still have a look next week. This might break
something else again? ;)
As done in one of those tests, we may just need to localize $ENV in Shibboleth
tests?

-- 
You are receiving this mail because:
You are watching all bug changes.