[Koha-bugs] [Bug 31579] Improve reserve/request.pl to avoid mistakes with pick up locations

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31579

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #7 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
>     1) Go in System preferences and find the "UseBranchTransfertLimits".
>     2) Change the value of "Don't enforce" to "Enforce".

I don't understand why the behavior you've coded here only applies when
UseBranchTransfertLimits is set to Enforce. These two separate dropdowns exist
regardless of whether or not one is using Branch Transfer Limits. 

More importantly, this patch breaks existing behavior when I have two items on
the same bib with different allowed pickup locations. To recreate:

(apply patch, set UseBranchTransfertLimits to Enforce)
1: Set Hold Pickup Library Match in circ rules to "item's hold group"
2: Create two library groups, both defined as local holds groups. Give each
group a couple of libraries, making sure they don't overlap
3: Find or create a biblio record with two items. The items should be held by
different libraries, one in each of your hold groups
4: try to place a hold on your bib. on reserve/request.pl, observe that you
have 3 pickup location dropdown (one for the biblio, one for each item) and
that all 3 show the same value.
5: confirm that changing the biblio-level dropdown forces the page to reload
and changes both item dropdowns to match what you selected in the biblio
dropdown
6: HOWEVER -- your items each have a distinct set of allowed pickup locations.
One of your two items will be showing a branch at which it is not allowed to be
picked up.
7: attempt to place the item-level hold with an illegal pickup location that
koha has suggested to you. observe that Koha leaves the holds creation page
without actually making a hold or giving an error message.

-- 
You are receiving this mail because:
You are watching all bug changes.