[Koha-bugs] [Bug 30024] link_bibs_to_authorities.pl relies on CatalogModuleRelink

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30024

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
This definitely seems right, but I want to highlight what I see in the routine
LinkBibHeadingsToAuthorities. 

When an existing link is found we check the value of 'allowrelink' as passed in
AND the value of LinkerRelink:
if ( defined $current_link && (!$allowrelink ||
!C4::Context->preference('LinkerRelink')) )

So really, it is currently controlled by both, and only enabling both causes
relink beforehand

                                         Before    | After
LinkerRelink 0 + CatalogModuleRelink 0 = No relink | No relink
LinkerRelink 1 + CatalogModuleRelink 0 = No relink | Relink
LinkerRelink 0 + CatalogModuleRelink 1 = No relink | No relink
LinkerRelink 1 + CatalogModuleRelink 1 = Relink    | Relink


It is worth noting - if we have a current link, but don't find an authority
record (i.e. linked to missing record) we also check 'allowrelink' in addition
to 'LinkerKeepStale'
  Relink + LinkerKeepStale 0 = Remove link (unless authrecord found in DB but
not zebra)
  Relink + LinkerKeepStale 1 = Keep stale
NoRelink + LinkerKeepStale 0 = Keep stale
NoRelink + LinkerKeepStale 1 = Keep stale

-- 
You are receiving this mail because:
You are watching all bug changes.